run-webkit-tests: Report MacCatalyst as a unique platform
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-20  Jonathan Bedard  <jbedard@apple.com>
2
3         run-webkit-tests: Report MacCatalyst as a unique platform
4         https://bugs.webkit.org/show_bug.cgi?id=209361
5
6         Rubber-stamped by Aakash Jain.
7
8         * Scripts/webkitpy/port/mac.py:
9         (MacCatalystPort):
10         (MacCatalystPort.configuration_for_upload): Treat MacCatalyst as a separate platform from Mac.
11
12 2020-03-20  Alex Christensen  <achristensen@webkit.org>
13
14         CORS-disabling SPI introduced in r253978 should make responses non-opaque
15         https://bugs.webkit.org/show_bug.cgi?id=209351
16         <rdar://problem/60024850>
17
18         Reviewed by Chris Dumez.
19
20         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
21
22 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
23
24         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
25         https://bugs.webkit.org/show_bug.cgi?id=208938
26
27         Reviewed by Jonathan Bedard.
28
29         * BuildSlaveSupport/ews-build/steps.py:
30         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
31         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
32         (CheckPatchStatusOnEWSQueues.get_patch_status):
33         (CheckPatchStatusOnEWSQueues.start):
34         * BuildSlaveSupport/ews-build/steps_unittest.py:
35         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
36         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
37         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
38         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
39
40 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
41
42         [ews] Better organize patch status api data
43         https://bugs.webkit.org/show_bug.cgi?id=209342
44
45         Reviewed by Jonathan Bedard.
46
47         * BuildSlaveSupport/ews-app/ews/views/status.py:
48         (Status._build_status):
49         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
50         (Status.get): Remove safe=false now that we are returning a dictionary.
51
52 2020-03-20  Tim Horton  <timothy_horton@apple.com>
53
54         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
55         https://bugs.webkit.org/show_bug.cgi?id=209307
56
57         Reviewed by Andy Estes.
58
59         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
60
61 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
62
63         Unreviewed, reverting r258748.
64
65         This commit broke the Catalina build
66
67         Reverted changeset:
68
69         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
70         https://bugs.webkit.org/show_bug.cgi?id=209307
71         https://trac.webkit.org/changeset/258748
72
73 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
74
75         [ews] commit-queue should comment on bug if patch fails to apply
76         https://bugs.webkit.org/show_bug.cgi?id=209334
77
78         Reviewed by Jonathan Bedard.
79
80         * BuildSlaveSupport/ews-build/steps.py:
81         (ApplyPatch):
82         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
83         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
84         (TestApplyPatch):
85         (TestApplyPatch.setUp):
86         (TestApplyPatch.setUp.mock_start):
87         (TestApplyPatch.tearDown):
88         (TestApplyPatch.test_success):
89         (TestApplyPatch.test_failure):
90         (TestApplyPatch.test_failure_on_commit_queue):
91
92 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
93
94         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
95         https://bugs.webkit.org/show_bug.cgi?id=209122
96
97         Reviewed by Jonathan Bedard.
98
99         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
100         (StatusBubble._build_bubble):
101
102 2020-03-19  Tim Horton  <timothy_horton@apple.com>
103
104         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
105         https://bugs.webkit.org/show_bug.cgi?id=209307
106
107         Reviewed by Andy Estes.
108
109         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
110
111 2020-03-19  Alex Christensen  <achristensen@webkit.org>
112
113         Remove test failing after r258734
114         https://bugs.webkit.org/show_bug.cgi?id=209303
115
116         We removed the functionality it was testing because it did nothing useful except call the callback.
117         I'm about to remove the only user of WKContextGetStatistics.
118
119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
120         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
121
122 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
123
124         commit-queue status-bubble shows incorrect position in queue
125         https://bugs.webkit.org/show_bug.cgi?id=209313
126
127         Reviewed by Jonathan Bedard.
128
129         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
130         (StatusBubble._queue_position):
131
132 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
133
134         [Curl] Add an API returns description of verification errors.
135         https://bugs.webkit.org/show_bug.cgi?id=208913
136
137         Reviewed by Fujii Hironori.
138
139         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
140         Browser can display more precise error information with this API.
141
142         API Test: Curl.CertificateAPI
143
144         * MiniBrowser/win/Common.cpp:
145         (askServerTrustEvaluation):
146         * MiniBrowser/win/Common.h:
147         * MiniBrowser/win/WebKitBrowserWindow.cpp:
148         (createPEMString):
149         (WebKitBrowserWindow::canTrustServerCertificate):
150         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
151         (TestWebKitAPI::Curl::TEST):
152
153 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
154
155         Update build.webkit.org link for EWS
156         https://bugs.webkit.org/show_bug.cgi?id=209280
157
158         Reviewed by Alexey Proskuryakov.
159
160         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
161
162 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
163
164         [WinCairo] extract-built-product fails after r258612
165         https://bugs.webkit.org/show_bug.cgi?id=209285
166
167         extractBuiltProduct also references the old name for the
168         requirements on wincairo.
169
170         Reviewed by Ross Kirsling.
171
172         * BuildSlaveSupport/built-product-archive:
173
174 2020-03-19  Philippe Normand  <pnormand@igalia.com>
175
176         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
177         https://bugs.webkit.org/show_bug.cgi?id=209223
178
179         Reviewed by Carlos Alberto Lopez Perez.
180
181         flatpak build doesn't expose a --socket option for white-listing
182         the systemd journal socket. So white-list everything in /run. 🤷
183
184         * flatpak/flatpakutils.py:
185         (WebkitFlatpak.run_in_sandbox):
186
187 2020-03-19  Charlie Turner  <cturner@igalia.com>
188
189         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
190         https://bugs.webkit.org/show_bug.cgi?id=209146
191
192         Reviewed by Darin Adler.
193
194         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
195         (TestWebKitAPI::TEST):
196         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
197         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
198         (testDownloadMIMEType):
199         (testContextMenuDownloadActions):
200         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
201
202 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
203
204         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
205         https://bugs.webkit.org/show_bug.cgi?id=209278
206
207         Reviewed by Philippe Normand.
208
209         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
210         means flatpak.
211
212         * Scripts/webkitdirs.pm:
213         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
214
215 2020-03-19  Philippe Normand  <pnormand@igalia.com>
216
217         [CMake] cache not cleared when build-webkit options change
218         https://bugs.webkit.org/show_bug.cgi?id=209277
219
220         Reviewed by Adrian Perez de Castro.
221
222         * Scripts/webkitdirs.pm:
223         (shouldRemoveCMakeCache): The expected function signature never
224         included the cache file path. Remove it.
225
226 2020-03-18  Philippe Normand  <pnormand@igalia.com>
227
228         REGRESSION(r258626): webkit-dirs warning
229         https://bugs.webkit.org/show_bug.cgi?id=209221
230
231         Reviewed by Adrian Perez de Castro.
232
233         * Scripts/webkitdirs.pm:
234         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
235
236 2020-03-19  Chris Lord  <clord@igalia.com>
237
238         Add Chris Lord (clord@igalia.com) to the list of contributors
239         https://bugs.webkit.org/show_bug.cgi?id=209274
240
241         Unreviewed
242
243         * Scripts/webkitpy/common/config/contributors.json:
244
245 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
246
247         Remove commit queue bubble from bot watchers dashboard
248         https://bugs.webkit.org/show_bug.cgi?id=209271
249
250         Reviewed by Alexey Proskuryakov.
251
252         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
253
254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
255         (BubbleQueueServer): 
256
257 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
258
259         eventSender.monitorWheelEvents() is very fragile
260         https://bugs.webkit.org/show_bug.cgi?id=197819
261         <rdar://problem/51319456>
262
263         Reviewed by Tim Horton.
264
265         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
266         adding back changes from r257844 that were reverted in r258558.
267         
268         First, have EventSendingController keep track of whether it's seen then "end" event
269         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
270         now waits until it sees these, which prevents premature triggering which was a common cause of
271         failure before.
272         
273         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
274         for completion in a callout from the end of Page::updateRendering(), which makes it test
275         and fire at a more consistent time.
276         
277         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
278         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
279         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
280         also resulting in a premature trigger.
281
282         * DumpRenderTree/mac/EventSendingController.h:
283         * DumpRenderTree/mac/EventSendingController.mm:
284         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
285         (-[EventSendingController monitorWheelEvents]):
286         (-[EventSendingController callAfterScrollingCompletes:]):
287         * DumpRenderTree/win/EventSender.cpp:
288         (mouseScrollBy):
289         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
290         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
291         (WTR::EventSendingController::monitorWheelEvents):
292         (WTR::EventSendingController::callAfterScrollingCompletes):
293         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
294
295 2020-03-18  John Wilander  <wilander@apple.com>
296
297         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
298         https://bugs.webkit.org/show_bug.cgi?id=209245
299         <rdar://problem/60511121>
300
301         Reviewed by Chris Dumez.
302
303         These changes to the TestRunner makes sure that
304         - statisticsClearInMemoryAndPersistentStore()
305         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
306         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
307         and adds the infrastructure for that.
308
309         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
310         (WTR::InjectedBundle::didReceiveMessageToPage):
311         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
312         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
313         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
314         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
315         * WebKitTestRunner/InjectedBundle/TestRunner.h:
316         * WebKitTestRunner/TestController.cpp:
317         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
318         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
319         * WebKitTestRunner/TestInvocation.cpp:
320         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
321         * WebKitTestRunner/TestInvocation.h:
322
323 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
324
325         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
326         https://bugs.webkit.org/show_bug.cgi?id=209218
327         <rdar://problem/60560831>
328
329         Reviewed by Tim Horton.
330
331         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
332         those views must be parented (i.e. they must be connected to a UIWindow).
333
334         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
335         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
336         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
337         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
338
339 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
340
341         [ews] commit-queue should comment on bug in case of test failures
342         https://bugs.webkit.org/show_bug.cgi?id=209226
343
344         Reviewed by Jonathan Bedard.
345
346         * BuildSlaveSupport/ews-build/steps.py:
347         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
348         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
349         (SetBuildSummary): Ditto.
350         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
351
352 2020-03-18  Philippe Normand  <pnormand@igalia.com>
353
354         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
355         https://bugs.webkit.org/show_bug.cgi?id=209238
356
357         Reviewed by Jonathan Bedard.
358
359         * Scripts/test262-runner: Perform the flatpak check on Linux only.
360
361 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
362
363         [WinCairo] archive-built-product fails after r258612
364         https://bugs.webkit.org/show_bug.cgi?id=209237
365
366         Reviewed by Alex Christensen.
367
368         * BuildSlaveSupport/built-product-archive:
369         Update name of version file for requirements version
370         file for wincairo.
371
372 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
373
374         commit-queue should allow patches which are reviewed by patch author
375         https://bugs.webkit.org/show_bug.cgi?id=209231
376
377         Reviewed by Jonathan Bedard.
378
379         * BuildSlaveSupport/ews-build/steps.py:
380         (BugzillaMixin._does_patch_have_acceptable_review_flag):
381
382 2020-03-18  Philippe Normand  <pnormand@igalia.com>
383
384         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
385         https://bugs.webkit.org/show_bug.cgi?id=209222
386
387         Reviewed by Carlos Alberto Lopez Perez.
388
389         * Scripts/webkitdirs.pm:
390         (runInFlatpakIfAvailable): If a command wrapper is required it
391         means Flatpak shouldn't be used.
392
393 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
394
395         [ews] commit-queue should comment on bug in case patch fails to build
396         https://bugs.webkit.org/show_bug.cgi?id=209227
397
398         Reviewed by Jonathan Bedard.
399
400         * BuildSlaveSupport/ews-build/steps.py:
401         (AnalyzeCompileWebKitResults.start):
402         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
403
404 2020-03-18  Philippe Normand  <pnormand@igalia.com>
405
406         [GTK][WPE] Migrate to Flatpak-based dev SDK
407         https://bugs.webkit.org/show_bug.cgi?id=205658
408
409         Reviewed by Carlos Alberto Lopez Perez.
410
411         JHBuild will now be used only if the WEBKIT_JHBUILD environment
412         variable is set to 1, which is the case for the time being on the
413         GTK and WPE EWS/build bots.
414
415         By default the build dependencies are now locally installed from a
416         Flatpak repository hosted at https://software.igalia.com. The
417         repository can be regenerated with the scripts from the
418         webkit-flatpak-sdk Github project
419         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
420         transparently with the update-webkit{gtk,wpe}-libs scripts. As
421         there is no need to rebuild the dependencies from scratch, the
422         developer user-experience should now be much more friendly and
423         overall build times reduced.
424
425         As an additional commodity, the new environment supports the
426         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
427         environment variable to your gst-build path. This feature was
428         contributed by Thibault Saunier.
429
430         The JHBuild infrastructure will be removed once all the bots have
431         been switched over to Flatpak.
432
433         * BuildSlaveSupport/ews-build/steps.py:
434         (InstallGtkDependencies):
435         (InstallWpeDependencies):
436         (CompileWebKit.start):
437         * BuildSlaveSupport/gtk/buildbot/run:
438         * Scripts/build-webkit:
439         * Scripts/run-bindings-tests:
440         * Scripts/run-builtins-generator-tests:
441         * Scripts/run-gtk-tests:
442         * Scripts/run-javascriptcore-tests:
443         * Scripts/run-minibrowser:
444         * Scripts/run-qt-wpe-minibrowser:
445         * Scripts/run-webdriver-tests:
446         * Scripts/run-wpe-tests:
447         * Scripts/test-webkitperl:
448         * Scripts/test-webkitpy:
449         * Scripts/test262-runner:
450         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
451         * Scripts/update-webkitgtk-libs:
452         * Scripts/update-webkitwpe-flatpak: Removed.
453         * Scripts/update-webkitwpe-libs:
454         * Scripts/webkitdirs.pm:
455         (getUserFlatpakPath):
456         (inFlatpakSandbox):
457         (runInFlatpakIfAvailable):
458         (wrapperPrefixIfNeeded):
459         (shouldUseJhbuild):
460         (shouldUseFlatpak):
461         (shouldRemoveCMakeCache):
462         * Scripts/webkitpy/common/system/executive.py:
463         (Executive.kill_all):
464         * Scripts/webkitpy/port/base.py:
465         (Port._path_to_apache):
466         (Port._should_run_as_pixel_test):
467         (Port._in_flatpak_sandbox):
468         * Scripts/webkitpy/port/gtk.py:
469         (GtkPort.setup_environ_for_server):
470         (GtkPort._get_crash_log):
471         * Scripts/webkitpy/port/linux_get_crash_log.py:
472         (GDBCrashLogGenerator):
473         (GDBCrashLogGenerator.__init__):
474         (GDBCrashLogGenerator.generate_crash_log):
475         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
476         (GDBCrashLogGeneratorTest.test_generate_crash_log):
477         * Scripts/webkitpy/port/wpe.py:
478         (WPEPort.setup_environ_for_server):
479         (WPEPort._get_crash_log):
480         * Scripts/webkitpy/port/xvfbdriver.py:
481         (XvfbDriver._setup_environ_for_test):
482         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
483         (WTR::getFontsPath):
484         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
485         (WTR::getFontsPath):
486         * flatpak/files/default.xkm: Removed.
487         * flatpak/files/httpd-autogen.sh: Removed.
488         * flatpak/flatpakutils.py:
489         (check_flatpak):
490         (FlatpakRepos.update):
491         (FlatpakPackage.__repr__):
492         (FlatpakPackage.__str__):
493         (WebkitFlatpak.load_from_args):
494         (WebkitFlatpak.__init__):
495         (WebkitFlatpak.clean_args):
496         (WebkitFlatpak.setup_builddir):
497         (WebkitFlatpak):
498         (WebkitFlatpak.setup_gstbuild):
499         (WebkitFlatpak.run_in_sandbox):
500         (WebkitFlatpak.run):
501         (WebkitFlatpak.has_environment):
502         (WebkitFlatpak.save_config):
503         (WebkitFlatpak.setup_dev_env):
504         (WebkitFlatpak.install_all):
505         (WebkitFlatpak.run_gdb):
506         * flatpak/org.webkit.CommonModules.yaml: Removed.
507         * flatpak/org.webkit.GTK.yaml: Removed.
508         * flatpak/org.webkit.WPE.yaml: Removed.
509         * flatpak/org.webkit.WPEModules.yaml: Removed.
510         * flatpak/org.webkit.WPEQT.yaml: Removed.
511         * flatpak/org.webkit.WebKit.yaml: Removed.
512         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
513         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
514         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
515
516 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
517
518         Expand In-App-Browser-Privacy testing
519         https://bugs.webkit.org/show_bug.cgi?id=209142
520         <rdar://problem/60496618>
521
522         Reviewed by Darin Adler.
523
524         Expanded test coverage by adding new tests and creating a custom url
525         scheme handler to get around the fact that local file loads are
526         always classified as app-bound.
527
528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
529         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
530         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
531         If the path indicates testing user scripts on load, notify the script message
532         handler that the navigation has finished. If the path indicates
533         testing user-agent scripts, set the window.wkUserScriptInjected
534         variable to true. A user agent script will attempt to read this
535         variable and should fail.
536
537         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
538         (initializeInAppBrowserPrivacyTestSettings):
539         Basic test setup. Initialize the main run loop and make sure we are
540         starting with a clean state.
541
542         (TEST):
543         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
544         except for blob files which must be generated within the web content.
545
546         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
547         Basic html document to test local file loads are classified as
548         app-bound.
549
550         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
551         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
552         These files are no longer needed as their content is directly copied
553         into the URL scheme handler.
554
555 2020-03-17  Chris Dumez  <cdumez@apple.com>
556
557         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
558         https://bugs.webkit.org/show_bug.cgi?id=207307
559         <rdar://problem/59206964>
560
561         Reviewed by Alex Christensen.
562
563         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
564         notifications from the map but not tell WebCore that the notification were discarded. As a result,
565         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
566         notification would no longer be in the map, causing us to hit an assertion in debug.
567
568         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
569         to let WebCore know the notification was discarded. This is similar to what is already done for
570         WebKit2 in WebNotificationManager::clearNotifications().
571
572         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
573         (-[MockWebNotificationProvider reset]):
574
575 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
576
577         [WinCairo][FTW] Update path to requirements download
578         https://bugs.webkit.org/show_bug.cgi?id=209202
579
580         Reviewed by Ross Kirsling.
581
582         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
583         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
584         WebKitRequirementsWin64.zip.
585
586         * Scripts/update-webkit-wincairo-libs.py:
587
588 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
589
590         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
591         https://bugs.webkit.org/show_bug.cgi?id=208920
592
593         Reviewed by Jonathan Bedard.
594
595         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
596         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
597         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
598         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
599         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
600         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
601         * BuildSlaveSupport/ews-app/ews/fetcher.py:
602         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
603         for commit-queue which isn't expected to change.
604         (BugzillaPatchFetcher.fetch_commit_queue_patches):
605         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
606         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
607         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
608         setting cq+ flag on bugzilla.
609
610 2020-03-17  Chris Dumez  <cdumez@apple.com>
611
612         [WKTR] testRunner API that takes in a completion handler should use async IPC
613         https://bugs.webkit.org/show_bug.cgi?id=209187
614
615         Reviewed by John Wilander.
616
617         testRunner API that takes in a completion handler should use async IPC. This hangs
618         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
619         to IPC the WebProcess as a result of this testRunner call.
620
621         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
622         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
623         (WTR::TestRunner::statisticsUpdateCookieBlocking):
624         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
625         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
626         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
627         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
628         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
629         (WTR::TestRunner::statisticsResetToConsistentState):
630         (WTR::TestRunner::getAllStorageAccessEntries):
631         (WTR::TestRunner::removeAllSessionCredentials):
632         (WTR::TestRunner::getApplicationManifestThen):
633         * WebKitTestRunner/TestInvocation.cpp:
634         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
635         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
636
637 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
638
639         [ews-app] Timestamp shown in status-bubble hover-over message is in future
640         https://bugs.webkit.org/show_bug.cgi?id=196628
641
642         Reviewed by Jonathan Bedard.
643
644         * BuildSlaveSupport/ews-build/events.py:
645         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
646         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
647         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
648         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
649
650 2020-03-17  Alex Christensen  <achristensen@webkit.org>
651
652         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
653         https://bugs.webkit.org/show_bug.cgi?id=209192
654         <rdar://problem/51313336>
655
656         Reviewed by Geoff Garen.
657
658         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
659         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
660         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
661         (TEST):
662
663 2020-03-17  Chris Dumez  <cdumez@apple.com>
664
665         Use less sync IPC for ITP testRunner methods
666         https://bugs.webkit.org/show_bug.cgi?id=209184
667
668         Reviewed by Alex Christensen.
669
670         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
671         (WTR::TestRunner::setStatisticsDebugMode):
672         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
673         (WTR::TestRunner::setStatisticsLastSeen):
674         (WTR::TestRunner::setStatisticsMergeStatistic):
675         (WTR::TestRunner::setStatisticsPrevalentResource):
676         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
677         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
678         * WebKitTestRunner/TestInvocation.cpp:
679         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
680         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
681
682 2020-03-17  Chris Dumez  <cdumez@apple.com>
683
684         [WKTR] Crash when trying to open a new window in an ephemeral session test
685         https://bugs.webkit.org/show_bug.cgi?id=209181
686
687         Reviewed by Geoffrey Garen.
688
689         Make sure that the new WKWebView is using the same data store as its related WKWebView.
690
691         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
692         (WTR::TestController::platformCreateOtherPage):
693
694 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
695
696         Unreviewed, reverting r257844.
697
698         this revision caused a test to start timing out
699
700         Reverted changeset:
701
702         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
703         zero.html is a flaky failure"
704         https://bugs.webkit.org/show_bug.cgi?id=207948
705         https://trac.webkit.org/changeset/257844
706
707 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
708
709         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
710         https://bugs.webkit.org/show_bug.cgi?id=209151
711
712         Reviewed by Yusuke Suzuki.
713
714         * Scripts/webkitpy/common/config/contributors.json:
715
716 2020-03-16  Chris Dumez  <cdumez@apple.com>
717
718         Crash under WebCookieCache::clearForHost()
719         https://bugs.webkit.org/show_bug.cgi?id=209149
720         <rdar://problem/60453086>
721
722         Reviewed by Alex Christensen.
723
724         Add API test coverage.
725
726         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
727         (TEST):
728
729 2020-03-16  Keith Rollin  <krollin@apple.com>
730
731         Remove support for WebKitSystemInterface
732         https://bugs.webkit.org/show_bug.cgi?id=208894
733         <rdar://problem/60297590>
734
735         Reviewed by Brent Fulgham.
736
737         This project provided support for facilities that are now handled
738         elsewhere and is no longer needed.
739
740         * Scripts/copy-webkitlibraries-to-product-directory:
741
742 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
743
744         [macOS] Accessibility sandbox regressions
745         https://bugs.webkit.org/show_bug.cgi?id=209065
746
747         Reviewed by Brent Fulgham.
748
749         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
750         (TEST):
751         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
752         (TEST):
753
754 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
755
756         Unreviewed infrastructure fix.
757
758         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
759         while the hardware is out for repair.
760
761 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
762
763         [WebXR] IDLs, stubs and build configuration for WPE
764         https://bugs.webkit.org/show_bug.cgi?id=208702
765
766         Reviewed by Dean Jackson.
767
768         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
769         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
770
771 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
772
773         [Cocoa] Limit set of classes that can be decoded when a preference has changed
774         https://bugs.webkit.org/show_bug.cgi?id=208012
775
776         Reviewed by Brent Fulgham.
777
778         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
779         (TEST):
780
781 2020-03-16  youenn fablet  <youenn@apple.com>
782
783         Unique origins should not be Potentially Trustworthy
784         https://bugs.webkit.org/show_bug.cgi?id=209049
785
786         Reviewed by Darin Adler.
787
788         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
789         (TestWebKitAPI::TEST_F):
790
791 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
792
793         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
794         https://bugs.webkit.org/show_bug.cgi?id=207324
795
796         Reviewed by Darin Adler.
797
798         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
799         (TestWebKitAPI::generateRandomData): Added.
800         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
801
802 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
803
804         Should not use variable-length-array (VLA)
805         https://bugs.webkit.org/show_bug.cgi?id=209043
806
807         Reviewed by Mark Lam.
808
809         * ContentExtensionTester/Configurations/Base.xcconfig:
810         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
811
812 2020-03-13  Alex Christensen  <achristensen@webkit.org>
813
814         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
815         https://bugs.webkit.org/show_bug.cgi?id=209011
816         <rdar://problem/59370588>
817
818         Reviewed by Youenn Fablet.
819
820         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
821         (TestWebKitAPI::TEST):
822
823 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
824
825         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
826         https://bugs.webkit.org/show_bug.cgi?id=209089
827
828         Reviewed by Tim Horton.
829
830         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
831         marketing name for the feature.
832
833         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
834         (runUntilReceivesAutoplayEvent):
835
836         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
837         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
838         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
839         be any compelling reason to compare against different types here (especially since we only set
840         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
841         these all to be `_WKAutoplayEvent`.
842
843         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
844         (-[AutoFillTestView _autofillInputView]):
845         (-[AutoFillTestView textInputHasAutoFillContext]):
846         (TestWebKitAPI::TEST):
847         (-[AutofillTestView initWithFrame:]): Deleted.
848         (-[AutofillTestView _autofillInputView]): Deleted.
849         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
850         * TestWebKitAPI/ios/UIKitSPI.h:
851
852 2020-03-13  Chris Dumez  <cdumez@apple.com>
853
854         Unreviewed, reverting r256232.
855
856         Caused ResizeObserver tests to become flaky
857
858         Reverted changeset:
859
860         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
861         override TestOptions"
862         https://bugs.webkit.org/show_bug.cgi?id=207481
863         https://trac.webkit.org/changeset/256232
864
865 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
866
867         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
868         https://bugs.webkit.org/show_bug.cgi?id=209016
869         <rdar://problem/60329530> 
870
871         Reviewed by Chris Dumez.
872
873         Re-initialize the app-bound domains when the correct
874         TestOptions parameter is set.
875
876         * WebKitTestRunner/TestController.cpp:
877         (WTR::TestController::createWebViewWithOptions):
878         (WTR::TestController::reinitializeAppBoundDomains):
879         * WebKitTestRunner/TestController.h:
880
881 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
882
883         Report all third party loads on a per-page basis
884         https://bugs.webkit.org/show_bug.cgi?id=209032
885         <rdar://problem/60397323>
886
887         Reviewed by Chris Dumez.
888
889         Mostly naming updates to reflect the change in use for this SPI call.
890         It now returns all loaded third party domains, not just prevalent ones.
891
892         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
893         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
894         (WTR::InjectedBundle::didReceiveMessageToPage):
895         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
896         (WTR::TestRunner::getLoadedThirdPartyDomains):
897         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
898         (WTR::TestRunner::getPrevalentDomains): Deleted.
899         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
900         * WebKitTestRunner/InjectedBundle/TestRunner.h:
901         * WebKitTestRunner/TestController.cpp:
902         (WTR::TestController::resetStateToConsistentValues):
903         (WTR::TestController::getLoadedThirdPartyDomains):
904         (WTR::TestController::clearLoadedThirdPartyDomains):
905         (WTR::TestController::getPrevalentDomains): Deleted.
906         (WTR::TestController::clearPrevalentDomains): Deleted.
907         * WebKitTestRunner/TestController.h:
908         * WebKitTestRunner/TestInvocation.cpp:
909         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
910         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
911         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
912         * WebKitTestRunner/TestInvocation.h:
913         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
914         (WTR::TestController::getLoadedThirdPartyDomains):
915         (WTR::TestController::clearLoadedThirdPartyDomains):
916         (WTR::TestController::getPrevalentDomains): Deleted.
917         (WTR::TestController::clearPrevalentDomains): Deleted.
918
919 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
920
921         [ews] run FindModifiedChangeLogs early in the build
922         https://bugs.webkit.org/show_bug.cgi?id=209060
923
924         Reviewed by Jonathan Bedard.
925
926         * BuildSlaveSupport/ews-build/factories.py:
927         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
928
929 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
930
931         [GTK] Add EWS testers to run GTK layout tests
932         https://bugs.webkit.org/show_bug.cgi?id=207648
933
934         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
935
936         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
937         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
938         tests (layout tests).
939
940         * BuildSlaveSupport/ews-build/config.json: Added new queue for
941         WK2 tests.
942         * BuildSlaveSupport/ews-build/factories.py:
943         (GTKTestsFactory):
944         * BuildSlaveSupport/ews-build/factories_unittest.py:
945         (TestCommitQueueFactory.test_commit_queue_factory):
946         (TestGTKFactory): Added unit-test.
947         (TestGTKFactory.test_gtk_factory):
948         * BuildSlaveSupport/ews-build/loadConfig.py:
949         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
950         (TagsForBuilderTest.test_getTagsForBuilder):
951
952 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
953
954         Add API endpoint in EWS django app to provide patch status in json format
955         https://bugs.webkit.org/show_bug.cgi?id=208940
956
957         Reviewed by Jonathan Bedard.
958
959         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
960         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
961
962 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
963
964         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
965         https://bugs.webkit.org/show_bug.cgi?id=209055
966         <rdar://problem/60272692>
967
968         Reviewed by Simon Fraser.
969
970         Now that WebKitTestRunner has a bundleID, its' user default values
971         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
972         to NO before running tests. It will be set to YES in PlatformWebView
973         if specified by the test.
974
975         * WebKitTestRunner/mac/main.mm:
976         (setDefaultsToConsistentValuesForTesting):
977
978 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
979
980         [CMake] Eleminate mismatches between Find* module names and variables they set
981         https://bugs.webkit.org/show_bug.cgi?id=208948
982
983         Reviewed by Michael Catanzaro.
984
985         * wpe/backends/CMakeLists.txt:
986
987 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
988
989         [ews-app] reduce logging
990         https://bugs.webkit.org/show_bug.cgi?id=209062
991
992         Reviewed by Jonathan Bedard.
993
994         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
995         (BugzillaBeautifulSoup.authenticate):
996         (BugzillaBeautifulSoup._load_query):
997
998 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
999
1000         Crash in TextIterator::node via TextManipulationController::replace
1001         https://bugs.webkit.org/show_bug.cgi?id=209048
1002
1003         Reviewed by Wenson Hsieh.
1004
1005         Added a regression test.
1006
1007         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1008         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
1009
1010 2020-03-13  Saam Barati  <sbarati@apple.com>
1011
1012         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
1013         https://bugs.webkit.org/show_bug.cgi?id=209038
1014
1015         Reviewed by Keith Miller.
1016
1017         This allows us to automatically pull in some tests that are in non open sourced Apple
1018         checkouts.
1019
1020         * Scripts/run-javascriptcore-tests:
1021         (runJSCStressTests):
1022
1023 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
1024
1025         Crash in TextManipulationController::replace
1026         https://bugs.webkit.org/show_bug.cgi?id=209021
1027
1028         Reviewed by Wenson Hsieh.
1029
1030         Added a regression test.
1031
1032         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1033         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
1034
1035 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
1036
1037         [macOS] _AXSApplicationAccessibilityEnabled should not be called
1038         https://bugs.webkit.org/show_bug.cgi?id=208953
1039
1040         Reviewed by Brent Fulgham.
1041
1042         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1043
1044 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
1045
1046         Resource load statistics data summary should return all third party data
1047         https://bugs.webkit.org/show_bug.cgi?id=209000
1048         <rdar://problem/60348306>
1049
1050         Reviewed by John Wilander.
1051
1052         Marked only 2 of 3 domains prevalent in data summary tests to ensure
1053         the call returns all third parties, not just prevalent ones.
1054         Added a more aggressive check for the size of the array at the
1055         beginning of the test to ensure the array is still returning 3 values. 
1056         Also removed the ASSERT statements as they seem to cause timeouts (not
1057         clear crashes) when they are not true, which is hard to debug.
1058         If these values are nil, the test will fail in the EXPECT_WK_STREQ
1059         checks, we don't need ASSERT statements.
1060
1061         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1062         (TEST):
1063
1064 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
1065
1066         resultsdpy: Add script to run local instance
1067         https://bugs.webkit.org/show_bug.cgi?id=208746
1068
1069         Rubber-stamped by Aakash Jain.
1070
1071         * resultsdbpy/resultsdbpy/example: Added.
1072         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
1073         * resultsdbpy/resultsdbpy/example/environment.py: Added.
1074         (Environment): Organize environment variables used by results database.
1075         (ModelFromEnvironment): Construct the database model from the environment.
1076         (main): Create and drop tables, if required.
1077         * resultsdbpy/resultsdbpy/example/main.py: Added.
1078         (health): Web-server health check.
1079         (handle_errors):
1080         (main): Run results database web-server.
1081         * resultsdbpy/resultsdbpy/example/worker.py: Added.
1082         (main): Asynchronously process uploaded results.
1083         * resultsdbpy/resultsdbpy/run: Added.
1084
1085 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1086
1087         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
1088         https://bugs.webkit.org/show_bug.cgi?id=209004
1089
1090         Reviewed by Tim Horton.
1091
1092         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
1093         `use_gpu_process` is specified.
1094
1095         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1096         (parse_args):
1097
1098 2020-03-12  Matt Lewis  <jlewis3@apple.com>
1099
1100         Make flatpack import for run-webkit-tests only happen on linux systems
1101         https://bugs.webkit.org/show_bug.cgi?id=208954
1102
1103         Reviewed by Philippe Normand.
1104
1105         * Scripts/run-webkit-tests: Added an if statement to find the system platform
1106         to determine if we need the flatpackutils import. 
1107
1108 2020-03-12  Alex Christensen  <achristensen@webkit.org>
1109
1110         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
1111         https://bugs.webkit.org/show_bug.cgi?id=207609
1112
1113         Reviewed by Ryosuke Niwa.
1114
1115         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1116         (TestWebKitAPI::TEST):
1117
1118 2020-03-12  Daniel Bates  <dabates@apple.com>
1119
1120         FocusController::setFocusedElement() should tell client of refocused element
1121         https://bugs.webkit.org/show_bug.cgi?id=208880
1122
1123         Reviewed by Wenson Hsieh.
1124
1125         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
1126         to start an input session. Currently, it does not even try.
1127
1128         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1129         (TEST):
1130
1131 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
1132
1133         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
1134         https://bugs.webkit.org/show_bug.cgi?id=208970
1135
1136         Reviewed by Daniel Bates.
1137
1138         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
1139         #!/usr/bin/env python.
1140
1141         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
1142         probably has similar rules.
1143
1144         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
1145         Everything else that does so is probably only used by webkit-build.
1146
1147         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
1148
1149         * gtkdoc/generate-gtkdoc:
1150
1151 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
1152
1153         [WebAuthn] Formalize the Keychain schema
1154         https://bugs.webkit.org/show_bug.cgi?id=183533
1155         <rdar://problem/43347926>
1156
1157         Reviewed by Brent Fulgham.
1158
1159         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
1160         the original combination of RP ID and user handle.
1161
1162         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1163         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1164         (WTR::TestRunner::cleanUpKeychain):
1165         (WTR::TestRunner::keyExistsInKeychain):
1166         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1167         * WebKitTestRunner/TestController.h:
1168         * WebKitTestRunner/TestInvocation.cpp:
1169         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1170         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1171         (WTR::TestController::cleanUpKeychain):
1172         (WTR::TestController::keyExistsInKeychain):
1173
1174 2020-03-11  Keith Miller  <keith_miller@apple.com>
1175
1176         Test262-runner should always consider crashes as new failures
1177         https://bugs.webkit.org/show_bug.cgi?id=208943
1178
1179         Reviewed by Yusuke Suzuki.
1180
1181         Right now the runner will consider crashes with no output as passes, which is obviously bad.
1182         Since we should never crash on a conformance test we should consider a crash as a new failure
1183         100% of the time.
1184
1185         * Scripts/test262/Runner.pm:
1186         (processFile):
1187         (runTest):
1188         (processResult):
1189
1190 2020-03-11  Chris Dumez  <cdumez@apple.com>
1191
1192         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
1193         https://bugs.webkit.org/show_bug.cgi?id=208927
1194         <rdar://problem/55448331>
1195
1196         Reviewed by Alex Christensen.
1197
1198         Add API test coverage.
1199
1200         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1201
1202 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
1203
1204         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
1205         https://bugs.webkit.org/show_bug.cgi?id=208860
1206
1207         Reviewed by Carlos Alberto Lopez Perez.
1208
1209         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1210         (StatusBubble): Added 'api-gtk'.
1211         * BuildSlaveSupport/ews-build/config.json:
1212         * BuildSlaveSupport/ews-build/factories.py:
1213         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
1214         GTK.
1215         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
1216         GTK.
1217         (GTKBuildFactory):
1218         (GTKBuildFactory.__init__): Deleted.
1219         (GTKBuildAndTestFactory): Deleted.
1220         (GTKBuildAndTestFactory.__init__): Deleted.
1221         (GTKAPIBuildAndTestFactory): Deleted.
1222         * BuildSlaveSupport/ews-build/loadConfig.py:
1223
1224 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
1225
1226         [ews] Add unit test to prevent multiple schedulers for a builder.
1227         https://bugs.webkit.org/show_bug.cgi?id=208917
1228
1229         Reviewed by Carlos Alberto Lopez Perez.
1230
1231         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1232         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
1233         (TagsForBuilderTest): Fixed a typo.
1234
1235 2020-03-11 Philippe Normand  <pnormand@igalia.com>
1236
1237         [GTK] Failing API tests under the Flatpak SDK environment
1238         https://bugs.webkit.org/show_bug.cgi?id=208871
1239
1240         Reviewed by Michael Catanzaro.
1241
1242         The load-failed signal callback should return a boolean result,
1243         otherwise we enter in unknown territory depending on how the
1244         toolchain compiles this, possibly triggering bad behavior (with
1245         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
1246         GCC toolchain on buildbots).
1247
1248         Patch suggested by Michael Catanzaro.
1249
1250         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1251         (loadFailedCallback):
1252
1253 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
1254
1255         Sync FeatureList.pm with CMake definitions
1256         https://bugs.webkit.org/show_bug.cgi?id=208866
1257
1258         Reviewed by Michael Catanzaro.
1259
1260         * Scripts/webkitperl/FeatureList.pm:
1261
1262 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1263
1264         [ews] Add unit tests for commit queue factory
1265         https://bugs.webkit.org/show_bug.cgi?id=208862
1266
1267         Reviewed by Jonathan Bedard.
1268
1269         * BuildSlaveSupport/ews-build/factories_unittest.py:
1270         (TestCommitQueueFactory):
1271         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
1272
1273 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1274
1275         [ews-app] Status bubble should only display important messages in pop-over - part 3
1276         https://bugs.webkit.org/show_bug.cgi?id=208865
1277
1278         Reviewed by Jonathan Bedard.
1279
1280         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1281         (StatusBubble): Added more strings to STEPS_TO_HIDE.
1282
1283 2020-03-10  Lauro Moura  <lmoura@igalia.com>
1284
1285         [WPE] MiniBrowser: Close child WebViews when exiting
1286         https://bugs.webkit.org/show_bug.cgi?id=208689
1287
1288         Reviewed by Carlos Garcia Campos.
1289
1290         Store created views so we can release them before exiting.
1291
1292         * MiniBrowser/wpe/main.cpp:
1293         (webViewClose):
1294         (createWebView):
1295         (main):
1296
1297 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1298
1299         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
1300         https://bugs.webkit.org/show_bug.cgi?id=208861
1301
1302         Reviewed by Jonathan Bedard.
1303
1304         * BuildSlaveSupport/ews-build/factories.py:
1305         (Factory.__init__): Remove verifycqplus parameter.
1306         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
1307         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
1308         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
1309
1310 2020-03-10  Philippe Normand  <pnormand@igalia.com>
1311
1312         [GTK] API favicon test flaky timeouts
1313         https://bugs.webkit.org/show_bug.cgi?id=208189
1314
1315         Reviewed by Carlos Garcia Campos.
1316
1317         Sometimes the favicon changes already during the load. Keeping
1318         track of it in the WebView favicon property notification handler
1319         gets us rid of the race.
1320
1321         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1322         (testFaviconDatabaseGetFavicon):
1323
1324 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1325
1326         Generate commit-queue status bubble from new EWS
1327         https://bugs.webkit.org/show_bug.cgi?id=208811
1328
1329         Reviewed by Jonathan Bedard.
1330
1331         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1332         (StatusBubble._build_bubbles_for_patch):
1333
1334 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
1335
1336         Remove obsolete feature flags
1337         https://bugs.webkit.org/show_bug.cgi?id=208830
1338
1339         Reviewed by Alex Christensen.
1340
1341         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
1342         are no longer used.
1343
1344         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
1345         when the compilation flag was removed in r258148.
1346
1347         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
1348         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
1349
1350         * Scripts/webkitperl/FeatureList.pm:
1351         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1352
1353 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
1354
1355         WebKitTestRunner bundleID should not be cleared before every test
1356         https://bugs.webkit.org/show_bug.cgi?id=208823
1357         <rdar://problem/60204539>
1358
1359         Reviewed by Per Arne Vollan.
1360
1361         This is causing test failures for layout tests which rely on the Info.plist 
1362         bundle identifier (not the one set via the override method).
1363
1364         * WebKitTestRunner/TestController.cpp:
1365         (WTR::TestController::createWebViewWithOptions):
1366         (WTR::TestController::ensureViewSupportsOptionsForTest):
1367         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1368
1369 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
1370
1371         [macOS] Notification observer is not removed
1372         https://bugs.webkit.org/show_bug.cgi?id=208834
1373
1374         Reviewed by Tim Horton.
1375
1376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1377         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
1378         (TEST):
1379
1380 2020-03-06  Brian Burg  <bburg@apple.com>
1381
1382         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
1383         https://bugs.webkit.org/show_bug.cgi?id=208729
1384         <rdar://problem/60105447>
1385
1386         Reviewed by Jonathan Bedard.
1387
1388         Improve upload.py to look for the svn branch and revision for the 'webkit'
1389         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
1390
1391         * Scripts/webkitpy/common/checkout/scm/git.py:
1392         (Git):
1393         (Git.git_svn_id_regexp):
1394         (Git._field_from_git_svn_id):
1395         (Git.svn_revision):
1396         (Git.svn_branch):
1397         (Git.svn_url):
1398         (Git.native_branch):
1399         Refactor svn revision, branch, url to use the same regexp and helper code.
1400
1401         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1402         (StubRepository.svn_branch):
1403         Expose a stub since this is used unconditionally by Port.commits_for_upload.
1404
1405         * Scripts/webkitpy/common/checkout/scm/svn.py:
1406         (SVN.svn_branch):
1407         (SVN.native_revision):
1408         (SVN):
1409         (SVN.native_branch):
1410         Refactor so the actual implementation is contained in svn_revision / svn_branch.
1411         The native_* methods call out to the SVN equivalents since this is an SVN repository.
1412
1413         * Scripts/webkitpy/port/base.py:
1414         (Port.commits_for_upload):
1415         Add special git-svn handling for the WebKit repository so that SVN branch and revision
1416         is preferred over the git equivalents.
1417
1418 2020-03-09  Antoine Quint  <graouts@apple.com>
1419
1420         TestWebKitAPI fails to build on watchOS
1421         https://bugs.webkit.org/show_bug.cgi?id=208820
1422
1423         Reviewed by Tim Horton.
1424
1425         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1426
1427 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
1428
1429         resultsdbpy: Add tool to manage resultsdbpy container
1430         https://bugs.webkit.org/show_bug.cgi?id=208743
1431
1432         Rubber-stamped by Aakash Jain.
1433
1434         Add tool to start, stop and restart the resultsdbpy Docker container.
1435
1436         * resultsdbpy/resultsdbpy/container: Added.
1437
1438 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1439
1440         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
1441         https://bugs.webkit.org/show_bug.cgi?id=208706
1442
1443         Reviewed by Žan Doberšek.
1444
1445         Add test case to check surrounding text in multiline context.
1446
1447         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
1448         (testWebKitInputMethodContextSurrounding):
1449
1450 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
1451
1452         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
1453         https://bugs.webkit.org/show_bug.cgi?id=208783
1454
1455         Reviewed by Brent Fulgham.
1456
1457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1458
1459 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
1460
1461         Replace the use of term "rollout" to "revert" in various tools
1462         https://bugs.webkit.org/show_bug.cgi?id=208775
1463
1464         Reviewed by Ryosuke Niwa.
1465
1466         See this webkit-dev thread for the originating discussion:
1467         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
1468
1469         'rollout' is a confusing term to anyone unacquainted with WebKit;
1470         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
1471
1472         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
1473         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
1474
1475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
1476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1478         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
1479         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
1480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1483         * BuildSlaveSupport/ews-build/steps.py:
1484         * BuildSlaveSupport/ews-build/steps_unittest.py:
1485         * Scripts/webkit-tools-completion.sh:
1486         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1487         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1488         * Scripts/webkitpy/common/checkout/scm/svn.py:
1489         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1490         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1491         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1492         * Scripts/webkitpy/tool/bot/feeders.py:
1493         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1494         * Scripts/webkitpy/tool/bot/irc_command.py:
1495         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1496         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1497         * Scripts/webkitpy/tool/bot/sheriff.py:
1498         * Scripts/webkitpy/tool/commands/download.py:
1499         * Scripts/webkitpy/tool/commands/download_unittest.py:
1500         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1501         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1502         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1503         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1504         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1505         * Scripts/webkitpy/tool/steps/__init__.py:
1506         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1507         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1508         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1509         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
1510
1511 2020-03-07  David Quesada  <david_quesada@apple.com>
1512
1513         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
1514         https://bugs.webkit.org/show_bug.cgi?id=208781
1515         rdar://problem/60061016
1516
1517         Reviewed by Alex Christensen.
1518
1519         Add a test that recreates the conditions of this crash:
1520         - Send a message from the injected bundle to the UI process that contains a reply block.
1521         - Hold a reference to the reply block.
1522         - Let the web view deallocate.
1523         - Call the block, and expect not to crash.
1524
1525         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1526         (localObjectInterface):
1527         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1528         (-[LocalObject doSomethingWithCompletionHandler:]):
1529         (TEST):
1530         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1531         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
1532
1533 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
1534
1535         TextManipulationController should work with ARIA labels
1536         https://bugs.webkit.org/show_bug.cgi?id=208759
1537
1538         Reviewed by Wenson Hsieh.
1539
1540         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1541         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
1542         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
1543         the expected number of tokens for the first item as the very first image is correctly
1544         detected per the code change. 
1545         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
1546
1547 2020-03-07  Alex Christensen  <achristensen@webkit.org>
1548
1549         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
1550         https://bugs.webkit.org/show_bug.cgi?id=208767
1551
1552         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1553         The frameID of the main frame before loading is only 0 on Mac right now.
1554         The test is still good because it validates that execution works in the main frame before loading.
1555
1556 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1557
1558         [ews] commit queue is not skipping layout tests for rollout patches
1559         https://bugs.webkit.org/show_bug.cgi?id=208716
1560
1561         Unreviewed minor fix.
1562
1563         * BuildSlaveSupport/ews-build/steps.py:
1564         (RunWebKitTests.doStepIf):
1565         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
1566         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
1567
1568 2020-03-05  Sam Weinig  <weinig@apple.com>
1569
1570         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
1571         https://bugs.webkit.org/show_bug.cgi?id=207436
1572         <rdar://problem/59296762>
1573
1574         Reviewed by Darin Adler.
1575
1576         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1577         Remove JSC related defines.
1578
1579 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
1580
1581         AX: Provide a way to run tests in isolated tree mode
1582         https://bugs.webkit.org/show_bug.cgi?id=208629
1583         <rdar://problem/60075583>
1584
1585         Reviewed by Ryosuke Niwa.
1586
1587         Provide the ability to run tests for accessibility in the isolated tree mode.
1588         This sends a flag over to the injected bundle which calls the right HIServices override so that
1589         the system thinks it is in isolated mode.
1590
1591         * Scripts/compare-webkit-configurations:
1592         (flag_for_comparison):
1593         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1594         (parse_args):
1595         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1596         (parse_args):
1597         * Scripts/webkitpy/port/driver.py:
1598         (Driver.cmd_line):
1599         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1600         (WTR::AccessibilityController::AccessibilityController):
1601         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
1602         (WTR::AccessibilityController::updateIsolatedTreeMode):
1603         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
1604         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1605         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1606         (WTR::InjectedBundle::didReceiveMessageToPage):
1607         (WTR::InjectedBundle::beginTesting):
1608         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1609         * WebKitTestRunner/Options.cpp:
1610         (WTR::handleOptionAccessibilityIsolatedTreeMode):
1611         (WTR::OptionsHandler::OptionsHandler):
1612         * WebKitTestRunner/Options.h:
1613         * WebKitTestRunner/TestController.cpp:
1614         (WTR::TestController::initialize):
1615         (WTR::TestController::resetPreferencesToConsistentValues):
1616         (WTR::TestController::resetStateToConsistentValues):
1617         * WebKitTestRunner/TestController.h:
1618         (WTR::TestController::accessibilityIsolatedTreeMode const):
1619
1620 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
1621
1622         [Cocoa] Re-enable CFPrefs direct mode
1623         https://bugs.webkit.org/show_bug.cgi?id=208690
1624
1625         Reviewed by Brent Fulgham.
1626
1627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1628         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
1629         (TEST):
1630         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1631         (TestWebKitAPI::TEST):
1632
1633 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
1634
1635         UIProcess needs mechanism to specify AppBound domains
1636         https://bugs.webkit.org/show_bug.cgi?id=208528
1637         <rdar://problem/59980340>
1638
1639         Reviewed by Brent Fulgham.
1640
1641         Added test app-bound domains to the plist and tested that the domains
1642         are properly stored in the website data store after a navigation.
1643
1644         * TestWebKitAPI/Info.plist:
1645         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1646         (TEST):
1647
1648 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1649
1650         Add SPI to disable cross origin access control checks
1651         https://bugs.webkit.org/show_bug.cgi?id=208748
1652
1653         Reviewed by Tim Hatcher.
1654
1655         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1656         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
1657
1658 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
1659
1660         [webkitpy] Fix executive on Windows to run wpt server correctly
1661         https://bugs.webkit.org/show_bug.cgi?id=208693
1662
1663         Reviewed by Jonathan Bedard.
1664
1665         Bug fix for Windows environment a) fixing a typo. b) fixing path
1666         c) fix how to kill subprocesses.
1667
1668         * Scripts/webkitpy/common/system/executive.py:
1669         (Executive._windows_kill_command):
1670         (Executive.interrupt):
1671         (Executive.kill_all):
1672         * Scripts/webkitpy/port/base.py:
1673         (Port.web_platform_test_server_doc_root):
1674
1675 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1676
1677         Evaluating JavaScript in main frame before loading should succeed
1678         https://bugs.webkit.org/show_bug.cgi?id=208733
1679
1680         Reviewed by Tim Horton.
1681
1682         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1683
1684 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
1685
1686         TextManipulationController should preserve images
1687         https://bugs.webkit.org/show_bug.cgi?id=208692
1688
1689         Reviewed by Wenson Hsieh.
1690
1691         Added tests for preserving images and their ordering.
1692
1693         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1694         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
1695         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
1696         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
1697
1698 2020-03-06  David Quesada  <david_quesada@apple.com>
1699
1700         Add _WKResourceLoadInfo.resourceType SPI
1701         https://bugs.webkit.org/show_bug.cgi?id=208723
1702
1703         Reviewed by Alex Christensen.
1704
1705         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1706         (TEST):
1707
1708 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
1709
1710         Stop reporting to webkit-test-results.webkit.org
1711         https://bugs.webkit.org/show_bug.cgi?id=207218
1712
1713         Reviewed by Alexey Proskuryakov.
1714
1715         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1716         (RunWebKitTests):
1717
1718 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
1719
1720         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1721         https://bugs.webkit.org/show_bug.cgi?id=208365
1722         <rdar://problem/59877296>
1723
1724         Reviewed by Geoffrey Garen.
1725
1726         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1727         (TEST):
1728
1729 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1730
1731         EWS should be able to fetch patch status for security bugs while processing them
1732         https://bugs.webkit.org/show_bug.cgi?id=206511
1733
1734         Reviewed by Alexey Proskuryakov.
1735
1736         * BuildSlaveSupport/ews-build/steps.py:
1737         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
1738         (BugzillaMixin.get_patch_json): 
1739         (BugzillaMixin.get_bug_json):
1740         (BugzillaMixin._is_bug_closed):
1741         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
1742         (TransferToS3.hideStepIf): Ditto.
1743
1744 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1745
1746         [ews] commit-queue should show the trac url for the commit on the build page
1747         https://bugs.webkit.org/show_bug.cgi?id=208715
1748
1749         Reviewed by Jonathan Bedard.
1750
1751         * BuildSlaveSupport/ews-build/steps.py:
1752         (PushCommitToWebKitRepo.evaluateCommand):
1753
1754 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1755
1756         Fix ResourceLoadDelegate.LoadInfo API test after r257816
1757         https://bugs.webkit.org/show_bug.cgi?id=208550
1758
1759         * TestWebKitAPI/cocoa/HTTPServer.mm:
1760         (TestWebKitAPI::HTTPServer::respondToRequests):
1761         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
1762         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
1763
1764 2020-03-06  Lauro Moura <lmoura@igalia.com>
1765
1766         [WPE][WebDriver] MiniBrowser should react to close session commands
1767         https://bugs.webkit.org/show_bug.cgi?id=207529
1768
1769         Reviewed by Carlos Garcia Campos.
1770
1771         Do not call g_object_unref on the first created view if it has already
1772         been disposed in the "close" signal handler.
1773
1774         Based on original patch by Yury Semikhatsky.
1775
1776         * MiniBrowser/wpe/main.cpp:
1777         (main):
1778
1779 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1780
1781         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
1782         https://bugs.webkit.org/show_bug.cgi?id=208647
1783
1784         Reviewed by Carlos Garcia Campos.
1785
1786         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1787         (TestWebKitAPI::TEST):
1788
1789 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1790
1791         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
1792         https://bugs.webkit.org/show_bug.cgi?id=208670
1793
1794         Reviewed by Brady Eidson.
1795
1796         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1797         (-[FrameNavigationDelegate waitForNavigations:]):
1798         (-[FrameNavigationDelegate requests]):
1799         (-[FrameNavigationDelegate frames]):
1800         (-[FrameNavigationDelegate callbacks]):
1801         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
1802         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
1803         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
1804         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
1805         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
1806         (TEST):
1807
1808 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1809
1810         Add WKFrameInfo._parentFrameHandle SPI
1811         https://bugs.webkit.org/show_bug.cgi?id=208674
1812
1813         Reviewed by Brady Eidson.
1814
1815         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1816
1817 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
1818
1819         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
1820         https://bugs.webkit.org/show_bug.cgi?id=208626
1821         <rdar://problem/60074148>
1822
1823         Reviewed by Brent Fulgham.
1824
1825         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1826         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1827         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1828         (TestWebKitAPI::TEST):
1829         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
1830         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
1831         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
1832
1833 2020-03-05  Antoine Quint  <graouts@apple.com>
1834
1835         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
1836         https://bugs.webkit.org/show_bug.cgi?id=208644
1837         <rdar://problem/60042429>
1838
1839         Reviewed by Brady Eidson.
1840
1841         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
1842         
1843         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
1844            empty document has been removed in favor of the document for the requested URL,
1845         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
1846            correctly does not injected the style sheet.
1847
1848         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1849
1850 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1851
1852         [ews] Add build step to push commit to WebKit repository
1853         https://bugs.webkit.org/show_bug.cgi?id=208589
1854
1855         Reviewed by Jonathan Bedard.
1856
1857         * BuildSlaveSupport/ews-build/steps.py:
1858         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
1859         (PushCommitToWebKitRepo.start): Initialize log observer.
1860         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
1861         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
1862         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
1863         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
1864         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1865         * BuildSlaveSupport/ews-build/factories.py:
1866
1867 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1868
1869         [ews] Add unit tests for ValidateCommiterAndReviewer build step
1870         https://bugs.webkit.org/show_bug.cgi?id=208262
1871
1872         Reviewed by Jonathan Bedard.
1873
1874         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
1875
1876 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1877
1878         commit-queue should run WK2 tests instead of WK1 tests
1879         https://bugs.webkit.org/show_bug.cgi?id=208544
1880
1881         Reviewed by Jonathan Bedard.
1882
1883         * BuildSlaveSupport/ews-build/factories.py:
1884
1885 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1886
1887         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
1888         https://bugs.webkit.org/show_bug.cgi?id=208645
1889
1890         Reviewed by Alexey Proskuryakov.
1891
1892         * BuildSlaveSupport/ews-build/steps.py:
1893         (ValidateCommiterAndReviewer.load_contributors):
1894         (ValidateCommiterAndReviewer.start):
1895
1896 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1897
1898         style-checker: Add UAF to the list of security words to warn about.
1899         https://bugs.webkit.org/show_bug.cgi?id=208643
1900
1901         Reviewed by Jonathan Bedard.
1902
1903         UAF is a common acronym used for use after free.
1904
1905         * Scripts/webkitpy/style/checkers/changelog.py:
1906         (ChangeLogChecker.check_for_unwanted_security_phrases):
1907
1908 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
1909
1910         [MSVC] Add .natvis support of WebKit types
1911         https://bugs.webkit.org/show_bug.cgi?id=193119
1912
1913         Reviewed by Don Olmstead.
1914
1915         To help the WebKit developer while debugging, this file defines how
1916         WebKit types are displayed in debugger of Visual Studio.
1917         Very limited set of WebKit types, but it changes the world.
1918
1919         * VisualStudio/WebKit.natvis: Added.
1920
1921 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1922
1923         Add system trace points around display list replay
1924         https://bugs.webkit.org/show_bug.cgi?id=208616
1925
1926         Reviewed by Simon Fraser.
1927
1928         Add a new "Display list replay" trace point.
1929
1930         * Tracing/SystemTracePoints.plist:
1931
1932 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1933
1934         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
1935         https://bugs.webkit.org/show_bug.cgi?id=208615
1936         <rdar://problem/59406743>
1937
1938         Reviewed by Alex Christensen.
1939
1940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1941         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
1942         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1943         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1944         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1945         (TEST):
1946         Also make a test written in bug 206310 actually run code.
1947
1948 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1949
1950         [build.webkit.org] Remove leaks queue
1951         https://bugs.webkit.org/show_bug.cgi?id=208580
1952
1953         Reviewed by Jonathan Bedard.
1954
1955         * BuildSlaveSupport/build.webkit.org-config/config.json:
1956         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1958
1959 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1960
1961         Add SPI to evaluate JavaScript in an iframe
1962         https://bugs.webkit.org/show_bug.cgi?id=208605
1963
1964         Reviewed by Brady Eidson.
1965
1966         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1967
1968 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
1969
1970         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
1971         https://bugs.webkit.org/show_bug.cgi?id=208533
1972         <rdar://problem/60010184>
1973
1974         Reviewed by Alex Christensen.
1975
1976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1977         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1978         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
1979         (TestWebKitAPI::TEST):
1980         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
1981         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
1982
1983 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1984
1985         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
1986         https://bugs.webkit.org/show_bug.cgi?id=208593
1987
1988         Reviewed by Brady Eidson.
1989
1990         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
1991         (TestWebKitAPI::TEST):
1992
1993 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1994
1995         WKWebView's frames accessor should return a traversable type
1996         https://bugs.webkit.org/show_bug.cgi?id=208591
1997
1998         Reviewed by Brady Eidson.
1999
2000         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2001
2002 2020-03-04  Antoine Quint  <graouts@apple.com>
2003
2004         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
2005         https://bugs.webkit.org/show_bug.cgi?id=208575
2006         <rdar://problem/59773690>
2007
2008         Reviewed by Brady Eidson.
2009
2010         Add new tests for the new SPI which check:
2011         
2012         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
2013            specified WKWebView alone,
2014         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
2015         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
2016         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
2017         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
2018         6. and that the same test also works with PSON enabled.
2019
2020         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2021
2022 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
2023
2024         [macOS] test-lldb-webkit failing on debug bots
2025         https://bugs.webkit.org/show_bug.cgi?id=208545
2026
2027         Reviewed by Jonathan Bedard.
2028
2029         The lldb-webkit-test step must pass in the build configuration as an
2030         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
2031         binary that is downloaded with the rest of the build products. Without this
2032         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
2033         regardless of their actual build configuration.
2034
2035         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2036         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
2037         * Scripts/test-lldb-webkit:
2038         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
2039
2040 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2041
2042         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
2043         https://bugs.webkit.org/show_bug.cgi?id=208539
2044
2045         Unreviewed follow-up fix.
2046
2047         * BuildSlaveSupport/ews-build/steps.py:
2048
2049 2020-03-04  Daniel Bates  <dabates@apple.com>
2050
2051         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
2052         https://bugs.webkit.org/show_bug.cgi?id=208565
2053
2054         Reviewed by Wenson Hsieh.
2055
2056         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
2057         of its frame as a means to find all the editable elements in the visible content area
2058         of the web view.
2059
2060         Coincidentally this makes no difference to the test results right now because the web view
2061         happens to be located at the origin (0, 0) in the window. However if in the future the
2062         web view would be located at some other point then the tests may fail because the rectangle
2063         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
2064         rectangle for the visible content area.
2065
2066         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2067         (TEST):
2068
2069 2020-03-04  Daniel Bates  <dabates@apple.com>
2070
2071         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
2072         https://bugs.webkit.org/show_bug.cgi?id=208564
2073
2074         Reviewed by Alex Christensen.
2075
2076         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
2077         to make it easy to run just these tests.
2078
2079         Currently, the tests are organized under the test case name WebKit. This means you need to
2080         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
2081         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
2082         so that a person can run just these test using:
2083         
2084                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
2085
2086         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2087         (TEST):
2088
2089 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2090
2091         [ews] Add build step to create local git commit for commit-queue
2092         https://bugs.webkit.org/show_bug.cgi?id=208539
2093
2094         Reviewed by Jonathan Bedard.
2095
2096         * BuildSlaveSupport/ews-build/steps.py:
2097         (CreateLocalGITCommit): Build step to create local git commit.
2098         (CreateLocalGITCommit.start):
2099         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
2100         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
2101         * BuildSlaveSupport/ews-build/factories.py:
2102
2103 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
2104
2105         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
2106         https://bugs.webkit.org/show_bug.cgi?id=207948
2107
2108         Reviewed by Zalan Bujtas.
2109
2110         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
2111         so that it receives the wheel events.
2112
2113         * DumpRenderTree/mac/EventSendingController.mm:
2114         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2115         * DumpRenderTree/win/EventSender.cpp:
2116         (mouseScrollBy):
2117
2118 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
2119
2120         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
2121         https://bugs.webkit.org/show_bug.cgi?id=208520
2122         <rdar://problem/60000214>
2123
2124         Reviewed by Chris Fleizach.
2125
2126         Calling InjectedBundle::singleton().page()->page() in the constructor
2127         of the AccessibilityController is having this side effect on iOS.
2128         So #if to MAC where it's actually being used.
2129
2130         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2131         (WTR::AccessibilityController::AccessibilityController):
2132
2133 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2134
2135         Add SPI _WKResourceLoadInfo.loadedFromCache
2136         https://bugs.webkit.org/show_bug.cgi?id=208554
2137
2138         Reviewed by Wenson Hsieh.
2139
2140         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2141         (TEST):
2142
2143 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2144
2145         Batch observations and completions of text manipulations
2146         https://bugs.webkit.org/show_bug.cgi?id=208406
2147
2148         Reviewed by Wenson Hsieh.
2149
2150         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
2151         multiple paragraphs at once.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2154         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
2155         (-[TextManipulationDelegate items]):
2156         (-[LegacyTextManipulationDelegate init]):
2157         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
2158         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
2159         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
2160         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
2161         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
2162         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
2163         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
2164
2165 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
2166
2167         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2168         https://bugs.webkit.org/show_bug.cgi?id=208415
2169
2170         Reviewed by Brent Fulgham.
2171
2172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2173         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2174         (TEST):
2175
2176 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2177
2178         Add response to _WKResourceLoadDelegate didCompleteWithError callback
2179         https://bugs.webkit.org/show_bug.cgi?id=208553
2180
2181         Reviewed by Simon Fraser.
2182
2183         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2184         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
2185         (TEST):
2186         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
2187
2188 2020-03-03  Brady Eidson  <beidson@apple.com>
2189
2190         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
2191         https://bugs.webkit.org/show_bug.cgi?id=198795
2192
2193         Reviewed by Chris Dumez.
2194
2195         This test appears to no longer be flaky.
2196         
2197         Let's re-enable it.
2198         
2199         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2200         (TestWebKitAPI::TEST):
2201
2202 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2203
2204         Requests sent to _WKResourceLoadDelegate should include HTTPBody
2205         https://bugs.webkit.org/show_bug.cgi?id=208550
2206
2207         Reviewed by Tim Hatcher.
2208
2209         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2210         (TEST):
2211         * TestWebKitAPI/cocoa/HTTPServer.mm:
2212         (TestWebKitAPI::HTTPServer::respondToRequests):
2213         HTTPServer now looks for Content-Length in its request.
2214         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
2215
2216 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2217
2218         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
2219         https://bugs.webkit.org/show_bug.cgi?id=208522
2220
2221         Reviewed by Brian Weinstein.
2222
2223         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2224         (TEST):
2225
2226 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2227
2228         commit-queue should update working directory and reapply patch just before commiting
2229         https://bugs.webkit.org/show_bug.cgi?id=208521
2230
2231         Reviewed by Jonathan Bedard.
2232
2233         * BuildSlaveSupport/ews-build/factories.py:
2234
2235 2020-03-03  Matt Lewis  <jlewis3@apple.com>
2236
2237         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
2238         https://bugs.webkit.org/show_bug.cgi?id=208485
2239
2240         Reviewed by Jonathan Bedard.
2241
2242         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2243         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
2244         that we don't have to recreate the variables that are already created.
2245         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
2246         from each module, rather than making extra imports that we don't need.
2247         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
2248         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
2249         and not part of the host.
2250         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
2251         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
2252         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
2253         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
2254         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
2255         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
2256         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
2257         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
2258         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
2259         if we were geting any value at all
2260         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
2261         sure we aren't gabking the wrong key:value pair
2262         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
2263         come with the MockHosts and MockHost inherits from MockSystemHost.
2264         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
2265         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
2266         to the various upload steps.
2267
2268 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2269
2270         [ews] Add build step to find list of modified changelogs
2271         https://bugs.webkit.org/show_bug.cgi?id=208514
2272
2273         Reviewed by Jonathan Bedard.
2274
2275         * BuildSlaveSupport/ews-build/factories.py:
2276         * BuildSlaveSupport/ews-build/steps.py:
2277         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
2278         (FindModifiedChangeLogs.start): Initialize log observer.
2279         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
2280         (FindModifiedChangeLogs.evaluateCommand):
2281         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
2282         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
2283         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
2284         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2285
2286 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
2287
2288         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2289         https://bugs.webkit.org/show_bug.cgi?id=208451
2290
2291         Unreviewed test gardening.
2292
2293         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
2294
2295 2020-03-03  Jiten Mehta  <jmehta@apple.com>
2296
2297         Adopt HTTP Alternative Services Storage
2298         https://bugs.webkit.org/show_bug.cgi?id=208387
2299
2300         Reviewed by Alex Christensen.
2301
2302         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2303         (checkUntilEntryFound):
2304         (TEST):
2305
2306 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
2307
2308         Check for navigation to app-bound domain during script evaluation
2309         https://bugs.webkit.org/show_bug.cgi?id=208319
2310         <rdar://problem/57569321>
2311
2312         Reviewed by Brent Fulgham.
2313
2314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2315         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
2316         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2317         (TEST):
2318         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
2319         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
2320
2321 2020-03-03  Commit Queue  <commit-queue@webkit.org>
2322
2323         Unreviewed, rolling out r257754.
2324         https://bugs.webkit.org/show_bug.cgi?id=208513
2325
2326         Introduced API test failure (Requested by perarne on #webkit).
2327
2328         Reverted changeset:
2329
2330         "[Cocoa] Mapping from MIME type to UTI type should be done in
2331         the UI process"
2332         https://bugs.webkit.org/show_bug.cgi?id=208415
2333         https://trac.webkit.org/changeset/257754
2334
2335 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
2336
2337         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
2338         https://bugs.webkit.org/show_bug.cgi?id=208506
2339
2340         Reviewed by Carlos Garcia Campos.
2341
2342         * WebKitTestRunner/TestController.cpp:
2343         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
2344
2345 2020-03-02  Ben Nham  <nham@apple.com>
2346
2347         Add performance probes for HTML parsing
2348         https://bugs.webkit.org/show_bug.cgi?id=208271
2349
2350         Reviewed by Daniel Bates.
2351
2352         This adds probes that show which lines of HTML are have been parsed.
2353
2354         * Tracing/SystemTracePoints.plist:
2355
2356 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2357
2358         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2359         https://bugs.webkit.org/show_bug.cgi?id=208415
2360
2361         Reviewed by Brent Fulgham.
2362
2363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2364         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2365         (TEST):
2366
2367 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2368
2369         Unreviewed, rolling out r257725.
2370
2371         This commit caused 10 API tests to fail
2372
2373         Reverted changeset:
2374
2375         "[Cocoa] Mapping from MIME type to UTI type should be done in
2376         the UI process"
2377         https://bugs.webkit.org/show_bug.cgi?id=208415
2378         https://trac.webkit.org/changeset/257725
2379
2380 2020-03-02  Saam Barati  <sbarati@apple.com>
2381
2382         Don't skip tests unnecessarily on arm64
2383         https://bugs.webkit.org/show_bug.cgi?id=208470
2384         <rdar://problem/59968869>
2385
2386         Reviewed by Tadeu Zagallo.
2387
2388         * Scripts/run-jsc-stress-tests:
2389
2390 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
2391
2392         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
2393         https://bugs.webkit.org/show_bug.cgi?id=208434
2394
2395         Reviewed by Chris Fleizach.
2396
2397         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2398         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
2399         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
2400         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2401         (WTR::AccessibilityController::accessibleElementById): Same as above.
2402
2403 2020-03-02  John Wilander  <wilander@apple.com>
2404
2405         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
2406         https://bugs.webkit.org/show_bug.cgi?id=208399
2407         <rdar://problem/24731650>
2408
2409         Reviewed by Brent Fulgham.
2410
2411         The majority of the changes in WTR::TestController is (partially) fixing a bug
2412         where the TestRunner would statically use the default website datastore instead
2413         of the website data store configure for the page. This worked for persistent
2414         storage testing but not for ephemeral sessions which is what this patch is all
2415         about. The previous TestController::websiteDataStore() is now called
2416         TestController::defaultWebsiteDataStore() and the new
2417         TestController::websiteDataStore() returns the configured website data store.
2418         Most of the use of the default website data store should probably change but
2419         that's not really for this patch to deal with. I did however move all of
2420         resource load statistics' use to the new TestController::websiteDataStore().
2421
2422         A new TestRunner function was added: isStatisticsEphemeral()
2423         It allows test cases to query the ephemeral status of resource load statistics.
2424
2425         One problem that is mitigated in this patch but not fully fixed is that for
2426         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
2427         TestController::generatePageConfiguration() via C API 
2428         WKPageConfigurationSetWebsiteDataStore(), and then again in 
2429         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
2430         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
2431         I tried removing the latter since one session for all platforms should be
2432         Enough but got broken behavior as a result. So now both are still there
2433         and both enable resource load statistics.
2434
2435         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2436         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2437         (WTR::TestRunner::isStatisticsEphemeral):
2438         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2439         * WebKitTestRunner/TestController.cpp:
2440         (WTR::TestController::defaultWebsiteDataStore):
2441         (WTR::TestController::websiteDataStore):
2442         (WTR::TestController::generatePageConfiguration):
2443         (WTR::TestController::resetPreferencesToConsistentValues):
2444         (WTR::TestController::resetStateToConsistentValues):
2445         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2446         (WTR::TestController::decidePolicyForNavigationAction):
2447         (WTR::TestController::platformAdjustContext):
2448         (WTR::TestController::clearServiceWorkerRegistrations):
2449         (WTR::TestController::clearDOMCache):
2450         (WTR::TestController::clearDOMCaches):
2451         (WTR::TestController::clearIndexedDatabases):
2452         (WTR::TestController::clearLocalStorage):
2453         (WTR::TestController::hasDOMCache):
2454         (WTR::TestController::domCacheSize):
2455         (WTR::TestController::setStatisticsEnabled):
2456         (WTR::TestController::isStatisticsEphemeral):
2457         (WTR::TestController::setStatisticsDebugMode):
2458         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
2459         (WTR::TestController::setStatisticsLastSeen):
2460         (WTR::TestController::setStatisticsMergeStatistic):
2461         (WTR::TestController::setStatisticsPrevalentResource):
2462         (WTR::TestController::setStatisticsVeryPrevalentResource):
2463         (WTR::TestController::dumpResourceLoadStatistics):
2464         (WTR::TestController::isStatisticsPrevalentResource):
2465         (WTR::TestController::isStatisticsVeryPrevalentResource):
2466         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
2467         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2468         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2469         (WTR::TestController::setStatisticsHasHadUserInteraction):
2470         (WTR::TestController::isStatisticsHasHadUserInteraction):
2471         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
2472         (WTR::TestController::setStatisticsGrandfathered):
2473         (WTR::TestController::isStatisticsGrandfathered):
2474         (WTR::TestController::setUseITPDatabase):
2475         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2476         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2477         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2478         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
2479         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
2480         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
2481         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2482         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2483         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2484         (WTR::TestController::statisticsUpdateCookieBlocking):
2485         (WTR::TestController::statisticsSubmitTelemetry):
2486         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2487         (WTR::TestController::setStatisticsIsRunningTest):
2488         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2489         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2490         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2491         (WTR::TestController::setStatisticsGrandfatheringTime):
2492         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2493         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2494         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2495         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2496         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2497         (WTR::TestController::statisticsDeleteCookiesForHost):
2498         (WTR::TestController::isStatisticsHasLocalStorage):
2499         (WTR::TestController::setStatisticsCacheMaxAgeCap):
2500         (WTR::TestController::hasStatisticsIsolatedSession):
2501         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
2502         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
2503         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
2504         (WTR::TestController::statisticsResetToConsistentState):
2505         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2506         * WebKitTestRunner/TestController.h:
2507         * WebKitTestRunner/TestInvocation.cpp:
2508         (WTR::TestInvocation::invoke):
2509         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2510         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2511         (WTR::initializeWebViewConfiguration):
2512         (WTR::TestController::platformCreateWebView):
2513
2514 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2515
2516         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2517         https://bugs.webkit.org/show_bug.cgi?id=208415
2518
2519         Reviewed by Brent Fulgham.
2520
2521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2522         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2523         (TEST):
2524
2525 2020-03-02  Daniel Bates  <dabates@apple.com>
2526
2527         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
2528         https://bugs.webkit.org/show_bug.cgi?id=208352
2529         <rdar://problem/59867815>
2530
2531         Reviewed by Wenson Hsieh.
2532
2533         Update test results to reflect the new behavior. To do this I also need to fix up the test code
2534         to actually scroll the web content. This also means we now execute the same code on both Mac and
2535         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
2536         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
2537         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
2538
2539         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2540         (TEST):
2541
2542 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2543
2544         Unreviewed, rolling out r257687.
2545
2546         This commit caused debug tests to crash for macOS & iOS
2547
2548         Reverted changeset:
2549
2550         "[Cocoa] Mapping from MIME type to UTI type should be done in
2551         the UI process"
2552         https://bugs.webkit.org/show_bug.cgi?id=208415
2553         https://trac.webkit.org/changeset/257687
2554
2555 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2556
2557         Unreviewed, rolling out r257618.
2558
2559         This allegedly causes Safari to crash when closing a window
2560         (see rdar://problem/59922725).
2561
2562         Reverted changeset:
2563
2564         "UIProcess crash after using _prepareForMoveToWindow, then
2565         deallocating the WKWebView before moving to the window"
2566         https://bugs.webkit.org/show_bug.cgi?id=208365
2567         https://trac.webkit.org/changeset/257618
2568
2569 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
2570
2571         Remove std::lock_guard
2572         https://bugs.webkit.org/show_bug.cgi?id=206451
2573
2574         Reviewed by Anders Carlsson.
2575
2576         Add std::lock_guard lint rule to prevent from using it.
2577
2578         * Scripts/webkitpy/style/checkers/cpp.py:
2579         (check_lock_guard):
2580         (check_style):
2581         (CppChecker):
2582         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2583         (WebKitStyleTest.test_lock_guard):
2584         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2585         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2586         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2587         (assertHasObjects):
2588         (assertHasOnlyObjects):
2589         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2590         (WTR::AXThread::dispatch):
2591         (WTR::AXThread::dispatchFunctionsFromAXThread):
2592         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2593         (WTR::AXThread::initializeRunLoop):
2594
2595 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
2596
2597         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2598         https://bugs.webkit.org/show_bug.cgi?id=208415
2599
2600         Reviewed by Brent Fulgham.
2601
2602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2603         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2604         (TEST):
2605
2606 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2607
2608         Unreviewed, rolling out r257565.
2609
2610         It broke WinCairo MiniBrowser
2611
2612         Reverted changeset:
2613
2614         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
2615         https://bugs.webkit.org/show_bug.cgi?id=206894
2616         https://trac.webkit.org/changeset/257565
2617
2618 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2619
2620         EWS fails to retry build in case of kill-old-processes exception
2621         https://bugs.webkit.org/show_bug.cgi?id=208003
2622
2623         Reviewed by Jonathan Bedard.
2624
2625         * BuildSlaveSupport/ews-build/steps.py:
2626         (KillOldProcesses.evaluateCommand):
2627         (KillOldProcesses.getResultSummary):
2628
2629 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2630
2631         [ews] commit-queue should update the ChangeLog with Reviewer name
2632         https://bugs.webkit.org/show_bug.cgi?id=206535
2633
2634         Reviewed by Jonathan Bedard.
2635
2636         * BuildSlaveSupport/ews-build/steps.py:
2637         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
2638
2639 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
2640
2641         run-javascriptcore-tests: Make upload format valid
2642         https://bugs.webkit.org/show_bug.cgi?id=208341
2643
2644         Rubber-stamped by Aakash Jain.
2645
2646         * Scripts/run-javascriptcore-tests:
2647         (uploadResults): Remove. FIXME.
2648         * Scripts/webkitdirs.pm:
2649         (splitVersionString): Handle case where the subminor version number has a - in it.
2650         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
2651
2652 2020-02-28  youenn fablet  <youenn@apple.com>
2653
2654         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
2655         https://bugs.webkit.org/show_bug.cgi?id=208130
2656
2657         Reviewed by Eric Carlson.
2658
2659         * WebKitTestRunner/TestOptions.h:
2660         Use GPU process to capture by default.
2661         We will remove this option once done verifying that every test works smoothly.
2662
2663 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2664
2665         [ews] commit queue should skip building and testing for rollout patches
2666         https://bugs.webkit.org/show_bug.cgi?id=208329
2667
2668         Reviewed by Jonathan Bedard.
2669
2670         * BuildSlaveSupport/ews-build/steps.py:
2671         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
2672         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
2673         (RunWebKit1Tests.doStepIf): Ditto.
2674         * BuildSlaveSupport/ews-build/steps_unittest.py:
2675         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
2676         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
2677
2678 2020-02-28  Daniel Bates  <dabates@apple.com>
2679
2680         Update my watch list preferences and contributor's entry.
2681
2682         * Scripts/webkitpy/common/config/contributors.json:
2683         * Scripts/webkitpy/common/config/watchlist:
2684
2685 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2686
2687         Fix WebCore export macros for declspec
2688         https://bugs.webkit.org/show_bug.cgi?id=208363
2689
2690         Reviewed by Konstantin Tokarev.
2691
2692         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
2693         files. Removed precompiled headers that were empty.
2694
2695         * DumpRenderTree/DumpRenderTreePrefix.h:
2696         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
2697         * MiniBrowser/win/stdafx.h:
2698         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
2699         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
2700         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
2701         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
2702         * WebKitTestRunner/PlatformFTW.cmake:
2703         * WebKitTestRunner/PlatformWin.cmake:
2704         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2705
2706 2020-02-27  Tim Horton  <timothy_horton@apple.com>
2707
2708         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
2709         https://bugs.webkit.org/show_bug.cgi?id=208365
2710
2711         Reviewed by Alex Christensen.
2712
2713         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2714         (TEST):
2715         Add a test! It was a 100% repro crash before this change.
2716
2717 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
2718
2719         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2720         https://bugs.webkit.org/show_bug.cgi?id=208260
2721         <rdar://problem/59820107>
2722
2723         Reviewed by Tim Horton.
2724
2725         Followed instructions for adding an Info.plist for Single-File Tools
2726         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2727
2728         The default WebsiteDataStore file path will change with this test to
2729         reflect the new bundleID so we must change expectations for any api
2730         tests which rely on knowing the path.
2731
2732         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2734         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2735         (TEST):
2736         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2737         (TEST):
2738         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
2739         (TEST):
2740         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
2741         (TEST):
2742         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2743         (TEST):
2744         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2745         (TEST):
2746         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2747         (TEST):
2748         (defaultWebsiteCacheDirectory):
2749         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
2750         (TEST):
2751         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2752         (TEST):
2753         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2754         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2755         (TEST):
2756         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2757         (TEST):
2758         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2759         (runWebsiteDataStoreCustomPaths):
2760         (TEST):
2761         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2762         (TestWebKitAPI::resetTestState):
2763         Now that we set a bundleID, we have to reset the cache model between
2764         tests, otherwise it gets stored between tests.
2765
2766         (TestWebKitAPI::TEST):
2767         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2768         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2769
2770 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2771
2772         TextManipulationController should not generate a new item for content in manipulated paragraphs
2773         https://bugs.webkit.org/show_bug.cgi?id=208286
2774
2775         Reviewed by Wenson Hsieh.
2776
2777         Added a regression test.
2778
2779         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2780         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
2781
2782 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
2783
2784         run-javascriptcore-tests: Make upload format valid
2785         https://bugs.webkit.org/show_bug.cgi?id=208341
2786
2787         Reviewed by Aakash Jain.
2788
2789         * Scripts/run-javascriptcore-tests:
2790         (uploadResults): Print json blob for upload after failure for debugging.
2791
2792 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2793
2794         [CMake] Add WebKit::PAL target
2795         https://bugs.webkit.org/show_bug.cgi?id=198493
2796
2797         Reviewed by Michael Catanzaro.
2798
2799         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
2800
2801         * DumpRenderTree/PlatformWin.cmake:
2802
2803 2020-02-27  Alex Christensen  <achristensen@webkit.org>
2804
2805         Add SPI to query WKFrameInfos in a WKWebView
2806         https://bugs.webkit.org/show_bug.cgi?id=208212
2807
2808         Reviewed by Brady Eidson.
2809
2810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2811         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2812         * WebKitTestRunner/TestController.cpp:
2813         (WTR::TestController::saltForOrigin):
2814
2815 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
2816
2817         Unreviewed, rolling out r257530.
2818
2819         This commit seems to have broke the build internally for
2820         watchOS
2821
2822         Reverted changeset:
2823
2824         "Add SPI to query WKFrameInfos in a WKWebView"
2825         https://bugs.webkit.org/show_bug.cgi?id=208212
2826         https://trac.webkit.org/changeset/257530
2827
2828 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2829
2830         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
2831         https://bugs.webkit.org/show_bug.cgi?id=206894
2832
2833         Reviewed by Adrian Perez de Castro.
2834
2835         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
2836         MiniBrowsers.
2837
2838         * MiniBrowser/gtk/CMakeLists.txt:
2839         * MiniBrowser/win/CMakeLists.txt:
2840         * MiniBrowser/wpe/CMakeLists.txt:
2841
2842 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2843
2844         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
2845         https://bugs.webkit.org/show_bug.cgi?id=206456
2846
2847         Reviewed by Brady Eidson.
2848
2849         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2850         (TEST):
2851
2852 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2853
2854         _WKUserContentWorld should be a wrapper around WKContentWorld
2855         https://bugs.webkit.org/show_bug.cgi?id=208274
2856
2857         Reviewed by Brady Eidson.
2858
2859         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
2860         (TEST):
2861         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2862         (TEST):
2863
2864 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
2865
2866         Unreviewed, rolling out r257522.
2867
2868         Caused 16 API test failures on the bots
2869
2870         Reverted changeset:
2871
2872         "TestWebKitAPI and WebKitTestRunner should have bundle
2873         identifiers"
2874         https://bugs.webkit.org/show_bug.cgi?id=208260
2875         https://trac.webkit.org/changeset/257522
2876
2877 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2878
2879         Add SPI to query WKFrameInfos in a WKWebView
2880         https://bugs.webkit.org/show_bug.cgi?id=208212
2881
2882         Reviewed by Brady Eidson.
2883
2884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2885         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2886         * WebKitTestRunner/TestController.cpp:
2887         (WTR::TestController::saltForOrigin):
2888
2889 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2890
2891         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2892         https://bugs.webkit.org/show_bug.cgi?id=208260
2893         <rdar://problem/59820107>
2894
2895         Reviewed by Tim Horton.
2896
2897         Followed instructions for adding an Info.plist for Single-File Tools
2898         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2899
2900         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2901         * TestWebKitAPI/Info.plist: Added.
2902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2903         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2904         * WebKitTestRunner/Info.plist: Added.
2905         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2906
2907 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2908
2909         Tests should each use a unique ResourceLoadStatistics file path for its database store
2910         https://bugs.webkit.org/show_bug.cgi?id=208206
2911         <rdar://problem/59690272>
2912
2913         Reviewed by Brady Eidson.
2914
2915         Initialize a default website data store before checking for the ITP
2916         store to ensure the directory exists after the file has been deleted.
2917
2918         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2919         (TEST):
2920
2921 2020-02-26  Christopher Reid  <chris.reid@sony.com>
2922
2923         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
2924         https://bugs.webkit.org/show_bug.cgi?id=197684
2925         <rdar://problem/59467397>
2926
2927         Reviewed by Yusuke Suzuki.
2928
2929         Add test for FileSystem::createFile
2930
2931         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2932
2933 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
2934
2935         [ews] commit-queue should verify patch committer and reviewer
2936         https://bugs.webkit.org/show_bug.cgi?id=206532
2937
2938         Reviewed by Jonathan Bedard.
2939
2940         * BuildSlaveSupport/ews-build/steps.py:
2941         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
2942         (ValidateCommiterAndReviewer._addToLog):
2943         (ValidateCommiterAndReviewer.getResultSummary):
2944         (ValidateCommiterAndReviewer.fail_build):
2945         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
2946         (ValidateCommiterAndReviewer.is_reviewer):
2947         (ValidateCommiterAndReviewer.is_committer):
2948         (ValidateCommiterAndReviewer.full_name_from_email):
2949         (ValidateCommiterAndReviewer.start):
2950
2951 2020-02-26  Daniel Bates  <dabates@apple.com>
2952
2953         [iOS] Send focus update immediately on becoming or resigning first responder
2954         https://bugs.webkit.org/show_bug.cgi?id=208082
2955         <rdar://problem/59688413>
2956
2957         Rubber-stamped by Jer Noble.
2958
2959         Add a test to ensure that selecting a position at a point after the web view
2960         becomes first responder is allowed. Such an operation is only allowed if the
2961         web view is focused.
2962
2963         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2964         (-[TestWKWebView selectPositionAtPoint:]):
2965         (TEST):
2966         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
2967
2968 2020-02-26  Chris Dumez  <cdumez@apple.com>
2969
2970         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
2971
2972         The test was added for macOS and times out on iOS.
2973
2974         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2975         (TEST):
2976
2977 2020-02-26  Youenn Fablet  <youenn@apple.com>
2978
2979         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
2980         https://bugs.webkit.org/show_bug.cgi?id=208238
2981
2982         Reviewed by Eric Carlson.
2983
2984         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2985         (TEST):
2986         Remove use of deleted parameter.
2987
2988 2020-02-25  Devin Rousso  <drousso@apple.com>
2989
2990         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
2991         https://bugs.webkit.org/show_bug.cgi?id=206911
2992         <rdar://problem/58026635>
2993
2994         Reviewed by Brian Burg.
2995
2996         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2997         (TestWebKitAPI::TEST):
2998         Add test for `WTF::HashSet::reserveInitialCapacity`.
2999
3000         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3001         (TestWebKitAPI::TEST):
3002         Actually check the value of `WTF::HashMap::capacity`.
3003
3004         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
3005         (-[InspectorDelegate _webView:didAttachInspector:])
3006         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
3007         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
3008         (TestWebKitAPI::TEST):
3009         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3010         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
3011         (TestWebKitAPI::TEST): Deleted.
3012
3013 2020-02-25  Matt Lewis  <jlewis3@apple.com>
3014
3015         Add checkout_root to stubrepository.py
3016         https://bugs.webkit.org/show_bug.cgi?id=208213
3017
3018         Reviewed by Jonathan Bedard.
3019
3020         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3021         (StubRepository.__init__):
3022
3023         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
3024         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
3025
3026 2020-02-25  Daniel Bates  <dabates@apple.com>
3027
3028         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
3029         https://bugs.webkit.org/show_bug.cgi?id=208214
3030
3031         Reviewed by Wenson Hsieh.
3032
3033         Wait until the copy operation completes before loading the second web view and testing paste
3034         to ensure that something was actually copied to the clipboard.
3035
3036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
3037         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3038         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
3039         so that we wait until the command completes.
3040
3041 2020-02-25  Chris Dumez  <cdumez@apple.com>
3042
3043         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
3044         https://bugs.webkit.org/show_bug.cgi?id=208199
3045         <rdar://problem/59746887>
3046
3047         Reviewed by Alex Christensen.
3048
3049         Add API test coverage.
3050
3051         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3052         (TEST):
3053
3054 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3055
3056         spinRunLoop should take a non-zero integer as parameter
3057         https://bugs.webkit.org/show_bug.cgi?id=208148
3058         <rdar://problem/59766682>
3059
3060         Unreviewed iOS build fix.
3061
3062         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3063         (TestWebKitAPI::Util::spinRunLoop):
3064
3065 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3066
3067         spinRunLoop should take a non-zero integer as parameter
3068         https://bugs.webkit.org/show_bug.cgi?id=208148
3069
3070         Reviewed by Darin Adler.
3071
3072         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3073         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3074         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3075         (TestWebKitAPI::Util::spinRunLoop):
3076
3077 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3078
3079         [WTF] Add tests for CompactRefPtrTuple
3080         https://bugs.webkit.org/show_bug.cgi?id=208172
3081
3082         Reviewed by Darin Adler.
3083
3084         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
3085         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
3086
3087         * TestWebKitAPI/CMakeLists.txt:
3088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3089         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
3090         (TestWebKitAPI::TEST):
3091
3092 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
3093
3094         [ews] commit-queue should check that patch have appropriate review flag
3095         https://bugs.webkit.org/show_bug.cgi?id=208138
3096
3097         Reviewed by Jonathan Bedard.
3098
3099         * BuildSlaveSupport/ews-build/steps.py:
3100         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
3101         (BugzillaMixin._is_patch_cq_plus):
3102         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
3103         (ValidatePatch.start):
3104
3105 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
3106
3107         [WebAuthn] Implement SPI for the platform authenticator
3108         https://bugs.webkit.org/show_bug.cgi?id=208087
3109         <rdar://problem/59369305>
3110
3111         Reviewed by Brent Fulgham.
3112
3113         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
3114
3115         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
3116         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3118         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3119         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3120         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
3121         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
3122         (TestWebKitAPI::TEST):
3123         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
3124         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
3125         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
3126         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
3127
3128 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3129
3130         Unreviewed, updating LLDB test for CompactPointerTuple.
3131         https://bugs.webkit.org/show_bug.cgi?id=207827
3132
3133         * lldb/lldb_webkit.py:
3134         (WTFCompactPointerTupleProvider):
3135         (WTFCompactPointerTupleProvider.update):
3136
3137 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
3138
3139         Provide alternate way to name Web Content process
3140         https://bugs.webkit.org/show_bug.cgi?id=205224
3141         rdar://57038084
3142
3143         Reviewed by Alex Christensen.
3144
3145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3146         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
3147         (TestWebKitAPI::TEST):
3148
3149 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
3150
3151         results.webkit.org: Link to result archives
3152         https://bugs.webkit.org/show_bug.cgi?id=207646
3153         <rdar://problem/59395807>
3154
3155         Rubber-stamped by Aakash Jain.
3156
3157         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
3158         (_ArchiveRouter): Retrieve json from archive-router endpoint.
3159         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
3160         return the most specific value.
3161         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
3162         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
3163         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
3164         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3165         (parametersForInstance): Extract from lambda function.
3166         (testRunLink): Use parametersForInstance instead of a lambda function.
3167         (archiveLink): Return an archive link for data. 
3168         (contentForData): Add archive link to view.
3169         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3170         (TimelineFromEndpoint): Accept both suite and test.
3171         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
3172         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
3173         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
3174         * resultsdbpy/resultsdbpy/view/view_routes.py:
3175         (ViewRoutes.__init__): Add archive_route dictionary.
3176
3177 2020-02-24  Alex Christensen  <achristensen@webkit.org>
3178
3179         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
3180         https://bugs.webkit.org/show_bug.cgi?id=208035
3181         <rdar://problem/58011337>
3182
3183         Reviewed by Tim Hatcher.
3184
3185         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3186
3187 2020-02-22  Darin Adler  <darin@apple.com>
3188
3189         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
3190         https://bugs.webkit.org/show_bug.cgi?id=208099
3191
3192         Reviewed by Antti Koivisto.
3193
3194         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3195         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
3196         so we can use the -[NSString createJSStringRef] method.
3197         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
3198         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
3199
3200 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3201
3202         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
3203         https://bugs.webkit.org/show_bug.cgi?id=208096
3204         <rdar://problem/59632008>
3205
3206         Reviewed by Alexey Proskuryakov.
3207
3208         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
3209         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
3210         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
3211
3212         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
3213         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
3214         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
3215         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
3216         in the credit card expiry field.
3217
3218         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
3219
3220         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3221         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3222         (WTR::UIScriptController::setDefaultCalendarType):
3223         * WebKitTestRunner/TestController.h:
3224
3225         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
3226         identifier and calendar locale identifier.
3227
3228         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3229         (WTR::swizzledCalendar):
3230         (WTR::TestController::overriddenCalendarIdentifier const):
3231         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
3232
3233         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
3234
3235         (WTR::TestController::setDefaultCalendarType):
3236
3237         Plumb the new calendar's locale identifier through this method.
3238
3239         (WTR::TestController::cocoaResetStateToConsistentValues):
3240         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
3241         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
3242         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
3243         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
3244
3245 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
3246
3247         App-bound domains should have separate Network Sessions
3248         https://bugs.webkit.org/show_bug.cgi?id=208026
3249         <rdar://problem/59434006>
3250
3251         Reviewed by Brent Fulgham.
3252
3253         This patch is mostly test infrastructure involving 3 functions.
3254         One sets in-app browser privacy as enabled in the network process
3255         manually for the test. One ensures that setting the WebView category
3256         works properly, and the last one checks for an app-bound session for
3257         an app-bound navigation.
3258
3259         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3260         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3261         (WTR::InjectedBundle::didReceiveMessageToPage):
3262         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3263         (WTR::TestRunner::getWebViewCategory):
3264         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
3265         (WTR::TestRunner::hasAppBoundSession):
3266         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
3267         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
3268         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3269         * WebKitTestRunner/TestController.cpp:
3270         (WTR::TestController::ensureViewSupportsOptionsForTest):
3271         Clearing the bundleID should happen right before setting a new one, 
3272         otherwise it clears the ID after it is set and returns a null ID.
3273
3274         (WTR::TestController::resetStateToConsistentValues):
3275         (WTR::TestController::getWebViewCategory):
3276         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
3277         (WTR::inAppBrowserPrivacyBooleanResultCallback):
3278         (WTR::inAppBrowserPrivacyVoidResultCallback):
3279         (WTR::TestController::hasAppBoundSession):
3280         (WTR::TestController::setInAppBrowserPrivacyEnabled):
3281         * WebKitTestRunner/TestController.h:
3282         * WebKitTestRunner/TestInvocation.cpp:
3283         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3284         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3285         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
3286         (WTR::TestInvocation::didReceivePrevalentDomains):
3287         (WTR::TestInvocation::didReceiveWebViewCategory):
3288         * WebKitTestRunner/TestInvocation.h:
3289         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3290         (WTR::TestController::getWebViewCategory):
3291
3292 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
3293
3294         Build DumpRenderTree and WebKitTestRunner for macCatalyst
3295         https://bugs.webkit.org/show_bug.cgi?id=208068
3296         <rdar://problem/59676596>
3297
3298         Reviewed by Tim Horton.
3299
3300         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
3301         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3302         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
3303         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
3304         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
3305         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
3306         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
3307         * DumpRenderTree/mac/EventSendingController.h: Ditto.
3308         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
3309         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
3310         * Makefile: Add DumpRenderTree and WebKitTestRunner.
3311         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3312         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
3313         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
3314
3315 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3316
3317         [ews] Add build step to Validate ChangeLog for commit-queue
3318         https://bugs.webkit.org/show_bug.cgi?id=208064
3319
3320         Reviewed by Jonathan Bedard.
3321
3322         * BuildSlaveSupport/ews-build/steps.py:
3323         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
3324         (ValidateChangeLogAndReviewer.start):
3325         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
3326         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
3327
3328 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3329
3330         [ews] Add build step to set cq- flag on bugzilla patch
3331         https://bugs.webkit.org/show_bug.cgi?id=208021
3332
3333         Reviewed by Jonathan Bedard.
3334
3335         * BuildSlaveSupport/ews-build/steps.py:
3336         (BugzillaMixin.set_cq_minus_flag_on_patch):
3337         (SetCommitQueueMinusFlagOnPatch):
3338         (SetCommitQueueMinusFlagOnPatch.start):
3339         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
3340
3341 2020-02-20  Matt Lewis  <jlewis3@apple.com>
3342
3343         Stub repositories fail to upload some results due to missing head svn revision
3344         https://bugs.webkit.org/show_bug.cgi?id=207684
3345
3346         Reviewed by Jonathan Bedard.
3347
3348         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
3349         (MockHost.__init__):
3350         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3351         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
3352         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3353         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
3354         * Scripts/webkitpy/port/base.py:
3355         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
3356         from using mock SCMs and more
3357         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
3358
3359 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
3360
3361         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
3362         https://bugs.webkit.org/show_bug.cgi?id=208051
3363
3364         Reviewed by Carlos Alberto Lopez Perez.
3365
3366         Verbose flag prints out each test name executed. Without this flag
3367         stdout prints out one or two periods.
3368
3369         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3370         (RunJavaScriptCoreTests.start):
3371
3372 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
3373
3374         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
3375         https://bugs.webkit.org/show_bug.cgi?id=207984
3376
3377         Reviewed by Daniel Bates.
3378
3379         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3380         (TestWebKitAPI::TEST):
3381
3382 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
3383
3384         [GTK] Improve user agent quirk for Google Docs and Google Drive
3385         https://bugs.webkit.org/show_bug.cgi?id=206506
3386
3387         Reviewed by Carlos Garcia Campos.
3388
3389         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3390         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3391         (TestWebKitAPI::TEST):
3392
3393 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3394
3395         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
3396         https://bugs.webkit.org/show_bug.cgi?id=207380
3397
3398         Reviewed by Jonathan Bedard.
3399
3400         Added a new rule 'build/export_macro'.
3401
3402         Removed a obsolete rule 'readability/webkit_export' which was used
3403         only by Chromium port (r148185).
3404
3405         * Scripts/webkitpy/style/checkers/cpp.py:
3406         (_FunctionState.export_macro):
3407         (check_function_definition):
3408         (_unix_path): Added.
3409         (is_generated_file): Use _unix_path.
3410         (check_has_config_header): Ditto.
3411         (CppChecker):
3412         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3413         (WebKitStyleTest.test_export_macro_check):
3414         (WebKitStyleTest.test_webkit_export_check): Deleted.
3415
3416 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3417
3418         [Win][MiniBrowser] Add prettier toolbar button icons
3419         https://bugs.webkit.org/show_bug.cgi?id=207999
3420
3421         Reviewed by Ross Kirsling.
3422
3423         Use a custom toolbar button icons instead of system stock icons.
3424
3425         Fixed a bug toolbar button dropdown arrows always looked being
3426         hovered. TBSTYLE_FLAT should be given.
3427
3428         Removed the window border line of Progress Indicator.
3429
3430         * MiniBrowser/win/MainWindow.cpp:
3431         (MainWindow::createToolbar):
3432         * MiniBrowser/win/MiniBrowserLib.rc:
3433         * MiniBrowser/win/MiniBrowserLibResource.h:
3434         * MiniBrowser/win/toolbar.bmp: Added.
3435
3436 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
3437
3438         Update run-webkit-tests help description for skip-failing-tests
3439         https://bugs.webkit.org/show_bug.cgi?id=208031
3440
3441         Reviewed by Alexey Proskuryakov.
3442
3443         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3444
3445 2020-02-20  Chris Dumez  <cdumez@apple.com>
3446
3447         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
3448         https://bugs.webkit.org/show_bug.cgi?id=208015
3449         <rdar://problem/59591630>
3450
3451         Reviewed by Geoffrey Garen.
3452
3453         Add API test coverage.
3454
3455         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3456         (TEST):
3457
3458 2020-02-20  Tim Horton  <timothy_horton@apple.com>
3459
3460         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
3461         https://bugs.webkit.org/show_bug.cgi?id=207998
3462         <rdar://problem/40942425>
3463
3464         Reviewed by Sam Weinig.
3465
3466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3467         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
3468         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3469         (TestWebKitAPI::TEST):
3470         Add some tests for top content insets.
3471
3472 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
3473
3474         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
3475         https://bugs.webkit.org/show_bug.cgi?id=207910
3476
3477         Unreviewed infrastructure fix.
3478
3479         * Scripts/run-javascriptcore-tests:
3480         (configurationForUpload): Use the major version instead of the sub-minor version
3481         for version name.
3482
3483 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
3484
3485         [CMake] Add WPE::libwpe target
3486         https://bugs.webkit.org/show_bug.cgi?id=207970
3487
3488         Reviewed by Adrian Perez de Castro.
3489
3490         Use the WPE::libwpe target.
3491
3492         * MiniBrowser/wpe/CMakeLists.txt:
3493         * TestWebKitAPI/PlatformWPE.cmake:
3494         * TestWebKitAPI/glib/PlatformWPE.cmake:
3495         * wpe/backends/CMakeLists.txt:
3496
3497 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3498
3499         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
3500         https://bugs.webkit.org/show_bug.cgi?id=207749
3501
3502         Reviewed by Ross Kirsling.
3503
3504         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
3505
3506         * MiniBrowser/win/MainWindow.cpp:
3507         (MainWindow::createToolbar):
3508         (MainWindow::WndProc):
3509         (MainWindow::setDefaultURLToCurrentURL):
3510         (MainWindow::goHome): Added.
3511         (MainWindow::onURLBarEnter):
3512         * MiniBrowser/win/MainWindow.h:
3513         * MiniBrowser/win/MiniBrowserLib.rc:
3514         * MiniBrowser/win/MiniBrowserLibResource.h:
3515         * MiniBrowser/win/MiniBrowserReplace.h:
3516         * MiniBrowser/win/WinMain.cpp:
3517         (wWinMain):
3518
3519 2020-02-19  Peng Liu  <peng.liu6@apple.com>
3520
3521         Fix check-webkit-style errors related to AVFoundationSPI.h
3522         https://bugs.webkit.org/show_bug.cgi?id=207834
3523
3524         Reviewed by Daniel Bates.
3525
3526         Revert the change in r256770 regarding the headers ordering.
3527         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
3528
3529         * Scripts/webkitpy/style/checkers/cpp.py:
3530         (check_include_line):
3531
3532 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
3533
3534         results.webkit.org: Correctly report JSC tests for windows
3535         https://bugs.webkit.org/show_bug.cgi?id=207910
3536
3537         Rubber-stamped by Aakash Jain.
3538
3539         * Scripts/run-javascriptcore-tests:
3540         (configurationForUpload): Give Windows a version name.
3541         * Scripts/webkitdirs.pm:
3542         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
3543         Version dictionary.
3544
3545 2020-02-19  Chris Dumez  <cdumez@apple.com>
3546
3547         Unreviewed, fix assertions in storage access API layout tests after r256882.
3548
3549         Drop dead testRunner code to toggle storage access API feature.
3550
3551         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3552         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3553         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
3554         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3555         * WebKitTestRunner/TestInvocation.cpp:
3556         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3557
3558 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
3559
3560         [WPE] Support 2D axis, smooth-motion events
3561         https://bugs.webkit.org/show_bug.cgi?id=207881
3562
3563         Reviewed by Carlos Garcia Campos.
3564
3565         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
3566
3567 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
3568
3569         Unreviewed, rolling out r256851.
3570
3571         Broke internal bots
3572
3573         Reverted changeset:
3574
3575         "Stub repositories fail to upload some results due to missing
3576         head svn revision"
3577         https://bugs.webkit.org/show_bug.cgi?id=207684
3578         https://trac.webkit.org/changeset/256851
3579
3580 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
3581
3582         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
3583         https://bugs.webkit.org/show_bug.cgi?id=207883
3584
3585         Reviewed by Ross Kirsling.
3586
3587         Unlike other mouse buttons, 4th and 5th mouse buttons are
3588         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
3589         WM_XBUTTONUP events to the window under the mouse cursor.
3590         Unhandled WM_XBUTTONUP events are automatically converted to
3591         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
3592         parent window.
3593         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
3594
3595         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
3596         handled.
3597
3598         * MiniBrowser/win/BrowserWindow.h:
3599         * MiniBrowser/win/MainWindow.cpp:
3600         (MainWindow::WndProc):
3601         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3602         (WebKitBrowserWindow::navigateForwardOrBackward):
3603         * MiniBrowser/win/WebKitBrowserWindow.h:
3604         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3605         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
3606         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3607
3608 2020-02-18  Alex Christensen  <achristensen@webkit.org>
3609
3610         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
3611         https://bugs.webkit.org/show_bug.cgi?id=207912
3612         <rdar://problem/59556922>
3613
3614         Reviewed by Brian Weinstein.
3615
3616         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3617         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3618         (TEST):
3619         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3620         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
3621
3622 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3623
3624         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
3625         https://bugs.webkit.org/show_bug.cgi?id=207899
3626         <rdar://problem/55658207>
3627
3628         Reviewed by Tim Horton and Simon Fraser.
3629
3630         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
3631
3632         * WebKitTestRunner/TestController.cpp:
3633         (WTR::updateTestOptionsFromTestHeader):
3634         * WebKitTestRunner/TestOptions.h:
3635         (WTR::TestOptions::hasSameInitializationOptions const):
3636         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3637         (WTR::TestController::platformCreateWebView):
3638
3639 2020-02-18  Matt Lewis  <jlewis3@apple.com>
3640
3641         Stub repositories fail to upload some results due to missing head svn revision
3642         https://bugs.webkit.org/show_bug.cgi?id=207684
3643
3644         Reviewed by Jonathan Bedard.
3645
3646