Tools/ChangeLog

   1 2016-01-27  Jason Marcell  <jmarcell@apple.com>
   2
   3         Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
   4         https://bugs.webkit.org/show_bug.cgi?id=153332
   5
   6         Reviewed by Alexey Proskuryakov.
   7
   8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
   9         (Trac.prototype._xmlTimelineURL): Uses new function.
  10         (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
  11         logic for parsing git hashes.
  12         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
  13         Trac._parseRevisionFromURL.
  14
  15 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
  16
  17         Remove Mavericks from the flakiness dashboard
  18         https://bugs.webkit.org/show_bug.cgi?id=153521
  19
  20         Reviewed by Dan Bernstein.
  21
  22         * TestResultServer/static-dashboards/builders.jsonp:
  23         * TestResultServer/static-dashboards/flakiness_dashboard.js:
  24
  25 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
  26
  27         Remove ENABLE_CURRENTSRC
  28         https://bugs.webkit.org/show_bug.cgi?id=153545
  29
  30         Reviewed by Simon Fraser.
  31
  32         * Scripts/webkitperl/FeatureList.pm:
  33
  34 2016-01-26  Jason Marcell  <jmarcell@apple.com>
  35
  36         Sort incoming commits via date instead of revision number.
  37         https://bugs.webkit.org/show_bug.cgi?id=153467
  38
  39         Reviewed by Alexey Proskuryakov.
  40
  41         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
  42         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
  43
  44         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
  45         (Trac.prototype._loaded): Sort via date instead of revision number.
  46         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
  47         (MockTrac): Fix up the mock data to look more like real-world data.
  48         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
  49         Fake RSS feed that adds three more commits.
  50         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
  51         Trac._loaded().
  52
  53 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
  54
  55         Add a test for WebKit::stringMatchesWildcardString.
  56         https://bugs.webkit.org/show_bug.cgi?id=153090
  57
  58         Reviewed by Darin Adler.
  59
  60         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  61         Add the file to the project.
  62
  63         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
  64         (TestWebKitAPI::TEST):
  65         Test that a string matches another string that may contain wildcard characters.
  66
  67 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
  68
  69         [webkitdirs] Removed check for bison, gperf, and flex.
  70         https://bugs.webkit.org/show_bug.cgi?id=153496
  71
  72         Reviewed by Alex Christensen.
  73
  74         This prerequisites are checked in WebKitCommon.cmake and don't
  75         have to be in $PATH.
  76
  77         * Scripts/webkitdirs.pm:
  78         (checkRequiredSystemConfig):
  79
  80 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
  81
  82         [webkitdirs] isCMakeBuild should be true by default
  83         https://bugs.webkit.org/show_bug.cgi?id=153497
  84
  85         Reviewed by Michael Catanzaro.
  86
  87         * Scripts/webkitdirs.pm:
  88         (isCMakeBuild):
  89
  90 2016-01-26  Daniel Bates  <dabates@apple.com>
  91
  92         Add WebKitSystemInterface for iOS 9.2
  93         https://bugs.webkit.org/show_bug.cgi?id=153355
  94
  95         Rubber-stamped by David Kilzer.
  96
  97         * Scripts/copy-webkitlibraries-to-product-directory:
  98
  99 2016-01-26  Daniel Bates  <dabates@apple.com>
 100
 101         WebKitTestRunner: Credential cache is not cleared between tests
 102         https://bugs.webkit.org/show_bug.cgi?id=153407
 103         <rdar://problem/24280834>
 104
 105         Reviewed by Alexey Proskuryakov.
 106
 107         * WebKitTestRunner/TestController.cpp:
 108         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
 109         to clear cached credentials.
 110
 111 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 112
 113         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
 114         https://bugs.webkit.org/show_bug.cgi?id=153483
 115
 116         Reviewed by Csaba Osztrogonác.
 117
 118         * BuildSlaveSupport/kill-old-processes:
 119         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
 120
 121 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
 122
 123         Give the layout test results file a <title> showing the date and time the tests were run
 124         https://bugs.webkit.org/show_bug.cgi?id=153187
 125
 126         Reviewed by Darin Adler.
 127
 128         Include a 'date' property in the JSON with the date and time the tests completed.
 129
 130         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
 131         (summarize_results):
 132
 133 2016-01-25  Commit Queue  <commit-queue@webkit.org>
 134
 135         Unreviewed, rolling out r195543.
 136         https://bugs.webkit.org/show_bug.cgi?id=153451
 137
 138         regressed performance of test bots by ~6% (Requested by dydz
 139         on #webkit).
 140
 141         Reverted changeset:
 142
 143         "WebKitTestRunner: Credential cache is not cleared between
 144         tests"
 145         https://bugs.webkit.org/show_bug.cgi?id=153407
 146         http://trac.webkit.org/changeset/195543
 147
 148 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
 149
 150         Failing to upload to flakiness dashboard should not be a hard error
 151         https://bugs.webkit.org/show_bug.cgi?id=153444
 152         <rdar://problem/22146294>
 153
 154         Reviewed by Alexey Proskuryakov.
 155
 156         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 157         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
 158
 159 2016-01-25  Daniel Bates  <dabates@apple.com>
 160
 161         WebKitTestRunner: Credential cache is not cleared between tests
 162         https://bugs.webkit.org/show_bug.cgi?id=153407
 163         <rdar://problem/24280834>
 164
 165         Reviewed by Brady Eidson.
 166
 167         * WebKitTestRunner/TestController.cpp:
 168         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
 169         to clear cached credentials.
 170
 171 2016-01-24  Dan Bernstein  <mitz@apple.com>
 172
 173         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
 174
 175         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
 176
 177 2016-01-22  Enrica Casucci  <enrica@apple.com>
 178
 179         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
 180
 181         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 182         (WTR::TestController::platformCreateWebView):
 183
 184 2016-01-22  Tim Horton  <timothy_horton@apple.com>
 185
 186         Add a test for iOS arrow-key repeat
 187         https://bugs.webkit.org/show_bug.cgi?id=152857
 188         <rdar://problem/24017380>
 189
 190         Reviewed by Darin Adler.
 191
 192         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
 193         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
 194         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
 195         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
 196         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
 197         * WebKitTestRunner/ios/HIDEventGenerator.h:
 198         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 199         (-[HIDEventGenerator keyPress:completionBlock:]):
 200         (-[HIDEventGenerator keyDown:completionBlock:]):
 201         (-[HIDEventGenerator keyUp:completionBlock:]):
 202         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 203         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
 204         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
 205         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
 206         Make it possible to independently send keyUp/keyDown, instead of just paired.
 207
 208 2016-01-22  Tim Horton  <timothy_horton@apple.com>
 209
 210         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
 211         https://bugs.webkit.org/show_bug.cgi?id=153193
 212         <rdar://problem/24222034>
 213
 214         Reviewed by Darin Adler.
 215
 216         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
 217         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
 218         (TEST):
 219         Add a test that exhibits the problems we're fixing here.
 220         Before, it would both log and assert in debug, and crash in release.
 221         Now it runs happily to completion.
 222
 223 2016-01-22  Enrica Casucci  <enrica@apple.com>
 224
 225         Add support for testing data detection.
 226         https://bugs.webkit.org/show_bug.cgi?id=153360
 227
 228         Reviewed by Tim Horton.
 229
 230         Adding a new testing option (useDataDetection) to turn on
 231         data detection when running the a test.
 232
 233         * WebKitTestRunner/TestController.cpp:
 234         (WTR::updateTestOptionsFromTestHeader):
 235         * WebKitTestRunner/TestOptions.h:
 236         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 237         (WTR::TestController::platformCreateWebView):
 238
 239 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
 240
 241         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
 242         https://bugs.webkit.org/show_bug.cgi?id=153334
 243
 244         Reviewed by Zalan Bujtas.
 245
 246         Evaluating expressions in the LayoutUnit summary provider seems to cause
 247         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
 248         denominator to 64.
 249
 250         * lldb/lldb_webkit.py:
 251         (WebCoreLayoutUnitProvider.to_string):
 252
 253 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
 254
 255         display-profiler-output should be able to display code blocks sorted by machine counts
 256         https://bugs.webkit.org/show_bug.cgi?id=153298
 257
 258         Reviewed by Oliver Hunt.
 259
 260         * Scripts/display-profiler-output:
 261
 262 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
 263
 264         Ensure to use compatible liborc version with wanted gstreamer version
 265         https://bugs.webkit.org/show_bug.cgi?id=153276
 266
 267         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
 268         The user may have a very recent liborc installed on his system.
 269
 270         Reviewed by Philippe Normand.
 271
 272         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
 273         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
 274
 275 2016-01-21  Nan Wang  <n_wang@apple.com>
 276
 277         AX: [IOS] Implement next/previous text marker functions using TextIterator
 278         https://bugs.webkit.org/show_bug.cgi?id=153292
 279         <rdar://problem/24268243>
 280
 281         Reviewed by Chris Fleizach.
 282
 283         Made text marker tests available on iOS.
 284
 285         * DumpRenderTree/AccessibilityTextMarker.h:
 286         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 287         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
 288         (AccessibilityTextMarker::AccessibilityTextMarker):
 289         (AccessibilityTextMarker::~AccessibilityTextMarker):
 290         (AccessibilityTextMarker::isEqual):
 291         (AccessibilityTextMarker::platformTextMarker):
 292         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
 293         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
 294         (AccessibilityTextMarkerRange::isEqual):
 295         (AccessibilityTextMarkerRange::platformTextMarkerRange):
 296         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
 297         (AccessibilityUIElement::pathDescription):
 298         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
 299         (AccessibilityUIElement::textMarkerRangeForElement):
 300         (AccessibilityUIElement::selectedTextMarkerRange):
 301         (AccessibilityUIElement::resetSelectedTextMarkerRange):
 302         (AccessibilityUIElement::textMarkerRangeLength):
 303         (AccessibilityUIElement::textMarkerRangeForMarkers):
 304         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
 305         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
 306         (AccessibilityUIElement::accessibilityElementForTextMarker):
 307         (AccessibilityUIElement::endTextMarkerForBounds):
 308         (AccessibilityUIElement::startTextMarkerForBounds):
 309         (AccessibilityUIElement::textMarkerForPoint):
 310         (AccessibilityUIElement::previousTextMarker):
 311         (AccessibilityUIElement::nextTextMarker):
 312         (AccessibilityUIElement::stringForTextMarkerRange):
 313         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
 314         (AccessibilityUIElement::indexForTextMarker):
 315         (AccessibilityUIElement::isTextMarkerValid):
 316         (AccessibilityUIElement::textMarkerForIndex):
 317         (AccessibilityUIElement::startTextMarker):
 318         (AccessibilityUIElement::endTextMarker):
 319         (AccessibilityUIElement::setSelectedVisibleTextRange):
 320         (AccessibilityUIElement::getLinkedUIElements):
 321         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
 322         (AccessibilityTextMarkerRange::platformTextMarkerRange):
 323         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 324         (AccessibilityUIElement::removeSelection):
 325         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
 326         (AccessibilityUIElement::setSelectedVisibleTextRange):
 327         (AccessibilityUIElement::supportedActions):
 328         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
 329         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
 330         (WTR::AccessibilityUIElement::textMarkerRangeLength):
 331         (WTR::AccessibilityUIElement::previousTextMarker):
 332         (WTR::AccessibilityUIElement::nextTextMarker):
 333         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
 334         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
 335         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
 336         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
 337         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
 338         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
 339         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
 340
 341 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
 342
 343         Unreviewed, revert accidental unreviewed commit.
 344
 345         * Scripts/display-profiler-output:
 346
 347 2016-01-20  Jason Marcell  <jmarcell@apple.com>
 348
 349         Refactor compareIterations to remove duplicate code.
 350         https://bugs.webkit.org/show_bug.cgi?id=152913
 351
 352         Reviewed by Daniel Bates.
 353
 354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
 355         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
 356         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
 357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
 358         the same behavior before and after refactor.
 359
 360 2016-01-20  Dana Burkart  <dburkart@apple.com>
 361
 362         Botwatcher's dashboard should show an 'X' when the build is broken
 363         https://bugs.webkit.org/show_bug.cgi?id=152507
 364
 365         Reviewed by David Kilzer.
 366
 367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
 368         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
 369         (BuildbotStaticAnalyzerQueueView.prototype.update):
 370
 371 2016-01-19  Jason Marcell  <jmarcell@apple.com>
 372
 373         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
 374         https://bugs.webkit.org/show_bug.cgi?id=153262
 375
 376         Reviewed by Alexey Proskuryakov.
 377
 378         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
 379         such cases this revisionContentForIteration method does not have any content to return, thus the
 380         assertion fails.
 381
 382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
 383         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
 384
 385 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
 386
 387         [GTK] Runtime critical warnings when loading a URL after a session restore
 388         https://bugs.webkit.org/show_bug.cgi?id=153233
 389
 390         Reviewed by Michael Catanzaro.
 391
 392         Add new test case.
 393
 394         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
 395         (viewLoadChanged):
 396         (testWebKitWebViewNavigationAfterSessionRestore):
 397         (beforeAll):
 398
 399 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
 400
 401         [GTK] Remove jhbuild-optional.modules
 402         https://bugs.webkit.org/show_bug.cgi?id=152964
 403
 404         Reviewed by Alex Christensen.
 405
 406         * gtk/jhbuild-optional.modules: Removed.
 407         * gtk/jhbuild.modules:
 408
 409 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
 410
 411         [GTK] Add support to load/save session in MiniBrowser
 412         https://bugs.webkit.org/show_bug.cgi?id=153201
 413
 414         Reviewed by Michael Catanzaro.
 415
 416         It makes it easier to test the new WebView session API.
 417
 418         * MiniBrowser/gtk/BrowserWindow.c:
 419         (browserWindowFinalize): Free the session file path.
 420         (browserWindowSaveSession): Save the current WebView session if
 421         there's a session file path.
 422         (browserWindowDeleteEvent): Call browserWindowSaveSession().
 423         (browser_window_load_session): Try to load the session from the
 424         given file path, otherwise fall back to homepage and keep the
 425         session file to save the session on window close.
 426         * MiniBrowser/gtk/BrowserWindow.h:
 427         * MiniBrowser/gtk/main.c:
 428         (createBrowserWindow): Pass the given session file path when
 429         shouldLoadSession is TRUE.
 430         (main): Only allow to restore/save session when MiniBrowser is
 431         launched without URL arguments.
 432
 433 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
 434
 435         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
 436
 437         Geolocation is no longer allowed for unique origins after r195075.
 438
 439         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
 440         (testWebViewGeolocationPermissionRequests):
 441
 442 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 443
 444         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
 445         https://bugs.webkit.org/show_bug.cgi?id=153216
 446
 447         Reviewed by Michael Catanzaro.
 448
 449         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
 450         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
 451
 452 2016-01-18  Nan Wang  <n_wang@apple.com>
 453
 454         AX: [Mac] Implement next/previous text marker functions using TextIterator
 455         https://bugs.webkit.org/show_bug.cgi?id=152728
 456
 457         Reviewed by Chris Fleizach.
 458
 459         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 460         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
 461
 462 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
 463
 464         [cmake] Add testair to the build system
 465         https://bugs.webkit.org/show_bug.cgi?id=153126
 466
 467         Reviewed by Michael Catanzaro.
 468
 469         * Scripts/build-jsc:
 470
 471 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
 472
 473         Remove TextRun::allowsRoundingHacks()
 474         https://bugs.webkit.org/show_bug.cgi?id=153185
 475
 476         Reviewed by Simon Fraser.
 477
 478         * DumpRenderTree/mac/DumpRenderTree.mm:
 479         (resetWebViewToConsistentStateBeforeTesting): Deleted.
 480
 481 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
 482
 483         [webkitdirs] Avoid list form of open because it broke WinCairo
 484         https://bugs.webkit.org/show_bug.cgi?id=153106
 485
 486         Reviewed by Alex Christensen.
 487
 488         * Scripts/webkitdirs.pm:
 489         (determineArchitecture):
 490
 491 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
 492
 493         Add kdebug_trace signposts for a few WebCore operations
 494         https://bugs.webkit.org/show_bug.cgi?id=153136
 495         rdar://problem/24208487
 496
 497         Reviewed by Sam Weinig.
 498
 499         Plist used by kdebug_trace() viewing tools.
 500
 501         * Tracing/SystemTracePoints.plist: Added.
 502
 503 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
 504
 505         [webkitdirs] Replaced grep invocation with perl code
 506         https://bugs.webkit.org/show_bug.cgi?id=153106
 507
 508         Reviewed by Alex Christensen.
 509
 510         * Scripts/webkitdirs.pm:
 511         (determineArchitecture):
 512
 513 2016-01-14  Brian Burg  <bburg@apple.com>
 514
 515         prepare-changelog does not read paths containing spaces properly
 516         https://bugs.webkit.org/show_bug.cgi?id=137982
 517
 518         Reviewed by Joseph Pecoraro.
 519
 520         Escape whitespace in filenames before passing the file path to other functions.
 521
 522         * Scripts/prepare-ChangeLog:
 523         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
 524
 525 2016-01-14  Jason Marcell  <jmarcell@apple.com>
 526
 527         Standardize the usage of "branch" vs. "branchName".
 528         https://bugs.webkit.org/show_bug.cgi?id=152982
 529
 530         Reviewed by Daniel Bates.
 531
 532         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
 533         "branchName" implies that the variable or property in question is simply a string.
 534
 535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
 536         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
 537         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
 538         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
 539         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
 540         (Trac.prototype.commitsOnBranch): Change branch to branchName.
 541         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
 542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
 543         (MockTrac): Ditto.
 544
 545 2016-01-14  Jason Marcell  <jmarcell@apple.com>
 546
 547         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
 548         https://bugs.webkit.org/show_bug.cgi?id=152910
 549
 550         Reviewed by Daniel Bates.
 551
 552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
 553         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
 554         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
 555         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
 556         the need to talk to a real Buildbot server.
 557         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
 558         without the need to talk to a real Buildbot server.
 559         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
 560         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
 561         server.
 562         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
 563         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
 564         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
 565         trying to talk to Trac.
 566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
 567         QUnit unit tests.
 568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
 569
 570 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
 571
 572         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
 573         https://bugs.webkit.org/show_bug.cgi?id=132599
 574
 575         Reviewed by Michael Catanzaro.
 576
 577         Check if cmake Ninja generators are installed.
 578
 579         * Scripts/webkitdirs.pm:
 580         (canUseNinjaGenerator):
 581         (canUseEclipseNinjaGenerator):
 582         (generateBuildSystemFromCMakeProject):
 583         (canUseEclipse): Deleted.
 584
 585 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
 586
 587         [Cocoa] Testing with font family name "System Font" is unused
 588         https://bugs.webkit.org/show_bug.cgi?id=153073
 589         <rdar://problem/24091683>
 590
 591         Reviewed by Brent Fulgham.
 592
 593         * DumpRenderTree/mac/DumpRenderTree.mm:
 594         (allowedFontFamilySet): Deleted.
 595         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
 596         (WTR::allowedFontFamilySet): Deleted.
 597         * WebKitTestRunner/mac/TestControllerMac.mm:
 598         (WTR::allowedFontFamilySet): Deleted.
 599
 600 2016-01-13  Daniel Bates  <dabates@apple.com>
 601
 602         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
 603         https://bugs.webkit.org/show_bug.cgi?id=152871
 604
 605         Reviewed by Brent Fulgham.
 606
 607         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
 608         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
 609
 610         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
 611
 612 2016-01-08  Andy Estes  <aestes@apple.com>
 613
 614         [Content Filtering] Lazily load platform frameworks
 615         https://bugs.webkit.org/show_bug.cgi?id=152881
 616         rdar://problem/23270886
 617
 618         Reviewed by Brady Eidson.
 619
 620         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
 621         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
 622         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
 623         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
 624         is loaded after an HTTPS request.
 625
 626         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
 627         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
 628         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
 629         also re-enabled on iOS after mistakenly being disabled by r188892.
 630
 631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 632         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
 633         (TestWebKitAPI::TEST):
 634         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
 635         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
 636         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
 637         (TEST):
 638         (downloadTest):
 639         (-[LazilyLoadPlatformFrameworksController init]):
 640         (-[LazilyLoadPlatformFrameworksController webView]):
 641         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
 642         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
 643         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
 644         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
 645         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
 646         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
 647         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
 648         (TestWebKitAPI::TEST):
 649         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
 650         (TestWebKitAPI::TEST): Deleted.
 651         * TestWebKitAPI/cocoa/TestProtocol.h:
 652         * TestWebKitAPI/cocoa/TestProtocol.mm:
 653         (+[TestProtocol registerWithScheme:]):
 654         (+[TestProtocol unregister]):
 655
 656 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
 657
 658         Fix the Sunpider converage in slow device.
 659         https://bugs.webkit.org/show_bug.cgi?id=152938
 660         <rdar://problem/22511411>
 661
 662         Reviewed by Ryosuke Niwa.
 663
 664         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
 665
 666         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
 667
 668 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
 669
 670         Add a build flag for custom element
 671         https://bugs.webkit.org/show_bug.cgi?id=153005
 672
 673         Reviewed by Alex Christensen.
 674
 675         Added --custom-elements option to enable custom elements support.
 676
 677         * Scripts/webkitperl/FeatureList.pm:
 678
 679 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
 680
 681         [JSC] Add a help message when run-jsc-stress-tests fails
 682         https://bugs.webkit.org/show_bug.cgi?id=153014
 683
 684         Reviewed by Csaba Osztrogonác.
 685
 686         * Scripts/run-jsc-stress-tests:
 687
 688 2016-01-11  Saam barati  <sbarati@apple.com>
 689
 690         run-jsc-stress-tests should try to figure out a JSC path
 691         https://bugs.webkit.org/show_bug.cgi?id=152971
 692
 693         Reviewed by Yusuke Suzuki.
 694
 695         This patch now allows run-jsc-stress-tests to be run
 696         without a "--jsc <jsc-path>" argument. It tries
 697         to take its best guess at a <jsc-path> automagically.
 698
 699         This makes it much easier to just run run-jsc-stress-tests
 700         with a directory or a yaml file as an argument.
 701         You now just do this:
 702         `run-jsc-stress-tests <path-to-yaml>`
 703         or
 704         `run-jsc-stress-tests <path-to-directory-of-js-files>`
 705
 706         I wrote this patch because I'd often find myself hacking the
 707         run-javascriptcore-tests file just to run a particular subset of tests.
 708         Because I always forget the arguments to run-jsc-stress-tests (which means
 709         I always forgot to provide a --jsc argument), I always found it easier to
 710         just hack on that file instead of calling run-jsc-stress-tests directly.
 711         No longer is this true!
 712
 713         * Scripts/run-jsc-stress-tests:
 714
 715 2016-01-09  Andy Estes  <aestes@apple.com>
 716
 717         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
 718         https://bugs.webkit.org/show_bug.cgi?id=152950
 719         rdar://problem/24066652
 720
 721         Reviewed by Tim Horton.
 722
 723         Added an API test.
 724
 725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 726         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
 727         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
 728         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
 729         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
 730         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
 731         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
 732         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
 733         (TEST):
 734
 735 2016-01-11  Commit Queue  <commit-queue@webkit.org>
 736
 737         Unreviewed, rolling out r194866.
 738         https://bugs.webkit.org/show_bug.cgi?id=152986
 739
 740         This change broke the mac build (Requested by ryanhaddad on
 741         #webkit).
 742
 743         Reverted changeset:
 744
 745         "[Cocoa] Add SPI to opt out a URL scheme from the memory
 746         cache"
 747         https://bugs.webkit.org/show_bug.cgi?id=152950
 748         http://trac.webkit.org/changeset/194866
 749
 750 2016-01-11  Andy Estes  <aestes@apple.com>
 751
 752         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
 753         https://bugs.webkit.org/show_bug.cgi?id=152950
 754         rdar://problem/24066652
 755
 756         Reviewed by Tim Horton.
 757
 758         Added an API test.
 759
 760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 761         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
 762         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
 763         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
 764         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
 765         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
 766         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
 767         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
 768         (TEST):
 769
 770 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
 771
 772         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
 773         https://bugs.webkit.org/show_bug.cgi?id=152959
 774
 775         Reviewed by Brent Fulgham.
 776
 777         * Scripts/webkitdirs.pm:
 778         (determineArchitecture):
 779
 780 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
 781
 782         [GTK] W3C CSS2.1 anonymous table tests are failing
 783         https://bugs.webkit.org/show_bug.cgi?id=152455
 784
 785         Reviewed by Mario Sanchez Prada.
 786
 787         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
 788         tests. Add upstream patches to fix detection of XHTML files.
 789
 790         * gtk/jhbuild.modules:
 791         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
 792         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
 793
 794 2016-01-10  Saam barati  <sbarati@apple.com>
 795
 796         Implement a sampling profiler
 797         https://bugs.webkit.org/show_bug.cgi?id=151713
 798
 799         Reviewed by Filip Pizlo.
 800
 801         * Scripts/run-jsc-stress-tests:
 802
 803 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
 804
 805         [webkitdirs] Try arch and uname commands on non-windows OS
 806         https://bugs.webkit.org/show_bug.cgi?id=152958
 807
 808         Reviewed by Michael Catanzaro.
 809
 810         Right now, determineArchitecture()  uses `arch` and `uname -m`
 811         commands to determine architecture in case of condition (isGtk() ||
 812         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
 813         instead, because this code is applicable to any non-windows OS WebKit
 814         supports (even Haiku which once was supported is moderately
 815         POSIX-compliant and has uname command).
 816
 817         * Scripts/webkitdirs.pm:
 818         (determineArchitecture):
 819
 820 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
 821
 822         run-webkit-tests mis-counts totals when there are other crashes
 823         https://bugs.webkit.org/show_bug.cgi?id=152894
 824         <rdar://problem/24098697>
 825
 826         Reviewed by Alexey Proskuryakov.
 827
 828         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
 829         (TestRunResults.add): Do not update result counters for other crashes.
 830
 831 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 832
 833         webkit-patch build-and-test should have an option to iterate over new tests
 834         https://bugs.webkit.org/show_bug.cgi?id=143093
 835
 836         Reviewed by Michael Catanzaro.
 837
 838         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
 839         It allows running run-webkit-tests on modified or new paths in LayoutTests.
 840         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
 841         It implements the translation of -expected.* paths to their related tests.
 842         It also implements the removal of skipped tests.
 843
 844         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
 845         (LayoutTestFinder.find_touched_tests):
 846         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
 847         (MockPort):
 848         (MockPort.__init__):
 849         (MockPort.tests):
 850         (LayoutTestFinderTests):
 851         (LayoutTestFinderTests.touched_files):
 852         (LayoutTestFinderTests.test_touched_test):
 853         (LayoutTestFinderTests.test_expected_touched_test):
 854         (LayoutTestFinderTests.test_platform_expected_touched_test):
 855         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
 856         (LayoutTestFinderTests.test_touched_but_skipped_test):
 857         * Scripts/webkitpy/port/base.py:
 858         (Port.potential_test_names_from_expected_file):
 859         * Scripts/webkitpy/tool/commands/download_unittest.py:
 860         (DownloadCommandsTest._default_options):
 861         * Scripts/webkitpy/tool/steps/options.py:
 862         (Options):
 863         * Scripts/webkitpy/tool/steps/runtests.py:
 864         (RunTests.options):
 865         (RunTests.run):
 866         (RunTests):
 867         (RunTests._new_or_modified_tests):
 868         (RunTests._run_webkit_tests):
 869         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
 870         (RunTestsTest.test_webkit_run_unit_tests):
 871         * Scripts/webkitpy/tool/steps/steps_unittest.py:
 872         (StepsTest._step_options):
 873
 874 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
 875
 876         prepare-ChangeLog should include radar number
 877         https://bugs.webkit.org/show_bug.cgi?id=152839
 878         <rdar://problem/24093563>
 879
 880         Reviewed by Daniel Bates.
 881
 882         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
 883         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
 884         in the ChangeLog description after the bug URL.
 885
 886         * Scripts/prepare-ChangeLog:
 887         (main): Update signatures.
 888         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
 889         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
 890         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
 891         (generateNewChangeLogs): Include radar URL if we found one.
 892
 893         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
 894         Tests for the radar URL extraction.
 895
 896 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
 897
 898         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
 899         https://bugs.webkit.org/show_bug.cgi?id=152390
 900         <rdar://problem/23948321>
 901
 902         Reviewed by Simon Fraser.
 903
 904         Fix two use-after-frees.
 905
 906         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
 907         but we may have already progressed to another test by the time the callback fires,
 908         having destroyed the TestInvocation.
 909         2. UIScriptController is a RefCounted object, but it has a raw pointer to
 910         UIScriptContext which has the same lifetime as a TestInvocation.
 911         As a result, completion blocks of UIScriptController actions would use a destroyed
 912         TestInvocation.
 913
 914         * WebKitTestRunner/TestInvocation.cpp:
 915         (WTR::TestInvocation::~TestInvocation):
 916         (WTR::TestInvocation::url):
 917         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 918         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
 919         (WTR::TestInvocation::runUISideScript):
 920         * WebKitTestRunner/TestInvocation.h:
 921         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
 922         (UIScriptContext::UIScriptContext):
 923         (UIScriptContext::~UIScriptContext):
 924         (UIScriptContext::runUIScript):
 925         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
 926         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
 927         (WTR::UIScriptController::UIScriptController):
 928         (WTR::UIScriptController::contextDestroyed):
 929         (WTR::UIScriptController::makeWindowObject):
 930         (WTR::UIScriptController::setWillBeginZoomingCallback):
 931         (WTR::UIScriptController::willBeginZoomingCallback):
 932         (WTR::UIScriptController::setDidEndZoomingCallback):
 933         (WTR::UIScriptController::didEndZoomingCallback):
 934         (WTR::UIScriptController::setDidEndScrollingCallback):
 935         (WTR::UIScriptController::didEndScrollingCallback):
 936         (WTR::UIScriptController::setDidShowKeyboardCallback):
 937         (WTR::UIScriptController::didShowKeyboardCallback):
 938         (WTR::UIScriptController::setDidHideKeyboardCallback):
 939         (WTR::UIScriptController::didHideKeyboardCallback):
 940         (WTR::UIScriptController::uiScriptComplete):
 941         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
 942         (WTR::UIScriptController::create):
 943         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 944         (WTR::UIScriptController::doAsyncTask):
 945         (WTR::UIScriptController::zoomToScale):
 946         (WTR::UIScriptController::singleTapAtPoint):
 947         (WTR::UIScriptController::doubleTapAtPoint):
 948         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
 949         (WTR::UIScriptController::contentVisibleRect):
 950         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
 951         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
 952         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
 953         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
 954         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
 955         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
 956         (WTR::UIScriptController::doAsyncTask):
 957
 958 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 959
 960         [buildbot] clean-build script should remove untracked files and revert local changes too
 961         https://bugs.webkit.org/show_bug.cgi?id=142400
 962
 963         Reviewed by Ryosuke Niwa.
 964
 965         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
 966         A helper routine SCM.discard_untracked_files is added for that purpose.
 967
 968         * BuildSlaveSupport/clean-build:
 969         (main): Making call to Scripts/clean-webkit
 970         * Scripts/clean-webkit: Added.
 971         (main): Revert changes and delete untracked files.
 972         * Scripts/webkitpy/common/checkout/scm/scm.py:
 973         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
 974         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 975         (SCMTest._shared_test_discard_untracked_files):
 976         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
 977
 978 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
 979
 980         Add a setting and preferences to enable display-list drawing. Does nothing yet.
 981         https://bugs.webkit.org/show_bug.cgi?id=152807
 982
 983         Reviewed by Zalan Bujtas.
 984
 985         Add an item to the Settings menu to toggle display-list drawing.
 986
 987         * MiniBrowser/mac/SettingsController.h:
 988         * MiniBrowser/mac/SettingsController.m:
 989         (-[SettingsController _populateMenu]):
 990         (-[SettingsController validateMenuItem:]):
 991         (-[SettingsController toggleDisplayListDrawingEnabled:]):
 992         (-[SettingsController displayListDrawingEnabled]):
 993         * MiniBrowser/mac/WK2BrowserWindowController.m:
 994         (-[WK2BrowserWindowController didChangeSettings]):
 995
 996 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 997
 998         Python SCM should be able to retrieve untracked files - Add GIT support
 999         https://bugs.webkit.org/show_bug.cgi?id=143135
1000
1001         Reviewed by Michael Catanzaro.
1002
1003         * Scripts/webkitpy/common/checkout/scm/git.py:
1004         (Git.untracked_files): Adding support for git.
1005         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1006         (GitTest.setUp):
1007         (GitTest.test_untracked_files): Adding test.
1008
1009 2016-01-05  Mark Lam  <mark.lam@apple.com>
1010
1011         Rename badly named JSC_timeout env var to JSCTEST_timeout.
1012         https://bugs.webkit.org/show_bug.cgi?id=152748
1013
1014         Reviewed by Geoffrey Garen.
1015
1016         Now that we validate JSC options, the badly named JSC_timeout env var causes the
1017         bots to have a bad time.
1018
1019         * Scripts/run-javascriptcore-tests:
1020         * Scripts/run-jsc-stress-tests:
1021
1022 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1023
1024         [GTK] Allow to save and restore session
1025         https://bugs.webkit.org/show_bug.cgi?id=115600
1026
1027         Reviewed by Michael Catanzaro.
1028
1029         Add test case to check the new session API.
1030
1031         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1032         (testWebKitWebViewSessionState):
1033         (testWebKitWebViewSessionStateWithFormData):
1034         (beforeAll):
1035
1036 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
1037
1038         [EFL] Bump EFL version to 1.16.1
1039         https://bugs.webkit.org/show_bug.cgi?id=152688
1040
1041         Reviewed by Gyuyoung Kim.
1042
1043         * efl/jhbuild.modules:
1044
1045 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
1046
1047         error running layout tests on iOS simulator on latest build
1048         https://bugs.webkit.org/show_bug.cgi?id=152719
1049         <rdar://problem/24009549>
1050
1051         Reviewed by Alexey Proskuryakov.
1052
1053         * Scripts/webkitpy/xcode/simulator.py:
1054         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
1055           before running simctl spawn command.
1056
1057 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1058
1059         Unreviewed, move Frédéric Wang to committers list
1060
1061         He seems to be on the contributors list by accident. He has been landing his own commits for
1062         about two years now.
1063
1064         * Scripts/webkitpy/common/config/contributors.json:
1065
1066 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1067
1068         Unreviewed, move Sebastian Dröge to committers list harder
1069
1070         He accidentally added himself to the reviewers list because the file is confusing. Then I
1071         accidentially moved him to the contributors list because the file is confusing, even though
1072         I knew the contributors list existed in this file and was attempting to add him to the
1073         committers list. Really move him to the committers list now.
1074
1075         * Scripts/webkitpy/common/config/contributors.json:
1076
1077 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1078
1079         Python SCM should be able to retrieve untracked files - Add SVN support
1080         https://bugs.webkit.org/show_bug.cgi?id=152546
1081
1082         Reviewed by Michael Catanzaro.
1083
1084         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1085         (test_untracked_files): Activating test for SVN.
1086         * Scripts/webkitpy/common/checkout/scm/svn.py:
1087         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
1088
1089 2015-12-31  Andy Estes  <aestes@apple.com>
1090
1091         Replace WTF::move with WTFMove
1092         https://bugs.webkit.org/show_bug.cgi?id=152601
1093
1094         Reviewed by Brady Eidson.
1095
1096         * DumpRenderTree/TestRunner.h:
1097         (TestRunner::setAllowedHosts):
1098         * DumpRenderTree/win/DRTDataObject.cpp:
1099         (DRTDataObject::SetData):
1100         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1101         (TestWebKitAPI::TEST):
1102         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1103         (TestWebKitAPI::TEST):
1104         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1105         (TestWebKitAPI::TEST):
1106         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1107         (TestWebKitAPI::TEST):
1108         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1109         (TestWebKitAPI::passWithRef):
1110         (TestWebKitAPI::TEST):
1111         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1112         (TestWebKitAPI::TEST):
1113         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1114         (TestWebKitAPI::TEST):
1115         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1116         (TestWebKitAPI::TEST):
1117         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1118         (TestWebKitAPI::TEST):
1119         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1120         (TestWebKitAPI::createTestValue):
1121         (TestWebKitAPI::TEST):
1122         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1123         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1124         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1125         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1126         (TestWebKitAPI::createNFAs):
1127         (TestWebKitAPI::TEST_F):
1128         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
1129         (TestWebKitAPI::combine):
1130         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
1131         (TestWebKitAPI::createNFAs):
1132         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
1133         (TEST):
1134         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1135         (WebProcessTest::add):
1136
1137 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
1138
1139         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
1140         https://bugs.webkit.org/show_bug.cgi?id=152634
1141
1142         Reviewed by Carlos Garcia Campos.
1143
1144         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1145         (testLoadFromGResource): Added test.
1146         (beforeAll):
1147         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1148         (registerGResource): Added.
1149         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
1150         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
1151         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
1152
1153 2015-12-31  David Kilzer  <ddkilzer@apple.com>
1154
1155         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
1156         <https://bugs.webkit.org/show_bug.cgi?id=152601>
1157
1158         Ignore unknown pragmas on older clangs.  Fixes the following
1159         build failure:
1160
1161             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
1162             #pragma clang diagnostic ignored "-Wself-move"
1163                                              ^
1164             1 error generated.
1165
1166         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1167         (TestWebKitAPI::TEST):
1168         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1169         (TestWebKitAPI::TEST):
1170
1171 2015-12-31  Andy Estes  <aestes@apple.com>
1172
1173         Update the style checker to advise using WTFMove() instead of WTF::move()
1174         https://bugs.webkit.org/show_bug.cgi?id=152601
1175
1176         Reviewed by Daniel Bates.
1177
1178         * Scripts/webkitpy/style/checkers/cpp.py:
1179         (check_wtf_move):
1180         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1181         (WebKitStyleTest.test_wtf_move):
1182
1183 2015-12-31  Andy Estes  <aestes@apple.com>
1184
1185         Fix warnings uncovered by migrating to WTF_MOVE
1186         https://bugs.webkit.org/show_bug.cgi?id=152601
1187
1188         Reviewed by Daniel Bates.
1189
1190         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
1191         self-move, even if doing so would trigger a warning.
1192
1193         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1194         (TestWebKitAPI::TEST):
1195         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1196         (TestWebKitAPI::TEST):
1197
1198 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
1199
1200         [GTK] The install-dependencies script has a syntax error
1201         https://bugs.webkit.org/show_bug.cgi?id=152613
1202
1203         Reviewed by Michael Catanzaro.
1204
1205         * gtk/install-dependencies: Add the missing 'then.'
1206
1207 2015-12-30  Philippe Normand  <pnormand@igalia.com>
1208
1209         [Mac][GTK] Jhbuild support for OSX
1210         https://bugs.webkit.org/show_bug.cgi?id=150799
1211
1212         Reviewed by Michael Catanzaro.
1213
1214         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
1215         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
1216         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
1217         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
1218
1219 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1220
1221         Unreviewed, move Sebastian Dröge to committers list
1222
1223         He accidentally added himself to the reviewers list because the file is confusing.
1224
1225         * Scripts/webkitpy/common/config/contributors.json:
1226
1227 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
1228
1229         Remove the unused #define _USE_MATH_DEFINES
1230         https://bugs.webkit.org/show_bug.cgi?id=152034
1231
1232         Reviewed by Tim Horton.
1233
1234         Update this test to use piDouble from MathExtras.h, and
1235         std::numeric_limits<>.
1236
1237         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1238
1239 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1240
1241         Python SCM should be able to retrieve untracked files - Generic changes
1242         https://bugs.webkit.org/show_bug.cgi?id=152536
1243
1244         Reviewed by Brent Fulgham.
1245
1246         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1247         No support is yet added to GIT and SVN specific implementations.
1248
1249         * Scripts/webkitpy/common/checkout/scm/scm.py:
1250         (SCM.untracked_files):
1251         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1252         (SCMTest._shared_test_untracked_files):
1253
1254 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
1255
1256         SVN checkout used by RunBenchmark should be non-interactive
1257         https://bugs.webkit.org/show_bug.cgi?id=152542
1258
1259         Reviewed by Ryosuke Niwa.
1260
1261         RunBenchmark should not require user interaction while running.
1262
1263         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1264         (BenchmarkBuilder._checkout_with_subversion):
1265
1266 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1267
1268         Web Inspector: add support for running protocol-test.js tests on Windows
1269         https://bugs.webkit.org/show_bug.cgi?id=148037
1270         <rdar://problem/22292237>
1271
1272         Reviewed by Simon Fraser.
1273
1274         * DumpRenderTree/win/TestRunnerWin.cpp:
1275         (TestRunner::inspectorTestStubURL): Provide implementation.
1276
1277 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
1278
1279         [MediaStream] MediaDeviceInfo.label must be empty in some situations
1280         https://bugs.webkit.org/show_bug.cgi?id=152000
1281
1282         Reviewed by Brent Fulgham.
1283
1284         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1285         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1286         (WTR::InjectedBundle::setUserMediaPermission):
1287         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1288         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1289
1290         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1291         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1292         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1293
1294         * WebKitTestRunner/TestController.cpp:
1295         (WTR::TestController::setUserMediaPermissionForOrigin):
1296         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1297         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add
1298           persistent permission for origin, that can be done from script now.
1299         * WebKitTestRunner/TestController.h:
1300
1301         * WebKitTestRunner/TestInvocation.cpp:
1302         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1303           SetUserMediaPermissionForOrigin.
1304
1305 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1306
1307         [Win] Unreviewed build fix: Recognize Windows 10 variants.
1308
1309         * Scripts/webkitpy/common/system/platforminfo.py:
1310         (PlatformInfo._determine_win_version):
1311
1312 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1313
1314         Content blockers should be able to promote http to https
1315         https://bugs.webkit.org/show_bug.cgi?id=148966
1316
1317         Reviewed by Benjamin Poulain.
1318
1319         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1320         (WebCore::ContentExtensions::operator<<):
1321         (TestWebKitAPI::TEST_F):
1322
1323 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1324
1325         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1326         https://bugs.webkit.org/show_bug.cgi?id=152516
1327
1328         Reviewed by Gyuyoung Kim.
1329
1330         * MiniBrowser/efl/main.c:
1331
1332 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
1333
1334         Unreviewed: Add John Wilander as a contributor.
1335
1336         * Scripts/webkitpy/common/config/contributors.json:
1337
1338 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
1339
1340         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1341         https://bugs.webkit.org/show_bug.cgi?id=152482
1342
1343         Reviewed by Brent Fulgham.
1344
1345         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1346         for the same property. On WK2, the element returned will not be valid, but is still present and
1347         that can lead to looping.
1348
1349         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1350         (AccessibilityUIElement::horizontalScrollbar):
1351         (AccessibilityUIElement::verticalScrollbar):
1352         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1353         (WTR::AccessibilityUIElement::horizontalScrollbar):
1354         (WTR::AccessibilityUIElement::verticalScrollbar):
1355
1356 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1357
1358         Unreviewed.
1359
1360         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1361
1362 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1363
1364         [EFL] test_ewk2_context failed after r192808
1365         https://bugs.webkit.org/show_bug.cgi?id=151846
1366
1367         Reviewed by Gyuyoung Kim.
1368
1369         Used the added ewk_context_web_process_count_limit_set api
1370         instead of the deprecated ewk_context_process_model_set.
1371
1372         * MiniBrowser/efl/main.c:
1373         (elm_main):
1374
1375 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1376
1377         Unreviewed, move myself to reviewer list.
1378
1379         * Scripts/webkitpy/common/config/contributors.json:
1380
1381 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1382
1383         Unreviewed, add myself to the committers list.
1384
1385         * Scripts/webkitpy/common/config/contributors.json:
1386
1387 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1388
1389         [GTK] jquery.min.js violates DFSG
1390         https://bugs.webkit.org/show_bug.cgi?id=152428
1391
1392         Reviewed by Joseph Pecoraro.
1393
1394         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1395         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1396
1397         * gtk/manifest.txt.in:
1398
1399 2015-12-19  Dan Bernstein  <mitz@apple.com>
1400
1401         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1402         https://bugs.webkit.org/show_bug.cgi?id=152462
1403
1404         Reviewed by Alexey Proskuryakov.
1405
1406         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1407           OS X 10.9:
1408
1409         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1410         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1411         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1412         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1413         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1414
1415         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1416           never getting compiled:
1417
1418         * DumpRenderTree/mac/TextInputController.m:
1419         * MiniBrowser/mac/BrowserWindowController.m:
1420         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1421         * WebKitTestRunner/mac/EventSenderProxy.mm:
1422
1423 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1424
1425         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1426
1427         This is to make it easy to CC it on Bugzilla.
1428
1429         * Scripts/webkitpy/common/config/contributors.json:
1430
1431 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1432
1433         Pasteboard get messed up after running kill-old-processes
1434         https://bugs.webkit.org/show_bug.cgi?id=152426
1435
1436         Reviewed by Alexey Proskuryakov.
1437
1438         * BuildSlaveSupport/kill-old-processes:
1439         (main): Do not kill pasteboard anymore.
1440
1441 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1442
1443         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1444         https://bugs.webkit.org/show_bug.cgi?id=152157
1445         <rdar://problem/23851817>
1446
1447         Reviewed by Alexey Proskuryakov.
1448
1449         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1450         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1451         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1452         (Manager._get_test_inputs): Common method to calculate test_inputs.
1453         (Manager._update_worker_count): Calculate and update required number of workers.
1454
1455 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1456
1457         run-webkit-tests fails to delete Simulator device during cleanup
1458         https://bugs.webkit.org/show_bug.cgi?id=152363
1459
1460         Reviewed by Alexey Proskuryakov.
1461
1462         * Scripts/webkitpy/xcode/simulator.py:
1463         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1464
1465 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1466
1467         [mac-wk2] fast/events force click tests crashing
1468         https://bugs.webkit.org/show_bug.cgi?id=152339
1469
1470         Reviewed by Beth Dakin.
1471
1472         * WebKitTestRunner/mac/EventSenderProxy.mm:
1473         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1474         Set the NSEvent's _type member in addition to overriding -type,
1475         because there are assertions in touch event handling code that depend on it.
1476
1477 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1478
1479         Enforce temporarily bots to sync WebKit and WPT testharness.js
1480         https://bugs.webkit.org/show_bug.cgi?id=152334
1481
1482         Reviewed by Darin Adler.
1483
1484         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1485         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1486
1487 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1488
1489         [Fetch API] Add fetch API compile time flag
1490         https://bugs.webkit.org/show_bug.cgi?id=152254
1491
1492         Reviewed by Darin Adler.
1493
1494         * Scripts/webkitperl/FeatureList.pm:
1495
1496 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1497
1498         Unreviewed.
1499
1500         Added files that have impact in building Streams API to the watchlist.
1501
1502         * Scripts/webkitpy/common/config/watchlist:
1503
1504 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1505
1506         Unreviewed.
1507
1508         Added imported tests to Streams API watchlist.
1509
1510         * Scripts/webkitpy/common/config/watchlist:
1511
1512 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1513
1514         Remove default copy of wpt testharness.js when launching wpt server
1515         https://bugs.webkit.org/show_bug.cgi?id=152298
1516
1517         Reviewed by Darin Adler.
1518
1519         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1520         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1521
1522 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1523
1524         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1525         <http://webkit.org/b/152314>
1526
1527         Reviewed by Daniel Bates.
1528
1529         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1530         code path to exit immediately when calling main().
1531         Unfortunately, DumpRenderTreeMain.mm was used for both
1532         DumpRenderTree command-line binary and DumpRenderTree.app, which
1533         meant that the app would exit immediately with no error code
1534         when run!
1535
1536         The workaround is to introduce a separate source file called
1537         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1538         already does.
1539
1540         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1541         DumpRenderTreeAppMain.mm to the project.  Make it the only
1542         compiled source for the DumpRenderTree.app target.
1543         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1544         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1545         case someone tries mistakenly to use the app.
1546         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1547         Link to JavaScriptCore.framework on iOS for the assert.
1548         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1549         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1550         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1551         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1552         (main): Add assert for iOS so that a crash occurs if someone
1553         tries to run the wrong command.
1554
1555 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1556
1557         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1558         https://bugs.webkit.org/show_bug.cgi?id=152266
1559         <rdar://problem/22092676>
1560
1561         Reviewed by Simon Fraser.
1562
1563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1564         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1565         Add a test that crashed before this change, and doesn't crash after.
1566
1567 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1568
1569         AX: iOS: Text field variations do not have the correct traits
1570         https://bugs.webkit.org/show_bug.cgi?id=152237
1571
1572         Reviewed by Mario Sanchez Prada.
1573
1574         Add iOS calls for determing if an object is a search field or a text area.
1575
1576         * DumpRenderTree/AccessibilityUIElement.cpp:
1577         (getIsSearchFieldCallback):
1578         (getIsTextAreaCallback):
1579         (stringForSelectionCallback):
1580         (AccessibilityUIElement::getJSClass):
1581         * DumpRenderTree/AccessibilityUIElement.h:
1582         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1583         (AccessibilityUIElement::identifier):
1584         (AccessibilityUIElement::isTextArea):
1585         (AccessibilityUIElement::isSearchField):
1586         (AccessibilityUIElement::traits):
1587         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1588         (WTR::AccessibilityUIElement::scrollPageRight):
1589         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1590         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1591         (WTR::AccessibilityUIElement::isSearchField):
1592         (WTR::AccessibilityUIElement::isTextArea):
1593         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1594         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1595         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1596         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1597         (WTR::AccessibilityUIElement::isTextArea):
1598         (WTR::AccessibilityUIElement::isSearchField):
1599         (WTR::AccessibilityUIElement::rowCount):
1600
1601 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1602
1603         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1604         https://bugs.webkit.org/show_bug.cgi?id=152252
1605
1606         Reviewed by Sergio Villar Senin.
1607
1608         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1609         for building the JHBuild on Debian systems.
1610
1611 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1612
1613         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1614         https://bugs.webkit.org/show_bug.cgi?id=152156
1615
1616         Reviewed by Dan Bernstein.
1617
1618         Our frameworks should appropriately prefix all ObjC classes,
1619         not just external symbols.
1620
1621         * Scripts/check-for-inappropriate-objc-class-names:
1622         Remove the -g switch to check all ObjC class names.
1623
1624 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1625
1626         [MediaStream] Expose media capture devices persistent permissions to WebCore
1627         https://bugs.webkit.org/show_bug.cgi?id=152087
1628
1629         Add support for the new user media permission checker page UI client method.
1630
1631         Reviewed by Chris Dumez.
1632
1633         * WebKitTestRunner/TestController.cpp:
1634         (WTR::decidePolicyForUserMediaPermissionRequest):
1635         (WTR::checkUserMediaPermissionForOrigin):
1636         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1637         (WTR::TestController::createWebViewWithOptions): Ditto.
1638         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1639         (WTR::originUserVisibleName): New, create a string for the origin.
1640         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1641           according to the state of the origin permission map.
1642         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1643           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1644         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1645           origin permission map.
1646         * WebKitTestRunner/TestController.h:
1647
1648 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1649
1650         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1651         https://bugs.webkit.org/show_bug.cgi?id=152022
1652         rdar://problem/23763584
1653
1654         Reviewed by Darin Adler.
1655
1656         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1657         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1658         (WTR::InjectedBundlePage::willSendRequestForFrame):
1659         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1660         (WTR::TestRunner::setWillSendRequestReturnsNull):
1661         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1662         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1663         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1664         (WTR::TestRunner::willSendRequestHTTPBody):
1665         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1666
1667 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1668
1669         Remove additional simulator checks before running layout-tests
1670         https://bugs.webkit.org/show_bug.cgi?id=152146
1671
1672         Reviewed by Darin Adler.
1673
1674         * Scripts/webkitpy/port/ios.py:
1675         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1676         * Scripts/webkitpy/xcode/simulator.py:
1677         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1678         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1679
1680 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1681
1682         Run atleast one simulator even if max process limit is low
1683         https://bugs.webkit.org/show_bug.cgi?id=152081
1684         <rdar://problem/23819694>
1685
1686         Reviewed by Alexey Proskuryakov.
1687
1688 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1689
1690         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1691         https://bugs.webkit.org/show_bug.cgi?id=144262
1692
1693         Reviewed by Carlos Garcia Campos.
1694
1695         Added new unit test to check the additional scenarios we now
1696         handle for custom URI schemes.
1697
1698         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1699         (generateHTMLContent): New helper function to generate big enough content.
1700         (testWebContextURIScheme): New unit test.
1701
1702 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1703
1704         [EFL] Fix unhandled web process message when launching MiniBrowser
1705         https://bugs.webkit.org/show_bug.cgi?id=152048
1706
1707         Reviewed by Gyuyoung Kim.
1708
1709         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1710         (TestWebKitAPI::TEST):
1711
1712 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1713
1714         [GTK] Add API to handle beforeunload events
1715         https://bugs.webkit.org/show_bug.cgi?id=139090
1716
1717         Reviewed by Gustavo Noronha Silva.
1718
1719         * MiniBrowser/gtk/BrowserWindow.c:
1720         (browserWindowConstructed):
1721         (browserWindowDeleteEvent):
1722         (browser_window_class_init):
1723         Handle delete-event to prevent the window from being closed when
1724         the page has beforeunload handlers. Use
1725         webkit_web_view_try_close() when the window is requested to be
1726         closed.
1727         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1728         (testWebViewJavaScriptDialogs):
1729         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1730         script dialog type.
1731
1732 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1733
1734         Refactored initialization code in LoadTrackingTest.
1735
1736         Rubber-stamped by Carlos Garcia Campos.
1737
1738         Small refactoring to make sure that the state of a LoadTrackingTest
1739         gets properly reset before loading new web content.
1740
1741         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1742         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1743         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1744         functions and reset the remaining local variables.
1745         (LoadTrackingTest::loadURI): Call reset();
1746         (LoadTrackingTest::loadHtml): Ditto.
1747         (LoadTrackingTest::loadPlainText): Ditto.
1748         (LoadTrackingTest::loadBytes): Ditto.
1749         (LoadTrackingTest::loadRequest): Ditto.
1750         (LoadTrackingTest::reload): Ditto.
1751         (LoadTrackingTest::goBack): Ditto.
1752         (LoadTrackingTest::goForward): Ditto.
1753
1754 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1755
1756         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1757         https://bugs.webkit.org/show_bug.cgi?id=151942
1758
1759         Reviewed by Darin Adler.
1760
1761         * MiniBrowser/efl/main.c:
1762         (window_create): Enable offline web application cache feature on MiniBrowser.
1763         (elm_main):
1764
1765 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1766
1767         https://bugs.webkit.org/show_bug.cgi?id=151243
1768         <rdar://problem/22955197>
1769
1770         Reviewed by Alexey Proskuryakov.
1771
1772         * LayoutTestRelay/LayoutTestRelay/main.m:
1773         (getTestingSimDevice): Use separate testing device for each worker.
1774         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1775         (Manager.run): Perform cleanup even if setup fails.
1776         * Scripts/webkitpy/port/ios.py:
1777         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1778         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1779         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1780         (IOSSimulatorPort._quit_ios_simulator): Same
1781         (IOSSimulatorPort.clean_up_test_run): Same
1782         (IOSSimulatorPort.check_sys_deps): Same
1783         (IOSSimulatorPort.testing_device): Same
1784         (IOSSimulatorPort.reset_preferences): Same
1785         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1786         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1787         * Scripts/webkitpy/xcode/simulator.py:
1788         (Device.delete): Delete the simulator device.
1789         (Simulator.delete_device): Same
1790         (Simulator.wait_until_device_is_booted): Wait for device booting.
1791
1792 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1793
1794         [EFL] Add API to provide preferences before creating ewk_view
1795         https://bugs.webkit.org/show_bug.cgi?id=151587
1796
1797         Reviewed by Gyuyoung Kim.
1798
1799         * MiniBrowser/efl/main.c:
1800         (on_key_down):
1801         (quit):
1802         (window_create):
1803         Moved settings related code to configuration() not to update settings
1804         whenever ewk_view is created.
1805         (configuration):
1806         (elm_main):
1807
1808 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1809
1810         Unreviewed. Fix GTK+ API tests after r193639.
1811
1812         The new jhbuild version needs some more variables ot be present in
1813         the builtin dict, even if they are set to None.
1814
1815         * jhbuild/jhbuildutils.py:
1816         (enter_jhbuild_environment_if_available):
1817
1818 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1819
1820         [GTK] Notify WebCore when notification is clicked
1821         https://bugs.webkit.org/show_bug.cgi?id=151951
1822
1823         Reviewed by Carlos Garcia Campos.
1824
1825         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1826         (testWebViewNotification): test the new API.
1827
1828 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1829
1830         'jhbuild build' should fail immediately when building any module fails
1831         https://bugs.webkit.org/show_bug.cgi?id=145697
1832
1833         Reviewed by Carlos Garcia Campos.
1834
1835         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1836         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1837         Everything is placed under lib instead of lib64 now.
1838         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1839         --exit-on-error when running 'jhbuild build'.
1840         * jhbuild/jhbuildrc_common.py:
1841         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1842         jhbuild should be able to handle these for us without breaking things....
1843
1844 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1845
1846         Add support to import w3c tests from a repository with a different root that the main repo dir
1847         https://bugs.webkit.org/show_bug.cgi?id=151751
1848
1849         Reviewed by Ryosuke Niwa and Youenn Fablet.
1850
1851         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1852         in a different directory than the repository root.
1853
1854         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1855         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1856         requires having the copy_path lists including tuples of origin and destination directories.
1857
1858         * Scripts/webkitpy/w3c/test_downloader.py:
1859         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1860         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1861         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1862         (TestImporterTest.test_tests_directory): Test.
1863
1864 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1865
1866         Mock TestRepositories in W3C importer tests
1867         https://bugs.webkit.org/show_bug.cgi?id=151938
1868
1869         Reviewed by Youenn Fablet.
1870
1871         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1872         is because the test repository method reading the file was using the filesystem directly instead of taking the
1873         host one. This patch changes that.
1874
1875         * Scripts/webkitpy/w3c/test_downloader.py:
1876         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1877         default one.
1878         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1879         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1880         (TestImporterTest.test_harnesslinks_conversion):
1881         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1882
1883 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1884
1885         TestNetscapePlugIn: Address review comment on 193607
1886         <http://webkit.org/b/151881>
1887
1888         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1889         (testSetStatus): Initializing std::unique_ptr<char[]> with
1890         nullptr is redundant.
1891
1892 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1893
1894         [GTK] Add webkit_uri_request_get_http_method
1895         https://bugs.webkit.org/show_bug.cgi?id=151601
1896
1897         Reviewed by Martin Robinson.
1898
1899         Add test case to check HTTP method of WebKitURIRequest.
1900
1901         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1902         (testURIRequestHTTPMethod):
1903         (serverCallback):
1904         (beforeAll):
1905         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1906         (sendRequestCallback):
1907
1908 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1909
1910         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1911         https://bugs.webkit.org/show_bug.cgi?id=79918
1912
1913         Reviewed by Gustavo Noronha Silva.
1914
1915         Add unit tests to check the different console messages.
1916
1917         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1918         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1919         (ConsoleMessageTest::ConsoleMessage::operator==):
1920         (ConsoleMessageTest::consoleMessageReceivedCallback):
1921         (ConsoleMessageTest::ConsoleMessageTest):
1922         (ConsoleMessageTest::~ConsoleMessageTest):
1923         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1924         (testWebKitConsoleMessageConsoleAPI):
1925         (testWebKitConsoleMessageJavaScriptException):
1926         (testWebKitConsoleMessageNetworkError):
1927         (testWebKitConsoleMessageSecurityError):
1928         (beforeAll):
1929         (afterAll):
1930         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1931         (consoleMessageSentCallback):
1932         (pageCreatedCallback):
1933
1934 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1935
1936         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1937         https://bugs.webkit.org/show_bug.cgi?id=151934
1938
1939         Reviewed by Csaba Osztrogonác.
1940
1941         * MiniBrowser/efl/main.c:
1942         (on_window_deletion): Revert the changes of r192767.
1943
1944 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1945
1946         [GTK] update-webkitgtk-libs cannot build mesa
1947         https://bugs.webkit.org/show_bug.cgi?id=151535
1948
1949         Reviewed by Martin Robinson.
1950
1951         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1952         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1953         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1954         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1955         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1956         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1957
1958         * gtk/jhbuild.modules:
1959
1960 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1961
1962         [GTK][Mac] libWebExtensionTest link error
1963         https://bugs.webkit.org/show_bug.cgi?id=150802
1964
1965         Reviewed by Carlos Garcia Campos.
1966
1967         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1968
1969 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1970
1971         TestNetscapePlugIn: Fix leaks found by static analyzer
1972         <http://webkit.org/b/151881>
1973
1974         Reviewed by Darin Adler.
1975
1976         Fixes the following leaks found by the static analyzer:
1977             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1978                     return false;
1979                            ^~~~~
1980             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1981                     return false;
1982                            ^~~~~
1983             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1984                     return false;
1985                            ^~~~~
1986
1987         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1988         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1989         early return if allocation fails.
1990         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1991         Make sure to call fclose() on filehandle, even for an early
1992         return.
1993         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1994
1995 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1996
1997         prepare-ChangeLog: Fix some warning messages when using svn
1998         <http://webkit.org/b/151914>
1999
2000         Reviewed by Daniel Bates.
2001
2002         * Scripts/prepare-ChangeLog:
2003         (generateFunctionLists): Simplify logic so that we never call
2004         normalizePath() with an undefined value.
2005         (attributeCommand): Quote $subPath for the shell so that we
2006         don't try to run "svn propget" on invalid paths.
2007
2008 2015-12-04  David Kilzer  <ddkilzer@apple.com>
2009
2010         TestNetscapePlugIn: Fix remaining static analyzer warnings
2011         <http://webkit.org/b/151888>
2012
2013         Reviewed by Alexey Proskuryakov.
2014
2015         Fixes the following static analyzer warnings:
2016             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
2017                     CRASH();
2018                     ^~~~~~~
2019             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
2020                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
2021                 ^~~~~~~~~~~~~~~~
2022             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
2023                 return obj->pluginTest->NPP_SetWindow(window);
2024                        ^~~~~~~~~~~~~~~
2025             2 warnings generated.
2026
2027         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2028         (CRASH): Use __builtin_trap() for gcc/clang.
2029         (NPP_SetWindow): Add early return if obj is nullptr.
2030
2031 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2032
2033         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
2034         https://bugs.webkit.org/show_bug.cgi?id=151797
2035
2036         Reviewed by Martin Robinson.
2037
2038         Since we switched to use the network process to run the unit tests
2039         the test /webkit2/WebKitWebResource/get-data sometimes fails and
2040         sometimes passes. We are now also getting the notification for the
2041         css image. Since we wait for 3 resources, sometimes the css image
2042         is loaded before and then checkResourceData is called for it, but
2043         not handled. When the css image is the last one loaded the test
2044         passes. So, we just need to wait for the 4 resources.
2045
2046         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2047         (testWebResourceGetData):
2048
2049 2015-12-03  David Kilzer  <ddkilzer@apple.com>
2050
2051         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
2052         <http://webkit.org/b/151845>
2053
2054         Reviewed by Simon Fraser.
2055
2056         Fixes the following static analyzer warning:
2057             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
2058                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
2059                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2060
2061         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2062         (createBitmapContext): Free 'buffer' after using it in logging
2063         to fix the use-after-free.  Assign a value of nullptr to buffer
2064         so we don't return with it set to a freed address.
2065
2066 2015-12-03  Jer Noble  <jer.noble@apple.com>
2067
2068         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
2069         https://bugs.webkit.org/show_bug.cgi?id=151830
2070
2071         Reviewed by Anders Carlsson.
2072
2073         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
2074
2075         * DumpRenderTree/mac/DumpRenderTree.mm:
2076         (resetWebPreferencesToConsistentValues):
2077         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2078         (WTR::initializeWebViewConfiguration):
2079
2080 2015-12-03  Anders Carlsson  <andersca@apple.com>
2081
2082         Remove Objective-C GC support
2083         https://bugs.webkit.org/show_bug.cgi?id=151819
2084         rdar://problem/23746991
2085
2086         Reviewed by Dan Bernstein.
2087
2088         * asan/asan.xcconfig:
2089
2090 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2091
2092         Allow nil for unspecified benchmark pathes
2093         https://bugs.webkit.org/show_bug.cgi?id=151784
2094
2095         Reviewed by Filip Pizlo.
2096
2097         `Pathname.new(nil)` will raise an error.
2098         Only generate Pathname if the benchmark path is specified.
2099
2100         * Scripts/run-jsc-benchmarks:
2101
2102 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
2103
2104         [Win] Run non-http tests without Cygwin
2105         https://bugs.webkit.org/show_bug.cgi?id=151721
2106
2107         Reviewed by Andy Estes.
2108
2109         Support native 32-bit and 64-bit Python (and Perl) builds
2110         for running tests:
2111
2112         1. Use "startswith('win')", rather than "== 'win32'" to support
2113         various Windows build types.
2114         2. Supply full path for some native Windows utilities, since the
2115         path environment does not always have the specified, and they are
2116         guaranteed to exist in those specific locations.
2117         3. Make sure native Windows Python test runs pass proper environment
2118         variables to run programs.
2119         4. Append 'exe' suffix when running Windows executables.
2120         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
2121         command doesn't exist.
2122
2123         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
2124         the current Perl executable, rather than requiring a new path search.
2125         * Scripts/webkitpy/common/find_files_unittest.py:
2126         (TestWinNormalize.test_win): Use startswith('win').
2127         * Scripts/webkitpy/common/prettypatch_unittest.py:
2128         (test_pretty_diff_encodings): Ditto.
2129         * Scripts/webkitpy/common/system/executive.py:
2130         (Executive._should_close_fds): Ditto.
2131         (Executive.shell_command_for_script): Use startswith('win').
2132         (Executive.kill_process): Use full path to killall executable.
2133         (Executive.check_running_pid): Use startswith('win').
2134         (Executive.running_pids): Ditto.
2135         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
2136         running under native Windows Python.
2137         (Executive._child_process_encoding): Use startswith('win').
2138         (Executive._should_encode_child_process_arguments): Ditto.
2139         (Executive.popen): Recognize proper script engine on Windows, since it
2140         does not support the shebang syntax.
2141         (Executive.run_in_parallel): Use startswith('win').
2142         * Scripts/webkitpy/common/system/executive_unittest.py:
2143         (never_ending_command): Ditto.
2144         (ExecutiveTest.test_run_command_with_unicode): Ditto.
2145         (ExecutiveTest.serial_test_kill_process): Ditto.
2146         (ExecutiveTest.serial_test_kill_all): Ditto.
2147         (ExecutiveTest.serial_test_check_running_pid): Ditto.
2148         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
2149         (main): Ditto.
2150         * Scripts/webkitpy/common/system/file_lock.py:
2151         (FileLock._create_lock): Ditto.
2152         (FileLock._remove_lock): Ditto.
2153         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2154         (RealFileSystemTest.test_chdir): Ditto.
2155         (RealFileSystemTest.test_chdir__notexists): Ditto.
2156         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
2157         * Scripts/webkitpy/common/system/path_unittest.py:
2158         (AbspathTest.test_abspath_to_uri_win): Ditto.
2159         * Scripts/webkitpy/common/system/platforminfo.py:
2160         (PlatformInfo._determine_os_name): Ditto.
2161         * Scripts/webkitpy/common/system/user.py: Ditto.
2162         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2163         (ManagerTest.integration_test_needs_servers): Ditto.
2164         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2165         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
2166         driver letters.
2167         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
2168         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2169         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
2170         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2171         (HttpServerBase._check_that_all_ports_are_available): Ditto.
2172         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2173         (TestHttpServer.test_start_cmd): Ditto.
2174         * Scripts/webkitpy/port/base.py:
2175         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
2176         and 'SYSTEMROOT' in environment passed to test runners.
2177         (Port._apache_config_file_name_for_platform): Use startswith('win').
2178         (Port._build_path): Ditto.
2179         (Port._path_to_driver): Include 'exe' suffix when running under native
2180         Windows.
2181         * Scripts/webkitpy/port/driver.py:
2182         (Driver._setup_environ_for_driver): Explicitly make some environment
2183         variables strings.
2184         * Scripts/webkitpy/port/server_process.py:
2185         (ServerProcess.__init__): Use startswith('win').
2186         * Scripts/webkitpy/port/win.py:
2187         (WinPort): Use the win32 registry utilities on Windows, and appropriate
2188         registry key formats.
2189         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
2190         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
2191         and regtool on Cygwin.
2192         (WinPort.write_registry_value): Ditto.
2193         (WinPort.setup_crash_log_saving): Ditto.
2194         (WinPort.restore_crash_log_saving): Ditto.
2195         (WinPort.prevent_error_dialogs): Ditto.
2196         (WinPort.allow_error_dialogs): Ditto.
2197         (WinPort.find_system_pid): Revise to use Windows management
2198         infrastructure on native Windows, continue using 'ps' on Cygwin.
2199         (WinPort.read_registry_string): Deleted.
2200         (WinPort.write_registry_string): Deleted.
2201         * Scripts/webkitpy/test/main.py:
2202         (main): Use startswith('win').
2203         (Tester._parse_args): Ditto.
2204
2205 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2206
2207         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2208         https://bugs.webkit.org/show_bug.cgi?id=150792
2209
2210         Reviewed by Saam Barati.
2211
2212         * Scripts/webkitperl/FeatureList.pm:
2213
2214 2015-12-01  Commit Queue  <commit-queue@webkit.org>
2215
2216         Unreviewed, rolling out r192914.
2217         https://bugs.webkit.org/show_bug.cgi?id=151734
2218
2219         JSC tests for this change are failing on 32 and 64-bit bots
2220         (Requested by ryanhaddad on #webkit).
2221
2222         Reverted changeset:
2223
2224         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
2225         enable this feature"
2226         https://bugs.webkit.org/show_bug.cgi?id=150792
2227         http://trac.webkit.org/changeset/192914
2228
2229 2015-12-01  David Kilzer  <ddkilzer@apple.com>
2230
2231         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
2232         <http://webkit.org/b/151726>
2233
2234         Reviewed by Simon Fraser.
2235
2236         * WebKitTestRunner/mac/EventSenderProxy.mm:
2237         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2238         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
2239
2240 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
2241
2242         Give String and AtomicString an existingHash() function
2243         https://bugs.webkit.org/show_bug.cgi?id=151717
2244
2245         Reviewed by Andreas Kling.
2246
2247         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2248         (TestWebKitAPI::TEST):
2249         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2250         (TestWebKitAPI::TEST):
2251
2252 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2253
2254         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2255         https://bugs.webkit.org/show_bug.cgi?id=150792
2256
2257         Reviewed by Saam Barati.
2258
2259         * Scripts/webkitperl/FeatureList.pm:
2260
2261 2015-12-01  Sam Weinig  <sam@webkit.org>
2262
2263         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2264         <rdar://problem/23320863>
2265         https://bugs.webkit.org/show_bug.cgi?id=151708
2266
2267         Reviewed by Anders Carlsson.
2268
2269         * WebKitTestRunner/TestController.cpp:
2270         (WTR::TestController::createOtherPage):
2271         (WTR::TestController::createWebViewWithOptions):
2272         Update for new WKPageUIClient.
2273
2274 2015-12-01  Anders Carlsson  <andersca@apple.com>
2275
2276         Remove WebKit2.framework
2277         https://bugs.webkit.org/show_bug.cgi?id=151715
2278
2279         Reviewed by Dan Bernstein.
2280
2281         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2282         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2283         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2284         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2285         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2286         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2287         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2288
2289 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2290
2291         Unreviewed common typo fix "occurance" => "occurrence".
2292
2293         * Scripts/webkitpy/tool/commands/queries.py:
2294         (FindFlakyTests._print_statistics):
2295
2296 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2297
2298         Make ProcessModel always MultipleSecondaryProcesses
2299         https://bugs.webkit.org/show_bug.cgi?id=151662
2300
2301         Reviewed by Antti Koivisto.
2302
2303         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2304         (TestWebKitAPI::TEST):
2305         * WebKitTestRunner/TestController.cpp:
2306         (WTR::TestController::generatePageConfiguration):
2307
2308 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2309
2310         Make usesNetworkProcess always true
2311         https://bugs.webkit.org/show_bug.cgi?id=151580
2312
2313         Reviewed by Darin Adler.
2314
2315         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2316         (TestWebKitAPI::TEST):
2317         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2318         (TestWebKitAPI::TEST):
2319         * WebKitTestRunner/TestController.cpp:
2320         (WTR::TestController::generatePageConfiguration):
2321
2322 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2323
2324         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2325
2326         Add a way to skip unit tests only for Debug or Release builds and
2327         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2328
2329         * Scripts/run-gtk-tests:
2330         (SkippedTest):
2331         (SkippedTest.__init__):
2332         (SkippedTest.__str__):
2333         (SkippedTest.skip_entire_suite):
2334         (SkippedTest.skip_for_build_type):
2335         (TestRunner):
2336         (TestRunner.__init__):
2337
2338 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2339
2340         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2341
2342         It's an assert hit because we are reloading a view loaded with
2343         HTML data which is not supported. Use loadURI instead.
2344
2345         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2346         (testWebViewCustomCharset):
2347
2348 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2349
2350         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2351         https://bugs.webkit.org/show_bug.cgi?id=151633
2352
2353         Reviewed by Csaba Osztrogonác.
2354
2355         * TestWebKitAPI/PlatformGTK.cmake:
2356         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2357
2358 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2359
2360         [GTK] Remove the remaining uses of GMainLoopSource
2361         https://bugs.webkit.org/show_bug.cgi?id=151632
2362
2363         Reviewed by Žan Doberšek.
2364
2365         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2366         (testWebViewSyncRequestOnMaxConns):
2367         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2368         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2369         (WTR::TestRunner::TestRunner):
2370         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2371         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2372         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2373         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2374         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2375         (WTR::timeoutSource):
2376         (WTR::TestController::notifyDone):
2377         (WTR::TestController::platformRunUntil):
2378
2379 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2380
2381         [cmake] Add testb3 to the build system
2382         https://bugs.webkit.org/show_bug.cgi?id=151619
2383
2384         Reviewed by Gyuyoung Kim.
2385
2386         * Scripts/build-jsc:
2387
2388 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2389
2390         [jhbuild] Fix pixman build with clang
2391         https://bugs.webkit.org/show_bug.cgi?id=151441
2392
2393         Reviewed by Carlos Garcia Campos.
2394
2395         * efl/jhbuild.modules:
2396         * gtk/jhbuild.modules:
2397
2398 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2399
2400         Extract prependToEnvironmentVariableList
2401         <http://webkit.org/b/151536>
2402
2403         Reviewed by Daniel Bates.
2404
2405         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2406                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2407
2408         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2409         and prependToEnvironmentVariableList.
2410         (appendToEnvironmentVariableList): Simplify variable name.
2411         Switch to use $Config{path_sep}.
2412         (prependToEnvironmentVariableList): Add new method.
2413         (setupMacWebKitEnvironment): Switch to use
2414         prependToEnvironmentVariableList().
2415         (setupIOSWebKitEnvironment): Ditto.
2416
2417         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2418         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2419
2420 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2421
2422         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2423         https://bugs.webkit.org/show_bug.cgi?id=151567
2424
2425         Reviewed by Darin Adler.
2426
2427         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2428         (on_window_deletion):
2429
2430 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2431
2432         [GTK] Use the network process unconditionally
2433         https://bugs.webkit.org/show_bug.cgi?id=151541
2434
2435         Reviewed by Alex Christensen.
2436
2437         Fix TestInspectorServer test. Do not assume we already have the
2438         title we want when the page has been loaded, since the title is
2439         changed afterwards. So, check if the title has already been set,
2440         and if not wait for it.
2441
2442         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2443         (openRemoteDebuggingSession):
2444
2445 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2446
2447         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2448         https://bugs.webkit.org/show_bug.cgi?id=151532
2449
2450         Reviewed by Benjamin Poulain.
2451
2452         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2453         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2454         (TestWebKitAPI::TEST):
2455         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2456         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2457         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2458         Properly load about:blank in all WebViews to clean up.  Without this change, we had a
2459         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2460         so it was calling a function on a test object that had gone out of scope.
2461         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2462         but that will become the default soon and that call will be removed.
2463
2464 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2465
2466         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2467         <http://webkit.org/b/151542>
2468
2469         Reviewed by Daniel Bates.
2470
2471         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2472         (base_url): Use the Port object (already passed in) to give us
2473         the path to the LayoutTests directory, which already checks for a
2474         --layout-tests-directory command-line switch.
2475         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2476         argument since we can get this from the Port object already
2477         passed in via Port.results_directory().  Also switch to use
2478         Port.layout_tests_dir() to get the LayoutTests directory.
2479
2480         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2481         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2482         Add test case for custom LayoutTests directory.
2483         (TestWebPlatformTestServer.test_previously_spawned_instance):
2484         Update Port object to set mock results directory as if it was
2485         set on the command-line.  Remove unneeded argument from
2486         WebPlatformTestServer constructor.
2487         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2488
2489         * Scripts/webkitpy/port/base.py:
2490         (Port.to.start_web_platform_test_server): Remove unneeded
2491         argument from WebPlatformTestServer constuctor.
2492
2493 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2494
2495         [GTK] Some unit tests fail when using the network process
2496         https://bugs.webkit.org/show_bug.cgi?id=151490
2497
2498         Reviewed by Martin Robinson.
2499
2500         Run the soup server in a separate thread in TestResources test to
2501         avoid deadlocks.
2502
2503         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2504         /webkit2/WebKitWebResource/get-data when using the network process.
2505
2506         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2507         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2508         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2509         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2510         present, create a WorkQueue to run the server.
2511         (WebKitTestServer::run): Run the server in the work queue if it
2512         has been created.
2513         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2514         type into server options as flags.
2515
2516 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2517
2518         [GTK] ImageDiff should normalize the diff image
2519         https://bugs.webkit.org/show_bug.cgi?id=151261
2520
2521         Reviewed by Sergio Villar Senin.
2522
2523         * ImageDiff/gtk/ImageDiff.cpp:
2524         (readPixbufFromStdin): Fix memory leak.
2525         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2526         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2527
2528 == Rolled over to ChangeLog-2015-11-21 ==