[wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than...
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-04  Robin Dunn  <robin@alldunn.com>
2
3         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
4         https://bugs.webkit.org/show_bug.cgi?id=67577
5
6         Reviewed by Kevin Ollivier.
7
8         * waf/build/settings.py:
9
10 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
11
12         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
13
14         * waf/build/settings.py:
15
16 2011-09-03  Dan Bernstein  <mitz@apple.com>
17
18         32-bit build fix.
19
20         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
21         (TestWebKitAPI::Util::toSTD):
22
23 2011-09-03  Dan Bernstein  <mitz@apple.com>
24
25         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
26         https://bugs.webkit.org/show_bug.cgi?id=67559
27
28         Reviewed by Darin Adler.
29
30         * DumpRenderTree/mac/DumpRenderTree.mm:
31         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
32         the call to it.
33         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
34         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
35         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
36         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
37         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
38         (TestWebKitAPI::Util::toSTD): Added.
39
40 2011-09-03  Adam Barth  <abarth@webkit.org>
41
42         garden-o-matic results view should have a better results selector
43         https://bugs.webkit.org/show_bug.cgi?id=67542
44
45         Reviewed by Dimitri Glazkov.
46
47         This patch adds a basic grid-based results selector to the results
48         view.  Currently, this grid just shows how the tests fail on the
49         various bots.  A future patch will let you select which failure to view
50         and to mark the failures for rebaselining.
51
52         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
53         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
54           - Add some more basic functions for manipulating dictionaries.
55         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
56         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
57         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
58
59 2011-09-03  Adam Barth  <abarth@webkit.org>
60
61         garden-o-matic results view should show Actual and Expected results for text failures
62         https://bugs.webkit.org/show_bug.cgi?id=67536
63
64         Reviewed by Eric Seidel.
65
66         In the past, we didn't show actual and expected text results (we just
67         showed the diff) because we didn't have the awesome six-by-two results
68         grid.  Now that we do, we can move show these results.
69
70         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
71         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
72           - Fixed some typos that were preventing these unit tests from running.
73         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
74         (.):
75         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
76           - Report -actual.txt and -expected.txt as possible results URLs.
77
78 2011-09-03  Adam Barth  <abarth@webkit.org>
79
80         garden-o-matic shows "ghost" failures that are already fixed
81         https://bugs.webkit.org/show_bug.cgi?id=67535
82
83         Reviewed by Eric Seidel.
84
85         About 10% of writes fail to stick on test-results.appspot.com.  This
86         patch causes us to fetch the full_results.json blob directly from
87         build.chromium.org rather than relying upon AppEngine.
88
89         Unforuntately, we still need to get historical information from
90         AppEngine.  That will take several patches to fix becuase I need to
91         change the bots to write the full_results.json file to the
92         build-specific directory in addition to the zip file.
93
94         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
95         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
96         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
97
98 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
99
100         Unreviewed, rolling out r94458.
101         http://trac.webkit.org/changeset/94458
102         https://bugs.webkit.org/show_bug.cgi?id=67558
103
104         Caused appcache test to fail on various bots (Requested by
105         rniwa on #webkit).
106
107         * Scripts/webkitpy/layout_tests/port/webkit.py:
108         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
109
110 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
111
112         Unreviewed, rolling out r94453.
113         http://trac.webkit.org/changeset/94453
114         https://bugs.webkit.org/show_bug.cgi?id=67557
115
116         Caused appcache test to fail on various bots (Requested by
117         rniwa on #webkit).
118
119         * Scripts/webkitpy/layout_tests/port/webkit.py:
120
121 2011-09-02  Michael Saboff  <msaboff@apple.com>
122
123         Add JSC:RegExp functional tests
124         https://bugs.webkit.org/show_bug.cgi?id=67339
125
126         New perl script to build JavaScriptCore and run the RegExp tests.
127
128         Reviewed by Gavin Barraclough.
129
130         * Scripts/run-regexp-tests: Added.
131
132 2011-09-02  Michael Saboff  <msaboff@apple.com>
133
134         Add JSC:RegExp functional tests
135         https://bugs.webkit.org/show_bug.cgi?id=67339
136
137         New perl script to build JavaScriptCore and run the RegExp tests.
138
139         Reviewed by Gavin Barraclough.
140
141         * Scripts/run-regexp-tests: Added.
142
143 2011-09-02  Eric Seidel  <eric@webkit.org>
144
145         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
146         https://bugs.webkit.org/show_bug.cgi?id=67530
147
148         Unreviewed.  Fixing typo from previous commit.
149
150         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
151         which exercises the code I previously made a typo in.
152
153         * Scripts/webkitpy/layout_tests/port/webkit.py:
154         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
155
156 2011-09-02  Eric Seidel  <eric@webkit.org>
157
158         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
159         https://bugs.webkit.org/show_bug.cgi?id=67530
160
161         Reviewed by Adam Barth.
162
163         No functional change, just reshuffling code.
164
165         * Scripts/webkitpy/layout_tests/port/webkit.py:
166
167 2011-09-02  Darin Adler  <darin@apple.com>
168
169         Added Subversion ignore for .pyc generated files.
170
171         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
172         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
173         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
174
175 2011-09-02  Adam Barth  <abarth@webkit.org>
176
177         Enable testing on mac-ews
178         https://bugs.webkit.org/show_bug.cgi?id=67505
179
180         Reviewed by Eric Seidel.
181
182         This patch enables testing on the Mac EWS, which should help
183         contributors not turn the Mac bots red.
184
185         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
186
187 2011-09-01  Beth Dakin  <bdakin@apple.com>
188
189         https://bugs.webkit.org/show_bug.cgi?id=67451
190         Add a test for going back to a cached page after changing the device scale factor
191
192         Reviewed by Adam Roben.
193
194         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
196         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
197         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
198         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
199         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
200         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
201         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
202         (TestWebKitAPI::TEST_F):
203
204         Added new function to WebKitAgnosticTest to goBack. Separated 
205         waitForLoadToFinish() into its own function (instead of being a part of 
206         loadAndWaitUntilFinished()) so that it can be called from goBack as 
207         well. Also added initializeView() so we can set the cache model.
208         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
209         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
210         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
211         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
212         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
213         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
214         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
215         (TestWebKitAPI::WebKitAgnosticTest::goBack):
216         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
217
218 2011-09-02  Anders Carlsson  <andersca@apple.com>
219
220         Build fix.
221
222         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
223         (PrivateBrowsing::ScriptableObject::pluginTest):
224
225 2011-09-02  Anders Carlsson  <andersca@apple.com>
226
227         Move private browsing test to a PluginTest subclass
228         https://bugs.webkit.org/show_bug.cgi?id=67498
229
230         Reviewed by Darin Adler.
231
232         * DumpRenderTree/DumpRenderTree.gypi:
233         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
234         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
235         (pluginGetProperty):
236         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
237         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
238         (PluginTest::NPP_SetValue):
239         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
240         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
241         (PrivateBrowsing::PrivateBrowsing):
242         (PrivateBrowsing::privateBrowsingEnabled):
243         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
244         (PrivateBrowsing::ScriptableObject::hasProperty):
245         (PrivateBrowsing::ScriptableObject::getProperty):
246         (PrivateBrowsing::ScriptableObject::pluginTest):
247         (PrivateBrowsing::NPP_New):
248         (PrivateBrowsing::NPP_GetValue):
249         (PrivateBrowsing::NPP_SetValue):
250         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
251         (NPP_New):
252         (NPP_SetValue):
253         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
254         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
255         * GNUmakefile.am:
256
257 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
258
259         [Qt] Build dependency problems
260         https://bugs.webkit.org/show_bug.cgi?id=38054
261
262         Trivial fix after r94288.
263
264         Rubber-stamped by Andras Becsi.
265
266         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
267         (buildQMakeProject):
268
269 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
270
271         Remove my old e-mail address and add my new one.
272
273         Rubber-stamped by Tor Arne Vestbø.
274
275         * Scripts/webkitpy/common/config/committers.py:
276
277 2011-09-02  Philippe Normand  <pnormand@igalia.com>
278
279         [GTK] run-gtk-tests leaves a zombie Xvfb process
280         https://bugs.webkit.org/show_bug.cgi?id=67389
281
282         Reviewed by Martin Robinson.
283
284         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
285         child process instead of doing shell redirection.
286
287 2011-09-01  Mark Rowe  <mrowe@apple.com>
288
289         Fix the build by adding some more missing return types.
290
291         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
292         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
293
294 2011-09-01  Eric Seidel  <eric@webkit.org>
295
296         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
297         https://bugs.webkit.org/show_bug.cgi?id=66228
298
299         Reviewed by Dirk Pranke.
300
301         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
302         The LeaksViewer tool globs for all *-leaks.txt files.
303         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
304
305         In order to test this I had to fix a limitation in our MockFileSystem.glob
306         method.  However, doing so uncovered a typo and bug in the integration tests.
307         I've disabled the offending integration tests.
308
309         * Scripts/webkitpy/common/system/filesystem_mock.py:
310         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
311         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
312
313 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
314
315         Adds a LayoutTestController method to make it possible to test
316         starting speech input via an API call.
317         https://bugs.webkit.org/show_bug.cgi?id=60170
318
319         Reviewed by Dimitri Glazkov.
320
321         * DumpRenderTree/LayoutTestController.h:
322         * DumpRenderTree/chromium/LayoutTestController.cpp:
323         (LayoutTestController::LayoutTestController):
324         (LayoutTestController::startSpeechInput):
325         * DumpRenderTree/chromium/LayoutTestController.h:
326         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
327         (LayoutTestController::startSpeechInput):
328         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
329         (LayoutTestController::startSpeechInput):
330         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
331         (LayoutTestController::startSpeechInput):
332         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
333         (LayoutTestController::startSpeechInput):
334         * DumpRenderTree/qt/LayoutTestControllerQt.h:
335         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
336         (LayoutTestController::startSpeechInput):
337         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
338         (LayoutTestController::startSpeechInput):
339
340 2011-09-01  Tim Horton  <hortont424@gmail.com>
341
342         Fix TestWebKitAPI build on clang-2.0
343
344         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
345
346 2011-09-01  Adam Barth  <abarth@webkit.org>
347
348         Remove unused "extension" parameter from rebaseline gardeningserver handler
349         https://bugs.webkit.org/show_bug.cgi?id=67384
350
351         Reviewed by James Robinson.
352
353         This parameter hasn't done anything in a while.
354
355         * Scripts/webkitpy/tool/commands/rebaseline.py:
356         * Scripts/webkitpy/tool/servers/gardeningserver.py:
357         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
358
359 2011-09-01  Eric Seidel  <eric@webkit.org>
360
361         Unreviewed.
362
363         Fix a typo in unittests.  Unfortunately fixing it
364         caused several assertions.  Just disabling the test
365         instead, since it was providing no value before due to the typo.
366
367         * Scripts/webkitpy/layout_tests/port/test.py:
368
369 2011-09-01  Adam Barth  <abarth@webkit.org>
370
371         Add a "rebaseline" button to the garden-o-matic summary page
372         https://bugs.webkit.org/show_bug.cgi?id=67382
373
374         Reviewed by Dimitri Glazkov.
375
376         As much as we might wish folks to not rebaseline entire test groups at
377         once, the truth is that doing so is a common operation.  Adding a
378         button for this operation is likely to make folks happy.
379
380         This patch also cleans up a bunch of plumbing surrounding failureInfo
381         objects.
382
383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
393
394 2011-09-01  Adam Barth  <abarth@webkit.org>
395
396         garden-o-matic should let the gardener assign blame for a group of test failures
397         https://bugs.webkit.org/show_bug.cgi?id=67379
398
399         Reviewed by Dimitri Glazkov.
400
401         If a group of test failures has a large revision range, the gardener
402         might wish to blame a specific revision for the failure.  Currently,
403         this only effect of assigning blame in this way is to hide the other
404         suspect commits.
405
406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
409
410 2011-09-01  Adam Barth  <abarth@webkit.org>
411
412         Hide garden-o-matic failure table until hover
413         https://bugs.webkit.org/show_bug.cgi?id=67376
414
415         Reviewed by Dimitri Glazkov.
416
417         This patch removes the failure table for build failures (because it
418         does not make sense) and hides the failure table for test groups until
419         the user hovers over the test failure block, reducing visual noise.
420
421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
424
425 2011-09-01  Adam Barth  <abarth@webkit.org>
426
427         Switch garden-o-matic from commitData.title to commitData.summary
428         https://bugs.webkit.org/show_bug.cgi?id=67375
429
430         Reviewed by Dimitri Glazkov.
431
432         commitData.title is a string provided by Trac, which isn't great in all
433         cases.  commitData.summary is my attempt to find the most important
434         one-line summary of the commit.  This patch switches garden-o-matic
435         over to summary.
436
437         Also, this patch tweaks a bunch of CSS to tighten up the summary page
438         and reduce visual noise.
439
440         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
441         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
442         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
443
444 2011-09-01  Adam Barth  <abarth@webkit.org>
445
446         Group failing tests in garden-o-matic if there are more than three in a folder
447         https://bugs.webkit.org/show_bug.cgi?id=67373
448
449         Reviewed by Dimitri Glazkov.
450
451         Sometimes a failure will cause many tests in a given directory to fail.
452         When that happens, it's better to list the directory as a single item
453         (with a count) rather than spamming all the test names.
454
455         (This patch also updates a bunch of unit test expected results after my last commit.)
456
457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
462
463 2011-09-01  Adam Barth  <abarth@webkit.org>
464
465         Lower the visual noise from the failing builders display
466         https://bugs.webkit.org/show_bug.cgi?id=67369
467
468         Reviewed by Dimitri Glazkov.
469
470         This patch ensures that the "Building" row in the failing builders
471         display is always last and dims it by 50% to reduce visual noise.  This
472         lets the gardener focus on the actual failures.
473
474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
477
478 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
479
480         [Qt] Build dependency problems
481         https://bugs.webkit.org/show_bug.cgi?id=38054
482
483         Make clean build after the defines are changed.
484
485         Reviewed by Csaba Osztrogonác.
486
487         * Scripts/webkitdirs.pm:
488         (buildQMakeProject):
489
490 2011-08-31  Adam Barth  <abarth@webkit.org>
491
492         Move DumpRenderTree to WebKitPlatformSupport
493         https://bugs.webkit.org/show_bug.cgi?id=67331
494
495         Reviewed by Darin Fisher.
496
497         This patch update DumpRenderTree to account for the WebKitClient =>
498         WebKitPlatformSupport rename.
499
500         * DumpRenderTree/chromium/NotificationPresenter.cpp:
501         (NotificationPresenter::show):
502         * DumpRenderTree/chromium/Task.cpp:
503         (postTask):
504
505 2011-08-31  Eric Seidel  <eric@webkit.org>
506
507         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
508         https://bugs.webkit.org/show_bug.cgi?id=67314
509
510         Reviewed by Adam Barth.
511
512         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
513         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
514         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
515
516         I also moved a bunch of code into dashboard.css which belonged there.
517
518         * QueueStatusServer/handlers/activebots.py: Added.
519         * QueueStatusServer/main.py:
520         * QueueStatusServer/stylesheets/dashboard.css:
521         (.queue_bubble):
522         (.queue_name):
523         (.last_heard_from):
524         (.status_text):
525         (.alive):
526         (.behind):
527         (.dead):
528         * QueueStatusServer/templates/activebots.html: Added.
529         * QueueStatusServer/templates/dashboard.html:
530         * QueueStatusServer/templates/recentstatus.html:
531
532 2011-08-31  Oliver Hunt  <oliver@apple.com>
533
534         Move CheckedArithmeticOperations.cpp to the intended location
535
536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
537         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
538
539 2011-08-31  Elliot Poger  <epoger@google.com>
540
541         add unittest to validate the complete set of Chromium configurations
542         https://bugs.webkit.org/show_bug.cgi?id=67211
543
544         Reviewed by Adam Barth.
545
546         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
547
548 2011-08-31  Nico Weber  <thakis@chromium.org>
549
550         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
551         https://bugs.webkit.org/show_bug.cgi?id=67297
552
553         Reviewed by Tony Chang.
554
555         Explicitly disable smooth scrolling in chromium's DRT.
556
557         * DumpRenderTree/chromium/WebPreferences.cpp:
558         (WebPreferences::applyTo):
559
560 2011-08-31  Oliver Hunt  <oliver@apple.com>
561
562         Add Checked<> tests to windows build
563
564         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
565
566 2011-08-30  Oliver Hunt  <oliver@apple.com>
567
568         Add support for checked arithmetic
569         https://bugs.webkit.org/show_bug.cgi?id=67095
570
571         Reviewed by Sam Weinig.
572
573         Add test cases for Checked<>
574
575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
576         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
577
578 2011-08-31  Adam Barth  <abarth@webkit.org>
579
580         Move summary.html to garden-o-matic.html.
581
582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
584         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
586
587 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
588
589         [chromium] DRT linux should pass nativeKeyCode to plugins
590         https://bugs.webkit.org/show_bug.cgi?id=66679
591
592         Reviewed by Tony Chang.
593
594         * DumpRenderTree/chromium/EventSender.cpp:
595         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
596         (simulated) nativeKeyCode for the given input keyboard code.
597
598 2011-08-31  Adam Barth  <abarth@webkit.org>
599
600         Tighen up UI for garden-o-matic tab strip
601         https://bugs.webkit.org/show_bug.cgi?id=67266
602
603         Reviewed by Dimitri Glazkov.
604
605         This patch add CSS to move the tab strip to the edges of the page and
606         to remove some gratuitous border-radius.
607
608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
610
611 2011-08-31  Adam Barth  <abarth@webkit.org>
612
613         garden-o-matic results view shouldn't be horrifically ugly
614         https://bugs.webkit.org/show_bug.cgi?id=67264
615
616         Reviewed by Dimitri Glazkov.
617
618         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
619
620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
622         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
623
624 2011-08-31  Adam Barth  <abarth@webkit.org>
625
626         garden-o-matic needs a tabstrip
627         https://bugs.webkit.org/show_bug.cgi?id=67263
628
629         Reviewed by Dimitri Glazkov.
630
631         This patch adds a basic tabstrip to garden-o-matic.  The results
632         details view now opens in the "Results" tab, and the user can flip back
633         and forth between the Summary and the Results tab quickly.  There's
634         also a stub for a "Commits" tab, which is disabled.
635
636         This patch isn't the most beautiful in the world, but it gets the ball
637         rolling on a multi-modal UI.
638
639         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
641         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
642         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
643         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
644
645 2011-08-31  Ai Makabi  <makabi@google.com>
646
647         Extract reference links from reftest test file.
648         https://bugs.webkit.org/show_bug.cgi?id=66838
649
650         Reviewed by Shinichiro Hamaji.
651
652         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
653         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
654         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
655
656 2011-08-03  Philippe Normand  <pnormand@igalia.com>
657
658         [webkitpy] missing log import in common/net/resultsjsonparser.py
659         https://bugs.webkit.org/show_bug.cgi?id=65606
660
661         Reviewed by Martin Robinson.
662
663         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
664
665 2011-08-30  Philippe Normand  <pnormand@igalia.com>
666
667         [stylechecker] complains about NULL usage in some gst_structure_ calls
668         https://bugs.webkit.org/show_bug.cgi?id=67194
669
670         Reviewed by Martin Robinson.
671
672         Don't warn about NULL in some gst_structure_ calls. 0 can't be
673         used for these, a proper sentinel is required.
674
675         * Scripts/webkitpy/style/checkers/cpp.py:
676         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
677
678 2011-08-30  Adam Barth  <abarth@webkit.org>
679
680         Remove old-style UI from garden-o-matic
681         https://bugs.webkit.org/show_bug.cgi?id=67257
682
683         Reviewed by Dimitri Glazkov.
684
685         This code is nowhere near as awesome as the new hotness.  Let's remove
686         it so it doesn't weigh us down.
687
688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
692         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
693         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
694
695 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
696
697         [WebSocket] update pywebsocket to 0.6b5.
698         https://bugs.webkit.org/show_bug.cgi?id=66924
699
700         Reviewed by Kent Tamura.
701
702         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
703         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
704         0.6b3 or later supports a closing handshake handler and it is useful to
705         verify client's closing handshake implementation.
706         0.6b4 supports AbortedByUserException. It is useful to eliminate
707         unnecessary server warning messages on intended abnormal closures.
708         0.6b5 supports Python 2.5.1 or Mac 10.5.
709
710         * Scripts/webkitpy/thirdparty/__init__.py:
711         Update download URL and directory path.
712
713 2011-08-30  Dan Bernstein  <mitz@apple.com>
714
715         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
716         https://bugs.webkit.org/show_bug.cgi?id=67230
717
718         Reviewed by Darin Adler.
719
720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
721         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
722         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
723         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
724         (TestWebKitAPI::TEST):
725
726 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
727
728         Add MediaSource API to HTMLMediaElement
729         https://bugs.webkit.org/show_bug.cgi?id=64731
730
731         Reviewed by Eric Carlson.
732
733         * Scripts/build-webkit:
734
735 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
736
737         Emit last progress notification before calling dispatchDidFinishLoad
738         https://bugs.webkit.org/show_bug.cgi?id=28851
739
740         Reviewed by Adam Barth.
741
742         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
743         Chromium and GTK ports. The first two were simple changes.
744
745         Some refactoring was needed in GTK port to assure that the dumps are emitted
746         correctly and the processing after the page load finished is in the right place.
747
748         To detect the load finished, we use the callback for the "load-status" notifier
749         signal of the top loading frame. And we use the deprecated "load-finished" signal
750         for dumping (if enabled) the progress finished expected output.
751
752         * DumpRenderTree/LayoutTestController.cpp:
753         (LayoutTestController::LayoutTestController):
754         (dumpProgressFinishedCallbackCallback):
755         (LayoutTestController::staticFunctions):
756         * DumpRenderTree/LayoutTestController.h:
757         (LayoutTestController::dumpProgressFinishedCallback):
758         (LayoutTestController::setDumpProgressFinishedCallback):
759         * DumpRenderTree/chromium/LayoutTestController.cpp:
760         (LayoutTestController::LayoutTestController):
761         (LayoutTestController::dumpProgressFinishedCallback):
762         (LayoutTestController::reset):
763         * DumpRenderTree/chromium/LayoutTestController.h:
764         (LayoutTestController::shouldDumpProgressFinishedCallback):
765         (LayoutTestController::setShouldDumpProgressFinishedCallback):
766         * DumpRenderTree/chromium/WebViewHost.cpp:
767         (WebViewHost::didStopLoading):
768         * DumpRenderTree/gtk/DumpRenderTree.cpp:
769         (webViewLoadFinished):
770         (topLoadingFrameLoadFinished):
771         (webFrameLoadStatusNotified):
772         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
773         (LayoutTestController::reset):
774         (LayoutTestController::dumpProgressFinishedCallback):
775         * DumpRenderTree/qt/LayoutTestControllerQt.h:
776
777 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
778
779         JavaScriptCore does not have a good mechanism for performance
780         regression testing
781         https://bugs.webkit.org/show_bug.cgi?id=67177
782
783         Reviewed by Darin Adler.
784         
785         Added a new script, which allows for testing one, two, or more VMs
786         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
787         are interleaved at random to minimize systematics.  The results
788         that bencher prints includes all possible relevant information about
789         how bencher was invoked.  Bencher can be easily used to measure
790         performance changes down to fractions of a percent.
791         
792         Bencher also includes experimental support for running benchmarks in
793         a DumpRenderTree release build.  This works in SunSpider and V8, but
794         not yet in Kraken.  Running benchmarks in DumpRenderTree more
795         closely mimics the performance when running in browser.
796
797         * Scripts/bencher: Added.
798
799 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
800
801         DumpRenderTree should begin each test with an empty cookie store
802         https://bugs.webkit.org/show_bug.cgi?id=63545
803         <rdar://problem/5666907>
804
805         Reviewed by Darin Adler.
806
807         * DumpRenderTree/mac/DumpRenderTree.mm:
808         (resetDefaultsToConsistentValues):
809         (setDefaultsToConsistentValuesForTesting):
810         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
811         (LayoutTestController::setAlwaysAcceptCookies):
812         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
813         (WTR::InjectedBundle::beginTesting):
814         Use new SPIs to manipulate sessions.
815
816 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
817
818         Unreviewed, rolling out r94055 and r94057.
819         http://trac.webkit.org/changeset/94055
820         http://trac.webkit.org/changeset/94057
821         https://bugs.webkit.org/show_bug.cgi?id=67191
822
823         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
824
825         * Scripts/webkitpy/thirdparty/__init__.py:
826
827 2011-08-30  Adam Barth  <abarth@webkit.org>
828
829         Chromium Android should not be a core builder
830         https://bugs.webkit.org/show_bug.cgi?id=67184
831
832         Reviewed by Ryosuke Niwa.
833
834         This bot hasn't been consistently green yet because it has never actually run!
835
836         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
837         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
838
839 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
840
841         [WebSocket] update pywebsocket to 0.6b4.
842         https://bugs.webkit.org/show_bug.cgi?id=66924
843
844         Reviewed by Kent Tamura.
845
846         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
847         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
848         0.6b3 or later supports a closing handshake handler and it is useful to
849         verify client's closing handshake implementation.
850         0.6b4 supports AbortedByUserException. It is useful to eliminate
851         unnecessary server warning messages on intended abnormal closures.
852
853         * Scripts/webkitpy/thirdparty/__init__.py:
854         Update download URL and directory path.
855
856 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
857
858         sheriffbot "usage" help statements are wrong
859         https://bugs.webkit.org/show_bug.cgi?id=67170
860
861         Reviewed by Adam Barth.
862
863         * Scripts/webkitpy/tool/bot/irc_command.py:
864         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
865         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
866
867 2011-08-29  Adam Barth  <abarth@webkit.org>
868
869         Add support for chomium-mac (non-CoreGraphics) baselines
870         https://bugs.webkit.org/show_bug.cgi?id=67163
871
872         Reviewed by Eric Seidel.
873
874         This patch teaches the non-CG chromium-mac bots to look at non-CG
875         baselines.  However, the patch still leaves CG as the default set of
876         baselines.
877
878         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
879         * Scripts/webkitpy/common/config/build.py:
880         * Scripts/webkitpy/common/config/build_unittest.py:
881         * Scripts/webkitpy/layout_tests/port/builders.py:
882         * Scripts/webkitpy/layout_tests/port/chromium.py:
883         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
884         * Scripts/webkitpy/layout_tests/port/factory.py:
885         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
886         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
887         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
888         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
889
890 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
891
892         Small fix in chromium port of new-run-webkit-tests.
893         https://bugs.webkit.org/show_bug.cgi?id=67078
894
895         Reviewed by Dirk Pranke.
896
897         * Scripts/webkitpy/layout_tests/port/chromium.py:
898
899 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
900
901         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
902         r93999.
903         http://trac.webkit.org/changeset/93987
904         http://trac.webkit.org/changeset/93992
905         http://trac.webkit.org/changeset/93995
906         http://trac.webkit.org/changeset/93998
907         http://trac.webkit.org/changeset/93999
908         https://bugs.webkit.org/show_bug.cgi?id=67147
909
910         Many failing tests (Requested by ap on #webkit).
911
912         * DumpRenderTree/mac/DumpRenderTree.mm:
913         (setDefaultsToConsistentValuesForTesting):
914         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
915         (WTR::InjectedBundle::beginTesting):
916
917 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
918
919         DumpRenderTree should begin each test with an empty cookie store
920         https://bugs.webkit.org/show_bug.cgi?id=63545
921         <rdar://problem/5666907>
922
923         Reviewed by Darin Adler.
924
925         * DumpRenderTree/mac/DumpRenderTree.mm:
926         (setDefaultsToConsistentValuesForTesting):
927         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
928         (WTR::InjectedBundle::beginTesting):
929         Tell WebCore to use a temporary session, starting with a clean cookie store.
930
931 2011-08-23  Chris Marrin  <cmarrin@apple.com>
932
933         [mac] requestAnimationFrame support for mac port
934         https://bugs.webkit.org/show_bug.cgi?id=59146
935
936         Reviewed by Simon Fraser.
937
938         Add support for request-animation-callback flag
939
940         * Scripts/build-webkit:
941
942 2011-08-27  Peter Beverloo  <peter@chromium.org>
943
944         Add a build bot for Chromium with OS(ANDROID)
945         https://bugs.webkit.org/show_bug.cgi?id=66687
946
947         Reviewed by Adam Barth.
948
949         * BuildSlaveSupport/build.webkit.org-config/config.json:
950
951 2011-08-27  Peter Beverloo  <peter@chromium.org>
952
953         Update the master build bot configuration script to properly
954         deal with the --chromium-android switch.
955         https://bugs.webkit.org/show_bug.cgi?id=66687
956
957         The --chromium-android switch is needed when running
958         update-webkit-chromium and build-webkit, as it'll tell the
959         scripts to pull in the right dependencies and cross-compile
960         WebKit using the Android NDK.
961
962         Reviewed by Adam Barth.
963
964         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
965
966 2011-08-27  Peter Beverloo  <peter@chromium.org>
967
968         Teach the update and build scripts how to handle dependencies
969         and cross-compiling rules for the Chromium port on OS(ANDROID).
970         https://bugs.webkit.org/show_bug.cgi?id=66687
971
972         Reviewed by Adam Barth.
973
974         * Scripts/build-webkit:
975         * Scripts/update-webkit:
976         * Scripts/update-webkit-chromium:
977         * Scripts/webkitdirs.pm:
978         (argumentsForConfiguration):
979         (isChromium):
980         (isChromiumAndroid):
981         (determineIsChromiumAndroid):
982         (buildChromium):
983
984 2011-08-26  Adam Barth  <abarth@webkit.org>
985
986         garden-o-matic should let me know that I need to run the local server
987         https://bugs.webkit.org/show_bug.cgi?id=66985
988
989         Reviewed by Dimitri Glazkov.
990
991         The patch triggers an alert dialog whenever the user tries to use a
992         feature that requires the local server.
993
994         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
997
998 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
999
1000         garden-o-matic summary view should have pretty commit data information.
1001         https://bugs.webkit.org/show_bug.cgi?id=67069
1002
1003         Reviewed by Adam Barth.
1004
1005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
1006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
1007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
1008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
1009
1010 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1011
1012         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
1013         https://bugs.webkit.org/show_bug.cgi?id=67066
1014
1015         Reviewed by Adam Barth.
1016
1017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
1018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1019
1020 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
1021
1022         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
1023         https://bugs.webkit.org/show_bug.cgi?id=67041
1024
1025         Reviewed by Martin Robinson.
1026
1027         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
1028         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
1029         when the GTK+ port was being built.
1030
1031         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1032
1033 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1034
1035         Clean up and line up layout in garden-o-matic summary view.
1036         https://bugs.webkit.org/show_bug.cgi?id=67057
1037
1038         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
1039         2) Rearranged DOM structure a bit to accommodate recent changes;
1040         3) Added minimal CSS to line things up.
1041
1042         Reviewed by Adam Barth.
1043
1044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
1045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
1046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
1047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
1048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
1049         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1050         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
1051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
1052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
1053         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1054
1055 2011-08-26  Alice Liu  <alice.liu@apple.com>
1056
1057         https://bugs.webkit.org/show_bug.cgi?id=66823
1058         Add the request info to the WebPageProxy::CreateNewPage message
1059
1060         Reviewed by Anders Carlsson.
1061
1062         Update function declarations with additional parameter:
1063         * MiniBrowser/gtk/BrowserWindow.c:
1064         (createNewPage):
1065         * MiniBrowser/mac/BrowserWindowController.m:
1066         (createNewPage):
1067         * MiniBrowser/win/BrowserView.cpp:
1068         (createNewPage):
1069         * WebKitTestRunner/TestController.cpp:
1070         (WTR::TestController::createOtherPage):
1071         * WebKitTestRunner/TestController.h:
1072
1073 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
1074
1075         Make show-pretty-diff work on linux
1076         https://bugs.webkit.org/show_bug.cgi?id=67017
1077
1078         Reviewed by Adam Barth.
1079
1080         * Scripts/show-pretty-diff:
1081
1082 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1083
1084         Reorganize garden-o-matic CSS files to match JS-built views.
1085         https://bugs.webkit.org/show_bug.cgi?id=66998
1086
1087         Reviewed by Adam Barth.
1088
1089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
1090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
1091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
1092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
1093         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
1094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1095
1096 2011-08-25  Adam Barth  <abarth@webkit.org>
1097
1098         garden-o-matic should be able to roll out patches
1099         https://bugs.webkit.org/show_bug.cgi?id=66982
1100
1101         Reviewed by Dimitri Glazkov.
1102
1103         This patch just wires the rollout event through the controller to the
1104         local server, which is already set up to perform rollouts.
1105
1106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1110
1111 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1112
1113         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
1114         https://bugs.webkit.org/show_bug.cgi?id=66951
1115
1116         Reviewed by Andreas Kling.
1117
1118         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
1119         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
1120
1121         * MiniBrowser/qt/BrowserView.cpp:
1122         (BrowserView::resizeEvent):
1123
1124 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1125
1126         garden-o-matic summary view should provide information on builders still in flight.
1127         https://bugs.webkit.org/show_bug.cgi?id=66992
1128
1129         Reviewed by Adam Barth.
1130
1131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
1132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
1133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
1134         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
1135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
1136
1137 2011-08-25  Adam Barth  <abarth@webkit.org>
1138
1139         webkit-patch rebaseline-expectations don't work when run outside the root
1140         https://bugs.webkit.org/show_bug.cgi?id=66966
1141
1142         Reviewed by Eric Seidel.
1143
1144         Turns out tool.path() used to be relative, which caused problems when
1145         running webkit-patch outside the root directory.  This patch makes it
1146         absolute.  I checked all callers, and they all appear to want this
1147         behavior.
1148
1149         It was unclear to me how to test this change because we only really
1150         have a testing strategy for webkitpy, not for the main script.
1151
1152         * Scripts/webkit-patch:
1153
1154 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1155
1156         garden-o-matic summary needs a mock view that could be used for working on styling
1157         https://bugs.webkit.org/show_bug.cgi?id=66971
1158
1159         Reviewed by Adam Barth.
1160
1161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
1162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
1163
1164 2011-08-25  Anders Carlsson  <andersca@apple.com>
1165
1166         Return the correct value for NPNVsupportsCarbonBool
1167         https://bugs.webkit.org/show_bug.cgi?id=66964
1168
1169         Add a test.
1170
1171         Reviewed by Adam Roben.
1172
1173         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1174         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
1175         (SupportsCarbonEventModel::SupportsCarbonEventModel):
1176         (SupportsCarbonEventModel::testConvert):
1177         (SupportsCarbonEventModel::runTest):
1178         (SupportsCarbonEventModel::NPP_New):
1179
1180 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1181
1182         garden-o-matic summary view should not be broken.
1183
1184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1185         (table.comparison): Added more specificity.
1186
1187 2011-08-25  Adam Barth  <abarth@webkit.org>
1188
1189         This command has been broken for a while.  This patch updates the
1190         callsite to the new API.
1191
1192         * Scripts/webkitpy/tool/commands/rebaseline.py:
1193
1194 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1195
1196         garden-o-matic needs a way to report where and how tests are failing in the summary view.
1197         https://bugs.webkit.org/show_bug.cgi?id=66955
1198
1199         Introduce FailureGrid, your one-stop failure-indicating destination. 
1200
1201         Reviewed by Adam Barth.
1202
1203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
1205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
1206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
1207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
1209
1210 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
1211
1212         Add myself to the committers list
1213         https://bugs.webkit.org/show_bug.cgi?id=66941
1214
1215         Reviewed by Andreas Kling.
1216
1217         * Scripts/webkitpy/common/config/committers.py:
1218
1219 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1220
1221         Unreviewed, rolling out r93767.
1222         http://trac.webkit.org/changeset/93767
1223         https://bugs.webkit.org/show_bug.cgi?id=66931
1224
1225         Broke Qt bot. (Requested by yutak on #webkit).
1226
1227         * Scripts/webkitpy/thirdparty/__init__.py:
1228
1229 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
1230
1231         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
1232         https://bugs.webkit.org/show_bug.cgi?id=66924
1233
1234         Reviewed by Kent Tamura.
1235
1236         * Scripts/webkitpy/thirdparty/__init__.py:
1237
1238 2011-08-24  Adam Barth  <abarth@webkit.org>
1239
1240         The user can't close the details view in garden-o-matic
1241         https://bugs.webkit.org/show_bug.cgi?id=66911
1242
1243         Reviewed by Dimitri Glazkov.
1244
1245         In addition to adding a close button, this patch changes the test
1246         selector to use a <select> element and refactors the test selector to
1247         share code with the builder selector.
1248
1249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1253
1254 2011-08-24  James Robinson  <jamesr@chromium.org>
1255
1256         [chromium] Stacktrace not in test output when a test crashes
1257         https://bugs.webkit.org/show_bug.cgi?id=66806
1258
1259         Reviewed by Dirk Pranke.
1260
1261         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
1262         trace.
1263
1264         * Scripts/webkitpy/layout_tests/port/chromium.py:
1265
1266 2011-08-24  Adam Barth  <abarth@webkit.org>
1267
1268         Remove empty directory.
1269
1270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
1271
1272 2011-08-24  Adam Barth  <abarth@webkit.org>
1273
1274         Finish writing up details-view in garden-o-matic
1275         https://bugs.webkit.org/show_bug.cgi?id=66891
1276
1277         Reviewed by Dimitri Glazkov.
1278
1279         This patch mostly just copies a bunch of CSS from main.css to
1280         summary.css.  Presumably we'll delete main.css soon.
1281
1282         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1284         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1287
1288 2011-08-24  James Robinson  <jamesr@chromium.org>
1289
1290         Some compositing LayoutTests flakily crashing on Mac 10.6
1291         https://bugs.webkit.org/show_bug.cgi?id=66740
1292
1293         Reviewed by Adam Barth.
1294
1295         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
1296         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
1297         chromium configuration.
1298
1299         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1300         (NPP_Destroy):
1301
1302 2011-08-24  Anton D'Auria  <adauria@apple.com>
1303
1304         No review necessary.
1305
1306         Adding myself to list of committers.
1307
1308         * Scripts/webkitpy/common/config/committers.py:
1309
1310 2011-08-24  Avi Drissman  <avi@google.com>
1311
1312         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
1313         https://bugs.webkit.org/show_bug.cgi?id=66875
1314
1315         Reviewed by James Robinson.
1316
1317         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1318         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1319
1320 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1321
1322         Make notifications appear in time order again.
1323         https://bugs.webkit.org/show_bug.cgi?id=66815
1324
1325         Reviewed by Adam Barth.
1326
1327         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
1328         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
1329
1330 2011-08-23  James Robinson  <jamesr@chromium.org>
1331
1332         [chromium] Need a way to test lost compositor context recovery
1333         https://bugs.webkit.org/show_bug.cgi?id=66820
1334
1335         Reviewed by Kenneth Russell.
1336
1337         Exposes a LayoutTestController interface in chromium to simulate a
1338         lost compositor context.
1339
1340         * DumpRenderTree/chromium/LayoutTestController.cpp:
1341         (LayoutTestController::LayoutTestController):
1342         (LayoutTestController::loseCompositorContext):
1343         * DumpRenderTree/chromium/LayoutTestController.h:
1344
1345 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1346
1347         Change garden-o-matic frontend builder array to be a configuration map.
1348         https://bugs.webkit.org/show_bug.cgi?id=66816
1349
1350         Reviewed by Adam Barth.
1351
1352         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
1353         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
1354         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
1355         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
1356         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
1357
1358 2011-08-23  Cary Clark  <caryclark@google.com>
1359
1360         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
1361         https://bugs.webkit.org/show_bug.cgi?id=66803
1362
1363         This fixes the WebKit Canaries, in particular avoids a crash on tests
1364         like css1/basic/comments.html.
1365
1366         Reviewed by James Robinson.
1367
1368         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1369         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1370         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
1371         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
1372         and treated it as if it were a CGContextRef.
1373
1374 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1375
1376         Fix mergeChangeLogs test on native windows
1377         https://bugs.webkit.org/show_bug.cgi?id=66797
1378
1379         Reviewed by Adam Roben.
1380
1381         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
1382         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
1383
1384         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1385         (writeTempFile):
1386
1387 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1388
1389         garden-o-matic relative time is wrong and updates too frequently.
1390         https://bugs.webkit.org/show_bug.cgi?id=66802
1391
1392         Reviewed by Adam Barth.
1393
1394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
1395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
1397
1398 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1399
1400         Add missing quotes around filenames in mergeChangeLogs
1401         https://bugs.webkit.org/show_bug.cgi?id=66794
1402
1403         Reviewed by Adam Roben.
1404
1405         * Scripts/VCSUtils.pm:
1406         (mergeChangeLogs):
1407
1408 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1409
1410         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
1411         https://bugs.webkit.org/show_bug.cgi?id=49080
1412
1413         Reviewed by Adam Roben.
1414
1415         Use the string form of pipe open instead (like we do at all other places).
1416
1417         * Scripts/VCSUtils.pm:
1418         (mergeChangeLogs):
1419
1420 2011-08-23  Adam Barth  <abarth@webkit.org>
1421
1422         garden-o-matic summary should be able to examine failures
1423         https://bugs.webkit.org/show_bug.cgi?id=66748
1424
1425         Reviewed by Dimitri Glazkov.
1426
1427         This patch refactors a bunch of code from summary.js to independent
1428         controllers in controllers.js.  This patch also contains the first
1429         iteration of binding the "examine" event to a the behavior showing the
1430         details view for the tests.  There's more work to do here to make this
1431         work properly (and elegantly), but this patch is a start.
1432
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
1437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1440         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1441         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1442
1443 2011-08-23  Adam Barth  <abarth@webkit.org>
1444
1445         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
1446         https://bugs.webkit.org/show_bug.cgi?id=66737
1447
1448         Reviewed by Steve Block.
1449
1450         This directory doesn't exist anymore now that the Android port shares
1451         more code with Chromium.
1452
1453         * Scripts/webkitpy/common/config/build.py:
1454
1455 2011-08-22  Eric Seidel  <eric@webkit.org>
1456
1457         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
1458         I won't have ssh access to the bot again for a couple days, so
1459         attempting to fix by changing this script.  If this doesn't
1460         work we'll just live with the it hung for now.
1461
1462         Unreviewed.
1463
1464         * EWSTools/start-queue.sh:
1465
1466 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1467
1468         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
1469         https://bugs.webkit.org/show_bug.cgi?id=66727
1470
1471         Reviewed by Adam Barth.
1472
1473         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
1474             in which case the serializer treats all expectations as unparsed.
1475         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
1476
1477 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1478
1479         Update unit test expectations after r93530.
1480
1481         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
1482         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1483
1484 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1485
1486         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
1487         https://bugs.webkit.org/show_bug.cgi?id=66705
1488
1489         Reviewed by Adam Barth.
1490
1491         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
1492         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
1493
1494 2011-08-22  James Robinson  <jamesr@chromium.org>
1495
1496         [chromium] Update builder names for chromium gpu bots due to CG switchover
1497         https://bugs.webkit.org/show_bug.cgi?id=66693
1498
1499         Reviewed by Dirk Pranke.
1500
1501         Update the port and builder names for the chromium mac gpu bots to
1502         account for the CG transition.
1503
1504         * Scripts/webkitpy/layout_tests/port/builders.py:
1505
1506 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
1507
1508         fix the GPU bot names on the layout test dashboard
1509         https://bugs.webkit.org/show_bug.cgi?id=66697
1510
1511         Reviewed by Dimitri Glazkov.
1512
1513         * TestResultServer/static-dashboards/builders.js:
1514
1515 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1516
1517         garden-o-matic's relative time display should be updated regularly.
1518         https://bugs.webkit.org/show_bug.cgi?id=66682
1519
1520         Reviewed by Adam Barth.
1521
1522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
1523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
1524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
1525
1526 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1527
1528         Pass --makeargs of build-webkit to chromium linux builder
1529         https://bugs.webkit.org/show_bug.cgi?id=66361
1530
1531         Reviewed by Tony Chang.
1532
1533         * Scripts/build-webkit:
1534         * Scripts/webkitdirs.pm:
1535         (buildChromiumMakefile):
1536         (buildChromium):
1537
1538 2011-08-22  Peter Beverloo  <peter@chromium.org>
1539
1540         Add myself to the contributor list.
1541         https://bugs.webkit.org/show_bug.cgi?id=66674
1542
1543         Reviewed by Tony Gentilcore.
1544
1545         * Scripts/webkitpy/common/config/committers.py:
1546
1547 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
1548
1549         [Qt] ImageDiff does not consider --tolerance
1550         https://bugs.webkit.org/show_bug.cgi?id=66299
1551
1552         Reviewed by Csaba Osztrogonác.
1553
1554         * DumpRenderTree/qt/ImageDiff.cpp:
1555         (main):
1556
1557 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
1558
1559         Update contributor list.
1560
1561         Reviewed by Zoltan Herczeg.
1562
1563         * Scripts/webkitpy/common/config/committers.py:
1564
1565 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1566
1567         [ORWT] Fix --reset-results --add-platform-exceptions combo
1568         https://bugs.webkit.org/show_bug.cgi?id=65464
1569
1570         Reviewed by Csaba Osztrogonác.
1571
1572         * Scripts/old-run-webkit-tests:
1573
1574 2011-08-20  Adam Barth  <abarth@webkit.org>
1575
1576         garden-o-matic summary.html should have UI for examining failures
1577         https://bugs.webkit.org/show_bug.cgi?id=66625
1578
1579         Reviewed by Dimitri Glazkov.
1580
1581         This patch introduces the notion of UI actions and converts our
1582         existing manual <button> manipulation with this new abstraction.  The
1583         patch also adds an Examine button to failure notifications.  In a
1584         future patch, I'll add a controller that wires this button up to
1585         something useful.
1586
1587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1588         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
1590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
1591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1595
1596 2011-08-20  Adam Barth  <abarth@webkit.org>
1597
1598         garden-o-matic summary page should indiciate compile failures
1599         https://bugs.webkit.org/show_bug.cgi?id=66624
1600
1601         Reviewed by Dimitri Glazkov.
1602
1603         This patch creates a notification-based UI for build failures.  The new
1604         UI displays the same information that used to be displayed in the
1605         infobar.  There's lots of room for improvement in surfacing more
1606         information, but this is a start.
1607
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1610         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1611
1612 2011-08-19  James Robinson  <jamesr@chromium.org>
1613
1614         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
1615         https://bugs.webkit.org/show_bug.cgi?id=66606
1616
1617         Reviewed by Dirk Pranke.
1618
1619         The chromium GPU configuration does not (currently) contain any tests
1620         incompatible with --experimental-fully-parallel, and this flag is a
1621         significan speedup because of the directory canvas/philip/tests which
1622         contains 802 tests in the same directory. Setting this option by
1623         default on this configuration is a 2x speed in release, 44s to 22s,
1624         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
1625
1626         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1627         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1628         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1629
1630 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1631
1632         Unreviewed, rolling out r93426.
1633         http://trac.webkit.org/changeset/93426
1634         https://bugs.webkit.org/show_bug.cgi?id=66607
1635
1636         Broke the Mac build by not building gtest.framework anymore
1637         (Requested by andersca on #webkit).
1638
1639         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1640
1641 2011-08-19  James Robinson  <jamesr@chromium.org>
1642
1643         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
1644         https://bugs.webkit.org/show_bug.cgi?id=66603
1645
1646         Reviewed by Dirk Pranke.
1647
1648         The various ChromiumGpu ports should use the same child worker
1649         selection logic as other ports so they can run with full
1650         parallelization on multicore systems.
1651
1652         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1653         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1654
1655 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
1656
1657         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
1658         https://bugs.webkit.org/show_bug.cgi?id=66570
1659
1660         Reviewed by Mihai Parparita.
1661
1662         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1663         (WebThemeControlDRTWin::draw):
1664         (WebThemeControlDRTWin::drawTextField):
1665         (WebThemeControlDRTWin::drawProgressBar):
1666         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1667
1668 2011-08-18  Dmitry Lomov  <dslomov@google.com>
1669
1670         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
1671         https://bugs.webkit.org/show_bug.cgi?id=66521
1672
1673         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
1674
1675         Reviewed by David Levin.
1676
1677         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
1678
1679 2011-08-19  Adam Roben  <aroben@apple.com>
1680
1681         Add project file changes I left out in r93417
1682
1683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1684
1685 2011-08-19  Adam Roben  <aroben@apple.com>
1686
1687         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
1688
1689         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
1690         NSScreen
1691
1692         Reviewed by Anders Carlsson.
1693
1694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1695
1696         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
1697         (-[SimpleObject setValue:]): Original implementation.
1698
1699         (TestWebKitAPI::setValue2):
1700         (TestWebKitAPI::setValue3):
1701         Swizzled implementations.
1702
1703         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
1704         instance method.
1705
1706         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
1707         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
1708         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
1709         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
1710
1711 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
1712
1713         Fix _path_to_apache() error reporting
1714         https://bugs.webkit.org/show_bug.cgi?id=66486
1715
1716         Reviewed by Ryosuke Niwa.
1717
1718         * Scripts/webkitpy/layout_tests/port/webkit.py:
1719
1720 2011-08-19  Adam Roben  <aroben@apple.com>
1721
1722         Windows build fix after r93404
1723
1724         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
1725
1726 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
1727
1728         Add leandrogracia to the committers list
1729         https://bugs.webkit.org/show_bug.cgi?id=66552
1730
1731         Also fix line endings in file.
1732
1733         No reviewed required.
1734
1735         * Scripts/webkitpy/common/config/committers.py:
1736
1737 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
1738
1739         Fix compilation issue in WebKitTestRunner
1740         https://bugs.webkit.org/show_bug.cgi?id=66554
1741
1742         Reviewed by Martin Robinson.
1743
1744         * WebKitTestRunner/PixelDumpSupport.cpp:
1745
1746 2011-08-19  Adam Roben  <aroben@apple.com>
1747
1748         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
1749
1750         This will make it easier to write other WebKit-agnostic tests
1751
1752         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
1753         code in other WebKit-agnostic tests
1754
1755         Reviewed by Anders Carlsson.
1756
1757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1758
1759         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
1760         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
1761         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
1762         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
1763         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
1764         WebKitAgnosticTest handles for us.
1765         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
1766
1767         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
1768         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
1769         DynamicDeviceScaleFactor::runTest.
1770
1771         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
1772         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
1773         DynamicDeviceScaleFactor.WebKit.
1774         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
1775         DynamicDeviceScaleFactor.WebKit2.
1776
1777 2011-08-19  Adam Roben  <aroben@apple.com>
1778
1779         Clean up #includes in TestWebKitAPI
1780
1781         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
1782
1783         Reviewed by Anders Carlsson.
1784
1785         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
1786         files and WebKit/WebKit.h for ObjC files.
1787
1788         * TestWebKitAPI/InjectedBundleController.cpp:
1789         * TestWebKitAPI/JavaScriptTest.h:
1790         * TestWebKitAPI/PlatformUtilities.h:
1791         * TestWebKitAPI/PlatformWebView.h:
1792         * TestWebKitAPI/Test.h:
1793         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1794         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1795         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
1796         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1797         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1798         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1799         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1800         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1801         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1802         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1803         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1804         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1805         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1806         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1807         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1808         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1809         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1810         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1811         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1812         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1813         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1814         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1815         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1816         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1817         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1818         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1819         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1820         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1821         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1822         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1823         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1824         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1825         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1826         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1827         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1828         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1829         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1830         * TestWebKitAPI/TestsController.cpp:
1831         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1832         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
1833         #includes since it is no longer a special header.
1834
1835 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
1836
1837         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
1838         https://bugs.webkit.org/show_bug.cgi?id=64886
1839
1840         Temporarily disable the http locking to work around the issue.
1841         I'm not actually sure if this is going to work or improve things
1842         much.
1843
1844         Reviewed by Ryosuke Niwa.
1845
1846         * Scripts/webkitpy/layout_tests/port/mac.py:
1847
1848 2011-08-18  Tony Chang  <tony@chromium.org>
1849
1850         add embedded png checksums to WebKitTestRunner
1851         https://bugs.webkit.org/show_bug.cgi?id=66494
1852
1853         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
1854         some code from DRT and adds it to the WebKitTestRunner.
1855
1856         Reviewed by Darin Adler.
1857
1858         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
1859         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
1860         * WebKitTestRunner/GNUmakefile.am: Add new files
1861         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
1862         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
1863         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
1864         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1865         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
1866         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1867         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1868         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
1869         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1870         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
1871
1872 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
1873
1874         https://bugs.webkit.org/show_bug.cgi?id=47240
1875
1876         Fixed a cygwin path problem in the chromium port of diff_image;
1877         Also made the return values of the diff_image function more consistent.
1878
1879         Reviewed by Dirk Pranke.
1880
1881         * Scripts/webkitpy/layout_tests/port/chromium.py:
1882
1883 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
1884
1885         [GTK] Fix compilation problems with deprecations in gtk+
1886         https://bugs.webkit.org/show_bug.cgi?id=66073
1887
1888         Reviewed by Martin Robinson.
1889
1890         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1891         (main): G_CONST_RETURN was deprecated
1892         * GtkLauncher/main.c:
1893         (createWindow): Added gtk_box_new conditional compilation for
1894         gtk+-3.
1895         * MiniBrowser/gtk/BrowserWindow.c:
1896         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
1897         are just supporting gtk+-3 for WebKit2.
1898
1899 2011-08-18  Anders Carlsson  <andersca@apple.com>
1900
1901         Fix libc++ C++0x build
1902         https://bugs.webkit.org/show_bug.cgi?id=66479
1903
1904         Reviewed by Adam Roben.
1905
1906         Add missing includes.
1907
1908         * DumpRenderTree/LayoutTestController.cpp:
1909         * DumpRenderTree/mac/CheckedMalloc.cpp:
1910
1911 2011-08-18  Adam Roben  <aroben@apple.com>
1912
1913         Test that WebKit updates style when a WebView is moved between differently-scaled windows
1914
1915         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
1916         WebView is moved between windows with different backing scale factors
1917
1918         Reviewed by Anders Carlsson.
1919
1920         * TestWebKitAPI/JavaScriptTest.cpp:
1921         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
1922         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
1923         gtest's built-in error messages.
1924
1925         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
1926         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
1927         those overloads.
1928
1929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1930
1931         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
1932         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
1933         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
1934         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
1935         (TestWebKitAPI::setPageLoaderClient): Set up the client.
1936         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
1937         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
1938         SyntheticBackingScaleFactorWindow and returns it.
1939         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
1940         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
1941         window, is moved to a differently-scaled window, and is taken out of the window.
1942         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
1943         WebKit1 and WebKit2.
1944         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
1945
1946         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
1947
1948         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
1949         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
1950
1951         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
1952         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
1953         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
1954         initializer.
1955         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
1956
1957         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
1958         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
1959         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
1960
1961 2011-08-18  Dmitry Lomov  <dslomov@google.com>
1962
1963         https://bugs.webkit.org/show_bug.cgi?id=66425
1964         check-webkit-style should detect incorrectly formatted file change descriptions.
1965         Description, if present, should be separated from colon with a space.
1966
1967         Reviewed by David Levin.
1968
1969         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
1970         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
1971
1972 2011-08-18  Adam Barth  <abarth@webkit.org>
1973
1974         webkit-patch pretty-diff should be shown in main help
1975         https://bugs.webkit.org/show_bug.cgi?id=66404
1976
1977         Reviewed by Dimitri Glazkov.
1978
1979         As requested by dglazkov.
1980
1981         * Scripts/webkitpy/tool/commands/prettydiff.py:
1982
1983 2011-08-17  Dmitry Lomov  <dslomov@google.com>
1984
1985         https://bugs.webkit.org/show_bug.cgi?id=66400
1986         Fix TestWebKitAPI build on Mac OS.
1987
1988         Reviewed by David Levin.
1989
1990         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
1991
1992 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
1993
1994         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
1995         https://bugs.webkit.org/show_bug.cgi?id=66427
1996
1997         Reviewed by Adam Barth.
1998
1999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
2000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
2001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
2002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
2003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
2004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
2005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
2006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
2007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
2008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
2009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
2010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
2011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
2012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
2013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
2014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
2015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
2016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
2017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
2018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
2019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
2020         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
2021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
2022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
2023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
2024         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
2025         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
2026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
2027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
2028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
2029         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
2030         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
2031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
2032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
2033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
2034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
2035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
2036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
2037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
2038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
2039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
2041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
2043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
2045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
2046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
2047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
2049         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
2050         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
2051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
2052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
2053         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2054         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
2055         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
2056         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
2057         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
2058         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
2059         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
2063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
2064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
2065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
2066         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
2067         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
2068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
2069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
2070         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
2071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
2072         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
2073         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
2074         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
2075         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
2076         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
2077         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
2078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
2079         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
2080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
2081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
2082         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
2083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
2084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
2085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
2086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
2087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
2088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
2089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
2090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
2091         ():
2092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
2093         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
2094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
2095         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
2096         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
2097         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
2098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
2099         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
2101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
2102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
2103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
2104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
2105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
2106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
2108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
2109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
2110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
2111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
2112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
2113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
2114
2115 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
2116
2117         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
2118         https://bugs.webkit.org/show_bug.cgi?id=65877
2119
2120         Reviewed by Eric Seidel.
2121
2122         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2123
2124 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2125
2126         Remove base.keys and replace it with Object.keys.
2127         https://bugs.webkit.org/show_bug.cgi?id=66422
2128
2129         Reviewed by Adam Barth.
2130
2131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
2132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
2133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
2134
2135 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2136
2137         garden-o-matic Summary view should have items in descending chronological order.
2138         https://bugs.webkit.org/show_bug.cgi?id=66403
2139
2140         Reviewed by Adam Barth.
2141
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
2143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
2144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
2145
2146 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2147
2148         Fix a few errors in garden-o-matic frontend unit tests.
2149         https://bugs.webkit.org/show_bug.cgi?id=66421
2150
2151         Reviewed by Adam Barth.
2152
2153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
2154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
2155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
2156
2157 2011-08-17  Adam Barth  <abarth@webkit.org>
2158
2159         Update Tools to account for (CG) being added to Chromium builder names
2160         https://bugs.webkit.org/show_bug.cgi?id=66410
2161
2162         Reviewed by Adam Barth.
2163
2164         Some of these names will change back once we turn on Skia bots.
2165
2166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
2167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2169         * Scripts/webkitpy/layout_tests/port/builders.py:
2170         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2171         * TestResultServer/static-dashboards/builders.js:
2172         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2173
2174 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2175
2176         Wire up relative time to garden-o-matic summary view.
2177         https://bugs.webkit.org/show_bug.cgi?id=66343
2178
2179         Reviewed by Adam Barth.
2180
2181         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
2182         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
2183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
2184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
2186
2187 2011-08-17  Adam Roben  <aroben@apple.com>
2188
2189         Make run-api-tests run tests in alphabetical order
2190
2191         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
2192
2193         Reviewed by David Kilzer.
2194
2195         * Scripts/run-api-tests:
2196         (runAllTests):
2197         (runAllTestsInSuite):
2198         Sort the lists of tests and suites before iterating over them.
2199
2200 2011-08-17  Adam Barth  <abarth@webkit.org>
2201
2202         garden-o-matic should be able to rebaseline expected failures
2203         https://bugs.webkit.org/show_bug.cgi?id=66204
2204
2205         Reviewed by Dimitri Glazkov.
2206
2207         This patch introduces a new view for displaying expect, actual, and
2208         differences between results.  The new view also has a fledgling
2209         controller that handles some basic operations.  The new view is
2210         exercised by rebaseline.html, which lets you rebaselines expected
2211         failures, but the new view is not fully integrated into
2212         garden-o-matic.html
2213
2214         More patches will be required to make this stuff fully working, but
2215         this patch was already somewhat spiraling out of control.  Hopefully
2216         this patch will serve as a good starting point for further development.
2217
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
2219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
2221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2223         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
2225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2227         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
2229         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
2230
2231 2011-08-16  Chang Shu  <cshu@webkit.org>
2232
2233         Support reset in WebCore::Internals
2234         https://bugs.webkit.org/show_bug.cgi?id=66307
2235
2236         Reviewed by Dimitri Glazkov.
2237
2238         Added call to resetInternalsObject in DRT.
2239
2240         * DumpRenderTree/chromium/TestShell.cpp:
2241         (TestShell::resetTestController):
2242         * DumpRenderTree/mac/DumpRenderTree.mm:
2243         (resetWebViewToConsistentStateBeforeTesting):
2244         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2245         (WebCore::WebPage::resetSettings):
2246
2247 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
2248
2249         Add a new build slave for the Qt port on Mac OS SnowLeopard.
2250         https://bugs.webkit.org/show_bug.cgi?id=66392
2251
2252         Modify the config file to include the new build slave.
2253
2254         Reviewed by Adam Roben.
2255
2256         * BuildSlaveSupport/build.webkit.org-config/config.json:
2257
2258 2011-08-17  Sam White  <samuel.white@rochester.edu>
2259
2260         AccessibilityObject levels are inconsistent
2261         https://bugs.webkit.org/show_bug.cgi?id=66180
2262         
2263         Added the ability to get numeric attribute values using numberAttributeValue. This
2264         function complements the existing stringAttributeValue and boolAttributeValue functions.
2265         The addition of numberAttributeValue was necessary because the stringAttributeValue
2266         function does a type check and will only return strings. This limitation made it
2267         impossible to get values for attributes that returned an NSNumber.
2268
2269         Reviewed by Chris Fleizach.
2270
2271         * DumpRenderTree/AccessibilityUIElement.cpp:
2272         (numberAttributeValueCallback):
2273         (AccessibilityUIElement::getJSClass):
2274         * DumpRenderTree/AccessibilityUIElement.h:
2275         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2276         (AccessibilityUIElement::numberAttributeValue):
2277         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2278         (AccessibilityUIElement::numberAttributeValue):
2279         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2280         (AccessibilityUIElement::numberAttributeValue):
2281
2282 2011-08-17  Adam Roben  <aroben@apple.com>
2283
2284         Tell Trac logs always to display all specified revisions in a single page
2285
2286         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
2287         revisions than that.
2288
2289         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
2290         relevant revisions
2291
2292         Reviewed by Daniel Bates.
2293
2294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2295         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
2296         a single page.
2297
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
2300         Updated tests for the above.
2301
2302 2011-08-17  Adam Roben  <aroben@apple.com>
2303
2304         Fix TestFailures's link to file a bug about TestFailures itself
2305
2306         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
2307         bug about itself is broken
2308
2309         Reviewed by Dan Bates.
2310
2311         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2312         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
2313         the host from the path.
2314
2315 2011-08-17  Adam Roben  <aroben@apple.com>
2316
2317         Teach TestFailures to ignore unbelievably short test runs
2318
2319         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
2320         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
2321
2322         Reviewed by Dan Bates.
2323
2324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2325         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
2326         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
2327         that caused it not to run any tests at all (as happened for a while due to
2328         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
2329
2330         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2331         Test for the above.
2332
2333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2334         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
2335
2336 2011-08-16  Adam Barth  <abarth@webkit.org>
2337
2338         Add a CG qualifier similar to the GPU qualifier
2339         https://bugs.webkit.org/show_bug.cgi?id=66359
2340
2341         Reviewed by Eric Seidel.
2342
2343         Once we have a Skia configuration on Chromium Mac, we'll use this CG
2344         qualifier to note that expectations apply only to the CG configuration.
2345
2346         * Scripts/webkitpy/layout_tests/port/chromium.py:
2347         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2348
2349 2011-08-16  Eric Seidel  <eric@webkit.org>
2350
2351         REGRESSION(92717): WinPort needs to parse version information from port_name
2352         https://bugs.webkit.org/show_bug.cgi?id=66325
2353
2354         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
2355
2356         * Scripts/webkitpy/layout_tests/port/mac.py:
2357         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2358
2359 2011-08-16  Adam Barth  <abarth@webkit.org>
2360
2361         Change webkit-patch analyze-baselines to print in a more unix-friendly way
2362         https://bugs.webkit.org/show_bug.cgi?id=66349
2363
2364         Reviewed by James Robinson.
2365
2366         As requested by jamesr.
2367
2368         * Scripts/webkitpy/tool/commands/rebaseline.py:
2369
2370 2011-08-16  Eric Seidel  <eric@webkit.org>
2371
2372         REGRESSION(92717): WinPort needs to parse version information from port_name
2373         https://bugs.webkit.org/show_bug.cgi?id=66325
2374
2375         Reviewed by Adam Barth.
2376
2377         WinPort didn't have any port_name parsing logic.
2378         Seemed it was best to just share the logic from MacPort.
2379         Sharing the logic from MacPort seemed easiest with a shared superclass.
2380         Once I created ApplePort (the superclass) there was a bunch of logic to share.
2381         I found LeakDetector was just in the way when switching back and forth
2382         between win.py and mac.py so I moved it into its own file.
2383
2384         The only logic change here is that WinPort should now be
2385         able to parse port_name values like MacPort (and other ports)
2386         can.  The fact that ports do this in their constructors is
2387         wrong and a source of many bugs.  But at least now WinPort
2388         matches the status-quo.
2389
2390         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
2391         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
2392         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
2393         * Scripts/webkitpy/layout_tests/port/mac.py:
2394         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2395         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2396         * Scripts/webkitpy/layout_tests/port/win.py:
2397         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2398
2399 2011-08-16  Adam Barth  <abarth@webkit.org>
2400
2401         Add webkit-patch analyze-baselines, as requested by jamesr.
2402
2403         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2404         * Scripts/webkitpy/tool/commands/rebaseline.py:
2405
2406 2011-08-16  Adam Barth  <abarth@webkit.org>
2407
2408         Fold bulk-optimize-baselines into optimize-baselines
2409         https://bugs.webkit.org/show_bug.cgi?id=66345
2410
2411         Reviewed by James Robinson.
2412
2413         bulk-optimize-baselines is now a superset of optimize-baselines, so
2414         they can be combined.
2415
2416         * Scripts/webkitpy/tool/commands/rebaseline.py:
2417
2418 2011-08-16  Adam Barth  <abarth@webkit.org>
2419
2420         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
2421         https://bugs.webkit.org/show_bug.cgi?id=66334
2422
2423         Reviewed by Tony Chang.
2424
2425         This patch moves us closer to switching the Chromium port from
2426         CoreGraphics to Skia.  This patch teaches our tools that the current
2427         Chromium Mac configuration is actually chromium-cg-mac, which makes
2428         room for a future chromium-mac configuration that uses Skia.
2429
2430         Shortly after this patch lands, I'll do a server-side move of the
2431         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
2432         and chromium-cg-mac-leopard.
2433
2434         * BuildSlaveSupport/build.webkit.org-config/config.json:
2435         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2436         * Scripts/webkitpy/common/config/build.py:
2437         * Scripts/webkitpy/common/config/build_unittest.py:
2438         * Scripts/webkitpy/layout_tests/port/base.py:
2439         * Scripts/webkitpy/layout_tests/port/builders.py:
2440         * Scripts/webkitpy/layout_tests/port/chromium.py:
2441         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2442         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2443         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2444         * Scripts/webkitpy/layout_tests/port/factory.py:
2445         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2446         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2447         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2448         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2449         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2450         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2451         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2452
2453 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2454
2455         garden-o-matic frontend needs a friendly relative time description method.
2456         https://bugs.webkit.org/show_bug.cgi?id=66324
2457
2458         Reviewed by Adam Barth.
2459
2460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
2461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
2462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
2463
2464 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2465
2466         Summary view should not add multiple entries for the same test failure.
2467         https://bugs.webkit.org/show_bug.cgi?id=66318
2468
2469         Reviewed by Adam Barth.
2470
2471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
2472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
2473             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
2474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2475
2476 2011-08-16  Adam Roben  <aroben@apple.com>
2477
2478         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
2479
2480         The basic strategy here is that once a test has failed or passed many times in a row we
2481         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
2482         in many fewer false positives than our current behavior.
2483
2484         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
2485         flaky, including tests that failed for a while but then were fixed
2486
2487         Reviewed by Dan Bates.
2488
2489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
2490         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
2491         number of non-too-many-failure builds we've seen.
2492         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
2493         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
2494         tests, keep track of how many times they have passed or failed in a row. If they pass or
2495         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
2496         considered flaky it doesn't matter how many times it passes or fails.)
2497
2498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
2499         Added tests for the above.
2500
2501 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2502
2503         garden-o-matic needs a summary view with actions for each problem.
2504         https://bugs.webkit.org/show_bug.cgi?id=66144
2505
2506         Reviewed by Adam Barth.
2507
2508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
2509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
2512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
2513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
2514
2515 2011-08-16  Dean Jackson  <dino@apple.com>
2516
2517         Adding Ted "hober" O'Connor as a non-committing contributor.
2518
2519         * Scripts/webkitpy/common/config/committers.py:
2520
2521 2011-08-16  Adam Roben  <aroben@apple.com>
2522
2523         Teach TestFailures how to interpret unfinished test runs
2524
2525         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
2526         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
2527
2528         Reviewed by David Kilzer.
2529
2530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2531         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
2532         rather than "isStarted" so that we don't count builds for which the test run never finished.
2533         Bumped the cache version to evict old, buggy cached data.
2534
2535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2536         Added a test for the above, and made a somewhat synthetic test more realistic by including
2537         more of the actual JSON data from build.webkit.org.
2538
2539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2540         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
2541         cached data.
2542
2543 2011-08-16  Adam Roben  <aroben@apple.com>
2544
2545         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
2546
2547         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
2548         should match Lion's behavior.
2549
2550         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
2551         but doesn't use Lion results
2552
2553         Reviewed by David Kilzer.
2554
2555         * Scripts/old-run-webkit-tests:
2556         (expectedDirectoryForTest):
2557         * Scripts/webkitpy/layout_tests/port/win.py:
2558         (WinPort.baseline_search_path):
2559         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2560         (WinPortTest.test_baseline_search_path):
2561         Replaced mac-snowleopard with mac-lion.
2562
2563         * Scripts/webkitpy/common/config/build.py:
2564         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
2565         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
2566         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
2567         will no longer look there for results.
2568
2569         * Scripts/webkitpy/common/config/build_unittest.py:
2570         (ShouldBuildTest.test_should_build): Tests for the above changes.
2571
2572 2011-08-16  Dean Jackson  <dino@apple.com>
2573
2574         Move me from contributor to reviewer.
2575
2576         * Scripts/webkitpy/common/config/committers.py:
2577
2578 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2579
2580         garden-o-matic frontend needs model.commitDataForRevisionRange function.
2581         https://bugs.webkit.org/show_bug.cgi?id=66252
2582
2583         Reviewed by Adam Barth.
2584
2585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
2586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
2587
2588 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2589
2590         garden-o-matic frontend needs a generic way to track updates.
2591         https://bugs.webkit.org/show_bug.cgi?id=66245
2592
2593         Reviewed by Adam Barth.
2594
2595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
2597
2598 2011-08-15  Adam Roben  <aroben@apple.com>
2599
2600         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
2601
2602         Failures now give output of the form: foo should be bar but is baz
2603
2604         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
2605         test is in TestWebKitAPI's output
2606
2607         Reviewed by David Levin.
2608
2609         * TestWebKitAPI/JavaScriptTest.cpp:
2610         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
2611         members.
2612         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
2613         object, rather than doing any testing of it here.
2614         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
2615         to use a pretty error message when the test fails.
2616
2617         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
2618         gtest-style macros that wrap it.
2619
2620         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
2621
2622         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2623         (TestWebKitAPI::TEST): Changed to use the new macros.
2624
2625         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2626         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
2627         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
2628         the test passes, though. Returning early seems to have been an unnecessary optimization.
2629
2630         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2631         (TestWebKitAPI::TEST): Changed to use the new macros.
2632
2633 2011-08-15  Eric Seidel  <eric@webkit.org>
2634
2635         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
2636
2637         Unreviewed.
2638
2639         * Scripts/run-webkit-tests:
2640         (usingLeaks):
2641         (useNewRunWebKitTests):
2642
2643 2011-08-14  Adam Barth  <abarth@webkit.org>
2644
2645         Switch results detail view over to new-style object-oriented UI widgets
2646         https://bugs.webkit.org/show_bug.cgi?id=66200
2647
2648         Reviewed by Dimitri Glazkov.
2649
2650         This patch replaces my goofy template-based UI for the results
2651         comparison screen with new object-oriented UI widgets.
2652
2653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2658         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
2659         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2660
2661 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
2662
2663         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
2664         https://bugs.webkit.org/show_bug.cgi?id=66166
2665
2666         Also changed base.RequestTracker to:
2667         a) fire callback immediately if requestsInFlight is 0;
2668         b) not barf if callback is not supplied.
2669
2670         Reviewed by Adam Barth.
2671
2672         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
2673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
2674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
2675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
2676
2677 2011-08-12  Mark Rowe  <mrowe@apple.com>
2678
2679         Be more forward-looking in the choice of compiler.
2680
2681         Rubber-stamped by Jon Honeycutt.
2682
2683         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
2684         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
2685         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2686         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
2687
2688 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2689
2690         DRT: Add support for gesture events.
2691         https://bugs.webkit.org/show_bug.cgi?id=66105
2692
2693         Reviewed by Darin Fisher.
2694
2695         * DumpRenderTree/chromium/EventSender.cpp:
2696         (EventSender::EventSender):
2697         (EventSender::gestureScrollBegin):
2698         (EventSender::gestureScrollEnd):
2699         (EventSender::gestureTap):
2700         (EventSender::gestureEvent):
2701         * DumpRenderTree/chromium/EventSender.h:
2702
2703 2011-08-12  Andy Estes  <aestes@apple.com>
2704
2705         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
2706         https://bugs.webkit.org/show_bug.cgi?id=66158
2707
2708         Reviewed by Dan Bernstein.
2709
2710         * DumpRenderTree/LayoutTestController.cpp:
2711         (allowRoundingHacksCallback): The third argument is the 'this'
2712         JSObjectRef, not the second.
2713
2714 2011-08-12  Andy Estes  <aestes@apple.com>
2715
2716         Cancel in onbeforeunload dialog sometime causes a button to stop working.
2717         https://bugs.webkit.org/show_bug.cgi?id=26211
2718
2719         Reviewed by Alexey Proskuryakov.
2720
2721         Implement a new LayoutTestController method that a test can call to set
2722         the return value of DumpRenderTree's beforeunload UI delegate.
2723
2724         * DumpRenderTree/LayoutTestController.cpp:
2725         (LayoutTestController::LayoutTestController): Initialize
2726         m_shouldStayOnPageAfterHandlingBeforeUnload.
2727         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
2728         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
2729         (LayoutTestController::staticFunctions): Register
2730         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
2731         * DumpRenderTree/LayoutTestController.h: 
2732         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
2733         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
2734         * DumpRenderTree/chromium/LayoutTestController.cpp:
2735         (LayoutTestController::LayoutTestController): Initialize
2736         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
2737         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
2738         (LayoutTestController::reset): Reset
2739         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
2740         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
2741         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
2742         from JavaScript.
2743         * DumpRenderTree/chromium/LayoutTestController.h:
2744         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
2745         * DumpRenderTree/chromium/WebViewHost.cpp:
2746         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
2747         return the inverse of
2748         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
2749         * DumpRenderTree/mac/UIDelegate.mm:
2750         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
2751         * DumpRenderTree/win/UIDelegate.cpp:
2752         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2753         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2754         Define setShouldStayOnPageAfterHandlingBeforeUnload().
2755         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2756         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
2757         to the Test Controller telling it what value it should return in its
2758         onbeforeunload UI delegate.
2759         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2760         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2761         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
2762         Call InjectedBundle::postNewBeforeUnloadReturnValue().
2763         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2764         * WebKitTestRunner/TestController.cpp:
2765         (WTR::TestController::TestController): Initialize
2766         m_beforeUnloadReturnValue to true.
2767         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
2768         the value of TestController::beforeUnloadReturnValue().
2769         (WTR::TestController::resetStateToConsistentValues): Reset
2770         m_beforeUnloadReturnValue to true.
2771         * WebKitTestRunner/TestController.h:
2772         (WTR::TestController::beforeUnloadReturnValue):
2773         (WTR::TestController::setBeforeUnloadReturnValue):
2774         * WebKitTestRunner/TestInvocation.cpp:
2775         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
2776         message posted from the injected bundle by retrieving the message body
2777         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
2778
2779 2011-08-12  Sam Weinig  <sam@webkit.org>
2780
2781         Move compiler specific macros to their own header
2782         https://bugs.webkit.org/show_bug.cgi?id=66119
2783
2784         Reviewed by Anders Carlsson.
2785
2786         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
2787
2788 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
2789
2790         Add a way to extend DOM objects in garden-o-matic.
2791         https://bugs.webkit.org/show_bug.cgi?id=66096
2792
2793         Reviewed by Adam Barth.
2794
2795         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
2796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
2797
2798 2011-08-11  MORITA Hajime  <morrita@google.com>
2799
2800         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
2801         https://bugs.webkit.org/show_bug.cgi?id=45438
2802
2803         Reviewed by Kent Tamura.
2804
2805         MockSpellCheck was assuming the input of spellCheckWord() is a word.
2806         But it can be a series of word. This change made spellCheckWord()
2807         understand simple word boundary which appears in tests.
2808         
2809         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2810         (MockSpellCheck::spellCheckWord):
2811
2812 2011-08-11  Mark Rowe  <mrowe@apple.com>
2813
2814         Rework some Makefile logic to remove a double-negative.
2815
2816         Reviewed by Jon Honeycutt.
2817
2818         * DumpRenderTree/mac/PerlSupport/Makefile:
2819
2820 2011-08-11  Anders Carlsson  <andersca@apple.com>
2821
2822         Add a FIXME.
2823
2824         * TestWebKitAPI/TestsController.cpp:
2825         (TestWebKitAPI::TestsController::TestsController):
2826
2827 2011-08-11  Anders Carlsson  <andersca@apple.com>
2828
2829         Initialize threading before running any tests
2830         https://bugs.webkit.org/show_bug.cgi?id=66112
2831
2832         Reviewed by Adam Barth.
2833
2834         * TestWebKitAPI/TestsController.cpp:
2835         (TestWebKitAPI::TestsController::TestsController):
2836
2837 2011-08-11  Adam Barth  <abarth@webkit.org>
2838
2839         Add unexpected-passes.html to TestFailures for marking tests as passing
2840         https://bugs.webkit.org/show_bug.cgi?id=66102
2841
2842         Reviewed by Dimitri Glazkov.
2843
2844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2845         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2846             - Move some code into the library so it can be shared.
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2850             - Add round-trip unit tests.
2851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
2852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
2853             - I'm not entirely sure this feature should remain a separate HTML
2854               file, but it seemed better than cluttering up the main HTML file
2855               with too much extra stuff.
2856         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2857         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2858             - The gardening server couldn't handle adding PASS expectations.  Now it can.
2859
2860 2011-08-11  Eric Seidel  <eric@webkit.org>
2861
2862         NRWT has wrong fallback order for Mac now that Lion exists
2863         https://bugs.webkit.org/show_bug.cgi?id=66093
2864
2865         Reviewed by Adam Barth.
2866
2867         ORWT used a different system for fallback orders than NRWT did.
2868         I moved win.py to match ORWT fallback orders in bug 64486.
2869         This bug moves mac.py to match ORWT fallback order
2870         and adds 'lion' as a supported OS version.
2871
2872         Because ChromiumMac shares OS version detection code with AppleMac
2873         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
2874
2875         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2876         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2877         * Scripts/webkitpy/layout_tests/port/mac.py:
2878         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2879         * Scripts/webkitpy/layout_tests/port/win.py:
2880
2881 2011-08-11  Adam Barth  <abarth@webkit.org>
2882
2883         Update test results now that we use absolute URLs.
2884
2885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
2886
2887 2011-08-11  Adam Barth  <abarth@webkit.org>
2888
2889         garden-o-matic should be able to determine when tests unexpectedly pass
2890         https://bugs.webkit.org/show_bug.cgi?id=66092
2891
2892         Reviewed by Dimitri Glazkov.
2893
2894         This patch just contains the library methods for extracting this
2895         information.  I'll add some UI in a subsequent patch.
2896
2897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2898         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2899
2900 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
2901
2902         New expectation entries should be placed next to existing ones.
2903         https://bugs.webkit.org/show_bug.cgi?id=66066
2904
2905         Reviewed by Adam Barth.
2906
2907         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
2908             which is computed as the last found reference to the same test.
2909         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
2910
2911 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
2912
2913         Unreviewed, rolling out r92847.
2914         http://trac.webkit.org/changeset/92847
2915         https://bugs.webkit.org/show_bug.cgi?id=65986
2916
2917         Broke check-webkit-style
2918
2919         * Scripts/webkitpy/style/checker.py:
2920         * Scripts/webkitpy/style/checker_unittest.py:
2921
2922 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
2923
2924         Unreviewed, rolling out r92847.
2925         http://trac.webkit.org/changeset/92847
2926         https://bugs.webkit.org/show_bug.cgi?id=65986
2927
2928         Broke check-webkit-style
2929
2930         * Scripts/webkitpy/style/checker.py:
2931         * Scripts/webkitpy/style/checker_unittest.py:
2932
2933 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
2934
2935         [Qt] autotests shouldn't require config.h in the style check
2936         https://bugs.webkit.org/show_bug.cgi?id=65986
2937
2938         Remove the include rules from the style-check for Qt tests.
2939         Since for the most part it's just a matter of using the
2940         API provided by QtWebKit, enforcing the WebCore set of rules
2941         only seems to make sense in the case of MIMESniffing.
2942
2943         Reviewed by Benjamin Poulain.
2944
2945         * Scripts/webkitpy/style/checker.py:
2946         * Scripts/webkitpy/style/checker_unittest.py:
2947
2948 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2949
2950         [WK2] Implement waitForPolicyDelegate
2951         https://bugs.webkit.org/show_bug.cgi?id=42330
2952
2953         Reviewed by Csaba Osztrogonác.
2954
2955         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2956         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2957         (WTR::navigationTypeToString):
2958         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2959         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2960         (WTR::LayoutTestController::LayoutTestController):
2961         (WTR::LayoutTestController::setCustomPolicyDelegate):
2962         (WTR::LayoutTestController::waitForPolicyDelegate):
2963         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2964         (WTR::LayoutTestController::isPolicyDelegateEnabled):
2965         (WTR::LayoutTestController::isPolicyDelegatePermissive):
2966
2967 2011-08-11  Adam Barth  <abarth@webkit.org>
2968
2969         rebaseline-expectations should use the release bots, not the debug
2970         bots.  The debug bots don't all run all the tests.  Also, delay
2971         updating test_expectations a long as possible to avoid clearing out
2972         lines that we'll need for other ports.
2973
2974         * Scripts/webkitpy/layout_tests/port/builders.py:
2975         * Scripts/webkitpy/tool/commands/rebaseline.py:
2976         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2977
2978 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
2979
2980         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
2981         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
2982
2983         * BuildSlaveSupport/build.webkit.org-config/config.json:
2984
2985 2011-08-10  Eric Seidel  <eric@webkit.org>
2986
2987         new-run-webkit-test's WinPort has no fallback logic
2988         https://bugs.webkit.org/show_bug.cgi?id=64486
2989
2990         Unreviewed.
2991
2992         Turns out that we've long had a subtle bug whereby if you didn't
2993         already have DumpRenderTree built, we might end up running unsupported tests
2994         because the DumpRenderTree --print-supported-features check would silently fail.
2995
2996         When I moved the call from using popen to using Executive.run_command, this silent
2997         failure became noisy.  (Breaking some bots.)
2998
2999         This re-orders our steps so that we always build DRT before collecting expectations,
3000         as well as adds a warning message when DumpRenderTree can't be found.
3001
3002         * Scripts/webkitpy/layout_tests/port/webkit.py:
3003         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3004
3005 2011-08-10  Eric Seidel  <eric@webkit.org>
3006
3007         new-run-webkit-test's WinPort has no fallback logic
3008         https://bugs.webkit.org/show_bug.cgi?id=64486
3009
3010         Unreviewed.  Fix test-webkitpy under Python 2.5.
3011
3012         * Scripts/webkitpy/layout_tests/port/win.py:
3013
3014 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
3015
3016         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
3017         https://bugs.webkit.org/show_bug.cgi?id=65875
3018
3019         Reviewed by Kenneth Rohde Christiansen.
3020
3021         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
3022
3023         This causes mouse events to be sent twice in some cases. We work around the problem
3024         by defining the first touch point to be a primary touch point (case which hit some
3025         weird condition in QWidget, skipping the generation of fake mouse events).
3026
3027         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3028         (MiniBrowserApplication::notify):
3029
3030 2011-08-10  David Hyatt  <hyatt@apple.com>
3031
3032         https://bugs.webkit.org/show_bug.cgi?id=66004
3033
3034         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
3035         the code on by default.
3036
3037         Reviewed by Adam Roben.
3038
3039         * BuildSlaveSupport/build.webkit.org-config/config.json:
3040         * Scripts/build-webkit:
3041
3042 2011-08-10  Oliver Hunt  <oliver@apple.com>
3043
3044         JSEvaluteScript does not return the correct object when given JSONP data
3045         https://bugs.webkit.org/show_bug.cgi?id=66003
3046
3047         Reviewed by Gavin Barraclough.
3048
3049         Add a test case.
3050
3051         * DumpRenderTree/mac/DumpRenderTree.mm:
3052         (testStringByEvaluatingJavaScriptFromString):
3053
3054 2011-08-10  Eric Seidel  <eric@webkit.org>
3055
3056         WIN: NRWT runs compositing tests on configurations that don't support compositing
3057         https://bugs.webkit.org/show_bug.cgi?id=64472
3058
3059         Reviewed by Adam Barth.
3060
3061         I think the code was just wrong.  It was never splitting the string
3062         into list pieces before.
3063         I've now tested the supported_features code and theoretically it
3064         should now work with Windows DRT.
3065
3066         I also made the list-lookup functions always return lists, to make
3067         it possible to clean up the list-transform code in the future
3068         (I opted not to do that cleanup in this patch, but at least now
3069         both types of feature lookup functions match return types.)
3070
3071         * Scripts/webkitpy/layout_tests/port/webkit.py:
3072         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3073
3074 2011-08-10  Eric Seidel  <eric@webkit.org>
3075
3076         Clean up ChromiumDriver a little
3077         https://bugs.webkit.org/show_bug.cgi?id=65995
3078
3079         Unreviewed.
3080
3081         Fix NRWT for chromium.  Silly python.
3082
3083         * Scripts/webkitpy/layout_tests/port/chromium.py:
3084
3085 2011-08-10  Eric Seidel  <eric@webkit.org>
3086
3087         Clean up ChromiumDriver a little
3088         https://bugs.webkit.org/show_bug.cgi?id=65995
3089
3090         Reviewed by Adam Barth.
3091
3092         - We no longer support threading, so remove threading specific code.
3093         - Add FIXMEs about using ServerProcess instead.
3094         - Condense option-mapping if-cascade into a for loop.
3095         - Unindent long if blocks by using early return.
3096         - Unwrap lines which are needlessly wrapped.
3097
3098         There should be no functional changes here, just code cleanup/dead-code removal.
3099
3100         * Scripts/webkitpy/layout_tests/port/chromium.py:
3101
3102 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
3103
3104         Unmuddle construction options for TestConfiguration.
3105         https://bugs.webkit.org/show_bug.cgi?id=65988
3106
3107         The TestConfiguration instance is now constructed only using actual values.
3108         Port-based construction is split into a "from_port" class method.
3109
3110         Reviewed by Eric Seidel.
3111
3112         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
3113         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
3114         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
3115         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
3116         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
3117
3118 2011-08-10  Eric Seidel  <eric@webkit.org>
3119
3120         Leaks bot shows python logging prefixes as part of summary display
3121         https://bugs.webkit.org/show_bug.cgi?id=65931
3122
3123         Reviewed by Adam Barth.
3124
3125         The big part of this change is adding a unittesting system for
3126         master.cfg, so mere-mortals can make changes to build.webkit.org
3127         with greatly-reduced risk of breaking the world.
3128
3129         Turns out that in typing up my trival logging fix I made 2 typos,
3130         so hopefully the hour spent getting master.cfg to load was worth it. :)
3131
3132         I also tried to make mastercfg_unittest run as part of test-webkitpy
3133         but right now test-webkitpy requires that unittest files be located in
3134         a module-name-compatible directory.  'build.webkit.org-config' is not
3135         a valid module name.
3136
3137         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3138          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
3139            by using a new _strip_python_logging_prefix function.
3140          - Also fixed this function to file to work with a more modern
3141            simplejson version (which returns unicode objects instead of str objects)
3142            and filed a related bug with buildbot.net due to their handling of unicode builder names.
3143         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
3144          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
3145          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
3146         * Scripts/webkitpy/thirdparty/__init__.py:
3147          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
3148
3149 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
3150
3151         garden-o-matic should extrapolate failures given a set of known results
3152         https://bugs.webkit.org/show_bug.cgi?id=65882
3153
3154         Reviewed by Adam Barth.
3155
3156         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
3157         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
3158             adjusted all call sites.
3159         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
3160             makes wider net for specific failures.
3161         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
3162
3163 2011-08-10  Adam Barth  <abarth@webkit.org>
3164
3165         The URL we were computing for retrieving baselines was missing a slash
3166         character because our mocks had an extra slash character.  I've
3167         corrected both the code and the mock.
3168
3169         * Scripts/webkitpy/tool/commands/rebaseline.py:
3170         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3171         * Scripts/webkitpy/tool/mocktool.py:
3172
3173 2011-08-09  Adam Barth  <abarth@webkit.org>
3174
3175         Move the quote mark to the right place.
3176
3177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3178
3179 2011-08-09  Adam Barth  <abarth@webkit.org>
3180
3181         garden-o-matic should use huerstics to narrow regression range
3182         https://bugs.webkit.org/show_bug.cgi?id=65948
3183
3184         Reviewed by Dimitri Glazkov.
3185
3186         When analyzing a regression range, if one of the commit messages
3187         mentions the test in question, we now hueristically assume that
3188         revision caused the failure.  (I'm shamelessly stealing this idea from
3189         TestFailures.)
3190
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3192
3193 2011-07-13  Eric Seidel  <eric@webkit.org>
3194
3195         new-run-webkit-test's WinPort has no fallback logic
3196         https://bugs.webkit.org/show_bug.cgi?id=64486
3197
3198         Reviewed by Adam Roben.
3199
3200         I've tried to write a patch for bug 64439 twice now, and both times
3201         I've ended up re-writing half the port system.  So I'm breaking
3202         things up into smaller pieces, this being the first.
3203
3204         WinPort still does not have any port_name parsing, so when instantiated
3205         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
3206         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
3207
3208         Otherwise this should "just work" for windows.  I've not been able to test the
3209         version detection on my mac, but the unit tests show the code behaving as designed.
3210
3211         * Scripts/webkitpy/layout_tests/port/win.py:
3212         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
3213
3214 2011-08-09  Adam Barth  <abarth@webkit.org>
3215
3216         Teach build.webkit.org's garden-o-matic how to talk to the local server
3217         https://bugs.webkit.org/show_bug.cgi?id=65940
3218
3219         Reviewed by Dimitri Glazkov.
3220
3221         After this patch, the version of garden-o-matic on build.webkit.org is
3222         fully functional.  It can interact with the local server via CORS.
3223
3224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3227         * Scripts/webkitpy/tool/commands/gardenomatic.py:
3228         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3229
3230 2011-08-09  Adam Barth  <abarth@webkit.org>
3231
3232         Enable CORS for garden-o-matic
3233         https://bugs.webkit.org/show_bug.cgi?id=65936
3234
3235         Reviewed by Dimitri Glazkov.
3236
3237         This patch will allow the hosted instance of garden-o-matic to
3238         communicate with the local server.
3239
3240         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3241         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3242
3243 2011-08-09  Adam Barth  <abarth@webkit.org>
3244
3245         Upgrade jquery in TestFailures
3246         https://bugs.webkit.org/show_bug.cgi?id=65935
3247
3248         Reviewed by Dimitri Glazkov.
3249
3250         Upgrade to a newer version of jQuery with better support for CORS and CSP.
3251
3252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3253         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
3254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3255
3256 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3257
3258         Unreviewed, rolling out r92683.
3259         http://trac.webkit.org/changeset/92683
3260         https://bugs.webkit.org/show_bug.cgi?id=65921
3261
3262          "Breaks Qt --minimal build. Revert pending update of the Qt
3263         minimal configuration" (Requested by simathur on #webkit).
3264
3265         * QtTestBrowser/cookiejar.cpp:
3266         (TestBrowserCookieJar::TestBrowserCookieJar):
3267         * QtTestBrowser/launcherwindow.cpp:
3268         (LauncherWindow::createChrome):
3269         (LauncherWindow::setDiskCache):
3270         * QtTestBrowser/main.cpp:
3271         (LauncherApplication::handleUserOptions):
3272         * QtTestBrowser/webpage.cpp:
3273         (WebPage::openUrlInDefaultBrowser):
3274
3275 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
3276
3277         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
3278         https://bugs.webkit.org/show_bug.cgi?id=65880
3279
3280         Reviewed by Andreas Kling.
3281
3282         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
3283         check for their feature flags. Assume that any reasonable Qt build provides them. 
3284         * QtTestBrowser/cookiejar.cpp:
3285         (TestBrowserCookieJar::TestBrowserCookieJar):
3286         * QtTestBrowser/launcherwindow.cpp:
3287         (LauncherWindow::createChrome):
3288         (LauncherWindow::setDiskCache):
3289         * QtTestBrowser/main.cpp:
3290         (LauncherApplication::handleUserOptions):
3291         * QtTestBrowser/webpage.cpp:
3292         (WebPage::openUrlInDefaultBrowser):
3293
3294 2011-08-09  Adam Barth  <abarth@webkit.org>
3295
3296         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
3297         https://bugs.webkit.org/show_bug.cgi?id=65891
3298
3299         Reviewed by Eric Seidel.
3300
3301         The problem was that platform/chromium contained a bogus expectation
3302         file that needed to be removed, but by the time we got around to
3303         removing it, we'd already moved the correct baseline into its place.
3304         After this patch, we copy the gold results into memory before
3305         reshuffling things on disk (and we delete bad things before adding good
3306         things).
3307
3308         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3309         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3310
3311 2011-08-08  Adam Barth  <abarth@webkit.org>
3312
3313         Chromium Windows bots can't figure out what SVN revision they're running
3314         https://bugs.webkit.org/show_bug.cgi?id=65893
3315
3316         Reviewed by Eric Seidel.
3317
3318         The comment in _engage_awesome_windows_hacks explains why we're making
3319         this change.  It's ugly and rediculous, but this approach seems better
3320         than using shell=True when calling popen.
3321
3322         * Scripts/webkitpy/common/checkout/scm/svn.py:
3323         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3324
3325 2011-08-08  Adam Barth  <abarth@webkit.org>
3326
3327         Remove deduplicate-tests
3328         https://bugs.webkit.org/show_bug.cgi?id=65886
3329
3330         Reviewed by Tony Chang.
3331
3332         This script is redundant with "webkit-patch bulk-optimize-baselines",
3333         which can find many more duplicates than deduplicate-tests because
3334         bulk-optimize-baselines can move results around whereas
3335         deduplicate-tests can only remove results.
3336
3337         * Scripts/deduplicate-tests: Removed.
3338         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
3339         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
3340
3341 2011-08-08  Adam Barth  <abarth@webkit.org>
3342
3343         scm.delete should delete empty parent directories as well
3344         https://bugs.webkit.org/show_bug.cgi?id=65878
3345
3346         Reviewed by Eric Seidel.
3347
3348         This behavior makes SVN match GIT (which has no concept of empty
3349         directories).  This bug comes up a lot when optimizing baselines, which
3350         often create empty directories when we're able to optimize everything
3351         out of a given folder.
3352
3353         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3354         * Scripts/webkitpy/common/checkout/scm/svn.py:
3355
3356 2011-08-08  Lucas Forschler  <lforschler@apple.com>
3357
3358         Add triggers for Lion WK2 test bots.
3359
3360         Reviewed by Stephanie Lewis.
3361
3362         * BuildSlaveSupport/build.webkit.org-config/config.json:
3363
3364 2011-08-08  Adam Barth  <abarth@webkit.org>
3365
3366         bulk-optimize-baselines should take directories on the command line
3367         https://bugs.webkit.org/show_bug.cgi?id=65879
3368
3369         Reviewed by Dimitri Glazkov.
3370
3371         Passing lists of tests via stdin is a pain.  It's easier if the command
3372         takes a list of tests on the command line, like run-webkit-tests.
3373
3374         * Scripts/webkitpy/tool/commands/rebaseline.py:
3375
3376 2011-08-08  Adam Barth  <abarth@webkit.org>
3377
3378         Deprecate rebaseline-chromium-webkit-tests
3379         https://bugs.webkit.org/show_bug.cgi?id=65873
3380
3381         Reviewed by Dimitri Glazkov.
3382
3383         This script never worked correctly and now is redundant with more
3384         modern infrastructure for rebaselining tests.  This patch deprecates
3385         the script in order to flush out any issues with the new tools.  Once
3386         folks are happy with the new tools, we'll delete this script.
3387
3388         * Scripts/rebaseline-chromium-webkit-tests:
3389
3390 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
3391
3392         garden-o-matic should only touch expectations that need updating.
3393         https://bugs.webkit.org/show_bug.cgi?id=65876
3394
3395         Reviewed by Adam Barth.
3396
3397         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
3398             so that a caller could influence which lines to serialize from values.
3399         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
3400         * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
3401         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
3402
3403 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
3404
3405         TestExpectationsEditor should return a list of updated expectations.
3406         https://bugs.webkit.org/show_bug.cgi?id=65872
3407
3408         Reviewed by Adam Barth.
3409
3410         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
3411         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
3412
3413 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
3414
3415         Fix SCM webkitpy unit test failures
3416         https://bugs.webkit.org/show_bug.cgi?id=65823
3417
3418         Reviewed by Eric Seidel.
3419
3420         * Scripts/webkitpy/common/checkout/scm/git.py:
3421         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3422
3423 2011-08-08  Eric Seidel  <eric@webkit.org>
3424
3425         Move the --leaks bot back over to NRWT now that I'm back
3426         from vacation and able to debug it.
3427
3428         Unreviewed.
3429
3430         * Scripts/run-webkit-tests:
3431         (usingWebKit2):
3432         (useNewRunWebKitTests):
3433
3434 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
3435
3436         Wire up updating expectations in garden-o-matic.
3437         https://bugs.webkit.org/show_bug.cgi?id=65794
3438
3439         Reviewed by Adam Barth.
3440
3441         * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
3442         * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
3443         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
3444         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
3445
3446 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
3447
3448         webkit-patch doesn't get along with renamed files
3449         https://bugs.webkit.org/show_bug.cgi?id=48075
3450
3451         Possibly a bit heavy handed - I removed all instances of -C and
3452         changed every instance of -M with '--no-renames' in git.py. This
3453         forces git to not try to tell us about renames at all, which is
3454         ultimately the behaviour we want. The old file is shown deleted,
3455         then the new file is shown added, followed by any changes that
3456         occurred. Also gets rid of the problem where deleting one file
3457         and adding another file which has similar content would
3458         unexpectedly show up as a rename, and fall out of a diff.
3459
3460         Based on a patch by Wyatt Carss.
3461
3462         Reviewed by Eric Seidel.
3463
3464         * Scripts/webkitpy/common/checkout/scm/git.py:
3465
3466 2011-08-07  Sam White  <samuel.white@rochester.edu>
3467
3468         Add the ability to search the AccessibilityObject cache
3469         https://bugs.webkit.org/show_bug.cgi?id=64994
3470         
3471         Added testing support for AccessibilityObject cache searching. Currently,
3472         only the mac platform is full supported and has had API exposed. Other
3473         platforms have only have this new functionality stubbed. Full implementation
3474         is a job suited only for an accessibility expert of each respective platform.
3475
3476         Reviewed by Chris Fleizach.
3477
3478         * DumpRenderTree/AccessibilityUIElement.cpp:
3479         (uiElementForSearchPredicateCallback):
3480         (AccessibilityUIElement::getJSClass):
3481         * DumpRenderTree/AccessibilityUIElement.h:
3482         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3483         (AccessibilityUIElement::uiElementForSearchPredicate):
3484         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3485         (AccessibilityUIElement::uiElementForSearchPredicate):
3486         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3487         (AccessibilityUIElement::uiElementForSearchPredicate):
3488
3489 2011-08-06  Adam Barth  <abarth@webkit.org>
3490
3491         Remove dead code in webkitpy
3492         https://bugs.webkit.org/show_bug.cgi?id=65818
3493
3494         Reviewed by Dimitri Glazkov.
3495
3496         This code was added to support the rebaseline2 command six months ago,
3497         but the rebaseline2 command was never finished and no one else has used
3498         this code since it was landed.  This patch removes the dead code.  If
3499         we revive rebaseline2, then we can revert this patch and recover the
3500         code.  Until then, this code is just dead weight.
3501
3502         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3503         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3504         * Scripts/webkitpy/common/net/testoutput.py: Removed.
3505         * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
3506         * Scripts/webkitpy/common/net/testoutputset.py: Removed.
3507         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
3508         * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
3509         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
3510         * Scripts/webkitpy/layout_tests/port/base.py:
3511         * Scripts/webkitpy/layout_tests/port/chromium.py:
3512         * Scripts/webkitpy/layout_tests/port/webkit.py:
3513
3514 2011-08-06  Adam Barth  <abarth@webkit.org>
3515
3516         webkit-patch optimize-baselines can't handle promotions to base results directory
3517         https://bugs.webkit.org/show_bug.cgi?id=65819
3518
3519         Reviewed by Dimitri Glazkov.
3520
3521         This bug came up when testing the optimizer on some editing baselines.
3522
3523         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3524         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3525
3526 2011-08-06  Adam Barth  <abarth@webkit.org>
3527
3528         Add a small command to optimize baselines in bulk.
3529
3530         * Scripts/webkitpy/tool/commands/rebaseline.py:
3531
3532 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
3533
3534         Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
3535
3536         * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
3537
3538 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
3539
3540         Garden-o-matic updateexpectations needs a unit test.
3541         https://bugs.webkit.org/show_bug.cgi?id=65780
3542
3543         Reviewed by Adam Barth.
3544
3545         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
3546
3547 2011-08-05  Anders Carlsson  <andersca@apple.com>
3548
3549         Future proof an Objective-C test
3550         https://bugs.webkit.org/show_bug.cgi?id=65788
3551
3552         Reviewed by Dan Bernstein.
3553
3554         Add isObjectInstanceOf to ObjCController.
3555
3556         * DumpRenderTree/mac/ObjCController.m:
3557         (+[ObjCController isSelectorExcludedFromWebScript:]):
3558         (+[ObjCController webScriptNameForSelector:]):
3559         (-[ObjCController isObject:instanceOf:]):
3560
3561 2011-08-05  Adam Barth  <abarth@webkit.org>
3562
3563         trac.js needs unittests
3564         https://bugs.webkit.org/show_bug.cgi?id=65673
3565
3566         Reviewed by Dimitri Glazkov.
3567
3568         This tests also have somewhat large fixtures.  I've trimmed the example