Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-03  John Wilander  <wilander@apple.com>
2
3         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
4         https://bugs.webkit.org/show_bug.cgi?id=194104
5         <rdar://problem/47649991>
6
7         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
8
9         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
10         (TestWebKitAPI::TEST):
11             Changed numeric types from unsigned short to uint32_t.
12
13 2019-02-02  David Kilzer  <ddkilzer@apple.com>
14
15         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
16         <https://webkit.org/b/194178>
17         <rdar://problem/47753473>
18
19         Reviewed by Alexey Proskuryakov.
20
21         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
22         (WTR::uninstallFakeHelvetica): Pass nullptr into
23         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
24
25 2019-02-02  Zalan Bujtas  <zalan@apple.com>
26
27         [LFC] Initialize ICB's style with fixed width/height.
28         https://bugs.webkit.org/show_bug.cgi?id=194188
29
30         Reviewed by Antti Koivisto.
31
32         * LayoutReloaded/misc/LFC-passing-tests.txt:
33
34 2019-02-02  Zalan Bujtas  <zalan@apple.com>
35
36         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
37         https://bugs.webkit.org/show_bug.cgi?id=194185
38
39         Reviewed by Antti Koivisto.
40
41         * LayoutReloaded/misc/LFC-passing-tests.txt:
42
43 2018-12-16  Darin Adler  <darin@apple.com>
44
45         Convert additional String::format clients to alternative approaches
46         https://bugs.webkit.org/show_bug.cgi?id=192746
47
48         Reviewed by Alexey Proskuryakov.
49
50         * WebKitTestRunner/TestController.cpp:
51         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
52         as an intermediate in code that ultimately constructs a WTF::String.
53         (WTR::userMediaOriginHash): Use makeString.
54         (WTR::TestController::didNavigateWithNavigationData): More of the same.
55         (WTR::TestController::didPerformClientRedirect): Ditto.
56         (WTR::TestController::didPerformServerRedirect): Ditto.
57         (WTR::TestController::didUpdateHistoryTitle): Ditto.
58
59 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
60
61         [ews-build] Add unit test to verify builder keys
62         https://bugs.webkit.org/show_bug.cgi?id=194152
63
64         Reviewed by Lucas Forschler.
65
66         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
67         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
68
69 2019-02-01  Zalan Bujtas  <zalan@apple.com>
70
71         [LFC] Expand tests coverage (12 new tests -> 787)
72
73         Unreviewed test gardening.
74
75         * LayoutReloaded/misc/LFC-passing-tests.txt:
76
77 2019-02-01  Zalan Bujtas  <zalan@apple.com>
78
79         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
80         https://bugs.webkit.org/show_bug.cgi?id=194163
81
82         Reviewed by Simon Fraser.
83
84         775
85
86         * LayoutReloaded/misc/LFC-passing-tests.txt:
87
88 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
89
90         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
91         https://bugs.webkit.org/show_bug.cgi?id=194140
92         <rdar://problem/47728098>
93
94         Reviewed by Tim Horton.
95
96         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
97         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
98         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
99
100         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
101         test to induce an IPC deadlock when presenting a modal alert during touch start.
102
103         * WebKitTestRunner/InjectedBundle/TestRunner.h:
104         * WebKitTestRunner/TestController.cpp:
105         (WTR::runJavaScriptAlert):
106
107         Add a client callback function for running JavaScript alerts.
108
109         (WTR::TestController::createOtherPage):
110         (WTR::TestController::generateContextConfiguration const):
111
112         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
113         the fix in this patch.
114
115         (WTR::TestController::createWebViewWithOptions):
116
117         Plumb TestOptions to generateContextConfiguration.
118
119         (WTR::TestController::resetPreferencesToConsistentValues):
120         (WTR::TestController::resetStateToConsistentValues):
121         (WTR::updateTestOptionsFromTestHeader):
122         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
123         (WTR::TestController::handleJavaScriptAlert):
124         * WebKitTestRunner/TestController.h:
125         * WebKitTestRunner/TestInvocation.cpp:
126         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
127         * WebKitTestRunner/TestOptions.h:
128         (WTR::TestOptions::hasSameInitializationOptions const):
129
130 2019-02-01  Chris Dumez  <cdumez@apple.com>
131
132         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
133         https://bugs.webkit.org/show_bug.cgi?id=193740
134         <rdar://problem/47527267>
135
136         Reviewed by Alex Christensen.
137
138         Add API test coverage.
139
140         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
141
142 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
143
144         [ews-app] Add display name field to BuilderMapping model
145         https://bugs.webkit.org/show_bug.cgi?id=194153
146
147         Reviewed by Lucas Forschler.
148
149         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
150         (BuilderMapping):
151
152 2019-02-01  Youenn Fablet  <youenn@apple.com>
153
154         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
155         https://bugs.webkit.org/show_bug.cgi?id=194155
156
157         Reviewed by Eric Carlson.
158
159         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
160         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
161         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
162
163 2019-02-01  Zalan Bujtas  <zalan@apple.com>
164
165         [LFC] Adjust replaced element's intrinsic ratio
166         https://bugs.webkit.org/show_bug.cgi?id=194154
167
168         Reviewed by Antti Koivisto.
169
170         761
171
172         * LayoutReloaded/misc/LFC-passing-tests.txt:
173
174 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
175
176         [WPE] Show test results in minibrowser
177         https://bugs.webkit.org/show_bug.cgi?id=194150
178
179         Reviewed by Žan Doberšek.
180
181         * Scripts/webkitpy/port/wpe.py:
182         (WPEPort.show_results_html_file):
183
184 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
185
186         [WPE] MiniBrowser: add ky bindings for back/forward navigation
187         https://bugs.webkit.org/show_bug.cgi?id=194151
188
189         Reviewed by Žan Doberšek.
190
191         ALT + <- go back
192         ALT + -> go forward
193
194         * MiniBrowser/wpe/main.cpp:
195         (main):
196
197 2019-02-01  Zalan Bujtas  <zalan@apple.com>
198
199         [LFC] Set intrinsic size on Layout::Replaced
200         https://bugs.webkit.org/show_bug.cgi?id=194139
201
202         Reviewed by Antti Koivisto.
203
204         744
205
206         * LayoutReloaded/misc/LFC-passing-tests.txt:
207
208 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
209
210         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
211         https://bugs.webkit.org/show_bug.cgi?id=194146
212
213         Reviewed by Xabier Rodriguez-Calvar.
214
215         It allows to open relative paths.
216
217         * MiniBrowser/wpe/main.cpp:
218         (main):
219
220 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
221
222         Update flakiness dashboard configuration after recent queue changes
223         https://bugs.webkit.org/show_bug.cgi?id=194127
224
225         Rubber-stamped by Aakash Jain.
226
227         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
228
229         * TestResultServer/static-dashboards/builders.jsonp:
230
231 2019-01-31  Youenn Fablet  <youenn@apple.com>
232
233         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
234         https://bugs.webkit.org/show_bug.cgi?id=194106
235         <rdar://problem/47676333>
236
237         Reviewed by Ryosuke Niwa.
238
239         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
240         (TestWebKitAPI::didFinishNavigation):
241         (TestWebKitAPI::TEST):
242         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
243
244 2019-01-31  Chris Dumez  <cdumez@apple.com>
245
246         Page zoom level is lost after a process swap or a crash
247         https://bugs.webkit.org/show_bug.cgi?id=194105
248         <rdar://problem/47610781>
249
250         Reviewed by Alex Christensen.
251
252         Add API test coverage.
253
254         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
255         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
256
257 2019-01-31  Alex Christensen  <achristensen@webkit.org>
258
259         Revert r238819 which is unneeded and caused a performance regression.
260         https://bugs.webkit.org/show_bug.cgi?id=192272
261         <rdar://problem/46664625>
262
263         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
264         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
265         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
266
267 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
268
269         Formalize WebKitAdditions mechanism of LoadOptimizer
270         https://bugs.webkit.org/show_bug.cgi?id=193886
271         <rdar://problem/47696809>
272
273         Reviewed by Brent Fulgham.
274
275         * MiniBrowser/MiniBrowser.entitlements:
276         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
277
278 2019-01-31  Zalan Bujtas  <zalan@apple.com>
279
280         [LFC] Margin before/after/start/end initial value is 0 and not auto.
281         https://bugs.webkit.org/show_bug.cgi?id=194090
282
283         Reviewed by Antti Koivisto.
284
285         * LayoutReloaded/misc/LFC-passing-tests.txt:
286
287 2019-01-31  Zalan Bujtas  <zalan@apple.com>
288
289         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
290         https://bugs.webkit.org/show_bug.cgi?id=194074
291
292         Reviewed by Antti Koivisto.
293
294         * LayoutReloaded/misc/LFC-passing-tests.txt:
295
296 2019-01-31  Zalan Bujtas  <zalan@apple.com>
297
298         [LFC][BFC] Add support for block level replaced box.
299         https://bugs.webkit.org/show_bug.cgi?id=194071
300
301         Reviewed by Antti Koivisto.
302
303         * LayoutReloaded/misc/LFC-passing-tests.txt:
304
305 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
306
307         Fix WebKitTestRunner's testPath with Windows full paths
308         https://bugs.webkit.org/show_bug.cgi?id=194012
309
310         Reviewed by Alex Christensen.
311
312         updateTestOptionsFromTestHeader failed to open test files because
313         testPath returned wrong file paths. It returned a path "/C:/..."
314         if a URL "file:///C:/..." was given.
315
316         * WebKitTestRunner/TestController.cpp:
317         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
318
319 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
320
321         [WPE] Bump font related dependencies to match the GTK+ port
322         https://bugs.webkit.org/show_bug.cgi?id=194017
323
324         Reviewed by Žan Doberšek.
325
326         * wpe/jhbuild.modules:
327         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
328         * wpe/patches/icudata-stdlibs.patch: Added.
329
330 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
331
332         Enable swipe tests on iOS
333         https://bugs.webkit.org/show_bug.cgi?id=194076
334
335         Reviewed by Geoffrey Garen.
336
337         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
338         it causes a debug assertion failure in runUIScript.
339
340         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
341         (WTR::UIScriptController::beginBackSwipe):
342         (WTR::UIScriptController::completeBackSwipe):
343
344 2019-01-30  Keith Rollin  <krollin@apple.com>
345
346         Use correct printf format specifier
347         https://bugs.webkit.org/show_bug.cgi?id=194062
348         <rdar://problem/47686167>
349
350         Reviewed by Alexey Proskuryakov.
351
352         LayoutTestSpellChecker.mm is trying to format a variable of type
353         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
354         actually an unsigned long long. Fix this by formatting with %llu.
355
356         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
357         (-[LayoutTestTextCheckingResult description]):
358
359 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
360
361         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
362         https://bugs.webkit.org/show_bug.cgi?id=193979
363
364         Reviewed by Wenson Hsieh.
365
366         Fix the test for iOS. Make the test work with iOS UA string.
367
368         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
369
370 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
371
372         Replace High Sierra LLINT CLoop bot due to hardware failure
373         https://bugs.webkit.org/show_bug.cgi?id=194066
374
375         Reviewed by Aakash Jain.
376
377         * BuildSlaveSupport/build.webkit.org-config/config.json:
378
379 2019-01-30  Keith Rollin  <krollin@apple.com>
380
381         [NSDragItem init] is unavailable
382         https://bugs.webkit.org/show_bug.cgi?id=194059
383         <rdar://problem/47685715>
384
385         Reviewed by Wenson Hsieh.
386
387         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
388         DumpRenderTree and TestWebKitAPI, which both try to create an
389         NSDragItem in a manner that invokes this method. Address this by using
390         -initWithPasteboardWriter instead.
391
392         Note that the parameter passed to initWithPasteboardWriter is likely
393         incorrect. In both cases, the object passed does not conform to
394         NSPasteboardWriting. However, with this fix, we're no worse off than
395         before, and can now perform builds with newer compilers and SDKs until
396         a real fix can be crafted. That work is tracked in
397         https://bugs.webkit.org/show_bug.cgi?id=194060
398
399         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
400         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
401         * TestWebKitAPI/mac/TestDraggingInfo.mm:
402         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
403
404 2019-01-30  Daniel Bates  <dabates@apple.com>
405
406         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
407         https://bugs.webkit.org/show_bug.cgi?id=192824
408         <rdar://problem/47100332>
409
410         Reviewed by Wenson Hsieh.
411
412         Fix a bug where the wrong usage code was used for F13 thru F24.
413
414         * WebKitTestRunner/ios/HIDEventGenerator.mm:
415         (keyCodeForDOMFunctionKey):
416
417 2019-01-30  Chris Dumez  <cdumez@apple.com>
418
419         Regression(PSON) Load hang can occur on history navigation
420         https://bugs.webkit.org/show_bug.cgi?id=194030
421         <rdar://problem/47656939>
422
423         Reviewed by Antti Koivisto.
424
425         Add API test coverage.
426
427         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
428
429 2019-01-30  Zalan Bujtas  <zalan@apple.com>
430
431         [LFC] Expand tests coverage.
432
433         Unreviewed test gardening.
434
435         * LayoutReloaded/misc/LFC-passing-tests.txt:
436
437 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
438
439         [Flatpak] Add openjpeg support
440         https://bugs.webkit.org/show_bug.cgi?id=194019
441
442         Reviewed by Michael Catanzaro.
443
444         * flatpak/org.webkit.CommonModules.yaml:
445
446 2019-01-30  Commit Queue  <commit-queue@webkit.org>
447
448         Unreviewed, rolling out r240708.
449         https://bugs.webkit.org/show_bug.cgi?id=194022
450
451         It broke WPE build (Requested by KaL on #webkit).
452
453         Reverted changeset:
454
455         "[WPE] Bump font related dependencies to match the GTK+ port"
456         https://bugs.webkit.org/show_bug.cgi?id=194017
457         https://trac.webkit.org/changeset/240708
458
459 2019-01-30  Zalan Bujtas  <zalan@apple.com>
460
461         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
462         https://bugs.webkit.org/show_bug.cgi?id=194001
463
464         Reviewed by Antti Koivisto.
465
466         * LayoutReloaded/misc/LFC-passing-tests.txt:
467
468 2019-01-30  Zalan Bujtas  <zalan@apple.com>
469
470         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
471         https://bugs.webkit.org/show_bug.cgi?id=194020
472
473         Reviewed by Antti Koivisto.
474
475         * LayoutReloaded/misc/LFC-passing-tests.txt:
476
477 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
478
479         AX: Support color well on iOS
480         https://bugs.webkit.org/show_bug.cgi?id=194010
481
482         Reviewed by Joanmarie Diggs.
483
484         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
485         (WTR::AccessibilityUIElement::stringAttributeValue):
486
487 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
488
489         [WPE] Bump font related dependencies to match the GTK+ port
490         https://bugs.webkit.org/show_bug.cgi?id=194017
491
492         Reviewed by Žan Doberšek.
493
494         * wpe/jhbuild.modules:
495         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
496         * wpe/patches/icudata-stdlibs.patch: Added.
497
498 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
499
500         [Mac] Update window scale API usage
501         https://bugs.webkit.org/show_bug.cgi?id=193991
502         rdar://problem/47614795
503
504         Reviewed by Tim Horton.
505
506         * DumpRenderTree/mac/DumpRenderTree.mm:
507         (changeWindowScaleIfNeeded):
508         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
509         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
510         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
511
512 2019-01-29  Chris Dumez  <cdumez@apple.com>
513
514         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
515         https://bugs.webkit.org/show_bug.cgi?id=193977
516         <rdar://problem/47643716>
517
518         Reviewed by Geoff Garen.
519
520         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
521         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
522         to the previous provisional committing *before* we make the last load. 
523
524         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
525
526 2019-01-29  Youenn Fablet  <youenn@apple.com>
527
528         Adopt new SPI to evaluate server certificate trust
529         https://bugs.webkit.org/show_bug.cgi?id=193355
530
531         Reviewed by Alex Christensen.
532
533         Add infrastructure to handle HTTPS server trust evaluation testing.
534
535         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
537         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
538         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
539         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
540         * WebKitTestRunner/InjectedBundle/TestRunner.h:
541         * WebKitTestRunner/TestController.cpp:
542         (WTR::TestController::resetPreferencesToConsistentValues):
543         (WTR::TestController::didReceiveAuthenticationChallenge):
544         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
545         * WebKitTestRunner/TestController.h:
546         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
547         * WebKitTestRunner/TestInvocation.cpp:
548         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
549         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
550         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
551
552 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
553
554         [ews-build] Add build step to print bot Configuration
555         https://bugs.webkit.org/show_bug.cgi?id=193887
556
557         Reviewed by Lucas Forschler.
558
559         * BuildSlaveSupport/ews-build/steps.py:
560         (PrintConfiguration): Build step to print configuration.
561         * BuildSlaveSupport/ews-build/factories.py:
562
563 2019-01-29  Chris Dumez  <cdumez@apple.com>
564
565         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
566         https://bugs.webkit.org/show_bug.cgi?id=193967
567         <rdar://problem/47635348>
568
569         Reviewed by Alex Christensen.
570
571         Add API test coverage.
572
573         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
574         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
575
576 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
577
578         [ews-app] Handle incoming results data
579         https://bugs.webkit.org/show_bug.cgi?id=193973
580
581         Reviewed by Lucas Forschler.
582
583         * BuildSlaveSupport/ews-app/ews/views/results.py:
584
585 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
586
587         [ews-app] Make the results url generic
588         https://bugs.webkit.org/show_bug.cgi?id=193928
589
590         Reviewed by Lucas Forschler.
591
592         * BuildSlaveSupport/ews-app/ews/urls.py:
593
594 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
595
596         [ews-build] Configure buildbot to send events to ews-app
597         https://bugs.webkit.org/show_bug.cgi?id=193968
598
599         Reviewed by Lucas Forschler.
600
601         * BuildSlaveSupport/ews-build/events.py: Added.
602         * BuildSlaveSupport/ews-build/master.cfg:
603
604 2019-01-29  Keith Rollin  <krollin@apple.com>
605
606         Add .xcfilelists to Run Script build phases
607         https://bugs.webkit.org/show_bug.cgi?id=193792
608         <rdar://problem/47201785>
609
610         Reviewed by Alex Christensen.
611
612         As part of supporting XCBuild, update the necessary Run Script build
613         phases in their Xcode projects to refer to their associated
614         .xcfilelist files.
615
616         Note that the addition of these files bumps the Xcode project version
617         number to something that's Xcode 10 compatible. This change means that
618         older versions of the Xcode IDE can't read these projects. Nor can it
619         fully load workspaces that refer to these projects (the updated
620         projects are shown as non-expandable placeholders). `xcodebuild` can
621         still build these projects; it's just that the IDE can't open them.
622
623         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
624         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
625
626 2019-01-29  John Wilander  <wilander@apple.com>
627
628         Add data abstraction and validation for Ad Click Attribution
629         https://bugs.webkit.org/show_bug.cgi?id=193916
630         <rdar://problem/47603481>
631
632         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
633
634         Ad click attribution has two steps. First, the storage of an ad
635         campaign ID for a click that takes the user to a destination
636         site. Second, a conversion on the destination site that can be
637         attributed to the ad click.
638
639         This patch adds a class that represents a request for ad click
640         attribution. Validation makes sure that the bits of entropy
641         reported through this mechanism is limited.
642
643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
644         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
645         (TestWebKitAPI::TEST):
646
647 2019-01-29  Chris Dumez  <cdumez@apple.com>
648
649         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
650         https://bugs.webkit.org/show_bug.cgi?id=193932
651         <rdar://problem/47598947>
652
653         Reviewed by Brady Eidson.
654
655         Add API test coverage.
656
657         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
658
659 2019-01-29  Zalan Bujtas  <zalan@apple.com>
660
661         Adding new passing LFC tests.
662
663         Unreviewed test gardening.
664
665         * LayoutReloaded/misc/LFC-passing-tests.txt:
666
667 2019-01-29  Zalan Bujtas  <zalan@apple.com>
668
669         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
670         https://bugs.webkit.org/show_bug.cgi?id=193964
671
672         Reviewed by Antti Koivisto.
673
674         * LayoutReloaded/misc/LFC-passing-tests.txt:
675
676 2019-01-29  Zalan Bujtas  <zalan@apple.com>
677
678         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
679         https://bugs.webkit.org/show_bug.cgi?id=193954
680
681         Reviewed by Antti Koivisto.
682
683         * LayoutReloaded/misc/LFC-passing-tests.txt:
684
685 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
686
687         WebDriver: add support for running subtests
688         https://bugs.webkit.org/show_bug.cgi?id=193904
689
690         Reviewed by Michael Catanzaro.
691
692         pytest already supports it by passing test.py::subtest, so we can do the same.
693
694         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
695         (get_item_name): Made this global.
696         (CollectRecorder.__init__): Receive the parameter to ignore.
697         (CollectRecorder.pytest_collectreport): Collect also the subtests.
698         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
699         (collect): Add parameter to ignore.
700         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
701         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
702         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
703         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
704         (WebDriverTestRunnerSelenium.run): Ditto.
705         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
706         (WebDriverTestRunnerW3C.collect_tests): Ditto.
707         (WebDriverTestRunnerW3C.run): Ditto.
708
709 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
710
711         User agent string override for navigator.userAgent should be site specific quirks
712         https://bugs.webkit.org/show_bug.cgi?id=193950
713
714         Reviewed by Brent Fulgham.
715
716         Updated per the _WKWebsitePolicies rename.
717
718         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
719         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
720
721 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
722
723         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
724         https://bugs.webkit.org/show_bug.cgi?id=193941
725
726         Reviewed by Alex Christensen.
727
728         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
729         * TestWebKitAPI/Tests/WTF/Condition.cpp:
730         * TestWebKitAPI/Tests/WTF/Lock.cpp:
731         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
732         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
733         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
734         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
735         * TestWebKitAPI/Tests/WTF/Time.cpp:
736         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
737         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
738         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
739         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
740
741 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
742
743         Unreviewed, reorder my emails to fix autocomplete in bugzilla
744
745         * Scripts/webkitpy/common/config/contributors.json:
746
747 2019-01-28  Andy Estes  <aestes@apple.com>
748
749         [watchOS] Enable Parental Controls content filtering
750         https://bugs.webkit.org/show_bug.cgi?id=193939
751         <rdar://problem/46641912>
752
753         Reviewed by Ryosuke Niwa.
754
755         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
756
757 2019-01-28  David Kilzer  <ddkilzer@apple.com>
758
759         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
760         <https://webkit.org/b/193884>
761
762         Reviewed by Jiewen Tan.
763
764         * Scripts/webkitpy/style/checkers/cpp.py:
765         (check_language): Add LocalAuthentication to
766         `frameworks_with_soft_links`.
767
768 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
769
770         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
771         https://bugs.webkit.org/show_bug.cgi?id=193891
772
773         Reviewed by Ross Kirsling.
774
775         There were three problems in window sizes of WebView and the host window.
776         1. The sizes of pixel image output were incorrect.
777         2. The host window is going to appear after window.resize was invoked.
778         3. window.resize resized only the host window, not WebView.
779
780         This change solves them with a following approach.
781         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
782         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
783            as well as DumpRenderTree in order to match the client area and the window area.
784         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
785         d. PlatformWebView::setWindowFrame changes both window sizes.
786         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
787
788         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
789         (WTR::PlatformWebView::PlatformWebView): Create the host window
790         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
791         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
792         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
793
794 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
795
796         [ews-app] Add method to save Step data to database
797         https://bugs.webkit.org/show_bug.cgi?id=193890
798
799         Reviewed by Lucas Forschler.
800
801         * BuildSlaveSupport/ews-app/ews/models/step.py:
802         (Step.save_step): Method to save step data.
803         (Step.update_step): Method to update step data.
804         (Step.get_existing_step): Method to fetch existing step from database.
805         (Step.is_valid_result): Method to validate valid step result.
806
807 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
808
809         [ews-app] Add method to save Build data to database
810         https://bugs.webkit.org/show_bug.cgi?id=193735
811
812         Reviewed by Lucas Forschler.
813
814         * BuildSlaveSupport/ews-app/ews/models/build.py:
815         (Build.save_build): Method to save build information to database.
816         (Build.get_existing_build): Method to fetch existing build from database.
817         (Build.is_valid_result): Method to validate build result.
818         * BuildSlaveSupport/ews-app/ews/common/util.py:
819         (is_valid_int_id): Method to validate valid id.
820
821 2019-01-28  Chris Dumez  <cdumez@apple.com>
822
823         Regression(PSON) Crash under WebPageProxy::didStartProgress()
824         https://bugs.webkit.org/show_bug.cgi?id=193915
825         <rdar://problem/47560907>
826
827         Reviewed by Alex Christensen.
828
829         Add API test coverage.
830
831         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
832
833 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
834
835         [ews-app] Rename id variables
836         https://bugs.webkit.org/show_bug.cgi?id=193883
837
838         Reviewed by Lucas Forschler.
839
840         * BuildSlaveSupport/ews-app/ews/models/build.py:
841         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
842         * BuildSlaveSupport/ews-app/ews/models/step.py:
843         * BuildSlaveSupport/ews-app/ews/urls.py:
844         * BuildSlaveSupport/ews-app/ews/views/patch.py:
845         * BuildSlaveSupport/ews-app/ews/views/results.py:
846         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
847
848 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
849
850         [ews-app] Allow certain fields to be empty
851         https://bugs.webkit.org/show_bug.cgi?id=193892
852
853         Reviewed by Lucas Forschler.
854
855         * BuildSlaveSupport/ews-app/ews/models/build.py:
856         * BuildSlaveSupport/ews-app/ews/models/step.py:
857
858 2019-01-28  Rob Buis  <rbuis@igalia.com>
859
860         Update MIME type parser
861         https://bugs.webkit.org/show_bug.cgi?id=180526
862
863         Reviewed by Frédéric Wang.
864
865         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
866         (TestWebKitAPI::TEST):
867
868 2019-01-28  Zalan Bujtas  <zalan@apple.com>
869
870         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
871         https://bugs.webkit.org/show_bug.cgi?id=193896
872
873         Reviewed by Antti Koivisto.
874
875         * LayoutReloaded/misc/LFC-passing-tests.txt:
876
877 2018-12-15  Darin Adler  <darin@apple.com>
878
879         Replace many uses of String::format with more type-safe alternatives
880         https://bugs.webkit.org/show_bug.cgi?id=192742
881
882         Reviewed by Mark Lam.
883
884         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
885         (WTR::cacheTestRunnerCallback): Use makeString.
886         * WebKitTestRunner/TestController.cpp:
887         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
888         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
889
890 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
891
892         Use a load optimizer for some sites
893         https://bugs.webkit.org/show_bug.cgi?id=193881
894         <rdar://problem/46325455>
895
896         Reviewed by Brent Fulgham.
897
898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
899         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
900
901 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
902
903         AX: Introduce a static accessibility tree
904         https://bugs.webkit.org/show_bug.cgi?id=193348
905         <rdar://problem/47203295>
906
907         Reviewed by Ryosuke Niwa.
908
909         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
910
911 2019-01-26  Zalan Bujtas  <zalan@apple.com>
912
913         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
914         https://bugs.webkit.org/show_bug.cgi?id=193867
915
916         Reviewed by Antti Koivisto.
917
918         * LayoutReloaded/misc/LFC-passing-tests.txt:
919
920 2019-01-26  Zalan Bujtas  <zalan@apple.com>
921
922         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
923         https://bugs.webkit.org/show_bug.cgi?id=193865
924
925         Reviewed by Antti Koivisto.
926
927         * LayoutReloaded/misc/LFC-passing-tests.txt:
928
929 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
930
931         Need a mechanism to override navigator.userAgent
932         https://bugs.webkit.org/show_bug.cgi?id=193762
933         <rdar://problem/47504939>
934
935         Reviewed by Brent Fulgham.
936
937         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
938
939         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
940         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
941         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
942
943 2019-01-25  Dean Jackson  <dino@apple.com>
944
945         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
946         https://bugs.webkit.org/show_bug.cgi?id=193831
947         <rdar://problem/47399263>
948
949         Reviewed by Chris Dumez.
950
951         Two new tests that exercise cross-origin and same-origin System
952         Previews.
953
954         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
955
956 2019-01-25  Keith Rollin  <krollin@apple.com>
957
958         Update Xcode projects with "Check .xcfilelists" build phase
959         https://bugs.webkit.org/show_bug.cgi?id=193790
960         <rdar://problem/47201374>
961
962         Reviewed by Alex Christensen.
963
964         Support for XCBuild includes specifying inputs and outputs to various
965         Run Script build phases. These inputs and outputs are specified as
966         .xcfilelist files. Once created, these .xcfilelist files need to be
967         kept up-to-date. In order to check that they are up-to-date or not,
968         add an Xcode build step that invokes an external script that performs
969         the checking. If the .xcfilelists are found to be out-of-date, update
970         them, halt the build, and instruct the developer to restart the build
971         with up-to-date files.
972
973         At this time, the checking and regenerating is performed only if the
974         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
975         who want to use this facility can set this variable and test out the
976         checking/regenerating. Once it seems like there are no egregious
977         issues that upset a developer's workflow, we'll unconditionally enable
978         this facility.
979
980         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
981         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
982         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
983         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
984
985 2019-01-25  Keith Rollin  <krollin@apple.com>
986
987         Update Xcode projects with "Apply Configuration to XCFileLists" build target
988         https://bugs.webkit.org/show_bug.cgi?id=193781
989         <rdar://problem/47201153>
990
991         Reviewed by Alex Christensen.
992
993         Part of generating the .xcfilelists used as part of adopting XCBuild
994         includes running `make DerivedSources.make` from a standalone script.
995         It’s important for this invocation to have the same environment as
996         when the actual build invokes `make DerivedSources.make`. If the
997         environments are different, then the two invocations will provide
998         different results. In order to get the same environment in the
999         standalone script, have the script launch xcodebuild targeting the
1000         "Apply Configuration to XCFileLists" build target, which will then
1001         re-invoke our standalone script. The script is now running again, this
1002         time in an environment with all workspace, project, target, xcconfig
1003         and other environment variables established.
1004
1005         The "Apply Configuration to XCFileLists" build target accomplishes
1006         this task via a small embedded shell script that consists only of:
1007
1008             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1009
1010         The process that invokes "Apply Configuration to XCFileLists" first
1011         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1012         evaluated and exports it into the shell environment. When xcodebuild
1013         is invoked, it inherits the value of this variable and can `eval` the
1014         contents of that variable. Our external standalone script can then set
1015         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1016         of command-line parameters needed to restart itself in the appropriate
1017         state.
1018
1019         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1020         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1021
1022 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1023
1024         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1025         https://bugs.webkit.org/show_bug.cgi?id=193802
1026         <rdar://problem/46010580>
1027
1028         Reviewed by Andy Estes.
1029
1030         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1031         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1032         (TEST):
1033
1034 2019-01-25  Daniel Bates  <dabates@apple.com>
1035
1036         [iOS] uiController.keyDown() does not translate Control modified key
1037         https://bugs.webkit.org/show_bug.cgi?id=192898
1038
1039         Reviewed by Wenson Hsieh.
1040
1041         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1042         key translation, as applicable. Among other cases, key translation occurs when performing
1043         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1044         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1045         human pressing down and releasing key(s) using a hardware keyboard.
1046
1047         * WebKitTestRunner/ios/HIDEventGenerator.h:
1048         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1049         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1050
1051         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1052         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1053         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1054         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1055         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1056         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1057         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1058         (-[HIDEventGenerator longPress:completionBlock:]):
1059         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1060         Update code for above renaming.
1061
1062         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1063         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1064
1065         (-[HIDEventGenerator keyDown:]): Added.
1066         (-[HIDEventGenerator keyUp:]): Added.
1067         (-[HIDEventGenerator keyPress:completionBlock:]):
1068         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1069         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1070         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1071         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1072         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1073         (WTR::parseModifier): Deleted.
1074
1075 2019-01-25  Keith Rollin  <krollin@apple.com>
1076
1077         Complete the implementation of generate-xcfilelists
1078         https://bugs.webkit.org/show_bug.cgi?id=193782
1079
1080         Reviewed by Alex Christensen.
1081
1082         A preliminary version of generate-xcfilelists was added in r238008.
1083         This patch updates that script in order to:
1084
1085         - Support checking of .xcfilelists
1086         - Perform better execution of `make DerivedSources.make` by
1087           relaunching generate-xcfilelists under xcodebuild
1088         - Support incremental generation and checking of .xcfilelists
1089         - Support supplementary .xcfilelists files from WebKitAdditions
1090         - Support being wrapped by parallel version of generate-xcfilelists in
1091           Internal that adds support for (re)generating WebKit projects in
1092           that repo.
1093         - Support builds that have been performed in WebKitBuild as well as
1094           ~/Library/Developer/code/DerivedData
1095         - Increase robustness and debugging facilities.
1096
1097         * Scripts/generate-xcfilelists:
1098
1099 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1100
1101         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1102         https://bugs.webkit.org/show_bug.cgi?id=193297
1103         <rdar://problem/47158841>
1104
1105         Unreviewed test case fix.
1106
1107         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1108         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1109
1110         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1111         (TEST):
1112
1113 2019-01-25  Keith Rollin  <krollin@apple.com>
1114
1115         Update existing .xcfilelists
1116         https://bugs.webkit.org/show_bug.cgi?id=193791
1117         <rdar://problem/47201706>
1118
1119         Reviewed by Alex Christensen.
1120
1121         Many .xcfilelist files were added in r238824 in order to support
1122         XCBuild. Update these with recent changes to the set of build files
1123         and with the current generate-xcfilelist script.
1124
1125         * DumpRenderTree/DerivedSources-input.xcfilelist:
1126         * DumpRenderTree/DerivedSources-output.xcfilelist:
1127         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1128         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1129
1130 2019-01-25  Keith Rollin  <krollin@apple.com>
1131
1132         Fix missing dependencies in extract-dependencies-from-makefile
1133         https://bugs.webkit.org/show_bug.cgi?id=193783
1134         <rdar://problem/47201571>
1135
1136         Reviewed by Alex Christensen.
1137
1138         The extract-dependencies-from-makefile script generates .xcfilelists
1139         for XCBuild by invoking a makefile in --debug mode, parsing the
1140         dependency information in the output, and extracting information
1141         regarding targets and dependents. However, the way `make` emits this
1142         dependency information is not rigorous, and so we need to determine
1143         what lines to look for and parse by trial and error. This approach
1144         didn't coriginally atch all the information we needed to collect, so
1145         update the script to look for the additional lines we now know to look
1146         for.
1147
1148         * Scripts/extract-dependencies-from-makefile:
1149         (Parser):
1150         (Parser.addTarget):
1151         (Parser.addPrereq):
1152         (Parser.doParse):
1153
1154 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1155
1156         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1157         https://bugs.webkit.org/show_bug.cgi?id=193297
1158         <rdar://problem/47158841>
1159
1160         Reviewed by Alex Christensen.
1161
1162         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1163             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1164         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1165         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1166         activating the message used to trigger the callback when it is set.
1167
1168 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1169
1170         WKWebView.goBack should reload if there is a safe browsing warning
1171         https://bugs.webkit.org/show_bug.cgi?id=193805
1172         <rdar://problem/46908216>
1173
1174         Reviewed by Geoff Garen.
1175
1176         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1177         (+[Simple3LookupContext sharedLookupContext]):
1178         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1179         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1180         (TEST):
1181
1182 2019-01-25  Chris Dumez  <cdumez@apple.com>
1183
1184         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1185         https://bugs.webkit.org/show_bug.cgi?id=193788
1186         <rdar://problem/47531231>
1187
1188         Reviewed by Alex Christensen.
1189
1190         Add API test coverage.
1191
1192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1193         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1194
1195 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1196
1197         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1198         https://bugs.webkit.org/show_bug.cgi?id=193771
1199
1200         Unreviewed infrastructure fix.
1201
1202         * Scripts/webkitpy/port/darwin.py:
1203         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1204
1205 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1206
1207         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1208
1209 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1210
1211         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1212
1213         * Scripts/webkitpy/common/config/contributors.json:
1214
1215 2019-01-25  Chris Dumez  <cdumez@apple.com>
1216
1217         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1218         https://bugs.webkit.org/show_bug.cgi?id=193779
1219         <rdar://problem/46170903>
1220
1221         Reviewed by Antti Koivisto.
1222
1223         Add API test that quickly navigates forward to a previous process without waiting for it to
1224         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1225         the process' previous page when reconnecting the it for the forward navigation.
1226
1227         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1228
1229 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1230
1231         Need a way for JavaScript (or bundle) code to participate in undo
1232         https://bugs.webkit.org/show_bug.cgi?id=190009
1233         <rdar://problem/44807048>
1234
1235         Reviewed by Ryosuke Niwa.
1236
1237         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1238         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1239
1240         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1241         (WTR::UIScriptController::lastUndoLabel const):
1242         (WTR::UIScriptController::firstRedoLabel const):
1243         (WTR::UIScriptController::platformUndoManager const):
1244         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1245         (WTR::UIScriptController::lastUndoLabel const):
1246         (WTR::UIScriptController::firstRedoLabel const):
1247         (WTR::UIScriptController::platformUndoManager const):
1248         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1249         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1250         (WTR::UIScriptController::lastUndoLabel const):
1251         (WTR::UIScriptController::firstRedoLabel const):
1252         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1253         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1254         (WTR::UIScriptController::lastUndoLabel const):
1255         (WTR::UIScriptController::firstRedoLabel const):
1256         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1257         (WTR::UIScriptController::platformUndoManager const):
1258         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1259         (WTR::UIScriptController::platformUndoManager const):
1260
1261 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1262
1263         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1264         https://bugs.webkit.org/show_bug.cgi?id=193824
1265
1266         Reviewed by Antti Koivisto.
1267
1268         * LayoutReloaded/misc/LFC-passing-tests.txt:
1269
1270 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1271
1272         Update macOS JSC bot configurations
1273         https://bugs.webkit.org/show_bug.cgi?id=193739
1274
1275         Reviewed by Alexey Proskuryakov.
1276
1277         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1279         (BubbleQueueServer): Move JSC EWS to Mojave section.
1280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1281         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1282         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1283
1284 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1285
1286         [Win][WebKitTestRunner] Implement EventSenderProxy
1287         https://bugs.webkit.org/show_bug.cgi?id=193755
1288
1289         Reviewed by Don Olmstead.
1290
1291         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1292         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1293         (WTR::EventSenderProxy::dispatchMessage):
1294         (WTR::EventSenderProxy::EventSenderProxy):
1295         (WTR::EventSenderProxy::mouseDown):
1296         (WTR::EventSenderProxy::mouseUp):
1297         (WTR::EventSenderProxy::mouseMoveTo):
1298         (WTR::EventSenderProxy::mouseScrollBy):
1299         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1300
1301 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1302
1303         Unreviewed fix for API test failure after r240437.
1304
1305         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1306
1307         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1308
1309 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1310
1311         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1312         https://bugs.webkit.org/show_bug.cgi?id=193787
1313         <rdar://problem/47497634>
1314
1315         Reviewed by Alexey Proskuryakov.
1316
1317         * Scripts/webkitdirs.pm:
1318         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1319
1320 2019-01-24  Truitt Savell  <tsavell@apple.com>
1321
1322         Unreviewed, rolling out r240446.
1323
1324         Casued 5 API failures
1325
1326         Reverted changeset:
1327
1328         "Activate the WebResourceLoadStatisticsStore in the
1329         NetworkProcess and deactivate it in the UIProcess."
1330         https://bugs.webkit.org/show_bug.cgi?id=193297
1331         https://trac.webkit.org/changeset/240446
1332
1333 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1334
1335         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1336         https://bugs.webkit.org/show_bug.cgi?id=193741
1337         <rdar://problem/47135030>
1338
1339         Reviewed by Antti Koivisto and Simon Fraser.
1340
1341         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1342         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1343         (TestWebKitAPI::TEST):
1344
1345 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1346
1347         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1348         https://bugs.webkit.org/show_bug.cgi?id=193297
1349         <rdar://problem/47158841>
1350
1351         Reviewed by Alex Christensen.
1352
1353         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1354         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1355         activating the message used to trigger the callback when it is set.
1356
1357 2019-01-24  John Wilander  <wilander@apple.com>
1358
1359         Add Ad Click Attribution as an internal/experimental feature
1360         https://bugs.webkit.org/show_bug.cgi?id=193685
1361         <rdar://problem/47450399>
1362
1363         Reviewed by Brent Fulgham.
1364
1365         Added test option adClickAttributionEnabled.
1366
1367         * DumpRenderTree/TestOptions.cpp:
1368         (TestOptions::TestOptions):
1369         * DumpRenderTree/TestOptions.h:
1370         * DumpRenderTree/mac/DumpRenderTree.mm:
1371         (setWebPreferencesForTestOptions):
1372
1373 2019-01-24  Antti Koivisto  <antti@apple.com>
1374
1375         [PSON] Flash on back navigation on Mac
1376         https://bugs.webkit.org/show_bug.cgi?id=193716
1377         <rdar://problem/47148458>
1378
1379         Reviewed by Chris Dumez.
1380
1381         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1382
1383         Closing of the previous page is delayed so waiting for didFinishNavigation is
1384         not sufficient to guarantee we have received all the messages. Wait for them.
1385
1386 2019-01-24  Chris Dumez  <cdumez@apple.com>
1387
1388         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1389         https://bugs.webkit.org/show_bug.cgi?id=193761
1390         <rdar://problem/47456405>
1391
1392         Reviewed by Alex Christensen.
1393
1394         Add API test coverage.
1395
1396         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1397
1398 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1399
1400         webkitpy: Missing PID in crashlog name should not be fatal
1401         https://bugs.webkit.org/show_bug.cgi?id=193771
1402
1403         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1404         of raising an exception.
1405
1406         Reviewed by Lucas Forschler.
1407
1408         * Scripts/webkitpy/port/darwin.py:
1409         (DarwinPort._merge_crash_logs):
1410
1411 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1412
1413         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1414         https://bugs.webkit.org/show_bug.cgi?id=193746
1415
1416         Reviewed by Youenn Fablet.
1417
1418         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1419         so we'd best just not call it.
1420
1421         * Scripts/webkitpy/w3c/test_exporter.py:
1422         (WebPlatformTestExporter.create_branch_with_patch):
1423
1424 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1425
1426         Move FileSystem to WTF
1427         https://bugs.webkit.org/show_bug.cgi?id=193602
1428
1429         Reviewed by Yusuke Suzuki.
1430
1431         * DumpRenderTree/win/DumpRenderTree.cpp:
1432         * TestWebKitAPI/CMakeLists.txt:
1433         * TestWebKitAPI/PlatformGTK.cmake:
1434         * TestWebKitAPI/PlatformJSCOnly.cmake:
1435         * TestWebKitAPI/PlatformPlayStation.cmake:
1436         * TestWebKitAPI/PlatformWPE.cmake:
1437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1438         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1439         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1440         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1441         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1442         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1443         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1444         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1445         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1446         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1447
1448 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1449
1450         [WPE] Remove hard dependency on subprocess32 for the API tests
1451
1452         Rubber-stamped by Carlos Garcia Campos.
1453
1454         * glib/api_test_runner.py:
1455         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1456         its presence only when running WPEQt tests.
1457
1458 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1459
1460         [GLIB] Expose JavaScriptCore options in GLib public API
1461         https://bugs.webkit.org/show_bug.cgi?id=188742
1462
1463         Reviewed by Michael Catanzaro.
1464
1465         Add a test for the new API.
1466
1467         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1468         (testsJSCOptions):
1469         (main):
1470
1471 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1472
1473         [GTK][WPE] Support JPEG 2000 images
1474         https://bugs.webkit.org/show_bug.cgi?id=186272
1475
1476         Reviewed by Žan Doberšek.
1477
1478         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1479
1480         * gtk/jhbuild.modules:
1481         * wpe/jhbuild.modules:
1482
1483 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1484
1485         check-webkit-style should warn when using soft-linking macros in a header
1486         <https://webkit.org/b/193750>
1487
1488         Reviewed by Darin Adler.
1489
1490         * Scripts/webkitpy/style/checkers/cpp.py:
1491         (check_language): Add softlink/header check by refactoring the
1492         softlink/framework check.
1493         (CppChecker): Enable softlink/header check by default.
1494         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1495         (CppStyleTest.test_softlink_framework): Rename from
1496         CppStyleTest.test_softlink() and change test framework name in
1497         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1498         files. Set file_name for macros that only appear in headers.
1499         (CppStyleTest.test_softlink_header): Add tests for using
1500         soft-link macros in headers.
1501
1502 2019-01-23  Chris Dumez  <cdumez@apple.com>
1503
1504         Deprecate API to limit the maximum number of WebProcesses
1505         https://bugs.webkit.org/show_bug.cgi?id=193725
1506         <rdar://problem/47464879>
1507
1508         Reviewed by Geoff Garen.
1509
1510         Update existing API tests to stop using deprecated API.
1511
1512         * MiniBrowser/mac/AppDelegate.m:
1513         (defaultConfiguration):
1514         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1515         (TestWebKitAPI::TEST):
1516         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1517         (TestWebKitAPI::TEST):
1518         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1519         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1520         (TEST):
1521         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1522         (TEST):
1523
1524 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1525
1526         [ews-app] Rename ews model buildermappings to buildermapping
1527         https://bugs.webkit.org/show_bug.cgi?id=193729
1528
1529         Reviewed by Lucas Forschler.
1530
1531         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1532         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1533         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1534
1535 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1536
1537         [ews-app] Rename ews model steps to step
1538         https://bugs.webkit.org/show_bug.cgi?id=193697
1539
1540         Reviewed by Lucas Forschler.
1541
1542         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1543         (Step): Renamed Steps to Step.
1544
1545 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1546
1547         Clean up IndexedDB files between tests
1548         https://bugs.webkit.org/show_bug.cgi?id=192796
1549         <rdar://problem/46824999>
1550
1551         Reviewed by Geoffrey Garen.
1552
1553         * DumpRenderTree/mac/DumpRenderTree.mm:
1554         (runTest):
1555         * WebKitTestRunner/TestController.cpp:
1556         (WTR::TestController::resetStateToConsistentValues):
1557         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1558         (WTR::RemoveAllIndexedDatabasesCallback):
1559         (WTR::TestController::ClearIndexedDatabases):
1560         * WebKitTestRunner/TestController.h:
1561         * WebKitTestRunner/TestInvocation.cpp:
1562         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1563
1564 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1565
1566         [ews-app] Rename ews model Builds to Build
1567         https://bugs.webkit.org/show_bug.cgi?id=193695
1568
1569         Reviewed by Lucas Forschler.
1570
1571         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1572         (Build): Renamed Builds to Build.
1573
1574 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1575
1576         webkitpy: Wait longer when launching WebKitTestRunner
1577         https://bugs.webkit.org/show_bug.cgi?id=193734
1578
1579         Reviewed by Aakash Jain.
1580
1581         * Scripts/webkitpy/port/simulator_process.py:
1582         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
1583
1584 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1585
1586         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
1587         https://bugs.webkit.org/show_bug.cgi?id=193182
1588         <rdar://problem/47452154>
1589
1590         Reviewed by Tim Horton.
1591
1592         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
1593         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
1594         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
1595
1596         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
1597         preventing later tests from recognizing gestures.
1598
1599         * WebKitTestRunner/ios/TestControllerIOS.mm:
1600         (WTR::TestController::platformResetStateToConsistentValues):
1601
1602         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
1603
1604 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1605
1606         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
1607         https://bugs.webkit.org/show_bug.cgi?id=193722
1608         <rdar://problem/47481475>
1609
1610         Reviewed by Lucas Forschler.
1611
1612         iPhone and iPad ports should both use the iOS config.
1613
1614         * Scripts/webkitpy/port/ios_simulator.py:
1615         (IPhoneSimulatorPort.__init__):
1616         (IPadSimulatorPort.__init__):
1617
1618 2019-01-23  Rob Buis  <rbuis@igalia.com>
1619
1620         Update MIME type parser
1621         https://bugs.webkit.org/show_bug.cgi?id=180526
1622
1623         Reviewed by Frédéric Wang.
1624
1625         Add unit tests for both parse modes of ParsedContentType.
1626
1627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1628         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
1629         (TestWebKitAPI::TEST):
1630
1631 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1632
1633         [ews-app] fetch loop should not stop on network issues
1634         https://bugs.webkit.org/show_bug.cgi?id=193666
1635
1636         Reviewed by Lucas Forschler.
1637
1638         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1639         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
1640
1641 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1642
1643         [iOS] Multiple WKWebViewAutofillTests are flaky failures
1644         https://bugs.webkit.org/show_bug.cgi?id=189165
1645         <rdar://problem/47433765>
1646
1647         Reviewed by Tim Horton.
1648
1649         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
1650         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
1651         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
1652         process in sufficient to ensure that any previous action that blurred the focused element in the web process
1653         would make its way to the UI process by the time the layer tree commit is finished.
1654
1655         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
1656         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
1657         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
1658         will fail because it asks for -_autofillContext too early.
1659
1660         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
1661         is handled in the UI process.
1662
1663         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1664
1665         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
1666         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
1667         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
1668         input session.
1669
1670         (-[AutofillTestView textInputHasAutofillContext]):
1671
1672         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
1673
1674         * TestWebKitAPI/cocoa/TestWKWebView.h:
1675         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1676         (nextInputSessionChangeCount):
1677
1678         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
1679         This includes changing the focused element from one to another.
1680
1681         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1682         (-[TestWKWebView didStartFormControlInteraction]):
1683         (-[TestWKWebView didEndFormControlInteraction]):
1684         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1685
1686         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
1687         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
1688         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
1689         that doesn't require an input session to one that doesn't.
1690
1691 2019-01-22  David Kilzer  <ddkilzer@apple.com>
1692
1693         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
1694         <https://webkit.org/b/193676>
1695
1696         Reviewed by Alexey Proskuryakov.
1697
1698         * Scripts/webkitpy/style/checkers/cpp.py:
1699         (check_member_initialization_list):
1700         - Don't report missing whitespace around colon if the colon at
1701           the start of the line is formatted correctly.
1702         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1703         (WebKitStyleTest.test_member_initialization_list):
1704         - Add a test for a missing permutation of existing tests.
1705         - Add a test this false-positive.
1706         - Add blank lines between subtests to make them easier to read.
1707
1708 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1709
1710         [build.webkit.org] Unit-test failure after r237113
1711         https://bugs.webkit.org/show_bug.cgi?id=193669
1712
1713         Reviewed by Michael Catanzaro.
1714
1715         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1716         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
1717         multiple or zero flags.
1718
1719 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
1720
1721         Cache bytecode to disk
1722         https://bugs.webkit.org/show_bug.cgi?id=192782
1723         <rdar://problem/46084932>
1724
1725         Reviewed by Keith Miller.
1726
1727         Add test helper to execute bytecode-cache tests: it executes each test
1728         twice, the first with JSC_diskCachePath set to a temporary directory
1729         and second with JSC_forceDiskCache=true (in addition to the cache path)
1730         to guarantee that only the disk cache is being used and no new
1731         UnlinkedCodeBlocks are being created.
1732
1733         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
1734         * Scripts/run-jsc-stress-tests:
1735
1736 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1737
1738         [css-logical] Implement flow-relative margin, padding and border shorthands
1739         https://bugs.webkit.org/show_bug.cgi?id=188697
1740
1741         Reviewed by Simon Fraser and Antti Koivisto.
1742
1743         * DumpRenderTree/TestOptions.cpp:
1744         (TestOptions::TestOptions):
1745         * DumpRenderTree/TestOptions.h:
1746         * DumpRenderTree/mac/DumpRenderTree.mm:
1747         (setWebPreferencesForTestOptions):
1748         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1749
1750         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1751         (JSONCSSPropertiesChecker.check_codegen_properties):
1752         Allow CSS property definitions to have a 'runtime-flag' parameter which
1753         disables the property when the specified runtime flag is disabled.
1754
1755 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1756
1757         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1758         https://bugs.webkit.org/show_bug.cgi?id=193643
1759
1760         Reviewed by Michael Catanzaro.
1761
1762         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1763         * wpe/jhbuild.modules: Ditto.
1764
1765 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1766
1767         [LFC][Floats] Take float top position into account when computing containing block height.
1768         https://bugs.webkit.org/show_bug.cgi?id=193655
1769
1770         Reviewed by Antti Koivisto.
1771
1772         * LayoutReloaded/misc/LFC-passing-tests.txt:
1773
1774 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1775
1776         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1777         <https://webkit.org/b/193645>
1778         <rdar://problem/47421574>
1779
1780         Reviewed by Alex Christensen.
1781
1782         - Now checks for local soft-linking of all frameworks that have
1783           their own *SoftLinking.{cpp,h,mm} files.
1784         - Changes softlink/uikit warning to softlink/framework.
1785
1786         * Scripts/webkitpy/style/checkers/cpp.py:
1787         (check_language):
1788         (CppChecker):
1789         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1790         (CppStyleTest):
1791
1792 2019-01-20  Saam Barati  <sbarati@apple.com>
1793
1794         Rollout r240210: It broke tests on iOS
1795         https://bugs.webkit.org/show_bug.cgi?id=193640
1796
1797         Unreviewed.
1798
1799         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1800         * Scripts/run-jsc-stress-tests:
1801
1802 2019-01-20  chris fleizach  <cfleizach@apple.com>
1803
1804         AX: Support returning relative frames for accessibility
1805         https://bugs.webkit.org/show_bug.cgi?id=193414
1806         <rdar://problem/47268501>
1807
1808         Reviewed by Zalan Bujtas.
1809
1810         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1811         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1812         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1813         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1814         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1815         (WTR::attributesOfElement):
1816         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1817
1818 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1819
1820         Unreviewed, add my new email address
1821
1822         * Scripts/webkitpy/common/config/contributors.json:
1823
1824 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1825
1826         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1827         https://bugs.webkit.org/show_bug.cgi?id=193617
1828
1829         Reviewed by Antti Koivisto.
1830
1831         * LayoutReloaded/misc/LFC-passing-tests.txt:
1832
1833 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1834
1835         Unreviewed, rolling out r240209.
1836
1837         Broke GTK/WPE injected bundle
1838
1839         Reverted changeset:
1840
1841         "AX: Support returning relative frames for accessibility"
1842         https://bugs.webkit.org/show_bug.cgi?id=193414
1843         https://trac.webkit.org/changeset/240209
1844
1845 2019-01-12  Dan Bernstein  <mitz@apple.com>
1846
1847         [Cocoa] Avoid importing directly from subumbrella frameworks
1848         https://bugs.webkit.org/show_bug.cgi?id=186016
1849         <rdar://problem/40591038>
1850
1851         Reviewed by Sam Weinig.
1852
1853         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1854           LaunchServices header.
1855         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1856           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1857         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1858           when using SDKs earlier than 10.13.
1859         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1860           and OTHER_CPLUSPLUSFLAGS.
1861         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1862           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1863         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1864           LaunchServices header.
1865
1866 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1867
1868         Cache bytecode to disk
1869         https://bugs.webkit.org/show_bug.cgi?id=192782
1870         <rdar://problem/46084932>
1871
1872         Reviewed by Keith Miller.
1873
1874         Add test helper to execute bytecode-cache tests: it executes each test
1875         twice, the first with JSC_diskCachePath set to a temporary directory
1876         and second with JSC_forceDiskCache=true (in addition to the cache path)
1877         to guarantee that only the disk cache is being used and no new
1878         UnlinkedCodeBlocks are being created.
1879
1880         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1881         * Scripts/run-jsc-stress-tests:
1882
1883 2019-01-20  chris fleizach  <cfleizach@apple.com>
1884
1885         AX: Support returning relative frames for accessibility
1886         https://bugs.webkit.org/show_bug.cgi?id=193414
1887         <rdar://problem/47268501>
1888
1889         Reviewed by Zalan Bujtas.
1890
1891         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1892         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1893         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1894         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1895         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1896         (WTR::attributesOfElement):
1897         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1898
1899 2019-01-20  Antoine Quint  <graouts@apple.com>
1900
1901         Add a POINTER_EVENTS feature flag
1902         https://bugs.webkit.org/show_bug.cgi?id=193577
1903         <rdar://problem/47408511>
1904
1905         Unreviewed. Also enable Pointer Events for iosmac.
1906
1907         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1908
1909 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1910
1911         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1912         https://bugs.webkit.org/show_bug.cgi?id=193613
1913
1914         Reviewed by Antti Koivisto.
1915
1916         * LayoutReloaded/misc/LFC-passing-tests.txt:
1917
1918 2019-01-19  Antoine Quint  <graouts@apple.com>
1919
1920         Add a POINTER_EVENTS feature flag
1921         https://bugs.webkit.org/show_bug.cgi?id=193577
1922
1923         Reviewed by Dean Jackson.
1924
1925         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1926
1927 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1928
1929         Disable the run-jsc-stress-test remote host key check [second round].
1930         https://bugs.webkit.org/show_bug.cgi?id=192988
1931
1932         Reviewed by Dewei Zhu.
1933
1934         * Scripts/run-jsc-stress-tests:
1935
1936 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1937
1938         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1939         https://bugs.webkit.org/show_bug.cgi?id=193597
1940
1941         Reviewed by Lucas Forschler.
1942
1943         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1944
1945 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1946
1947         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1948         https://bugs.webkit.org/show_bug.cgi?id=193595
1949
1950         Reviewed by Lucas Forschler.
1951
1952         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1953         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1954         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1955
1956 2019-01-18  Chris Dumez  <cdumez@apple.com>
1957
1958         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1959         https://bugs.webkit.org/show_bug.cgi?id=193588
1960         <rdar://problem/47131566>
1961
1962         Reviewed by Alex Christensen.
1963
1964         Add layout test coverage.
1965
1966         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1967
1968 2019-01-18  Jer Noble  <jer.noble@apple.com>
1969
1970         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1971         https://bugs.webkit.org/show_bug.cgi?id=189553
1972
1973         Reviewed by Tim Horton.
1974
1975         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1976
1977         * ContentExtensionTester/Configurations/Base.xcconfig:
1978         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1979         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1980         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1981         * ImageDiff/cg/Configurations/Base.xcconfig:
1982         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1983         * MiniBrowser/Configurations/Base.xcconfig:
1984         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1985         * MobileMiniBrowser/Configurations/Base.xcconfig:
1986         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1987         * Scripts/webkitpy/style/checker.py:
1988         (_all_categories):
1989         (FileType):
1990         (CheckerDispatcher._file_type):
1991         (CheckerDispatcher._create_checker):
1992         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1993         (SDKVariantChecker):
1994         (SDKVariantChecker.__init__):
1995         (SDKVariantChecker.check):
1996         * TestWebKitAPI/Configurations/Base.xcconfig:
1997         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1998         * WebEditingTester/Configurations/Base.xcconfig:
1999         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2000         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2001         * WebKitTestRunner/Configurations/Base.xcconfig:
2002         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2003         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2004         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2005
2006 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2007
2008         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2009         <https://webkit.org/b/193568>
2010         <rdar://problem/47381130>
2011
2012         Reviewed by Alex Christensen.
2013
2014         Make sure no one re-introduces UIKit soft-linking by adding a
2015         style rule.
2016
2017         * Scripts/webkitpy/style/checkers/cpp.py:
2018         (check_language): Add softlink/uikit check.
2019         (CppChecker): Enable softlink/uikit check.
2020         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2021         (CppStyleTest): Add test for softlink/uikit.
2022
2023 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2024
2025         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2026         https://bugs.webkit.org/show_bug.cgi?id=193584
2027
2028         Change "-dev" to "-devel".
2029
2030         Reviewed by Michael Catanzaro.
2031
2032         * gtk/install-dependencies:
2033
2034 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2035
2036         webkitpy: Add iPhone and iPad ports
2037         https://bugs.webkit.org/show_bug.cgi?id=193537
2038         <rdar://problem/47353390>
2039
2040         Reviewed by Lucas Forschler.
2041
2042         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2043         ports. Note that this separation is optional, the --ios-simulator command remains.
2044
2045         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2046         (RunTest.test_device_type_test_division): Drive-by fix.
2047         (RunTest.test_device_type_specific_listing): Ditto.
2048         (RunTest.test_ipad_test_division):
2049         (RunTest):
2050         (RunTest.test_ipad_listing):
2051         * Scripts/webkitpy/port/factory.py:
2052         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2053         (PortFactory):
2054         * Scripts/webkitpy/port/ios_simulator.py:
2055         (IPhoneSimulatorPort):
2056         (IPadSimulatorPort):
2057
2058 2019-01-18  Chris Dumez  <cdumez@apple.com>
2059
2060         Regression(PSON) Scroll position is not always restored properly when navigating back
2061         https://bugs.webkit.org/show_bug.cgi?id=193578
2062         <rdar://problem/47386331>
2063
2064         Reviewed by Tim Horton.
2065
2066         Add API test coverage.
2067
2068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2069
2070 2019-01-18  Youenn Fablet  <youenn@apple.com>
2071
2072         Add a new SPI to request for cache storage quota increase
2073         https://bugs.webkit.org/show_bug.cgi?id=193323
2074
2075         Reviewed by Alex Christensen.
2076
2077         Implement WebsiteDataStore quota delegate to handle quota requests.
2078         By default, do not update quota.
2079         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2080
2081         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2082         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2083         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2084         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2085         * WebKitTestRunner/TestController.cpp:
2086         (WTR::TestController::allowCacheStorageQuotaIncrease):
2087         * WebKitTestRunner/TestController.h:
2088         * WebKitTestRunner/TestInvocation.cpp:
2089         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2090         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2091         (-[CacheStorageQuotaManager init]):
2092         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2093         (WTR::initializeWebViewConfiguration):
2094         (WTR::TestController::cocoaResetStateToConsistentValues):
2095         (WTR::TestController::allowCacheStorageQuotaIncrease):
2096
2097 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2098
2099         [ews-build] Pass owner to the triggered builds
2100         https://bugs.webkit.org/show_bug.cgi?id=193574
2101
2102         Reviewed by Lucas Forschler.
2103
2104         * BuildSlaveSupport/ews-build/factories.py:
2105         (BuildFactory.propertiesToPassToTriggers):
2106
2107 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2108
2109         [ews-app] Send patch author as a build property
2110         https://bugs.webkit.org/show_bug.cgi?id=193560
2111
2112         Reviewed by Lucas Forschler.
2113
2114         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2115         (BugzillaPatchFetcher.fetch):
2116
2117 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2118
2119         webkitpy: Implement device type specific expected results (Follow-up fix)
2120         https://bugs.webkit.org/show_bug.cgi?id=192162
2121         <rdar://problem/46345449>
2122
2123         Unreviewed infrastructure fix.
2124
2125         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2126         (Manager.run): Don't boot a device if no tests are available to run on it.
2127
2128 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2129
2130         webkitpy: Implement device type specific expected results (Follow-up fix)
2131         https://bugs.webkit.org/show_bug.cgi?id=192162
2132         <rdar://problem/46345449>
2133
2134         Unreviewed infrastructure fix.
2135
2136         * Scripts/webkitpy/api_tests/manager.py:
2137         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2138
2139 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2140
2141         webkitpy: Implement device type specific expected results (Part 2)
2142         https://bugs.webkit.org/show_bug.cgi?id=192162
2143         <rdar://problem/46345449>
2144
2145         Rubber-stamped by Aakash Jain.
2146
2147         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2148         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2149         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2150
2151         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2152         (LayoutTestFinder.find_tests): Pass device_type through.
2153         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2154         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2155         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2156         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2157         (Manager._collect_tests): Pass device type to test finder.
2158         (Manager._needs_web_platform_test):
2159         (Manager._prepare_lists): Index _expectations by device type.
2160         (Manager._test_input_for_file):
2161         (Manager._test_is_slow): Ditto.
2162         (Manager._test_should_dump_jsconsolelog_in_stderr):
2163         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2164         (Manager._get_test_inputs):
2165         (Manager._update_worker_count):
2166         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2167         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2168         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2169         the one which runs the test.
2170         (Manager._run_test_subset):
2171         (Manager._run_tests): Index _expectations by current_device_type.
2172         (Manager._print_expectation_line_for_test): Ditto.
2173         (Manager._print_expectations_for_subset): Ditto.
2174         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2175         Unlike run, this function will behave the same regardless of what devices are available.
2176         (Manager._custom_device_for_test): Deleted.
2177         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2178         (ManagerTest.test_uses_custom_device): Deleted.
2179         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2180         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2181         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2182         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2183         all of the expectations.
2184         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2185         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2186         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2187         (TestExpectations.__init__): Allow device_type to be passed through.
2188         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2189         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2190         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2191         (summarize_results):
2192         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2193         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2194         a test ran with, one must check all expectations to find the first non-skip expectation.
2195         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2196         (RunTest.test_device_type_test_division):
2197         (RunTest):
2198         (RunTest.test_device_type_specific_listing):
2199         * Scripts/webkitpy/port/base.py:
2200         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2201         (Port.supported_device_types): The result of this function will change based on what devices are available.
2202         * Scripts/webkitpy/port/device_port.py:
2203         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2204         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2205         can be used.
2206         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2207         any, or the DEFAULT_DEVICE_TYPES of the port.
2208         * Scripts/webkitpy/port/ios.py:
2209         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2210         * Scripts/webkitpy/port/ios_simulator.py:
2211         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2212         * Scripts/webkitpy/port/watch.py:
2213         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2214         * Scripts/webkitpy/port/watch_simulator.py:
2215         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2216         * Scripts/webkitpy/xcode/device_type.py:
2217         (DeviceType):
2218         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2219
2220 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2221
2222         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2223         https://bugs.webkit.org/show_bug.cgi?id=193575
2224
2225         Reviewed by Michael Catanzaro.
2226
2227         Allow the script to run without explicit port argument because
2228         it's specific to the WPE port anyway.
2229
2230         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2231         and simplify the rest of the code accordingly.
2232
2233 2019-01-18  Charlie Turner  <cturner@igalia.com>
2234
2235         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2236         https://bugs.webkit.org/show_bug.cgi?id=192229
2237
2238         Reviewed by Xabier Rodriguez-Calvar.
2239
2240         * MiniBrowser/wpe/main.cpp:
2241         (main): Enable encrypted-media by default.
2242
2243 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2244
2245         [Flatpak] Missing KeyboardInterrupt exception handler
2246         https://bugs.webkit.org/show_bug.cgi?id=193570
2247
2248         Reviewed by Michael Catanzaro.
2249
2250         * flatpak/flatpakutils.py:
2251         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2252
2253 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2254
2255         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2256         https://bugs.webkit.org/show_bug.cgi?id=193564
2257
2258         Reviewed by Antti Koivisto.
2259
2260         * LayoutReloaded/misc/LFC-passing-tests.txt:
2261
2262 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2263
2264         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2265         https://bugs.webkit.org/show_bug.cgi?id=193562
2266
2267         Reviewed by Antti Koivisto.
2268
2269         * LayoutReloaded/misc/LFC-passing-tests.txt:
2270
2271 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2272
2273         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2274         https://bugs.webkit.org/show_bug.cgi?id=193555
2275
2276         Reviewed by Antti Koivisto.
2277
2278         * LayoutReloaded/misc/LFC-passing-tests.txt:
2279
2280 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2281
2282         [WPE] Add Qt extension
2283         https://bugs.webkit.org/show_bug.cgi?id=191464
2284
2285         Reviewed by Carlos Garcia Campos.
2286
2287         MiniBrowser and API tests for the WPE Qt API. To run the
2288         MiniBrowser a new script is introduced. Example invocation:
2289
2290         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2291
2292         Also note-worthy is the introduction of the python2-subprocess32
2293         dependency to run the GLib API tests.
2294
2295         * MiniBrowser/wpe/CMakeLists.txt:
2296         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2297         * MiniBrowser/wpe/qt/main.cpp: Added.
2298         (main):
2299         * MiniBrowser/wpe/qt/main.qml: Added.
2300         * MiniBrowser/wpe/qt/qml.qrc: Added.
2301         * Scripts/run-gtk-tests:
2302         (GtkTestRunner.is_google_test):
2303         (GtkTestRunner):
2304         (GtkTestRunner.is_qt_test):
2305         * Scripts/run-qt-wpe-minibrowser: Added.
2306         * Scripts/run-wpe-tests:
2307         (WPETestRunner):
2308         (WPETestRunner.is_google_test):
2309         (WPETestRunner.is_qt_test):
2310         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2311         (TestLoad::main):
2312         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2313         (TestLoadHtml::main):
2314         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2315         (TestLoadRequest::main):
2316         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2317         (TestRunJavaScript::main):
2318         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2319         (waitForSignal):
2320         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2321         (LoadSpy::LoadSpy):
2322         (LoadSpy::~LoadSpy):
2323         (LoadSpy::onLoadingChanged):
2324         (LoadStartedCatcher::LoadStartedCatcher):
2325         (LoadStartedCatcher::~LoadStartedCatcher):
2326         (LoadStartedCatcher::onLoadingChanged):
2327         (waitForLoadSucceeded):
2328         (waitForLoadFailed):
2329         * TestWebKitAPI/glib/CMakeLists.txt:
2330         * flatpak/flatpakutils.py:
2331         (WebkitFlatpak.load_from_args):
2332         (WebkitFlatpak.__init__):
2333         (WebkitFlatpak.clean_args):
2334         (WebkitFlatpak.run_in_sandbox):
2335         * flatpak/org.webkit.CommonModules.yaml:
2336         * flatpak/org.webkit.WPE.yaml:
2337         * flatpak/org.webkit.WPEModules.yaml:
2338         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2339         * flatpak/org.webkit.WebKit.yaml:
2340         * glib/api_test_runner.py:
2341         (TestRunner._run_test_qt):
2342         (TestRunner.is_qt_test):
2343         (TestRunner._run_test):
2344
2345 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2346
2347         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2348         https://bugs.webkit.org/show_bug.cgi?id=193494
2349         <rdar://problem/46859627>
2350
2351         Reviewed by Simon Fraser and Tim Horton.
2352
2353         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2354         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2355
2356         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2357         (WTR::UIScriptController::contentOffsetX const):
2358         (WTR::UIScriptController::contentOffsetY const):
2359         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2360         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2361         (WTR::UIScriptController::contentOffsetX const):
2362         (WTR::UIScriptController::contentOffsetY const):
2363         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2364
2365         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2366
2367         * WebKitTestRunner/TestController.cpp:
2368         (WTR::updateTestOptionsFromTestHeader):
2369         * WebKitTestRunner/TestOptions.h:
2370         (WTR::TestOptions::hasSameInitializationOptions const):
2371         * WebKitTestRunner/ios/TestControllerIOS.mm:
2372         (WTR::TestController::platformResetStateToConsistentValues):
2373         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2374         (WTR::UIScriptController::contentOffsetX const):
2375         (WTR::UIScriptController::contentOffsetY const):
2376
2377 2019-01-17  Truitt Savell  <tsavell@apple.com>
2378
2379         Unreviewed, rolling out r240124.
2380
2381         This commit broke an internal build.
2382
2383         Reverted changeset:
2384
2385         "SDK_VARIANT build destinations should be separate from non-
2386         SDK_VARIANT builds"
2387         https://bugs.webkit.org/show_bug.cgi?id=189553
2388         https://trac.webkit.org/changeset/240124
2389
2390 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2391
2392         Fix string concatenation API test after r239920
2393         https://bugs.webkit.org/show_bug.cgi?id=193551
2394         <rdar://problem/47359304>
2395
2396         Reviewed by Youenn Fablet.
2397
2398         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2399         (TestWebKitAPI::TEST):
2400         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2401         in WebKit's build configuration like it apparently is on Linux.
2402
2403 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2404
2405         [ews-build] validate-patch should handle the case when bug_id is None
2406         https://bugs.webkit.org/show_bug.cgi?id=193547
2407
2408         Reviewed by Lucas Forschler.
2409
2410         * BuildSlaveSupport/ews-build/steps.py:
2411         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2412         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2413
2414 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2415
2416         [ews-build] Add patch author information in build
2417         https://bugs.webkit.org/show_bug.cgi?id=193465
2418
2419         Reviewed by Lucas Forschler.
2420
2421         * BuildSlaveSupport/ews-build/steps.py:
2422         (ValidatePatch._is_patch_obsolete):
2423
2424 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2425
2426         [ews-build] Pass bug_id to the triggered builds
2427         https://bugs.webkit.org/show_bug.cgi?id=193548
2428
2429         Reviewed by Lucas Forschler.
2430
2431         * BuildSlaveSupport/ews-build/factories.py:
2432         (BuildFactory.propertiesToPassToTriggers):
2433
2434 2019-01-17  Jer Noble  <jer.noble@apple.com>
2435
2436         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2437         https://bugs.webkit.org/show_bug.cgi?id=189553
2438
2439         Reviewed by Tim Horton.
2440
2441         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2442
2443         * ContentExtensionTester/Configurations/Base.xcconfig:
2444         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2445         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2446         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2447         * ImageDiff/cg/Configurations/Base.xcconfig:
2448         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2449         * MiniBrowser/Configurations/Base.xcconfig:
2450         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2451         * MobileMiniBrowser/Configurations/Base.xcconfig:
2452         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2453         * Scripts/webkitpy/style/checker.py:
2454         (_all_categories):
2455         (FileType):
2456         (CheckerDispatcher._file_type):
2457         (CheckerDispatcher._create_checker):
2458         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2459         (SDKVariantChecker):
2460         (SDKVariantChecker.__init__):
2461         (SDKVariantChecker.check):
2462         * TestWebKitAPI/Configurations/Base.xcconfig:
2463         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2464         * WebEditingTester/Configurations/Base.xcconfig:
2465         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2466         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2467         * WebKitTestRunner/Configurations/Base.xcconfig:
2468         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2469         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2470         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2471
2472 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2473
2474         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2475         https://bugs.webkit.org/show_bug.cgi?id=193534
2476
2477         Reviewed by Antti Koivisto.
2478
2479         * LayoutReloaded/misc/LFC-passing-tests.txt:
2480
2481 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2482
2483         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2484         https://bugs.webkit.org/show_bug.cgi?id=193528
2485
2486         Reviewed by Antti Koivisto.
2487
2488         * LayoutReloaded/misc/LFC-passing-tests.txt:
2489
2490 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2491
2492         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2493         https://bugs.webkit.org/show_bug.cgi?id=193520
2494
2495         Reviewed by Antti Koivisto.
2496
2497         * LayoutReloaded/misc/LFC-passing-tests.txt:
2498
2499 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2500
2501         [ews-build] unapply-patch step should not update source
2502         https://bugs.webkit.org/show_bug.cgi?id=193234
2503
2504         Reviewed by Lucas Forschler.
2505
2506         * BuildSlaveSupport/ews-build/steps.py:
2507         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2508         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2509
2510 2019-01-16  Youenn Fablet  <youenn@apple.com>
2511
2512         Add a new SPI for controlling getUserMedia
2513         https://bugs.webkit.org/show_bug.cgi?id=192793
2514
2515         Reviewed by Eric Carlson.
2516
2517         * MiniBrowser/mac/WK2BrowserWindowController.m:
2518         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2519         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2520         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2521         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2522         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2523         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2524         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2525         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2526         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2527         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2528         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2529         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2530         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2531         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2532
2533 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2534
2535         [LFC][BFC] Inflow non-replaced used width should not be negative.
2536         https://bugs.webkit.org/show_bug.cgi?id=193495
2537
2538         Reviewed by Antti Koivisto.
2539
2540         * LayoutReloaded/misc/LFC-passing-tests.txt:
2541
2542 2019-01-16  Chris Dumez  <cdumez@apple.com>
2543
2544         Regression(PSON) View becomes blank after click a cross-site download link
2545         https://bugs.webkit.org/show_bug.cgi?id=193361
2546         <rdar://problem/47099573>
2547
2548         Reviewed by Geoffrey Garen.
2549
2550         Add API test coverage.
2551
2552         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2553         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2554
2555 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2556
2557         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2558         https://bugs.webkit.org/show_bug.cgi?id=193470
2559
2560         Reviewed by Antti Koivisto.
2561
2562         * LayoutReloaded/misc/LFC-passing-tests.txt:
2563
2564 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2565
2566         [LFC] Adjust margin box verification.
2567         https://bugs.webkit.org/show_bug.cgi?id=193482
2568
2569         Reviewed by Antti Koivisto.
2570
2571         * LayoutReloaded/misc/LFC-passing-tests.txt:
2572
2573 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2574
2575         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2576         https://bugs.webkit.org/show_bug.cgi?id=193451
2577
2578         Reviewed by Geoffrey Garen.
2579
2580         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
2581         (TEST):
2582         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2583         (runWebsiteDataStoreCustomPaths):
2584
2585 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2586
2587         webkitpy: Support boolean simctl isAvailable
2588         https://bugs.webkit.org/show_bug.cgi?id=193472
2589         <rdar://problem/47296150>
2590
2591         Reviewed by Ryosuke Niwa.
2592
2593         * Scripts/webkitpy/xcode/simulated_device.py:
2594         (SimulatedDeviceManager._create_runtimes):
2595         (SimulatedDeviceManager._create_device_with_runtime):
2596
2597 2019-01-15  Chris Dumez  <cdumez@apple.com>
2598
2599         Unreviewed, rolling out r239993, r239995, r239997, and
2600         r239999.
2601
2602         Caused assertions under
2603         ViewGestureController::disconnectFromProcess()
2604
2605         Reverted changesets:
2606
2607         "Regression(PSON) View becomes blank after click a cross-site
2608         download link"
2609         https://bugs.webkit.org/show_bug.cgi?id=193361
2610         https://trac.webkit.org/changeset/239993
2611
2612         "Unreviewed iOS build fix after r239993."
2613         https://trac.webkit.org/changeset/239995
2614
2615         "Fix iOS build after r239993"
2616         https://bugs.webkit.org/show_bug.cgi?id=193361
2617         https://trac.webkit.org/changeset/239997
2618
2619         "Unreviewed, revert part of r239997 as it is not needed to fix
2620         the build."
2621         https://trac.webkit.org/changeset/239999
2622
2623 2019-01-15  Tim Horton  <timothy_horton@apple.com>
2624
2625         Cannot tab out of WKWebView on macOS
2626         https://bugs.webkit.org/show_bug.cgi?id=161448
2627         <rdar://problem/28100085>
2628
2629         Reviewed by Dean Jackson.
2630
2631         Add a test that tabbing into and out of WKWebView works correctly.
2632
2633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2634         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2635         (WebKit2_CommandBackForwardTest::SetUp):
2636         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
2637         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
2638         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
2639         (-[FocusableView canBecomeKeyView]):
2640         (TEST):
2641         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
2642         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
2643         (-[OffscreenWindow initWithSize:]):
2644         (-[OffscreenWindow isKeyWindow]):
2645         (-[OffscreenWindow isVisible]):
2646         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2647         (TestWebKitAPI::PlatformWebView::initialize):
2648         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
2649         (-[ActiveOffscreenWindow isVisible]): Deleted.
2650         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
2651
2652 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
2653
2654         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
2655         https://bugs.webkit.org/show_bug.cgi?id=193459
2656
2657         Reviewed by Mark Lam.
2658
2659         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2660         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
2661
2662 2019-01-15  Chris Dumez  <cdumez@apple.com>
2663
2664         Regression(PSON) View becomes blank after click a cross-site download link
2665         https://bugs.webkit.org/show_bug.cgi?id=193361
2666         <rdar://problem/47099573>
2667
2668         Reviewed by Geoff Garen.
2669
2670         Add API test coverage.
2671
2672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2673         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2674
2675 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2676
2677         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
2678         https://bugs.webkit.org/show_bug.cgi?id=193448
2679
2680         Reviewed by Antti Koivisto.
2681
2682         * LayoutReloaded/misc/LFC-passing-tests.txt:
2683
2684 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2685
2686         webkitpy: Implement device type specific expected results (Part 1)
2687         https://bugs.webkit.org/show_bug.cgi?id=192162
2688
2689         Reviewed by Lucas Forschler.
2690
2691         Device type specific expected results covers two related ideas. The first (covered by this change)
2692         is where to search for -expected.* files. The second is which tests to run based on the
2693         TestExpectations.txt file.
2694
2695         After this change, the baseline search path will be determined by the type of device running a
2696         test. Device type will be passed into any function which picks a file based on the baseline search
2697         path.
2698
2699         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2700         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
2701         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2702         (Manager.run): Print baseline search path for each round of devices.
2703         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2704         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
2705         (SingleTestRunner._expected_driver_output): Ditto.
2706         (SingleTestRunner._driver_input): Ditto.
2707         * Scripts/webkitpy/layout_tests/views/printing.py:
2708         (Printer.print_config): Move printing of baseline search path to a separate function.
2709         (Printer.print_baseline_search_path): Moved from Printer.print_config.
2710         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2711         (Testprinter.test_print_config):
2712         (Testprinter.test_print_baseline_search_path):
2713         * Scripts/webkitpy/port/base.py:
2714         (Port.baseline_search_path): Pass device_type through.
2715         (Port._expected_baselines_for_suffixes): Ditto.
2716         (Port.expected_baselines): Ditto.
2717         (Port.expected_filename): Ditto.
2718         (Port.expected_checksum): Ditto.
2719         (Port.expected_image): Ditto.
2720         (Port.expected_audio): Ditto.
2721         (Port.expected_text): Ditto.
2722         (Port.reference_files): Ditto.
2723         (Port.tests): Ditto.
2724         (Port._expanded_paths): Ditto.
2725         (Port.skipped_layout_tests): Ditto.
2726         (Port.expectations_dict): Ditto.
2727         (Port._port_specific_expectations_files): Ditto.
2728         (Port.expectations_files): Ditto.
2729         (Port.test_search_path): Ditto.
2730         (Port._tests_for_other_platforms): Ditto.
2731         * Scripts/webkitpy/port/base_unittest.py:
2732         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
2733         (PortTest.test_nonexistant_expectations): Ditto.
2734         (test_ref_tests_platform_directory): Ditto.
2735         * Scripts/webkitpy/port/darwin.py:
2736         (DarwinPort._port_specific_expectations_files): Accept device_type.
2737         * Scripts/webkitpy/port/driver.py:
2738         (DriverProxy):
2739         (DriverProxy.host): Expose _target_host for device_type information.
2740         * Scripts/webkitpy/port/gtk.py:
2741         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2742         * Scripts/webkitpy/port/ios.py:
2743         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2744         * Scripts/webkitpy/port/mac.py:
2745         (MacPort. default_baseline_search_path): Ditto.
2746         * Scripts/webkitpy/port/port_testcase.py:
2747         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2748         * Scripts/webkitpy/port/test.py:
2749         * Scripts/webkitpy/port/watch.py:
2750         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2751         * Scripts/webkitpy/port/win.py:
2752         (WinPort.test_search_path): Accept, but do not use, device_type.
2753         * Scripts/webkitpy/port/wpe.py:
2754         (WPEPort._port_specific_expectations_files): Ditto.
2755         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2756         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2757
2758 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2759
2760         [LFC] Use the containing block's padding box to position out-of-flow elements.
2761         https://bugs.webkit.org/show_bug.cgi?id=193431
2762
2763         Reviewed by Antti Koivisto.
2764
2765         * LayoutReloaded/misc/LFC-passing-tests.txt:
2766
2767 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2768
2769         Move a test implementation file that got misplaced in the Xcode project
2770
2771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2772
2773 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2774
2775         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2776         r239913, and r239914.
2777         https://bugs.webkit.org/show_bug.cgi?id=193407
2778
2779         These revisions caused an internal failure (Requested by
2780         Truitt on #webkit).
2781
2782         Reverted changesets:
2783
2784         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2785         https://bugs.webkit.org/show_bug.cgi?id=186016
2786         https://trac.webkit.org/changeset/239901
2787
2788         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2789         https://trac.webkit.org/changeset/239909
2790
2791         "Tried to fix the build."
2792         https://trac.webkit.org/changeset/239910
2793
2794         "Fixed iOS builds after r239910."
2795         https://trac.webkit.org/changeset/239912
2796
2797         "More build fixing."
2798         https://trac.webkit.org/changeset/239913
2799
2800         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2801         https://trac.webkit.org/changeset/239914
2802
2803 2019-01-14  Mark Lam  <mark.lam@apple.com>
2804
2805         Re-enable ability to build --cloop builds.
2806         https://bugs.webkit.org/show_bug.cgi?id=192955
2807         <rdar://problem/46882363>
2808
2809         Reviewed by Saam barati and Keith Miller.
2810
2811         The --cloop build option was being ignored this whole time since r236381.
2812         This patch makes it possible to build CLoop builds again.
2813
2814         * Scripts/build-jsc:
2815         * Scripts/webkitperl/FeatureList.pm:
2816         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2817
2818 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2819
2820         webkitpy: Expose device_type from host-like objects
2821         https://bugs.webkit.org/show_bug.cgi?id=193406
2822         <rdar://problem/47262305>
2823
2824         Reviewed by Lucas Forschler.
2825
2826         Devices should expose device_type. As a result, all host objects should
2827         provide a device_type property, even if they do not yet define a device_type.
2828
2829         * Scripts/webkitpy/common/system/systemhost.py:
2830         (SystemHost):
2831         (SystemHost.device_type):
2832         * Scripts/webkitpy/common/system/systemhost_mock.py:
2833         (MockSystemHost):
2834         (MockSystemHost.device_type):
2835         * Scripts/webkitpy/port/device.py:
2836         (Device):
2837         (Device.device_type):
2838         * Scripts/webkitpy/xcode/simulated_device.py:
2839         (SimulatedDeviceManager._find_exisiting_device_for_request):
2840         (SimulatedDeviceManager._disambiguate_device_type):
2841         (SimulatedDeviceManager._does_fulfill_request):
2842         (SimulatedDeviceManager.device_count_for_type):
2843         (SimulatedDeviceManager.initialize_devices):
2844         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2845         (test_available_devices):
2846         (test_swapping_devices):
2847
2848 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2849
2850         webkitpy: Support alternate simctl device list output (Follow-up fix)
2851         https://bugs.webkit.org/show_bug.cgi?id=193362
2852         <rdar://problem/47122965>
2853
2854         Rubber-stamped by Lucas Forschler.
2855
2856         * Scripts/webkitpy/xcode/simulated_device.py:
2857         (SimulatedDeviceManager.populate_available_devices):
2858
2859 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2860
2861         [iOS] Expose SPI to access the current sentence boundary and selection state
2862         https://bugs.webkit.org/show_bug.cgi?id=193398
2863         <rdar://problem/45893108>
2864
2865         Reviewed by Dean Jackson.
2866
2867         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2868         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2869         expected.
2870
2871         * TestWebKitAPI/EditingTestHarness.h:
2872         * TestWebKitAPI/EditingTestHarness.mm:
2873         (-[EditingTestHarness moveBackward]):
2874         (-[EditingTestHarness moveForward]):
2875         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2876
2877         Add a couple of new helper methods on EditingTestHarness.
2878
2879         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2880         (-[SelectionChangeObserver initWithWebView:]):
2881         (-[SelectionChangeObserver webView]):
2882         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2883         (-[SelectionChangeObserver currentSelectionAttributes]):
2884
2885 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2886
2887         [LFC][BFC] Add basic box-sizing support.
2888         https://bugs.webkit.org/show_bug.cgi?id=193392
2889
2890         Reviewed by Antti Koivisto.
2891
2892         * LayoutReloaded/misc/LFC-passing-tests.txt:
2893
2894 2019-01-14  Charlie Turner  <cturner@igalia.com>
2895
2896         [WPE] API test gardening
2897         https://bugs.webkit.org/show_bug.cgi?id=193319
2898
2899         Reviewed by Michael Catanzaro.
2900
2901         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2902         passing tests.
2903
2904 2019-01-14  Charlie Turner  <cturner@igalia.com>
2905
2906         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2907         https://bugs.webkit.org/show_bug.cgi?id=192977
2908
2909         Reviewed by Carlos Garcia Campos.
2910
2911         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2912         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2913         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2914         (TestWebKitAPI::GStreamerTest::SetUp):
2915         (TestWebKitAPI::GStreamerTest::TearDown):
2916         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2917         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2918         (TestWebKitAPI::TEST_F):
2919
2920 2019-01-14  Charlie Turner  <cturner@igalia.com>
2921
2922         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2923         https://bugs.webkit.org/show_bug.cgi?id=193332
2924
2925         Reviewed by Michael Catanzaro.
2926
2927         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2928         defined as a char16_t, which changed in ICU 59, the
2929         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2930         unsigned short. This test is relying on the behaviour that
2931         UChar=unsigned short, which doesn't hold across platforms and ICU
2932         library versions. The full fix would be a special syntax for
2933         literal characters so that these ambiguities do not arise. That
2934         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2935         (TestWebKitAPI::TEST):
2936
2937 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2938
2939         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2940
2941         * Scripts/make-dist:
2942         (Distcheck.configure):
2943
2944 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2945
2946         [ews-build] Update macOS queue configurations
2947         https://bugs.webkit.org/show_bug.cgi?id=193365
2948         <rdar://problem/47221073>
2949
2950         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2951
2952         * BuildSlaveSupport/ews-build/config.json:
2953
2954 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2955
2956         [LFC] Adjust assert for statically positioned fixed elements
2957         https://bugs.webkit.org/show_bug.cgi?id=193385
2958
2959         Reviewed by Antti Koivisto.
2960
2961         * LayoutReloaded/misc/LFC-passing-tests.txt:
2962
2963 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2964
2965         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2966         https://bugs.webkit.org/show_bug.cgi?id=193387
2967
2968         Reviewed by Carlos Garcia Campos.
2969
2970         * MiniBrowser/wpe/main.cpp:
2971         (main):
2972
2973 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2974
2975         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2976         https://bugs.webkit.org/show_bug.cgi?id=191655
2977         rdar://problem/46074680
2978
2979         Reviewed by Megan Gardner.
2980
2981         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2982         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2983
2984 2019-01-12  Dan Bernstein  <mitz@apple.com>
2985
2986         [Cocoa] Avoid importing directly from subumbrella frameworks
2987         https://bugs.webkit.org/show_bug.cgi?id=186016
2988         <rdar://problem/40591038>
2989
2990         Reviewed by Sam Weinig.
2991
2992         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2993           LaunchServices header.
2994         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2995           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2996         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2997           when using SDKs earlier than 10.13.
2998         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2999           and OTHER_CPLUSPLUSFLAGS.
3000         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3001           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3002         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3003           LaunchServices header.
3004
3005 2019-01-11  John Wilander  <wilander@apple.com>
3006
3007         Compile out Web API Statistics Collection
3008         https://bugs.webkit.org/show_bug.cgi?id=193370
3009         <rdar://problem/45388584>
3010
3011         Reviewed by Brent Fulgham.
3012
3013         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3014             Defined ENABLE_WEB_API_STATISTICS, off by default.
3015
3016 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3017
3018         [WPE] Add gtk-doc
3019         https://bugs.webkit.org/show_bug.cgi?id=178900
3020
3021         Reviewed by Michael Catanzaro.
3022
3023         Add Tools/gtkdoc to manifest.txt.in files.
3024         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3025
3026         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3027         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3028
3029 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3030
3031         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3032         https://bugs.webkit.org/show_bug.cgi?id=193364
3033         <rdar://problem/47214117>
3034
3035         Reviewed by Tim Horton.
3036
3037         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3038         precise, whereas dragging near the middle of the textarea does.
3039
3040         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3041         (TestWebKitAPI::TEST):
3042
3043 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3044
3045         webkitpy: Support alternate simctl device list output
3046         https://bugs.webkit.org/show_bug.cgi?id=193362
3047         <rdar://problem/47122965>
3048
3049         Reviewed by Lucas Forschler.
3050
3051         * Scripts/webkitpy/xcode/simulated_device.py:
3052         (SimulatedDeviceManager.populate_available_devices):
3053
3054 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3055
3056         [ews-build] Update macOS queue configurations
3057         https://bugs.webkit.org/show_bug.cgi?id=193365
3058
3059         Reviewed by Lucas Forschler.
3060
3061         * BuildSlaveSupport/ews-build/config.json:
3062
3063 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3064
3065         webkitpy: Incorporate device type into baseline search path
3066         https://bugs.webkit.org/show_bug.cgi?id=193356
3067         <rdar://problem/47215515>
3068
3069         Reviewed by Lucas Forschler.
3070
3071         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3072
3073         * Scripts/webkitpy/port/base.py:
3074         (Port.default_baseline_search_path): Allow device type to be passed in.
3075         * Scripts/webkitpy/port/gtk.py:
3076         (GtkPort.default_baseline_search_path): Ignore device type.
3077         * Scripts/webkitpy/port/ios.py:
3078         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3079         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3080         * Scripts/webkitpy/port/ios_device_unittest.py:
3081         (IOSDeviceTest):
3082         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3083         (IOSSimulatorTest):
3084         * Scripts/webkitpy/port/mac.py:
3085         (MacPort.default_baseline_search_path): Ignore device type.
3086         * Scripts/webkitpy/port/watch.py:
3087         (WatchPort.default_baseline_search_path): Ditto.
3088         * Scripts/webkitpy/port/win.py:
3089         (WinPort.default_baseline_search_path): Ditto.
3090         (WinCairoPort.default_baseline_search_path): Ditto.
3091         * Scripts/webkitpy/port/wpe.py:
3092         (WPEPort.default_baseline_search_path): Ditto.
3093
3094 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3095
3096         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3097         https://bugs.webkit.org/show_bug.cgi?id=193352
3098         <rdar://problem/47210736>
3099
3100         Reviewed by Lucas Forschler.
3101
3102         * Scripts/webkitpy/layout_tests/views/printing.py:
3103         (Printer.print_config): Print list on only baseline search paths which exist. 
3104         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3105         (Testprinter.test_print_config):
3106
3107 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3108
3109         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3110         https://bugs.webkit.org/show_bug.cgi?id=193340
3111
3112         Reviewed by David Kilzer.
3113
3114         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3115         (WTR::InjectedBundle::didReceiveMessageToPage):
3116         Pull the strings out into a WKRetainPtr.
3117
3118         * WebKitTestRunner/WebNotificationProvider.cpp:
3119         (WTR::WebNotificationProvider::closeWebNotification):
3120         Adopt the created value into the WKRetainPtr.
3121
3122         * WebKitTestRunner/mac/TestControllerMac.mm:
3123         (WTR::generateWhitelist):
3124         Immediately adopt a created value to avoid potential mistakes.
3125
3126 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3127
3128         Enable DFG on ARM/Linux again
3129         https://bugs.webkit.org/show_bug.cgi?id=192496
3130
3131         Reviewed by Yusuke Suzuki.
3132
3133         After changing the bytecode format DFG was disabled on all 32-bit
3134         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3135         on ARM by default.
3136
3137         * Scripts/run-jsc-stress-tests:
3138
3139 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3140
3141         Unreviewed, fix #ifdef in API test added in r239851.
3142         https://bugs.webkit.org/show_bug.cgi?id=193327
3143         rdar://problem/47093222
3144
3145         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3146
3147 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3148
3149         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3150         https://bugs.webkit.org/show_bug.cgi?id=193109
3151         <rdar://problem/44807048>
3152
3153         Reviewed by Ryosuke Niwa.
3154
3155         Introduce and respect a test option to enable the UndoManager API.
3156
3157         * WebKitTestRunner/TestController.cpp:
3158         (WTR::updateTestOptionsFromTestHeader):
3159         * WebKitTestRunner/TestOptions.h:
3160         (WTR::TestOptions::hasSameInitializationOptions const):
3161         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3162         (WTR::TestController::platformCreateWebView):
3163
3164 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3165
3166         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3167         https://bugs.webkit.org/show_bug.cgi?id=193346
3168
3169         Reviewed by Antti Koivisto.
3170
3171         * LayoutReloaded/misc/LFC-passing-tests.txt:
3172
3173 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3174
3175         Unreviewed, fix typo that breaks dashboard link.
3176
3177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3178         (WebKitBuildbot):
3179
3180 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3181
3182         Update macOS queue configurations
3183         https://bugs.webkit.org/show_bug.cgi?id=193329
3184
3185         Reviewed by Alexey Proskuryakov.
3186
3187         * BuildSlaveSupport/build.webkit.org-config/config.json:
3188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3189         (BubbleQueueServer):
3190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3192         (WebKitBuildbot):
3193         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3194         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3195         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3196
3197 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3198
3199         MiniBrowser should be able to navigate to about:blank
3200         https://bugs.webkit.org/show_bug.cgi?id=193345
3201
3202         Reviewed by Simon Fraser.
3203
3204         * MiniBrowser/mac/BrowserWindowController.m:
3205         (-[BrowserWindowController addProtocolIfNecessary:]):
3206         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3207
3208         * MiniBrowser/mac/WK1BrowserWindowController.m:
3209         (-[WK1BrowserWindowController fetch:]):
3210         * MiniBrowser/mac/WK2BrowserWindowController.m:
3211         (-[WK2BrowserWindowController fetch:]):
3212         Clean up the code that uses this to match style.
3213
3214 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3215
3216         Remove MiniBrowser custom "Process Swap" menu item which does not work
3217         https://bugs.webkit.org/show_bug.cgi?id=193344
3218
3219         Reviewed by Simon Fraser.
3220
3221         There is a menu item under the Experimental menu that does work.
3222
3223         * MiniBrowser/mac/AppDelegate.m:
3224         (defaultConfiguration):
3225         * MiniBrowser/mac/SettingsController.h:
3226         * MiniBrowser/mac/SettingsController.m:
3227         (-[SettingsController _populateMenu]):
3228         (-[SettingsController validateMenuItem:]):
3229         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3230         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3231
3232 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3233
3234         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3235         https://bugs.webkit.org/show_bug.cgi?id=193327
3236         rdar://problem/47093222
3237
3238         Reviewed by Tim Horton.
3239
3240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3241         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3242         (TestWebKitAPI::didFinishNavigation):
3243         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3244         (TestWebKitAPI::TEST):
3245         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3246         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3247         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3248         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3249         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3250
3251 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3252
3253         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3254         https://bugs.webkit.org/show_bug.cgi?id=193338
3255         <rdar://problem/46664774>
3256
3257         Reviewed by David Kilzer.
3258
3259         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3260         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3261
3262 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3263
3264         Unreviewed, rolling out r239825.
3265         https://bugs.webkit.org/show_bug.cgi?id=193330
3266
3267         Broke tests on armv7/linux bots (Requested by guijemont on
3268         #webkit).
3269
3270         Reverted changeset:
3271
3272         "Enable DFG on ARM/Linux again"
3273         https://bugs.webkit.org/show_bug.cgi?id=192496
3274         https://trac.webkit.org/changeset/239825
3275
3276 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3277
3278         Disable the run-jsc-stress-test remote host key check.
3279         https://bugs.webkit.org/show_bug.cgi?id=192988
3280
3281         Reviewed by Alexey Proskuryakov.
3282
3283         * Scripts/run-jsc-stress-tests:
3284
3285 2019-01-10  John Wilander  <wilander@apple.com>
3286
3287         Override the session configuration for cookieAcceptPolicy
3288         https://bugs.webkit.org/show_bug.cgi?id=190925
3289         <rdar://problem/45497382>
3290
3291         Reviewed by Alexey Proskuryakov and Alex Christensen.
3292
3293         Test infrastructure for setting a first-party-only cookie policy.
3294
3295         * DumpRenderTree/TestRunner.cpp:
3296         (setOnlyAcceptFirstPartyCookiesCallback):
3297         (TestRunner::staticFunctions):
3298         * DumpRenderTree/TestRunner.h:
3299         * DumpRenderTree/mac/TestRunnerMac.mm:
3300         (TestRunner::setOnlyAcceptFirstPartyCookies):
3301         * DumpRenderTree/win/TestRunnerWin.cpp:
3302         (TestRunner::setOnlyAcceptFirstPartyCookies):
3303         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3304         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3305         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3306         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3307         * WebKitTestRunner/TestInvocation.cpp:
3308         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3309
3310 2019-01-09  Matt Rajca  <mrajca@apple.com>
3311
3312         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3313         https://bugs.webkit.org/show_bug.cgi?id=193301
3314
3315         Reviewed by Jer Noble.
3316         
3317         Added API tests.
3318
3319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3320         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3321         (TEST):
3322         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3323
3324 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3325
3326         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3327         https://bugs.webkit.org/show_bug.cgi?id=193310
3328
3329         Reviewed by Antti Koivisto.
3330
3331         * LayoutReloaded/misc/LFC-passing-tests.txt:
3332
3333 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3334
3335         Enable DFG on ARM/Linux again
3336         https://bugs.webkit.org/show_bug.cgi?id=192496
3337
3338         Reviewed by Yusuke Suzuki.
3339
3340         After changing the bytecode format DFG was disabled on all 32-bit
3341         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3342         on ARM by default.
3343
3344         * Scripts/run-jsc-stress-tests:
3345
3346 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3347
3348         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3349         https://bugs.webkit.org/show_bug.cgi?id=193271
3350
3351         Reviewed by Brent Fulgham.
3352
3353         BSTR is a special data structure created by SysAllocString, not a
3354         wchar_t null-terminated string.
3355
3356         * DumpRenderTree/win/TestRunnerWin.cpp:
3357         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3358         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3359         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3360         BSTR from wide string literals.
3361
3362 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3363
3364         Tweak wording for build/version_check style checker error
3365         https://bugs.webkit.org/show_bug.cgi?id=193256
3366
3367         Reviewed by Tim Horton.
3368
3369         * Scripts/webkitpy/style/checkers/cpp.py:
3370         (check_os_version_checks):
3371         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3372         (WebKitStyleTest.test_os_version_checks):
3373
3374 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3375
3376         [ews-build] Add link to bug along with bug title
3377         https://bugs.webkit.org/show_bug.cgi?id=193293
3378
3379         Reviewed by Lucas Forschler.
3380
3381         * BuildSlaveSupport/ews-build/steps.py:
3382         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3383         (ConfigureBuild.add_bug_id_url): Deleted.
3384         (ConfigureBuild.getBugURL): Deleted.
3385
3386 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3387
3388         [ews-build] Use https for ews-build server
3389         https://bugs.webkit.org/show_bug.cgi?id=193193
3390
3391         Reviewed by Lucas Forschler.
3392
3393         * BuildSlaveSupport/ews-build/steps.py:
3394
3395 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3396
3397         [ews-build] Parse and display number of style failures
3398         https://bugs.webkit.org/show_bug.cgi?id=193280
3399
3400         Reviewed by Lucas Forschler.
3401
3402         * BuildSlaveSupport/ews-build/steps.py:
3403         (CheckStyle): Use TestWithFailureCount as base class.
3404         (CheckStyle.countFailures): Count the number of style failures.
3405
3406 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3407
3408         [ews-build] use patch_id instead of ewspatchid
3409         https://bugs.webkit.org/show_bug.cgi?id=193235
3410
3411         Reviewed by Lucas Forschler.
3412
3413         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3414         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3415         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3416
3417 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3418
3419         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3420         https://bugs.webkit.org/show_bug.cgi?id=192625
3421
3422         Reviewed by Antti Koivisto.
3423
3424         * LayoutReloaded/misc/LFC-passing-tests.txt:
3425
3426 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3427
3428         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3429         https://bugs.webkit.org/show_bug.cgi?id=192841
3430
3431         Reviewed by Carlos Garcia Campos.
3432
3433         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3434         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3435         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3436
3437         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3438
3439         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3440         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3441         (WebKitWebEditorTest::testSelectionChanged):
3442         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3443         (WebKitFrameTest::testMainFrame):
3444         (WebKitFrameTest::testURI):
3445         (WebKitFrameTest::testJavaScriptContext):
3446         (WebKitFrameTest::testJavaScriptValues):
3447         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3448         (testWebViewAuthenticationRequest):
3449         (testWebViewAuthenticationLoadCancelled):
3450         (testWebViewAuthenticationFailure):
3451         (testWebViewAuthenticationStorage):
3452         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3453         (testWebViewAuthenticationProxy):
3454         (testWebViewAuthenticationProxyHTTPS):
3455         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3456         (testAutomationSessionRequestSession):
3457         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3458         (testBackForwardListNavigation):
3459         (testWebKitWebViewSessionState):
3460         (testWebKitWebViewSessionStateWithFormData):
3461         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3462         (ConsoleMessageTest::consoleMessageReceivedCallback):
3463         (testWebKitConsoleMessageConsoleAPI):
3464         (testWebKitConsoleMessageJavaScriptException):
3465         (testWebKitConsoleMessageNetworkError):
3466         (testWebKitConsoleMessageSecurityError):
3467         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3468         (testCookieManagerAcceptPolicy):
3469         (testCookieManagerCookiesChanged):
3470         (testCookieManagerPersistentStorage):
3471         (testCookieManagerPersistentStorageDeleteAll):
3472         (testCookieManagerEphemeral):
3473         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3474         (testWebKitDOMElementAutoFill):
3475         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3476         (downloadLocalFileSuccessfully):
3477         (createFileAtDestination):
3478         (testDownloadOverwriteDestinationDisallowed):
3479         (testDownloadLocalFileError):
3480         (testDownloadRemoteFile):
3481         (testDownloadRemoteFileError):
3482         (testWebViewDownloadURI):
3483         (testPolicyResponseDownload):
3484         (testPolicyResponseDownloadCancel):
3485         (testDownloadMIMEType):
3486         (contextMenuCallback):
3487         (testContextMenuDownloadActions):
3488         (testBlobDownload):
3489         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3490         (testWebKitWebEditorSelectionChanged):
3491         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3492         (testWebKitFrameMainFrame):
3493         (testWebKitFrameURI):
3494         (testWebKitFrameJavaScriptContext):
3495         (testWebKitFrameJavaScriptValues):
3496         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3497         (LoadStopTrackingTest::loadFailed):
3498         (testWebViewTitle):
3499         (testURIRequestHTTPHeaders):
3500         (testURIRequestHTTPMethod):
3501         (testURIResponseHTTPHeaders):
3502         (testRedirectToDataURI):
3503         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3504         (testProcessPerWebView):
3505         (testWebProcessLimit):
3506         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3507         (testWebViewResources):
3508         (testWebResourceLoading):
3509         (testWebResourceSuggestedFilename):
3510         (testWebResourceGetData):
3511         (testWebResourceGetDataError):
3512         (testWebViewResourcesHistoryCache):
3513         (testWebResourceSendRequest):
3514         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3515         (testSSL):
3516         (testInsecureContent):
3517         (testTLSErrorsPolicy):
3518         (testTLSErrorsRedirect):
3519         (testTLSErrorsHTTPAuth):
3520         (testLoadFailedWithTLSErrors):
3521         (testSubresourceLoadFailedWithTLSErrors):
3522         (httpsServerCallback):
3523         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3524         (testWebViewCreateNavigationData):
3525         (testWebViewJavaScriptDialogs):
3526         (testWebViewWindowProperties):
3527         (testWebViewMouseTarget):
3528         (testWebViewFileChooserRequest):
3529         (testWebViewColorChooserRequest):
3530         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3531         (testWebExtensionGetTitle):
3532         (testDocumentLoadedSignal):
3533         (testWebKitWebViewProcessCrashed):
3534         (testWebExtensionWindowObjectCleared):
3535         (testWebExtensionIsolatedWorld):
3536         (permissionRequestCallback):
3537         (didAssociateFormControlsCallback):
3538         (testWebExtensionFormControlsAssociated):
3539         (FormSubmissionTest::FormSubmissionTest):
3540         (FormSubmissionTest::testFormSubmissionResult):
3541         (testWebExtensionFormSubmissionSteps):
3542         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3543         (testNotInitialized):
3544         (testClearDatabase):
3545         (testPrivateBrowsing):
3546         (testGetFavicon):
3547         (testWebViewFavicon):
3548         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3549         (testFindControllerTextFound):
3550         (testFindControllerTextNotFound):
3551         (testFindControllerMatchCount):
3552         (testFindControllerMaxMatchCount):
3553         (testFindControllerNext):
3554         (testFindControllerPrevious):
3555         (testFindControllerCountedMatches):
3556         (testFindControllerOptions):
3557         (testFindControllerHide):
3558         (testFindControllerInstance):
3559         (testFindControllerGetters):
3560         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3561         (testNavigationPolicy):
3562         (testResponsePolicy):
3563         (testNewWindowPolicy):
3564         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3565         (testSecurityOriginBasicConstructor):
3566         (testSecurityOriginURIConstructor):
3567         (testSecurityOriginDefaultPort):
3568         (testSecurityOriginFileURI):
3569         (testOpaqueSecurityOrigin):
3570         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3571         (testWebKitSettings):
3572         (testWebKitSettingsNewWithSettings):
3573         (testWebKitSettingsUserAgent):
3574         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3575         (testWebViewNewWithUserContentManager):
3576         (isStyleSheetInjectedForURLAtPath):
3577         (isScriptInjectedForURLAtPath):
3578         (testUserContentManagerInjectedStyleSheet):
3579         (testUserContentManagerInjectedScript):
3580         (UserScriptMessageTest::scriptMessageReceived):
3581         (UserScriptMessageTest::waitUntilMessageReceived):
3582         (UserScriptMessageTest::runJavaScriptFinished):
3583         (testUserContentManagerScriptMessageReceived):
3584         (testUserContentManagerScriptMessageInWorldReceived):
3585         (testUserContentManagerScriptMessageFromDOMBindings):
3586         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3587         (testWebContextDefault):
3588         (testWebContextEphemeral):
3589         (testWebContextGetPlugins):
3590         (testWebContextURIScheme):
3591         (testWebContextSpellChecker):
3592         (testWebContextLanguages):
3593         (consoleMessageReceivedCallback):
3594         (testWebContextSecurityFileXHR):
3595         (ProxyTest::ProxyTest):
3596         (testWebContextProxySettings):
3597         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3598         (testWebViewWebContext):
3599         (testWebViewWebBackend):
3600         (testWebViewEphemeral):
3601         (testWebViewCustomCharset):
3602         (testWebViewSettings):
3603         (testWebViewRunJavaScript):
3604         (testWebViewCanShowMIMEType):
3605         (testWebViewSubmitForm):
3606         (testWebViewSave):
3607         (testWebViewPageVisibility):
3608         (testWebViewSnapshot):
3609         (testWebViewNotification):
3610         (testWebViewNotificationInitialPermissionAllowed):
3611         (testWebViewNotificationInitialPermissionDisallowed):
3612         (testWebViewIsPlayingAudio):
3613         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3614         (WebsiteDataTest::WebsiteDataTest):
3615         (WebsiteDataTest::remove):
3616         (WebsiteDataTest::clear):
3617         (testWebsiteDataConfiguration):
3618         (testWebsiteDataEphemeral):
3619         (testWebsiteDataCache):
3620         (testWebsiteDataStorage):
3621         (testWebsiteDataDatabases):
3622         (testWebsiteDataAppcache):
3623         (testWebsiteDataCookies):
3624         (testWebsiteDataDeviceIdHashSalt):
3625         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3626         (emitDocumentLoaded):
3627         (emitURIChanged):
3628         (sendRequestCallback):
3629         (contextMenuCallback):
3630         (consoleMessageSentCallback):
3631         (emitFormControlsAssociated):
3632         (formControlsAssociatedCallback):
3633         (emitFormSubmissionEvent):
3634         (willSubmitFormCallback):
3635         (windowObjectCleared):
3636         (methodCallCallback):
3637         (registerGResource):
3638         (webkit_web_extension_initialize_with_user_data):
3639         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
3640         (checkLeaks):
3641         (WebProcessTest::create):
3642         (runTest):
3643         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
3644         (AutocleanupsTest::testWebProcessAutocleanups):
3645         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
3646         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
3647         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
3648         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
3649         (WebKitDOMDOMWindowTest::testSignals):
3650         (WebKitDOMDOMWindowTest::testDispatchEvent):
3651         (WebKitDOMDOMWindowTest::testGetComputedStyle):
3652         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
3653         (WebKitDOMNodeFilterTest::testTreeWalker):
3654         (WebKitDOMNodeFilterTest::testNodeIterator):
3655         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
3656         (WebKitDOMNodeTest::testHierarchyNavigation):
3657         (WebKitDOMNodeTest::testInsertion):
3658         (WebKitDOMNodeTest::testTagNamesNodeList):
3659         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
3660         (WebKitDOMNodeTest::testDOMCache):
3661         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
3662         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3663         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3664         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3665         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
3666         (testUIProcessAutocleanups):
3667         (testWebProcessAutocleanups):
3668         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3669         (testContextMenuPopulateMenu):
3670         (testContextMenuDismissed):
3671         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
3672         (testWebKitDOMClientRectDivBoundingClientRectPosition):