1 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
3 Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
5 Geolocation is no longer allowed for unique origins after r195075.
7 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
8 (testWebViewGeolocationPermissionRequests):
10 2016-01-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
12 [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
13 https://bugs.webkit.org/show_bug.cgi?id=153216
15 Reviewed by Michael Catanzaro.
17 * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
18 (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
20 2016-01-18 Nan Wang <n_wang@apple.com>
22 AX: [Mac] Implement next/previous text marker functions using TextIterator
23 https://bugs.webkit.org/show_bug.cgi?id=152728
25 Reviewed by Chris Fleizach.
27 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
28 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
30 2016-01-18 Csaba Osztrogonác <ossy@webkit.org>
32 [cmake] Add testair to the build system
33 https://bugs.webkit.org/show_bug.cgi?id=153126
35 Reviewed by Michael Catanzaro.
39 2016-01-16 Myles C. Maxfield <mmaxfield@apple.com>
41 Remove TextRun::allowsRoundingHacks()
42 https://bugs.webkit.org/show_bug.cgi?id=153185
44 Reviewed by Simon Fraser.
46 * DumpRenderTree/mac/DumpRenderTree.mm:
47 (resetWebViewToConsistentStateBeforeTesting): Deleted.
49 2016-01-15 Konstantin Tokarev <annulen@yandex.ru>
51 [webkitdirs] Avoid list form of open because it broke WinCairo
52 https://bugs.webkit.org/show_bug.cgi?id=153106
54 Reviewed by Alex Christensen.
56 * Scripts/webkitdirs.pm:
57 (determineArchitecture):
59 2016-01-15 Simon Fraser <simon.fraser@apple.com>
61 Add kdebug_trace signposts for a few WebCore operations
62 https://bugs.webkit.org/show_bug.cgi?id=153136
63 rdar://problem/24208487
65 Reviewed by Sam Weinig.
67 Plist used by kdebug_trace() viewing tools.
69 * Tracing/SystemTracePoints.plist: Added.
71 2016-01-14 Konstantin Tokarev <annulen@yandex.ru>
73 [webkitdirs] Replaced grep invocation with perl code
74 https://bugs.webkit.org/show_bug.cgi?id=153106
76 Reviewed by Alex Christensen.
78 * Scripts/webkitdirs.pm:
79 (determineArchitecture):
81 2016-01-14 Brian Burg <bburg@apple.com>
83 prepare-changelog does not read paths containing spaces properly
84 https://bugs.webkit.org/show_bug.cgi?id=137982
86 Reviewed by Joseph Pecoraro.
88 Escape whitespace in filenames before passing the file path to other functions.
90 * Scripts/prepare-ChangeLog:
91 (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
93 2016-01-14 Jason Marcell <jmarcell@apple.com>
95 Standardize the usage of "branch" vs. "branchName".
96 https://bugs.webkit.org/show_bug.cgi?id=152982
98 Reviewed by Daniel Bates.
100 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
101 "branchName" implies that the variable or property in question is simply a string.
103 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
104 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
105 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
106 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
107 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
108 (Trac.prototype.commitsOnBranch): Change branch to branchName.
109 (Trac.prototype._convertCommitInfoElementToObject): Ditto.
110 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
113 2016-01-14 Jason Marcell <jmarcell@apple.com>
115 Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
116 https://bugs.webkit.org/show_bug.cgi?id=152910
118 Reviewed by Daniel Bates.
120 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
121 (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
122 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
123 (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
124 the need to talk to a real Buildbot server.
125 (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
126 without the need to talk to a real Buildbot server.
127 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
128 (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
130 (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
131 (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
132 (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
133 trying to talk to Trac.
134 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
136 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
138 2016-01-14 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
140 [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
141 https://bugs.webkit.org/show_bug.cgi?id=132599
143 Reviewed by Michael Catanzaro.
145 Check if cmake Ninja generators are installed.
147 * Scripts/webkitdirs.pm:
148 (canUseNinjaGenerator):
149 (canUseEclipseNinjaGenerator):
150 (generateBuildSystemFromCMakeProject):
151 (canUseEclipse): Deleted.
153 2016-01-13 Myles C. Maxfield <mmaxfield@apple.com>
155 [Cocoa] Testing with font family name "System Font" is unused
156 https://bugs.webkit.org/show_bug.cgi?id=153073
157 <rdar://problem/24091683>
159 Reviewed by Brent Fulgham.
161 * DumpRenderTree/mac/DumpRenderTree.mm:
162 (allowedFontFamilySet): Deleted.
163 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
164 (WTR::allowedFontFamilySet): Deleted.
165 * WebKitTestRunner/mac/TestControllerMac.mm:
166 (WTR::allowedFontFamilySet): Deleted.
168 2016-01-13 Daniel Bates <dabates@apple.com>
170 [XSS Auditor] Add test when XSS payload is in the path portion of the URL
171 https://bugs.webkit.org/show_bug.cgi?id=152871
173 Reviewed by Brent Fulgham.
175 Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
176 <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
178 * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
180 2016-01-08 Andy Estes <aestes@apple.com>
182 [Content Filtering] Lazily load platform frameworks
183 https://bugs.webkit.org/show_bug.cgi?id=152881
184 rdar://problem/23270886
186 Reviewed by Brady Eidson.
188 Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
189 expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
190 loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
191 and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
192 is loaded after an HTTPS request.
194 To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
195 Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
196 WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
197 also re-enabled on iOS after mistakenly being disabled by r188892.
199 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
200 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
201 (TestWebKitAPI::TEST):
202 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
203 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
204 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
207 (-[LazilyLoadPlatformFrameworksController init]):
208 (-[LazilyLoadPlatformFrameworksController webView]):
209 (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
210 (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
211 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
212 (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
213 (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
214 (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
215 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
216 (TestWebKitAPI::TEST):
217 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
218 (TestWebKitAPI::TEST): Deleted.
219 * TestWebKitAPI/cocoa/TestProtocol.h:
220 * TestWebKitAPI/cocoa/TestProtocol.mm:
221 (+[TestProtocol registerWithScheme:]):
222 (+[TestProtocol unregister]):
224 2016-01-12 Dewei Zhu <dewei_zhu@apple.com>
226 Fix the Sunpider converage in slow device.
227 https://bugs.webkit.org/show_bug.cgi?id=152938
228 <rdar://problem/22511411>
230 Reviewed by Ryosuke Niwa.
232 Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
234 * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
236 2016-01-12 Ryosuke Niwa <rniwa@webkit.org>
238 Add a build flag for custom element
239 https://bugs.webkit.org/show_bug.cgi?id=153005
241 Reviewed by Alex Christensen.
243 Added --custom-elements option to enable custom elements support.
245 * Scripts/webkitperl/FeatureList.pm:
247 2016-01-12 Benjamin Poulain <bpoulain@apple.com>
249 [JSC] Add a help message when run-jsc-stress-tests fails
250 https://bugs.webkit.org/show_bug.cgi?id=153014
252 Reviewed by Csaba Osztrogonác.
254 * Scripts/run-jsc-stress-tests:
256 2016-01-11 Saam barati <sbarati@apple.com>
258 run-jsc-stress-tests should try to figure out a JSC path
259 https://bugs.webkit.org/show_bug.cgi?id=152971
261 Reviewed by Yusuke Suzuki.
263 This patch now allows run-jsc-stress-tests to be run
264 without a "--jsc <jsc-path>" argument. It tries
265 to take its best guess at a <jsc-path> automagically.
267 This makes it much easier to just run run-jsc-stress-tests
268 with a directory or a yaml file as an argument.
269 You now just do this:
270 `run-jsc-stress-tests <path-to-yaml>`
272 `run-jsc-stress-tests <path-to-directory-of-js-files>`
274 I wrote this patch because I'd often find myself hacking the
275 run-javascriptcore-tests file just to run a particular subset of tests.
276 Because I always forget the arguments to run-jsc-stress-tests (which means
277 I always forgot to provide a --jsc argument), I always found it easier to
278 just hack on that file instead of calling run-jsc-stress-tests directly.
279 No longer is this true!
281 * Scripts/run-jsc-stress-tests:
283 2016-01-09 Andy Estes <aestes@apple.com>
285 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
286 https://bugs.webkit.org/show_bug.cgi?id=152950
287 rdar://problem/24066652
289 Reviewed by Tim Horton.
293 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
294 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
295 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
296 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
297 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
298 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
299 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
300 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
303 2016-01-11 Commit Queue <commit-queue@webkit.org>
305 Unreviewed, rolling out r194866.
306 https://bugs.webkit.org/show_bug.cgi?id=152986
308 This change broke the mac build (Requested by ryanhaddad on
313 "[Cocoa] Add SPI to opt out a URL scheme from the memory
315 https://bugs.webkit.org/show_bug.cgi?id=152950
316 http://trac.webkit.org/changeset/194866
318 2016-01-11 Andy Estes <aestes@apple.com>
320 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
321 https://bugs.webkit.org/show_bug.cgi?id=152950
322 rdar://problem/24066652
324 Reviewed by Tim Horton.
328 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
329 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
330 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
331 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
332 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
333 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
334 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
335 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
338 2016-01-11 Konstantin Tokarev <annulen@yandex.ru>
340 [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
341 https://bugs.webkit.org/show_bug.cgi?id=152959
343 Reviewed by Brent Fulgham.
345 * Scripts/webkitdirs.pm:
346 (determineArchitecture):
348 2016-01-11 Michael Catanzaro <mcatanzaro@igalia.com>
350 [GTK] W3C CSS2.1 anonymous table tests are failing
351 https://bugs.webkit.org/show_bug.cgi?id=152455
353 Reviewed by Mario Sanchez Prada.
355 Add shared-mime-info to the jhbuild environment, since it affects the results of layout
356 tests. Add upstream patches to fix detection of XHTML files.
358 * gtk/jhbuild.modules:
359 * gtk/patches/shared-mime-info-xht-glob.patch: Added.
360 * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
362 2016-01-10 Saam barati <sbarati@apple.com>
364 Implement a sampling profiler
365 https://bugs.webkit.org/show_bug.cgi?id=151713
367 Reviewed by Filip Pizlo.
369 * Scripts/run-jsc-stress-tests:
371 2016-01-10 Konstantin Tokarev <annulen@yandex.ru>
373 [webkitdirs] Try arch and uname commands on non-windows OS
374 https://bugs.webkit.org/show_bug.cgi?id=152958
376 Reviewed by Michael Catanzaro.
378 Right now, determineArchitecture() uses `arch` and `uname -m`
379 commands to determine architecture in case of condition (isGtk() ||
380 isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
381 instead, because this code is applicable to any non-windows OS WebKit
382 supports (even Haiku which once was supported is moderately
383 POSIX-compliant and has uname command).
385 * Scripts/webkitdirs.pm:
386 (determineArchitecture):
388 2016-01-08 Aakash Jain <aakash_jain@apple.com>
390 run-webkit-tests mis-counts totals when there are other crashes
391 https://bugs.webkit.org/show_bug.cgi?id=152894
392 <rdar://problem/24098697>
394 Reviewed by Alexey Proskuryakov.
396 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
397 (TestRunResults.add): Do not update result counters for other crashes.
399 2016-01-08 Youenn Fablet <youenn.fablet@crf.canon.fr>
401 webkit-patch build-and-test should have an option to iterate over new tests
402 https://bugs.webkit.org/show_bug.cgi?id=143093
404 Reviewed by Michael Catanzaro.
406 This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
407 It allows running run-webkit-tests on modified or new paths in LayoutTests.
408 Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
409 It implements the translation of -expected.* paths to their related tests.
410 It also implements the removal of skipped tests.
412 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
413 (LayoutTestFinder.find_touched_tests):
414 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
418 (LayoutTestFinderTests):
419 (LayoutTestFinderTests.touched_files):
420 (LayoutTestFinderTests.test_touched_test):
421 (LayoutTestFinderTests.test_expected_touched_test):
422 (LayoutTestFinderTests.test_platform_expected_touched_test):
423 (LayoutTestFinderTests.test_platform_duplicate_touched_test):
424 (LayoutTestFinderTests.test_touched_but_skipped_test):
425 * Scripts/webkitpy/port/base.py:
426 (Port.potential_test_names_from_expected_file):
427 * Scripts/webkitpy/tool/commands/download_unittest.py:
428 (DownloadCommandsTest._default_options):
429 * Scripts/webkitpy/tool/steps/options.py:
431 * Scripts/webkitpy/tool/steps/runtests.py:
435 (RunTests._new_or_modified_tests):
436 (RunTests._run_webkit_tests):
437 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
438 (RunTestsTest.test_webkit_run_unit_tests):
439 * Scripts/webkitpy/tool/steps/steps_unittest.py:
440 (StepsTest._step_options):
442 2016-01-07 Joseph Pecoraro <pecoraro@apple.com>
444 prepare-ChangeLog should include radar number
445 https://bugs.webkit.org/show_bug.cgi?id=152839
446 <rdar://problem/24093563>
448 Reviewed by Daniel Bates.
450 When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
451 starts with a "<rdar://problem/####>" URL. If found, include that radar URL
452 in the ChangeLog description after the bug URL.
454 * Scripts/prepare-ChangeLog:
455 (main): Update signatures.
456 (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
457 (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
458 (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
459 (generateNewChangeLogs): Include radar URL if we found one.
461 * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
462 Tests for the radar URL extraction.
464 2016-01-07 Alexey Proskuryakov <ap@apple.com>
466 testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
467 https://bugs.webkit.org/show_bug.cgi?id=152390
468 <rdar://problem/23948321>
470 Reviewed by Simon Fraser.
472 Fix two use-after-frees.
474 1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
475 but we may have already progressed to another test by the time the callback fires,
476 having destroyed the TestInvocation.
477 2. UIScriptController is a RefCounted object, but it has a raw pointer to
478 UIScriptContext which has the same lifetime as a TestInvocation.
479 As a result, completion blocks of UIScriptController actions would use a destroyed
482 * WebKitTestRunner/TestInvocation.cpp:
483 (WTR::TestInvocation::~TestInvocation):
484 (WTR::TestInvocation::url):
485 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
486 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
487 (WTR::TestInvocation::runUISideScript):
488 * WebKitTestRunner/TestInvocation.h:
489 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
490 (UIScriptContext::UIScriptContext):
491 (UIScriptContext::~UIScriptContext):
492 (UIScriptContext::runUIScript):
493 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
494 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
495 (WTR::UIScriptController::UIScriptController):
496 (WTR::UIScriptController::contextDestroyed):
497 (WTR::UIScriptController::makeWindowObject):
498 (WTR::UIScriptController::setWillBeginZoomingCallback):
499 (WTR::UIScriptController::willBeginZoomingCallback):
500 (WTR::UIScriptController::setDidEndZoomingCallback):
501 (WTR::UIScriptController::didEndZoomingCallback):
502 (WTR::UIScriptController::setDidEndScrollingCallback):
503 (WTR::UIScriptController::didEndScrollingCallback):
504 (WTR::UIScriptController::setDidShowKeyboardCallback):
505 (WTR::UIScriptController::didShowKeyboardCallback):
506 (WTR::UIScriptController::setDidHideKeyboardCallback):
507 (WTR::UIScriptController::didHideKeyboardCallback):
508 (WTR::UIScriptController::uiScriptComplete):
509 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
510 (WTR::UIScriptController::create):
511 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
512 (WTR::UIScriptController::doAsyncTask):
513 (WTR::UIScriptController::zoomToScale):
514 (WTR::UIScriptController::singleTapAtPoint):
515 (WTR::UIScriptController::doubleTapAtPoint):
516 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
517 (WTR::UIScriptController::contentVisibleRect):
518 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
519 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
520 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
521 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
522 (WTR::UIScriptController::platformSetDidEndScrollingCallback):
523 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
524 (WTR::UIScriptController::doAsyncTask):
526 2016-01-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
528 [buildbot] clean-build script should remove untracked files and revert local changes too
529 https://bugs.webkit.org/show_bug.cgi?id=142400
531 Reviewed by Ryosuke Niwa.
533 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
534 A helper routine SCM.discard_untracked_files is added for that purpose.
536 * BuildSlaveSupport/clean-build:
537 (main): Making call to Scripts/clean-webkit
538 * Scripts/clean-webkit: Added.
539 (main): Revert changes and delete untracked files.
540 * Scripts/webkitpy/common/checkout/scm/scm.py:
541 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
542 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
543 (SCMTest._shared_test_discard_untracked_files):
544 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
546 2016-01-06 Simon Fraser <simon.fraser@apple.com>
548 Add a setting and preferences to enable display-list drawing. Does nothing yet.
549 https://bugs.webkit.org/show_bug.cgi?id=152807
551 Reviewed by Zalan Bujtas.
553 Add an item to the Settings menu to toggle display-list drawing.
555 * MiniBrowser/mac/SettingsController.h:
556 * MiniBrowser/mac/SettingsController.m:
557 (-[SettingsController _populateMenu]):
558 (-[SettingsController validateMenuItem:]):
559 (-[SettingsController toggleDisplayListDrawingEnabled:]):
560 (-[SettingsController displayListDrawingEnabled]):
561 * MiniBrowser/mac/WK2BrowserWindowController.m:
562 (-[WK2BrowserWindowController didChangeSettings]):
564 2016-01-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
566 Python SCM should be able to retrieve untracked files - Add GIT support
567 https://bugs.webkit.org/show_bug.cgi?id=143135
569 Reviewed by Michael Catanzaro.
571 * Scripts/webkitpy/common/checkout/scm/git.py:
572 (Git.untracked_files): Adding support for git.
573 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
575 (GitTest.test_untracked_files): Adding test.
577 2016-01-05 Mark Lam <mark.lam@apple.com>
579 Rename badly named JSC_timeout env var to JSCTEST_timeout.
580 https://bugs.webkit.org/show_bug.cgi?id=152748
582 Reviewed by Geoffrey Garen.
584 Now that we validate JSC options, the badly named JSC_timeout env var causes the
585 bots to have a bad time.
587 * Scripts/run-javascriptcore-tests:
588 * Scripts/run-jsc-stress-tests:
590 2016-01-04 Carlos Garcia Campos <cgarcia@igalia.com>
592 [GTK] Allow to save and restore session
593 https://bugs.webkit.org/show_bug.cgi?id=115600
595 Reviewed by Michael Catanzaro.
597 Add test case to check the new session API.
599 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
600 (testWebKitWebViewSessionState):
601 (testWebKitWebViewSessionStateWithFormData):
604 2016-01-04 Csaba Osztrogonác <ossy@webkit.org>
606 [EFL] Bump EFL version to 1.16.1
607 https://bugs.webkit.org/show_bug.cgi?id=152688
609 Reviewed by Gyuyoung Kim.
611 * efl/jhbuild.modules:
613 2016-01-04 Aakash Jain <aakash_jain@apple.com>
615 error running layout tests on iOS simulator on latest build
616 https://bugs.webkit.org/show_bug.cgi?id=152719
617 <rdar://problem/24009549>
619 Reviewed by Alexey Proskuryakov.
621 * Scripts/webkitpy/xcode/simulator.py:
622 (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
623 before running simctl spawn command.
625 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
627 Unreviewed, move Frédéric Wang to committers list
629 He seems to be on the contributors list by accident. He has been landing his own commits for
632 * Scripts/webkitpy/common/config/contributors.json:
634 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
636 Unreviewed, move Sebastian Dröge to committers list harder
638 He accidentally added himself to the reviewers list because the file is confusing. Then I
639 accidentially moved him to the contributors list because the file is confusing, even though
640 I knew the contributors list existed in this file and was attempting to add him to the
641 committers list. Really move him to the committers list now.
643 * Scripts/webkitpy/common/config/contributors.json:
645 2016-01-02 Youenn Fablet <youenn.fablet@crf.canon.fr>
647 Python SCM should be able to retrieve untracked files - Add SVN support
648 https://bugs.webkit.org/show_bug.cgi?id=152546
650 Reviewed by Michael Catanzaro.
652 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
653 (test_untracked_files): Activating test for SVN.
654 * Scripts/webkitpy/common/checkout/scm/svn.py:
655 (SVN.untracked_files): Implementing untracked files retrieval for SVN.
657 2015-12-31 Andy Estes <aestes@apple.com>
659 Replace WTF::move with WTFMove
660 https://bugs.webkit.org/show_bug.cgi?id=152601
662 Reviewed by Brady Eidson.
664 * DumpRenderTree/TestRunner.h:
665 (TestRunner::setAllowedHosts):
666 * DumpRenderTree/win/DRTDataObject.cpp:
667 (DRTDataObject::SetData):
668 * TestWebKitAPI/Tests/WTF/Deque.cpp:
669 (TestWebKitAPI::TEST):
670 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
671 (TestWebKitAPI::TEST):
672 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
673 (TestWebKitAPI::TEST):
674 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
675 (TestWebKitAPI::TEST):
676 * TestWebKitAPI/Tests/WTF/Ref.cpp:
677 (TestWebKitAPI::passWithRef):
678 (TestWebKitAPI::TEST):
679 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
680 (TestWebKitAPI::TEST):
681 * TestWebKitAPI/Tests/WTF/Vector.cpp:
682 (TestWebKitAPI::TEST):
683 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
684 (TestWebKitAPI::TEST):
685 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
686 (TestWebKitAPI::TEST):
687 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
688 (TestWebKitAPI::createTestValue):
689 (TestWebKitAPI::TEST):
690 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
691 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
692 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
693 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
694 (TestWebKitAPI::createNFAs):
695 (TestWebKitAPI::TEST_F):
696 * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
697 (TestWebKitAPI::combine):
698 * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
699 (TestWebKitAPI::createNFAs):
700 * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
702 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
703 (WebProcessTest::add):
705 2016-01-01 Michael Catanzaro <mcatanzaro@igalia.com>
707 [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
708 https://bugs.webkit.org/show_bug.cgi?id=152634
710 Reviewed by Carlos Garcia Campos.
712 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
713 (testLoadFromGResource): Added test.
715 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
716 (registerGResource): Added.
717 (webkit_web_extension_initialize_with_user_data): Load the test gresource.
718 * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
719 * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
721 2015-12-31 David Kilzer <ddkilzer@apple.com>
723 REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
724 <https://bugs.webkit.org/show_bug.cgi?id=152601>
726 Ignore unknown pragmas on older clangs. Fixes the following
729 Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
730 #pragma clang diagnostic ignored "-Wself-move"
734 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
735 (TestWebKitAPI::TEST):
736 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
737 (TestWebKitAPI::TEST):
739 2015-12-31 Andy Estes <aestes@apple.com>
741 Update the style checker to advise using WTFMove() instead of WTF::move()
742 https://bugs.webkit.org/show_bug.cgi?id=152601
744 Reviewed by Daniel Bates.
746 * Scripts/webkitpy/style/checkers/cpp.py:
748 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
749 (WebKitStyleTest.test_wtf_move):
751 2015-12-31 Andy Estes <aestes@apple.com>
753 Fix warnings uncovered by migrating to WTF_MOVE
754 https://bugs.webkit.org/show_bug.cgi?id=152601
756 Reviewed by Daniel Bates.
758 Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
759 self-move, even if doing so would trigger a warning.
761 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
762 (TestWebKitAPI::TEST):
763 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
764 (TestWebKitAPI::TEST):
766 2015-12-31 Martin Robinson <mrobinson@igalia.com>
768 [GTK] The install-dependencies script has a syntax error
769 https://bugs.webkit.org/show_bug.cgi?id=152613
771 Reviewed by Michael Catanzaro.
773 * gtk/install-dependencies: Add the missing 'then.'
775 2015-12-30 Philippe Normand <pnormand@igalia.com>
777 [Mac][GTK] Jhbuild support for OSX
778 https://bugs.webkit.org/show_bug.cgi?id=150799
780 Reviewed by Michael Catanzaro.
782 * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
783 * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
784 * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
785 * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
787 2015-12-28 Michael Catanzaro <mcatanzaro@igalia.com>
789 Unreviewed, move Sebastian Dröge to committers list
791 He accidentally added himself to the reviewers list because the file is confusing.
793 * Scripts/webkitpy/common/config/contributors.json:
795 2015-12-24 Simon Fraser <simon.fraser@apple.com>
797 Remove the unused #define _USE_MATH_DEFINES
798 https://bugs.webkit.org/show_bug.cgi?id=152034
800 Reviewed by Tim Horton.
802 Update this test to use piDouble from MathExtras.h, and
803 std::numeric_limits<>.
805 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
807 2015-12-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
809 Python SCM should be able to retrieve untracked files - Generic changes
810 https://bugs.webkit.org/show_bug.cgi?id=152536
812 Reviewed by Brent Fulgham.
814 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
815 No support is yet added to GIT and SVN specific implementations.
817 * Scripts/webkitpy/common/checkout/scm/scm.py:
818 (SCM.untracked_files):
819 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
820 (SCMTest._shared_test_untracked_files):
822 2015-12-23 Dewei Zhu <dewei_zhu@apple.com>
824 SVN checkout used by RunBenchmark should be non-interactive
825 https://bugs.webkit.org/show_bug.cgi?id=152542
827 Reviewed by Ryosuke Niwa.
829 RunBenchmark should not require user interaction while running.
831 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
832 (BenchmarkBuilder._checkout_with_subversion):
834 2015-12-23 Brent Fulgham <bfulgham@apple.com>
836 Web Inspector: add support for running protocol-test.js tests on Windows
837 https://bugs.webkit.org/show_bug.cgi?id=148037
838 <rdar://problem/22292237>
840 Reviewed by Simon Fraser.
842 * DumpRenderTree/win/TestRunnerWin.cpp:
843 (TestRunner::inspectorTestStubURL): Provide implementation.
845 2015-12-23 Eric Carlson <eric.carlson@apple.com>
847 [MediaStream] MediaDeviceInfo.label must be empty in some situations
848 https://bugs.webkit.org/show_bug.cgi?id=152000
850 Reviewed by Brent Fulgham.
852 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
853 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
854 (WTR::InjectedBundle::setUserMediaPermission):
855 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
856 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
858 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
859 (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
860 * WebKitTestRunner/InjectedBundle/TestRunner.h:
862 * WebKitTestRunner/TestController.cpp:
863 (WTR::TestController::setUserMediaPermissionForOrigin):
864 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
865 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add
866 persistent permission for origin, that can be done from script now.
867 * WebKitTestRunner/TestController.h:
869 * WebKitTestRunner/TestInvocation.cpp:
870 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
871 SetUserMediaPermissionForOrigin.
873 2015-12-23 Brent Fulgham <bfulgham@apple.com>
875 [Win] Unreviewed build fix: Recognize Windows 10 variants.
877 * Scripts/webkitpy/common/system/platforminfo.py:
878 (PlatformInfo._determine_win_version):
880 2015-12-23 Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
882 Content blockers should be able to promote http to https
883 https://bugs.webkit.org/show_bug.cgi?id=148966
885 Reviewed by Benjamin Poulain.
887 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
888 (WebCore::ContentExtensions::operator<<):
889 (TestWebKitAPI::TEST_F):
891 2015-12-22 Hunseop Jeong <hs85.jeong@samsung.com>
893 [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
894 https://bugs.webkit.org/show_bug.cgi?id=152516
896 Reviewed by Gyuyoung Kim.
898 * MiniBrowser/efl/main.c:
900 2015-12-22 Brent Fulgham <bfulgham@apple.com>
902 Unreviewed: Add John Wilander as a contributor.
904 * Scripts/webkitpy/common/config/contributors.json:
906 2015-12-22 Chris Fleizach <cfleizach@apple.com>
908 [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
909 https://bugs.webkit.org/show_bug.cgi?id=152482
911 Reviewed by Brent Fulgham.
913 vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
914 for the same property. On WK2, the element returned will not be valid, but is still present and
915 that can lead to looping.
917 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
918 (AccessibilityUIElement::horizontalScrollbar):
919 (AccessibilityUIElement::verticalScrollbar):
920 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
921 (WTR::AccessibilityUIElement::horizontalScrollbar):
922 (WTR::AccessibilityUIElement::verticalScrollbar):
924 2015-12-22 Xabier Rodriguez Calvar <calvaris@igalia.com>
928 * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
930 2015-12-21 Hunseop Jeong <hs85.jeong@samsung.com>
932 [EFL] test_ewk2_context failed after r192808
933 https://bugs.webkit.org/show_bug.cgi?id=151846
935 Reviewed by Gyuyoung Kim.
937 Used the added ewk_context_web_process_count_limit_set api
938 instead of the deprecated ewk_context_process_model_set.
940 * MiniBrowser/efl/main.c:
943 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
945 Unreviewed, move myself to reviewer list.
947 * Scripts/webkitpy/common/config/contributors.json:
949 2015-12-21 Aakash Jain <aakash_jain@apple.com>
951 Unreviewed, add myself to the committers list.
953 * Scripts/webkitpy/common/config/contributors.json:
955 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
957 [GTK] jquery.min.js violates DFSG
958 https://bugs.webkit.org/show_bug.cgi?id=152428
960 Reviewed by Joseph Pecoraro.
962 Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
963 into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
965 * gtk/manifest.txt.in:
967 2015-12-19 Dan Bernstein <mitz@apple.com>
969 [Mac] WebKit contains dead source code for OS X Mavericks and earlier
970 https://bugs.webkit.org/show_bug.cgi?id=152462
972 Reviewed by Alexey Proskuryakov.
974 - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
977 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
978 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
979 * MiniBrowser/Configurations/DebugRelease.xcconfig:
980 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
981 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
983 - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
984 never getting compiled:
986 * DumpRenderTree/mac/TextInputController.m:
987 * MiniBrowser/mac/BrowserWindowController.m:
988 * TestWebKitAPI/Tests/mac/AttributedString.mm:
989 * WebKitTestRunner/mac/EventSenderProxy.mm:
991 2015-12-18 Michael Catanzaro <mcatanzaro@igalia.com>
993 Unreviewed, add WebKitGTK+ Bugzilla email to committers list
995 This is to make it easy to CC it on Bugzilla.
997 * Scripts/webkitpy/common/config/contributors.json:
999 2015-12-18 Aakash Jain <aakash_jain@apple.com>
1001 Pasteboard get messed up after running kill-old-processes
1002 https://bugs.webkit.org/show_bug.cgi?id=152426
1004 Reviewed by Alexey Proskuryakov.
1006 * BuildSlaveSupport/kill-old-processes:
1007 (main): Do not kill pasteboard anymore.
1009 2015-12-17 Aakash Jain <aakash_jain@apple.com>
1011 run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1012 https://bugs.webkit.org/show_bug.cgi?id=152157
1013 <rdar://problem/23851817>
1015 Reviewed by Alexey Proskuryakov.
1017 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1018 (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1019 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1020 (Manager._get_test_inputs): Common method to calculate test_inputs.
1021 (Manager._update_worker_count): Calculate and update required number of workers.
1023 2015-12-16 Aakash Jain <aakash_jain@apple.com>
1025 run-webkit-tests fails to delete Simulator device during cleanup
1026 https://bugs.webkit.org/show_bug.cgi?id=152363
1028 Reviewed by Alexey Proskuryakov.
1030 * Scripts/webkitpy/xcode/simulator.py:
1031 (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1033 2015-12-16 Tim Horton <timothy_horton@apple.com>
1035 [mac-wk2] fast/events force click tests crashing
1036 https://bugs.webkit.org/show_bug.cgi?id=152339
1038 Reviewed by Beth Dakin.
1040 * WebKitTestRunner/mac/EventSenderProxy.mm:
1041 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1042 Set the NSEvent's _type member in addition to overriding -type,
1043 because there are assertions in touch event handling code that depend on it.
1045 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1047 Enforce temporarily bots to sync WebKit and WPT testharness.js
1048 https://bugs.webkit.org/show_bug.cgi?id=152334
1050 Reviewed by Darin Adler.
1052 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1053 (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1055 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1057 [Fetch API] Add fetch API compile time flag
1058 https://bugs.webkit.org/show_bug.cgi?id=152254
1060 Reviewed by Darin Adler.
1062 * Scripts/webkitperl/FeatureList.pm:
1064 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1068 Added files that have impact in building Streams API to the watchlist.
1070 * Scripts/webkitpy/common/config/watchlist:
1072 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1076 Added imported tests to Streams API watchlist.
1078 * Scripts/webkitpy/common/config/watchlist:
1080 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1082 Remove default copy of wpt testharness.js when launching wpt server
1083 https://bugs.webkit.org/show_bug.cgi?id=152298
1085 Reviewed by Darin Adler.
1087 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1088 (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1090 2015-12-15 David Kilzer <ddkilzer@apple.com>
1092 REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1093 <http://webkit.org/b/152314>
1095 Reviewed by Daniel Bates.
1097 The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1098 code path to exit immediately when calling main().
1099 Unfortunately, DumpRenderTreeMain.mm was used for both
1100 DumpRenderTree command-line binary and DumpRenderTree.app, which
1101 meant that the app would exit immediately with no error code
1104 The workaround is to introduce a separate source file called
1105 DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1108 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1109 DumpRenderTreeAppMain.mm to the project. Make it the only
1110 compiled source for the DumpRenderTree.app target.
1111 * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1112 (main): Call DumpRenderTreeMain() on iOS. Assert on OS X in
1113 case someone tries mistakenly to use the app.
1114 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1115 Link to JavaScriptCore.framework on iOS for the assert.
1116 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1117 Link to JavaScriptCore.framework on OS X for the assert. Remove
1118 unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1119 * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1120 (main): Add assert for iOS so that a crash occurs if someone
1121 tries to run the wrong command.
1123 2015-12-14 Tim Horton <timothy_horton@apple.com>
1125 Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1126 https://bugs.webkit.org/show_bug.cgi?id=152266
1127 <rdar://problem/22092676>
1129 Reviewed by Simon Fraser.
1131 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1132 * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1133 Add a test that crashed before this change, and doesn't crash after.
1135 2015-12-14 Chris Fleizach <cfleizach@apple.com>
1137 AX: iOS: Text field variations do not have the correct traits
1138 https://bugs.webkit.org/show_bug.cgi?id=152237
1140 Reviewed by Mario Sanchez Prada.
1142 Add iOS calls for determing if an object is a search field or a text area.
1144 * DumpRenderTree/AccessibilityUIElement.cpp:
1145 (getIsSearchFieldCallback):
1146 (getIsTextAreaCallback):
1147 (stringForSelectionCallback):
1148 (AccessibilityUIElement::getJSClass):
1149 * DumpRenderTree/AccessibilityUIElement.h:
1150 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1151 (AccessibilityUIElement::identifier):
1152 (AccessibilityUIElement::isTextArea):
1153 (AccessibilityUIElement::isSearchField):
1154 (AccessibilityUIElement::traits):
1155 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1156 (WTR::AccessibilityUIElement::scrollPageRight):
1157 (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1158 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1159 (WTR::AccessibilityUIElement::isSearchField):
1160 (WTR::AccessibilityUIElement::isTextArea):
1161 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1162 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1163 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1164 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1165 (WTR::AccessibilityUIElement::isTextArea):
1166 (WTR::AccessibilityUIElement::isSearchField):
1167 (WTR::AccessibilityUIElement::rowCount):
1169 2015-12-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
1171 [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1172 https://bugs.webkit.org/show_bug.cgi?id=152252
1174 Reviewed by Sergio Villar Senin.
1176 * gtk/install-dependencies: Add libtool-bin to the list of packages required
1177 for building the JHBuild on Debian systems.
1179 2015-12-11 Joseph Pecoraro <pecoraro@apple.com>
1181 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1182 https://bugs.webkit.org/show_bug.cgi?id=152156
1184 Reviewed by Dan Bernstein.
1186 Our frameworks should appropriately prefix all ObjC classes,
1187 not just external symbols.
1189 * Scripts/check-for-inappropriate-objc-class-names:
1190 Remove the -g switch to check all ObjC class names.
1192 2015-12-10 Eric Carlson <eric.carlson@apple.com>
1194 [MediaStream] Expose media capture devices persistent permissions to WebCore
1195 https://bugs.webkit.org/show_bug.cgi?id=152087
1197 Add support for the new user media permission checker page UI client method.
1199 Reviewed by Chris Dumez.
1201 * WebKitTestRunner/TestController.cpp:
1202 (WTR::decidePolicyForUserMediaPermissionRequest):
1203 (WTR::checkUserMediaPermissionForOrigin):
1204 (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1205 (WTR::TestController::createWebViewWithOptions): Ditto.
1206 (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1207 (WTR::originUserVisibleName): New, create a string for the origin.
1208 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1209 according to the state of the origin permission map.
1210 (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1211 request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1212 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1213 origin permission map.
1214 * WebKitTestRunner/TestController.h:
1216 2015-12-10 Alex Christensen <achristensen@webkit.org>
1218 REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1219 https://bugs.webkit.org/show_bug.cgi?id=152022
1220 rdar://problem/23763584
1222 Reviewed by Darin Adler.
1224 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1225 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1226 (WTR::InjectedBundlePage::willSendRequestForFrame):
1227 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1228 (WTR::TestRunner::setWillSendRequestReturnsNull):
1229 (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1230 (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1231 (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1232 (WTR::TestRunner::willSendRequestHTTPBody):
1233 Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1235 2015-12-10 Aakash Jain <aakash_jain@apple.com>
1237 Remove additional simulator checks before running layout-tests
1238 https://bugs.webkit.org/show_bug.cgi?id=152146
1240 Reviewed by Darin Adler.
1242 * Scripts/webkitpy/port/ios.py:
1243 (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1244 * Scripts/webkitpy/xcode/simulator.py:
1245 (Simulator._boot_and_shutdown_simulator_device): Deleted.
1246 (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1248 2015-12-09 Aakash Jain <aakash_jain@apple.com>
1250 Run atleast one simulator even if max process limit is low
1251 https://bugs.webkit.org/show_bug.cgi?id=152081
1252 <rdar://problem/23819694>
1254 Reviewed by Alexey Proskuryakov.
1256 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
1258 [GTK] Crash in WebProcess when loading large content with custom URI schemes
1259 https://bugs.webkit.org/show_bug.cgi?id=144262
1261 Reviewed by Carlos Garcia Campos.
1263 Added new unit test to check the additional scenarios we now
1264 handle for custom URI schemes.
1266 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1267 (generateHTMLContent): New helper function to generate big enough content.
1268 (testWebContextURIScheme): New unit test.
1270 2015-12-09 Ryuan Choi <ryuan.choi@navercorp.com>
1272 [EFL] Fix unhandled web process message when launching MiniBrowser
1273 https://bugs.webkit.org/show_bug.cgi?id=152048
1275 Reviewed by Gyuyoung Kim.
1277 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1278 (TestWebKitAPI::TEST):
1280 2015-12-09 Carlos Garcia Campos <cgarcia@igalia.com>
1282 [GTK] Add API to handle beforeunload events
1283 https://bugs.webkit.org/show_bug.cgi?id=139090
1285 Reviewed by Gustavo Noronha Silva.
1287 * MiniBrowser/gtk/BrowserWindow.c:
1288 (browserWindowConstructed):
1289 (browserWindowDeleteEvent):
1290 (browser_window_class_init):
1291 Handle delete-event to prevent the window from being closed when
1292 the page has beforeunload handlers. Use
1293 webkit_web_view_try_close() when the window is requested to be
1295 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1296 (testWebViewJavaScriptDialogs):
1297 Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1300 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
1302 Refactored initialization code in LoadTrackingTest.
1304 Rubber-stamped by Carlos Garcia Campos.
1306 Small refactoring to make sure that the state of a LoadTrackingTest
1307 gets properly reset before loading new web content.
1309 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1310 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1311 (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1312 functions and reset the remaining local variables.
1313 (LoadTrackingTest::loadURI): Call reset();
1314 (LoadTrackingTest::loadHtml): Ditto.
1315 (LoadTrackingTest::loadPlainText): Ditto.
1316 (LoadTrackingTest::loadBytes): Ditto.
1317 (LoadTrackingTest::loadRequest): Ditto.
1318 (LoadTrackingTest::reload): Ditto.
1319 (LoadTrackingTest::goBack): Ditto.
1320 (LoadTrackingTest::goForward): Ditto.
1322 2015-12-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1324 [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1325 https://bugs.webkit.org/show_bug.cgi?id=151942
1327 Reviewed by Darin Adler.
1329 * MiniBrowser/efl/main.c:
1330 (window_create): Enable offline web application cache feature on MiniBrowser.
1333 2015-12-08 Aakash Jain <aakash_jain@apple.com>
1335 https://bugs.webkit.org/show_bug.cgi?id=151243
1336 <rdar://problem/22955197>
1338 Reviewed by Alexey Proskuryakov.
1340 * LayoutTestRelay/LayoutTestRelay/main.m:
1341 (getTestingSimDevice): Use separate testing device for each worker.
1342 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1343 (Manager.run): Perform cleanup even if setup fails.
1344 * Scripts/webkitpy/port/ios.py:
1345 (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1346 (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1347 (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1348 (IOSSimulatorPort._quit_ios_simulator): Same
1349 (IOSSimulatorPort.clean_up_test_run): Same
1350 (IOSSimulatorPort.check_sys_deps): Same
1351 (IOSSimulatorPort.testing_device): Same
1352 (IOSSimulatorPort.reset_preferences): Same
1353 (IOSSimulatorPort.get_simulator_path): Return simulator path.
1354 (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1355 * Scripts/webkitpy/xcode/simulator.py:
1356 (Device.delete): Delete the simulator device.
1357 (Simulator.delete_device): Same
1358 (Simulator.wait_until_device_is_booted): Wait for device booting.
1360 2015-12-08 Ryuan Choi <ryuan.choi@navercorp.com>
1362 [EFL] Add API to provide preferences before creating ewk_view
1363 https://bugs.webkit.org/show_bug.cgi?id=151587
1365 Reviewed by Gyuyoung Kim.
1367 * MiniBrowser/efl/main.c:
1371 Moved settings related code to configuration() not to update settings
1372 whenever ewk_view is created.
1376 2015-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
1378 Unreviewed. Fix GTK+ API tests after r193639.
1380 The new jhbuild version needs some more variables ot be present in
1381 the builtin dict, even if they are set to None.
1383 * jhbuild/jhbuildutils.py:
1384 (enter_jhbuild_environment_if_available):
1386 2015-12-07 Gustavo Noronha Silva <gns@gnome.org>
1388 [GTK] Notify WebCore when notification is clicked
1389 https://bugs.webkit.org/show_bug.cgi?id=151951
1391 Reviewed by Carlos Garcia Campos.
1393 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1394 (testWebViewNotification): test the new API.
1396 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
1398 'jhbuild build' should fail immediately when building any module fails
1399 https://bugs.webkit.org/show_bug.cgi?id=145697
1401 Reviewed by Carlos Garcia Campos.
1403 * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1404 * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1405 Everything is placed under lib instead of lib64 now.
1406 * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1407 --exit-on-error when running 'jhbuild build'.
1408 * jhbuild/jhbuildrc_common.py:
1409 (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1410 jhbuild should be able to handle these for us without breaking things....
1412 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
1414 Add support to import w3c tests from a repository with a different root that the main repo dir
1415 https://bugs.webkit.org/show_bug.cgi?id=151751
1417 Reviewed by Ryosuke Niwa and Youenn Fablet.
1419 We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1420 in a different directory than the repository root.
1422 This patch introduces a new parameter tests_directory that we will use as root directory to search for
1423 tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1424 requires having the copy_path lists including tuples of origin and destination directories.
1426 * Scripts/webkitpy/w3c/test_downloader.py:
1427 (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1428 (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1429 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1430 (TestImporterTest.test_tests_directory): Test.
1432 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
1434 Mock TestRepositories in W3C importer tests
1435 https://bugs.webkit.org/show_bug.cgi?id=151938
1437 Reviewed by Youenn Fablet.
1439 The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1440 is because the test repository method reading the file was using the filesystem directly instead of taking the
1441 host one. This patch changes that.
1443 * Scripts/webkitpy/w3c/test_downloader.py:
1444 (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1446 (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1447 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1448 (TestImporterTest.test_harnesslinks_conversion):
1449 (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1451 2015-12-07 David Kilzer <ddkilzer@apple.com>
1453 TestNetscapePlugIn: Address review comment on 193607
1454 <http://webkit.org/b/151881>
1456 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1457 (testSetStatus): Initializing std::unique_ptr<char[]> with
1458 nullptr is redundant.
1460 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
1462 [GTK] Add webkit_uri_request_get_http_method
1463 https://bugs.webkit.org/show_bug.cgi?id=151601
1465 Reviewed by Martin Robinson.
1467 Add test case to check HTTP method of WebKitURIRequest.
1469 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1470 (testURIRequestHTTPMethod):
1473 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1474 (sendRequestCallback):
1476 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
1478 [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1479 https://bugs.webkit.org/show_bug.cgi?id=79918
1481 Reviewed by Gustavo Noronha Silva.
1483 Add unit tests to check the different console messages.
1485 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1486 * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1487 (ConsoleMessageTest::ConsoleMessage::operator==):
1488 (ConsoleMessageTest::consoleMessageReceivedCallback):
1489 (ConsoleMessageTest::ConsoleMessageTest):
1490 (ConsoleMessageTest::~ConsoleMessageTest):
1491 (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1492 (testWebKitConsoleMessageConsoleAPI):
1493 (testWebKitConsoleMessageJavaScriptException):
1494 (testWebKitConsoleMessageNetworkError):
1495 (testWebKitConsoleMessageSecurityError):
1498 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1499 (consoleMessageSentCallback):
1500 (pageCreatedCallback):
1502 2015-12-07 Ryuan Choi <ryuan.choi@navercorp.com>
1504 [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1505 https://bugs.webkit.org/show_bug.cgi?id=151934
1507 Reviewed by Csaba Osztrogonác.
1509 * MiniBrowser/efl/main.c:
1510 (on_window_deletion): Revert the changes of r192767.
1512 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
1514 [GTK] update-webkitgtk-libs cannot build mesa
1515 https://bugs.webkit.org/show_bug.cgi?id=151535
1517 Reviewed by Martin Robinson.
1519 Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1520 dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1521 on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1522 does not have a stable API and we cannot expect mesa to be buildable unless we control the
1523 LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1524 --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1526 * gtk/jhbuild.modules:
1528 2015-12-07 Philippe Normand <pnormand@igalia.com>
1530 [GTK][Mac] libWebExtensionTest link error
1531 https://bugs.webkit.org/show_bug.cgi?id=150802
1533 Reviewed by Carlos Garcia Campos.
1535 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1537 2015-12-06 David Kilzer <ddkilzer@apple.com>
1539 TestNetscapePlugIn: Fix leaks found by static analyzer
1540 <http://webkit.org/b/151881>
1542 Reviewed by Darin Adler.
1544 Fixes the following leaks found by the static analyzer:
1545 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1548 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1551 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1555 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1556 (toCString): Switch to returning std::unique_ptr<char[]>. Add
1557 early return if allocation fails.
1558 (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1559 Make sure to call fclose() on filehandle, even for an early
1561 (testSetStatus): Switch to using std::unique_ptr<char[]>.
1563 2015-12-05 David Kilzer <ddkilzer@apple.com>
1565 prepare-ChangeLog: Fix some warning messages when using svn
1566 <http://webkit.org/b/151914>
1568 Reviewed by Daniel Bates.
1570 * Scripts/prepare-ChangeLog:
1571 (generateFunctionLists): Simplify logic so that we never call
1572 normalizePath() with an undefined value.
1573 (attributeCommand): Quote $subPath for the shell so that we
1574 don't try to run "svn propget" on invalid paths.
1576 2015-12-04 David Kilzer <ddkilzer@apple.com>
1578 TestNetscapePlugIn: Fix remaining static analyzer warnings
1579 <http://webkit.org/b/151888>
1581 Reviewed by Alexey Proskuryakov.
1583 Fixes the following static analyzer warnings:
1584 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1587 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1588 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1590 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1591 return obj->pluginTest->NPP_SetWindow(window);
1593 2 warnings generated.
1595 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1596 (CRASH): Use __builtin_trap() for gcc/clang.
1597 (NPP_SetWindow): Add early return if obj is nullptr.
1599 2015-12-03 Carlos Garcia Campos <cgarcia@igalia.com>
1601 [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1602 https://bugs.webkit.org/show_bug.cgi?id=151797
1604 Reviewed by Martin Robinson.
1606 Since we switched to use the network process to run the unit tests
1607 the test /webkit2/WebKitWebResource/get-data sometimes fails and
1608 sometimes passes. We are now also getting the notification for the
1609 css image. Since we wait for 3 resources, sometimes the css image
1610 is loaded before and then checkResourceData is called for it, but
1611 not handled. When the css image is the last one loaded the test
1612 passes. So, we just need to wait for the 4 resources.
1614 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1615 (testWebResourceGetData):
1617 2015-12-03 David Kilzer <ddkilzer@apple.com>
1619 DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1620 <http://webkit.org/b/151845>
1622 Reviewed by Simon Fraser.
1624 Fixes the following static analyzer warning:
1625 DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1626 WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1627 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1629 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1630 (createBitmapContext): Free 'buffer' after using it in logging
1631 to fix the use-after-free. Assign a value of nullptr to buffer
1632 so we don't return with it set to a freed address.
1634 2015-12-03 Jer Noble <jer.noble@apple.com>
1636 Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1637 https://bugs.webkit.org/show_bug.cgi?id=151830
1639 Reviewed by Anders Carlsson.
1641 Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1643 * DumpRenderTree/mac/DumpRenderTree.mm:
1644 (resetWebPreferencesToConsistentValues):
1645 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1646 (WTR::initializeWebViewConfiguration):
1648 2015-12-03 Anders Carlsson <andersca@apple.com>
1650 Remove Objective-C GC support
1651 https://bugs.webkit.org/show_bug.cgi?id=151819
1652 rdar://problem/23746991
1654 Reviewed by Dan Bernstein.
1656 * asan/asan.xcconfig:
1658 2015-12-02 Yusuke Suzuki <utatane.tea@gmail.com>
1660 Allow nil for unspecified benchmark pathes
1661 https://bugs.webkit.org/show_bug.cgi?id=151784
1663 Reviewed by Filip Pizlo.
1665 `Pathname.new(nil)` will raise an error.
1666 Only generate Pathname if the benchmark path is specified.
1668 * Scripts/run-jsc-benchmarks:
1670 2015-12-02 Brent Fulgham <bfulgham@apple.com>
1672 [Win] Run non-http tests without Cygwin
1673 https://bugs.webkit.org/show_bug.cgi?id=151721
1675 Reviewed by Andy Estes.
1677 Support native 32-bit and 64-bit Python (and Perl) builds
1680 1. Use "startswith('win')", rather than "== 'win32'" to support
1681 various Windows build types.
1682 2. Supply full path for some native Windows utilities, since the
1683 path environment does not always have the specified, and they are
1684 guaranteed to exist in those specific locations.
1685 3. Make sure native Windows Python test runs pass proper environment
1686 variables to run programs.
1687 4. Append 'exe' suffix when running Windows executables.
1688 5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1689 command doesn't exist.
1691 * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1692 the current Perl executable, rather than requiring a new path search.
1693 * Scripts/webkitpy/common/find_files_unittest.py:
1694 (TestWinNormalize.test_win): Use startswith('win').
1695 * Scripts/webkitpy/common/prettypatch_unittest.py:
1696 (test_pretty_diff_encodings): Ditto.
1697 * Scripts/webkitpy/common/system/executive.py:
1698 (Executive._should_close_fds): Ditto.
1699 (Executive.shell_command_for_script): Use startswith('win').
1700 (Executive.kill_process): Use full path to killall executable.
1701 (Executive.check_running_pid): Use startswith('win').
1702 (Executive.running_pids): Ditto.
1703 (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1704 running under native Windows Python.
1705 (Executive._child_process_encoding): Use startswith('win').
1706 (Executive._should_encode_child_process_arguments): Ditto.
1707 (Executive.popen): Recognize proper script engine on Windows, since it
1708 does not support the shebang syntax.
1709 (Executive.run_in_parallel): Use startswith('win').
1710 * Scripts/webkitpy/common/system/executive_unittest.py:
1711 (never_ending_command): Ditto.
1712 (ExecutiveTest.test_run_command_with_unicode): Ditto.
1713 (ExecutiveTest.serial_test_kill_process): Ditto.
1714 (ExecutiveTest.serial_test_kill_all): Ditto.
1715 (ExecutiveTest.serial_test_check_running_pid): Ditto.
1716 (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1718 * Scripts/webkitpy/common/system/file_lock.py:
1719 (FileLock._create_lock): Ditto.
1720 (FileLock._remove_lock): Ditto.
1721 * Scripts/webkitpy/common/system/filesystem_unittest.py:
1722 (RealFileSystemTest.test_chdir): Ditto.
1723 (RealFileSystemTest.test_chdir__notexists): Ditto.
1724 (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1725 * Scripts/webkitpy/common/system/path_unittest.py:
1726 (AbspathTest.test_abspath_to_uri_win): Ditto.
1727 * Scripts/webkitpy/common/system/platforminfo.py:
1728 (PlatformInfo._determine_os_name): Ditto.
1729 * Scripts/webkitpy/common/system/user.py: Ditto.
1730 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1731 (ManagerTest.integration_test_needs_servers): Ditto.
1732 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1733 (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1735 (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1736 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1737 (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1738 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1739 (HttpServerBase._check_that_all_ports_are_available): Ditto.
1740 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1741 (TestHttpServer.test_start_cmd): Ditto.
1742 * Scripts/webkitpy/port/base.py:
1743 (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1744 and 'SYSTEMROOT' in environment passed to test runners.
1745 (Port._apache_config_file_name_for_platform): Use startswith('win').
1746 (Port._build_path): Ditto.
1747 (Port._path_to_driver): Include 'exe' suffix when running under native
1749 * Scripts/webkitpy/port/driver.py:
1750 (Driver._setup_environ_for_driver): Explicitly make some environment
1752 * Scripts/webkitpy/port/server_process.py:
1753 (ServerProcess.__init__): Use startswith('win').
1754 * Scripts/webkitpy/port/win.py:
1755 (WinPort): Use the win32 registry utilities on Windows, and appropriate
1756 registry key formats.
1757 (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1758 (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1759 and regtool on Cygwin.
1760 (WinPort.write_registry_value): Ditto.
1761 (WinPort.setup_crash_log_saving): Ditto.
1762 (WinPort.restore_crash_log_saving): Ditto.
1763 (WinPort.prevent_error_dialogs): Ditto.
1764 (WinPort.allow_error_dialogs): Ditto.
1765 (WinPort.find_system_pid): Revise to use Windows management
1766 infrastructure on native Windows, continue using 'ps' on Cygwin.
1767 (WinPort.read_registry_string): Deleted.
1768 (WinPort.write_registry_string): Deleted.
1769 * Scripts/webkitpy/test/main.py:
1770 (main): Use startswith('win').
1771 (Tester._parse_args): Ditto.
1773 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
1775 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1776 https://bugs.webkit.org/show_bug.cgi?id=150792
1778 Reviewed by Saam Barati.
1780 * Scripts/webkitperl/FeatureList.pm:
1782 2015-12-01 Commit Queue <commit-queue@webkit.org>
1784 Unreviewed, rolling out r192914.
1785 https://bugs.webkit.org/show_bug.cgi?id=151734
1787 JSC tests for this change are failing on 32 and 64-bit bots
1788 (Requested by ryanhaddad on #webkit).
1792 "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1793 enable this feature"
1794 https://bugs.webkit.org/show_bug.cgi?id=150792
1795 http://trac.webkit.org/changeset/192914
1797 2015-12-01 David Kilzer <ddkilzer@apple.com>
1799 EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1800 <http://webkit.org/b/151726>
1802 Reviewed by Simon Fraser.
1804 * WebKitTestRunner/mac/EventSenderProxy.mm:
1805 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1806 Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1808 2015-12-01 Myles C. Maxfield <mmaxfield@apple.com>
1810 Give String and AtomicString an existingHash() function
1811 https://bugs.webkit.org/show_bug.cgi?id=151717
1813 Reviewed by Andreas Kling.
1815 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1816 (TestWebKitAPI::TEST):
1817 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1818 (TestWebKitAPI::TEST):
1820 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
1822 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1823 https://bugs.webkit.org/show_bug.cgi?id=150792
1825 Reviewed by Saam Barati.
1827 * Scripts/webkitperl/FeatureList.pm:
1829 2015-12-01 Sam Weinig <sam@webkit.org>
1831 Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1832 <rdar://problem/23320863>
1833 https://bugs.webkit.org/show_bug.cgi?id=151708
1835 Reviewed by Anders Carlsson.
1837 * WebKitTestRunner/TestController.cpp:
1838 (WTR::TestController::createOtherPage):
1839 (WTR::TestController::createWebViewWithOptions):
1840 Update for new WKPageUIClient.
1842 2015-12-01 Anders Carlsson <andersca@apple.com>
1844 Remove WebKit2.framework
1845 https://bugs.webkit.org/show_bug.cgi?id=151715
1847 Reviewed by Dan Bernstein.
1849 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1850 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1851 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1852 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1853 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1854 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1855 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1857 2015-12-01 Joseph Pecoraro <pecoraro@apple.com>
1859 Unreviewed common typo fix "occurance" => "occurrence".
1861 * Scripts/webkitpy/tool/commands/queries.py:
1862 (FindFlakyTests._print_statistics):
1864 2015-11-30 Alex Christensen <achristensen@webkit.org>
1866 Make ProcessModel always MultipleSecondaryProcesses
1867 https://bugs.webkit.org/show_bug.cgi?id=151662
1869 Reviewed by Antti Koivisto.
1871 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1872 (TestWebKitAPI::TEST):
1873 * WebKitTestRunner/TestController.cpp:
1874 (WTR::TestController::generatePageConfiguration):
1876 2015-11-30 Alex Christensen <achristensen@webkit.org>
1878 Make usesNetworkProcess always true
1879 https://bugs.webkit.org/show_bug.cgi?id=151580
1881 Reviewed by Darin Adler.
1883 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1884 (TestWebKitAPI::TEST):
1885 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1886 (TestWebKitAPI::TEST):
1887 * WebKitTestRunner/TestController.cpp:
1888 (WTR::TestController::generatePageConfiguration):
1890 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
1892 Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1894 Add a way to skip unit tests only for Debug or Release builds and
1895 skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1897 * Scripts/run-gtk-tests:
1899 (SkippedTest.__init__):
1900 (SkippedTest.__str__):
1901 (SkippedTest.skip_entire_suite):
1902 (SkippedTest.skip_for_build_type):
1904 (TestRunner.__init__):
1906 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
1908 Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1910 It's an assert hit because we are reloading a view loaded with
1911 HTML data which is not supported. Use loadURI instead.
1913 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1914 (testWebViewCustomCharset):
1916 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
1918 [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1919 https://bugs.webkit.org/show_bug.cgi?id=151633
1921 Reviewed by Csaba Osztrogonác.
1923 * TestWebKitAPI/PlatformGTK.cmake:
1924 * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1926 2015-11-27 Carlos Garcia Campos <cgarcia@igalia.com>
1928 [GTK] Remove the remaining uses of GMainLoopSource
1929 https://bugs.webkit.org/show_bug.cgi?id=151632
1931 Reviewed by Žan Doberšek.
1933 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1934 (testWebViewSyncRequestOnMaxConns):
1935 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1936 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1937 (WTR::TestRunner::TestRunner):
1938 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1939 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1940 (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1941 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1942 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1943 (WTR::timeoutSource):
1944 (WTR::TestController::notifyDone):
1945 (WTR::TestController::platformRunUntil):
1947 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
1949 [cmake] Add testb3 to the build system
1950 https://bugs.webkit.org/show_bug.cgi?id=151619
1952 Reviewed by Gyuyoung Kim.
1954 * Scripts/build-jsc:
1956 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
1958 [jhbuild] Fix pixman build with clang
1959 https://bugs.webkit.org/show_bug.cgi?id=151441
1961 Reviewed by Carlos Garcia Campos.
1963 * efl/jhbuild.modules:
1964 * gtk/jhbuild.modules:
1966 2015-11-26 David Kilzer <ddkilzer@apple.com>
1968 Extract prependToEnvironmentVariableList
1969 <http://webkit.org/b/151536>
1971 Reviewed by Daniel Bates.
1973 Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1974 webkitdirs_unittest/prependToEnvironmentVariableList.pl
1976 * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1977 and prependToEnvironmentVariableList.
1978 (appendToEnvironmentVariableList): Simplify variable name.
1979 Switch to use $Config{path_sep}.
1980 (prependToEnvironmentVariableList): Add new method.
1981 (setupMacWebKitEnvironment): Switch to use
1982 prependToEnvironmentVariableList().
1983 (setupIOSWebKitEnvironment): Ditto.
1985 * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1986 * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1988 2015-11-24 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1990 REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1991 https://bugs.webkit.org/show_bug.cgi?id=151567
1993 Reviewed by Darin Adler.
1995 * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1996 (on_window_deletion):
1998 2015-11-23 Carlos Garcia Campos <cgarcia@igalia.com>
2000 [GTK] Use the network process unconditionally
2001 https://bugs.webkit.org/show_bug.cgi?id=151541
2003 Reviewed by Alex Christensen.
2005 Fix TestInspectorServer test. Do not assume we already have the
2006 title we want when the page has been loaded, since the title is
2007 changed afterwards. So, check if the title has already been set,
2008 and if not wait for it.
2010 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2011 (openRemoteDebuggingSession):
2013 2015-11-23 Alex Christensen <achristensen@webkit.org>
2015 Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2016 https://bugs.webkit.org/show_bug.cgi?id=151532
2018 Reviewed by Benjamin Poulain.
2020 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2021 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2022 (TestWebKitAPI::TEST):
2023 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2024 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2025 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2026 Properly load about:blank in all WebViews to clean up. Without this change, we had a
2027 Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2028 so it was calling a function on a test object that had gone out of scope.
2029 Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2030 but that will become the default soon and that call will be removed.
2032 2015-11-22 David Kilzer <ddkilzer@apple.com>
2034 run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2035 <http://webkit.org/b/151542>
2037 Reviewed by Daniel Bates.
2039 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2040 (base_url): Use the Port object (already passed in) to give us
2041 the path to the LayoutTests directory, which already checks for a
2042 --layout-tests-directory command-line switch.
2043 (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2044 argument since we can get this from the Port object already
2045 passed in via Port.results_directory(). Also switch to use
2046 Port.layout_tests_dir() to get the LayoutTests directory.
2048 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2049 (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2050 Add test case for custom LayoutTests directory.
2051 (TestWebPlatformTestServer.test_previously_spawned_instance):
2052 Update Port object to set mock results directory as if it was
2053 set on the command-line. Remove unneeded argument from
2054 WebPlatformTestServer constructor.
2055 (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2057 * Scripts/webkitpy/port/base.py:
2058 (Port.to.start_web_platform_test_server): Remove unneeded
2059 argument from WebPlatformTestServer constuctor.
2061 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
2063 [GTK] Some unit tests fail when using the network process
2064 https://bugs.webkit.org/show_bug.cgi?id=151490
2066 Reviewed by Martin Robinson.
2068 Run the soup server in a separate thread in TestResources test to
2071 This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2072 /webkit2/WebKitWebResource/get-data when using the network process.
2074 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2075 (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2076 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2077 (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2078 present, create a WorkQueue to run the server.
2079 (WebKitTestServer::run): Run the server in the work queue if it
2081 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2082 type into server options as flags.
2084 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
2086 [GTK] ImageDiff should normalize the diff image
2087 https://bugs.webkit.org/show_bug.cgi?id=151261
2089 Reviewed by Sergio Villar Senin.
2091 * ImageDiff/gtk/ImageDiff.cpp:
2092 (readPixbufFromStdin): Fix memory leak.
2093 (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2094 (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2096 == Rolled over to ChangeLog-2015-11-21 ==