0fa080f69495444605294783d0202916de62c715
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-30  David Farler  <dfarler@apple.com>
2
3         Move OTHER_LDFLAGS erasure to DumpRenderTreeLibrary.xcconfig.
4         https://bugs.webkit.org/show_bug.cgi?id=127935
5
6         Reviewed by Andy Estes.
7
8         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
10         Move OTHER_LDFLAGS erasure to the static library's xcconfig.
11
12 2014-01-30  David Farler  <dfarler@apple.com>
13
14         DumpRenderTree fails to build with ASAN: -fsanitize=address passed to static DRT target
15         https://bugs.webkit.org/show_bug.cgi?id=127935
16
17         Reviewed by Andy Estes.
18
19         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
20         Clear OTHER_LDFLAGS at the project level for the static library target.
21         No other linker flags were inherited from DebugRelease.
22
23 2014-01-30  David Farler  <dfarler@apple.com>
24
25         package-root shouldn't prefix simulator roots with the SDK path
26         http://bugs.webkit.org/show_bug.cgi?id=127923
27
28         Reviewed by Dan Bernstein.
29
30         * Scripts/package-root: Don't add an install path prefix.
31
32 2014-01-30  Gabor Rapcsanyi  <rgabor@webkit.org>
33
34         Add ARM EFL Linux builder bots to Apple buildmaster
35         https://bugs.webkit.org/show_bug.cgi?id=127472
36
37         Reviewed by Csaba Osztrogonác.
38
39         There is no ARM buildslaves after removing the Qt builders.
40
41         * BuildSlaveSupport/build.webkit.org-config/config.json:
42
43 2014-01-30  Andy Estes  <aestes@apple.com>
44
45         REGRESSION (r163037): WebKit2.PageLoadBasic API test failing on Mountain Lion
46         https://bugs.webkit.org/show_bug.cgi?id=127934
47
48         Disable the failing test on Mountain Lion.
49
50         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
51         (TestWebKitAPI::TEST):
52
53 2014-01-30  Anders Carlsson  <andersca@apple.com>
54
55         Add WKNavigationDelegate class
56         https://bugs.webkit.org/show_bug.cgi?id=127927
57
58         Reviewed by Dan Bernstein.
59
60         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
61         (TEST):
62
63 2014-01-30  David Farler  <dfarler@apple.com>
64
65         Enable iOS Tools builds by default
66         https://bugs.webkit.org/show_bug.cgi?id=127919
67
68         Reviewed by Andy Estes.
69
70         * Makefile:
71         Build all the tools except MiniBrowser on iOS
72         * Scripts/build-webkit:
73         Ditto.
74         Build WebKitTestRunnerApp target on iOS.
75
76 2014-01-30  David Farler  <dfarler@apple.com>
77
78         Make TestWebKitAPI build and run for iOS
79         https://bugs.webkit.org/show_bug.cgi?id=127925
80
81         Reviewed by Andy Estes.
82
83         * TestWebKitAPI/Configurations/Base.xcconfig:
84         - Don't warn on 64-32 bit conversion on x86_64 and arm64
85         - Don't build mac/*
86         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
87         - Link WebKit2 on all platforms
88
89 2014-01-30  David Farler  <dfarler@apple.com>
90
91         package-root should copy ./usr from the build products directory
92         https://bugs.webkit.org/show_bug.cgi?id=127878
93
94         Reviewed by Daniel Bates.
95
96         * Scripts/package-root:
97         Copy ./usr in addition to the frameworks.
98
99 2014-01-30  Andrei Bucur  <abucur@adobe.com>
100
101         Remove the ACCELERATED_COMPOSITING flag
102         https://bugs.webkit.org/show_bug.cgi?id=127833
103
104         Reviewed by Antti Koivisto.
105
106         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
107         mandatory.
108
109         * DumpRenderTree/efl/DumpRenderTree.cpp:
110         (initEcoreEvas):
111         * EWebLauncher/main.c:
112         (windowCreate):
113         * MiniBrowser/efl/main.c:
114         (elm_main):
115         * TestWebKitAPI/efl/PlatformWebView.cpp:
116         (TestWebKitAPI::initEcoreEvas):
117         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
118         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
119         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
120         (WTR::initEcoreEvas):
121
122 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
123
124         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
125         https://bugs.webkit.org/show_bug.cgi?id=127845
126
127         Reviewed by Joseph Pecoraro.
128
129         * Scripts/webkitperl/FeatureList.pm:
130
131 2014-01-29  Anders Carlsson  <andersca@apple.com>
132
133         -[WKWebView loadRequest:] should return a WKNavigation
134         https://bugs.webkit.org/show_bug.cgi?id=127873
135
136         Reviewed by Dan Bernstein.
137
138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
139         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Added.
140         (TEST):
141
142 2014-01-29  Tim Horton  <timothy_horton@apple.com>
143
144         WebKit2 View Gestures (Swipe): Update rubberBandsAt{Left,Right} when WebKit swipe is enabled
145         https://bugs.webkit.org/show_bug.cgi?id=127855
146         <rdar://problem/15933878>
147
148         Reviewed by Anders Carlsson.
149
150         * MiniBrowser/mac/WK2BrowserWindowController.m:
151         (-[WK2BrowserWindowController awakeFromNib]):
152         Enable swipe in MiniBrowser for testing purposes.
153
154 2014-01-29  Daniel Bates  <dabates@apple.com>
155
156         Fix JSONP requests made by the WebKit Bot Watcher's Dashboard following <http://trac.webkit.org/changeset/163034>
157         (https://bugs.webkit.org/show_bug.cgi?id=127784)
158
159         Use dot-notation instead of array index notation to access the dictionary value for key jsonpCallbackName
160         in the specified options dictionary.
161
162         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
163         (JSON.load):
164
165 2014-01-29  Daniel Bates  <dabates@apple.com>
166
167         WebKit Bot Watcher's Dashboard: Add support for using HTTP authentication with Buildbot
168         https://bugs.webkit.org/show_bug.cgi?id=127784
169
170         Reviewed by Alexey Proskuryakov.
171
172         Implement support for querying a Buildbot that requires HTTP authentication to access it.
173
174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
175         (Buildbot): Add optional argument, options, to pass a dictionary of Buildbot options.
176         For now, we only support a single option, needsAuthentication, to indicate whether the
177         Buildbots requires HTTP authentication (defaults to false - HTTP authentication is
178         not required).
179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
180         (BuildbotIteration.prototype.loadLayoutTestResults): Modified to pass JSONP callback name
181         to JSON.load() using the option dictionary.
182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
183         (BuildbotQueue.prototype.update): Modified to pass withCredentials to JSON.load().
184         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
185         (JSON.load): Removed optional argument jsonpCallbackName and added optional argument options,
186         which is a dictionary. The argument jsonpCallbackName is now specified as an entry in the
187         options dictionary. Added boolean options withCredentials to toggle querying with HTTP
188         authentication credentials.
189
190 2014-01-29  Alexey Proskuryakov  <ap@apple.com>
191
192         build.webkit.org/dashboard links to an old failing build rather than the most recent
193         https://bugs.webkit.org/show_bug.cgi?id=127765
194         <rdar://problem/15795228>
195
196         Reviewed by Timothy Hatcher.
197
198         This patch changes builder view to not show how many failures there were in a row,
199         because it is not very relevant, and complicates the UI. Instead, we just show the
200         latest failing build and the latest successful one.
201
202         The patch also removes commit history popovers from revisions that can not be correlated
203         with any change. These popovers are only helpful in the first line, when there is
204         another line for comparison below. In this case, it's useful to see what changed
205         between the revisions, but even then, only if it was an actual failure, not a buildbot
206         exception.
207
208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
209         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
212         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
213         (BuildbotQueueView.prototype._revisionPopoverContentForIteration):
214         (BuildbotQueueView.prototype.revisionContentForIteration):
215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
216         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
217
218 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
219
220         Remove ENABLE(JAVASCRIPT_DEBUGGER) guards
221         https://bugs.webkit.org/show_bug.cgi?id=127840
222
223         Reviewed by Mark Lam.
224
225         * Scripts/webkitperl/FeatureList.pm:
226
227 2014-01-29  Krzysztof Czech  <k.czech@samsung.com>
228
229         [ATK] Expose aria-describedby with ATK_RELATION_DESCRIBED_BY
230         https://bugs.webkit.org/show_bug.cgi?id=121684
231
232         Reviewed by Mario Sanchez Prada.
233
234         Implementing helpText by using relation ATK_RELATION_DESCRIBED_BY.
235
236         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
237         (AccessibilityUIElement::helpText):
238         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
239         (WTR::AccessibilityUIElement::helpText):
240
241 2014-01-27  Chris Fleizach  <cfleizach@apple.com>
242
243         AX: Support @scope in HTML tables
244         https://bugs.webkit.org/show_bug.cgi?id=127688
245
246         Reviewed by Mario Sanchez Prada.
247
248         Add support for rowHeaders and columnHeaders.
249
250         * DumpRenderTree/AccessibilityUIElement.cpp:
251         (convertElementsToObjectArray):
252         (columnHeadersCallback):
253         (rowHeadersCallback):
254         (uiElementArrayAttributeValueCallback):
255         (AccessibilityUIElement::columnHeaders):
256         (AccessibilityUIElement::rowHeaders):
257         (AccessibilityUIElement::getJSClass):
258         * DumpRenderTree/AccessibilityUIElement.h:
259         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
260         (AccessibilityUIElement::rowHeaders):
261         (AccessibilityUIElement::columnHeaders):
262         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
263         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
264         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
265         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
266         (WTR::AccessibilityUIElement::rowHeaders):
267         (WTR::AccessibilityUIElement::columnHeaders):
268         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
269         (WTR::convertElementsToObjectArray):
270         (WTR::AccessibilityUIElement::rowHeaders):
271         (WTR::AccessibilityUIElement::columnHeaders):
272         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
273
274 2014-01-28  Daniel Bates  <dabates@apple.com>
275
276         Teach Buildbot dashboard to parse alternative revision format
277         https://bugs.webkit.org/show_bug.cgi?id=127561
278
279         Reviewed by Alexey Proskuryakov.
280
281         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
282         returns a dictionary for the value of property got_revision.
283
284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
285         (isMultiCodebaseGotRevisionProperty): Added.
286         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
287         string or a dictionary.
288         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
289         the OpenSource and Internal revision numbers.
290
291 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
292
293         [GTK] Add API to allow setting the process model in WebKitWebContext
294         https://bugs.webkit.org/show_bug.cgi?id=125463
295
296         Reviewed by Carlos Garcia Campos.
297
298         Implements accessors in WebKitWebContext for the process model.
299         The default behavior is unchanged, and a single web process is
300         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
301         as the process model will make use one web process for each
302         WebKitWebView. This also enables the network process. Setting
303         the process model must be done as early as possible, before the
304         very first web process is spawned.
305
306         * MiniBrowser/gtk/main.c:
307         (main):
308         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
309         environment variable is defined and not empty.
310         * TestWebKitAPI/GNUmakefile.am:
311         Add new TestMultiprocess test case.
312         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
313         Add new TestMultiprocess test case.
314         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
315         (loadChanged):
316         (testMultipleSecondaryProcesses):
317         (initializeWebExtensions):
318         (beforeAll):
319         (afterAll):
320         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
321         (methodCallCallback):
322         Implement the GetProcessIdentifier D-Bus method.
323         (makeBusName):
324         Choose a different bus name when the web extension is used
325         from TestMultiprocess.
326         (webkit_web_extension_initialize_with_user_data):
327         Use makeBusName() to choose the bus name.
328
329 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
330
331         [SOUP] Remove soupURIToKURL
332         https://bugs.webkit.org/show_bug.cgi?id=127104
333
334         Reviewed by Martin Robinson.
335
336         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
337         tests, because URL.h now includes GUniquePtrSoup.h.
338         * TestWebKitAPI/CMakeLists.txt: Ditto.
339         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
340         because URL.h now includes GUniquePtrSoup.h.
341
342 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
343
344         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
345         https://bugs.webkit.org/show_bug.cgi?id=127614
346
347         Reviewed by Gustavo Noronha Silva.
348
349         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
350         back the custom URI scheme WebView check.
351
352 2014-01-27  Tim Horton  <timothy_horton@apple.com>
353
354         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
355
356         * WebKitTestRunner/TestController.cpp:
357         (WTR::TestController::pluginLoadPolicy):
358         * WebKitTestRunner/TestController.h:
359
360 2014-01-27  Tim Horton  <timothy_horton@apple.com>
361
362         Revert one more tiny part of r162629 that didn't get reverted in r162883.
363
364         ... which was also causing test failures!
365
366         * WebKitTestRunner/TestController.cpp:
367         (WTR::TestController::createWebViewWithOptions):
368
369 2014-01-27  David Farler  <dfarler@apple.com>
370
371         iOS DumpRenderTree.app dies loading fonts
372         https://bugs.webkit.org/show_bug.cgi?id=127730
373
374         Reviewed by Daniel Bates.
375
376         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
377         - Add Ahem to the __DATA section
378         * DumpRenderTree/mac/DumpRenderTree.mm:
379         (activateFontsIOS):
380         - Load "WeightWatcher100" instead.
381
382 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
383
384         [Mac] Extra logging output from run-safari --no-saved-state
385         https://bugs.webkit.org/show_bug.cgi?id=127732
386
387         Reviewed by Daniel Bates.
388
389         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
390         disables saved state without logging.
391
392 2014-01-27  Tim Horton  <timothy_horton@apple.com>
393
394         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
395
396         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
397         plugin indicator intact, though.
398
399         * WebKitTestRunner/TestController.cpp:
400         (WTR::TestController::createWebViewWithOptions):
401
402 2014-01-27  Andy Estes  <aestes@apple.com>
403
404         Scrub WebKit API headers of WTF macros
405         https://bugs.webkit.org/show_bug.cgi?id=127706
406
407         Reviewed by David Kilzer.
408
409         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
410         the regex to require a '(' after the macro name in order to be
411         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
412         from being flagged as an ENABLE() macro.
413
414 2014-01-27  Commit Queue  <commit-queue@webkit.org>
415
416         Unreviewed, rolling out r162846.
417         http://trac.webkit.org/changeset/162846
418         https://bugs.webkit.org/show_bug.cgi?id=127695
419
420         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
421         (Requested by dydz on #webkit).
422
423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
424         (BuildbotIteration.prototype.update.):
425
426 2014-01-27  Daniel Bates  <dabates@apple.com>
427
428         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
429         https://bugs.webkit.org/show_bug.cgi?id=127564
430
431         Reviewed by Alexey Proskuryakov.
432
433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
434         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
435
436 2014-01-27  Daniel Bates  <dabates@apple.com>
437
438         Teach Buildbot dashboard to parse alternative revision format
439         https://bugs.webkit.org/show_bug.cgi?id=127561
440
441         Reviewed by Alexey Proskuryakov.
442
443         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
444         returns a dictionary for the value of property got_revision.
445
446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
447         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
448         string or a dictionary.
449         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
450         the OpenSource and Internal revision numbers.
451
452 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
453
454         [GTK] Implement custom URI schemes with CustomProtocols
455         https://bugs.webkit.org/show_bug.cgi?id=127091
456
457         Reviewed by Gustavo Noronha Silva.
458
459         Temporarily disable the WebKitWebView check until we figure out
460         how to implement it with CustomProtocols.
461
462         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
463
464 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
465
466         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
467
468         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
469         Fixed an incorrect ifdef.
470
471 2014-01-26  Brendan Long  <b.long@cablelabs.com>
472
473         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
474         https://bugs.webkit.org/show_bug.cgi?id=110602
475
476         Reviewed by Philippe Normand.
477
478         * DumpRenderTree/gtk/DumpRenderTree.cpp:
479         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
480         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
481
482 2014-01-24  Andy Estes  <aestes@apple.com>
483
484         [iOS] Upstream changes in Tools/DumpRenderTree
485         https://bugs.webkit.org/show_bug.cgi?id=127412
486
487         Reviewed by Simon Fraser.
488
489         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
490         which builds the DumpRenderTree static library into an app bundle as
491         expected by the iOS Simulator.
492
493         * DumpRenderTree/AccessibilityTextMarker.h:
494         * DumpRenderTree/AccessibilityUIElement.h:
495         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
496         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
497         * DumpRenderTree/DumpRenderTreePrefix.h:
498         * DumpRenderTree/PixelDumpSupport.cpp:
499         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
500         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
501         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
502         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
503         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
504         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
505         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
506         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
507         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
508         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
509         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
510         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
511         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
512         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
513         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
514         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
515         * DumpRenderTree/TestRunner.cpp:
516         * DumpRenderTree/TestRunner.h:
517         * DumpRenderTree/cg/ImageDiffCG.cpp:
518         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
519         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
520         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
521         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
522         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
523         * DumpRenderTree/ios/Info.plist: Added.
524         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
525         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
526         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
527         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
528         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
529         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
530         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
531         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
532         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
533         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
534         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
535         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
536         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
537         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
538         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
539         * DumpRenderTree/mac/AppleScriptController.m:
540         * DumpRenderTree/mac/Configurations/Base.xcconfig:
541         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
542         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
543         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
544         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
545         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
546         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
547         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
548         * DumpRenderTree/mac/DumpRenderTree.mm:
549         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
550         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
551         * DumpRenderTree/mac/DumpRenderTreeMac.h:
552         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
553         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
554         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
555         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
556         * DumpRenderTree/mac/EditingDelegate.h:
557         * DumpRenderTree/mac/EventSendingController.h:
558         * DumpRenderTree/mac/EventSendingController.mm:
559         * DumpRenderTree/mac/FrameLoadDelegate.mm:
560         * DumpRenderTree/mac/HistoryDelegate.h:
561         * DumpRenderTree/mac/LayoutTestHelper.m:
562         * DumpRenderTree/mac/MockGeolocationProvider.mm:
563         * DumpRenderTree/mac/NavigationController.h:
564         * DumpRenderTree/mac/ObjCPlugin.h:
565         * DumpRenderTree/mac/ObjCPlugin.m:
566         * DumpRenderTree/mac/ObjCPluginFunction.h:
567         * DumpRenderTree/mac/PolicyDelegate.h:
568         * DumpRenderTree/mac/ResourceLoadDelegate.h:
569         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
570         * DumpRenderTree/mac/TestRunnerMac.mm:
571         * DumpRenderTree/mac/TextInputController.h:
572         * DumpRenderTree/mac/TextInputController.m:
573         * DumpRenderTree/mac/UIDelegate.h:
574         * DumpRenderTree/mac/UIDelegate.mm:
575
576 2014-01-25  Darin Adler  <darin@apple.com>
577
578         Call deprecatedCharacters instead of characters at more call sites
579         https://bugs.webkit.org/show_bug.cgi?id=127631
580
581         Reviewed by Sam Weinig.
582
583         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
584         (TestWebKitAPI::expectBuilderContent):
585         (TestWebKitAPI::expectEmpty):
586         (TestWebKitAPI::TEST):
587         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
588         (TestWebKitAPI::TEST):
589         Use the new name.
590
591 2014-01-25  Anders Carlsson  <andersca@apple.com>
592
593         Modernize HashTable threading code
594         https://bugs.webkit.org/show_bug.cgi?id=127621
595
596         Reviewed by Darin Adler.
597
598         Explicitly include headers that used to be brought in by HashTable.h
599
600         * DumpRenderTree/JavaScriptThreading.cpp:
601
602 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
603
604         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
605
606         * Scripts/webkitpy/common/config/contributors.json:
607         * Scripts/webkitpy/common/config/watchlist:
608
609 2014-01-23  David Farler  <dfarler@apple.com>
610
611         Make WebKitTestRunner work with iOS
612         https://bugs.webkit.org/show_bug.cgi?id=127448
613
614         Reviewed by Simon Fraser.
615
616         Combined patch from Simon below with some additional xcconfig cleanups,
617         rebasing and stubbing out a couple of new functions that popped up
618         since then.
619
620         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
621
622                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
623
624                 Get WebKitTestRunner limping on iOS. Main parts:
625                 - Stub out lots of accessibility-related functions.
626                 - Stub out EventSender
627                 - Create target to make a bundled app that runs in the simulator,
628                   and copy the injected bundle library into it.
629                 - Make a UIWindow and WKView to load tests in
630
631                 It runs, load tests, and dumps results to output. More work will be
632                 required once we can execute it via the webkitpy scripts.
633
634         * WebKitTestRunner/Configurations/Base.xcconfig:
635         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
636         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
637         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
638         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
639         (WTR::AccessibilityController::addNotificationListener):
640         (WTR::AccessibilityController::removeNotificationListener):
641         (WTR::AccessibilityController::platformName):
642         (WTR::AccessibilityController::logAccessibilityEvents):
643         (WTR::AccessibilityController::resetToConsistentState):
644         (WTR::findAccessibleObjectById):
645         (WTR::AccessibilityController::accessibleElementById):
646         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
647         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
648         (WTR::AccessibilityTextMarker::isEqual):
649         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
650         (WTR::AccessibilityUIElement::AccessibilityUIElement):
651         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
652         (WTR::AccessibilityUIElement::isEqual):
653         (WTR::AccessibilityUIElement::getLinkedUIElements):
654         (WTR::AccessibilityUIElement::getDocumentLinks):
655         (WTR::AccessibilityUIElement::getChildren):
656         (WTR::AccessibilityUIElement::getChildrenWithRange):
657         (WTR::AccessibilityUIElement::childrenCount):
658         (WTR::AccessibilityUIElement::elementAtPoint):
659         (WTR::AccessibilityUIElement::indexOfChild):
660         (WTR::AccessibilityUIElement::childAtIndex):
661         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
662         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
663         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
664         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
665         (WTR::AccessibilityUIElement::rowAtIndex):
666         (WTR::AccessibilityUIElement::selectedChildAtIndex):
667         (WTR::AccessibilityUIElement::selectedChildrenCount):
668         (WTR::AccessibilityUIElement::selectedRowAtIndex):
669         (WTR::AccessibilityUIElement::titleUIElement):
670         (WTR::AccessibilityUIElement::parentElement):
671         (WTR::AccessibilityUIElement::disclosedByRow):
672         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
673         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
674         (WTR::AccessibilityUIElement::attributesOfChildren):
675         (WTR::AccessibilityUIElement::allAttributes):
676         (WTR::AccessibilityUIElement::stringAttributeValue):
677         (WTR::AccessibilityUIElement::numberAttributeValue):
678         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
679         (WTR::AccessibilityUIElement::uiElementAttributeValue):
680         (WTR::AccessibilityUIElement::boolAttributeValue):
681         (WTR::AccessibilityUIElement::isAttributeSettable):
682         (WTR::AccessibilityUIElement::isAttributeSupported):
683         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
684         (WTR::AccessibilityUIElement::role):
685         (WTR::AccessibilityUIElement::subrole):
686         (WTR::AccessibilityUIElement::roleDescription):
687         (WTR::AccessibilityUIElement::title):
688         (WTR::AccessibilityUIElement::description):
689         (WTR::AccessibilityUIElement::orientation):
690         (WTR::AccessibilityUIElement::stringValue):
691         (WTR::AccessibilityUIElement::language):
692         (WTR::AccessibilityUIElement::helpText):
693         (WTR::AccessibilityUIElement::x):
694         (WTR::AccessibilityUIElement::y):
695         (WTR::AccessibilityUIElement::width):
696         (WTR::AccessibilityUIElement::height):
697         (WTR::AccessibilityUIElement::clickPointX):
698         (WTR::AccessibilityUIElement::clickPointY):
699         (WTR::AccessibilityUIElement::intValue):
700         (WTR::AccessibilityUIElement::minValue):
701         (WTR::AccessibilityUIElement::maxValue):
702         (WTR::AccessibilityUIElement::valueDescription):
703         (WTR::AccessibilityUIElement::insertionPointLineNumber):
704         (WTR::AccessibilityUIElement::isPressActionSupported):
705         (WTR::AccessibilityUIElement::isIncrementActionSupported):
706         (WTR::AccessibilityUIElement::isDecrementActionSupported):
707         (WTR::AccessibilityUIElement::isEnabled):
708         (WTR::AccessibilityUIElement::isRequired):
709         (WTR::AccessibilityUIElement::isFocused):
710         (WTR::AccessibilityUIElement::isSelected):
711         (WTR::AccessibilityUIElement::isSelectedOptionActive):
712         (WTR::AccessibilityUIElement::isIndeterminate):
713         (WTR::AccessibilityUIElement::isExpanded):
714         (WTR::AccessibilityUIElement::isChecked):
715         (WTR::AccessibilityUIElement::hierarchicalLevel):
716         (WTR::AccessibilityUIElement::classList):
717         (WTR::AccessibilityUIElement::speak):
718         (WTR::AccessibilityUIElement::ariaIsGrabbed):
719         (WTR::AccessibilityUIElement::ariaDropEffects):
720         (WTR::AccessibilityUIElement::lineForIndex):
721         (WTR::AccessibilityUIElement::rangeForLine):
722         (WTR::AccessibilityUIElement::rangeForPosition):
723         (WTR::AccessibilityUIElement::boundsForRange):
724         (WTR::AccessibilityUIElement::stringForRange):
725         (WTR::AccessibilityUIElement::attributedStringForRange):
726         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
727         (WTR::uiElementCountForSearchPredicate):
728         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
729         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
730         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
731         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
732         (WTR::AccessibilityUIElement::attributesOfColumns):
733         (WTR::AccessibilityUIElement::attributesOfRows):
734         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
735         (WTR::AccessibilityUIElement::attributesOfHeader):
736         (WTR::AccessibilityUIElement::rowCount):
737         (WTR::AccessibilityUIElement::columnCount):
738         (WTR::AccessibilityUIElement::indexInTable):
739         (WTR::AccessibilityUIElement::rowIndexRange):
740         (WTR::AccessibilityUIElement::columnIndexRange):
741         (WTR::AccessibilityUIElement::cellForColumnAndRow):
742         (WTR::AccessibilityUIElement::horizontalScrollbar):
743         (WTR::AccessibilityUIElement::verticalScrollbar):
744         (WTR::AccessibilityUIElement::scrollToMakeVisible):
745         (WTR::AccessibilityUIElement::selectedTextRange):
746         (WTR::AccessibilityUIElement::setSelectedTextRange):
747         (WTR::AccessibilityUIElement::increment):
748         (WTR::AccessibilityUIElement::decrement):
749         (WTR::AccessibilityUIElement::showMenu):
750         (WTR::AccessibilityUIElement::press):
751         (WTR::AccessibilityUIElement::setSelectedChild):
752         (WTR::AccessibilityUIElement::accessibilityValue):
753         (WTR::AccessibilityUIElement::documentEncoding):
754         (WTR::AccessibilityUIElement::documentURI):
755         (WTR::AccessibilityUIElement::url):
756         (WTR::AccessibilityUIElement::addNotificationListener):
757         (WTR::AccessibilityUIElement::removeNotificationListener):
758         (WTR::AccessibilityUIElement::isFocusable):
759         (WTR::AccessibilityUIElement::isSelectable):
760         (WTR::AccessibilityUIElement::isMultiSelectable):
761         (WTR::AccessibilityUIElement::isVisible):
762         (WTR::AccessibilityUIElement::isOffScreen):
763         (WTR::AccessibilityUIElement::isCollapsed):
764         (WTR::AccessibilityUIElement::isIgnored):
765         (WTR::AccessibilityUIElement::hasPopup):
766         (WTR::AccessibilityUIElement::takeFocus):
767         (WTR::AccessibilityUIElement::takeSelection):
768         (WTR::AccessibilityUIElement::addSelection):
769         (WTR::AccessibilityUIElement::removeSelection):
770         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
771         (WTR::AccessibilityUIElement::textMarkerRangeLength):
772         (WTR::AccessibilityUIElement::previousTextMarker):
773         (WTR::AccessibilityUIElement::nextTextMarker):
774         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
775         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
776         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
777         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
778         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
779         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
780         (WTR::AccessibilityUIElement::textMarkerForPoint):
781         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
782         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
783         (WTR::AccessibilityUIElement::indexForTextMarker):
784         (WTR::AccessibilityUIElement::isTextMarkerValid):
785         (WTR::AccessibilityUIElement::textMarkerForIndex):
786         (WTR::AccessibilityUIElement::startTextMarker):
787         (WTR::AccessibilityUIElement::endTextMarker):
788         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
789         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
790         (WTR::AccessibilityUIElement::pathDescription):
791         (WTR::AccessibilityUIElement::supportedActions):
792         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
793         (WTR::activateFonts):
794         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
795         (WTR::EventSenderProxy::EventSenderProxy):
796         (WTR::EventSenderProxy::~EventSenderProxy):
797         (WTR::EventSenderProxy::updateClickCountForButton):
798         (WTR::EventSenderProxy::mouseDown):
799         (WTR::EventSenderProxy::mouseUp):
800         (WTR::EventSenderProxy::mouseMoveTo):
801         (WTR::EventSenderProxy::leapForward):
802         (WTR::EventSenderProxy::keyDown):
803         (WTR::EventSenderProxy::mouseScrollBy):
804         (WTR::EventSenderProxy::continuousMouseScrollBy):
805         (WTR::EventSenderProxy::addTouchPoint):
806         (WTR::EventSenderProxy::updateTouchPoint):
807         (WTR::EventSenderProxy::setTouchModifier):
808         (WTR::EventSenderProxy::setTouchPointRadius):
809         (WTR::EventSenderProxy::touchStart):
810         (WTR::EventSenderProxy::touchMove):
811         (WTR::EventSenderProxy::touchEnd):
812         (WTR::EventSenderProxy::touchCancel):
813         (WTR::EventSenderProxy::clearTouchPoints):
814         (WTR::EventSenderProxy::releaseTouchPoint):
815         (WTR::EventSenderProxy::cancelTouchPoint):
816         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
817         (WTR::InjectedBundle::platformInitialize):
818         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
819         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
820         * WebKitTestRunner/Makefile:
821         * WebKitTestRunner/TestController.cpp:
822         (WTR::TestController::initialize):
823         * WebKitTestRunner/TestController.h:
824         * WebKitTestRunner/TestInvocation.cpp:
825         (WTR::TestInvocation::invoke):
826         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
827         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
828         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
829         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
830         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
831         (-[AppDelegate applicationWillResignActive:]):
832         (-[AppDelegate applicationDidEnterBackground:]):
833         (-[AppDelegate applicationWillEnterForeground:]):
834         (-[AppDelegate applicationDidBecomeActive:]):
835         (-[AppDelegate applicationWillTerminate:]):
836         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
837         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
838         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
839         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
840         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
841         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
842         (main):
843         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
844         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
845         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
846         (-[WebKitTestRunnerAppTests setUp]):
847         (-[WebKitTestRunnerAppTests tearDown]):
848         (-[WebKitTestRunnerAppTests testExample]):
849         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
850         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
851         * WebKitTestRunner/cg/TestInvocationCG.cpp:
852         * WebKitTestRunner/iOS.xcconfig: Added.
853         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
854         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
855         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
856         (-[WebKitTestRunnerWindow isKeyWindow]):
857         (-[WebKitTestRunnerWindow setFrameOrigin:]):
858         (-[WebKitTestRunnerWindow setFrame:]):
859         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
860         (-[WebKitTestRunnerWindow backingScaleFactor]):
861         (WTR::PlatformWebView::PlatformWebView):
862         (WTR::PlatformWebView::resizeTo):
863         (WTR::PlatformWebView::~PlatformWebView):
864         (WTR::PlatformWebView::page):
865         (WTR::PlatformWebView::focus):
866         (WTR::PlatformWebView::windowFrame):
867         (WTR::PlatformWebView::setWindowFrame):
868         (WTR::PlatformWebView::didInitializeClients):
869         (WTR::PlatformWebView::addChromeInputField):
870         (WTR::PlatformWebView::removeChromeInputField):
871         (WTR::PlatformWebView::makeWebViewFirstResponder):
872         (WTR::PlatformWebView::windowSnapshotImage):
873         (WTR::PlatformWebView::viewSupportsOptions):
874         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
875         (WTR::TestController::notifyDone):
876         (WTR::TestController::platformInitialize):
877         (WTR::TestController::platformDestroy):
878         (WTR::TestController::initializeInjectedBundlePath):
879         (WTR::TestController::initializeTestPluginDirectory):
880         (WTR::TestController::platformRunUntil):
881         (WTR::TestController::platformInitializeContext):
882         (WTR::TestController::runModal):
883         (WTR::TestController::platformLibraryPathForTesting):
884         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
885         (createCFURLResponseFromResponseData):
886         (supportedNonImageMIMETypes):
887         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
888         (-[WebKitTestRunnerApp _runTestController]):
889         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
890         (main):
891
892 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
893
894         [GTK] Put cache files in XDG_CACHE_HOME
895         https://bugs.webkit.org/show_bug.cgi?id=123458
896
897         Reviewed by Martin Robinson.
898
899         * GtkLauncher/main.c:
900         (createBrowser):
901
902 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
903
904         Remove CSS Custom Filters code and tests
905         https://bugs.webkit.org/show_bug.cgi?id=127382
906
907         Reviewed by Simon Fraser.
908
909         * DumpRenderTree/gtk/DumpRenderTree.cpp:
910         (resetDefaultsToConsistentValues):
911         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
912         (TestRunner::overridePreference):
913
914 2014-01-23  Tim Horton  <timothy_horton@apple.com>
915
916         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
917         https://bugs.webkit.org/show_bug.cgi?id=127415
918         <rdar://problem/12482452>
919
920         Reviewed by Sam Weinig.
921
922         Adopt the new page loader client plugin load callback.
923
924         * WebKitTestRunner/TestController.cpp:
925         (WTR::TestController::createWebViewWithOptions):
926         (WTR::TestController::pluginLoadPolicy):
927         * WebKitTestRunner/TestController.h:
928
929 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
930
931         [Curl] There is no way to specify cache folder.
932         https://bugs.webkit.org/show_bug.cgi?id=125028
933
934         Reviewed by Brent Fulgham.
935
936         Enable disc cache in WinLauncher by setting cache folder location.
937
938         * WinLauncher/WinLauncher.cpp:
939         (getAppDataFolder): Added function to get app data folder.
940         (setCacheFolder): Added function to set cache folder.
941         (createCrashReport): Use new getAppDataFolder function.
942         (wWinMain): Use function setCacheFolder to set cache folder location.
943
944 2014-01-23  Daniel Bates  <dabates@apple.com>
945
946         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
947         https://bugs.webkit.org/show_bug.cgi?id=127379
948
949         Reviewed by Simon Fraser.
950
951         Teach build-webkit to recognize --sdk=X.
952
953         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
954         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
955         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
956         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
957
958         * Scripts/webkitdirs.pm:
959         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
960         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
961         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
962
963 2014-01-23  Commit Queue  <commit-queue@webkit.org>
964
965         Unreviewed, rolling out r162612.
966         http://trac.webkit.org/changeset/162612
967         https://bugs.webkit.org/show_bug.cgi?id=127488
968
969         broke the build (Requested by mhahnenberg on #webkit).
970
971         * Scripts/build-jsc:
972         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
973         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
974         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
975         * jsc-cli/jsc-cli/JSModule.h: Removed.
976         * jsc-cli/jsc-cli/JSModule.m: Removed.
977         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
978         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
979         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
980         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
981         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
982         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
983         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
984         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
985         * jsc-cli/jsc-cli/main.m: Removed.
986
987 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
988
989         Basic framework for a modern jsc CLI
990         https://bugs.webkit.org/show_bug.cgi?id=127435
991
992         Reviewed by Geoffrey Garen.
993
994         The most basic components of a modern jsc command line interface consist of the following:
995
996         - A simple REPL to enter commands and receive results
997         - The ability to define a module (which consists of various internal methods as well as a 
998           set of externally visible methods)
999         - The ability to load other modules at runtime
1000         - The ability to interact with the underlying platform to perform various "privileged" 
1001           functions (e.g. opening files, printing to the stdout, etc.)
1002         
1003         The basic architecture will look something like the following:
1004         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
1005           on the main thread and start a secondary thread with a run loop to handle various inputs 
1006           from the REPL thread.
1007         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
1008           it might transitively load) within the run loop on the secondary thread while the main 
1009           thread blocks until it has completed.
1010
1011         * Scripts/build-jsc:
1012         * jsc-cli: Added.
1013         * jsc-cli/jsc-cli: Added.
1014         * jsc-cli/jsc-cli.xcodeproj: Added.
1015         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
1016         * jsc-cli/jsc-cli/CLIInstance.h: Added.
1017         * jsc-cli/jsc-cli/CLIInstance.m: Added.
1018         (-[CLIInstance init]):
1019         (-[CLIInstance loadFile:]):
1020         (-[CLIInstance run]):
1021         * jsc-cli/jsc-cli/JSModule.h: Added.
1022         * jsc-cli/jsc-cli/JSModule.m: Added.
1023         (coreModules):
1024         (isCoreModule):
1025         (classForModule):
1026         (coreModuleFullPath):
1027         (resolveModuleAsFile):
1028         (resolveModuleAsDirectory):
1029         (nodeModulePaths):
1030         (resolveAsNodeModule):
1031         (+[JSModule resolve:atPath:]):
1032         (globalModuleCache):
1033         (isCached):
1034         (cachedModule):
1035         (cacheModule):
1036         (+[JSModule require:atPath:]):
1037         (+[JSModule require:atPath:inContext:]):
1038         (-[JSModule platformObjectInContext:]):
1039         (-[JSModule initWithId:filename:context:]):
1040         (-[JSModule dealloc]):
1041         (-[JSModule didStartLoading]):
1042         (-[JSModule didFinishLoading]):
1043         (-[JSModule require:]):
1044         (-[JSModule exports]):
1045         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
1046         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
1047         (jsThreadMain):
1048         (+[JSRunLoopThread threadMain]):
1049         (-[JSRunLoopThread initWithFiles:andContext:]):
1050         (-[JSRunLoopThread startRunLoop]):
1051         (-[JSRunLoopThread start]):
1052         (-[JSRunLoopThread join]):
1053         (-[JSRunLoopThread didReceiveInput:]):
1054         (-[JSRunLoopThread performCallback:withError:]):
1055         (-[JSRunLoopThread performCallback:withArguments:]):
1056         (-[JSRunLoopThread didFinishRunLoopInitialization]):
1057         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
1058         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
1059         (-[ReadEvalPrintLoop initWithJSThread:]):
1060         (prompt):
1061         (escapeStringForOutput):
1062         (-[ReadEvalPrintLoop processNextInput]):
1063         (-[ReadEvalPrintLoop run]):
1064         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
1065         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
1066         (+[RunLoopThread threadMain]):
1067         (-[RunLoopThread init]):
1068         (-[RunLoopThread dealloc]):
1069         (-[RunLoopThread didFinishRunLoopInitialization]):
1070         (-[RunLoopThread start]):
1071         (-[RunLoopThread join]):
1072         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
1073         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
1074         (scriptInputSourceScheduleRoutine):
1075         (scriptInputSourcePerformRoutine):
1076         (scriptInputSourceCancelRoutine):
1077         (-[ScriptInputSource initWithContext:]):
1078         (-[ScriptInputSource dealloc]):
1079         (-[ScriptInputSource addToCurrentRunLoop]):
1080         (-[ScriptInputSource removeFromRemoteRunLoop]):
1081         (-[ScriptInputSource didReceiveScript:]):
1082         (-[ScriptInputSource didReceiveSignal]):
1083         (-[ScriptInputSource runScriptRemotely:]):
1084         (-[ScriptInputSource finishAsyncCallback:withResult:]):
1085         * jsc-cli/jsc-cli/main.m: Added.
1086         (main):
1087
1088 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
1089
1090         Remove a FIXME comment that is already fixed.
1091         https://bugs.webkit.org/show_bug.cgi?id=127468
1092
1093         Reviewed by Csaba Osztrogonác.
1094
1095         * Scripts/webkitpy/style/filereader.py:
1096         (TextFileReader.__init__):
1097
1098 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1099
1100         [GLIB] Use GUniquePtr instead of GOwnPtr
1101         https://bugs.webkit.org/show_bug.cgi?id=127431
1102
1103         Reviewed by Martin Robinson.
1104
1105         GUniquePtr is a template alias of std::unique_ptr with a custom
1106         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
1107         where the output pointer is needed, but it will also be replaced soon.
1108
1109         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1110         (printAccessibilityEvent):
1111         (axObjectEventListener):
1112         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1113         (indexRangeInTable):
1114         (AccessibilityUIElement::role):
1115         (AccessibilityUIElement::title):
1116         (AccessibilityUIElement::description):
1117         (AccessibilityUIElement::stringValue):
1118         (AccessibilityUIElement::language):
1119         (AccessibilityUIElement::lineForIndex):
1120         (AccessibilityUIElement::selectedTextRange):
1121         (AccessibilityUIElement::url):
1122         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
1123         (AccessibilityController::accessibleElementById):
1124         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1125         (AccessibilityController::accessibleElementById):
1126         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1127         (getOutputDir):
1128         (getFontsPath):
1129         (initializeFonts):
1130         (dumpFramesAsText):
1131         (compareHistoryItems):
1132         (dumpHistoryItem):
1133         (soupURIToStringPreservingPassword):
1134         (resetDefaultsToConsistentValues):
1135         (temporaryDatabaseDirectory):
1136         (webViewTitleChanged):
1137         (webFrameLoadStatusNotified):
1138         (pathFromSoupURI):
1139         (convertWebResourceToURLPath):
1140         (urlSuitableForTestResult):
1141         (descriptionSuitableForTestResult):
1142         (willSendRequestCallback):
1143         (frameLoadEventCallback):
1144         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1145         (dumpNodePath):
1146         (dumpRange):
1147         (shouldApplyStyle):
1148         * DumpRenderTree/gtk/EventSender.cpp:
1149         (contextClickCallback):
1150         (beginDragWithFilesCallback):
1151         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1152         (TestRunner::pathToLocalResource):
1153         (TestRunner::queueLoad):
1154         (TestRunner::removeOriginAccessWhitelistEntry):
1155         (TestRunner::setMockGeolocationPositionUnavailableError):
1156         (TestRunner::setIconDatabaseEnabled):
1157         (TestRunner::findString):
1158         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1159         (TestRunner::overridePreference):
1160         (TestRunner::addUserScript):
1161         (TestRunner::addUserStyleSheet):
1162         (TestRunner::setTextDirection):
1163         * DumpRenderTree/gtk/TextInputController.cpp:
1164         (setMarkedTextCallback):
1165         (insertTextCallback):
1166         (doCommandCallback):
1167         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1168         (LoadHTMLStringItem::invoke):
1169         * TestWebKitAPI/PlatformGTK.cmake:
1170         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1171         (WebKitDOMNodeTest::testTagNames):
1172         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1173         (testBackForwardListLimitAndCache):
1174         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1175         (testContextMenuSmartSeparators):
1176         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1177         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1178         (testDownloadLocalFile):
1179         (testDownloadLocalFileError):
1180         (addContentDispositionHTTPHeaderToResponse):
1181         (serverCallback):
1182         (testDownloadRemoteFileError):
1183         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1184         (startTestServer):
1185         (testInspectorServerPageList):
1186         (openRemoteDebuggingSession):
1187         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1188         (testPrintOperationPrint):
1189         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1190         (addCacheHTTPHeadersToResponse):
1191         (serverCallback):
1192         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1193         (httpsServerCallback):
1194         (httpServerCallback):
1195         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1196         (testWebViewJavaScriptDialogs):
1197         (testWebViewWindowProperties):
1198         (testWebViewFileChooserRequest):
1199         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1200         (testWebExtensionWindowObjectCleared):
1201         (testWebExtensionIsolatedWorld):
1202         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1203         (startTestServer):
1204         (checkAtspiAccessible):
1205         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1206         (serverCallback):
1207         (testClearDatabase):
1208         (testGetFaviconURI):
1209         (webkitFaviconDatabaseFinalizedCallback):
1210         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1211         (testWebContextGetPlugins):
1212         (testWebContextURIScheme):
1213         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1214         (testWebViewRunJavaScript):
1215         (testWebViewMode):
1216         (testWebViewPageVisibility):
1217         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
1218         (isStyleSheetInjectedForURLAtPath):
1219         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1220         (testWebViewEditorCutCopyPasteNonEditable):
1221         (testWebViewEditorCutCopyPasteEditable):
1222         (testWebViewEditorSelectAllNonEditable):
1223         (testWebViewEditorSelectAllEditable):
1224         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1225         (sendRequestCallback):
1226         (methodCallCallback):
1227         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1228         (TestWebKitAPI::Util::createInjectedBundlePath):
1229         (TestWebKitAPI::Util::createURLForResource):
1230         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1231         (TestWebKitAPI::doKeyStroke):
1232         (TestWebKitAPI::doMouseButtonEvent):
1233         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1234         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1235         (loadFailedCallback):
1236         (LoadTrackingTest::loadURI):
1237         (LoadTrackingTest::loadHtml):
1238         (LoadTrackingTest::loadPlainText):
1239         (LoadTrackingTest::loadRequest):
1240         (LoadTrackingTest::reload):
1241         (LoadTrackingTest::goBack):
1242         (LoadTrackingTest::goForward):
1243         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1244         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1245         (registerGResource):
1246         (removeNonEmptyDirectory):
1247         (main):
1248         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1249         (Test::getWebKit1TestResoucesDir):
1250         (Test::getResourcesDir):
1251         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1252         (WebKitTestBus::run):
1253         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1254         (WebKitTestServer::WebKitTestServer):
1255         (WebKitTestServer::getURIForPath):
1256         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1257         (WebProcessTestRunner::runTest):
1258         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1259         (resourceGetDataCallback):
1260         (WebViewTest::mainResourceData):
1261         (WebViewTest::mouseMoveTo):
1262         (WebViewTest::keyStroke):
1263         (WebViewTest::doMouseButtonEvent):
1264         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1265         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1266         (WTR::AccessibilityController::accessibleElementById):
1267         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1268         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1269         (WTR::AccessibilityUIElement::role):
1270         (WTR::AccessibilityUIElement::title):
1271         (WTR::AccessibilityUIElement::description):
1272         (WTR::AccessibilityUIElement::stringValue):
1273         (WTR::AccessibilityUIElement::language):
1274         (WTR::AccessibilityUIElement::lineForIndex):
1275         (WTR::AccessibilityUIElement::selectedTextRange):
1276         (WTR::AccessibilityUIElement::url):
1277         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1278         (WTR::getOutputDir):
1279         (WTR::getFontsPath):
1280         (WTR::initializeFontConfigSetting):
1281         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1282         (WTR::topLevelPath):
1283         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1284         (WTR::TestRunner::pathToLocalResource):
1285         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1286         (WTR::TestController::initializeInjectedBundlePath):
1287         (WTR::TestController::initializeTestPluginDirectory):
1288
1289 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
1290
1291         [GTK] [CMake] run-webkit-tests should support the CMake build
1292         https://bugs.webkit.org/show_bug.cgi?id=126503
1293
1294         Reviewed by Daniel Bates.
1295
1296         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
1297         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
1298
1299         * Scripts/run-launcher: Work properly with the gtkcmake flag.
1300         * Scripts/webkitpy/port/gtk.py:
1301         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
1302         file to detect a CMake build.
1303         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
1304         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
1305         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
1306         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
1307         (GtkPort._path_to_driver): Use the new helper.
1308         (GtkPort._path_to_image_diff): Use the new helper.
1309         (GtkPort._path_to_webcore_library): Use the new helper.
1310         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
1311
1312 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
1313
1314         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
1315         https://bugs.webkit.org/show_bug.cgi?id=127417
1316
1317         Reviewed by Gyuyoung Kim.
1318
1319         * EWebLauncher/main.c:
1320         (on_key_down): Removed shortcut to test pre render.
1321
1322 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
1323
1324         Remove CSS3_TEXT_DECORATION define
1325         https://bugs.webkit.org/show_bug.cgi?id=127333
1326
1327         This is required for unprefixing the text-decoration-* CSS properties.
1328
1329         Reviewed by Simon Fraser.
1330
1331         * Configurations/FeatureDefines.xcconfig:
1332
1333 2014-01-22  Andy Estes  <aestes@apple.com>
1334
1335         [iOS] Prepare for upstreaming DumpRenderTree changes
1336         https://bugs.webkit.org/show_bug.cgi?id=127412
1337
1338         Reviewed by Simon Fraser.
1339
1340         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
1341         an application bundle. Instead of upstreaming a separate target for the
1342         app that duplicates the 'Compile Sources' phase of the tool, separate
1343         out the compilation into a static library target that both the
1344         command-line tool and the app can link against. Also, perform some
1345         unrelated cleanup.
1346
1347         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
1348         project file format from 2.4- to 3.2-compatible. Removed the
1349         'Copy Headers' build phase and removed all files from the
1350         'Compile Sources' build phase of DumpRenderTree. Added some files that
1351         were missing from the project. Created a 'DumpRenderTree (Library)'
1352         target for building the static library and made the 'DumpRenderTree'
1353         target depend on it. Added a 'Compile Sources' build phase to this
1354         target that builds the same files the DumpRenderTree target used to.
1355         Created DumpRenderTreeMain.mm as the only source file of the
1356         DumpRenderTree target, since targets won't link a binary without at
1357         least one source file. Made DumpRenderTree (Library) use
1358         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
1359         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
1360         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
1361         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
1362         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
1363         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
1364         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
1365         This is needed to correctly link a static library containing an Objective-C
1366         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
1367         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
1368         * DumpRenderTree/mac/DumpRenderTree.mm:
1369         (DumpRenderTreeMain): Renamed from main.
1370         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
1371         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
1372         (main): Called DumpRenderTreeMain from main.
1373
1374 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
1375
1376         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
1377         https://bugs.webkit.org/show_bug.cgi?id=127073
1378
1379         Reviewed by Daniel Bates.
1380
1381         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
1382         the new isCMakeBuild conditional. This allows us to share more code between ports.
1383         Pass the build arguments to the removeCMakeCache function.
1384         * Scripts/webkitdirs.pm:
1385         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
1386         because it's now shared with the CMake build.
1387         (cachedArgumentFileOutOfDate): Renamed.
1388         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
1389         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
1390         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
1391         as well as checking if build-webkit has been run with different arguments.
1392         (removeCMakeCache): Call shouldRemoveCMakeCache now.
1393         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
1394         (isCMakeBuild): Added.
1395
1396 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1397
1398         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
1399         https://bugs.webkit.org/show_bug.cgi?id=127119
1400
1401         Reviewed by Mario Sanchez Prada.
1402
1403         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
1404
1405         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1406         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1407         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1408         (resetDefaultsToConsistentValues):
1409         (webViewWindowObjectCleared):
1410         (main):
1411         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1412         (WTR::AccessibilityController::platformName):
1413         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1414         (WTR::AccessibilityUIElement::isIndeterminate):
1415
1416 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1417
1418
1419         [GTK] Add GUniquePtr
1420         https://bugs.webkit.org/show_bug.cgi?id=127170
1421
1422         Reviewed by Gustavo Noronha Silva.
1423
1424         Add unit tests for GUniquePtr.
1425
1426         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
1427         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
1428         (log):
1429         (takeLogStr):
1430         (TestWebKitAPI::TEST):
1431
1432 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
1433
1434         Remove Nix files from Tools
1435         https://bugs.webkit.org/show_bug.cgi?id=127418
1436
1437         Reviewed by Csaba Osztrogonác.
1438
1439         * Scripts/build-webkit:
1440         * Scripts/update-webkit-libs-jhbuild:
1441         * Scripts/webkitdirs.pm:
1442         (determineArchitecture):
1443         (argumentsForConfiguration):
1444         (jscProductDir):
1445         (builtDylibPathForName):
1446         (isAppleWebKit):
1447         (launcherPath):
1448         (launcherName):
1449         (checkRequiredSystemConfig):
1450         (copyInspectorFrontendFiles):
1451         (jhbuildWrapperPrefixIfNeeded):
1452         (buildCMakeProjectOrExit):
1453         (cmakeBasedPortName):
1454         * Scripts/webkitpy/common/config/ports.py:
1455         (DeprecatedPort.port):
1456         (EflWK2Port.build_webkit_command):
1457         * Scripts/webkitpy/port/factory.py:
1458         (platform_options):
1459         (PortFactory):
1460         * Scripts/webkitpy/port/nix.py: Removed.
1461         * Scripts/webkitpy/port/nix_unittest.py: Removed.
1462
1463 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
1464
1465         Add Ian and Ricky to the contributor list
1466
1467         * Scripts/webkitpy/common/config/contributors.json:
1468         I am too old to remember all those email addresses :)
1469
1470 2014-01-21  David Farler  <dfarler@apple.com>
1471
1472         Upstream package-root for iOS
1473
1474         Reviewed by Daniel bates.
1475
1476         * Scripts/package-root: Added.
1477         (usage):
1478         * Scripts/webkitdirs.pm:
1479         (XcodeSDKPath): Added function.
1480
1481 2014-01-21  Daniel Bates  <dabates@apple.com>
1482
1483         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
1484         https://bugs.webkit.org/show_bug.cgi?id=127368
1485
1486         Reviewed by Tim Horton.
1487
1488         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
1489         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
1490         Tools.
1491
1492         * Makefile:
1493
1494 2014-01-21  Daniel Bates  <dabates@apple.com>
1495
1496         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
1497         https://bugs.webkit.org/show_bug.cgi?id=127364
1498
1499         Reviewed by Simon Fraser.
1500
1501         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
1502         projects fail to build because we need to upstream the relevant iOS changes.
1503         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
1504         aren't building TestWebKitAPI.
1505
1506         * Scripts/build-webkit:
1507
1508 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1509
1510         Unreviewed, remove myself from some watchlist entries.
1511
1512         * Scripts/webkitpy/common/config/watchlist:
1513
1514 2014-01-21  Zalan Bujtas  <zalan@apple.com>
1515
1516         Use 64 as the default value for the subpixel denominator.
1517
1518         Reviewed by Simon Fraser.
1519
1520         * lldb/lldb_webkit.py:
1521         (WebCoreLayoutUnitProvider.to_string):
1522
1523 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
1524
1525         [GTK] Fix a c++11 compliance issue for fontconfig
1526         https://bugs.webkit.org/show_bug.cgi?id=127283
1527
1528         Reviewed by Martin Robinson.
1529
1530         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
1531         hotfix until bumping fontconfig up.
1532
1533         * gtk/jhbuild.modules:
1534         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
1535
1536 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1537
1538         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
1539         like run_webkit_test does
1540         https://bugs.webkit.org/show_bug.cgi?id=127349
1541
1542         Reviewed by Csaba Osztrogonác.
1543
1544         * Scripts/run-jsc-stress-tests:
1545
1546 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
1547
1548         [GTK] Allow passing extra data to web extensions
1549         https://bugs.webkit.org/show_bug.cgi?id=125990
1550
1551         Reviewed by Carlos Garcia Campos.
1552
1553         Allow passing additional information to the injected bundle. On top
1554         of the string containing the path to the web extensions directory,
1555         a GVariant can be set with additional data using
1556         webkit_web_context_set_web_extensions_initialization_user_data().
1557         Also, a new initialize-web-extensions signal is emitted before
1558         launching a new WebProcess to allow setting different user data
1559         for each process. The GVariant is serialized as a string, passed
1560         to the injected bundle, and the injected bundle deserializes back
1561         the data, which is passed to web extensions which define the
1562         webkit_web_extension_initialize_with_user_data() function (for
1563         backwards compatibility, webkit_web_extension_initialize() is
1564         used as a fallback.)
1565
1566         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1567         (initializeWebExtensions): Handles the initialize-web-extensions
1568         signal, and sets the web extensions directory and the initialization
1569         user data.
1570         (testWebExtensionInitializationUserData): New test case for checking
1571         the user data passed on initialization to web extensions.
1572         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1573         (methodCallCallback): Added implementation for the
1574         GetInitializationUserData D-Bus method, used by
1575         testWebExtensionInitializationUserData().
1576         (webkit_web_extension_initialize_with_user_data): Define the
1577         initialization function with the additional user data parameter.
1578
1579 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
1580
1581         Change my email address in contributors.json.
1582
1583         Unreviewed.
1584
1585         * Scripts/webkitpy/common/config/contributors.json:
1586
1587 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
1588
1589         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
1590         https://bugs.webkit.org/show_bug.cgi?id=127291
1591
1592         Reviewed by Mario Sanchez Prada.
1593
1594         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
1595
1596         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1597         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1598         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1599         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1600
1601 2014-01-20  Zalan Bujtas  <zalan@apple.com>
1602
1603         Force float division when calculating CSS px value.
1604
1605         Reviewed by Simon Fraser.
1606
1607         Note that in Python 3, this is the default behavior.
1608
1609         * lldb/lldb_webkit.py:
1610         (WebCoreLayoutUnitProvider.to_string):
1611
1612 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1613
1614         build.webkit.org/dashboard should display information about patches in EWS
1615         https://bugs.webkit.org/show_bug.cgi?id=127006
1616
1617         Reviewed by Ryosuke Niwa.
1618
1619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
1621         (Bugzilla.prototype.detailsURLForAttachment):
1622         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
1623         which is needed when one wants to do something with a patch EWS is stuck on.
1624
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1626         Create a Bugzilla instance.
1627
1628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1629         (EWS.prototype.jsonQueueLengthURL):
1630         (EWS.prototype.jsonQueueStatusURL):
1631         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
1632
1633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1634         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
1635         of second guessing.
1636         (EWSQueue.prototype.get chartsPageURL): Added.
1637         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
1638         additional data already loaded (it's reset with every update).
1639         (EWSQueue.prototype.get patches): Get patch queue.
1640         (EWSQueue.prototype.get bots): Get bots.
1641         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
1642         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
1643
1644         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1645         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
1646         in the queue.
1647         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
1648         (EWSQueueView.prototype.addTextToRow): Ditto.
1649         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
1650         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
1651         (EWSQueueView.prototype._addDividerToPopover): Ditto.
1652         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
1653         relative string.
1654         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
1655         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
1656         it when done.
1657
1658         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1659         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
1660         Changed a few difficult to read padding styles to padding-left.
1661
1662 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1663
1664         Fix webkitpy tests.
1665
1666         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
1667         Added a mock implementation, as we now call this function.
1668
1669 2014-01-20  Darin Adler  <darin@apple.com>
1670
1671         Update style checker and tests to deal with override instead of OVERRIDE
1672         https://bugs.webkit.org/show_bug.cgi?id=127175
1673
1674         Reviewed by Anders Carlsson.
1675
1676         * Scripts/webkitpy/style/checkers/cpp.py:
1677         (check_braces): Use override instead of OVERRIDE.
1678         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1679         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
1680
1681 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1682
1683         EWS should provide better information to Dashboard via JSON
1684         https://bugs.webkit.org/show_bug.cgi?id=127265
1685
1686         Reviewed by Ryosuke Niwa.
1687
1688         * QueueStatusServer/app.yaml: Updated version.
1689
1690         * QueueStatusServer/main.py:
1691         * QueueStatusServer/handlers/queuelengthjson.py:
1692         Added a way to cheaply get only the queue length, which is all the dashboard
1693         needs unless a popover is opened.
1694
1695         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
1696         that we will need. Changed some field names to be more meaningful. Fixed bot listing
1697         to understand that a bot can be reprurposed and used in a different queue.
1698
1699 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1700
1701         Make uploading results to EWS work despite robots.txt
1702         https://bugs.webkit.org/show_bug.cgi?id=127296
1703
1704         Reviewed by Ryosuke Niwa.
1705
1706         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
1707         checking robots.txt.
1708
1709         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
1710         Removed a comment saying that we would want to stop doing this. Not checking
1711         robots.txt is more efficient than checking it.
1712
1713 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
1714
1715         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
1716         https://bugs.webkit.org/show_bug.cgi?id=127214
1717
1718         Reviewed by Gyuyoung Kim.
1719
1720         Followed the changes of API.
1721
1722         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1723         (drtViewAdd):
1724         * EWebLauncher/main.c:
1725         (windowCreate):
1726
1727 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
1728
1729         [EFL][WK2] Add touch events option to MiniBrowser.
1730         https://bugs.webkit.org/show_bug.cgi?id=127262
1731
1732         Reviewed by Gyuyoung Kim.
1733
1734         As a default, touch events are disabled and mouse events are enabled.
1735         If touch events option sets to true, touch events are enabled and mouse
1736         events are disabled.
1737
1738         * MiniBrowser/efl/main.c:
1739         (window_create):
1740         (elm_main):
1741
1742 2014-01-19  Zalan Bujtas  <zalan@apple.com>
1743
1744         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
1745         https://bugs.webkit.org/show_bug.cgi?id=126080
1746
1747         Reviewed by Sam Weinig.
1748
1749         This changes the output of printing LayoutUnits to be in px but it also
1750         preserves the original LayoutUnit value.
1751
1752         This will lead to lldb output like: (and it works even when subpixel is disabled)
1753
1754         (const WebCore::LayoutRect) $0 = {
1755             m_location = { x = 2.25px (144), y = 1px (64)}
1756             m_size = { width = 13.75px (880), height = 20px (1280) }
1757
1758
1759         And gdb output like:
1760
1761         m_frameRect = {
1762             m_location = LayoutPoint(0px (0), 0px(0)),
1763             m_size = LayoutSize(8px (512), 5px (320))
1764         }
1765
1766         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
1767
1768         * gdb/webkit.py:
1769         (WebCoreLayoutUnitPrinter):
1770         (WebCoreLayoutUnitPrinter.__init__):
1771         (WebCoreLayoutUnitPrinter.to_string):
1772         (WebCoreLayoutSizePrinter):
1773         (WebCoreLayoutSizePrinter.__init__):
1774         (WebCoreLayoutSizePrinter.to_string):
1775         (WebCoreLayoutPointPrinter):
1776         (WebCoreLayoutPointPrinter.__init__):
1777         (WebCoreLayoutPointPrinter.to_string):
1778         (add_pretty_printers):
1779         * lldb/lldb_webkit.py:
1780         (__lldb_init_module):
1781         (WebCoreLayoutUnit_SummaryProvider):
1782         (WebCoreLayoutSize_SummaryProvider):
1783         (WebCoreLayoutPoint_SummaryProvider):
1784         (WebCoreLayoutUnitProvider):
1785         (WebCoreLayoutUnitProvider.__init__):
1786         (WebCoreLayoutUnitProvider.to_string):
1787         (WebCoreLayoutSizeProvider):
1788         (WebCoreLayoutSizeProvider.__init__):
1789         (WebCoreLayoutSizeProvider.get_width):
1790         (WebCoreLayoutSizeProvider.get_height):
1791         (WebCoreLayoutPointProvider):
1792         (WebCoreLayoutPointProvider.__init__):
1793         (WebCoreLayoutPointProvider.get_x):
1794         (WebCoreLayoutPointProvider.get_y):
1795
1796 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1797
1798         Add robots.txt to http://webkit-queues.appspot.com
1799         https://bugs.webkit.org/show_bug.cgi?id=127240
1800
1801         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
1802
1803 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1804
1805         Add robots.txt to http://webkit-queues.appspot.com
1806         https://bugs.webkit.org/show_bug.cgi?id=127240
1807
1808         Reviewed by Ryosuke Niwa.
1809
1810         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
1811
1812         * QueueStatusServer/robots.txt: Added.
1813
1814 2014-01-18  Alberto Garcia  <berto@igalia.com>
1815
1816         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
1817         https://bugs.webkit.org/show_bug.cgi?id=127217
1818
1819         Reviewed by Daniel Bates.
1820
1821         The syntax File::Temp->tempdir() was explicitly made invalid
1822         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
1823         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
1824
1825         Use File::Temp::tempdir() instead.
1826
1827         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1828
1829 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1830
1831         build.webkit.org/dashboard should have image diff links in test results popovers
1832         https://bugs.webkit.org/show_bug.cgi?id=127188
1833
1834         Reviewed by Timothy Hatcher.
1835
1836         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1837         (Buildbot.prototype.layoutTestImagesURLForIteration):
1838         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
1839         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1840         (BuildbotIteration.prototype.loadLayoutTestResults):
1841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1842         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
1843         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
1844         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1845
1846 2014-01-18  Anders Carlsson  <andersca@apple.com>
1847
1848         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
1849         https://bugs.webkit.org/show_bug.cgi?id=127225
1850
1851         Reviewed by Andreas Kling.
1852
1853         This concludes the removal of over 8.8 million lines of threaded parser code.
1854
1855         * Scripts/webkitperl/FeatureList.pm:
1856
1857 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
1858
1859         build.webkit.org/dashboard should have diff links in test results popovers
1860         https://bugs.webkit.org/show_bug.cgi?id=126986
1861
1862         Reviewed by Tim Horton.
1863
1864         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1865         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
1866         (Buildbot.prototype.layoutTestStderrURLForIteration):
1867         (Buildbot.prototype.layoutTestDiffURLForIteration):
1868         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
1869         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1870         (BuildbotIteration.prototype.loadLayoutTestResults):
1871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1872         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1873
1874 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
1875
1876         Add the bare minimum support for branches to the bot-watchers dashboard
1877         https://bugs.webkit.org/show_bug.cgi?id=127124
1878
1879         This patch simply introduces the notion of branches into the bot-watchers dashboard.
1880         Subsequent patches will build functionality on top of this simple bit of infrastructure.
1881
1882         Reviewed by Timothy Hatcher.
1883
1884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1885         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
1886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1887         Initialize the Dashboard.Branch object
1888
1889 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
1890
1891         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1892         https://bugs.webkit.org/show_bug.cgi?id=127141
1893
1894         Reviewed by Alexey Proskuryakov.
1895
1896         Make sure to reset the notification handler each time.
1897
1898         * DumpRenderTree/AccessibilityController.cpp:
1899         (AccessibilityController::resetToConsistentState):
1900         * DumpRenderTree/AccessibilityController.h:
1901         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1902         (AccessibilityController::platformResetToConsistentState):
1903         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1904         (AccessibilityController::platformResetToConsistentState):
1905         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1906         (AccessibilityController::~AccessibilityController):
1907         (AccessibilityController::platformResetToConsistentState):
1908         (AccessibilityController::removeNotificationListener):
1909         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1910         (AccessibilityController::platformResetToConsistentState):
1911
1912 2014-01-17  Alberto Garcia  <berto@igalia.com>
1913
1914         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
1915         https://bugs.webkit.org/show_bug.cgi?id=82329
1916
1917         Reviewed by Carlos Garcia Campos.
1918
1919         Unskip, this is working fine now.
1920
1921         * Scripts/run-gtk-tests:
1922         (TestRunner):
1923
1924 2014-01-17  Alberto Garcia  <berto@igalia.com>
1925
1926         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
1927         https://bugs.webkit.org/show_bug.cgi?id=82328
1928
1929         Reviewed by Carlos Garcia Campos.
1930
1931         This was caused by the icon database being corrupted in the
1932         Release bot. After removing it the test works fine so it can be
1933         run again.
1934
1935         * Scripts/run-gtk-tests:
1936         (TestRunner):
1937
1938 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
1939
1940         Test results popovers at http://build.webkit.org/dashboard should link to stderr
1941         https://bugs.webkit.org/show_bug.cgi?id=126929
1942
1943         Reviewed by Timothy Hatcher.
1944
1945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1946         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
1947         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
1948
1949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1950         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
1951
1952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1953         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1954         Add a link to stderr output if present.
1955
1956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1957         (.test-results-popover .additional-link): Style with light grey (will use the same style
1958         for diff links).
1959
1960 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1961
1962         Automate DoYouEvenBench
1963         https://bugs.webkit.org/show_bug.cgi?id=124497
1964
1965         Reviewed by Geoffrey Garen.
1966
1967         * Scripts/webkitpy/performance_tests/perftest.py:
1968         (PerfTestMetric.__init__): Added the aggregator name as an argument.
1969         (PerfTestMetric.aggregator): Added.
1970         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
1971         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
1972         should be parsed as the metric and the aggregator respectively.
1973         (PerfTest._run_with_driver): Pass in the aggregator name.
1974         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
1975         which generates subtests of subtests within a single test file.
1976
1977         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1978         (test_parse_output_with_subtests_and_total): Added.
1979
1980         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1981         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
1982
1983         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1984         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
1985
1986 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
1987
1988         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1989         https://bugs.webkit.org/show_bug.cgi?id=127141
1990
1991         Reviewed by Alexey Proskuryakov.
1992
1993         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
1994
1995         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1996         (AccessibilityController::~AccessibilityController):
1997
1998 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1999
2000         EWS shouldn't comment on Bugzilla for failing builds or style errors
2001         https://bugs.webkit.org/show_bug.cgi?id=127079
2002
2003         Reviewed by Anders Carlsson.
2004
2005         Since patch authors and reviewers could retrieve this information from bubbles,
2006         we shouldn't spam the Bugzilla with useless comments.
2007
2008         We still post style errors but not python paths we used since it's a pure noise.
2009
2010         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2011         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
2012         * Scripts/webkitpy/tool/commands/queues.py:
2013         (StyleQueue.review_patch):
2014
2015 2014-01-15  Roger Fong  <roger_fong@apple.com>
2016
2017         Add support for handling WebGL load policies.
2018         https://bugs.webkit.org/show_bug.cgi?id=126935
2019         <rdar://problem/15790448>.
2020
2021         Reviewed by Timothy Horton.
2022
2023         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
2024         (WTR::TestController::createWebViewWithOptions):
2025
2026 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2027
2028         Remove workaround for compilers not supporting explicit override control
2029         https://bugs.webkit.org/show_bug.cgi?id=127111
2030
2031         Reviewed by Anders Carlsson.
2032
2033         Now all compilers support explicit override control, this workaround can be removed.
2034
2035         * DumpRenderTree/gtk/fonts/fonts.conf:
2036         * Scripts/do-webcore-rename:
2037         Removed this rename operation from the list of contemplated future renames.
2038         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2039         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2040         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2041         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2042         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2043
2044 2014-01-16  Oliver Hunt  <oliver@apple.com>
2045
2046         Stop run-jsc from consuming stderr output
2047         https://bugs.webkit.org/show_bug.cgi?id=127115
2048
2049         Reviewed by Mark Lam.
2050
2051         Simple patch to make run-jsc easier to deal with
2052
2053         * Scripts/run-jsc:
2054
2055 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2056
2057         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
2058         https://bugs.webkit.org/show_bug.cgi?id=126323
2059
2060         Reviewed by Csaba Osztrogonác.
2061
2062         * gtk/generate-feature-defines-files:
2063
2064 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2065
2066         [EFL][WK2] Implement TestController::setHidden
2067         https://bugs.webkit.org/show_bug.cgi?id=127036
2068
2069         Reviewed by Gyuyoung Kim.
2070
2071         WebKitTestRunner needs TestController::setHidden implementation to
2072         properly handle page visibility API layout tests after r161105.
2073
2074         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2075         (WTR::TestController::setHidden):
2076
2077 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
2078
2079         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
2080         https://bugs.webkit.org/show_bug.cgi?id=127083
2081
2082         Reviewed by Carlos Garcia Campos.
2083
2084         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
2085         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
2086
2087         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
2088         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
2089         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
2090         BrowserWindow object is being finalized, preventing the callback from firing.
2091
2092         * MiniBrowser/gtk/BrowserWindow.c:
2093         (resetEntryProgress):
2094         (webViewLoadProgressChanged):
2095         (browserWindowFinalize):
2096
2097 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
2098
2099         DumpRenderTree doesn't disable web preferences autosave
2100         https://bugs.webkit.org/show_bug.cgi?id=127062
2101
2102         Reviewed by Dan Bernstein.
2103
2104         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
2105         Do it.
2106
2107 2014-01-15  Dean Jackson  <dino@apple.com>
2108
2109         Improve filter-build-webkit, especially for iOS builds
2110         https://bugs.webkit.org/show_bug.cgi?id=81046
2111
2112         Reviewed by Joseph Pecoraro.
2113
2114         Lots of updates to the filtering rules, mostly from the
2115         iOS build output. Other highlights include:
2116         - ignoring escape sequences for color ouput
2117         - detecting escaped spaces in file name regexps
2118
2119         * Scripts/filter-build-webkit:
2120         (shouldIgnoreLine):
2121
2122 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2123
2124         [GTK] Web process sometimes crashes when printing in synchronous mode
2125         https://bugs.webkit.org/show_bug.cgi?id=126979
2126
2127         Reviewed by Gustavo Noronha Silva.
2128
2129         * Scripts/run-gtk-tests:
2130         (TestRunner): Unskip
2131         /webkit2/WebKitPrintOperation/close-after-print.
2132
2133 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
2134
2135         [EFL] Change test font installed path to webkitgtk-font-tests
2136         https://bugs.webkit.org/show_bug.cgi?id=126723
2137
2138         Reviewed by Gyuyoung Kim.
2139
2140         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
2141         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
2142         hard-coded in FontManagement.cpp#105
2143
2144         * DumpRenderTree/PlatformEfl.cmake:
2145         * WebKitTestRunner/PlatformEfl.cmake:
2146         * efl/jhbuild.modules:
2147
2148 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
2149
2150         Make DoYouEvenBench runnable by run-perf-tests
2151         https://bugs.webkit.org/show_bug.cgi?id=127030
2152
2153         Reviewed by Andreas Kling.
2154
2155         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
2156         ":Total" to appear at the end of a test name. We don't do anything with it for now.
2157
2158         * Scripts/webkitpy/performance_tests/perftest.py:
2159         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
2160         to the JSON in a follow up patch for the perf dashboard.
2161         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
2162
2163 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2164
2165         [GTK] UI process crashes when the web process crashes while printing
2166         https://bugs.webkit.org/show_bug.cgi?id=126977
2167
2168         Reviewed by Gustavo Noronha Silva.
2169
2170         Add new test case to check that closing the window right after
2171         printing works. It's skipped for now, because this patch only
2172         fixes the UI process crash, but not the web process one.
2173
2174         * Scripts/run-gtk-tests:
2175         (TestRunner): Skip
2176         /webkit2/WebKitPrintOperation/close-after-print.
2177         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2178         (testPrintOperationPrintPrinter):
2179         (findPrintToFilePrinter):
2180         (testPrintOperationPrint):
2181         (testPrintOperationErrors):
2182         (testPrintOperationCloseAfterPrint):
2183         (beforeAll):
2184
2185 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
2186
2187         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
2188         https://bugs.webkit.org/show_bug.cgi?id=127002
2189
2190         Reviewed by David Kilzer.
2191
2192         * Scripts/webkitdirs.pm:
2193         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
2194
2195 2014-01-14  Commit Queue  <commit-queue@webkit.org>
2196
2197         Unreviewed, rolling out r162000.
2198         http://trac.webkit.org/changeset/162000
2199         https://bugs.webkit.org/show_bug.cgi?id=127009
2200
2201         API versioning is wrong (Requested by rfong on #webkit).
2202
2203         * MiniBrowser/mac/WK2BrowserWindowController.m:
2204         (-[WK2BrowserWindowController awakeFromNib]):
2205         * WebKitTestRunner/TestController.cpp:
2206         (WTR::TestController::createOtherPage):
2207         (WTR::TestController::createWebViewWithOptions):
2208
2209 2014-01-13  Roger Fong  <roger_fong@apple.com>
2210
2211         Add support for handling WebGL load policies.
2212         https://bugs.webkit.org/show_bug.cgi?id=126935
2213         <rdar://problem/15790448>.
2214
2215         Reviewed by Brent Fulgham.
2216
2217         * MiniBrowser/mac/WK2BrowserWindowController.m:
2218         (-[WK2BrowserWindowController awakeFromNib]):
2219         * WebKitTestRunner/TestController.cpp:
2220         (WTR::TestController::createWebViewWithOptions):
2221
2222 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
2223
2224         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
2225         https://bugs.webkit.org/show_bug.cgi?id=120110
2226
2227         Reviewed by Martin Robinson.
2228
2229         Skip the FontConfig settings initialization in WebKitTestRunner if the
2230         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
2231         This is useful when profiling the WebKitTestRunner execution, where at the startup
2232         this step takes considerable amount of time and disturbs the profiling output.
2233
2234         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2235         (WTR::initializeFontConfigSetting):
2236
2237 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
2238
2239         Add ENABLE(WEB_REPLAY) feature flag to the build system
2240         https://bugs.webkit.org/show_bug.cgi?id=126949
2241
2242         Reviewed by Joseph Pecoraro.
2243
2244         * Scripts/webkitperl/FeatureList.pm:
2245
2246 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
2247
2248         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
2249         https://bugs.webkit.org/show_bug.cgi?id=126702
2250
2251         Reviewed by Alexey Proskuryakov.
2252
2253         Resolve regression and remove a FIXME comment that is already fixed.
2254
2255         * Scripts/webkitpy/common/system/filesystem.py:
2256         (FileSystem.open_text_file_for_reading):
2257         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2258         (RealFileSystemTest.test_read_and_write_file):
2259         * Scripts/webkitpy/style/filereader.py:
2260         (TextFileReader._read_lines):
2261         * Scripts/webkitpy/style/filereader_unittest.py:
2262         (TextFileReaderTest.test_count_delete_only_file):
2263         (TextFileReaderTest):
2264         (TextFileReaderTest.test_process_malformed_file):
2265
2266 2014-01-02  Brian Holt  <brian.holt@samsung.com>
2267
2268         [GTK] Parse Valgrind xml leak files
2269         https://bugs.webkit.org/show_bug.cgi?id=119446
2270
2271         Reviewed by Alejandro G. Castro.
2272
2273         Parse the xml files generated by Valgrind to yield useful
2274         information about the memory leaks.
2275
2276         * Scripts/webkitpy/port/gtk.py:
2277         (GtkPort.__init__):
2278         (GtkPort.setup_test_run): Clear the previous output files before new
2279         run.
2280         (GtkPort.print_leaks_summary):
2281
2282         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2283         Parse the xml files generated by Valgrind and summarise leaks
2284         into an easily understandable list.
2285         (get_text_of):
2286         (get_CDATA_of):
2287         (gather_frames):
2288         (ValgrindError):
2289         (ValgrindError.__init__):
2290         (ValgrindError.__str__):
2291         (ValgrindError.unique_string):
2292         (ValgrindError.error_hash):
2293         (ValgrindError.__hash__):
2294         (ValgrindError.__eq__):
2295         (LeakDetectorValgrind):
2296         (LeakDetectorValgrind.__init__):
2297         (LeakDetectorValgrind._parse_leaks_output):
2298         (LeakDetectorValgrind.leaks_files_in_results_directory):
2299         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2300         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2301
2302         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2303         (make_mock_valgrind_output):
2304         (make_mock_incomplete_valgrind_output):
2305         (make_mock_valgrind_results):
2306         (make_mock_valgrind_results_incomplete):
2307         (make_mock_valgrind_results_empty):
2308         (make_mock_valgrind_results_misformatted):
2309         (mock_run_cppfilt_command):
2310         (LeakDetectorValgrindTest):
2311         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2312         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2313         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2314         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2315         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2316         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2317         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2318         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2319
2320 2014-01-13  Lucas Forschler  <lforschler@apple.com>
2321
2322         Update the LLINT CLoop Bot build infrastructure
2323         https://bugs.webkit.org/show_bug.cgi?id=126604
2324         
2325         Unreviewed.
2326         
2327         * BuildSlaveSupport/build.webkit.org-config/config.json:
2328         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2329         (CompileLLINTCLoop):
2330         (RunLLINTCLoopTests):
2331         (BuildAndTestLLINTCLoopFactory):
2332         (BuildAndTestLLINTCLoopFactory.__init__):
2333
2334 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2335
2336         [EFL][WK2] Disable failing API tests
2337         https://bugs.webkit.org/show_bug.cgi?id=126960
2338
2339         Reviewed by Gyuyoung Kim.
2340
2341         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
2342
2343         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2344         (TestWebKitAPI::TEST):
2345
2346 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
2347
2348         Remove wdiff
2349         https://bugs.webkit.org/show_bug.cgi?id=124766
2350
2351         Reviewed by Ryosuke Niwa.
2352
2353         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2354         (ResultsJSONParserTest):
2355         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2356         (TestResultWriter):
2357         (TestResultWriter.create_text_diff_and_write_result):
2358         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2359         (summarize_results):
2360         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2361         (RunTest.test_output_diffs):
2362         * Scripts/webkitpy/port/base.py:
2363         (Port.__init__):
2364         (Port.driver_stop_timeout):
2365         (Port.check_image_diff):
2366         (Port.repository_paths):
2367         (Port._path_to_lighttpd_php):
2368         * Scripts/webkitpy/port/base_unittest.py:
2369         (PortTest.test_default_child_processes):
2370         (PortTest.test_pretty_patch_script_error):
2371         * Scripts/webkitpy/port/port_testcase.py:
2372         (PortTestCase.test_diff_image_crashed):
2373         * Scripts/webkitpy/port/test.py:
2374         (TestPort.operating_system):
2375
2376 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
2377
2378         Build fix for the GTK+ CMake port
2379
2380         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
2381
2382 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2383
2384         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
2385         https://bugs.webkit.org/show_bug.cgi?id=126881
2386
2387         Reviewed by Carlos Garcia Campos.
2388
2389         * MiniBrowser/gtk/BrowserWindow.c:
2390         (browser_window_new):
2391         Explicitly cast GtkWindow** to gpointer* in call to
2392         g_object_add_weak_pointer to avoid compiler warnings.
2393
2394 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2395
2396         Remove parsing of old-run-webkit-tests output from master.cfg
2397         https://bugs.webkit.org/show_bug.cgi?id=126690
2398
2399         Reviewed by Csaba Osztrogonác.
2400
2401         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2402         Removed parsing of ORWT output, as it is not used anymore.
2403         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2404         Updated unit tests accordingly.
2405
2406 2014-01-13  Commit Queue  <commit-queue@webkit.org>
2407
2408         Unreviewed, rolling out r161808.
2409         http://trac.webkit.org/changeset/161808
2410         https://bugs.webkit.org/show_bug.cgi?id=126874
2411
2412         This patch make several files to be always regenerated on
2413         every make (Requested by KaL on #webkit).
2414
2415         * WebKitTestRunner/GNUmakefile.am:
2416
2417 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2418
2419         [GTK] Make MiniBrowser windows non-transient by default
2420         https://bugs.webkit.org/show_bug.cgi?id=126840
2421
2422         Reviewed by Carlos Garcia Campos.
2423
2424         Instead of making new browser windows transient as soon as they are
2425         created, save the pointer to the parent window and set the transient
2426         state later on when handling the "run-as-modal" signal. This makes
2427         it easier to use the MiniBrowser to do tests involving multiple
2428         windows, and will be useful as well when multi-web-process mode is
2429         enabled for the GTK port.
2430
2431         * MiniBrowser/gtk/BrowserWindow.c:
2432         (webViewRunAsModal): Set the parent window using
2433         gtk_window_set_transient_for() using the saved parent
2434         window.
2435         (browser_window_new): Save the parent window using
2436         g_object_set_data() instead of making the new window
2437         transient immediately.
2438
2439 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
2440
2441         [EFL][WK2] Make API tests work again
2442         https://bugs.webkit.org/show_bug.cgi?id=126769
2443
2444         Reviewed by Gyuyoung Kim.
2445
2446         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
2447         [E]WebKit2, respectively, and this causes problems because the logic to find
2448         where WebProcess is to look in the same directory of the running process and
2449         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
2450
2451         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
2452         Gtk port, which allows us to look for WebProcess initially in this directory,
2453         if it's defined.
2454
2455         * TestWebKitAPI/efl/main.cpp:
2456         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
2457
2458 2014-01-12  Daniel Bates  <dabates@apple.com>
2459
2460         [iOS] Fix the build
2461
2462         For now, ensure we build WebKit System Interface before we build WebKit.
2463         We'll remove this constraint and the constraint to build WebKit Additions
2464         in a subsequent commit.
2465
2466         * Scripts/build-webkit:
2467
2468 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2469
2470         Unreviewed. Fix make distcheck.
2471
2472         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
2473         to EXTRA_DIST.
2474
2475 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
2476
2477         --disable-dependency-tracking causes build failure due to missing directories
2478         https://bugs.webkit.org/show_bug.cgi?id=94488
2479
2480         Reviewed by Gustavo Noronha Silva.
2481
2482         Autotools build fix: Ensure output directory existing
2483         before generating DerivedSources. This allows for
2484         --disable-dependency-tracking to be run.
2485
2486
2487         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
2488
2489 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2490
2491         [GTK] Fix return value of WebKitDownload::created-destination
2492         https://bugs.webkit.org/show_bug.cgi?id=126741
2493
2494         Reviewed by Martin Robinson.
2495
2496         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
2497         value of several callbacks.
2498
2499 2014-01-11  Sam Weinig  <sam@webkit.org>
2500
2501         Add support for null StringViews
2502         https://bugs.webkit.org/show_bug.cgi?id=126827
2503
2504         Reviewed by Anders Carlsson.
2505
2506         Add new test for StringView.
2507
2508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2509         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
2510         (TestWebKitAPI::TEST):
2511
2512 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2513
2514         Remove the BlackBerry port from trunk
2515         https://bugs.webkit.org/show_bug.cgi?id=126715
2516
2517         Reviewed by Anders Carlsson.
2518
2519         * DumpRenderTree/DumpRenderTree.h:
2520         * DumpRenderTree/PixelDumpSupport.cpp:
2521
2522 2014-01-10  Daniel Bates  <dabates@apple.com>
2523
2524         [iOS] Fix project build order
2525
2526         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
2527         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
2528         time of writing.
2529
2530         * Scripts/build-webkit:
2531
2532 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2533
2534         Move platformName property from testRunner to accessibilityController
2535         https://bugs.webkit.org/show_bug.cgi?id=126689
2536
2537         Reviewed by Chris Fleizach.
2538
2539         Move the platformName property from the testRunner into
2540         accessibilityController, since this is a concept that has only be
2541         used by accessibility tests since it got added, and also because
2542         the real intention was not to distinguish among "ports" (mac, win,
2543         gtk, efl) but between platforms (atk, mac, win).
2544
2545         This change will be very useful to merge GTK's roles-exposed.html
2546         and Mac's role-subrole-roledescription.html into one single test,
2547         since we will be specifying in the test itself which elements are
2548         supported in which accessibility "platform". In this context,
2549         being able to check accessibilityController.platformName directly
2550         against a list of supported accessibility platforms (e.g. "atk,mac")
2551         will certainly maintain the code cleaner and simpler.
2552
2553         * DumpRenderTree/TestRunner.h:
2554         (TestRunner::platformName): Removed.
2555         * DumpRenderTree/TestRunner.cpp:
2556         (getPlatformNameCallback): Removed.
2557         (TestRunner::staticValues): Removed platformName
2558         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2559         (TestRunner::platformName): Removed.
2560         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2561         (TestRunner::platformName): Removed.
2562         * DumpRenderTree/mac/TestRunnerMac.mm:
2563         (TestRunner::platformName): Removed.
2564         * DumpRenderTree/win/TestRunnerWin.cpp:
2565         (TestRunner::platformName): Removed.
2566
2567         * DumpRenderTree/AccessibilityController.h:
2568         (AccessibilityController::platformName): Added.
2569         * DumpRenderTree/AccessibilityController.cpp:
2570         (getPlatformNameCallback): Added.
2571         (AccessibilityController::getJSClass): Added platformName.
2572         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2573         (AccessibilityController::platformName): Added, returning "atk".
2574         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2575         (AccessibilityController::platformName): Ditto, returning "mac".
2576         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2577         (AccessibilityController::platformName): Ditto, returning "ios".
2578         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2579         (AccessibilityController::platformName): Ditto, returning "win".
2580
2581         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2582         (platformName): Removed.
2583         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2584         (TestRunner::platformName): Removed.
2585         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2586         (TestRunner::platformName): Removed.
2587         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2588         (TestRunner::platformName): Removed.
2589         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2590         (TestRunner::platformName): Removed.
2591         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2592         (TestRunner::platformName): Removed.
2593
2594         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2595         (WTR:AccessibilityController::platformName): Added.
2596         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2597         (platformName): Added.
2598         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2599         (WTR::AccessibilityController::platformName): Added, returning "atk".
2600         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2601         (WTR::AccessibilityController::platformName): Added, returning "mac".
2602
2603 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2604
2605         Remove the BlackBerry port from trunk
2606         https://bugs.webkit.org/show_bug.cgi?id=126715
2607
2608         Reviewed by Anders Carlsson.
2609
2610         * Scripts/webkitpy/common/config/watchlist:
2611
2612 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
2613
2614         Remove the BlackBerry files outside WebCore
2615         https://bugs.webkit.org/show_bug.cgi?id=126715
2616
2617         Reviewed by Anders Carlsson.
2618
2619         * DumpRenderTree/blackberry: Removed.
2620
2621 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
2622
2623         Remove knowledge of Blackberry from build scripts
2624         https://bugs.webkit.org/show_bug.cgi?id=126766
2625
2626         Reviewed by Anders Carlsson.
2627         
2628         Remove isBlackBerry() and references to it, and rmeove
2629         blackberry-related stuff from the watchlist.
2630
2631         * Scripts/build-webkit:
2632         * Scripts/webkit-build-directory:
2633         * Scripts/webkitdirs.pm:
2634         (determineBaseProductDir):
2635         (argumentsForConfiguration):
2636         (builtDylibPathForName):
2637         (isAppleWebKit):
2638         (buildCMakeProjectOrExit):
2639         (cmakeBasedPortArguments):
2640         (cmakeBasedPortName):
2641         * Scripts/webkitperl/FeatureList.pm:
2642         * Scripts/webkitpy/common/config/watchlist:
2643
2644 2014-01-10  Daniel Bates  <dabates@apple.com>
2645
2646         [iOS] Fix up simulator build and enable default features
2647
2648         Rubber-stamped by Joseph Pecoraro.
2649
2650         * Scripts/webkitdirs.pm:
2651         (determineArchitecture):
2652         (determinePassedArchitecture):
2653         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
2654         by default only in iOS).
2655
2656 2014-01-10  Daniel Bates  <dabates@apple.com>
2657
2658         [iOS] Upstream WebCore and Tools miscellaneous changes
2659         https://bugs.webkit.org/show_bug.cgi?id=126698
2660
2661         Reviewed by David Kilzer.
2662
2663         * Scripts/check-for-inappropriate-objc-class-names:
2664         * Scripts/check-for-webkit-framework-include-consistency:
2665
2666 2014-01-09  Dan Bernstein  <mitz@apple.com>
2667
2668         [Cocoa] Promote WKBackForwardList{,Item}.h to public
2669         https://bugs.webkit.org/show_bug.cgi?id=126707
2670
2671         Reviewed by Sam Weinig.
2672
2673         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
2674         left behind in the build products directory after a private header is made public.
2675
2676 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2677
2678         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
2679         https://bugs.webkit.org/show_bug.cgi?id=126686
2680
2681         Reviewed by Martin Robinson.
2682
2683         Test that partial files are not left on disk after a download has
2684         been cancelled after the destination has been decided. To make
2685         sure the download is cancelled after the destination has been
2686         decided and before the operation finishes, we cancel the download
2687         in the destination decided callback, and we use an infinite
2688         resource that writes chunks to the response body and never
2689         completes the body.
2690
2691         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2692         (addContentDispositionHTTPHeaderToResponse): Helper function to
2693         add the Content-Disposition to the response headers.
2694         (writeNextChunkIdle): Write next chunk to response body.
2695         (writeNextChunk): Write next chunk in an idle to avoid flooding
2696         the network with the inifnite resource.
2697         (serverCallback): Add an inifinite resource.
2698         (testDownloadRemoteFileError): Check that partial file is not
2699         present after the download has been cancelled.
2700
2701 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
2702
2703         Move myself to the committers list.
2704
2705         Unreviewed.
2706
2707         * Scripts/webkitpy/common/config/contributors.json:
2708
2709 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2710
2711         [GTK] Unreviewed build fix after r161522.
2712
2713         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
2714
2715 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2716
2717         Missleading style error when mixing system and non-system header include lines.
2718         https://bugs.webkit.org/show_bug.cgi?id=126564
2719
2720         Reviewed by Ryosuke Niwa.
2721
2722         * Scripts/webkitpy/style/checkers/cpp.py:
2723         (check_include_line):
2724         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2725         (OrderOfIncludesTest.test_check_alphabetical_include_order):
2726         (OrderOfIncludesTest.test_public_primary_header):
2727
2728 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2729
2730         [EFL] Unreviewed build fix after r161522.
2731
2732         * TestWebKitAPI/CMakeLists.txt:
2733         * TestWebKitAPI/PlatformEfl.cmake:
2734
2735 2014-01-08  Anders Carlsson  <andersca@apple.com>
2736
2737         Remove WKConnectionRef tests
2738         https://bugs.webkit.org/show_bug.cgi?id=126666
2739
2740         Reviewed by Dan Bernstein.
2741
2742         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
2743         Remove the API tests as a first step towards killing the entire thing.
2744
2745         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2746         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
2747         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
2748
2749 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2750
2751         Unreviewed, rolling out r161512.
2752         http://trac.webkit.org/changeset/161512
2753         https://bugs.webkit.org/show_bug.cgi?id=126655
2754
2755         Broke webkitpy tests (Requested by ap on #webkit).
2756
2757         * Scripts/webkitpy/port/gtk.py:
2758         (GtkPort.__init__):
2759         (GtkPort.setup_test_run):
2760         (GtkPort._port_specific_expectations_files):
2761         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
2762         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
2763
2764 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2765
2766         Unreviewed, rolling out r161517.
2767         http://trac.webkit.org/changeset/161517
2768         https://bugs.webkit.org/show_bug.cgi?id=126659
2769
2770         The fix didn't completely remove the problem and is now
2771         standing in the way of the rollout of the offending patch
2772         (Requested by zdobersek on #webkit).
2773
2774         * Scripts/webkitpy/port/gtk.py:
2775         (GtkPort.__init__):
2776
2777 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2778
2779         Unreviewed. Attempting to fix webkitpy tests after r161512.
2780
2781         * Scripts/webkitpy/port/gtk.py:
2782         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
2783
2784 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2785
2786         [GTK] Parse Valgrind xml leak files
2787         https://bugs.webkit.org/show_bug.cgi?id=119446
2788
2789         Reviewed by Alejandro G. Castro.
2790
2791         Parse the xml files generated by Valgrind to yield useful
2792         information about the memory leaks.
2793
2794         * Scripts/webkitpy/port/gtk.py:
2795         (GtkPort.__init__):
2796         (GtkPort.setup_test_run): Clear the previous output files before new
2797         run.
2798         (GtkPort.print_leaks_summary):
2799
2800         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2801         Parse the xml files generated by Valgrind and summarise leaks
2802         into an easily understandable list.
2803         (get_text_of):
2804         (get_CDATA_of):
2805         (gather_frames):
2806         (ValgrindError):
2807         (ValgrindError.__init__):
2808         (ValgrindError.__str__):
2809         (ValgrindError.unique_string):
2810         (ValgrindError.error_hash):
2811         (ValgrindError.__hash__):
2812         (ValgrindError.__eq__):
2813         (LeakDetectorValgrind):
2814         (LeakDetectorValgrind.__init__):
2815         (LeakDetectorValgrind._parse_leaks_output):
2816         (LeakDetectorValgrind.leaks_files_in_results_directory):
2817         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2818         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2819
2820         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2821         (make_mock_valgrind_output):
2822         (make_mock_incomplete_valgrind_output):
2823         (make_mock_valgrind_results):
2824         (make_mock_valgrind_results_incomplete):
2825         (make_mock_valgrind_results_empty):
2826         (make_mock_valgrind_results_misformatted):
2827         (LeakDetectorValgrindTest):
2828         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2829         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2830         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2831         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2832         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2833         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2834         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2835         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2836
2837 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2838
2839         Unreviewed, rolling out r161427.
2840         http://trac.webkit.org/changeset/161427
2841         https://bugs.webkit.org/show_bug.cgi?id=126645
2842
2843         Emits a stye error on any newly added files (Requested by ap
2844         on #webkit).
2845
2846         * Scripts/webkitpy/style/checkers/cpp.py:
2847         (check_style):
2848         (CppChecker):
2849         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2850         (WebKitStyleTest.test_other):
2851
2852 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2853
2854         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
2855         https://bugs.webkit.org/show_bug.cgi?id=126580
2856
2857         Reviewed by Csaba Osztrogonác.
2858
2859         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2860         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
2861         run-webkit-tests script.
2862         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
2863         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
2864
2865 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2866
2867         Update the list of non-committer u-szeged contributors
2868         https://bugs.webkit.org/show_bug.cgi?id=126640
2869
2870         Reviewed by Csaba Osztrogonác.
2871
2872         * Scripts/webkitpy/common/config/contributors.json:
2873
2874 2014-01-08  Alberto Garcia  <berto@igalia.com>
2875
2876         Fix some compilation warnings
2877         https://bugs.webkit.org/show_bug.cgi?id=126635
2878
2879         Reviewed by Csaba Osztrogonác.
2880
2881         * GtkLauncher/main.c:
2882         (createWindow): This function is not supposed to receive any
2883         parameter, yet we are passing one.
2884
2885 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2886
2887         [GTK][WK2] unskip passing unit tests
2888         https://bugs.webkit.org/show_bug.cgi?id=126637
2889
2890         Reviewed by Carlos Garcia Campos.
2891
2892         Unskip TestResources and TestAuthentication unit tests since they
2893         are passing both under Xvfb and X.
2894
2895         * Scripts/run-gtk-tests:
2896         (TestRunner):
2897
2898 2014-01-08  Alberto Garcia  <berto@igalia.com>
2899
2900         REGRESSION(r160304): [GTK] Disable libtool fast install
2901         https://bugs.webkit.org/show_bug.cgi?id=126381
2902
2903         Reviewed by Gustavo Noronha Silva.
2904
2905         Disable the libtool fast-install mode in developer/test builds.
2906
2907         In this mode binaries are generated ready to be used directly from
2908         the build tree. Otherwise they would need to be relinked when they
2909         are executed, which can take a lot of resources, particularly in
2910         debug builds.
2911
2912         * Scripts/webkitdirs.pm:
2913         (runAutogenForAutotoolsProjectIfNecessary):
2914
2915 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2916
2917         Unreviewed GTK gardening.
2918
2919         * Scripts/run-gtk-tests:
2920         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
2921         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
2922
2923 2014-01-07  Lucas Forschler  <lforschler@apple.com>
2924
2925         Add buildbot infrasctructure for building and testing JSC cloop
2926         https://bugs.webkit.org/show_bug.cgi?id=126604
2927
2928         Reviewed by Geoffrey Garen.
2929
2930         * BuildSlaveSupport/build.webkit.org-config/config.json:
2931         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2932         (CompileCLOOP):
2933         (RunCLOOPTests):
2934         (RunCLOOPTests.countFailures):
2935         (BuildAndTestCLOOP):
2936
2937 2014-01-07  Brian Burg  <bburg@apple.com>
2938
2939         Unreviewed. Add myself as a committer.
2940
2941         * Scripts/webkitpy/common/config/contributors.json:
2942
2943 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2944
2945         Popovers at build.webkit.org/dashboard could have titles
2946         https://bugs.webkit.org/show_bug.cgi?id=126495
2947
2948         Reviewed by Timothy Hatcher.
2949
2950         Added titles to all popovers except for pending revisions one, which I would like
2951         to improve more (probably add an ETA).
2952
2953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2954         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
2955         adding a title to base class.
2956
2957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2958         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
2959         a divider to a separate function.
2960         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
2961         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
2962         title from above function.
2963         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
2964         variable to "content" to match all other code.
2965         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
2966         (BuildbotQueueView.prototype._addDividerToPopover): Added.
2967
2968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2969         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
2970         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
2971         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
2972
2973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2974
2975 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2976
2977         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
2978         https://bugs.webkit.org/show_bug.cgi?id=126472
2979
2980         Reviewed by Timothy Hatcher.
2981
2982         Added a delay when quickly switching to a different popover, making it easier to
2983         move mouse pointer from active element to its popover without accidentally opening
2984         a different popover.
2985
2986         Used this code to add a delay before creating a popover. This doesn't change UI
2987         behavior, as there was alerady a delay before it became visible, but it avoids
2988         flooding buildbot server with http requests when quickly moving the mouse over
2989         dashboard page.
2990
2991         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
2992         Fixed a case where popover could get stuck. If content was updated while fade-out
2993         transition was already in place, the transition was removed for no good reason.
2994
2995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2996         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
2997
2998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
2999         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
3000         popover delay from 1s to 800ms.
3001
3002 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
3003
3004         Improve display of failed builds at build.webkit.org/dashboard
3005         https://bugs.webkit.org/show_bug.cgi?id=126542
3006         <rdar://problem/15753550>
3007
3008         Reviewed by Timothy Hatcher.
3009
3010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3011         Instead of hardcoding step name, look for the first step that failed.
3012         While at it, added a popover with more links. There are multiple, and it's good
3013         to have a choice of which one to look at in each situation.
3014
3015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3016         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
3017         of having failed. Many iterations are interrupted for whatever reason internal to
3018         Buildbot, and these are suppoed to be orange, not red.
3019         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
3020         not only WillRetry ones.
3021         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
3022         actually failed, more likely indicating a problem with code base.
3023         (BuildbotIteration.prototype.get firstFailedStepName):
3024         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
3025         (BuildbotIteration.prototype.get failureLogs): Ditto.
3026         (BuildbotIteration.prototype.update): Store complete results for the failed step.
3027         Not every failure stops the iteration, so we could have multiple failed steps,
3028         but let's see if seeing just the first one will be enough.
3029
3030         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3031         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
3032         terms of successful iterations.
3033         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
3034
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3036         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
3037         terms of successful iterations.
3038
3039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3040         Removed code to create a path to build output, we now take it from results JSON.
3041
3042         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3043         Added styles for the new popover.
3044
3045 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3046
3047         defined constants should use all uppercase names with words separated by underscores.
3048         https://bugs.webkit.org/show_bug.cgi?id=126055
3049
3050         Reviewed by Alexey Proskuryakov.
3051
3052         * Scripts/webkitpy/style/checkers/cpp.py:
3053         (check_style):
3054         (CppChecker):
3055         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3056         (WebKitStyleTest.test_define_constants):
3057
3058 2014-01-07  Brian Holt  <brian.holt@samsung.com>
3059
3060         Unreviewed. Add myself as a committer.
3061
3062         * Scripts/webkitpy/common/config/contributors.json:
3063
3064 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3065
3066         Remove the WinCE buildbot from build.webkit.org
3067         https://bugs.webkit.org/show_bug.cgi?id=126517
3068
3069         Reviewed by Alexey Proskuryakov.
3070
3071         * BuildSlaveSupport/build.webkit.org-config/config.json:
3072         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3073         (appendCustomBuildFlags):
3074
3075 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
3076
3077         [EFL] Change ATK version to 2.11.4
3078         https://bugs.webkit.org/show_bug.cgi?id=126573
3079
3080         Reviewed by Gyuyoung Kim.
3081
3082         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
3083
3084         * efl/jhbuild.modules:
3085
3086 2014-01-07  Alberto Garcia  <berto@igalia.com>
3087
3088         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
3089         https://bugs.webkit.org/show_bug.cgi?id=117275
3090
3091         Reviewed by Carlos Garcia Campos.
3092
3093         If we are not using the internal jhbuild we must not use the
3094         jhbuild-wrapper script, else it will try to download and install
3095         it.
3096
3097         * Scripts/run-launcher:
3098
3099 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
3100
3101         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
3102         https://bugs.webkit.org/show_bug.cgi?id=125855
3103
3104         Reviewed by Mario Sanchez Prada.
3105
3106         Added new function isIndeterminate for testing aria-checked mixed state.
3107         I provided respective, but empty function in mac port. Mac testing it differently.
3108
3109         * DumpRenderTree/AccessibilityUIElement.cpp:
3110         (getIsIndeterminate):
3111         (AccessibilityUIElement::getJSClass):
3112         * DumpRenderTree/AccessibilityUIElement.h:
3113         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3114         (AccessibilityUIElement::isIndeterminate):
3115         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
3116         (AccessibilityUIElement::isIndeterminate):
3117         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
3118         (AccessibilityUIElement::isIndeterminate):
3119         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
3120         (AccessibilityUIElement::isIndeterminate):
3121         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3122         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3123         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3124         (WTR::AccessibilityUIElement::isIndeterminate):
3125         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3126         (WTR::AccessibilityUIElement::isIndeterminate):
3127
3128 2014-01-06  Mark Rowe  <mrowe@apple.com>
3129
3130         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
3131
3132         Reviewed by Ryosuke Niwa.
3133
3134         * DumpRenderTree/mac/DumpRenderTree.mm:
3135         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
3136         with a single case. This avoids the potential for warnings about unhandled cases.
3137         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3138         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
3139
3140 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3141
3142         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
3143         https://bugs.webkit.org/show_bug.cgi?id=126342
3144
3145         Reviewed by Gustavo Noronha Silva.
3146
3147         * CMakeLists.txt: Include the new unit tests subdirectories.
3148         * Scripts/run-gtk-tests: Update to refer to the new build locations.
3149         * Scripts/webkitpy/style/checker.py: Update the style checker.
3150         * Scripts/webkitpy/style/checker_unittest.py:
3151         * TestWebKitAPI/GNUmakefile.am:
3152         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
3153         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
3154         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
3155         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
3156         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
3157         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
3158         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
3159         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
3160         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
3161         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
3162         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
3163         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
3164         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
3165         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
3166         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
3167         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
3168         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
3169         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
3170         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
3171         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
3172         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
3173         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
3174         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
3175         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
3176         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
3177         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
3178         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
3179         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
3180         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
3181         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
3182         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
3183         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
3184         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
3185         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
3186         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
3187         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
3188         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
3189         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
3190         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
3191         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
3192         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
3193         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
3194         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
3195         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
3196         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
3197         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
3198         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
3199         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
3200         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
3201         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
3202         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
3203         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
3204         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
3205         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
3206         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
3207         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
3208         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
3209         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
3210         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
3211         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
3212         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
3213         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
3214         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
3215         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
3216         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
3217         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
3218         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
3219         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
3220         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
3221         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
3222         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
3223         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
3224         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
3225         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
3226         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
3227         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
3228         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
3229         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
3230         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
3231         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
3232         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
3233         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
3234         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
3235         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
3236         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
3237         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
3238         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
3239
3240 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
3241
3242         Gtk and Efl API test results confuse the dashboard
3243         https://bugs.webkit.org/show_bug.cgi?id=126535
3244
3245         Reviewed by Tim Horton.
3246
3247         Added "API tests" step as "platform api tests".
3248
3249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3250         (Buildbot.prototype.platformAPITestResultsURLForIteration):
3251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3252         (BuildbotIteration):
3253         (BuildbotIteration.prototype.update):
3254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3255         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3256         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3257
3258 2014-01-06  Tim Horton  <timothy_horton@apple.com>
3259
3260         build.webkit.org/dashboard should still function if localStorage is disabled
3261         https://bugs.webkit.org/show_bug.cgi?id=126511
3262
3263         Reviewed by Alexey Proskuryakov.
3264
3265         If localStorage is disabled, we should carry on with a warning.
3266
3267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3268         Don't show the gear if localStorage isn't working.
3269
3270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3271         (QueueView.prototype._updateHiddenState):
3272         Bail if localStorage isn't working.
3273
3274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3275         (Settings.prototype.available):
3276
3277 2014-01-02  Roger Fong  <roger_fong@apple.com>
3278
3279         Set VSINSTALLDIR in win ews start script.
3280         https://bugs.webkit.org/show_bug.cgi?id=126407
3281
3282         Reviewed by Brent Fulgham.
3283
3284         * EWSTools/start-queue-win.sh:
3285
3286 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
3287
3288         Adding myself as a reviewer.
3289
3290         Unreviewed.
3291
3292         * Scripts/webkitpy/common/config/contributors.json:
3293
3294 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
3295
3296         Unreviewed. Unbreaking JSC tests after r161328.
3297
3298         * Scripts/webkitdirs.pm:
3299         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
3300         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
3301
3302 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
3303
3304         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
3305         https://bugs.webkit.org/show_bug.cgi?id=126212
3306
3307         Reviewed by Daniel Bates.
3308
3309         Allow building the GTK+ cmake port with --gtkcmake.
3310
3311         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
3312         when appropriate. Skip the autotoos path when isGtkAutotools is false.
3313         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
3314         Add isGtk which checks isGtkCMake || isGtkAutotools
3315         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
3316         (argumentsForConfiguration): use --gtkcmake when appropriate.
3317         (jscProductDir): Look in the CMake directory when appropriate.
3318         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
3319         (determineIsGtkCMake): Added.
3320         (isGtkCMake): Added.
3321         (isGtkAutotools): Renamed from isGtk.
3322         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
3323         (determineIsGtkAutotools): Renamed from determineIsGtk.
3324         (cmakeBasedPortName): Added a GTK+ path.
3325
3326 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
3327
3328         [GTK] [CMake] Fix the video and audio build
3329         https://bugs.webkit.org/show_bug.cgi?id=126464
3330
3331         Reviewed by Philippe Normand.
3332
3333         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
3334
3335 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3336
3337         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
3338         https://bugs.webkit.org/show_bug.cgi?id=126467
3339
3340         Reviewed by Geoffrey Garen.
3341
3342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3343         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
3344         pointer, or to tap.
3345
3346 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3347
3348         build.webkit.org/dashboard says "failed build" even if it's another step that failed
3349         https://bugs.webkit.org/show_bug.cgi?id=126461
3350
3351         Reviewed by Geoffrey Garen.
3352
3353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3354         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
3355         build page if it's not the compilation that failed. Use text from buildbot for description.
3356         Show a yellow icon if it's a different kind of failure.
3357
3358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3359         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
3360
3361 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
3362
3363         setup-git-clone fails to get email address from git
3364         https://bugs.webkit.org/show_bug.cgi?id=126446
3365
3366         Reviewed by Ryosuke Niwa.
3367
3368         The setup-git-clone command fails to get an email address from git
3369         because of a bug in VCSUtils. This patch fixes that bug, and also
3370         makes it so that when VCSUtils fails for real because of a local
3371         misconfiguration, the error message is actually presented to the user
3372         of setup-git-clone.
3373
3374         * Scripts/VCSUtils.pm:
3375         (gitConfig): Call isGit() instead of accessing $isGit directly to make
3376             sure that $isGit is properly initialized.
3377         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3378         (SetupGitClone.execute): Pull out username and email acquistion to
3379             it's own method.
3380         (SetupGitClone._get_username_and_email): Catch the exception thrown
3381             when VCSUtils fails and print out the error message so that the
3382             user actually knows why the command failed.
3383
3384 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3385
3386         It feels too hard to get rid of a popover at build.webkit.org/dashboard
3387         https://bugs.webkit.org/show_bug.cgi?id=126451
3388
3389         Reviewed by Simon Fraser.
3390
3391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3392         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
3393         when moving the mouse from an element to its popover.
3394
3395 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3396
3397         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3398         https://bugs.webkit.org/show_bug.cgi?id=122181
3399
3400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3401         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
3402         popover.present signature change.
3403
3404 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3405
3406         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3407         https://bugs.webkit.org/show_bug.cgi?id=122181
3408
3409         Reviewed by Timothy Hatcher and Timothy Horton.
3410
3411         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
3412         JSONP). Dashboard will load them on demand.
3413
3414         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3415         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
3416         and made it use a function from WebKitBuildbot that builds results directory path.
3417         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
3418         a URL for full_results.json.
3419         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
3420         a URL for a crash log.
3421
3422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3423         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
3424         the iteration.
3425
3426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
3427         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
3428         popover API (see below).
3429         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
3430
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3432         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
3433         for iterations that were interrupted (previously, they were displayed incorrectly,
3434         often as passes). Install popover trackers for failure bubbles for which we can currently
3435         display something useful.
3436         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
3437         a popover for layout test regressions when we have the data loaded on demand.
3438         We have test paths, special indicators for crashes/timeouts, and links to test history
3439         at flakiness dashboard.
3440         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
3441         the popover for layout test regressions. Just shows "Loading..." until the data is
3442         loaded.
3443         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
3444         types of failures if there are multiple. There is a lot of similarity with
3445         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
3446
3447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3448         Create a global test history object, which is used for links in layout test popover.
3449
3450         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3451         Changed the API to be more like WebInspector again, allowing for changing content
3452         of an existing popover. As the size of a popover can change, making the mouse pointer
3453         enter it without a mousenter event, install a handler for mousewheel instead, and block
3454         document scrolling from this event handler when needed.
3455
3456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3457         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
3458         bubble element, making it possible to install a popover on it.
3459
3460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3461         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
3462
3463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3464         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
3465         building a complete results URL to only building one for root results path. This is
3466         the part that depends on specific buildbot installation, everything relative to it
3467         is the same.
3468
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
3470         Build a path to test history page. In the future, we may consider adding code to
3471         load the data and display it inline.
3472
3473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3474         Added styles for this new popover.
3475
3476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
3477         a new file, WebKitTestHistory.js.
3478
3479 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3480
3481         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
3482         https://bugs.webkit.org/show_bug.cgi?id=126430
3483
3484         Reviewed by Martin Robinson.
3485
3486         * Scripts/run-gtk-tests:
3487         (TestRunner._setup_testing_environment):
3488         * gtk/common.py: Use common.tests_library_build_path() instead.
3489         (tests_library_build_path): Helper funtion that returns the path
3490         where the tests libraries are built.
3491
3492 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
3493
3494         [CMake] Build TestWebKitAPI tests into a directory structure
3495         https://bugs.webkit.org/show_bug.cgi?id=126358
3496
3497         Reviewed by Gyuyoung Kim.
3498
3499         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
3500         is useful for keeping the "bin" directory tidy during building and will make it easier
3501         to integrate the CMake build into the existing WebKitGTK+ scripts.
3502
3503         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
3504         and make the names simpler now that the directory identifies what category the test is in.
3505
3506 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3507
3508         Provide a visual clue when element has a popover at build.webkit.org/dashboard
3509         https://bugs.webkit.org/show_bug.cgi?id=126281
3510
3511         Reviewed by Timothy Hatcher.
3512
3513         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3514         (PopoverTracker): Add a class name to elements with popovers.
3515
3516         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3517         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
3518         I might have broke that recently.
3519         (*:link): Show hand cursor over links.
3520         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
3521
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3523         (.status-line .message .revision-number): Show text selection cursor on our only
3524         selectable text element.
3525         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
3526         a white shadow than with a dark one on hover.
3527
3528 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3529
3530         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
3531         https://bugs.webkit.org/show_bug.cgi?id=124652
3532
3533         Reviewed by Martin Robinson.
3534
3535         * MiniBrowser/gtk/BrowserWindow.c:
3536         (webViewDecidePolicy): Use the new API instead of
3537         webkit_web_view_can_show_mime_type().
3538
3539 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3540
3541         REGRESSION(r160304): [GTK] Disable libtool fast install
3542         https://bugs.webkit.org/show_bug.cgi?id=126381
3543
3544         Reviewed by Martin Robinson.
3545
3546         Remove -no-fast-install ld flag since fast install is now disabled
3547         globally.
3548
3549         * GNUmakefile.am:
3550         * GtkLauncher/GNUmakefile.am:
3551         * MiniBrowser/gtk/GNUmakefile.am:
3552         * TestWebKitAPI/GNUmakefile.am:
3553         * WebKitTestRunner/GNUmakefile.am:
3554
3555 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
3556
3557         Unreviewed. Add myself to EFL and related watch lists.
3558
3559         * Scripts/webkitpy/common/config/watchlist:
3560
3561 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
3562
3563         [GTK] fixing ycm_extra_conf.py file
3564         https://bugs.webkit.org/show_bug.cgi?id=126371
3565
3566         It's an attempt to fix three problems with the current ycm_extra_conf file.
3567         The current implementation assumes that it's a symlink, which is not true.
3568         Usually python creates a pyc file, and this is what you get in __file__.
3569         the .pyc is not a symlink, and the current implementation doesn't work
3570         if that's the case.
3571
3572         It also assumes that the user is in the root folder.
3573         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
3574
3575         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
3576         exception since "flag" doesn't exists.
3577
3578         All those things were fixed.
3579
3580         Reviewed by Martin Robinson.
3581
3582         * gtk/ycm_extra_conf.py:
3583         (transform_relative_paths_to_absolute_paths):
3584
3585 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3586
3587         Bindings tests results links are broken at build.webkit.org/dashboard
3588         https://bugs.webkit.org/show_bug.cgi?id=126402
3589
3590         Reviewed by Tim Horton.
3591
3592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3593         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
3594         since the beginning.
3595
3596 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3597
3598         "+" is very confusing at http://build.webkit.org/dashboard
3599         https://bugs.webkit.org/show_bug.cgi?id=126400
3600
3601         Reviewed by Tim Horton.
3602
3603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3604         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
3605         source and internal counts separately, simply add them. One can always open a popover
3606         for more detail.
3607
3608 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3609
3610         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3611         https://bugs.webkit.org/show_bug.cgi?id=126391
3612
3613         Reviewed by Dan Bernstein.
3614
3615         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
3616         One can request credentials use via Initialization.js.
3617
3618         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3619         (Trac):
3620         (Trac.prototype.update):
3621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3622         (loadXML):
3623
3624 2014-01-02  Commit Queue  <commit-queue@webkit.org>
3625
3626         Unreviewed, rolling out r160846.
3627         http://trac.webkit.org/changeset/160846
3628         https://bugs.webkit.org/show_bug.cgi?id=126395
3629
3630         Breaks build scripts for Windows when Visual Studio is not
3631         installed in Program Files (Requested by rfong on #webkit).
3632
3633         * Scripts/webkitdirs.pm:
3634         (visualStudioInstallDir):
3635
3636 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
3637
3638         [GTK] [CMake] run-gtk-tests should run with the cmake build
3639         https://bugs.webkit.org/show_bug.cgi?id=126341
3640
3641         Reviewed by Carlos Garcia Campos.
3642
3643         * Scripts/run-gtk-tests:
3644         (TestRunner.__init__): Use the new calling conventions for the common script.
3645         (TestRunner._setup_testing_environment): Ditto.
3646         * gtk/common.py:
3647         (set_build_types): Added set_build_types, to avoid having build_type arguments
3648         for all functions in common.
3649         (binary_build_path): Added this function which gets the path to the built binaries.
3650         (get_build_path): Removed the build_types argument.
3651         (build_path): Removed the build_types argument and call get_build_path directly now.
3652
3653 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3654
3655         https://bugs.webkit.org/show_bug.cgi?id=126391
3656         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3657
3658         Rubber-stamped by Dan Bernstein.
3659
3660         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3661         (loadXML): Quick and dirty fix, with a FIXME.
3662
3663 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
3664
3665         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
3666         https://bugs.webkit.org/show_bug.cgi?id=126349
3667
3668         Reviewed by Carlos Garcia Campos.
3669
3670         All CMake ports use "libTestNetscapePlugin," so choosing the same
3671         name in the autotools port will make the transition easier.
3672
3673         * GNUmakefile.am: Rename the plugin library.
3674
3675 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
3676
3677         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
3678         https://bugs.webkit.org/show_bug.cgi?id=126354
3679
3680         Reviewed by Carlos Garcia Campos.
3681
3682         The latest visited site for backward history should be placed on the top of a history stack
3683         as a common behavior. However currently its order is reverse.
3684
3685         * MiniBrowser/gtk/BrowserWindow.c:
3686         (browserWindowUpdateNavigationActions):
3687
3688 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
3689
3690         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
3691         https://bugs.webkit.org/show_bug.cgi?id=126297
3692
3693         Reviewed by Philippe Normand.
3694
3695         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
3696         (TestRunner): Ditto.
3697         (TestRunner._run_test): Ditto.
3698
3699 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
3700
3701         full_results.json should distinguish unexpected failures from expected ones
3702         https://bugs.webkit.org/show_bug.cgi?id=126300
3703
3704         Reviewed by Timothy Hatcher.
3705
3706         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3707         (summarize_results): Add "report" element to JSON, which tells the consumer how
3708         this result was counted for summary.
3709
3710         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3711         Updated results to include the new element.
3712
3713         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3714         (print_unexpected_results): Added a comment pointing to another place that
3715         summarizes results, and should stay in sync.
3716
3717 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
3718
3719         Replace remaning CoreIPC namespace to IPC
3720         https://bugs.webkit.org/show_bug.cgi?id=126305
3721
3722         Reviewed by Anders Carlsson.
3723
3724         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3725         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
3726         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3727         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
3728
3729 2013-12-30  Brendan Long  <self@brendanlong.com>
3730
3731         Add myself to the committers list.
3732
3733         Unreviewed.
3734
3735         * Scripts/webkitpy/common/config/contributors.json:
3736
3737 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3738
3739         [GTK] Split WebKit2APITests/TestWebKitWebView
3740         https://bugs.webkit.org/show_bug.cgi?id=126284
3741
3742         Reviewed by Philippe Normand.
3743
3744         Skip only WebKitWebView/mouse-target and all TestAuthentication
3745         tests that are timing out when running under xvfb.
3746
3747         * Scripts/run-gtk-tests:
3748         (TestRunner):
3749
3750 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3751
3752         [EFL][WK2] Disable geolocation API test
3753         https://bugs.webkit.org/show_bug.cgi?id=125851
3754
3755         Reviewed by Gyuyoung Kim.
3756
3757         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
3758
3759         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
3760
3761 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
3762
3763         [EFL] Remove ewk_view_tiled
3764         https://bugs.webkit.org/show_bug.cgi?id=125961
3765
3766         Reviewed by Gyuyoung Kim.
3767
3768         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3769         (shouldUseTiledBackingStore):
3770         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
3771         instead of switching ewk_view_tiled.
3772         (DumpRenderTreeChrome::createView):
3773         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3774         (drtViewAdd):
3775         * EWebLauncher/main.c: Removed ewk_view_tiled option.
3776         (windowCreate):
3777         (parseUserArguments):
3778
3779 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3780
3781         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
3782         https://bugs.webkit.org/show_bug.cgi?id=126278
3783
3784         Reviewed by Timothy Hatcher.
3785
3786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3787         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
3788         as StatusLineView message element has extra padding, and doesn't fit the text snugly.
3789         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
3790
3791         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3792         (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
3793
3794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3795         Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
3796
3797 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3798
3799         Interrupted test runs should not count at build.webkit.org/dashboard
3800         https://bugs.webkit.org/show_bug.cgi?id=126279
3801
3802         Reviewed by Timothy Hatcher.
3803
3804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3805         (BuildbotIteration.prototype.get productive):
3806         (BuildbotIteration.prototype.get previousProductiveIteration): Replaced previous with
3807         this accessor to skips iterations that don't have relevant data. We still want to
3808         display them, but revision ranges should not be affected.
3809         (BuildbotIteration.prototype.update): Record whether the iteration was up for retry.
3810
3811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3812         Use latest productive iteration instead of latest iteration for pending revision
3813         count and popovers.
3814
3815 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3816
3817         Please display (and link to) revision ranges at build.webkit.org/dashboard
3818         https://bugs.webkit.org/show_bug.cgi?id=122187
3819
3820         Reviewed by Timothy Hatcher.
3821
3822         Added popovers for revision numbers. Removed direct links, because they were misleading -
3823         a test run covers a revision range, not just the latest revision. This also makes
3824         selecting a revision for copy easier.
3825
3826         All revision numbers have the popovers for consistency, although they are most useful
3827         for iterations that are not the last ones in a view, because the content is a delta
3828         from previous iteration.
3829
3830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3831         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
3832         revisionLinksForIteration() is now named revisionContentForIteration().
3833
3834         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3835         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3836         Ditto.
3837
3838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3839         (BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
3840
3841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3842         Refactored to support the new popover variation. Replaced revisionLinksForIteration()
3843         with a function that builds an element with popover.
3844
3845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3846         Changed to take a function for popover presentation instead of delegate object.
3847         We only need one delegate function, and it's easier to have multiple popovers per view class
3848         this way.
3849
3850         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3851         Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
3852
3853         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3854         Renamed pending-commits-popover class to commit-history-popover.
3855
3856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3857         (.status-line .message .revision-number): Added a rule for revision numbers.
3858
3859 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3860
3861         Please display information about pending runs in build.webkit.org/dashboard
3862         https://bugs.webkit.org/show_bug.cgi?id=122180
3863
3864         Reviewed by Timothy Hatcher.
3865
3866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3867         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Added a semicolon at the end of a line.
3868
3869         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3870         (BuildbotQueueView.prototype._latestFinishedIteration): Factored out of _appendPendingRevisionCount.
3871         (BuildbotQueueView.prototype._appendPendingRevisionCount): Install a popover tracker over the element.
3872         (BuildbotQueueView.prototype.lineForCommit): Build an element for a particular commit ot be shown in popover.
3873         (BuildbotQueueView.prototype.presentPopoverForElement): Build and show popover content when PopoverTracker
3874         asks us to.
3875
3876         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Geometry.js: Added.
3877         Taken from WebInspector with minimal changes:
3878         - Changed root name from WebInspector to Dashboard.
3879         - Removed some unused functionality.
3880         - Added Rect.containsPoint.
3881
3882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js: Added.
3883         Popover has extensive changes compared to WebInspector version, only drawing code is the same:
3884         - Fixed to work in scrollable pages - WebInspector version assumes that window
3885         and document coordinates are the same, and also erroneously dismisses a scrollable
3886         popover if scrolling cascades out of it after reaching a bound.
3887         - Simplified API and implementation to Dashboard needs, it is no longer possible to
3888         change content of an existing popover.
3889         - Rewrote visibility tracking to be more complete, and not rely on external tracker
3890         object so much.
3891         - Added code to flash scroll bars when showing a scrollable popover.
3892
3893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js: Added.
3894         Objects of this class show and hide popovers as appropriate for registered active elements.
3895
3896         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3897         (StatusLineView.prototype.get messageElement): Added an accessor, so that we could
3898         install a popover on message element. It's the only visible element in pending commit
3899         line, but the line has different bounds, so we can't install a popover on it (it
3900         would be incorrectly positioned if we did).
3901
3902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3903         (Trac.prototype._convertCommitInfoElementToObject):
3904         - Some trac installations report author in a different element, updated to support that.
3905         - Changed to parse title out of description, because trac titles are ugly. Also,
3906         we get a nice HTML with links from the description.
3907
3908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3909         (Node.prototype.isAncestor): Copied from Web Inspector, only changing the form for
3910         consistency with the rest of this file (add a property on prototype with assignment
3911         instead of using Object.defineProperty).
3912         (Node.prototype.isDescendant): Ditto.
3913         (Node.prototype.isSelfOrAncestor): Ditto.
3914         (Node.prototype.isSelfOrDescendant): Ditto.
3915         (DOMTokenList.prototype.contains): Ditto.
3916
3917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css: Added.
3918         Like JS counterpart, mostly lifted from Web Inspector.
3919
3920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3921         Added style rules for pending commits popover.
3922
3923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3924         (.status-line.no-bubble .message): Changed to display:inline-block, so that it fits
3925         to content, and we can show the popover in a correct place.
3926
3927         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added new files.
3928
3929 2013-12-27  Gavin Barraclough  <barraclough@apple.com>
3930
3931         Merge PageVisibilityState & ViewState::IsVisible in WebKit2
3932         https://bugs.webkit.org/show_bug.cgi?id=126214
3933
3934         Reviewed by Alexey Proskuryakov.
3935
3936         WebKit2 redundantly tracks the visibility of the view through two mechanisms - the visibility
3937         state, and the view state. Remove visibility state from the WebKit2 layer. The visibility
3938         state also tracks the prerender state - so split this out and handle it separately (a change
3939         we should make in WebCore, too).
3940
3941         Tools - WebKit2 no longer (poorly) supports a fake visibility state, so to test the page
3942         visibility mechanisms we should actually be changing characteristics of the view that will
3943         be detected by WebKit2 as a visibility change. This affects three things:
3944             1) On setVisibilityState WebKitTestRunner must actually change visibility of the view.
3945             2) The 'PageVisibilityState' test in the API tests is useless (as evidenced by the fact
3946                that page visibility has been broken in WebKit2 for a couple of months, and didn't
3947                catch this fact). Removed in favour of:
3948             3) 'PageVisibilityStateWithWindowChanges' - this is the good stuff. This actually tests
3949                the visibility mechanism. Beef this test up by adding coverage for: a) the prerender
3950             state, b) document.hidden, and c) too many state change notifications (it already looks
3951             for too few).
3952
3953         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3954         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Removed.
3955             - Removed PageVisibilityState - this test was ineffective, API no longer supports this
3956               test, and behaviour is covered by PageVisibilityStateWithWindowChanges.
3957         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3958         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3959         (runJavaScriptAlert):
3960             - Add checking for too many calls to the alert.
3961         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::setPrerender):
3962             - Added methods to set visibility to prerender.
3963         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3964             - Added checking of 'document.hidden'.
3965         * WebKitTestRunner/TestController.cpp:
3966         (WTR::TestController::setVisibilityState):
3967         * WebKitTestRunner/TestController.h:
3968         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3969         (WTR::TestController::setHidden):
3970         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3971         (WTR::TestController::setHidden):
3972         * WebKitTestRunner/mac/TestControllerMac.mm:
3973         (WTR::TestController::setHidden):
3974             - Add setHidden method; call this from setVisibilityState.
3975
3976 2013-12-27  Alexey Proskuryakov  <ap@apple.com>
3977
3978         Display EWS status on bot watcher's dashboard
3979         https://bugs.webkit.org/show_bug.cgi?id=126224
3980
3981         Silence spurious exceptions, no visible behavior change.
3982
3983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3984         (EWSQueue.prototype.update): Removed code that was only needed for an experimental
3985         feature that wasn't landed.
3986
3987 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
3988
3989         Display EWS status on bot watcher's dashboard
3990         https://bugs.webkit.org/show_bug.cgi?id=126224
3991
3992         Reviewed by Timothy Hatcher.
3993
3994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added.
3996         Moved platform definitions out of Buildbot.js, as they are also needed for EWS.
3997
3998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: Added.
4000         (QueueView):
4001         (QueueView.prototype.updateSoon):
4002         (QueueView.prototype.update):
4003         (QueueView.prototype._updateHiddenState):
4004         Moved auto-update and hide logic to a base class, as it equally applies to EWS.
4005
4006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Added.
4007         This is a peer to Buildbot.js and WebKitBuildbot.js.
4008
4009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Added.
4010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Added.
4011         Quite simple for now, only keeping track of queue size.
4012         
4013         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
4014         Initialize EWS.
4015
4016         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4017         Create EWS views.
4018
4019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4020         Updated for Buildbot.Platform rename, it's now Dashboard.Platform.
4021
4022         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Removed.
4023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Removed.
4024         These were empty, no reason to waste the time loading them.
4025
4026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Removed.
4027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css.
4028         Renamed, as these styles apply to all queues, not just buildbot ones (and they have to, as columns should look alike).
4029
4030         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
4031             - Changed page title, as it no longer displays just buildbot status.
4032             - Updated subresource lists for the new, renamed and removed files.
4033
4034 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
4035
4036         EWS status JSON should include Access-Control-Allow-Origin
4037         https://bugs.webkit.org/show_bug.cgi?id=126246
4038
4039         Reviewed by Ryosuke Niwa.
4040
4041         * QueueStatusServer/app.yaml: Update version.
4042         * QueueStatusServer/handlers/queuestatusjson.py:
4043         (QueueStatusJSON.get): Add the header field.
4044
4045 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
4046
4047         Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
4048         https://bugs.webkit.org/show_bug.cgi?id=126234
4049
4050         Reviewed by Timothy Hatcher.
4051
4052         Changed elements that are semantically links from <div> to <a>.
4053
4054         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
4055         (StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
4056         Don't try simulate a link with CSS/JS, it's not needed any more.
4057         (StatusLineView.prototype._clicked): Removed.
4058
4059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
4060         Removed text-decoration rules, default ones in Main.css now work for queue elements.
4061
4062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4063         Simplified cursor rules.
4064         Added a universal rule for links to only show underline on hover, as this is what
4065         we want almost everywhere.
4066
4067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
4068         (.status-line .bubble): Added text-decoration: none, as this is the one place where
4069         we don't want it even on hover.
4070         (.status-line .label): Force display: block for consistent layout between <a>
4071         and <div>.
4072
4073 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
4074
4075         Please clarify "pending" reporting at build.webkit.org/dashboard
4076         https://bugs.webkit.org/show_bug.cgi?id=122191
4077
4078         Reviewed by Timothy Hatcher.
4079
4080         Reporting the count of pending runs didn't make a lot of sense - first, runs are
4081         coalesced and sometimes even out of order, and second, buildbot's notion of pending
4082         run was confusingly different from dashboard's.
4083
4084         Let's display how many SVN revisions are pending. This can be somewhat misleading
4085         too, because some revisions (like those for other platforms) don't trigger builds,
4086         but it's better than what we had.
4087
4088         This patch also lays the groundwork for displaying detailed information about
4089         pending revisions.
4090
4091         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
4092         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
4093         building pending status line directly, call newly added base class method.
4094
4095         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4096         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Ditto.
4097
4098         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4099         (BuildbotQueueView): Listen for events when new SVN revisions are landed, and update the view.
4100         (BuildbotQueueView.prototype._appendPendingRevisionCount): Add a line for pending
4101         SVN revisions. It uses a new style, StatusLineView.Status.NoBubble, because this
4102         information is secondary, and doesn't need as much attention.
4103         (BuildbotQueueView.prototype.revisionLinksForIteration): Build revisionURL through
4104         Trac, not through Buildbot.
4105         (BuildbotQueueView.prototype._newCommitsRecorded): Schedule an update, just like when
4106         iterations are updated.
4107
4108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
4109         Initialize a global webkitTrac object.
4110
4111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
4112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
4113         Added a new style for messages without a bubble.
4114
4115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
4116         Added a model class for Trac, which keeps track of SVN timeline, and notifies
4117         listeners of changes. It uses an RSS interface to Trac, because there is no JSON one.
4118
4119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
4120         (loadXML): Added a function to load XML asynchronously, just like existing JSON.load.
4121
4122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4123         Removed tracRevisionURL() function. Now that we have a Trac object, it just makes
4124         more sense to build trac URLs through it.
4125
4126         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
4127         Load Trac.js.
4128
4129 2013-12-25  Jongwoo Choi  <jw0330.choi@samsung.com>
4130
4131         [EFL] Activate keyboard homepage shortcut on efl minibrowser.
4132         https://bugs.webkit.org/show_bug.cgi?id=124636
4133
4134         Reviewed by Gyuyoung Kim.
4135
4136         * MiniBrowser/efl/main.c: Added.
4137         (on_key_down): Add a homepage shortcut using Alt + Home key. 
4138
4139 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
4140
4141         Revision selection behavior at build.webkit.org/dashboard is annoying
4142         https://bugs.webkit.org/show_bug.cgi?id=126235
4143
4144         Reviewed by Tim Horton.
4145
4146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
4147         (BuildbotQueueView.prototype.revisionLinksForIteration): Make the whole message
4148         selectable, not just the numbers in it.
4149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4150         (.selectable): Make selectable enable default behavior, not user-select:all.
4151
4152 2013-12-25  Martin Robinson  <mrobinson@igalia.com>
4153
4154         [GTK] [CMake] Clean up generated sources directories
4155         https://bugs.webkit.org/show_bug.cgi?id=126216
4156
4157         Reviewed by Gustavo Noronha Silva.
4158
4159         * DumpRenderTree/PlatformGTK.cmake: Use the new derived sources variables.
4160         * GtkLauncher/CMakeLists.txt: Ditto.
4161         * MiniBrowser/gtk/CMakeLists.txt: Ditto.
4162         * TestWebKitAPI/CMakeLists.txt: Now that the EFL and GTK+ forwarding header locations differ,
4163         move the platform-specific includes to the EFL and GTK platform files. Also clean up forwarding
4164         header generation into on target.
4165         * TestWebKitAPI/PlatformEfl.cmake: Added EFL-specific locations to the include list.
4166         * TestWebKitAPI/PlatformGTK.cmake: Added GTK-specific locations to the include list.
4167         * WebKitTestRunner/CMakeLists.txt: Same as for TestWebKitAPI.
4168         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
4169         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
4170         * gtk/generate-gtkdoc: Update to select the appropriate derived sources locations for
4171         the cmake build.
4172
4173 2013-12-23  Alexey Proskuryakov  <ap@apple.com>
4174
4175         Add a JSON interface for getting EWS queue status
4176         https://bugs.webkit.org/show_bug.cgi?id=126182
4177
4178         Reviewed by Ryosuke Niwa.
4179
4180         The current goal is to add an indicator of how many patches are in the queue, and
4181         the JSON also includes some other information that was easy to add.
4182
4