0f95b382b445611396856b7da6eb01717d060327
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2
3         [Win] DumpRenderTreeWatchDog.py is not checked into source
4         https://bugs.webkit.org/show_bug.cgi?id=196567
5         <rdar://problem/49525901>
6
7         Reviewed by Lucas Forschler.
8
9         This script is used on Win EWS bots to terminate hanging DRT processes.
10
11         * EWSTools/dumprendertreewatchdog.py: Added.
12
13 2019-04-04  Chris Dumez  <cdumez@apple.com>
14
15         Unreviewed, roll out r243858 which made tests time out.
16
17         Disable new API tests on Windows instead.
18
19         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
20         (TestWebKitAPI::TEST):
21
22 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
23
24         [ATK] Cleanup WebPageAccessibilityObjectAtk
25         https://bugs.webkit.org/show_bug.cgi?id=196537
26
27         Reviewed by Michael Catanzaro.
28
29         Also consider files under atk directories as exceptions for GObject conventions.
30
31         * Scripts/webkitpy/style/checkers/cpp.py:
32         (check_identifier_name_in_declaration):
33
34 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
35
36         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
37         https://bugs.webkit.org/show_bug.cgi?id=196588
38         <rdar://problem/49365787>
39
40         Unreviewed build fix for Windows port.
41
42         error C3861: 'kill': identifier not found
43
44         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
45         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
46
47 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
48
49         [ews-build] Cancel build and similar operations should have authentication
50         https://bugs.webkit.org/show_bug.cgi?id=196520
51
52         Reviewed by Dewei Zhu.
53
54         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
55         environment variables.
56
57 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
58
59         [ews-build] Do not trigger queues which are not in production yet
60         https://bugs.webkit.org/show_bug.cgi?id=196581
61
62         Reviewed by Dewei Zhu.
63
64         * BuildSlaveSupport/ews-build/config.json:
65
66 2019-04-03  Chris Dumez  <cdumez@apple.com>
67
68         Unreviewed, fix typo in the name of API test added in r243848.
69
70         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
71         (TestWebKitAPI::TEST):
72
73 2019-04-03  Chris Dumez  <cdumez@apple.com>
74
75         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
76         https://bugs.webkit.org/show_bug.cgi?id=196588
77         <rdar://problem/49365787>
78
79         Reviewed by Ryosuke Niwa.
80
81         Add API test coverage.
82
83         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
84         (TestWebKitAPI::nullJavaScriptCallback):
85         (TestWebKitAPI::didCrashCheckFrames):
86         (TestWebKitAPI::TEST):
87
88 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
89
90         run-webkit-tests: Upload test results (new results database)
91         https://bugs.webkit.org/show_bug.cgi?id=196577
92         <rdar://problem/34841155>
93
94         Reviewed by Lucas Forschler.
95
96         * Scripts/webkitpy/layout_tests/controllers/manager.py:
97         (Manager.run): Upload results after each device shard, since the configuration will be
98         different for each device.
99         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
100         uploaded to a results database.
101         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
102         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
103
104 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
105
106         -apple-trailing-word is needed for browser detection
107         https://bugs.webkit.org/show_bug.cgi?id=196575
108
109         Unreviewed.
110
111         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
112
113 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
114
115         [CMake][WTF] Mirror XCode header directories
116         https://bugs.webkit.org/show_bug.cgi?id=191662
117
118         Reviewed by Konstantin Tokarev.
119
120         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
121         builds.
122
123         * CMakeLists.txt:
124         * DumpRenderTree/CMakeLists.txt:
125         * DumpRenderTree/PlatformWin.cmake:
126         * MiniBrowser/win/CMakeLists.txt:
127         * TestWebKitAPI/CMakeLists.txt:
128         * TestWebKitAPI/PlatformWin.cmake:
129         * WebKitTestRunner/PlatformGTK.cmake:
130         * WebKitTestRunner/PlatformWin.cmake:
131
132 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
133
134         [ews-app] Status bubble should not display certain infrastructure status messages
135         https://bugs.webkit.org/show_bug.cgi?id=196550
136
137         Reviewed by Lucas Forschler.
138
139         Do not display the steps which are un-needed for end-user. This information is still avaiable
140         if the user click on the bubble and look at the Buildbot build.
141         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
142         (StatusBubble._steps_messages):
143         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
144
145 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
146
147         [ews-build] Use https for sending data to ews-app
148         https://bugs.webkit.org/show_bug.cgi?id=196492
149
150         Reviewed by Lucas Forschler.
151
152         * BuildSlaveSupport/ews-build/events.py:
153
154 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
155
156         Remove support for -apple-trailing-word
157         https://bugs.webkit.org/show_bug.cgi?id=196525
158
159         Reviewed by Zalan Bujtas.
160
161         This CSS property is nonstandard and not used.
162
163         * Scripts/webkitperl/FeatureList.pm:
164         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
165
166 2019-04-03  Youenn Fablet  <youenn@apple.com>
167
168         Add a test for DOMCache on multiple browsing in case of private browsing
169         https://bugs.webkit.org/show_bug.cgi?id=196524
170
171         Reviewed by Alex Christensen.
172
173         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
174         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
175
176 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
177
178         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
179         https://bugs.webkit.org/show_bug.cgi?id=196540
180
181         Reviewed by Aakash Jain.
182
183         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
184
185 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
186
187         Add plumbing for a compatibility mode preference in WebKit
188         https://bugs.webkit.org/show_bug.cgi?id=196005
189
190         Reviewed by Tim Horton.
191
192         Add new API tests.
193
194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
195         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
196
197 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
198
199         [WPE][GTK] Update libsrtp dependency package for Debian
200         https://bugs.webkit.org/show_bug.cgi?id=196528
201
202         Reviewed by Frédéric Wang.
203
204         * gtk/install-dependencies:
205         * wpe/install-dependencies:
206
207 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
208
209         [WK2] Add support for Window's beforeprint / afterprint events
210         https://bugs.webkit.org/show_bug.cgi?id=196478
211         <rdar://problem/49535124>
212
213         Unreviewed build fix for MSVC.
214
215         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
216
217         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
218
219         * WebKitTestRunner/TestController.cpp:
220         (WTR::printFrame): Use int and float literals.
221
222 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
223
224         [ews-build] Reassign bots to queues
225
226         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
227
228 2019-04-02  Chris Dumez  <cdumez@apple.com>
229
230         [WK2] Add support for Window's beforeprint / afterprint events
231         https://bugs.webkit.org/show_bug.cgi?id=196478
232
233         Reviewed by Alex Christensen.
234
235         Add minimal implementation for printFrame in WebKitTestRunner.
236
237         * WebKitTestRunner/TestController.cpp:
238         (WTR::printFrame):
239         (WTR::TestController::createOtherPage):
240         (WTR::TestController::createWebViewWithOptions):
241
242 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
243
244         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
245         https://bugs.webkit.org/show_bug.cgi?id=196491
246
247         Reviewed by Lucas Forschler.
248
249         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
250
251 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
252
253         [ews-build] Configure buildbot try credentials in environment variables
254         https://bugs.webkit.org/show_bug.cgi?id=196501
255
256         Reviewed by Lucas Forschler.
257
258         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
259         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
260         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
261
262 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
263
264         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
265         https://bugs.webkit.org/show_bug.cgi?id=196496
266         <rdar://problem/49521634>
267
268         Reviewed by Chris Dumez.
269
270         Add new API tests (see WebKit ChangeLog for more detail).
271
272         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
273         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
274         (TEST):
275
276 2019-04-02  David Kilzer  <ddkilzer@apple.com>
277
278         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
279         <https://webkit.org/b/196499>
280
281         Reviewed by Alexey Proskuryakov.
282
283         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
284         ENABLE_ADDRESS_SANITIZER.
285
286 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
287
288         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
289         https://bugs.webkit.org/show_bug.cgi?id=182757
290
291         Reviewed by Don Olmstead.
292
293         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
294         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
295
296 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
297
298         run-api-tests: Upload test results
299         https://bugs.webkit.org/show_bug.cgi?id=196323
300         <rdar://problem/49356714>
301
302         Reviewed by Lucas Forschler.
303
304         * Scripts/webkitpy/api_tests/manager.py:
305         (Manager):
306         (Manager.run): Upload results to a results database.
307         * Scripts/webkitpy/api_tests/run_api_tests.py:
308         (parse_args): Add upload arguments.
309         * Scripts/webkitpy/port/base.py:
310         (Port):
311         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
312         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
313         with commits from any other associated repositories.
314         * Scripts/webkitpy/port/device.py:
315         (Device):
316         (Device.build_version): Access build_versoin of underlying platform device.
317         * Scripts/webkitpy/port/ios_simulator_unittest.py:
318         (IOSSimulatorTest):
319         (IOSSimulatorTest.test_configuration_for_upload):
320         * Scripts/webkitpy/port/device_port.py:
321         (DevicePort):
322         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
323         the same as the machine uploading results.
324         * Scripts/webkitpy/port/mac.py:
325         (MacPort):
326         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
327         * Scripts/webkitpy/port/mac_unittest.py:
328         (MacTest):
329         (MacTest.test_configuration_for_upload):
330         * Scripts/webkitpy/xcode/simulated_device.py:
331         (SimulatedDeviceManager._create_device_with_runtime):
332         (SimulatedDevice.__init__): Create simulated device with a build_version.
333         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
334         (test_existing_simulator):
335
336 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
337
338         Remove extra newline characters (Follow-up fix to r243707)
339
340         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
341
342 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
343
344         [ews-app] Use API_KEY to accept results data
345         https://bugs.webkit.org/show_bug.cgi?id=196461
346
347         Reviewed by Dewei Zhu.
348
349         * BuildSlaveSupport/ews-app/ews/views/results.py:
350         (Results.post): Validate EWS_API_KEY before accepting any data.
351         * BuildSlaveSupport/ews-build/events.py:
352         (Events.sendData): Send EWS_API_KEY if available along with event data.
353
354 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
355
356         Unable to copy and paste a PDF from Notes into Mail compose body
357         https://bugs.webkit.org/show_bug.cgi?id=196442
358         <rdar://problem/48573098>
359
360         Reviewed by Tim Horton.
361
362         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
363         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
364         to be specified on the item providers.
365
366         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
367         (TestWebKitAPI::mapItemForTesting):
368         (TestWebKitAPI::contactItemForTesting):
369
370 2019-04-01  Tim Horton  <timothy_horton@apple.com>
371
372         Make UIWKDocumentContext rects per-character instead of per-word
373         https://bugs.webkit.org/show_bug.cgi?id=196459
374
375         Reviewed by Wenson Hsieh.
376
377         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
378         (TEST):
379         Adjust test results due to switching to per-character rects.
380
381 2019-04-01  Chris Dumez  <cdumez@apple.com>
382
383         UIProcess crash when a prewarmed process is terminated
384         https://bugs.webkit.org/show_bug.cgi?id=196451
385         <rdar://problem/49245471>
386
387         Reviewed by Geoffrey Garen.
388
389         Add API test coverage.
390
391         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
392         (TEST):
393
394 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
395
396         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
397         https://bugs.webkit.org/show_bug.cgi?id=196449
398
399         Reviewed by Lucas Forschler.
400
401         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
402         (StatusBubble.get_os_details): Method to get OS and Xcode details.
403         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
404         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
405
406 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
407
408         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
409         https://bugs.webkit.org/show_bug.cgi?id=196444
410
411         Reviewed by Lucas Forschler.
412
413         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
414
415 2019-04-01  Alex Christensen  <achristensen@webkit.org>
416
417         Add SPI to canonicalize NSURLs with WTF::URL
418         https://bugs.webkit.org/show_bug.cgi?id=196415
419         <rdar://problem/44980271>
420
421         Reviewed by Darin Adler.
422
423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
424         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
425         (TestWebKitAPI::TEST):
426
427 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
428
429         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
430         https://bugs.webkit.org/show_bug.cgi?id=196441
431
432         Reviewed by Carlos Garcia Campos.
433
434         Don't cache the wpe_view_backend object that might not exist yet at the
435         time of EventSenderProxy constructor invocation, but instead retrieve
436         that object whenever it's required for event dispatching. This should
437         avoid crashes in this constructor now that it's invoked before any
438         PlatformWindow has been set up (as changed in r243496).
439
440         * WebKitTestRunner/EventSenderProxy.h:
441         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
442         (WTR::viewBackend):
443         (WTR::EventSenderProxy::EventSenderProxy):
444         (WTR::EventSenderProxy::mouseDown):
445         (WTR::EventSenderProxy::mouseUp):
446         (WTR::EventSenderProxy::mouseMoveTo):
447         (WTR::EventSenderProxy::mouseScrollBy):
448         (WTR::EventSenderProxy::keyDown):
449         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
450
451 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
452
453         [Win][WebKit] MiniBrowser should support high DPI display
454         https://bugs.webkit.org/show_bug.cgi?id=196391
455
456         Reviewed by Alex Christensen.
457
458         * MiniBrowser/win/WebKitBrowserWindow.cpp:
459         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
460         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
461         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
462
463 2019-03-31  Sam Weinig  <weinig@apple.com>
464
465         Remove more i386 specific configurations
466         https://bugs.webkit.org/show_bug.cgi?id=196430
467
468         Reviewed by Alexey Proskuryakov.
469
470         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
471         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
472
473 2019-03-31  Andy Estes  <aestes@apple.com>
474
475         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
476         https://bugs.webkit.org/show_bug.cgi?id=196433
477         <rdar://problem/49293305>
478
479         Reviewed by Tim Horton.
480
481         Enhanced API test coverage to include all navigation response policy decisions in both
482         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
483
484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
485         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
486         (TestWebKitAPI::TEST):
487         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
488         (readFile):
489         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
490         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
491         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
492         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
493         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
494         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
495         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
496         (-[QuickLookDelegate _downloadDidStart:]):
497         (-[QuickLookDelegate _download:didReceiveResponse:]):
498         (-[QuickLookDelegate _download:didReceiveData:]):
499         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
500         (-[QuickLookDelegate _downloadDidFinish:]):
501         (-[QuickLookDelegate _download:didFailWithError:]):
502         (-[QuickLookDelegate _downloadDidCancel:]):
503         (-[QuickLookDelegate verifyDownload]):
504         (runTest):
505         (runTestDecideBeforeLoading):
506         (runTestDecideAfterLoading):
507         (TEST):
508         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
509         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
510         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
511         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
512         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
513         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
514         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
515         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
516         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
517         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
518         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
519         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
520         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
521         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
522
523 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
524
525         [CMake] add testdfg as target with build-jsc
526         https://bugs.webkit.org/show_bug.cgi?id=196393
527
528         Reviewed by Saam Barati.
529
530         Added testdfg as one of the targets to build when
531         using CMake.
532
533         * Scripts/build-jsc:
534
535 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
536
537         Delete WebMetal implementation in favor of WebGPU
538         https://bugs.webkit.org/show_bug.cgi?id=195418
539
540         Reviewed by Dean Jackson.
541
542         * DumpRenderTree/mac/DumpRenderTree.mm:
543         (enableExperimentalFeatures):
544         (resetWebPreferencesToConsistentValues):
545         * Scripts/webkitperl/FeatureList.pm:
546         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
548         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
549         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
550         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
551         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
552         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
553         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
554         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
555         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
556         (WTR::InjectedBundle::beginTesting):
557         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
558         (WTR::TestRunner::setWebMetalEnabled): Deleted.
559         * WebKitTestRunner/InjectedBundle/TestRunner.h:
560
561 2019-03-29  Chris Dumez  <cdumez@apple.com>
562
563         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
564         https://bugs.webkit.org/show_bug.cgi?id=196405
565         <rdar://problem/49428130>
566
567         Reviewed by Wenson Hsieh.
568
569         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
570         the popover presentation methods to be no-ops. Use this in the new test added in
571         r243523 so that we do not swizzle those methods for all tests. This is needed because
572         those WatchOS tests rely on the popover getting presented and interactive.
573
574         * WebKitTestRunner/TestController.cpp:
575         (WTR::updateTestOptionsFromTestHeader):
576         * WebKitTestRunner/TestController.h:
577         * WebKitTestRunner/TestOptions.h:
578         (WTR::TestOptions::hasSameInitializationOptions const):
579         * WebKitTestRunner/ios/TestControllerIOS.mm:
580         (WTR::TestController::platformInitialize):
581         (WTR::TestController::platformResetStateToConsistentValues):
582
583 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
584
585         [Curl] Add Server Trust Evaluation Support.
586         https://bugs.webkit.org/show_bug.cgi?id=191646
587
588         Reviewed by Fujii Hironori.
589
590         Implemented MiniBrowser UI for asking if user trusts the server.
591
592         * MiniBrowser/win/Common.cpp:
593         (askServerTrustEvaluation):
594         (replaceString):
595         * MiniBrowser/win/Common.h:
596         * MiniBrowser/win/MiniBrowserLib.rc:
597         * MiniBrowser/win/MiniBrowserLibResource.h:
598         * MiniBrowser/win/WebKitBrowserWindow.cpp:
599         (createPEMString):
600         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
601         (WebKitBrowserWindow::canTrustServerCertificate):
602         * MiniBrowser/win/WebKitBrowserWindow.h:
603
604 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
605
606         Implement ResizeObserver.
607         https://bugs.webkit.org/show_bug.cgi?id=157743
608
609         Reviewed by Simon Fraser.
610
611         Support resizeObserverEnabled webPreferences.
612
613         * DumpRenderTree/TestOptions.cpp:
614         (TestOptions::TestOptions):
615         * DumpRenderTree/TestOptions.h:
616         * DumpRenderTree/mac/DumpRenderTree.mm:
617         (setWebPreferencesForTestOptions):
618         * DumpRenderTree/win/DumpRenderTree.cpp:
619         (enableExperimentalFeatures):
620         * Scripts/webkitperl/FeatureList.pm:
621         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
622
623 2019-03-28  John Wilander  <wilander@apple.com>
624
625         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
626         https://bugs.webkit.org/show_bug.cgi?id=196281
627         <rdar://problem/48938748>
628
629         Reviewed by Alex Christensen.
630
631         This patch adds the function isStatisticsHasLocalStorage() to the
632         TestRunner. With it, the page can query the WebsiteDataStore in the
633         UI process to make sure that it sees LocalStorage.
634
635         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
636         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
637         (WTR::TestRunner::isStatisticsHasLocalStorage):
638         * WebKitTestRunner/InjectedBundle/TestRunner.h:
639         * WebKitTestRunner/TestController.cpp:
640         (WTR::TestController::isStatisticsHasLocalStorage):
641         * WebKitTestRunner/TestController.h:
642         * WebKitTestRunner/TestInvocation.cpp:
643         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
644
645 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
646
647         API::Data::createWithoutCopying should do a null check before calling CFRelease
648         https://bugs.webkit.org/show_bug.cgi?id=196276
649         <rdar://problem/48059859>
650
651         Reviewed by Alex Christensen.
652
653         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
654
655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
656         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
657         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
658         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
659         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
660         (TestWebKitAPI::TEST):
661
662 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
663
664         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
665         https://bugs.webkit.org/show_bug.cgi?id=186276
666
667         Reviewed by Carlos Garcia Campos.
668
669         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
670         (webViewLoadChanged):
671         (testWebResourceGetDataError):
672         (testWebResourceGetDataEmpty):
673         (beforeAll):
674         (webViewloadChanged): Deleted.
675
676 2019-03-27  Andy Estes  <aestes@apple.com>
677
678         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
679         https://bugs.webkit.org/show_bug.cgi?id=196317
680
681         Reviewed by Dan Bernstein.
682
683         package-root copies built products into a staging directory using ditto(1), which does not
684         follow symbolic links as it traverses a directory. Now that the files in
685         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
686         itself, these become broken links when ditto'd into the staging directory.
687
688         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
689
690         * Scripts/package-root:
691
692 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
693
694         [ews-app] Update display text of Submit for ews analysis
695         https://bugs.webkit.org/show_bug.cgi?id=196309
696
697         Reviewed by Dewei Zhu.
698
699         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
700
701 2019-03-27  David Kilzer  <ddkilzer@apple.com>
702
703         run-webkit-tests should check for leaks in WebKit processes
704         <https://webkit.org/b/193772>
705         <rdar://problem/46526680>
706
707         Reviewed by Ryosuke Niwa.
708
709         This works by doing the following:
710         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
711           The list of child processes are returned one per line:
712           process.name: pid
713         - Run the "#LIST CHILD PROCESSES" command just before the
714           "#CHECK FOR WORLD LEAKS" command, and store the list of child
715           processes on the ServerProcess object.
716         - When the `--leaks` switch is handled, run check_for_leaks() on
717           each child process after the main test harness.
718
719         * DumpRenderTree/mac/DumpRenderTree.mm:
720         (handleControlCommand):
721         - Use strncmp() instead of strcmp().
722         - Add support for handling "#LIST CHILD PROCESSES" command.
723
724         * Scripts/webkitpy/port/base.py:
725         (Port.check_for_leaks):
726         * Scripts/webkitpy/port/darwin.py:
727         (DarwinPort.check_for_leaks):
728         - Rename redundant 'process_pid' argument to 'process_id'.
729
730         * Scripts/webkitpy/port/driver.py:
731         (Driver.do_post_tests_work):
732         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
733           longer the only command this sends to WebKitTestRunner.
734         - If the `--leaks` switch is present, send the
735           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
736           result using Port.set_webkit_processes().
737         (Driver._parse_child_processes_output):
738         - Add helper method to parse list of child process names and
739           process IDs returned from WebKitTestRunner.
740
741         * Scripts/webkitpy/port/ios_device.py:
742         (IOSDevicePort.check_for_leaks):
743         - Rename redundant 'process_pid' argument to 'process_id'.
744
745         * Scripts/webkitpy/port/leakdetector.py:
746         (LeakDetector._parse_leaks_output):
747         - Return early if there is no leaks_output.
748         (LeakDetector.check_for_leaks):
749         - Rename redundant 'process_pid' argument to 'process_id'.
750
751         * Scripts/webkitpy/port/server_process.py:
752         (ServerProcess.__init__):
753         (ServerProcess.child_processes):
754         (ServerProcess.set_child_processes):
755         - Add instance variable to Port to store list of child process
756           names and process IDs returned from WebKitTestRunner.
757         (ServerProcess._start):
758         - Clear self._child_processes.
759         (ServerProcess.stop):
760         - If self._child_processes is set, call
761           self._port.check_for_leaks() for each child process.
762
763         * Scripts/webkitpy/port/server_process_unittest.py:
764         (TrivialMockPort.check_for_leaks):
765         - Rename redundant 'process_pid' argument to 'process_id'.
766
767         * Scripts/webkitpy/port/simulator_process.py:
768         (SimulatorProcess.stop):
769         - If self._child_processes is set, call
770           self._port.check_for_leaks() for each child process.
771
772         * Scripts/webkitpy/port/watch_device.py:
773         (WatchDevicePort.check_for_leaks):
774         - Rename redundant 'process_pid' argument to 'process_id'.
775
776         * WebKitTestRunner/TestController.cpp:
777         (WTR::TestController::dumpResponse):
778         - Extract method from findAndDumpWorldLeaks() so that it may be
779           reused by findAndDumpWebKitProcessIdentifiers().
780         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
781         - Add method to output process name and process ID of both the
782           WebContent and Networking processes.
783         (WTR::TestController::findAndDumpWorldLeaks):
784         - Fix missing newline in output when there were no abandoned
785           documents.
786         - Call dumpResponse() for extracted code.
787         (WTR::TestController::handleControlCommand):
788         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
789         - Use strncmp() instead of strcmp().
790         - Call findAndDumpWebKitProcessIdentifiers() when
791           "#LIST CHILD PROCESSES" command is sent.
792         * WebKitTestRunner/TestController.h:
793         (WTR::TestController::dumpResponse):
794         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
795         - Declare methods.
796
797 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
798
799         Unreviewed. Add GLib API test cases after r243434.
800
801         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
802         (testWebViewActiveURI):
803         (serverCallback):
804         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
805         (sendRequestCallback):
806
807 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
808
809         Geolocation request not complete when watch request was started in a different web process
810         https://bugs.webkit.org/show_bug.cgi?id=195996
811
812         Reviewed by Alex Christensen.
813
814         Add a test case.
815
816         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
817         (TestWebKitAPI::runJavaScriptAlert):
818         (TestWebKitAPI::TEST):
819
820 2019-03-26  Keith Rollin  <krollin@apple.com>
821
822         Update the way generate-xcfilelists returns strings from functions
823         https://bugs.webkit.org/show_bug.cgi?id=195975
824         <rdar://problem/49040807>
825
826         Reviewed by Dean Jackson.
827
828         There are places where generate-xcfilelists executes assignments with
829         statements like:
830
831             FOO=$(some_function)
832
833         where "some_function" return a string by echoing it. E.g.
834
835             some_function()
836             {
837                 echo "Hello, World"
838             }
839
840         This is a common idiom, but it has a problem if "some_function" needs
841         to call "exit" in an attempt to halt the entire script right then and
842         there. Since "some_function" is called inside of $(), it's being
843         executed in a sub-shell. Calling exit in that sub-shell simply exits
844         that shell; it doesn't not exit the outer shell in which the main part
845         of the script is still running. As such, the main script keeps
846         executing when the intent was for the script to halt.
847
848         The solution to this is to use a different idiom for returning
849         strings. The one we now is to pass in the name of the variable to
850         receive the string result:
851
852             some_function()
853             {
854                 variable_name=$1
855                 eval $variable_name ="Hello, World"
856             }
857
858         The call site now looks like
859
860             some_function FOO
861
862         Because there's no invocation of a sub-shell, some_function can now
863         call "exit" if it wants to, and the entire script will exit at that
864         point.
865
866         * Scripts/generate-xcfilelists:
867
868 2019-03-26  Chris Dumez  <cdumez@apple.com>
869
870         Add basic layout test coverage for File Picker on iOS
871         https://bugs.webkit.org/show_bug.cgi?id=196265
872
873         Reviewed by Wenson Hsieh.
874
875         Add layout test infrastructure to test the file picker on iOS.
876
877         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
878         (WTR::UIScriptController::dismissFilePicker):
879         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
880         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
881         (WTR::UIScriptController::dismissFilePicker):
882         * TestRunnerShared/UIScriptContext/UIScriptController.h:
883         * WebKitTestRunner/TestController.cpp:
884         (WTR::TestController::createWebViewWithOptions):
885         (WTR::updateTestOptionsFromTestHeader):
886         * WebKitTestRunner/TestOptions.h:
887         (WTR::TestOptions::hasSameInitializationOptions const):
888         * WebKitTestRunner/ios/TestControllerIOS.mm:
889         (overridePresentViewController):
890         (WTR::TestController::platformInitialize):
891         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
892         (WTR::UIScriptController::dismissFilePicker):
893
894 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
895
896         Implement async paste method on UIWKInteractionViewProtocol
897         https://bugs.webkit.org/show_bug.cgi?id=196267
898         <rdar://problem/49236346>
899
900         Reviewed by Tim Horton.
901
902         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
903         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
904         are now a part of all iOS 12 internal SDKs.
905
906         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
907
908         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
909         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
910
911         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
912         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
913         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
914         * TestWebKitAPI/ios/UIKitSPI.h:
915
916 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
917
918         [ews-build] Use PostgreSQL for ews.webkit.org database
919         https://bugs.webkit.org/show_bug.cgi?id=196270
920
921         Reviewed by Lucas Forschler.
922
923         * BuildSlaveSupport/ews-app/ews-app/settings.py:
924
925 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
926
927         [ews] Reset simctl states on reboot
928         https://bugs.webkit.org/show_bug.cgi?id=196260
929
930         Rubber-stamped by Aakash Jain.
931
932         * EWSTools/start-queue-mac.sh:
933
934 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
935
936         [ews-build] Use PostgreSQL for ews-build database
937         https://bugs.webkit.org/show_bug.cgi?id=196229
938
939         Reviewed by Lucas Forschler.
940
941         * BuildSlaveSupport/ews-build/master.cfg:
942
943 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
944
945         [ews-build] Get master_hostname dynamically in master.cfg
946         https://bugs.webkit.org/show_bug.cgi?id=196255
947
948         Reviewed by Lucas Forschler.
949
950         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
951         send events data in test mode.
952
953 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
954
955         [ews-app] Set db_constraint to False for Foreign Keys
956         https://bugs.webkit.org/show_bug.cgi?id=196252
957
958         Reviewed by Lucas Forschler.
959
960         * BuildSlaveSupport/ews-app/ews/models/build.py:
961         * BuildSlaveSupport/ews-app/ews/models/step.py:
962
963 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
964
965         [ews-build] is_test_mode_enabled should default to True
966         https://bugs.webkit.org/show_bug.cgi?id=196248
967
968         Reviewed by Lucas Forschler.
969
970         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
971
972 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
973
974         [ews-app] Add webkitperl to ENABLED_QUEUES
975         https://bugs.webkit.org/show_bug.cgi?id=196253
976
977         Reviewed by Lucas Forschler.
978
979         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
980
981 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
982
983         Address NSWindow sometimes using WebKitTestRunnerEvent too early
984         https://bugs.webkit.org/show_bug.cgi?id=196211
985         rdar://problem/49110552
986
987         Reviewed by Tim Horton.
988
989         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
990         Make sure that EventSenderProxy always exists when running tests. We used to create
991         it when resetting before the first test, which is a bit too late.
992
993         * WebKitTestRunner/TestController.h:
994         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
995         (WTR::TestController::platformCreateWebView):
996         (WTR::TestController::platformCreateOtherPage):
997         (WTR::TestController::finishCreatingPlatformWebView):
998         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
999         (WTR::PlatformWebView::PlatformWebView):
1000         Moved some code that made NSWindow use NSEvent during web view creation. We may
1001         need to move more if some other case us found, but this is enough for now.
1002
1003 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1004
1005         Unreviewed. Fix typo in GLib geolocation API after r243285.
1006
1007         gelocation -> geolocation.
1008
1009         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1010         (testGeolocationManagerWatchPosition):
1011
1012 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1013
1014         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1015         https://bugs.webkit.org/show_bug.cgi?id=196213
1016
1017         Reviewed by Geoff Garen.
1018
1019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1020         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1021         (credentialWithIdentityAndKeychainPath):
1022         (-[ChallengeDelegate webView:didFinishNavigation:]):
1023         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1024         (TestWebKitAPI::TEST):
1025
1026 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1027
1028         Expected shouldn't assume its contained types are copyable
1029         https://bugs.webkit.org/show_bug.cgi?id=195986
1030
1031         Reviewed by JF Bastien.
1032
1033         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1034         (TestWebKitAPI::NonCopyable::operator== const):
1035         (TestWebKitAPI::NonCopyable::operator!= const):
1036         (TestWebKitAPI::TEST):
1037
1038 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1039
1040         Remove some now-unnecessary dynamic class lookup
1041         https://bugs.webkit.org/show_bug.cgi?id=196237
1042
1043         Reviewed by Simon Fraser.
1044
1045         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1046         (makeRequest):
1047         (TEST):
1048
1049 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1050
1051         Unreviewed, rolling out r243450.
1052
1053         AppleWin and WinCairo port builds get broken.
1054
1055         Reverted changeset:
1056
1057         "Add test for fix of #196095"
1058         https://bugs.webkit.org/show_bug.cgi?id=196097
1059         https://trac.webkit.org/changeset/243450
1060
1061 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1062
1063         Unreviewed, rolling out r243465.
1064         https://bugs.webkit.org/show_bug.cgi?id=196226
1065
1066         the test doesn't build (Requested by thorton on #webkit).
1067
1068         Reverted changeset:
1069
1070         "Do not terminate the NetworkProcess if a third party
1071         application sends a NSCredential with a SecIdentityRef"
1072         https://bugs.webkit.org/show_bug.cgi?id=196213
1073         https://trac.webkit.org/changeset/243465
1074
1075 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1076
1077         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1078         https://bugs.webkit.org/show_bug.cgi?id=196213
1079
1080         Reviewed by Geoff Garen.
1081
1082         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1083         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1084         (credentialWithIdentityAndKeychainPath):
1085         (-[ChallengeDelegate webView:didFinishNavigation:]):
1086         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1087         (TestWebKitAPI::TEST):
1088
1089 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1090
1091         [ews-build] Gracefully handle missing patch_id in events
1092         https://bugs.webkit.org/show_bug.cgi?id=196216
1093
1094         Reviewed by Lucas Forschler.
1095
1096         * BuildSlaveSupport/ews-build/events.py:
1097
1098 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1099
1100         [ews-build] use lz4 compression for improving buildbot performance
1101         https://bugs.webkit.org/show_bug.cgi?id=196155
1102
1103         Reviewed by Lucas Forschler.
1104
1105         * BuildSlaveSupport/ews-build/master.cfg:
1106
1107 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1108
1109         Pull some API testing helper methods out of TestWKWebView
1110         https://bugs.webkit.org/show_bug.cgi?id=196212
1111
1112         Reviewed by Tim Horton.
1113
1114         Refactor some more API testing utility methods, so that they can be used in
1115         tests that do not use TestWKWebView.
1116
1117         * TestWebKitAPI/cocoa/TestWKWebView.h:
1118         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1119         (-[WKWebView loadTestPageNamed:]):
1120         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1121         (-[WKWebView synchronouslyLoadHTMLString:]):
1122         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1123         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1124         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1125         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1126         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1127
1128 2019-03-25  Jer Noble  <jer.noble@apple.com>
1129
1130         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1131         https://bugs.webkit.org/show_bug.cgi?id=196097
1132
1133         Reviewed by Eric Carlson.
1134
1135         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1136
1137         * DumpRenderTree/mac/DumpRenderTree.mm:
1138         (resetWebPreferencesToConsistentValues):
1139         * WebKitTestRunner/TestController.cpp:
1140         (WTR::TestController::resetPreferencesToConsistentValues):
1141
1142 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1143
1144         Pull IPadUserInterfaceSwizzler out into a separate header file
1145         https://bugs.webkit.org/show_bug.cgi?id=196193
1146
1147         Reviewed by Anders Carlsson.
1148
1149         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1150         be used in other API tests.
1151
1152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1153         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1154         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1155         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1156         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1157         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1158         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1159
1160 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1161
1162         Remove NavigatorContentUtils in WebCore/Modules
1163         https://bugs.webkit.org/show_bug.cgi?id=196070
1164
1165         Reviewed by Alex Christensen.
1166
1167         NavigatorContentUtils was to support the custom scheme spec [1].
1168         However, in WebKit side, no port has supported the feature in
1169         WebKit layer after EFL port was removed. So there has been the
1170         only IDL implementation of the NavigatorContentUtils in WebCore.
1171         So we don't need to keep the implementation in WebCore anymore.
1172
1173         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1174
1175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1176
1177 2019-03-24  Andy Estes  <aestes@apple.com>
1178
1179         [watchOS] Remove unused Proximity Networking code
1180         https://bugs.webkit.org/show_bug.cgi?id=196188
1181
1182         Reviewed by Tim Horton.
1183
1184         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1185         (TEST):
1186
1187 2019-03-23  Keith Miller  <keith_miller@apple.com>
1188
1189         Refactor clz/ctz and fix getLSBSet.
1190         https://bugs.webkit.org/show_bug.cgi?id=196162
1191
1192         Reviewed by Saam Barati.
1193
1194         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1195
1196         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1197         (TestWebKitAPI::TEST):
1198
1199 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1200
1201         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1202         https://bugs.webkit.org/show_bug.cgi?id=196143
1203
1204         Reviewed by Michael Catanzaro.
1205
1206         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1207         directories.
1208
1209         * Scripts/webkitpy/style/checkers/cpp.py:
1210         (check_identifier_name_in_declaration):
1211         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1212         (WebKitStyleTest.test_names):
1213
1214 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1215
1216         [Flatpak] Manifest expanding fails for qt WPE extension
1217         https://bugs.webkit.org/show_bug.cgi?id=196148
1218
1219         Reviewed by Alex Christensen.
1220
1221         * flatpak/flatpakutils.py:
1222         (expand_submodules_recurse): The last recurse manifest expand
1223         iteration might lead to a single module so take it into account
1224         and don't try to recurse further.
1225
1226 2019-03-22  Chris Dumez  <cdumez@apple.com>
1227
1228         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1229         https://bugs.webkit.org/show_bug.cgi?id=195348
1230         <rdar://problem/48622090>
1231
1232         Reviewed by Alex Christensen.
1233
1234         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1235         to NO when test.options().shouldIgnoreMetaViewport is false.
1236
1237         * WebKitTestRunner/ios/TestControllerIOS.mm:
1238         (WTR::TestController::platformConfigureViewForTest):
1239
1240 2019-03-22  Chris Dumez  <cdumez@apple.com>
1241
1242         Prewarmed processes should be usable with any website data store
1243         https://bugs.webkit.org/show_bug.cgi?id=196104
1244
1245         Reviewed by Alex Christensen.
1246
1247         Add API test coverage.
1248
1249         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1250         (runInitialWarmedProcessUsedTest):
1251         (TEST):
1252
1253 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1254
1255         Back out local changes to Alex's Subversion working directory
1256
1257         They were accidentally committed.
1258
1259         * Scripts/webkitpy/common/system/abstractexecutive.py:
1260         (AbstractExecutive.wait_newest):
1261         * Scripts/webkitpy/common/system/executive.py:
1262         (Executive.running_pids):
1263         * Scripts/webkitpy/common/system/executive_mock.py:
1264         (MockExecutive.running_pids):
1265         * Scripts/webkitpy/common/system/executive_unittest.py:
1266         (ExecutiveTest.serial_test_running_pids):
1267         * Scripts/webkitpy/port/darwin.py:
1268         (DarwinPort.check_for_leaks):
1269         * Scripts/webkitpy/port/leakdetector.py:
1270         (LeakDetector.check_for_leaks):
1271         - This was the hack attached to Bug 193772.
1272
1273         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1274         (+[WebKitTestRunnerEvent mouseLocation]):
1275         - This works around a crash on an internal build.
1276
1277 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1278
1279         Fix the build after r243354
1280         https://bugs.webkit.org/show_bug.cgi?id=196138
1281         <rdar://problem/49145951>
1282
1283         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1284         (TEST):
1285         * TestWebKitAPI/ios/UIKitSPI.h:
1286
1287 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1288
1289         Adopt UIWKDocumentContext
1290         https://bugs.webkit.org/show_bug.cgi?id=196040
1291         <rdar://problem/48642440>
1292
1293         Reviewed by Ryosuke Niwa.
1294
1295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1296         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1297         (makeRequest):
1298         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1299         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1300         (applyStyle):
1301         (TEST):
1302         Add tests for UIWKDocumentContext.
1303
1304         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1305         (TEST):
1306         (recursiveFindWKContentView): Deleted.
1307         * TestWebKitAPI/cocoa/TestWKWebView.h:
1308         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1309         (recursiveFindWKContentView):
1310         (-[TestWKWebView wkContentView]):
1311         * TestWebKitAPI/ios/UIKitSPI.h:
1312         Share the WKContentView finding code between tests.
1313
1314 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1315
1316         [iOS WK2] Turn on async overflow scrolling by default
1317         https://bugs.webkit.org/show_bug.cgi?id=196011
1318         rdar://problem/48453859
1319
1320         Reviewed by Antti Koivisto.
1321         
1322         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1323         since so many basic layout tests have different results when compositing is triggered for
1324         overflow.
1325         
1326         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1327
1328         * WebKitTestRunner/TestController.cpp:
1329         (WTR::TestController::resetPreferencesToConsistentValues):
1330
1331 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1332
1333         [ews-build] Retry API test in case of failures
1334         https://bugs.webkit.org/show_bug.cgi?id=196004
1335
1336         Reviewed by Lucas Forschler.
1337
1338         * BuildSlaveSupport/ews-build/steps.py:
1339         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1340         (CompileWebKitToT.doStepIf): Ditto.
1341         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1342         (ReRunAPITests): Re-run API tests.
1343         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1344         (RunAPITestsWithoutPatch): Run API tests without patch.
1345         (RunAPITestsWithoutPatch.doStepIf):
1346         (RunAPITestsWithoutPatch.hideStepIf):
1347         (RunAPITestsWithoutPatch.evaluateCommand):
1348         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1349         (AnalyzeAPITestsResults.start):
1350         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1351         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1352         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1353         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1354
1355 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1356
1357         [ews-build] Update queues configurations
1358         https://bugs.webkit.org/show_bug.cgi?id=196074
1359
1360         Reviewed by Dewei Zhu.
1361
1362         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1363         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1364
1365 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1366
1367         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1368         https://bugs.webkit.org/show_bug.cgi?id=195680
1369         <rdar://problem/48903534>
1370
1371         Unreviewed infrastructure fix.
1372
1373         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1374         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1375
1376 2019-03-21  Andy Estes  <aestes@apple.com>
1377
1378         [iOS] Apple Pay should be available in documents with no user agent scripts
1379         https://bugs.webkit.org/show_bug.cgi?id=196061
1380         <rdar://problem/48649391>
1381
1382         Reviewed by Brady Eidson.
1383
1384         Added API tests and related infrastructure.
1385
1386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1387         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1388         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1389         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1390         (TestWebKitAPI::TEST):
1391         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1392         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1393         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1394         * TestWebKitAPI/cocoa/TestProtocol.mm:
1395         (-[TestProtocol startLoading]):
1396         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1397         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1398         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1399         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1400
1401 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1402
1403         REGRESSSION (r243297): webkitpy tests broken
1404         https://bugs.webkit.org/show_bug.cgi?id=196108
1405
1406         Reviewed by Aakash Jain.
1407
1408         r243297 updated contributors.json, which broke a few unit tests.
1409
1410         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1411         (IRCCommandTest.test_whois):
1412         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1413
1414 2019-03-21  Chris Dumez  <cdumez@apple.com>
1415
1416         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1417         https://bugs.webkit.org/show_bug.cgi?id=196041
1418         <rdar://problem/49083230>
1419
1420         Reviewed by Alex Christensen.
1421
1422         Add API test coverage.
1423
1424         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1425         (TEST):
1426
1427 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1428
1429         Add SPI to inform applications of WKContentRuleList actions
1430         https://bugs.webkit.org/show_bug.cgi?id=195965
1431         <rdar://problem/42664365>
1432
1433         Reviewed by Geoff Garen.
1434
1435         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1436         (TestWebKitAPI::allActionsForResourceLoad):
1437         (TestWebKitAPI::testRequest):
1438         (TestWebKitAPI::TEST_F):
1439         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1440         (Notification::description):
1441         (Notification::operator== const):
1442         (toVector):
1443         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1444         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1445         (makeContentRuleList):
1446         (TEST):
1447         (makeWarnContentRuleList): Deleted.
1448
1449 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1450
1451         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1452         https://bugs.webkit.org/show_bug.cgi?id=196088
1453
1454         Reviewed by Brian Burg.
1455
1456         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1457         Support checks when only one platform is specified. Also deprecate macosx() and
1458         force the use of macos() instead.
1459
1460         * Scripts/webkitpy/style/checkers/cpp.py:
1461         (check_min_versions_of_wk_api_available):
1462         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1463         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1464
1465 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1466
1467         Update status inactive committers' status to 'contributor'.
1468
1469         * Scripts/webkitpy/common/config/contributors.json:
1470
1471 2019-03-21  Xan Lopez  <xan@igalia.com>
1472
1473         [JSC][x86] Drop support for x87 floating point
1474         https://bugs.webkit.org/show_bug.cgi?id=194853
1475
1476         Reviewed by Don Olmstead.
1477
1478         Force SSE2 on x86/32bit builds.
1479
1480         * Scripts/webkitdirs.pm:
1481         (generateBuildSystemFromCMakeProject):
1482
1483 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1484
1485         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1486         https://bugs.webkit.org/show_bug.cgi?id=196073
1487
1488         Reviewed by Michael Catanzaro.
1489
1490         Add test cases to check functions and constructors with no arguments but receiving user data.
1491
1492         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1493         (checkUserData):
1494         (testJSCFunction):
1495         (fooCreateWithUserData):
1496         (testJSCClass):
1497
1498 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1499
1500         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1501
1502         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1503
1504         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1505
1506 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1507
1508         [GTK][WPE] Add API to provide geolocation information
1509         https://bugs.webkit.org/show_bug.cgi?id=195940
1510
1511         Reviewed by Michael Catanzaro.
1512
1513         Add a new test to check the new API.
1514
1515         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1516         (testGeolocationManagerCurrentPosition):
1517         (testGeolocationManagerWatchPosition):
1518         (beforeAll):
1519         (afterAll):
1520         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1521         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1522         (beforeAll): Ditto.
1523         * TestWebKitAPI/glib/CMakeLists.txt:
1524
1525 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1526
1527         [GLib] Returning G_TYPE_OBJECT from a method does not work
1528         https://bugs.webkit.org/show_bug.cgi?id=195574
1529
1530         Reviewed by Michael Catanzaro.
1531
1532         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1533
1534         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1535         (getGFile):
1536         (getParent):
1537         (createGString):
1538         (getGString):
1539         (getGStringCopyWillRaise):
1540         (getGStringCopy):
1541         (getGStringStr):
1542         (getGStringLen):
1543         (freeGString):
1544         (testJSCClass):
1545
1546 2019-03-20  Saam Barati  <sbarati@apple.com>
1547
1548         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1549         https://bugs.webkit.org/show_bug.cgi?id=195721
1550
1551         Reviewed by Filip Pizlo.
1552
1553         * Scripts/run-javascriptcore-tests:
1554
1555 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1556
1557         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1558         https://bugs.webkit.org/show_bug.cgi?id=196049
1559
1560         Reviewed by Tim Horton.
1561
1562         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1563         overflow scrolling in general, so rename it.
1564
1565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1566
1567 2019-03-20  Daniel Bates  <dabates@apple.com>
1568
1569         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1570         https://bugs.webkit.org/show_bug.cgi?id=196031
1571         <rdar://problem/49078172>
1572
1573         Reviewed by Tim Horton.
1574
1575         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1576         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1577         same code path used when the Done button is pressed to dismiss the <select> picker.
1578
1579         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1580         (TestWebKitAPI::TEST):
1581
1582 2019-03-20  Chris Dumez  <cdumez@apple.com>
1583
1584         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1585         https://bugs.webkit.org/show_bug.cgi?id=196029
1586         <rdar://problem/48954651>
1587
1588         Reviewed by Tim Horton.
1589
1590         Add API test coverage.
1591
1592         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1593
1594 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1595
1596         [ews-build] Improve failure summary string for ApplyPatch step
1597         https://bugs.webkit.org/show_bug.cgi?id=195995
1598
1599         Reviewed by Alexey Proskuryakov.
1600
1601         * BuildSlaveSupport/ews-build/steps.py:
1602         (ApplyPatch.getResultSummary): Override getResultSummary.
1603
1604 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1605
1606         AX: Implement support for new meter ARIA role
1607         https://bugs.webkit.org/show_bug.cgi?id=195966
1608
1609         Reviewed by Chris Fleizach.
1610
1611         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1612         to AXLevelIndicator.
1613
1614         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1615
1616 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1617
1618         [WebAuthN] Implement FIDO AppID extension
1619         https://bugs.webkit.org/show_bug.cgi?id=143491
1620         <rdar://problem/48298273>
1621
1622         Reviewed by Brent Fulgham.
1623
1624         Add a test that covers the new flag of convertToU2fSignCommand.
1625
1626         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1627         (TestWebKitAPI::TEST):
1628         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1629         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1630         (TestWebKitAPI::TEST):
1631
1632 2019-03-19  Keith Rollin  <krollin@apple.com>
1633
1634         Add support for more platforms to generate-xcfilelists
1635         https://bugs.webkit.org/show_bug.cgi?id=195977
1636
1637         Reviewed by Alexey Proskuryakov.
1638
1639         generate-xcfilelists incorrectly complains when involved with building
1640         WebKit for iphonesimulator:
1641
1642             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1643             …
1644             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1645
1646         Address this by teaching generate-xcfilelists about more platforms.
1647
1648         * Scripts/generate-xcfilelists:
1649
1650 2019-03-19  John Wilander  <wilander@apple.com>
1651
1652         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1653         https://bugs.webkit.org/show_bug.cgi?id=195923
1654         <rdar://problem/49001272>
1655
1656         Reviewed by Alex Christensen.
1657
1658         This patch does the following to the TestRunner:
1659         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1660         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1661         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1662
1663         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1664         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1665         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1666         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1667         * WebKitTestRunner/TestController.cpp:
1668         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1669         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1670         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1671         * WebKitTestRunner/TestController.h:
1672         * WebKitTestRunner/TestInvocation.cpp:
1673         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1674
1675 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1676
1677         [CMake] Support more clang and gcc sanitizers
1678         https://bugs.webkit.org/show_bug.cgi?id=195956
1679
1680         Reviewed by Michael Catanzaro.
1681
1682         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1683
1684 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1685
1686         [ews-build] Improve summary for PrintConfiguration step
1687         https://bugs.webkit.org/show_bug.cgi?id=195945
1688
1689         Reviewed by Lucas Forschler.
1690
1691         * BuildSlaveSupport/ews-build/steps.py:
1692         (PrintConfiguration.getResultSummary): Override getResultSummary.
1693
1694 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1695
1696         [ews-build] Improve summary for CheckOutSource step
1697         https://bugs.webkit.org/show_bug.cgi?id=195963
1698
1699         Reviewed by Lucas Forschler.
1700
1701         * BuildSlaveSupport/ews-build/steps.py:
1702         (CheckOutSource.getResultSummary):
1703
1704 2019-03-19  Daniel Bates  <dabates@apple.com>
1705
1706         [iOS] Focus not preserved when switching between tabs
1707         https://bugs.webkit.org/show_bug.cgi?id=195820
1708         <rdar://problem/43614450>
1709
1710         Reviewed by Brent Fulgham.
1711
1712         Add tests to ensure that we restore focus when resigning and becoming first responder.
1713
1714         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1715         (TestWebKitAPI::TEST):
1716
1717 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1718
1719         Make WTFLogChannelState and WTFLogLevel enum classes
1720         https://bugs.webkit.org/show_bug.cgi?id=195904
1721
1722         Reviewed by Eric Carlson.
1723
1724         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1725         (TestWebKitAPI::TEST_F):
1726
1727 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1728
1729         [GStreamer][EME] Backported mssdemux protection data crash fix
1730         https://bugs.webkit.org/show_bug.cgi?id=195918
1731
1732         Reviewed by Philippe Normand.
1733
1734         * gstreamer/jhbuild.modules:
1735         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1736
1737 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1738
1739         Unreviewed, rolling out r243132.
1740
1741         Broke GTK build
1742
1743         Reverted changeset:
1744
1745         "Make WTFLogChannelState and WTFLogLevel enum classes"
1746         https://bugs.webkit.org/show_bug.cgi?id=195904
1747         https://trac.webkit.org/changeset/243132
1748
1749 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1750
1751         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1752
1753         * Scripts/webkitdirs.pm:
1754         (builtDylibPathForName): Adjust the shared library name that's changed
1755         with the API version bump in r243073.
1756
1757 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1758
1759         Make WTFLogChannelState and WTFLogLevel enum classes
1760         https://bugs.webkit.org/show_bug.cgi?id=195904
1761
1762         Reviewed by Eric Carlson.
1763
1764         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1765         (TestWebKitAPI::TEST_F):
1766
1767 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1768
1769         Disable flaky test added in r2431100
1770         https://webkit.org/b/195785
1771
1772         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1773         (TestWebKitAPI::TEST):
1774         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1775
1776 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1777
1778         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1779         https://bugs.webkit.org/show_bug.cgi?id=195916
1780
1781         Reviewed by Tim Horton.
1782
1783         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1784         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1785
1786 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1787
1788         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1789
1790         * Scripts/webkitpy/common/config/contributors.json:
1791
1792 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1793
1794         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1795         https://bugs.webkit.org/show_bug.cgi?id=195785
1796
1797         Reviewed by Geoffrey Garen.
1798
1799         * TestWebKitAPI/TCPServer.cpp: Added.
1800         (TestWebKitAPI::TCPServer::TCPServer):
1801         (TestWebKitAPI::TCPServer::~TCPServer):
1802         (TestWebKitAPI::TCPServer::socketBindListen):
1803         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1804         * TestWebKitAPI/TCPServer.h: Added.
1805         (TestWebKitAPI::TCPServer::port const):
1806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1807         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1808         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1809         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1810         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1811         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1812         (TestWebKitAPI::respondSlowly):
1813         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1814         (TestWebKitAPI::downloadAtRate):
1815         (TestWebKitAPI::TEST):
1816
1817 2019-03-18  Saam Barati  <sbarati@apple.com>
1818
1819         Add a plan file for JetStream 2
1820         https://bugs.webkit.org/show_bug.cgi?id=190734
1821
1822         Reviewed by Mark Lam.
1823
1824         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1825
1826 2019-03-18  Chris Dumez  <cdumez@apple.com>
1827
1828         Delay WebProcess launch until a load is triggered in a Web view
1829         https://bugs.webkit.org/show_bug.cgi?id=195758
1830         <rdar://problem/48126013>
1831
1832         Reviewed by Geoff Garen.
1833
1834         Add API test coverage. Also update some existing API tests to not expect
1835         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1836
1837         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1838         (TestWebKitAPI::TEST):
1839         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1840         (TestWebKitAPI::TEST):
1841         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1842         (TEST):
1843         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1844         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1845         (TEST):
1846         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1847         (TEST):
1848         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1849
1850 2019-03-18  Xan Lopez  <xan@igalia.com>
1851
1852         [CMake] Prevent potential warning when determining $architecture
1853         https://bugs.webkit.org/show_bug.cgi?id=195891
1854
1855         Reviewed by Michael Catanzaro.
1856
1857         It's possible for generateBuildSystemForCMakeProject to be called
1858         before determineArchitecture() is ever called. This will make the
1859         first eq check with $architecture to be bogus (and print a
1860         warning). Change that to an eq check with architecture(), which
1861         implicitly calls determineArchitecture() if needed, and change all
1862         the other similar cases in the method in the same way to prevent
1863         future bugs like this one.
1864
1865         * Scripts/webkitdirs.pm:
1866         (generateBuildSystemFromCMakeProject):
1867
1868 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1869
1870         [WPE] Tarballs generated with “make dist” cannot build documentation
1871         https://bugs.webkit.org/show_bug.cgi?id=195885
1872
1873         Reviewed by Carlos Garcia Campos.
1874
1875         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1876
1877 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1878
1879         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1880         https://bugs.webkit.org/show_bug.cgi?id=195883
1881
1882         Reviewed by Carlos Garcia Campos.
1883
1884         * gtkdoc/gtkdoc.py:
1885         (GTKDoc._run_command): When commands fail to run, include the full command line for
1886         the program invocation and the output it has generated on the standard error stream.
1887
1888 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1889
1890         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1891         https://bugs.webkit.org/show_bug.cgi?id=195786
1892
1893         Reviewed by Philippe Normand.
1894
1895         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1896         * wpe/jhbuild.modules: Ditto.
1897
1898 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1899
1900         [ews-build] Don't run clean builds on EWS builders
1901         https://bugs.webkit.org/show_bug.cgi?id=195851
1902
1903         Reviewed by Geoffrey Garen.
1904
1905         * BuildSlaveSupport/ews-build/factories.py:
1906
1907 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1908
1909         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1910         https://bugs.webkit.org/show_bug.cgi?id=195849
1911
1912         Reviewed by Chris Dumez.
1913
1914         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1917         (runWebsiteDataStoreCustomPaths):
1918
1919 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1920
1921         webkitpy: Upload test results
1922         https://bugs.webkit.org/show_bug.cgi?id=195755
1923         <rdar://problem/48896182>
1924
1925         Reviewed by Aakash Jain.
1926
1927         Establish a new format for uploading results that is not tied to layout tests, apply
1928         that format to webkitpy tests.
1929
1930         * Scripts/webkitpy/common/checkout/scm/git.py:
1931         (Git.native_branch): Return what branch the current checkout is on.
1932         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1933         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1934         * Scripts/webkitpy/common/checkout/scm/svn.py:
1935         (SVN.native_branch): Ditto.
1936         * Scripts/webkitpy/common/system/platforminfo.py:
1937         (PlatformInfo.build_version): Return a build version for Mac.
1938         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1939         (MockPlatformInfo.__init__):
1940         (MockPlatformInfo.build_version):
1941         * Scripts/webkitpy/results: Added.
1942         * Scripts/webkitpy/results/__init__.py: Added.
1943         * Scripts/webkitpy/results/options.py: Added.
1944         (upload_options): OptParse list for upload options.
1945         * Scripts/webkitpy/results/upload.py: Added.
1946         (Upload): Class which enforces the upload format expected by the results server.
1947         (Upload.Expectations):
1948         (Upload.create_configuration):
1949         (Upload.create_commit):
1950         (Upload.create_details):
1951         (Upload.create_run_stats):
1952         (Upload.create_test_result):
1953         (Upload.__init__):
1954         (Upload.Encoder): Encode Upload object as json.
1955         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1956         * Scripts/webkitpy/results/upload_unittest.py: Added.
1957         * Scripts/webkitpy/test/main.py:
1958         (Tester._parse_args): Add upload arguments.
1959         (Tester._run_tests): Allow results to be uploaded.
1960         * Scripts/webkitpy/test/runner.py:
1961         (Runner.__init__): Record which tests were run, rather than just counting them.
1962         (Runner.handle):
1963         * Scripts/webkitpy/test/runner_unittest.py:
1964         (RunnerTest.test_run):
1965         * Scripts/webkitpy/thirdparty/__init__.py:
1966         (AutoinstallImportHook.find_module): Add requests auto-install.
1967         (AutoinstallImportHook._install_requests):
1968         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1969         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1970
1971 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1972
1973         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1974         https://bugs.webkit.org/show_bug.cgi?id=195810
1975
1976         Reviewed by Tim Horton.
1977
1978         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1979         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1980         ending certain layout tests.
1981
1982         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1983         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1984         (-[TestRunnerWKWebView dealloc]):
1985         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1986
1987         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1988         helper method when destroying the web view, and when resetting state between tests.
1989
1990         * WebKitTestRunner/ios/TestControllerIOS.mm:
1991         (WTR::TestController::platformResetStateToConsistentValues):
1992
1993         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1994
1995 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1996
1997         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1998         https://bugs.webkit.org/show_bug.cgi?id=190350
1999         <rdar://problem/45089503>
2000
2001         Reviewed by Geoffrey Garen.
2002
2003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2004         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2005         (TEST):
2006         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2007         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2008         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2009         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2010         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2011         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2012         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2013         (runTest):
2014         (createDirectories):
2015         (TEST):
2016         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2017         (TEST):
2018         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2019         (TEST):
2020
2021 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2022
2023         Add support to WebPage for getting the contents as an attributed string.
2024         https://bugs.webkit.org/show_bug.cgi?id=195636
2025         rdar://problem/45055697
2026
2027         Reviewed by Tim Horton.
2028
2029         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2030         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2031
2032 2019-03-15  Chris Dumez  <cdumez@apple.com>
2033
2034         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2035         https://bugs.webkit.org/show_bug.cgi?id=195747
2036
2037         Reviewed by Geoff Garen.
2038
2039         Add API test coverage.
2040
2041         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2042
2043 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2044
2045         Unreviewed, rolling out r242952.
2046
2047         Causing API failures on iOS Simulator
2048
2049         Reverted changeset:
2050
2051         "[PSON] Make sure the WebProcessCache is leverage when
2052         relaunching a process after termination"
2053         https://bugs.webkit.org/show_bug.cgi?id=195747
2054         https://trac.webkit.org/changeset/242952
2055
2056 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2057
2058         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2059         https://bugs.webkit.org/show_bug.cgi?id=195740
2060
2061         Reviewed by Ross Kirsling.
2062
2063         window.open doesn't work for WebKitBrowserWindow because it is not
2064         implemented yet.
2065
2066         1. Implemented createNewPage callback of WKPageUIClient.
2067         2. Changed MainWindow to take a BrowserWindow factory function
2068           instead of BrowserWindowType to be flexible to create
2069           BrowserWindow with extra settings.
2070         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2071           because it is not relevant with MainWindow anymore.
2072
2073         * MiniBrowser/win/Common.cpp:
2074         (parseCommandLine):
2075         * MiniBrowser/win/Common.h:
2076         (CommandLineOptions::CommandLineOptions):
2077         * MiniBrowser/win/MainWindow.cpp:
2078         (MainWindow::MainWindow):
2079         (MainWindow::create):
2080         (MainWindow::init):
2081         (MainWindow::WndProc):
2082         * MiniBrowser/win/MainWindow.h:
2083         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2084         (PrintWebUIDelegate::createWebViewWithRequest):
2085         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2086         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2087         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2088         (WebKitBrowserWindow::updateProxySettings):
2089         (WebKitBrowserWindow::createNewPage):
2090         * MiniBrowser/win/WebKitBrowserWindow.h:
2091         * MiniBrowser/win/WinMain.cpp:
2092         (wWinMain):
2093
2094 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2095
2096         Make it possible to test scrolling tree layer manipulation more easily
2097         https://bugs.webkit.org/show_bug.cgi?id=195780
2098
2099         Reviewed by Tim Horton.
2100         
2101         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2102         cuts off communication of scrolling tree scrolls back to the web process
2103         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2104         allows tests to trigger scrolls which run the scrolling tree layer positioning
2105         logic, but never get another commit from the web process that might mask
2106         scrolling tree bugs.
2107         
2108         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2109         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2110         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2111
2112         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2113         (WTR::UIScriptController::scrollUpdatesDisabled const):
2114         (WTR::UIScriptController::setScrollUpdatesDisabled):
2115         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2116         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2117         (WTR::UIScriptController::scrollUpdatesDisabled const):
2118         (WTR::UIScriptController::setScrollUpdatesDisabled):
2119         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2120         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2121         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2122         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2123         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2124         * WebKitTestRunner/ios/TestControllerIOS.mm:
2125         (WTR::TestController::platformResetStateToConsistentValues):
2126         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2127         (WTR::UIScriptController::scrollUpdatesDisabled const):
2128         (WTR::UIScriptController::setScrollUpdatesDisabled):
2129
2130 2019-03-14  Youenn Fablet  <youenn@apple.com>
2131
2132         Move IDB storage in private browsing mode to NetworkProcess
2133         https://bugs.webkit.org/show_bug.cgi?id=195602
2134
2135         Reviewed by Brady Eidson.
2136
2137         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2138         (TEST):
2139
2140 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2141
2142         [ews-build] Make descriptionDone messages more readable
2143         https://bugs.webkit.org/show_bug.cgi?id=195760
2144
2145         Reviewed by Lucas Forschler.
2146
2147         * BuildSlaveSupport/ews-build/steps.py:
2148         * BuildSlaveSupport/ews-build/steps_unittest.py:
2149
2150 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2151
2152         [ews-build] Generate status-bubble hover-over messages
2153         https://bugs.webkit.org/show_bug.cgi?id=195680
2154
2155         Reviewed by Lucas Forschler.
2156
2157         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2158         (StatusBubble):
2159         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2160         on hover-over.
2161         (StatusBubble._iso_time):
2162         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2163         hover-over message.
2164         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2165
2166 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2167
2168         [ews-app] Gracefully handle the case when state_string is None
2169         https://bugs.webkit.org/show_bug.cgi?id=195753
2170
2171         Reviewed by Lucas Forschler.
2172
2173         * BuildSlaveSupport/ews-app/ews/models/build.py:
2174         * BuildSlaveSupport/ews-app/ews/models/step.py:
2175
2176 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2177
2178         [ews-app] Status bubble display pending for currently running build step
2179         https://bugs.webkit.org/show_bug.cgi?id=195744
2180
2181         Reviewed by Lucas Forschler.
2182
2183         * BuildSlaveSupport/ews-build/events.py:
2184         (Events.stepStarted): If state_string is pending, replace it with step name.
2185
2186 2019-03-14  Chris Dumez  <cdumez@apple.com>
2187
2188         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2189         https://bugs.webkit.org/show_bug.cgi?id=195750
2190
2191         Reviewed by Geoffrey Garen.
2192
2193         Add API test coverage.
2194
2195         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2196         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2197         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2198         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2199
2200 2019-03-14  Chris Dumez  <cdumez@apple.com>
2201
2202         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2203         https://bugs.webkit.org/show_bug.cgi?id=195747
2204
2205         Reviewed by Geoff Garen.
2206
2207         Add API test coverage.
2208
2209         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2210
2211 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2212
2213         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2214         https://bugs.webkit.org/show_bug.cgi?id=195725
2215         <rdar://problem/48545062>
2216
2217         Reviewed by Tim Horton.
2218
2219         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2220         handler is nil.
2221
2222         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2223         (TestWebKitAPI::TEST):
2224
2225 2019-03-13  Sam Weinig  <sam@webkit.org>
2226
2227         Add utility function to allow easy reverse range-based iteration of a container
2228         https://bugs.webkit.org/show_bug.cgi?id=195542
2229
2230         Reviewed by Antti Koivisto.
2231
2232         * TestWebKitAPI/CMakeLists.txt:
2233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2234         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2235         (TestWebKitAPI::TEST):
2236         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2237
2238 2019-03-13  Chris Dumez  <cdumez@apple.com>
2239
2240         Use a ServiceWorker process per registrable domain
2241         https://bugs.webkit.org/show_bug.cgi?id=195649
2242
2243         Reviewed by Youenn Fablet.
2244
2245         Update API test coverage.
2246
2247         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2248
2249 2019-03-13  Chris Dumez  <cdumez@apple.com>
2250
2251         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2252         https://bugs.webkit.org/show_bug.cgi?id=195684
2253         <rdar://problem/48294714>
2254
2255         Reviewed by Antti Koivisto.
2256
2257         Add API test coverage.
2258
2259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2260
2261 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2262
2263         [ews-app] Remove unused patch view
2264         https://bugs.webkit.org/show_bug.cgi?id=195669
2265
2266         Reviewed by Lucas Forschler.
2267
2268         * BuildSlaveSupport/ews-app/ews/urls.py:
2269         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2270
2271 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2272
2273         [ews-app] Use Buildbot result code variables
2274         https://bugs.webkit.org/show_bug.cgi?id=195668
2275
2276         Reviewed by Alexey Proskuryakov.
2277
2278         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2279         (Buildbot): Added Buildbot result code variables.
2280         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2281         (StatusBubble._build_bubble): Used Buildbot result code variables.
2282
2283 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2284
2285         [Flatpak] Expand submodule recursively
2286         https://bugs.webkit.org/show_bug.cgi?id=195672
2287
2288         Building WPE with flatpak was impossible without that as it was raising an exception.
2289         Also update wpebackend-fdo to match what is built in jhbuild
2290
2291         Reviewed by Philippe Normand.
2292
2293         * flatpak/flatpakutils.py:
2294         (expand_submodules_recurse):
2295         (expand_manifest):
2296         * flatpak/org.webkit.WPEModules.yaml:
2297
2298 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2299
2300         [ews-app] status bubble should be hidden for certain builds
2301         https://bugs.webkit.org/show_bug.cgi?id=194597
2302
2303         Reviewed by Dewei Zhu.
2304
2305         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2306         (StatusBubble._build_bubble):
2307         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2308         because the patch didn't have relevant changes.
2309         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2310         in production yet.
2311
2312 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2313
2314         [Win] Fix a slew of simple clang-cl warnings.
2315         https://bugs.webkit.org/show_bug.cgi?id=195652
2316
2317         Reviewed by Don Olmstead.
2318
2319         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2320         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2321
2322 2019-03-12  Justin Fan  <justin_fan@apple.com>
2323
2324         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2325         https://bugs.webkit.org/show_bug.cgi?id=195518
2326         <rdar://problem/46322356>
2327
2328         Reviewed by Myles C. Maxfield.
2329
2330         * DumpRenderTree/DerivedSources-input.xcfilelist:
2331         * DumpRenderTree/DerivedSources-output.xcfilelist:
2332
2333 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2334
2335         Unreviewed, rolling out r242825.
2336         https://bugs.webkit.org/show_bug.cgi?id=195648
2337
2338         "Broke webkitpy tests with my change to
2339         lldb_dump_class_layout.py" (Requested by rmorisset on
2340         #webkit).
2341
2342         Reverted changeset:
2343
2344         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2345         classes with suspicious padding"
2346         https://bugs.webkit.org/show_bug.cgi?id=195573
2347         https://trac.webkit.org/changeset/242825
2348
2349 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2350
2351         [ews-build] Show status bubbles while the patch is waiting in queue
2352         https://bugs.webkit.org/show_bug.cgi?id=195618
2353
2354         Reviewed by Lucas Forschler.
2355
2356         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2357         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2358         enabled in initial deployment.
2359         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2360         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2361         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2362         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2363         (StatusBubble._build_bubbles_for_patch):
2364
2365 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2366
2367         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2368         https://bugs.webkit.org/show_bug.cgi?id=195573
2369
2370         Reviewed by Simon Fraser.
2371
2372         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2373
2374         * Scripts/dump-class-layout:
2375         (main):
2376         * lldb/lldb_dump_class_layout.py:
2377         (ClassLayout.__init__):
2378         (ClassLayout._compute_padding_recursive):
2379         (LLDBDebuggerInstance.dump_layout_for_classname):
2380         (LLDBDebuggerInstance):
2381         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2382         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2383
2384 2019-03-12  Chris Dumez  <cdumez@apple.com>
2385
2386         Device Orientation access permission should be denied unless explicitly granted by the client
2387         https://bugs.webkit.org/show_bug.cgi?id=195625
2388
2389         Reviewed by Youenn Fablet.
2390
2391         add API test coverage.
2392
2393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2394         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2395         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2396         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2397         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2398         (runDeviceOrientationTest):
2399         (TEST):
2400         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2401         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2402
2403 2019-03-12  Jer Noble  <jer.noble@apple.com>
2404
2405         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2406         https://bugs.webkit.org/show_bug.cgi?id=195137
2407         <rdar://problem/48810307>
2408
2409         Reviewed by Eric Carlson.
2410
2411         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2412         (TestWebKitAPI::TEST):
2413
2414 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2415
2416         [ews-build] Change urls from uat to production
2417         https://bugs.webkit.org/show_bug.cgi?id=195566
2418
2419         Reviewed by Lucas Forschler.
2420
2421         * BuildSlaveSupport/ews-app/ews/config.py:
2422         * BuildSlaveSupport/ews-build/events.py:
2423         * BuildSlaveSupport/ews-build/steps.py:
2424
2425 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2426
2427         [ews-build] change max_builds for local-worker to 1
2428         https://bugs.webkit.org/show_bug.cgi?id=195568
2429
2430         Reviewed by Lucas Forschler.
2431
2432         * BuildSlaveSupport/ews-build/loadConfig.py:
2433
2434 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2435
2436         Fix the build
2437
2438         * TestRunnerShared/spi/PencilKitTestSPI.h:
2439         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2440
2441 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2442
2443         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2444         https://bugs.webkit.org/show_bug.cgi?id=194131
2445
2446         Reviewed by Michael Catanzaro.
2447
2448         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2449         (uriChanged):
2450         (testUnfinishedSubresourceLoad):
2451         (serverCallback):
2452         (beforeAll):
2453
2454 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2455
2456         WTF::Expected should use std::addressof instead of operator&
2457         https://bugs.webkit.org/show_bug.cgi?id=195604
2458
2459         Reviewed by Myles Maxfield.
2460
2461         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2462         (TestWebKitAPI::Unique::Unique):
2463         (TestWebKitAPI::Unique::operator&):
2464         (TestWebKitAPI::TEST):
2465
2466 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2467
2468         Add Optional to Forward.h.
2469         https://bugs.webkit.org/show_bug.cgi?id=195586
2470
2471         Reviewed by Darin Adler.
2472
2473         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2474         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2475         Remove unnecessary includes from headers.
2476
2477 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2478
2479         Add testing API to hit-test and scroll overflow scrollers
2480         https://bugs.webkit.org/show_bug.cgi?id=195278
2481
2482         Reviewed by Antti Koivisto.
2483         
2484         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2485         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2486         
2487         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2488
2489         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2490         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2491         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2492         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2493         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2494         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2495         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2496         (WTR::enclosingScrollViewIncludingSelf):
2497         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2498
2499 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2500
2501         API test WebKit.RequestTextInputContext fails on iOS
2502         https://bugs.webkit.org/show_bug.cgi?id=195585
2503
2504         Reviewed by Wenson Hsieh and Simon Fraser.
2505
2506         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2507         (applyStyle):
2508         (TEST):
2509         Add a viewport, so that the coordinates match up on iOS.
2510         Scroll by moving the UIScrollView's contentOffset.
2511
2512 2019-03-11  Chris Dumez  <cdumez@apple.com>
2513
2514         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2515         https://bugs.webkit.org/show_bug.cgi?id=195506
2516         <rdar://problem/48733477>
2517
2518         Reviewed by Alex Christensen.
2519
2520         Add API test coverage.
2521
2522         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2523
2524 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2525
2526         Adding myself to contributors.json
2527
2528         Unreviewed, addming myself to contributors.json .
2529
2530         * Scripts/webkitpy/common/config/contributors.json:
2531
2532 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2533
2534         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2535         https://bugs.webkit.org/show_bug.cgi?id=195511
2536         <rdar://problem/44873269>
2537
2538         Reviewed by Darin Adler.
2539
2540         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2541         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2542         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2543         (TEST_F):
2544
2545 2019-03-11  Chris Dumez  <cdumez@apple.com>
2546
2547         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2548         https://bugs.webkit.org/show_bug.cgi?id=195561
2549
2550         Reviewed by Youenn Fablet.
2551
2552         Make sure the JS in the test requests for permission to receive device orientation events.
2553
2554         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2555
2556 2019-03-11  Youenn Fablet  <youenn@apple.com>
2557
2558         Allow storage quota increase by default in WTR
2559         https://bugs.webkit.org/show_bug.cgi?id=195541
2560
2561         Reviewed by Geoffrey Garen.
2562
2563         Allow storage quota increase by default in WTR.
2564         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2565         Use this for tests that explicitly need cache increase.
2566
2567         Instead of increasing quota by 2, make sure the next request is
2568         granted by adding all given parameters.
2569
2570         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2572         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2573         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2574         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2575         * WebKitTestRunner/TestController.cpp:
2576         (WTR::TestController::setAllowStorageQuotaIncrease):
2577         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2578         * WebKitTestRunner/TestController.h:
2579         * WebKitTestRunner/TestInvocation.cpp:
2580         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2581         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2582         (WTR::TestController::cocoaResetStateToConsistentValues):
2583         (WTR::TestController::setAllowStorageQuotaIncrease):
2584         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2585         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2586         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2587
2588 2019-03-11  Xan Lopez  <xan@igalia.com>
2589
2590         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2591         https://bugs.webkit.org/show_bug.cgi?id=194147
2592
2593         Reviewed by Michael Saboff.
2594
2595         To make --32-bit work correctly on Linux/64bit we need to:
2596
2597         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2598         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2599         unfortunately CMake only allows us to do this during
2600         crosscompilation, which is overkill here.
2601         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2602         pkg-config detection module uses the x86 .pc files instead of the
2603         x86_64 ones.
2604         - Set the -m32 flags for the compiler.
2605
2606         * Scripts/webkitdirs.pm:
2607         (generateBuildSystemFromCMakeProject):
2608
2609 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2610
2611         Add MotionMark-1.1 plan file for run-benchmark script.
2612         https://bugs.webkit.org/show_bug.cgi?id=195481
2613
2614         Rubber-stamped by Darin Adler.
2615
2616         Run-benchmark script should support MontionMark-1.1.
2617
2618         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2619
2620 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2621
2622         [ews-app] Add support for submit-to-ews url
2623         https://bugs.webkit.org/show_bug.cgi?id=195477
2624
2625         Reviewed by Lucas Forschler.
2626
2627         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2628         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2629         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2630         * BuildSlaveSupport/ews-app/ews/urls.py:
2631         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2632
2633 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2634
2635         Unreviewed, rolling out r242688, r242643, r242624.
2636
2637         Caused multiple layout test failures and crashes on iOS and macOS.
2638
2639         Reverted changeset:
2640
2641         "requestAnimationFrame should execute before the next frame"
2642         https://bugs.webkit.org/show_bug.cgi?id=177484
2643         https://trac.webkit.org/changeset/242624/webkit
2644
2645         * Tracing/SystemTracePoints.plist:
2646
2647 2019-03-11  John Wilander  <wilander@apple.com>
2648
2649         Resource Load Statistics: Make it possible exclude localhost from classification
2650         https://bugs.webkit.org/show_bug.cgi?id=195474
2651         <rdar://problem/47520577>
2652
2653         Reviewed by Brent Fulgham.
2654
2655         This patch allows for localhost to be excluded from classification and
2656         treatment as a prevalent resource.
2657
2658         The WebKit Tools change adds a new function called
2659         testRunner.setStatisticsIsRunningTest() which can be used to control this
2660         behavior.
2661
2662         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2663         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2664         (WTR::TestRunner::setStatisticsIsRunningTest):
2665         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2666         * WebKitTestRunner/TestController.cpp:
2667         (WTR::TestController::setStatisticsIsRunningTest):
2668         * WebKitTestRunner/TestController.h:
2669         * WebKitTestRunner/TestInvocation.cpp:
2670         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2671
2672 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2673
2674         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2675         https://bugs.webkit.org/show_bug.cgi?id=195560
2676
2677         Reviewed by Lucas Forschler.
2678
2679         * BuildSlaveSupport/ews-build/master.cfg:
2680
2681 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2682
2683         Unreviewed, rolling out r242698.
2684
2685         API test crashes on bots.
2686
2687         Reverted changeset:
2688
2689         "Add a WKContentRuleList variant that uses copied memory
2690         instead of mmap'd shared memory for class A containerized
2691         apps"
2692         https://bugs.webkit.org/show_bug.cgi?id=195511
2693         https://trac.webkit.org/changeset/242698
2694
2695 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2696
2697         [WPE] Enable web process sandbox
2698         https://bugs.webkit.org/show_bug.cgi?id=195169
2699
2700         Reviewed by Daniel Bates.
2701
2702         * wpe/install-dependencies:
2703         * wpe/jhbuild.modules:
2704
2705 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2706
2707         [ews-app] Use port 17000 for worker communication
2708         https://bugs.webkit.org/show_bug.cgi?id=195558
2709
2710         Reviewed by Lucas Forschler.
2711
2712         * BuildSlaveSupport/ews-build/master.cfg:
2713
2714 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2715
2716         [ews-build] unit-tests fail when passwords.json is missing
2717         https://bugs.webkit.org/show_bug.cgi?id=195557
2718
2719         Reviewed by Lucas Forschler.
2720
2721         * BuildSlaveSupport/ews-build/loadConfig.py:
2722         (loadBuilderConfig):
2723         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2724         (ConfigDotJSONTest.test_configuration):
2725         * BuildSlaveSupport/ews-build/master.cfg:
2726
2727 2019-03-11  Truitt Savell  <tsavell@apple.com>
2728
2729         Unreviewed, rolling out r242702.
2730
2731         Broke High Sierra builders.
2732
2733         Reverted changeset:
2734
2735         "Add utility function to allow easy reverse range-based
2736         iteration of a container"
2737         https://bugs.webkit.org/show_bug.cgi?id=195542
2738         https://trac.webkit.org/changeset/242702
2739
2740 2019-03-11  Sam Weinig  <sam@webkit.org>
2741
2742         Add utility function to allow easy reverse range-based iteration of a container
2743         https://bugs.webkit.org/show_bug.cgi?id=195542
2744
2745         Reviewed by Antti Koivisto.
2746
2747         * TestWebKitAPI/CMakeLists.txt:
2748         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2749         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2750         (TestWebKitAPI::TEST):
2751         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2752
2753 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2754
2755         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2756         https://bugs.webkit.org/show_bug.cgi?id=195511
2757         <rdar://problem/44873269>
2758
2759         Reviewed by Darin Adler.
2760
2761         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2762         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2763         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2764         (TEST_F):
2765
2766 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2767
2768         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2769         https://bugs.webkit.org/show_bug.cgi?id=195499
2770
2771         Reviewed by Darin Adler.
2772
2773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2774         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2775         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2776         (-[WKWebView synchronouslyFocusTextInputContext:]):
2777         (applyStyle):
2778         (applyIframe):
2779         (TEST):
2780         Add some tests for this SPI.
2781
2782 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2783
2784         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2785         https://bugs.webkit.org/show_bug.cgi?id=181151
2786
2787         Reviewed by Don Olmstead.
2788
2789         * TestWebKitAPI/CMakeLists.txt:
2790         * TestWebKitAPI/PlatformWin.cmake:
2791         Enable TestWTF RunLoop tests in all platforms.
2792
2793         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2794         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2795         (TestWebKitAPI::DerivedOneShotTimer::fired):
2796         (TestWebKitAPI::TEST):
2797         Only a few platforms support nested RunLoop.
2798
2799         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2800         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2801
2802 2019-03-10  David Quesada  <david_quesada@apple.com>
2803
2804         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2805         https://bugs.webkit.org/show_bug.cgi?id=152480
2806
2807         Reviewed by Chris Dumez.
2808
2809         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2810         there are no additional references to the process pool besides the one held by
2811         the download, waits for the download to finish (in the sense that the
2812         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2813         measure, also check that the process pool has been deallocated at the end of the
2814         test. The test wouldn't be meaningful if the process pool were still alive.
2815
2816         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2817         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2818         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2819             The download will be canceled because the delegate does not implement the
2820             method to decide the download's destination, so this is where we know the
2821             DownloadProxyMap is done with the DownloadProxy.
2822         (TEST):
2823
2824 2019-03-08  Chris Dumez  <cdumez@apple.com>
2825
2826         Add support for Device Orientation / Motion permission API
2827         https://bugs.webkit.org/show_bug.cgi?id=195329
2828         <rdar://problem/47645367>
2829
2830         Reviewed by Geoffrey Garen.
2831
2832         Add test infrastructure to help test the Device Orientation / Motion permission API.
2833
2834         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2835         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2836         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2837         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2838         * WebKitTestRunner/TestController.cpp:
2839         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2840         (WTR::TestController::createWebViewWithOptions):
2841         (WTR::TestController::resetStateToConsistentValues):
2842         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2843         * WebKitTestRunner/TestController.h:
2844         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2845         * WebKitTestRunner/TestInvocation.cpp:
2846         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2847
2848 2019-03-08  Saam barati  <sbarati@apple.com>
2849
2850         Add a compare-results script to compare benchmark results
2851         https://bugs.webkit.org/show_bug.cgi?id=195486
2852         <rdar://problem/48723397>
2853
2854         Reviewed by Geoffrey Garen.
2855
2856         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2857         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2858         to extend it to learn about our other benchmarks.
2859
2860         * Scripts/compare-results: Added.
2861         (readJSONFile):
2862         (detectJetStream2):
2863         (JetStream2Results):
2864         (detectSpeedometer2):
2865         (Speedometer2Results):
2866         (detectPLT5):
2867         (PLT5Results):
2868         (detectBenchmark):
2869         (biggerIsBetter):
2870         (ttest):
2871         (getOptions):
2872         (main):
2873
2874 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2875
2876         Ensure old tab state is cleared between iterations of run-benchmark
2877         https://bugs.webkit.org/show_bug.cgi?id=195393
2878         <rdar://problem/46885583>
2879
2880         Reviewed by Dewei Zhu.
2881
2882         a) ensure the default to restore state is not set
2883         b) terminate Safari correctly
2884         c) Set the system default to ignore Persistent State in Safari
2885
2886         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2887         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2888         (OSXBrowserDriver.prepare_env): 
2889         (OSXBrowserDriver.restore_env):
2890         (OSXBrowserDriver.close_browsers):
2891         (OSXBrowserDriver._terminate_processes):
2892         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2893         (OSXChromeDriver):
2894         (OSXChromeCanaryDriver):
2895         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2896         (OSXFirefoxDriver):
2897         (OSXFirefoxNightlyDriver):
2898         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2899         (OSXSafariDriver):
2900         (OSXSafariDriver.prepare_env):
2901
2902 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2903
2904         [GTK] Several InputMethodFilter tests are failing
2905         https://bugs.webkit.org/show_bug.cgi?id=195408
2906
2907         Reviewed by Carlos Garcia Campos.
2908
2909         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2910         Regressed in r241751.
2911         Hexadecimal values of keycodes are expressed now in upper letters.
2912         Composited characters should be cast to UTF8 strings.
2913
2914         (TestWebKitAPI::TEST):
2915
2916 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2917
2918         [GTK] Make Tools/gtkdoc python3 compatible
2919         https://bugs.webkit.org/show_bug.cgi?id=195359
2920
2921         Reviewed by Carlos Garcia Campos.
2922
2923         * gtkdoc/generate-gtkdoc:
2924         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2925         work with Python 2 and 3.
2926         (get_gtkdoc_module_paths):
2927         The iteritems() was removed in Python 3, so let's use items() that's
2928         available in Python 2 and 3.
2929         (get_generator_for_config):
2930         * gtkdoc/gtkdoc.py:
2931         (GTKDoc._run_command):
2932         The sys.stdout.write() is expecting str in Python 3 and not bytes
2933         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2934         for passing the bytes there.
2935
2936 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2937
2938         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2939         https://bugs.webkit.org/show_bug.cgi?id=195346
2940         <rdar://problem/48667048>
2941
2942         Unreviewed build fix for clang-cl.
2943
2944         * DumpRenderTree/win/DumpRenderTree.cpp:
2945         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2946
2947 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2948
2949         requestAnimationFrame should execute before the next frame
2950         https://bugs.webkit.org/show_bug.cgi?id=177484
2951
2952         Reviewed by Simon Fraser.
2953
2954         Add trace points for the page RenderingUpdate.
2955
2956         * Tracing/SystemTracePoints.plist:
2957
2958 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2959
2960         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2961         https://bugs.webkit.org/show_bug.cgi?id=195353
2962         <rdar://problem/48626394>
2963
2964         Reviewed by Simon Fraser.
2965
2966         * WebKitTestRunner/ios/TestControllerIOS.mm:
2967         (WTR::TestController::platformResetPreferencesToConsistentValues):
2968
2969 2019-03-07  John Wilander  <wilander@apple.com>
2970
2971         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2972         https://bugs.webkit.org/show_bug.cgi?id=195383
2973         <rdar://problem/48570136>
2974
2975         Reviewed by Brent Fulgham.
2976
2977         This patch adds test infrastructure to purge only script-accessible cookies,
2978         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2979
2980         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2981         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2982         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2983         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2984         * WebKitTestRunner/TestController.cpp:
2985         (WTR::TestController::statisticsDeleteCookiesForHost):
2986         * WebKitTestRunner/TestController.h:
2987         * WebKitTestRunner/TestInvocation.cpp:
2988         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2989
2990 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2991
2992         Unreviewed, rolling out r242354.
2993         https://bugs.webkit.org/show_bug.cgi?id=195402
2994
2995         breaks layout tests in all configurations (Requested by
2996         zdobersek on #webkit).
2997
2998         Reverted changeset:
2999
3000         "[WPE] Enable web process sandbox"
3001         https://bugs.webkit.org/show_bug.cgi?id=195169
3002         https://trac.webkit.org/changeset/242354
3003
3004 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3005
3006         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3007         https://bugs.webkit.org/show_bug.cgi?id=195346
3008
3009         Reviewed by Fujii Hironori.
3010
3011         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3012         (TestWebKitAPI::TEST):
3013         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3014
3015         * DumpRenderTree/win/DumpRenderTree.cpp:
3016         (findFontFallback):
3017         (addFontFallbackIfPresent):
3018         (removeFontFallbackIfPresent):
3019         (main):
3020         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3021         (TestWebKitAPI::Util::moduleDirectory):
3022         (TestWebKitAPI::Util::createInjectedBundlePath):
3023         Use wchar helpers as needed.
3024
3025 2019-03-06  Rob Buis  <rbuis@igalia.com>
3026
3027         Consider supporting the `referrerpolicy` attribute.
3028         https://bugs.webkit.org/show_bug.cgi?id=179053
3029
3030         Reviewed by Darin Adler.
3031
3032         Add a runtime flag for referrerpolicy attribute.
3033
3034         * DumpRenderTree/mac/DumpRenderTree.mm:
3035         (enableExperimentalFeatures):
3036
3037 2019-03-05  Daniel Bates  <dabates@apple.com>
3038
3039         Update expected API test result following r242379
3040         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3041
3042         Update expected x-coordinate of selection rect now that the left padding of
3043         a textarea is sized in ems (so dependent on the font size) just like the left
3044         padding of a text field.
3045
3046         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3047         (TestWebKitAPI::TEST):
3048
3049 2019-03-05  David Quesada  <david_quesada@apple.com>
3050
3051         [WK2] It should be possible to follow links with 'download' attributes
3052         https://bugs.webkit.org/show_bug.cgi?id=195145
3053         rdar://problem/48462642
3054
3055         Reviewed by Alex Christensen.
3056
3057         Add a unit test to verify that activating links with 'download' attributes now
3058         navigates to the linked resource, rather than starts downloading it. Add another
3059         to verify that it is still possible to explicitly download the link via the
3060         'Download' navigation action policy.
3061
3062         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3063         (-[DownloadAttributeTestDelegate init]):
3064         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3065         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3066         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3067         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3068         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3069         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3070         (TEST):
3071         * WebKitTestRunner/TestController.cpp:
3072         (WTR::TestController::decidePolicyForNavigationAction):
3073         * WebKitTestRunner/TestController.h:
3074
3075 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3076
3077         [Curl] Implement Cookie Accept Policy.
3078         https://bugs.webkit.org/show_bug.cgi?id=191645
3079
3080         Reviewed by Fujii Hironori.
3081
3082         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3083         (TestWebKitAPI::Curl::TEST_F):
3084
3085 2019-03-05  Youenn Fablet  <youenn@apple.com>
3086
3087         Rename requestCacheStorageSpace to requestStorageSpace
3088         https://bugs.webkit.org/show_bug.cgi?id=195282
3089
3090         Reviewed by Chris Dumez.
3091
3092         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3093         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3094         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3095
3096 2019-03-05  Brady Eidson  <beidson@apple.com>
3097
3098         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3099         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3100
3101         Reviewed by Tim Horton.
3102
3103         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3104         different directory into that same WKWebView should work.
3105
3106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3107         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3108
3109 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3110
3111         Add WeakHashSet
3112         https://bugs.webkit.org/show_bug.cgi?id=195152
3113
3114         Reviewed by Antti Koivisto.
3115
3116         Added tests for WeakHashSet.
3117
3118         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3119         (TestWebKitAPI::Base::Base): Moved.
3120         (TestWebKitAPI::Derived::foo): Moved.
3121         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3122         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3123         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3124         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3125
3126 2019-03-04  Chris Dumez  <cdumez@apple.com>
3127
3128         Do not share WebProcesses between private and regular sessions
3129         https://bugs.webkit.org/show_bug.cgi?id=195189
3130         <rdar://problem/48421064>
3131
3132         Reviewed by Alex Christensen.
3133
3134         Add API test coverage.
3135
3136         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3137         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3138
3139 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3140
3141         [WPE] Enable web process sandbox
3142         https://bugs.webkit.org/show_bug.cgi?id=195169
3143
3144         Reviewed by Daniel Bates.
3145
3146         * wpe/install-dependencies:
3147         * wpe/jhbuild.modules:
3148
3149 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3150
3151         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3152         https://bugs.webkit.org/show_bug.cgi?id=195206
3153
3154         Reviewed by Žan Doberšek.
3155
3156         Add a new test case.
3157
3158         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3159         (testJSCClass):
3160
3161 2019-03-04  Charlie Turner  <cturner@igalia.com>
3162
3163         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3164         https://bugs.webkit.org/show_bug.cgi?id=194898
3165
3166         Reviewed by Žan Doberšek.
3167
3168         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3169         a GCC extension that permits arithmetic on void* pointer. Inline
3170         the macro until this issue is fixed upstream.
3171
3172 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3173
3174         Rid the world of WK_API_ENABLED
3175         https://bugs.webkit.org/show_bug.cgi?id=195263
3176
3177         Reviewed by Dan Bernstein.
3178
3179         List of changed files elided because it's useless.
3180
3181 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3182
3183         Unreviewed follow-up to r242292.
3184
3185         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3186
3187         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3188         (TestWebKitAPI::testStrip): Renamed from strip.
3189         (TestWebKitAPI::TEST):
3190
3191 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3192
3193         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3194
3195         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3196         and bug #194272 for details.
3197
3198         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3199
3200 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3201
3202         Remove some more unused 32-bit code
3203         https://bugs.webkit.org/show_bug.cgi?id=195255
3204
3205         Reviewed by Darin Adler.
3206
3207         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3208         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3209         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3210         (NPP_New):
3211         (NPP_HandleEvent):
3212         (handleEventCarbon): Deleted.
3213
3214 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3215
3216         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3217
3218         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3219         (TestWebKitAPI::TEST):
3220
3221 2019-03-01  Darin Adler  <darin@apple.com>
3222
3223         Finish removing String::format
3224         https://bugs.webkit.org/show_bug.cgi?id=194893
3225
3226         Reviewed by Daniel Bates.
3227 '
3228         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3229
3230 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3231
3232         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3233         https://bugs.webkit.org/show_bug.cgi?id=195229
3234         <rdar://problem/48520362>
3235
3236         Reviewed by Chris Dumez.
3237
3238         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3239         (TEST):
3240
3241 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3242
3243         Add a system trace scope for event region building
3244         https://bugs.webkit.org/show_bug.cgi?id=195226
3245
3246         Reviewed by Jon Lee.
3247
3248         This trace scope measures the time spend converting element rects into Region objects,
3249         which can be large on some pages.
3250
3251         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3252
3253         * Tracing/SystemTracePoints.plist:
3254
3255 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3256
3257         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3258         https://bugs.webkit.org/show_bug.cgi?id=194612
3259
3260         Reviewed by Alex Christensen.
3261
3262         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3263         Just test the new string-processing function and don't touch the actual environment.
3264         (Test cases are all as before, but based on operator== instead of strcmp.)
3265
3266 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3267
3268         [ews-app] Update primary keys for handling multiple Buildbot instances
3269         https://bugs.webkit.org/show_bug.cgi?id=195120
3270
3271         Reviewed by Stephanie Lewis.
3272
3273         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3274         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3275         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3276
3277         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3278         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3279         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3280         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3281         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3282         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3283
3284 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3285
3286         [WinCairo] Enable service worker
3287         https://bugs.webkit.org/show_bug.cgi?id=188318
3288
3289         Reviewed by Youenn Fablet.
3290
3291         * DumpRenderTree/DumpRenderTreePrefix.h:
3292         * TestWebKitAPI/PlatformWin.cmake:
3293         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3294         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3295         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3296
3297 2019-03-01  Justin Fan  <justin_fan@apple.com>
3298
3299         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3300         https://bugs.webkit.org/show_bug.cgi?id=195191
3301
3302         Rubber-stamped by Dean Jackson.
3303
3304         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3305
3306         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3307
3308 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3309
3310         Unreviewed, fix lldb webkitpy tests
3311         https://bugs.webkit.org/show_bug.cgi?id=194375
3312
3313         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3314
3315         * lldb/lldb_webkit.py:
3316         (WTFStringImplProvider.is_8bit):
3317
3318 2019-02-28  David Quesada  <david_quesada@apple.com>
3319
3320         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3321         https://bugs.webkit.org/show_bug.cgi?id=195121
3322         rdar://problem/48450302
3323
3324         Reviewed by Alex Christensen.
3325
3326         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3327         configurations where the 'download' attribute is absent, blank, or populated
3328         with a filename, and where the anchor element is same-origin or cross-origin
3329         (meaning the 'download' attribute shouldn't be honored).
3330
3331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3332         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3333         (-[NavigationActionTestDelegate init]):
3334         (-[NavigationActionTestDelegate navigationAction]):
3335         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3336         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3337         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3338         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3339         (TEST):
3340
3341 2019-02-28  Antoine Quint  <graouts@apple.com>
3342
3343         Enable the Pointer Events runtime flag by default
3344         https://bugs.webkit.org/show_bug.cgi?id=195156
3345
3346         Reviewed by Dean Jackson.
3347
3348         * DumpRenderTree/mac/DumpRenderTree.mm:
3349         (enableExperimentalFeatures):
3350
3351 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3352
3353         Several PasteImage API tests are flaky
3354         https://bugs.webkit.org/show_bug.cgi?id=195160
3355
3356         Reviewed by Tim Horton.
3357
3358         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3359         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3360         listening for a "load" event after image load is already complete.
3361
3362         To address this, make these tests first register a "load" event handler, then run script to insert an image
3363         element into the document, and finally wait until the load event is observed before checking image size.
3364
3365         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3366
3367 2019-02-28  Chris Dumez  <cdumez@apple.com>
3368
3369         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3370         https://bugs.webkit.org/show_bug.cgi?id=195107
3371
3372         Reviewed by Alex Christensen.
3373
3374         Give some time for the zoom level to get restored.
3375
3376         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3377
3378 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3379
3380         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3381         https://bugs.webkit.org/show_bug.cgi?id=194958
3382
3383         Reviewed by Geoffrey Garen.
3384
3385         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3386         (TEST):
3387
3388 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3389
3390         [ews-app] Update method to save build to handle builder_display_name
3391         https://bugs.webkit.org/show_bug.cgi?id=195047
3392
3393         Reviewed by Dewei Zhu.
3394
3395         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3396         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3397
3398 2019-02-28  Justin Fan  <justin_fan@apple.com>
3399
3400         [Web GPU] Enable Web GPU only on 64-bit
3401         https://bugs.webkit.org/show_bug.cgi?id=195139
3402
3403         Because Metal is only supported on 64 bit apps.
3404
3405         Unreviewed build fix.
3406
3407         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3408
3409 2019-02-27  Youenn Fablet  <youenn@apple.com>
3410
3411         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3412         https://bugs.webkit.org/show_bug.cgi?id=194959
3413
3414         Reviewed by Chris Dumez.
3415
3416         Spin loop until getting the condition to remove flakiness.
3417
3418         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3419
3420 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3421
3422         [ews-build] Buildbot should include builder_display_name in the build events
3423         https://bugs.webkit.org/show_bug.cgi?id=195045
3424
3425         Reviewed by Dewei Zhu.
3426
3427         * BuildSlaveSupport/ews-build/events.py:
3428         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3429         buildername to builder_name to be consistent in naming style.
3430         (Events.buildFinished): Ditto.
3431
3432 2019-02-27  Chris Dumez  <cdumez@apple.com>
3433
3434         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3435         https://bugs.webkit.org/show_bug.cgi?id=194480
3436
3437         Reviewed by Brady Eidson.
3438
3439         Update existing API test to make it more likely to reproduce the issue.
3440
3441         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3442
3443 2019-02-27  Brady Eidson  <beidson@apple.com>
3444
3445         Universal links from Google search results pages don't open the app.
3446         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3447
3448         Reviewed by Geoffrey Garen.
3449
3450         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3451         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3452         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3453         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3454
3455 2019-02-27  Chris Dumez  <cdumez@apple.com>
3456
3457         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3458         https://bugs.webkit.org/show_bug.cgi?id=195102
3459
3460         Reviewed by Geoffrey Garen.
3461
3462         If the number of processes is not yet what we expect, wait a bit and check again to give
3463         processes some time to exit.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3466
3467 2019-02-27  Chris Dumez  <cdumez@apple.com>
3468
3469         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3470         https://bugs.webkit.org/show_bug.cgi?id=194545
3471
3472         Reviewed by Brady Eidson.
3473
3474         Make sure the test navigates forward and then back only once. Previously, navigating
3475         back would trigger a navigation again in a timer.
3476
3477         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3478
3479 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3480
3481         High Sierra Debug JSC test queue should use faster hardware
3482         https://bugs.webkit.org/show_bug.cgi?id=194603
3483
3484         Rubber-stamped by Alexey Proskuryakov.
3485
3486         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3487
3488         * BuildSlaveSupport/build.webkit.org-config/config.json:
3489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3490         (BubbleQueueServer):
3491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3492         (WebKitBuildbot):
3493         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3494         * QueueStatusServer/config/queues.py:
3495         * Scripts/webkitpy/common/config/ews.json:
3496         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3497         (test_ews_name):
3498
3499 2019-02-27  John Wilander  <wilander@apple.com>
3500
3501         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3502         https://bugs.webkit.org/show_bug.cgi?id=195071
3503         <rdar://problem/48417690>
3504
3505         Reviewed by Alex Christensen and Brent Fulgham.
3506
3507         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3508         (TestWebKitAPI::createURL):
3509             Convenience function.
3510         (TestWebKitAPI::TEST):
3511             WebCore::AdClickAttribution now takes a URL when creating Source and
3512             Destination.
3513         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3514         (TestWebKitAPI::TEST):
3515             WebCore::AdClickAttribution now takes a URL when creating Source and
3516             Destination.
3517
3518 2019-02-27  Antoine Quint  <graouts@apple.com>
3519
3520         Support Pointer Events on macOS
3521         https://bugs.webkit.org/show_bug.cgi?id=195008
3522         <rdar://problem/47454419>
3523
3524         Reviewed by Dean Jackson.
3525
3526         * DumpRenderTree/mac/DumpRenderTree.mm:
3527         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3528         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3529
3530 2019-02-26  Mark Lam  <mark.lam@apple.com>
3531
3532         Remove remaining poisoning code.
3533         https://bugs.webkit.org/show_bug.cgi?id=194138
3534
3535         Reviewed by Saam Barati.
3536
3537         * TestWebKitAPI/CMakeLists.txt:
3538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3539         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3540         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3541         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3542         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3543         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3544         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3545
3546 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3547
3548         Move ephemeral local storage from WebProcess to UIProcess
3549         https://bugs.webkit.org/show_bug.cgi?id=195074
3550         <rdar://problem/47937975>
3551
3552         Reviewed by Geoff Garen.
3553
3554         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3555
3556 2019-02-20  Jer Noble  <jer.noble@apple.com>
3557
3558         [Cocoa] Media elements will restart network buffering just before suspending
3559         https://bugs.webkit.org/show_bug.cgi?id=193691
3560
3561         Reviewed by Eric Carlson.
3562
3563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3565         (TEST):
3566
3567 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3568
3569         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3570         https://bugs.webkit.org/show_bug.cgi?id=191652
3571
3572         Reviewed by Alex Christensen.
3573
3574         Fix WinCairo MiniBrowser behavior of authentication dialog.
3575
3576         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3577         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3578
3579 2019-02-26  Youenn Fablet  <youenn@apple.com>
3580
3581         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3582         https://bugs.webkit.org/show_bug.cgi?id=195028
3583         <rdar://problem/48243733>
3584
3585         Reviewed by Eric Carlson.
3586
3587         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3588
3589 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3590
3591         [WPE] Add API for webview background color configuration
3592         https://bugs.webkit.org/show_bug.cgi?id=192305
3593
3594         Reviewed by Michael Catanzaro.
3595
3596         * MiniBrowser/wpe/main.cpp:
3597         (main): Add a new option to configure the webview background
3598         color. Example: --bg-color=transparent.
3599         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3600         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3601         (beforeAll): Ditto.
3602
3603 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3604
3605         scalableNativeWebpageParameters() is not preserved on new page navigation.
3606         https://bugs.webkit.org/show_bug.cgi?id=194892
3607         <rdar://problem/47538280>
3608
3609         Reviewed by Wenson Hsieh.
3610         
3611         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3612
3613         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3614         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3615         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3616         (WTR::UIScriptController::allowsViewportShrinkToFit):
3617         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3618         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3619         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3620         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3621         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3622         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3623
3624 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3625
3626         [ews-app] Add model for handling multiple Buildbot instances
3627         https://bugs.webkit.org/show_bug.cgi?id=194863
3628
3629         Reviewed by Stephanie Lewis.
3630
3631         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3632
3633 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3634
3635         [ews-app] Remove BuilderMapping table
3636         https://bugs.webkit.org/show_bug.cgi?id=194961
3637
3638         Reviewed by Stephanie Lewis.
3639
3640         Store builder name directly in build table, instead of having a separate
3641         table for it.
3642
3643         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3644         * BuildSlaveSupport/ews-app/ews/models/build.py:
3645         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3646         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3647
3648 2019-02-25  John Wilander  <wilander@apple.com>
3649
3650         Introduce and adopt new class RegistrableDomain for eTLD+1
3651         https://bugs.webkit.org/show_bug.cgi?id=194791
3652         <rdar://problem/48179240>
3653
3654         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3655
3656         This patch adds an API test and replaces two instances of
3657         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3658
3659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3660         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3661         (TestWebKitAPI::TEST):
3662             Changed two strings to make sure the registrable domains are still considered
3663             invalid and pass the test.
3664         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3665         (TestWebKitAPI::TEST):
3666         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3667         (WTR::InjectedBundle::didReceiveMessageToPage):
3668
3669 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3670
3671         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3672         https://bugs.webkit.org/show_bug.cgi?id=195001
3673
3674         Reviewed by Carlos Garcia Campos.
3675
3676         API version 1.0 always includes the functionality previously guarded with
3677         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3678         unconditionally.
3679
3680         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3681         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3682         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3683         (WebViewTest::showInWindow): Ditto.
3684         (WebViewTest::hideView): Ditto.
3685         * wpe/backends/HeadlessViewBackend.cpp:
3686         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3687         * wpe/backends/ViewBackend.cpp:
3688         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3689         * wpe/backends/WindowViewBackend.cpp:
3690         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3691         WPE_BACKEND_CHECK_VERSION().
3692         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3693
3694 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3695
3696         [Flatpak] Add support for flatpak > 1.1.2
3697         https://bugs.webkit.org/show_bug.cgi?id=194088
3698
3699         Flatpak 1.2 is now out so we need to support that
3700         version now.
3701
3702         Reviewed by Michael Catanzaro.
3703
3704         * flatpak/flatpakutils.py:
3705         (check_flatpak):
3706         (FlatpakPackages.__init__):
3707         (FlatpakPackages.__detect_packages):
3708         (FlatpakPackages.__detect_packages.in):
3709         (FlatpakRepos.update):
3710
3711 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3712
3713         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3714         https://bugs.webkit.org/show_bug.cgi?id=194998
3715
3716         Reviewed by Carlos Garcia Campos.
3717
3718         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3719         to a Git checkout and using the latest commit containing various fixes
3720         and improvements.
3721
3722 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3723
3724         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3725         https://bugs.webkit.org/show_bug.cgi?id=194981
3726
3727         Reviewed by Žan Doberšek.
3728
3729         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3730         (TestWebKitAPI::TEST):
3731
3732 2019-02-23  Keith Miller  <keith_miller@apple.com>
3733
3734         Add new mac target numbers
3735         https://bugs.webkit.org/show_bug.cgi?id=194955
3736
3737         Reviewed by Tim Horton.
3738
3739         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3740         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3741         * MiniBrowser/Configurations/Base.xcconfig:
3742         * TestWebKitAPI/Configurations/Base.xcconfig:
3743         * WebKitTestRunner/Configurations/Base.xcconfig:
3744
3745 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3746
3747         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3748         https://bugs.webkit.org/show_bug.cgi?id=194846
3749
3750         Reviewed by Don Olmstead.
3751
3752         Added _search_paths() and _port_specific_expectations_files() for
3753         WinCairoPort.
3754
3755         * Scripts/webkitpy/port/win.py:
3756         (WinCairoPort.default_baseline_search_path):
3757         (WinCairoPort):
3758         (WinCairoPort._port_specific_expectations_files):
3759         (WinCairoPort._search_paths):
3760
3761 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3762
3763         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3764         https://bugs.webkit.org/show_bug.cgi?id=194963
3765
3766         Reviewed by Dean Jackson.
3767
3768         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3769         Do a `contains` check instead of `equals`, because in debug builds we
3770         put the GraphicsLayer pointer in a prefix.
3771
3772 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3773
3774         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3775         https://bugs.webkit.org/show_bug.cgi?id=194873
3776         <rdar://problem/46701974>
3777
3778         Reviewed by Tim Horton.
3779
3780         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3781
3782         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3783         (WTR::UIScriptController::menuRect const):
3784         (WTR::UIScriptController::isShowingMenu const):
3785         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3786         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3787         (WTR::UIScriptController::menuRect const):
3788
3789         Add a function to query the bounds of the callout menu in content coordinates.
3790
3791         (WTR::UIScriptController::isShowingMenu const):
3792
3793         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3794
3795         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3796         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3797         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3798         (WTR::UIScriptController::rectForMenuAction const):
3799         (WTR::UIScriptController::menuRect const):
3800         (WTR::UIScriptController::isShowingMenu const):
3801         (WTR::findViewInHierarchyOfType): Deleted.
3802
3803 2019-02-22  Chris Dumez  <cdumez@apple.com>
3804
3805         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3806         https://bugs.webkit.org/show_bug.cgi?id=194954
3807         <rdar://problem/48127957>
3808
3809         Reviewed by Alex Christensen.
3810
3811         Add API test coverage.
3812
3813         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3814         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3815         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3816         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3817
3818 2019-02-22  Chris Dumez  <cdumez@apple.com>
3819
3820         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3821         https://bugs.webkit.org/show_bug.cgi?id=194924
3822         <rdar://problem/48216125>
3823
3824         Reviewed by Geoffrey Garen.
3825
3826         Add API test coverage.
3827
3828         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3829
3830 2019-02-22  Chris Dumez  <cdumez@apple.com>
3831
3832         Unreviewed, disable API test added in r241928 on iOS.
3833
3834         The cache is not enabled on devices with less than 3GB of RAM.
3835
3836         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3837
3838 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3839
3840         Hardcode Visual Viewports on everywhere except iOS WK1
3841         https://bugs.webkit.org/show_bug.cgi?id=194928
3842
3843         Reviewed by Zalan Bujtas.
3844
3845         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3846         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3847         set it to false. The setting has shipped for several years and there's no need to turn
3848         it off now.
3849
3850         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3851         Visual Viewports are not enabled.
3852         
3853         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3854         that only runs in WK2
3855
3856         * MiniBrowser/mac/SettingsController.h:
3857         * MiniBrowser/mac/SettingsController.m:
3858         (-[SettingsController init]):
3859         (-[SettingsController _populateMenu]):
3860         (-[SettingsController validateMenuItem:]):
3861         (-[SettingsController visualViewportEnabled]): Deleted.
3862         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3863         * MiniBrowser/mac/WK1BrowserWindowController.m:
3864         (-[WK1BrowserWindowController didChangeSettings]):
3865         * MiniBrowser/mac/WK2BrowserWindowController.m:
3866         (-[WK2BrowserWindowController didChangeSettings]):
3867
3868 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3869
3870         Discard cached processes when clearing website data store
3871         https://bugs.webkit.org/show_bug.cgi?id=194894
3872
3873         Reviewed by Chris Dumez.
3874
3875         Added a test case.
3876
3877         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3878         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3879
3880 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3881
3882         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3883         https://bugs.webkit.org/show_bug.cgi?id=194914
3884         <rdar://problem/47586889>
3885
3886         Reviewed by Geoffrey Garen.
3887
3888         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3889         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3890         (TEST):
3891         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3892
3893 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3894
3895         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3896         <https://webkit.org/b/194761>
3897
3898         Reviewed by Myles Maxfield.
3899
3900         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3901         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3902         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3903         to use ARC-compliant cast.
3904         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3905         ARC-compliant cast.
3906         (WTR::installFakeHelvetica): Log `error` to console if
3907         CTFontManagerRegisterFontsForURL() fails, but only on supported
3908         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3909         Call CFRelease() on `error` to fix the leak.  Update to use
3910         ARC-compliant cast.
3911         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3912         cast.
3913
3914 2019-02-21  Chris Dumez  <cdumez@apple.com>
3915
3916         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3917         https://bugs.webkit.org/show_bug.cgi?id=194481
3918
3919         Reviewed by Alex Christensen.
3920
3921         Give the processes a chance to shutdown and wait until we reached the expected number
3922         of processes.
3923
3924         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3925
3926 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3927
3928         Fix the macOS build
3929
3930         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3931
3932 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3933
3934         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3935
3936         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3937         I am a backwards.
3938
3939 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3940
3941         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3942
3943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3944         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3945         We could force on UI-side compositing, but I feel like the test might be more
3946         valuable exercising the normal path on each platform (though the original
3947         bug was also UI-side specific). Though we can't validate that the overlay
3948         layer was installed successfully, there are layout tests that do that.
3949
3950 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3951
3952         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3953         https://bugs.webkit.org/show_bug.cgi?id=194845
3954         <rdar://problem/47944579>
3955
3956         Reviewed by Antti Koivisto.
3957
3958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3959         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3960
3961 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3962
3963         [LFC][Floats] Add support for placing formatting roots in-between floats.
3964         https://bugs.webkit.org/show_bug.cgi?id=194902
3965
3966         Reviewed by Antti Koivisto.
3967
3968         * LayoutReloaded/misc/LFC-passing-tests.txt:
3969
3970 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3971
3972         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3973         https://bugs.webkit.org/show_bug.cgi?id=194901
3974
3975         Unreviewed build fix.
3976
3977         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3978         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3979         WPEBackend-fdo-0.1 as library name.
3980
3981 2019-02-21  Rob Buis  <rbuis@igalia.com>
3982
3983         Update MIME type parser
3984         https://bugs.webkit.org/show_bug.cgi?id=180526
3985
3986         Reviewed by Darin Adler.
3987
3988         Add tests involving leading and trailing whitespace, non-token
3989         characters and quoted strings.
3990
3991         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3992         (TestWebKitAPI::TEST):
3993
3994 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3995
3996         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3997         https://bugs.webkit.org/show_bug.cgi?id=194884
3998
3999         Reviewed by Michael Catanzaro.
4000
4001         * PlatformWin.cmake:
4002
4003 2019-02-20  Chris Dumez  <cdumez@apple.com>
4004
4005         Add API test for <rdar://problem/47471222>
4006         https://bugs.webkit.org/show_bug.cgi?id=194847
4007
4008         Reviewed by Alex Christensen.
4009
4010         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4011
4012 2019-02-20  Chris Dumez  <cdumez@apple.com>
4013
4014         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4015         https://bugs.webkit.org/show_bug.cgi?id=194872
4016         <rdar://problem/47924500>
4017
4018         Reviewed by Alex Christensen.
4019
4020         Add API test coverage.
4021
4022         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4023
4024 2019-02-20  Jer Noble  <jer.noble@apple.com>
4025
4026         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4027         https://bugs.webkit.org/show_bug.cgi?id=191332
4028
4029         Reviewed by Dean Jackson.
4030
4031         * Scripts/git-is-in-range: Added.
4032
4033 2019-02-20  Andy Estes  <aestes@apple.com>
4034
4035         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4036         https://bugs.webkit.org/show_bug.cgi?id=194869
4037
4038         Rubber-stamped by Jer Noble.
4039
4040         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4041         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4042         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4043         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4045         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4046
4047 2019-02-20  Chris Dumez  <cdumez@apple.com>
4048
4049         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4050         https://bugs.webkit.org/show_bug.cgi?id=194857
4051         <rdar://problem/47759323>
4052
4053         Reviewed by Alex Christensen.
4054
4055         Add API test coverage.
4056
4057         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4058
4059 2019-02-20  Chris Dumez  <cdumez@apple.com>
4060
4061         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4062         https://bugs.webkit.org/show_bug.cgi?id=194829
4063         <rdar://problem/47889906>
4064
4065         Reviewed by Alexey Proskuryakov.
4066
4067         Every time the TestOptions were changing we were creating both a new Web view and
4068         a new WKContext, which would start a new Network process. In most cases, we only
4069         need to contruct a new Web view and we do can keep reusing the same WKContext.
4070         This patch implements this optimization and thus avoids spinning a lot of new
4071         Network processes while running the layout tests.
4072
4073         * WebKitTestRunner/TestController.cpp:
4074         (WTR::TestController::generateContextConfiguration const):
4075         (WTR::TestController::generatePageConfiguration):
4076         (WTR::TestController::createWebViewWithOptions):
4077         (WTR::TestController::resetPreferencesToConsistentValues):
4078         (WTR::updateTestOptionsFromTestHeader):
4079         * WebKitTestRunner/TestController.h:
4080         * WebKitTestRunner/TestOptions.h:
4081         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4082         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4083         (WTR::TestOptions::hasSameInitializationOptions const):
4084         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4085         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4086         (WTR::TestController::platformAddTestOptions const):
4087
4088 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4089
4090         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4091         https://bugs.webkit.org/show_bug.cgi?id=167941
4092
4093         Reviewed by Carlos Garcia Campos.
4094
4095         * MiniBrowser/gtk/main.c:
4096         (filterSavedCallback): Added.
4097         (main): Support loading a JSON rule set file for content filtering.
4098         * MiniBrowser/wpe/main.cpp:
4099         (filterSavedCallback): Added.
4100         (main): Support loading a JSON rule set file for content filtering.
4101         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4102         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4103         (WTF::derefGPtr): Ditto.
4104         (testEmptyStore):
4105         (testSaveInvalidFilter):
4106         (testSaveLoadFilter):
4107         (testSavedFilterIdentifierMatch):
4108         (testRemoveFilter):
4109         (testSaveMultipleFilters):
4110         (testSaveFilterFromFile):
4111         (testFilterPersistence):
4112         (beforeAll):
4113         (afterAll):
4114         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4115         (removeOldInjectedContentAndResetLists): Also reset content filters.
4116         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4117         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4118         the element affected by the style sheet.
4119         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4120         and returns it to be used by tests.
4121         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4122         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4123         (serverCallback): Add support for serving a CSS style sheet for testing.
4124         (beforeAll): Add call to testUserContentManagerContentFilter().
4125         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4126
4127 2019-02-19  Keith Rollin  <krollin@apple.com>
4128
4129         Add timing information to build output
4130         https://bugs.webkit.org/show_bug.cgi?id=194839
4131         <rdar://problem/48219609>
4132
4133         Reviewed by Alexey Proskuryakov.
4134
4135         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4136         emit each project's build time to its output. E.g.,
4137
4138             ** BUILD SUCCEEDED ** [0.132 sec]
4139
4140         * Scripts/webkitdirs.pm:
4141         (XcodeOptions):
4142
4143 2019-02-19  Truitt Savell  <tsavell@apple.com>
4144
4145         Unreviewed, rolling out r241784.
4146
4147         Broke all OpenSource builds.
4148
4149         Reverted changeset:
4150
4151         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4152         instances view"
4153         https://bugs.webkit.org/show_bug.cgi?id=172848
4154         https://trac.webkit.org/changeset/241784
4155
4156 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4157
4158         [LFC][Floats] Remove redundant intersecting logic
4159         https://bugs.webkit.org/show_bug.cgi?id=194804
4160
4161         Reviewed by Antti Koivisto.
4162
4163         * LayoutReloaded/misc/LFC-passing-tests.txt:
4164
4165 2019-02-19  Dean Jackson  <dino@apple.com>
4166
4167         Clean-up output from generate-xcfilelists so it can be filtered
4168         https://bugs.webkit.org/show_bug.cgi?id=194795
4169
4170         Reviewed by Joseph Pecoraro (and Keith Rollin).
4171
4172         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4173         make a slight tweak to filter-build-webkit so such lines are marked
4174         as plain.
4175
4176         * Scripts/filter-build-webkit:
4177         * Scripts/generate-xcfilelists:
4178
4179 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4180
4181         pytest is not correctly auto-installed
4182         https://bugs.webkit.org/show_bug.cgi?id=194707
4183
4184         Reviewed by Carlos Garcia Campos.
4185
4186         * Scripts/webkitpy/thirdparty/__init__.py:
4187         (AutoinstallImportHook._install_pytest):
4188
4189 2019-02-18  Chris Dumez  <cdumez@apple.com>
4190
4191         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4192         https://bugs.webkit.org/show_bug.cgi?id=194797
4193         <rdar://problem/48055151>
4194
4195         Reviewed by Geoffrey Garen.
4196
4197         Add API test coverage.
4198
4199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4200
4201 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4202
4203         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4204         https://bugs.webkit.org/show_bug.cgi?id=194670
4205         <rdar://problem/39066529>
4206
4207         Reviewed by Tim Horton.
4208
4209         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4210         pasted in an editable area as attachment elements.
4211
4212         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4213         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4214         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4215         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4216         (TestWebKitAPI::TEST):
4217         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4218         (WTR::InjectedBundlePage::InjectedBundlePage):
4219
4220 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4221
4222         Fix API test after r241728
4223        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4224
4225         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4226         (TEST):
4227         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4228
4229 2019-02-18  Daniel Bates  <dabates@apple.com>
4230
4231         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4232         https://bugs.webkit.org/show_bug.cgi?id=192824
4233         <rdar://problem/47100332>
4234
4235         Reviewed by Wenson Hsieh.
4236
4237         Fix a bug where the wrong usage code was used for F13 thru F24.
4238
4239         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4240         (keyCodeForDOMFunctionKey):
4241
4242 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4243
4244         Bytecode cache should a have a boot-specific validation
4245         https://bugs.webkit.org/show_bug.cgi?id=194769
4246         <rdar://problem/48149509>
4247
4248         Reviewed by Keith Miller.
4249
4250         Add test for WTF::bootSessionUUIDString()
4251
4252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4253         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4254         (TEST):
4255
4256 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4257
4258         Disable safe browsing in WKWebView and remove its WKPreferences API
4259         https://bugs.webkit.org/show_bug.cgi?id=194723
4260         <rdar://problem/48122993>
4261
4262         Reviewed by Geoffrey Garen.
4263
4264         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4265         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4266         (TEST):
4267         (safeBrowsingView):
4268         Make tests use SPI instead of API.
4269
4270 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4271
4272         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4273         https://bugs.webkit.org/show_bug.cgi?id=194586
4274
4275         Reviewed by Ross Kirsling.
4276
4277         * DumpRenderTree/win/DumpRenderTree.cpp:
4278         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4279         * Scripts/webkitpy/port/driver.py:
4280         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4281
4282 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4283
4284         Unreviewed, rolling out r241620.
4285
4286         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4287         (Requested by ddkilzer on #webkit.)
4288
4289         Reverted changeset:
4290
4291         "[WTF] Add environment variable helpers"
4292         https://bugs.webkit.org/show_bug.cgi?id=192405
4293         https://trac.webkit.org/changeset/241620
4294
4295 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4296
4297         [LFC] RenderImage's default intrinsic size is 0.
4298         https://bugs.webkit.org/show_bug.cgi?id=194745
4299
4300         Reviewed by Antti Koivisto.
4301
4302         * LayoutReloaded/misc/LFC-passing-tests.txt:
4303
4304 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4305
4306         [LFC][BFC] Add support for block replaced intrinsic width.
4307         https://bugs.webkit.org/show_bug.cgi?id=194705
4308
4309         Reviewed by Simon Fraser.
4310
4311         * LayoutReloaded/misc/LFC-passing-tests.txt:
4312
4313 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4314
4315         [LFC] Apply min/max width constraints to preferred width computation
4316         https://bugs.webkit.org/show_bug.cgi?id=194739
4317
4318         Reviewed by Simon Fraser.
4319
4320         * LayoutReloaded/misc/LFC-passing-tests.txt:
4321
4322 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4323
4324         [WTF] Add environment variable helpers
4325         https://bugs.webkit.org/show_bug.cgi?id=192405
4326
4327         Reviewed by Michael Catanzaro.
4328
4329         * DumpRenderTree/mac/DumpRenderTree.mm:
4330         (libraryPathForDumpRenderTree):
4331         * DumpRenderTree/win/DumpRenderTree.cpp:
4332         (libraryPathForDumpRenderTree):
4333         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4334         (setUpIOSLayoutTestCommunication):
4335         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4336         (beforeAll):
4337         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4338         (main):
4339         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4340         (WebKitTestBus::run):
4341         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4342         (WTR::getOutputDir):
4343         (WTR::initializeFontConfigSetting):
4344         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4345         (WTR::InjectedBundle::platformInitialize):
4346         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4347         (WTR::topLevelPath):
4348         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4349         (WTR::topLevelPath):
4350         (WTR::getOutputDir):
4351         (WTR::activateFonts):
4352         * WebKitTestRunner/TestController.cpp:
4353         (WTR::TestController::libraryPathForTesting):
4354         (WTR::TestController::generateContextConfiguration const):
4355         (WTR::TestController::generatePageConfiguration):
4356         (WTR::TestController::decideDestinationWithSuggestedFilename):
4357         (WTR::TestController::platformAdjustContext):
4358         * WebKitTestRunner/TestController.h:
4359         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4360         (WTR::TestController::cocoaPlatformInitialize):
4361         (WTR::TestController::platformAdjustContext):
4362         * WebKitTestRunner/gtk/main.cpp:
4363         (main):
4364         * WebKitTestRunner/mac/TestControllerMac.mm:
4365         (WTR::TestController::configureContentExtensionForTest):
4366         * WebKitTestRunner/wpe/main.cpp:
4367         (main):
4368         Utilize WTF::Environment where possible.
4369
4370 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4371
4372         [iOS] WKWebView callout bar is missing Change Writing Direction item
4373         https://bugs.webkit.org/show_bug.cgi?id=190015
4374         <rdar://problem/44810366>
4375
4376         Reviewed by Tim Horton.
4377
4378         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4379         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4380
4381         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4382         (TestWebKitAPI::TEST):
4383
4384 2019-02-15  Chris Dumez  <cdumez@apple.com>
4385
4386    &nbs