0e95fa50e994d546064cd86c945d98c2ab033ffa
[WebKit-https.git] / Tools / ChangeLog
1 2016-10-05  Alex Christensen  <achristensen@webkit.org>
2
3         UTF-8 encode queries of nonspecial and websocket schemes
4         https://bugs.webkit.org/show_bug.cgi?id=162956
5
6         Reviewed by Geoffrey Garen and Brady Eidson.
7
8         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
9         (TestWebKitAPI::TEST_F):
10
11 2016-10-05  Alex Christensen  <achristensen@webkit.org>
12
13         Prepare to enable URLParser
14         https://bugs.webkit.org/show_bug.cgi?id=162974
15
16         Reviewed by Brady Eidson.
17
18         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
19         (TestWebKitAPI::TEST_F):
20         Added some tests that are unrelated to the code change, but these are
21         reflected in changed LayoutTest results when enabling the URLParser,
22         and they weren't in the URLParser tests yet.  They should be.
23
24 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
25
26         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
27         https://bugs.webkit.org/show_bug.cgi?id=162903
28
29         Reviewed by Alex Christensen.
30
31         Rename build guards for the remaining implementation of the legacy EME API
32         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
33         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
34
35         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Also remove the
36         ENABLE_IOS_TEXT_AUTOSIZING feature define that was renamed in r206395 and was
37         throwing up style checker errors.
38
39 2016-10-04  Andy Estes  <aestes@apple.com>
40
41         [iOS] Crash in WebResourceLoaderQuickLookDelegate when the client cancels the navigation to a QuickLook resource
42         https://bugs.webkit.org/show_bug.cgi?id=162950
43         <rdar://problem/23759114>
44
45         Reviewed by Brady Eidson.
46
47         Added a new API test.
48
49         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Sorted imports and removed redundant
50         initialization of static bools.
51         (runTest): Factored out the common test logic between QuickLook.NavigationDelegate and
52         QuickLook.CancelNavigationAfterResponse.
53         (TEST): Added QuickLook.CancelNavigationAfterResponse.
54         (-[QuickLookDecidePolicyDelegate
55         webView:decidePolicyForNavigationResponse:decisionHandler:]): Canceled the navigation.
56         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Set
57         isDone to true.
58
59 2016-10-04  Ryosuke Niwa  <rniwa@webkit.org>
60
61         Add the support for running ES6SampleBench to run-benchmark
62         https://bugs.webkit.org/show_bug.cgi?id=162890
63
64         Reviewed by Saam Barati.
65
66         Added the support for running ES6SampleBench as "es6bench".
67         e.g. ./Tools/Scripts/run-benchmark --platform osx --plan es6bench --browser safari
68
69         Instead of the default 10 iterations, run the test 4 iterations using 5 instances of browser
70         for the total of 20 iterations.
71
72         * Scripts/webkitpy/benchmark_runner/data/patches/ES6SampleBench.patch: Added.
73         * Scripts/webkitpy/benchmark_runner/data/plans/es6bench.plan: Added.
74         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
75         (start): Fixed the bug that the linter will complain about the presence of "debugOutput" by
76         removing it if it's present.
77
78 2016-10-04  Simon Fraser  <simon.fraser@apple.com>
79
80         [iOS WK2] Make it possible for a test to describe a user gesture as a stream of events in JSON format
81         https://bugs.webkit.org/show_bug.cgi?id=162934
82
83         Reviewed by Dean Jackson.
84
85         With this change, a test can describe a user gesture in an "event stream", which is
86         some JSON describing an array of events with their underlying touches. The added
87         test describes a single tap.
88         
89         The implementation fires up an NSThread, and sleeps the thread between events to dispatch
90         them at close to real time.
91         
92         In future, HIDEventGenerator could use this internally for all of the "compound" interactions.
93
94         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
95         (WTR::UIScriptController::sendEventStream):
96         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
97         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
98         (WTR::UIScriptController::sendEventStream):
99         * TestRunnerShared/UIScriptContext/UIScriptController.h:
100         * WebKitTestRunner/ios/HIDEventGenerator.h:
101         * WebKitTestRunner/ios/HIDEventGenerator.mm:
102         (transducerTypeFromString):
103         (phaseFromString):
104         (-[HIDEventGenerator eventMaskFromEventInfo:]):
105         (-[HIDEventGenerator touchFromEventInfo:]):
106         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
107         (-[HIDEventGenerator dispatchEventWithInfo:]):
108         (-[HIDEventGenerator eventDispatchThreadEntry:]):
109         (-[HIDEventGenerator sendEventStream:completionBlock:]):
110         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
111         (WTR::UIScriptController::sendEventStream):
112
113 2016-10-04  Megan Gardner  <megan_gardner@apple.com>
114
115         Add Megan to contributor's list
116         https://bugs.webkit.org/show_bug.cgi?id=162944
117
118         Reviewed by Tim Horton.
119
120         Add Megan to the contributor's lists so that her e-mail autocompletes for CC
121
122         * Scripts/webkitpy/common/config/contributors.json:
123
124 2016-10-04  Alex Christensen  <achristensen@webkit.org>
125
126         Add tests verifying non-special URL hosts are parsed according to spec
127         https://bugs.webkit.org/show_bug.cgi?id=162885
128
129         Reviewed by Sam Weinig.
130
131         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
132         (TestWebKitAPI::TEST_F):
133
134 2016-10-04  Anders Carlsson  <andersca@apple.com>
135
136         Properly kill web processes in the launching state
137         https://bugs.webkit.org/show_bug.cgi?id=162938
138
139         Reviewed by Tim Horton.
140
141         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
142         Enable this test again.
143
144 2016-10-04  Alex Christensen  <achristensen@webkit.org>
145
146         URLParser: query-only URLs relative to file URLs should just add a query
147         https://bugs.webkit.org/show_bug.cgi?id=162888
148
149         Reviewed by Tim Horton.
150
151         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
152         (TestWebKitAPI::TEST_F):
153
154 2016-10-04  Alex Christensen  <achristensen@webkit.org>
155
156         URLParser should match URL::parse and other browsers when parsing a URL containing only scheme://
157         https://bugs.webkit.org/show_bug.cgi?id=162909
158
159         Reviewed by Tim Horton.
160
161         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
162         (TestWebKitAPI::TEST_F):
163
164 2016-10-04  Yusuke Suzuki  <utatane.tea@gmail.com>
165
166         [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
167         https://bugs.webkit.org/show_bug.cgi?id=162916
168
169         Reviewed by Filip Pizlo.
170
171         * DumpRenderTree/CMakeLists.txt:
172
173 2016-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
174
175         Media controls are displayed in the incorrect state momentarily after switching between tabs playing media
176         https://bugs.webkit.org/show_bug.cgi?id=162766
177         <rdar://problem/28533523>
178
179         Reviewed by Jer Noble.
180
181         Adds new tests and tweaks existing tests to verify last updated Now Playing information.
182
183         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
184         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]):
185         (TestWebKitAPI::TEST):
186         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]): Deleted.
187         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html:
188
189 2016-10-03  Alex Christensen  <achristensen@webkit.org>
190
191         URLParser should ignore tabs at all locations
192         https://bugs.webkit.org/show_bug.cgi?id=162836
193
194         Reviewed by Geoffrey Garen.
195
196         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
197         (TestWebKitAPI::checkURL):
198         (TestWebKitAPI::checkRelativeURL):
199         (TestWebKitAPI::checkURLDifferences):
200         (TestWebKitAPI::checkRelativeURLDifferences):
201         (TestWebKitAPI::TEST_F):
202
203 2016-10-03  Alex Christensen  <achristensen@webkit.org>
204
205         URLParser: fragment-only URLs relative to file URLs should just add a fragment
206         https://bugs.webkit.org/show_bug.cgi?id=162871
207
208         Reviewed by Geoffrey Garen.
209
210         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
211         (TestWebKitAPI::TEST_F):
212
213 2016-10-03  Per Arne Vollan  <pvollan@apple.com>
214
215         [Win] DRT temp folder is not used.
216         https://bugs.webkit.org/show_bug.cgi?id=162863
217
218         Reviewed by Alex Christensen.
219
220         Convert DRT temp folder to DOS path, which DRT can use.
221
222         * Scripts/webkitpy/port/driver.py:
223         (Driver._setup_environ_for_driver):
224
225 2016-10-03  Alex Christensen  <achristensen@webkit.org>
226
227         URLParser: empty relative URLs should not copy fragment from the base URL
228         https://bugs.webkit.org/show_bug.cgi?id=162864
229
230         Reviewed by Chris Dumez.
231
232         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
233         (TestWebKitAPI::TEST_F):
234
235 2016-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
236
237         [SOUP] Cleanup persistent credential storage code
238         https://bugs.webkit.org/show_bug.cgi?id=162777
239
240         Reviewed by Alex Christensen.
241
242         Use USE(LIBSECRET) instead of ENABLE(CREDENTIAL_STORAGE).
243
244         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
245         (testWebViewAuthenticationStorage):
246
247 2016-10-02  Darin Adler  <darin@apple.com>
248
249         Rename ExceptionCode-based exception handling to "legacy"
250         https://bugs.webkit.org/show_bug.cgi?id=162859
251
252         Reviewed by Chris Dumez.
253
254         * Scripts/do-webcore-rename: Updated script to do this round of renames.
255
256 2016-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
257
258         Media controls for Soundcloud easily falls out of sync with what's actually playing
259         https://bugs.webkit.org/show_bug.cgi?id=162843
260         <rdar://problem/28176874>
261
262         Reviewed by Beth Dakin.
263
264         Adds two new tests simulating audio playback behavior on soundcloud. Also tweaks some of the WKWebView test
265         message handling logic to support having multiple message-handler mappings.
266
267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
268         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
269         (TestWebKitAPI::TEST):
270         * TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Added.
271         * TestWebKitAPI/mac/TestWKWebViewMac.h:
272         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
273         (-[TestMessageHandler addMessage:withHandler:]):
274         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
275         (-[TestWKWebView performAfterReceivingMessage:action:]):
276         (-[TestWKWebView performAfterLoading:]):
277         (-[TestMessageHandler initWithMessage:handler:]): Deleted.
278
279 2016-09-30  Alex Christensen  <achristensen@webkit.org>
280
281         Fix off-by-one error in URLParser::parseIPv4Host
282         https://bugs.webkit.org/show_bug.cgi?id=162789
283
284         Reviewed by Tim Horton.
285
286         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
287         (TestWebKitAPI::TEST_F):
288
289 2016-09-30  Alex Christensen  <achristensen@webkit.org>
290
291         URLParser: parsing a URL with an empty host and a colon should fail
292         https://bugs.webkit.org/show_bug.cgi?id=162795
293
294         Reviewed by Tim Horton.
295
296         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
297         (TestWebKitAPI::TEST_F):
298
299 2016-09-30  Alex Christensen  <achristensen@webkit.org>
300
301         URLParser: handle syntax violations in non-UTF-8 encoded queries
302         https://bugs.webkit.org/show_bug.cgi?id=162770
303
304         Reviewed by Tim Horton.
305
306         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
307         (TestWebKitAPI::checkURL):
308         (TestWebKitAPI::TEST_F):
309         Tests with emoji change behavior when we insert a tab between the surrogates, so don't do the
310         insert-tab-at-each-location verification that syntax violations are handled correctly.
311
312 2016-09-30  Megan Gardner  <megan_gardner@apple.com>
313
314         Make it possible to test web-related user-interface features
315         https://bugs.webkit.org/show_bug.cgi?id=162657
316
317         Reviewed by Simon Fraser.
318
319         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
320         (WTR::UIScriptController::contentsOfUserInterfaceItem):
321         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
322         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
323         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
324         (WTR::UIScriptController::contentsOfUserInterfaceItem):
325         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
326         * TestRunnerShared/UIScriptContext/UIScriptController.h:
327         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
328         (WTR::UIScriptController::contentsOfUserInterfaceItem):
329         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
330
331 2016-09-29  Jiewen Tan  <jiewen_tan@apple.com>
332
333         Expose CryptoKey to web workers
334         https://bugs.webkit.org/show_bug.cgi?id=162640
335         <rdar://problem/28182204>
336
337         Reviewed by Brent Fulgham.
338
339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
340         * TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm: Added.
341         (TestWebKitAPI::TEST_F):
342         Add API tests for SerializedCryptoKeyWrap APIs.
343
344 2016-09-29  Alex Christensen  <achristensen@webkit.org>
345
346         Fix syntax violation handling in IPv4 address parsing
347         https://bugs.webkit.org/show_bug.cgi?id=162756
348
349         Reviewed by Tim Horton.
350
351         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
352         (TestWebKitAPI::TEST_F):
353
354 2016-09-29  Alex Christensen  <achristensen@webkit.org>
355
356         URLParser should correctly parse ports with leading 0's
357         https://bugs.webkit.org/show_bug.cgi?id=162752
358
359         Reviewed by Tim Horton.
360
361         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
362         (TestWebKitAPI::TEST_F):
363
364 2016-09-29  Alex Christensen  <achristensen@webkit.org>
365
366         URLParser: make parsing invalid IPv4 addresses more robust and correct
367         https://bugs.webkit.org/show_bug.cgi?id=162746
368
369         Reviewed by Tim Horton.
370
371         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
372         (TestWebKitAPI::TEST_F):
373
374 2016-09-29  Alex Christensen  <achristensen@webkit.org>
375
376         URLParser: IPv6 addresses followed by a colon are invalid
377         https://bugs.webkit.org/show_bug.cgi?id=162747
378
379         Reviewed by Tim Horton.
380
381         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
382         (TestWebKitAPI::TEST_F):
383
384 2016-09-29  Alexey Proskuryakov  <ap@apple.com>
385
386         Make WKTR short timeout dynamic
387         https://bugs.webkit.org/show_bug.cgi?id=162733
388
389         Reviewed by Alex Christensen.
390
391         WebKitTestRunner has a hardcoded value for how long to wait for IPC responses,
392         which is 5 seconds, or 10 seconds under ASan. But some of the operations can be
393         fairly time consuming - e.g. launching Networking process on demand.
394         These may take longer under load, especially with GuardMalloc.
395
396         * WebKitTestRunner/TestController.cpp:
397         (WTR::TestController::resetStateToConsistentValues):
398         (WTR::TestController::reattachPageToWebProcess):
399         * WebKitTestRunner/TestController.h:
400         * WebKitTestRunner/TestInvocation.cpp:
401         (WTR::TestInvocation::shortTimeout):
402         (WTR::TestInvocation::invoke):
403         (WTR::TestInvocation::dumpResults):
404
405         * WebKitTestRunner/TestInvocation.h:
406         (WTR::TestInvocation::customTimeout): Deleted, this function was unused.
407
408 2016-09-29  Alex Christensen  <achristensen@webkit.org>
409
410         URLParser should fail to parse unclosed IPv6 addresses
411         https://bugs.webkit.org/show_bug.cgi?id=162715
412
413         Reviewed by Tim Horton.
414
415         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
416         (TestWebKitAPI::TEST_F):
417
418 2016-09-29  Alex Christensen  <achristensen@webkit.org>
419
420         URLParser should ignore tabs at all possible locations
421         https://bugs.webkit.org/show_bug.cgi?id=162711
422
423         Reviewed by Tim Horton.
424
425         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
426         (TestWebKitAPI::ExpectedParts::isInvalid):
427         (TestWebKitAPI::checkURL):
428         (TestWebKitAPI::TEST_F):
429
430 2016-09-29  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
431
432         [EFL] Add search button to url bar in MiniBrowser
433         https://bugs.webkit.org/show_bug.cgi?id=162716
434
435         Reviewed by Michael Catanzaro.
436
437         As a bug title, it would be good to add a search button to URL bar.
438         Additionally this patch changes color of button to recognize the buttons.
439
440         * MiniBrowser/efl/main.c:
441         (_search_button_clicked_cb):
442         (_create_toolbar_button):
443         (window_create):
444         (create_toolbar_button): Deleted.
445
446 2016-09-28  Tim Horton  <timothy_horton@apple.com>
447
448         API test WebKit2.AutoLayoutIntegration is a flaky timeout
449         https://bugs.webkit.org/show_bug.cgi?id=160284
450
451         Reviewed by Dan Bernstein.
452
453         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
454         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
455         (-[AutoLayoutWKWebView beginLayoutAtMinimumWidth:andExpectContentSizeChange:]):
456         (-[AutoLayoutWKWebView waitForContentSizeChangeResettingWidth:]):
457         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
458         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
459         (TEST):
460         Make the autolayout tests a bit more flexible regarding the ordering of
461         invalidateIntrinsicContentSize, to avoid a race between the load
462         completing and the invalidation.
463
464         Also, move the newly added test to use its own WKWebView, since once in a
465         while we get a first layout notification from the previous page, causing the test to fail.
466
467         Un-disable the tests, which now run without any flakes for me with quite a few iterations.
468
469 2016-09-28  Alex Christensen  <achristensen@webkit.org>
470
471         URLParser should properly handle unexpected periods and overflows in IPv4 addresses
472         https://bugs.webkit.org/show_bug.cgi?id=162655
473
474         Reviewed by Geoffrey Garen.
475
476         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
477         (TestWebKitAPI::TEST_F):
478
479 2016-09-28  Ryan Haddad  <ryanhaddad@apple.com>
480
481         Disable flaky API test WebKit2.AutoLayoutIntegration.
482         https://bugs.webkit.org/show_bug.cgi?id=160284
483
484         Unreviewed test gardening.
485
486         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
487         (TEST):
488
489 2016-09-28  Alex Christensen  <achristensen@webkit.org>
490
491         URLParser should ignore tabs in authority
492         https://bugs.webkit.org/show_bug.cgi?id=162694
493
494         Reviewed by Geoffrey Garen.
495
496         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
497         (TestWebKitAPI::TEST_F):
498
499 2016-09-28  Alex Christensen  <achristensen@webkit.org>
500
501         URLParser should ignore extra slashes after scheme:// and handle a missing slash after the port
502         https://bugs.webkit.org/show_bug.cgi?id=162690
503
504         Reviewed by Geoffrey Garen.
505
506         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
507         (TestWebKitAPI::TEST_F):
508
509 2016-09-28  Alex Christensen  <achristensen@webkit.org>
510
511         URLParser should correctly canonicalize uppercase IPv6 addresses
512         https://bugs.webkit.org/show_bug.cgi?id=162680
513
514         Reviewed by Tim Horton.
515
516         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
517         (TestWebKitAPI::TEST_F):
518
519 2016-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
520
521         Adopt MediaRemote SPI to achieve desired Now Playing behavior
522         https://bugs.webkit.org/show_bug.cgi?id=162658
523         <rdar://problem/28499358>
524
525         Reviewed by Jer Noble.
526
527         Introduces 2 unit tests in the new NowPlayingControlsTests test suite. Also provides some basic support for
528         mocking key window status for TestWKWebViews.
529
530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
531         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Added.
532         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
533         (-[NowPlayingTestWebView expectHasActiveNowPlayingSession:]):
534         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]):
535         (TestWebKitAPI::TEST):
536         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Added.
537         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
538         (-[TestWKWebViewHostWindow isKeyWindow]):
539         (-[TestWKWebViewHostWindow makeKeyWindow]):
540         (-[TestWKWebViewHostWindow resignKeyWindow]):
541
542 2016-09-28  Per Arne Vollan  <pvollan@apple.com>
543
544         [Win] Compile fix.
545         https://bugs.webkit.org/show_bug.cgi?id=162670
546
547         Reviewed by Brent Fulgham.
548
549         Make sure we include JavaScriptCore files from the forwarding headers folder.
550         Otherwise we might get multiple definitions if a JSC file is included both
551         from the forwarding headers folder and the JSC source folder, since
552         #pragma once is used in the header files.
553
554         * DumpRenderTree/TestRunner.cpp:
555
556 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
557
558         [GTK] Add Chrome UA quirk
559         https://bugs.webkit.org/show_bug.cgi?id=162617
560
561         Reviewed by Carlos Garcia Campos.
562
563         Update test. This portion of the commit was actually unreviewed.
564
565         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
566         (TestWebKitAPI::TEST):
567
568 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
569
570         [GTK] Adjust OS X UA quirks list
571         https://bugs.webkit.org/show_bug.cgi?id=162616
572
573         "Reviewed" by Carlos Garcia Campos.
574
575         Update test. This portion of the commit was actually unreviewed.
576
577         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
578         (TestWebKitAPI::TEST):
579
580 2016-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
581
582         [GTK] Switch to use GMenu internally in the context menu implementation
583         https://bugs.webkit.org/show_bug.cgi?id=162603
584
585         Reviewed by Michael Catanzaro.
586
587         Remove smart separators test, since that's now done automatically by GTK+.
588
589         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
590         (beforeAll):
591         (testContextMenuWebExtensionMenu): Deleted.
592
593 2016-09-27  Alex Christensen  <achristensen@webkit.org>
594
595         Correctly parse URLs with the first tab in the fragment
596         https://bugs.webkit.org/show_bug.cgi?id=162650
597
598         Reviewed by Saam Barati.
599
600         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
601         (TestWebKitAPI::TEST_F):
602
603 2016-09-27  Alex Christensen  <achristensen@webkit.org>
604
605         URLParser: Handle windows drive letters after two slashes in relative URLs according to spec
606         https://bugs.webkit.org/show_bug.cgi?id=162646
607
608         Reviewed by Saam Barati.
609
610         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
611         (TestWebKitAPI::TEST_F):
612
613 2016-09-27  Alex Christensen  <achristensen@webkit.org>
614
615         URLs with @ in the user should only search for the last @ until the end of the authority and host
616         https://bugs.webkit.org/show_bug.cgi?id=162635
617
618         Reviewed by Geoffrey Garen.
619
620         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
621         (TestWebKitAPI::TEST_F):
622
623 2016-09-27  JF Bastien  <jfbastien@apple.com>
624
625         Speed up Heap::isMarkedConcurrently
626         https://bugs.webkit.org/show_bug.cgi?id=162095
627
628         Reviewed by Filip Pizlo.
629
630         * TestWebKitAPI/CMakeLists.txt:
631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
632         * TestWebKitAPI/Tests/WTF/Consume.cpp: Added.
633         (testConsume):
634         (TestWebKitAPI::TEST):
635
636 2016-09-26  Alex Christensen  <achristensen@webkit.org>
637
638         Implement URLParser::syntaxViolation
639         https://bugs.webkit.org/show_bug.cgi?id=162593
640
641         Reviewed by Geoffrey Garen.
642
643         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
644         (TestWebKitAPI::TEST_F):
645
646 2016-09-27  Anders Carlsson  <andersca@apple.com>
647
648         Turns out OptionSet.cpp wasn't added to the right target. Add it and fix the build for real.
649
650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
651         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
652         (TestWebKitAPI::TEST):
653
654 2016-09-27  Anders Carlsson  <andersca@apple.com>
655
656         Try to fix the GTK+ build.
657
658         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
659         (TestWebKitAPI::TEST):
660
661 2016-09-27  Dan Bernstein  <mitz@apple.com>
662
663         [iOS] REGRESSION (r182126): Selection highlight and handles aren’t visible with WKSelectionGranularityCharacter
664         https://bugs.webkit.org/show_bug.cgi?id=162577
665         <rdar://problem/28481984>
666
667         Reviewed by Simon Fraser.
668
669         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
670         (WTR::UIScriptController::selectionRangeViewRects): Returns null.
671
672         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Declared new
673           selectionRangeViewRects attribute.
674
675         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
676         (WTR::UIScriptContext::jsContext): Added this public accessor.
677
678         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
679         (WTR::selectionRangeViewRects): Generic implementation that returns null.
680         * TestRunnerShared/UIScriptContext/UIScriptController.h:
681
682         * WebKitTestRunner/TestController.cpp:
683         (WTR::updateTestOptionsFromTestHeader): Parse the new useCharacterSelectionGranularity
684           option.
685
686         * WebKitTestRunner/TestOptions.h: Added new useCharacterSelectionGranularity option.
687
688         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
689         (WTR::TestController::platformCreateWebView): Set the configuration’s selectionGranularity
690           property based on the new option.
691
692         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
693         (WTR::PlatformWebView::viewSupportsOptions): Compare selection granularity option values.
694
695         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
696         (WTR::UIScriptController::selectionRangeViewRects): iOS-specific implementation that calls
697           the new -[WKWebView _uiTextSelectionRectViews] and returns an array of view frame
698           dictionaries.
699
700 2016-09-27  Daniel Bates  <dabates@apple.com>
701
702         Cannot run dump-class-layout; dies with "global name 'lldb' is not defined"
703         https://bugs.webkit.org/show_bug.cgi?id=162585
704
705         Reviewed by Simon Fraser.
706
707         Import the lldb module into the global namespace.
708
709         Currently dump-class-layout imports the lldb Python module using the import statement
710         from the helper function import_lldb. The import statement imports the names of the
711         specified module into the scope of import_lldb(); => the names imported from this
712         module cannot be accessed outside the scope of import_lldb(). Other functions in
713         this script assume that the lldb module was imported into the global scope. We should
714         import the module lldb into the global scope, if it exists, so that these functions
715         can find it. Otherwise, we should emit a human readable error message that explains
716         that we failed to import the lldb module.
717
718         Also remove some unnecessary semicolon characters.
719
720         * Scripts/dump-class-layout:
721         (import_lldb):
722
723 2016-09-27  Jer Noble  <jer.noble@apple.com>
724
725         Remove deprecated ENCRYPTED_MEDIA implementation.
726         https://bugs.webkit.org/show_bug.cgi?id=161010
727
728         Reviewed by Eric Carlson.
729
730         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
731
732 2016-09-27  Chris Dumez  <cdumez@apple.com>
733
734         [WK2] Navigating to a Blob URL does not trigger a download
735         https://bugs.webkit.org/show_bug.cgi?id=162574
736
737         Reviewed by Darin Adler.
738
739         Add API that tests navigating to a Blob URL and checks that that the load
740         properly gets converted into a download.
741
742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
743         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
744         (-[BlobDownloadDelegate _downloadDidStart:]):
745         (-[BlobDownloadDelegate _download:didReceiveResponse:]):
746         (-[BlobDownloadDelegate _download:didReceiveData:]):
747         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
748         (-[BlobDownloadDelegate _downloadDidFinish:]):
749         (-[DownloadBlobURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
750         (TEST):
751         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Added.
752
753 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
754
755         [GTK] Install binaries to pkglibexecdir rather than bindir
756         https://bugs.webkit.org/show_bug.cgi?id=162602
757
758         Reviewed by Carlos Garcia Campos.
759
760         Install MiniBrowser to LIBEXEC_INSTALL_DIR rather than EXEC_INSTALL_DIR.
761
762         * MiniBrowser/gtk/CMakeLists.txt:
763
764 2016-09-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
765
766         [EFL] Locate color picker popup to center of window
767         https://bugs.webkit.org/show_bug.cgi?id=162540
768
769         Reviewed by Michael Catanzaro.
770
771         Color picker popup hasn't located in a center of main window, because
772         elm_win_center() function doesn't work correctly. It looks a bug.
773
774         To fix the problem, this patch uses evas_object_geometry_set() instead.
775
776         * MiniBrowser/efl/main.c:
777         (_color_picker_request_cb):
778
779 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
780
781         [GTK] Disable ACCELERATED_2D_CANVAS when using build-webkit
782         https://bugs.webkit.org/show_bug.cgi?id=162600
783
784         Reviewed by Carlos Garcia Campos.
785
786         * Scripts/webkitperl/FeatureList.pm:
787
788 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
789
790         PyGIWarnings printed by webkit-patch
791         https://bugs.webkit.org/show_bug.cgi?id=152470
792
793         Reviewed by Carlos Garcia Campos.
794
795         Update to a newer version of the keyring module, since this bug has been fixed upstream for
796         a while. But be careful not to update to the latest version, since it has some compatibility
797         breaks and requires the SecretService python module on Linux, but I couldn't figure out how
798         to autoinstall it successfully.
799
800         * Scripts/webkitpy/thirdparty/__init__.py:
801         (AutoinstallImportHook._install_keyring):
802
803 2016-09-26  Ryan Haddad  <ryanhaddad@apple.com>
804
805         Add Sierra to the flakiness dashboard.
806         https://bugs.webkit.org/show_bug.cgi?id=162509
807
808         Reviewed by Alexey Proskuryakov.
809
810         * TestResultServer/static-dashboards/builders.jsonp:
811
812 2016-09-26  Daniel Bates  <dabates@apple.com>
813
814         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
815         https://bugs.webkit.org/show_bug.cgi?id=162365
816
817         Reviewed by Simon Fraser.
818
819         * DumpRenderTree/TestRunner.h:
820         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
821
822 2016-09-26  Tomas Popela  <tpopela@redhat.com>
823
824         [GTK] TestContextMenu is failing
825         https://bugs.webkit.org/show_bug.cgi?id=162569
826
827         We cannot use the MP3 file in the TestContextMenu, as it will not work
828         by default on most distributions (that don't have an MP3 codecs
829         installed). Change the test to use OGG file instead.
830
831         Reviewed by Michael Catanzaro.
832
833         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
834         (testContextMenuDefaultMenu):
835
836 2016-09-26  Yusuke Suzuki  <utatane.tea@gmail.com>
837
838         Using char16_t instead of wchar_t in TestWebKitAPI URLParser tests
839         https://bugs.webkit.org/show_bug.cgi?id=162537
840
841         Reviewed by Alex Christensen.
842
843         Some build bot (Linux ARM GTK port) fails since we cannot select
844         the specific StringBuilder::append method for wchar_t.
845
846         wchar_t implementation highly depends on platforms. sizeof(wchar_t) == 2
847         in Windows, while sizeof(wchar_t) == 4 in Linux and OS X. So, ICU
848         uses wchar_t for UChar (UTF-16) in Windows while it doesn't in other
849         platforms.
850
851         StringBuilder::append is overloaded for UChar. In Windows, we can pass
852         wchar_t since UChar is wchar_t. However, we cannot do that in other platforms.
853
854         Instead of using wchar_t, we use more platform portable UTF-16 literal for
855         testing. Use char16_t and C++11 UTF-16 literal.
856
857         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
858         (TestWebKitAPI::utf16String):
859         (TestWebKitAPI::TEST_F):
860         (TestWebKitAPI::wideString): Deleted.
861
862 2016-09-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
863
864         [EFL] Adjust EFL indentation to EFL MiniBrowser
865         https://bugs.webkit.org/show_bug.cgi?id=162542
866
867         Unreviewed, EFL simple coding style fix.
868
869         Some functions wasn't applied EFL coding style in prefix fix.
870
871         * MiniBrowser/efl/main.c:
872         (_key_down_cb):
873         (view_focus_set):
874         (_mouse_down_cb):
875         (title_set):
876         (_title_changed_cb):
877         (_url_changed_cb):
878         (_back_forward_list_changed_cb):
879         (_progress_cb):
880         (_error_cb):
881         (_download_request_cb):
882         (close_file_picker):
883         (_filepicker_parent_deletion_cb):
884         (_filepicker_deletion_cb):
885         (_fileselector_done_cb):
886         (_file_chooser_request_cb):
887         (_download_finished_cb):
888         (_download_failed_cb):
889         (_color_changed_cb):
890         (_color_item_selected_cb):
891         (_color_picker_ok_clicked_cb):
892         (_color_picker_cancel_clicked_cb):
893         (_color_picker_dismiss_cb):
894         (_color_picker_request_cb):
895         (quit):
896         (has_scheme):
897         (url_from_user_input):
898         (url_load_from_user_input):
899         (_url_bar_activated_cb):
900         (_url_bar_clicked_cb):
901         (_search_field_aborted_cb):
902         (_search_field_activated_cb):
903         (_search_field_clicked_cb):
904         (_back_button_clicked_cb):
905         (_forward_button_clicked_cb):
906         (_search_backward_button_clicked_cb):
907         (_search_forward_button_clicked_cb):
908         (_search_case_option_changed):
909         (_search_word_start_option_changed_cb):
910         (_search_close_button_clicked_cb):
911         (_refresh_button_clicked_cb):
912         (_stop_button_clicked_cb):
913         (list_item_label_get):
914         (_list_item_select_cb):
915         (navigation_button_longpress_process):
916         (_forward_button_longpress_cb):
917         (_back_button_longpress_cb):
918         (quit_event_loop):
919         (_ok_clicked_cb):
920         (_file_entry_dialog_show):
921
922 2016-09-24  Chris Dumez  <cdumez@apple.com>
923
924         [WK2] anchor.download attribute value is ignored by NETWORK_SESSION code path
925         https://bugs.webkit.org/show_bug.cgi?id=162531
926
927         Reviewed by Darin Adler.
928
929         Update decideDestinationWithSuggestedFilename() to return a actual file path
930         instead of nullptr. The NETWORK_SESSION code path cancels the download when
931         decideDestinationWithSuggestedFilename() returns an empty file path, unlike
932         the !NETWORK_SESSION code path that just continue downloading without
933         explicitely setting a destination path. This lead to different test results
934         for NETWORK_SESSION and !NETWORK_SESSION code paths. Returns a valid
935         destination path makes more sense and leads to consistent results.
936
937         * WebKitTestRunner/TestController.cpp:
938         (WTR::TestController::decideDestinationWithSuggestedFilename):
939
940 2016-09-23  Wenson Hsieh  <wenson_hsieh@apple.com>
941
942         [mac-sierra] 2 WKWebViewCandidateTests API test failures
943         https://bugs.webkit.org/show_bug.cgi?id=162470
944
945         Reviewed by Tim Horton.
946
947         VideoControlsManager, WKWebViewCandidateTests and CandidateTests should not be running on 10.12.0. Guard these
948         tests with an SDK check to prevent 10.12.0 bots from building them.
949
950         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
951         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
952         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
953
954 2016-09-23  Alex Christensen  <achristensen@webkit.org>
955
956         Refactor URLParser
957         https://bugs.webkit.org/show_bug.cgi?id=162516
958
959         Reviewed by Brady Eidson.
960
961         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
962         (TestWebKitAPI::TEST_F):
963
964 2016-09-23  Caitlin Potter  <caitp@igalia.com>
965
966         [JSC] Implement parsing of Async Functions
967         https://bugs.webkit.org/show_bug.cgi?id=161409
968
969         Reviewed by Yusuke Suzuki.
970
971         * Scripts/build-jsc:
972         (cMakeArgsFromFeatures):
973         * Scripts/webkitperl/FeatureList.pm:
974         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
975
976 2016-09-23  Alex Christensen  <achristensen@webkit.org>
977
978         Refactor URLParser
979         https://bugs.webkit.org/show_bug.cgi?id=162511
980
981         Reviewed by Brady Eidson.
982
983         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
984         (TestWebKitAPI::TEST_F):
985         (TestWebKitAPI::checkURL):
986
987 2016-09-23  Alexey Proskuryakov  <ap@apple.com>
988
989         iOS playback user action tests fail on some machines
990         https://bugs.webkit.org/show_bug.cgi?id=162504
991         rdar://problem/28013994
992
993         Reviewed by Jer Noble.
994
995         Avoid the need to have a timeout.
996
997         * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
998         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
999         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
1000         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
1001
1002 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1003
1004         REGRESSION(r204163): [GTK] API test /webkit2/WebKitSecurityManager/file-xhr is failing
1005         https://bugs.webkit.org/show_bug.cgi?id=161607
1006
1007         Reviewed by Michael Catanzaro.
1008
1009         Since r204163, in case of cross origin error when loading the XHR, the load fails and an error message is shown
1010         in the console, but there isn't any js expcetion, which is what we were checking. Now, we check that there
1011         aren't exceptions, and that the error message is sent to the console.
1012
1013         * Scripts/run-gtk-tests:
1014         (TestRunner):
1015         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1016         (consoleMessageReceivedCallback):
1017         (testWebContextSecurityFileXHR):
1018
1019 2016-09-23  Ryan Haddad  <ryanhaddad@apple.com>
1020
1021         Use correct hardware for Sierra Debug WK2 testers.
1022         https://bugs.webkit.org/show_bug.cgi?id=162474
1023
1024         Reviewed by Alexey Proskuryakov.
1025
1026         * BuildSlaveSupport/build.webkit.org-config/config.json:
1027
1028 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1029
1030         [GTK] Make all WebView tests have a WebKitUserContentManager
1031         https://bugs.webkit.org/show_bug.cgi?id=162487
1032
1033         Reviewed by Michael Catanzaro.
1034
1035         It simplifies tests using the user content manager, and allows to use it without having to subclass WebViewTest.
1036
1037         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1038         (ConsoleMessageTest::ConsoleMessageTest):
1039         (ConsoleMessageTest::~ConsoleMessageTest):
1040         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1041         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1042         (testUserContentManagerInjectedStyleSheet):
1043         (testUserContentManagerInjectedScript):
1044         (UserScriptMessageTest::UserScriptMessageTest):
1045         (beforeAll):
1046         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1047         (testWebViewIsPlayingAudio):
1048         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1049         (WebViewTest::WebViewTest):
1050         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1051
1052 2016-09-23  Antoine Quint  <graouts@apple.com>
1053
1054         Add a new runtime flag for work on modern media controls (off by default)
1055         https://bugs.webkit.org/show_bug.cgi?id=162420
1056         <rdar://problem/27989489>
1057
1058         Reviewed by Eric Carlson.
1059
1060         * DumpRenderTree/mac/DumpRenderTree.mm:
1061         (resetWebPreferencesToConsistentValues):
1062         * DumpRenderTree/win/DumpRenderTree.cpp:
1063         (resetWebPreferencesToConsistentValues):
1064         * Scripts/webkitperl/FeatureList.pm:
1065         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1066         (WTR::InjectedBundle::beginTesting):
1067         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1068         (WTR::TestRunner::setModernMediaControlsEnabled):
1069         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1070
1071 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1072
1073         REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale
1074         https://bugs.webkit.org/show_bug.cgi?id=162139
1075
1076         Reviewed by Michael Catanzaro.
1077
1078         Add test cases to check the behavior when using the C locale and an invalid locale.
1079
1080         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1081         (testWebContextLanguages):
1082
1083 2016-09-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1084
1085         [EFL] alert box is not displayed 
1086         https://bugs.webkit.org/show_bug.cgi?id=156395
1087
1088         Reviewed by Gyuyoung Kim.
1089
1090         Some popup objects(alert, confirm, prompt, file entry dialog) used the ecore_main_loop_begin() to make
1091         the modal popup but ecore_main_loop_begin() was not executed inside an exisiting main loop. So we have
1092         to use the ecore_main_loop_iterate() instead of the ecore_main_loop_begin().
1093
1094         * MiniBrowser/efl/main.c:
1095         (_ok_clicked_cb):
1096         (_file_entry_dialog_show):
1097         (_javascript_alert_cb):
1098         (_javascript_confirm_cb):
1099         (_javascript_prompt_cb):
1100         (quit_event_loop): Deleted.
1101
1102 2016-09-22  Matthew Hanson  <matthew_hanson@apple.com>
1103
1104         Add an API for getting the branch identifier from a Git or SVN checkout.
1105         https://bugs.webkit.org/show_bug.cgi?id=151570
1106         rdar://problem/17959831
1107
1108         Reviewed by David Kilzer.
1109
1110         This patch adds a function called svnIdentifierForPath. This function returns either "trunk",
1111         the name of the tag, or the name of the branch, as appropriate. This function is necessary for
1112         a VCSUtils client that is not checked in to the WebKit project.
1113
1114         This patch also breaks up pathRelativeToSVNRepositoryRootForPath into four functions:
1115         - pathRelativeToSVNRepositoryRootForPath
1116         - svnInfoForPath
1117         - svnURLForPath
1118         - svnRepositoryRootForPath
1119
1120         This allows us to reuse logic from pathRelativeToSVNRepositoryRootForPath in svnIdentifierForPath and
1121         allows clients of VCSUtils to extract what arbitrary information from the `svn info` command regardless
1122         of SCM.
1123
1124         * Scripts/VCSUtils.pm:
1125         (svnInfoForPath):
1126         Copied logic that previously lived in pathRelativeToSVNRepositoryRootForPath.
1127         Make code safe to use for a path, and not just for the CWD.
1128
1129         (svnURLForPath):
1130         Calls svnInfoForPath and extracts the URL.
1131
1132         (svnRepositoryRootForPath):
1133         Calls svnInfoForPath and extracts the Repository Root.
1134
1135         (svnIdentifierForPath):
1136         Calls pathRelativeToSVNRepositoryRootForPath and extracts the repository identifier.
1137
1138         (pathRelativeToSVNRepositoryRootForPath):
1139         Now uses svnURLForPath and svnRepositoryRootForPath instead of being responsible for
1140         determining both values.
1141
1142 2016-09-22  Megan Gardner  <megan_gardner@apple.com>
1143
1144         Add long press selection test
1145         https://bugs.webkit.org/show_bug.cgi?id=162367
1146
1147         Reviewed by Simon Fraser.
1148
1149         Add support to UIScriptController to synthesize long press events on iOS.
1150         This required adding long-press functionality to HIDEventGenerator.
1151
1152         HIDEventGenerator sends the touchDown, but must then send the touchUp with
1153         a dispatch_after (rather than sleeping, as we do for other events) in order
1154         for the gesture recognizers to correctly detect a long press.
1155
1156         Use the long press synthesis in a test that detects whether a long press
1157         gesture triggers text selection.
1158
1159         Fixed incorrect constants. NSTimeInterval is in seconds, original numbers
1160         were nanoseconds and typedefed to long without regard to the type
1161         differences. Redid constants to be the right value, and converted upon use.
1162
1163         Cleaned up unused enum types.
1164
1165         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1166         (WTR::UIScriptController::longPressAtPoint):
1167         (WTR::UIScriptController::forcePressAtPoint):
1168         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
1169         * Scripts/webkitpy/common/config/contributors.json:
1170         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1171         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1172         (WTR::UIScriptController::longPressAtPoint):
1173         (WTR::UIScriptController::forcePressAtPoint):
1174         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
1175         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1176         * WebKitTestRunner/ios/HIDEventGenerator.h:
1177         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1178         (-[HIDEventGenerator _createIOHIDEventType:]):
1179         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1180         (-[HIDEventGenerator clearTap:]):
1181         (-[HIDEventGenerator longPressTimerCall:]):
1182         (-[HIDEventGenerator longPressFinish:completionBlock:]):
1183         (-[HIDEventGenerator longPress:completionBlock:]):
1184         (-[HIDEventGenerator forcePress:completionBlock:]):
1185         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1186         (WTR::UIScriptController::longPressAtPoint):
1187         (WTR::UIScriptController::forcePressAtPoint):
1188         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
1189
1190 2016-09-22  Jonathan Bedard  <jbedard@apple.com>
1191
1192         Automatic Text Replacement Testing in WebKit2
1193         https://bugs.webkit.org/show_bug.cgi?id=161919
1194
1195         Reviewed by Ryosuke Niwa.
1196
1197         Implemented test hooks for text replacement for WebKit2.
1198         Note that spell checking has not been implemented, so most tests which use text replacement still fail.
1199
1200         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Removed setAutomaticLinkDetectionEnabled from TestRunner, moved to Internals.
1201         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
1202         (WTR::InjectedBundle::beginTesting): Ditto.
1203         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
1204         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1205         * WebKitTestRunner/TestController.cpp:
1206         (WTR::TestController::runTest): Place TextChecker into testing mode.
1207
1208 2016-09-21  Dan Bernstein  <mitz@apple.com>
1209
1210         [macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
1211         https://bugs.webkit.org/show_bug.cgi?id=162359
1212         <rdar://problem/27776454>
1213
1214         Reviewed by Tim Horton.
1215
1216         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1217         (TEST):
1218
1219 2016-09-21  Keith Miller  <keith_miller@apple.com>
1220
1221         Fix build for future versions of Clang.
1222         https://bugs.webkit.org/show_bug.cgi?id=162346
1223
1224         Reviewed by Filip Pizlo.
1225
1226         * TestWebKitAPI/Counters.cpp:
1227         * TestWebKitAPI/Counters.h:
1228         (DeleterCounter::deleterCount):
1229         (DeleterCounter::TestingScope::TestingScope):
1230         (DeleterCounter::operator()):
1231         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
1232         (TestWebKitAPI::TEST):
1233         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1234         (TestWebKitAPI::TEST):
1235
1236 2016-09-21  Commit Queue  <commit-queue@webkit.org>
1237
1238         Unreviewed, rolling out r206222 and r206227.
1239         https://bugs.webkit.org/show_bug.cgi?id=162361
1240
1241         "broke the windows build" (Requested by keith_mi_ on #webkit).
1242
1243         Reverted changesets:
1244
1245         "Fix build for future versions of Clang."
1246         https://bugs.webkit.org/show_bug.cgi?id=162346
1247         http://trac.webkit.org/changeset/206222
1248
1249         "Attempt to fix windows build after r206222."
1250         http://trac.webkit.org/changeset/206227
1251
1252 2016-09-21  Alex Christensen  <achristensen@webkit.org>
1253
1254         URLParser should match URL::parse when parsing data urls with slashes in them
1255         https://bugs.webkit.org/show_bug.cgi?id=162352
1256
1257         Reviewed by Darin Adler.
1258
1259         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1260         (TestWebKitAPI::TEST_F):
1261
1262 2016-09-21  Alex Christensen  <achristensen@webkit.org>
1263
1264         URLParser should fail when parsing invalid relative URLs with no schemes
1265         https://bugs.webkit.org/show_bug.cgi?id=162355
1266
1267         Reviewed by Tim Horton.
1268
1269         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1270         (TestWebKitAPI::TEST_F):
1271
1272 2016-09-21  Keith Miller  <keith_miller@apple.com>
1273
1274         Fix build for future versions of Clang.
1275         https://bugs.webkit.org/show_bug.cgi?id=162346
1276
1277         Reviewed by Filip Pizlo.
1278
1279         * TestWebKitAPI/Counters.cpp:
1280         * TestWebKitAPI/Counters.h:
1281         (DeleterCounter::deleterCount):
1282         (DeleterCounter::TestingScope::TestingScope):
1283         (DeleterCounter::operator()):
1284         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
1285         (TestWebKitAPI::TEST):
1286         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1287         (TestWebKitAPI::TEST):
1288
1289 2016-09-21  Alex Christensen  <achristensen@webkit.org>
1290
1291         Prepare API tests for enabling URLParser by default
1292         https://bugs.webkit.org/show_bug.cgi?id=162341
1293
1294         Reviewed by Tim Horton.
1295
1296         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1297         (TestWebKitAPI::checkURL):
1298         (TestWebKitAPI::checkRelativeURL):
1299         (TestWebKitAPI::checkURLDifferences):
1300         (TestWebKitAPI::checkRelativeURLDifferences):
1301         (TestWebKitAPI::shouldFail):
1302
1303 2016-09-21  Alex Christensen  <achristensen@webkit.org>
1304
1305         URLParser: Correctly parse URLs that are just nonspecialscheme:/
1306         https://bugs.webkit.org/show_bug.cgi?id=162340
1307
1308         Reviewed by Tim Horton.
1309
1310         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1311         (TestWebKitAPI::TEST_F):
1312
1313 2016-09-21  Alex Christensen  <achristensen@webkit.org>
1314
1315         URLParser: correctly parse relative URLs that are just one character
1316         https://bugs.webkit.org/show_bug.cgi?id=162344
1317
1318         Reviewed by Tim Horton.
1319
1320         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1321         (TestWebKitAPI::TEST_F):
1322
1323 2016-09-20  Alex Christensen  <achristensen@webkit.org>
1324
1325         Optimize URLParser
1326         https://bugs.webkit.org/show_bug.cgi?id=162105
1327
1328         Reviewed by Geoffrey Garen.
1329
1330         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1331         (TestWebKitAPI::TEST_F):
1332
1333 2016-09-20  Aakash Jain  <aakash_jain@apple.com>
1334
1335         enable remote_api (for debugging) in flakiness dashboard app
1336         https://bugs.webkit.org/show_bug.cgi?id=162325
1337
1338         Reviewed by Alexey Proskuryakov.
1339
1340         * TestResultServer/app.yaml: enabled remote_api and datastore_admin.
1341
1342 2016-09-20  Ryan Haddad  <ryanhaddad@apple.com>
1343
1344         Unreviewed, rolling out r206180.
1345
1346         Roll r206178 back in as the necessary changes have been made
1347         on the build master.
1348
1349         Reverted changeset:
1350
1351         "Unreviewed, rolling out r206178."
1352         https://bugs.webkit.org/show_bug.cgi?id=162249
1353         http://trac.webkit.org/changeset/206180
1354
1355 2016-09-20  Alexey Proskuryakov  <ap@apple.com>
1356
1357         Use a hardcoded patch for sRGB color profile
1358         https://bugs.webkit.org/show_bug.cgi?id=162320
1359         rdar://problem/28387318
1360
1361         Reviewed by Simon Fraser.
1362
1363         This is a workaround for rdar://problem/28392768
1364
1365         * DumpRenderTree/mac/LayoutTestHelper.m:
1366         (installLayoutTestColorProfile):
1367
1368 2016-09-20  Ryan Haddad  <ryanhaddad@apple.com>
1369
1370         Unreviewed, rolling out r206178.
1371
1372         This change caused buildbot config issues.
1373
1374         Reverted changeset:
1375
1376         "Add Sierra bots to buildbot and dashboard."
1377         https://bugs.webkit.org/show_bug.cgi?id=162249
1378         http://trac.webkit.org/changeset/206178
1379
1380 2016-09-20  Dean Johnson  <dean_johnson@apple.com>
1381
1382         Add Sierra bots to buildbot and dashboard.
1383         https://bugs.webkit.org/show_bug.cgi?id=162249
1384
1385         Reviewed by Alexey Proskuryakov.
1386
1387         * BuildSlaveSupport/build.webkit.org-config/config.json:
1388         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1390         (WebKitBuildbot):
1391
1392 2016-09-20  Alex Christensen  <achristensen@webkit.org>
1393
1394         Reduce allocations in URLParser
1395         https://bugs.webkit.org/show_bug.cgi?id=162241
1396
1397         Reviewed by Chris Dumez.
1398
1399         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1400         (TestWebKitAPI::TEST_F):
1401         (TestWebKitAPI::checkURL):
1402
1403 2016-09-20  Alex Christensen  <achristensen@webkit.org>
1404
1405         Align URLParser with web platform tests when parsing non-special relative URLs ending in AuthorityOrHost state
1406         https://bugs.webkit.org/show_bug.cgi?id=162251
1407
1408         Reviewed by Tim Horton.
1409
1410         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1411         (TestWebKitAPI::checkURL):
1412         (TestWebKitAPI::TEST_F):
1413         (TestWebKitAPI::checkRelativeURL):
1414         (TestWebKitAPI::checkURLDifferences):
1415         (TestWebKitAPI::checkRelativeURLDifferences):
1416
1417 2016-09-20  Alex Christensen  <achristensen@webkit.org>
1418
1419         URLParser should allow '@' in user
1420         https://bugs.webkit.org/show_bug.cgi?id=162272
1421
1422         Reviewed by Tim Horton.
1423
1424         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1425         (TestWebKitAPI::TEST_F):
1426
1427 2016-09-20  Alex Christensen  <achristensen@webkit.org>
1428
1429         URLParser: Fix parsing relative URLs with one slash after the scheme:
1430         https://bugs.webkit.org/show_bug.cgi?id=162294
1431
1432         Reviewed by Tim Horton.
1433
1434         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1435         (TestWebKitAPI::TEST_F):
1436
1437 2016-09-20  Alex Christensen  <achristensen@webkit.org>
1438
1439         Fix Windows file URL quirks in URLParser
1440         https://bugs.webkit.org/show_bug.cgi?id=162303
1441
1442         Reviewed by Tim Horton.
1443
1444         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1445         (TestWebKitAPI::TEST_F):
1446
1447 2016-09-20  Filip Pizlo  <fpizlo@apple.com>
1448
1449         Make MarkedBlock state tracking support overlapped allocation and marking state
1450         https://bugs.webkit.org/show_bug.cgi?id=161581
1451
1452         Reviewed by Geoffrey Garen.
1453         
1454         Remove the always-trigger-copy-phase configuration.
1455
1456         * Scripts/run-jsc-stress-tests:
1457
1458 2016-09-20  Don Olmstead  <don.olmstead@am.sony.com>
1459
1460         [WinCairo] Use find_package cairo in build
1461         https://bugs.webkit.org/show_bug.cgi?id=162239
1462
1463         Reviewed by Alex Christensen.
1464
1465         * DumpRenderTree/PlatformWin.cmake:
1466         * TestWebKitAPI/PlatformWin.cmake:
1467
1468 2016-09-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1469
1470         Unreviewed build fix on 10.10 bots.
1471
1472         * TestWebKitAPI/mac/TestWKWebViewMac.h:
1473
1474 2016-09-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1475
1476         VideoControlsManager.VideoControlsManagerSingleLargeVideo fails intermittently on the Mac WK2 bot
1477         https://bugs.webkit.org/show_bug.cgi?id=162255
1478
1479         Reviewed by Jer Noble.
1480
1481         This is reproducible by running the test repeatedly in a for loop (locally, I observed that running the test
1482         back-to-back would result in the second one failing). This suggests that even on the runloop after the video
1483         starts playing, the state of the playback controls manager may not be up to date in the UI process. Instead, we
1484         can just spin the runloop until the playback controls are shown, which makes back-to-back tests to succeed and
1485         will probably address flakiness on the bots for this test.
1486
1487         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1488         (TestWebKitAPI::TEST):
1489         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1490
1491 2016-09-20  Per Arne Vollan  <pvollan@apple.com>
1492
1493         [Win] Run layout tests in parallel.
1494         https://bugs.webkit.org/show_bug.cgi?id=162145
1495
1496         Reviewed by Brent Fulgham.
1497
1498         To speed up layout tests, try running them in parallel.
1499
1500         * Scripts/webkitpy/port/win.py:
1501         (WinPort.default_child_processes): Deleted.
1502
1503 2016-09-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1504
1505         Unreviewed build fix after r206135
1506
1507         NSEventMaskLeftMouseDown and friends are only available on 10.12.
1508
1509         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
1510         (__simulated_forceClickAssociatedEventsMask):
1511
1512 2016-09-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1513
1514         Add a unit test covering <https://trac.webkit.org/changeset/205983>
1515         https://bugs.webkit.org/show_bug.cgi?id=162112
1516
1517         Reviewed by Beth Dakin.
1518
1519         Adds a new unit test covering the changes in r205983 along with the infrastructure needed to support it. Also
1520         further refactors the TestWKWebView used by VideoControlsManager and WKWebViewCandidateTests so that in both
1521         cases, we add the WKWebView to a visible key window, and when sending a mouse down event, we propagate the event
1522         at the window level rather than the view level, allowing greater flexibility to simulate behaviors such as
1523         pressure-sensitive events that are needed for the new test.
1524
1525         Also rewrites currently disabled unit tests in CandidateTests as WebKit2 unit tests in WKWebViewCandidateTests,
1526         checking whether or not to should be requesting candidates in password and non-password fields.
1527
1528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1529         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1530         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
1531         (TestWebKitAPI::TEST):
1532         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1533         (-[CandidateTestWebView typeString:inputMessage:]):
1534         (+[CandidateTestWebView setUpWithFrame:testPage:]):
1535         * TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Added.
1536         * TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Added.
1537         * TestWebKitAPI/mac/TestWKWebViewMac.h:
1538         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
1539         (__simulated_forceClickAssociatedEventsMask):
1540         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1541         (-[TestWKWebView initWithFrame:]):
1542         (-[TestWKWebView initWithFrame:configuration:]):
1543         (-[TestWKWebView _setUpTestWindow:]):
1544         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1545         (-[TestWKWebView typeCharacter:]):
1546         (-[TestWKWebView mouseDownAtPoint:]): Deleted.
1547
1548 2016-09-19  Alex Christensen  <achristensen@webkit.org>
1549
1550         URLParser can read memory out of bounds
1551         https://bugs.webkit.org/show_bug.cgi?id=162206
1552
1553         Reviewed by Geoff Garen.
1554
1555         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1556         (TestWebKitAPI::TEST_F):
1557
1558 2016-09-19  Daniel Bates  <dabates@apple.com>
1559
1560         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
1561         https://bugs.webkit.org/show_bug.cgi?id=162167
1562
1563         Reviewed by Simon Fraser.
1564
1565         * Scripts/webkitperl/FeatureList.pm:
1566         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1567
1568 2016-09-19  Nan Wang  <n_wang@apple.com>
1569
1570         AX: Add accessibility support for details element on iOS
1571         https://bugs.webkit.org/show_bug.cgi?id=162041
1572
1573         Reviewed by Chris Fleizach.
1574
1575         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1576         (AccessibilityUIElement::isExpanded):
1577         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1578         (WTR::AccessibilityUIElement::isExpanded):
1579
1580 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
1581
1582         [EFL] Bump efl library to 1.18.1
1583         https://bugs.webkit.org/show_bug.cgi?id=162120
1584
1585         Reviewed by Michael Catanzaro.
1586
1587         * efl/jhbuild.modules: Use efl-1.18.1 instead of 1.18.
1588
1589 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1590
1591         [EFL] Adjust EFL coding style to EFL MiniBrowser
1592         https://bugs.webkit.org/show_bug.cgi?id=162119
1593
1594         Reviewed by Michael Catanzaro.
1595
1596         Apply EFL coding style to main.c for MiniBrowser.
1597           - Use _foo_cb instead of on_foo for callback function
1598           - Use 3 spaces and use 2 spaces in keywords.
1599
1600         - EFL coding style.
1601           https://phab.enlightenment.org/w/coding_convention/
1602
1603         Additionally this patch adds an exception rule that style checker doesn't
1604         check indentation rule in EFL MiniBrowser.
1605
1606         * MiniBrowser/efl/main.c:
1607         (miniBrowserViewSmartClass):
1608         (window_find_with_ewk_view):
1609         (_tooltip_show):
1610         (window_tooltip_hide):
1611         (window_tooltip_update):
1612         (_mouse_in_cb):
1613         (_mouse_move_cb):
1614         (_mouse_out_cb):
1615         (_mouse_wheel_cb):
1616         (_window_resize_cb):
1617         (update_view_favicon):
1618         (_icon_changed_cb):
1619         (window_free):
1620         (window_close):
1621         (search_icon_show):
1622         (search_box_show):
1623         (search_box_hide):
1624         (history_list_hide):
1625         (save_page_contents_callback):
1626         (script_execute_callback):
1627         (toggle_window_fullscreen):
1628         (_key_down_cb):
1629         (_mouse_down_cb):
1630         (_title_changed_cb):
1631         (_url_changed_cb):
1632         (_back_forward_list_changed_cb):
1633         (_progress_cb):
1634         (_error_cb):
1635         (_download_request_cb):
1636         (close_file_picker):
1637         (_filepicker_parent_deletion_cb):
1638         (_filepicker_deletion_cb):
1639         (_fileselector_done_cb):
1640         (_file_chooser_request_cb):
1641         (_download_finished_cb):
1642         (_download_failed_cb):
1643         (_color_changed_cb):
1644         (_color_item_selected_cb):
1645         (_color_picker_ok_clicked_cb):
1646         (_color_picker_cancel_clicked_cb):
1647         (_color_picker_dismiss_cb):
1648         (_color_picker_request_cb):
1649         (_url_bar_activated_cb):
1650         (_url_bar_clicked_cb):
1651         (_search_field_aborted_cb):
1652         (_search_field_activated_cb):
1653         (_search_field_clicked_cb):
1654         (_back_button_clicked_cb):
1655         (_forward_button_clicked_cb):
1656         (_search_backward_button_clicked_cb):
1657         (_search_forward_button_clicked_cb):
1658         (_search_case_option_changed):
1659         (_search_word_start_option_changed_cb):
1660         (_search_close_button_clicked_cb):
1661         (_refresh_button_clicked_cb):
1662         (_stop_button_clicked_cb):
1663         (_list_item_select_cb):
1664         (navigation_button_longpress_process):
1665         (_forward_button_longpress_cb):
1666         (_back_button_longpress_cb):
1667         (_ok_clicked_cb):
1668         (_file_entry_dialog_show):
1669         (_javascript_alert_cb):
1670         (_javascript_confirm_cb):
1671         (_javascript_prompt_cb):
1672         (_javascript_before_unload_confirm_cb):
1673         (_popup_menu_item_clicked_cb):
1674         (popup_menu_populate):
1675         (_popup_menu_show):
1676         (_popup_menu_hide):
1677         (_window_geometry_get):
1678         (_window_geometry_set):
1679         (_fullscreen_accept_cb):
1680         (_fullscreen_deny_cb):
1681         (_fullscreen_enter_cb):
1682         (_fullscreen_exit_cb):
1683         (_window_create_cb):
1684         (_window_close_cb):
1685         (_context_menu_item_selected_cb):
1686         (context_menu_populate):
1687         (_context_menu_show):
1688         (_context_menu_hide):
1689         (auth_popup_close):
1690         (_auth_cancel_cb):
1691         (_auth_ok_cb):
1692         (_authentication_request_cb):
1693         (_search_text_found_cb):
1694         (_tooltip_text_set):
1695         (_tooltip_text_unset):
1696         (_navigation_policy_decision_cb):
1697         (_home_button_clicked_cb):
1698         (_window_deletion_cb):
1699         (create_toolbar_button):
1700         (window_create):
1701         (configuration):
1702         (parse_cookies_policy):
1703         (parse_window_size):
1704         (elm_main):
1705         (on_tooltip_show): Deleted.
1706         (on_mouse_in): Deleted.
1707         (on_mouse_move): Deleted.
1708         (on_mouse_out): Deleted.
1709         (on_mouse_wheel): Deleted.
1710         (on_window_resize): Deleted.
1711         (on_icon_changed_cb): Deleted.
1712         (on_key_down): Deleted.
1713         (on_mouse_down): Deleted.
1714         (on_title_changed): Deleted.
1715         (on_url_changed): Deleted.
1716         (on_back_forward_list_changed): Deleted.
1717         (on_progress): Deleted.
1718         (on_error): Deleted.
1719         (on_download_request): Deleted.
1720         (on_filepicker_parent_deletion): Deleted.
1721         (on_filepicker_deletion): Deleted.
1722         (on_fileselector_done): Deleted.
1723         (on_file_chooser_request): Deleted.
1724         (on_download_finished): Deleted.
1725         (on_download_failed): Deleted.
1726         (on_color_changed): Deleted.
1727         (on_color_item_selected): Deleted.
1728         (on_color_picker_ok_clicked): Deleted.
1729         (on_color_picker_cancel_clicked): Deleted.
1730         (on_color_picker_dismiss): Deleted.
1731         (on_color_picker_request): Deleted.
1732         (on_url_bar_activated): Deleted.
1733         (on_url_bar_clicked): Deleted.
1734         (on_search_field_aborted): Deleted.
1735         (on_search_field_activated): Deleted.
1736         (on_search_field_clicked): Deleted.
1737         (on_back_button_clicked): Deleted.
1738         (on_forward_button_clicked): Deleted.
1739         (on_search_backward_button_clicked): Deleted.
1740         (on_search_forward_button_clicked): Deleted.
1741         (on_search_case_option_changed): Deleted.
1742         (on_search_word_start_option_changed): Deleted.
1743         (on_search_close_button_clicked): Deleted.
1744         (on_refresh_button_clicked): Deleted.
1745         (on_stop_button_clicked): Deleted.
1746         (on_list_item_select): Deleted.
1747         (on_forward_button_longpress): Deleted.
1748         (on_back_button_longpress): Deleted.
1749         (on_ok_clicked): Deleted.
1750         (show_file_entry_dialog): Deleted.
1751         (on_javascript_alert): Deleted.
1752         (on_javascript_confirm): Deleted.
1753         (on_javascript_prompt): Deleted.
1754         (on_javascript_before_unload_confirm): Deleted.
1755         (on_popup_menu_item_clicked): Deleted.
1756         (on_popup_menu_show): Deleted.
1757         (on_popup_menu_hide): Deleted.
1758         (on_window_geometry_get): Deleted.
1759         (on_window_geometry_set): Deleted.
1760         (on_fullscreen_accept): Deleted.
1761         (on_fullscreen_deny): Deleted.
1762         (on_fullscreen_enter): Deleted.
1763         (on_fullscreen_exit): Deleted.
1764         (on_window_create): Deleted.
1765         (on_window_close): Deleted.
1766         (context_menu_item_selected_cb): Deleted.
1767         (on_context_menu_show): Deleted.
1768         (on_context_menu_hide): Deleted.
1769         (on_auth_cancel): Deleted.
1770         (on_auth_ok): Deleted.
1771         (on_authentication_request): Deleted.
1772         (on_search_text_found): Deleted.
1773         (on_tooltip_text_set): Deleted.
1774         (on_tooltip_text_unset): Deleted.
1775         (on_navigation_policy_decision): Deleted.
1776         (on_home_button_clicked): Deleted.
1777         (on_window_deletion): Deleted.
1778         * Scripts/webkitpy/style/checker.py:
1779
1780 2016-09-16  Dave Hyatt  <hyatt@apple.com>
1781
1782         [CSS Parser] Get CSSPropertyParserHelpers.cpp compiling
1783         https://bugs.webkit.org/show_bug.cgi?id=162078
1784
1785         Reviewed by Dean Jackson.
1786
1787         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1788         (TestWebKitAPI::createTestValue):
1789         Convert to ValueRange.
1790
1791 2016-09-16  Alex Christensen  <achristensen@webkit.org>
1792
1793         Fix API tests after r206036
1794         https://bugs.webkit.org/show_bug.cgi?id=162049
1795
1796         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1797         (TestWebKitAPI::TEST_F):
1798         An emoji had been UTF-8 encoded in the patch that was applied.
1799         The test needed to check the encoding of the emoji, not the UTF-8 encoding of the emoji.
1800         Everything was correct except applying the patch before committing.
1801
1802 2016-09-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1803
1804         RequiresUserActionForPlayback TestWebKitAPI tests are broken after r206033.
1805         https://bugs.webkit.org/show_bug.cgi?id=162080
1806
1807         Reviewed by Jer Noble.
1808
1809         I renamed "playingHandler" to the more generalized "testHandler", but did not realize that the
1810         RequiresUserActionForPlayback tests also used "playingHandler". Renames the handler to account for this change.
1811
1812         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1813         (RequiresUserActionForPlaybackTest::SetUp):
1814
1815 2016-09-16  Alex Christensen  <achristensen@webkit.org>
1816
1817         URLParser should percent encode the user and password according to spec
1818         https://bugs.webkit.org/show_bug.cgi?id=162049
1819
1820         Reviewed by Tim Horton.
1821
1822         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1823         (TestWebKitAPI::TEST_F):
1824
1825 2016-09-16  Alex Christensen  <achristensen@webkit.org>
1826
1827         Fix more edge cases in URLParser
1828         https://bugs.webkit.org/show_bug.cgi?id=162051
1829
1830         Reviewed by Tim Horton.
1831
1832         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1833         (TestWebKitAPI::TEST_F):
1834
1835 2016-09-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1836
1837         Inserting a space after inserting an accepted candidate scrolls the document and causes a flicker
1838         https://bugs.webkit.org/show_bug.cgi?id=162009
1839         <rdar://problem/28086237>
1840
1841         Reviewed by Tim Horton.
1842
1843         Adds 3 new text editing API tests covering candidate insertion, as well as support for testing candidates in
1844         WKWebViews. Refactors common WKWebView helpers across both VideoControlsManager tests and the new
1845         WKWebViewCandidateTests into a new utility class, TestWKWebView in TestWKWebView.mm, which is capable of
1846         simulating mouse and keyboard events as well as waiting for JavaScript messages sent from the web process and
1847         performing actions in response.
1848
1849         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1850         * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
1851         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
1852         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
1853         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1854         (TestWebKitAPI::TEST):
1855         (-[MessageHandler initWithMessage:handler:]): Deleted.
1856         (-[MessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1857         (-[VideoControlsManagerTestWebView mouseDownAtPoint:]): Deleted.
1858         (-[VideoControlsManagerTestWebView performAfterLoading:]): Deleted.
1859         (-[VideoControlsManagerTestWebView callJavascriptFunction:]): Deleted.
1860         (-[VideoControlsManagerTestWebView loadTestPageNamed:]): Deleted.
1861         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]): Deleted.
1862         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Added.
1863         (-[TestCandidate initWithReplacementString:inRange:]):
1864         (-[TestCandidate replacementString]):
1865         (-[TestCandidate resultType]):
1866         (-[TestCandidate range]):
1867         (-[CandidateTestWebView insertCandidatesAndWaitForResponse:range:]):
1868         (-[CandidateTestWebView _didHandleAcceptedCandidate]):
1869         (-[CandidateTestWebView expectCandidateListVisibilityUpdates:whenPerformingActions:]):
1870         (-[CandidateTestWebView _didUpdateCandidateListVisibility:]):
1871         (TEST):
1872         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
1873         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html:
1874         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html:
1875         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html:
1876         * TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Added.
1877         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
1878         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html:
1879         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html:
1880         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
1881         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html:
1882         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html:
1883         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1884         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
1885         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
1886         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
1887         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
1888         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
1889         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
1890         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
1891         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html:
1892         * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html:
1893         * TestWebKitAPI/mac/TestWKWebViewMac.h: Added.
1894         * TestWebKitAPI/mac/TestWKWebViewMac.mm: Added.
1895         (-[TestMessageHandler initWithMessage:handler:]):
1896         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1897         (-[TestWKWebView mouseDownAtPoint:]):
1898         (-[TestWKWebView performAfterReceivingMessage:action:]):
1899         (-[TestWKWebView loadTestPageNamed:]):
1900         (-[TestWKWebView typeCharacter:]):
1901         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1902         (-[TestWKWebView waitForMessage:]):
1903         (-[TestWKWebView performAfterLoading:]):
1904
1905 2016-09-14  Jer Noble  <jer.noble@apple.com>
1906
1907         [media-source] fix imported/w3c/web-platform-tests/media-source/mediasource-duration.html
1908         https://bugs.webkit.org/show_bug.cgi?id=161999
1909
1910         Reviewed by Eric Carlson.
1911
1912         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1913         (TestWebKitAPI::TEST):
1914
1915 2016-09-16  Anders Carlsson  <andersca@apple.com>
1916
1917         Fix isValidEnum to work with older versions of GCC
1918         https://bugs.webkit.org/show_bug.cgi?id=162065
1919
1920         Reviewed by Michael Catanzaro.
1921
1922         Add EnumTraits.cpp to the CMake build.
1923
1924         * TestWebKitAPI/CMakeLists.txt:
1925
1926 2016-09-16  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1927
1928         Unreviewed: Change my primary address for auto-complete in bugzilla.
1929
1930         * Scripts/webkitpy/common/config/contributors.json:
1931
1932 2016-09-15  Alex Christensen  <achristensen@webkit.org>
1933
1934         URLParser: Check for invalid characters in the host
1935         https://bugs.webkit.org/show_bug.cgi?id=162023
1936
1937         Reviewed by Tim Horton.
1938
1939         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1940         (TestWebKitAPI::TEST_F):
1941
1942 2016-09-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1943
1944         [CMake] Refactor GENERATE_BINDINGS
1945         https://bugs.webkit.org/show_bug.cgi?id=161854
1946
1947         Reviewed by Gyuyoung Kim.
1948
1949         * DumpRenderTree/CMakeLists.txt: Changed the arguments of
1950         GENERATE_BINDINGS to new style.
1951         * WebKitTestRunner/CMakeLists.txt: Ditto.
1952
1953 2016-09-15  Ryan Haddad  <ryanhaddad@apple.com>
1954
1955         Disable failing API WebKit2.DataDetectionReferenceDate until it can be investigated.
1956         https://bugs.webkit.org/show_bug.cgi?id=161967
1957
1958         Unreviewed test gardening.
1959
1960         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
1961         (TEST):
1962
1963 2016-09-15  Per Arne Vollan  <pvollan@apple.com>
1964
1965         [Win] run-api-tests is failing.
1966         https://bugs.webkit.org/show_bug.cgi?id=162015
1967
1968         Reviewed by Brent Fulgham.
1969
1970         MSVC is not interpreting C++ string literals with unicode characters correctly when the source file
1971         doesn't contain encoding information. Save the file with utf8 encoding with signature.
1972
1973         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1974
1975 2016-09-15  Jonathan Bedard  <jbedard@apple.com>
1976
1977         Move --no-sample-on-timeout to config.json for each bot
1978         https://bugs.webkit.org/show_bug.cgi?id=161964
1979
1980         Reviewed by Daniel Bates.
1981
1982         Roll out changes from 205573 and move them into config.json.  At this time, only macOS and iOS simulator sample a process on timeout, —no-sample-on-timeout is unneeded for GTK, EFL and Windows.
1983
1984         * BuildSlaveSupport/build.webkit.org-config/config.json: Each bot now independently defines if it will be running sample on timeout.
1985         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1986         (RunWebKitTests.start): Rolled out changes from 205573.
1987
1988 2016-09-15  Csaba Osztrogonác  <ossy@webkit.org>
1989
1990         js/stringimpl-to-jsstring-on-large-strings tests consume huge memory
1991         https://bugs.webkit.org/show_bug.cgi?id=159807
1992
1993         Reviewed by Saam Barati.
1994
1995         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1996         (RunRemoteJavaScriptCoreTests.start): JSCOnly bots are memory limited devices, tests should run with --memory-limited option.
1997         * Scripts/run-javascriptcore-tests:
1998         (runJSCStressTests): Pass through --memory-limited option to run-jsc-stress-tests.
1999         * Scripts/run-jsc-stress-tests: Typo fix.
2000
2001 2016-09-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2002
2003         Media controls behave strangely when changing media sources
2004         https://bugs.webkit.org/show_bug.cgi?id=161914
2005         <rdar://problem/28227805>
2006
2007         Reviewed by Tim Horton.
2008
2009         Adds three new unit tests verifying that media controls remain stable during common `src` change scenarios. Also
2010         tweaks an existing test to account for new `ended` behavior.
2011
2012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2013         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2014         (-[VideoControlsManagerTestWebView waitForMediaControlsToShow]):
2015         (-[VideoControlsManagerTestWebView waitForMediaControlsToHide]):
2016         (TestWebKitAPI::TEST):
2017         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Added.
2018         * TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Added.
2019         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Added.
2020
2021 2016-09-14  Jonathan Bedard  <jbedard@apple.com>
2022
2023         Fix mastercfg_unittest
2024         https://bugs.webkit.org/show_bug.cgi?id=161816
2025
2026         Reviewed by Daniel Bates.
2027
2028         (RunWebKitTests.start):
2029         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Fixed broken unit tests.
2030
2031 2016-09-13  Alexey Proskuryakov  <ap@apple.com>
2032
2033         Landing optimized .png files, forgot to do it initially.
2034
2035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
2036         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
2037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
2038         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
2039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
2040
2041 2016-09-13  Alexey Proskuryakov  <ap@apple.com>
2042
2043         Switch build.webkit.org to iOS 10
2044         https://bugs.webkit.org/show_bug.cgi?id=161930
2045
2046         Reviewed by Daniel Bates.
2047
2048         * BuildSlaveSupport/build.webkit.org-config/config.json:
2049         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2050         (RunWebKitTests.start):
2051         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png: Added.
2053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png: Added.
2054         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png: Added.
2055         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png: Added.
2056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
2057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
2058         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png: Added.
2059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png: Added.
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2063         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2064         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2065         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2066         * Scripts/webkitpy/port/ios.py:
2067         * TestResultServer/static-dashboards/builders.jsonp:
2068
2069 2016-09-13  Tim Horton  <timothy_horton@apple.com>
2070
2071         Provide a mechanism to specify the maximum width of WKThumbnailView snapshots
2072         https://bugs.webkit.org/show_bug.cgi?id=161896
2073         <rdar://problem/28229827>
2074
2075         Reviewed by Simon Fraser.
2076
2077         * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm:
2078         (TestWebKitAPI::TEST):
2079         Add a test for the new property.
2080         Also fix the old new test to run on arbitrary scale displays without failing.
2081
2082 2016-09-12  Brent Fulgham  <bfulgham@apple.com>
2083
2084         [Win][Direct2D] Provide Direct2D-based geometry and transform cast operations
2085         https://bugs.webkit.org/show_bug.cgi?id=161818
2086
2087         Reviewed by Dean Jackson.
2088
2089         Add several new test suites for the various geometric primitives in WebCore.
2090
2091         * TestWebKitAPI/PlatformWin.cmake: Add new files for test cases.
2092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2093         * TestWebKitAPI/Tests/WebCore/AffineTransform.cpp: Added.
2094         * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp: Added.
2095         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp: Added.
2096         * TestWebKitAPI/Tests/WebCore/FloatSize.cpp: Added.
2097         * TestWebKitAPI/Tests/WebCore/IntPoint.cpp: Added.
2098         * TestWebKitAPI/Tests/WebCore/IntRect.cpp: Added.
2099         * TestWebKitAPI/Tests/WebCore/IntSize.cpp: Added.
2100         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Add some new
2101         Windows-focused test cases.
2102
2103 2016-09-12  Chris Dumez  <cdumez@apple.com>
2104
2105         Fix post-landing review comments after r205787
2106         https://bugs.webkit.org/show_bug.cgi?id=161885
2107
2108         Reviewed by Darin Adler.
2109
2110         Leverage new StringBuilder::append(CFStringRef) overload.
2111
2112         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2113         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2114
2115 2016-09-12  Alex Christensen  <achristensen@webkit.org>
2116
2117         URLParser: Correctly ignore spaces before relative URLs with no scheme
2118         https://bugs.webkit.org/show_bug.cgi?id=161889
2119
2120         Reviewed by Daniel Bates.
2121
2122         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2123         (TestWebKitAPI::TEST_F):
2124
2125 2016-09-12  Alex Christensen  <achristensen@webkit.org>
2126
2127         URLParser: Fix relative URLs containing only fragments
2128         https://bugs.webkit.org/show_bug.cgi?id=161882
2129
2130         Reviewed by Brady Eidson.
2131
2132         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2133         (TestWebKitAPI::TEST_F):
2134
2135 2016-09-12  Alex Christensen  <achristensen@webkit.org>
2136
2137         URLParser: Correctly handle relative URLs that are just a scheme and a colon
2138         https://bugs.webkit.org/show_bug.cgi?id=161876
2139
2140         Reviewed by Brady Eidson.
2141
2142         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2143         (TestWebKitAPI::TEST_F):
2144
2145 2016-09-12  DAN SAUNDERS  <dasau@microsoft.com>
2146
2147         AX: WKWebView for macOS does not allow configuration of tabsToLinks
2148         https://bugs.webkit.org/show_bug.cgi?id=161394
2149
2150         Reviewed by Anders Carlsson.
2151
2152         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2153         (TEST):
2154
2155 2016-09-12  Alex Christensen  <achristensen@webkit.org>
2156
2157         Remove trailing control characters and spaces before parsing a URL
2158         https://bugs.webkit.org/show_bug.cgi?id=161870
2159
2160         Reviewed by Tim Horton.
2161
2162         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2163         (TestWebKitAPI::TEST_F):
2164
2165 2016-09-12  Alex Christensen  <achristensen@webkit.org>
2166
2167         Fix more URLParser quirks
2168         https://bugs.webkit.org/show_bug.cgi?id=161834
2169
2170         Reviewed by Brady Eidson.
2171
2172         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2173         (TestWebKitAPI::TEST_F):
2174
2175 2016-09-10  Alex Christensen  <achristensen@webkit.org>
2176
2177         Optimize URLParser performance
2178         https://bugs.webkit.org/show_bug.cgi?id=161837
2179
2180         Reviewed by Brady Eidson.
2181
2182         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2183         (TestWebKitAPI::TEST_F):
2184         Added a test to verify the case insensitivity of the default port checks.
2185
2186 2016-09-10  Chris Dumez  <cdumez@apple.com>
2187
2188         parseHTMLInteger() should take a StringView in parameter
2189         https://bugs.webkit.org/show_bug.cgi?id=161669
2190
2191         Reviewed by Ryosuke Niwa.
2192
2193         Explicitly construct a String from the CFStringRef in order to call
2194         StringBuilder::append(). This is needed now that there is an append()
2195         overload taking an AtomicString in parameter.
2196
2197         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2198         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2199
2200 2016-09-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2201
2202         Apple.com keynote does not display media controls
2203         https://bugs.webkit.org/show_bug.cgi?id=161833
2204         <rdar://problem/28230123>
2205
2206         Reviewed by Tim Horton.
2207
2208         New unit test verifying that wide videos (~2 aspect ratio) still get media controls.
2209
2210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2211         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2212         (TestWebKitAPI::TEST):
2213         * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Added.
2214
2215 2016-09-09  Tim Horton  <timothy_horton@apple.com>
2216
2217         WKThumbnailView should expose a mode where it can be reparented without resnapshotting
2218         https://bugs.webkit.org/show_bug.cgi?id=161828
2219         <rdar://problem/28229756>
2220
2221         Reviewed by Alex Christensen.
2222
2223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2224         * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Added.
2225         (-[SnapshotSizeObserver observeValueForKeyPath:ofObject:change:context:]):
2226         (TestWebKitAPI::didFinishLoadForFrame):
2227         (TestWebKitAPI::setPageLoaderClient):
2228         (TestWebKitAPI::TEST):
2229         Add a test ensuring that this behaves correctly.
2230
2231 2016-09-09  Alex Christensen  <achristensen@webkit.org>
2232
2233         URLParser: Keep track of cannot-be-a-base-url according to spec
2234         https://bugs.webkit.org/show_bug.cgi?id=161830
2235
2236         Reviewed by Tim Horton.
2237
2238         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2239         (TestWebKitAPI::TEST_F):
2240
2241 2016-09-09  Alex Christensen  <achristensen@webkit.org>
2242
2243         Fix API tests after r205774.
2244         https://bugs.webkit.org/show_bug.cgi?id=161820
2245
2246         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2247         (TestWebKitAPI::TEST_F):
2248         I had committed the wrong expected path in one case. The functionality is correct.
2249
2250 2016-09-09  Michael Saboff  <msaboff@apple.com>
2251
2252         Unreviewed, rolling r205759 back in with a fix.
2253
2254         An expectation file, JSTests/ChakraCore/test/Lib/tostring.baseline-jsc,
2255         should be named "toString.baseline-jsc".  For systems with case-insensitive
2256         filesystems, the wrong name isn't an issue.  That rename is part of this
2257         fix.
2258
2259         * Scripts/run-javascriptcore-tests:
2260         (runJSCStressTests):
2261
2262 2016-09-09  Johan K. Jensen  <johan_jensen@apple.com>
2263
2264         Unreviewed. Added myself to the list of committers.
2265
2266         * Scripts/webkitpy/common/config/contributors.json:
2267
2268 2016-09-09  Alex Christensen  <achristensen@webkit.org>
2269
2270         URLParser should convert ASCII hosts to lowercase
2271         https://bugs.webkit.org/show_bug.cgi?id=161820
2272
2273         Reviewed by Geoffrey Garen.
2274
2275         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2276         (TestWebKitAPI::TEST_F):
2277
2278 2016-09-09  Ryan Haddad  <ryanhaddad@apple.com>
2279
2280         Unreviewed, rolling out r205759.
2281
2282         This change broke all JSC tests
2283
2284         Reverted changeset:
2285
2286         "Add ChakraCore tests to run-javascriptcore-tests"
2287         https://bugs.webkit.org/show_bug.cgi?id=161808
2288         http://trac.webkit.org/changeset/205759
2289
2290 2016-09-09  Ryan Haddad  <ryanhaddad@apple.com>
2291
2292         Revert r205770 because Ricky is already a committer.
2293
2294         Unreviewed.
2295
2296         * Scripts/webkitpy/common/config/contributors.json:
2297
2298 2016-09-09  Ricky Mondello  <rmondello@apple.com>
2299
2300         Unreviewed. Added myself to the list of committers.
2301
2302         * Scripts/webkitpy/common/config/contributors.json:
2303
2304 2016-09-09  Alex Christensen  <achristensen@webkit.org>
2305
2306         URLParser: Fix and optimize parsing file URLs ending with a host but no slash
2307         https://bugs.webkit.org/show_bug.cgi?id=161815
2308
2309         Reviewed by Geoffrey Garen.
2310
2311         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2312         (TestWebKitAPI::TEST_F):
2313
2314 2016-09-08  Dean Jackson  <dino@apple.com>
2315
2316         Expose Apple Pencil data to Touch events
2317         https://bugs.webkit.org/show_bug.cgi?id=161783
2318         <rdar://problem/28218898>
2319
2320         Reviewed by Beth Dakin.
2321
2322         The values that IOHID expects are different from their
2323         documentation, and from what UITouch interprets. Tweak
2324         incoming data so it will produce the output we expect.
2325
2326         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2327         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
2328         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
2329
2330 2016-09-09  JF Bastien  <jfbastien@apple.com>
2331
2332         Unreviewed. Added myself to the list of committers.
2333
2334         * Scripts/webkitpy/common/config/contributors.json:
2335
2336 2016-09-09  Michael Saboff  <msaboff@apple.com>
2337
2338         Add ChakraCore tests to run-javascriptcore-tests
2339         https://bugs.webkit.org/show_bug.cgi?id=161808
2340
2341         Reviewed by Saam Barati.
2342
2343         Added ChakraCore tests to the default list of tests to run.
2344
2345         * Scripts/run-javascriptcore-tests:
2346         (runJSCStressTests):
2347
2348 2016-09-09  Alex Christensen  <achristensen@webkit.org>
2349
2350         URLParser: Handle \ in path according to spec
2351         https://bugs.webkit.org/show_bug.cgi?id=161805
2352
2353         Reviewed by Andy Estes.
2354
2355         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2356         (TestWebKitAPI::TEST_F):
2357
2358 2016-09-09  Alex Christensen  <achristensen@webkit.org>
2359
2360         URLParser should parse URLs with non-special schemes
2361         https://bugs.webkit.org/show_bug.cgi?id=161786
2362
2363         Reviewed by Andy Estes.
2364
2365         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2366         (TestWebKitAPI::TEST_F):
2367
2368 2016-09-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2369
2370         [WTF] HashTable's rehash is not compatible to Ref<T> and ASan
2371         https://bugs.webkit.org/show_bug.cgi?id=161763
2372
2373         Reviewed by Mark Lam.
2374
2375         Add tests that inserts many Ref<>s. It incurs HashTable::rehash, and we can ensure
2376         that ASan crash does not occur with this patch.
2377
2378         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2379         (TestWebKitAPI::TEST):
2380         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2381         (TestWebKitAPI::TEST):
2382
2383 2016-09-08  Alex Christensen  <achristensen@webkit.org>
2384
2385         URLParser: Handle \ in paths of special URLs according to spec
2386         https://bugs.webkit.org/show_bug.cgi?id=161781
2387
2388         Reviewed by Tim Horton.
2389
2390         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2391         (TestWebKitAPI::TEST_F):
2392
2393 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
2394
2395         Update the content-animation.plan file to run css-accelerated-animation.html
2396         and pull SVN revision r205680.
2397
2398         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2399
2400 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
2401
2402         Add a content-animation test with accelerated CSS animations
2403         https://bugs.webkit.org/show_bug.cgi?id=161776
2404
2405         Reviewed by Dean Jackson.
2406
2407         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
2408
2409 2016-09-08  Alex Christensen  <achristensen@webkit.org>
2410
2411         URLParser: Parsing empty URLs with a base URL should return the base URL
2412         https://bugs.webkit.org/show_bug.cgi?id=161777
2413
2414         Reviewed by Tim Horton.
2415
2416         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2417         (TestWebKitAPI::TEST_F):
2418
2419 2016-09-08  Alex Christensen  <achristensen@webkit.org>
2420
2421         URLParser failures should preserve the original input string
2422         https://bugs.webkit.org/show_bug.cgi?id=161769
2423
2424         Reviewed by Tim Horton.
2425
2426         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2427         (TestWebKitAPI::TEST_F):
2428         (TestWebKitAPI::shouldFail):
2429
2430 2016-09-08  Alex Christensen  <achristensen@webkit.org>
2431
2432         URLParser should parse URLs with a user but no password
2433         https://bugs.webkit.org/show_bug.cgi?id=161773
2434
2435         Reviewed by Brady Eidson.
2436
2437         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2438         (TestWebKitAPI::TEST_F):
2439
2440 2016-09-08  Alex Christensen  <achristensen@webkit.org>
2441
2442         URLParser should parse ports after IPv4 and IPv6 hosts
2443         https://bugs.webkit.org/show_bug.cgi?id=161731
2444
2445         Reviewed by Brady Eidson.
2446
2447         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2448         (TestWebKitAPI::TEST_F):
2449
2450 2016-09-08  Alex Christensen  <achristensen@webkit.org>
2451
2452         URLParser should correctly handle \ in path
2453         https://bugs.webkit.org/show_bug.cgi?id=161762
2454
2455         Reviewed by Brady Eidson.
2456
2457         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2458         (TestWebKitAPI::TEST_F):
2459
2460 2016-09-08  Alex Christensen  <achristensen@webkit.org>
2461
2462         URLParser should handle URLs with empty authority
2463         https://bugs.webkit.org/show_bug.cgi?id=161711
2464
2465         Reviewed by Brady Eidson.
2466
2467         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2468         (TestWebKitAPI::TEST_F):
2469
2470 2016-09-08  Alex Christensen  <achristensen@webkit.org>
2471
2472         Re-land r205580 after r205649 fixed the test failures
2473         https://bugs.webkit.org/show_bug.cgi?id=161668
2474
2475         Re-landing changesets:
2476
2477         "Punycode encode non-ascii hosts in URLParser"
2478         https://bugs.webkit.org/show_bug.cgi?id=161655
2479         http://trac.webkit.org/changeset/205521
2480
2481         "Fix query-only and fragment-only relative URLs when using
2482         URLParser"
2483         https://bugs.webkit.org/show_bug.cgi?id=161657
2484         http://trac.webkit.org/changeset/205526
2485
2486         "URLParser should parse / as a relative URL"
2487         https://bugs.webkit.org/show_bug.cgi?id=161667
2488         http://trac.webkit.org/changeset/205532
2489
2490 2016-09-08  Dean Jackson  <dino@apple.com>
2491
2492         Expose Apple Pencil input to testing system
2493         https://bugs.webkit.org/show_bug.cgi?id=161670
2494         <rdar://problem/28183327>
2495
2496         I fixed the internal builds, now try to fix the public builds.
2497
2498         * WebKitTestRunner/ios/IOKitSPI.h: Add new enum values.
2499
2500 2016-09-07  Dean Jackson  <dino@apple.com>
2501
2502         Expose Apple Pencil input to testing system
2503         https://bugs.webkit.org/show_bug.cgi?id=161670
2504         <rdar://problem/28183327>
2505
2506         Attempt to fix iOS 9 builds.
2507
2508         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2509         (-[HIDEventGenerator _createIOHIDEventType:]):
2510
2511 2016-09-07  Alex Christensen  <achristensen@webkit.org>
2512
2513         Roll out r205580 and r205582.
2514         https://bugs.webkit.org/show_bug.cgi?id=161668
2515
2516         I need to figure out why this is failing on the bots before landing any more URLParser progress.
2517
2518 2016-09-07  Alex Christensen  <achristensen@webkit.org>
2519
2520         Unreviewed, revert r205533.
2521         https://bugs.webkit.org/show_bug.cgi?id=161668
2522
2523         Re-landing changesets:
2524
2525         "Punycode encode non-ascii hosts in URLParser"
2526         https://bugs.webkit.org/show_bug.cgi?id=161655
2527         http://trac.webkit.org/changeset/205521
2528
2529         "Fix query-only and fragment-only relative URLs when using
2530         URLParser"
2531         https://bugs.webkit.org/show_bug.cgi?id=161657
2532         http://trac.webkit.org/changeset/205526
2533
2534         "URLParser should parse / as a relative URL"
2535         https://bugs.webkit.org/show_bug.cgi?id=161667
2536         http://trac.webkit.org/changeset/205532
2537
2538 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
2539
2540         Enable the <meter> element on iOS
2541         https://bugs.webkit.org/show_bug.cgi?id=161714
2542         rdar://problem/8978410
2543
2544         Reviewed by Tim Horton.
2545
2546         Define ENABLE_METER_ELEMENT unconditionally now.
2547
2548         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2549
2550 2016-09-07  Jonathan Bedard  <jbedard@apple.com>
2551
2552         Run spindumps on timeout on iOS 9 Simulator Release WK2 (Tests)
2553         https://bugs.webkit.org/show_bug.cgi?id=161699
2554
2555         Reviewed by Alexey Proskuryakov.
2556
2557         This change does not have testing associated with it because the testing infrastructure does not exists, we cannot currently mock build-bot variables.
2558
2559         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2560         (RunWebKitTests): Enable sample on timeout for everything.
2561         (RunWebKitTests.start): Disable sample on timeout for everything except iOS 9 WK2 release simulators.
2562
2563 2016-09-06  Dean Jackson  <dino@apple.com>
2564
2565         Expose Apple Pencil input to testing system
2566         https://bugs.webkit.org/show_bug.cgi?id=161670
2567         <rdar://problem/28183327>
2568
2569         Reviewed by Simon Fraser.
2570
2571         Add API to UIScriptController that allows a test to emulate
2572         stylus input, such as from the Apple Pencil.
2573
2574         The code is only implemented for WebKitTestRunner.
2575
2576         There are also four new tests that ensure an Apple Pencil
2577         operates similarly to a regular touch. The main difference
2578         is that you can't have multiple touches when using an Apple Pencil.
2579
2580         * DumpRenderTree/ios/UIScriptControllerIOS.mm: New methods. Empty implementations.
2581         (WTR::UIScriptController::stylusDownAtPoint):
2582         (WTR::UIScriptController::stylusMoveToPoint):
2583         (WTR::UIScriptController::stylusUpAtPoint):
2584         (WTR::UIScriptController::stylusTapAtPoint):
2585         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: New methods.
2586         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Empty implementations.
2587         (WTR::UIScriptController::stylusDownAtPoint):
2588         (WTR::UIScriptController::stylusMoveToPoint):
2589         (WTR::UIScriptController::stylusUpAtPoint):
2590         (WTR::UIScriptController::stylusTapAtPoint):
2591         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2592
2593         * WebKitTestRunner/ios/HIDEventGenerator.h:
2594         * WebKitTestRunner/ios/HIDEventGenerator.mm: New StylusEvent types. Add some properties
2595         to SyntheticEventDigitizerInfo.
2596         (-[HIDEventGenerator _createIOHIDEventType:]): Add support for StylusEvent types.
2597         (-[HIDEventGenerator touchDownAtPoints:touchCount:]): Clear any old stylus info.
2598         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
2599         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
2600         (-[HIDEventGenerator stylusUpAtPoint:]):
2601         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2602         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2603         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2604         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2605         * WebKitTestRunner/ios/IOKitSPI.h: Add new include, and new SPI.
2606         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Calls into the HIDEventGenerator for the new API.
2607         (WTR::UIScriptController::stylusDownAtPoint):
2608         (WTR::UIScriptController::stylusMoveToPoint):
2609         (WTR::UIScriptController::stylusUpAtPoint):
2610         (WTR::UIScriptController::stylusTapAtPoint):
2611
2612 2016-09-07  Daniel Bates  <dabates@apple.com>
2613
2614         Update WebKitSystemInterface
2615
2616         Rubber-stamped by Dean Jackson.
2617
2618         Copy WebKitSystemInterface for iOS 10 to the built products directory.
2619
2620         * Scripts/copy-webkitlibraries-to-product-directory:
2621
2622 2016-09-07  Youenn Fablet  <youenn@apple.com>
2623
2624         [Streams API] Separate compile flag for ReadableStream and WritableStream
2625         https://bugs.webkit.org/show_bug.cgi?id=161044
2626
2627         Reviewed by Alex Christensen.
2628
2629         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
2630
2631         * Scripts/webkitperl/FeatureList.pm:
2632         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2633
2634 2016-09-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2635
2636         [GTK] Move some GObject DOM unstable API to stable
2637         https://bugs.webkit.org/show_bug.cgi?id=161681
2638
2639         Reviewed by Žan Doberšek.
2640
2641         Do not use user message handler unstable API in the tests, since we have stable convenient API for that.
2642
2643         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2644         (testUserContentManagerScriptMessageFromDOMBindings):
2645         (serverCallback): Deleted.
2646         (beforeAll): Deleted.
2647         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2648         (documentLoadedCallback):
2649         (emitURIChanged): Deleted.
2650
2651 2016-09-07  Youenn Fablet  <youenn@apple.com>
2652
2653         Using tests-options.json to compute whether tests are slow
2654         https://bugs.webkit.org/show_bug.cgi?id=161626
2655
2656         Reviewed by Darin Adler.
2657
2658         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Updated first test to use a MockHost.
2659         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2660         (Manager.__init__): Loading tests-options.json
2661         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
2662
2663 2016-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
2664
2665         [EFL] Need the libosmesa to support the software backend drawing.
2666         https://bugs.webkit.org/show_bug.cgi?id=147065
2667
2668         Reviewed by Gyuyoung Kim.
2669
2670         Added the libosmesa to support the software backend drawing.
2671
2672         * efl/install-dependencies:
2673
2674 2016-09-06  Commit Queue  <commit-queue@webkit.org>
2675
2676         Unreviewed, rolling out r205521, r205526, and r205532.
2677         https://bugs.webkit.org/show_bug.cgi?id=161668
2678
2679         broke API tests (Requested by alexchristensen on #webkit).
2680
2681         Reverted changesets:
2682
2683         "Punycode encode non-ascii hosts in URLParser"
2684         https://bugs.webkit.org/show_bug.cgi?id=161655
2685         http://trac.webkit.org/changeset/205521
2686
2687         "Fix query-only and fragment-only relative URLs when using
2688         URLParser"
2689         https://bugs.webkit.org/show_bug.cgi?id=161657
2690         http://trac.webkit.org/changeset/205526
2691
2692         "URLParser should parse / as a relative URL"
2693         https://bugs.webkit.org/show_bug.cgi?id=161667
2694         http://trac.webkit.org/changeset/205532
2695
2696 2016-09-06  Alex Christensen  <achristensen@webkit.org>
2697
2698         URLParser should parse / as a relative URL
2699         https://bugs.webkit.org/show_bug.cgi?id=161667
2700
2701         Reviewed by Tim Horton.
2702
2703         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2704         (TestWebKitAPI::TEST_F):
2705
2706 2016-09-06  Daniel Bates  <dabates@apple.com>
2707
2708         [iOS] DumpRenderTree and WebKitTestRunner fail to build - "Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'"
2709         https://bugs.webkit.org/show_bug.cgi?id=161661
2710
2711         Reviewed by Darin Adler.
2712
2713         Allow ad-hoc code signing when building the dummy DumpRenderTree and WebKitTestRunner
2714         command line tools for simulator with the iOS 10 beta SDK.
2715
2716         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2717         * WebKitTestRunner/Configurations/Base.xcconfig:
2718
2719 2016-09-06  Alex Christensen  <achristensen@webkit.org>
2720
2721         Fix query-only and fragment-only relative URLs when using URLParser
2722         https://bugs.webkit.org/show_bug.cgi?id=161657
2723
2724         Reviewed by Tim Horton.
2725
2726         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2727         (TestWebKitAPI::TEST_F):
2728
2729 2016-09-06  Alex Christensen  <achristensen@webkit.org>
2730
2731         Punycode encode non-ascii hosts in URLParser
2732         https://bugs.webkit.org/show_bug.cgi?id=161655
2733
2734         Reviewed by Tim Horton.
2735
2736         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2737         (TestWebKitAPI::wideString):
2738         (TestWebKitAPI::TEST_F):
2739
2740 2016-09-05  Alex Christensen  <achristensen@webkit.org>
2741
2742         Implement relative file urls and begin implementing character encoding in URLParser
2743         https://bugs.webkit.org/show_bug.cgi?id=161618
2744
2745         Reviewed by Tim Horton.
2746
2747         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2748         (TestWebKitAPI::TEST_F):
2749
2750 2016-09-06  Commit Queue  <commit-queue@webkit.org>
2751
2752         Unreviewed, rolling out r205480.
2753         https://bugs.webkit.org/show_bug.cgi?id=161630
2754
2755         tests-options.json is not known from knockout filesystem
2756         (Requested by youenn on #webkit).
2757
2758         Reverted changeset:
2759
2760         "Using tests-options.json to compute whether tests are slow"
2761         https://bugs.webkit.org/show_bug.cgi?id=161626
2762         http://trac.webkit.org/changeset/205480
2763
2764 2016-09-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2765
2766         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
2767         https://bugs.webkit.org/show_bug.cgi?id=161606
2768
2769         Reviewed by Darin Adler.
2770
2771         Avoid extra arguments in call to sprintf, hopefully without introducing new warnings this
2772         time.
2773
2774         * Scripts/prepare-ChangeLog:
2775         (statusDescription):
2776
2777 2016-09-06  Youenn Fablet  <youenn@apple.com>
2778
2779         Using tests-options.json to compute whether tests are slow
2780         https://bugs.webkit.org/show_bug.cgi?id=161626
2781
2782         Reviewed by Darin Adler.
2783
2784         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2785         (Manager.__init__): Loading tests-options.json
2786         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
2787
2788 2016-09-06  Commit Queue  <commit-queue@webkit.org>
2789
2790         Unreviewed, rolling out r205461.
2791         https://bugs.webkit.org/show_bug.cgi?id=161628
2792
2793         Introduced "Use of uninitialized value $original in sprintf"
2794         warning (Requested by mcatanzaro on #webkit).
2795
2796         Reverted changeset:
2797
2798         ""Redundant argument in sprintf" warning spam from prepare-
2799         ChangeLog"
2800         https://bugs.webkit.org/show_bug.cgi?id=161606
2801         http://trac.webkit.org/changeset/205461
2802
2803 2016-09-06  Youenn Fablet  <youenn@apple.com>
2804
2805         W3C test importer should be able to identify slow test
2806         https://bugs.webkit.org/show_bug.cgi?id=161601
2807
2808         Reviewed by Darin Adler.
2809
2810         Test parser is now identifying slow tests based on "meta element name=timeout content=long" elements.
2811         Test importer is updating test-options.json file according that information.
2812
2813         In case of clean import, the test-options.json is cleaned from 'slow' options for all W3C tests.
2814
2815         * Scripts/webkitpy/w3c/test_importer.py:
2816         (TestImporter.__init__):
2817         (TestImporter.find_importable_tests):
2818         (TestImporter.import_tests):
2819         (TestImporter.update_test_options):
2820         (TestImporter):
2821         (TestImporter.remove_slow_from_w3c_test_options):
2822         * Scripts/webkitpy/w3c/test_parser.py:
2823         (TestParser.analyze_test):
2824         (TestParser.is_slow_test):
2825         (TestParser.potential_ref_filename):
2826
2827 2016-09-06  Per Arne Vollan  <pvollan@apple.com>
2828
2829         [Win] Crash logs have incorrect symbols.
2830         https://bugs.webkit.org/show_bug.cgi?id=161603
2831
2832         Reviewed by Darin Adler.
2833
2834         Add build path to _NT_SYMBOL_PATH environment variable.
2835
2836         * Scripts/webkitpy/port/win.py:
2837         (WinPort.setup_crash_log_saving):
2838
2839 2016-08-31  Filip Pizlo  <fpizlo@apple.com>
2840
2841         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
2842         https://bugs.webkit.org/show_bug.cgi?id=160125
2843
2844         Reviewed by Geoffrey Garen and Keith Miller.
2845
2846         * DumpRenderTree/TestRunner.cpp:
2847         * DumpRenderTree/mac/DumpRenderTree.mm:
2848         (DumpRenderTreeMain):
2849         * Scripts/run-jsc-stress-tests:
2850         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2851         (TestWebKitAPI::TEST):
2852
2853 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2854
2855         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
2856         https://bugs.webkit.org/show_bug.cgi?id=161606
2857
2858         Reviewed by Darin Adler.
2859
2860         Avoid extra arguments in call to sprintf.
2861
2862         * Scripts/prepare-ChangeLog:
2863         (statusDescription):
2864
2865 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2866
2867         [GTK] Skip several failing API tests
2868
2869         Unfortunately we don't have any form of test expectations for API tests, so we'll just skip
2870         them after bugs are filed.
2871
2872         * Scripts/run-gtk-tests:
2873         (TestRunner):
2874
2875 2016-09-05  Youenn Fablet  <youenn@apple.com>
2876
2877         Fix W3C test importer unit tests after r205447
2878         https://bugs.webkit.org/show_bug.cgi?id=161604
2879
2880         Unreviewed.
2881
2882         * Scripts/webkitpy/w3c/test_importer.py:
2883         (TestImporter.__init__): Skip cleaning test_resource_files files if resource-files.json cannot be read.
2884
2885 2016-09-05  Philippe Normand  <pnormand@igalia.com>
2886
2887         WebRTC: Several media stream tests crashing
2888         https://bugs.webkit.org/show_bug.cgi?id=161582
2889
2890         Reviewed by Alejandro G. Castro.
2891
2892         * gtk/jhbuild.modules: Bump to latest OpenWebRTC master fixing the crash on missing
2893         glvideoflip GStreamer element.
2894
2895 2016-09-05  Youenn Fablet  <youenn@apple.com>
2896
2897         W3C test importer should generate the list of resource files
2898         https://bugs.webkit.org/show_bug.cgi?id=161578
2899
2900         Reviewed by Ryosuke Niwa.
2901
2902         Generating LayoutTests/imported/w3c/resources/resource-files.json when importing tests.
2903
2904         * Scripts/webkitpy/w3c/test_importer.py:
2905         (TestImporter.__init__): Reading test resource files configuration file.
2906         (TestImporter.find_importable_tests):
2907         (TestImporter.import_tests): Update the test resource files based on test parsed files.
2908         (TestImporter):
2909         (TestImporter._already_identified_as_resource_file): Helper routine to know whether a file is already set as a resource file.
2910         (TestImporter._is_in_resources_directory: Helper routine to know whether a file is in a resources directory.
2911
2912 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2913
2914         Media controls behave strangely when videos mute from within a playing handler
2915         https://bugs.webkit.org/show_bug.cgi?id=161559
2916         <rdar://problem/28018438>
2917
2918         Reviewed by Darin Adler.
2919
2920         Accounts for changes when determining whether or not to show media controls for autoplaying videos that have not
2921         begun playing yet. Rather than check for a controlled media element upon page load, we force tests to wait until
2922         all autoplaying videos have actually begun playing. This extends to tests that involve interaction, such as
2923         clicking or scrolling.
2924
2925         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2926         (-[VideoControlsManagerTestWebView callJavascriptFunction:]):
2927         (-[VideoControlsManagerTestWebView expectControlsManager:afterReceivingMessage:]):
2928         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
2929         (-[VideoControlsManagerTestWebView waitForPageToLoadWithAutoplayingVideos:]):
2930         (TestWebKitAPI::TEST):
2931         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): Deleted.
2932         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
2933         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
2934         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
2935         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
2936         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
2937         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
2938         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
2939         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
2940         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
2941
2942 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2943
2944         Refactor the heuristic for showing media controls to take all media sessions into account
2945         https://bugs.webkit.org/show_bug.cgi?id=161503
2946         <rdar://problem/28033783>
2947
2948         Reviewed by Darin Adler.
2949
2950         Adds new unit tests verifying the behavior of media playback controls when scrolling another video into view.
2951         Please see the WebCore ChangeLog for more details about this change. Also refactors existing
2952         VideoControlsManager tests by folding duplicated setup and testing logic into helper methods to make the unit
2953         tests more readable.
2954
2955         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2956         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2957         (-[MessageHandler initWithMessage:handler:]):
2958         (-[MessageHandler userContentController:didReceiveScriptMessage:]):
2959         (-[VideoControlsManagerTestWebView performAfterLoading:]):
2960         (-[VideoControlsManagerTestWebView loadTestPageNamed:]):
2961         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]):
2962         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
2963         (-[VideoControlsManagerTestWebView controlledElementID]):
2964         (-[VideoControlsManagerTestWebView _handleControlledElementIDResponse:]):
2965         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2966         (TestWebKitAPI::TEST):
2967         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): Deleted.
2968         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2969         (-[OnLoadMessageHandler initWithWKWebView:handler:]): Deleted.
2970         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2971         (-[WKWebView performAfterLoading:]): Deleted.
2972         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Added.
2973         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Added.
2974         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Added.
2975         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Added.
2976         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Added.
2977         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Added.
2978
2979 2016-09-03  Youenn Fablet  <youenn@apple.com>
2980
2981         run-webkit-tests should detect w3c test resource files
2982         https://bugs.webkit.org/show_bug.cgi?id=161307
2983
2984         Reviewed by Ryosuke Niwa.
2985
2986         * Scripts/webkitpy/port/base.py:
2987         (Port.__init__): Adding self._w3c_resource_files to store the list of resource files.
2988         (Port.potential_test_names_from_expected_file):
2989         (Port._real_tests):
2990         (Port.is_w3c_resource_file): Computing whether a file is a resource file based on imported/w3c/resources/resource-files.json.
2991         (Port._is_test_file): Updated to call Port.is_w3c_resource_file. _is_test_file is no longer static.
2992         (Port): Deleted.
2993         * Scripts/webkitpy/port/base_unittest.py:
2994         (PortTest.test_additional_platform_directory):
2995         (PortTest.test_find_no_paths_specified):
2996         (PortTest.test_is_test_file): Updated to use non-static version of _is_test_file.
2997         (PortTest.test_is_w3c_resource_file): Adding tests.
2998
2999 2016-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3000
3001         Unreviewed. Fix archive-built-product step in GTK+ bots after r205280.
3002
3003         * BuildSlaveSupport/built-product-archive:
3004         (archiveBuiltProduct): Do not copy to the archive the files needed to run GObject DOM bindings API breaks tests
3005         that no longer exist.
3006
3007 2016-09-02  Alex Christensen  <achristensen@webkit.org>
3008
3009         URLParser should parse file URLs
3010         https://bugs.webkit.org/show_bug.cgi?id=161556
3011
3012         Reviewed by Tim Horton.
3013
3014         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3015         (TestWebKitAPI::TEST_F):
3016         (TestWebKitAPI::checkURLDifferences):
3017
3018 2016-09-01  Michael Saboff  <msaboff@apple.com>
3019
3020         Import Chakra tests to JSC
3021         https://bugs.webkit.org/show_bug.cgi?id=154697
3022
3023         Reviewed by Saam Barati.
3024
3025         Added "runChakra" and "chakraPassFailErrorHandler" to support the running of
3026         Chakra tests.
3027
3028         * Scripts/run-jsc-stress-tests:
3029
3030 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
3031
3032         WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode
3033         https://bugs.webkit.org/show_bug.cgi?id=42547
3034  
3035         Reviewed by Darin Adler.
3036
3037         Added JavaScript bindings and C++ implementation of setUseDashboardCompatibilityMode for the WebKit2 sTestRunner.
3038         Note: this bug mistakenly called this function setDashboardCompatibilityMode, it is actually setUseDashboardCompatibilityMode.
3039
3040         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added dashboard compatiblity mode setter.
3041         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3042         (WTR::InjectedBundle::beginTesting): Reset dashboard compatibility mode.
3043         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3044         (WTR::TestRunner::setJavaScriptCanAccessClipboard): Code style changes.
3045         (WTR::TestRunner::setPrivateBrowsingEnabled): Code style changes.
3046         (WTR::TestRunner::setUseDashboardCompatibilityMode): Added dashboard compatiblity mode setter.
3047         (WTR::TestRunner::setPopupBlockingEnabled): Code style changes.
3048         (WTR::TestRunner::setAuthorAndUserStylesEnabled): Code style changes.
3049         (WTR::TestRunner::addOriginAccessWhitelistEntry): Code style changes.
3050         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added dashboard compatiblity mode setter.
3051
3052 2016-09-02  Jer Noble  <jer.noble@apple.com>
3053
3054         Unreviewed build fix: restore storyboard files to Xcode 7-compatability.
3055
3056         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
3057         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard:
3058
3059 2016-09-02  Tim Horton  <timothy_horton@apple.com>
3060
3061         REGRESSION (r205329): Two API tests time out on iOS Simulator
3062         https://bugs.webkit.org/show_bug.cgi?id=161542
3063
3064         Reviewed by Brady Eidson.
3065
3066         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3067         (createAnimatedResizeWebView):
3068         (createFirstVisuallyNonEmptyWatchingNavigationDelegate):
3069         (TEST):
3070         (animatedResizeWebView): Deleted.
3071         The navigation delegate was being stored in a local and went out of scope
3072         before the test was over. Keep it around, instead.
3073
3074 2016-08-31  Jer Noble  <jer.noble@apple.com>
3075
3076         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
3077         https://bugs.webkit.org/show_bug.cgi?id=161462
3078
3079         Reviewed by Eric Carlson.
3080
3081         XCTest targets need to be in the same project as the application which they're testing. To facilitate
3082         having external projects with XCTest targets, move the application's implementation into a framework
3083         that can be included with a bare-bones application shell for testing.
3084
3085         Simultaneously, add the ability to load files from within the new framework's bundle by using a
3086         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
3087         an external server for testing.
3088
3089         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3090         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
3091         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
3092         * MobileMiniBrowser/MobileMiniBrowser/main.m:
3093         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
3094         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
3095         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
3096             controller from the framework's bundle.
3097         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
3098         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
3099         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
3100         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
3101         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
3102         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
3103         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
3104         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
3105         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
3106         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
3107         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
3108             pointing to the framework's resources directory.
3109         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
3110         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
3111         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
3112
3113 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
3114
3115         Fix --no-sample-on-timeout command line argument
3116         https://bugs.webkit.org/show_bug.cgi?id=161507
3117
3118         Reviewed by Alexey Proskuryakov.
3119
3120         This patch fixes the —no-sample-on-timeout flag and correctly names spindumps as spindump.txt.
3121
3122         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3123         (parse_args): Fixed —-no-sample-on-timeout.
3124         * Scripts/webkitpy/port/apple.py:
3125         (ApplePort.sample_process): Use correct file name.
3126         (ApplePort.spindump_file_path): Spindump and sample file names are different.
3127         * Scripts/webkitpy/port/driver.py:
3128         (Driver._check_for_driver_timeout): Check “sample_on_timeout” flag.
3129         * Scripts/webkitpy/port/mac_unittest.py:
3130         (MacTest.test_spindump): Modified for correct filename.
3131
3132 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
3133
3134         Unreviewed: moved myself to the reviewers list.
3135
3136         * Scripts/webkitpy/common/config/contributors.json:
3137
3138 2016-09-02  Tomas Popela  <tpopela@redhat.com>
3139
3140         [GTK] Fix compiler warning in MiniBrowser
3141         https://bugs.webkit.org/show_bug.cgi?id=161529
3142
3143         We were missing a return statement in decidePermissionRequest() and
3144         also there was unused variable in browserWindowConstructed().
3145
3146         Reviewed by Carlos Garcia Campos.
3147
3148         * MiniBrowser/gtk/BrowserTab.c:
3149         (decidePermissionRequest):
3150         * MiniBrowser/gtk/BrowserWindow.c:
3151         (browserWindowConstructed):
3152
3153 2016-09-01  Dan Bernstein  <mitz@apple.com>
3154
3155         Build fix.
3156
3157         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3158
3159 2016-09-01  Tim Horton  <timothy_horton@apple.com>
3160
3161         Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
3162         https://bugs.webkit.org/show_bug.cgi?id=161413
3163
3164         Reviewed by Simon Fraser.
3165
3166         Add TestNavigationDelegate, which provides block properties to make
3167         writing tests feel a little more natural (the callbacks can be inline),
3168         and also add WKWebView _test_waitForDidFinishNavigation, so that many
3169         tests don't even need to manually allocate a navigation delegate at all.
3170
3171         Adopt in some of the simpler tests; there are a few navigation delegates
3172         left behind, which we can move to the new model in the future.
3173
3174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3175         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
3176         (TEST):
3177         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted.
3178         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm:
3179         (TEST):
3180         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted.
3181         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3182         (animatedResizeWebView):
3183         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted.
3184         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3185         (-[AutoLayoutWKWebView initWithFrame:configuration:]):
3186         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
3187         (TEST):
3188         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted.
3189         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
3190         (TEST):
3191         (-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted.
3192         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
3193         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
3194         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
3195         (TEST_F):
3196         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted.
3197         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3198         (expectLinkCount):
3199         (TEST):
3200         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted.
3201         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
3202         (TEST):
3203         (-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted.
3204         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
3205         (TEST):
3206         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
3207         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
3208         (TEST):
3209         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted.
3210         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
3211         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted.
3212         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:
3213         (TEST):
3214         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted.
3215         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted.
3216         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3217         (RequiresUserActionForPlaybackTest::createWebView):
3218         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
3219         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
3220         (RequiresUserActionForPlaybackTest::testAudioOnly):
3221         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted.
3222         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:
3223         (TEST):
3224         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted.
3225         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3226         (TEST):
3227         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
3228         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
3229         (TEST):
3230         (-[SimpleDelegate webView:didFinishNavigation:]): Deleted.
3231         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm:
3232         (TEST):
3233         (-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
3234         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3235         (TEST):
3236         (-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted.
3237         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
3238         (TEST):
3239         (-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted.
3240         * TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added.
3241         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added.
3242         (-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3243         (-[TestNavigationDelegate webView:didFinishNavigation:]):
3244         (-[TestNavigationDelegate _webView:renderingProgressDidChange:]):
3245         (-[TestNavigationDelegate waitForDidFinishNavigation]):
3246         (-[WKWebView _test_waitForDidFinishNavigation]):
3247
3248 2016-09-01  Ricky Mondello  <rmondello@apple.com>
3249
3250         YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
3251         https://bugs.webkit.org/show_bug.cgi?id=161478
3252         <rdar://problem/28050847>
3253
3254         Reviewed by Eric Carlson.
3255
3256         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
3257         (TestWebKitAPI::TEST_F): Update expected results.
3258
3259 2016-09-01  Anders Carlsson  <andersca@apple.com>
3260
3261         add BlockPtr::fromCallable
3262         https://bugs.webkit.org/show_bug.cgi?id=161504
3263
3264         Reviewed by Tim Horton.
3265
3266         Add a test.
3267
3268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3269         * TestWebKitAPI/Tests/WTF/BlockPtr.mm: Added.
3270         (TestWebKitAPI::TEST):
3271
3272 2016-09-01  Alex Christensen  <achristensen@webkit.org>
3273
3274         URLParser should handle . and .. in URL paths
3275         https://bugs.webkit.org/show_bug.cgi?id=161443
3276
3277         Reviewed by Brady Eidson.
3278
3279         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3280         (TestWebKitAPI::eq):
3281         (TestWebKitAPI::TEST_F):
3282
3283 2016-09-01  Commit Queue  <commit-queue@webkit.org>
3284
3285         Unreviewed, rolling out r205295 and r205303.
3286         https://bugs.webkit.org/show_bug.cgi?id=161505
3287
3288         Broke the iOS build (Requested by ryanhaddad on #webkit).
3289
3290         Reverted changesets:
3291
3292         "Refactor MobileMiniBrowser into an application framework to
3293         allow external XCTesting"
3294         https://bugs.webkit.org/show_bug.cgi?id=161462
3295         http://trac.webkit.org/changeset/205295
3296
3297         "Unreviewed build-fix; don't specify an explicit deployment
3298         target."
3299         http://trac.webkit.org/changeset/205303
3300
3301 2016-09-01  Ricky Mondello  <rmondello@apple.com>
3302
3303         YouTube Flash plug-in replacement facility should more gracefully handle malformed queries
3304         https://bugs.webkit.org/show_bug.cgi?id=161476
3305         <rdar://problem/28050847>
3306
3307         Reviewed by Eric Carlson.
3308
3309         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
3310         (TestWebKitAPI::TEST_F): New tests. The first two and second-to-last test cases cover the "malformed" query
3311             logic. A few other tests are added, too.
3312
3313 2016-09-01  Jer Noble  <jer.noble@apple.com>
3314
3315         Unreviewed build-fix; don't specify an explicit deployment target.
3316
3317         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3318
3319 2016-08-31  Jer Noble  <jer.noble@apple.com>
3320
3321         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
3322         https://bugs.webkit.org/show_bug.cgi?id=161462
3323
3324         Reviewed by Eric Carlson.
3325
3326         XCTest targets need to be in the same project as the application which they're testing. To facilitate
3327         having external projects with XCTest targets, move the application's implementation into a framework
3328         that can be included with a bare-bones application shell for testing.
3329
3330         Simultaneously, add the ability to load files from within the new framework's bundle by using a
3331         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
3332         an external server for testing.
3333
3334         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3335         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
3336         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
3337         * MobileMiniBrowser/MobileMiniBrowser/main.m:
3338         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
3339         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
3340         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
3341             controller from the framework's bundle.
3342         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
3343         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
3344         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
3345         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
3346         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
3347         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
3348         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
3349         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
3350         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
3351         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
3352         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
3353             pointing to the framework's resources directory.
3354         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
3355         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
3356         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
3357
3358 2016-09-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3359
3360         Unreviewed. Fix webkitpy unit tests after r205280.
3361
3362         * Scripts/webkitpy/style/checker_unittest.py:
3363         (GlobalVariablesTest.test_path_rules_specifier):
3364
3365 2016-08-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3366
3367         [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them
3368         https://bugs.webkit.org/show_bug.cgi?id=161438
3369
3370         Reviewed by Michael Catanzaro.
3371
3372         Remove scripts related to the GObject DOM bindings auto-generation.
3373
3374         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3375         (RunGtkAPITests.getText2):
3376         (TestFactory.__init__):
3377         (RunWebKit1Tests): Deleted.
3378         (RunWebKit1Tests.start): Deleted.
3379         (RunWebKit1LeakTests): Deleted.
3380         (RunWebKit1LeakTests.start): Deleted.
3381         (RunAndUploadPerfTests): Deleted.
3382         (RunAndUploadPerfTests.start): Deleted.
3383         (BuildAndRemoteJSCTestsFactory.__init__): Deleted.
3384         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3385         (BuildStepsTest.test_unnecessary_expected_results):
3386         (RunAndUploadPerfTestsTest): Deleted.
3387         (RunAndUploadPerfTestsTest.assertResults): Deleted.
3388         (RunAndUploadPerfTestsTest.test_success): Deleted.
3389         (RunAndUploadPerfTestsTest.test_tests_failed): Deleted.
3390         (RunAndUploadPerfTestsTest.test_build_bad_build): Deleted.
3391         (RunAndUploadPerfTestsTest.test_build_bad_source_json): Deleted.
3392         (RunAndUploadPerfTestsTest.test_build_bad_marge): Deleted.
3393         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading): Deleted.
3394         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
3395         (RunAndUploadPerfTestsTest.test_buildbot_timeout): Deleted.
3396         (RunBenchmarkTest): Deleted.
3397         (RunBenchmarkTest.assertResults): Deleted.
3398         (RunBenchmarkTest.test_success): Deleted.
3399         * Scripts/run-bindings-tests:
3400         (main):
3401         * Scripts/webkitpy/style/checker.py:
3402         * gtk/check-for-webkitdom-api-breaks: Removed.
3403         * gtk/generate-gtkdoc:
3404         * gtk/webkitdom.py: Removed.
3405
3406 2016-08-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3407
3408         [EFL] Small clean up in MiniBrowser
3409         https://bugs.webkit.org/show_bug.cgi?id=161428
3410
3411         Reviewed by Yusuke Suzuki.
3412
3413         This patch resizes MiniBrowser, add *char* constants for scheme,
3414         does line breaking, and remove unnecessary spaces.
3415
3416         * MiniBrowser/efl/main.c:
3417         (on_mouse_wheel):
3418         (history_list_hide):
3419         (script_execute_callback):
3420         (on_key_down):
3421         (on_url_changed):
3422         (on_error):
3423         (on_color_picker_request):
3424         (url_from_user_input):
3425         (url_load_from_user_input):
3426         (on_back_button_clicked):
3427         (on_search_case_option_changed):
3428         (on_search_word_start_option_changed):
3429         (on_list_item_select):
3430         (navigation_button_longpress_process):
3431         (on_navigation_policy_decision):
3432         (window_create):
3433         (parse_cookies_policy):
3434
3435 2016-08-31  Alex Christensen  <achristensen@webkit.org>
3436
3437         Implement IPv6 parsing in URLParser
3438         https://bugs.webkit.org/show_bug.cgi?id=161390
3439
3440         Reviewed by Darin Adler.
3441
3442         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3443         (TestWebKitAPI::TEST_F):
3444         (TestWebKitAPI::checkURLDifferences):
3445
3446 2016-08-31  Brady Eidson  <beidson@apple.com>
3447
3448         WK2 Gamepad provider on iOS.
3449         https://bugs.webkit.org/show_bug.cgi?id=161412
3450
3451         Reviewed by Tim Horton.
3452
3453         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3454
3455 2016-08-30  Ricky Mondello  <rmondello@apple.com>
3456
3457         YouTubePluginReplacementTest's URL transformation logic should have tests
3458         https://bugs.webkit.org/show_bug.cgi?id=161406
3459         <rdar://problem/28050847>
3460
3461         Reviewed by Eric Carlson.
3462
3463         Add some very basic tests. Future patches should expand on these to find and fix bugs.
3464
3465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add YouTubePluginReplacement.cpp.
3466         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Added.
3467         (TestWebKitAPI::test): Added.
3468         (TestWebKitAPI::TEST_F): Added.
3469
3470 2016-08-30  Brady Eidson  <beidson@apple.com>
3471
3472         GameController.framework backend for gamepad API.
3473         https://bugs.webkit.org/show_bug.cgi?id=161086
3474
3475         Reviewed by Alex Christensen.
3476
3477         * MiniBrowser/mac/AppDelegate.m:
3478         (-[BrowserAppDelegate awakeFromNib]):
3479
3480         * MiniBrowser/mac/SettingsController.h:
3481         * MiniBrowser/mac/SettingsController.m:
3482         (-[SettingsController _populateMenu]):
3483         (-[SettingsController validateMenuItem:]):
3484         (-[SettingsController usesGameControllerFramework]):
3485         (-[SettingsController toggleUsesGameControllerFramework:]):
3486
3487 2016-08-30  Brent Fulgham  <bfulgham@apple.com>
3488
3489         Use of uninitialised memory in TransformationMatrx::blend4()
3490         https://bugs.webkit.org/show_bug.cgi?id=134621
3491         <rdar://problem/27337539>
3492
3493         Reviewed by Dean Jackson.
3494
3495         Change is based on the Blink change (patch by <alancutter@chromium.org>):
3496         <https://src.chromium.org/viewvc/blink?revision=177453&view=revision>
3497
3498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3499         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Added.
3500         (TestWebKitAPI::TEST):
3501
3502 2016-08-30  Alex Christensen  <achristensen@webkit.org>
3503
3504         URLParser should handle relative URLs that start with //
3505         https://bugs.webkit.org/show_bug.cgi?id=161364
3506
3507         Reviewed by Darin Adler.
3508
3509         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3510         (TestWebKitAPI::checkRelativeURL):
3511         (TestWebKitAPI::TEST_F):
3512
3513 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
3514
3515         EWS patch status page should indicate bot corresponding to each status message
3516         https://bugs.webkit.org/show_bug.cgi?id=161280
3517
3518         Reviewed by Alexey Proskuryakov.
3519
3520         * QueueStatusServer/templates/patch.html: Formatting changes.
3521
3522 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
3523
3524         EWS should indicate which bot processed the patch
3525         https://bugs.webkit.org/show_bug.cgi?id=161222
3526
3527         Reviewed by Alexey Proskuryakov.
3528
3529         * QueueStatusServer/handlers/statusbubble.py:
3530         (StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
3531         bot ids are now displayed in patch status page.
3532
3533 2016-08-29  Alex Christensen  <achristensen@webkit.org>
3534
3535         URLParser should parse about:blank
3536         https://bugs.webkit.org/show_bug.cgi?id=161324
3537
3538         Reviewed by Brady Eidson.
3539
3540         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3541         (TestWebKitAPI::TEST_F):
3542
3543 2016-08-29  JF Bastien  <jfbastien@apple.com>
3544
3545         Bug 161165 - check-webkit-style doesn't understand macros containing `else` or labels
3546         https://bugs.webkit.org/show_bug.cgi?id=161165
3547
3548         Reviewed by Geoffrey Garen.
3549
3550         Fix handling of `else` in a macro. Don't handle labels in a macro:
3551         the checker is already pretty messy in that area and it should be
3552         a rare thing.
3553
3554         * Scripts/webkitpy/style/checkers/cpp.py:
3555         (check_braces):
3556         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3557         (CppStyleTest.test_else_clause_not_on_same_line_as_else):
3558
3559 2016-08-29  Alex Christensen  <achristensen@webkit.org>
3560
3561         API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
3562         https://bugs.webkit.org/show_bug.cgi?id=161317
3563
3564         Reviewed by Brady Eidson.
3565
3566         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3567         (TestWebKitAPI::TEST_F):
3568
3569 2016-08-29  Jer Noble  <jer.noble@apple.com>
3570
3571         Unreviewed gardening; only build MiniBrowser against iOS SDK targets.
3572
3573         * Makefile:
3574
3575 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
3576
3577         Sample Process on notifyDone timed out
3578         https://bugs.webkit.org/show_bug.cgi?id=161063
3579
3580         Reviewed by Darin Adler.
3581
3582         * Scripts/webkitpy/port/driver.py:
3583         (Driver._check_for_driver_timeout): 
3584         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Call sample_process during notifyDone timeouts.
3585         (WTR::TestRunner::waitToDumpWatchdogTimerFired):
3586         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Log pid and name for testing harness.
3587
3588 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
3589
3590         Check-webkit-style does not work with Objective-C blocks
3591         https://bugs.webkit.org/show_bug.cgi?id=161247
3592
3593         Reviewed by Darin Adler.
3594
3595         * Scripts/webkitpy/style/checkers/cpp.py:
3596         (regex_for_lambda_functions): Changed to regex_for_lambdas_and_blocks.
3597         (regex_for_lambdas_and_blocks): Added check for Objective-C blocks.
3598         (check_spacing_for_function_call): Pass file state for lambda check.
3599         (check_spacing): Pass file state for lambda check.
3600         (check_braces): Pass file state for lambda check.
3601         (check_style): Pass file state for lambda check.
3602         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3603         (CppStyleTest.test_cpp_lambda_functions): Changed from ‘test_lambda_functions’.
3604         (CppStyleTest.test_objective_c_block): Tests Objective-C blocks.
3605         (CppStyleTest.test_lambda_functions): Changed to ‘test_cpp_lambda_functions’.
3606
3607 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
3608
3609         EWS patch status page should indicate bot corresponding to each status message
3610         https://bugs.webkit.org/show_bug.cgi?id=161280
3611
3612         Reviewed by Alexey Proskuryakov.
3613
3614         * QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
3615         for each status message.
3616         * QueueStatusServer/stylesheets/common.css:
3617         (.status-bot): Added corresponding stylesheet class.
3618
3619 2016-08-29  Per Arne Vollan  <pvollan@apple.com>
3620
3621         Attempt to fix Windows build after r205090.
3622
3623         Unreviewed build fix.
3624
3625         * DumpRenderTree/win/DRTDataObject.cpp:
3626         (cfFileNameWFormat):
3627         (cfUrlWFormat):
3628
3629 2016-08-27  Alex Christensen  <achristensen@webkit.org>
3630
3631         URLParser should parse relative URLs
3632         https://bugs.webkit.org/show_bug.cgi?id=161282
3633
3634         Reviewed by Darin Adler.
3635
3636         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3637         (TestWebKitAPI::TEST):
3638         Added some tests for the new operator=.
3639         Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
3640         Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.
3641         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3642         (TestWebKitAPI::checkURL):
3643         (TestWebKitAPI::TEST_F):
3644         (TestWebKitAPI::checkRelativeURL):
3645         (TestWebKitAPI::checkURLDifferences):
3646         (TestWebKitAPI::shouldFail):
3647         Add some relative URL tests.
3648
3649 2016-08-27  Jonathan Bedard  <jbedard@apple.com>
3650
3651         WTR needs an implementation of setAutomaticLinkDetectionEnabled
3652         https://bugs.webkit.org/show_bug.cgi?id=87162
3653
3654         Reviewed by Darin Adler.
3655
3656         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
3657         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3658         (WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.
3659         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3660         (WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
3661         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.
3662
3663 2016-08-27  Joseph Pecoraro  <pecoraro@apple.com>
3664
3665         Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
3666         https://bugs.webkit.org/show_bug.cgi?id=28685
3667         <rdar://problem/16460975>
3668
3669         Reviewed by Darin Adler.
3670
3671         * Scripts/extract-localizable-js-strings:
3672         * Scripts/update-webkit-localizable-strings:
3673         WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
3674         this script still use UTF-16, so keep that the default.
3675
3676 2016-08-27  Alexey Proskuryakov  <ap@apple.com>
3677
3678         REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
3679         https://bugs.webkit.org/show_bug.cgi?id=161254
3680
3681         Reviewed by Darin Adler.
3682
3683         Simplify the CSS. My understanding that the CSS was correct, and the root cause
3684         is tracked in bug 160478.
3685
3686         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3687
3688 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
3689
3690         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
3691         https://bugs.webkit.org/show_bug.cgi?id=161217
3692
3693         Reviewed by Ryosuke Niwa.
3694
3695         "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
3696         dumps out the lists of tests that would be run and skipped, and, for each, the entry
3697         in TestExpectations that determines the expected outcome of the test.
3698
3699         This is an improved version of webkit-patch print-expectations.
3700
3701         See bug for sample output.
3702
3703         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3704         (Manager._print_expectations_for_subset): Print out the list of tests and expected
3705         outcome for some subset of tests.
3706         (Manager.print_expectations): Do the same splitting by device class that running tests
3707         does, and for each subset of tests, call _print_expectations_for_subset.
3708         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3709         (TestExpectationParser.expectation_for_skipped_test): Set the flag
3710         expectation_line.not_applicable_to_current_platform
3711         (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
3712         (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
3713         even for skipped tests. This function returns a list relevant for display, taking the skipped
3714         modifier into account.
3715         (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
3716         (TestExpectations.readable_filename_and_line_number): Return something printable for 
3717         lines with and without filenames
3718         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3719         (main): Handle options.print_expectations
3720         (parse_args): Add support for --print-expectations
3721         (_print_expectations):
3722         * Scripts/webkitpy/port/ios.py:
3723         (IOSSimulatorPort.default_child_processes): Make this a debug log.
3724
3725 2016-08-26  Dan Bernstein  <mitz@apple.com>
3726
3727         Keep trying to fix the build after r205057.
3728
3729         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3730
3731 2016-08-26  Dan Bernstein  <mitz@apple.com>
3732
3733         Keep trying to fix the build after r205057.
3734
3735         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
3736           config.h. This file is only meant to be built with Xcode anyway.
3737         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
3738           with Xcode 7.3 and deploy to iOS 9.0.
3739         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
3740         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
3741         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
3742
3743 2016-08-26  Dan Bernstein  <mitz@apple.com>
3744
3745         Start trying to fix the build after r205057.
3746
3747         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3748
3749 2016-08-26  Alexey Proskuryakov  <ap@apple.com>
3750
3751         Remove Yosemite Leaks from the flakiness dashboard
3752         https://bugs.webkit.org/show_bug.cgi?id=161253
3753
3754         Reviewed by Anders Carlsson.
3755
3756         * TestResultServer/static-dashboards/builders.jsonp:
3757
3758 2016-08-26  Sam Weinig  <sam@webkit.org>
3759
3760         Remove support for ENABLE_LEGACY_WEB_AUDIO
3761         https://bugs.webkit.org/show_bug.cgi?id=161262
3762
3763         Reviewed by Anders Carlsson.
3764
3765         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3766
3767 2016-08-26  Jer Noble  <jer.noble@apple.com>
3768
3769         Add a test harness for running UI tests on the iOS Simulator
3770         https://bugs.webkit.org/show_bug.cgi?id=161265
3771
3772         Reviewed by Simon Fraser.
3773
3774         Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
3775         can serve as a test harness for WebKit UI tests.
3776
3777         Also add a basic media playback test which verifies that a <video> element will begin playing in
3778         fullscreen on an iPhone device, but will play inline on an iPad device.
3779
3780         * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
3781         * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
3782         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
3783         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
3784         * MobileMiniBrowser/Makefile: Added.
3785         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
3786         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
3787         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
3788         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
3789         (-[AppDelegate applicationWillResignActive:]):
3790         (-[AppDelegate applicationDidEnterBackground:]):
3791         (-[AppDelegate applicationWillEnterForeground:]):
3792         (-[AppDelegate applicationDidBecomeActive:]):
3793         (-[AppDelegate applicationWillTerminate:]):
3794         * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
3795         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
3796         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
3797         * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
3798         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
3799         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
3800         (-[TabViewController dealloc]):
3801         (-[TabViewController viewDidLoad]):
3802         (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
3803         (-[TabViewController tableView:cellForRowAtIndexPath:]):
3804         (-[TabViewController tableView:numberOfRowsInSection:]):
3805         (-[TabViewController numberOfSectionsInTableView:]):
3806         (-[TabViewController tableView:canEditRowAtIndexPath:]):
3807         (-[TabViewController tableView:canMoveRowAtIndexPath:]):
3808         (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
3809         (-[TabViewController tableView:didSelectRowAtIndexPath:]):
3810         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
3811         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
3812         (-[WebViewController viewDidLoad]):
3813         (-[WebViewController didReceiveMemoryWarning]):
3814         (-[WebViewController reload:]):
3815         (-[WebViewController goBack:]):
3816         (-[WebViewController goForward:]):
3817         (-[WebViewController urlFieldEditingBegan:]):
3818         (-[WebViewController navigateTo:]):
3819         (-[WebViewController showTabs:]):
3820         (-[WebViewController selectWebViewAtIndex:]):
3821         (-[WebViewController removeWebViewAtIndex:]):
3822         (-[WebViewController addWebView]):
3823         (-[WebViewController createWebView]):
3824         (-[WebViewController removeWebView:]):
3825         (-[WebViewController setCurrentWebView:]):
3826         (-[WebViewController webView:didFailNavigation:withError:]):
3827         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
3828         * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
3829         (main):
3830         * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
3831         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
3832         (-[MobileMiniBrowserUITests setUp]):
3833         (-[MobileMiniBrowserUITests tearDown]):
3834         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
3835
3836 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
3837
3838         webkit-queues queue-status page should should list more recent statuses
3839         https://bugs.webkit.org/show_bug.cgi?id=161220
3840
3841         Reviewed by Daniel Bates.
3842
3843         * QueueStatusServer/handlers/queuestatus.py:
3844         (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
3845
3846 2016-08-26  Dan Bernstein  <mitz@apple.com>
3847
3848         [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
3849         https://bugs.webkit.org/show_bug.cgi?id=161258
3850
3851         Reviewed by Anders Carlsson.
3852
3853         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
3854         (TestWebKitAPI::TEST):
3855
3856 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
3857
3858         Fix the ENABLE(WEBASSEMBLY) build on Linux
3859         https://bugs.webkit.org/show_bug.cgi?id=161197
3860
3861         Reviewed by Mark Lam.
3862
3863         * Scripts/build-jsc:
3864
3865 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3866
3867         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
3868         https://bugs.webkit.org/show_bug.cgi?id=161149
3869
3870         Reviewed by Carlos Garcia Campos.
3871
3872         Add a new function for waiting for the accesibility bus. It sets
3873         the test environment variables before starting the GLib mainloop.
3874         And restores the previous environment after it has finished.
3875         It also adds a timeout (5 seconds) to abort in case it has not
3876         been able to detect the accesibility bus before the timeout expires.
3877
3878         * Scripts/run-gtk-tests:
3879         (TestRunner):
3880         (TestRunner._wait_for_accessibility_bus):
3881         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
3882         (TestRunner._start_accessibility_daemons):
3883         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
3884
3885 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
3886
3887         [Win] Warning fix.
3888         https://bugs.webkit.org/show_bug.cgi?id=161236
3889
3890         Reviewed by Brent Fulgham.
3891
3892         The & operator in the Test struct has no body.
3893
3894         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3895         (TestWebKitAPI::TEST):
3896
3897 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3898
3899         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
3900         https://bugs.webkit.org/show_bug.cgi?id=160736
3901
3902         Reviewed by Carlos Garcia Campos.
3903
3904         This plugs run-gtk-tests into the webkitpy testing infrastructure.
3905         As a benefit of this, run-gtk-tests now can be executed over any of
3906         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
3907         or native xorg). A new command line switch --wayland is added for
3908         run-gtk-tests.
3909
3910         * Scripts/run-gtk-tests:
3911         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
3912         Add a --wayland command line switch.
3913         (TestRunner._start_accessibility_daemons):
3914         (TestRunner):
3915         (TestRunner.__init__):
3916         (TestRunner._run_xvfb): Deleted.
3917         (TestRunner._create_driver):
3918         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
3919         are now done by driver._setup_environ_for_test().
3920         (TestRunner._tear_down_testing_environment):
3921         * Scripts/webkitpy/port/driver.py:
3922         (Driver.__init__): Define self._server_name in the constructor of the base class.
3923         It is used by several functions, so it makes sense to store once the value here.
3924         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
3925         (Driver._start): Get the environment from self._setup_environ_for_test()
3926         * Scripts/webkitpy/port/driver_unittest.py:
3927         (DriverTest):
3928         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
3929         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
3930         (GtkPort.__init__):
3931         (GtkPort._driver_class):
3932         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
3933         (WestonDriver._setup_environ_for_test):
3934         (WestonDriver._start):
3935         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
3936         (XorgDriver._setup_environ_for_test):
3937         (XorgDriver._start):
3938         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
3939         (XvfbDriver._setup_environ_for_test):
3940         (XvfbDriver._start):
3941
3942 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
3943
3944         [EFL][GTK] REGRESSION(204877): Fix the clean build
3945         https://bugs.webkit.org/show_bug.cgi?id=161240
3946
3947         Reviewed by Carlos Garcia Campos.
3948
3949         * WebKitTestRunner/PlatformEfl.cmake:
3950         * WebKitTestRunner/PlatformGTK.cmake:
3951
3952 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
3953
3954         EWS should indicate which bot processed the patch
3955         https://bugs.webkit.org/show_bug.cgi?id=161222
3956
3957         Reviewed by Daniel Bates.
3958
3959         * QueueStatusServer/handlers/statusbubble.py:
3960         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
3961         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
3962         Also added "Started processing patch" message to progress_statuses.
3963         I might consider displaying bot id in other statuses as well later on.
3964
3965 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3966
3967         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
3968         https://bugs.webkit.org/show_bug.cgi?id=161184
3969
3970         Reviewed by Carlos Garcia Campos.
3971
3972         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
3973
3974 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
3975
3976         ews queues should update status server when they start processing patch
3977         https://bugs.webkit.org/show_bug.cgi?id=161223
3978
3979         Reviewed by Daniel Bates.
3980
3981         * Scripts/webkitpy/tool/commands/queues.py:
3982         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
3983         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3984         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
3985         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3986         (StyleQueueTest.test_style_queue_with_style_exception): Same.
3987         (test_style_queue_with_watch_list_exception): Same.
3988         (test_non_valid_patch): Same.
3989
3990 2016-08-25  Alex Christensen  <achristensen@webkit.org>
3991
3992         CMake build fix.
3993
3994         * DumpRenderTree/PlatformMac.cmake:
3995
3996 2016-08-25  Alex Christensen  <achristensen@webkit.org>
3997
3998         Fix URLParserTest with GuardMalloc
3999         https://bugs.webkit.org/show_bug.cgi?id=161214
4000         rdar://problem/28014390
4001
4002         Reviewed by Tim Horton.
4003
4004         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
4005         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
4006
4007         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4008         (TestWebKitAPI::eq):
4009         (TestWebKitAPI::checkURL):
4010         (TestWebKitAPI::checkURLDifferences):
4011         (TestWebKitAPI::s): Deleted.
4012
4013 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4014
4015         Dragging against the end of the inline media scrubber causes the media scrubber to hide
4016         https://bugs.webkit.org/show_bug.cgi?id=161207
4017
4018         Reviewed by Eric Carlson.
4019
4020         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
4021         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
4022         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
4023
4024         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
4025         (TestWebKitAPI::TEST):
4026
4027 2016-08-25  Daniel Bates  <dabates@apple.com>
4028
4029         Watch more things.
4030
4031         * Scripts/webkitpy/common/config/watchlist:
4032
4033 2016-08-25  Daniel Bates  <dabates@apple.com>
4034
4035         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
4036         (https://bugs.webkit.org/show_bug.cgi?id=148437)
4037
4038         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
4039         and is not installed on the GTK Linux bots.
4040
4041         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
4042         (writeFileWithContent): Added.
4043
4044 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
4045
4046         [Win] run-api-tests is failing.
4047         https://bugs.webkit.org/show_bug.cgi?id=161140
4048
4049         Reviewed by Brent Fulgham.
4050
4051         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
4052
4053         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
4054         (TestWebKitAPI::TEST):
4055
4056 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
4057
4058         [Win] run-api-tests is failing.
4059         https://bugs.webkit.org/show_bug.cgi?id=161140
4060
4061         Reviewed by Brent Fulgham.
4062
4063         The number of times the move constructor is called is different on Windows in this test. This seems
4064         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
4065
4066         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
4067         (TestWebKitAPI::TEST):
4068
4069 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
4070
4071         Fix iOS DRT build.
4072
4073         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4074         (WTR::UIScriptController::zoomToScale):
4075
4076 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
4077
4078         [iOS DRT] Hook up uiController.zoomToScale() for DRT
4079         https://bugs.webkit.org/show_bug.cgi?id=161173
4080
4081         Reviewed by Tim Horton.
4082         
4083         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
4084         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
4085         
4086         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
4087         the WebThread!), but queue up the callback first.
4088
4089         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
4090         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
4091         (-[DumpRenderTreeWebScrollView initWithFrame:]):
4092         (-[DumpRenderTreeWebScrollView dealloc]):
4093         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
4094         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
4095         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
4096         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
4097         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
4098         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4099         (WTR::UIScriptController::zoomToScale):
4100         * DumpRenderTree/mac/DumpRenderTree.mm:
4101         (createWebViewAndOffscreenWindow):
4102         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4103         (WTR::UIScriptController::context):
4104
4105 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
4106
4107         Attempt to fix Windows build after r204918.
4108
4109         Unreviewed build fix.
4110
4111         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4112         (ResourceLoadDelegate::willSendRequest):
4113
4114 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
4115
4116         [iOS DRT] Get basic viewport tests working in DRT
4117         https://bugs.webkit.org/show_bug.cgi?id=161160
4118
4119         Reviewed by Tim Horton.
4120         
4121         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
4122         scale, and get the contentVisibleRect.
4123         
4124         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
4125         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
4126         
4127         One test has different results between DRT and WTR, but DRT behavior seems to differ
4128         from UIWebView here, so just give it a WK1-specific result.
4129
4130         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
4131         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
4132         (-[DumpRenderTreeBrowserView documentVisibleRect]):
4133         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
4134         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4135         (WTR::UIScriptController::zoomScale):
4136         (WTR::UIScriptController::minimumZoomScale):
4137         (WTR::UIScriptController::maximumZoomScale):
4138         (WTR::UIScriptController::contentVisibleRect):
4139         * DumpRenderTree/mac/DumpRenderTree.mm:
4140         (createWebViewAndOffscreenWindow):
4141         * DumpRenderTree/mac/DumpRenderTreeMac.h:
4142
4143 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
4144
4145         Minor project rearrangement.
4146
4147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4148
4149 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
4150
4151         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
4152         https://bugs.webkit.org/show_bug.cgi?id=161124
4153
4154         Reviewed by Daniel Bates.
4155         
4156         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
4157         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
4158         
4159         Remove some unnecessary zero initializations of static variables.
4160         
4161         Change _setVisibleSize to use the window size, which should not be a behavior change
4162         because this it just used for text autosizing, which is disabled by default,
4163         and only the width is consulted.
4164
4165         * DumpRenderTree/mac/DumpRenderTree.mm:
4166         (adjustWebDocumentForFlexibleViewport):
4167         (adjustWebDocumentForStandardViewport):
4168         (createWebViewAndOffscreenWindow):
4169
4170 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
4171
4172         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
4173         https://bugs.webkit.org/show_bug.cgi?id=42777
4174
4175         Reviewed by Darin Adler.
4176
4177         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
4178
4179         * DumpRenderTree/TestRunner.cpp:
4180         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
4181         * DumpRenderTree/TestRunner.h:
4182         (TestRunner::deferMainResourceDataLoad): Ditto.
4183         (TestRunner::setDeferMainResourceDataLoad): Ditto.
4184         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
4185
4186 2016-08-23  Anders Carlsson  <andersca@apple.com>
4187
4188         Add enum traits and use them in the IPC::Decoder
4189         https://bugs.webkit.org/show_bug.cgi?id=161103
4190
4191         Reviewed by Sam Weinig.
4192
4193         Add API test.
4194
4195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4196         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
4197         (TestWebKitAPI::TEST):
4198
4199 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
4200
4201         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
4202
4203         * DumpRenderTree/TestRunner.cpp:
4204         * DumpRenderTree/mac/DumpRenderTree.mm:
4205         (DumpRenderTreeMain):
4206         * Scripts/run-jsc-stress-tests:
4207         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4208         (TestWebKitAPI::TEST):
4209
4210 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
4211
4212         Try to fix Production builds.
4213         
4214         PRODUCTION_FRAMEWORKS_DIR was undefined here.
4215
4216         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4217
4218 2016-08-24  Dan Bernstein  <mitz@apple.com>
4219
4220         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
4221         https://bugs.webkit.org/show_bug.cgi?id=161152
4222
4223         Reviewed by Anders Carlsson.
4224
4225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4226         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
4227         (TestWebKitAPI::didFinishLoadForFrame):
4228         (TestWebKitAPI::TEST):
4229
4230 2016-08-24  Nan Wang  <n_wang@apple.com>
4231
4232         AX: Add test for line text marker range on iOS
4233         https://bugs.webkit.org/show_bug.cgi?id=161108
4234         <rdar://problem/27976405>
4235
4236         Reviewed by Chris Fleizach.
4237
4238         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4239         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
4240         (AccessibilityUIElement::textMarkerRangeForElement):
4241         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4242         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
4243         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
4244
4245 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
4246
4247         [Win] Warning fixes.
4248         https://bugs.webkit.org/show_bug.cgi?id=161079
4249
4250         Reviewed by Brent Fulgham.
4251
4252         * MiniBrowser/win/WebDownloadDelegate.cpp:
4253         * MiniBrowser/win/WinMain.cpp:
4254         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4255         (TestWebKitAPI::TEST):
4256
4257 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
4258
4259         Fix Windows DRT build.
4260
4261         * DumpRenderTree/win/TestRunnerWin.cpp:
4262         (TestRunner::mainFrameJSContext):
4263
4264 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
4265
4266         Try to fix Windows build.
4267         
4268         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
4269         so that perl finds CodeGeneratorDumpRenderTree.pm.
4270
4271         * DumpRenderTree/CMakeLists.txt:
4272
4273 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
4274
4275         Hook up UIScriptController in DumpRenderTree
4276         https://bugs.webkit.org/show_bug.cgi?id=161064
4277
4278         Reviewed by Sam Weinig.
4279
4280         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
4281         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
4282         in fast/harness which test this.
4283
4284         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
4285
4286         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
4287         WK2-isms. Fix the makefiles to refer to the new location.
4288
4289         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
4290         by ID and firing them once they are complete.
4291
4292         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
4293         * DumpRenderTree/CMakeLists.txt:
4294         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
4295         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4296         * DumpRenderTree/TestRunner.cpp:
4297         (runUIScriptCallback):
4298         (TestRunner::staticFunctions):
4299         (TestRunner::cacheTestRunnerCallback):
4300         (TestRunner::callTestRunnerCallback):
4301         (TestRunner::clearTestRunnerCallbacks):
4302         (nextUIScriptCallbackID):
4303         (TestRunner::runUIScript):
4304         (TestRunner::callUIScriptCallback):
4305         (TestRunner::uiScriptDidComplete):
4306         (TestRunner::cleanup):
4307         * DumpRenderTree/TestRunner.h:
4308         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
4309         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
4310         * DumpRenderTree/mac/DumpRenderTree.mm:
4311         (runTest):
4312         * DumpRenderTree/mac/TestRunnerMac.mm:
4313         (TestRunner::mainFrameJSContext):
4314         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
4315         (WTR::UIScriptController::doAsyncTask):
4316         * DumpRenderTree/win/DumpRenderTree.cpp:
4317         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
4318         (WTR::JSWrappable::~JSWrappable):
4319         (WTR::JSValueMakeStringOrNull):
4320         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
4321         (WTR::JSWrapper::wrap):
4322         (WTR::JSWrapper::unwrap):
4323         (WTR::unwrapObject):
4324         (WTR::JSWrapper::initialize):
4325         (WTR::JSWrapper::finalize):
4326         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
4327         (WTR::toJS):
4328         (WTR::setProperty):
4329         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
4330         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
4331         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
4332         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
4333         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
4334         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
4335         * WebKitTestRunner/CMakeLists.txt:
4336         * WebKitTestRunner/DerivedSources.make:
4337         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
4338         (WTR::JSWrappable::~JSWrappable): Deleted.
4339         (WTR::JSValueMakeStringOrNull): Deleted.
4340         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
4341         (WTR::JSWrapper::wrap): Deleted.
4342         (WTR::JSWrapper::unwrap): Deleted.
4343         (WTR::unwrapObject): Deleted.
4344         (WTR::JSWrapper::initialize): Deleted.
4345   &n