[WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
4         https://bugs.webkit.org/show_bug.cgi?id=186276
5
6         Reviewed by Carlos Garcia Campos.
7
8         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
9         (webViewLoadChanged):
10         (testWebResourceGetDataError):
11         (testWebResourceGetDataEmpty):
12         (beforeAll):
13         (webViewloadChanged): Deleted.
14
15 2019-03-27  Andy Estes  <aestes@apple.com>
16
17         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
18         https://bugs.webkit.org/show_bug.cgi?id=196317
19
20         Reviewed by Dan Bernstein.
21
22         package-root copies built products into a staging directory using ditto(1), which does not
23         follow symbolic links as it traverses a directory. Now that the files in
24         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
25         itself, these become broken links when ditto'd into the staging directory.
26
27         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
28
29         * Scripts/package-root:
30
31 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
32
33         [ews-app] Update display text of Submit for ews analysis
34         https://bugs.webkit.org/show_bug.cgi?id=196309
35
36         Reviewed by Dewei Zhu.
37
38         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
39
40 2019-03-27  David Kilzer  <ddkilzer@apple.com>
41
42         run-webkit-tests should check for leaks in WebKit processes
43         <https://webkit.org/b/193772>
44         <rdar://problem/46526680>
45
46         Reviewed by Ryosuke Niwa.
47
48         This works by doing the following:
49         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
50           The list of child processes are returned one per line:
51           process.name: pid
52         - Run the "#LIST CHILD PROCESSES" command just before the
53           "#CHECK FOR WORLD LEAKS" command, and store the list of child
54           processes on the ServerProcess object.
55         - When the `--leaks` switch is handled, run check_for_leaks() on
56           each child process after the main test harness.
57
58         * DumpRenderTree/mac/DumpRenderTree.mm:
59         (handleControlCommand):
60         - Use strncmp() instead of strcmp().
61         - Add support for handling "#LIST CHILD PROCESSES" command.
62
63         * Scripts/webkitpy/port/base.py:
64         (Port.check_for_leaks):
65         * Scripts/webkitpy/port/darwin.py:
66         (DarwinPort.check_for_leaks):
67         - Rename redundant 'process_pid' argument to 'process_id'.
68
69         * Scripts/webkitpy/port/driver.py:
70         (Driver.do_post_tests_work):
71         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
72           longer the only command this sends to WebKitTestRunner.
73         - If the `--leaks` switch is present, send the
74           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
75           result using Port.set_webkit_processes().
76         (Driver._parse_child_processes_output):
77         - Add helper method to parse list of child process names and
78           process IDs returned from WebKitTestRunner.
79
80         * Scripts/webkitpy/port/ios_device.py:
81         (IOSDevicePort.check_for_leaks):
82         - Rename redundant 'process_pid' argument to 'process_id'.
83
84         * Scripts/webkitpy/port/leakdetector.py:
85         (LeakDetector._parse_leaks_output):
86         - Return early if there is no leaks_output.
87         (LeakDetector.check_for_leaks):
88         - Rename redundant 'process_pid' argument to 'process_id'.
89
90         * Scripts/webkitpy/port/server_process.py:
91         (ServerProcess.__init__):
92         (ServerProcess.child_processes):
93         (ServerProcess.set_child_processes):
94         - Add instance variable to Port to store list of child process
95           names and process IDs returned from WebKitTestRunner.
96         (ServerProcess._start):
97         - Clear self._child_processes.
98         (ServerProcess.stop):
99         - If self._child_processes is set, call
100           self._port.check_for_leaks() for each child process.
101
102         * Scripts/webkitpy/port/server_process_unittest.py:
103         (TrivialMockPort.check_for_leaks):
104         - Rename redundant 'process_pid' argument to 'process_id'.
105
106         * Scripts/webkitpy/port/simulator_process.py:
107         (SimulatorProcess.stop):
108         - If self._child_processes is set, call
109           self._port.check_for_leaks() for each child process.
110
111         * Scripts/webkitpy/port/watch_device.py:
112         (WatchDevicePort.check_for_leaks):
113         - Rename redundant 'process_pid' argument to 'process_id'.
114
115         * WebKitTestRunner/TestController.cpp:
116         (WTR::TestController::dumpResponse):
117         - Extract method from findAndDumpWorldLeaks() so that it may be
118           reused by findAndDumpWebKitProcessIdentifiers().
119         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
120         - Add method to output process name and process ID of both the
121           WebContent and Networking processes.
122         (WTR::TestController::findAndDumpWorldLeaks):
123         - Fix missing newline in output when there were no abandoned
124           documents.
125         - Call dumpResponse() for extracted code.
126         (WTR::TestController::handleControlCommand):
127         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
128         - Use strncmp() instead of strcmp().
129         - Call findAndDumpWebKitProcessIdentifiers() when
130           "#LIST CHILD PROCESSES" command is sent.
131         * WebKitTestRunner/TestController.h:
132         (WTR::TestController::dumpResponse):
133         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
134         - Declare methods.
135
136 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
137
138         Unreviewed. Add GLib API test cases after r243434.
139
140         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
141         (testWebViewActiveURI):
142         (serverCallback):
143         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
144         (sendRequestCallback):
145
146 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
147
148         Geolocation request not complete when watch request was started in a different web process
149         https://bugs.webkit.org/show_bug.cgi?id=195996
150
151         Reviewed by Alex Christensen.
152
153         Add a test case.
154
155         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
156         (TestWebKitAPI::runJavaScriptAlert):
157         (TestWebKitAPI::TEST):
158
159 2019-03-26  Keith Rollin  <krollin@apple.com>
160
161         Update the way generate-xcfilelists returns strings from functions
162         https://bugs.webkit.org/show_bug.cgi?id=195975
163         <rdar://problem/49040807>
164
165         Reviewed by Dean Jackson.
166
167         There are places where generate-xcfilelists executes assignments with
168         statements like:
169
170             FOO=$(some_function)
171
172         where "some_function" return a string by echoing it. E.g.
173
174             some_function()
175             {
176                 echo "Hello, World"
177             }
178
179         This is a common idiom, but it has a problem if "some_function" needs
180         to call "exit" in an attempt to halt the entire script right then and
181         there. Since "some_function" is called inside of $(), it's being
182         executed in a sub-shell. Calling exit in that sub-shell simply exits
183         that shell; it doesn't not exit the outer shell in which the main part
184         of the script is still running. As such, the main script keeps
185         executing when the intent was for the script to halt.
186
187         The solution to this is to use a different idiom for returning
188         strings. The one we now is to pass in the name of the variable to
189         receive the string result:
190
191             some_function()
192             {
193                 variable_name=$1
194                 eval $variable_name ="Hello, World"
195             }
196
197         The call site now looks like
198
199             some_function FOO
200
201         Because there's no invocation of a sub-shell, some_function can now
202         call "exit" if it wants to, and the entire script will exit at that
203         point.
204
205         * Scripts/generate-xcfilelists:
206
207 2019-03-26  Chris Dumez  <cdumez@apple.com>
208
209         Add basic layout test coverage for File Picker on iOS
210         https://bugs.webkit.org/show_bug.cgi?id=196265
211
212         Reviewed by Wenson Hsieh.
213
214         Add layout test infrastructure to test the file picker on iOS.
215
216         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
217         (WTR::UIScriptController::dismissFilePicker):
218         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
219         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
220         (WTR::UIScriptController::dismissFilePicker):
221         * TestRunnerShared/UIScriptContext/UIScriptController.h:
222         * WebKitTestRunner/TestController.cpp:
223         (WTR::TestController::createWebViewWithOptions):
224         (WTR::updateTestOptionsFromTestHeader):
225         * WebKitTestRunner/TestOptions.h:
226         (WTR::TestOptions::hasSameInitializationOptions const):
227         * WebKitTestRunner/ios/TestControllerIOS.mm:
228         (overridePresentViewController):
229         (WTR::TestController::platformInitialize):
230         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
231         (WTR::UIScriptController::dismissFilePicker):
232
233 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
234
235         Implement async paste method on UIWKInteractionViewProtocol
236         https://bugs.webkit.org/show_bug.cgi?id=196267
237         <rdar://problem/49236346>
238
239         Reviewed by Tim Horton.
240
241         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
242         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
243         are now a part of all iOS 12 internal SDKs.
244
245         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
246
247         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
248         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
249
250         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
251         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
252         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
253         * TestWebKitAPI/ios/UIKitSPI.h:
254
255 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
256
257         [ews-build] Use PostgreSQL for ews.webkit.org database
258         https://bugs.webkit.org/show_bug.cgi?id=196270
259
260         Reviewed by Lucas Forschler.
261
262         * BuildSlaveSupport/ews-app/ews-app/settings.py:
263
264 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
265
266         [ews] Reset simctl states on reboot
267         https://bugs.webkit.org/show_bug.cgi?id=196260
268
269         Rubber-stamped by Aakash Jain.
270
271         * EWSTools/start-queue-mac.sh:
272
273 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
274
275         [ews-build] Use PostgreSQL for ews-build database
276         https://bugs.webkit.org/show_bug.cgi?id=196229
277
278         Reviewed by Lucas Forschler.
279
280         * BuildSlaveSupport/ews-build/master.cfg:
281
282 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
283
284         [ews-build] Get master_hostname dynamically in master.cfg
285         https://bugs.webkit.org/show_bug.cgi?id=196255
286
287         Reviewed by Lucas Forschler.
288
289         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
290         send events data in test mode.
291
292 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
293
294         [ews-app] Set db_constraint to False for Foreign Keys
295         https://bugs.webkit.org/show_bug.cgi?id=196252
296
297         Reviewed by Lucas Forschler.
298
299         * BuildSlaveSupport/ews-app/ews/models/build.py:
300         * BuildSlaveSupport/ews-app/ews/models/step.py:
301
302 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
303
304         [ews-build] is_test_mode_enabled should default to True
305         https://bugs.webkit.org/show_bug.cgi?id=196248
306
307         Reviewed by Lucas Forschler.
308
309         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
310
311 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
312
313         [ews-app] Add webkitperl to ENABLED_QUEUES
314         https://bugs.webkit.org/show_bug.cgi?id=196253
315
316         Reviewed by Lucas Forschler.
317
318         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
319
320 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
321
322         Address NSWindow sometimes using WebKitTestRunnerEvent too early
323         https://bugs.webkit.org/show_bug.cgi?id=196211
324         rdar://problem/49110552
325
326         Reviewed by Tim Horton.
327
328         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
329         Make sure that EventSenderProxy always exists when running tests. We used to create
330         it when resetting before the first test, which is a bit too late.
331
332         * WebKitTestRunner/TestController.h:
333         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
334         (WTR::TestController::platformCreateWebView):
335         (WTR::TestController::platformCreateOtherPage):
336         (WTR::TestController::finishCreatingPlatformWebView):
337         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
338         (WTR::PlatformWebView::PlatformWebView):
339         Moved some code that made NSWindow use NSEvent during web view creation. We may
340         need to move more if some other case us found, but this is enough for now.
341
342 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
343
344         Unreviewed. Fix typo in GLib geolocation API after r243285.
345
346         gelocation -> geolocation.
347
348         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
349         (testGeolocationManagerWatchPosition):
350
351 2019-03-25  Alex Christensen  <achristensen@webkit.org>
352
353         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
354         https://bugs.webkit.org/show_bug.cgi?id=196213
355
356         Reviewed by Geoff Garen.
357
358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
359         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
360         (credentialWithIdentityAndKeychainPath):
361         (-[ChallengeDelegate webView:didFinishNavigation:]):
362         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
363         (TestWebKitAPI::TEST):
364
365 2019-03-25  Alex Christensen  <achristensen@webkit.org>
366
367         Expected shouldn't assume its contained types are copyable
368         https://bugs.webkit.org/show_bug.cgi?id=195986
369
370         Reviewed by JF Bastien.
371
372         * TestWebKitAPI/Tests/WTF/Expected.cpp:
373         (TestWebKitAPI::NonCopyable::operator== const):
374         (TestWebKitAPI::NonCopyable::operator!= const):
375         (TestWebKitAPI::TEST):
376
377 2019-03-25  Tim Horton  <timothy_horton@apple.com>
378
379         Remove some now-unnecessary dynamic class lookup
380         https://bugs.webkit.org/show_bug.cgi?id=196237
381
382         Reviewed by Simon Fraser.
383
384         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
385         (makeRequest):
386         (TEST):
387
388 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
389
390         Unreviewed, rolling out r243450.
391
392         AppleWin and WinCairo port builds get broken.
393
394         Reverted changeset:
395
396         "Add test for fix of #196095"
397         https://bugs.webkit.org/show_bug.cgi?id=196097
398         https://trac.webkit.org/changeset/243450
399
400 2019-03-25  Commit Queue  <commit-queue@webkit.org>
401
402         Unreviewed, rolling out r243465.
403         https://bugs.webkit.org/show_bug.cgi?id=196226
404
405         the test doesn't build (Requested by thorton on #webkit).
406
407         Reverted changeset:
408
409         "Do not terminate the NetworkProcess if a third party
410         application sends a NSCredential with a SecIdentityRef"
411         https://bugs.webkit.org/show_bug.cgi?id=196213
412         https://trac.webkit.org/changeset/243465
413
414 2019-03-25  Alex Christensen  <achristensen@webkit.org>
415
416         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
417         https://bugs.webkit.org/show_bug.cgi?id=196213
418
419         Reviewed by Geoff Garen.
420
421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
422         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
423         (credentialWithIdentityAndKeychainPath):
424         (-[ChallengeDelegate webView:didFinishNavigation:]):
425         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
426         (TestWebKitAPI::TEST):
427
428 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
429
430         [ews-build] Gracefully handle missing patch_id in events
431         https://bugs.webkit.org/show_bug.cgi?id=196216
432
433         Reviewed by Lucas Forschler.
434
435         * BuildSlaveSupport/ews-build/events.py:
436
437 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
438
439         [ews-build] use lz4 compression for improving buildbot performance
440         https://bugs.webkit.org/show_bug.cgi?id=196155
441
442         Reviewed by Lucas Forschler.
443
444         * BuildSlaveSupport/ews-build/master.cfg:
445
446 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
447
448         Pull some API testing helper methods out of TestWKWebView
449         https://bugs.webkit.org/show_bug.cgi?id=196212
450
451         Reviewed by Tim Horton.
452
453         Refactor some more API testing utility methods, so that they can be used in
454         tests that do not use TestWKWebView.
455
456         * TestWebKitAPI/cocoa/TestWKWebView.h:
457         * TestWebKitAPI/cocoa/TestWKWebView.mm:
458         (-[WKWebView loadTestPageNamed:]):
459         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
460         (-[WKWebView synchronouslyLoadHTMLString:]):
461         (-[WKWebView synchronouslyLoadTestPageNamed:]):
462         (-[TestWKWebView loadTestPageNamed:]): Deleted.
463         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
464         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
465         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
466
467 2019-03-25  Jer Noble  <jer.noble@apple.com>
468
469         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
470         https://bugs.webkit.org/show_bug.cgi?id=196097
471
472         Reviewed by Eric Carlson.
473
474         Drive-by bug fix: allow tests to play audio without a user gesture by default.
475
476         * DumpRenderTree/mac/DumpRenderTree.mm:
477         (resetWebPreferencesToConsistentValues):
478         * WebKitTestRunner/TestController.cpp:
479         (WTR::TestController::resetPreferencesToConsistentValues):
480
481 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
482
483         Pull IPadUserInterfaceSwizzler out into a separate header file
484         https://bugs.webkit.org/show_bug.cgi?id=196193
485
486         Reviewed by Anders Carlsson.
487
488         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
489         be used in other API tests.
490
491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
492         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
493         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
494         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
495         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
496         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
497         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
498
499 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
500
501         Remove NavigatorContentUtils in WebCore/Modules
502         https://bugs.webkit.org/show_bug.cgi?id=196070
503
504         Reviewed by Alex Christensen.
505
506         NavigatorContentUtils was to support the custom scheme spec [1].
507         However, in WebKit side, no port has supported the feature in
508         WebKit layer after EFL port was removed. So there has been the
509         only IDL implementation of the NavigatorContentUtils in WebCore.
510         So we don't need to keep the implementation in WebCore anymore.
511
512         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
513
514         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
515
516 2019-03-24  Andy Estes  <aestes@apple.com>
517
518         [watchOS] Remove unused Proximity Networking code
519         https://bugs.webkit.org/show_bug.cgi?id=196188
520
521         Reviewed by Tim Horton.
522
523         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
524         (TEST):
525
526 2019-03-23  Keith Miller  <keith_miller@apple.com>
527
528         Refactor clz/ctz and fix getLSBSet.
529         https://bugs.webkit.org/show_bug.cgi?id=196162
530
531         Reviewed by Saam Barati.
532
533         Add tests for clz, ctz, getLSBSet, and getMSBSet.
534
535         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
536         (TestWebKitAPI::TEST):
537
538 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
539
540         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
541         https://bugs.webkit.org/show_bug.cgi?id=196143
542
543         Reviewed by Michael Catanzaro.
544
545         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
546         directories.
547
548         * Scripts/webkitpy/style/checkers/cpp.py:
549         (check_identifier_name_in_declaration):
550         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
551         (WebKitStyleTest.test_names):
552
553 2019-03-22  Philippe Normand  <pnormand@igalia.com>
554
555         [Flatpak] Manifest expanding fails for qt WPE extension
556         https://bugs.webkit.org/show_bug.cgi?id=196148
557
558         Reviewed by Alex Christensen.
559
560         * flatpak/flatpakutils.py:
561         (expand_submodules_recurse): The last recurse manifest expand
562         iteration might lead to a single module so take it into account
563         and don't try to recurse further.
564
565 2019-03-22  Chris Dumez  <cdumez@apple.com>
566
567         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
568         https://bugs.webkit.org/show_bug.cgi?id=195348
569         <rdar://problem/48622090>
570
571         Reviewed by Alex Christensen.
572
573         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
574         to NO when test.options().shouldIgnoreMetaViewport is false.
575
576         * WebKitTestRunner/ios/TestControllerIOS.mm:
577         (WTR::TestController::platformConfigureViewForTest):
578
579 2019-03-22  Chris Dumez  <cdumez@apple.com>
580
581         Prewarmed processes should be usable with any website data store
582         https://bugs.webkit.org/show_bug.cgi?id=196104
583
584         Reviewed by Alex Christensen.
585
586         Add API test coverage.
587
588         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
589         (runInitialWarmedProcessUsedTest):
590         (TEST):
591
592 2019-03-22  David Kilzer  <ddkilzer@apple.com>
593
594         Back out local changes to Alex's Subversion working directory
595
596         They were accidentally committed.
597
598         * Scripts/webkitpy/common/system/abstractexecutive.py:
599         (AbstractExecutive.wait_newest):
600         * Scripts/webkitpy/common/system/executive.py:
601         (Executive.running_pids):
602         * Scripts/webkitpy/common/system/executive_mock.py:
603         (MockExecutive.running_pids):
604         * Scripts/webkitpy/common/system/executive_unittest.py:
605         (ExecutiveTest.serial_test_running_pids):
606         * Scripts/webkitpy/port/darwin.py:
607         (DarwinPort.check_for_leaks):
608         * Scripts/webkitpy/port/leakdetector.py:
609         (LeakDetector.check_for_leaks):
610         - This was the hack attached to Bug 193772.
611
612         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
613         (+[WebKitTestRunnerEvent mouseLocation]):
614         - This works around a crash on an internal build.
615
616 2019-03-22  Tim Horton  <timothy_horton@apple.com>
617
618         Fix the build after r243354
619         https://bugs.webkit.org/show_bug.cgi?id=196138
620         <rdar://problem/49145951>
621
622         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
623         (TEST):
624         * TestWebKitAPI/ios/UIKitSPI.h:
625
626 2019-03-21  Tim Horton  <timothy_horton@apple.com>
627
628         Adopt UIWKDocumentContext
629         https://bugs.webkit.org/show_bug.cgi?id=196040
630         <rdar://problem/48642440>
631
632         Reviewed by Ryosuke Niwa.
633
634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
635         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
636         (makeRequest):
637         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
638         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
639         (applyStyle):
640         (TEST):
641         Add tests for UIWKDocumentContext.
642
643         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
644         (TEST):
645         (recursiveFindWKContentView): Deleted.
646         * TestWebKitAPI/cocoa/TestWKWebView.h:
647         * TestWebKitAPI/cocoa/TestWKWebView.mm:
648         (recursiveFindWKContentView):
649         (-[TestWKWebView wkContentView]):
650         * TestWebKitAPI/ios/UIKitSPI.h:
651         Share the WKContentView finding code between tests.
652
653 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
654
655         [iOS WK2] Turn on async overflow scrolling by default
656         https://bugs.webkit.org/show_bug.cgi?id=196011
657         rdar://problem/48453859
658
659         Reviewed by Antti Koivisto.
660         
661         Explicitly turn off the async overflow scrolling internal feature for tests by default,
662         since so many basic layout tests have different results when compositing is triggered for
663         overflow.
664         
665         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
666
667         * WebKitTestRunner/TestController.cpp:
668         (WTR::TestController::resetPreferencesToConsistentValues):
669
670 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
671
672         [ews-build] Retry API test in case of failures
673         https://bugs.webkit.org/show_bug.cgi?id=196004
674
675         Reviewed by Lucas Forschler.
676
677         * BuildSlaveSupport/ews-build/steps.py:
678         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
679         (CompileWebKitToT.doStepIf): Ditto.
680         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
681         (ReRunAPITests): Re-run API tests.
682         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
683         (RunAPITestsWithoutPatch): Run API tests without patch.
684         (RunAPITestsWithoutPatch.doStepIf):
685         (RunAPITestsWithoutPatch.hideStepIf):
686         (RunAPITestsWithoutPatch.evaluateCommand):
687         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
688         (AnalyzeAPITestsResults.start):
689         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
690         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
691         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
692         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
693
694 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
695
696         [ews-build] Update queues configurations
697         https://bugs.webkit.org/show_bug.cgi?id=196074
698
699         Reviewed by Dewei Zhu.
700
701         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
702         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
703
704 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
705
706         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
707         https://bugs.webkit.org/show_bug.cgi?id=195680
708         <rdar://problem/48903534>
709
710         Unreviewed infrastructure fix.
711
712         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
713         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
714
715 2019-03-21  Andy Estes  <aestes@apple.com>
716
717         [iOS] Apple Pay should be available in documents with no user agent scripts
718         https://bugs.webkit.org/show_bug.cgi?id=196061
719         <rdar://problem/48649391>
720
721         Reviewed by Brady Eidson.
722
723         Added API tests and related infrastructure.
724
725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
726         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
727         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
728         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
729         (TestWebKitAPI::TEST):
730         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
731         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
732         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
733         * TestWebKitAPI/cocoa/TestProtocol.mm:
734         (-[TestProtocol startLoading]):
735         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
736         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
737         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
738         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
739
740 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
741
742         REGRESSSION (r243297): webkitpy tests broken
743         https://bugs.webkit.org/show_bug.cgi?id=196108
744
745         Reviewed by Aakash Jain.
746
747         r243297 updated contributors.json, which broke a few unit tests.
748
749         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
750         (IRCCommandTest.test_whois):
751         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
752
753 2019-03-21  Chris Dumez  <cdumez@apple.com>
754
755         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
756         https://bugs.webkit.org/show_bug.cgi?id=196041
757         <rdar://problem/49083230>
758
759         Reviewed by Alex Christensen.
760
761         Add API test coverage.
762
763         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
764         (TEST):
765
766 2019-03-21  Alex Christensen  <achristensen@webkit.org>
767
768         Add SPI to inform applications of WKContentRuleList actions
769         https://bugs.webkit.org/show_bug.cgi?id=195965
770         <rdar://problem/42664365>
771
772         Reviewed by Geoff Garen.
773
774         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
775         (TestWebKitAPI::allActionsForResourceLoad):
776         (TestWebKitAPI::testRequest):
777         (TestWebKitAPI::TEST_F):
778         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
779         (Notification::description):
780         (Notification::operator== const):
781         (toVector):
782         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
783         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
784         (makeContentRuleList):
785         (TEST):
786         (makeWarnContentRuleList): Deleted.
787
788 2019-03-21  Timothy Hatcher  <timothy@apple.com>
789
790         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
791         https://bugs.webkit.org/show_bug.cgi?id=196088
792
793         Reviewed by Brian Burg.
794
795         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
796         Support checks when only one platform is specified. Also deprecate macosx() and
797         force the use of macos() instead.
798
799         * Scripts/webkitpy/style/checkers/cpp.py:
800         (check_min_versions_of_wk_api_available):
801         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
802         (WebKitStyleTest.test_min_versions_of_wk_api_available):
803
804 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
805
806         Update status inactive committers' status to 'contributor'.
807
808         * Scripts/webkitpy/common/config/contributors.json:
809
810 2019-03-21  Xan Lopez  <xan@igalia.com>
811
812         [JSC][x86] Drop support for x87 floating point
813         https://bugs.webkit.org/show_bug.cgi?id=194853
814
815         Reviewed by Don Olmstead.
816
817         Force SSE2 on x86/32bit builds.
818
819         * Scripts/webkitdirs.pm:
820         (generateBuildSystemFromCMakeProject):
821
822 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
823
824         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
825         https://bugs.webkit.org/show_bug.cgi?id=196073
826
827         Reviewed by Michael Catanzaro.
828
829         Add test cases to check functions and constructors with no arguments but receiving user data.
830
831         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
832         (checkUserData):
833         (testJSCFunction):
834         (fooCreateWithUserData):
835         (testJSCClass):
836
837 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
838
839         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
840
841         Add g_assert_cmpfloat_with_epsilon macro if not defined.
842
843         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
844
845 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
846
847         [GTK][WPE] Add API to provide geolocation information
848         https://bugs.webkit.org/show_bug.cgi?id=195940
849
850         Reviewed by Michael Catanzaro.
851
852         Add a new test to check the new API.
853
854         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
855         (testGeolocationManagerCurrentPosition):
856         (testGeolocationManagerWatchPosition):
857         (beforeAll):
858         (afterAll):
859         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
860         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
861         (beforeAll): Ditto.
862         * TestWebKitAPI/glib/CMakeLists.txt:
863
864 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
865
866         [GLib] Returning G_TYPE_OBJECT from a method does not work
867         https://bugs.webkit.org/show_bug.cgi?id=195574
868
869         Reviewed by Michael Catanzaro.
870
871         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
872
873         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
874         (getGFile):
875         (getParent):
876         (createGString):
877         (getGString):
878         (getGStringCopyWillRaise):
879         (getGStringCopy):
880         (getGStringStr):
881         (getGStringLen):
882         (freeGString):
883         (testJSCClass):
884
885 2019-03-20  Saam Barati  <sbarati@apple.com>
886
887         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
888         https://bugs.webkit.org/show_bug.cgi?id=195721
889
890         Reviewed by Filip Pizlo.
891
892         * Scripts/run-javascriptcore-tests:
893
894 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
895
896         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
897         https://bugs.webkit.org/show_bug.cgi?id=196049
898
899         Reviewed by Tim Horton.
900
901         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
902         overflow scrolling in general, so rename it.
903
904         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
905
906 2019-03-20  Daniel Bates  <dabates@apple.com>
907
908         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
909         https://bugs.webkit.org/show_bug.cgi?id=196031
910         <rdar://problem/49078172>
911
912         Reviewed by Tim Horton.
913
914         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
915         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
916         same code path used when the Done button is pressed to dismiss the <select> picker.
917
918         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
919         (TestWebKitAPI::TEST):
920
921 2019-03-20  Chris Dumez  <cdumez@apple.com>
922
923         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
924         https://bugs.webkit.org/show_bug.cgi?id=196029
925         <rdar://problem/48954651>
926
927         Reviewed by Tim Horton.
928
929         Add API test coverage.
930
931         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
932
933 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
934
935         [ews-build] Improve failure summary string for ApplyPatch step
936         https://bugs.webkit.org/show_bug.cgi?id=195995
937
938         Reviewed by Alexey Proskuryakov.
939
940         * BuildSlaveSupport/ews-build/steps.py:
941         (ApplyPatch.getResultSummary): Override getResultSummary.
942
943 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
944
945         AX: Implement support for new meter ARIA role
946         https://bugs.webkit.org/show_bug.cgi?id=195966
947
948         Reviewed by Chris Fleizach.
949
950         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
951         to AXLevelIndicator.
952
953         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
954
955 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
956
957         [WebAuthN] Implement FIDO AppID extension
958         https://bugs.webkit.org/show_bug.cgi?id=143491
959         <rdar://problem/48298273>
960
961         Reviewed by Brent Fulgham.
962
963         Add a test that covers the new flag of convertToU2fSignCommand.
964
965         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
966         (TestWebKitAPI::TEST):
967         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
968         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
969         (TestWebKitAPI::TEST):
970
971 2019-03-19  Keith Rollin  <krollin@apple.com>
972
973         Add support for more platforms to generate-xcfilelists
974         https://bugs.webkit.org/show_bug.cgi?id=195977
975
976         Reviewed by Alexey Proskuryakov.
977
978         generate-xcfilelists incorrectly complains when involved with building
979         WebKit for iphonesimulator:
980
981             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
982             …
983             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
984
985         Address this by teaching generate-xcfilelists about more platforms.
986
987         * Scripts/generate-xcfilelists:
988
989 2019-03-19  John Wilander  <wilander@apple.com>
990
991         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
992         https://bugs.webkit.org/show_bug.cgi?id=195923
993         <rdar://problem/49001272>
994
995         Reviewed by Alex Christensen.
996
997         This patch does the following to the TestRunner:
998         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
999         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1000         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1001
1002         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1003         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1004         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1005         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1006         * WebKitTestRunner/TestController.cpp:
1007         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1008         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1009         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1010         * WebKitTestRunner/TestController.h:
1011         * WebKitTestRunner/TestInvocation.cpp:
1012         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1013
1014 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1015
1016         [CMake] Support more clang and gcc sanitizers
1017         https://bugs.webkit.org/show_bug.cgi?id=195956
1018
1019         Reviewed by Michael Catanzaro.
1020
1021         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1022
1023 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1024
1025         [ews-build] Improve summary for PrintConfiguration step
1026         https://bugs.webkit.org/show_bug.cgi?id=195945
1027
1028         Reviewed by Lucas Forschler.
1029
1030         * BuildSlaveSupport/ews-build/steps.py:
1031         (PrintConfiguration.getResultSummary): Override getResultSummary.
1032
1033 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1034
1035         [ews-build] Improve summary for CheckOutSource step
1036         https://bugs.webkit.org/show_bug.cgi?id=195963
1037
1038         Reviewed by Lucas Forschler.
1039
1040         * BuildSlaveSupport/ews-build/steps.py:
1041         (CheckOutSource.getResultSummary):
1042
1043 2019-03-19  Daniel Bates  <dabates@apple.com>
1044
1045         [iOS] Focus not preserved when switching between tabs
1046         https://bugs.webkit.org/show_bug.cgi?id=195820
1047         <rdar://problem/43614450>
1048
1049         Reviewed by Brent Fulgham.
1050
1051         Add tests to ensure that we restore focus when resigning and becoming first responder.
1052
1053         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1054         (TestWebKitAPI::TEST):
1055
1056 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1057
1058         Make WTFLogChannelState and WTFLogLevel enum classes
1059         https://bugs.webkit.org/show_bug.cgi?id=195904
1060
1061         Reviewed by Eric Carlson.
1062
1063         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1064         (TestWebKitAPI::TEST_F):
1065
1066 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1067
1068         [GStreamer][EME] Backported mssdemux protection data crash fix
1069         https://bugs.webkit.org/show_bug.cgi?id=195918
1070
1071         Reviewed by Philippe Normand.
1072
1073         * gstreamer/jhbuild.modules:
1074         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1075
1076 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1077
1078         Unreviewed, rolling out r243132.
1079
1080         Broke GTK build
1081
1082         Reverted changeset:
1083
1084         "Make WTFLogChannelState and WTFLogLevel enum classes"
1085         https://bugs.webkit.org/show_bug.cgi?id=195904
1086         https://trac.webkit.org/changeset/243132
1087
1088 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1089
1090         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1091
1092         * Scripts/webkitdirs.pm:
1093         (builtDylibPathForName): Adjust the shared library name that's changed
1094         with the API version bump in r243073.
1095
1096 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1097
1098         Make WTFLogChannelState and WTFLogLevel enum classes
1099         https://bugs.webkit.org/show_bug.cgi?id=195904
1100
1101         Reviewed by Eric Carlson.
1102
1103         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1104         (TestWebKitAPI::TEST_F):
1105
1106 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1107
1108         Disable flaky test added in r2431100
1109         https://webkit.org/b/195785
1110
1111         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1112         (TestWebKitAPI::TEST):
1113         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1114
1115 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1116
1117         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1118         https://bugs.webkit.org/show_bug.cgi?id=195916
1119
1120         Reviewed by Tim Horton.
1121
1122         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1123         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1124
1125 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1126
1127         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1128
1129         * Scripts/webkitpy/common/config/contributors.json:
1130
1131 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1132
1133         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1134         https://bugs.webkit.org/show_bug.cgi?id=195785
1135
1136         Reviewed by Geoffrey Garen.
1137
1138         * TestWebKitAPI/TCPServer.cpp: Added.
1139         (TestWebKitAPI::TCPServer::TCPServer):
1140         (TestWebKitAPI::TCPServer::~TCPServer):
1141         (TestWebKitAPI::TCPServer::socketBindListen):
1142         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1143         * TestWebKitAPI/TCPServer.h: Added.
1144         (TestWebKitAPI::TCPServer::port const):
1145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1146         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1147         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1148         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1149         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1150         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1151         (TestWebKitAPI::respondSlowly):
1152         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1153         (TestWebKitAPI::downloadAtRate):
1154         (TestWebKitAPI::TEST):
1155
1156 2019-03-18  Saam Barati  <sbarati@apple.com>
1157
1158         Add a plan file for JetStream 2
1159         https://bugs.webkit.org/show_bug.cgi?id=190734
1160
1161         Reviewed by Mark Lam.
1162
1163         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1164
1165 2019-03-18  Chris Dumez  <cdumez@apple.com>
1166
1167         Delay WebProcess launch until a load is triggered in a Web view
1168         https://bugs.webkit.org/show_bug.cgi?id=195758
1169         <rdar://problem/48126013>
1170
1171         Reviewed by Geoff Garen.
1172
1173         Add API test coverage. Also update some existing API tests to not expect
1174         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1175
1176         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1177         (TestWebKitAPI::TEST):
1178         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1179         (TestWebKitAPI::TEST):
1180         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1181         (TEST):
1182         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1183         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1184         (TEST):
1185         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1186         (TEST):
1187         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1188
1189 2019-03-18  Xan Lopez  <xan@igalia.com>
1190
1191         [CMake] Prevent potential warning when determining $architecture
1192         https://bugs.webkit.org/show_bug.cgi?id=195891
1193
1194         Reviewed by Michael Catanzaro.
1195
1196         It's possible for generateBuildSystemForCMakeProject to be called
1197         before determineArchitecture() is ever called. This will make the
1198         first eq check with $architecture to be bogus (and print a
1199         warning). Change that to an eq check with architecture(), which
1200         implicitly calls determineArchitecture() if needed, and change all
1201         the other similar cases in the method in the same way to prevent
1202         future bugs like this one.
1203
1204         * Scripts/webkitdirs.pm:
1205         (generateBuildSystemFromCMakeProject):
1206
1207 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1208
1209         [WPE] Tarballs generated with “make dist” cannot build documentation
1210         https://bugs.webkit.org/show_bug.cgi?id=195885
1211
1212         Reviewed by Carlos Garcia Campos.
1213
1214         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1215
1216 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1217
1218         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1219         https://bugs.webkit.org/show_bug.cgi?id=195883
1220
1221         Reviewed by Carlos Garcia Campos.
1222
1223         * gtkdoc/gtkdoc.py:
1224         (GTKDoc._run_command): When commands fail to run, include the full command line for
1225         the program invocation and the output it has generated on the standard error stream.
1226
1227 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1228
1229         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1230         https://bugs.webkit.org/show_bug.cgi?id=195786
1231
1232         Reviewed by Philippe Normand.
1233
1234         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1235         * wpe/jhbuild.modules: Ditto.
1236
1237 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1238
1239         [ews-build] Don't run clean builds on EWS builders
1240         https://bugs.webkit.org/show_bug.cgi?id=195851
1241
1242         Reviewed by Geoffrey Garen.
1243
1244         * BuildSlaveSupport/ews-build/factories.py:
1245
1246 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1247
1248         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1249         https://bugs.webkit.org/show_bug.cgi?id=195849
1250
1251         Reviewed by Chris Dumez.
1252
1253         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1254
1255         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1256         (runWebsiteDataStoreCustomPaths):
1257
1258 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1259
1260         webkitpy: Upload test results
1261         https://bugs.webkit.org/show_bug.cgi?id=195755
1262         <rdar://problem/48896182>
1263
1264         Reviewed by Aakash Jain.
1265
1266         Establish a new format for uploading results that is not tied to layout tests, apply
1267         that format to webkitpy tests.
1268
1269         * Scripts/webkitpy/common/checkout/scm/git.py:
1270         (Git.native_branch): Return what branch the current checkout is on.
1271         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1272         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1273         * Scripts/webkitpy/common/checkout/scm/svn.py:
1274         (SVN.native_branch): Ditto.
1275         * Scripts/webkitpy/common/system/platforminfo.py:
1276         (PlatformInfo.build_version): Return a build version for Mac.
1277         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1278         (MockPlatformInfo.__init__):
1279         (MockPlatformInfo.build_version):
1280         * Scripts/webkitpy/results: Added.
1281         * Scripts/webkitpy/results/__init__.py: Added.
1282         * Scripts/webkitpy/results/options.py: Added.
1283         (upload_options): OptParse list for upload options.
1284         * Scripts/webkitpy/results/upload.py: Added.
1285         (Upload): Class which enforces the upload format expected by the results server.
1286         (Upload.Expectations):
1287         (Upload.create_configuration):
1288         (Upload.create_commit):
1289         (Upload.create_details):
1290         (Upload.create_run_stats):
1291         (Upload.create_test_result):
1292         (Upload.__init__):
1293         (Upload.Encoder): Encode Upload object as json.
1294         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1295         * Scripts/webkitpy/results/upload_unittest.py: Added.
1296         * Scripts/webkitpy/test/main.py:
1297         (Tester._parse_args): Add upload arguments.
1298         (Tester._run_tests): Allow results to be uploaded.
1299         * Scripts/webkitpy/test/runner.py:
1300         (Runner.__init__): Record which tests were run, rather than just counting them.
1301         (Runner.handle):
1302         * Scripts/webkitpy/test/runner_unittest.py:
1303         (RunnerTest.test_run):
1304         * Scripts/webkitpy/thirdparty/__init__.py:
1305         (AutoinstallImportHook.find_module): Add requests auto-install.
1306         (AutoinstallImportHook._install_requests):
1307         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1308         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1309
1310 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1311
1312         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1313         https://bugs.webkit.org/show_bug.cgi?id=195810
1314
1315         Reviewed by Tim Horton.
1316
1317         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1318         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1319         ending certain layout tests.
1320
1321         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1322         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1323         (-[TestRunnerWKWebView dealloc]):
1324         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1325
1326         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1327         helper method when destroying the web view, and when resetting state between tests.
1328
1329         * WebKitTestRunner/ios/TestControllerIOS.mm:
1330         (WTR::TestController::platformResetStateToConsistentValues):
1331
1332         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1333
1334 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1335
1336         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1337         https://bugs.webkit.org/show_bug.cgi?id=190350
1338         <rdar://problem/45089503>
1339
1340         Reviewed by Geoffrey Garen.
1341
1342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1343         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1344         (TEST):
1345         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1346         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1347         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1348         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1349         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1350         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1351         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1352         (runTest):
1353         (createDirectories):
1354         (TEST):
1355         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1356         (TEST):
1357         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1358         (TEST):
1359
1360 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1361
1362         Add support to WebPage for getting the contents as an attributed string.
1363         https://bugs.webkit.org/show_bug.cgi?id=195636
1364         rdar://problem/45055697
1365
1366         Reviewed by Tim Horton.
1367
1368         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1369         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1370
1371 2019-03-15  Chris Dumez  <cdumez@apple.com>
1372
1373         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1374         https://bugs.webkit.org/show_bug.cgi?id=195747
1375
1376         Reviewed by Geoff Garen.
1377
1378         Add API test coverage.
1379
1380         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1381
1382 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1383
1384         Unreviewed, rolling out r242952.
1385
1386         Causing API failures on iOS Simulator
1387
1388         Reverted changeset:
1389
1390         "[PSON] Make sure the WebProcessCache is leverage when
1391         relaunching a process after termination"
1392         https://bugs.webkit.org/show_bug.cgi?id=195747
1393         https://trac.webkit.org/changeset/242952
1394
1395 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1396
1397         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1398         https://bugs.webkit.org/show_bug.cgi?id=195740
1399
1400         Reviewed by Ross Kirsling.
1401
1402         window.open doesn't work for WebKitBrowserWindow because it is not
1403         implemented yet.
1404
1405         1. Implemented createNewPage callback of WKPageUIClient.
1406         2. Changed MainWindow to take a BrowserWindow factory function
1407           instead of BrowserWindowType to be flexible to create
1408           BrowserWindow with extra settings.
1409         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1410           because it is not relevant with MainWindow anymore.
1411
1412         * MiniBrowser/win/Common.cpp:
1413         (parseCommandLine):
1414         * MiniBrowser/win/Common.h:
1415         (CommandLineOptions::CommandLineOptions):
1416         * MiniBrowser/win/MainWindow.cpp:
1417         (MainWindow::MainWindow):
1418         (MainWindow::create):
1419         (MainWindow::init):
1420         (MainWindow::WndProc):
1421         * MiniBrowser/win/MainWindow.h:
1422         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1423         (PrintWebUIDelegate::createWebViewWithRequest):
1424         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1425         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1426         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1427         (WebKitBrowserWindow::updateProxySettings):
1428         (WebKitBrowserWindow::createNewPage):
1429         * MiniBrowser/win/WebKitBrowserWindow.h:
1430         * MiniBrowser/win/WinMain.cpp:
1431         (wWinMain):
1432
1433 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1434
1435         Make it possible to test scrolling tree layer manipulation more easily
1436         https://bugs.webkit.org/show_bug.cgi?id=195780
1437
1438         Reviewed by Tim Horton.
1439         
1440         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1441         cuts off communication of scrolling tree scrolls back to the web process
1442         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1443         allows tests to trigger scrolls which run the scrolling tree layer positioning
1444         logic, but never get another commit from the web process that might mask
1445         scrolling tree bugs.
1446         
1447         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1448         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1449         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1450
1451         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1452         (WTR::UIScriptController::scrollUpdatesDisabled const):
1453         (WTR::UIScriptController::setScrollUpdatesDisabled):
1454         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1455         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1456         (WTR::UIScriptController::scrollUpdatesDisabled const):
1457         (WTR::UIScriptController::setScrollUpdatesDisabled):
1458         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1459         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1460         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1461         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1462         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1463         * WebKitTestRunner/ios/TestControllerIOS.mm:
1464         (WTR::TestController::platformResetStateToConsistentValues):
1465         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1466         (WTR::UIScriptController::scrollUpdatesDisabled const):
1467         (WTR::UIScriptController::setScrollUpdatesDisabled):
1468
1469 2019-03-14  Youenn Fablet  <youenn@apple.com>
1470
1471         Move IDB storage in private browsing mode to NetworkProcess
1472         https://bugs.webkit.org/show_bug.cgi?id=195602
1473
1474         Reviewed by Brady Eidson.
1475
1476         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1477         (TEST):
1478
1479 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1480
1481         [ews-build] Make descriptionDone messages more readable
1482         https://bugs.webkit.org/show_bug.cgi?id=195760
1483
1484         Reviewed by Lucas Forschler.
1485
1486         * BuildSlaveSupport/ews-build/steps.py:
1487         * BuildSlaveSupport/ews-build/steps_unittest.py:
1488
1489 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1490
1491         [ews-build] Generate status-bubble hover-over messages
1492         https://bugs.webkit.org/show_bug.cgi?id=195680
1493
1494         Reviewed by Lucas Forschler.
1495
1496         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1497         (StatusBubble):
1498         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1499         on hover-over.
1500         (StatusBubble._iso_time):
1501         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1502         hover-over message.
1503         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1504
1505 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1506
1507         [ews-app] Gracefully handle the case when state_string is None
1508         https://bugs.webkit.org/show_bug.cgi?id=195753
1509
1510         Reviewed by Lucas Forschler.
1511
1512         * BuildSlaveSupport/ews-app/ews/models/build.py:
1513         * BuildSlaveSupport/ews-app/ews/models/step.py:
1514
1515 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1516
1517         [ews-app] Status bubble display pending for currently running build step
1518         https://bugs.webkit.org/show_bug.cgi?id=195744
1519
1520         Reviewed by Lucas Forschler.
1521
1522         * BuildSlaveSupport/ews-build/events.py:
1523         (Events.stepStarted): If state_string is pending, replace it with step name.
1524
1525 2019-03-14  Chris Dumez  <cdumez@apple.com>
1526
1527         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1528         https://bugs.webkit.org/show_bug.cgi?id=195750
1529
1530         Reviewed by Geoffrey Garen.
1531
1532         Add API test coverage.
1533
1534         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1535         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1536         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1537         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1538
1539 2019-03-14  Chris Dumez  <cdumez@apple.com>
1540
1541         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1542         https://bugs.webkit.org/show_bug.cgi?id=195747
1543
1544         Reviewed by Geoff Garen.
1545
1546         Add API test coverage.
1547
1548         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1549
1550 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1551
1552         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1553         https://bugs.webkit.org/show_bug.cgi?id=195725
1554         <rdar://problem/48545062>
1555
1556         Reviewed by Tim Horton.
1557
1558         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1559         handler is nil.
1560
1561         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1562         (TestWebKitAPI::TEST):
1563
1564 2019-03-13  Sam Weinig  <sam@webkit.org>
1565
1566         Add utility function to allow easy reverse range-based iteration of a container
1567         https://bugs.webkit.org/show_bug.cgi?id=195542
1568
1569         Reviewed by Antti Koivisto.
1570
1571         * TestWebKitAPI/CMakeLists.txt:
1572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1573         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1574         (TestWebKitAPI::TEST):
1575         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1576
1577 2019-03-13  Chris Dumez  <cdumez@apple.com>
1578
1579         Use a ServiceWorker process per registrable domain
1580         https://bugs.webkit.org/show_bug.cgi?id=195649
1581
1582         Reviewed by Youenn Fablet.
1583
1584         Update API test coverage.
1585
1586         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1587
1588 2019-03-13  Chris Dumez  <cdumez@apple.com>
1589
1590         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1591         https://bugs.webkit.org/show_bug.cgi?id=195684
1592         <rdar://problem/48294714>
1593
1594         Reviewed by Antti Koivisto.
1595
1596         Add API test coverage.
1597
1598         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1599
1600 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1601
1602         [ews-app] Remove unused patch view
1603         https://bugs.webkit.org/show_bug.cgi?id=195669
1604
1605         Reviewed by Lucas Forschler.
1606
1607         * BuildSlaveSupport/ews-app/ews/urls.py:
1608         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1609
1610 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1611
1612         [ews-app] Use Buildbot result code variables
1613         https://bugs.webkit.org/show_bug.cgi?id=195668
1614
1615         Reviewed by Alexey Proskuryakov.
1616
1617         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1618         (Buildbot): Added Buildbot result code variables.
1619         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1620         (StatusBubble._build_bubble): Used Buildbot result code variables.
1621
1622 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1623
1624         [Flatpak] Expand submodule recursively
1625         https://bugs.webkit.org/show_bug.cgi?id=195672
1626
1627         Building WPE with flatpak was impossible without that as it was raising an exception.
1628         Also update wpebackend-fdo to match what is built in jhbuild
1629
1630         Reviewed by Philippe Normand.
1631
1632         * flatpak/flatpakutils.py:
1633         (expand_submodules_recurse):
1634         (expand_manifest):
1635         * flatpak/org.webkit.WPEModules.yaml:
1636
1637 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1638
1639         [ews-app] status bubble should be hidden for certain builds
1640         https://bugs.webkit.org/show_bug.cgi?id=194597
1641
1642         Reviewed by Dewei Zhu.
1643
1644         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1645         (StatusBubble._build_bubble):
1646         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1647         because the patch didn't have relevant changes.
1648         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1649         in production yet.
1650
1651 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1652
1653         [Win] Fix a slew of simple clang-cl warnings.
1654         https://bugs.webkit.org/show_bug.cgi?id=195652
1655
1656         Reviewed by Don Olmstead.
1657
1658         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1659         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1660
1661 2019-03-12  Justin Fan  <justin_fan@apple.com>
1662
1663         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1664         https://bugs.webkit.org/show_bug.cgi?id=195518
1665         <rdar://problem/46322356>
1666
1667         Reviewed by Myles C. Maxfield.
1668
1669         * DumpRenderTree/DerivedSources-input.xcfilelist:
1670         * DumpRenderTree/DerivedSources-output.xcfilelist:
1671
1672 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1673
1674         Unreviewed, rolling out r242825.
1675         https://bugs.webkit.org/show_bug.cgi?id=195648
1676
1677         "Broke webkitpy tests with my change to
1678         lldb_dump_class_layout.py" (Requested by rmorisset on
1679         #webkit).
1680
1681         Reverted changeset:
1682
1683         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1684         classes with suspicious padding"
1685         https://bugs.webkit.org/show_bug.cgi?id=195573
1686         https://trac.webkit.org/changeset/242825
1687
1688 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1689
1690         [ews-build] Show status bubbles while the patch is waiting in queue
1691         https://bugs.webkit.org/show_bug.cgi?id=195618
1692
1693         Reviewed by Lucas Forschler.
1694
1695         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1696         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1697         enabled in initial deployment.
1698         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1699         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1700         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1701         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1702         (StatusBubble._build_bubbles_for_patch):
1703
1704 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1705
1706         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1707         https://bugs.webkit.org/show_bug.cgi?id=195573
1708
1709         Reviewed by Simon Fraser.
1710
1711         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1712
1713         * Scripts/dump-class-layout:
1714         (main):
1715         * lldb/lldb_dump_class_layout.py:
1716         (ClassLayout.__init__):
1717         (ClassLayout._compute_padding_recursive):
1718         (LLDBDebuggerInstance.dump_layout_for_classname):
1719         (LLDBDebuggerInstance):
1720         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1721         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1722
1723 2019-03-12  Chris Dumez  <cdumez@apple.com>
1724
1725         Device Orientation access permission should be denied unless explicitly granted by the client
1726         https://bugs.webkit.org/show_bug.cgi?id=195625
1727
1728         Reviewed by Youenn Fablet.
1729
1730         add API test coverage.
1731
1732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1733         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1734         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1735         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1736         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1737         (runDeviceOrientationTest):
1738         (TEST):
1739         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1740         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1741
1742 2019-03-12  Jer Noble  <jer.noble@apple.com>
1743
1744         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1745         https://bugs.webkit.org/show_bug.cgi?id=195137
1746         <rdar://problem/48810307>
1747
1748         Reviewed by Eric Carlson.
1749
1750         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1751         (TestWebKitAPI::TEST):
1752
1753 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1754
1755         [ews-build] Change urls from uat to production
1756         https://bugs.webkit.org/show_bug.cgi?id=195566
1757
1758         Reviewed by Lucas Forschler.
1759
1760         * BuildSlaveSupport/ews-app/ews/config.py:
1761         * BuildSlaveSupport/ews-build/events.py:
1762         * BuildSlaveSupport/ews-build/steps.py:
1763
1764 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1765
1766         [ews-build] change max_builds for local-worker to 1
1767         https://bugs.webkit.org/show_bug.cgi?id=195568
1768
1769         Reviewed by Lucas Forschler.
1770
1771         * BuildSlaveSupport/ews-build/loadConfig.py:
1772
1773 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1774
1775         Fix the build
1776
1777         * TestRunnerShared/spi/PencilKitTestSPI.h:
1778         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1779
1780 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1781
1782         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1783         https://bugs.webkit.org/show_bug.cgi?id=194131
1784
1785         Reviewed by Michael Catanzaro.
1786
1787         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1788         (uriChanged):
1789         (testUnfinishedSubresourceLoad):
1790         (serverCallback):
1791         (beforeAll):
1792
1793 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1794
1795         WTF::Expected should use std::addressof instead of operator&
1796         https://bugs.webkit.org/show_bug.cgi?id=195604
1797
1798         Reviewed by Myles Maxfield.
1799
1800         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1801         (TestWebKitAPI::Unique::Unique):
1802         (TestWebKitAPI::Unique::operator&):
1803         (TestWebKitAPI::TEST):
1804
1805 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
1806
1807         Add Optional to Forward.h.
1808         https://bugs.webkit.org/show_bug.cgi?id=195586
1809
1810         Reviewed by Darin Adler.
1811
1812         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
1813         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1814         Remove unnecessary includes from headers.
1815
1816 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
1817
1818         Add testing API to hit-test and scroll overflow scrollers
1819         https://bugs.webkit.org/show_bug.cgi?id=195278
1820
1821         Reviewed by Antti Koivisto.
1822         
1823         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
1824         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
1825         
1826         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
1827
1828         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1829         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1830         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1831         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1832         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1833         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1834         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1835         (WTR::enclosingScrollViewIncludingSelf):
1836         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1837
1838 2019-03-11  Tim Horton  <timothy_horton@apple.com>
1839
1840         API test WebKit.RequestTextInputContext fails on iOS
1841         https://bugs.webkit.org/show_bug.cgi?id=195585
1842
1843         Reviewed by Wenson Hsieh and Simon Fraser.
1844
1845         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1846         (applyStyle):
1847         (TEST):
1848         Add a viewport, so that the coordinates match up on iOS.
1849         Scroll by moving the UIScrollView's contentOffset.
1850
1851 2019-03-11  Chris Dumez  <cdumez@apple.com>
1852
1853         Assert in WebPageProxy::suspendCurrentPageIfPossible()
1854         https://bugs.webkit.org/show_bug.cgi?id=195506
1855         <rdar://problem/48733477>
1856
1857         Reviewed by Alex Christensen.
1858
1859         Add API test coverage.
1860
1861         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1862
1863 2019-03-11  Shawn Roberts  <sroberts@apple.com>
1864
1865         Adding myself to contributors.json
1866
1867         Unreviewed, addming myself to contributors.json .
1868
1869         * Scripts/webkitpy/common/config/contributors.json:
1870
1871 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1872
1873         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1874         https://bugs.webkit.org/show_bug.cgi?id=195511
1875         <rdar://problem/44873269>
1876
1877         Reviewed by Darin Adler.
1878
1879         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1880         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1881         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1882         (TEST_F):
1883
1884 2019-03-11  Chris Dumez  <cdumez@apple.com>
1885
1886         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
1887         https://bugs.webkit.org/show_bug.cgi?id=195561
1888
1889         Reviewed by Youenn Fablet.
1890
1891         Make sure the JS in the test requests for permission to receive device orientation events.
1892
1893         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1894
1895 2019-03-11  Youenn Fablet  <youenn@apple.com>
1896
1897         Allow storage quota increase by default in WTR
1898         https://bugs.webkit.org/show_bug.cgi?id=195541
1899
1900         Reviewed by Geoffrey Garen.
1901
1902         Allow storage quota increase by default in WTR.
1903         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
1904         Use this for tests that explicitly need cache increase.
1905
1906         Instead of increasing quota by 2, make sure the next request is
1907         granted by adding all given parameters.
1908
1909         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1910         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1911         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1912         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
1913         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1914         * WebKitTestRunner/TestController.cpp:
1915         (WTR::TestController::setAllowStorageQuotaIncrease):
1916         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1917         * WebKitTestRunner/TestController.h:
1918         * WebKitTestRunner/TestInvocation.cpp:
1919         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1920         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1921         (WTR::TestController::cocoaResetStateToConsistentValues):
1922         (WTR::TestController::setAllowStorageQuotaIncrease):
1923         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1924         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1925         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1926
1927 2019-03-11  Xan Lopez  <xan@igalia.com>
1928
1929         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
1930         https://bugs.webkit.org/show_bug.cgi?id=194147
1931
1932         Reviewed by Michael Saboff.
1933
1934         To make --32-bit work correctly on Linux/64bit we need to:
1935
1936         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
1937         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
1938         unfortunately CMake only allows us to do this during
1939         crosscompilation, which is overkill here.
1940         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
1941         pkg-config detection module uses the x86 .pc files instead of the
1942         x86_64 ones.
1943         - Set the -m32 flags for the compiler.
1944
1945         * Scripts/webkitdirs.pm:
1946         (generateBuildSystemFromCMakeProject):
1947
1948 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
1949
1950         Add MotionMark-1.1 plan file for run-benchmark script.
1951         https://bugs.webkit.org/show_bug.cgi?id=195481
1952
1953         Rubber-stamped by Darin Adler.
1954
1955         Run-benchmark script should support MontionMark-1.1.
1956
1957         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
1958
1959 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1960
1961         [ews-app] Add support for submit-to-ews url
1962         https://bugs.webkit.org/show_bug.cgi?id=195477
1963
1964         Reviewed by Lucas Forschler.
1965
1966         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1967         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1968         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
1969         * BuildSlaveSupport/ews-app/ews/urls.py:
1970         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
1971
1972 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
1973
1974         Unreviewed, rolling out r242688, r242643, r242624.
1975
1976         Caused multiple layout test failures and crashes on iOS and macOS.
1977
1978         Reverted changeset:
1979
1980         "requestAnimationFrame should execute before the next frame"
1981         https://bugs.webkit.org/show_bug.cgi?id=177484
1982         https://trac.webkit.org/changeset/242624/webkit
1983
1984         * Tracing/SystemTracePoints.plist:
1985
1986 2019-03-11  John Wilander  <wilander@apple.com>
1987
1988         Resource Load Statistics: Make it possible exclude localhost from classification
1989         https://bugs.webkit.org/show_bug.cgi?id=195474
1990         <rdar://problem/47520577>
1991
1992         Reviewed by Brent Fulgham.
1993
1994         This patch allows for localhost to be excluded from classification and
1995         treatment as a prevalent resource.
1996
1997         The WebKit Tools change adds a new function called
1998         testRunner.setStatisticsIsRunningTest() which can be used to control this
1999         behavior.
2000
2001         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2002         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2003         (WTR::TestRunner::setStatisticsIsRunningTest):
2004         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2005         * WebKitTestRunner/TestController.cpp:
2006         (WTR::TestController::setStatisticsIsRunningTest):
2007         * WebKitTestRunner/TestController.h:
2008         * WebKitTestRunner/TestInvocation.cpp:
2009         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2010
2011 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2012
2013         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2014         https://bugs.webkit.org/show_bug.cgi?id=195560
2015
2016         Reviewed by Lucas Forschler.
2017
2018         * BuildSlaveSupport/ews-build/master.cfg:
2019
2020 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2021
2022         Unreviewed, rolling out r242698.
2023
2024         API test crashes on bots.
2025
2026         Reverted changeset:
2027
2028         "Add a WKContentRuleList variant that uses copied memory
2029         instead of mmap'd shared memory for class A containerized
2030         apps"
2031         https://bugs.webkit.org/show_bug.cgi?id=195511
2032         https://trac.webkit.org/changeset/242698
2033
2034 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2035
2036         [WPE] Enable web process sandbox
2037         https://bugs.webkit.org/show_bug.cgi?id=195169
2038
2039         Reviewed by Daniel Bates.
2040
2041         * wpe/install-dependencies:
2042         * wpe/jhbuild.modules:
2043
2044 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2045
2046         [ews-app] Use port 17000 for worker communication
2047         https://bugs.webkit.org/show_bug.cgi?id=195558
2048
2049         Reviewed by Lucas Forschler.
2050
2051         * BuildSlaveSupport/ews-build/master.cfg:
2052
2053 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2054
2055         [ews-build] unit-tests fail when passwords.json is missing
2056         https://bugs.webkit.org/show_bug.cgi?id=195557
2057
2058         Reviewed by Lucas Forschler.
2059
2060         * BuildSlaveSupport/ews-build/loadConfig.py:
2061         (loadBuilderConfig):
2062         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2063         (ConfigDotJSONTest.test_configuration):
2064         * BuildSlaveSupport/ews-build/master.cfg:
2065
2066 2019-03-11  Truitt Savell  <tsavell@apple.com>
2067
2068         Unreviewed, rolling out r242702.
2069
2070         Broke High Sierra builders.
2071
2072         Reverted changeset:
2073
2074         "Add utility function to allow easy reverse range-based
2075         iteration of a container"
2076         https://bugs.webkit.org/show_bug.cgi?id=195542
2077         https://trac.webkit.org/changeset/242702
2078
2079 2019-03-11  Sam Weinig  <sam@webkit.org>
2080
2081         Add utility function to allow easy reverse range-based iteration of a container
2082         https://bugs.webkit.org/show_bug.cgi?id=195542
2083
2084         Reviewed by Antti Koivisto.
2085
2086         * TestWebKitAPI/CMakeLists.txt:
2087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2088         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2089         (TestWebKitAPI::TEST):
2090         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2091
2092 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2093
2094         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2095         https://bugs.webkit.org/show_bug.cgi?id=195511
2096         <rdar://problem/44873269>
2097
2098         Reviewed by Darin Adler.
2099
2100         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2101         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2102         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2103         (TEST_F):
2104
2105 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2106
2107         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2108         https://bugs.webkit.org/show_bug.cgi?id=195499
2109
2110         Reviewed by Darin Adler.
2111
2112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2113         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2114         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2115         (-[WKWebView synchronouslyFocusTextInputContext:]):
2116         (applyStyle):
2117         (applyIframe):
2118         (TEST):
2119         Add some tests for this SPI.
2120
2121 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2122
2123         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2124         https://bugs.webkit.org/show_bug.cgi?id=181151
2125
2126         Reviewed by Don Olmstead.
2127
2128         * TestWebKitAPI/CMakeLists.txt:
2129         * TestWebKitAPI/PlatformWin.cmake:
2130         Enable TestWTF RunLoop tests in all platforms.
2131
2132         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2133         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2134         (TestWebKitAPI::DerivedOneShotTimer::fired):
2135         (TestWebKitAPI::TEST):
2136         Only a few platforms support nested RunLoop.
2137
2138         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2139         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2140
2141 2019-03-10  David Quesada  <david_quesada@apple.com>
2142
2143         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2144         https://bugs.webkit.org/show_bug.cgi?id=152480
2145
2146         Reviewed by Chris Dumez.
2147
2148         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2149         there are no additional references to the process pool besides the one held by
2150         the download, waits for the download to finish (in the sense that the
2151         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2152         measure, also check that the process pool has been deallocated at the end of the
2153         test. The test wouldn't be meaningful if the process pool were still alive.
2154
2155         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2156         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2157         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2158             The download will be canceled because the delegate does not implement the
2159             method to decide the download's destination, so this is where we know the
2160             DownloadProxyMap is done with the DownloadProxy.
2161         (TEST):
2162
2163 2019-03-08  Chris Dumez  <cdumez@apple.com>
2164
2165         Add support for Device Orientation / Motion permission API
2166         https://bugs.webkit.org/show_bug.cgi?id=195329
2167         <rdar://problem/47645367>
2168
2169         Reviewed by Geoffrey Garen.
2170
2171         Add test infrastructure to help test the Device Orientation / Motion permission API.
2172
2173         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2174         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2175         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2176         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2177         * WebKitTestRunner/TestController.cpp:
2178         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2179         (WTR::TestController::createWebViewWithOptions):
2180         (WTR::TestController::resetStateToConsistentValues):
2181         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2182         * WebKitTestRunner/TestController.h:
2183         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2184         * WebKitTestRunner/TestInvocation.cpp:
2185         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2186
2187 2019-03-08  Saam barati  <sbarati@apple.com>
2188
2189         Add a compare-results script to compare benchmark results
2190         https://bugs.webkit.org/show_bug.cgi?id=195486
2191         <rdar://problem/48723397>
2192
2193         Reviewed by Geoffrey Garen.
2194
2195         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2196         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2197         to extend it to learn about our other benchmarks.
2198
2199         * Scripts/compare-results: Added.
2200         (readJSONFile):
2201         (detectJetStream2):
2202         (JetStream2Results):
2203         (detectSpeedometer2):
2204         (Speedometer2Results):
2205         (detectPLT5):
2206         (PLT5Results):
2207         (detectBenchmark):
2208         (biggerIsBetter):
2209         (ttest):
2210         (getOptions):
2211         (main):
2212
2213 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2214
2215         Ensure old tab state is cleared between iterations of run-benchmark
2216         https://bugs.webkit.org/show_bug.cgi?id=195393
2217         <rdar://problem/46885583>
2218
2219         Reviewed by Dewei Zhu.
2220
2221         a) ensure the default to restore state is not set
2222         b) terminate Safari correctly
2223         c) Set the system default to ignore Persistent State in Safari
2224
2225         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2226         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2227         (OSXBrowserDriver.prepare_env): 
2228         (OSXBrowserDriver.restore_env):
2229         (OSXBrowserDriver.close_browsers):
2230         (OSXBrowserDriver._terminate_processes):
2231         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2232         (OSXChromeDriver):
2233         (OSXChromeCanaryDriver):
2234         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2235         (OSXFirefoxDriver):
2236         (OSXFirefoxNightlyDriver):
2237         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2238         (OSXSafariDriver):
2239         (OSXSafariDriver.prepare_env):
2240
2241 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2242
2243         [GTK] Several InputMethodFilter tests are failing
2244         https://bugs.webkit.org/show_bug.cgi?id=195408
2245
2246         Reviewed by Carlos Garcia Campos.
2247
2248         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2249         Regressed in r241751.
2250         Hexadecimal values of keycodes are expressed now in upper letters.
2251         Composited characters should be cast to UTF8 strings.
2252
2253         (TestWebKitAPI::TEST):
2254
2255 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2256
2257         [GTK] Make Tools/gtkdoc python3 compatible
2258         https://bugs.webkit.org/show_bug.cgi?id=195359
2259
2260         Reviewed by Carlos Garcia Campos.
2261
2262         * gtkdoc/generate-gtkdoc:
2263         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2264         work with Python 2 and 3.
2265         (get_gtkdoc_module_paths):
2266         The iteritems() was removed in Python 3, so let's use items() that's
2267         available in Python 2 and 3.
2268         (get_generator_for_config):
2269         * gtkdoc/gtkdoc.py:
2270         (GTKDoc._run_command):
2271         The sys.stdout.write() is expecting str in Python 3 and not bytes
2272         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2273         for passing the bytes there.
2274
2275 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2276
2277         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2278         https://bugs.webkit.org/show_bug.cgi?id=195346
2279         <rdar://problem/48667048>
2280
2281         Unreviewed build fix for clang-cl.
2282
2283         * DumpRenderTree/win/DumpRenderTree.cpp:
2284         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2285
2286 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2287
2288         requestAnimationFrame should execute before the next frame
2289         https://bugs.webkit.org/show_bug.cgi?id=177484
2290
2291         Reviewed by Simon Fraser.
2292
2293         Add trace points for the page RenderingUpdate.
2294
2295         * Tracing/SystemTracePoints.plist:
2296
2297 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2298
2299         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2300         https://bugs.webkit.org/show_bug.cgi?id=195353
2301         <rdar://problem/48626394>
2302
2303         Reviewed by Simon Fraser.
2304
2305         * WebKitTestRunner/ios/TestControllerIOS.mm:
2306         (WTR::TestController::platformResetPreferencesToConsistentValues):
2307
2308 2019-03-07  John Wilander  <wilander@apple.com>
2309
2310         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2311         https://bugs.webkit.org/show_bug.cgi?id=195383
2312         <rdar://problem/48570136>
2313
2314         Reviewed by Brent Fulgham.
2315
2316         This patch adds test infrastructure to purge only script-accessible cookies,
2317         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2318
2319         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2320         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2321         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2322         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2323         * WebKitTestRunner/TestController.cpp:
2324         (WTR::TestController::statisticsDeleteCookiesForHost):
2325         * WebKitTestRunner/TestController.h:
2326         * WebKitTestRunner/TestInvocation.cpp:
2327         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2328
2329 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2330
2331         Unreviewed, rolling out r242354.
2332         https://bugs.webkit.org/show_bug.cgi?id=195402
2333
2334         breaks layout tests in all configurations (Requested by
2335         zdobersek on #webkit).
2336
2337         Reverted changeset:
2338
2339         "[WPE] Enable web process sandbox"
2340         https://bugs.webkit.org/show_bug.cgi?id=195169
2341         https://trac.webkit.org/changeset/242354
2342
2343 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2344
2345         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2346         https://bugs.webkit.org/show_bug.cgi?id=195346
2347
2348         Reviewed by Fujii Hironori.
2349
2350         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2351         (TestWebKitAPI::TEST):
2352         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2353
2354         * DumpRenderTree/win/DumpRenderTree.cpp:
2355         (findFontFallback):
2356         (addFontFallbackIfPresent):
2357         (removeFontFallbackIfPresent):
2358         (main):
2359         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2360         (TestWebKitAPI::Util::moduleDirectory):
2361         (TestWebKitAPI::Util::createInjectedBundlePath):
2362         Use wchar helpers as needed.
2363
2364 2019-03-06  Rob Buis  <rbuis@igalia.com>
2365
2366         Consider supporting the `referrerpolicy` attribute.
2367         https://bugs.webkit.org/show_bug.cgi?id=179053
2368
2369         Reviewed by Darin Adler.
2370
2371         Add a runtime flag for referrerpolicy attribute.
2372
2373         * DumpRenderTree/mac/DumpRenderTree.mm:
2374         (enableExperimentalFeatures):
2375
2376 2019-03-05  Daniel Bates  <dabates@apple.com>
2377
2378         Update expected API test result following r242379
2379         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2380
2381         Update expected x-coordinate of selection rect now that the left padding of
2382         a textarea is sized in ems (so dependent on the font size) just like the left
2383         padding of a text field.
2384
2385         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2386         (TestWebKitAPI::TEST):
2387
2388 2019-03-05  David Quesada  <david_quesada@apple.com>
2389
2390         [WK2] It should be possible to follow links with 'download' attributes
2391         https://bugs.webkit.org/show_bug.cgi?id=195145
2392         rdar://problem/48462642
2393
2394         Reviewed by Alex Christensen.
2395
2396         Add a unit test to verify that activating links with 'download' attributes now
2397         navigates to the linked resource, rather than starts downloading it. Add another
2398         to verify that it is still possible to explicitly download the link via the
2399         'Download' navigation action policy.
2400
2401         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2402         (-[DownloadAttributeTestDelegate init]):
2403         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2404         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2405         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2406         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2407         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2408         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2409         (TEST):
2410         * WebKitTestRunner/TestController.cpp:
2411         (WTR::TestController::decidePolicyForNavigationAction):
2412         * WebKitTestRunner/TestController.h:
2413
2414 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2415
2416         [Curl] Implement Cookie Accept Policy.
2417         https://bugs.webkit.org/show_bug.cgi?id=191645
2418
2419         Reviewed by Fujii Hironori.
2420
2421         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2422         (TestWebKitAPI::Curl::TEST_F):
2423
2424 2019-03-05  Youenn Fablet  <youenn@apple.com>
2425
2426         Rename requestCacheStorageSpace to requestStorageSpace
2427         https://bugs.webkit.org/show_bug.cgi?id=195282
2428
2429         Reviewed by Chris Dumez.
2430
2431         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2432         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2433         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2434
2435 2019-03-05  Brady Eidson  <beidson@apple.com>
2436
2437         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2438         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2439
2440         Reviewed by Tim Horton.
2441
2442         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2443         different directory into that same WKWebView should work.
2444
2445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2446         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2447
2448 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2449
2450         Add WeakHashSet
2451         https://bugs.webkit.org/show_bug.cgi?id=195152
2452
2453         Reviewed by Antti Koivisto.
2454
2455         Added tests for WeakHashSet.
2456
2457         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2458         (TestWebKitAPI::Base::Base): Moved.
2459         (TestWebKitAPI::Derived::foo): Moved.
2460         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2461         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2462         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2463         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2464
2465 2019-03-04  Chris Dumez  <cdumez@apple.com>
2466
2467         Do not share WebProcesses between private and regular sessions
2468         https://bugs.webkit.org/show_bug.cgi?id=195189
2469         <rdar://problem/48421064>
2470
2471         Reviewed by Alex Christensen.
2472
2473         Add API test coverage.
2474
2475         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2476         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2477
2478 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2479
2480         [WPE] Enable web process sandbox
2481         https://bugs.webkit.org/show_bug.cgi?id=195169
2482
2483         Reviewed by Daniel Bates.
2484
2485         * wpe/install-dependencies:
2486         * wpe/jhbuild.modules:
2487
2488 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2489
2490         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2491         https://bugs.webkit.org/show_bug.cgi?id=195206
2492
2493         Reviewed by Žan Doberšek.
2494
2495         Add a new test case.
2496
2497         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2498         (testJSCClass):
2499
2500 2019-03-04  Charlie Turner  <cturner@igalia.com>
2501
2502         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2503         https://bugs.webkit.org/show_bug.cgi?id=194898
2504
2505         Reviewed by Žan Doberšek.
2506
2507         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2508         a GCC extension that permits arithmetic on void* pointer. Inline
2509         the macro until this issue is fixed upstream.
2510
2511 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2512
2513         Rid the world of WK_API_ENABLED
2514         https://bugs.webkit.org/show_bug.cgi?id=195263
2515
2516         Reviewed by Dan Bernstein.
2517
2518         List of changed files elided because it's useless.
2519
2520 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2521
2522         Unreviewed follow-up to r242292.
2523
2524         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2525
2526         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2527         (TestWebKitAPI::testStrip): Renamed from strip.
2528         (TestWebKitAPI::TEST):
2529
2530 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2531
2532         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2533
2534         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2535         and bug #194272 for details.
2536
2537         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2538
2539 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2540
2541         Remove some more unused 32-bit code
2542         https://bugs.webkit.org/show_bug.cgi?id=195255
2543
2544         Reviewed by Darin Adler.
2545
2546         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2547         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2548         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2549         (NPP_New):
2550         (NPP_HandleEvent):
2551         (handleEventCarbon): Deleted.
2552
2553 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2554
2555         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2556
2557         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2558         (TestWebKitAPI::TEST):
2559
2560 2019-03-01  Darin Adler  <darin@apple.com>
2561
2562         Finish removing String::format
2563         https://bugs.webkit.org/show_bug.cgi?id=194893
2564
2565         Reviewed by Daniel Bates.
2566 '
2567         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2568
2569 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2570
2571         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2572         https://bugs.webkit.org/show_bug.cgi?id=195229
2573         <rdar://problem/48520362>
2574
2575         Reviewed by Chris Dumez.
2576
2577         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2578         (TEST):
2579
2580 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2581
2582         Add a system trace scope for event region building
2583         https://bugs.webkit.org/show_bug.cgi?id=195226
2584
2585         Reviewed by Jon Lee.
2586
2587         This trace scope measures the time spend converting element rects into Region objects,
2588         which can be large on some pages.
2589
2590         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2591
2592         * Tracing/SystemTracePoints.plist:
2593
2594 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2595
2596         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2597         https://bugs.webkit.org/show_bug.cgi?id=194612
2598
2599         Reviewed by Alex Christensen.
2600
2601         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2602         Just test the new string-processing function and don't touch the actual environment.
2603         (Test cases are all as before, but based on operator== instead of strcmp.)
2604
2605 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2606
2607         [ews-app] Update primary keys for handling multiple Buildbot instances
2608         https://bugs.webkit.org/show_bug.cgi?id=195120
2609
2610         Reviewed by Stephanie Lewis.
2611
2612         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2613         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2614         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2615
2616         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2617         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2618         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2619         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2620         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2621         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2622
2623 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2624
2625         [WinCairo] Enable service worker
2626         https://bugs.webkit.org/show_bug.cgi?id=188318
2627
2628         Reviewed by Youenn Fablet.
2629
2630         * DumpRenderTree/DumpRenderTreePrefix.h:
2631         * TestWebKitAPI/PlatformWin.cmake:
2632         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2633         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2634         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2635
2636 2019-03-01  Justin Fan  <justin_fan@apple.com>
2637
2638         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2639         https://bugs.webkit.org/show_bug.cgi?id=195191
2640
2641         Rubber-stamped by Dean Jackson.
2642
2643         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2644
2645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2646
2647 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2648
2649         Unreviewed, fix lldb webkitpy tests
2650         https://bugs.webkit.org/show_bug.cgi?id=194375
2651
2652         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2653
2654         * lldb/lldb_webkit.py:
2655         (WTFStringImplProvider.is_8bit):
2656
2657 2019-02-28  David Quesada  <david_quesada@apple.com>
2658
2659         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2660         https://bugs.webkit.org/show_bug.cgi?id=195121
2661         rdar://problem/48450302
2662
2663         Reviewed by Alex Christensen.
2664
2665         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2666         configurations where the 'download' attribute is absent, blank, or populated
2667         with a filename, and where the anchor element is same-origin or cross-origin
2668         (meaning the 'download' attribute shouldn't be honored).
2669
2670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2671         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2672         (-[NavigationActionTestDelegate init]):
2673         (-[NavigationActionTestDelegate navigationAction]):
2674         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2675         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2676         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2677         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2678         (TEST):
2679
2680 2019-02-28  Antoine Quint  <graouts@apple.com>
2681
2682         Enable the Pointer Events runtime flag by default
2683         https://bugs.webkit.org/show_bug.cgi?id=195156
2684
2685         Reviewed by Dean Jackson.
2686
2687         * DumpRenderTree/mac/DumpRenderTree.mm:
2688         (enableExperimentalFeatures):
2689
2690 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2691
2692         Several PasteImage API tests are flaky
2693         https://bugs.webkit.org/show_bug.cgi?id=195160
2694
2695         Reviewed by Tim Horton.
2696
2697         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2698         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2699         listening for a "load" event after image load is already complete.
2700
2701         To address this, make these tests first register a "load" event handler, then run script to insert an image
2702         element into the document, and finally wait until the load event is observed before checking image size.
2703
2704         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2705
2706 2019-02-28  Chris Dumez  <cdumez@apple.com>
2707
2708         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2709         https://bugs.webkit.org/show_bug.cgi?id=195107
2710
2711         Reviewed by Alex Christensen.
2712
2713         Give some time for the zoom level to get restored.
2714
2715         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2716
2717 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2718
2719         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2720         https://bugs.webkit.org/show_bug.cgi?id=194958
2721
2722         Reviewed by Geoffrey Garen.
2723
2724         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2725         (TEST):
2726
2727 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2728
2729         [ews-app] Update method to save build to handle builder_display_name
2730         https://bugs.webkit.org/show_bug.cgi?id=195047
2731
2732         Reviewed by Dewei Zhu.
2733
2734         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2735         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2736
2737 2019-02-28  Justin Fan  <justin_fan@apple.com>
2738
2739         [Web GPU] Enable Web GPU only on 64-bit
2740         https://bugs.webkit.org/show_bug.cgi?id=195139
2741
2742         Because Metal is only supported on 64 bit apps.
2743
2744         Unreviewed build fix.
2745
2746         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2747
2748 2019-02-27  Youenn Fablet  <youenn@apple.com>
2749
2750         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2751         https://bugs.webkit.org/show_bug.cgi?id=194959
2752
2753         Reviewed by Chris Dumez.
2754
2755         Spin loop until getting the condition to remove flakiness.
2756
2757         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2758
2759 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2760
2761         [ews-build] Buildbot should include builder_display_name in the build events
2762         https://bugs.webkit.org/show_bug.cgi?id=195045
2763
2764         Reviewed by Dewei Zhu.
2765
2766         * BuildSlaveSupport/ews-build/events.py:
2767         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2768         buildername to builder_name to be consistent in naming style.
2769         (Events.buildFinished): Ditto.
2770
2771 2019-02-27  Chris Dumez  <cdumez@apple.com>
2772
2773         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2774         https://bugs.webkit.org/show_bug.cgi?id=194480
2775
2776         Reviewed by Brady Eidson.
2777
2778         Update existing API test to make it more likely to reproduce the issue.
2779
2780         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2781
2782 2019-02-27  Brady Eidson  <beidson@apple.com>
2783
2784         Universal links from Google search results pages don't open the app.
2785         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2786
2787         Reviewed by Geoffrey Garen.
2788
2789         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2790         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2791         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2792         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2793
2794 2019-02-27  Chris Dumez  <cdumez@apple.com>
2795
2796         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2797         https://bugs.webkit.org/show_bug.cgi?id=195102
2798
2799         Reviewed by Geoffrey Garen.
2800
2801         If the number of processes is not yet what we expect, wait a bit and check again to give
2802         processes some time to exit.
2803
2804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2805
2806 2019-02-27  Chris Dumez  <cdumez@apple.com>
2807
2808         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
2809         https://bugs.webkit.org/show_bug.cgi?id=194545
2810
2811         Reviewed by Brady Eidson.
2812
2813         Make sure the test navigates forward and then back only once. Previously, navigating
2814         back would trigger a navigation again in a timer.
2815
2816         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2817
2818 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2819
2820         High Sierra Debug JSC test queue should use faster hardware
2821         https://bugs.webkit.org/show_bug.cgi?id=194603
2822
2823         Rubber-stamped by Alexey Proskuryakov.
2824
2825         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
2826
2827         * BuildSlaveSupport/build.webkit.org-config/config.json:
2828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2829         (BubbleQueueServer):
2830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2831         (WebKitBuildbot):
2832         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2833         * QueueStatusServer/config/queues.py:
2834         * Scripts/webkitpy/common/config/ews.json:
2835         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2836         (test_ews_name):
2837
2838 2019-02-27  John Wilander  <wilander@apple.com>
2839
2840         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
2841         https://bugs.webkit.org/show_bug.cgi?id=195071
2842         <rdar://problem/48417690>
2843
2844         Reviewed by Alex Christensen and Brent Fulgham.
2845
2846         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2847         (TestWebKitAPI::createURL):
2848             Convenience function.
2849         (TestWebKitAPI::TEST):
2850             WebCore::AdClickAttribution now takes a URL when creating Source and
2851             Destination.
2852         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2853         (TestWebKitAPI::TEST):
2854             WebCore::AdClickAttribution now takes a URL when creating Source and
2855             Destination.
2856
2857 2019-02-27  Antoine Quint  <graouts@apple.com>
2858
2859         Support Pointer Events on macOS
2860         https://bugs.webkit.org/show_bug.cgi?id=195008
2861         <rdar://problem/47454419>
2862
2863         Reviewed by Dean Jackson.
2864
2865         * DumpRenderTree/mac/DumpRenderTree.mm:
2866         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
2867         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2868
2869 2019-02-26  Mark Lam  <mark.lam@apple.com>
2870
2871         Remove remaining poisoning code.
2872         https://bugs.webkit.org/show_bug.cgi?id=194138
2873
2874         Reviewed by Saam Barati.
2875
2876         * TestWebKitAPI/CMakeLists.txt:
2877         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2878         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
2879         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
2880         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
2881         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
2882         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
2883         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
2884
2885 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2886
2887         Move ephemeral local storage from WebProcess to UIProcess
2888         https://bugs.webkit.org/show_bug.cgi?id=195074
2889         <rdar://problem/47937975>
2890
2891         Reviewed by Geoff Garen.
2892
2893         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2894
2895 2019-02-20  Jer Noble  <jer.noble@apple.com>
2896
2897         [Cocoa] Media elements will restart network buffering just before suspending
2898         https://bugs.webkit.org/show_bug.cgi?id=193691
2899
2900         Reviewed by Eric Carlson.
2901
2902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2903         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2904         (TEST):
2905
2906 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
2907
2908         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
2909         https://bugs.webkit.org/show_bug.cgi?id=191652
2910
2911         Reviewed by Alex Christensen.
2912
2913         Fix WinCairo MiniBrowser behavior of authentication dialog.
2914
2915         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2916         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2917
2918 2019-02-26  Youenn Fablet  <youenn@apple.com>
2919
2920         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
2921         https://bugs.webkit.org/show_bug.cgi?id=195028
2922         <rdar://problem/48243733>
2923
2924         Reviewed by Eric Carlson.
2925
2926         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2927
2928 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2929
2930         [WPE] Add API for webview background color configuration
2931         https://bugs.webkit.org/show_bug.cgi?id=192305
2932
2933         Reviewed by Michael Catanzaro.
2934
2935         * MiniBrowser/wpe/main.cpp:
2936         (main): Add a new option to configure the webview background
2937         color. Example: --bg-color=transparent.
2938         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2939         (testWebViewBackgroundColor): Enable background color API tests for WPE.
2940         (beforeAll): Ditto.
2941
2942 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2943
2944         scalableNativeWebpageParameters() is not preserved on new page navigation.
2945         https://bugs.webkit.org/show_bug.cgi?id=194892
2946         <rdar://problem/47538280>
2947
2948         Reviewed by Wenson Hsieh.
2949         
2950         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
2951
2952         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2953         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2954         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2955         (WTR::UIScriptController::allowsViewportShrinkToFit):
2956         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2957         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2958         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2959         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2960         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2961         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2962
2963 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2964
2965         [ews-app] Add model for handling multiple Buildbot instances
2966         https://bugs.webkit.org/show_bug.cgi?id=194863
2967
2968         Reviewed by Stephanie Lewis.
2969
2970         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
2971
2972 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2973
2974         [ews-app] Remove BuilderMapping table
2975         https://bugs.webkit.org/show_bug.cgi?id=194961
2976
2977         Reviewed by Stephanie Lewis.
2978
2979         Store builder name directly in build table, instead of having a separate
2980         table for it.
2981
2982         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2983         * BuildSlaveSupport/ews-app/ews/models/build.py:
2984         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
2985         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2986
2987 2019-02-25  John Wilander  <wilander@apple.com>
2988
2989         Introduce and adopt new class RegistrableDomain for eTLD+1
2990         https://bugs.webkit.org/show_bug.cgi?id=194791
2991         <rdar://problem/48179240>
2992
2993         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
2994
2995         This patch adds an API test and replaces two instances of
2996         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
2997
2998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2999         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3000         (TestWebKitAPI::TEST):
3001             Changed two strings to make sure the registrable domains are still considered
3002             invalid and pass the test.
3003         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3004         (TestWebKitAPI::TEST):
3005         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3006         (WTR::InjectedBundle::didReceiveMessageToPage):
3007
3008 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3009
3010         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3011         https://bugs.webkit.org/show_bug.cgi?id=195001
3012
3013         Reviewed by Carlos Garcia Campos.
3014
3015         API version 1.0 always includes the functionality previously guarded with
3016         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3017         unconditionally.
3018
3019         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3020         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3021         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3022         (WebViewTest::showInWindow): Ditto.
3023         (WebViewTest::hideView): Ditto.
3024         * wpe/backends/HeadlessViewBackend.cpp:
3025         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3026         * wpe/backends/ViewBackend.cpp:
3027         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3028         * wpe/backends/WindowViewBackend.cpp:
3029         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3030         WPE_BACKEND_CHECK_VERSION().
3031         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3032
3033 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3034
3035         [Flatpak] Add support for flatpak > 1.1.2
3036         https://bugs.webkit.org/show_bug.cgi?id=194088
3037
3038         Flatpak 1.2 is now out so we need to support that
3039         version now.
3040
3041         Reviewed by Michael Catanzaro.
3042
3043         * flatpak/flatpakutils.py:
3044         (check_flatpak):
3045         (FlatpakPackages.__init__):
3046         (FlatpakPackages.__detect_packages):
3047         (FlatpakPackages.__detect_packages.in):
3048         (FlatpakRepos.update):
3049
3050 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3051
3052         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3053         https://bugs.webkit.org/show_bug.cgi?id=194998
3054
3055         Reviewed by Carlos Garcia Campos.
3056
3057         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3058         to a Git checkout and using the latest commit containing various fixes
3059         and improvements.
3060
3061 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3062
3063         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3064         https://bugs.webkit.org/show_bug.cgi?id=194981
3065
3066         Reviewed by Žan Doberšek.
3067
3068         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3069         (TestWebKitAPI::TEST):
3070
3071 2019-02-23  Keith Miller  <keith_miller@apple.com>
3072
3073         Add new mac target numbers
3074         https://bugs.webkit.org/show_bug.cgi?id=194955
3075
3076         Reviewed by Tim Horton.
3077
3078         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3079         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3080         * MiniBrowser/Configurations/Base.xcconfig:
3081         * TestWebKitAPI/Configurations/Base.xcconfig:
3082         * WebKitTestRunner/Configurations/Base.xcconfig:
3083
3084 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3085
3086         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3087         https://bugs.webkit.org/show_bug.cgi?id=194846
3088
3089         Reviewed by Don Olmstead.
3090
3091         Added _search_paths() and _port_specific_expectations_files() for
3092         WinCairoPort.
3093
3094         * Scripts/webkitpy/port/win.py:
3095         (WinCairoPort.default_baseline_search_path):
3096         (WinCairoPort):
3097         (WinCairoPort._port_specific_expectations_files):
3098         (WinCairoPort._search_paths):
3099
3100 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3101
3102         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3103         https://bugs.webkit.org/show_bug.cgi?id=194963
3104
3105         Reviewed by Dean Jackson.
3106
3107         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3108         Do a `contains` check instead of `equals`, because in debug builds we
3109         put the GraphicsLayer pointer in a prefix.
3110
3111 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3112
3113         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3114         https://bugs.webkit.org/show_bug.cgi?id=194873
3115         <rdar://problem/46701974>
3116
3117         Reviewed by Tim Horton.
3118
3119         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3120
3121         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3122         (WTR::UIScriptController::menuRect const):
3123         (WTR::UIScriptController::isShowingMenu const):
3124         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3125         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3126         (WTR::UIScriptController::menuRect const):
3127
3128         Add a function to query the bounds of the callout menu in content coordinates.
3129
3130         (WTR::UIScriptController::isShowingMenu const):
3131
3132         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3133
3134         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3135         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3136         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3137         (WTR::UIScriptController::rectForMenuAction const):
3138         (WTR::UIScriptController::menuRect const):
3139         (WTR::UIScriptController::isShowingMenu const):
3140         (WTR::findViewInHierarchyOfType): Deleted.
3141
3142 2019-02-22  Chris Dumez  <cdumez@apple.com>
3143
3144         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3145         https://bugs.webkit.org/show_bug.cgi?id=194954
3146         <rdar://problem/48127957>
3147
3148         Reviewed by Alex Christensen.
3149
3150         Add API test coverage.
3151
3152         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3153         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3154         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3155         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3156
3157 2019-02-22  Chris Dumez  <cdumez@apple.com>
3158
3159         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3160         https://bugs.webkit.org/show_bug.cgi?id=194924
3161         <rdar://problem/48216125>
3162
3163         Reviewed by Geoffrey Garen.
3164
3165         Add API test coverage.
3166
3167         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3168
3169 2019-02-22  Chris Dumez  <cdumez@apple.com>
3170
3171         Unreviewed, disable API test added in r241928 on iOS.
3172
3173         The cache is not enabled on devices with less than 3GB of RAM.
3174
3175         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3176
3177 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3178
3179         Hardcode Visual Viewports on everywhere except iOS WK1
3180         https://bugs.webkit.org/show_bug.cgi?id=194928
3181
3182         Reviewed by Zalan Bujtas.
3183
3184         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3185         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3186         set it to false. The setting has shipped for several years and there's no need to turn
3187         it off now.
3188
3189         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3190         Visual Viewports are not enabled.
3191         
3192         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3193         that only runs in WK2
3194
3195         * MiniBrowser/mac/SettingsController.h:
3196         * MiniBrowser/mac/SettingsController.m:
3197         (-[SettingsController init]):
3198         (-[SettingsController _populateMenu]):
3199         (-[SettingsController validateMenuItem:]):
3200         (-[SettingsController visualViewportEnabled]): Deleted.
3201         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3202         * MiniBrowser/mac/WK1BrowserWindowController.m:
3203         (-[WK1BrowserWindowController didChangeSettings]):
3204         * MiniBrowser/mac/WK2BrowserWindowController.m:
3205         (-[WK2BrowserWindowController didChangeSettings]):
3206
3207 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3208
3209         Discard cached processes when clearing website data store
3210         https://bugs.webkit.org/show_bug.cgi?id=194894
3211
3212         Reviewed by Chris Dumez.
3213
3214         Added a test case.
3215
3216         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3217         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3218
3219 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3220
3221         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3222         https://bugs.webkit.org/show_bug.cgi?id=194914
3223         <rdar://problem/47586889>
3224
3225         Reviewed by Geoffrey Garen.
3226
3227         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3228         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3229         (TEST):
3230         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3231
3232 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3233
3234         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3235         <https://webkit.org/b/194761>
3236
3237         Reviewed by Myles Maxfield.
3238
3239         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3240         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3241         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3242         to use ARC-compliant cast.
3243         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3244         ARC-compliant cast.
3245         (WTR::installFakeHelvetica): Log `error` to console if
3246         CTFontManagerRegisterFontsForURL() fails, but only on supported
3247         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3248         Call CFRelease() on `error` to fix the leak.  Update to use
3249         ARC-compliant cast.
3250         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3251         cast.
3252
3253 2019-02-21  Chris Dumez  <cdumez@apple.com>
3254
3255         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3256         https://bugs.webkit.org/show_bug.cgi?id=194481
3257
3258         Reviewed by Alex Christensen.
3259
3260         Give the processes a chance to shutdown and wait until we reached the expected number
3261         of processes.
3262
3263         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3264
3265 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3266
3267         Fix the macOS build
3268
3269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3270
3271 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3272
3273         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3274
3275         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3276         I am a backwards.
3277
3278 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3279
3280         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3281
3282         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3283         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3284         We could force on UI-side compositing, but I feel like the test might be more
3285         valuable exercising the normal path on each platform (though the original
3286         bug was also UI-side specific). Though we can't validate that the overlay
3287         layer was installed successfully, there are layout tests that do that.
3288
3289 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3290
3291         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3292         https://bugs.webkit.org/show_bug.cgi?id=194845
3293         <rdar://problem/47944579>
3294
3295         Reviewed by Antti Koivisto.
3296
3297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3298         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3299
3300 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3301
3302         [LFC][Floats] Add support for placing formatting roots in-between floats.
3303         https://bugs.webkit.org/show_bug.cgi?id=194902
3304
3305         Reviewed by Antti Koivisto.
3306
3307         * LayoutReloaded/misc/LFC-passing-tests.txt:
3308
3309 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3310
3311         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3312         https://bugs.webkit.org/show_bug.cgi?id=194901
3313
3314         Unreviewed build fix.
3315
3316         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3317         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3318         WPEBackend-fdo-0.1 as library name.
3319
3320 2019-02-21  Rob Buis  <rbuis@igalia.com>
3321
3322         Update MIME type parser
3323         https://bugs.webkit.org/show_bug.cgi?id=180526
3324
3325         Reviewed by Darin Adler.
3326
3327         Add tests involving leading and trailing whitespace, non-token
3328         characters and quoted strings.
3329
3330         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3331         (TestWebKitAPI::TEST):
3332
3333 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3334
3335         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3336         https://bugs.webkit.org/show_bug.cgi?id=194884
3337
3338         Reviewed by Michael Catanzaro.
3339
3340         * PlatformWin.cmake:
3341
3342 2019-02-20  Chris Dumez  <cdumez@apple.com>
3343
3344         Add API test for <rdar://problem/47471222>
3345         https://bugs.webkit.org/show_bug.cgi?id=194847
3346
3347         Reviewed by Alex Christensen.
3348
3349         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3350
3351 2019-02-20  Chris Dumez  <cdumez@apple.com>
3352
3353         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3354         https://bugs.webkit.org/show_bug.cgi?id=194872
3355         <rdar://problem/47924500>
3356
3357         Reviewed by Alex Christensen.
3358
3359         Add API test coverage.
3360
3361         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3362
3363 2019-02-20  Jer Noble  <jer.noble@apple.com>
3364
3365         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3366         https://bugs.webkit.org/show_bug.cgi?id=191332
3367
3368         Reviewed by Dean Jackson.
3369
3370         * Scripts/git-is-in-range: Added.
3371
3372 2019-02-20  Andy Estes  <aestes@apple.com>
3373
3374         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3375         https://bugs.webkit.org/show_bug.cgi?id=194869
3376
3377         Rubber-stamped by Jer Noble.
3378
3379         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3380         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3381         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3382         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3384         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3385
3386 2019-02-20  Chris Dumez  <cdumez@apple.com>
3387
3388         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3389         https://bugs.webkit.org/show_bug.cgi?id=194857
3390         <rdar://problem/47759323>
3391
3392         Reviewed by Alex Christensen.
3393
3394         Add API test coverage.
3395
3396         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3397
3398 2019-02-20  Chris Dumez  <cdumez@apple.com>
3399
3400         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3401         https://bugs.webkit.org/show_bug.cgi?id=194829
3402         <rdar://problem/47889906>
3403
3404         Reviewed by Alexey Proskuryakov.
3405
3406         Every time the TestOptions were changing we were creating both a new Web view and
3407         a new WKContext, which would start a new Network process. In most cases, we only
3408         need to contruct a new Web view and we do can keep reusing the same WKContext.
3409         This patch implements this optimization and thus avoids spinning a lot of new
3410         Network processes while running the layout tests.
3411
3412         * WebKitTestRunner/TestController.cpp:
3413         (WTR::TestController::generateContextConfiguration const):
3414         (WTR::TestController::generatePageConfiguration):
3415         (WTR::TestController::createWebViewWithOptions):
3416         (WTR::TestController::resetPreferencesToConsistentValues):
3417         (WTR::updateTestOptionsFromTestHeader):
3418         * WebKitTestRunner/TestController.h:
3419         * WebKitTestRunner/TestOptions.h:
3420         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3421         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3422         (WTR::TestOptions::hasSameInitializationOptions const):
3423         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3424         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3425         (WTR::TestController::platformAddTestOptions const):
3426
3427 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3428
3429         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3430         https://bugs.webkit.org/show_bug.cgi?id=167941
3431
3432         Reviewed by Carlos Garcia Campos.
3433
3434         * MiniBrowser/gtk/main.c:
3435         (filterSavedCallback): Added.
3436         (main): Support loading a JSON rule set file for content filtering.
3437         * MiniBrowser/wpe/main.cpp:
3438         (filterSavedCallback): Added.
3439         (main): Support loading a JSON rule set file for content filtering.
3440         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3441         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3442         (WTF::derefGPtr): Ditto.
3443         (testEmptyStore):
3444         (testSaveInvalidFilter):
3445         (testSaveLoadFilter):
3446         (testSavedFilterIdentifierMatch):
3447         (testRemoveFilter):
3448         (testSaveMultipleFilters):
3449         (testSaveFilterFromFile):
3450         (testFilterPersistence):
3451         (beforeAll):
3452         (afterAll):
3453         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3454         (removeOldInjectedContentAndResetLists): Also reset content filters.
3455         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3456         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3457         the element affected by the style sheet.
3458         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3459         and returns it to be used by tests.
3460         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3461         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3462         (serverCallback): Add support for serving a CSS style sheet for testing.
3463         (beforeAll): Add call to testUserContentManagerContentFilter().
3464         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3465
3466 2019-02-19  Keith Rollin  <krollin@apple.com>
3467
3468         Add timing information to build output
3469         https://bugs.webkit.org/show_bug.cgi?id=194839
3470         <rdar://problem/48219609>
3471
3472         Reviewed by Alexey Proskuryakov.
3473
3474         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3475         emit each project's build time to its output. E.g.,
3476
3477             ** BUILD SUCCEEDED ** [0.132 sec]
3478
3479         * Scripts/webkitdirs.pm:
3480         (XcodeOptions):
3481
3482 2019-02-19  Truitt Savell  <tsavell@apple.com>
3483
3484         Unreviewed, rolling out r241784.
3485
3486         Broke all OpenSource builds.
3487
3488         Reverted changeset:
3489
3490         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3491         instances view"
3492         https://bugs.webkit.org/show_bug.cgi?id=172848
3493         https://trac.webkit.org/changeset/241784
3494
3495 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3496
3497         [LFC][Floats] Remove redundant intersecting logic
3498         https://bugs.webkit.org/show_bug.cgi?id=194804
3499
3500         Reviewed by Antti Koivisto.
3501
3502         * LayoutReloaded/misc/LFC-passing-tests.txt:
3503
3504 2019-02-19  Dean Jackson  <dino@apple.com>
3505
3506         Clean-up output from generate-xcfilelists so it can be filtered
3507         https://bugs.webkit.org/show_bug.cgi?id=194795
3508
3509         Reviewed by Joseph Pecoraro (and Keith Rollin).
3510
3511         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3512         make a slight tweak to filter-build-webkit so such lines are marked
3513         as plain.
3514
3515         * Scripts/filter-build-webkit:
3516         * Scripts/generate-xcfilelists:
3517
3518 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3519
3520         pytest is not correctly auto-installed
3521         https://bugs.webkit.org/show_bug.cgi?id=194707
3522
3523         Reviewed by Carlos Garcia Campos.
3524
3525         * Scripts/webkitpy/thirdparty/__init__.py:
3526         (AutoinstallImportHook._install_pytest):
3527
3528 2019-02-18  Chris Dumez  <cdumez@apple.com>
3529
3530         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3531         https://bugs.webkit.org/show_bug.cgi?id=194797
3532         <rdar://problem/48055151>
3533
3534         Reviewed by Geoffrey Garen.
3535
3536         Add API test coverage.
3537
3538         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3539
3540 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3541
3542         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3543         https://bugs.webkit.org/show_bug.cgi?id=194670
3544         <rdar://problem/39066529>
3545
3546         Reviewed by Tim Horton.
3547
3548         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3549         pasted in an editable area as attachment elements.
3550
3551         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3552         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3553         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3554         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3555         (TestWebKitAPI::TEST):
3556         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3557         (WTR::InjectedBundlePage::InjectedBundlePage):
3558
3559 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3560
3561         Fix API test after r241728
3562        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3563
3564         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3565         (TEST):
3566         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3567
3568 2019-02-18  Daniel Bates  <dabates@apple.com>
3569
3570         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3571         https://bugs.webkit.org/show_bug.cgi?id=192824
3572         <rdar://problem/47100332>
3573
3574         Reviewed by Wenson Hsieh.
3575
3576         Fix a bug where the wrong usage code was used for F13 thru F24.
3577
3578         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3579         (keyCodeForDOMFunctionKey):
3580
3581 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3582
3583         Bytecode cache should a have a boot-specific validation
3584         https://bugs.webkit.org/show_bug.cgi?id=194769
3585         <rdar://problem/48149509>
3586
3587         Reviewed by Keith Miller.
3588
3589         Add test for WTF::bootSessionUUIDString()
3590
3591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3592         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3593         (TEST):
3594
3595 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3596
3597         Disable safe browsing in WKWebView and remove its WKPreferences API
3598         https://bugs.webkit.org/show_bug.cgi?id=194723
3599         <rdar://problem/48122993>
3600
3601         Reviewed by Geoffrey Garen.
3602
3603         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3604         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3605         (TEST):
3606         (safeBrowsingView):
3607         Make tests use SPI instead of API.
3608
3609 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3610
3611         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3612         https://bugs.webkit.org/show_bug.cgi?id=194586
3613
3614         Reviewed by Ross Kirsling.
3615
3616         * DumpRenderTree/win/DumpRenderTree.cpp:
3617         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3618         * Scripts/webkitpy/port/driver.py:
3619         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3620
3621 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3622
3623         Unreviewed, rolling out r241620.
3624
3625         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3626         (Requested by ddkilzer on #webkit.)
3627
3628         Reverted changeset:
3629
3630         "[WTF] Add environment variable helpers"
3631         https://bugs.webkit.org/show_bug.cgi?id=192405
3632         https://trac.webkit.org/changeset/241620
3633
3634 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3635
3636         [LFC] RenderImage's default intrinsic size is 0.
3637         https://bugs.webkit.org/show_bug.cgi?id=194745
3638
3639         Reviewed by Antti Koivisto.
3640
3641         * LayoutReloaded/misc/LFC-passing-tests.txt:
3642
3643 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3644
3645         [LFC][BFC] Add support for block replaced intrinsic width.
3646         https://bugs.webkit.org/show_bug.cgi?id=194705
3647
3648         Reviewed by Simon Fraser.
3649
3650         * LayoutReloaded/misc/LFC-passing-tests.txt:
3651
3652 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3653
3654         [LFC] Apply min/max width constraints to preferred width computation
3655         https://bugs.webkit.org/show_bug.cgi?id=194739
3656
3657         Reviewed by Simon Fraser.
3658
3659         * LayoutReloaded/misc/LFC-passing-tests.txt:
3660
3661 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3662
3663         [WTF] Add environment variable helpers
3664         https://bugs.webkit.org/show_bug.cgi?id=192405
3665
3666         Reviewed by Michael Catanzaro.
3667
3668         * DumpRenderTree/mac/DumpRenderTree.mm:
3669         (libraryPathForDumpRenderTree):
3670         * DumpRenderTree/win/DumpRenderTree.cpp:
3671         (libraryPathForDumpRenderTree):
3672         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3673         (setUpIOSLayoutTestCommunication):
3674         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3675         (beforeAll):
3676         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3677         (main):
3678         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3679         (WebKitTestBus::run):
3680         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3681         (WTR::getOutputDir):
3682         (WTR::initializeFontConfigSetting):
3683         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3684         (WTR::InjectedBundle::platformInitialize):
3685         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3686         (WTR::topLevelPath):
3687         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3688         (WTR::topLevelPath):
3689         (WTR::getOutputDir):
3690         (WTR::activateFonts):
3691         * WebKitTestRunner/TestController.cpp:
3692         (WTR::TestController::libraryPathForTesting):
3693         (WTR::TestController::generateContextConfiguration const):
3694         (WTR::TestController::generatePageConfiguration):
3695         (WTR::TestController::decideDestinationWithSuggestedFilename):
3696         (WTR::TestController::platformAdjustContext):
3697         * WebKitTestRunner/TestController.h:
3698         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3699         (WTR::TestController::cocoaPlatformInitialize):
3700         (WTR::TestController::platformAdjustContext):
3701         * WebKitTestRunner/gtk/main.cpp:
3702  &