0e4e8cc878f13812c164b3157f6d964afb998eee
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2
3         Update text for old EWS submit button
4         https://bugs.webkit.org/show_bug.cgi?id=197140
5
6         Reviewed by Alexey Proskuryakov.
7
8         * QueueStatusServer/templates/statusbubble.html:
9
10 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
11
12         [ews-app] New EWS should poll bugzilla more frequently
13         https://bugs.webkit.org/show_bug.cgi?id=197138
14
15         Reviewed by Alexey Proskuryakov.
16
17         * BuildSlaveSupport/ews-app/ews/fetcher.py:
18         (FetchLoop.__init__):
19
20 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
21
22         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
23         https://bugs.webkit.org/show_bug.cgi?id=197139
24
25         Reviewed by Alexey Proskuryakov.
26
27         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
28         * QueueStatusServer/templates/statusbubble.html:
29
30 2019-04-20  Chris Dumez  <cdumez@apple.com>
31
32         Unreviewed, fix iOS build with recent SDKs.
33
34         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
35
36 2019-04-19  Keith Miller  <keith_miller@apple.com>
37
38         Add script to merge run_benchmark jsons
39         https://bugs.webkit.org/show_bug.cgi?id=197107
40
41         Reviewed by Michael Saboff.
42
43         The script basically recursively decends through all json objects until it gets
44         to an array or JSON primitive and concats or takes the first value, respectively.
45
46         This patch also adds +x bits to the compare-results script so it
47         can be run directly from the command line. I had to add a new line so that svn
48         will accept the change... yay svn!
49
50         * Scripts/compare-results:
51         * Scripts/merge-result-jsons: Added.
52         (readJSONFile):
53         (deepAppend):
54         (mergeJSONs):
55         (main):
56
57 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
58
59         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
60         https://bugs.webkit.org/show_bug.cgi?id=197079
61
62         Reviewed by Darin Adler.
63
64         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
65
66         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
67         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
68
69 2019-04-18  Commit Queue  <commit-queue@webkit.org>
70
71         Unreviewed, rolling out r244434.
72         https://bugs.webkit.org/show_bug.cgi?id=197089
73
74         caused 1 API test failure (Requested by zalan on #webkit).
75
76         Reverted changeset:
77
78         "Regression (r244291): Broken API Test
79         AutoLayoutRenderingProgressRelativeOrdering"
80         https://bugs.webkit.org/show_bug.cgi?id=196948
81         https://trac.webkit.org/changeset/244434
82
83 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
84
85         Add new compatibility mode API on WKNavigation
86         https://bugs.webkit.org/show_bug.cgi?id=197069
87         <rdar://problem/50025800>
88
89         Reviewed by Tim Horton.
90
91         Add a block property for -didCommitNavigation to TestNavigationDelegate.
92
93         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
94         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
95         (-[TestNavigationDelegate webView:didCommitNavigation:]):
96
97 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
98
99         [CMake] Make WebCore headers copies
100         https://bugs.webkit.org/show_bug.cgi?id=182512
101         <rdar://problem/37510435>
102
103         Reviewed by Alex Christensen.
104
105         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
106         ports.
107
108         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
109         of WebCore headers using "*.h" were modified to <WebCore/*.h>
110
111         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
112         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
113         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
114         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
115         * TestWebKitAPI/CMakeLists.txt:
116         * TestWebKitAPI/PlatformWin.cmake:
117         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
118         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
119         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
120
121 2019-04-18  Jer Noble  <jer.noble@apple.com>
122
123         Add support for parsing FairPlayStreaming PSSH boxes.
124         https://bugs.webkit.org/show_bug.cgi?id=197064
125
126         Reviewed by Eric Carlson.
127
128         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
129         (TestWebKitAPI::TEST):
130
131 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
132
133         InjectedBundle parameters often need initialization function called before unarchiving
134         https://bugs.webkit.org/show_bug.cgi?id=189709
135         <rdar://problem/44573653>
136
137         Reviewed by Ryosuke Niwa.
138
139         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
140         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
141
142 2019-04-18  Zalan Bujtas  <zalan@apple.com>
143
144         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
145         https://bugs.webkit.org/show_bug.cgi?id=196948
146         <rdar://problem/49927131>
147
148         Reviewed by Tim Horton.
149
150         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
151         (TEST): 
152         The expected order of incoming events is
153         1. didInvalidateIntrinsicContentSize
154         2. didFirstLayout
155         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
156         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
157         (and remember, all we care about is ordering).
158
159 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
160
161         Unreviewed, rolling out r244299.
162
163         Breaks internal tests.
164
165         Reverted changeset:
166
167         "InjectedBundle parameters often need initialization function
168         called before unarchiving"
169         https://bugs.webkit.org/show_bug.cgi?id=189709
170         https://trac.webkit.org/changeset/244299
171
172 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
173
174         [WTF] StringBuilder should set correct m_is8Bit flag when merging
175         https://bugs.webkit.org/show_bug.cgi?id=197053
176
177         Reviewed by Saam Barati.
178
179         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
180         (TestWebKitAPI::TEST):
181
182 2019-04-17  Tim Horton  <timothy_horton@apple.com>
183
184         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
185         https://bugs.webkit.org/show_bug.cgi?id=197028
186         <rdar://problem/49985290>
187
188         Reviewed by Wenson Hsieh.
189
190         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
191         (TEST):
192         Liberal application of waitForNextPresentationUpdate works around a race
193         where if the page rapidly changes its viewport arguments (or an API client
194         rapidly changes its viewport arguments), we'd get stuck thinking that the
195         user had intentionally zoomed the page, and stop resetting the initial scale.
196         This deserves a separate bug, but no need to keep the test failing while
197         we think about it.
198
199 2019-04-17  Tim Horton  <timothy_horton@apple.com>
200
201         REGRESSION (r241988): Switching tabs is slow
202         https://bugs.webkit.org/show_bug.cgi?id=197037
203         <rdar://problem/49951473>
204
205         Reviewed by Simon Fraser.
206
207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
208         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
209         (TEST):
210         * TestWebKitAPI/cocoa/TestWKWebView.h:
211         * TestWebKitAPI/cocoa/TestWKWebView.mm:
212         (-[TestWKWebView addToTestWindow]):
213         Add a test that hangs without this fix.
214
215 2019-04-17  Truitt Savell  <tsavell@apple.com>
216
217         Unreviewed, rolling out r244400.
218
219         Caused testing to exit early with assertionon Debug WK2
220
221         Reverted changeset:
222
223         "UI↔Web deadlock when printing with a JavaScript alert
224         visible"
225         https://bugs.webkit.org/show_bug.cgi?id=196839
226         https://trac.webkit.org/changeset/244400
227
228 2019-04-17  Brady Eidson  <beidson@apple.com>
229
230         Link clicks in PDFs shouldn't send referrer headers.
231         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
232
233         Reviewed by Tim Horton.
234
235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
236         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
237         (putPDFBytesCallback):
238         (emptyReleaseInfoCallback):
239         (createPDFWithLinkToURL):
240         (TEST):
241
242 2019-04-17  Tim Horton  <timothy_horton@apple.com>
243
244         UI↔Web deadlock when printing with a JavaScript alert visible
245         https://bugs.webkit.org/show_bug.cgi?id=196839
246         <rdar://problem/49157642>
247
248         Reviewed by Andy Estes.
249
250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
251         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
252         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
253         (TEST):
254
255 2019-04-17  Alex Christensen  <achristensen@webkit.org>
256
257         WKRetainPtr's adoption constructor should be private
258         https://bugs.webkit.org/show_bug.cgi?id=197019
259
260         Reviewed by Tim Horton.
261
262         * DumpRenderTree/mac/DumpRenderTree.mm:
263         (dumpFramesAsText):
264         * TestWebKitAPI/InjectedBundleController.cpp:
265         (TestWebKitAPI::InjectedBundleController::initialize):
266         * TestWebKitAPI/PlatformUtilities.cpp:
267         (TestWebKitAPI::Util::createContextWithInjectedBundle):
268         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
269         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
270         (TestWebKitAPI::Util::toWK):
271         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
272         (TestWebKitAPI::TEST):
273         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
274         (TestWebKitAPI::TEST):
275         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
276         (TestWebKitAPI::TEST):
277         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
278         (TestWebKitAPI::TEST):
279         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
280         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
281         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
282         (TestWebKitAPI::TEST):
283         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
284         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
285         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
286         (TestWebKitAPI::TEST):
287         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
288         (TestWebKitAPI::TEST):
289         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
290         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
291         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
292         (TestWebKitAPI::TEST):
293         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
294         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
295         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
296         (TestWebKitAPI::TEST):
297         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
298         (TestWebKitAPI::TEST):
299         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
300         (TestWebKitAPI::TEST):
301         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
302         (TestWebKitAPI::TEST):
303         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
304         (TestWebKitAPI::TEST):
305         * TestWebKitAPI/Tests/WebKit/Find.cpp:
306         (TestWebKitAPI::TEST):
307         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
308         (TestWebKitAPI::TEST):
309         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
310         (TestWebKitAPI::TEST):
311         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
312         (TestWebKitAPI::TEST):
313         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
314         (TestWebKitAPI::TEST):
315         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
316         (TestWebKitAPI::TEST):
317         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
318         (TestWebKitAPI::TEST):
319         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
320         (TestWebKitAPI::TEST):
321         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
322         (TestWebKitAPI::TEST):
323         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
324         (TestWebKitAPI::TEST):
325         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
326         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
327         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
328         (TestWebKitAPI::TEST):
329         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
330         (TestWebKitAPI::TEST):
331         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
332         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
333         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
334         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
335         (TestWebKitAPI::TEST):
336         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
337         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
338         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
339         (TestWebKitAPI::TEST):
340         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
341         (TestWebKitAPI::TEST):
342         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
343         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
344         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
345         (TestWebKitAPI::TEST):
346         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
347         (TestWebKitAPI::loadAlternateHTMLString):
348         (TestWebKitAPI::TEST):
349         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
350         (TestWebKitAPI::TEST):
351         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
352         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
353         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
354         (TestWebKitAPI::buildAndPerformTest):
355         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
356         (TestWebKitAPI::TEST):
357         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
358         (TestWebKitAPI::TEST):
359         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
360         (TestWebKitAPI::TEST):
361         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
362         (TestWebKitAPI::TEST):
363         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
364         (TestWebKitAPI::TEST):
365         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
366         (TestWebKitAPI::TEST):
367         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
368         (TestWebKitAPI::TEST):
369         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
370         (TestWebKitAPI::TEST):
371         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
372         (TestWebKitAPI::TEST):
373         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
374         (TestWebKitAPI::TEST):
375         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
376         (TestWebKitAPI::TEST):
377         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
378         (TestWebKitAPI::TEST):
379         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
380         (TestWebKitAPI::TEST):
381         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
382         (TestWebKitAPI::TEST):
383         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
384         (TestWebKitAPI::TEST):
385         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
386         (TestWebKitAPI::TEST):
387         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
388         (TestWebKitAPI::TEST):
389         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
390         (TestWebKitAPI::TEST):
391         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
392         (TestWebKitAPI::TEST):
393         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
394         (TestWebKitAPI::TEST):
395         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
396         (TestWebKitAPI::TEST):
397         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
398         (TestWebKitAPI::TEST):
399         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
400         (TestWebKitAPI::TEST):
401         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
402         (TestWebKitAPI::TEST):
403         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
404         (TestWebKitAPI::TEST):
405         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
406         (TestWebKitAPI::TEST):
407         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
408         (TestWebKitAPI::TEST):
409         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
410         (TestWebKitAPI::TEST):
411         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
412         (TestWebKitAPI::TEST):
413         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
414         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
415         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
416         (TestWebKitAPI::TEST):
417         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
418         (TestWebKitAPI::TEST):
419         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
420         (TestWebKitAPI::TEST):
421         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
422         (TestWebKitAPI::TEST):
423         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
424         (TestWebKitAPI::TEST):
425         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
426         (TestWebKitAPI::TEST):
427         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
428         (TestWebKitAPI::TEST):
429         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
430         (TestWebKitAPI::TEST):
431         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
432         (TestWebKitAPI::TEST):
433         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
434         (TestWebKitAPI::TEST):
435         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
436         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
437         (TEST):
438         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
439         (TEST):
440         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
441         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
442         (TEST):
443         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
444         (TestWebKitAPI::TEST):
445         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
446         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
447         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
448         (WTR::getMenuItemTitleCallback):
449         (WTR::createMouseMessageBody):
450         (WTR::EventSendingController::mouseDown):
451         (WTR::EventSendingController::mouseUp):
452         (WTR::EventSendingController::mouseMoveTo):
453         (WTR::EventSendingController::mouseForceClick):
454         (WTR::EventSendingController::startAndCancelMouseForceClick):
455         (WTR::EventSendingController::mouseForceDown):
456         (WTR::EventSendingController::mouseForceUp):
457         (WTR::EventSendingController::mouseForceChanged):
458         (WTR::EventSendingController::leapForward):
459         (WTR::EventSendingController::scheduleAsynchronousClick):
460         (WTR::createKeyDownMessageBody):
461         (WTR::EventSendingController::keyDown):
462         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
463         (WTR::EventSendingController::mouseScrollBy):
464         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
465         (WTR::EventSendingController::continuousMouseScrollBy):
466         (WTR::EventSendingController::addTouchPoint):
467         (WTR::EventSendingController::updateTouchPoint):
468         (WTR::EventSendingController::setTouchModifier):
469         (WTR::EventSendingController::setTouchPointRadius):
470         (WTR::EventSendingController::touchStart):
471         (WTR::EventSendingController::touchMove):
472         (WTR::EventSendingController::touchEnd):
473         (WTR::EventSendingController::touchCancel):
474         (WTR::EventSendingController::clearTouchPoints):
475         (WTR::EventSendingController::releaseTouchPoint):
476         (WTR::EventSendingController::cancelTouchPoint):
477         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
478         (WTR::InjectedBundle::didCreatePage):
479         (WTR::InjectedBundle::didReceiveMessage):
480         (WTR::InjectedBundle::didReceiveMessageToPage):
481         (WTR::InjectedBundle::booleanForKey):
482         (WTR::InjectedBundle::done):
483         (WTR::InjectedBundle::dumpToStdErr):
484         (WTR::InjectedBundle::outputText):
485         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
486         (WTR::InjectedBundle::postAddChromeInputField):
487         (WTR::InjectedBundle::postRemoveChromeInputField):
488         (WTR::InjectedBundle::postFocusWebView):
489         (WTR::InjectedBundle::postSetBackingScaleFactor):
490         (WTR::InjectedBundle::postSetWindowIsKey):
491         (WTR::InjectedBundle::postSetViewSize):
492         (WTR::InjectedBundle::postSimulateWebNotificationClick):
493         (WTR::InjectedBundle::postSetAddsVisitedLinks):
494         (WTR::InjectedBundle::setGeolocationPermission):
495         (WTR::InjectedBundle::setMockGeolocationPosition):
496         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
497         (WTR::InjectedBundle::isGeolocationProviderActive const):
498         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
499         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
500         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
501         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
502         (WTR::InjectedBundle::setCustomPolicyDelegate):
503         (WTR::InjectedBundle::setHidden):
504         (WTR::InjectedBundle::setCacheModel):
505         (WTR::InjectedBundle::shouldProcessWorkQueue const):
506         (WTR::InjectedBundle::processWorkQueue):
507         (WTR::InjectedBundle::queueBackNavigation):
508         (WTR::InjectedBundle::queueForwardNavigation):
509         (WTR::InjectedBundle::queueLoad):
510         (WTR::InjectedBundle::queueLoadHTMLString):
511         (WTR::InjectedBundle::queueReload):
512         (WTR::InjectedBundle::queueLoadingScript):
513         (WTR::InjectedBundle::queueNonLoadingScript):
514         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
515         (WTR::frameToStr):
516         (WTR::InjectedBundlePage::InjectedBundlePage):
517         (WTR::dumpFrameDescriptionSuitableForTestResult):
518         (WTR::dumpFrameScrollPosition):
519         (WTR::dumpDescendantFrameScrollPositions):
520         (WTR::dumpFrameText):
521         (WTR::dumpDescendantFramesText):
522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
523         (WTR::TestRunner::shouldDumpPixels const):
524         (WTR::TestRunner::setDumpPixels):
525         (WTR::TestRunner::whatToDump const):
526         (WTR::TestRunner::setWhatToDump):
527         (WTR::TestRunner::setWaitUntilDone):
528         (WTR::TestRunner::shouldWaitUntilDone const):
529         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
530         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
531         (WTR::TestRunner::clearAllDatabases):
532         (WTR::TestRunner::setIDBPerOriginQuota):
533         (WTR::TestRunner::originsWithApplicationCache):
534         (WTR::TestRunner::setCanOpenWindows):
535         (WTR::TestRunner::setXSSAuditorEnabled):
536         (WTR::TestRunner::setMediaDevicesEnabled):
537         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
538         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
539         (WTR::TestRunner::setCustomUserAgent):
540         (WTR::TestRunner::setWebAPIStatisticsEnabled):
541         (WTR::TestRunner::setModernMediaControlsEnabled):
542         (WTR::TestRunner::setWebGL2Enabled):
543         (WTR::TestRunner::setWritableStreamAPIEnabled):
544         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
545         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
546         (WTR::TestRunner::setAllowsAnySSLCertificate):
547         (WTR::TestRunner::setPluginsEnabled):
548         (WTR::TestRunner::setValueForUser):
549         (WTR::TestRunner::setAudioResult):
550         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
551         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
552         (WTR::TestRunner::setAlwaysAcceptCookies):
553         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
554         (WTR::TestRunner::isDoingMediaCapture const):
555         (WTR::TestRunner::queueLoad):
556         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
557         (WTR::TestRunner::setHandlesAuthenticationChallenges):
558         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
559         (WTR::TestRunner::setShouldLogDownloadCallbacks):
560         (WTR::TestRunner::setAuthenticationUsername):
561         (WTR::TestRunner::setAuthenticationPassword):
562         (WTR::TestRunner::secureEventInputIsEnabled const):
563         (WTR::TestRunner::setBlockAllPlugins):
564         (WTR::TestRunner::setPluginSupportedMode):
565         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
566         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
567         (WTR::TestRunner::setNavigationGesturesEnabled):
568         (WTR::TestRunner::setIgnoresViewportScaleLimits):
569         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
570         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
571         (WTR::TestRunner::terminateNetworkProcess):
572         (WTR::TestRunner::terminateServiceWorkerProcess):
573         (WTR::TestRunner::runUIScript):
574         (WTR::TestRunner::setStatisticsDebugMode):
575         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
576         (WTR::TestRunner::setStatisticsLastSeen):
577         (WTR::TestRunner::setStatisticsPrevalentResource):
578         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
579         (WTR::TestRunner::dumpResourceLoadStatistics):
580         (WTR::TestRunner::isStatisticsPrevalentResource):
581         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
582         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
583         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
584         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
585         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
586         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
587         (WTR::TestRunner::setStatisticsGrandfathered):
588         (WTR::TestRunner::isStatisticsGrandfathered):
589         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
590         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
591         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
592         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
593         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
594         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
595         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
596         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
597         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
598         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
599         (WTR::TestRunner::statisticsUpdateCookieBlocking):
600         (WTR::TestRunner::statisticsSubmitTelemetry):
601         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
602         (WTR::TestRunner::setStatisticsIsRunningTest):
603         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
604         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
605         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
606         (WTR::TestRunner::setStatisticsGrandfatheringTime):
607         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
608         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
609         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
610         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
611         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
612         (WTR::TestRunner::statisticsDeleteCookiesForHost):
613         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
614         (WTR::TestRunner::statisticsResetToConsistentState):
615         (WTR::TestRunner::setStorageAccessAPIEnabled):
616         (WTR::TestRunner::getAllStorageAccessEntries):
617         (WTR::TestRunner::addMockMediaDevice):
618         (WTR::TestRunner::clearMockMediaDevices):
619         (WTR::TestRunner::removeMockMediaDevice):
620         (WTR::TestRunner::resetMockMediaDevices):
621         (WTR::TestRunner::connectMockGamepad):
622         (WTR::TestRunner::disconnectMockGamepad):
623         (WTR::TestRunner::setMockGamepadDetails):
624         (WTR::TestRunner::setMockGamepadAxisValue):
625         (WTR::TestRunner::setMockGamepadButtonValue):
626         (WTR::TestRunner::removeAllSessionCredentials):
627         (WTR::TestRunner::clearDOMCache):
628         (WTR::TestRunner::clearDOMCaches):
629         (WTR::TestRunner::hasDOMCache):
630         (WTR::TestRunner::domCacheSize):
631         (WTR::TestRunner::setAllowStorageQuotaIncrease):
632         (WTR::TestRunner::getApplicationManifestThen):
633         (WTR::TestRunner::injectUserScript):
634         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
635         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
636         (WTR::TestRunner::addTestKeyToKeychain):
637         (WTR::TestRunner::cleanUpKeychain):
638         (WTR::TestRunner::keyExistsInKeychain):
639         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
640         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
641         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
642         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
643         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
644         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
645         * WebKitTestRunner/TestController.cpp:
646         (WTR::TestController::initialize):
647         (WTR::parseStringTestHeaderValueAsRelativePath):
648         (WTR::updateTestOptionsFromTestHeader):
649         (WTR::TestController::runTest):
650         (WTR::TestController::didReceiveLiveDocumentsList):
651         (WTR::TestController::didReceiveMessageFromInjectedBundle):
652         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
653         (WTR::TestController::didFinishNavigation):
654         (WTR::TestController::didReceiveAuthenticationChallenge):
655         * WebKitTestRunner/TestInvocation.cpp:
656         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
657         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
658         (WTR::TestInvocation::uiScriptDidComplete):
659         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
660         * WebKitTestRunner/WebNotificationProvider.cpp:
661         (WTR::WebNotificationProvider::closeWebNotification):
662         * WebKitTestRunner/WorkQueueManager.cpp:
663         (WTR::ScriptItem::ScriptItem):
664         (WTR::WorkQueueManager::queueLoad):
665         (WTR::WorkQueueManager::queueLoadHTMLString):
666
667 2019-04-17  Alex Christensen  <achristensen@webkit.org>
668
669         Add a comment to make my test from r244139 less mysterious.
670         https://bugs.webkit.org/show_bug.cgi?id=196744
671
672         As suggested by Darin Adler.
673
674         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
675         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
676
677 2019-04-17  Chris Dumez  <cdumez@apple.com>
678
679         Remember device orientation permission for the duration of the browsing session
680         https://bugs.webkit.org/show_bug.cgi?id=196992
681         <rdar://problem/49946067>
682
683         Reviewed by Alex Christensen.
684
685         Add API test coverage.
686
687         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
688         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
689         (TEST):
690
691 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
692
693         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
694         https://bugs.webkit.org/show_bug.cgi?id=196675
695
696         Reviewed by Lucas Forschler.
697
698         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
699         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
700
701 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
702
703         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
704         https://bugs.webkit.org/show_bug.cgi?id=196919
705         <rdar://problem/41630459>
706
707         Reviewed by Tim Horton.
708
709         Add iOS support for several new testing hooks. See below for more detail.
710
711         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
712         (WTR::UIScriptController::isDismissingMenu const):
713
714         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
715         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
716         by UIKit when dismissing the callout bar (i.e. UIMenuController).
717
718         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
719         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
720         (WTR::UIScriptController::isDismissingMenu const):
721         * TestRunnerShared/UIScriptContext/UIScriptController.h:
722         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
723         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
724         (WTR::InjectedBundle::didReceiveMessageToPage):
725         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
726         (WTR::TestRunner::setAllowedMenuActions):
727
728         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
729         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
730         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
731         against the name of the custom action.
732
733         (WTR::TestRunner::installCustomMenuAction):
734
735         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
736         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
737         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
738         triggered.
739
740         (WTR::TestRunner::performCustomMenuAction):
741
742         Invoked when the custom menu action is triggered.
743
744         * WebKitTestRunner/InjectedBundle/TestRunner.h:
745         * WebKitTestRunner/TestController.cpp:
746         (WTR::TestController::installCustomMenuAction):
747         (WTR::TestController::setAllowedMenuActions):
748         * WebKitTestRunner/TestController.h:
749         * WebKitTestRunner/TestInvocation.cpp:
750         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
751         (WTR::TestInvocation::performCustomMenuAction):
752
753         Add plumbing to call back into the injected bundle when performing the custom action.
754
755         * WebKitTestRunner/TestInvocation.h:
756         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
757         (WTR::TestController::installCustomMenuAction):
758         (WTR::TestController::setAllowedMenuActions):
759         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
760         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
761         (-[TestRunnerWKWebView initWithFrame:configuration:]):
762         (-[TestRunnerWKWebView becomeFirstResponder]):
763         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
764
765         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
766         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
767         in the Mail app on iOS.
768
769         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
770         (-[TestRunnerWKWebView setAllowedMenuActions:]):
771         (-[TestRunnerWKWebView resetCustomMenuAction]):
772         (-[TestRunnerWKWebView performCustomAction:]):
773         (-[TestRunnerWKWebView canPerformAction:withSender:]):
774         (-[TestRunnerWKWebView _willHideMenu]):
775         (-[TestRunnerWKWebView _didHideMenu]):
776         * WebKitTestRunner/ios/TestControllerIOS.mm:
777         (WTR::TestController::platformResetStateToConsistentValues):
778
779         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
780         if specified.
781
782         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
783         (WTR::UIScriptController::isDismissingMenu const):
784
785 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
786
787         Allow sharing from imageSheet on an image document
788         https://bugs.webkit.org/show_bug.cgi?id=196891
789         <rdar://problem/25377386>
790
791         Reviewed by Tim Horton.
792
793         Test to make sure that the correct imageURL is extracted from an image element.
794
795         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
796         (TestWebKitAPI::TEST):
797
798 2019-04-16  Alex Christensen  <achristensen@webkit.org>
799
800         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
801         https://bugs.webkit.org/show_bug.cgi?id=196995
802
803         Reviewed by Brady Eidson.
804
805         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
806         (TEST):
807
808 2019-04-16  Chris Dumez  <cdumez@apple.com>
809
810         URL set by document.open() is not communicated to the UIProcess
811         https://bugs.webkit.org/show_bug.cgi?id=196941
812         <rdar://problem/49237544>
813
814         Reviewed by Geoff Garen.
815
816         Add API test coverage.
817
818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
819         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
820         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
821         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
822         (TEST):
823
824 2019-04-16  Commit Queue  <commit-queue@webkit.org>
825
826         Unreviewed, rolling out r244321.
827         https://bugs.webkit.org/show_bug.cgi?id=196968
828
829         Causing all WK2 Debug builds to exit early after Assertion
830         failures. (Requested by ShawnRoberts on #webkit).
831
832         Reverted changeset:
833
834         "URL set by document.open() is not communicated to the
835         UIProcess"
836         https://bugs.webkit.org/show_bug.cgi?id=196941
837         https://trac.webkit.org/changeset/244321
838
839 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
840
841         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
842         https://bugs.webkit.org/show_bug.cgi?id=196948
843
844         Reviewed by Zalan Bujtas.
845
846         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
847         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
848
849 2019-04-15  Chris Dumez  <cdumez@apple.com>
850
851         URL set by document.open() is not communicated to the UIProcess
852         https://bugs.webkit.org/show_bug.cgi?id=196941
853         <rdar://problem/49237544>
854
855         Reviewed by Geoffrey Garen.
856
857         Add API test coverage.
858
859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
860         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
861         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
862         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
863         (TEST):
864
865 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
866
867         Using Tools/Scripts/clean-webkit should not install requests
868         https://bugs.webkit.org/show_bug.cgi?id=196940
869
870         Reviewed by Lucas Forschler.
871
872         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
873         existing, depending on the path autoinstalled is run through.
874         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
875         needed.
876         (Port.configuration_for_upload):
877         (Port.commits_for_upload):
878
879 2019-04-15  Alex Christensen  <achristensen@webkit.org>
880
881         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
882         https://bugs.webkit.org/show_bug.cgi?id=196773
883
884         Reviewed by Jer Noble.
885
886         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
887         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
888         (TEST):
889
890 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
891
892         ews-build should clearly indicate flaky test failures
893         https://bugs.webkit.org/show_bug.cgi?id=196947
894
895         Reviewed by Lucas Forschler.
896
897         * BuildSlaveSupport/ews-build/steps.py:
898         (AnalyzeAPITestsResults.analyzeResults):
899
900 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
901
902         InjectedBundle parameters often need initialization function called before unarchiving
903         https://bugs.webkit.org/show_bug.cgi?id=189709
904         <rdar://problem/44573653>
905
906         Reviewed by Ryosuke Niwa.
907
908         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
909         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
910
911 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
912
913         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
914         https://bugs.webkit.org/show_bug.cgi?id=196681
915
916         Reviewed by Darin Adler.
917
918         Added tests.
919
920         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
921         (WTF_HashSet.RemoveIf):
922         (WTF_HashSet.RemoveIfShrinkToBestSize):
923
924 2019-04-15  John Wilander  <wilander@apple.com>
925
926         Send delayed Ad Click Attribution conversion requests to the click source
927         https://bugs.webkit.org/show_bug.cgi?id=196838
928         <rdar://problem/47650157>
929
930         Reviewed by Chris Dumez and Youenn Fablet.
931
932         This patch adds test infrastructure to override the default behavior in
933         WebKit::NetworkAdClickAttribution.
934
935         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
936         (TestWebKitAPI::TEST):
937         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
938         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
939         (WTR::TestRunner::dumpAdClickAttribution):
940         (WTR::TestRunner::clearAdClickAttribution):
941         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
942         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
943         * WebKitTestRunner/InjectedBundle/TestRunner.h:
944         * WebKitTestRunner/TestController.cpp:
945         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
946         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
947         * WebKitTestRunner/TestController.h:
948         * WebKitTestRunner/TestInvocation.cpp:
949         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
950
951 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
952
953         [ews-app] status-bubble should display position in queue
954         https://bugs.webkit.org/show_bug.cgi?id=196607
955
956         Reviewed by Lucas Forschler.
957
958         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
959         (StatusBubble._build_bubble):
960         (StatusBubble._queue_position): Method to calculate patch's position in queue.
961
962 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
963
964         [ews-build] Do not run clean build by default on EWS builders
965         https://bugs.webkit.org/show_bug.cgi?id=196897
966
967         Reviewed by Lucas Forschler.
968
969         * BuildSlaveSupport/ews-build/steps.py:
970         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
971         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
972         untracked directories like WebKitBuild).
973         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
974         untracked files/directories (like WebKitBuild).
975
976 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
977
978         TestRunner::notifyDone() should be safely reentrant
979         https://bugs.webkit.org/show_bug.cgi?id=196898
980
981         Reviewed by Darin Adler.
982
983         It is currently possible that TestRunner::notifyDone() will call itself, since
984         notifyDone() will force a repaint, which can start executing JavaScript, which
985         may call notifyDone() again. This can lead to test failures and flakiness.
986         Fix this by setting the m_waitToDump flag before calling the dump() method.
987
988         * DumpRenderTree/mac/TestRunnerMac.mm:
989         (TestRunner::notifyDone):
990         (TestRunner::forceImmediateCompletion):
991         * DumpRenderTree/win/TestRunnerWin.cpp:
992         (TestRunner::notifyDone):
993         (TestRunner::forceImmediateCompletion):
994
995 2019-04-15  Philippe Normand  <pnormand@igalia.com>
996
997         [GTK][WPE] Add enable-media websetting
998         https://bugs.webkit.org/show_bug.cgi?id=196863
999
1000         Reviewed by Michael Catanzaro.
1001
1002         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1003         (testWebKitSettings): Add test for the enable-media web-setting.
1004
1005 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1006
1007         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1008         https://bugs.webkit.org/show_bug.cgi?id=196905
1009         <rdar://problem/49886096>
1010
1011         Reviewed by Tim Horton.
1012
1013         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1014         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1015         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1016         delay timer, we end up with this sequence of events in the problematic (failure) case:
1017
1018         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1019             ...IPC from UI to web process...
1020         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1021             ...IPC from web to UI process...
1022         (c) [UI]    Invoke completion handler for script #1
1023         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1024             ...IPC from UI to web process...
1025         (e) [Web]   Evaluate script #2 in the web process
1026         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1027
1028         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1029         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1030         #2 is run in step (e).
1031
1032         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1033         the UI process by waiting on a script message posted by the web process, after attachment updates are
1034         dispatched.
1035
1036         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1037         (TestWebKitAPI::TEST):
1038
1039 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1040
1041         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1042         https://bugs.webkit.org/show_bug.cgi?id=196909
1043
1044         Reviewed by Wenson Hsieh.
1045
1046         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1047         (TestWebKitAPI::TEST):
1048
1049 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1050
1051         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1052         https://bugs.webkit.org/show_bug.cgi?id=196880
1053
1054         Reviewed by Yusuke Suzuki.
1055
1056         Add a new function for bytecode cache tests that does not forceDiskCache
1057         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1058         test added in this patch, since the code is invalid and therefore won't be
1059         cached. It should also be useful for tests that evaluate dynamically
1060         generated code.
1061
1062         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1063         * Scripts/run-jsc-stress-tests:
1064
1065 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1066
1067         Update AudioSession route sharing policy
1068         https://bugs.webkit.org/show_bug.cgi?id=196776
1069         <rdar://problem/46501611>
1070
1071         Reviewed by Jer Noble.
1072
1073         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1074         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1075         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1076         (TestWebKitAPI::TEST):
1077
1078 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1079
1080         [iOS] Software keyboard is shown too frequently on some websites
1081         https://bugs.webkit.org/show_bug.cgi?id=195856
1082         <rdar://problem/49191395>
1083
1084         Reviewed by Darin Adler.
1085
1086         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1087
1088         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1089         (WTR::UIScriptController::setHardwareKeyboardAttached):
1090         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1091         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1092         (WTR::UIScriptController::setHardwareKeyboardAttached):
1093         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1094         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1095
1096         Additionally link against GraphicsServices in WebKitTestRunner.
1097
1098         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1099         (WTR::TestController::platformResetStateToConsistentValues):
1100         (WTR::UIScriptController::setHardwareKeyboardAttached):
1101
1102 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1103
1104         [GTK][WPE] Fix pacman install-dependencies packages
1105         https://bugs.webkit.org/show_bug.cgi?id=196817
1106
1107         Reviewed by Žan Doberšek.
1108         
1109         python3-setuptools is called python-setuptools
1110         ruby-highline is only available on AUR
1111         libv4l-devel is incorporated in v4l-utils
1112
1113         * gtk/install-dependencies:
1114         * wpe/install-dependencies:
1115
1116 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1117
1118         [GTK] REGRESSION(r243860): Many tests failing
1119         https://bugs.webkit.org/show_bug.cgi?id=196791
1120
1121         Reviewed by Joanmarie Diggs.
1122
1123         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1124         multiple documents and check that accessibility hierarchy is updated after a navigation.
1125
1126         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1127         (loadChangedCallback):
1128         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1129         (AccessibilityTest::AccessibilityTest):
1130         (AccessibilityTest::~AccessibilityTest):
1131         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1132         (AccessibilityTest::findTestServerApplication):
1133         (AccessibilityTest::findDocumentWeb):
1134         (AccessibilityTest::findRootObject):
1135         (AccessibilityTest::waitUntilChildrenRemoved):
1136         (AccessibilityTest::ensureProxy):
1137         (testAtspiBasicHierarchy):
1138         (beforeAll):
1139         (afterAll):
1140
1141 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1142
1143         [ews-build] Handle bug titles with unicode characters
1144         https://bugs.webkit.org/show_bug.cgi?id=196802
1145
1146         Reviewed by Dewei Zhu.
1147
1148         * BuildSlaveSupport/ews-build/steps.py:
1149         (ValidatePatch._is_bug_closed):
1150
1151 2019-04-11  Michael Saboff  <msaboff@apple.com>
1152
1153         Improve the Inline Cache Stats code
1154         https://bugs.webkit.org/show_bug.cgi?id=196836
1155
1156         Reviewed by Saam Barati.
1157
1158         Added a new script to consolidate and arrange the output of --useICStats option.
1159
1160         This script merges the output from every group into one large table and sorts it from most common to
1161         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1162         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1163         Put together, this is useful to see what property accesses are not getting cached.
1164
1165         * Scripts/ic-stats.py: Added.
1166         (ICStats):
1167         (ICStats.__init__):
1168         (ICStats.parse):
1169         (ICStats.dumpStats):
1170         (usage):
1171
1172 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1173
1174         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1175         https://bugs.webkit.org/show_bug.cgi?id=196809
1176         <rdar://49800762>
1177
1178         Reviewed by Brady Eidson.
1179
1180         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1181         (TEST):
1182
1183 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1184
1185         requestAnimationFrame should execute before the next frame
1186         https://bugs.webkit.org/show_bug.cgi?id=177484
1187
1188         Reviewed by Simon Fraser.
1189
1190         Add trace points for the page RenderingUpdate.
1191
1192         * Tracing/SystemTracePoints.plist:
1193
1194 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1195
1196         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1197         https://bugs.webkit.org/show_bug.cgi?id=196760
1198
1199         Reviewed by Don Olmstead.
1200
1201         vswhere.exe has been bundled since Visual Studio 2017 version
1202         15.2. We shouldn't download vswhere.exe.
1203
1204         * Scripts/build-jsc: Do not call update-vswhere.py.
1205         * Scripts/build-webkit: Ditto.
1206         * Scripts/update-vswhere.py: Removed.
1207         * Scripts/webkitdirs.pm:
1208         (requireModulesForVSWhere): Deleted.
1209         (pickCurrentVisualStudioInstallation): Deleted.
1210         (visualStudioInstallDirVSWhere): Return the latest installed VS
1211         installation path by using the bundled vswhere.exe.
1212         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1213         (visualStudioInstallDirFallback): Removed.
1214
1215 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1216
1217         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1218         https://bugs.webkit.org/show_bug.cgi?id=196780
1219
1220         Reviewed by Alexey Proskuryakov.
1221
1222         * BuildSlaveSupport/ews-build/steps.py:
1223         * BuildSlaveSupport/ews-build/steps_unittest.py:
1224
1225 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1226
1227         Add SPI WKNavigationResponse._downloadAttribute
1228         https://bugs.webkit.org/show_bug.cgi?id=196755
1229         <rdar://49587365>
1230
1231         Reviewed by Brady Eidson.
1232
1233         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1234         (-[NavigationResponseTestDelegate navigationResponse]):
1235         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1236         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1237         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1238         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1239         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1240         (readRequest):
1241         (writeResponse):
1242         (TEST):
1243
1244 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1245
1246         Add modern API for overriding the page's specified viewport configuration
1247         https://bugs.webkit.org/show_bug.cgi?id=167734
1248         <rdar://problem/30331795>
1249
1250         Reviewed by Simon Fraser.
1251
1252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1253         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1254
1255 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1256
1257         Add support for incremental bytecode cache updates
1258         https://bugs.webkit.org/show_bug.cgi?id=195000
1259
1260         Reviewed by Filip Pizlo.
1261
1262         Exit when the initial run to generate bytecode fails.
1263
1264         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1265
1266 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1267
1268         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1269         https://bugs.webkit.org/show_bug.cgi?id=196744
1270         <rdar://49415309>
1271
1272         Reviewed by Chris Dumez.
1273
1274         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1275         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1276
1277 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1278
1279         Add a way to opt into modern compatibility mode in layout tests
1280         https://bugs.webkit.org/show_bug.cgi?id=196770
1281         <rdar://problem/49777550>
1282
1283         Reviewed by Antoine Quint.
1284
1285         Add a new test option to enable modern compatibility mode in layout tests.
1286
1287         * WebKitTestRunner/TestController.cpp:
1288         (WTR::updateTestOptionsFromTestHeader):
1289         * WebKitTestRunner/TestController.h:
1290         * WebKitTestRunner/TestOptions.h:
1291         (WTR::TestOptions::hasSameInitializationOptions const):
1292         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1293         (WTR::TestController::platformCreateWebView):
1294         (WTR::TestController::enableModernCompatibilityMode):
1295
1296 2019-04-10  Andy Estes  <aestes@apple.com>
1297
1298         Try to fix the 32-bit watchOS build.
1299
1300         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1301         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1302
1303 2019-04-10  Antoine Quint  <graouts@apple.com>
1304
1305         Enable Pointer Events on watchOS
1306         https://bugs.webkit.org/show_bug.cgi?id=196771
1307         <rdar://problem/49040909>
1308
1309         Reviewed by Dean Jackson.
1310
1311         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1312
1313 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1314
1315         Unreviewed. Fix WPE accessibility tests after r244059.
1316
1317         We are failing to load the injected bundle due to undefined symbol
1318         AccessibilityUIElement::replaceTextInRange().
1319
1320         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1321         (WTR::AccessibilityUIElement::replaceTextInRange):
1322
1323 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1324
1325         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1326         https://bugs.webkit.org/show_bug.cgi?id=196727
1327
1328         Reviewed by Fujii Hironori.
1329
1330         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1331         (WebKitBrowserWindow::create):
1332
1333 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1334
1335         [ews-build] Add unit tests for PrintConfiguration
1336         https://bugs.webkit.org/show_bug.cgi?id=196752
1337
1338         Reviewed by Dewei Zhu.
1339
1340         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1341
1342 2019-04-09  Keith Rollin  <krollin@apple.com>
1343
1344         Unreviewed build maintenance -- update .xcfilelists.
1345
1346         * DumpRenderTree/DerivedSources-input.xcfilelist:
1347         * DumpRenderTree/DerivedSources-output.xcfilelist:
1348
1349 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1350
1351         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1352         https://bugs.webkit.org/show_bug.cgi?id=196743
1353         <rdar://problem/43897551>
1354
1355         Reviewed by Tim Horton.
1356
1357         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1358         (TEST):
1359
1360 2019-04-09  Youenn Fablet  <youenn@apple.com>
1361
1362         Close service worker database on network process suspension
1363         https://bugs.webkit.org/show_bug.cgi?id=196623
1364         <rdar://problem/48930869>
1365
1366         Reviewed by Alex Christensen.
1367
1368         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1369
1370 2019-04-09  Daniel Bates  <dabates@apple.com>
1371
1372         [iPad] Should open popover when the spacebar is pressed
1373         https://bugs.webkit.org/show_bug.cgi?id=196360
1374         <rdar://problem/49389129>
1375
1376         Reviewed by Brent Fulgham.
1377
1378         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1379
1380         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1381         (WTR::UIScriptController::isShowingPopover const): Added.
1382         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1383         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1384         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1385         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1386         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1387         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1388         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1389         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1390         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1391         (WTR::UIScriptController::isShowingPopover const): Added.
1392         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1393         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1394         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1395         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1396         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1397         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1398         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1399         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1400         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1401         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1402         (WTR::UIScriptController::isShowingPopover const): Added.
1403         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1404         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1405
1406 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1407
1408         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1409         https://bugs.webkit.org/show_bug.cgi?id=196665
1410         <rdar://45115669>
1411
1412         Reviewed by Geoff Garen.
1413
1414         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1415         (goBack):
1416         (+[SimpleLookupContext sharedLookupContext]):
1417         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1418         (TEST):
1419         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1420         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1421
1422 2019-04-09  John Wilander  <wilander@apple.com>
1423
1424         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1425         https://bugs.webkit.org/show_bug.cgi?id=196558
1426         <rdar://problem/47650245>
1427
1428         Reviewed by Youenn Fablet.
1429
1430         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1431         (TestWebKitAPI::TEST):
1432             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1433
1434 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1435
1436         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1437         https://bugs.webkit.org/show_bug.cgi?id=196720
1438
1439         Reviewed by Konstantin Tokarev.
1440
1441         * TestWebKitAPI/PlatformMac.cmake:
1442
1443 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1444
1445         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1446         https://bugs.webkit.org/show_bug.cgi?id=196694
1447         <rdar://problem/48388734>
1448
1449         Rubber-stamped by Aakash Jain.
1450
1451         * Scripts/webkitpy/port/image_diff.py:
1452         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1453         * Scripts/webkitpy/port/server_process.py:
1454         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1455         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1456         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1457         * Scripts/webkitpy/port/server_process_mock.py:
1458         (MockServerProcess.has_available_stdout):
1459         * Scripts/webkitpy/port/server_process_unittest.py:
1460         (TestServerProcess.serial_test_basic):
1461
1462 2019-04-09  Jer Noble  <jer.noble@apple.com>
1463
1464         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1465         https://bugs.webkit.org/show_bug.cgi?id=196097
1466
1467         Reviewed by Eric Carlson.
1468
1469         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1470
1471         * DumpRenderTree/mac/DumpRenderTree.mm:
1472         (resetWebPreferencesToConsistentValues):
1473         * WebKitTestRunner/TestController.cpp:
1474         (WTR::TestController::resetPreferencesToConsistentValues):
1475
1476 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1477
1478         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1479         https://bugs.webkit.org/show_bug.cgi?id=196690
1480
1481         Reviewed by Michael Catanzaro.
1482
1483         * QueueStatusServer/config/queues.py:
1484         * Scripts/webkitpy/common/config/ews.json:
1485         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1486         (test_ews_name):
1487
1488 2019-04-09  Chris Dumez  <cdumez@apple.com>
1489
1490         Loads using loadHTMLString() cause flashing when process-swapping
1491         https://bugs.webkit.org/show_bug.cgi?id=196714
1492         <rdar://problem/49637354>
1493
1494         Reviewed by Antti Koivisto.
1495
1496         Add API test coverage.
1497
1498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1499
1500 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1501
1502         Unreviewed. Fix ATK accessibility tests after r244059.
1503
1504         We are failing to load the injected bundle due to undefined symbol
1505         AccessibilityUIElement::replaceTextInRange().
1506
1507         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1508         (WTR::AccessibilityUIElement::replaceTextInRange):
1509
1510 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1511
1512         AX: Support API: accessibilityReplaceRange:withText
1513         https://bugs.webkit.org/show_bug.cgi?id=196636
1514
1515         Unreviewed build fix for Windows port.
1516
1517         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1518         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1519
1520 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1521
1522         [CMake][WinCairo] Separate copied headers into different directories
1523         https://bugs.webkit.org/show_bug.cgi?id=196655
1524
1525         Reviewed by Michael Catanzaro.
1526
1527         * DumpRenderTree/CMakeLists.txt:
1528         * MiniBrowser/win/CMakeLists.txt:
1529         * TestWebKitAPI/CMakeLists.txt:
1530         * TestWebKitAPI/PlatformWin.cmake:
1531
1532 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1533
1534         Log stack-trace for run-webkit-tests when interrupted
1535         https://bugs.webkit.org/show_bug.cgi?id=176393
1536         <rdar://problem/34262310>
1537
1538         Reviewed by Lucas Forschler.
1539
1540         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1541         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1542         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1543         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1544         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1545         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1546         (main): Set handlers to log stack trace on interruption.
1547
1548 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1549
1550         AX: Support API: accessibilityReplaceRange:withText
1551         https://bugs.webkit.org/show_bug.cgi?id=196636
1552
1553         Unreviewed build fix for Windows port.
1554
1555         * DumpRenderTree/AccessibilityUIElement.cpp:
1556         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1557
1558 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1559
1560         [ews-build] Scripts using Buildbot API have CORS error
1561         https://bugs.webkit.org/show_bug.cgi?id=196709
1562
1563         Reviewed by Alexey Proskuryakov.
1564
1565         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1566
1567 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1568
1569         AX: Support API: accessibilityReplaceRange:withText
1570         https://bugs.webkit.org/show_bug.cgi?id=196636
1571
1572         Reviewed by Daniel Bates.
1573
1574         * DumpRenderTree/AccessibilityUIElement.cpp:
1575         (replaceTextInRangeCallback):
1576         (AccessibilityUIElement::replaceTextInRange):
1577         (AccessibilityUIElement::getJSClass):
1578         * DumpRenderTree/AccessibilityUIElement.h:
1579         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1580         (AccessibilityUIElement::replaceTextInRange):
1581         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1582         (AccessibilityUIElement::replaceTextInRange):
1583         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1584         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1585         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1586         (WTR::AccessibilityUIElement::replaceTextInRange):
1587         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1588         (WTR::AccessibilityUIElement::replaceTextInRange):
1589
1590 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1591
1592         [iOS] Do not allow starting selection drags when selection views are not visible
1593         https://bugs.webkit.org/show_bug.cgi?id=196686
1594         <rdar://problem/49399192>
1595
1596         Reviewed by Tim Horton.
1597
1598         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1599         also add some new API tests to cover scenarios where the web view is not first responder.
1600
1601         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1602         (TestWebKitAPI::TEST):
1603         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1604
1605         Add a switch to optionally make the web view first responder when starting the simulated drag.
1606
1607         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1608         (-[DragAndDropSimulator initWithWebView:]):
1609         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1610
1611 2019-04-08  Justin Fan  <justin_fan@apple.com>
1612
1613         [Web GPU] Fix Web GPU experimental feature on iOS
1614         https://bugs.webkit.org/show_bug.cgi?id=196632
1615
1616         Reviewed by Myles C. Maxfield.
1617
1618         Properly make Web GPU available on iOS 11+.
1619
1620         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1621
1622 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1623
1624         [ews-build] Do not upload archive when Compile Fails
1625         https://bugs.webkit.org/show_bug.cgi?id=196674
1626
1627         Reviewed by Alexey Proskuryakov.
1628
1629         * BuildSlaveSupport/ews-build/factories.py:
1630         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1631         * BuildSlaveSupport/ews-build/steps.py:
1632         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1633         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1634         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1635
1636 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1637
1638         Enable DFG on MIPS
1639         https://bugs.webkit.org/show_bug.cgi?id=196689
1640
1641         Reviewed by Žan Doberšek.
1642
1643         Since the bytecode change, we enabled the baseline JIT on mips in
1644         r240432, but DFG is still missing. With this change, all tests are
1645         passing on a ci20 board.
1646
1647         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1648
1649 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1650
1651         [Flatpak] Second run update-webkitwpe-flatpak fails
1652         https://bugs.webkit.org/show_bug.cgi?id=192702
1653
1654         Reviewed by Carlos Garcia Campos.
1655
1656         * flatpak/flatpakutils.py:
1657         (FlatpakObject.flatpak): Fix typo.
1658         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1659         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1660
1661 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1662
1663         [GTK][WPE] outlook.live.com displays old-fashioned UI
1664         https://bugs.webkit.org/show_bug.cgi?id=196642
1665
1666         Reviewed by Carlos Garcia Campos.
1667
1668         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1669         (TestWebKitAPI::TEST): New Mac platform quirk test.
1670
1671 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1672
1673         Unreviewed, rolling out r243956.
1674         https://bugs.webkit.org/show_bug.cgi?id=196688
1675
1676         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1677         by aakashjain on #webkit).
1678
1679         Reverted changeset:
1680
1681         "Clicking "Go Back" from a safe browsing warning from an
1682         iframe should navigate the WKWebView back to the previous
1683         page"
1684         https://bugs.webkit.org/show_bug.cgi?id=196665
1685         https://trac.webkit.org/changeset/243956
1686
1687 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1688
1689         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1690         https://bugs.webkit.org/show_bug.cgi?id=196669
1691
1692         Reviewed by Geoffrey Garen.
1693
1694         Added three new unit tests for WeakHashSet.
1695
1696         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1697         (WTF_WeakPtr.WeakHashSetConstObjects):
1698         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1699         (WTF_WeakPtr.WeakHashSetComputeSize):
1700
1701 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1702
1703         Hide next and previous form control buttons when WKWebView is editable
1704         https://bugs.webkit.org/show_bug.cgi?id=196672
1705         <rdar://problem/35625321>
1706
1707         Reviewed by Tim Horton.
1708
1709         Add a new API test.
1710
1711         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1712         (-[TestWKWebView lastTrailingBarButtonGroup]):
1713         (TestWebKitAPI::TEST):
1714         * TestWebKitAPI/ios/UIKitSPI.h:
1715
1716 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1717
1718         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1719         https://bugs.webkit.org/show_bug.cgi?id=196077
1720         <rdar://problem/49108202>
1721
1722         Reviewed by Chris Dumez.
1723
1724         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1725         on new web view.
1726
1727         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1728
1729 2019-04-05  Saam Barati  <sbarati@apple.com>
1730
1731         Make compare-results understand MotionMark
1732         https://bugs.webkit.org/show_bug.cgi?id=196666
1733
1734         Reviewed by Yusuke Suzuki.
1735
1736         * Scripts/compare-results:
1737         (PLT5Results):
1738         (detectMotionMark):
1739         (detectMotionMark1_1):
1740         (motionMarkResults):
1741         (motionMark1_1Results):
1742         (detectBenchmark):
1743         (biggerIsBetter):
1744         (main):
1745
1746 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1747
1748         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1749         https://bugs.webkit.org/show_bug.cgi?id=196665
1750         <rdar://45115669>
1751
1752         Reviewed by Geoff Garen.
1753
1754         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1755         (goBack):
1756         (+[SimpleLookupContext sharedLookupContext]):
1757         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1758         (TEST):
1759         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1760         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1761
1762 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1763
1764         [ews-build] Add configuration and architecture for windows builders
1765         https://bugs.webkit.org/show_bug.cgi?id=196660
1766
1767         Reviewed by Lucas Forschler.
1768
1769         * BuildSlaveSupport/ews-build/config.json:
1770
1771 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1772
1773         webkitpy: Don't run subsequent rounds if interrupted
1774         https://bugs.webkit.org/show_bug.cgi?id=196646
1775
1776         Reviewed by Aakash Jain.
1777
1778         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1779         (Manager.run): Bail out if interrupted.
1780
1781 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1782
1783         Test sessionStorage in PSON private browsing mode
1784         https://bugs.webkit.org/show_bug.cgi?id=196561
1785
1786         Reviewed by Alex Christensen.
1787
1788         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1789
1790 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1791
1792         Unreviewed, rolling out r243833.
1793         https://bugs.webkit.org/show_bug.cgi?id=196645
1794
1795         This change breaks build of WPE and GTK ports (Requested by
1796         annulen on #webkit).
1797
1798         Reverted changeset:
1799
1800         "[CMake][WTF] Mirror XCode header directories"
1801         https://bugs.webkit.org/show_bug.cgi?id=191662
1802         https://trac.webkit.org/changeset/243833
1803
1804 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1805
1806         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1807         https://bugs.webkit.org/show_bug.cgi?id=196635
1808
1809         Reviewed by Antti Koivisto.
1810         
1811         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1812         for a test to enable async frame scrolling via:
1813             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1814         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1815         
1816         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1817
1818         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1819         (WTR::InjectedBundle::beginTesting):
1820         * WebKitTestRunner/TestController.cpp:
1821         (WTR::TestController::resetPreferencesToConsistentValues):
1822
1823 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1824
1825         Use a correct LC_RPATH when building with ASan
1826         https://bugs.webkit.org/show_bug.cgi?id=196576
1827
1828         Reviewed by David Kilzer.
1829
1830         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1831         so that ../Frameworks is checked. This is simpler and more reliable than updating
1832         each SPC service xcconfig.
1833
1834 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1835
1836         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1837         https://bugs.webkit.org/show_bug.cgi?id=196629
1838
1839         Reviewed by Lucas Forschler.
1840
1841         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1842
1843 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1844
1845         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1846         https://bugs.webkit.org/show_bug.cgi?id=196618
1847
1848         Reviewed by Lucas Forschler.
1849
1850         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1851         (StatusBubble): Added QUEUE_TRIGGERS.
1852         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1853         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1854         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1855         its parent(builder).
1856
1857 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1858
1859         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1860         https://bugs.webkit.org/show_bug.cgi?id=196625
1861
1862         Reviewed by Lucas Forschler.
1863
1864         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1865         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1866
1867 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1868
1869         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1870         https://bugs.webkit.org/show_bug.cgi?id=196630
1871
1872         Reviewed by Wenson Hsieh.
1873
1874         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1875
1876 2019-04-04  Youenn Fablet  <youenn@apple.com>
1877
1878         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1879         https://bugs.webkit.org/show_bug.cgi?id=196543
1880
1881         Reviewed by Alex Christensen.
1882
1883         * WebKitTestRunner/TestController.cpp:
1884         (WTR::TestController::generatePageConfiguration):
1885
1886 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1887
1888         [ews-app] Status bubble should not display skipped buildbot steps
1889         https://bugs.webkit.org/show_bug.cgi?id=196584
1890
1891         Reviewed by Lucas Forschler.
1892
1893         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1894
1895 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1896
1897         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1898         https://bugs.webkit.org/show_bug.cgi?id=196620
1899
1900         Reviewed by Lucas Forschler.
1901
1902         * BuildSlaveSupport/ews-app/ews/config.py:
1903
1904 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1905
1906         [Win] DumpRenderTreeWatchDog.py is not checked into source
1907         https://bugs.webkit.org/show_bug.cgi?id=196567
1908         <rdar://problem/49525901>
1909
1910         Reviewed by Lucas Forschler.
1911
1912         This script is used on Win EWS bots to terminate hanging DRT processes.
1913
1914         * EWSTools/dumprendertreewatchdog.py: Added.
1915
1916 2019-04-04  Chris Dumez  <cdumez@apple.com>
1917
1918         Unreviewed, roll out r243858 which made tests time out.
1919
1920         Disable new API tests on Windows instead.
1921
1922         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1923         (TestWebKitAPI::TEST):
1924
1925 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1926
1927         [ATK] Cleanup WebPageAccessibilityObjectAtk
1928         https://bugs.webkit.org/show_bug.cgi?id=196537
1929
1930         Reviewed by Michael Catanzaro.
1931
1932         Also consider files under atk directories as exceptions for GObject conventions.
1933
1934         * Scripts/webkitpy/style/checkers/cpp.py:
1935         (check_identifier_name_in_declaration):
1936
1937 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1938
1939         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1940         https://bugs.webkit.org/show_bug.cgi?id=196588
1941         <rdar://problem/49365787>
1942
1943         Unreviewed build fix for Windows port.
1944
1945         error C3861: 'kill': identifier not found
1946
1947         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1948         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1949
1950 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1951
1952         [ews-build] Cancel build and similar operations should have authentication
1953         https://bugs.webkit.org/show_bug.cgi?id=196520
1954
1955         Reviewed by Dewei Zhu.
1956
1957         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1958         environment variables.
1959
1960 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1961
1962         [ews-build] Do not trigger queues which are not in production yet
1963         https://bugs.webkit.org/show_bug.cgi?id=196581
1964
1965         Reviewed by Dewei Zhu.
1966
1967         * BuildSlaveSupport/ews-build/config.json:
1968
1969 2019-04-03  Chris Dumez  <cdumez@apple.com>
1970
1971         Unreviewed, fix typo in the name of API test added in r243848.
1972
1973         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1974         (TestWebKitAPI::TEST):
1975
1976 2019-04-03  Chris Dumez  <cdumez@apple.com>
1977
1978         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1979         https://bugs.webkit.org/show_bug.cgi?id=196588
1980         <rdar://problem/49365787>
1981
1982         Reviewed by Ryosuke Niwa.
1983
1984         Add API test coverage.
1985
1986         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1987         (TestWebKitAPI::nullJavaScriptCallback):
1988         (TestWebKitAPI::didCrashCheckFrames):
1989         (TestWebKitAPI::TEST):
1990
1991 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1992
1993         run-webkit-tests: Upload test results (new results database)
1994         https://bugs.webkit.org/show_bug.cgi?id=196577
1995         <rdar://problem/34841155>
1996
1997         Reviewed by Lucas Forschler.
1998
1999         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2000         (Manager.run): Upload results after each device shard, since the configuration will be
2001         different for each device.
2002         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2003         uploaded to a results database.
2004         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2005         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2006
2007 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2008
2009         -apple-trailing-word is needed for browser detection
2010         https://bugs.webkit.org/show_bug.cgi?id=196575
2011
2012         Unreviewed.
2013
2014         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2015
2016 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2017
2018         [CMake][WTF] Mirror XCode header directories
2019         https://bugs.webkit.org/show_bug.cgi?id=191662
2020
2021         Reviewed by Konstantin Tokarev.
2022
2023         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2024         builds.
2025
2026         * CMakeLists.txt:
2027         * DumpRenderTree/CMakeLists.txt:
2028         * DumpRenderTree/PlatformWin.cmake:
2029         * MiniBrowser/win/CMakeLists.txt:
2030         * TestWebKitAPI/CMakeLists.txt:
2031         * TestWebKitAPI/PlatformWin.cmake:
2032         * WebKitTestRunner/PlatformGTK.cmake:
2033         * WebKitTestRunner/PlatformWin.cmake:
2034
2035 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2036
2037         [ews-app] Status bubble should not display certain infrastructure status messages
2038         https://bugs.webkit.org/show_bug.cgi?id=196550
2039
2040         Reviewed by Lucas Forschler.
2041
2042         Do not display the steps which are un-needed for end-user. This information is still avaiable
2043         if the user click on the bubble and look at the Buildbot build.
2044         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2045         (StatusBubble._steps_messages):
2046         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2047
2048 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2049
2050         [ews-build] Use https for sending data to ews-app
2051         https://bugs.webkit.org/show_bug.cgi?id=196492
2052
2053         Reviewed by Lucas Forschler.
2054
2055         * BuildSlaveSupport/ews-build/events.py:
2056
2057 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2058
2059         Remove support for -apple-trailing-word
2060         https://bugs.webkit.org/show_bug.cgi?id=196525
2061
2062         Reviewed by Zalan Bujtas.
2063
2064         This CSS property is nonstandard and not used.
2065
2066         * Scripts/webkitperl/FeatureList.pm:
2067         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2068
2069 2019-04-03  Youenn Fablet  <youenn@apple.com>
2070
2071         Add a test for DOMCache on multiple browsing in case of private browsing
2072         https://bugs.webkit.org/show_bug.cgi?id=196524
2073
2074         Reviewed by Alex Christensen.
2075
2076         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2077         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2078
2079 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2080
2081         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2082         https://bugs.webkit.org/show_bug.cgi?id=196540
2083
2084         Reviewed by Aakash Jain.
2085
2086         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2087
2088 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2089
2090         Add plumbing for a compatibility mode preference in WebKit
2091         https://bugs.webkit.org/show_bug.cgi?id=196005
2092
2093         Reviewed by Tim Horton.
2094
2095         Add new API tests.
2096
2097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2098         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2099
2100 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2101
2102         [WPE][GTK] Update libsrtp dependency package for Debian
2103         https://bugs.webkit.org/show_bug.cgi?id=196528
2104
2105         Reviewed by Frédéric Wang.
2106
2107         * gtk/install-dependencies:
2108         * wpe/install-dependencies:
2109
2110 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2111
2112         [WK2] Add support for Window's beforeprint / afterprint events
2113         https://bugs.webkit.org/show_bug.cgi?id=196478
2114         <rdar://problem/49535124>
2115
2116         Unreviewed build fix for MSVC.
2117
2118         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2119
2120         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2121
2122         * WebKitTestRunner/TestController.cpp:
2123         (WTR::printFrame): Use int and float literals.
2124
2125 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2126
2127         [ews-build] Reassign bots to queues
2128
2129         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2130
2131 2019-04-02  Chris Dumez  <cdumez@apple.com>
2132
2133         [WK2] Add support for Window's beforeprint / afterprint events
2134         https://bugs.webkit.org/show_bug.cgi?id=196478
2135
2136         Reviewed by Alex Christensen.
2137
2138         Add minimal implementation for printFrame in WebKitTestRunner.
2139
2140         * WebKitTestRunner/TestController.cpp:
2141         (WTR::printFrame):
2142         (WTR::TestController::createOtherPage):
2143         (WTR::TestController::createWebViewWithOptions):
2144
2145 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2146
2147         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2148         https://bugs.webkit.org/show_bug.cgi?id=196491
2149
2150         Reviewed by Lucas Forschler.
2151
2152         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2153
2154 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2155
2156         [ews-build] Configure buildbot try credentials in environment variables
2157         https://bugs.webkit.org/show_bug.cgi?id=196501
2158
2159         Reviewed by Lucas Forschler.
2160
2161         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2162         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2163         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2164
2165 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2166
2167         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2168         https://bugs.webkit.org/show_bug.cgi?id=196496
2169         <rdar://problem/49521634>
2170
2171         Reviewed by Chris Dumez.
2172
2173         Add new API tests (see WebKit ChangeLog for more detail).
2174
2175         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2176         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2177         (TEST):
2178
2179 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2180
2181         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2182         <https://webkit.org/b/196499>
2183
2184         Reviewed by Alexey Proskuryakov.
2185
2186         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2187         ENABLE_ADDRESS_SANITIZER.
2188
2189 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2190
2191         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2192         https://bugs.webkit.org/show_bug.cgi?id=182757
2193
2194         Reviewed by Don Olmstead.
2195
2196         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2197         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2198
2199 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2200
2201         run-api-tests: Upload test results
2202         https://bugs.webkit.org/show_bug.cgi?id=196323
2203         <rdar://problem/49356714>
2204
2205         Reviewed by Lucas Forschler.
2206
2207         * Scripts/webkitpy/api_tests/manager.py:
2208         (Manager):
2209         (Manager.run): Upload results to a results database.
2210         * Scripts/webkitpy/api_tests/run_api_tests.py:
2211         (parse_args): Add upload arguments.
2212         * Scripts/webkitpy/port/base.py:
2213         (Port):
2214         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2215         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2216         with commits from any other associated repositories.
2217         * Scripts/webkitpy/port/device.py:
2218         (Device):
2219         (Device.build_version): Access build_versoin of underlying platform device.
2220         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2221         (IOSSimulatorTest):
2222         (IOSSimulatorTest.test_configuration_for_upload):
2223         * Scripts/webkitpy/port/device_port.py:
2224         (DevicePort):
2225         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2226         the same as the machine uploading results.
2227         * Scripts/webkitpy/port/mac.py:
2228         (MacPort):
2229         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2230         * Scripts/webkitpy/port/mac_unittest.py:
2231         (MacTest):
2232         (MacTest.test_configuration_for_upload):
2233         * Scripts/webkitpy/xcode/simulated_device.py:
2234         (SimulatedDeviceManager._create_device_with_runtime):
2235         (SimulatedDevice.__init__): Create simulated device with a build_version.
2236         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2237         (test_existing_simulator):
2238
2239 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2240
2241         Remove extra newline characters (Follow-up fix to r243707)
2242
2243         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2244
2245 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2246
2247         [ews-app] Use API_KEY to accept results data
2248         https://bugs.webkit.org/show_bug.cgi?id=196461
2249
2250         Reviewed by Dewei Zhu.
2251
2252         * BuildSlaveSupport/ews-app/ews/views/results.py:
2253         (Results.post): Validate EWS_API_KEY before accepting any data.
2254         * BuildSlaveSupport/ews-build/events.py:
2255         (Events.sendData): Send EWS_API_KEY if available along with event data.
2256
2257 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2258
2259         Unable to copy and paste a PDF from Notes into Mail compose body
2260         https://bugs.webkit.org/show_bug.cgi?id=196442
2261         <rdar://problem/48573098>
2262
2263         Reviewed by Tim Horton.
2264
2265         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2266         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2267         to be specified on the item providers.
2268
2269         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2270         (TestWebKitAPI::mapItemForTesting):
2271         (TestWebKitAPI::contactItemForTesting):
2272
2273 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2274
2275         Make UIWKDocumentContext rects per-character instead of per-word
2276         https://bugs.webkit.org/show_bug.cgi?id=196459
2277
2278         Reviewed by Wenson Hsieh.
2279
2280         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2281         (TEST):
2282         Adjust test results due to switching to per-character rects.
2283
2284 2019-04-01  Chris Dumez  <cdumez@apple.com>
2285
2286         UIProcess crash when a prewarmed process is terminated
2287         https://bugs.webkit.org/show_bug.cgi?id=196451
2288         <rdar://problem/49245471>
2289
2290         Reviewed by Geoffrey Garen.
2291
2292         Add API test coverage.
2293
2294         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2295         (TEST):
2296
2297 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2298
2299         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2300         https://bugs.webkit.org/show_bug.cgi?id=196449
2301
2302         Reviewed by Lucas Forschler.
2303
2304         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2305         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2306         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2307         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2308
2309 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2310
2311         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2312         https://bugs.webkit.org/show_bug.cgi?id=196444
2313
2314         Reviewed by Lucas Forschler.
2315
2316         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2317
2318 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2319
2320         Add SPI to canonicalize NSURLs with WTF::URL
2321         https://bugs.webkit.org/show_bug.cgi?id=196415
2322         <rdar://problem/44980271>
2323
2324         Reviewed by Darin Adler.
2325
2326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2327         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2328         (TestWebKitAPI::TEST):
2329
2330 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2331
2332         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2333         https://bugs.webkit.org/show_bug.cgi?id=196441
2334
2335         Reviewed by Carlos Garcia Campos.
2336
2337         Don't cache the wpe_view_backend object that might not exist yet at the
2338         time of EventSenderProxy constructor invocation, but instead retrieve
2339         that object whenever it's required for event dispatching. This should
2340         avoid crashes in this constructor now that it's invoked before any
2341         PlatformWindow has been set up (as changed in r243496).
2342
2343         * WebKitTestRunner/EventSenderProxy.h:
2344         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2345         (WTR::viewBackend):
2346         (WTR::EventSenderProxy::EventSenderProxy):
2347         (WTR::EventSenderProxy::mouseDown):
2348         (WTR::EventSenderProxy::mouseUp):
2349         (WTR::EventSenderProxy::mouseMoveTo):
2350         (WTR::EventSenderProxy::mouseScrollBy):
2351         (WTR::EventSenderProxy::keyDown):
2352         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2353
2354 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2355
2356         [Win][WebKit] MiniBrowser should support high DPI display
2357         https://bugs.webkit.org/show_bug.cgi?id=196391
2358
2359         Reviewed by Alex Christensen.
2360
2361         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2362         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2363         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2364         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2365
2366 2019-03-31  Sam Weinig  <weinig@apple.com>
2367
2368         Remove more i386 specific configurations
2369         https://bugs.webkit.org/show_bug.cgi?id=196430
2370
2371         Reviewed by Alexey Proskuryakov.
2372
2373         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2374         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2375
2376 2019-03-31  Andy Estes  <aestes@apple.com>
2377
2378         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2379         https://bugs.webkit.org/show_bug.cgi?id=196433
2380         <rdar://problem/49293305>
2381
2382         Reviewed by Tim Horton.
2383
2384         Enhanced API test coverage to include all navigation response policy decisions in both
2385         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2386
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2389         (TestWebKitAPI::TEST):
2390         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2391         (readFile):
2392         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2393         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2394         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2395         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2396         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2397         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2398         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2399         (-[QuickLookDelegate _downloadDidStart:]):
2400         (-[QuickLookDelegate _download:didReceiveResponse:]):
2401         (-[QuickLookDelegate _download:didReceiveData:]):
2402         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2403         (-[QuickLookDelegate _downloadDidFinish:]):
2404         (-[QuickLookDelegate _download:didFailWithError:]):
2405         (-[QuickLookDelegate _downloadDidCancel:]):
2406         (-[QuickLookDelegate verifyDownload]):
2407         (runTest):
2408         (runTestDecideBeforeLoading):
2409         (runTestDecideAfterLoading):
2410         (TEST):
2411         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2412         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2413         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2414         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2415         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2416         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2417         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2418         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2419         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2420         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2421         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2422         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2423         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2424         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2425
2426 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2427
2428         [CMake] add testdfg as target with build-jsc
2429         https://bugs.webkit.org/show_bug.cgi?id=196393
2430
2431         Reviewed by Saam Barati.
2432
2433         Added testdfg as one of the targets to build when
2434         using CMake.
2435
2436         * Scripts/build-jsc:
2437
2438 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2439
2440         Delete WebMetal implementation in favor of WebGPU
2441         https://bugs.webkit.org/show_bug.cgi?id=195418
2442
2443         Reviewed by Dean Jackson.
2444
2445         * DumpRenderTree/mac/DumpRenderTree.mm:
2446         (enableExperimentalFeatures):
2447         (resetWebPreferencesToConsistentValues):
2448         * Scripts/webkitperl/FeatureList.pm:
2449         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2451         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2452         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2453         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2454         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2455         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2456         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2457         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2458         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2459         (WTR::InjectedBundle::beginTesting):
2460         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2461         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2462         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2463
2464 2019-03-29  Chris Dumez  <cdumez@apple.com>
2465
2466         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2467         https://bugs.webkit.org/show_bug.cgi?id=196405
2468         <rdar://problem/49428130>
2469
2470         Reviewed by Wenson Hsieh.
2471
2472         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2473         the popover presentation methods to be no-ops. Use this in the new test added in
2474         r243523 so that we do not swizzle those methods for all tests. This is needed because
2475         those WatchOS tests rely on the popover getting presented and interactive.
2476
2477         * WebKitTestRunner/TestController.cpp:
2478         (WTR::updateTestOptionsFromTestHeader):
2479         * WebKitTestRunner/TestController.h:
2480         * WebKitTestRunner/TestOptions.h:
2481         (WTR::TestOptions::hasSameInitializationOptions const):
2482         * WebKitTestRunner/ios/TestControllerIOS.mm:
2483         (WTR::TestController::platformInitialize):
2484         (WTR::TestController::platformResetStateToConsistentValues):
2485
2486 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2487
2488         [Curl] Add Server Trust Evaluation Support.
2489         https://bugs.webkit.org/show_bug.cgi?id=191646
2490
2491         Reviewed by Fujii Hironori.
2492
2493         Implemented MiniBrowser UI for asking if user trusts the server.
2494
2495         * MiniBrowser/win/Common.cpp:
2496         (askServerTrustEvaluation):
2497         (replaceString):
2498         * MiniBrowser/win/Common.h:
2499         * MiniBrowser/win/MiniBrowserLib.rc:
2500         * MiniBrowser/win/MiniBrowserLibResource.h:
2501         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2502         (createPEMString):
2503         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2504         (WebKitBrowserWindow::canTrustServerCertificate):
2505         * MiniBrowser/win/WebKitBrowserWindow.h:
2506
2507 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2508
2509         Implement ResizeObserver.
2510         https://bugs.webkit.org/show_bug.cgi?id=157743
2511
2512         Reviewed by Simon Fraser.
2513
2514         Support resizeObserverEnabled webPreferences.
2515
2516         * DumpRenderTree/TestOptions.cpp:
2517         (TestOptions::TestOptions):
2518         * DumpRenderTree/TestOptions.h:
2519         * DumpRenderTree/mac/DumpRenderTree.mm:
2520         (setWebPreferencesForTestOptions):
2521         * DumpRenderTree/win/DumpRenderTree.cpp:
2522         (enableExperimentalFeatures):
2523         * Scripts/webkitperl/FeatureList.pm:
2524         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2525
2526 2019-03-28  John Wilander  <wilander@apple.com>
2527
2528         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2529         https://bugs.webkit.org/show_bug.cgi?id=196281
2530         <rdar://problem/48938748>
2531
2532         Reviewed by Alex Christensen.
2533
2534         This patch adds the function isStatisticsHasLocalStorage() to the
2535         TestRunner. With it, the page can query the WebsiteDataStore in the
2536         UI process to make sure that it sees LocalStorage.
2537
2538         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2539         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2540         (WTR::TestRunner::isStatisticsHasLocalStorage):
2541         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2542         * WebKitTestRunner/TestController.cpp:
2543         (WTR::TestController::isStatisticsHasLocalStorage):
2544         * WebKitTestRunner/TestController.h:
2545         * WebKitTestRunner/TestInvocation.cpp:
2546         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2547
2548 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2549
2550         API::Data::createWithoutCopying should do a null check before calling CFRelease
2551         https://bugs.webkit.org/show_bug.cgi?id=196276
2552         <rdar://problem/48059859>
2553
2554         Reviewed by Alex Christensen.
2555
2556         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2557
2558         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2559         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2560         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2561         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2562         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2563         (TestWebKitAPI::TEST):
2564
2565 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2566
2567         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2568         https://bugs.webkit.org/show_bug.cgi?id=186276
2569
2570         Reviewed by Carlos Garcia Campos.
2571
2572         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2573         (webViewLoadChanged):
2574         (testWebResourceGetDataError):
2575         (testWebResourceGetDataEmpty):
2576         (beforeAll):
2577         (webViewloadChanged): Deleted.
2578
2579 2019-03-27  Andy Estes  <aestes@apple.com>
2580
2581         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2582         https://bugs.webkit.org/show_bug.cgi?id=196317
2583
2584         Reviewed by Dan Bernstein.
2585
2586         package-root copies built products into a staging directory using ditto(1), which does not
2587         follow symbolic links as it traverses a directory. Now that the files in
2588         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2589         itself, these become broken links when ditto'd into the staging directory.
2590
2591         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2592
2593         * Scripts/package-root:
2594
2595 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2596
2597         [ews-app] Update display text of Submit for ews analysis
2598         https://bugs.webkit.org/show_bug.cgi?id=196309
2599
2600         Reviewed by Dewei Zhu.
2601
2602         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2603
2604 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2605
2606         run-webkit-tests should check for leaks in WebKit processes
2607         <https://webkit.org/b/193772>
2608         <rdar://problem/46526680>
2609
2610         Reviewed by Ryosuke Niwa.
2611
2612         This works by doing the following:
2613         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2614           The list of child processes are returned one per line:
2615           process.name: pid
2616         - Run the "#LIST CHILD PROCESSES" command just before the
2617           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2618           processes on the ServerProcess object.
2619         - When the `--leaks` switch is handled, run check_for_leaks() on
2620           each child process after the main test harness.
2621
2622         * DumpRenderTree/mac/DumpRenderTree.mm:
2623         (handleControlCommand):
2624         - Use strncmp() instead of strcmp().
2625         - Add support for handling "#LIST CHILD PROCESSES" command.
2626
2627         * Scripts/webkitpy/port/base.py:
2628         (Port.check_for_leaks):
2629         * Scripts/webkitpy/port/darwin.py:
2630         (DarwinPort.check_for_leaks):
2631         - Rename redundant 'process_pid' argument to 'process_id'.
2632
2633         * Scripts/webkitpy/port/driver.py:
2634         (Driver.do_post_tests_work):
2635         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2636           longer the only command this sends to WebKitTestRunner.
2637         - If the `--leaks` switch is present, send the
2638           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2639           result using Port.set_webkit_processes().
2640         (Driver._parse_child_processes_output):
2641         - Add helper method to parse list of child process names and
2642           process IDs returned from WebKitTestRunner.
2643
2644         * Scripts/webkitpy/port/ios_device.py:
2645         (IOSDevicePort.check_for_leaks):
2646         - Rename redundant 'process_pid' argument to 'process_id'.
2647
2648         * Scripts/webkitpy/port/leakdetector.py:
2649         (LeakDetector._parse_leaks_output):
2650         - Return early if there is no leaks_output.
2651         (LeakDetector.check_for_leaks):
2652         - Rename redundant 'process_pid' argument to 'process_id'.
2653
2654         * Scripts/webkitpy/port/server_process.py:
2655         (ServerProcess.__init__):
2656         (ServerProcess.child_processes):
2657         (ServerProcess.set_child_processes):
2658         - Add instance variable to Port to store list of child process
2659           names and process IDs returned from WebKitTestRunner.
2660         (ServerProcess._start):
2661         - Clear self._child_processes.
2662         (ServerProcess.stop):
2663         - If self._child_processes is set, call
2664           self._port.check_for_leaks() for each child process.
2665
2666         * Scripts/webkitpy/port/server_process_unittest.py:
2667         (TrivialMockPort.check_for_leaks):
2668         - Rename redundant 'process_pid' argument to 'process_id'.
2669
2670         * Scripts/webkitpy/port/simulator_process.py:
2671         (SimulatorProcess.stop):
2672         - If self._child_processes is set, call
2673           self._port.check_for_leaks() for each child process.
2674
2675         * Scripts/webkitpy/port/watch_device.py:
2676         (WatchDevicePort.check_for_leaks):
2677         - Rename redundant 'process_pid' argument to 'process_id'.
2678
2679         * WebKitTestRunner/TestController.cpp:
2680         (WTR::TestController::dumpResponse):
2681         - Extract method from findAndDumpWorldLeaks() so that it may be
2682           reused by findAndDumpWebKitProcessIdentifiers().
2683         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2684         - Add method to output process name and process ID of both the
2685           WebContent and Networking processes.
2686         (WTR::TestController::findAndDumpWorldLeaks):
2687         - Fix missing newline in output when there were no abandoned
2688           documents.
2689         - Call dumpResponse() for extracted code.
2690         (WTR::TestController::handleControlCommand):
2691         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2692         - Use strncmp() instead of strcmp().
2693         - Call findAndDumpWebKitProcessIdentifiers() when
2694           "#LIST CHILD PROCESSES" command is sent.
2695         * WebKitTestRunner/TestController.h:
2696         (WTR::TestController::dumpResponse):
2697         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2698         - Declare methods.
2699
2700 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2701
2702         Unreviewed. Add GLib API test cases after r243434.
2703
2704         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2705         (testWebViewActiveURI):
2706         (serverCallback):
2707         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2708         (sendRequestCallback):
2709
2710 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2711
2712         Geolocation request not complete when watch request was started in a different web process
2713         https://bugs.webkit.org/show_bug.cgi?id=195996
2714
2715         Reviewed by Alex Christensen.
2716
2717         Add a test case.
2718
2719         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2720         (TestWebKitAPI::runJavaScriptAlert):
2721         (TestWebKitAPI::TEST):
2722
2723 2019-03-26  Keith Rollin  <krollin@apple.com>
2724
2725         Update the way generate-xcfilelists returns strings from functions
2726         https://bugs.webkit.org/show_bug.cgi?id=195975
2727         <rdar://problem/49040807>
2728
2729         Reviewed by Dean Jackson.
2730
2731         There are places where generate-xcfilelists executes assignments with
2732         statements like:
2733
2734             FOO=$(some_function)
2735
2736         where "some_function" return a string by echoing it. E.g.
2737
2738             some_function()
2739             {
2740                 echo "Hello, World"
2741             }
2742
2743         This is a common idiom, but it has a problem if "some_function" needs
2744         to call "exit" in an attempt to halt the entire script right then and
2745         there. Since "some_function" is called inside of $(), it's being
2746         executed in a sub-shell. Calling exit in that sub-shell simply exits
2747         that shell; it doesn't not exit the outer shell in which the main part
2748         of the script is still running. As such, the main script keeps
2749         executing when the intent was for the script to halt.
2750
2751         The solution to this is to use a different idiom for returning
2752         strings. The one we now is to pass in the name of the variable to
2753         receive the string result:
2754
2755             some_function()
2756             {
2757                 variable_name=$1
2758                 eval $variable_name ="Hello, World"
2759             }
2760
2761         The call site now looks like
2762
2763             some_function FOO
2764
2765         Because there's no invocation of a sub-shell, some_function can now
2766         call "exit" if it wants to, and the entire script will exit at that
2767         point.
2768
2769         * Scripts/generate-xcfilelists:
2770
2771 2019-03-26  Chris Dumez  <cdumez@apple.com>
2772
2773         Add basic layout test coverage for File Picker on iOS
2774         https://bugs.webkit.org/show_bug.cgi?id=196265
2775
2776         Reviewed by Wenson Hsieh.
2777
2778         Add layout test infrastructure to test the file picker on iOS.
2779
2780         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2781         (WTR::UIScriptController::dismissFilePicker):
2782         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2783         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2784         (WTR::UIScriptController::dismissFilePicker):
2785         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2786         * WebKitTestRunner/TestController.cpp:
2787         (WTR::TestController::createWebViewWithOptions):
2788         (WTR::updateTestOptionsFromTestHeader):
2789         * WebKitTestRunner/TestOptions.h:
2790         (WTR::TestOptions::hasSameInitializationOptions const):
2791         * WebKitTestRunner/ios/TestControllerIOS.mm:
2792         (overridePresentViewController):
2793         (WTR::TestController::platformInitialize):
2794         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2795         (WTR::UIScriptController::dismissFilePicker):
2796
2797 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2798
2799         Implement async paste method on UIWKInteractionViewProtocol
2800         https://bugs.webkit.org/show_bug.cgi?id=196267
2801         <rdar://problem/49236346>
2802
2803         Reviewed by Tim Horton.
2804
2805         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2806         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2807         are now a part of all iOS 12 internal SDKs.
2808
2809         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2810
2811         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2812         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2813
2814         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2815         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2816         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2817         * TestWebKitAPI/ios/UIKitSPI.h:
2818
2819 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2820
2821         [ews-build] Use PostgreSQL for ews.webkit.org database
2822         https://bugs.webkit.org/show_bug.cgi?id=196270
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2827
2828 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2829
2830         [ews] Reset simctl states on reboot
2831         https://bugs.webkit.org/show_bug.cgi?id=196260
2832
2833         Rubber-stamped by Aakash Jain.
2834
2835         * EWSTools/start-queue-mac.sh:
2836
2837 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2838
2839         [ews-build] Use PostgreSQL for ews-build database
2840         https://bugs.webkit.org/show_bug.cgi?id=196229
2841
2842         Reviewed by Lucas Forschler.
2843
2844         * BuildSlaveSupport/ews-build/master.cfg:
2845
2846 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2847
2848         [ews-build] Get master_hostname dynamically in master.cfg
2849         https://bugs.webkit.org/show_bug.cgi?id=196255
2850
2851         Reviewed by Lucas Forschler.
2852
2853         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2854         send events data in test mode.
2855
2856 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2857
2858         [ews-app] Set db_constraint to False for Foreign Keys
2859         https://bugs.webkit.org/show_bug.cgi?id=196252
2860
2861         Reviewed by Lucas Forschler.
2862
2863         * BuildSlaveSupport/ews-app/ews/models/build.py:
2864         * BuildSlaveSupport/ews-app/ews/models/step.py:
2865
2866 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2867
2868         [ews-build] is_test_mode_enabled should default to True
2869         https://bugs.webkit.org/show_bug.cgi?id=196248
2870
2871         Reviewed by Lucas Forschler.
2872
2873         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2874
2875 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2876
2877         [ews-app] Add webkitperl to ENABLED_QUEUES
2878         https://bugs.webkit.org/show_bug.cgi?id=196253
2879
2880         Reviewed by Lucas Forschler.
2881
2882         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2883
2884 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2885
2886         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2887         https://bugs.webkit.org/show_bug.cgi?id=196211
2888         rdar://problem/49110552
2889
2890         Reviewed by Tim Horton.
2891
2892         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2893         Make sure that EventSenderProxy always exists when running tests. We used to create
2894         it when resetting before the first test, which is a bit too late.
2895
2896         * WebKitTestRunner/TestController.h:
2897         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2898         (WTR::TestController::platformCreateWebView):
2899         (WTR::TestController::platformCreateOtherPage):
2900         (WTR::TestController::finishCreatingPlatformWebView):
2901         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2902         (WTR::PlatformWebView::PlatformWebView):
2903         Moved some code that made NSWindow use NSEvent during web view creation. We may
2904         need to move more if some other case us found, but this is enough for now.
2905
2906 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2907
2908         Unreviewed. Fix typo in GLib geolocation API after r243285.
2909
2910         gelocation -> geolocation.
2911
2912         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2913         (testGeolocationManagerWatchPosition):
2914
2915 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2916
2917         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2918         https://bugs.webkit.org/show_bug.cgi?id=196213
2919
2920         Reviewed by Geoff Garen.
2921
2922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2923         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2924         (credentialWithIdentityAndKeychainPath):
2925         (-[ChallengeDelegate webView:didFinishNavigation:]):
2926         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2927         (TestWebKitAPI::TEST):
2928
2929 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2930
2931         Expected shouldn't assume its contained types are copyable
2932         https://bugs.webkit.org/show_bug.cgi?id=195986
2933
2934         Reviewed by JF Bastien.
2935
2936         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2937         (TestWebKitAPI::NonCopyable::operator== const):
2938         (TestWebKitAPI::NonCopyable::operator!= const):
2939         (TestWebKitAPI::TEST):
2940
2941 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2942
2943         Remove some now-unnecessary dynamic class lookup
2944         https://bugs.webkit.org/show_bug.cgi?id=196237
2945
2946         Reviewed by Simon Fraser.
2947
2948         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2949         (makeRequest):
2950         (TEST):
2951
2952 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2953
2954         Unreviewed, rolling out r243450.
2955
2956         AppleWin and WinCairo port builds get broken.
2957
2958         Reverted changeset:
2959
2960         "Add test for fix of #196095"
2961         https://bugs.webkit.org/show_bug.cgi?id=196097
2962         https://trac.webkit.org/changeset/243450
2963
2964 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2965
2966         Unreviewed, rolling out r243465.
2967         https://bugs.webkit.org/show_bug.cgi?id=196226
2968
2969         the test doesn't build (Requested by thorton on #webkit).
2970
2971         Reverted changeset:
2972
2973         "Do not terminate the NetworkProcess if a third party
2974         application sends a NSCredential with a SecIdentityRef"
2975         https://bugs.webkit.org/show_bug.cgi?id=196213
2976         https://trac.webkit.org/changeset/243465
2977
2978 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2979
2980         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2981         https://bugs.webkit.org/show_bug.cgi?id=196213
2982
2983         Reviewed by Geoff Garen.
2984
2985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2986         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2987         (credentialWithIdentityAndKeychainPath):
2988         (-[ChallengeDelegate webView:didFinishNavigation:]):
2989         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2990         (TestWebKitAPI::TEST):
2991
2992 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2993
2994         [ews-build] Gracefully handle missing patch_id in events
2995         https://bugs.webkit.org/show_bug.cgi?id=196216
2996
2997         Reviewed by Lucas Forschler.
2998
2999         * BuildSlaveSupport/ews-build/events.py:
3000
3001 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3002
3003         [ews-build] use lz4 compression for improving buildbot performance
3004         https://bugs.webkit.org/show_bug.cgi?id=196155
3005
3006         Reviewed by Lucas Forschler.
3007
3008         * BuildSlaveSupport/ews-build/master.cfg:
3009
3010 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3011
3012         Pull some API testing helper methods out of TestWKWebView
3013         https://bugs.webkit.org/show_bug.cgi?id=196212
3014
3015         Reviewed by Tim Horton.
3016
3017         Refactor some more API testing utility methods, so that they can be used in
3018         tests that do not use TestWKWebView.
3019
3020         * TestWebKitAPI/cocoa/TestWKWebView.h:
3021         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3022         (-[WKWebView loadTestPageNamed:]):
3023         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3024         (-[WKWebView synchronouslyLoadHTMLString:]):
3025         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3026         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3027         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3028         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3029         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3030
3031 2019-03-25  Jer Noble  <jer.noble@apple.com>
3032
3033         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3034         https://bugs.webkit.org/show_bug.cgi?id=196097
3035
3036         Reviewed by Eric Carlson.
3037
3038         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3039
3040         * DumpRenderTree/mac/DumpRenderTree.mm:
3041         (resetWebPreferencesToConsistentValues):
3042         * WebKitTestRunner/TestController.cpp:
3043         (WTR::TestController::resetPreferencesToConsistentValues):
3044
3045 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3046
3047         Pull IPadUserInterfaceSwizzler out into a separate header file
3048         https://bugs.webkit.org/show_bug.cgi?id=196193
3049
3050         Reviewed by Anders Carlsson.
3051
3052         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3053         be used in other API tests.
3054
3055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3056         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3057         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3058         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3059         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3060         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3061         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3062
3063 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3064
3065         Remove NavigatorContentUtils in WebCore/Modules
3066         https://bugs.webkit.org/show_bug.cgi?id=196070
3067
3068         Reviewed by Alex Christensen.
3069
3070         NavigatorContentUtils was to support the custom scheme spec [1].
3071         However, in WebKit side, no port has supported the feature in
3072         WebKit layer after EFL port was removed. So there has been the
3073         only IDL implementation of the NavigatorContentUtils in WebCore.
3074         So we don't need to keep the implementation in WebCore anymore.
3075
3076         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3077
3078         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3079
3080 2019-03-24  Andy Estes  <aestes@apple.com>
3081
3082         [watchOS] Remove unused Proximity Networking code
3083         https://bugs.webkit.org/show_bug.cgi?id=196188
3084
3085         Reviewed by Tim Horton.
3086
3087         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3088         (TEST):
3089
3090 2019-03-23  Keith Miller  <keith_miller@apple.com>
3091
3092         Refactor clz/ctz and fix getLSBSet.
3093         https://bugs.webkit.org/show_bug.cgi?id=196162
3094
3095         Reviewed by Saam Barati.
3096
3097         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3098
3099         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3100         (TestWebKitAPI::TEST):
3101
3102 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3103
3104         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3105         https://bugs.webkit.org/show_bug.cgi?id=196143
3106
3107         Reviewed by Michael Catanzaro.
3108
3109         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3110         directories.
3111
3112         * Scripts/webkitpy/style/checkers/cpp.py:
3113         (check_identifier_name_in_declaration):
3114         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3115         (WebKitStyleTest.test_names):
3116
3117 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3118
3119         [Flatpak] Manifest expanding fails for qt WPE extension
3120         https://bugs.webkit.org/show_bug.cgi?id=196148
3121
3122         Reviewed by Alex Christensen.
3123
3124         * flatpak/flatpakutils.py:
3125         (expand_submodules_recurse): The last recurse manifest expand
3126         iteration might lead to a single module so take it into account
3127         and don't try to recurse further.
3128
3129 2019-03-22  Chris Dumez  <cdumez@apple.com>
3130
3131         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3132         https://bugs.webkit.org/show_bug.cgi?id=195348
3133         <rdar://problem/48622090>
3134
3135         Reviewed by Alex Christensen.
3136
3137         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3138         to NO when test.options().shouldIgnoreMetaViewport is false.
3139
3140         * WebKitTestRunner/ios/TestControllerIOS.mm:
3141         (WTR::TestController::platformConfigureViewForTest):
3142
3143 2019-03-22  Chris Dumez  <cdumez@apple.com>
3144
3145         Prewarmed processes should be usable with any website data store
3146         https://bugs.webkit.org/show_bug.cgi?id=196104
3147
3148         Reviewed by Alex Christensen.
3149
3150         Add API test coverage.
3151
3152         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3153         (runInitialWarmedProcessUsedTest):
3154         (TEST):
3155
3156 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3157
3158         Back out local changes to Alex's Subversion working directory
3159
3160         They were accidentally committed.
3161
3162         * Scripts/webkitpy/common/system/abstractexecutive.py:
3163         (AbstractExecutive.wait_newest):
3164         * Scripts/webkitpy/common/system/executive.py:
3165         (Executive.running_pids):
3166         * Scripts/webkitpy/common/system/executive_mock.py:
3167         (MockExecutive.running_pids):
3168         * Scripts/webkitpy/common/system/executive_unittest.py:
3169         (ExecutiveTest.serial_test_running_pids):
3170         * Scripts/webkitpy/port/darwin.py:
3171         (DarwinPort.check_for_leaks):
3172         * Scripts/webkitpy/port/leakdetector.py:
3173         (LeakDetector.check_for_leaks):
3174         - This was the hack attached to Bug 193772.
3175
3176         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3177         (+[WebKitTestRunnerEvent mouseLocation]):
3178         - This works around a crash on an internal build.
3179
3180 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3181
3182         Fix the build after r243354
3183         https://bugs.webkit.org/show_bug.cgi?id=196138
3184         <rdar://problem/49145951>
3185
3186         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3187         (TEST):
3188         * TestWebKitAPI/ios/UIKitSPI.h:
3189
3190 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3191
3192         Adopt UIWKDocumentContext
3193         https://bugs.webkit.org/show_bug.cgi?id=196040
3194         <rdar://problem/48642440>
3195
3196         Reviewed by Ryosuke Niwa.
3197
3198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3199         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3200         (makeRequest):
3201         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3202         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3203         (applyStyle):
3204         (TEST):
3205         Add tests for UIWKDocumentContext.
3206
3207         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3208         (TEST):
3209         (recursiveFindWKContentView): Deleted.
3210         * TestWebKitAPI/cocoa/TestWKWebView.h:
3211         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3212         (recursiveFindWKContentView):
3213         (-[TestWKWebView wkContentView]):
3214         * TestWebKitAPI/ios/UIKitSPI.h:
3215         Share the WKContentView finding code between tests.
3216
3217 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3218
3219         [iOS WK2] Turn on async overflow scrolling by default
3220         https://bugs.webkit.org/show_bug.cgi?id=196011
3221         rdar://problem/48453859
3222
3223         Reviewed by Antti Koivisto.
3224         
3225         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3226         since so many basic layout tests have different results when compositing is triggered for
3227         overflow.
3228         
3229         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3230
3231         * WebKitTestRunner/TestController.cpp:
3232         (WTR::TestController::resetPreferencesToConsistentValues):
3233
3234 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3235
3236         [ews-build] Retry API test in case of failures
3237         https://bugs.webkit.org/show_bug.cgi?id=196004
3238
3239         Reviewed by Lucas Forschler.
3240
3241         * BuildSlaveSupport/ews-build/steps.py:
3242         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3243         (CompileWebKitToT.doStepIf): Ditto.
3244         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3245         (ReRunAPITests): Re-run API tests.
3246         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3247         (RunAPITestsWithoutPatch): Run API tests without patch.
3248         (RunAPITestsWithoutPatch.doStepIf):
3249         (RunAPITestsWithoutPatch.hideStepIf):
3250         (RunAPITestsWithoutPatch.evaluateCommand):
3251         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3252         (AnalyzeAPITestsResults.start):
3253         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3254         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3255         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3256         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3257
3258 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3259
3260         [ews-build] Update queues configurations
3261         https://bugs.webkit.org/show_bug.cgi?id=196074
3262
3263         Reviewed by Dewei Zhu.
3264
3265         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3266         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3267
3268 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3269
3270         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3271         https://bugs.webkit.org/show_bug.cgi?id=195680
3272         <rdar://problem/48903534>
3273
3274         Unreviewed infrastructure fix.
3275
3276         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3277         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3278
3279 2019-03-21  Andy Estes  <aestes@apple.com>
3280
3281         [iOS] Apple Pay should be available in documents with no user agent scripts
3282         https://bugs.webkit.org/show_bug.cgi?id=196061
3283         <rdar://problem/48649391>
3284
3285         Reviewed by Brady Eidson.
3286
3287         Added API tests and related infrastructure.
3288
3289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3290         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3291         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3292         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3293         (TestWebKitAPI::TEST):
3294         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3295         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3296         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3297         * TestWebKitAPI/cocoa/TestProtocol.mm:
3298         (-[TestProtocol startLoading]):
3299         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3300         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3301         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3302         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3303
3304 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3305
3306         REGRESSSION (r243297): webkitpy tests broken
3307         https://bugs.webkit.org/show_bug.cgi?id=196108
3308
3309         Reviewed by Aakash Jain.
3310
3311         r243297 updated contributors.json, which broke a few unit tests.
3312
3313         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3314         (IRCCommandTest.test_whois):
3315         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3316
3317 2019-03-21  Chris Dumez  <cdumez@apple.com>
3318
3319         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3320         https://bugs.webkit.org/show_bug.cgi?id=196041
3321         <rdar://problem/49083230>
3322
3323         Reviewed by Alex Christensen.
3324
3325         Add API test coverage.
3326
3327         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3328         (TEST):
3329
3330 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3331
3332         Add SPI to inform applications of WKContentRuleList actions
3333         https://bugs.webkit.org/show_bug.cgi?id=195965
3334         <rdar://problem/42664365>
3335
3336         Reviewed by Geoff Garen.
3337
3338         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3339         (TestWebKitAPI::allActionsForResourceLoad):
3340         (TestWebKitAPI::testRequest):
3341         (TestWebKitAPI::TEST_F):
3342         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3343         (Notification::description):
3344         (Notification::operator== const):
3345         (toVector):
3346         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3347         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3348         (makeContentRuleList):
3349         (TEST):
3350         (makeWarnContentRuleList): Deleted.
3351
3352 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3353
3354         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3355         https://bugs.webkit.org/show_bug.cgi?id=196088
3356
3357         Reviewed by Brian Burg.
3358
3359         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3360         Support checks when only one platform is specified. Also deprecate macosx() and
3361         force the use of macos() instead.
3362
3363         * Scripts/webkitpy/style/checkers/cpp.py:
3364         (check_min_versions_of_wk_api_available):
3365         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3366         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3367
3368 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3369
3370         Update status inactive committers' status to 'contributor'.
3371
3372         * Scripts/webkitpy/common/config/contributors.json:
3373
3374 2019-03-21  Xan Lopez  <xan@igalia.com>
3375
3376         [JSC][x86] Drop support for x87 floating point
3377         https://bugs.webkit.org/show_bug.cgi?id=194853
3378
3379         Reviewed by Don Olmstead.
3380
3381         Force SSE2 on x86/32bit builds.
3382
3383         * Scripts/webkitdirs.pm:
3384         (generateBuildSystemFromCMakeProject):
3385
3386 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3387
3388         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3389         https://bugs.webkit.org/show_bug.cgi?id=196073
3390
3391         Reviewed by Michael Catanzaro.
3392
3393         Add test cases to check functions and constructors with no arguments but receiving user data.
3394
3395         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3396         (checkUserData):
3397         (testJSCFunction):
3398         (fooCreateWithUserData):
3399         (testJSCClass):
3400
3401 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3402
3403         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3404
3405         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3406
3407         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3408
3409 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3410
3411         [GTK][WPE] Add API to provide geolocation information
3412         https://bugs.webkit.org/show_bug.cgi?id=195940
3413
3414         Reviewed by Michael Catanzaro.
3415
3416         Add a new test to check the new API.
3417
3418         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3419         (testGeolocationManagerCurrentPosition):
3420         (testGeolocationManagerWatchPosition):
3421         (beforeAll):
3422         (afterAll):
3423         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3424         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3425         (beforeAll): Ditto.
3426         * TestWebKitAPI/glib/CMakeLists.txt:
3427
3428 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3429
3430         [GLib] Returning G_TYPE_OBJECT from a method does not work
3431         https://bugs.webkit.org/show_bug.cgi?id=195574
3432
3433         Reviewed by Michael Catanzaro.
3434
3435         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3436
3437         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3438         (getGFile):
3439         (getParent):
3440         (createGString):
3441         (getGString):
3442         (getGStringCopyWillRaise):
3443         (getGStringCopy):
3444         (getGStringStr):
3445         (getGStringLen):
3446         (freeGString):
3447         (testJSCClass):
3448
3449 2019-03-20  Saam Barati  <sbarati@apple.com>
3450
3451         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3452         https://bugs.webkit.org/show_bug.cgi?id=195721
3453
3454         Reviewed by Filip Pizlo.
3455
3456         * Scripts/run-javascriptcore-tests:
3457
3458 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3459
3460         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3461         https://bugs.webkit.org/show_bug.cgi?id=196049
3462
3463         Reviewed by Tim Horton.
3464
3465         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3466         overflow scrolling in general, so rename it.
3467
3468         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3469
3470 2019-03-20  Daniel Bates  <dabates@apple.com>
3471
3472         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3473         https://bugs.webkit.org/show_bug.cgi?id=196031
3474         <rdar://problem/49078172>
3475
3476         Reviewed by Tim Horton.
3477
3478         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3479         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3480         same code path used when the Done button is pressed to dismiss the <select> picker.
3481
3482         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3483         (TestWebKitAPI::TEST):
3484
3485 2019-03-20  Chris Dumez  <cdumez@apple.com>
3486
3487         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3488         https://bugs.webkit.org/show_bug.cgi?id=196029
3489         <rdar://problem/48954651>
3490
3491         Reviewed by Tim Horton.
3492
3493         Add API test coverage.
3494
3495         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3496
3497 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3498
3499         [ews-build] Improve failure summary string for ApplyPatch step
3500         https://bugs.webkit.org/show_bug.cgi?id=195995
3501
3502         Reviewed by Alexey Proskuryakov.
3503
3504         * BuildSlaveSupport/ews-build/steps.py:
3505         (ApplyPatch.getResultSummary): Override getResultSummary.
3506
3507 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3508
3509         AX: Implement support for new meter ARIA role
3510         https://bugs.webkit.org/show_bug.cgi?id=195966
3511
3512         Reviewed by Chris Fleizach.
3513
3514         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3515         to AXLevelIndicator.
3516
3517         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3518
3519 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3520
3521         [WebAuthN] Implement FIDO AppID extension
3522         https://bugs.webkit.org/show_bug.cgi?id=143491
3523         <rdar://problem/48298273>
3524
3525         Reviewed by Brent Fulgham.
3526
3527         Add a test that covers the new flag of convertToU2fSignCommand.
3528
3529         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3530         (TestWebKitAPI::TEST):
3531         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3532         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3533         (TestWebKitAPI::TEST):
3534
3535 2019-03-19  Keith Rollin  <krollin@apple.com>
3536
3537         Add support for more platforms to generate-xcfilelists
3538         https://bugs.webkit.org/show_bug.cgi?id=195977
3539
3540         Reviewed by Alexey Proskuryakov.
3541
3542         generate-xcfilelists incorrectly complains when involved with building
3543         WebKit for iphonesimulator:
3544
3545             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3546             …
3547             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3548
3549         Address this by teaching generate-xcfilelists about more platforms.
3550
3551         * Scripts/generate-xcfilelists:
3552
3553 2019-03-19  John Wilander  <wilander@apple.com>
3554
3555         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3556         https://bugs.webkit.org/show_bug.cgi?id=195923
3557         <rdar://problem/49001272>
3558
3559         Reviewed by Alex Christensen.
3560
3561         This patch does the following to the TestRunner:
3562         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3563         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3564         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3565
3566         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3567         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3568         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3569         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3570         * WebKitTestRunner/TestController.cpp:
3571         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3572         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3573         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3574         * WebKitTestRunner/TestController.h:
3575         * WebKitTestRunner/TestInvocation.cpp:
3576         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3577
3578 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3579
3580         [CMake] Support more clang and gcc sanitizers
3581         https://bugs.webkit.org/show_bug.cgi?id=195956
3582
3583         Reviewed by Michael Catanzaro.
3584
3585         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3586
3587 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3588
3589         [ews-build] Improve summary for PrintConfiguration step
3590         https://bugs.webkit.org/show_bug.cgi?id=195945
3591
3592         Reviewed by Lucas Forschler.
3593
3594         * BuildSlaveSupport/ews-build/steps.py:
3595         (PrintConfiguration.getResultSummary): Override getResultSummary.
3596
3597 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3598
3599         [ews-build] Improve summary for CheckOutSource step
3600         https://bugs.webkit.org/show_bug.cgi?id=195963
3601
3602         Reviewed by Lucas Forschler.
3603
3604         * BuildSlaveSupport/ews-build/steps.py:
3605         (CheckOutSource.getResultSummary):
3606
3607 2019-03-19  Daniel Bates  <dabates@apple.com>
3608
3609         [iOS] Focus not preserved when switching between tabs
3610         https://bugs.webkit.org/show_bug.cgi?id=195820
3611         <rdar://problem/43614450>
3612
3613         Reviewed by Brent Fulgham.
3614
3615         Add tests to ensure that we restore focus when resigning and becoming first responder.
3616
3617         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3618         (TestWebKitAPI::TEST):
3619
3620 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3621
3622         Make WTFLogChannelState and WTFLogLevel enum classes
3623         https://bugs.webkit.org/show_bug.cgi?id=195904
3624
3625         Reviewed by Eric Carlson.
3626
3627         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3628         (TestWebKitAPI::TEST_F):
3629
3630 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3631
3632         [GStreamer][EME] Backported mssdemux protection data crash fix
3633         https://bugs.webkit.org/show_bug.cgi?id=195918
3634
3635         Reviewed by Philippe Normand.
3636
3637         * gstreamer/jhbuild.modules:
3638         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3639
3640 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3641
3642         Unreviewed, rolling out r243132.
3643
3644         Broke GTK build
3645
3646         Reverted changeset:
3647
3648         "Make WTFLogChannelState and WTFLogLevel enum classes"
3649         https://bugs.webkit.org/show_bug.cgi?id=195904
3650         https://trac.webkit.org/changeset/243132
3651
3652 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3653
3654         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3655
3656         * Scripts/webkitdirs.pm:
3657         (builtDylibPathForName): Adjust the shared library name that's changed
3658         with the API version bump in r243073.
3659
3660 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3661
3662         Make WTFLogChannelState and WTFLogLevel enum classes
3663         https://bugs.webkit.org/show_bug.cgi?id=195904
3664
3665         Reviewed by Eric Carlson.
3666
3667         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3668         (TestWebKitAPI::TEST_F):
3669
3670 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3671
3672         Disable flaky test added in r2431100
3673         https://webkit.org/b/195785