2011-06-22 David Levin <levin@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-22  David Levin  <levin@chromium.org>
2
3         Reviewed by Adam Barth.
4
5         check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
6         https://bugs.webkit.org/show_bug.cgi?id=63204
7
8         * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
9           with similar code for the parameter checking.
10         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
11           those done for single lines since they don't make sense in that case (variable decls look like function decls).
12           Removed some redundant comments (one of which was slightly wrong).
13           Added checks for the new functionality and minor other test changes.
14
15 2011-06-22  Nate Chapin  <japhet@chromium.org>
16
17         Reviewed by Adam Barth.
18
19         Add libsoup to libWebCoreInternals build.
20         https://bugs.webkit.org/show_bug.cgi?id=62066
21
22         * GNUmakefile.am:
23
24 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
25
26         Reviewed by Tony Chang.
27
28         nrwt: handle missing httpd cleanly
29         https://bugs.webkit.org/show_bug.cgi?id=62027
30
31         We had reverted the change in r89414, so this adds it back in
32         (modifying check_sys_deps() in port/base.py to check for an
33         installed web server).
34
35         This change then fixes the change in r89414 to stub out the
36         check_sys_deps() in the test port so that the unit tests run correctly.
37
38         * Scripts/webkitpy/layout_tests/port/base.py:
39         * Scripts/webkitpy/layout_tests/port/test.py:
40
41 2011-06-22  David Levin  <levin@chromium.org>
42
43         Reviewed by Adam Barth.
44
45         check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
46         https://bugs.webkit.org/show_bug.cgi?id=63188
47
48         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
49         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
50
51 2011-06-22  Tony Chang  <tony@chromium.org>
52
53         Reviewed by Ojan Vafai.
54
55         Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
56         https://bugs.webkit.org/show_bug.cgi?id=62891
57
58         * BuildSlaveSupport/build.webkit.org-config/config.json:
59
60 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
61
62         Reviewed by Ojan Vafai.
63
64         nrwt: don't look for http lock when running the test port
65         https://bugs.webkit.org/show_bug.cgi?id=63158
66
67         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
68         * Scripts/webkitpy/layout_tests/port/test.py:
69
70 2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>
71
72         Reviewed by Andreas Kling.
73
74         [Qt][WK2] Set up plugin tests
75         https://bugs.webkit.org/show_bug.cgi?id=63066
76
77         * WebKitTestRunner/qt/TestControllerQt.cpp:
78         (WTR::TestController::initializeTestPluginDirectory):
79         Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
80         of the test plugin like DRT does.
81
82 2011-06-22  Eric Seidel  <eric@webkit.org>
83
84         Reviewed by Ojan Vafai.
85
86         Make sheriff-bot rollout messages a little nicer
87         https://bugs.webkit.org/show_bug.cgi?id=63107
88
89         It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
90         into urls myself.  So I have now fixed its "preparing" message to include a url.
91
92         I also figured that I should make the messages mention all of the responsible parties
93         so that rollouts are never surprises.  If you're in the channel and were involved
94         in a patch, you will see if someone is using sheriff-bot to rollout a patch.
95
96         As part of doing this I also changed (and tested) _parse_args to fail-fast
97         when given invalid args.
98
99         * Scripts/webkitpy/tool/bot/irc_command.py:
100         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
101         * Scripts/webkitpy/tool/bot/sheriff.py:
102         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
103
104 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
105
106         Reviewed by Tony Chang.
107
108         run-webkit-websocketserver fails to stop websocket server
109         https://bugs.webkit.org/show_bug.cgi?id=63123
110
111         There's a ten-character change in new-run-webkit-websocketserver
112         that fixes the actual bug, and then we update the code in
113         new-run-webkit-httpd to do the actual stop call, and add more tests
114         (refactoring the existing test code so that it is shared).
115
116         * Scripts/new-run-webkit-httpd:
117         * Scripts/new-run-webkit-websocketserver:
118         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
119
120 2011-06-22  Adam Roben  <aroben@apple.com>
121
122         Add links to existing bugs related to failing tests on TestFailures page
123
124         I changed the layout of the page a little to make it easier to read with all the new
125         information. Passing/failing revisions have been moved down below the list of tests to be
126         closer to the existing bugs and the new bug link. And each set of tests and its relevant
127         information is in a light gray box.
128
129         Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
130         possible
131
132         Reviewed by Darin Adler.
133
134         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
135         (Bugzilla): This new class represents a single Bugzilla instance.
136         (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
137         passing the resulting bug titles and URLs to the callback when complete. If called multiple
138         times with the same query before the query returns, caches the callbacks so that only one
139         query is sent over the wire. When the query completes, all pending callbacks are called.
140
141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
142         (#failure-history): Reduce the margin/padding on the top-level list a bit.
143         (#failure-history > li): Put each set of tests in a gray box, and indent most information
144         inside the box.
145         (.test-list): Unindent the list of failing tests so it is visually at the top level.
146         (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
147         each box isn't a big empty space.
148         (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
149         quite long.
150
151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
152         (addQueryParametersToURL): New function extracted from
153         ViewController.prototype._domForNewAndExistingBugs.
154
155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
156         (ViewController): Take and store an optional Bugzilla instance.
157         (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
158         purposes and move the list of failing tests above all other information. Only show bug
159         information once we've determined the most-recent passing revision for a set of tests. It's
160         not that useful to file a new bug before this information has been determined, and searching
161         for existing bugs before we've figured out which tests started failing at the same time
162         would end up giving you information about a bunch of unrelated tests.
163         (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
164         returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
165         instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
166         failing tests, and adds links to the bugs when the search completes.
167
168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
169         Bugzilla instance for bugs.webkit.org to the ViewController.
170
171 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
172
173         Reviewed by Martin Robinson.
174
175         [GTK] Apply current view settings to newly created views in GtkLauncher
176         https://bugs.webkit.org/show_bug.cgi?id=63142
177
178         * GtkLauncher/main.c:
179         (createWebViewCb):
180
181 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
182
183         Reviewed by Martin Robinson.
184
185         [GTK] Use GOption to parse main arguments in GtkLauncher
186         https://bugs.webkit.org/show_bug.cgi?id=63060
187
188         Instead of getting the settings from the view, create a new
189         settings object not associated with any view so that we can parse
190         the command line arguments before creating the view. It will also
191         allows to use the same settings for more than one view if we
192         eventually support passing more than one uri from the command
193         line.
194
195         * GtkLauncher/main.c:
196         (parseOptionEntryCallback): Make this function static. Also use
197         g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
198         of atoi/atof to provide better error messages. And always fill the
199         error struct when the function fails.
200         (getOptionEntriesFromWebKitWebSettings): Use an array of
201         GOptionEntry structs instead of a GArray, since that is what
202         g_option_group_add_entries() expects and the array size doesn't
203         change.
204         (addWebSettingsGroupToContext): Helper function to add the
205         websettings group to the option context.
206         (main): Create the option context to parse command line arguments.
207
208 2011-06-22  Martin Robinson  <mrobinson@igalia.com>
209
210         Reviewed by Adam Roben.
211
212         [GTK] Implement pixel dump support for WebKitTestRunner
213         https://bugs.webkit.org/show_bug.cgi?id=58242
214
215         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
216         * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
217         * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
218         * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
219         * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
220         file so that we can share it across platforms.
221         (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
222         * WebKitTestRunner/TestInvocation.h: Updated method list.
223         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
224         * WebKitTestRunner/cg/TestInvocationCG.cpp:
225         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
226
227 2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>
228
229         Unreviewed, rolling out r89414.
230         http://trac.webkit.org/changeset/89414
231         https://bugs.webkit.org/show_bug.cgi?id=63130
232
233         It broke webkitpy tests (Requested by Ossy on #webkit).
234
235         * Scripts/webkitpy/layout_tests/port/base.py:
236
237 2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
238
239         Reviewed by Dirk Pranke.
240
241         [NRWT] Print error message when there is no httpd present on the system
242         https://bugs.webkit.org/show_bug.cgi?id=62027
243
244         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
245
246 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
247
248         Unreviewed, build fix.
249         Fix crashes in new-run-webkit-tests resulting from the
250         change to the http_server logic in r89400. Python 2.5
251         on Mac 10.5 has some weird error paths.
252
253         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
254         * Scripts/webkitpy/common/system/executive.py:
255
256 2011-06-21  MORITA Hajime  <morrita@google.com>
257
258         Unreviewed, rolling out r89401 and r89403.
259         http://trac.webkit.org/changeset/89401
260         http://trac.webkit.org/changeset/89403
261         https://bugs.webkit.org/show_bug.cgi?id=62970
262
263         Breaks mac build and mistakenly enables the spellcheck API
264
265         * Scripts/build-webkit:
266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
267
268 2011-06-21  Kent Tamura  <tkent@chromium.org>
269
270         [Mac] Sort Xcode project files.
271
272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
273
274 2011-06-20  MORITA Hajime  <morrita@google.com>
275
276         Reviewed by Kent Tamura.
277
278         Spellcheck API should be build-able.
279         https://bugs.webkit.org/show_bug.cgi?id=62970
280
281         * Scripts/build-webkit:
282
283 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
284
285         Reviewed by Tony Chang.
286
287         nrwt: attempt #3 at fixing server startup/shutdown
288         https://bugs.webkit.org/show_bug.cgi?id=62829
289
290         Attempt yet again to make starting and stopping servers
291         reliable. It turns out that apache has races between when the
292         ctl process exists and when it writes/removes the pid file.
293         This change accounts for the races.
294
295         * Scripts/new-run-webkit-httpd:
296         * Scripts/webkitpy/common/system/executive.py:
297         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
298         * Scripts/webkitpy/layout_tests/port/base.py:
299         * Scripts/webkitpy/layout_tests/port/http_server.py:
300         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
301         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
302         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
303         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
304
305 2011-06-21  Dmitry Lomov  <dslomov@google.com>
306
307         Reviewed by Adam Roben.
308
309         https://bugs.webkit.org/show_bug.cgi?id=63080
310         Unit-tests step on test-only bot is broken.
311         Removing the step until run-api-tests is fixed.
312
313         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
314
315 2011-06-20  Dmitry Lomov  <dslomov@google.com>
316
317         Reviewed by David Levin.
318
319         https://bugs.webkit.org/show_bug.cgi?id=63017
320         "Unit tests" step on bots should provide more information in case of failure.
321
322         * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
323
324 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
325
326         Reviewed by Ojan Vafai.
327
328         new-run-webkit-tests: order shards by name, not number of tests
329         https://bugs.webkit.org/show_bug.cgi?id=62753
330
331         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
332
333 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
334
335         Reviewed by Ojan Vafai.
336
337         we should only log the test names to the tests_run.txt files during layout_tests
338         https://bugs.webkit.org/show_bug.cgi?id=62751
339
340         * Scripts/old-run-webkit-tests:
341         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
342
343 2011-06-20  Eric Seidel  <eric@webkit.org>
344
345         Reviewed by Adam Barth.
346
347         commit-queue/ews-bots should run run-bindings-tests for every patch
348         https://bugs.webkit.org/show_bug.cgi?id=63010
349
350         * Scripts/webkitpy/common/config/ports.py:
351         * Scripts/webkitpy/tool/commands/download_unittest.py:
352         * Scripts/webkitpy/tool/steps/runtests.py:
353         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
354         * Scripts/webkitpy/tool/steps/steps_unittest.py:
355
356 2011-06-20  Chang Shu  <cshu@webkit.org>
357
358         Reviewed by Adam Barth.
359
360         fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
361         https://bugs.webkit.org/show_bug.cgi?id=53676
362
363         * WebKitTestRunner/TestController.cpp:
364         (WTR::TestController::initialize):
365
366 2011-06-20  Eric Seidel  <eric@webkit.org>
367
368         Reviewed by Adam Barth.
369
370         buildbots should run run-bindings-tests
371         https://bugs.webkit.org/show_bug.cgi?id=63001
372
373         run-bindings-tests takes 2.4 seconds on my machine, so
374         I expect this will not be noticeable on the bots.
375
376         I also removed tiger-specific checks since Tiger is no
377         longer a supported platform for webkit.
378
379         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
380
381 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
382
383         Unreviewed. Fix WebKit2 GTK build after r89249.
384
385         * GtkLauncher/main.c:
386         (main):
387
388 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
389
390         Reviewed by Yury Semikhatsky.
391
392         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
393         https://bugs.webkit.org/show_bug.cgi?id=62994
394
395         * DumpRenderTree/LayoutTestController.cpp:
396         (closeWebInspectorCallback):
397         (LayoutTestController::staticFunctions):
398         * DumpRenderTree/LayoutTestController.h:
399         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
400         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
401         * DumpRenderTree/chromium/LayoutTestController.cpp:
402         (LayoutTestController::LayoutTestController):
403         * DumpRenderTree/chromium/LayoutTestController.h:
404         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
405         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
406         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
407         * DumpRenderTree/qt/LayoutTestControllerQt.h:
408         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
409         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
410         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
411         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
412         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
413
414 2011-06-20  Lukasz Slachciak  <l.slachciak@samsung.com>
415
416         Reviewed by Martin Robinson.
417
418         [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
419         https://bugs.webkit.org/show_bug.cgi?id=55308
420
421         * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
422         (parseOptionEntryCallback): Callback for parsing option entry.
423         (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
424         list of option entries.
425         (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
426         (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
427         (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
428         (parseAdditionalOptions): Help function parsing additional commandline options.
429         (main): Added call to parseAdditionalOptions.
430
431 2011-06-20  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
432
433         Reviewed by Andreas Kling.
434
435         [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
436         https://bugs.webkit.org/show_bug.cgi?id=62869
437
438         Add QFont include to fix "incomlete type QFont" error.
439
440         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
441
442 2011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
443
444         Reviewed by Martin Robinson.
445
446         [GTK] Enable Media Stream feature and make it default on
447         https://bugs.webkit.org/show_bug.cgi?id=60394
448
449         * Scripts/build-webkit:
450
451 2011-06-19  Sheriff Bot  <webkit.review.bot@gmail.com>
452
453         Unreviewed, rolling out r89198.
454         http://trac.webkit.org/changeset/89198
455         https://bugs.webkit.org/show_bug.cgi?id=62953
456
457         Chromium breakage on "Linux Tests" (Requested by senorblanco
458         on #webkit).
459
460         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
461         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
462         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
463
464 2011-06-18  Daniel Bates  <dbates@webkit.org>
465
466         Reviewed by Eric Seidel.
467
468         Git.push_local_commits_to_server() should use passed username and
469         password when we don't have cached credentials
470         https://bugs.webkit.org/show_bug.cgi?id=62941
471
472         Fixes a issue where Git.push_local_commits_to_server() would always look
473         for cached credentials regardless of whether a username and password
474         were passed as arguments. Instead, if given both a username and password
475         then we shouldn't look for cached credentials (since we were explicitly given
476         credentials).
477
478         * Scripts/webkitpy/common/checkout/scm/git.py:
479         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
480
481 2011-06-18  Daniel Bates  <dbates@rim.com>
482
483         Rubber-stamped by Eric Seidel.
484
485         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
486         https://bugs.webkit.org/show_bug.cgi?id=62767
487
488         Part 3 of 3
489
490         Remove the command-line option --skip-build now that the master BuildBot has been restarted
491         following <http://trac.webkit.org/changeset/89138>.
492
493         Instead, specify --no-build to get analogous functionality.
494
495         * Scripts/run-javascriptcore-tests:
496
497 2011-06-18  Dirk Pranke  <dpranke@chromium.org>
498
499         Reviewed by Tony Chang.
500
501         new-run-webkit-tests: fix test sorting
502         https://bugs.webkit.org/show_bug.cgi?id=58691
503
504         This changes the sorting to use a "natural" sort order such that
505         foo2.html sorts before foo13.html, and sorts the tests so
506         that all the tests in a directory are run before any test in a
507         subdirectory.
508
509         This change also adds a split() method to the filesystem since
510         that is needed to cluster files into a directory otherwise.
511
512         * Scripts/webkitpy/common/system/filesystem.py:
513         * Scripts/webkitpy/common/system/filesystem_mock.py:
514         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
515         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
516
517 2011-06-18  Evan Martin  <evan@chromium.org>
518
519         Reviewed by Darin Adler.
520
521         Compiler warning in double->int conversion in TestNetscapePlugIn
522         https://bugs.webkit.org/show_bug.cgi?id=51554
523
524         This code is providing a JS API for removing a property by numeric ID.
525         We get it from JS as a double, and must convert it to an int before using it.
526
527         Test: LayoutTests/plugins/npruntime/remove-property.html
528
529         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
530         (NPRuntimeRemoveProperty::TestObject::invoke):
531
532 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
533
534         Reviewed by Eric Seidel.
535
536         Don't exit webkit-patch when running on Win32 python
537         https://bugs.webkit.org/show_bug.cgi?id=55811
538
539         Most of the basic actions work in the meantime,
540         so let people play with in on Win32 now.
541
542         * Scripts/webkit-patch:
543
544 2011-06-18  Alice Boxhall  <aboxhall@chromium.org>
545
546         Reviewed by Ojan Vafai.
547
548         Convert json_results_generator.py to output version 4 JSON.
549         https://bugs.webkit.org/show_bug.cgi?id=60869
550
551         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
552         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
553         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
554
555 2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
556
557         Reviewed by Eric Seidel.
558
559         Some names with spaces are incorrectly reported as not containing spaces
560         while running prepare-ChangeLog
561         https://bugs.webkit.org/show_bug.cgi?id=55572
562
563         * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
564           non-alphanumeric characters in names.
565
566 2011-06-18  Michael Saboff  <msaboff@apple.com>
567
568         Reviewed by Eric Seidel.
569
570         Enhancement: New Script to Format malloc_history output as tree
571         https://bugs.webkit.org/show_bug.cgi?id=56378
572
573         New script to process malloc_history output to tree format.
574
575         * Scripts/malloc-tree: Added.
576
577 2011-06-17  Dmitry Lomov  <dslomov@google.com>
578
579         Reviewed by Daniel Bates.
580
581         https://bugs.webkit.org/show_bug.cgi?id=62918 
582         Pass configuration to UnitTests step in master.cfg
583
584         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
585
586 2011-06-17  Leandro Pereira  <leandro@profusion.mobi>
587
588         Reviewed by Eric Seidel.
589
590         [EFL] Add Evas-based ImageDiff implementation.
591         https://bugs.webkit.org/show_bug.cgi?id=61942
592
593         Build system changes will be performed as soon as the complete
594         DumpRenderTree implementation is upstreamed.
595
596         * DumpRenderTree/efl/ImageDiff.cpp: Added.
597         (pixelFromImageData):
598         (differenceImageFromDifferenceBuffer):
599         (computeDistanceBetweenPixelComponents):
600         (calculatePixelDifference):
601         (calculateDifference):
602         (getTemporaryFile):
603         (printImage):
604         (printImageDifferences):
605         (resizeEcoreEvasIfNeeded):
606         (readImageFromStdin):
607         (parseCommandLineOptions):
608         (shutdownEfl):
609         (abortWithErrorMessage):
610         (initEfl):
611         (main):
612
613 2011-06-17  Tony Chang  <tony@chromium.org>
614
615         Reviewed by Dirk Pranke.
616
617         [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
618         https://bugs.webkit.org/show_bug.cgi?id=62907
619
620         This fixes a bug where the ImageDiff on the user's machine doesn't
621         match the logic used on the Chromium buildbots.  This has the downside
622         of requiring that the Chromium ImageDiff is built, but it turns out
623         that even with --tolerance 0, the CG ImageDiff will allow small pixel
624         differences through.
625
626         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
627
628 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
629
630         [WinCairo] Unreviewed build correction.
631
632         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
633         Update WinCairo property sheet to link against the Cairo DLL,
634         now that we are using a more recent Cairo build. 
635
636 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
637
638         Reviewed by Brian Weinstein.
639
640         Create a simple example of using the COM-based C++ listeners.
641         A new onclick event is attached (via C++) to the WebKit logo
642         in the default test pattern displayed on startup.  Clicking on
643         the logo causes a message box to be displayed.
644         https://bugs.webkit.org/show_bug.cgi?id=61885
645
646         * WinLauncher/DOMDefaultImpl.h: Added.  Stub implementation of
647           the WebScriptObject and DOMEventListener.
648         * WinLauncher/WinLauncher.cpp:
649         (SimpleEventListener::SimpleEventListener): Example implementation
650           of a simple DOM event listener.
651         (SimpleEventListener::handleEvent): 
652         (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
653          to bind a C++ method to the 'onclick' event for the WebKit logo.
654         (_tWinMain):
655         * WinLauncher/WinLauncher.h:
656         * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
657
658 2011-06-17  Chang Shu  <cshu@webkit.org>
659
660         Reviewed by Andreas Kling.
661
662         [Qt] [WK2] Support undo/redo in MiniBrowser
663         https://bugs.webkit.org/show_bug.cgi?id=62809
664
665         * MiniBrowser/qt/BrowserWindow.cpp:
666         (BrowserWindow::BrowserWindow):
667
668 2011-06-17  Daniel Bates  <dbates@rim.com>
669
670         Rubber-stamped by Eric Seidel.
671
672         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
673         https://bugs.webkit.org/show_bug.cgi?id=62767
674
675         Part 2 of 3
676
677         Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
678         command line option instead of --skip-build.
679
680         We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
681         master buildbot picks up the change.
682
683         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
684
685 2011-06-17  Daniel Bates  <dbates@rim.com>
686
687         Rubber-stamped by Eric Seidel.
688
689         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
690         https://bugs.webkit.org/show_bug.cgi?id=62767
691
692         Part 1 of 3
693
694         Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
695         run-javascriptcore-tests. Also, add a remark about these options to the usage message
696         printed by run-javascriptcore-tests.
697
698         We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
699
700         * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
701           of $showHelp.
702
703 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
704
705         Reviewed by Martin Robinson.
706
707         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
708         https://bugs.webkit.org/show_bug.cgi?id=60687
709
710         Replace GdkRectangle by cairo_rectangle_int_t.
711
712         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
713         (createBitmapContextFromWebView):
714         * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
715         (firstRectForCharacterRangeCallback):
716
717 2011-06-16  Dmitry Lomov  <dslomov@google.com>
718
719         Reviewed by David Levin.
720
721         https://bugs.webkit.org/show_bug.cgi?id=62603
722         Run run-api-tests on bots in debug mode.
723         Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
724
725         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
726
727 2011-06-16  Leandro Pereira  <leandro@profusion.mobi>
728
729         Reviewed by Eric Seidel.
730
731         [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
732         WorkQueueItem.
733         They will be plugged into the build system once the EFL's DRT is
734         fully upstreamed.
735         https://bugs.webkit.org/show_bug.cgi?id=61958
736
737         * DumpRenderTree/efl: Added.
738         * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
739         (GCController::collect):
740         (GCController::collectOnAlternateThread):
741         (GCController::getJSObjectCount):
742         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
743         (createBitmapContextFromWebView):
744         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
745         (LoadItem::invoke):
746         (LoadHTMLStringItem::invoke):
747         (ReloadItem::invoke):
748         (ScriptItem::invoke):
749         (BackForwardItem::invoke):
750         * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
751         (WorkQueueItem::~WorkQueueItem):
752         (LoadItem::LoadItem):
753         (LoadHTMLStringItem::LoadHTMLStringItem):
754         (ScriptItem::ScriptItem):
755         (LoadingScriptItem::LoadingScriptItem):
756         (LoadingScriptItem::invoke):
757         (NonLoadingScriptItem::NonLoadingScriptItem):
758         (NonLoadingScriptItem::invoke):
759         (BackForwardItem::BackForwardItem):
760         (BackItem::BackItem):
761         (ForwardItem::ForwardItem):
762
763 2011-06-16  Kevin Ollivier  <kevino@theolliviers.com>
764
765         [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
766         preference like the perl scripts do.
767
768         * waf/build/build_utils.py:
769         * waf/build/settings.py:
770
771 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
772
773         Reviewed by Tony Gentilcore.
774
775         MediaStream API: Runtime enabled features
776         https://bugs.webkit.org/show_bug.cgi?id=62798
777
778         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
779
780         * DumpRenderTree/chromium/TestShell.cpp:
781         (TestShell::TestShell):
782
783 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
784
785         Reviewed by Eric Seidel.
786
787         Add support for sys.platform == 'linux3' by relaxing
788         conditional statements and/or extending lookup dicts.
789         This way, Linux kernels >=3.0-rc1 get supported in the
790         build process.
791         https://bugs.webkit.org/show_bug.cgi?id=62730
792
793         * Scripts/webkitpy/common/system/executive.py:
794         * Scripts/webkitpy/common/system/file_lock.py:
795         * Scripts/webkitpy/common/system/path_unittest.py:
796         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
797         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
798         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
799         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
800         * Scripts/webkitpy/layout_tests/port/factory.py:
801         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
802         * Scripts/webkitpy/layout_tests/port/qt.py:
803         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
804
805 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
806
807         Unreviewed, rolling out r88796.
808         http://trac.webkit.org/changeset/88796
809         https://bugs.webkit.org/show_bug.cgi?id=62790
810
811         It made fast/dom/nodesFromRect-basic.html time out on Qt,
812         64-bit, debug mode (Requested by Ossy on #webkit).
813
814         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
815         (LayoutTestController::nodesFromRect):
816         * DumpRenderTree/qt/LayoutTestControllerQt.h:
817         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
818         (PlainTextController::plainText):
819         * DumpRenderTree/qt/PlainTextControllerQt.h:
820
821 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
822
823         Unreviewed, build fix.
824
825         Revert the patches in r88995 and r88999; the http servers don't
826         seem to be shutting down reliably.
827
828         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
829         * Scripts/webkitpy/layout_tests/port/base.py:
830         * Scripts/webkitpy/layout_tests/port/http_server.py:
831         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
832         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
833         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
834         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
835
836 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
837
838         Unreviewed, build fix.
839
840         Add some debugging messages to triage problems introduced in
841         r88995.
842
843         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
844
845 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
846
847         Reviewed by Tony Chang.
848
849         nrwt: should clean up stale server processes from a previous run
850         https://bugs.webkit.org/show_bug.cgi?id=62615
851
852         This change fixes cases where NRWT might start a server and then
853         exit, leaving the server still running. Now NRWT should detect
854         this case and clean up on the next run, without shutting down
855         any processes it didn't start.
856
857         This change also fixes a bug in executive.kill_process on UNIX
858         where zombies weren't being handled properly.
859
860         * Scripts/webkitpy/common/system/executive.py:
861         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
862         * Scripts/webkitpy/layout_tests/port/base.py:
863         * Scripts/webkitpy/layout_tests/port/http_server.py:
864         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
865         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
866         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
867
868 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
869
870         Reviewed by Tony Chang.
871
872         nrwt: fix http, websocket server startup, shutdown
873         https://bugs.webkit.org/show_bug.cgi?id=62180
874
875         This change refactors all of the server-related code to
876         have consistent semantics. It pushes the start()/stop()
877         logic into the base class and adds four much smaller routines
878         for specialization:
879         _prepare_config() - for optionally writing config files etc.
880             to disk prior to starting the server
881         _remove_stale_log_files()
882         _spawn_process() - the actual launch of the subprocess
883         _cleanup_after_stop() - and custom cleanup code
884
885         Prior to this change the three server implementations were
886         fairly inconsistent, leading to lots of weirdness on the bots
887         with servers being left around, etc.
888
889         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
890         * Scripts/webkitpy/layout_tests/port/http_server.py:
891         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
892         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
893
894 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
895
896         Reviewed by Tony Chang.
897
898         webkitpy: clean up code prior to functional changes for server startup/shutdown
899         https://bugs.webkit.org/show_bug.cgi?id=62256
900
901         This patch does a bunch of minor cleanup of the code, but there
902         should be no functional changes except that all of the modules
903         will now use the same exception type. Other changes include
904         removing unused code paths and functions, pushing 'name' and
905         'pid_file' into the base class of the server objects, and using
906         the Filesystem object instead of the codecs, tempfile, and
907         shutils modules.
908
909         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
910         * Scripts/webkitpy/layout_tests/port/http_server.py:
911         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
912         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
913
914 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
915
916         Reviewed by Tony Chang.
917
918         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
919         https://bugs.webkit.org/show_bug.cgi?id=62251
920
921         shut_down_http_server() was a total hack that was only used by
922         new-run-webkit-httpd, so I've moved the code there and switched
923         to using executive.kill_process() for the common case. The
924         method itself will be removed in the patch on bug 59993.
925
926         * Scripts/new-run-webkit-httpd:
927         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
928         * Scripts/webkitpy/layout_tests/port/http_server.py:
929         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
930         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
931
932 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
933
934         Unreviewed, build fix.
935
936         Fix test-webkitpy failure introduced in r88986.
937
938         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
939
940 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
941
942         Reviewed by Eric Seidel.
943
944         NRWT: doesn't support webarchives, has stale skipping logic.
945         https://bugs.webkit.org/show_bug.cgi?id=58293
946
947         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
948         * Scripts/webkitpy/layout_tests/port/base.py:
949         * Scripts/webkitpy/layout_tests/port/webkit.py:
950
951 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
952
953         Change my email to @webkit.org
954
955         * Scripts/webkitpy/common/config/committers.py:
956
957 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
958
959         Reviewed by David Hyatt.
960
961         CSS 2.1: Support replaced elements with relative intrinsic sizes
962         https://bugs.webkit.org/show_bug.cgi?id=15849
963
964         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
965         https://bugs.webkit.org/show_bug.cgi?id=53099
966
967         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
968
969         * Scripts/old-run-webkit-tests:
970         * Scripts/webkitpy/layout_tests/port/test_files.py:
971
972 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
973
974         Reviewed by Martin Robinson.
975
976         [GTK] Add a statusbar to MiniBrowser
977         https://bugs.webkit.org/show_bug.cgi?id=62634
978
979         It shows the url of the current hovered link.
980
981         * MiniBrowser/gtk/BrowserWindow.c:
982         (browserWindowConstructed): Create the GtkSatusbar.
983         (mouseDidMoveOverElement): Update statusbar text.
984         (browserWindowUIClientInit): Add implementation for
985         mouseDidMoveOverElement().
986         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
987         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
988         (mouseDidMoveOverElement): Pass the url of the current hovered
989         link to the UI process.
990         (didCreatePage): Set the UI client adding an implementation for
991         mouseDidMoveOverElement().
992         (WKBundleInitialize):
993         * MiniBrowser/gtk/main.c:
994         (createWKContextWithInjectedBundle): Create a global context with
995         the injected bundle.
996         (loadURI): Use the global context.
997         (main):
998
999 2011-06-14  Lucas Forschler  <lforschler@apple.com>
1000
1001         Reviewed by Stephanie Lewis.
1002
1003         https://bugs.webkit.org/show_bug.cgi?id=62495
1004         Bug 62495 - combine windows and mac kill-old-processes script
1005         Add a platform agnostic script.  Remove the recently added mac flavor.
1006         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
1007         
1008         * BuildSlaveSupport/kill-old-processes: Added.
1009         * BuildSlaveSupport/mac: Removed.
1010         * BuildSlaveSupport/mac/kill-old-processes: Removed.
1011
1012 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
1013
1014         Reviewed by Tony Chang.
1015
1016         nrwt: handle worker exceptions cleanly
1017         https://bugs.webkit.org/show_bug.cgi?id=62614
1018
1019         This change modifiers new-run-webkit-tests to handle exceptions
1020         raised by worker threads better, by:
1021         - capturing the worker's stack and logging it in the manager
1022         - propagating the worker's exception in the caller correctly
1023         - attempting to cancel the workers and clean up even when
1024           we get an unexpected exception
1025
1026         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1027         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1028         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1029         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1030
1031 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
1032
1033         Reviewed by Laszlo Gombos.
1034
1035         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
1036         https://bugs.webkit.org/show_bug.cgi?id=62227
1037
1038         QtWebkit does not yet support different CacheModels. This change will 
1039         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
1040
1041         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1042         (LayoutTestController::setCacheModel):
1043         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1044
1045 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1046
1047         Reviewed by Andreas Kling.
1048
1049         [Qt] tst_QWebFrame::overloadedSlots() fails
1050         https://bugs.webkit.org/show_bug.cgi?id=37319
1051
1052         Since we don't implictly convert 'document' object to QWebElement
1053         in metacalls anymore, change the controller to expect QVariantMap instead.
1054
1055         The method plainText() was updated to use QVariantMap as well to let the bridge
1056         do the conversion directly for us.
1057
1058         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1059         (LayoutTestController::nodesFromRect):
1060         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1061         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1062         (PlainTextController::plainText):
1063         * DumpRenderTree/qt/PlainTextControllerQt.h:
1064
1065 2011-06-14  Andras Becsi  <abecsi@webkit.org>
1066
1067         Reviewed by Csaba Osztrogonác.
1068
1069         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
1070         https://bugs.webkit.org/show_bug.cgi?id=62630
1071
1072         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1073         (NPP_New): remove dead variable 'forceCarbon'
1074
1075 2011-06-13  Hayato Ito  <hayato@chromium.org>
1076
1077         Reviewed by Ojan Vafai.
1078
1079         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
1080         https://bugs.webkit.org/show_bug.cgi?id=59188
1081
1082         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
1083         WebKitDriver should always return an actual hash value if DRT returns that.
1084
1085         No tests since I'll add sample reftests to make sure mismatch reftests work later,
1086         which should be in a separate patch.
1087
1088         * Scripts/webkitpy/layout_tests/port/webkit.py:
1089
1090 2011-06-13  Kent Tamura  <tkent@chromium.org>
1091
1092         [Chromium-win] Fix two wrong assertions exposed by r88757.
1093
1094         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1095         (WebThemeEngineDRTWin::paintTrackbar):
1096
1097 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
1098
1099         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
1100         and commit queue happy.
1101
1102         * Scripts/webkitpy/common/config/committers.py:
1103
1104 2011-06-13  Chris Rogers  <crogers@google.com>
1105
1106         Unreviewed build fix.
1107
1108         Build fix to chromium DRT until we can rebaseline some tests
1109         https://bugs.webkit.org/show_bug.cgi?id=62608
1110
1111         * DumpRenderTree/chromium/TestShell.cpp:
1112         (TestShell::TestShell):
1113
1114 2011-06-13  Chris Rogers  <crogers@google.com>
1115
1116         Reviewed by Dirk Pranke.
1117
1118         Add Web Audio support to chromium DRT
1119         https://bugs.webkit.org/show_bug.cgi?id=62306
1120
1121         * DumpRenderTree/chromium/LayoutTestController.cpp:
1122         (LayoutTestController::LayoutTestController):
1123         (LayoutTestController::reset):
1124         (LayoutTestController::setEncodedAudioData):
1125         * DumpRenderTree/chromium/LayoutTestController.h:
1126         (LayoutTestController::encodedAudioData):
1127         (LayoutTestController::shouldDumpAsAudio):
1128         (LayoutTestController::setShouldDumpAsAudio):
1129         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1130         (DRTPrinter::handleAudioHeader):
1131         (TestShellPrinter::handleAudioHeader):
1132         * DumpRenderTree/chromium/TestEventPrinter.h:
1133         * DumpRenderTree/chromium/TestShell.cpp:
1134         (TestShell::TestShell):
1135         (TestShell::dump):
1136
1137 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1138
1139         Reviewed by Eric Seidel.
1140
1141         [EFL] Add load error handler to EWebLauncher
1142         https://bugs.webkit.org/show_bug.cgi?id=62347
1143
1144         Add a handler function of "load,error" to EWebLauncher.
1145         EWebLauncher now displays a simple error page on load errors.
1146
1147         * EWebLauncher/main.c:
1148         (on_load_error):
1149         (browserCreate):
1150
1151 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
1152
1153         Reviewed by Eric Seidel.
1154
1155         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
1156         https://bugs.webkit.org/show_bug.cgi?id=62385
1157
1158         Remove duplicate TestNetscapePlugIn implementation. Having two copies
1159         of this code makes keeping it in sync much more difficult. The files are
1160         almost identical and this change ports the X11 changes to main.cpp.
1161
1162         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1163         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
1164         some results on Qt and this seems to be unnecessary for the moment.
1165         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
1166         (handleEventX11): Use the handler to properly convert the keycode. Do not print
1167         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
1168         it should not be in the results.
1169         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
1170         XP_UNIX block is first by guarding against using a null instance.
1171         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
1172         the XP_UNIX define for Linux.
1173         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
1174         * GNUmakefile.am: Update source list.
1175
1176 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1177
1178         Unreviewed, rolling out r88671.
1179         http://trac.webkit.org/changeset/88671
1180         https://bugs.webkit.org/show_bug.cgi?id=62591
1181
1182         "didn't work" (Requested by dpranke on #webkit).
1183
1184         * Scripts/new-run-webkit-httpd:
1185         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1186         * Scripts/webkitpy/layout_tests/port/http_server.py:
1187         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1188         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
1189         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1190         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1191
1192 2011-06-13  Nate Chapin  <japhet@chromium.org>
1193
1194         Reviewed by Darin Fisher.
1195
1196         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
1197
1198         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1199
1200 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
1201
1202         Reviewed by Tony Chang.
1203
1204         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
1205         https://bugs.webkit.org/show_bug.cgi?id=62251
1206
1207         shut_down_http_server() was a total hack that was only used by
1208         new-run-webkit-httpd, so I've moved the code there and switched
1209         to using executive.kill_process() for the common case. The
1210         method itself will be removed in the patch on bug 59993.
1211
1212         * Scripts/new-run-webkit-httpd:
1213         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1214         * Scripts/webkitpy/layout_tests/port/http_server.py:
1215         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1216         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1217
1218 2011-06-13  Tony Chang  <tony@chromium.org>
1219
1220         Reviewed by Dimitri Glazkov.
1221
1222         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
1223         https://bugs.webkit.org/show_bug.cgi?id=62578
1224
1225         * Scripts/build-webkit:
1226
1227 2011-06-13  Tony Chang  <tony@chromium.org>
1228
1229         Reviewed by Adam Barth.
1230
1231         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
1232         https://bugs.webkit.org/show_bug.cgi?id=62545
1233
1234         * Scripts/build-webkit:
1235
1236 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1237
1238         Reviewed by Martin Robinson.
1239
1240         [GTK] Export an API similar to WebKit1
1241         https://bugs.webkit.org/show_bug.cgi?id=57820
1242
1243         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
1244         code, but linking to libwebkit2gtk.
1245
1246         * GNUmakefile.am:
1247         * GtkLauncher/main.c:
1248         (createBrowser):
1249         (main):
1250
1251 2011-06-12  MORITA Hajime  <morrita@google.com>
1252
1253         Unreviewed, rolling out r88625.
1254         http://trac.webkit.org/changeset/88625
1255         https://bugs.webkit.org/show_bug.cgi?id=61073
1256
1257         Breaks SL Webkit2 Tests
1258
1259         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1260         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1261         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1263         (WTR::InjectedBundlePage::didClearWindowForFrame):
1264         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1265
1266 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1267
1268         Reviewed by Antonio Gomes.
1269
1270         [Qt] LayoutTestController needs setTextDirection implementation
1271         https://bugs.webkit.org/show_bug.cgi?id=62442
1272
1273         Implements LayoutController.setTextDirection.
1274
1275         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1276         (LayoutTestController::setTextDirection):
1277         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1278
1279 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
1280
1281         Reviewed by Hajime Morita.
1282
1283         Add window.internals to WebKit2's WebKitTestRunner.
1284         https://bugs.webkit.org/show_bug.cgi?id=61073
1285
1286         Test: fast/harness/internals-object.html
1287
1288         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1289         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1290         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1291         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1292         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
1293         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1294
1295 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1296
1297         Unreviewed, rolling out r88616.
1298         http://trac.webkit.org/changeset/88616
1299         https://bugs.webkit.org/show_bug.cgi?id=62517
1300
1301         It broke editing/text-iterator/findString.html (Requested by
1302         tonikitoo on #webkit).
1303
1304         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1305         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1306
1307 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1308
1309         Reviewed by Antonio Gomes.
1310
1311         [Qt] LayoutTestController needs setTextDirection implementation
1312         https://bugs.webkit.org/show_bug.cgi?id=62442
1313
1314         Implements LayoutController.setTextDirection.
1315
1316         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1317         (LayoutTestController::setTextDirection):
1318         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1319
1320 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
1321
1322         Reviewed by Ojan Vafai.
1323
1324         new-run-webkit-tests: 'images' links on results.html don't work
1325         https://bugs.webkit.org/show_bug.cgi?id=62194
1326
1327         Use relative path when generating images-diffs.html
1328
1329         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1330         Added _output_testname.
1331
1332 2011-06-10  Lucas Forschler  <lforschler@apple.com>
1333
1334         Reviewed by Stephanie Lewis.
1335
1336         Script to kill old processes on Mac.
1337         This matches the windows version.
1338         https://bugs.webkit.org/show_bug.cgi?id=62479  
1339         
1340         * BuildSlaveSupport/mac: Added.
1341         * BuildSlaveSupport/mac/kill-old-processes: Added.
1342
1343 2011-06-10  Adam Barth  <abarth@webkit.org>
1344
1345         Reviewed by James Robinson.
1346
1347         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
1348         https://bugs.webkit.org/show_bug.cgi?id=62489
1349
1350         * Scripts/webkitpy/tool/bot/sheriff.py:
1351         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1352
1353 2011-06-10  Tony Chang  <tony@chromium.org>
1354
1355         Reviewed by Ojan Vafai.
1356
1357         add a compile guard ENABLE(FLEXBOX)
1358         https://bugs.webkit.org/show_bug.cgi?id=62049
1359
1360         * Scripts/build-webkit:
1361
1362 2011-06-10  Mark Rowe  <mrowe@apple.com>
1363
1364         Reviewed by Dimitri Glazkov.
1365
1366         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
1367
1368         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
1369         header file.
1370
1371         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1372         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1373
1374 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1375
1376         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
1377
1378         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1379         (handleEventX11):
1380         (NPP_GetValue):
1381         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1382         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
1383         (webkit_test_plugin_new_instance):
1384         (webkit_test_plugin_destroy_instance):
1385         (webkit_test_plugin_set_window):
1386         (executeScript):
1387         (webkit_test_plugin_new_stream):
1388         (webkit_test_plugin_destroy_stream):
1389         (webkit_test_plugin_stream_as_file):
1390         (webkit_test_plugin_write_ready):
1391         (webkit_test_plugin_write):
1392         (webkit_test_plugin_print):
1393         (keyEventToChar):
1394         (webkit_test_plugin_handle_event):
1395         (webkit_test_plugin_url_notify):
1396         (webkit_test_plugin_get_value):
1397         (webkit_test_plugin_set_value):
1398         (NP_GetMIMEDescription):
1399         (NP_Initialize):
1400         (NP_Shutdown):
1401         (NP_GetValue):
1402         * GNUmakefile.am:
1403
1404 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
1405
1406         Reviewed by Eric Seidel.
1407
1408         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
1409         https://bugs.webkit.org/show_bug.cgi?id=55603
1410
1411         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
1412         TextInputController support.
1413
1414         * DumpRenderTree/gtk/TextInputController.cpp:
1415         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
1416         of start and end. This matches the other ports. Do not use GLib style early returns.
1417         (hasMarkedTextCallback): Added.
1418         (markedRangeCallback): Added.
1419         (insertTextCallback): Cleanup as described above.
1420         (unmarkTextCallback): Cleanup as described above.
1421         (firstRectForCharacterRangeCallback): Cleanup as described above.
1422         (selectedRangeCallback): Cleanup as described above.
1423
1424 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
1425
1426         Reviewed by Tony Chang.
1427
1428         nrwt: support webaudio in chromium driver
1429         https://bugs.webkit.org/show_bug.cgi?id=62226
1430
1431         * Scripts/webkitpy/layout_tests/port/chromium.py:
1432
1433 2011-06-09  Dan Bernstein  <mitz@apple.com>
1434
1435         Reviewed by Anders Carlsson.
1436
1437         Added a test for Vector::reverse()
1438         https://bugs.webkit.org/show_bug.cgi?id=62393
1439
1440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1441         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
1442         (TestWebKitAPI::TEST):
1443         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1444
1445 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
1446
1447         Reviewed by Andreas Kling.
1448
1449         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
1450         https://bugs.webkit.org/show_bug.cgi?id=62385
1451
1452         Remove duplicate TestNetscapePlugIn implementation. Having two copies
1453         of this code makes keeping it in sync much more difficult. The files are
1454         almost identical and this change ports the X11 changes to main.cpp.
1455
1456         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1457         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
1458         (handleEventX11): Use the handler to properly convert the keycode. Do not print
1459         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
1460         it should not be in the results.
1461         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
1462         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
1463         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
1464         * GNUmakefile.am: Update source list.
1465
1466 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
1467
1468         Reviewed by Tony Chang.
1469
1470         Test plugin should support event logging on the windows port.
1471         https://bugs.webkit.org/show_bug.cgi?id=61721
1472
1473         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
1474         calls to mean the plugin handled the event.
1475
1476         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1477         (handleEventWin): Return 0 for each event on windows.
1478
1479 2011-06-09  Chang Shu  <cshu@webkit.org>
1480
1481         Reviewed by Andreas Kling.
1482
1483         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
1484         https://bugs.webkit.org/show_bug.cgi?id=62381
1485
1486         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
1487         QWKPagePrivate::isViewFocused() will check it later.
1488
1489         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1490         (WTR::PlatformWebView::PlatformWebView):
1491
1492 2011-06-09  Robert Hogan  <robert@webkit.org>
1493
1494         Reviewed by Andreas Kling.
1495
1496         Teach Qt about window.internals
1497         https://bugs.webkit.org/show_bug.cgi?id=61074
1498
1499         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1500         (WebCore::DumpRenderTree::initJSObjects):
1501
1502 2011-06-09  Eric Seidel  <eric@webkit.org>
1503
1504         Reviewed by Adam Barth.
1505
1506         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
1507         https://bugs.webkit.org/show_bug.cgi?id=62362
1508
1509         The mac bots are failing inspector tests.  We don't know why yet.
1510         So for now, turning run-webkit-tests off for the mac-ews.
1511
1512         Also noticed that due to the wrong variable name the cr-linux
1513         bots weren't running tests!
1514
1515         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1516
1517 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
1518
1519         Reviewed by Csaba Osztrogonac.
1520
1521         [Qt][WK2] Canvas tests make css2.1 ones failing
1522         https://bugs.webkit.org/show_bug.cgi?id=53427
1523
1524         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
1525         Since the Qt port should eventually go to QRawFont, this issue will be resolved
1526         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
1527         needed for the workaround.
1528
1529         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1530         (WTR::LayoutTestController::platformInitialize):
1531
1532 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
1533
1534         Reviewed by Chris Fleizach.
1535
1536         [GTK] Provide a way in DRT to check the platform name
1537         https://bugs.webkit.org/show_bug.cgi?id=56855
1538
1539         Patch for adding 'platformName' static property to DRT's
1540         LayoutController and provide platform specific implementations.
1541
1542         In principle, this feature will be only of interest for writing
1543         accessibility tests, so that's why it's only implemented in the
1544         Mac, Gtk and Win platforms.
1545
1546         * DumpRenderTree/LayoutTestController.h: New method platformName().
1547         * DumpRenderTree/LayoutTestController.cpp:
1548         (getPlatformNameCallback): New callback for 'platformName'.
1549         (LayoutTestController::staticValues): New static property.
1550
1551         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1552         (LayoutTestController::platformName): Implemented.
1553
1554         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1555         (LayoutTestController::platformName): Implemented.
1556
1557         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1558         (LayoutTestController::platformName): Implemented.
1559
1560 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
1561
1562         Reviewed by James Robinson.
1563
1564         Add mikelawther to committers.py
1565         https://bugs.webkit.org/show_bug.cgi?id=62354
1566
1567         * Scripts/webkitpy/common/config/committers.py:
1568
1569 2011-06-08  Kent Tamura  <tkent@chromium.org>
1570
1571         [Chromium] Fix a typo.
1572
1573         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1574         (WebThemeControlDRTWin::draw):
1575
1576 2011-06-08  Kent Tamura  <tkent@chromium.org>
1577
1578         Reviewed by Hajime Morita.
1579
1580         [Chromium] Support vertical sliders in Windows DRT
1581         https://bugs.webkit.org/show_bug.cgi?id=62352
1582
1583         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1584         (WebThemeControlDRTWin::draw):
1585           Paint VerticalSliderThumbType and VerticalSliderTrackType.
1586         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1587           Add VerticalSliderTrackType and VerticalSliderThumbType.
1588         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1589         (WebThemeEngineDRTWin::paintTrackbar):
1590           Convert Windows identifiers to the internal identifiers for vertical sliders.
1591
1592 2011-06-08  Ojan Vafai  <ojan@chromium.org>
1593
1594         Reviewed by Tony Chang.
1595
1596         add a short-flag for --experimental-fully-parallel
1597         https://bugs.webkit.org/show_bug.cgi?id=62321
1598
1599         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1600
1601 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1602
1603         Reviewed by Tony Chang.
1604
1605         new-run-webkit-tests: don't turn the tree red when there are new passes
1606         https://bugs.webkit.org/show_bug.cgi?id=62311
1607
1608         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
1609         to match commandComplete.
1610
1611         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1612
1613 2011-06-08  Tom Hudson  <tomhudson@google.com>
1614
1615         Reviewed by Mihai Parparita.
1616
1617         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
1618         https://bugs.webkit.org/show_bug.cgi?id=60964
1619
1620         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1621         Add 'Sort tests by metric' link.
1622         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1623         (disableSorting): Activate 'Sort tests by metric' link.
1624         (enableSorting): Deactivate 'Sort tests by metric' link.
1625         (selectDirectory): Call enableSorting()/disableSorting() depending
1626         on currently selected failure type, and sort tests if requested.
1627         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1628         New .disabled-control class for deactivated links.
1629
1630 2011-06-08  Tom Sepez  <tsepez@chromium.org>
1631
1632         Reviewed by Adam Barth.
1633
1634         Add web permissions callbacks for mixed content blocking.
1635         https://bugs.webkit.org/show_bug.cgi?id=61946
1636
1637         * DumpRenderTree/chromium/LayoutTestController.cpp:
1638         (LayoutTestController::setAllowDisplayOfInsecureContent):
1639         (LayoutTestController::setAllowRunningOfInsecureContent):
1640         (LayoutTestController::overridePreference):
1641         * DumpRenderTree/chromium/WebPermissions.cpp:
1642         (WebPermissions::allowDisplayingInsecureContent):
1643         (WebPermissions::allowRunningInsecureContent):
1644         (WebPermissions::setDisplayingInsecureContentAllowed):
1645         (WebPermissions::setRunningInsecureContentAllowed):
1646         (WebPermissions::reset):
1647         * DumpRenderTree/chromium/WebPermissions.h:
1648
1649 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
1650
1651         Reviewed by Tony Chang.
1652
1653         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
1654         https://bugs.webkit.org/show_bug.cgi?id=62259
1655
1656         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1657
1658 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1659
1660         Reviewed by Tony Chang.
1661
1662         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
1663         https://bugs.webkit.org/show_bug.cgi?id=62303
1664
1665         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
1666
1667         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1668
1669 2011-06-08  Greg Simon  <gregsimon@chromium.org>
1670
1671         Reviewed by Dimitri Glazkov.
1672
1673         Control Indexeddb backends from LayoutTestController
1674         https://bugs.webkit.org/show_bug.cgi?id=61000
1675
1676         * DumpRenderTree/chromium/LayoutTestController.cpp:
1677         (LayoutTestController::LayoutTestController):
1678         (LayoutTestController::setOverrideIndexedDBBackingStore):
1679         (LayoutTestController::clearAllDatabases):
1680         * DumpRenderTree/chromium/LayoutTestController.h:
1681
1682 2011-06-08  Andreas Kling  <kling@webkit.org>
1683
1684         Add Pierre Rossi to contributors list for EZ-CC.
1685
1686         * Scripts/webkitpy/common/config/committers.py:
1687
1688 2011-06-08  Ilya Sherman  <isherman@chromium.org>
1689
1690         Reviewed by Andreas Kling.
1691
1692         Add Ilya Sherman to list of committers
1693         https://bugs.webkit.org/show_bug.cgi?id=62270
1694
1695         * Scripts/webkitpy/common/config/committers.py:
1696
1697 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
1698
1699         Reviewed by Tony Chang.
1700
1701         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
1702         https://bugs.webkit.org/show_bug.cgi?id=62178
1703
1704         Added commandComplete and evaluateCommand for NewRunWebKitTests class
1705         to parse new-run-webkit-tests' results.
1706
1707         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1708
1709 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
1710
1711         Reviewed by Eric Seidel.
1712
1713         webkitpy: add a popen() call to executive
1714         https://bugs.webkit.org/show_bug.cgi?id=62179
1715
1716         This change adds a popen() wrapper call to the Executive object.
1717         This will allow other webkitpy scripts that currently call
1718         subprocess directly to use Executive, instead.
1719
1720         No additional tests are necessary (the existing tests cover the code).
1721
1722         * Scripts/webkitpy/common/system/executive.py:
1723
1724 2011-06-07  Sam Weinig  <sam@webkit.org>
1725
1726         Reviewed by Anders Carlsson.
1727
1728         Remove repeated IPC traffic from SetRenderTreeSize message
1729         https://bugs.webkit.org/show_bug.cgi?id=62244
1730
1731         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1732         (WTR::InjectedBundlePage::InjectedBundlePage):
1733         Add stub for didLayoutForFrame.
1734
1735 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
1736
1737         Reviewed by Tony Chang.
1738
1739         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
1740         https://bugs.webkit.org/show_bug.cgi?id=62241
1741
1742         * Scripts/webkitpy/layout_tests/port/chromium.py:
1743
1744 2011-06-07  Adam Barth  <abarth@webkit.org>
1745
1746         Rubber-stamped by Eric Seidel.
1747
1748         Enable tests on the mac-ews
1749
1750         When we bring the mac-ews back up, we're going to try running tests!
1751
1752         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1753
1754 2011-06-07  Dmitry Lomov  <dslomov@google.com>
1755
1756         Reviewed by David Levin.
1757
1758         https://bugs.webkit.org/show_bug.cgi?id=62215
1759         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
1760
1761         * Scripts/webkitpy/style/checkers/cpp.py:
1762         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1763
1764 2011-06-07  Nico Weber  <thakis@chromium.org>
1765
1766         Reviewed by Dimitri Glazkov.
1767
1768         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
1769         https://bugs.webkit.org/show_bug.cgi?id=62210
1770
1771         The change to TestEventPrinter fixes a latent bug, because
1772         objects are deleted through the TestEventPrinter type, but none
1773         of the subclasses have destructors or non-POD members.
1774
1775         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
1776         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
1777         discussed at http://codereview.chromium.org/7094005/, we prefer making
1778         leaf class destructors virtual over making the leaf classes final.
1779
1780         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1781         (NotificationPresenter::~NotificationPresenter):
1782         * DumpRenderTree/chromium/NotificationPresenter.h:
1783         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1784         (TestEventPrinter::~TestEventPrinter):
1785         * DumpRenderTree/chromium/TestEventPrinter.h:
1786         * DumpRenderTree/chromium/WebViewHost.h:
1787
1788 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
1789
1790         Reviewed by Dirk Pranke.
1791
1792         [chromium] Chromium bots on build.webkit.org don't upload results.html
1793         https://bugs.webkit.org/show_bug.cgi?id=61961
1794
1795         Don't fix the path on chromium port erroneously.
1796
1797         * BuildSlaveSupport/test-result-archive:
1798
1799 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
1800
1801         Fix the GTK+ build by ensuring that the autogenerated sources
1802         necessary for libWebCoreInternals are recorded in a predeclared
1803         variable before assigning to BUILT_SOURCES.
1804
1805         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
1806
1807 2011-06-06  Yong Li  <yoli@rim.com>
1808
1809         Reviewed by Eric Seidel.
1810
1811         https://bugs.webkit.org/show_bug.cgi?id=62097
1812         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
1813
1814         * Scripts/webkitpy/style/checkers/cpp.py:
1815         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1816
1817 2011-06-06  Xan Lopez  <xlopez@igalia.com>
1818
1819         Reviewed by Martin Robinson.
1820
1821         [GTK] Enable feature/symbol detection in NWRT/GTK
1822         https://bugs.webkit.org/show_bug.cgi?id=62136
1823
1824         Disable feature detection through DRT, since we don't support it,
1825         and set the libwebcore patch correctly so that symbol detection
1826         through 'nm' works.
1827
1828         * Scripts/webkitpy/layout_tests/port/gtk.py:
1829
1830 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
1831
1832         Reviewed by Tony Gentilcore.
1833
1834         Add a "prerender" state for page visibility.
1835         https://bugs.webkit.org/show_bug.cgi?id=62062
1836
1837         * DumpRenderTree/chromium/LayoutTestController.cpp:
1838         (LayoutTestController::setPageVisibility):
1839
1840 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
1841
1842         [Qt] Implement download feature for QtTestBrowser
1843         https://bugs.webkit.org/show_bug.cgi?id=61865
1844
1845         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
1846
1847         * QtTestBrowser/launcherwindow.cpp:
1848         (LauncherWindow::LauncherWindow):
1849         * QtTestBrowser/launcherwindow.h:
1850
1851 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
1852
1853         Reviewed by Csaba Osztrogonác.
1854
1855         [Qt] Implement download feature for QtTestBrowser
1856         https://bugs.webkit.org/show_bug.cgi?id=61865
1857
1858         * QtTestBrowser/launcherwindow.cpp:
1859         (LauncherWindow::LauncherWindow):
1860         (LauncherWindow::downloadRequest):
1861         (LauncherWindow::fileDownloadFinished):
1862         * QtTestBrowser/launcherwindow.h:
1863
1864 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
1865
1866         Reviewed by Dimitri Glazkov.
1867
1868         Make DumpRenderTree initialize window.internals.
1869         https://bugs.webkit.org/show_bug.cgi?id=61076
1870
1871         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
1872         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1873         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1874
1875 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
1876
1877         Reviewed by Kent Tamura.
1878
1879         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
1880         https://bugs.webkit.org/show_bug.cgi?id=61628
1881
1882         * Scripts/build-webkit:
1883
1884 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
1885
1886         Reviewed by Kent Tamura.
1887
1888         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
1889         https://bugs.webkit.org/show_bug.cgi?id=61631
1890
1891         * Scripts/build-webkit:
1892
1893 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1894
1895         Unreviewed. Fix the GTK+ build.
1896
1897         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
1898
1899 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
1900
1901         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
1902         works properly).
1903
1904         * Scripts/webkitpy/common/config/committers.py:
1905
1906 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
1907
1908         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
1909         WebKit scripts expect, so other scripts work properly with wx.
1910
1911         * waf/build/build_utils.py:
1912         * waf/build/settings.py:
1913
1914 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
1915
1916         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
1917         to build on Mac.
1918
1919         * waf/build/settings.py:
1920         * wx/install-unix-extras:
1921
1922 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
1923
1924         [wx] Unreviewed build fixes for recent trunk changes.
1925
1926         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1927         (LayoutTestController::setTextDirection):
1928         * waf/build/settings.py:
1929
1930 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
1931
1932         Fix the GTK+ build.
1933
1934         * GNUmakefile.am: Add some missing newline escape.
1935
1936 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
1937
1938         Try to fix the GTK+ bulid.
1939
1940         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
1941         source list.
1942
1943 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1944
1945         Reviewed by Adam Barth.
1946
1947         nrwt: should skip chromium test expectation overrides on upstream bots
1948         https://bugs.webkit.org/show_bug.cgi?id=61888
1949
1950         * Scripts/webkitpy/layout_tests/port/chromium.py:
1951         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1952
1953 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1954
1955         Reviewed by Ojan Vafai.
1956
1957         new-run-webkit-tests: minor logging, code cleanup
1958         https://bugs.webkit.org/show_bug.cgi?id=62055
1959
1960         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1961         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1962
1963 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
1964
1965         Try to fix the build failure on the GTK+ 32-bit Release bot.
1966
1967         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
1968
1969 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
1970
1971         Reviewed by Ryosuke Niwa.
1972
1973         [GTK] Support smart replace for the pasteboard
1974         https://bugs.webkit.org/show_bug.cgi?id=61734
1975
1976         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
1977         This is required to produce consistent test results.
1978
1979         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1980         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
1981         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1982         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
1983         methods which calls into DumpRenderTreeSupportGtk.
1984
1985 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
1986
1987         Reviewed by Dimitri Glazkov.
1988
1989         Teach Gtk build about window.internals
1990         https://bugs.webkit.org/show_bug.cgi?id=61071
1991
1992         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1993         (webViewWindowObjectCleared): Inject the new internals object when the
1994         window object clears.
1995         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
1996         Also do a little bit of cleanup.
1997
1998 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1999
2000         Reviewed by Tony Chang.
2001
2002         Worker may not be stopped after LT.
2003         https://bugs.webkit.org/show_bug.cgi?id=61847
2004
2005         Re-submit a variant of the first fix for this bug. It's possible
2006         that actually calling cleanup() in the worker threads was taking
2007         too long and we triggered the assertions in the manager thread.
2008
2009         I've bumped up the timeout in the manager and added better
2010         diagnostics. I also cleaned up the cleanup() code a bit because
2011         there was some unnecessary if-checks.
2012
2013         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2014         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2015
2016 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
2017
2018         Reviewed by Tony Chang.
2019
2020         nrwt: fix duplicate logging regression
2021         https://bugs.webkit.org/show_bug.cgi?id=61981
2022
2023         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2024
2025 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
2026
2027         Reviewed by Adam Barth.
2028
2029         Modified addTouchPoint to correctly re-use touchPoint id values starting
2030         from the lowest not-un-use touchPoint id as is done by the embedder
2031         APIs. (Fixes BUGCR36415)
2032
2033         https://bugs.webkit.org/show_bug.cgi?id=62016
2034
2035         * DumpRenderTree/chromium/EventSender.cpp:
2036         (EventSender::addTouchPoint):
2037
2038 2011-06-03  Cary Clark  <caryclark@google.com>
2039
2040         Reviewed by Eric Seidel.
2041
2042         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
2043         https://bugs.webkit.org/show_bug.cgi?id=61534
2044
2045         Skia on Mac uses Skia to render WebKit, and CG
2046         to render UI elements. The CG elements need a
2047         transcribed graphics context that preserves the
2048         canvas matrix, and the canvas clip.
2049
2050         The SkiaBitLocker utility class sets up a CGContext
2051         from the SkCanvas, locks the bitmap's bits, and
2052         releases the lock when the class goes out of scope.
2053
2054         The SkiaBitLocker implementation is described by
2055         this patch:
2056         http://codereview.chromium.org/7031006/
2057
2058         When WebKit uses Skia for rendering, the WebCanvas
2059         is an SkCanvas. Create an equivalent CGContext to
2060         draw the scrollbar thumb.
2061
2062         As the Chrome Mac port does not yet use Skia, this
2063         patch has no effect and requires no tests.
2064
2065         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2066         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2067
2068 2011-06-03  Andras Becsi  <abecsi@webkit.org>
2069
2070         Unreviewed build fix.
2071
2072         Fix typo.
2073
2074         * Scripts/old-run-webkit-tests:
2075
2076 2011-06-03  Andras Becsi  <abecsi@webkit.org>
2077
2078         Reviewed by Csaba Osztrogonác.
2079
2080         Print error message when there is no httpd present on the system
2081         https://bugs.webkit.org/show_bug.cgi?id=61939
2082
2083         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
2084         * Scripts/webkitperl/httpd.pm:
2085
2086 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
2087
2088         Reviewed by Yury Semikhatsky.
2089
2090         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
2091         https://bugs.webkit.org/show_bug.cgi?id=61533
2092
2093         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
2094
2095         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2096         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
2097         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2098         * DumpRenderTree/chromium/LayoutTestController.cpp:
2099         (LayoutTestController::LayoutTestController):
2100         (LayoutTestController::setJavaScriptProfilingEnabled):
2101         * DumpRenderTree/chromium/LayoutTestController.h:
2102         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2103         (LayoutTestController::setJavaScriptProfilingEnabled):
2104         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2105         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
2106         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2107
2108 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
2109
2110         Reviewed by Tony Chang.
2111
2112         NRWT needs a way to log to a file without including backspaces without needing --verbose
2113         https://bugs.webkit.org/show_bug.cgi?id=60328
2114
2115         This change modifies NRWT so that if it can tell if it is
2116         writing to a terminal, it will overwrite any messages printed
2117         in the 'one-line-progress' and 'updates' print options, and if
2118         not (or if --verbose was specified) the messages will be printed
2119         without backspaces.
2120
2121         If the overwriting updates are disabled, one-line-progress will
2122         only print every 10 seconds instead of on every update. This
2123         ensures that we still get updates once in a while while the
2124         tests are running, even if we're not in --verbose mode. Note
2125         that one-line-progress will now still be printed in --verbose,
2126         since it's useful as long as you're not flooded with the
2127         updates.
2128
2129         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2130         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2131         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2132
2133 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
2134
2135         Reviewed by Gustavo Noronha Silva.
2136
2137         [GTK] autogen.sh is run twice for each buld on the bots
2138         https://bugs.webkit.org/show_bug.cgi?id=61951
2139
2140         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
2141         for the WebKit project. This prevents build-jsc runs from forcing subsequent
2142         build-webkit runs to re-rerun autogen.sh.
2143
2144 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2145
2146         Unreviewed, rolling out r87946.
2147         http://trac.webkit.org/changeset/87946
2148         https://bugs.webkit.org/show_bug.cgi?id=61965
2149
2150         Cause NRWT to break (Requested by abarth|gardener on #webkit).
2151
2152         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2153
2154 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
2155
2156         Reviewed by Darin Adler.
2157
2158         Add build logistics and plumbing for window.internals object.
2159         https://bugs.webkit.org/show_bug.cgi?id=60313
2160
2161         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2162         * DumpRenderTree/chromium/TestShell.cpp:
2163         (TestShell::bindJSObjectsToWindow): Added injection code.
2164         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2165         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2166
2167 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
2168
2169         Reviewed by Dirk Pranke.
2170
2171         Call cleanup() explicitly at the end of worker.run().
2172         https://bugs.webkit.org/show_bug.cgi?id=61847
2173
2174         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2175
2176 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
2177
2178         Unreviewed, rolling out r87926.
2179         http://trac.webkit.org/changeset/87926
2180         https://bugs.webkit.org/show_bug.cgi?id=60313
2181
2182         Fails to find WebCoreTestSupport.dylib on bots.
2183
2184         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2185         * DumpRenderTree/chromium/TestShell.cpp:
2186         (TestShell::bindJSObjectsToWindow):
2187         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2188         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2189
2190 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
2191
2192         Reviewed by Darin Adler.
2193
2194         Add build logistics and plumbing for window.internals object.
2195         https://bugs.webkit.org/show_bug.cgi?id=60313
2196
2197         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2198         * DumpRenderTree/chromium/TestShell.cpp:
2199         (TestShell::bindJSObjectsToWindow): Added injection code.
2200         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2201         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2202
2203 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2204
2205         Reviewed by Eric Seidel.
2206
2207         Adjust efl coding style to more efl directories
2208         https://bugs.webkit.org/show_bug.cgi?id=61903
2209
2210         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
2211
2212 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2213
2214         Reviewed by Tony Chang.
2215
2216         old-run-webkit-tests: add support for audio files
2217         https://bugs.webkit.org/show_bug.cgi?id=57992
2218
2219         * Scripts/old-run-webkit-tests:
2220
2221 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
2222
2223         Reviewed by Adam Barth.
2224
2225         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
2226         https://bugs.webkit.org/show_bug.cgi?id=34314
2227
2228         * DumpRenderTree/DumpRenderTree.gypi:
2229         * DumpRenderTree/chromium/LayoutTestController.cpp:
2230         (LayoutTestController::LayoutTestController):
2231         (LayoutTestController::setImagesAllowed):
2232         (LayoutTestController::setStorageAllowed):
2233         * DumpRenderTree/chromium/LayoutTestController.h:
2234         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
2235         (WebPermissions::WebPermissions):
2236         (WebPermissions::~WebPermissions):
2237         (WebPermissions::allowImages):
2238         (WebPermissions::allowStorage):
2239         (WebPermissions::setImagesAllowed):
2240         (WebPermissions::setStorageAllowed):
2241         (WebPermissions::reset):
2242         * DumpRenderTree/chromium/WebPermissions.h:
2243
2244 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
2245
2246         Reviewed by Tony Chang.
2247
2248         Test plugin should support event logging on the windows port.
2249         https://bugs.webkit.org/show_bug.cgi?id=61721
2250
2251         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2252         (handleEventWin): Well, handle them.
2253
2254 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
2255
2256         Reviewed by Tony Chang.
2257
2258         [chromium] Use correct file name for dragging out images.
2259         https://bugs.webkit.org/show_bug.cgi?id=24887
2260
2261         * DumpRenderTree/chromium/EventSender.cpp:
2262         (EventSender::EventSender):
2263         (EventSender::dumpFilenameBeingDragged):
2264         * DumpRenderTree/chromium/EventSender.h:
2265
2266 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
2267
2268         Reviewed by Tony Chang.
2269
2270         nrwt: make webaudio work w/o content-length header
2271         https://bugs.webkit.org/show_bug.cgi?id=61819
2272
2273         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2274         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2275         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2276         * Scripts/webkitpy/layout_tests/port/webkit.py:
2277
2278 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2279
2280         Reviewed by Andreas Kling.
2281
2282         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
2283         https://bugs.webkit.org/show_bug.cgi?id=61802
2284
2285         Add command line parameter and menu item to MiniBrowser application 
2286         enabling use of QGLWidget for browser viewport.
2287
2288         * MiniBrowser/qt/BrowserWindow.cpp:
2289         (BrowserWindow::BrowserWindow):
2290         (BrowserWindow::toggleGLViewport):
2291         * MiniBrowser/qt/BrowserWindow.h:
2292         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2293         (MiniBrowserApplication::handleUserOptions):
2294         * MiniBrowser/qt/MiniBrowserApplication.h:
2295         (WindowOptions::WindowOptions):
2296
2297 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
2298
2299         Reviewed by Xan Lopez.
2300
2301         Print out autogen arguments when they differ from the last set, to help
2302         with debugging build issues.
2303
2304         * Scripts/webkitdirs.pm: Print out previous and current build arguments
2305         when they differ.
2306
2307 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2308
2309         Reviewed by Martin Robinson.
2310
2311         [GTK] run-launcher should run MiniBrowser in WebKit2
2312         https://bugs.webkit.org/show_bug.cgi?id=61858
2313
2314         * Scripts/run-launcher: Check whether -2 command line option has
2315         been passed and run MiniBrowser instead of GtkLauncher.
2316
2317 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
2318
2319         Reviewed by Dirk Pranke.
2320
2321         Fix exception in verbose printing mode.
2322         https://bugs.webkit.org/show_bug.cgi?id=61723
2323
2324         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2325
2326 2011-05-31  Yong Li  <yoli@rim.com>
2327
2328         Reviewed by Eric Seidel.
2329
2330         https://bugs.webkit.org/show_bug.cgi?id=54807
2331         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
2332         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
2333         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
2334         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
2335         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
2336         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
2337         rule we should have in order to make our code independent from compilers and compiler flags.
2338
2339         * Scripts/webkitpy/style/checkers/cpp.py:
2340
2341 2011-05-31  Hironori Bono  <hbono@chromium.org>
2342
2343         Reviewed by Eric Seidel.
2344
2345         Add a JavaScript function layoutTestController.setTextDirection().
2346         https://bugs.webkit.org/show_bug.cgi?id=50952
2347
2348         This change adds a new JavaScript function setTextDirection() to the
2349         LayoutTestController class of Safari and Chrome to write layout tests
2350         that changes the text direction of an editable element.
2351
2352         * DumpRenderTree/LayoutTestController.cpp:
2353         (setTextDirectionCallback):
2354         (LayoutTestController::staticFunctions):
2355         * DumpRenderTree/LayoutTestController.h:
2356         * DumpRenderTree/chromium/LayoutTestController.cpp:
2357         (LayoutTestController::LayoutTestController):
2358         (LayoutTestController::setTextDirection):
2359         * DumpRenderTree/chromium/LayoutTestController.h:
2360         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2361         (LayoutTestController::setTextDirection):
2362         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2363         (LayoutTestController::setTextDirection):
2364         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2365         (LayoutTestController::setTextDirection):
2366
2367 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2368
2369         Reviewed by Simon Hausmann.
2370
2371         [Qt] User-agent list of Qt test browsers is very outdated
2372         https://bugs.webkit.org/show_bug.cgi?id=61531
2373
2374         The user can edit the user-agent manually, so there's no need to have
2375         a super complete and up to date list, but it's nice to have it
2376         minimally updated.
2377
2378         * MiniBrowser/qt/useragentlist.txt:
2379         * QtTestBrowser/useragentlist.txt:
2380
2381 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
2382
2383         Reviewed by Adam Roben.
2384
2385         [GTK] [WebKit2] Implement a basic WebKitTestRunner
2386         https://bugs.webkit.org/show_bug.cgi?id=57068
2387
2388         Add an implementation of WebKitTestRunner for GTK+.
2389
2390         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
2391         * Scripts/old-run-webkit-tests: Ditto.
2392         * Scripts/run-launcher: Ditto.
2393         * Scripts/webkitdirs.pm: Ditto.
2394         * WebKitTestRunner/GNUmakefile.am: Added.
2395         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2396         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
2397         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2398         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2399         * WebKitTestRunner/PlatformWebView.h:
2400         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
2401         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
2402         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2403         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2404         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
2405         (main): Added.
2406
2407 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
2408
2409         Reviewed by Tony Chang.
2410
2411         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
2412         https://bugs.webkit.org/show_bug.cgi?id=60241
2413
2414         * Scripts/new-run-webkit-tests:
2415
2416 2011-05-31  Eric Seidel  <eric@webkit.org>
2417
2418         Reviewed by David Kilzer.
2419
2420         webkitpy should create zips with zip -9
2421         https://bugs.webkit.org/show_bug.cgi?id=61789
2422
2423         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
2424
2425         * Scripts/webkitpy/common/system/workspace.py:
2426         * Scripts/webkitpy/common/system/workspace_unittest.py:
2427
2428 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2429
2430         Reviewed by Csaba Osztrogonác.
2431
2432         [Qt] Implement find feature for QtTestBrowser
2433         https://bugs.webkit.org/show_bug.cgi?id=61425
2434
2435         Buildfix for --minimal and CONFIG+=qt_minimal build.
2436
2437         * QtTestBrowser/launcherwindow.cpp:
2438         (LauncherWindow::LauncherWindow):
2439         (LauncherWindow::createChrome):
2440         * QtTestBrowser/launcherwindow.h:
2441
2442 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2443
2444         Reviewed by Csaba Osztrogonác.
2445
2446         [Qt] Implement find feature for QtTestBrowser
2447         https://bugs.webkit.org/show_bug.cgi?id=61425
2448
2449         * QtTestBrowser/launcherwindow.cpp:
2450         (LauncherWindow::LauncherWindow):
2451         (LauncherWindow::createChrome):
2452         (LauncherWindow::showFindBar):
2453         (LauncherWindow::find):
2454         * QtTestBrowser/launcherwindow.h:
2455
2456 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2457
2458         Reviewed by Martin Robinson.
2459
2460         [GTK] Implement JavaScript dialogs in MiniBrowser
2461         https://bugs.webkit.org/show_bug.cgi?id=61725
2462
2463         * MiniBrowser/gtk/BrowserWindow.c:
2464         (WKStringGetCString): Helper function to get a UTF-8 c string from
2465         a WKStringRef.
2466         (WKURLGetCString): Helper function to get a UTF-8 c string from a
2467         WKURLRef.
2468         (browserWindowUpdateURL): Update to use WKURLGetCString.
2469         (didReceiveTitleForFrame): Update to use WKStringGetCString.
2470         (createMessageDialog): Create a GtkMessageDialog.
2471         (runJavaScriptAlert):
2472         (runJavaScriptConfirm):
2473         (runJavaScriptPrompt):
2474         (browserWindowUIClientInit):
2475
2476 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
2477
2478         Reviewed by Kent Tamura.
2479
2480         WebSocket closing handshake
2481         https://bugs.webkit.org/show_bug.cgi?id=35721
2482
2483         * Scripts/webkitpy/thirdparty/__init__.py:
2484         Pull in pywebsocket 0.6b1. We need to update pywebsocket
2485         to get the right behavior of closing handshake.
2486
2487 2011-05-29  Daniel Bates  <dbates@rim.com>
2488
2489         Reviewed by David Kilzer.
2490
2491         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
2492         https://bugs.webkit.org/show_bug.cgi?id=61162
2493
2494         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
2495         that omits a line count. In particular, the chunk range regular expression does
2496         not match a chunk range line that omits a line count. GNU diff(1) will omit the
2497         line count in the chunk range if the line count is exactly 1. For example, appending
2498         a new line to the end of an existing file F that contains exactly one line of text will
2499         be represented in a diff with a chunk range line that omits the line count for F.
2500
2501         * Scripts/VCSUtils.pm:
2502           (parseChunkRange): Added.
2503         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
2504         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2505           - Added unit test "Git: Append new line to the end of an existing file".
2506
2507 2011-05-28  Adam Barth  <abarth@webkit.org>
2508
2509         Reviewed by Eric Seidel.
2510
2511         EWS builds patches that fail to build twice, which seems useless and slows down the bots
2512         https://bugs.webkit.org/show_bug.cgi?id=55585
2513
2514         This patch switches all the early warning system bots over to the new
2515         PatchAnalysisTask-based infrastructure.  This patch makes these bots
2516         more efficient (in the case where patches fail to build) and paves the
2517         way for running tests on these bots!
2518
2519         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2520         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2521         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2522         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2523         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2524         * Scripts/webkitpy/tool/commands/queues.py:
2525
2526 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
2527
2528         Reviewed by Kent Tamura.
2529
2530         Add bashi as a committer.
2531
2532         https://bugs.webkit.org/show_bug.cgi?id=61685
2533
2534         * Scripts/webkitpy/common/config/committers.py:
2535
2536 2011-05-27  Adam Barth  <abarth@webkit.org>
2537
2538         Reviewed by Eric Seidel.
2539
2540         When checking whether the tree is red, the EWS posts a link to the wrong log
2541         https://bugs.webkit.org/show_bug.cgi?id=61072
2542
2543         We need to cache the original script error because that contains the
2544         failure log we want to upload.  If we don't cache that script error,
2545         self._script_error will get overwritten when we sanity check the clean
2546         tree (and it also has test failures).
2547
2548         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2549             - This testing approach is slightly goofy.  We'd like to use
2550               assertRaisesRegexp, but that's not available until Python 2.7.
2551         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2552
2553 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
2554
2555         Reviewed by Adam Barth.
2556
2557         Add layoutTestController.setStorageAllowed() to control whether access
2558         to the localStorage API is enabled via the WebPermissionClient
2559         https://bugs.webkit.org/show_bug.cgi?id=61581
2560
2561         * DumpRenderTree/chromium/LayoutTestController.cpp:
2562         (LayoutTestController::LayoutTestController):
2563         (LayoutTestController::setStorageAllowed):
2564         * DumpRenderTree/chromium/LayoutTestController.h:
2565         * DumpRenderTree/chromium/TestShell.cpp:
2566         (TestShell::TestShell):
2567         (TestShell::createNewWindow):
2568         * DumpRenderTree/chromium/TestShell.h:
2569         * DumpRenderTree/chromium/WebPermissions.h: Added.
2570         (WebPermissions::WebPermissions):
2571         (WebPermissions::allowStorage):
2572         (WebPermissions::setStorageAllowed):
2573         (WebPermissions::reset):
2574
2575 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
2576
2577         Reviewed by Eric Seidel.
2578
2579         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
2580         https://bugs.webkit.org/show_bug.cgi?id=60326
2581
2582         This patch removes a lot of the complexity from the
2583         metered_stream implementation that was unnecessary since there
2584         was only one caller and the logic could be coordinated better.
2585
2586         There should be no functional changes in this patch, just code
2587         getting deleted and cleaned up.
2588
2589         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2590         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
2591         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2592         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2593
2594 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
2595
2596         Reviewed by Eric Seidel.
2597
2598         NRWT: minor cleanup in printing module
2599         https://bugs.webkit.org/show_bug.cgi?id=60329
2600
2601         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2602
2603 2011-05-27  Steve Lacey  <sjl@chromium.org>
2604
2605         Reviewed by David Levin.
2606
2607         Add sjl@chromium.org as a committer.
2608
2609         https://bugs.webkit.org/show_bug.cgi?id=61672
2610
2611         * Scripts/webkitpy/common/config/committers.py:
2612
2613 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
2614
2615         Reviewed by Adam Barth.
2616
2617         NRWT: remove --print detailed-progress
2618         https://bugs.webkit.org/show_bug.cgi?id=60324
2619
2620         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
2621         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2622         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2623         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2624
2625 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
2626
2627         Reviewed by Ojan Vafai.
2628
2629         NRWT: debug messages from the workers are being logged twice
2630         https://bugs.webkit.org/show_bug.cgi?id=60428
2631
2632         It looks like when the workers are run in separate processes
2633         we end up getting two copies of every log message they print.
2634         This has to do with the multiprocessing module on UNIX cloning
2635         the log configuration in a way I wasn't expecting, and so two
2636         log handlers end up getting registered.
2637
2638         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
2639         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2640         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2641         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2642
2643 2011-05-27  Adam Roben  <aroben@apple.com>
2644
2645         Always decode tester names from location.hash
2646
2647         When navigating directly to a tester-specific URL (e.g.,
2648         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
2649         with a URL-encoded tester name in the page, and then the encoded name could make its way
2650         into Bugzilla bugs. Bad!
2651
2652         Reviewed by David Kilzer.
2653
2654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2655         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
2656         decodeURIComponent before trying to use it.
2657
2658 2011-05-27  Adam Roben  <aroben@apple.com>
2659
2660         Remove testing code that snuck into r87528
2661
2662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2663         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
2664
2665 2011-05-27  Adam Roben  <aroben@apple.com>
2666
2667         Add links to TestFailures to easily file bugs about failing tests
2668
2669         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
2670         links to file bugs for failing tests
2671
2672         Reviewed by David Kilzer.
2673
2674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2675         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
2676         for a particular build.
2677         (Builder.prototype._getFailingTests): Use resultsPageURL.
2678
2679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2680         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
2681         failures.
2682         (ViewController.prototype._domForBuildName): Use resultsPageURL.
2683         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
2684         new bug link. The bug has a title, description, and URL already filled in for you!
2685
2686 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2687
2688         Unreviewed, rolling out r87464.
2689         http://trac.webkit.org/changeset/87464
2690         https://bugs.webkit.org/show_bug.cgi?id=61643
2691
2692         client-close/server-close tests are flaky on Chromium Mac and
2693         Windows (Requested by aklein on #webkit).
2694
2695         * Scripts/webkitpy/thirdparty/__init__.py:
2696
2697 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
2698
2699         Added Douglas Davidson to contributors list for easier CC'ing.
2700
2701         * Scripts/webkitpy/common/config/committers.py:
2702
2703 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
2704
2705         Reviewed by Adam Barth.
2706
2707         Fix worldID and destinationDomain argument names
2708         https://bugs.webkit.org/show_bug.cgi?id=61571
2709
2710         As part of working on r87423, I noticed a couple of inconsistencies in
2711         argument names:
2712         - We would use worldId in .h files but worldID in .cpp files.
2713           Standardize on the latter
2714         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
2715           destinationDomains argument, even though the actual parameter was for
2716           a single domain (renamed to be singular).
2717
2718         * DumpRenderTree/LayoutTestController.h:
2719         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2720         (LayoutTestController::evaluateScriptInIsolatedWorld):
2721
2722 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
2723
2724         Reviewed by Kent Tamura.
2725
2726         WebSocket closing handshake
2727         https://bugs.webkit.org/show_bug.cgi?id=35721
2728
2729         * Scripts/webkitpy/thirdparty/__init__.py:
2730         Pull in pywebsocket 0.6b1. We need to update pywebsocket
2731         to get the right behavior of closing handshake.
2732
2733 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
2734
2735         Reviewed by Andreas Kling.
2736
2737         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
2738         https://bugs.webkit.org/show_bug.cgi?id=42676
2739
2740         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
2741
2742         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2743         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2744         (WTR::InjectedBundle::beginTesting):
2745         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2746         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
2747         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2748
2749 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2750
2751         Reviewed by Andreas Kling.
2752
2753         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
2754         https://bugs.webkit.org/show_bug.cgi?id=61527
2755
2756         The setMaximumHeight() call is unecessary and breaks the dialog at
2757         least on my setup.
2758
2759         * QtTestBrowser/launcherwindow.cpp:
2760         (LauncherWindow::showUserAgentDialog):
2761
2762 2011-05-02  Robert Hogan  <robert@webkit.org>
2763
2764         Reviewed by Adam Roben.
2765
2766         [Qt] Allow popup windows from plugins when initiated by a user gesture
2767
2768         https://bugs.webkit.org/show_bug.cgi?id=41292
2769
2770         Support parameters introduced in plugin-initiate-popup-window.html
2771
2772         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2773         (webkit_test_plugin_new_instance):
2774         (webkit_test_plugin_handle_event):
2775
2776 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
2777
2778         Reviewed by Adam Barth.
2779
2780         Support cross-origin XMLHttpRequest in isolated worlds
2781         https://bugs.webkit.org/show_bug.cgi?id=59843
2782
2783         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
2784
2785         * DumpRenderTree/chromium/LayoutTestController.cpp:
2786         (LayoutTestController::LayoutTestController):
2787         (LayoutTestController::setIsolatedWorldSecurityOrigin):
2788         * DumpRenderTree/chromium/LayoutTestController.h:
2789
2790 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
2791
2792         Reviewed by Adam Roben.
2793
2794         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
2795         https://bugs.webkit.org/show_bug.cgi?id=61474
2796         <rdar://problem/9468337>
2797
2798         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2799         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
2800
2801 2011-05-26  Andreas Kling  <kling@webkit.org>
2802
2803         Unreviewed, correct address to webkit-committers mailing list.
2804
2805         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2806
2807 2011-05-25  Adam Roben  <aroben@apple.com>
2808
2809         Don't assume that builds finish in the order they were started
2810
2811         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
2812         build when one slave is taking a long time to finish a build
2813
2814         Reviewed by Antti Koivisto.
2815
2816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2817         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
2818         newer than the oldest in-progress build are also themselves in progress. Just check whether
2819         each build is actually in progress (as signified by its presence in the currentBuilds set).
2820
2821 2011-05-25  Adam Roben  <aroben@apple.com>
2822
2823         Correctly detect cases where only a single test failed/crashed/timed out
2824
2825         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
2826         failing test
2827
2828         Reviewed by Darin Adler.
2829
2830         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2831         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
2832         will be singular when only a single test fails/crashes/times out.
2833
2834         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2835         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
2836         failed/crashed/timed out.
2837
2838 2011-05-26  Tom Hudson  <tomhudson@google.com>
2839
2840         Reviewed by Tony Chang.
2841
2842         Add flags to Chromium ImageDiff to write image comparison metrics on
2843         stdout.
2844         https://bugs.webkit.org/show_bug.cgi?id=60569
2845
2846         * DumpRenderTree/chromium/ImageDiff.cpp:
2847         (Image::createFromStdin): Fix spelling.
2848         (maxOf3): New function to do 3-way maximum.
2849         (getRedComponent): Extract red component from ABGR packed encoding.
2850         (getGreenComponent): Extract green component from ABGR packed encoding.
2851         (getBlueComponent): Extract blue component from ABGR packed encoding.
2852         (weightedPercentageDifferent): Determine % of pixels different in two
2853         images multiplied by intensity difference of each pixel.
2854         (printHelp): Document new arguments.
2855         (compareImages): Parameterize.
2856         (untestedCompareImages): Parameterize.
2857         (diffImages): Parameterize; write results on stdout if requested.
2858         (main): Parse new arguments.
2859
2860 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
2861
2862         Reviewed by Simon Hausmann.
2863
2864         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
2865         https://bugs.webkit.org/show_bug.cgi?id=42697
2866
2867         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
2868
2869         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2870         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2871         (WTR::InjectedBundle::beginTesting):
2872         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2873         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
2874         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2875
2876 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
2877
2878         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
2879         https://bugs.webkit.org/show_bug.cgi?id=61428
2880         <rdar://problem/9457006>
2881
2882         Reviewed by Adam Roben.
2883
2884         The crash occurs when Flash posts a message to a window that it
2885         creates, and in processing the message, it calls NPN_Evaluate to
2886         evaluate JavaScript that removes the plug-in from the page. Flash then
2887         crashes when we return to Flash code.
2888
2889         This test emulates that behavior.
2890
2891         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
2892         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
2893         Initialize member vars.
2894         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
2895         Remove our custom property from the message window, and destroy it.
2896         (CallJSThatDestroysPlugin::NPP_Destroy):
2897         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
2898         layout test controller that we're done.
2899         (wndProc):
2900         Get the PluginTest object, and call its runTest() function.
2901         (CallJSThatDestroysPlugin::NPP_New):
2902         Setup the test: register a class for the message-only window, create
2903         it, and post a message to it to run the test.
2904         (CallJSThatDestroysPlugin::runTest):
2905         Execute JS that removes the plug-in from the page, and if we're not
2906         destroyed, log a success message.
2907
2908         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2909         Add new test to project.
2910
2911 2011-05-25  Tony Chang  <tony@chromium.org>
2912
2913         Reviewed by Adam Barth.
2914
2915         webkitpy's NetworkTransaction shouldn't use mechanize
2916         https://bugs.webkit.org/show_bug.cgi?id=61450
2917
2918         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
2919         use urllib2 directly.  Re-add NetworkTransaction to
2920         test_results_uploader.py (reverting r87124).
2921
2922         * Scripts/webkitpy/common/net/networktransaction.py:
2923         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2924
2925 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
2926
2927         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
2928         until the port begins using those export macros.
2929
2930         * DumpRenderTree/chromium/config.h:
2931
2932 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2933
2934         Unreviewed, rolling out r87257.
2935         http://trac.webkit.org/changeset/87257
2936         https://bugs.webkit.org/show_bug.cgi?id=61457
2937
2938         This broke layout tests, see bug 61431. (Requested by
2939         hwennborg on #webkit).
2940
2941         * DumpRenderTree/chromium/LayoutTestController.cpp:
2942         (LayoutTestController::LayoutTestController):
2943         (LayoutTestController::clearAllDatabases):
2944         * DumpRenderTree/chromium/LayoutTestController.h:
2945
2946 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
2947
2948         Reviewed by Andreas Kling.
2949
2950         [Qt] fast/css/disabled-author-styles.html failed
2951         https://bugs.webkit.org/show_bug.cgi?id=61438
2952
2953         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
2954
2955         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2956         (WebCore::WebPage::resetSettings):
2957         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2958         (LayoutTestController::setAuthorAndUserStylesEnabled):
2959         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2960
2961 2011-05-25  Adam Roben  <aroben@apple.com>
2962
2963         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
2964
2965         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
2966         started exiting early due to too many crashes, timeouts, or failures
2967
2968         Reviewed by David Kilzer.
2969
2970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2971         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
2972         run-webkit-tests exits early due to too many failures, pass that information in another
2973         argument to the callback.
2974         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
2975         the new structure of the object passed to the callback.
2976         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
2977         getNumberOfFailingTests and to pass that along to our own callbacks.
2978         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
2979         from _getFailingTests and to store that value in the history object.
2980
2981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2982         (.info): Added.
2983
2984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2985         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
2986         object and to add a note when run-webkit-tests exited early due to too many failures.
2987         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
2988         latestBuildInfos since each entry now contains more than just the tester and failure count.
2989         Now displays a message for testers where the latest build exited early due to too many
2990         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
2991         store that value in latestBuildInfos.
2992
2993 2011-05-24  Keishi Hattori  <keishi@webkit.org>
2994
2995         Reviewed by Kent Tamura.
2996
2997         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
2998         https://bugs.webkit.org/show_bug.cgi?id=61273
2999
3000         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
3001
3002 2011-05-24  Greg Simon  <gregsimon@chromium.org>
3003
3004         Reviewed by Dimitri Glazkov.
3005
3006         Control Indexeddb backends from LayoutTestController
3007         https://bugs.webkit.org/show_bug.cgi?id=61000
3008
3009         * DumpRenderTree/chromium/LayoutTestController.cpp:
3010         (LayoutTestController::LayoutTestController):
3011         (LayoutTestController::setOverrideIndexedDBBackingStore):
3012         (LayoutTestController::clearAllDatabases):
3013         * DumpRenderTree/chromium/LayoutTestController.h:
3014
3015 2011-05-24  Robert Hogan  <robert@webkit.org>
3016
3017         Reviewed by Ryosuke Niwa.
3018
3019         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
3020         https://bugs.webkit.org/show_bug.cgi?id=61393
3021
3022         * DumpRenderTree/qt/EventSenderQt.h:
3023         * DumpRenderTree/qt/EventSenderQt.cpp:
3024         (getModifiers): static function for interpreting modifiers
3025         (EventSender::mouseDown): Respect keyboard modifiers
3026         (EventSender::keyDown): use new static function
3027         (EventSender::sendOrQueueEvent): whitespace fix
3028
3029 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
3030
3031         Reviewed by Adam Barth.
3032
3033         Adding MHTML reading support.
3034         https://bugs.webkit.org/show_bug.cgi?id=7168
3035
3036         * Scripts/build-webkit:
3037         * Scripts/old-run-webkit-tests:
3038         * Scripts/webkitperl/features.pm:
3039         * Scripts/webkitpy/layout_tests/port/test_files.py:
3040         * Scripts/webkitpy/layout_tests/port/webkit.py:
3041
3042 2011-05-24  Stephen White  <senorblanco@chromium.org>
3043
3044         Reviewed by Kenneth Russell.
3045
3046         Remove most style checks on Source/ThirdParty/glu, since it doesn't
3047         follow WebKit style.
3048         https://bugs.webkit.org/show_bug.cgi?id=61365
3049
3050         * Scripts/webkitpy/style/checker.py:
3051
3052 2011-05-24  Adam Roben  <aroben@apple.com>
3053
3054         Don't allow forcing builds through the build.webkit.org web interface
3055
3056         Someone has been forcing bogus builds.
3057
3058         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3059
3060 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
3061
3062         Reviewed by Adam Roben.
3063
3064         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
3065         https://bugs.webkit.org/show_bug.cgi?id=42669
3066
3067         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
3068         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
3069         Because that case changed the setting.
3070
3071         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3072         (WTR::InjectedBundle::beginTesting):
3073
3074 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
3075
3076         Reviewed by Kenneth Rohde Christiansen.
3077
3078         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
3079         https://bugs.webkit.org/show_bug.cgi?id=61052
3080
3081         * Scripts/old-run-webkit-tests:
3082
3083 2011-05-24  Adam Roben  <aroben@apple.com>
3084
3085         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
3086
3087         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
3088         that don't have any failing tests, which isn't useful
3089
3090         Reviewed by David Kilzer.
3091
3092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
3093         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
3094         instead of name strings.
3095         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
3096         builder names into an array of builders.
3097
3098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3099         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
3100         the most recently completed build, or -1 if there is no such build.
3101         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
3102         in the given build, or -1 if the number could not be determined. Some of this code came from
3103         _getFailingTests.
3104         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
3105         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
3106         getNumberOfFailingTests functions.
3107
3108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3109         (ViewController.prototype._displayTesters): Get the current number of test failures for each
3110         tester and show it in the list. Omit testers that have no failures at all. We keep the
3111         testers and failure counts in an array and sort it before displaying the current data, as
3112         the order in which data will be fetched is unpredictable.
3113
3114 2011-05-23  Tony Chang  <tony@chromium.org>
3115
3116         Reviewed by Ojan Vafai.
3117
3118         [nrwt] don't use NetworkTranslation when uploading results
3119         https://bugs.webkit.org/show_bug.cgi?id=61315
3120
3121         This avoids autoinstalling mechanize.  It didn't matter anyway
3122         because test_results_uploader.py wasn't using mechanize to make the
3123         request so NetworkTransaction::run wasn't doing anything extra
3124         (it only matters if it catches mechanize.HTTPError).
3125
3126         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3127
3128 2011-05-23  Tony Chang  <tony@chromium.org>
3129
3130         Reviewed by Dirk Pranke.
3131
3132         [chromium] fix the rebaseline tool to work with Linux GPU failures
3133         https://bugs.webkit.org/show_bug.cgi?id=61312
3134
3135         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3136
3137 2011-05-23  Darin Adler  <darin@apple.com>
3138
3139         Ignore generated .pyc files in a directory full of python code.
3140
3141         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
3142
3143 2011-05-23  Adam Barth  <abarth@webkit.org>
3144
3145         Reviewed by Eric Seidel.
3146
3147         sheriffbot should give more details about the failures in IRC
3148         https://bugs.webkit.org/show_bug.cgi?id=61233
3149
3150         With this patch, sheriffbot will annonce the set of failing tests,
3151         which might help folks triage the problem.
3152
3153         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3154         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3155
3156 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3157
3158         Unreviewed, rolling out r87078.
3159         http://trac.webkit.org/changeset/87078
3160         https://bugs.webkit.org/show_bug.cgi?id=61294
3161
3162         Patch contains errors and seems likely to break a bunch of
3163         bots (Requested by abarth on #webkit).
3164
3165         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3166         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3167         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3168
3169 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
3170
3171         Reviewed by Ojan Vafai.
3172
3173         Convert json_results_generator.py to output version 4 JSON.
3174         https://bugs.webkit.org/show_bug.cgi?id=60869
3175
3176         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3177         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3178         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3179
3180 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
3181
3182         Reviewed by Adam Barth.
3183
3184         Move generation of shell_command from port to executive
3185         https://bugs.webkit.org/show_bug.cgi?id=61251
3186
3187         After move it's possible to use the code in other places too.
3188
3189         * Scripts/webkitpy/common/config/ports.py:
3190         * Scripts/webkitpy/common/system/executive.py:
3191
3192 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
3193
3194         Reviewed by Darin Adler.
3195
3196         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
3197         https://bugs.webkit.org/show_bug.cgi?id=42669
3198
3199         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
3200
3201         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3202         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3203         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
3204         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3205
3206 2011-05-22  Robert Hogan  <robert@webkit.org>
3207
3208         Reviewed by Kenneth Rohde Christiansen.
3209
3210         Fix policyDelegate in Qt DRT
3211         https://bugs.webkit.org/show_bug.cgi?id=61247
3212
3213         Use the 'policy delegate' implemented in FrameLoaderClient
3214         for layout tests. The partial implementation in DumpRenderTreeQt
3215         is redundant, so remove it.
3216
3217         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3218         (WebCore::WebPage::acceptNavigationRequest):
3219         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3220         (LayoutTestController::waitForPolicyDelegate):
3221
3222 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
3223
3224         Reviewed by Darin Adler.
3225
3226         Use double quotes for filename arguments
3227         https://bugs.webkit.org/show_bug.cgi?id=61250
3228
3229         Windows does not support single quotes on the command line,
3230         so replace them with double quotes.
3231
3232         * Scripts/prepare-ChangeLog:
3233
3234 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
3235
3236         Reviewed by Sam Weinig.
3237
3238         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
3239         https://bugs.webkit.org/show_bug.cgi?id=42550
3240         
3241         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
3242
3243         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3244         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3245         Copy the code for pausing animations, FIXME comments and all.
3246         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3247         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3248
3249 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
3250
3251         Reviewed by Stephen White.
3252
3253         Adding myself to the committers list.
3254
3255         * Scripts/webkitpy/common/config/committers.py:
3256
3257 2011-05-19  Adam Roben  <aroben@apple.com>
3258
3259         Test that the WebKit2 UI process doesn't crash when starting a download
3260
3261         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
3262         (preceded by assertion) in fastMalloc when downloading a file
3263
3264         Reviewed by Darin Adler.
3265
3266         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
3267
3268         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
3269         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
3270         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
3271         started, cancel the download, and return a bogus string.
3272
3273         (TestWebKitAPI::setContextDownloadClient):
3274         (TestWebKitAPI::setPagePolicyClient):
3275         Simple helper functions.
3276
3277         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
3278         our policy client, and run until we know that the download was started. If we haven't
3279         crashed, we win!
3280
3281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3282         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3283         * TestWebKitAPI/win/copy-resources.cmd:
3284         Added new files.
3285
3286 2011-05-20  Kent Tamura  <tkent@chromium.org>
3287
3288         Reviewed by Ryosuke Niwa.
3289
3290         Fix style errors in DumpRenderTree/chromium/.
3291         https://bugs.webkit.org/show_bug.cgi?id=61172
3292
3293         * DumpRenderTree/chromium/CppBoundClass.cpp:
3294         (CppBoundClass::getAsCppVariant):
3295         (CppBoundClass::bindToJavascript):
3296         * DumpRenderTree/chromium/CppBoundClass.h:
3297         (CppBoundClass::GetterCallback::~GetterCallback):
3298         (CppBoundClass::CppBoundClass):
3299         (CppBoundClass::Callback::~Callback):
3300         (CppBoundClass::MemberCallback::MemberCallback):
3301         (CppBoundClass::MemberCallback::~MemberCallback):
3302         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
3303         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
3304         * DumpRenderTree/chromium/CppVariant.h:
3305         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3306         (DRTDevToolsAgent::~DRTDevToolsAgent):
3307         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3308         (DRTDevToolsClient::sendFrontendLoaded):
3309         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3310         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3311         (main):
3312         * DumpRenderTree/chromium/EventSender.cpp:
3313         (SavedEvent::SavedEvent):
3314         (EventSender::EventSender):
3315         (EventSender::keyDown):
3316         * DumpRenderTree/chromium/EventSender.h:
3317         * DumpRenderTree/chromium/ImageDiff.cpp:
3318         (Image::Image):
3319         * DumpRenderTree/chromium/LayoutTestController.cpp:
3320         (LayoutTestController::LayoutTestController):
3321         (LayoutTestController::WorkQueue::reset):
3322         (WorkItemBackForward::WorkItemBackForward):
3323         (WorkItemLoadingScript::WorkItemLoadingScript):
3324         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
3325         (WorkItemLoad::WorkItemLoad):
3326         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3327         (LayoutTestController::pathToLocalResource):
3328         * DumpRenderTree/chromium/LayoutTestController.h:
3329         (LayoutTestController::WorkItem::~WorkItem):
3330         (LayoutTestController::WorkQueue::WorkQueue):
3331         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3332         (MockSpellCheck::MockSpellCheck):
3333         (MockSpellCheck::~MockSpellCheck):
3334         * DumpRenderTree/chromium/MockSpellCheck.h:
3335         * DumpRenderTree/chromium/NotificationPresenter.h:
3336         (NotificationPresenter::NotificationPresenter):
3337         * DumpRenderTree/chromium/Task.cpp:
3338         (WebTask::WebTask):
3339         * DumpRenderTree/chromium/Task.h:
3340         (TaskList::TaskList):
3341         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3342         (DRTPrinter::DRTPrinter):
3343         (TestShellPrinter::TestShellPrinter):
3344         * DumpRenderTree/chromium/TestNavigationController.cpp:
3345         (TestNavigationEntry::TestNavigationEntry):
3346         (TestNavigationEntry::~TestNavigationEntry):
3347         (TestNavigationController::TestNavigationController):
3348         (TestNavigationController::reload):
3349         (TestNavigationController::loadEntry):
3350         (TestNavigationController::didNavigateToEntry):
3351         * DumpRenderTree/chromium/TestNavigationController.h:
3352         (TestShellExtraData::TestShellExtraData):
3353         * DumpRenderTree/chromium/TestShell.cpp:
3354         (dumpHistoryItem):
3355         * DumpRenderTree/chromium/TestShell.h:
3356         (TestParams::TestParams):
3357         * DumpRenderTree/chromium/TestShellWin.cpp:
3358         (TestShell::waitTestFinished):
3359         * DumpRenderTree/chromium/TestWebWorker.h:
3360         (TestWebWorker::startWorkerContext):
3361         (TestWebWorker::terminateWorkerContext):
3362         (TestWebWorker::postMessageToWorkerContext):
3363         (TestWebWorker::clientDestroyed):
3364         (TestWebWorker::postMessageToWorkerObject):
3365         (TestWebWorker::postExceptionToWorkerObject):
3366         (TestWebWorker::postConsoleMessageToWorkerObject):
3367         (TestWebWorker::confirmMessageFromWorkerObject):
3368         (TestWebWorker::reportPendingActivity):
3369         (TestWebWorker::workerContextClosed):
3370         (TestWebWorker::~TestWebWorker):
3371         * DumpRenderTree/chromium/TextInputController.cpp:
3372         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
3373         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3374         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3375         (WebThemeEngineDRTWin::paintButton):
3376         (WebThemeEngineDRTWin::paintMenuList):
3377         (WebThemeEngineDRTWin::paintTrackbar):
3378         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
3379         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3380         * DumpRenderTree/chromium/WebViewHost.cpp:
3381         (WebViewHost::navigate):
3382         (WebViewHost::updateSessionHistory):
3383         (WebViewHost::paintInvalidatedRegion):
3384         * DumpRenderTree/chromium/WebViewHost.h:
3385
3386 2011-05-19  Dmitry Lomov  <dslomov@google.com>
3387
3388         Reviewed by Adam Roben.
3389
3390         Detect hangs in run-api-tests
3391         https://bugs.webkit.org/show_bug.cgi?id=48043
3392
3393         * Scripts/run-api-tests: Added test timeouts
3394
3395 2011-05-19  Dmitry Lomov  <dslomov@google.com>
3396
3397         Reviewed by Adam Roben.
3398
3399         run-api-tests should run one test per process
3400         https://bugs.webkit.org/show_bug.cgi?id=61088
3401
3402         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
3403         return code, and parsing GTest output format.
3404
3405 2011-05-15  Robert Hogan  <robert@webkit.org>
3406
3407         Reviewed by Antonio Gomes.
3408
3409         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
3410         https://bugs.webkit.org/show_bug.cgi?id=60834
3411         Fix unix test plugin for plugins/get-url-with-javascript-url.html
3412
3413         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3414         (webkit_test_plugin_new_stream):
3415         (webkit_test_plugin_write_ready):
3416         (webkit_test_plugin_write):
3417
3418 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3419
3420         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
3421         http://trac.webkit.org/changeset/86869
3422         http://trac.webkit.org/changeset/86873
3423         http://trac.webkit.org/changeset/86875
3424         http://trac.webkit.org/changeset/86877
3425         https://bugs.webkit.org/show_bug.cgi?id=61139
3426
3427         broke builds and debug DRT (Requested by rniwa on #webkit).
3428
3429         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3430         * DumpRenderTree/chromium/TestShell.cpp:
3431         (TestShell::bindJSObjectsToWindow):
3432         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3433         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3434
3435 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
3436
3437         Reviewed by Darin Adler.
3438
3439         Add build logistics and plumbing for window.internals object.
3440         https://bugs.webkit.org/show_bug.cgi?id=60313
3441
3442         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
3443         * DumpRenderTree/chromium/TestShell.cpp:
3444         (TestShell::bindJSObjectsToWindow): Added injection code.
3445         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3446         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
3447
3448 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3449
3450         Reviewed by Csaba Osztrogonác.
3451
3452         [Qt] Implement eventSender.scalePageBy
3453         https://bugs.webkit.org/show_bug.cgi?id=60015
3454
3455         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3456         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3457         * DumpRenderTree/qt/EventSenderQt.cpp:
3458         (EventSender::scalePageBy):
3459         * DumpRenderTree/qt/EventSenderQt.h:
3460
3461 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
3462
3463         Reviewed by Kent Tamura.
3464
3465         [Chromium] IME candidate window appears wrong position in an iframe
3466         https://bugs.webkit.org/show_bug.cgi?id=61023
3467
3468         Call the focused frame's firstRectForCharacterRange() instead of the
3469         main frame so that DRT behaves as the same as Chromium.
3470
3471         * DumpRenderTree/chromium/TextInputController.cpp:
3472         (TextInputController::firstRectForCharacterRange):
3473
3474 2011-05-18  Adam Roben  <aroben@apple.com>
3475
3476         Add a new page to build.webkit.org to help find when tests started failing
3477
3478         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
3479         right now, but already shows some useful information. It's somewhat similar to webkit-patch
3480         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
3481         little more convenient than either of them, though, because it's all done in the browser
3482         (and thus it's easy to go directly to the relevant test results).
3483
3484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
3485         (Buildbot): This class represents a Buildbot server.
3486         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
3487         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
3488         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
3489         callback.
3490         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
3491         be implemented by a derived class that understands this server's build naming scheme.
3492         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
3493         particular build.
3494
3495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
3496         (Builder): This class represents one builder on the buildbot.
3497         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
3498         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
3499         information about a particular test failure.
3500         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
3501         information about when tests started failing.
3502         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
3503         particular build.
3504         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
3505         callback.
3506         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
3507         extracts all the failing tests listed in it, passing them to the callback.
3508         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
3509         build, merges them into the build history, and calls the callback telling it whether the
3510         next build should be fetched to provide more information.
3511
3512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
3513         Added. Just some simple styles.
3514
3515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
3516         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
3517         (getResource): Wrapper around XMLHttpRequest.
3518         (Array.prototype.findFirst): Finds the first element matching the given predicate and
3519         returns it.
3520         (Array.prototype.last): Returns the last element of the array.
3521
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
3523         (ViewController): This class contains the main logic for displaying the page.
3524         (ViewController.loaded): Just calls through to parseHash.
3525         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
3526         shows the list of all testers so one can be chosen. This function is called when the page
3527         loads and whenever we get a hashchange event.
3528         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
3529         as it is fetched. The display ends up grouping tests by when they started failing.
3530         (ViewController._displayTesters): Gets the list of testers and displays it.
3531
3532         (ViewController._domForBuildName):
3533         (ViewController._domForFailedTest):
3534         Helper functions to create descriptions and links for a particular build or failed test.
3535
3536         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
3537         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
3538         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
3539
3540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
3541         loads all the files and sets up a ViewController, which does the rest.
3542
3543         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
3544         page.
3545
3546 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3547
3548         Reviewed by Csaba Osztrogonác.
3549
3550         [Qt] Implement layoutTestController.setValueForUser()
3551         https://bugs.webkit.org/show_bug.cgi?id=60956
3552
3553         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3554         (LayoutTestController::setValueForUser):
3555         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3556
3557 2011-05-16  Robert Hogan  <robert@webkit.org>
3558
3559         Reviewed by Kenneth Rohde Christiansen.
3560
3561         plugins/invalidate_rect.html fails on linux ports
3562
3563         - Make the unix test netscape plugin recognize the onPaintEvent
3564           and windowedPlugin parameters.
3565
3566         https://bugs.webkit.org/show_bug.cgi?id=54051
3567
3568         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3569         (handleEventX11):
3570         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3571         (LayoutTestController::displayInvalidatedRegion):
3572         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3573         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3574         (webkit_test_plugin_new_instance):
3575         (webkit_test_plugin_handle_event):
3576
3577 2011-05-17  Tony Chang  <tony@chromium.org>
3578
3579         Reviewed by Ojan Vafai.
3580
3581         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
3582         https://bugs.webkit.org/show_bug.cgi?id=60895
3583
3584         Update the tools to handle the move.  Lucid 32 results now go in
3585         chromium-linux-x86 and the default platform on Linux is now x86_64.
3586
3587         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
3588         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3589         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
3590         * Scripts/webkitpy/layout_tests/port/base.py: ditto
3591         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
3592         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3593         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
3594         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
3595         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
3596
3597 2011-05-17  Adam Roben  <aroben@apple.com>
3598
3599         Make run-api-tests work on Windows when there are spaces in the path
3600
3601         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
3602         spaces in the path to TestWebKitAPI.exe
3603
3604         Reviewed by David Levin.
3605
3606         * Scripts/run-api-tests:
3607         (runTestTool): Use the "direct object" form of system() to avoid having the path to
3608         TestWebKitAPI.exe be split by the shell.
3609
3610 2011-05-16  Ian Henderson  <ianh@apple.com>
3611
3612         Reviewed by Joseph Pecoraro.
3613
3614         Page::goToItem doesn't work while loading is deferred
3615         https://bugs.webkit.org/show_bug.cgi?id=60412
3616
3617         Add setDefersLoading and goBack methods to LayoutTestController.  We
3618         need to use goBack() instead of history.back() because the latter goes
3619         through NavigationScheduler, hence doesn't exhibit the bug.
3620
3621         * DumpRenderTree/LayoutTestController.cpp:
3622         (goBackCallback):
3623         (setDefersLoadingCallback):
3624         (LayoutTestController::staticFunctions):
3625         * DumpRenderTree/LayoutTestController.h:
3626         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3627         (LayoutTestController::goBack):
3628         (LayoutTestController::setDefersLoading):
3629         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3630         (LayoutTestController::goBack):
3631         (LayoutTestController::setDefersLoading):
3632         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3633         (LayoutTestController::goBack):
3634         (LayoutTestController::setDefersLoading):
3635         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3636         (LayoutTestController::goBack):
3637         (LayoutTestController::setDefersLoading):
3638
3639 2011-05-16  Sam Weinig  <sam@webkit.org>
3640
3641         Reviewed by Anders Carlsson.
3642
3643         TestWebKitAPI should build with clang if it can
3644         https://bugs.webkit.org/show_bug.cgi?id=60918
3645
3646         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
3647         Update CompilerVersion.xcconfig to match others.
3648
3649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3650         Add CompilerVersion.xcconfig to the project.
3651
3652         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3653         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
3654         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3655         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3656         Add some casts to quiet warnings from clang.
3657
3658 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
3659
3660         Reviewed by David Levin.
3661
3662         add dpranke as a reviewer
3663         https://bugs.webkit.org/show_bug.cgi?id=60919
3664
3665         * Scripts/webkitpy/common/config/committers.py:
3666
3667 2011-05-16  Robert Hogan  <robert@webkit.org>
3668
3669         Reviewed by Anders Carlsson.
3670
3671         [Gtk] plugins/get-url-not