1 2011-06-16 Kevin Ollivier <kevino@theolliviers.com>
3 [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
4 preference like the perl scripts do.
6 * waf/build/build_utils.py:
7 * waf/build/settings.py:
9 2011-06-16 Tommy Widenflycht <tommyw@google.com>
11 Reviewed by Tony Gentilcore.
13 MediaStream API: Runtime enabled features
14 https://bugs.webkit.org/show_bug.cgi?id=62798
16 Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
18 * DumpRenderTree/chromium/TestShell.cpp:
19 (TestShell::TestShell):
21 2011-06-16 Torsten Kurbad <gentoo@tk-webart.de>
23 Reviewed by Eric Seidel.
25 Add support for sys.platform == 'linux3' by relaxing
26 conditional statements and/or extending lookup dicts.
27 This way, Linux kernels >=3.0-rc1 get supported in the
29 https://bugs.webkit.org/show_bug.cgi?id=62730
31 * Scripts/webkitpy/common/system/executive.py:
32 * Scripts/webkitpy/common/system/file_lock.py:
33 * Scripts/webkitpy/common/system/path_unittest.py:
34 * Scripts/webkitpy/layout_tests/layout_package/manager.py:
35 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
36 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
37 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
38 * Scripts/webkitpy/layout_tests/port/factory.py:
39 * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
40 * Scripts/webkitpy/layout_tests/port/qt.py:
41 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
43 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
45 Unreviewed, rolling out r88796.
46 http://trac.webkit.org/changeset/88796
47 https://bugs.webkit.org/show_bug.cgi?id=62790
49 It made fast/dom/nodesFromRect-basic.html time out on Qt,
50 64-bit, debug mode (Requested by Ossy on #webkit).
52 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
53 (LayoutTestController::nodesFromRect):
54 * DumpRenderTree/qt/LayoutTestControllerQt.h:
55 * DumpRenderTree/qt/PlainTextControllerQt.cpp:
56 (PlainTextController::plainText):
57 * DumpRenderTree/qt/PlainTextControllerQt.h:
59 2011-06-15 Dirk Pranke <dpranke@chromium.org>
61 Unreviewed, build fix.
63 Revert the patches in r88995 and r88999; the http servers don't
64 seem to be shutting down reliably.
66 * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
67 * Scripts/webkitpy/layout_tests/port/base.py:
68 * Scripts/webkitpy/layout_tests/port/http_server.py:
69 * Scripts/webkitpy/layout_tests/port/http_server_base.py:
70 * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
71 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
72 * Scripts/webkitpy/layout_tests/port/websocket_server.py:
74 2011-06-15 Dirk Pranke <dpranke@chromium.org>
76 Unreviewed, build fix.
78 Add some debugging messages to triage problems introduced in
81 * Scripts/webkitpy/layout_tests/port/http_server_base.py:
83 2011-06-15 Dirk Pranke <dpranke@chromium.org>
85 Reviewed by Tony Chang.
87 nrwt: should clean up stale server processes from a previous run
88 https://bugs.webkit.org/show_bug.cgi?id=62615
90 This change fixes cases where NRWT might start a server and then
91 exit, leaving the server still running. Now NRWT should detect
92 this case and clean up on the next run, without shutting down
93 any processes it didn't start.
95 This change also fixes a bug in executive.kill_process on UNIX
96 where zombies weren't being handled properly.
98 * Scripts/webkitpy/common/system/executive.py:
99 * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
100 * Scripts/webkitpy/layout_tests/port/base.py:
101 * Scripts/webkitpy/layout_tests/port/http_server.py:
102 * Scripts/webkitpy/layout_tests/port/http_server_base.py:
103 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
104 * Scripts/webkitpy/layout_tests/port/websocket_server.py:
106 2011-06-15 Dirk Pranke <dpranke@chromium.org>
108 Reviewed by Tony Chang.
110 nrwt: fix http, websocket server startup, shutdown
111 https://bugs.webkit.org/show_bug.cgi?id=62180
113 This change refactors all of the server-related code to
114 have consistent semantics. It pushes the start()/stop()
115 logic into the base class and adds four much smaller routines
117 _prepare_config() - for optionally writing config files etc.
118 to disk prior to starting the server
119 _remove_stale_log_files()
120 _spawn_process() - the actual launch of the subprocess
121 _cleanup_after_stop() - and custom cleanup code
123 Prior to this change the three server implementations were
124 fairly inconsistent, leading to lots of weirdness on the bots
125 with servers being left around, etc.
127 * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
128 * Scripts/webkitpy/layout_tests/port/http_server.py:
129 * Scripts/webkitpy/layout_tests/port/http_server_base.py:
130 * Scripts/webkitpy/layout_tests/port/websocket_server.py:
132 2011-06-15 Dirk Pranke <dpranke@chromium.org>
134 Reviewed by Tony Chang.
136 webkitpy: clean up code prior to functional changes for server startup/shutdown
137 https://bugs.webkit.org/show_bug.cgi?id=62256
139 This patch does a bunch of minor cleanup of the code, but there
140 should be no functional changes except that all of the modules
141 will now use the same exception type. Other changes include
142 removing unused code paths and functions, pushing 'name' and
143 'pid_file' into the base class of the server objects, and using
144 the Filesystem object instead of the codecs, tempfile, and
147 * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
148 * Scripts/webkitpy/layout_tests/port/http_server.py:
149 * Scripts/webkitpy/layout_tests/port/http_server_base.py:
150 * Scripts/webkitpy/layout_tests/port/websocket_server.py:
152 2011-06-15 Dirk Pranke <dpranke@chromium.org>
154 Reviewed by Tony Chang.
156 webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
157 https://bugs.webkit.org/show_bug.cgi?id=62251
159 shut_down_http_server() was a total hack that was only used by
160 new-run-webkit-httpd, so I've moved the code there and switched
161 to using executive.kill_process() for the common case. The
162 method itself will be removed in the patch on bug 59993.
164 * Scripts/new-run-webkit-httpd:
165 * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
166 * Scripts/webkitpy/layout_tests/port/http_server.py:
167 * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
168 * Scripts/webkitpy/layout_tests/port/websocket_server.py:
170 2011-06-15 Dirk Pranke <dpranke@chromium.org>
172 Unreviewed, build fix.
174 Fix test-webkitpy failure introduced in r88986.
176 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
178 2011-06-15 Dirk Pranke <dpranke@chromium.org>
180 Reviewed by Eric Seidel.
182 NRWT: doesn't support webarchives, has stale skipping logic.
183 https://bugs.webkit.org/show_bug.cgi?id=58293
185 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
186 * Scripts/webkitpy/layout_tests/port/base.py:
187 * Scripts/webkitpy/layout_tests/port/webkit.py:
189 2011-06-15 Jeremy Orlow <jorlow@webkit.org>
191 Change my email to @webkit.org
193 * Scripts/webkitpy/common/config/committers.py:
195 2011-06-15 Nikolas Zimmermann <nzimmermann@rim.com>
197 Reviewed by David Hyatt.
199 CSS 2.1: Support replaced elements with relative intrinsic sizes
200 https://bugs.webkit.org/show_bug.cgi?id=15849
202 CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
203 https://bugs.webkit.org/show_bug.cgi?id=53099
205 Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
207 * Scripts/old-run-webkit-tests:
208 * Scripts/webkitpy/layout_tests/port/test_files.py:
210 2011-06-15 Carlos Garcia Campos <cgarcia@igalia.com>
212 Reviewed by Martin Robinson.
214 [GTK] Add a statusbar to MiniBrowser
215 https://bugs.webkit.org/show_bug.cgi?id=62634
217 It shows the url of the current hovered link.
219 * MiniBrowser/gtk/BrowserWindow.c:
220 (browserWindowConstructed): Create the GtkSatusbar.
221 (mouseDidMoveOverElement): Update statusbar text.
222 (browserWindowUIClientInit): Add implementation for
223 mouseDidMoveOverElement().
224 * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
225 * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
226 (mouseDidMoveOverElement): Pass the url of the current hovered
227 link to the UI process.
228 (didCreatePage): Set the UI client adding an implementation for
229 mouseDidMoveOverElement().
230 (WKBundleInitialize):
231 * MiniBrowser/gtk/main.c:
232 (createWKContextWithInjectedBundle): Create a global context with
234 (loadURI): Use the global context.
237 2011-06-14 Lucas Forschler <lforschler@apple.com>
239 Reviewed by Stephanie Lewis.
241 https://bugs.webkit.org/show_bug.cgi?id=62495
242 Bug 62495 - combine windows and mac kill-old-processes script
243 Add a platform agnostic script. Remove the recently added mac flavor.
244 Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
246 * BuildSlaveSupport/kill-old-processes: Added.
247 * BuildSlaveSupport/mac: Removed.
248 * BuildSlaveSupport/mac/kill-old-processes: Removed.
250 2011-06-14 Dirk Pranke <dpranke@chromium.org>
252 Reviewed by Tony Chang.
254 nrwt: handle worker exceptions cleanly
255 https://bugs.webkit.org/show_bug.cgi?id=62614
257 This change modifiers new-run-webkit-tests to handle exceptions
258 raised by worker threads better, by:
259 - capturing the worker's stack and logging it in the manager
260 - propagating the worker's exception in the caller correctly
261 - attempting to cancel the workers and clean up even when
262 we get an unexpected exception
264 * Scripts/webkitpy/layout_tests/layout_package/manager.py:
265 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
266 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
267 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
269 2011-06-14 Qi Zhang <qi.2.zhang@nokia.com>
271 Reviewed by Laszlo Gombos.
273 [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
274 https://bugs.webkit.org/show_bug.cgi?id=62227
276 QtWebkit does not yet support different CacheModels. This change will
277 expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
279 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
280 (LayoutTestController::setCacheModel):
281 * DumpRenderTree/qt/LayoutTestControllerQt.h:
283 2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
285 Reviewed by Andreas Kling.
287 [Qt] tst_QWebFrame::overloadedSlots() fails
288 https://bugs.webkit.org/show_bug.cgi?id=37319
290 Since we don't implictly convert 'document' object to QWebElement
291 in metacalls anymore, change the controller to expect QVariantMap instead.
293 The method plainText() was updated to use QVariantMap as well to let the bridge
294 do the conversion directly for us.
296 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
297 (LayoutTestController::nodesFromRect):
298 * DumpRenderTree/qt/LayoutTestControllerQt.h:
299 * DumpRenderTree/qt/PlainTextControllerQt.cpp:
300 (PlainTextController::plainText):
301 * DumpRenderTree/qt/PlainTextControllerQt.h:
303 2011-06-14 Andras Becsi <abecsi@webkit.org>
305 Reviewed by Csaba Osztrogonác.
307 Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
308 https://bugs.webkit.org/show_bug.cgi?id=62630
310 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
311 (NPP_New): remove dead variable 'forceCarbon'
313 2011-06-13 Hayato Ito <hayato@chromium.org>
315 Reviewed by Ojan Vafai.
317 [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
318 https://bugs.webkit.org/show_bug.cgi?id=59188
320 A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
321 WebKitDriver should always return an actual hash value if DRT returns that.
323 No tests since I'll add sample reftests to make sure mismatch reftests work later,
324 which should be in a separate patch.
326 * Scripts/webkitpy/layout_tests/port/webkit.py:
328 2011-06-13 Kent Tamura <tkent@chromium.org>
330 [Chromium-win] Fix two wrong assertions exposed by r88757.
332 * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
333 (WebThemeEngineDRTWin::paintTrackbar):
335 2011-06-13 Alexey Proskuryakov <ap@apple.com>
337 Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
338 and commit queue happy.
340 * Scripts/webkitpy/common/config/committers.py:
342 2011-06-13 Chris Rogers <crogers@google.com>
344 Unreviewed build fix.
346 Build fix to chromium DRT until we can rebaseline some tests
347 https://bugs.webkit.org/show_bug.cgi?id=62608
349 * DumpRenderTree/chromium/TestShell.cpp:
350 (TestShell::TestShell):
352 2011-06-13 Chris Rogers <crogers@google.com>
354 Reviewed by Dirk Pranke.
356 Add Web Audio support to chromium DRT
357 https://bugs.webkit.org/show_bug.cgi?id=62306
359 * DumpRenderTree/chromium/LayoutTestController.cpp:
360 (LayoutTestController::LayoutTestController):
361 (LayoutTestController::reset):
362 (LayoutTestController::setEncodedAudioData):
363 * DumpRenderTree/chromium/LayoutTestController.h:
364 (LayoutTestController::encodedAudioData):
365 (LayoutTestController::shouldDumpAsAudio):
366 (LayoutTestController::setShouldDumpAsAudio):
367 * DumpRenderTree/chromium/TestEventPrinter.cpp:
368 (DRTPrinter::handleAudioHeader):
369 (TestShellPrinter::handleAudioHeader):
370 * DumpRenderTree/chromium/TestEventPrinter.h:
371 * DumpRenderTree/chromium/TestShell.cpp:
372 (TestShell::TestShell):
375 2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>
377 Reviewed by Eric Seidel.
379 [EFL] Add load error handler to EWebLauncher
380 https://bugs.webkit.org/show_bug.cgi?id=62347
382 Add a handler function of "load,error" to EWebLauncher.
383 EWebLauncher now displays a simple error page on load errors.
385 * EWebLauncher/main.c:
389 2011-06-13 Martin Robinson <mrobinson@igalia.com>
391 Reviewed by Eric Seidel.
393 [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
394 https://bugs.webkit.org/show_bug.cgi?id=62385
396 Remove duplicate TestNetscapePlugIn implementation. Having two copies
397 of this code makes keeping it in sync much more difficult. The files are
398 almost identical and this change ports the X11 changes to main.cpp.
400 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
401 (NPP_New): Do not set the plugin as windowless always. Doing this breaks
402 some results on Qt and this seems to be unnecessary for the moment.
403 (keyEventToChar): Added this helper which converts a X11 keycode into a char.
404 (handleEventX11): Use the handler to properly convert the keycode. Do not print
405 adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
406 it should not be in the results.
407 (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
408 XP_UNIX block is first by guarding against using a null instance.
409 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
410 the XP_UNIX define for Linux.
411 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
412 * GNUmakefile.am: Update source list.
414 2011-06-13 Sheriff Bot <webkit.review.bot@gmail.com>
416 Unreviewed, rolling out r88671.
417 http://trac.webkit.org/changeset/88671
418 https://bugs.webkit.org/show_bug.cgi?id=62591
420 "didn't work" (Requested by dpranke on #webkit).
422 * Scripts/new-run-webkit-httpd:
423 * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
424 * Scripts/webkitpy/layout_tests/port/http_server.py:
425 * Scripts/webkitpy/layout_tests/port/http_server_base.py:
426 * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
427 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
428 * Scripts/webkitpy/layout_tests/port/websocket_server.py:
430 2011-06-13 Nate Chapin <japhet@chromium.org>
432 Reviewed by Darin Fisher.
434 New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
436 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
438 2011-06-13 Dirk Pranke <dpranke@chromium.org>
440 Reviewed by Tony Chang.
442 webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
443 https://bugs.webkit.org/show_bug.cgi?id=62251
445 shut_down_http_server() was a total hack that was only used by
446 new-run-webkit-httpd, so I've moved the code there and switched
447 to using executive.kill_process() for the common case. The
448 method itself will be removed in the patch on bug 59993.
450 * Scripts/new-run-webkit-httpd:
451 * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
452 * Scripts/webkitpy/layout_tests/port/http_server.py:
453 * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
454 * Scripts/webkitpy/layout_tests/port/websocket_server.py:
456 2011-06-13 Tony Chang <tony@chromium.org>
458 Reviewed by Dimitri Glazkov.
460 rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
461 https://bugs.webkit.org/show_bug.cgi?id=62578
463 * Scripts/build-webkit:
465 2011-06-13 Tony Chang <tony@chromium.org>
467 Reviewed by Adam Barth.
469 rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
470 https://bugs.webkit.org/show_bug.cgi?id=62545
472 * Scripts/build-webkit:
474 2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
476 Reviewed by Martin Robinson.
478 [GTK] Export an API similar to WebKit1
479 https://bugs.webkit.org/show_bug.cgi?id=57820
481 Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
482 code, but linking to libwebkit2gtk.
485 * GtkLauncher/main.c:
489 2011-06-12 MORITA Hajime <morrita@google.com>
491 Unreviewed, rolling out r88625.
492 http://trac.webkit.org/changeset/88625
493 https://bugs.webkit.org/show_bug.cgi?id=61073
495 Breaks SL Webkit2 Tests
497 * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
498 * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
499 * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
500 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
501 (WTR::InjectedBundlePage::didClearWindowForFrame):
502 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
504 2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
506 Reviewed by Antonio Gomes.
508 [Qt] LayoutTestController needs setTextDirection implementation
509 https://bugs.webkit.org/show_bug.cgi?id=62442
511 Implements LayoutController.setTextDirection.
513 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
514 (LayoutTestController::setTextDirection):
515 * DumpRenderTree/qt/LayoutTestControllerQt.h:
517 2011-06-12 Dominic Cooney <dominicc@chromium.org>
519 Reviewed by Hajime Morita.
521 Add window.internals to WebKit2's WebKitTestRunner.
522 https://bugs.webkit.org/show_bug.cgi?id=61073
524 Test: fast/harness/internals-object.html
526 * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
527 * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
528 * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
529 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
530 (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
531 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
533 2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
535 Unreviewed, rolling out r88616.
536 http://trac.webkit.org/changeset/88616
537 https://bugs.webkit.org/show_bug.cgi?id=62517
539 It broke editing/text-iterator/findString.html (Requested by
540 tonikitoo on #webkit).
542 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
543 * DumpRenderTree/qt/LayoutTestControllerQt.h:
545 2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
547 Reviewed by Antonio Gomes.
549 [Qt] LayoutTestController needs setTextDirection implementation
550 https://bugs.webkit.org/show_bug.cgi?id=62442
552 Implements LayoutController.setTextDirection.
554 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
555 (LayoutTestController::setTextDirection):
556 * DumpRenderTree/qt/LayoutTestControllerQt.h:
558 2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
560 Reviewed by Ojan Vafai.
562 new-run-webkit-tests: 'images' links on results.html don't work
563 https://bugs.webkit.org/show_bug.cgi?id=62194
565 Use relative path when generating images-diffs.html
567 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
568 Added _output_testname.
570 2011-06-10 Lucas Forschler <lforschler@apple.com>
572 Reviewed by Stephanie Lewis.
574 Script to kill old processes on Mac.
575 This matches the windows version.
576 https://bugs.webkit.org/show_bug.cgi?id=62479
578 * BuildSlaveSupport/mac: Added.
579 * BuildSlaveSupport/mac/kill-old-processes: Added.
581 2011-06-10 Adam Barth <abarth@webkit.org>
583 Reviewed by James Robinson.
585 When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
586 https://bugs.webkit.org/show_bug.cgi?id=62489
588 * Scripts/webkitpy/tool/bot/sheriff.py:
589 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
591 2011-06-10 Tony Chang <tony@chromium.org>
593 Reviewed by Ojan Vafai.
595 add a compile guard ENABLE(FLEXBOX)
596 https://bugs.webkit.org/show_bug.cgi?id=62049
598 * Scripts/build-webkit:
600 2011-06-10 Mark Rowe <mrowe@apple.com>
602 Reviewed by Dimitri Glazkov.
604 <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
606 Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
609 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
610 * DumpRenderTree/mac/Configurations/Base.xcconfig:
612 2011-06-09 Csaba Osztrogonác <ossy@webkit.org>
614 Unreviewed rolling out r88471, because it broke plugin tests on Qt.
616 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
619 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
620 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
621 (webkit_test_plugin_new_instance):
622 (webkit_test_plugin_destroy_instance):
623 (webkit_test_plugin_set_window):
625 (webkit_test_plugin_new_stream):
626 (webkit_test_plugin_destroy_stream):
627 (webkit_test_plugin_stream_as_file):
628 (webkit_test_plugin_write_ready):
629 (webkit_test_plugin_write):
630 (webkit_test_plugin_print):
632 (webkit_test_plugin_handle_event):
633 (webkit_test_plugin_url_notify):
634 (webkit_test_plugin_get_value):
635 (webkit_test_plugin_set_value):
636 (NP_GetMIMEDescription):
642 2011-06-09 Martin Robinson <mrobinson@igalia.com>
644 Reviewed by Eric Seidel.
646 [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
647 https://bugs.webkit.org/show_bug.cgi?id=55603
649 Add callbacks to support hasMarkedText and markedRange and also clean up existing
650 TextInputController support.
652 * DumpRenderTree/gtk/TextInputController.cpp:
653 (setMarkedTextCallback): Accept parameters in terms of start and length, instead
654 of start and end. This matches the other ports. Do not use GLib style early returns.
655 (hasMarkedTextCallback): Added.
656 (markedRangeCallback): Added.
657 (insertTextCallback): Cleanup as described above.
658 (unmarkTextCallback): Cleanup as described above.
659 (firstRectForCharacterRangeCallback): Cleanup as described above.
660 (selectedRangeCallback): Cleanup as described above.
662 2011-06-09 Dirk Pranke <dpranke@chromium.org>
664 Reviewed by Tony Chang.
666 nrwt: support webaudio in chromium driver
667 https://bugs.webkit.org/show_bug.cgi?id=62226
669 * Scripts/webkitpy/layout_tests/port/chromium.py:
671 2011-06-09 Dan Bernstein <mitz@apple.com>
673 Reviewed by Anders Carlsson.
675 Added a test for Vector::reverse()
676 https://bugs.webkit.org/show_bug.cgi?id=62393
678 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
679 * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
680 (TestWebKitAPI::TEST):
681 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
683 2011-06-09 Martin Robinson <mrobinson@igalia.com>
685 Reviewed by Andreas Kling.
687 [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
688 https://bugs.webkit.org/show_bug.cgi?id=62385
690 Remove duplicate TestNetscapePlugIn implementation. Having two copies
691 of this code makes keeping it in sync much more difficult. The files are
692 almost identical and this change ports the X11 changes to main.cpp.
694 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
695 (keyEventToChar): Added this helper which converts a X11 keycode into a char.
696 (handleEventX11): Use the handler to properly convert the keycode. Do not print
697 adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
698 it should not be in the results.
699 (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
700 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
701 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
702 * GNUmakefile.am: Update source list.
704 2011-06-09 Noel Gordon <noel.gordon@gmail.com>
706 Reviewed by Tony Chang.
708 Test plugin should support event logging on the windows port.
709 https://bugs.webkit.org/show_bug.cgi?id=61721
711 The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
712 calls to mean the plugin handled the event.
714 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
715 (handleEventWin): Return 0 for each event on windows.
717 2011-06-09 Chang Shu <cshu@webkit.org>
719 Reviewed by Andreas Kling.
721 [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
722 https://bugs.webkit.org/show_bug.cgi?id=62381
724 Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
725 QWKPagePrivate::isViewFocused() will check it later.
727 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
728 (WTR::PlatformWebView::PlatformWebView):
730 2011-06-09 Robert Hogan <robert@webkit.org>
732 Reviewed by Andreas Kling.
734 Teach Qt about window.internals
735 https://bugs.webkit.org/show_bug.cgi?id=61074
737 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
738 (WebCore::DumpRenderTree::initJSObjects):
740 2011-06-09 Eric Seidel <eric@webkit.org>
742 Reviewed by Adam Barth.
744 Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
745 https://bugs.webkit.org/show_bug.cgi?id=62362
747 The mac bots are failing inspector tests. We don't know why yet.
748 So for now, turning run-webkit-tests off for the mac-ews.
750 Also noticed that due to the wrong variable name the cr-linux
751 bots weren't running tests!
753 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
755 2011-06-09 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
757 Reviewed by Csaba Osztrogonac.
759 [Qt][WK2] Canvas tests make css2.1 ones failing
760 https://bugs.webkit.org/show_bug.cgi?id=53427
762 Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
763 Since the Qt port should eventually go to QRawFont, this issue will be resolved
764 in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
765 needed for the workaround.
767 * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
768 (WTR::LayoutTestController::platformInitialize):
770 2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>
772 Reviewed by Chris Fleizach.
774 [GTK] Provide a way in DRT to check the platform name
775 https://bugs.webkit.org/show_bug.cgi?id=56855
777 Patch for adding 'platformName' static property to DRT's
778 LayoutController and provide platform specific implementations.
780 In principle, this feature will be only of interest for writing
781 accessibility tests, so that's why it's only implemented in the
782 Mac, Gtk and Win platforms.
784 * DumpRenderTree/LayoutTestController.h: New method platformName().
785 * DumpRenderTree/LayoutTestController.cpp:
786 (getPlatformNameCallback): New callback for 'platformName'.
787 (LayoutTestController::staticValues): New static property.
789 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
790 (LayoutTestController::platformName): Implemented.
792 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
793 (LayoutTestController::platformName): Implemented.
795 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
796 (LayoutTestController::platformName): Implemented.
798 2011-06-08 Mike Lawther <mikelawther@chromium.org>
800 Reviewed by James Robinson.
802 Add mikelawther to committers.py
803 https://bugs.webkit.org/show_bug.cgi?id=62354
805 * Scripts/webkitpy/common/config/committers.py:
807 2011-06-08 Kent Tamura <tkent@chromium.org>
809 [Chromium] Fix a typo.
811 * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
812 (WebThemeControlDRTWin::draw):
814 2011-06-08 Kent Tamura <tkent@chromium.org>
816 Reviewed by Hajime Morita.
818 [Chromium] Support vertical sliders in Windows DRT
819 https://bugs.webkit.org/show_bug.cgi?id=62352
821 * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
822 (WebThemeControlDRTWin::draw):
823 Paint VerticalSliderThumbType and VerticalSliderTrackType.
824 * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
825 Add VerticalSliderTrackType and VerticalSliderThumbType.
826 * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
827 (WebThemeEngineDRTWin::paintTrackbar):
828 Convert Windows identifiers to the internal identifiers for vertical sliders.
830 2011-06-08 Ojan Vafai <ojan@chromium.org>
832 Reviewed by Tony Chang.
834 add a short-flag for --experimental-fully-parallel
835 https://bugs.webkit.org/show_bug.cgi?id=62321
837 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
839 2011-06-08 Ryosuke Niwa <rniwa@webkit.org>
841 Reviewed by Tony Chang.
843 new-run-webkit-tests: don't turn the tree red when there are new passes
844 https://bugs.webkit.org/show_bug.cgi?id=62311
846 Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
847 to match commandComplete.
849 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
851 2011-06-08 Tom Hudson <tomhudson@google.com>
853 Reviewed by Mihai Parparita.
855 Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
856 https://bugs.webkit.org/show_bug.cgi?id=60964
858 * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
859 Add 'Sort tests by metric' link.
860 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
861 (disableSorting): Activate 'Sort tests by metric' link.
862 (enableSorting): Deactivate 'Sort tests by metric' link.
863 (selectDirectory): Call enableSorting()/disableSorting() depending
864 on currently selected failure type, and sort tests if requested.
865 * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
866 New .disabled-control class for deactivated links.
868 2011-06-08 Tom Sepez <tsepez@chromium.org>
870 Reviewed by Adam Barth.
872 Add web permissions callbacks for mixed content blocking.
873 https://bugs.webkit.org/show_bug.cgi?id=61946
875 * DumpRenderTree/chromium/LayoutTestController.cpp:
876 (LayoutTestController::setAllowDisplayOfInsecureContent):
877 (LayoutTestController::setAllowRunningOfInsecureContent):
878 (LayoutTestController::overridePreference):
879 * DumpRenderTree/chromium/WebPermissions.cpp:
880 (WebPermissions::allowDisplayingInsecureContent):
881 (WebPermissions::allowRunningInsecureContent):
882 (WebPermissions::setDisplayingInsecureContentAllowed):
883 (WebPermissions::setRunningInsecureContentAllowed):
884 (WebPermissions::reset):
885 * DumpRenderTree/chromium/WebPermissions.h:
887 2011-06-08 Dirk Pranke <dpranke@chromium.org>
889 Reviewed by Tony Chang.
891 webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
892 https://bugs.webkit.org/show_bug.cgi?id=62259
894 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
896 2011-06-08 Ryosuke Niwa <rniwa@webkit.org>
898 Reviewed by Tony Chang.
900 new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
901 https://bugs.webkit.org/show_bug.cgi?id=62303
903 Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
905 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
907 2011-06-08 Greg Simon <gregsimon@chromium.org>
909 Reviewed by Dimitri Glazkov.
911 Control Indexeddb backends from LayoutTestController
912 https://bugs.webkit.org/show_bug.cgi?id=61000
914 * DumpRenderTree/chromium/LayoutTestController.cpp:
915 (LayoutTestController::LayoutTestController):
916 (LayoutTestController::setOverrideIndexedDBBackingStore):
917 (LayoutTestController::clearAllDatabases):
918 * DumpRenderTree/chromium/LayoutTestController.h:
920 2011-06-08 Andreas Kling <kling@webkit.org>
922 Add Pierre Rossi to contributors list for EZ-CC.
924 * Scripts/webkitpy/common/config/committers.py:
926 2011-06-08 Ilya Sherman <isherman@chromium.org>
928 Reviewed by Andreas Kling.
930 Add Ilya Sherman to list of committers
931 https://bugs.webkit.org/show_bug.cgi?id=62270
933 * Scripts/webkitpy/common/config/committers.py:
935 2011-06-07 Ryosuke Niwa <rniwa@webkit.org>
937 Reviewed by Tony Chang.
939 new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
940 https://bugs.webkit.org/show_bug.cgi?id=62178
942 Added commandComplete and evaluateCommand for NewRunWebKitTests class
943 to parse new-run-webkit-tests' results.
945 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
947 2011-06-07 Dirk Pranke <dpranke@chromium.org>
949 Reviewed by Eric Seidel.
951 webkitpy: add a popen() call to executive
952 https://bugs.webkit.org/show_bug.cgi?id=62179
954 This change adds a popen() wrapper call to the Executive object.
955 This will allow other webkitpy scripts that currently call
956 subprocess directly to use Executive, instead.
958 No additional tests are necessary (the existing tests cover the code).
960 * Scripts/webkitpy/common/system/executive.py:
962 2011-06-07 Sam Weinig <sam@webkit.org>
964 Reviewed by Anders Carlsson.
966 Remove repeated IPC traffic from SetRenderTreeSize message
967 https://bugs.webkit.org/show_bug.cgi?id=62244
969 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
970 (WTR::InjectedBundlePage::InjectedBundlePage):
971 Add stub for didLayoutForFrame.
973 2011-06-07 Dirk Pranke <dpranke@chromium.org>
975 Reviewed by Tony Chang.
977 rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
978 https://bugs.webkit.org/show_bug.cgi?id=62241
980 * Scripts/webkitpy/layout_tests/port/chromium.py:
982 2011-06-07 Adam Barth <abarth@webkit.org>
984 Rubber-stamped by Eric Seidel.
986 Enable tests on the mac-ews
988 When we bring the mac-ews back up, we're going to try running tests!
990 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
992 2011-06-07 Dmitry Lomov <dslomov@google.com>
994 Reviewed by David Levin.
996 https://bugs.webkit.org/show_bug.cgi?id=62215
997 Allow comparisons with 0 in LIKELY and UNLIKELY macros.
999 * Scripts/webkitpy/style/checkers/cpp.py:
1000 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1002 2011-06-07 Nico Weber <thakis@chromium.org>
1004 Reviewed by Dimitri Glazkov.
1006 [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
1007 https://bugs.webkit.org/show_bug.cgi?id=62210
1009 The change to TestEventPrinter fixes a latent bug, because
1010 objects are deleted through the TestEventPrinter type, but none
1011 of the subclasses have destructors or non-POD members.
1013 The changes to NotificationPresenter and WebViewHost do _not_ to fix a
1014 real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
1015 discussed at http://codereview.chromium.org/7094005/, we prefer making
1016 leaf class destructors virtual over making the leaf classes final.
1018 * DumpRenderTree/chromium/NotificationPresenter.cpp:
1019 (NotificationPresenter::~NotificationPresenter):
1020 * DumpRenderTree/chromium/NotificationPresenter.h:
1021 * DumpRenderTree/chromium/TestEventPrinter.cpp:
1022 (TestEventPrinter::~TestEventPrinter):
1023 * DumpRenderTree/chromium/TestEventPrinter.h:
1024 * DumpRenderTree/chromium/WebViewHost.h:
1026 2011-06-06 Ryosuke Niwa <rniwa@webkit.org>
1028 Reviewed by Dirk Pranke.
1030 [chromium] Chromium bots on build.webkit.org don't upload results.html
1031 https://bugs.webkit.org/show_bug.cgi?id=61961
1033 Don't fix the path on chromium port erroneously.
1035 * BuildSlaveSupport/test-result-archive:
1037 2011-06-06 Martin Robinson <mrobinson@igalia.com>
1039 Fix the GTK+ build by ensuring that the autogenerated sources
1040 necessary for libWebCoreInternals are recorded in a predeclared
1041 variable before assigning to BUILT_SOURCES.
1043 * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
1045 2011-06-06 Yong Li <yoli@rim.com>
1047 Reviewed by Eric Seidel.
1049 https://bugs.webkit.org/show_bug.cgi?id=62097
1050 Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
1052 * Scripts/webkitpy/style/checkers/cpp.py:
1053 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1055 2011-06-06 Xan Lopez <xlopez@igalia.com>
1057 Reviewed by Martin Robinson.
1059 [GTK] Enable feature/symbol detection in NWRT/GTK
1060 https://bugs.webkit.org/show_bug.cgi?id=62136
1062 Disable feature detection through DRT, since we don't support it,
1063 and set the libwebcore patch correctly so that symbol detection
1066 * Scripts/webkitpy/layout_tests/port/gtk.py:
1068 2011-06-06 Shishir Agrawal <shishir@chromium.org>
1070 Reviewed by Tony Gentilcore.
1072 Add a "prerender" state for page visibility.
1073 https://bugs.webkit.org/show_bug.cgi?id=62062
1075 * DumpRenderTree/chromium/LayoutTestController.cpp:
1076 (LayoutTestController::setPageVisibility):
1078 2011-06-06 Csaba Osztrogonác <ossy@webkit.org>
1080 [Qt] Implement download feature for QtTestBrowser
1081 https://bugs.webkit.org/show_bug.cgi?id=61865
1083 Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
1085 * QtTestBrowser/launcherwindow.cpp:
1086 (LauncherWindow::LauncherWindow):
1087 * QtTestBrowser/launcherwindow.h:
1089 2011-06-06 Barát Tibor <Barat.Tibor@stud.u-szeged.hu>
1091 Reviewed by Csaba Osztrogonác.
1093 [Qt] Implement download feature for QtTestBrowser
1094 https://bugs.webkit.org/show_bug.cgi?id=61865
1096 * QtTestBrowser/launcherwindow.cpp:
1097 (LauncherWindow::LauncherWindow):
1098 (LauncherWindow::downloadRequest):
1099 (LauncherWindow::fileDownloadFinished):
1100 * QtTestBrowser/launcherwindow.h:
1102 2011-06-04 Dominic Cooney <dominicc@chromium.org>
1104 Reviewed by Dimitri Glazkov.
1106 Make DumpRenderTree initialize window.internals.
1107 https://bugs.webkit.org/show_bug.cgi?id=61076
1109 * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
1110 * DumpRenderTree/win/FrameLoadDelegate.cpp:
1111 (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1113 2011-06-06 Alexandru Chiculita <achicu@adobe.com>
1115 Reviewed by Kent Tamura.
1117 Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
1118 https://bugs.webkit.org/show_bug.cgi?id=61628
1120 * Scripts/build-webkit:
1122 2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
1124 Reviewed by Kent Tamura.
1126 Add ENABLE(CSS_REGIONS) guard for CSS Regions support
1127 https://bugs.webkit.org/show_bug.cgi?id=61631
1129 * Scripts/build-webkit:
1131 2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
1133 Unreviewed. Fix the GTK+ build.
1135 * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
1137 2011-06-05 Alexey Proskuryakov <ap@apple.com>
1139 Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
1142 * Scripts/webkitpy/common/config/committers.py:
1144 2011-06-04 Kevin Ollivier <kevino@theolliviers.com>
1146 [wx] Unreviewed build fix. Update git branch build dir handling to match what other
1147 WebKit scripts expect, so other scripts work properly with wx.
1149 * waf/build/build_utils.py:
1150 * waf/build/settings.py:
1152 2011-06-04 Kevin Ollivier <kevino@theolliviers.com>
1154 [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
1157 * waf/build/settings.py:
1158 * wx/install-unix-extras:
1160 2011-06-04 Kevin Ollivier <kevino@theolliviers.com>
1162 [wx] Unreviewed build fixes for recent trunk changes.
1164 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1165 (LayoutTestController::setTextDirection):
1166 * waf/build/settings.py:
1168 2011-06-04 Martin Robinson <mrobinson@igalia.com>
1172 * GNUmakefile.am: Add some missing newline escape.
1174 2011-06-03 Martin Robinson <mrobinson@igalia.com>
1176 Try to fix the GTK+ bulid.
1178 * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
1181 2011-06-03 Dirk Pranke <dpranke@chromium.org>
1183 Reviewed by Adam Barth.
1185 nrwt: should skip chromium test expectation overrides on upstream bots
1186 https://bugs.webkit.org/show_bug.cgi?id=61888
1188 * Scripts/webkitpy/layout_tests/port/chromium.py:
1189 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1191 2011-06-03 Dirk Pranke <dpranke@chromium.org>
1193 Reviewed by Ojan Vafai.
1195 new-run-webkit-tests: minor logging, code cleanup
1196 https://bugs.webkit.org/show_bug.cgi?id=62055
1198 * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1199 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1201 2011-06-03 Martin Robinson <mrobinson@igalia.com>
1203 Try to fix the build failure on the GTK+ 32-bit Release bot.
1205 * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
1207 2011-05-31 Martin Robinson <mrobinson@igalia.com>
1209 Reviewed by Ryosuke Niwa.
1211 [GTK] Support smart replace for the pasteboard
1212 https://bugs.webkit.org/show_bug.cgi?id=61734
1214 Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
1215 This is required to produce consistent test results.
1217 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1218 (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
1219 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1220 (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
1221 methods which calls into DumpRenderTreeSupportGtk.
1223 2011-06-03 Martin Robinson <mrobinson@igalia.com>
1225 Reviewed by Dimitri Glazkov.
1227 Teach Gtk build about window.internals
1228 https://bugs.webkit.org/show_bug.cgi?id=61071
1230 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1231 (webViewWindowObjectCleared): Inject the new internals object when the
1232 window object clears.
1233 * GNUmakefile.am: Add new source files and includes necessary for window.internals.
1234 Also do a little bit of cleanup.
1236 2011-06-03 Dirk Pranke <dpranke@chromium.org>
1238 Reviewed by Tony Chang.
1240 Worker may not be stopped after LT.
1241 https://bugs.webkit.org/show_bug.cgi?id=61847
1243 Re-submit a variant of the first fix for this bug. It's possible
1244 that actually calling cleanup() in the worker threads was taking
1245 too long and we triggered the assertions in the manager thread.
1247 I've bumped up the timeout in the manager and added better
1248 diagnostics. I also cleaned up the cleanup() code a bit because
1249 there was some unnecessary if-checks.
1251 * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1252 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1254 2011-06-03 Dirk Pranke <dpranke@chromium.org>
1256 Reviewed by Tony Chang.
1258 nrwt: fix duplicate logging regression
1259 https://bugs.webkit.org/show_bug.cgi?id=61981
1261 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1263 2011-06-03 Robert Kroeger <rjkroege@chromium.org>
1265 Reviewed by Adam Barth.
1267 Modified addTouchPoint to correctly re-use touchPoint id values starting
1268 from the lowest not-un-use touchPoint id as is done by the embedder
1269 APIs. (Fixes BUGCR36415)
1271 https://bugs.webkit.org/show_bug.cgi?id=62016
1273 * DumpRenderTree/chromium/EventSender.cpp:
1274 (EventSender::addTouchPoint):
1276 2011-06-03 Cary Clark <caryclark@google.com>
1278 Reviewed by Eric Seidel.
1280 Draw DRT scroll bar thumb with CG when WebKit renders with Skia
1281 https://bugs.webkit.org/show_bug.cgi?id=61534
1283 Skia on Mac uses Skia to render WebKit, and CG
1284 to render UI elements. The CG elements need a
1285 transcribed graphics context that preserves the
1286 canvas matrix, and the canvas clip.
1288 The SkiaBitLocker utility class sets up a CGContext
1289 from the SkCanvas, locks the bitmap's bits, and
1290 releases the lock when the class goes out of scope.
1292 The SkiaBitLocker implementation is described by
1294 http://codereview.chromium.org/7031006/
1296 When WebKit uses Skia for rendering, the WebCanvas
1297 is an SkCanvas. Create an equivalent CGContext to
1298 draw the scrollbar thumb.
1300 As the Chrome Mac port does not yet use Skia, this
1301 patch has no effect and requires no tests.
1303 * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1304 (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1306 2011-06-03 Andras Becsi <abecsi@webkit.org>
1308 Unreviewed build fix.
1312 * Scripts/old-run-webkit-tests:
1314 2011-06-03 Andras Becsi <abecsi@webkit.org>
1316 Reviewed by Csaba Osztrogonác.
1318 Print error message when there is no httpd present on the system
1319 https://bugs.webkit.org/show_bug.cgi?id=61939
1321 * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
1322 * Scripts/webkitperl/httpd.pm:
1324 2011-06-03 Mikhail Naganov <mnaganov@chromium.org>
1326 Reviewed by Yury Semikhatsky.
1328 Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
1329 https://bugs.webkit.org/show_bug.cgi?id=61533
1331 Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
1333 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1334 (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
1335 * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1336 * DumpRenderTree/chromium/LayoutTestController.cpp:
1337 (LayoutTestController::LayoutTestController):
1338 (LayoutTestController::setJavaScriptProfilingEnabled):
1339 * DumpRenderTree/chromium/LayoutTestController.h:
1340 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1341 (LayoutTestController::setJavaScriptProfilingEnabled):
1342 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1343 (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
1344 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1346 2011-06-02 Dirk Pranke <dpranke@chromium.org>
1348 Reviewed by Tony Chang.
1350 NRWT needs a way to log to a file without including backspaces without needing --verbose
1351 https://bugs.webkit.org/show_bug.cgi?id=60328
1353 This change modifies NRWT so that if it can tell if it is
1354 writing to a terminal, it will overwrite any messages printed
1355 in the 'one-line-progress' and 'updates' print options, and if
1356 not (or if --verbose was specified) the messages will be printed
1359 If the overwriting updates are disabled, one-line-progress will
1360 only print every 10 seconds instead of on every update. This
1361 ensures that we still get updates once in a while while the
1362 tests are running, even if we're not in --verbose mode. Note
1363 that one-line-progress will now still be printed in --verbose,
1364 since it's useful as long as you're not flooded with the
1367 * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1368 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1369 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1371 2011-06-02 Martin Robinson <mrobinson@igalia.com>
1373 Reviewed by Gustavo Noronha Silva.
1375 [GTK] autogen.sh is run twice for each buld on the bots
1376 https://bugs.webkit.org/show_bug.cgi?id=61951
1378 * Scripts/webkitdirs.pm: Only check the previous autotools arguments
1379 for the WebKit project. This prevents build-jsc runs from forcing subsequent
1380 build-webkit runs to re-rerun autogen.sh.
1382 2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
1384 Unreviewed, rolling out r87946.
1385 http://trac.webkit.org/changeset/87946
1386 https://bugs.webkit.org/show_bug.cgi?id=61965
1388 Cause NRWT to break (Requested by abarth|gardener on #webkit).
1390 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1392 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
1394 Reviewed by Darin Adler.
1396 Add build logistics and plumbing for window.internals object.
1397 https://bugs.webkit.org/show_bug.cgi?id=60313
1399 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1400 * DumpRenderTree/chromium/TestShell.cpp:
1401 (TestShell::bindJSObjectsToWindow): Added injection code.
1402 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1403 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1405 2011-06-02 Hao Zheng <zhenghao@chromium.org>
1407 Reviewed by Dirk Pranke.
1409 Call cleanup() explicitly at the end of worker.run().
1410 https://bugs.webkit.org/show_bug.cgi?id=61847
1412 * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1414 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
1416 Unreviewed, rolling out r87926.
1417 http://trac.webkit.org/changeset/87926
1418 https://bugs.webkit.org/show_bug.cgi?id=60313
1420 Fails to find WebCoreTestSupport.dylib on bots.
1422 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1423 * DumpRenderTree/chromium/TestShell.cpp:
1424 (TestShell::bindJSObjectsToWindow):
1425 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1426 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1428 2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
1430 Reviewed by Darin Adler.
1432 Add build logistics and plumbing for window.internals object.
1433 https://bugs.webkit.org/show_bug.cgi?id=60313
1435 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1436 * DumpRenderTree/chromium/TestShell.cpp:
1437 (TestShell::bindJSObjectsToWindow): Added injection code.
1438 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1439 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1441 2011-06-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1443 Reviewed by Eric Seidel.
1445 Adjust efl coding style to more efl directories
1446 https://bugs.webkit.org/show_bug.cgi?id=61903
1448 * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
1450 2011-06-01 Dirk Pranke <dpranke@chromium.org>
1452 Reviewed by Tony Chang.
1454 old-run-webkit-tests: add support for audio files
1455 https://bugs.webkit.org/show_bug.cgi?id=57992
1457 * Scripts/old-run-webkit-tests:
1459 2011-06-01 Jochen Eisinger <jochen@chromium.org>
1461 Reviewed by Adam Barth.
1463 Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
1464 https://bugs.webkit.org/show_bug.cgi?id=34314
1466 * DumpRenderTree/DumpRenderTree.gypi:
1467 * DumpRenderTree/chromium/LayoutTestController.cpp:
1468 (LayoutTestController::LayoutTestController):
1469 (LayoutTestController::setImagesAllowed):
1470 (LayoutTestController::setStorageAllowed):
1471 * DumpRenderTree/chromium/LayoutTestController.h:
1472 * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
1473 (WebPermissions::WebPermissions):
1474 (WebPermissions::~WebPermissions):
1475 (WebPermissions::allowImages):
1476 (WebPermissions::allowStorage):
1477 (WebPermissions::setImagesAllowed):
1478 (WebPermissions::setStorageAllowed):
1479 (WebPermissions::reset):
1480 * DumpRenderTree/chromium/WebPermissions.h:
1482 2011-06-01 Noel Gordon <noel.gordon@gmail.com>
1484 Reviewed by Tony Chang.
1486 Test plugin should support event logging on the windows port.
1487 https://bugs.webkit.org/show_bug.cgi?id=61721
1489 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1490 (handleEventWin): Well, handle them.
1492 2011-06-01 Daniel Cheng <dcheng@chromium.org>
1494 Reviewed by Tony Chang.
1496 [chromium] Use correct file name for dragging out images.
1497 https://bugs.webkit.org/show_bug.cgi?id=24887
1499 * DumpRenderTree/chromium/EventSender.cpp:
1500 (EventSender::EventSender):
1501 (EventSender::dumpFilenameBeingDragged):
1502 * DumpRenderTree/chromium/EventSender.h:
1504 2011-06-01 Dirk Pranke <dpranke@chromium.org>
1506 Reviewed by Tony Chang.
1508 nrwt: make webaudio work w/o content-length header
1509 https://bugs.webkit.org/show_bug.cgi?id=61819
1511 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1512 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1513 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1514 * Scripts/webkitpy/layout_tests/port/webkit.py:
1516 2011-06-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
1518 Reviewed by Andreas Kling.
1520 [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
1521 https://bugs.webkit.org/show_bug.cgi?id=61802
1523 Add command line parameter and menu item to MiniBrowser application
1524 enabling use of QGLWidget for browser viewport.
1526 * MiniBrowser/qt/BrowserWindow.cpp:
1527 (BrowserWindow::BrowserWindow):
1528 (BrowserWindow::toggleGLViewport):
1529 * MiniBrowser/qt/BrowserWindow.h:
1530 * MiniBrowser/qt/MiniBrowserApplication.cpp:
1531 (MiniBrowserApplication::handleUserOptions):
1532 * MiniBrowser/qt/MiniBrowserApplication.h:
1533 (WindowOptions::WindowOptions):
1535 2011-06-01 Martin Robinson <mrobinson@igalia.com>
1537 Reviewed by Xan Lopez.
1539 Print out autogen arguments when they differ from the last set, to help
1540 with debugging build issues.
1542 * Scripts/webkitdirs.pm: Print out previous and current build arguments
1545 2011-06-01 Carlos Garcia Campos <cgarcia@igalia.com>
1547 Reviewed by Martin Robinson.
1549 [GTK] run-launcher should run MiniBrowser in WebKit2
1550 https://bugs.webkit.org/show_bug.cgi?id=61858
1552 * Scripts/run-launcher: Check whether -2 command line option has
1553 been passed and run MiniBrowser instead of GtkLauncher.
1555 2011-05-31 Hao Zheng <zhenghao@chromium.org>
1557 Reviewed by Dirk Pranke.
1559 Fix exception in verbose printing mode.
1560 https://bugs.webkit.org/show_bug.cgi?id=61723
1562 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1564 2011-05-31 Yong Li <yoli@rim.com>
1566 Reviewed by Eric Seidel.
1568 https://bugs.webkit.org/show_bug.cgi?id=54807
1569 We have been assuming plain bitfields (like "int a : 31") are always signed integers.
1570 However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
1571 bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
1572 http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
1573 Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
1574 always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
1575 rule we should have in order to make our code independent from compilers and compiler flags.
1577 * Scripts/webkitpy/style/checkers/cpp.py:
1579 2011-05-31 Hironori Bono <hbono@chromium.org>
1581 Reviewed by Eric Seidel.
1583 Add a JavaScript function layoutTestController.setTextDirection().
1584 https://bugs.webkit.org/show_bug.cgi?id=50952
1586 This change adds a new JavaScript function setTextDirection() to the
1587 LayoutTestController class of Safari and Chrome to write layout tests
1588 that changes the text direction of an editable element.
1590 * DumpRenderTree/LayoutTestController.cpp:
1591 (setTextDirectionCallback):
1592 (LayoutTestController::staticFunctions):
1593 * DumpRenderTree/LayoutTestController.h:
1594 * DumpRenderTree/chromium/LayoutTestController.cpp:
1595 (LayoutTestController::LayoutTestController):
1596 (LayoutTestController::setTextDirection):
1597 * DumpRenderTree/chromium/LayoutTestController.h:
1598 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1599 (LayoutTestController::setTextDirection):
1600 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1601 (LayoutTestController::setTextDirection):
1602 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1603 (LayoutTestController::setTextDirection):
1605 2011-05-31 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
1607 Reviewed by Simon Hausmann.
1609 [Qt] User-agent list of Qt test browsers is very outdated
1610 https://bugs.webkit.org/show_bug.cgi?id=61531
1612 The user can edit the user-agent manually, so there's no need to have
1613 a super complete and up to date list, but it's nice to have it
1616 * MiniBrowser/qt/useragentlist.txt:
1617 * QtTestBrowser/useragentlist.txt:
1619 2011-03-30 Martin Robinson <mrobinson@igalia.com>
1621 Reviewed by Adam Roben.
1623 [GTK] [WebKit2] Implement a basic WebKitTestRunner
1624 https://bugs.webkit.org/show_bug.cgi?id=57068
1626 Add an implementation of WebKitTestRunner for GTK+.
1628 * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
1629 * Scripts/old-run-webkit-tests: Ditto.
1630 * Scripts/run-launcher: Ditto.
1631 * Scripts/webkitdirs.pm: Ditto.
1632 * WebKitTestRunner/GNUmakefile.am: Added.
1633 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1634 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
1635 * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1636 * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1637 * WebKitTestRunner/PlatformWebView.h:
1638 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
1639 * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
1640 * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1641 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1642 * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1645 2011-05-31 Dirk Pranke <dpranke@chromium.org>
1647 Reviewed by Tony Chang.
1649 new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
1650 https://bugs.webkit.org/show_bug.cgi?id=60241
1652 * Scripts/new-run-webkit-tests:
1654 2011-05-31 Eric Seidel <eric@webkit.org>
1656 Reviewed by David Kilzer.
1658 webkitpy should create zips with zip -9
1659 https://bugs.webkit.org/show_bug.cgi?id=61789
1661 Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
1663 * Scripts/webkitpy/common/system/workspace.py:
1664 * Scripts/webkitpy/common/system/workspace_unittest.py:
1666 2011-05-31 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
1668 Reviewed by Csaba Osztrogonác.
1670 [Qt] Implement find feature for QtTestBrowser
1671 https://bugs.webkit.org/show_bug.cgi?id=61425
1673 Buildfix for --minimal and CONFIG+=qt_minimal build.
1675 * QtTestBrowser/launcherwindow.cpp:
1676 (LauncherWindow::LauncherWindow):
1677 (LauncherWindow::createChrome):
1678 * QtTestBrowser/launcherwindow.h:
1680 2011-05-31 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
1682 Reviewed by Csaba Osztrogonác.
1684 [Qt] Implement find feature for QtTestBrowser
1685 https://bugs.webkit.org/show_bug.cgi?id=61425
1687 * QtTestBrowser/launcherwindow.cpp:
1688 (LauncherWindow::LauncherWindow):
1689 (LauncherWindow::createChrome):
1690 (LauncherWindow::showFindBar):
1691 (LauncherWindow::find):
1692 * QtTestBrowser/launcherwindow.h:
1694 2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>
1696 Reviewed by Martin Robinson.
1698 [GTK] Implement JavaScript dialogs in MiniBrowser
1699 https://bugs.webkit.org/show_bug.cgi?id=61725
1701 * MiniBrowser/gtk/BrowserWindow.c:
1702 (WKStringGetCString): Helper function to get a UTF-8 c string from
1704 (WKURLGetCString): Helper function to get a UTF-8 c string from a
1706 (browserWindowUpdateURL): Update to use WKURLGetCString.
1707 (didReceiveTitleForFrame): Update to use WKStringGetCString.
1708 (createMessageDialog): Create a GtkMessageDialog.
1709 (runJavaScriptAlert):
1710 (runJavaScriptConfirm):
1711 (runJavaScriptPrompt):
1712 (browserWindowUIClientInit):
1714 2011-05-29 Yuta Kitamura <yutak@chromium.org>
1716 Reviewed by Kent Tamura.
1718 WebSocket closing handshake
1719 https://bugs.webkit.org/show_bug.cgi?id=35721
1721 * Scripts/webkitpy/thirdparty/__init__.py:
1722 Pull in pywebsocket 0.6b1. We need to update pywebsocket
1723 to get the right behavior of closing handshake.
1725 2011-05-29 Daniel Bates <dbates@rim.com>
1727 Reviewed by David Kilzer.
1729 REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
1730 https://bugs.webkit.org/show_bug.cgi?id=61162
1732 Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
1733 that omits a line count. In particular, the chunk range regular expression does
1734 not match a chunk range line that omits a line count. GNU diff(1) will omit the
1735 line count in the chunk range if the line count is exactly 1. For example, appending
1736 a new line to the end of an existing file F that contains exactly one line of text will
1737 be represented in a diff with a chunk range line that omits the line count for F.
1739 * Scripts/VCSUtils.pm:
1740 (parseChunkRange): Added.
1741 * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
1742 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1743 - Added unit test "Git: Append new line to the end of an existing file".
1745 2011-05-28 Adam Barth <abarth@webkit.org>
1747 Reviewed by Eric Seidel.
1749 EWS builds patches that fail to build twice, which seems useless and slows down the bots
1750 https://bugs.webkit.org/show_bug.cgi?id=55585
1752 This patch switches all the early warning system bots over to the new
1753 PatchAnalysisTask-based infrastructure. This patch makes these bots
1754 more efficient (in the case where patches fail to build) and paves the
1755 way for running tests on these bots!
1757 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1758 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1759 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1760 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1761 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1762 * Scripts/webkitpy/tool/commands/queues.py:
1764 2011-05-28 Kenichi Ishibashi <bashi@chromium.org>
1766 Reviewed by Kent Tamura.
1768 Add bashi as a committer.
1770 https://bugs.webkit.org/show_bug.cgi?id=61685
1772 * Scripts/webkitpy/common/config/committers.py:
1774 2011-05-27 Adam Barth <abarth@webkit.org>
1776 Reviewed by Eric Seidel.
1778 When checking whether the tree is red, the EWS posts a link to the wrong log
1779 https://bugs.webkit.org/show_bug.cgi?id=61072
1781 We need to cache the original script error because that contains the
1782 failure log we want to upload. If we don't cache that script error,
1783 self._script_error will get overwritten when we sanity check the clean
1784 tree (and it also has test failures).
1786 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1787 - This testing approach is slightly goofy. We'd like to use
1788 assertRaisesRegexp, but that's not available until Python 2.7.
1789 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1791 2011-05-27 Jochen Eisinger <jochen@chromium.org>
1793 Reviewed by Adam Barth.
1795 Add layoutTestController.setStorageAllowed() to control whether access
1796 to the localStorage API is enabled via the WebPermissionClient
1797 https://bugs.webkit.org/show_bug.cgi?id=61581
1799 * DumpRenderTree/chromium/LayoutTestController.cpp:
1800 (LayoutTestController::LayoutTestController):
1801 (LayoutTestController::setStorageAllowed):
1802 * DumpRenderTree/chromium/LayoutTestController.h:
1803 * DumpRenderTree/chromium/TestShell.cpp:
1804 (TestShell::TestShell):
1805 (TestShell::createNewWindow):
1806 * DumpRenderTree/chromium/TestShell.h:
1807 * DumpRenderTree/chromium/WebPermissions.h: Added.
1808 (WebPermissions::WebPermissions):
1809 (WebPermissions::allowStorage):
1810 (WebPermissions::setStorageAllowed):
1811 (WebPermissions::reset):
1813 2011-05-27 Dirk Pranke <dpranke@chromium.org>
1815 Reviewed by Eric Seidel.
1817 NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
1818 https://bugs.webkit.org/show_bug.cgi?id=60326
1820 This patch removes a lot of the complexity from the
1821 metered_stream implementation that was unnecessary since there
1822 was only one caller and the logic could be coordinated better.
1824 There should be no functional changes in this patch, just code
1825 getting deleted and cleaned up.
1827 * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1828 * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
1829 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1830 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1832 2011-05-27 Dirk Pranke <dpranke@chromium.org>
1834 Reviewed by Eric Seidel.
1836 NRWT: minor cleanup in printing module
1837 https://bugs.webkit.org/show_bug.cgi?id=60329
1839 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1841 2011-05-27 Steve Lacey <sjl@chromium.org>
1843 Reviewed by David Levin.
1845 Add sjl@chromium.org as a committer.
1847 https://bugs.webkit.org/show_bug.cgi?id=61672
1849 * Scripts/webkitpy/common/config/committers.py:
1851 2011-05-27 Dirk Pranke <dpranke@chromium.org>
1853 Reviewed by Adam Barth.
1855 NRWT: remove --print detailed-progress
1856 https://bugs.webkit.org/show_bug.cgi?id=60324
1858 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1859 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1860 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1861 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1863 2011-05-27 Dirk Pranke <dpranke@chromium.org>
1865 Reviewed by Ojan Vafai.
1867 NRWT: debug messages from the workers are being logged twice
1868 https://bugs.webkit.org/show_bug.cgi?id=60428
1870 It looks like when the workers are run in separate processes
1871 we end up getting two copies of every log message they print.
1872 This has to do with the multiprocessing module on UNIX cloning
1873 the log configuration in a way I wasn't expecting, and so two
1874 log handlers end up getting registered.
1876 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1877 * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1878 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1879 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1881 2011-05-27 Adam Roben <aroben@apple.com>
1883 Always decode tester names from location.hash
1885 When navigating directly to a tester-specific URL (e.g.,
1886 <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
1887 with a URL-encoded tester name in the page, and then the encoded name could make its way
1888 into Bugzilla bugs. Bad!
1890 Reviewed by David Kilzer.
1892 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1893 (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
1894 decodeURIComponent before trying to use it.
1896 2011-05-27 Adam Roben <aroben@apple.com>
1898 Remove testing code that snuck into r87528
1900 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1901 (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
1903 2011-05-27 Adam Roben <aroben@apple.com>
1905 Add links to TestFailures to easily file bugs about failing tests
1907 Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
1908 links to file bugs for failing tests
1910 Reviewed by David Kilzer.
1912 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1913 (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
1914 for a particular build.
1915 (Builder.prototype._getFailingTests): Use resultsPageURL.
1917 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1918 (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
1920 (ViewController.prototype._domForBuildName): Use resultsPageURL.
1921 (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
1922 new bug link. The bug has a title, description, and URL already filled in for you!
1924 2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>
1926 Unreviewed, rolling out r87464.
1927 http://trac.webkit.org/changeset/87464
1928 https://bugs.webkit.org/show_bug.cgi?id=61643
1930 client-close/server-close tests are flaky on Chromium Mac and
1931 Windows (Requested by aklein on #webkit).
1933 * Scripts/webkitpy/thirdparty/__init__.py:
1935 2011-05-27 Alexey Proskuryakov <ap@apple.com>
1937 Added Douglas Davidson to contributors list for easier CC'ing.
1939 * Scripts/webkitpy/common/config/committers.py:
1941 2011-05-26 Mihai Parparita <mihaip@chromium.org>
1943 Reviewed by Adam Barth.
1945 Fix worldID and destinationDomain argument names
1946 https://bugs.webkit.org/show_bug.cgi?id=61571
1948 As part of working on r87423, I noticed a couple of inconsistencies in
1950 - We would use worldId in .h files but worldID in .cpp files.
1951 Standardize on the latter
1952 - SecurityOrigin::addOriginAccessWhitelistEntry would take a
1953 destinationDomains argument, even though the actual parameter was for
1954 a single domain (renamed to be singular).
1956 * DumpRenderTree/LayoutTestController.h:
1957 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1958 (LayoutTestController::evaluateScriptInIsolatedWorld):
1960 2011-05-26 Yuta Kitamura <yutak@chromium.org>
1962 Reviewed by Kent Tamura.
1964 WebSocket closing handshake
1965 https://bugs.webkit.org/show_bug.cgi?id=35721
1967 * Scripts/webkitpy/thirdparty/__init__.py:
1968 Pull in pywebsocket 0.6b1. We need to update pywebsocket
1969 to get the right behavior of closing handshake.
1971 2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>
1973 Reviewed by Andreas Kling.
1975 WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
1976 https://bugs.webkit.org/show_bug.cgi?id=42676
1978 Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
1980 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1981 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1982 (WTR::InjectedBundle::beginTesting):
1983 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1984 (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
1985 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1987 2011-05-26 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
1989 Reviewed by Andreas Kling.
1991 [Qt] QtTestBrowser "Switch User Agent" dialog is broken
1992 https://bugs.webkit.org/show_bug.cgi?id=61527
1994 The setMaximumHeight() call is unecessary and breaks the dialog at
1997 * QtTestBrowser/launcherwindow.cpp:
1998 (LauncherWindow::showUserAgentDialog):
2000 2011-05-02 Robert Hogan <robert@webkit.org>
2002 Reviewed by Adam Roben.
2004 [Qt] Allow popup windows from plugins when initiated by a user gesture
2006 https://bugs.webkit.org/show_bug.cgi?id=41292
2008 Support parameters introduced in plugin-initiate-popup-window.html
2010 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2011 (webkit_test_plugin_new_instance):
2012 (webkit_test_plugin_handle_event):
2014 2011-05-26 Mihai Parparita <mihaip@chromium.org>
2016 Reviewed by Adam Barth.
2018 Support cross-origin XMLHttpRequest in isolated worlds
2019 https://bugs.webkit.org/show_bug.cgi?id=59843
2021 Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
2023 * DumpRenderTree/chromium/LayoutTestController.cpp:
2024 (LayoutTestController::LayoutTestController):
2025 (LayoutTestController::setIsolatedWorldSecurityOrigin):
2026 * DumpRenderTree/chromium/LayoutTestController.h:
2028 2011-05-25 Brian Weinstein <bweinstein@apple.com>
2030 Reviewed by Adam Roben.
2032 WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
2033 https://bugs.webkit.org/show_bug.cgi?id=61474
2034 <rdar://problem/9468337>
2036 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2037 (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
2039 2011-05-26 Andreas Kling <kling@webkit.org>
2041 Unreviewed, correct address to webkit-committers mailing list.
2043 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2045 2011-05-25 Adam Roben <aroben@apple.com>
2047 Don't assume that builds finish in the order they were started
2049 Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
2050 build when one slave is taking a long time to finish a build
2052 Reviewed by Antti Koivisto.
2054 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2055 (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
2056 newer than the oldest in-progress build are also themselves in progress. Just check whether
2057 each build is actually in progress (as signified by its presence in the currentBuilds set).
2059 2011-05-25 Adam Roben <aroben@apple.com>
2061 Correctly detect cases where only a single test failed/crashed/timed out
2063 Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
2066 Reviewed by Darin Adler.
2068 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2069 (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
2070 will be singular when only a single test fails/crashes/times out.
2072 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2073 (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
2074 failed/crashed/timed out.
2076 2011-05-26 Tom Hudson <tomhudson@google.com>
2078 Reviewed by Tony Chang.
2080 Add flags to Chromium ImageDiff to write image comparison metrics on
2082 https://bugs.webkit.org/show_bug.cgi?id=60569
2084 * DumpRenderTree/chromium/ImageDiff.cpp:
2085 (Image::createFromStdin): Fix spelling.
2086 (maxOf3): New function to do 3-way maximum.
2087 (getRedComponent): Extract red component from ABGR packed encoding.
2088 (getGreenComponent): Extract green component from ABGR packed encoding.
2089 (getBlueComponent): Extract blue component from ABGR packed encoding.
2090 (weightedPercentageDifferent): Determine % of pixels different in two
2091 images multiplied by intensity difference of each pixel.
2092 (printHelp): Document new arguments.
2093 (compareImages): Parameterize.
2094 (untestedCompareImages): Parameterize.
2095 (diffImages): Parameterize; write results on stdout if requested.
2096 (main): Parse new arguments.
2098 2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
2100 Reviewed by Simon Hausmann.
2102 WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
2103 https://bugs.webkit.org/show_bug.cgi?id=42697
2105 Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
2107 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2108 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2109 (WTR::InjectedBundle::beginTesting):
2110 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2111 (WTR::LayoutTestController::setPrivateBrowsingEnabled):
2112 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2114 2011-05-25 Jon Honeycutt <jhoneycutt@apple.com>
2116 REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
2117 https://bugs.webkit.org/show_bug.cgi?id=61428
2118 <rdar://problem/9457006>
2120 Reviewed by Adam Roben.
2122 The crash occurs when Flash posts a message to a window that it
2123 creates, and in processing the message, it calls NPN_Evaluate to
2124 evaluate JavaScript that removes the plug-in from the page. Flash then
2125 crashes when we return to Flash code.
2127 This test emulates that behavior.
2129 * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
2130 (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
2131 Initialize member vars.
2132 (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
2133 Remove our custom property from the message window, and destroy it.
2134 (CallJSThatDestroysPlugin::NPP_Destroy):
2135 Set m_isDestroyed, log that the plug-in was destroyed, and notify the
2136 layout test controller that we're done.
2138 Get the PluginTest object, and call its runTest() function.
2139 (CallJSThatDestroysPlugin::NPP_New):
2140 Setup the test: register a class for the message-only window, create
2141 it, and post a message to it to run the test.
2142 (CallJSThatDestroysPlugin::runTest):
2143 Execute JS that removes the plug-in from the page, and if we're not
2144 destroyed, log a success message.
2146 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2147 Add new test to project.
2149 2011-05-25 Tony Chang <tony@chromium.org>
2151 Reviewed by Adam Barth.
2153 webkitpy's NetworkTransaction shouldn't use mechanize
2154 https://bugs.webkit.org/show_bug.cgi?id=61450
2156 mechanize.HTTPError is just an alias for urllib2.HTTPError, so
2157 use urllib2 directly. Re-add NetworkTransaction to
2158 test_results_uploader.py (reverting r87124).
2160 * Scripts/webkitpy/common/net/networktransaction.py:
2161 * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2163 2011-05-25 Kevin Ollivier <kevino@theolliviers.com>
2165 [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
2166 until the port begins using those export macros.
2168 * DumpRenderTree/chromium/config.h:
2170 2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
2172 Unreviewed, rolling out r87257.
2173 http://trac.webkit.org/changeset/87257
2174 https://bugs.webkit.org/show_bug.cgi?id=61457
2176 This broke layout tests, see bug 61431. (Requested by
2177 hwennborg on #webkit).
2179 * DumpRenderTree/chromium/LayoutTestController.cpp:
2180 (LayoutTestController::LayoutTestController):
2181 (LayoutTestController::clearAllDatabases):
2182 * DumpRenderTree/chromium/LayoutTestController.h:
2184 2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
2186 Reviewed by Andreas Kling.
2188 [Qt] fast/css/disabled-author-styles.html failed
2189 https://bugs.webkit.org/show_bug.cgi?id=61438
2191 Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
2193 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2194 (WebCore::WebPage::resetSettings):
2195 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2196 (LayoutTestController::setAuthorAndUserStylesEnabled):
2197 * DumpRenderTree/qt/LayoutTestControllerQt.h:
2199 2011-05-25 Adam Roben <aroben@apple.com>
2201 Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
2203 Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
2204 started exiting early due to too many crashes, timeouts, or failures
2206 Reviewed by David Kilzer.
2208 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2209 (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
2210 run-webkit-tests exits early due to too many failures, pass that information in another
2211 argument to the callback.
2212 (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
2213 the new structure of the object passed to the callback.
2214 (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
2215 getNumberOfFailingTests and to pass that along to our own callbacks.
2216 (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
2217 from _getFailingTests and to store that value in the history object.
2219 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2222 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2223 (ViewController.prototype._displayBuilder): Updated for change in structure to the history
2224 object and to add a note when run-webkit-tests exited early due to too many failures.
2225 (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
2226 latestBuildInfos since each entry now contains more than just the tester and failure count.
2227 Now displays a message for testers where the latest build exited early due to too many
2228 failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
2229 store that value in latestBuildInfos.
2231 2011-05-24 Keishi Hattori <keishi@webkit.org>
2233 Reviewed by Kent Tamura.
2235 Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
2236 https://bugs.webkit.org/show_bug.cgi?id=61273
2238 * Scripts/build-webkit: Added INPUT_COLOR feature flag.
2240 2011-05-24 Greg Simon <gregsimon@chromium.org>
2242 Reviewed by Dimitri Glazkov.
2244 Control Indexeddb backends from LayoutTestController
2245 https://bugs.webkit.org/show_bug.cgi?id=61000
2247 * DumpRenderTree/chromium/LayoutTestController.cpp:
2248 (LayoutTestController::LayoutTestController):
2249 (LayoutTestController::setOverrideIndexedDBBackingStore):
2250 (LayoutTestController::clearAllDatabases):
2251 * DumpRenderTree/chromium/LayoutTestController.h:
2253 2011-05-24 Robert Hogan <robert@webkit.org>
2255 Reviewed by Ryosuke Niwa.
2257 [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
2258 https://bugs.webkit.org/show_bug.cgi?id=61393
2260 * DumpRenderTree/qt/EventSenderQt.h:
2261 * DumpRenderTree/qt/EventSenderQt.cpp:
2262 (getModifiers): static function for interpreting modifiers
2263 (EventSender::mouseDown): Respect keyboard modifiers
2264 (EventSender::keyDown): use new static function
2265 (EventSender::sendOrQueueEvent): whitespace fix
2267 2011-05-24 Jay Civelli <jcivelli@chromium.org>
2269 Reviewed by Adam Barth.
2271 Adding MHTML reading support.
2272 https://bugs.webkit.org/show_bug.cgi?id=7168
2274 * Scripts/build-webkit:
2275 * Scripts/old-run-webkit-tests:
2276 * Scripts/webkitperl/features.pm:
2277 * Scripts/webkitpy/layout_tests/port/test_files.py:
2278 * Scripts/webkitpy/layout_tests/port/webkit.py:
2280 2011-05-24 Stephen White <senorblanco@chromium.org>
2282 Reviewed by Kenneth Russell.
2284 Remove most style checks on Source/ThirdParty/glu, since it doesn't
2285 follow WebKit style.
2286 https://bugs.webkit.org/show_bug.cgi?id=61365
2288 * Scripts/webkitpy/style/checker.py:
2290 2011-05-24 Adam Roben <aroben@apple.com>
2292 Don't allow forcing builds through the build.webkit.org web interface
2294 Someone has been forcing bogus builds.
2296 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2298 2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>
2300 Reviewed by Adam Roben.
2302 WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2303 https://bugs.webkit.org/show_bug.cgi?id=42669
2305 Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the
2306 layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
2307 Because that case changed the setting.
2309 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2310 (WTR::InjectedBundle::beginTesting):
2312 2011-05-24 Csaba Osztrogonác <ossy@webkit.org>
2314 Reviewed by Kenneth Rohde Christiansen.
2316 [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
2317 https://bugs.webkit.org/show_bug.cgi?id=61052
2319 * Scripts/old-run-webkit-tests:
2321 2011-05-24 Adam Roben <aroben@apple.com>
2323 Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
2325 Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
2326 that don't have any failing tests, which isn't useful
2328 Reviewed by David Kilzer.
2330 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
2331 (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
2332 instead of name strings.
2333 (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
2334 builder names into an array of builders.
2336 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2337 (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
2338 the most recently completed build, or -1 if there is no such build.
2339 (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
2340 in the given build, or -1 if the number could not be determined. Some of this code came from
2342 (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
2343 (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
2344 getNumberOfFailingTests functions.
2346 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2347 (ViewController.prototype._displayTesters): Get the current number of test failures for each
2348 tester and show it in the list. Omit testers that have no failures at all. We keep the
2349 testers and failure counts in an array and sort it before displaying the current data, as
2350 the order in which data will be fetched is unpredictable.
2352 2011-05-23 Tony Chang <tony@chromium.org>
2354 Reviewed by Ojan Vafai.
2356 [nrwt] don't use NetworkTranslation when uploading results
2357 https://bugs.webkit.org/show_bug.cgi?id=61315
2359 This avoids autoinstalling mechanize. It didn't matter anyway
2360 because test_results_uploader.py wasn't using mechanize to make the
2361 request so NetworkTransaction::run wasn't doing anything extra
2362 (it only matters if it catches mechanize.HTTPError).
2364 * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2366 2011-05-23 Tony Chang <tony@chromium.org>
2368 Reviewed by Dirk Pranke.
2370 [chromium] fix the rebaseline tool to work with Linux GPU failures
2371 https://bugs.webkit.org/show_bug.cgi?id=61312
2373 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2375 2011-05-23 Darin Adler <darin@apple.com>
2377 Ignore generated .pyc files in a directory full of python code.
2379 * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
2381 2011-05-23 Adam Barth <abarth@webkit.org>
2383 Reviewed by Eric Seidel.
2385 sheriffbot should give more details about the failures in IRC
2386 https://bugs.webkit.org/show_bug.cgi?id=61233
2388 With this patch, sheriffbot will annonce the set of failing tests,
2389 which might help folks triage the problem.
2391 * Scripts/webkitpy/tool/commands/sheriffbot.py:
2392 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2394 2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
2396 Unreviewed, rolling out r87078.
2397 http://trac.webkit.org/changeset/87078
2398 https://bugs.webkit.org/show_bug.cgi?id=61294
2400 Patch contains errors and seems likely to break a bunch of
2401 bots (Requested by abarth on #webkit).
2403 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2404 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2405 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2407 2011-05-23 Alice Boxhall <aboxhall@chromium.org>
2409 Reviewed by Ojan Vafai.
2411 Convert json_results_generator.py to output version 4 JSON.
2412 https://bugs.webkit.org/show_bug.cgi?id=60869
2414 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2415 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2416 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2418 2011-05-23 Patrick Gansterer <paroga@webkit.org>
2420 Reviewed by Adam Barth.
2422 Move generation of shell_command from port to executive
2423 https://bugs.webkit.org/show_bug.cgi?id=61251
2425 After move it's possible to use the code in other places too.
2427 * Scripts/webkitpy/common/config/ports.py:
2428 * Scripts/webkitpy/common/system/executive.py:
2430 2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>
2432 Reviewed by Darin Adler.
2434 WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2435 https://bugs.webkit.org/show_bug.cgi?id=42669
2437 Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
2439 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2440 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2441 (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
2442 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2444 2011-05-22 Robert Hogan <robert@webkit.org>
2446 Reviewed by Kenneth Rohde Christiansen.
2448 Fix policyDelegate in Qt DRT
2449 https://bugs.webkit.org/show_bug.cgi?id=61247
2451 Use the 'policy delegate' implemented in FrameLoaderClient
2452 for layout tests. The partial implementation in DumpRenderTreeQt
2453 is redundant, so remove it.
2455 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2456 (WebCore::WebPage::acceptNavigationRequest):
2457 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2458 (LayoutTestController::waitForPolicyDelegate):
2460 2011-05-22 Patrick Gansterer <paroga@webkit.org>
2462 Reviewed by Darin Adler.
2464 Use double quotes for filename arguments
2465 https://bugs.webkit.org/show_bug.cgi?id=61250
2467 Windows does not support single quotes on the command line,
2468 so replace them with double quotes.
2470 * Scripts/prepare-ChangeLog:
2472 2011-05-20 Simon Fraser <simon.fraser@apple.com>
2474 Reviewed by Sam Weinig.
2476 WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
2477 https://bugs.webkit.org/show_bug.cgi?id=42550
2479 Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
2481 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2482 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2483 Copy the code for pausing animations, FIXME comments and all.
2484 (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2485 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2487 2011-05-20 Alok Priyadarshi <alokp@chromium.org>
2489 Reviewed by Stephen White.
2491 Adding myself to the committers list.
2493 * Scripts/webkitpy/common/config/committers.py:
2495 2011-05-19 Adam Roben <aroben@apple.com>
2497 Test that the WebKit2 UI process doesn't crash when starting a download
2499 Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
2500 (preceded by assertion) in fastMalloc when downloading a file
2502 Reviewed by Darin Adler.
2504 * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
2506 * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
2507 (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
2508 (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
2509 started, cancel the download, and return a bogus string.
2511 (TestWebKitAPI::setContextDownloadClient):
2512 (TestWebKitAPI::setPagePolicyClient):
2513 Simple helper functions.
2515 (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
2516 our policy client, and run until we know that the download was started. If we haven't
2519 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2520 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2521 * TestWebKitAPI/win/copy-resources.cmd:
2524 2011-05-20 Kent Tamura <tkent@chromium.org>
2526 Reviewed by Ryosuke Niwa.
2528 Fix style errors in DumpRenderTree/chromium/.
2529 https://bugs.webkit.org/show_bug.cgi?id=61172
2531 * DumpRenderTree/chromium/CppBoundClass.cpp:
2532 (CppBoundClass::getAsCppVariant):
2533 (CppBoundClass::bindToJavascript):
2534 * DumpRenderTree/chromium/CppBoundClass.h:
2535 (CppBoundClass::GetterCallback::~GetterCallback):
2536 (CppBoundClass::CppBoundClass):
2537 (CppBoundClass::Callback::~Callback):
2538 (CppBoundClass::MemberCallback::MemberCallback):
2539 (CppBoundClass::MemberCallback::~MemberCallback):
2540 (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
2541 (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
2542 * DumpRenderTree/chromium/CppVariant.h:
2543 * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2544 (DRTDevToolsAgent::~DRTDevToolsAgent):
2545 * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2546 (DRTDevToolsClient::sendFrontendLoaded):
2547 * DumpRenderTree/chromium/DRTDevToolsClient.h:
2548 * DumpRenderTree/chromium/DumpRenderTree.cpp:
2550 * DumpRenderTree/chromium/EventSender.cpp:
2551 (SavedEvent::SavedEvent):
2552 (EventSender::EventSender):
2553 (EventSender::keyDown):
2554 * DumpRenderTree/chromium/EventSender.h:
2555 * DumpRenderTree/chromium/ImageDiff.cpp:
2557 * DumpRenderTree/chromium/LayoutTestController.cpp:
2558 (LayoutTestController::LayoutTestController):
2559 (LayoutTestController::WorkQueue::reset):
2560 (WorkItemBackForward::WorkItemBackForward):
2561 (WorkItemLoadingScript::WorkItemLoadingScript):
2562 (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
2563 (WorkItemLoad::WorkItemLoad):
2564 (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2565 (LayoutTestController::pathToLocalResource):
2566 * DumpRenderTree/chromium/LayoutTestController.h:
2567 (LayoutTestController::WorkItem::~WorkItem):
2568 (LayoutTestController::WorkQueue::WorkQueue):
2569 * DumpRenderTree/chromium/MockSpellCheck.cpp:
2570 (MockSpellCheck::MockSpellCheck):
2571 (MockSpellCheck::~MockSpellCheck):
2572 * DumpRenderTree/chromium/MockSpellCheck.h:
2573 * DumpRenderTree/chromium/NotificationPresenter.h:
2574 (NotificationPresenter::NotificationPresenter):
2575 * DumpRenderTree/chromium/Task.cpp:
2577 * DumpRenderTree/chromium/Task.h:
2578 (TaskList::TaskList):
2579 * DumpRenderTree/chromium/TestEventPrinter.cpp:
2580 (DRTPrinter::DRTPrinter):
2581 (TestShellPrinter::TestShellPrinter):
2582 * DumpRenderTree/chromium/TestNavigationController.cpp:
2583 (TestNavigationEntry::TestNavigationEntry):
2584 (TestNavigationEntry::~TestNavigationEntry):
2585 (TestNavigationController::TestNavigationController):
2586 (TestNavigationController::reload):
2587 (TestNavigationController::loadEntry):
2588 (TestNavigationController::didNavigateToEntry):
2589 * DumpRenderTree/chromium/TestNavigationController.h:
2590 (TestShellExtraData::TestShellExtraData):
2591 * DumpRenderTree/chromium/TestShell.cpp:
2593 * DumpRenderTree/chromium/TestShell.h:
2594 (TestParams::TestParams):
2595 * DumpRenderTree/chromium/TestShellWin.cpp:
2596 (TestShell::waitTestFinished):
2597 * DumpRenderTree/chromium/TestWebWorker.h:
2598 (TestWebWorker::startWorkerContext):
2599 (TestWebWorker::terminateWorkerContext):
2600 (TestWebWorker::postMessageToWorkerContext):
2601 (TestWebWorker::clientDestroyed):
2602 (TestWebWorker::postMessageToWorkerObject):
2603 (TestWebWorker::postExceptionToWorkerObject):
2604 (TestWebWorker::postConsoleMessageToWorkerObject):
2605 (TestWebWorker::confirmMessageFromWorkerObject):
2606 (TestWebWorker::reportPendingActivity):
2607 (TestWebWorker::workerContextClosed):
2608 (TestWebWorker::~TestWebWorker):
2609 * DumpRenderTree/chromium/TextInputController.cpp:
2610 * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2611 * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2612 * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2613 (WebThemeEngineDRTWin::paintButton):
2614 (WebThemeEngineDRTWin::paintMenuList):
2615 (WebThemeEngineDRTWin::paintTrackbar):
2616 * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2617 (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2618 * DumpRenderTree/chromium/WebViewHost.cpp:
2619 (WebViewHost::navigate):
2620 (WebViewHost::updateSessionHistory):
2621 (WebViewHost::paintInvalidatedRegion):
2622 * DumpRenderTree/chromium/WebViewHost.h:
2624 2011-05-19 Dmitry Lomov <dslomov@google.com>
2626 Reviewed by Adam Roben.
2628 Detect hangs in run-api-tests
2629 https://bugs.webkit.org/show_bug.cgi?id=48043
2631 * Scripts/run-api-tests: Added test timeouts
2633 2011-05-19 Dmitry Lomov <dslomov@google.com>
2635 Reviewed by Adam Roben.
2637 run-api-tests should run one test per process
2638 https://bugs.webkit.org/show_bug.cgi?id=61088
2640 * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows,
2641 return code, and parsing GTest output format.
2643 2011-05-15 Robert Hogan <robert@webkit.org>
2645 Reviewed by Antonio Gomes.
2647 [Qt][GTK] plugins/get-url-with-javascript-url.html fails
2648 https://bugs.webkit.org/show_bug.cgi?id=60834
2649 Fix unix test plugin for plugins/get-url-with-javascript-url.html
2651 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2652 (webkit_test_plugin_new_stream):
2653 (webkit_test_plugin_write_ready):
2654 (webkit_test_plugin_write):
2656 2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
2658 Unreviewed, rolling out r86869, r86873, r86875, and r86877.
2659 http://trac.webkit.org/changeset/86869
2660 http://trac.webkit.org/changeset/86873
2661 http://trac.webkit.org/changeset/86875
2662 http://trac.webkit.org/changeset/86877
2663 https://bugs.webkit.org/show_bug.cgi?id=61139
2665 broke builds and debug DRT (Requested by rniwa on #webkit).
2667 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2668 * DumpRenderTree/chromium/TestShell.cpp:
2669 (TestShell::bindJSObjectsToWindow):
2670 * DumpRenderTree/mac/FrameLoadDelegate.mm:
2671 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2673 2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>
2675 Reviewed by Darin Adler.
2677 Add build logistics and plumbing for window.internals object.
2678 https://bugs.webkit.org/show_bug.cgi?id=60313
2680 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2681 * DumpRenderTree/chromium/TestShell.cpp:
2682 (TestShell::bindJSObjectsToWindow): Added injection code.
2683 * DumpRenderTree/mac/FrameLoadDelegate.mm:
2684 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2686 2011-05-19 Zsolt Fehér <h490267@stud.u-szeged.hu>
2688 Reviewed by Csaba Osztrogonác.
2690 [Qt] Implement eventSender.scalePageBy
2691 https://bugs.webkit.org/show_bug.cgi?id=60015
2693 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2694 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2695 * DumpRenderTree/qt/EventSenderQt.cpp:
2696 (EventSender::scalePageBy):
2697 * DumpRenderTree/qt/EventSenderQt.h:
2699 2011-05-19 Kenichi Ishibashi <bashi@chromium.org>
2701 Reviewed by Kent Tamura.
2703 [Chromium] IME candidate window appears wrong position in an iframe
2704 https://bugs.webkit.org/show_bug.cgi?id=61023
2706 Call the focused frame's firstRectForCharacterRange() instead of the
2707 main frame so that DRT behaves as the same as Chromium.
2709 * DumpRenderTree/chromium/TextInputController.cpp:
2710 (TextInputController::firstRectForCharacterRange):
2712 2011-05-18 Adam Roben <aroben@apple.com>
2714 Add a new page to build.webkit.org to help find when tests started failing
2716 The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
2717 right now, but already shows some useful information. It's somewhat similar to webkit-patch
2718 failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
2719 little more convenient than either of them, though, because it's all done in the browser
2720 (and thus it's easy to go directly to the relevant test results).
2722 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
2723 (Buildbot): This class represents a Buildbot server.
2724 (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
2725 (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
2726 (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
2728 (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
2729 be implemented by a derived class that understands this server's build naming scheme.
2730 (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2733 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
2734 (Builder): This class represents one builder on the buildbot.
2735 (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
2736 (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
2737 information about a particular test failure.
2738 (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
2739 information about when tests started failing.
2740 (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2742 (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
2744 (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
2745 extracts all the failing tests listed in it, passing them to the callback.
2746 (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
2747 build, merges them into the build history, and calls the callback telling it whether the
2748 next build should be fetched to provide more information.
2750 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2751 Added. Just some simple styles.
2753 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
2754 (createDefinitionList): Takes an array of pairs and turns them into a DL element.
2755 (getResource): Wrapper around XMLHttpRequest.
2756 (Array.prototype.findFirst): Finds the first element matching the given predicate and
2758 (Array.prototype.last): Returns the last element of the array.
2760 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
2761 (ViewController): This class contains the main logic for displaying the page.
2762 (ViewController.loaded): Just calls through to parseHash.
2763 (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
2764 shows the list of all testers so one can be chosen. This function is called when the page
2765 loads and whenever we get a hashchange event.
2766 (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
2767 as it is fetched. The display ends up grouping tests by when they started failing.
2768 (ViewController._displayTesters): Gets the list of testers and displays it.
2770 (ViewController._domForBuildName):
2771 (ViewController._domForFailedTest):
2772 Helper functions to create descriptions and links for a particular build or failed test.
2774 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
2775 (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
2776 (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
2778 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
2779 loads all the files and sets up a ViewController, which does the rest.
2781 * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
2784 2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
2786 Reviewed by Csaba Osztrogonác.
2788 [Qt] Implement layoutTestController.setValueForUser()
2789 https://bugs.webkit.org/show_bug.cgi?id=60956
2791 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2792 (LayoutTestController::setValueForUser):
2793 * DumpRenderTree/qt/LayoutTestControllerQt.h:
2795 2011-05-16 Robert Hogan <robert@webkit.org>
2797 Reviewed by Kenneth Rohde Christiansen.
2799 plugins/invalidate_rect.html fails on linux ports
2801 - Make the unix test netscape plugin recognize the onPaintEvent
2802 and windowedPlugin parameters.
2804 https://bugs.webkit.org/show_bug.cgi?id=54051
2806 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2808 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2809 (LayoutTestController::displayInvalidatedRegion):
2810 * DumpRenderTree/qt/LayoutTestControllerQt.h:
2811 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2812 (webkit_test_plugin_new_instance):
2813 (webkit_test_plugin_handle_event):
2815 2011-05-17 Tony Chang <tony@chromium.org>
2817 Reviewed by Ojan Vafai.
2819 [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
2820 https://bugs.webkit.org/show_bug.cgi?id=60895
2822 Update the tools to handle the move. Lucid 32 results now go in
2823 chromium-linux-x86 and the default platform on Linux is now x86_64.
2825 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
2826 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2827 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
2828 * Scripts/webkitpy/layout_tests/port/base.py: ditto
2829 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
2830 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2831 * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
2832 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
2833 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
2835 2011-05-17 Adam Roben <aroben@apple.com>
2837 Make run-api-tests work on Windows when there are spaces in the path
2839 Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
2840 spaces in the path to TestWebKitAPI.exe
2842 Reviewed by David Levin.
2844 * Scripts/run-api-tests:
2845 (runTestTool): Use the "direct object" form of system() to avoid having the path to
2846 TestWebKitAPI.exe be split by the shell.
2848 2011-05-16 Ian Henderson <ianh@apple.com>
2850 Reviewed by Joseph Pecoraro.
2852 Page::goToItem doesn't work while loading is deferred
2853 https://bugs.webkit.org/show_bug.cgi?id=60412
2855 Add setDefersLoading and goBack methods to LayoutTestController. We
2856 need to use goBack() instead of history.back() because the latter goes
2857 through NavigationScheduler, hence doesn't exhibit the bug.
2859 * DumpRenderTree/LayoutTestController.cpp:
2861 (setDefersLoadingCallback):
2862 (LayoutTestController::staticFunctions):
2863 * DumpRenderTree/LayoutTestController.h:
2864 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2865 (LayoutTestController::goBack):
2866 (LayoutTestController::setDefersLoading):
2867 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2868 (LayoutTestController::goBack):
2869 (LayoutTestController::setDefersLoading):
2870 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2871 (LayoutTestController::goBack):
2872 (LayoutTestController::setDefersLoading):
2873 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2874 (LayoutTestController::goBack):
2875 (LayoutTestController::setDefersLoading):
2877 2011-05-16 Sam Weinig <sam@webkit.org>
2879 Reviewed by Anders Carlsson.
2881 TestWebKitAPI should build with clang if it can
2882 https://bugs.webkit.org/show_bug.cgi?id=60918
2884 * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2885 Update CompilerVersion.xcconfig to match others.
2887 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2888 Add CompilerVersion.xcconfig to the project.
2890 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2891 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2892 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2893 (TestWebKitAPI::didSameDocumentNavigationForFrame):
2894 Add some casts to quiet warnings from clang.
2896 2011-05-16 Dirk Pranke <dpranke@chromium.org>
2898 Reviewed by David Levin.
2900 add dpranke as a reviewer
2901 https://bugs.webkit.org/show_bug.cgi?id=60919
2903 * Scripts/webkitpy/common/config/committers.py:
2905 2011-05-16 Robert Hogan <robert@webkit.org>
2907 Reviewed by Anders Carlsson.
2909 [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
2911 https://bugs.webkit.org/show_bug.cgi?id=60838
2913 The unix test plugin needs to call the test's NPP_URLNotify
2914 rather than the browsers.
2916 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2917 (webkit_test_plugin_url_notify):
2919 2011-05-16 Brent Fulgham <bfulgham@webkit.org>
2921 Rubber-stamped by Adam Roben.
2923 Adding myself as a reviewer.
2924 * Scripts/webkitpy/common/config/committers.py:
2926 2011-05-16 Sam Weinig <sam@webkit.org>
2928 Fix typo pointed out by Dave Levin.
2930 * TestWebKitAPI/PlatformUtilities.h:
2931 (TestWebKitAPI::Util::assertWKStringEqual):
2934 2011-05-16 Sam Weinig <sam@webkit.org>
2936 Reviewed by David Levin.
2938 Convert api tester over to using gtest expectations directly
2939 https://bugs.webkit.org/show_bug.cgi?id=60862
2941 * TestWebKitAPI/PlatformUtilities.cpp:
2942 (TestWebKitAPI::Util::toSTD):
2943 * TestWebKitAPI/PlatformUtilities.h:
2944 (TestWebKitAPI::Util::assertWKStrigEqual):
2945 Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
2946 the implementation of the macro simpler.
2948 * TestWebKitAPI/Test.h:
2949 Remove TEST_ASSERT forwarder.
2951 [Test changes elided]
2953 2011-05-16 David Kilzer <ddkilzer@apple.com>
2955 <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
2956 <rdar://problem/9446430>
2958 Reviewed by Mark Rowe.
2960 * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
2961 * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2962 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2964 2011-05-16 Jon Lee <jonlee@apple.com>
2966 Reviewed by Simon Fraser.
2968 Can't horizontally scroll iframes and overflow because wheel events are always accepted
2969 https://bugs.webkit.org/show_bug.cgi?id=60779
2971 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2972 (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
2974 2011-05-16 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
2976 Reviewed by Csaba Osztrogonác.
2978 [Qt] Tools.pro misses include(common.pri)
2979 https://bugs.webkit.org/show_bug.cgi?id=60883
2981 It includes features.pri, which depends on common.pri (the build is
2982 not broken today with the default options, but this is the right
2987 2011-05-15 Dominic Cooney <dominicc@chromium.org>
2989 Unreviewed: adding myself to committers.py.
2991 * Scripts/webkitpy/common/config/committers.py:
2993 2011-05-15 Daniel Bates <dbates@webkit.org>
2995 Reviewed by Chris Jerdonek.
2997 svn-apply can't handle Git diff that only changes executable bit
2998 https://bugs.webkit.org/show_bug.cgi?id=60848
3000 Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
3001 that only has an executable bit change.
3003 * Scripts/VCSUtils.pm:
3004 - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
3005 (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
3006 fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
3007 * Scripts/svn-apply:
3008 (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
3009 * Scripts/svn-unapply:
3011 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3012 - Updated expected results for test cases to account for numTextChunks.
3013 - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
3014 - Added test case "Git: file that only has an executable bit change".
3015 * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3016 - Updated expected results for test cases to account for numTextChunks.
3018 2011-05-15 Sam Weinig <sam@webkit.org>
3022 * TestWebKitAPI/win/main.cpp:
3025 2011-05-15 Sam Weinig <sam@webkit.org>
3027 Reviewed by David Levin.
3029 Make API tester more gtest friendly
3030 https://bugs.webkit.org/show_bug.cgi?id=60859
3032 * Scripts/run-api-tests:
3034 - Remove logic to run tests one at a time.
3035 - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to
3036 the test runner and allow gtest to print it for us.
3037 - Forward stdout from the test tool to stdout, even in non-verbose runs.
3038 - Run test tool from the current working directory instead of the root webkit
3041 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3042 Move plist to be with other bundle sources.
3044 * TestWebKitAPI/TestsController.cpp:
3045 (TestWebKitAPI::TestsController::TestsController):
3046 (TestWebKitAPI::TestsController::run):
3047 * TestWebKitAPI/TestsController.h:
3048 * TestWebKitAPI/mac/main.mm:
3049 Simplify TestController down to a single run function. We should consider removing the class
3050 entirely at some point.
3052 2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>
3054 Unreviewed, rolling out r86504.
3055 http://trac.webkit.org/changeset/86504
3056 https://bugs.webkit.org/show_bug.cgi?id=60853
3058 "Broke Qt EventSender in editing/selection tests" (Requested
3059 by mwenge on #webkit).
3061 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3062 (WebCore::WebPage::WebPage):
3063 (WebCore::DumpRenderTree::DumpRenderTree):
3064 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3065 (WebCore::DumpRenderTree::initJSObjects):
3066 * DumpRenderTree/qt/DumpRenderTreeQt.h:
3067 (WebCore::DumpRenderTree::eventSender):
3068 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3069 (webkit_test_plugin_new_instance):
3070 (webkit_test_plugin_set_window):
3071 (webkit_test_plugin_handle_event):
3073 2011-05-12 Robert Hogan <robert@webkit.org>
3075 Reviewed by Benjamin Poulain.
3077 [Qt] fix http/tests/plugins/plugin-document-has-focus.html
3079 The support for this test added to the unix test plugin here
3080 may allow other platforms to pass it (nearly everyone
3081 skips it). On Qt it required a bit of trickiness with
3082 the page's EventSender object to get it working fully though,
3083 so only unskipping Qt here.
3085 https://bugs.webkit.org/show_bug.cgi?id=60722
3087 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3088 (WebCore::WebPage::WebPage):
3089 (WebCore::WebPage::eventSender):
3090 (WebCore::DumpRenderTree::DumpRenderTree):
3091 (WebCore::DumpRenderTree::initJSObjects):
3092 (WebCore::DumpRenderTree::createWindow):
3093 * DumpRenderTree/qt/DumpRenderTreeQt.h:
3094 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3095 (webkit_test_plugin_new_instance):
3096 (webkit_test_plugin_set_window):
3097 (webkit_test_plugin_handle_event):
3099 2011-05-14 Arno Renevier <arno@renevier.net>
3101 Reviewed by Martin Robinson.
3103 make run-gtk-tests executable
3104 https://bugs.webkit.org/show_bug.cgi?id=59278
3106 * Scripts/run-gtk-tests:
3108 2011-05-14 Anders Carlsson <andersca@apple.com>
3110 Reviewed by Kevin Decker.
3112 NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
3113 https://bugs.webkit.org/show_bug.cgi?id=60823
3114 <rdar://problem/9430386>
3116 Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
3118 * DumpRenderTree/DumpRenderTree.gypi:
3119 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3120 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
3121 (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
3122 (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
3123 (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
3124 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3125 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3128 2011-05-14 Sheriff Bot <webkit.review.bot@gmail.com>
3130 Unreviewed, rolling out r86476.
3131 http://trac.webkit.org/changeset/86476
3132 https://bugs.webkit.org/show_bug.cgi?id=60832
3134 It made plugins/get-url-notify-with-url-that-fails-to-
3135 load.html crash on GTK (Requested by Ossy on #webkit).
3137 * DumpRenderTree/DumpRenderTree.gypi:
3138 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3139 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
3140 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3141 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3144 2011-05-13 Anders Carlsson <andersca@apple.com>
3146 Reviewed by Sam Weinig.
3148 NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
3149 https://bugs.webkit.org/show_bug.cgi?id=60823
3150 <rdar://problem/9430386>
3152 Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
3154 * DumpRenderTree/DumpRenderTree.gypi:
3155 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3156 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
3157 (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
3158 (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
3159 (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
3160 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3161 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3164 2011-05-13 Anders Carlsson <andersca@apple.com>
3168 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
3170 2011-05-13 Anders Carlsson <andersca@apple.com>
3172 Reviewed by Sam Weinig.
3174 NPN_GetURL with a javascript: URL doesn't send back the result in the stream
3175 https://bugs.webkit.org/show_bug.cgi?id=60810
3177 Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
3179 * DumpRenderTree/DumpRenderTree.gypi:
3180 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3181 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3182 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3186 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3187 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3188 Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
3190 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
3191 (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
3192 (GetURLWithJavaScriptURL::NPP_New):
3193 (GetURLWithJavaScriptURL::NPP_NewStream):
3194 (GetURLWithJavaScriptURL::NPP_DestroyStream):
3195 (GetURLWithJavaScriptURL::NPP_WriteReady):
3196 (GetURLWithJavaScriptURL::NPP_Write):
3197 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3202 call the PluginTest NPP wrappers.
3204 2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com>
3206 Unreviewed, rolling out r86447.
3207 http://trac.webkit.org/changeset/86447
3208 https://bugs.webkit.org/show_bug.cgi?id=60809
3210 "Broke some uses of EventSender object on Qt" (Requested by
3213 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3214 (WebCore::WebPage::WebPage):
3215 (WebCore::DumpRenderTree::DumpRenderTree):
3216 (WebCore::DumpRenderTree::initJSObjects):
3217 (WebCore::DumpRenderTree::createWindow):
3218 * DumpRenderTree/qt/DumpRenderTreeQt.h:
3219 (WebCore::DumpRenderTree::eventSender):
3220 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3221 (webkit_test_plugin_new_instance):
3222 (webkit_test_plugin_set_window):
3223 (webkit_test_plugin_handle_event):
3225 2011-05-13 Robert Hogan <robert@webkit.org>
3227 Reviewed by Benjamin Poulain.
3229 [Qt] fix http/tests/plugins/plugin-document-has-focus.html
3231 The support for this test added to the unix test plugin here
3232 may allow other platforms to pass it (nearly everyone
3233 skips it). On Qt it required a bit of trickiness with
3234 the page's EventSender object to get it working fully though,
3235 so only unskipping Qt here.
3237 https://bugs.webkit.org/show_bug.cgi?id=60722
3239 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3240 (WebCore::WebPage::WebPage):
3241 (WebCore::WebPage::eventSender):
3242 (WebCore::DumpRenderTree::DumpRenderTree):
3243 (WebCore::DumpRenderTree::initJSObjects):
3244 (WebCore::DumpRenderTree::createWindow):
3245 * DumpRenderTree/qt/DumpRenderTreeQt.h:
3246 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3247 (webkit_test_plugin_new_instance):
3248 (webkit_test_plugin_set_window):
3249 (webkit_test_plugin_handle_event):
3251 2011-05-13 Adam Roben <aroben@apple.com>
3253 Exclude the Leopard NRWT bot from the core builder set
3255 Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
3257 Reviewed by Darin Adler.
3259 * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3260 (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
3261 in the core builder set.
3263 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3264 (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
3267 2011-05-13 Adam Roben <aroben@apple.com>
3269 Group all the NRWT bots together
3271 This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
3272 bots are experimental, it seems best not to clutter up the non-experimental bots with
3275 Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
3278 Reviewed by Dan Bernstein.
3280 * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
3281 Chromium testers, which also use new-run-webkit-tests.
3283 2011-05-13 Adam Roben <aroben@apple.com>
3285 Add a plugin test that dumps the plugin window's rect
3287 Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
3288 (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
3290 Reviewed by Dan Bernstein.
3292 * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
3293 (DumpWindowRect::DumpWindowRect): Just call up to the base class.
3294 (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
3295 harness window and log it.
3297 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
3299 2011-05-13 Adam Roben <aroben@apple.com>
3301 Move code required for most tests of plugin window geometry into a base class
3303 WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
3304 having all the trickiness in a shared base class, writing new window geometry tests will be
3307 Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
3309 Reviewed by Anders Carlsson.
3311 * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3312 (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
3313 WindowGeometryTest base class. Most of the code from this class was moved to the new base
3315 (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
3316 This is called by the base class when it is safe to check the window's geometry. Note that
3317 the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
3318 just vestigial code from an earlier version of this test.
3320 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
3321 WindowGeometryTest class.
3323 * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
3324 WindowRegionIsSetToClipRect.
3325 (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
3326 We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
3327 Subclasses can implement that function to perform their own tests.
3329 * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
3331 2011-05-13 Zoltan Herczeg <zherczeg@webkit.org>
3333 Reviewed by Csaba Osztrogonác.
3335 Missing 2nd #EOF if WebProcess is killed.
3336 https://bugs.webkit.org/show_bug.cgi?id=60761
3338 If the WebProcess is killed, only one #EOF is yielded
3339 by WebKitTestRunner. However, run-webkit-test wait for
3340 a second #EOF, which signals the finishing of pixel dump.
3341 Since this never happens, run-webkit-test waits forever.
3343 * WebKitTestRunner/TestInvocation.cpp:
3344 (WTR::TestInvocation::dump):
3345 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3346 * WebKitTestRunner/TestInvocation.h:
3348 2011-05-13 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
3350 Reviewed by Csaba Osztrogonác.
3352 [NRWT] chromium-linux tests shouldn't run on other platforms
3353 https://bugs.webkit.org/show_bug.cgi?id=60162
3355 Remove _tests_for_other_platforms defs because r82753
3356 implemented it properly in the baseclass in webkit.py.
3358 * Scripts/webkitpy/layout_tests/port/gtk.py:
3359 * Scripts/webkitpy/layout_tests/port/qt.py:
3360 * Scripts/webkitpy/layout_tests/port/win.py:
3362 2011-05-12 Ryuan Choi <ryuan.choi@samsung.com>
3364 Reviewed by Antonio Gomes.
3366 [EFL] Remove unused option of EWeblauncher
3367 https://bugs.webkit.org/show_bug.cgi?id=60747
3369 Remove sudo-workaround option.
3370 This option is not used and make other option wrong.
3372 * EWebLauncher/main.c:
3374 2011-05-12 Lucas Forschler <lforschler@apple.com>
3376 Reviewed by Stephanie Lewis.
3378 Fix config.json to address missing WK2 builder/tester config.
3379 Fix naming of machines (xserve not macpro)
3381 * BuildSlaveSupport/build.webkit.org-config/config.json:
3383 2011-05-12 Lucas Forschler <lforschler@apple.com>
3385 Reviewed by Stephanie Lewis.
3387 Add SnowLeopard Debug builder and Test bot.
3388 apple-xserve-8 = SL Debug Tester.
3389 apple-xserve-9 = SL Debug Builder.
3391 * BuildSlaveSupport/build.webkit.org-config/config.json:
3393 2011-05-12 Adam Barth <abarth@webkit.org>
3395 This patch disables sheriffbot's bug postings. He's just been way too
3396 spammy recently due to test flakiness.
3398 * Scripts/webkitpy/tool/commands/sheriffbot.py:
3399 * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3401 2011-05-11 Brian Weinstein <bweinstein@apple.com>
3403 Reviewed by Anders Carlsson.
3405 After relaunching an unresponsive web process, web page stops responding to mouse movement
3406 https://bugs.webkit.org/show_bug.cgi?id=60669
3407 <rdar://problem/9409934>
3409 This test follows the steps needed to reproduce this bug:
3410 1) Hang the web process
3411 2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
3412 3) Kill and restart the WebProcess
3415 We are testing that we receive mouse move events after the WebProcess has restarted.
3417 * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
3418 (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
3419 (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
3420 (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
3421 (TestWebKitAPI::setPageLoaderClient):
3422 (TestWebKitAPI::TEST):
3423 * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
3424 (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
3425 (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
3426 * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
3428 * TestWebKitAPI/PlatformWebView.h:
3429 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3430 (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
3431 * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3432 (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
3435 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3436 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3437 * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3438 * TestWebKitAPI/win/copy-resources.cmd:
3440 2011-05-12 Tomasz Morawski <t.morawski@samsung.com>
3442 Reviewed by Antonio Gomes.
3444 [EFL] Added initialization/shutdown for ecore_file library
3445 https://bugs.webkit.org/show_bug.cgi?id=60457
3447 Added initialization and shuthown for ecore_file library and replaced
3448 realpath function to ecore_file_realpath.
3450 * EWebLauncher/main.c:
3455 2011-05-12 Young Han Lee <joybro@company100.net>
3457 Reviewed by Kenneth Rohde Christiansen.
3459 [Qt] Implement layoutTestController.layerTreeAsText()
3460 https://bugs.webkit.org/show_bug.cgi?id=60367
3462 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3463 (LayoutTestController::layerTreeAsText):
3464 * DumpRenderTree/qt/LayoutTestControllerQt.h:
3466 2011-05-11 Eric Seidel <eric@webkit.org>
3468 Reviewed by David Levin.
3470 Teach validate-committer-lists how to validate committers bugzilla_email()
3471 https://bugs.webkit.org/show_bug.cgi?id=60651
3473 It turns out we currently have 9 committers with invalid values for their
3474 bugzilla_email field (meaning we don't know what email is their bugzilla account).
3475 "Alexander Kellett" <lypanov@mac.com>
3476 "Andre Boule" <aboule@apple.com>
3477 "Cameron McCormack" <cam@webkit.org>
3478 "Chris Petersen" <cpetersen@apple.com>
3479 "Eli Fidler" <eli@staikos.net>
3480 "Matt Lilek" <webkit@mattlilek.com>
3481 "Pierre d'Herbemont" <pdherbemont@free.fr>
3482 "Scott Violet" <sky@chromium.org>
3483 "Adam Treat" <treat@kde.org>
3485 Most of those haven't committed in a very long time, so it's not suprising
3486 that we haven't noticed that their bugzilla emails are bogus.
3488 * Scripts/validate-committer-lists:
3489 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3490 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3492 2011-05-11 Dmitry Lomov <dslomov@google.com>
3494 Reviewed by David Levin.
3496 https://bugs.webkit.org/show_bug.cgi?id=59561
3497 Switch TestWebKitAPI to GTest
3499 Fixes Makefiles and WinCairo build as well
3502 * Scripts/build-api-tests:
3503 * Scripts/run-api-tests:
3504 * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3505 * TestWebKitAPI/Test.h:
3506 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3507 * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3508 (TestWebKitAPI::TEST):
3509 * TestWebKitAPI/TestsController.cpp:
3510 (TestWebKitAPI::TestsController::TestsController):
3511 (TestWebKitAPI::TestsController::dumpTestNames):
3512 (TestWebKitAPI::TestsController::runTestNamed):
3513 (TestWebKitAPI::TestsController::runAllTests):
3514 * TestWebKitAPI/TestsController.h:
3515 * TestWebKitAPI/mac/main.mm:
3518 2011-05-11 Eric Seidel <eric@webkit.org>
3520 Reviewed by Alexey Proskuryakov.
3522 Add Luke Macpherson to committers.py as a Contributor
3523 https://bugs.webkit.org/show_bug.cgi?id=60639
3525 * Scripts/webkitpy/common/config/committers.py:
3527 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
3529 Reviewed by Kenneth Rohde Christiansen.
3531 [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
3532 https://bugs.webkit.org/show_bug.cgi?id=60439
3534 Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
3536 * Scripts/build-webkit:
3538 2011-05-11 Brian Weinstein <bweinstein@apple.com>
3540 Reviewed by Adam Roben.
3542 REGRESSION (r86161): WKPreferences API test failing on Windows
3543 https://bugs.webkit.org/show_bug.cgi?id=60658
3545 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3546 (TestWebKitAPI::TEST):
3548 2011-05-11 Alice Boxhall <aboxhall@chromium.org>
3550 Reviewed by Ojan Vafai.
3552 Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
3553 https://bugs.webkit.org/show_bug.cgi?id=60521
3555 First steps towards making the results JSON all hierarchical.
3557 * TestResultServer/model/jsonresults.py:
3558 * TestResultServer/model/jsonresults_unittest.py:
3560 2011-05-11 Kevin Ollivier <kevino@theolliviers.com>
3562 [wx] Build fix, adding new LayoutTestController method stubs.
3564 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3565 (LayoutTestController::localStorageDiskUsageForOrigin):
3566 (LayoutTestController::applicationCacheDiskUsageForOrigin):
3568 2011-05-11 Jessie Berlin <jberlin@apple.com>
3570 Reviewed by Darin Adler.
3572 [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
3573 about the usage for both the origin overall and the database in question.
3574 https://bugs.webkit.org/show_bug.cgi?id=60573
3576 * WebKitTestRunner/TestController.cpp:
3577 (WTR::exceededDatabaseQuota):
3579 2011-05-10 Stephen White <senorblanco@chromium.org>
3581 Reviewed by David Levin.
3583 Adding myself as a reviewer.
3584 https://bugs.webkit.org/show_bug.cgi?id=60587
3586 * Scripts/webkitpy/common/config/committers.py:
3588 2011-05-11 Eric Seidel <eric@webkit.org>
3590 Reviewed by Csaba Osztrogonác.
3592 queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
3593 https://bugs.webkit.org/show_bug.cgi?id=60614
3595 AppEngine has a result limit of 1000. We hit that when trying
3596 to find out how many patches the style-queue (and other queues)
3597 have passed in the last 30 days. So lets display 1000+ instead
3598 of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
3600 I also made the status pages show "never" instead of just "ago" when we
3601 haven't seen a pass or boot message in the last 1000 messages.
3603 * QueueStatusServer/handlers/queuestatus.py:
3604 * QueueStatusServer/templates/queuestatus.html:
3606 2011-05-11 Adam Barth <abarth@webkit.org>
3608 Reviewed by Eric Seidel.
3610 sheriffbot shouldn't spam bugs when it can't figure out who to blame
3611 https://bugs.webkit.org/show_bug.cgi?id=60613
3613 This patch limits the number of bugs sheriffbot will spam to three.
3614 Ideally, we'd come up with some smarter huerstics, but hopefully this
3615 will cut down on the bugmail spam for slow bots.
3617 * Scripts/webkitpy/tool/commands/sheriffbot.py:
3619 2011-05-10 Eric Seidel <eric@webkit.org>
3621 Reviewed by Adam Barth.
3623 EWS bots should be robust against test-webkitpy hangs
3624 https://bugs.webkit.org/show_bug.cgi?id=60579
3626 Added a killAfterTimeout subroutine, which takes a child_pid
3627 and timeout, and will setup a watchdog process to kill that child
3628 after the timeout. killAfterTimeout will waitpid on the child.
3630 * EWSTools/start-queue.sh:
3632 2011-05-10 MORITA Hajime <morrita@google.com>
3634 Unreviewed, moved myself to the reviewers list.
3636 * Scripts/webkitpy/common/config/committers.py:
3638 2011-05-10 Anton D'Auria <adauria@apple.com>
3640 Reviewed by David Levin.
3642 StorageTracker should report actual local storage usage on disk
3643 https://bugs.webkit.org/show_bug.cgi?id=60558
3645 * DumpRenderTree/LayoutTestController.cpp:
3646 (localStorageDiskUsageForOriginCallback):
3647 (LayoutTestController::staticFunctions):
3648 * DumpRenderTree/LayoutTestController.h:
3649 * DumpRenderTree/chromium/LayoutTestController.cpp:
3650 (LayoutTestController::LayoutTestController):
3651 (LayoutTestController::localStorageDiskUsageForOrigin):
3652 * DumpRenderTree/chromium/LayoutTestController.h:
3653 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3654 (LayoutTestController::localStorageDiskUsageForOrigin):
3655 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3656 (LayoutTestController::localStorageDiskUsageForOrigin):
3657 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3658 (LayoutTestController::localStorageDiskUsageForOrigin):
3659 * DumpRenderTree/qt/LayoutTestControllerQt.h:
3660 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3661 (LayoutTestController::localStorageDiskUsageForOrigin):
3663 2011-05-10 Anton D'Auria <adauria@apple.com>
3665 Reviewed by Alexey Proskuryakov.
3667 Add ApplicationCache API to get disk usage per origin
3668 https://bugs.webkit.org/show_bug.cgi?id=57127
3670 Added test that loads two frames with ~15Kb image, checks usage,
3671 deletes app cache, verifies usage is 0.