0dc00dadfd2978adffde5c45734d81fc509586f9
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
4         https://bugs.webkit.org/show_bug.cgi?id=114397
5
6         Reviewed by Benjamin Poulain.
7
8         * Scripts/webkitpy/common/net/statusserver.py:
9         (StatusServer):
10
11 2013-04-10  Adam Barth  <abarth@webkit.org>
12
13         Remove abarth from watchlists
14         https://bugs.webkit.org/show_bug.cgi?id=114390
15
16         Reviewed by Ryosuke Niwa.
17
18         I'm trying to cut down on the amount of bugmail I get so that I'll have
19         more of a chance to notice a piece of bugmail directed at me.
20
21         * Scripts/webkitpy/common/config/watchlist:
22
23 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
24
25         webkit-test-results.appspot.com loads the dashboard for Chromium by default
26         https://bugs.webkit.org/show_bug.cgi?id=114381
27
28         Reviewed by Benjamin Poulain.
29
30         Changed the defaults.
31
32         * TestResultServer/static-dashboards/builders.js:
33         * TestResultServer/static-dashboards/dashboard_base.js:
34         (currentBuilderGroupCategory):
35
36 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
37
38         Remove Chromium EWS bots from the queue status server
39         https://bugs.webkit.org/show_bug.cgi?id=113988
40
41         Reviewed by Benjamin Poulain.
42
43         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
44
45         * QueueStatusServer/app.yaml:
46         * QueueStatusServer/config/queues.py:
47         * QueueStatusServer/model/queues.py:
48         (Queue.short_name):
49         (Queue.display_name):
50         * QueueStatusServer/model/queues_unittest.py:
51         (QueueTest.test_short_name):
52         (QueueTest.test_display_name):
53         (QueueTest.test_name_with_underscores):
54         * QueueStatusServer/templates/activebots.html:
55
56 2013-04-10  Ojan Vafai  <ojan@chromium.org>
57
58         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
59         https://bugs.webkit.org/show_bug.cgi?id=114370
60
61         Reviewed by Ryosuke Niwa.
62
63         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
64         Unfortunately, there's no way to test this until this is committed and there is
65         a master restart.
66
67         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
68         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
69         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
70         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
71         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
72         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
73         * TestResultServer/generate_builders_json.py:
74         * TestResultServer/static-dashboards/dashboard_base.js:
75         * TestResultServer/static-dashboards/loader.js:
76
77 2013-04-10  Glenn Adams  <glenn@skynav.com>
78
79         [Qt] Fix regression to test-webkitpy.
80         https://bugs.webkit.org/show_bug.cgi?id=114368
81
82         Reviewed by Ryosuke Niwa.
83
84         * Scripts/webkitpy/layout_tests/port/factory.py:
85         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
86         (PortFactory.get): Remove obsolete chromium port related code.
87         * Scripts/webkitpy/layout_tests/port/mac.py:
88         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
89
90 2013-04-10  Anders Carlsson  <andersca@apple.com>
91
92         Remove unneeded headers from FrameLoader.h
93         https://bugs.webkit.org/show_bug.cgi?id=114223
94
95         Reviewed by Geoffrey Garen.
96
97         Add back headers implicitly included by other headers.
98
99         * WebKitTestRunner/WorkQueueManager.cpp:
100
101 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
102
103         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
104         https://bugs.webkit.org/show_bug.cgi?id=114365
105
106         Reviewed by Martin Robinson.
107
108         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
109         The patch addresses crashes in the tally_event_reply method. It is already committed into the
110         at-spi2-atk source tree and will be available with the next stable release, after which the
111         patch should be removed and the dependency version bumped.
112
113         * gtk/jhbuild.modules:
114         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
115
116 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
117
118         [WinCairo] Unreviewed build fix. Correct DropBox download link.
119
120         * Scripts/update-webkit-wincairo-libs: Revise download URL to
121         match change in DropBox server behavior.
122
123 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
124
125         Removed an annoying message from svn-create-patch
126         https://bugs.webkit.org/show_bug.cgi?id=114332
127
128         Reviewed by Alexey Proskuryakov.
129
130         I see this message basically every time I write a patch, so it must not
131         be true.
132
133         * Scripts/svn-create-patch:
134         (generateDiff):
135
136 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
137
138         [GTK] Add support for Page Visibility
139         https://bugs.webkit.org/show_bug.cgi?id=97324
140
141         Reviewed by Sam Weinig.
142
143         Implemented test runner API for page visibility layout tests.
144
145         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
146         (TestRunner::resetPageVisibility):
147         (TestRunner::setPageVisibility):
148         * Scripts/webkitperl/FeatureList.pm:
149
150 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
151
152         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
153         https://bugs.webkit.org/show_bug.cgi?id=114342
154
155         Reviewed by Gyuyoung Kim.
156
157         Commit 148033 only added an implementation for the Mac port, which made
158         other ports fail most tests since loading the injected bundle failed
159         with a missing symbol.
160
161         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
162         (WTR::AccessibilityUIElement::pathDescription):
163
164 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
165
166         [EFL] Add spell checking option to MiniBrowser
167         https://bugs.webkit.org/show_bug.cgi?id=114282
168
169         Reviewed by Ryosuke Niwa.
170
171         Spell checking is enabled by adding a flag (t/text-checking)
172         with launching MiniBrowser.
173
174         * MiniBrowser/efl/main.c:
175         (window_create):
176         (elm_main):
177
178 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
179
180         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
181         https://bugs.webkit.org/show_bug.cgi?id=113281
182
183         Reviewed by Darin Adler.
184
185         * Scripts/run-gtk-tests:
186         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
187
188 2013-04-09  Glenn Adams  <glenn@skynav.com>
189
190         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
191
192         Unreviewed.
193
194         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
195         (RunTest.test_build_check):
196
197 2013-04-09  Glenn Adams  <glenn@skynav.com>
198
199         [webkitpy] Remove chromium ports.
200         https://bugs.webkit.org/show_bug.cgi?id=114326
201
202         Reviewed by Dirk Pranke.
203
204         As a side effect, also:
205
206         - remove chromium builders from webkitpy.layout_tests.port.builders
207         - remove chromium builders from rebaseline
208         - rewrite chromium dependent tests in rebaseline_unittest
209         - remove chromium platform from garden-o-matic
210         - select apple platform as default platform in garden-o-matic
211         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
212
213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
215         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
216         (BaselineOptimizerTest.test_move_baselines):
217         (BaselineOptimizerTest.test_efl):
218         (BaselineOptimizerTest.test_no_add_mac_future):
219         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
220         (BaselineOptimizerTest.test_common_directory_includes_root):
221         (BaselineOptimizerTest.test_complex_shadowing):
222         (BaselineOptimizerTest.test_virtual_ports_filtered):
223         * Scripts/webkitpy/layout_tests/port/builders.py:
224         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
225         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
226         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
227         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
228         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
229         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
230         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
231         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
232         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
233         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
234         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
235         * Scripts/webkitpy/layout_tests/port/factory.py:
236         (platform_options):
237         (PortFactory):
238         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
239         (FactoryTest.test_qt):
240         (FactoryTest.test_get_from_builder_name):
241         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
242         (RunTest.test_build_check):
243         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
244         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
245         * Scripts/webkitpy/tool/commands/rebaseline.py:
246         (Rebaseline._builders_to_pull_from):
247         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
248         (_BaseTestCase):
249         (_BaseTestCase.setUp):
250         (TestRebaselineTest.setUp):
251         (TestRebaselineTest.test_baseline_directory):
252         (test_rebaseline_updates_expectations_file):
253         (test_rebaseline_does_not_include_overrides):
254         (test_rebaseline_test):
255         (test_rebaseline_test_and_print_scm_changes):
256         (test_rebaseline_and_copy_test):
257         (test_rebaseline_and_copy_test_no_existing_result):
258         (test_rebaseline_and_copy_test_with_lion_result):
259         (test_rebaseline_and_copy_no_overwrite_test):
260         (TestRebaselineExpectations.test_rebaseline_expectations):
261
262 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
263
264         newcommitbot (WKR) requires a subversion checkout
265         https://bugs.webkit.org/show_bug.cgi?id=114309
266
267         Reviewed by Benjamin Poulain.
268
269         Directly talk to the subversion server instead of relying on a local checkout.
270         This allows us to run WKR off of a git clone.
271
272         * Scripts/webkitpy/tool/commands/newcommitbot.py:
273         (NewCommitBot.next_work_item):
274         (NewCommitBot.process_work_item):
275
276 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
277
278         webkitbot refers to sheriffbot in help
279         https://bugs.webkit.org/show_bug.cgi?id=114307
280
281         Reviewed by Benjamin Poulain.
282
283         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
284
285         * Scripts/webkitpy/tool/bot/irc_command.py:
286         (Help):
287         (Help.execute):
288         (RollChromiumDEPS.execute):
289         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
290         (IRCBotTest.test_help):
291         * Scripts/webkitpy/tool/bot/sheriff.py:
292         (Sheriff.name):
293
294 2013-04-06  Roger Fong  <roger_fong@apple.com>
295
296         Kill old processes between runs on WinEWS bots.
297         Temporarily disable tests to let bots catch up again.
298
299         * EWSTools/start-queue-win.sh:
300         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
301         (WinEWS):
302
303 2013-04-09  Glenn Adams  <glenn@skynav.com>
304
305         [webkitpy] Remove chromium deprecated port support.
306         https://bugs.webkit.org/show_bug.cgi?id=114228
307
308         Reviewed by Ryosuke Niwa.
309
310         * Scripts/webkitpy/common/config/ports.py:
311         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
312         (ChromiumPort): Removed.
313         (ChromiumAndroidPort): Removed.
314         (ChromiumXVFBPort): Removed.
315         * Scripts/webkitpy/common/config/ports_unittest.py:
316         (DeprecatedPortTest.test_chromium_port): Removed.
317         (DeprecatedPortTest.test_chromium_android_port): Removed.
318         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
319         * Scripts/webkitpy/tool/steps/update_unittest.py:
320         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
321         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
322
323 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
324
325         AX: The bounding paths should be made available through accessibility
326         https://bugs.webkit.org/show_bug.cgi?id=113817
327
328         Reviewed by David Kilzer.
329
330         Add a pathDescription property for testing so that it's possible
331         to verify that a path is being returned correctly.
332
333         * DumpRenderTree/AccessibilityUIElement.cpp:
334         (getPathDescriptionCallback):
335         (AccessibilityUIElement::pathDescription):
336         (AccessibilityUIElement::getJSClass):
337         * DumpRenderTree/AccessibilityUIElement.h:
338         (AccessibilityUIElement):
339         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
340         (_CGPathEnumerationIteration):
341         (AccessibilityUIElement::pathDescription):
342         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
343         (AccessibilityUIElement::pathDescription):
344         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
345         (WTR::AccessibilityUIElement::pathDescription):
346         (WTR):
347         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
348         (AccessibilityUIElement):
349         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
350         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
351         (WTR::AccessibilityUIElement::pathDescription):
352         (WTR):
353
354 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
355
356         [EFL] Declare TEST_THEME_DIR in a single place.
357         https://bugs.webkit.org/show_bug.cgi?id=114285
358
359         Reviewed by Anders Carlsson.
360
361         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
362
363         * DumpRenderTree/efl/CMakeLists.txt:
364         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
365         (DumpRenderTreeChrome::createView):
366         (DumpRenderTreeChrome::createInspectorView):
367         (DumpRenderTreeChrome::initialize):
368         (DumpRenderTreeChrome::onDownloadRequest):
369         * EWebLauncher/CMakeLists.txt:
370         * EWebLauncher/main.c:
371         (findThemePath):
372         * EWebLauncher/url_bar.c:
373         (url_bar_add):
374         * MiniBrowser/efl/CMakeLists.txt:
375         * MiniBrowser/efl/main.c:
376         (window_create):
377         * TestWebKitAPI/PlatformEfl.cmake:
378         * TestWebKitAPI/efl/PlatformWebView.cpp:
379         (TestWebKitAPI::PlatformWebView::PlatformWebView):
380         * WebKitTestRunner/PlatformEfl.cmake:
381         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
382         (WTR::PlatformWebView::PlatformWebView):
383
384 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
385
386         [GTK][AC] upversion of clutter and its dependecy
387         https://bugs.webkit.org/show_bug.cgi?id=114016
388
389         Reviewed by Gustavo Noronha Silva.
390
391         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
392
393         * gtk/jhbuild-optional.modules:
394
395 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
396
397         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
398         https://bugs.webkit.org/show_bug.cgi?id=89875
399
400         Reviewed by Maciej Stachowiak.
401
402         Add unit tests to verify if the handling of the open, openat, creat syscall
403         is being done right. We check if the Read/Write/ReadAndWrite permissions
404         are respected, if the canonical path is being resolved and if
405         the permissions are falling back to the topmost parent directory with a
406         policy set when the directory being opened has no policy.
407
408         We also test if any attempt of blocking SIGSYS is silently ignored.
409         SIGSYS cannot be blocked because in it's handler is where we hook
410         syscalls to the broker process.
411
412         Also added libseccomp to EFL's jhbuild to make the life of developers
413         willing to help easier.
414
415         * Scripts/webkitperl/FeatureList.pm:
416         * TestWebKitAPI/PlatformEfl.cmake:
417         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
418         (TestWebKitAPI):
419         (SeccompEnvironment):
420         (TestWebKitAPI::SeccompEnvironment::SetUp):
421         (TestWebKitAPI::SeccompEnvironment::TearDown):
422         (TestWebKitAPI::dummyHandler):
423         (TestWebKitAPI::TEST):
424         (TestWebKitAPI::stressTest):
425         * efl/jhbuild.modules:
426         * qmake/mkspecs/features/features.pri:
427
428 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
429
430         REGRESSION: Autocorrection doesn't work in DumpRenderTree
431         https://bugs.webkit.org/show_bug.cgi?id=113846
432
433         Reviewed by Alexey Proskuryakov.
434
435         The problem was that we were replacing NSSpellCheck's dictionary with our own
436         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
437
438         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
439         and "would" respectively in DumpRenderTree.
440
441         * DumpRenderTree/mac/DumpRenderTree.mm:
442         (resetDefaultsToConsistentValues):
443
444 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
445
446         Remove the gyp files for Tools
447         https://bugs.webkit.org/show_bug.cgi?id=114248
448
449         Reviewed by Ryosuke Niwa.
450
451         * DumpRenderTree/DumpRenderTree.gyp: Removed.
452         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
453         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
454         * DumpRenderTree/DumpRenderTree.gypi: Removed.
455         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
456         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
457         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
458         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
459
460 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
461
462         WKR (new-commit-bot) is too slow
463         https://bugs.webkit.org/show_bug.cgi?id=110087
464
465         Reviewed by Geoffrey Garen.
466
467         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
468         Just run "svn log -r <revision>" instead to cut down the delay.
469
470         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
471
472         * Scripts/webkitpy/tool/commands/newcommitbot.py:
473         (NewCommitBot):
474         (NewCommitBot.next_work_item):
475         (NewCommitBot._is_empty_log):
476         (NewCommitBot._update_checkout):
477
478 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
479
480         Build fix. Can't remove appendCustomBuildFlags.
481
482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
483         (appendCustomBuildFlags):
484
485 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
486
487         Remove Chromium builders from build.webkit.org
488         https://bugs.webkit.org/show_bug.cgi?id=113990
489
490         Reviewed by Benjamin Poulain.
491
492         Removed.
493
494         * BuildSlaveSupport/build.webkit.org-config/config.json:
495         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
496         (InstallGtkDependencies):
497         (RunUnitTests.start):
498         (RunWebKit2Tests.start):
499         (Factory.__init__):
500         (unitTestsSupported):
501         (TestFactory.__init__):
502         (BuildAndTestFactory.__init__):
503         (BuildAndPerfTestFactory.__init__):
504         (BuildAndPerfTestWebKit2Factory.__init__):
505         (DownloadAndPerfTestFactory.__init__):
506         (loadBuilderConfig):
507         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
508
509 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
510
511         Remove HTML Notification
512         https://bugs.webkit.org/show_bug.cgi?id=114231
513
514         Reviewed by Ryosuke Niwa.
515
516         * qmake/mkspecs/features/features.pri:
517
518 2013-04-08  Glenn Adams  <glenn@skynav.com>
519
520         Remove chromium EWS support, and fix broken test.
521         https://bugs.webkit.org/show_bug.cgi?id=114221
522
523         Reviewed by Ryosuke Niwa.
524
525         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
526         (AbstractChromiumEWS): Removed.
527         (ChromiumLinuxEWS): Removed.
528         (ChromiumLinuxDebugEWS): Removed.
529         (ChromiumWindowsEWS): Removed.
530         (ChromiumAndroidEWS): Removed.
531         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
532         (EarlyWarningSystemTest): Fix misspelled class name.
533         (test_ewses): Fix entry point name to ensure test is run.
534
535 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
536
537         [WIN] Remove WebKit2 source code
538         https://bugs.webkit.org/show_bug.cgi?id=114096
539
540         Reviewed by Anders Carlsson.
541
542         Remove the windows specific parts of the MiniBrowser.
543
544         * MiniBrowser/MiniBrowser.vcproj: Removed.
545         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
546         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
547         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
548         * MiniBrowser/win/BrowserView.cpp: Removed.
549         * MiniBrowser/win/BrowserView.h: Removed.
550         * MiniBrowser/win/BrowserWindow.cpp: Removed.
551         * MiniBrowser/win/BrowserWindow.h: Removed.
552         * MiniBrowser/win/MiniBrowser.cpp: Removed.
553         * MiniBrowser/win/MiniBrowser.h: Removed.
554         * MiniBrowser/win/MiniBrowser.rc: Removed.
555         * MiniBrowser/win/main.cpp: Removed.
556         * MiniBrowser/win/resource.h: Removed.
557         * MiniBrowser/win/stdafx.cpp: Removed.
558         * MiniBrowser/win/stdafx.h: Removed.
559
560 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
561
562         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
563
564         * Scripts/webkitpy/common/config/irc.py:
565
566 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
567
568         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
569         https://bugs.webkit.org/show_bug.cgi?id=113139
570
571         Reviewed by Anders Carlsson.
572
573         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
574         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
575         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
576         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
577         (ToStringAndValueOfObject):
578         (ToStringAndValueOfObject::ToStringAndValueOfObject):
579         (ScriptableObject):
580         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
581         (ToStringAndValueOfObject::ScriptableObject::invoke):
582         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
583         (ToStringAndValueOfObject::NPP_GetValue):
584         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
585         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
586         * GNUmakefile.am:
587
588 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
589
590         [GTK] Bump gnome-themes-standard to 3.6.0
591         https://bugs.webkit.org/show_bug.cgi?id=114155
592
593         Reviewed by Martin Robinson.
594
595         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
596         dependency of gnome-themes-standard accordingly.
597
598 2013-04-08  David Levin  <levin@chromium.org>
599
600         Remove my watchlist entries.
601         https://bugs.webkit.org/show_bug.cgi?id=114180
602
603         Reviewed by Adam Barth.
604
605         * Scripts/webkitpy/common/config/committers.py:
606         * Scripts/webkitpy/common/config/watchlist:
607
608 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
609
610         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
611         https://bugs.webkit.org/show_bug.cgi?id=114161
612
613         Reviewed by Gyuyoung Kim.
614
615         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
616         as it is crashing due to Bug 111074.
617
618         * TestWebKitAPI/PlatformEfl.cmake:
619
620 2013-04-07  David Kilzer  <ddkilzer@apple.com>
621
622         Remove the rest of SVG_DOM_OBJC_BINDINGS
623         <http://webkit.org/b/114112>
624
625         Reviewed by Geoffrey Garen.
626
627         * Scripts/webkitperl/FeatureList.pm:
628         - Remove --svg-dom-objc-bindings switch.
629         * qmake/mkspecs/features/features.pri:
630         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
631
632 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
633
634         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
635         https://bugs.webkit.org/show_bug.cgi?id=114089
636
637         Reviewed by Chris Fleizach.
638
639         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
640         * DumpRenderTree/AccessibilityController.cpp:
641         * DumpRenderTree/AccessibilityUIElement.cpp:
642         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
643         (DumpRenderTreeChrome::DumpRenderTreeChrome):
644         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
645         (DumpRenderTreeChrome):
646
647 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
648
649         Build fix after r147857, remove remaining USE(JSC) guards.
650
651         Unreviewed.
652
653         * DumpRenderTree/config.h:
654         * TestWebKitAPI/config.h:
655         * WebKitTestRunner/config.h:
656
657 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
658
659         Rename sheriffbot to webkitbot
660         https://bugs.webkit.org/show_bug.cgi?id=114109
661
662         Reviewed by Benjamin Poulain.
663
664         Renamed since sheriffbot will be used in Blink.
665
666         * Scripts/webkitpy/tool/commands/sheriffbot.py:
667         (SheriffBot):
668         (SheriffBot.begin_work_queue):
669
670 2013-04-06  Oliver Hunt  <oliver@apple.com>
671
672         Unify the many and varied stack trace mechanisms, and make the result sane.
673         https://bugs.webkit.org/show_bug.cgi?id=114072
674
675         Reviewed by Filip Pizlo.
676
677         The commandline jsc executable no longer requires arguments, so
678         I've made run-jsc work without them.
679
680         * Scripts/run-jsc:
681
682 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
683
684         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
685         https://bugs.webkit.org/show_bug.cgi?id=114086
686
687         Reviewed by Tim Horton.
688
689         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
690
691 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
692
693         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
694         https://bugs.webkit.org/show_bug.cgi?id=114083
695
696         Reviewed by Ryosuke Niwa.
697
698         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
699         in TestWebKitAPI and WebKitTestRunner.
700
701         * TestWebKitAPI/config.h:
702         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
703         (TestWebKitAPI::InjectedBundleController::platformInitialize):
704         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
705         (WTR::InjectedBundle::platformInitialize):
706
707 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
708
709         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
710         https://bugs.webkit.org/show_bug.cgi?id=114094
711
712         Reviewed by Anders Carlsson.
713
714         * Scripts/run-jsc:
715
716 2013-04-05  Ojan Vafai  <ojan@chromium.org>
717
718         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
719         https://bugs.webkit.org/show_bug.cgi?id=114080
720
721         Reviewed by Ryosuke Niwa.
722
723         This way, the WebKit and Blink dashboard code can change as appropriate without
724         needing to consider the other project's needs. This still doesn't update the
725         buildbots to upload to the new location, or the dashboard code to pull the
726         results.json files from the new location, but it at least allows for changing the
727         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
728
729         * TestResultServer/app.yaml:
730
731 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
732
733         Re-enable testing on the commit queue
734         https://bugs.webkit.org/show_bug.cgi?id=114078
735
736         Reviewed by Darin Adler.
737
738         Re-enabled the feature and the associated tests.
739
740         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
741         (CommitQueueTask.run):
742         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
743         (CommitQueueTaskTest._run_through_task):
744         * Scripts/webkitpy/tool/commands/queues_unittest.py:
745         (CommitQueueTest._mock_test_result):
746
747 2013-04-05  Oliver Hunt  <oliver@apple.com>
748
749         Unify the many and varied stack trace mechanisms, and make the result sane.
750         https://bugs.webkit.org/show_bug.cgi?id=114072
751
752         Reviewed by Filip Pizlo.
753
754         The commandline jsc executable no longer requires arguments, so
755         I've made run-jsc work without them.
756
757         * Scripts/run-jsc:
758
759 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
760
761         AX: Make SVG Group containers accessible elements
762         https://bugs.webkit.org/show_bug.cgi?id=113939
763
764         Reviewed by Simon Fraser.
765
766         Implement axController.elementAtPoint for iOS.
767         Implement a correct version of clickPoint for iOS.
768
769         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
770         (AccessibilityController::elementAtPoint):
771         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
772         (AccessibilityUIElement::clickPointX):
773         (AccessibilityUIElement::clickPointY):
774
775 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
776
777         Unreviewed, rolling out r147773 and r147774.
778         http://trac.webkit.org/changeset/147773
779         http://trac.webkit.org/changeset/147774
780         https://bugs.webkit.org/show_bug.cgi?id=114056
781
782         Causing some exceptions on AppEngine I don't understand
783         (Requested by rniwa on #webkit).
784
785         * QueueStatusServer/config/queues.py:
786         * QueueStatusServer/model/queues.py:
787         (Queue.short_name):
788         (Queue.display_name):
789         * QueueStatusServer/model/queues_unittest.py:
790         (QueueTest.test_short_name):
791         (QueueTest.test_display_name):
792         (QueueTest.test_name_with_underscores):
793
794 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
795
796         Fixed run-bindings-tests by removing V8
797         https://bugs.webkit.org/show_bug.cgi?id=114053
798
799         Reviewed by Benjamin Poulain.
800
801         * Scripts/run-bindings-tests:
802         (main):
803
804 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
805
806         Build fix.
807
808         * QueueStatusServer/model/queues.py:
809         (Queue.short_name):
810         (Queue.display_name):
811
812 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
813
814         Remove Chromium EWS bots from the queue status server
815         https://bugs.webkit.org/show_bug.cgi?id=113988
816
817         Reviewed by Benjamin Poulain.
818
819         Removed Chromium EWS bots.
820
821         * QueueStatusServer/config/queues.py:
822         * QueueStatusServer/model/queues.py:
823         (Queue.short_name):
824         (Queue.display_name):
825         * QueueStatusServer/model/queues_unittest.py:
826         (QueueTest.test_short_name):
827         (QueueTest.test_display_name):
828         (QueueTest.test_name_with_underscores):
829
830 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
831
832         [EFL] Enable indexed database
833         https://bugs.webkit.org/show_bug.cgi?id=107248
834
835         Reviewed by Alexis Menard.
836
837         * Scripts/webkitperl/FeatureList.pm:
838
839 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
840
841         Remove vestiges of Chromium bits from watchlists.
842         https://bugs.webkit.org/show_bug.cgi?id=114047
843
844         Reviewed by Ryosuke Niwa.
845
846         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
847
848 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
849
850         Add James Craig to the contributors list.
851
852         * Scripts/webkitpy/common/config/committers.py:
853
854 2013-04-04  Kent Tamura  <tkent@chromium.org>
855
856         Remove ChromiumPublicApi pattern, and cc/message rules for it.
857
858         * Scripts/webkitpy/common/config/watchlist:
859
860 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
861
862         Temporarily disable the Python unittests broken by the commit queue not running layout tests
863         https://bugs.webkit.org/show_bug.cgi?id=113997
864
865         Reviewed by Ryosuke Niwa.
866
867         Disable the tests until Ryosuke gets the time and hardware to have
868         a testing commit-queue.
869
870         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
871         (CommitQueueTaskTest):
872         * Scripts/webkitpy/tool/commands/queues_unittest.py:
873         (CommitQueueTest):
874
875 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
876
877         Remove Chromium builders from build.webkit.org
878         https://bugs.webkit.org/show_bug.cgi?id=113990
879
880         Reviewed by Benjamin Poulain.
881
882         Land the part to disable triggering of Chromium builders first so that we may start
883         deleting more Chromium code that breaks the update step.
884
885         * BuildSlaveSupport/build.webkit.org-config/config.json:
886
887 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
888
889         Remove Chromium's DumpRenderTree
890         https://bugs.webkit.org/show_bug.cgi?id=113989
891
892         Reviewed by Kent Tamura.
893
894         On second thought, let's not go to Camelot. It is a silly place.
895
896         * DumpRenderTree/mac/DumpRenderTree.mm:
897         (resetDefaultsToConsistentValues):
898
899 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
900
901         Nixed the defunct chromium folder from DumpRenderTree
902         https://bugs.webkit.org/show_bug.cgi?id=113993
903
904         Reviewed by Ryosuke Niwa.
905
906         * DumpRenderTree/chromium: Removed.
907         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
908         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
909         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
910         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
911         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
912         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
913         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
914         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
915         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
916         * DumpRenderTree/chromium/MockPlatform.h: Removed.
917         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
918         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
919         * DumpRenderTree/chromium/Task.cpp: Removed.
920         * DumpRenderTree/chromium/Task.h: Removed.
921         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
922         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
923         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
924         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
925         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
926         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
927         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
928         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
929         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
930         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
931         * DumpRenderTree/chromium/TestRunner: Removed.
932         * DumpRenderTree/chromium/TestRunner/public: Removed.
933         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
934         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
935         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
936         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
937         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
938         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
939         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
940         * DumpRenderTree/chromium/TestRunner/src: Removed.
941         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
942         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
943         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
944         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
945         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
946         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
947         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
948         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
949         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
950         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
951         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
952         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
953         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
954         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
955         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
956         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
957         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
958         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
959         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
960         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
961         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
962         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
963         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
964         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
965         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
966         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
967         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
968         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
969         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
970         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
971         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
972         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
973         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
974         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
975         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
976         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
977         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
978         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
979         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
980         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
981         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
982         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
983         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
984         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
985         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
986         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
987         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
988         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
989         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
990         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
991         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
992         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
993         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
994         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
995         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
996         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
997         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
998         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
999         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1000         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1001         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1002         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1003         * DumpRenderTree/chromium/TestShell.h: Removed.
1004         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1005         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1006         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1007         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1008         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1009         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1010         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1011         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1012         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1013         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1014         * DumpRenderTree/chromium/config.h: Removed.
1015         * DumpRenderTree/chromium/fonts.conf: Removed.
1016
1017 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1018
1019         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1020
1021         Rubber stamped by Benjamin Poulain.
1022
1023         * RebaselineQueueServer: Removed.
1024         * RebaselineQueueServer/app.yaml: Removed.
1025         * RebaselineQueueServer/handlers: Removed.
1026         * RebaselineQueueServer/handlers/__init__.py: Removed.
1027         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1028         * RebaselineQueueServer/handlers/pages.py: Removed.
1029         * RebaselineQueueServer/index.yaml: Removed.
1030         * RebaselineQueueServer/main.py: Removed.
1031         * RebaselineQueueServer/model: Removed.
1032         * RebaselineQueueServer/model/__init__.py: Removed.
1033         * RebaselineQueueServer/model/queueentry.py: Removed.
1034         * RebaselineQueueServer/static: Removed.
1035         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1036         * RebaselineQueueServer/static/styles.css: Removed.
1037         * RebaselineQueueServer/templates: Removed.
1038         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1039         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1040         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1041         * RebaselineQueueServer/templates/home.html: Removed.
1042
1043 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1044
1045         Fix setup-commit-queue and temporarily disable testing on commit-queue
1046         https://bugs.webkit.org/show_bug.cgi?id=113979
1047
1048         Reviewed by Benjamin Poulain.
1049
1050         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1051         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1052
1053         * EWSTools/setup-commit-queue.sh:
1054         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1055         (CommitQueueTask.run):
1056
1057 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1058
1059         temporarily make flakiness dashboard work again webkit.org bots
1060         https://bugs.webkit.org/show_bug.cgi?id=113972
1061
1062         Reviewed by Ojan Vafai.
1063
1064         This patch disables the chromium.org layout test bots TestExpectations
1065         parsing temporarily until we can work out the right way to split into
1066         two instances for webkit.org and chromium.org and figure out which
1067         code to delete where :).
1068
1069         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1070
1071 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1072
1073         Fix webkitpy tests after r147678.
1074
1075         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1076         (CommitQueueTest.test_commit_queue):
1077         (test_manual_reject_during_processing):
1078
1079 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1080
1081         The commit queue should use Mac MountainLion port
1082         https://bugs.webkit.org/show_bug.cgi?id=113971
1083
1084         Reviewed by Lucas Forschler.
1085
1086         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1087         * Scripts/webkitpy/tool/commands/queues.py:
1088         (CommitQueue):
1089
1090 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1091
1092         turn off running tests on chromium linux EWS bots
1093         https://bugs.webkit.org/show_bug.cgi?id=113959
1094
1095         Reviewed by Geoffrey Garen.
1096
1097         Now that the Chromium port is no longer being maintained
1098         there's little point in running the tests. Soon we should
1099         just shut this bot off altogether.
1100
1101         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1102         (ChromiumLinuxEWS):
1103
1104 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1105
1106         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1107
1108         * Scripts/webkitpy/common/config/watchlist:
1109
1110 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1111
1112         Indentation fix to get webkit-patch working again after r147625
1113
1114         Unreviewed.
1115
1116         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1117         (MacEWS):
1118         (MacWK2EWS):
1119
1120 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1121
1122         Turn tests back on for Mac WK1/WK2 EWS.
1123         
1124         Unreviewed.
1125         
1126         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1127         (MacEWS):
1128         (MacWK2EWS):
1129
1130 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1131
1132         [GTK][WK2] MiniBrowser custom URI scheme support
1133         https://bugs.webkit.org/show_bug.cgi?id=112419
1134
1135         Reviewed by Carlos Garcia Campos.
1136
1137         Add support for about URIs in MiniBrowser. An example about page is show
1138         with URI "about:minibrowser", the rest of the cases it will show a
1139         proper message explaining that the about page didn't exist.
1140
1141         Internally it uses "minibrowser-about" prefix instead of "about", but
1142         from the user point of view it works with "about" prefix.
1143
1144         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1145         (getInternalURI): Method to convert URIs from "about" prefix to
1146         "minibrowser-about".
1147         (getExternalURI): Opposite method.
1148         (webViewURIChanged): Use "about" prefix to show the URI to users.
1149         (webViewEnterFullScreen): Ditto.
1150         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1151         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1152         (aboutURISchemeRequestCallback): Callback to manage about calls.
1153         (main): Register the URI scheme to manage about URIs.
1154
1155 2013-04-03  Roger Fong  <roger_fong@apple.com>
1156
1157         Re-enable WinEWS tests.
1158
1159         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1160         (WinEWS):
1161
1162 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1163
1164         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1165         https://bugs.webkit.org/show_bug.cgi?id=113883
1166
1167         Reviewed by Martin Robinson.
1168
1169         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1170         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1171         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1172
1173 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1174
1175         [GTK] Include Pango in jhbuild-optional.modules
1176         https://bugs.webkit.org/show_bug.cgi?id=113878
1177
1178         Reviewed by Martin Robinson.
1179
1180         Since r147547 Pango 1.32.0 is required. Including the module in the
1181         JHBuild optional moduleset.
1182
1183         * gtk/jhbuild-optional.modules: Add Pango module.
1184
1185 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1186
1187         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1188         https://bugs.webkit.org/show_bug.cgi?id=113864
1189
1190         Moving setDefersLoading from TestRunnerQt to TestRunner
1191         requires access to the non-Qt TestRunner.
1192         As long as we instantiate both TestRunner and TestRunnerQt,
1193         we need a separate getter for the non-Qt TestRunner instance.
1194
1195         Reviewed by Simon Hausmann.
1196
1197         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1198         (WebPage::resetSettings):
1199         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1200         (DumpRenderTree::jscTestRunner):
1201         * DumpRenderTree/qt/TestRunnerQt.cpp:
1202         (TestRunner::setDefersLoading):
1203             Moving setDefersLoading from TestRunnerQt
1204             to TestRunner.
1205         * DumpRenderTree/qt/TestRunnerQt.h:
1206         (TestRunnerQt):
1207
1208 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1209
1210         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1211         https://bugs.webkit.org/show_bug.cgi?id=104779
1212
1213         Reviewed by Carlos Garcia Campos.
1214
1215         * Scripts/run-gtk-tests:
1216         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1217         passing in current trunk.
1218
1219 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1220
1221         Fix HAVE(QTTESTSUPPORT) logic
1222
1223         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1224         resulting in HAVE(QTTESTSUPPORT) never being true.
1225         Move that logic down in sanitizeFeatures.
1226
1227         Rubber-stamped by Tor Arne Vestbø.
1228
1229         * qmake/mkspecs/features/features.prf:
1230
1231 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1232
1233         [GTK] Bump required versions of some dependencies
1234         https://bugs.webkit.org/show_bug.cgi?id=113282
1235
1236         Reviewed by Martin Robinson.
1237
1238         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1239
1240 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1241
1242         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1243         https://bugs.webkit.org/show_bug.cgi?id=113809
1244
1245         Reviewed by Philippe Normand.
1246
1247         Newer Linux kernels have removed some deprecated macros from v4l2
1248         headers, causing gst-plugins-good's build to break. We don't need it
1249         right now, so just disable it.
1250
1251         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1252
1253 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1254
1255         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1256         https://bugs.webkit.org/show_bug.cgi?id=113535
1257
1258         Reviewed by Simon Hausmann.
1259
1260         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1261
1262         * qmake/mkspecs/features/features.prf:
1263
1264 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1265
1266         [Qt] Move logic of simple forwarding functions to TestRunner.
1267         https://bugs.webkit.org/show_bug.cgi?id=113863
1268
1269         Reviewed by Simon Hausmann.
1270
1271         * DumpRenderTree/qt/TestRunnerQt.cpp:
1272         (TestRunner::setTextDirection):
1273         (TestRunner::goBack):
1274         (TestRunner::evaluateScriptInIsolatedWorld):
1275         (TestRunner::addUserStyleSheet):
1276         * DumpRenderTree/qt/TestRunnerQt.h:
1277         (TestRunnerQt):
1278
1279 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1280
1281         [Qt] Disable media support using QuickTime if deployment target != SDK
1282
1283         We link to a single libWebKitSystemInterface static lib, so unless the
1284         deployment target matches the SDK let's not pretend like we'll be able
1285         to run on anything lower than the SDK version.
1286
1287         Reviewed by Simon Hausmann.
1288
1289         * qmake/mkspecs/features/features.prf:
1290
1291 2013-04-02  James Craig  <james@cookiecrook.com>
1292
1293         AXRoleDescripton for DL is "list"; should be "description list"
1294         https://bugs.webkit.org/show_bug.cgi?id=111665
1295
1296         Reviewed by Chris Fleizach.
1297
1298         Defining the role and description strings.
1299
1300         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1301
1302 2013-04-02  Roger Fong  <roger_fong@apple.com>
1303
1304         Unreviewed. Disable running tests on Win EWS queue.
1305
1306         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1307         (WinEWS):
1308
1309 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1310
1311         Disable running tests on the MAC WK2 EWS queue.
1312         
1313         Unreviewed.
1314         
1315         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1316         (MacWK2EWS):
1317
1318 2013-04-02  Julie Parent  <jparent@chromium.org>
1319
1320         Dashboard refactor: Move dashboard specific history related features to History.
1321         https://bugs.webkit.org/show_bug.cgi?id=113717
1322
1323         Reviewed by Ojan Vafai.
1324         
1325         Each dashboard now creates its own History object, with a custom
1326         configuration. This changes from just overriding global functions
1327         to passing in callbacks for generatePage, handleValidHashParameter,
1328         and handleQueryParameterChange. Same with passing in defaultStateValues
1329         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1330         variables.
1331         
1332         All functions related to these features are now (mostly) private
1333         function on History. 
1334         
1335         Loader no longer needs a loadingComplete callback, since it can just
1336         initialize the history object itself.
1337
1338         * TestResultServer/static-dashboards/aggregate_results.js:
1339         (handleValidHashParameter):
1340         * TestResultServer/static-dashboards/dashboard_base.js:
1341         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1342         (generatePage):
1343         (.switch.return):
1344         (handleQueryParameterChange):
1345         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1346         (resetGlobals):
1347         * TestResultServer/static-dashboards/history.js:
1348         (.):
1349         * TestResultServer/static-dashboards/loader.js:
1350         (.):
1351         * TestResultServer/static-dashboards/loader_unittests.js:
1352         * TestResultServer/static-dashboards/timeline_explorer.js:
1353         (generatePage):
1354         (initCurrentBuilderTestResults):
1355         * TestResultServer/static-dashboards/treemap.js:
1356         (generatePage):
1357         (.switch.return):
1358         (handleQueryParameterChange):
1359
1360 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1361
1362         Unreviewed, rolling out r147401.
1363         http://trac.webkit.org/changeset/147401
1364         https://bugs.webkit.org/show_bug.cgi?id=113767
1365
1366         The patch makes it extremely hard to set up the dependencies
1367         properly on the GTK builders (Requested by zdobersek on
1368         #webkit).
1369
1370         * gtk/jhbuild.modules:
1371
1372 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1373
1374         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1375         https://bugs.webkit.org/show_bug.cgi?id=113382
1376
1377         Reviewed by Gyuyoung Kim.
1378
1379         Do not show the empty tooltip box if the text is null.
1380
1381         * MiniBrowser/efl/main.c:
1382         (popup_menu_populate):
1383
1384 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1385
1386         [GTK] Bump required versions of some dependencies
1387         https://bugs.webkit.org/show_bug.cgi?id=113282
1388
1389         Reviewed by Martin Robinson.
1390
1391         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1392
1393 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1394
1395         Unreviewed, rolling out r147319.
1396         http://trac.webkit.org/changeset/147319
1397         https://bugs.webkit.org/show_bug.cgi?id=113707
1398
1399         The unit test is still failing on the buildbot (Requested by
1400         zdobersek on #webkit).
1401
1402         * Scripts/run-gtk-tests:
1403         (TestRunner):
1404
1405 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1406
1407         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1408         https://bugs.webkit.org/show_bug.cgi?id=104779
1409
1410         Reviewed by Carlos Garcia Campos.
1411
1412         * Scripts/run-gtk-tests:
1413         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1414         passing in current trunk.
1415
1416 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1417
1418         Unreviewed, rolling out r147289.
1419         http://trac.webkit.org/changeset/147289
1420         https://bugs.webkit.org/show_bug.cgi?id=113678
1421
1422         broke Win7 (dbg) build (Requested by shinyak|gardener on
1423         #webkit).
1424
1425         * DumpRenderTree/DumpRenderTree.gypi:
1426         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1427         (WebTestRunner):
1428         (WebUserMediaClientMock):
1429         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1430         (WebTestRunner::WebUserMediaClientMock::taskList):
1431         * Scripts/webkitpy/style/checkers/cpp.py:
1432         (check_function_definition):
1433
1434 2013-03-31  Adam Barth  <abarth@webkit.org>
1435
1436         configure-svn-config.sh fails
1437         https://codereview.chromium.org/13392007/
1438
1439         Reviewed by Eric Seidel.
1440
1441         This script was trying to use "svn checkout" to dowload a file from
1442         svn.webkit.org, but "svn checkout" only works with directories.
1443         Instead, we should use "svn export".
1444
1445         * EWSTools/configure-svn-config.sh:
1446
1447 2013-03-31  Wei Jia  <wjia@chromium.org>
1448
1449         Allow WebUserMediaClientMock to be used by client
1450         https://bugs.webkit.org/show_bug.cgi?id=113633
1451
1452         Reviewed by Adam Barth.
1453
1454         Export WebUserMediaClientMock.
1455         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1456
1457         * DumpRenderTree/DumpRenderTree.gypi:
1458         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1459         (WebUserMediaClientMock):
1460         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1461         * Scripts/webkitpy/style/checkers/cpp.py:
1462         (check_function_definition):
1463
1464 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1465
1466         Expose FeatureObserver data to WebKit clients
1467         https://bugs.webkit.org/show_bug.cgi?id=113613
1468
1469         Reviewed by Sam Weinig.
1470
1471         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1472         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1473
1474 2013-03-29  Greg Hughes  <ghughes@apple.com>
1475
1476         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1477         https://bugs.webkit.org/show_bug.cgi?id=112276
1478
1479         Reviewed by Chris Fleizach.
1480
1481         Added support to test accessibility search predicates with multiple keys.  
1482
1483         * DumpRenderTree/AccessibilityUIElement.cpp:
1484         (uiElementForSearchPredicateCallback):
1485         * DumpRenderTree/AccessibilityUIElement.h:
1486         (AccessibilityUIElement):
1487         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1488         (AccessibilityUIElement::uiElementForSearchPredicate):
1489         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1490         (AccessibilityUIElement::uiElementForSearchPredicate):
1491         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1492         (AccessibilityUIElement::uiElementForSearchPredicate):
1493         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1494         (AccessibilityUIElement::uiElementForSearchPredicate):
1495         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1496         (AccessibilityUIElement::uiElementForSearchPredicate):
1497         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1498         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1499         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1500         (AccessibilityUIElement):
1501         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1502         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1503         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1504         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1505         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1506
1507 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1508
1509         Fix a typo in r147147 to fix Mac EWS.
1510
1511         * Scripts/webkitpy/tool/commands/queues.py:
1512         (PatchProcessingQueue._new_port_name_from_old):
1513
1514 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1515
1516         [EFL] Build break with latest EFL libraries after r146265
1517         https://bugs.webkit.org/show_bug.cgi?id=113558
1518
1519         Unreviewed build fix.
1520
1521         * TestWebKitAPI/PlatformWebView.h:
1522         * WebKitTestRunner/PlatformWebView.h:
1523
1524 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1525
1526         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1527
1528         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1529         in libgcrypt build.
1530
1531 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1532
1533         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1534
1535         Unreviewed.
1536
1537         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1538         (MacEWS):
1539
1540 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1541
1542         Use the right OS name on Mac EWS instead of mac-future.
1543
1544         Rubber-stamped by Dirk Pranke.
1545
1546         * Scripts/webkitpy/tool/commands/queues.py:
1547         (PatchProcessingQueue._new_port_name_from_old):
1548         (PatchProcessingQueue.begin_work_queue):
1549         (PatchProcessingQueue._upload_results_archive_for_patch):
1550
1551 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1552
1553         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1554         https://bugs.webkit.org/show_bug.cgi?id=112546
1555
1556         Reviewed by Martin Robinson.
1557
1558         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1559         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1560
1561 2013-03-28  Ming Xie  <mxie@blackberry.com>
1562
1563         [BlackBerry] Committer Email Updates
1564         https://bugs.webkit.org/show_bug.cgi?id=113435
1565
1566         Reviewed by Rob Buis.
1567
1568         Add the @blackberry.com email address for all our BlackBerry
1569         WebKit committers. This is the first step for our email address
1570         migration.
1571
1572         * Scripts/webkitpy/common/config/committers.py:
1573
1574 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1575
1576         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1577         https://bugs.webkit.org/show_bug.cgi?id=113508
1578
1579         Reviewed by Martin Robinson.
1580
1581         Prevent the GStreamer plugin scanner to load system-wide
1582         plugins. Only the ones built in JHBuild should be loaded and used
1583         at runtime.
1584
1585         * efl/jhbuildrc:
1586         * gtk/jhbuildrc:
1587
1588 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1589
1590         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1591         https://bugs.webkit.org/show_bug.cgi?id=113386
1592
1593         Reviewed by Carlos Garcia Campos.
1594
1595         * Scripts/webkitdirs.pm:
1596         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1597         version to 3.0. Reflect this change so the builtDylibPathForName
1598         function doesn't fail to report the library as found.
1599
1600 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1601
1602         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1603         https://bugs.webkit.org/show_bug.cgi?id=113484
1604
1605         Unreviewed build fix.
1606
1607         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1608
1609         * TestWebKitAPI/CMakeLists.txt:
1610         * WebKitTestRunner/CMakeLists.txt:
1611
1612 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1613
1614         Revision for the internal jhbuild is too old
1615         https://bugs.webkit.org/show_bug.cgi?id=113324
1616
1617         Reviewed by Martin Robinson.
1618
1619         Update the minimum required version to a point where jhbuild won't
1620         fail installing packages when trying to remove a symlink to a directory.
1621
1622         * jhbuild/jhbuild-wrapper: Updated revision.
1623
1624 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1625
1626         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1627         https://bugs.webkit.org/show_bug.cgi?id=113203
1628
1629         Reviewed by Philippe Normand.
1630
1631         We build our libsoup without GNOME support. gst-plugins-good does separate
1632         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1633         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1634         build failures as the headers of those diverge. We do not use souphttpsrc, so
1635         disable it when building gst-plugins-good.
1636
1637         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1638
1639 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1640
1641         Build fix after r146852. Please another reference to the Lion leaks builder.
1642
1643         * BuildSlaveSupport/build.webkit.org-config/config.json:
1644
1645 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1646
1647         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1648         https://bugs.webkit.org/show_bug.cgi?id=113421
1649
1650         Reviewed by Dirk Pranke.
1651
1652         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1653         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1654         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1655         in the GTK-specific TestExpectations files.
1656
1657         To avoid this only enable the warnings only when not using WKTR.
1658
1659         * Scripts/webkitpy/layout_tests/port/gtk.py:
1660         (GtkPort.warn_if_bug_missing_in_test_expectations):
1661
1662 2013-03-27  Antti Koivisto  <antti@apple.com>
1663
1664         Fix Zalan's email.
1665
1666         * Scripts/webkitpy/common/config/committers.py:
1667
1668 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1669
1670         master.cfg cleanup
1671         https://bugs.webkit.org/show_bug.cgi?id=113195
1672
1673         Reviewed by Ryosuke Niwa.
1674
1675         * BuildSlaveSupport/build.webkit.org-config/config.json:
1676         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1677
1678 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1679
1680         master.cfg fine-tuning for Qt Mountain Lion Release bot
1681         https://bugs.webkit.org/show_bug.cgi?id=113191
1682
1683         Reviewed by Ryosuke Niwa.
1684
1685         * BuildSlaveSupport/build.webkit.org-config/config.json:
1686           - Rename the slave due to its location change.
1687           - Update the platform of the slave.
1688         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1689         (RunQtAPITests): Enable running WK2 API tests on Qt.
1690         (RunQtAPITests.start):
1691         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1692         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1693
1694 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1695
1696         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1697         https://bugs.webkit.org/show_bug.cgi?id=113403
1698
1699         Reviewed by Kenneth Rohde Christiansen.
1700
1701         As of Evas 1.7.5, when Wayland is detected on the system, support for
1702         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1703         The code, however, seems to depend on a few other flags which must be
1704         explicitly enabled.
1705
1706         If those additional GL-related options are passed, we end up
1707         having issues on the WebKit side, so disable Wayland support for
1708         now.
1709
1710         * efl/jhbuild.modules:
1711
1712 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1713
1714         Unreviewed, rolling out r146864.
1715         http://trac.webkit.org/changeset/146864
1716         https://bugs.webkit.org/show_bug.cgi?id=113391
1717
1718         causes crashes on Wk2 EFL release bot (Requested by drott on
1719         #webkit).
1720
1721         * Scripts/webkitperl/FeatureList.pm:
1722
1723 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1724
1725         [jhbuild] Correctly specify an alternate number of make jobs.
1726         https://bugs.webkit.org/show_bug.cgi?id=113396
1727
1728         Reviewed by Philippe Normand.
1729
1730         So far, we were using the `MAKEFLAGS' environment variable to pass the
1731         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1732         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1733
1734         We now behave more closely to the rest of the WebKit tools by first
1735         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1736         not set, just letting jhbuild itself figure out how many jobs to use.
1737
1738         * efl/jhbuildrc:
1739         * gtk/jhbuildrc:
1740
1741 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1742
1743         [Qt] Remove Qt specific WorkQueueItem definitions.
1744         https://bugs.webkit.org/show_bug.cgi?id=112891
1745
1746         This patch is preparation work for removing
1747         WorkQueue related code from TestRunnerQt and
1748         replacing it with generic TestRunner code.
1749
1750         Reviewed by Benjamin Poulain.
1751
1752         * DumpRenderTree/qt/TestRunnerQt.cpp:
1753         (TestRunnerQt::queueBackNavigation):
1754         (TestRunnerQt::queueForwardNavigation):
1755         (TestRunnerQt::queueLoadHTMLString):
1756         (TestRunnerQt::queueReload):
1757         (TestRunnerQt::queueLoadingScript):
1758         (TestRunnerQt::queueNonLoadingScript):
1759         (TestRunner::queueLoad):
1760         * DumpRenderTree/qt/TestRunnerQt.h:
1761         (TestRunnerQt):
1762         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1763         (LoadItem::invoke):
1764         (LoadHTMLStringItem::invoke):
1765         (LoadAlternateHTMLStringItem::invoke):
1766         (ReloadItem::invoke):
1767         (ScriptItem::invoke):
1768         (BackForwardItem::invoke):
1769         * DumpRenderTree/qt/WorkQueueItemQt.h:
1770         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1771         (LoadAlternateHTMLStringItem):
1772
1773 2013-03-26  Julie Parent  <jparent@chromium.org>
1774
1775         Flakiness dashboard: simplify logic around which tests to show.
1776         https://bugs.webkit.org/show_bug.cgi?id=113250
1777
1778         Reviewed by Ojan Vafai.
1779         
1780         The different filters for showing results are only used for layout
1781         tests, otherwise, we show everything.
1782         
1783         Change the defaults to false (what layout tests used), and only
1784         look at the values when viewing layout tests.
1785
1786         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1787         (htmlForTestsWithExpectationsButNoFailures):
1788         (shouldHideTest):
1789
1790 2013-03-26  Isaac Levy  <ilevy@google.com>
1791
1792         Update bots on test-results.appspot
1793         https://bugs.webkit.org/show_bug.cgi?id=113333
1794
1795         Reviewed by Ojan Vafai.
1796
1797         * TestResultServer/static-dashboards/builders.jsonp:
1798
1799 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1800
1801         Unreviewed GTK gardening.
1802
1803         * Scripts/run-gtk-tests:
1804         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1805
1806 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1807
1808         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1809         https://bugs.webkit.org/show_bug.cgi?id=113287
1810
1811         Reviewed by Jocelyn Turcotte.
1812
1813         * Scripts/run-qtwebkit-tests:
1814         (Options.__init__):
1815
1816 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1817
1818         [EFL] Enable IndexedDB by default
1819         https://bugs.webkit.org/show_bug.cgi?id=107248
1820
1821         Reviewed by Laszlo Gombos.
1822
1823         * Scripts/webkitperl/FeatureList.pm:
1824         Enable IndexedDB by default on EFL.
1825
1826 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1827
1828         Sheriffbot should explain rollout failures in a human readable form.
1829         https://bugs.webkit.org/show_bug.cgi?id=107092
1830
1831         Reviewed by Ryosuke Niwa.
1832
1833         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1834
1835         * Scripts/webkitpy/tool/bot/irc_command.py:
1836         (Rollout._check_diff_failure):
1837         (Rollout.execute):
1838         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1839         (IRCCommandTest.test_rollout):
1840
1841 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1842
1843         Unreviewed GTK gardening.
1844
1845         * Scripts/run-gtk-tests:
1846         (TestRunner): Skipping a failing unit test after r146518.
1847
1848 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1849
1850         Remove Lion leaks builder
1851         https://bugs.webkit.org/show_bug.cgi?id=113252
1852
1853         Reviewed by Andreas Kling.
1854
1855         Removed.
1856
1857         * BuildSlaveSupport/build.webkit.org-config/config.json:
1858
1859 2013-03-25  Kent Tamura  <tkent@chromium.org>
1860
1861         Rename ENABLE_INPUT_TYPE_DATETIME
1862         https://bugs.webkit.org/show_bug.cgi?id=113254
1863
1864         Reviewed by Kentaro Hara.
1865
1866         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1867         Actually I'd like to remove the code, but we shouldn't remove it yet
1868         because we shipped products with it on some platforms.
1869
1870         * Scripts/webkitperl/FeatureList.pm:
1871         * qmake/mkspecs/features/features.pri:
1872
1873 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1874
1875         Remove one more line that was intended to be removed in r146657.
1876
1877         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1878         (summarize_results):
1879
1880 2013-03-25  Roger Fong  <roger_fong@apple.com>
1881
1882         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1883         Re-enable WinEWS tests.
1884
1885         * Scripts/webkitpy/common/config/ports.py:
1886         (WinPort.run_bindings_tests_command):
1887         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1888         (WinEWS):
1889
1890 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1891
1892         Unreviewed, rolling out r146793.
1893         http://trac.webkit.org/changeset/146793
1894         https://bugs.webkit.org/show_bug.cgi?id=113248
1895
1896         Fix did not work (Requested by rfong on #webkit).
1897
1898         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1899         (WinEWS):
1900
1901 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1902
1903         REGRESSION(r146657): Test failures reported incorrectly
1904         https://bugs.webkit.org/show_bug.cgi?id=113223
1905
1906         Reviewed by Dirk Pranke.
1907
1908         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1909
1910         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1911         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1912
1913         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1914         (Manager.run):
1915
1916         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1917         (RunDetails.__init__):
1918         (summarize_results): Remove the line I intended to remove in r146657.
1919
1920         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1921         (logging_run): Return details instead of the exit code.
1922         (run_and_capture): Ditto.
1923
1924         (RunTest.test_full_results_html):
1925         (RunTest.test_hung_thread):
1926         (RunTest.test_no_tests_found):
1927         (RunTest.test_no_tests_found_2):
1928         (RunTest.test_repeat_each_iterations_num_tests):
1929         (RunTest.test_run_singly_actually_runs_tests):
1930         (RunTest.test_test_list):
1931         (RunTest.test_missing_and_unexpected_results):
1932         (RunTest.test_pixel_test_directories):
1933         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1934         (RunTest.test_crash_with_stderr):
1935         (RunTest.test_no_image_failure_with_image_diff):
1936         (RunTest.test_crash_log):
1937         (RunTest.test_exit_after_n_failures_upload):
1938         (RunTest.test_results_directory_absolute):
1939         (RunTest.test_results_directory_relative):
1940         (RunTest.test_retrying_and_flaky_tests):
1941         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1942         (RunTest.test_retrying_uses_retries_directory):
1943         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1944         (RunTest.test_output_diffs):
1945         (EndToEndTest.test_reftest_with_two_notrefs):
1946         (RebaselineTest.test_reset_results):
1947         (RebaselineTest.test_missing_results):
1948         (RebaselineTest.test_new_baseline):
1949
1950         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1951         (BuildBotPrinter.print_results):
1952         (BuildBotPrinter.print_unexpected_results):
1953         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1954         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1955
1956 2013-03-25  Julie Parent  <jparent@chromium.org>
1957
1958         Dashboard refactor: Move cross dashboard history related code into history.js.
1959         https://bugs.webkit.org/show_bug.cgi?id=113104
1960
1961         Reviewed by Ojan Vafai.
1962
1963         All functions relating to cross dashboard behavior move from being
1964         globals to methods on the history.History object. Names stay the same,
1965         except many are made private, ones that should have been constants now
1966         are, and the long standing TODO to change "currentState" to 
1967         dashboardSpecificState is done.
1968         
1969         We now create a global history object in dashboard_base, as an 
1970         intermediate measure.  Once the dashboard specific code is
1971         added to history, each DB will need to create its own, and this
1972         global will be eliminated.
1973         
1974         * TestResultServer/static-dashboards/aggregate_results.js:
1975         (handleValidHashParameter):
1976         (htmlForBuilder):
1977         (rawValuesHTML):
1978         * TestResultServer/static-dashboards/dashboard_base.js:
1979         (parseDashboardSpecificParameters):
1980         (defaultValue):
1981         (currentBuilderGroupCategory):
1982         (currentBuilderGroupName):
1983         (handleLocationChange):
1984         (expectationsMap):
1985         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1986         (generatePage):
1987         (.switch.return):
1988         (platformAndBuildType):
1989         (individualTests):
1990         (substringList):
1991         (processMissingAndExtraExpectations):
1992         (pathToFailureLog):
1993         (showPopupForBuild):
1994         (htmlForTestsWithExpectationsButNoFailures):
1995         (shouldHideTest):
1996         (isCrossBuilderView):
1997         (tableHeaders):
1998         (htmlForSingleTestRow):
1999         (htmlForTableColumnHeader):
2000         (generatePageForExpectationsUpdate):
2001         (handleUpdate):
2002         (nextUpdate):
2003         (setUpdateIndex):
2004         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2005         (.appendExpectationsItem):
2006         (loadExpectations):
2007         (.dummyNode.onload):
2008         (loadExpectationsLayoutTests):
2009         (appendExpectations):
2010         (htmlForNavBar):
2011         (checkBoxToToggleState):
2012         (linkHTMLToToggleState):
2013         (generatePageForBuilder):
2014         (isInvalidKeyForCrossBuilderView):
2015         (handleQueryParameterChange):
2016         (showLegend):
2017         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2018         (resetGlobals):
2019         (test):
2020         * TestResultServer/static-dashboards/history.js:
2021         (.):
2022         * TestResultServer/static-dashboards/history_unittests.js:
2023         * TestResultServer/static-dashboards/loader.js:
2024         (.):
2025         * TestResultServer/static-dashboards/loader_unittests.js:
2026         * TestResultServer/static-dashboards/timeline_explorer.js:
2027         (generatePage):
2028         (initCurrentBuilderTestResults):
2029         (selectBuild):
2030         (showResultsDelta):
2031         * TestResultServer/static-dashboards/treemap.js:
2032         (generatePage):
2033         (.switch.return):
2034         (handleFocus):
2035         * TestResultServer/static-dashboards/ui.js:
2036
2037 2013-03-25  Roger Fong  <roger_fong@apple.com>
2038
2039         Unreviewed. Enable WinEWS tests again.
2040
2041         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2042         (WinEWS):
2043
2044 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2045
2046         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2047         https://bugs.webkit.org/show_bug.cgi?id=112166
2048
2049         HarfBuzz 0.9.14 merged my patch for icu detection without
2050         pkg-config files, as needed by for example Ubuntu 12.04.
2051         This obsoletes our local workaround. Removed it for GTK and EFL.
2052
2053         Reviewed by Martin Robinson.
2054
2055         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2056         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2057         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2058         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2059
2060 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2061
2062         Unreviewed.  Move self from contributor to committer list.
2063
2064         * Scripts/webkitpy/common/config/committers.py:
2065
2066 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2067
2068         EWS should use a human readable port name when uploading layout test archives
2069         https://bugs.webkit.org/show_bug.cgi?id=113099
2070
2071         Reviewed by Dirk Pranke.
2072
2073         Use new port's object's name() method to report human readable port names.
2074         This will also help us resolving the bug to apply layout test results posted by EWS.
2075
2076         * Scripts/webkitpy/tool/bot/botinfo.py:
2077         (BotInfo.__init__): Take port's name.
2078         (BotInfo.summary_text):
2079
2080         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2081         (BotInfoTest.test_summary_text):
2082
2083         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2084         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2085
2086         * Scripts/webkitpy/tool/commands/queues.py:
2087         (PatchProcessingQueue.__init__): Initialize self._port.
2088         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2089         and use that for the attachment filename and the comment posted.
2090
2091         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2092         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2093         "mac-snowleopard" as expected for TestPort.
2094
2095 2013-03-22  Roger Fong  <roger_fong@apple.com>
2096
2097         Unreviewed. Turn off EWS test on Win again.
2098         The battle continues.
2099
2100         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2101         (WinEWS):
2102
2103 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2104
2105         NRWT: Enable pixel tests when retrying tests
2106         https://bugs.webkit.org/show_bug.cgi?id=112898
2107
2108         Reviewed by Dirk Pranke.
2109
2110         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2111         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2112         if we've forced pixel tests in the retry.
2113         (Manager._run_tests):
2114         (Manager._clean_up_run): Fixed the capitalizations.
2115         (Manager._force_pixel_tests_if_needed): Added.
2116
2117         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2118         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2119         'image_diff_percent' if it doesn't already exist.
2120
2121         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2122         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2123         treat this as a regular regression instead of a flakiness.
2124
2125         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2126         run had image diffs.
2127
2128         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2129         (summarized_results):
2130
2131         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2132         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2133         Also removed some dead code.
2134
2135         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2136         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2137         is set and pixel_tests_enabled is set to false.
2138         (EndToEndTest.test_reftest_with_two_notrefs):
2139
2140 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2141
2142         Make it possible to run layout tests on Retina MBP
2143         https://bugs.webkit.org/show_bug.cgi?id=93673
2144
2145         Reviewed by Ryosuke Niwa.
2146
2147         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2148         windows on 2x machines still run at 1x.
2149
2150         * DumpRenderTree/mac/DumpRenderTree.mm:
2151         (createWebViewAndOffscreenWindow):
2152         Reset the window resolution to 1x on creation.
2153         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2154         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2155         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2156         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2157         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2158         (WTR::PlatformWebView::PlatformWebView):
2159         Add NSWindow details, reset the window resolution to 1x on creation.
2160
2161 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2162
2163         Leak bots shouldn't build
2164         https://bugs.webkit.org/show_bug.cgi?id=112774
2165
2166         Reviewed by Simon Fraser.
2167
2168         Since leak bots use regular debug builds, there is no need to build on these bots.
2169         Simply downloading builds will dramatically improve the cycle time of these bots.
2170
2171         * BuildSlaveSupport/build.webkit.org-config/config.json:
2172         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2173         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2174         TestFactory instead of BuildAndTestFactory.
2175
2176 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2177
2178         [Qt] Fix the TestWebKitAPI build
2179         https://bugs.webkit.org/show_bug.cgi?id=113044
2180
2181         Reviewed by Tor Arne Vestbø.
2182
2183         The generate-forwarding-headers script would only be run
2184         after the targets in InjectedBundle.pri since the second
2185         addStrictSubdirOrderBetween call in
2186         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2187         the derived_sources -> injected_bundle order in SUBDIRS.
2188
2189         Fix it by only moving the dependent target at the end of
2190         SUBDIRS, don't touch its dependency.
2191
2192         * qmake/mkspecs/features/functions.prf:
2193
2194 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2195
2196         [EFL][WK2] View is not focused when fullscreen mode toggled
2197         https://bugs.webkit.org/show_bug.cgi?id=113009
2198
2199         Reviewed by Laszlo Gombos.
2200
2201         Set focus on view when fullscreen mode enabled/disabled
2202         by FullScreen API.
2203
2204         * MiniBrowser/efl/main.c:
2205         (on_fullscreen_accept):
2206         (on_fullscreen_deny):
2207
2208 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2209
2210         nrwt is no longer saving retry results in the retries/ subdirectory
2211         https://bugs.webkit.org/show_bug.cgi?id=112995
2212
2213         Reviewed by Ojan Vafai.
2214
2215         I think this has been broken a long time, unfortunately. This
2216         patch should fix that.
2217
2218         In order to do so, I had to pass the directory to use from
2219         the Worker object through the SingleTestWriter to the
2220         TestResultWriter. While I was plumbing that through, I rationalized
2221         the order of the parameter arguments a bit ...
2222
2223         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2224         (Worker._run_single_test):
2225         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2226         (run_single_test):
2227         (SingleTestRunner.__init__):
2228         (SingleTestRunner._run_compare_test):
2229         (SingleTestRunner._run_rebaseline):
2230         (SingleTestRunner._run_reftest):
2231         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2232         (write_test_result):
2233         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2234         (TestResultWriterTest.test_reftest_diff_image):
2235         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2236         (RunTest.test_retrying_uses_retries_directory):
2237
2238 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2239
2240         JSC profiler should have an at-a-glance report of the success of DFG optimization
2241         https://bugs.webkit.org/show_bug.cgi?id=112988
2242
2243         Reviewed by Geoffrey Garen.
2244
2245         * Scripts/display-profiler-output:
2246
2247 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2248
2249         [chromium] Linux ASAN WebKit canary is running out of memory
2250         https://bugs.webkit.org/show_bug.cgi?id=112978
2251
2252         Reviewed by Tony Chang.
2253
2254         Running the AddressSanitizer on a crash takes a lot of
2255         memory, so we should serialize access to it to avoid running
2256         out of memory on a machine.
2257
2258         * Scripts/webkitpy/layout_tests/port/chromium.py:
2259         (ChromiumPort._get_crash_log):
2260         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2261         (HttpLock.__init__):
2262         (HttpLock.wait_for_httpd_lock):
2263
2264 2013-03-21  Min Qin  <qinmin@chromium.org>
2265
2266         Cleanup android media layout test code
2267         https://bugs.webkit.org/show_bug.cgi?id=112944
2268
2269         Reviewed by Adam Barth.
2270
2271         Chromium change: https://codereview.chromium.org/12892010/
2272         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2273         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2274         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2275         Instead, we should switch to use content shell for layout tests.
2276
2277         * DumpRenderTree/chromium/TestShell.cpp:
2278         (TestShell::resetTestController):
2279
2280 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2281
2282         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2283         https://bugs.webkit.org/show_bug.cgi?id=112953
2284
2285         Reviewed by Tony Chang.
2286
2287         When I created the DumpRenderTree_resources target in r144863 I
2288         forgot to declare the needed dependencies on the other resource
2289         targets. Due to a quirk of ordering, this appears to have been fine
2290         w/ ninja but not w/ Xcode (which is still being used on the chromium
2291         mac valgrind bots). Declaring the dependencies fixes the build
2292         failures.
2293
2294         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2295
2296 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2297
2298         [WinCairo] Correct assert in Empty BitmapImage Test.
2299         https://bugs.webkit.org/show_bug.cgi?id=112934
2300
2301         Reviewed by Tim Horton.
2302
2303         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2304         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2305         to avoid ref counting assertion when leaving test scope.
2306
2307 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2308
2309         [GTK] generate-feature-defines-files is incompatible with Python3
2310         https://bugs.webkit.org/show_bug.cgi?id=112956
2311
2312         Reviewed by Martin Robinson.
2313
2314         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2315         method on the dictionary objects when iterating through said dictionaries.
2316
2317         * gtk/generate-feature-defines-files:
2318         (write_feature_defines_header):
2319         (write_flattened_feature_defines_file):
2320
2321 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2322
2323         kill-old-processes spits out error messages on Mac
2324         https://bugs.webkit.org/show_bug.cgi?id=112878
2325
2326         Reviewed by Jessie Berlin.
2327
2328         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2329         included in the list of options grep --help shows.
2330
2331         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2332
2333         * BuildSlaveSupport/kill-old-processes:
2334         (main):
2335
2336 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2337
2338         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2339         https://bugs.webkit.org/show_bug.cgi?id=112597
2340
2341         Reviewed by Xan Lopez.
2342
2343         These were introduced for the Chromium port in r105295. We need
2344         dummy implementations in order to compile the BlackBerry port.
2345
2346         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2347         (AccessibilityUIElement::scrollToMakeVisible):
2348         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2349         (AccessibilityUIElement::scrollToGlobalPoint):
2350
2351 2013-03-21  Roger Fong  <roger_fong@apple.com>
2352
2353         Re-enable WinEWS tests following r146376.
2354
2355         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2356         (WinEWS):
2357
2358 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2359
2360         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2361
2362         * Scripts/webkitpy/common/config/committers.py:
2363
2364 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2365
2366         [GTK] Missing atk in install-dependencies script
2367         https://bugs.webkit.org/show_bug.cgi?id=112272
2368
2369         Reviewed by Gustavo Noronha Silva.
2370
2371         * gtk/install-dependencies: Add missing atk dependency.
2372
2373 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2374
2375         [GTK] Missing backslash in install-dependencies script
2376         https://bugs.webkit.org/show_bug.cgi?id=112907
2377
2378         Reviewed by Philippe Normand.
2379
2380         * gtk/install-dependencies: Add missing backslash to dependencies
2381         list.
2382
2383 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2384
2385         EWS bots have stopped uploading results to bugzilla
2386         https://bugs.webkit.org/show_bug.cgi?id=101091
2387
2388         Reviewed by Adam Barth.
2389
2390         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2391         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2392         this relative file path resoled to a file inside a non-existent directory for "zip".
2393
2394         Fixed the bug by resolving both test results directory and zip archive paths in
2395         LayoutTestResultsReader.archive.
2396
2397         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2398         in the future.
2399
2400         * Scripts/webkitpy/common/system/filesystem_mock.py:
2401         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2402
2403         * Scripts/webkitpy/common/system/workspace.py:
2404         (Workspace.create_zip): Log the source path when "zip" failed.
2405
2406         * Scripts/webkitpy/common/system/workspace_mock.py:
2407         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2408
2409         * Scripts/webkitpy/common/system/workspace_unittest.py:
2410         (WorkspaceTest.test_create_zip_exception): Test that.
2411
2412         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2413         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2414         This is the actual bug fix.
2415
2416         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2417         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2418
2419 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2420
2421         [chromium] move WebThemeEngine implementations to TestRunner library
2422         https://bugs.webkit.org/show_bug.cgi?id=112751
2423
2424         Reviewed by Adam Barth.
2425
2426         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2427         * DumpRenderTree/DumpRenderTree.gypi:
2428         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2429         (WebKit):
2430         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2431         (WebTestRunner::TestInterfaces::themeEngine):
2432         (WebTestRunner):
2433         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2434         (WebKit):
2435         (TestInterfaces):
2436         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2437         (WebTestRunner::WebTestInterfaces::themeEngine):
2438         (WebTestRunner):
2439         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2440         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2441         (WebTestRunner):
2442         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2443         (WebTestRunner::WebTestThemeControlWin::box):
2444         (WebTestRunner::WebTestThemeControlWin::line):
2445         (WebTestRunner::WebTestThemeControlWin::triangle):
2446         (WebTestRunner::WebTestThemeControlWin::roundRect):
2447         (WebTestRunner::WebTestThemeControlWin::oval):
2448         (WebTestRunner::WebTestThemeControlWin::circle):
2449         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2450         (WebTestRunner::WebTestThemeControlWin::markState):
2451         (WebTestRunner::WebTestThemeControlWin::draw):
2452         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2453         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2454         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2455         (WebTestRunner):
2456         (WebTestThemeControlWin):
2457         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2458         (WebTestRunner):
2459         (WebTestThemeEngineMac):
2460         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2461         (+[FakeActiveWindow alwaysActiveWindow]):
2462         (+[FakeActiveWindow alwaysInactiveWindow]):
2463         (-[FakeActiveWindow initWithActiveControls:]):
2464         (-[FakeActiveWindow _hasActiveControls]):
2465         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2466         (WebTestRunner):
2467         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2468         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2469         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2470         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2471         (WebTestRunner):
2472         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2473         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2474         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2475         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2476         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2477         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2478         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2479         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2480         (WebTestRunner::WebTestThemeEngineWin::getSize):
2481         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2482         (WebTestRunner):
2483         (WebTestThemeEngineWin):
2484         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2485         * DumpRenderTree/chromium/TestShell.cpp:
2486         (TestShell::initialize):
2487         * DumpRenderTree/chromium/TestShell.h:
2488         (WebKit):
2489         * DumpRenderTree/chromium/TestShellMac.mm:
2490         (platformInit):
2491         * DumpRenderTree/chromium/TestShellWin.cpp:
2492         (platformInit):
2493         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2494
2495 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2496
2497         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2498
2499         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2500         New property sheet that does not link against CoreFoundation and
2501         CFNetwork.
2502         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2503         Use new TestWebKitAPICommonWinCairo property sheet.
2504         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2505         Ditto.
2506
2507 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2508
2509         [WinCairo] Unreviewed build fix for VS2010.
2510
2511         Had to add WinCairo-specific property sheets to deal with some
2512         library and path differences with the main Apple port.
2513
2514         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2515         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2516         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2517         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2518         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2519         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2520
2521 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2522
2523         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2524         https://bugs.webkit.org/show_bug.cgi?id=112849
2525
2526         Reviewed by Sam Weinig.
2527
2528         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2530         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2531
2532 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2533
2534         [WinCairo] Build WebKit Tools under VS2010
2535         https://bugs.webkit.org/show_bug.cgi?id=112821
2536
2537         Reviewed by Tim Horton.
2538
2539         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2540         Add WinCairo-specific build target.
2541         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2542         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2543         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2544         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2545         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2546         Add WinCairo-specific build target.
2547         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2548         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2549         Add WinCairo-specific build target.
2550         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2551         WinCairo-specific build target.
2552         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2553         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2554         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2555         specific build target.
2556         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2557         WinCairo-specific build target.
2558         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2559         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2560         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2561
2562 2013-03-20  Roger Fong  <roger_fong@apple.com>
2563
2564         API test gardening AppleWin port.
2565
2566         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2567
2568         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2569         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2570
2571 2013-03-20  Roger Fong  <roger_fong@apple.com>
2572
2573         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2574
2575         * EWSTools/start-queue-win.sh:
2576
2577 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2578
2579         Unreviewed, add myself to committers.py.
2580
2581 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2582
2583         Unreviewed. Adding another email for me.
2584
2585         * Scripts/webkitpy/common/config/committers.py:
2586
2587 2013-03-20  Justin Novosad  <junov@google.com>
2588
2589         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2590         https://bugs.webkit.org/show_bug.cgi?id=112605
2591
2592         Reviewed by James Robinson.
2593
2594         Deleting all the code that was used for propagating and supporting
2595         the Chromium setting for disabling deferred 2d canvas rendering.
2596
2597         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2598         (main):
2599         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2600         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2601         (WebTestRunner::WebPreferences::reset):
2602         (WebTestRunner::WebPreferences::applyTo):
2603         * DumpRenderTree/chromium/TestShell.cpp:
2604         (TestShell::TestShell):
2605         (TestShell::resetWebSettings):
2606         (TestShell::runFileTest):
2607         * DumpRenderTree/chromium/TestShell.h:
2608         (TestShell):
2609
2610 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2611
2612         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2613         https://bugs.webkit.org/show_bug.cgi?id=112699.
2614
2615         Reviewed by Adam Barth.
2616
2617         * Scripts/webkitpy/layout_tests/port/qt.py:
2618         (QtPort._search_paths):
2619         (QtPort._port_specific_expectations_files):
2620         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2621         (QtPortTest):
2622         (QtPortTest._assert_search_path):
2623         (QtPortTest._assert_expectations_files):
2624
2625 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2626
2627         [Qt] Enable kerning by default
2628         https://bugs.webkit.org/show_bug.cgi?id=112704
2629
2630         Reviewed by Jocelyn Turcotte.
2631
2632         Disable kerning by default, since some reference test expectations
2633         expect kerning to be default off.
2634
2635         * DumpRenderTree/qt/TestRunnerQt.cpp:
2636         (TestRunnerQt::reset):
2637         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2638         (WTR::activateFonts):
2639
2640 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2641
2642         [Qt] Remove empty function stubs from TestRunnerQt.
2643         https://bugs.webkit.org/show_bug.cgi?id=112799
2644
2645         We are reducing the code in TestRunnerQt step by step,
2646         in order to finally replace all of it with the generic
2647         TestRunner implementation.
2648         This patch removes several simple function stubs that
2649         currently do not implement any actual functionality.
2650
2651         Reviewed by Kenneth Rohde Christiansen.
2652
2653         * DumpRenderTree/qt/TestRunnerQt.cpp:
2654         * DumpRenderTree/qt/TestRunnerQt.h:
2655         (TestRunnerQt):
2656
2657 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2658
2659         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2660         https://bugs.webkit.org/show_bug.cgi?id=112687
2661
2662         Reviewed by Kenneth Rohde Christiansen.
2663
2664         Hide the SearchBar by default on window creation.
2665
2666         * MiniBrowser/efl/main.c:
2667         (window_create):
2668
2669 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2670
2671         Unreviewed, rolling out r146304.
2672         http://trac.webkit.org/changeset/146304
2673         https://bugs.webkit.org/show_bug.cgi?id=112788
2674
2675         to many expectations to update (Requested by antonm on
2676         #webkit).
2677
2678         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2679         * DumpRenderTree/DumpRenderTree.gypi:
2680         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2681         (WebKit):
2682         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2683         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2684         (TestInterfaces):
2685         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2686         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2687         * DumpRenderTree/chromium/TestShell.cpp:
2688         (TestShell::initialize):
2689         * DumpRenderTree/chromium/TestShell.h:
2690         (WebKit):
2691         * DumpRenderTree/chromium/TestShellMac.mm:
2692         (platformInit):
2693         * DumpRenderTree/chromium/TestShellWin.cpp:
2694         (platformInit):
2695         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2696         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2697         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2698         (WebThemeControlDRTWin::box):
2699         (WebThemeControlDRTWin::line):
2700         (WebThemeControlDRTWin::triangle):
2701         (WebThemeControlDRTWin::roundRect):
2702         (WebThemeControlDRTWin::oval):
2703         (WebThemeControlDRTWin::circle):
2704         (WebThemeControlDRTWin::nestedBoxes):
2705         (WebThemeControlDRTWin::markState):
2706         (WebThemeControlDRTWin::draw):
2707         (WebThemeControlDRTWin::drawTextField):
2708         (WebThemeControlDRTWin::drawProgressBar):
2709         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2710         (WebThemeControlDRTWin):
2711         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2712         (WebThemeEngineDRTMac):
2713         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2714         (+[FakeActiveWindow alwaysActiveWindow]):
2715         (+[FakeActiveWindow alwaysInactiveWindow]):
2716         (-[FakeActiveWindow initWithActiveControls:]):
2717         (-[FakeActiveWindow _hasActiveControls]):
2718         (WebThemeEngineDRTMac::paintScrollbarThumb):
2719         (stateToHIEnableState):
2720         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2721         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2722         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2723         (webRectToSkIRect):
2724         (drawControl):
2725         (drawTextField):
2726         (drawProgressBar):
2727         (WebThemeEngineDRTWin::paintButton):
2728         (WebThemeEngineDRTWin::paintMenuList):
2729         (WebThemeEngineDRTWin::paintScrollbarArrow):
2730         (WebThemeEngineDRTWin::paintScrollbarThumb):
2731         (WebThemeEngineDRTWin::paintScrollbarTrack):
2732         (WebThemeEngineDRTWin::paintSpinButton):
2733         (WebThemeEngineDRTWin::paintTextField):
2734         (WebThemeEngineDRTWin::paintTrackbar):
2735         (WebThemeEngineDRTWin::paintProgressBar):
2736         (WebThemeEngineDRTWin::getSize):
2737         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2738         (WebThemeEngineDRTWin):
2739         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2740
2741 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2742
2743         [Qt] Support -webkit-font-smoothing
2744         https://bugs.webkit.org/show_bug.cgi?id=106009
2745
2746         Reviewed by Jocelyn Turcotte.
2747
2748         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2749
2750         * DumpRenderTree/qt/TestRunnerQt.cpp:
2751         (TestRunnerQt::reset):
2752
2753 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2754
2755         [GTK] accessibility/aria-scrollbar-role.html is failing
2756         https://bugs.webkit.org/show_bug.cgi?id=98358
2757
2758         Reviewed by Martin Robinson.
2759
2760         Adds support for checking accessibility object's orientation.
2761         Orientation is checked by retrieving proper state of accessibility object.
2762
2763         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2764         (checkElementState):
2765         (AccessibilityUIElement::orientation):
2766         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2767         (WTR::AccessibilityUIElement::orientation):
2768
2769 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2770
2771         [chromium] move WebThemeEngine implementations to TestRunner library
2772         https://bugs.webkit.org/show_bug.cgi?id=112751
2773
2774         Reviewed by Adam Barth.
2775
2776         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2777         * DumpRenderTree/DumpRenderTree.gypi:
2778         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2779         (WebKit):
2780         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2781         (WebTestRunner::TestInterfaces::themeEngine):
2782         (WebTestRunner):
2783         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2784         (WebKit):
2785         (TestInterfaces):
2786         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2787         (WebTestRunner::WebTestInterfaces::themeEngine):
2788         (WebTestRunner):
2789         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2790         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2791         (WebTestRunner):
2792         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2793         (WebTestRunner::WebTestThemeControlWin::box):
2794         (WebTestRunner::WebTestThemeControlWin::line):
2795         (WebTestRunner::WebTestThemeControlWin::triangle):
2796         (WebTestRunner::WebTestThemeControlWin::roundRect):
2797         (WebTestRunner::WebTestThemeControlWin::oval):
2798         (WebTestRunner::WebTestThemeControlWin::circle):
2799         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2800         (WebTestRunner::WebTestThemeControlWin::markState):
2801         (WebTestRunner::WebTestThemeControlWin::draw):
2802         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2803         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2804         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2805         (WebTestRunner):
2806         (WebTestThemeControlWin):
2807         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2808         (WebTestRunner):
2809         (WebTestThemeEngineMac):
2810         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2811         (+[FakeActiveWindow alwaysActiveWindow]):
2812         (+[FakeActiveWindow alwaysInactiveWindow]):
2813         (-[FakeActiveWindow initWithActiveControls:]):
2814         (-[FakeActiveWindow _hasActiveControls]):
2815         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2816         (WebTestRunner):
2817         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2818         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2819         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2820         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2821         (WebTestRunner):
2822         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2823         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2824         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2825         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2826         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2827         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2828         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2829         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2830         (WebTestRunner::WebTestThemeEngineWin::getSize):
2831         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2832         (WebTestRunner):
2833         (WebTestThemeEngineWin):
2834         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2835         * DumpRenderTree/chromium/TestShell.cpp:
2836         (TestShell::initialize):
2837         * DumpRenderTree/chromium/TestShell.h:
2838         (WebKit):
2839         * DumpRenderTree/chromium/TestShellMac.mm:
2840         (platformInit):
2841         * DumpRenderTree/chromium/TestShellWin.cpp:
2842         (platformInit):
2843         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2844
2845 2013-03-19  Tony Chang  <tony@chromium.org>
2846
2847         Move testRunner.setTouchDragDropEnabled to internals.settings
2848         https://bugs.webkit.org/show_bug.cgi?id=112739
2849
2850         Reviewed by Adam Barth.
2851
2852         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2853         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2854         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2855         (TestRunner): Remove unnecessary code.
2856         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2857         (WebTestRunner::WebPreferences::reset):
2858         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2859
2860 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2861
2862         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2863         https://bugs.webkit.org/show_bug.cgi?id=112754
2864
2865         Reviewed by Darin Fisher.
2866
2867         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2868         now that it's always defined.
2869
2870         * DumpRenderTree/chromium/WebViewHost.cpp:
2871         * DumpRenderTree/chromium/WebViewHost.h:
2872         (WebViewHost):
2873
2874 2013-03-19  Kenneth Russell  <kbr@google.com>
2875
2876         Unreviewed, rolling out r146290.
2877         http://trac.webkit.org/changeset/146290
2878         https://bugs.webkit.org/show_bug.cgi?id=112751
2879
2880         Broke Chromium Mac build.
2881
2882         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2883         * DumpRenderTree/DumpRenderTree.gypi:
2884         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2885         (WebKit):
2886         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2887         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2888         (TestInterfaces):
2889         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2890         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2891         * DumpRenderTree/chromium/TestShell.cpp:
2892         (TestShell::initialize):
2893         * DumpRenderTree/chromium/TestShell.h:
2894         (WebKit):
2895         * DumpRenderTree/chromium/TestShellMac.mm:
2896         (platformInit):
2897         * DumpRenderTree/chromium/TestShellWin.cpp:
2898         (platformInit):
2899         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2900         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2901         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2902         (WebThemeControlDRTWin::box):
2903         (WebThemeControlDRTWin::line):
2904         (WebThemeControlDRTWin::triangle):
2905         (WebThemeControlDRTWin::roundRect):
2906         (WebThemeControlDRTWin::oval):
2907         (WebThemeControlDRTWin::circle):
2908         (WebThemeControlDRTWin::nestedBoxes):
2909         (WebThemeControlDRTWin::markState):
2910         (WebThemeControlDRTWin::draw):
2911         (WebThemeControlDRTWin::drawTextField):
2912         (WebThemeControlDRTWin::drawProgressBar):
2913         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2914         (WebThemeControlDRTWin):
2915         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2916         (WebThemeEngineDRTMac):
2917         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2918         (+[FakeActiveWindow alwaysActiveWindow]):
2919         (+[FakeActiveWindow alwaysInactiveWindow]):
2920         (-[FakeActiveWindow initWithActiveControls:]):
2921         (-[FakeActiveWindow _hasActiveControls]):
2922         (WebThemeEngineDRTMac::paintScrollbarThumb):
2923         (stateToHIEnableState):
2924         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2925         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2926         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2927         (webRectToSkIRect):
2928         (drawControl):
2929         (drawTextField):
2930         (drawProgressBar):
2931         (WebThemeEngineDRTWin::paintButton):
2932         (WebThemeEngineDRTWin::paintMenuList):
2933         (WebThemeEngineDRTWin::paintScrollbarArrow):
2934         (WebThemeEngineDRTWin::paintScrollbarThumb):
2935         (WebThemeEngineDRTWin::paintScrollbarTrack):
2936         (WebThemeEngineDRTWin::paintSpinButton):
2937         (WebThemeEngineDRTWin::paintTextField):
2938         (WebThemeEngineDRTWin::paintTrackbar):
2939         (WebThemeEngineDRTWin::paintProgressBar):
2940         (WebThemeEngineDRTWin::getSize):
2941         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2942         (WebThemeEngineDRTWin):
2943         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2944
2945 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2946
2947         [EFL] canvas-fallback-content.html is failing
2948         https://bugs.webkit.org/show_bug.cgi?id=111998
2949
2950         Reviewed by Chris Fleizach.
2951
2952         Adds support for getting platform name.
2953
2954         * DumpRenderTree/TestRunner.cpp:
2955         (TestRunner::staticValues):
2956         * DumpRenderTree/TestRunner.h:
2957         (TestRunner):
2958         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2959         (TestRunner::platformName):
2960
2961 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2962
2963         [chromium] move WebThemeEngine implementations to TestRunner library
2964         https://bugs.webkit.org/show_bug.cgi?id=112751
2965
2966         Reviewed by Adam Barth.
2967
2968         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2969         * DumpRenderTree/DumpRenderTree.gypi:
2970         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2971         (WebKit):
2972         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2973         (WebTestRunner::TestInterfaces::themeEngine):
2974         (WebTestRunner):
2975         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2976         (WebKit):
2977         (TestInterfaces):
2978         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2979         (WebTestRunner::WebTestInterfaces::themeEngine):
2980         (WebTestRunner):
2981         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2982         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2983         (WebTestRunner):
2984         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2985         (WebTestRunner::WebTestThemeControlWin::box):
2986         (WebTestRunner::WebTestThemeControlWin::line):
2987         (WebTestRunner::WebTestThemeControlWin::triangle):
2988         (WebTestRunner::WebTestThemeControlWin::roundRect):
2989         (WebTestRunner::WebTestThemeControlWin::oval):
2990         (WebTestRunner::WebTestThemeControlWin::circle):
2991         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2992         (WebTestRunner::WebTestThemeControlWin::markState):
2993         (WebTestRunner::WebTestThemeControlWin::draw):
2994         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2995         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2996         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2997         (WebTestRunner):
2998         (WebTestThemeControlWin):
2999         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3000         (WebTestRunner):
3001         (WebTestThemeEngineMac):
3002         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3003         (+[FakeActiveWindow alwaysActiveWindow]):
3004         (+[FakeActiveWindow alwaysInactiveWindow]):
3005         (-[FakeActiveWindow initWithActiveControls:]):
3006         (-[FakeActiveWindow _hasActiveControls]):
3007         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3008         (WebTestRunner):
3009         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3010         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3011         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3012         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3013         (WebTestRunner):
3014         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3015         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3016         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3017         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3018         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3019         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3020         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3021         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3022         (WebTestRunner::WebTestThemeEngineWin::getSize):
3023         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3024         (WebTestRunner):
3025         (WebTestThemeEngineWin):
3026         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3027         * DumpRenderTree/chromium/TestShell.cpp:
3028         (TestShell::initialize):
3029         * DumpRenderTree/chromium/TestShell.h:
3030         (WebKit):
3031         * DumpRenderTree/chromium/TestShellMac.mm:
3032         (platformInit):
3033         * DumpRenderTree/chromium/TestShellWin.cpp:
3034         (platformInit):
3035         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3036
3037 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3038
3039         [EFL][WK2] Separate WebView further from EwkView
3040         https://bugs.webkit.org/show_bug.cgi?id=111591
3041
3042         Reviewed by Caio Marcelo de Oliveira Filho.
3043
3044         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3045         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3046         since we can afford it having EWKViewGetWKView() private API to access WKView.
3047
3048         * TestWebKitAPI/PlatformWebView.h:
3049         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3050         (TestWebKitAPI::TEST):
3051         * TestWebKitAPI/efl/PlatformWebView.cpp:
3052         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3053         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3054         (TestWebKitAPI::PlatformWebView::resizeTo):
3055         (TestWebKitAPI::PlatformWebView::page):
3056         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3057         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3058         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3059         * WebKitTestRunner/PlatformWebView.h:
3060         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3061         (WTR::EventSenderProxy::dispatchEvent):
3062         (WTR::EventSenderProxy::keyDown):
3063         (WTR::EventSenderProxy::sendTouchEvent):
3064         (WTR::EventSenderProxy::setTouchModifier):
3065         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3066         (WTR::PlatformWebView::PlatformWebView):
3067         (WTR::PlatformWebView::~PlatformWebView):
3068         (WTR::PlatformWebView::resizeTo):
3069         (WTR::PlatformWebView::page):
3070         (WTR::PlatformWebView::focus):
3071         (WTR::PlatformWebView::windowSnapshotImage):
3072
3073 2013-03-19  Roger Fong  <roger_fong@apple.com>
3074
3075         Changes to VS2010 project files should only trigger builds on Windows bots.
3076         https://bugs.webkit.org/show_bug.cgi?id=112731
3077
3078         Reviewed by Timothy Horton.
3079
3080         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3081         (_should_file_trigger_build):
3082
3083 2013-03-19  Roger Fong  <roger_fong@apple.com>
3084
3085         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3086
3087         * Scripts/webkitpy/tool/steps/runtests.py:
3088         (RunTests.run):
3089         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3090         (RunTestsTest.test_webkit_run_unit_tests):
3091
3092 2013-03-19  Julie Parent  <jparent@chromium.org>
3093
3094         Dashboards: Introduce history namespace and unit tests.
3095         https://bugs.webkit.org/show_bug.cgi?id=112645
3096
3097         Reviewed by Ojan Vafai.
3098         
3099         Laying the framework for introducing the new history object and
3100         namespace.  This moves only static functions into the history
3101         namespace, and moves corresponding unit tests into seperate
3102         unit test file.
3103
3104         * TestResultServer/static-dashboards/aggregate_results.html:
3105         * TestResultServer/static-dashboards/dashboard_base.js:
3106         (parseCrossDashboardParameters):
3107         (parseDashboardSpecificParameters):
3108         (parseParameters):
3109         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3110         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3111         (.switch.return):
3112         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3113         * TestResultServer/static-dashboards/history.js: Added.
3114         * TestResultServer/static-dashboards/history_unittests.js: Added.
3115         * TestResultServer/static-dashboards/loader.js:
3116         (.):
3117         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3118         * TestResultServer/static-dashboards/run-unittests.html:
3119         * TestResultServer/static-dashboards/timeline_explorer.html:
3120         * TestResultServer/static-dashboards/timeline_explorer.js:
3121         * TestResultServer/static-dashboards/treemap.html:
3122         * TestResultServer/static-dashboards/treemap.js:
3123         (.switch.return):
3124         * TestResultServer/static-dashboards/ui.js:
3125
3126 2013-03-19  Daniel Bates  <dbates@webkit.org>
3127
3128         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3129         https://bugs.webkit.org/show_bug.cgi?id=112732
3130
3131         Reviewed by Eric Seidel.
3132
3133         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3134         of an existing file cannot be applied.
3135
3136         In particular, svn-{apply, unapply} compensate for differences in line endings
3137         by converting the line endings in a diff to match the line endings in the target
3138         file. The diff(1) command precedes the last line of a diff that adds a newline
3139         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3140         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3141         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3142         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3143         the newline characters in this special character sequence to match the line endings
3144         in the target file.
3145
3146         * Scripts/VCSUtils.pm:
3147         (parseDiff):
3148         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3149         Added tests:
3150             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3151             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3152             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3153             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3154         (escapeNewLineCharacters): Added.
3155         (toMacLineEndings): Added.
3156
3157 2013-03-19  James Robinson  <jamesr@chromium.org>
3158
3159         [chromium] Remove compositor settings that don't go through WebKit
3160         https://bugs.webkit.org/show_bug.cgi?id=112718
3161
3162         Reviewed by Adam Barth.
3163
3164         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3165         (main):
3166         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3167         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3168         (WebTestRunner::WebPreferences::reset):
3169         (WebTestRunner::WebPreferences::applyTo):
3170         * DumpRenderTree/chromium/TestShell.cpp:
3171         (TestShell::TestShell):
3172         (TestShell::resetWebSettings):
3173         * DumpRenderTree/chromium/TestShell.h:
3174         (TestShell):
3175
3176 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3177
3178         Unreviewed, rolling out r146101.
3179         https://bugs.webkit.org/show_bug.cgi?id=111884
3180
3181         re-enable custom freetype on asan; this needs to be on
3182         now that the bot is running lucid.
3183
3184         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3185
3186 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3187
3188         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3189         https://bugs.webkit.org/show_bug.cgi?id=112365
3190
3191         Reviewed by Benjamin Poulain.
3192
3193         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3194         harcoding it in wtf/Platform.h
3195
3196         * Scripts/webkitperl/FeatureList.pm:
3197
3198 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3199
3200         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3201         https://bugs.webkit.org/show_bug.cgi?id=94782
3202
3203         Based on patch by Csaba Osztrogonác.
3204         Reviewed by Jocelyn Turcotte.
3205
3206         The diff image is generated with bright red indicating errors, but letting the base image
3207         shine through so the context of the error-pixel can be identified.
3208
3209         * DumpRenderTree/qt/ImageDiff.cpp:
3210         (main):
3211
3212 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3213
3214         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3215
3216         Rubber-stamped by Csaba Osztrogonác.
3217
3218         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3219         since the latter might not cover the former.
3220
3221         * QtTestBrowser/launcherwindow.cpp:
3222         (LauncherWindow::print):
3223
3224 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3225
3226         Style tweeks to default.css.
3227         
3228         Rubber-stamped by David Kilzer.
3229         
3230         Give visited links a different color to other links, so you can
3231         see which builds you've viewed.
3232         
3233         Make the <small> text less tiny.
3234
3235         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3236         (small):
3237         (a:link,a:visited,a:active):
3238         (a:visited):
3239
3240 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3241
3242         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3243         https://bugs.webkit.org/show_bug.cgi?id=112494
3244
3245         Reviewed by Dirk Pranke.
3246
3247         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3248         Also merged two pairs of methods to cleanup the code.
3249
3250         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3251         (PerfTestsRunner.run): Merged _upload_and_show_results.
3252         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3253
3254 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3255
3256         [chromium] build xdisplaycheck when building DRT
3257         https://bugs.webkit.org/show_bug.cgi?id=112636
3258
3259         Reviewed by Tony Chang.
3260
3261         It appears that we need xdisplaycheck to be built in order for
3262         Xvfb to be started correctly on the bots, and DRT was missing
3263         a dependency on it. This may be the cause of the ASAN bot not
3264         starting up properly (it only builds DRT).
3265
3266         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3267
3268 2013-03-18  David Levin  <levin@chromium.org>
3269
3270         Implement icon change notification dump for Chromium's test shell.
3271         https://bugs.webkit.org/show_bug.cgi?id=112614
3272
3273         This was previously implemented for some other platforms in r58111
3274         and r116547.
3275
3276         In r122806, fast/dom/icon-url-property.html stopped using it, but
3277         it is useful for tests, so I plan to re-add it to that test again.
3278
3279         Reviewed by Jochen Eisinger.
3280
3281         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3282         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3283          icon change notifications from WebKit may be logged in test output.
3284         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3285         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3286         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3287         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3288         (WebTestRunner):
3289         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3290         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3291         (TestRunner):
3292         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3293         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3294         (WebTestRunner):
3295         * DumpRenderTree/chromium/WebViewHost.cpp:
3296         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3297         * DumpRenderTree/chromium/WebViewHost.h:
3298         (WebViewHost):
3299
3300 2013-03-18  Julie Parent  <jparent@chromium.org>
3301
3302         Cleanup: Move js for treemap and aggregate_results into own js files.
3303         https://bugs.webkit.org/show_bug.cgi?id=112618
3304
3305         Reviewed by Dirk Pranke.
3306         
3307         No functional changes, just moving the code into separate js file
3308         rather than inlined in the html, so we can test it, make it more
3309         modular, etc.  Other dashboard types are already done this way.
3310
3311         * TestResultServer/static-dashboards/aggregate_results.html:
3312         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3313         (generatePage):
3314         (handleValidHashParameter):
3315         (htmlForBuilder):
3316         (rawValuesHTML):
3317         (chartHTML):
3318         (filteredValues):
3319         (chart):
3320         (htmlForRevisionRows):
3321         (wrapHTMLInTable):
3322         (htmlForSummaryTable):
3323         (valuesPerExpectation):
3324         (htmlForTestType):
3325         (htmlForTableRow):
3326         (extendedEncode):
3327         * TestResultServer/static-dashboards/treemap.html:
3328         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3329         (humanReadableTime):
3330         (convertToWebTreemapFormat):
3331         (reverseSortByAverage):
3332         (generatePage):
3333         (focusPath):
3334         (.switch.return):
3335         (handleQueryParameterChange):
3336         (extractName):
3337         (fullName):
3338         (handleFocus.):
3339         (handleFocus):
3340
3341 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3342
3343         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3344         https://bugs.webkit.org/show_bug.cgi?id=112622
3345
3346         Reviewed by Dirk Pranke.
3347
3348         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3349         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3350
3351 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3352
3353         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3354         https://bugs.webkit.org/show_bug.cgi?id=112619
3355
3356         Reviewed by Dirk Pranke.
3357
3358         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3359         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3360
3361         * Scripts/webkitpy/layout_tests/port/gtk.py:
3362         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3363         Port._webkit_baseline_path method.
3364         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3365         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3366         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3367         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3368         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3369         that are expected based on the builder name.
3370
3371 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3372
3373         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3374         https://bugs.webkit.org/show_bug.cgi?id=112571
3375
3376         Reviewed by Adam Barth.
3377
3378         Update function declarations for new WebFileSystemType enum. (All
3379         changes are behind an #ifdef so we can sync required changes in embedders.)
3380
3381         * DumpRenderTree/chromium/WebViewHost.cpp:
3382         (WebViewHost::openFileSystem):
3383         (WebViewHost::deleteFileSystem):
3384         * DumpRenderTree/chromium/WebViewHost.h:
3385         (WebViewHost):
3386
3387 2013-03-18  Julie Parent  <jparent@chromium.org>
3388
3389         Cleanup: Move timeline_exporer js out of html file into js.
3390         https://bugs.webkit.org/show_bug.cgi?id=112188
3391
3392         Reviewed by Dirk Pranke.
3393         
3394         Moves the javascript out of the html file and into a new js file.
3395         This follows the format of flakiness_dashboard.{html|js}.
3396         
3397         Also moves code from dashboard_base that is used only by this one
3398         dashboard, and makes it private to the dashboard.
3399
3400         * TestResultServer/static-dashboards/dashboard_base.js:
3401         * TestResultServer/static-dashboards/timeline_explorer.html:
3402         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3403         (generatePage):
3404         (initCurrentBuilderTestResults):
3405         (shouldShowWebKitRevisionsOnly):
3406         (updateTimelineForBuilder.):
3407         (updateTimelineForBuilder):
3408         (selectBuild):
3409         (updateBuildIndicator):
3410         (.addRow):
3411         (.addNumberRow):
3412         (.inspectorNode.getElementsByTagName.0.onclick):
3413         (.inspectorNode.getElementsByTagName.1.onclick):
3414         (.inspectorNode.getElementsByTagName.2.onclick):
3415         (updateBuildInspector):
3416         (showResultsDelta):
3417         (decompressResults.addFlakyDelta):
3418         (decompressResults):
3419
3420 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3421
3422         Unreviewed, rolling out r145272.
3423         http://trac.webkit.org/changeset/145272
3424         https://bugs.webkit.org/show_bug.cgi?id=111884
3425
3426         Turns out the ASAN build is still broken; possibly there's
3427         something still setting LD_LIBRARY_PATH, or possibly there's
3428         something else wrong. In the meantime, we need it to work again.
3429
3430         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3431
3432 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3433
3434         delete-stale-build-files is too aggressive
3435         https://bugs.webkit.org/show_bug.cgi?id=112595
3436
3437         Reviewed by Tim Horton.
3438
3439         It appears that whitelisting file extensions to keep is not a good idea.
3440         Blacklist files to delete instead, and only delete .o files for now.
3441         We can add more file extensions as needed.
3442
3443         * BuildSlaveSupport/delete-stale-build-files:
3444
3445 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3446
3447         Disable accessibility notifications after each test
3448         https://bugs.webkit.org/show_bug.cgi?id=112579
3449
3450         Reviewed by Tim Horton.
3451         
3452         In WebKitTestRunner, if any tests triggered accessibility notifications,
3453         the global notification handler would thereafter be active, and fire
3454         notifications for all subsequent tests.
3455         
3456         Fix by implementing AccessibilityController::resetToConsistentState() for
3457         Mac, and using it to clear the global notification handler.
3458
3459         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3460         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3461         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3462         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3463         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3464         (e.g. because of -autorelease).
3465         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3466         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3467         if there is one.
3468         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3469         Add -stopObserving
3470         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3471         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3472         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3473         center.
3474
3475 2013-03-18  Dana Jansens  <danakj@chromium.org>
3476
3477         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3478         https://bugs.webkit.org/show_bug.cgi?id=112392
3479
3480         Reviewed by James Robinson.
3481
3482         Removes the command line flag option from DRT.
3483
3484         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3485         (main):
3486
3487 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3488
3489         [GTK] plugins/plugin-clip-subframe.html is failing
3490         https://bugs.webkit.org/show_bug.cgi?id=112570
3491
3492         Reviewed by Martin Robinson.
3493
3494         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3495
3496 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3497
3498         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3499         https://bugs.webkit.org/show_bug.cgi?id=112442
3500
3501         Reviewed by Gustavo Noronha Silva.
3502
3503         * GtkLauncher/main.c:
3504         (reloadCb):
3505         (createToolbar):
3506         (createWindow):
3507
3508 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3509
3510         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3511         https://bugs.webkit.org/show_bug.cgi?id=112205
3512
3513         Disable this API test until Geoff can fix it.
3514
3515         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3516         (TestWebKitAPI::TEST):
3517
3518 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3519
3520         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3521         https://bugs.webkit.org/show_bug.cgi?id=112478
3522
3523         Reviewed by Tony Chang.
3524
3525         There is nothing that ensures that the log messages from the plugin
3526         come in before the layout test finished loading.
3527
3528         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3529         (PassDifferentNPPStruct::NPP_SetWindow):
3530         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3531         (NPP_SetWindow):
3532
3533 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3534
3535         Have the mac port support per_test_timeout in webkitpy
3536         https://bugs.webkit.org/show_bug.cgi?id=112466
3537
3538         Reviewed by Dirk Pranke.
3539         
3540         Both WTR and DRT handle --timeout arguments, so we can
3541         have the scripts pass the timeout values down to the tools.
3542
3543         * Scripts/webkitpy/layout_tests/port/mac.py:
3544         (MacPort.supports_per_test_timeout):
3545
3546 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3547
3548         Remove setAsynchronousSpellCheckingEnabled from test runners
3549         https://bugs.webkit.org/show_bug.cgi?id=112362
3550
3551         Reviewed by Tony Chang.
3552
3553         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3554         in internals.settings, so all ports can share it.
3555
3556         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3557         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3558         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3559         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3560         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3561         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3562         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3563         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3564         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3565         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3566         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3567         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3568
3569 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3570
3571         Fix the stupid unit tests.
3572
3573         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3574         (test_sample_process):
3575
3576 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3577
3578         Collect samples for unresponsive web processes
3579         https://bugs.webkit.org/show_bug.cgi?id=112409
3580
3581         Reviewed by Tim Horton.
3582         
3583         When we detect that a subprocess was unresponsive, run the 'sample'
3584         tool on that process, for the Mac port.
3585         
3586         The sample will be linked to from the results.html page, next
3587         to the crash log link.
3588
3589         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3590         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3591         look for samples on disk.
3592         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3593         (TestResultWriter):
3594         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3595         -sample.txt files, and have it copy their contents to a new file
3596         next to the test that spawned them (as we do for crash logs).
3597         * Scripts/webkitpy/layout_tests/port/base.py:
3598         (Port.look_for_new_samples): Base class does nothing for sampling.
3599         * Scripts/webkitpy/layout_tests/port/driver.py:
3600         (Driver._check_for_driver_crash): Kick off a sample if we detected
3601         that the subprocess was unresponsive.
3602         * Scripts/webkitpy/layout_tests/port/mac.py:
3603         (MacPort.sample_file_path): Utility to generate the file path
3604         to the generated sample files at the top level of layout-test-results.
3605         (MacPort.look_for_new_crash_logs): Fix typo
3606         (MacPort.look_for_new_samples): New function to find sample files.
3607         (MacPort.sample_process): Use the utility function to get the file path.
3608
3609 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3610
3611         [Qt] Remove simple getters and setters from TestRunnerQt
3612         https://bugs.webkit.org/show_bug.cgi?id=112343
3613
3614         Reviewed by Benjamin Poulain.
3615
3616         The removed functions and boolean members
3617         are being replaced by the implementations in the
3618         generic TestRunner.h.
3619
3620         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3621         (DumpRenderTree::dumpFrameScrollPosition):
3622         (DumpRenderTree::dumpFramesAsText):
3623         (DumpRenderTree::dump):
3624         (DumpRenderTree::titleChanged):
3625         (DumpRenderTree::dumpDatabaseQuota):
3626         (DumpRenderTree::dumpApplicationCacheQuota):
3627         (DumpRenderTree::statusBarMessage):
3628         (DumpRenderTree::createWindow):
3629         * DumpRenderTree/qt/TestRunnerQt.cpp:
3630         (TestRunnerQt::reset):
3631         * DumpRenderTree/qt/TestRunnerQt.h:
3632         (TestRunnerQt):
3633
3634 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3635
3636         Update the link on build.webkit.org to refer to perf.webkit.org
3637         https://bugs.webkit.org/show_bug.cgi?id=112416
3638
3639         Reviewed by Philip Rogers.
3640
3641         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3642
3643         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3644
3645 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3646
3647         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3648         https://bugs.webkit.org/show_bug.cgi?id=112394
3649
3650       &nbs