0d3e1e38a294fc89bee039e2862590d65f0c1673
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
2
3         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
4         https://bugs.webkit.org/show_bug.cgi?id=97100
5
6         Reviewed by Gyuyoung Kim.
7
8         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
9         preference, in order to match WebKitTestRunner functionality.
10
11         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
12         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
13         * DumpRenderTree/efl/TestRunnerEfl.cpp:
14         (TestRunner::overridePreference):
15
16 2012-09-18  Kangil Han  <kangil.han@samsung.com>
17
18         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
19         https://bugs.webkit.org/show_bug.cgi?id=96181
20
21         Reviewed by Daniel Bates.
22
23         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
24
25         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
26         (new):
27         (_parseLicenseBlock):
28         (_parseLicenseBlockFromFile):
29         (_defaultLicenseBlock):
30         (_licenseBlock):
31         (_generateHeaderFile):
32         (_generateImplementationFile):
33
34 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
35
36         Title string should be changed when document.title is set to ''.
37         https://bugs.webkit.org/show_bug.cgi?id=96793
38
39         Reviewed by Kenneth Rohde Christiansen.
40
41         Change dump format of dumpTitleChanges more understandable.
42         Uses single quotation marks for the title string.
43
44         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
45         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
46         * DumpRenderTree/chromium/WebViewHost.cpp:
47         (WebViewHost::didReceiveTitle):
48         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
49         (DumpRenderTreeChrome::onFrameTitleChanged):
50         * DumpRenderTree/gtk/DumpRenderTree.cpp:
51         (webViewTitleChanged):
52         * DumpRenderTree/mac/FrameLoadDelegate.mm:
53         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
54         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
55         (WebCore::DumpRenderTree::titleChanged):
56         * DumpRenderTree/win/FrameLoadDelegate.cpp:
57         (FrameLoadDelegate::didReceiveTitle):
58         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
59         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
60         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
61         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
62
63 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
64
65         EWS shouldn't sleep if there are new patches in its queue
66         https://bugs.webkit.org/show_bug.cgi?id=83038
67
68         Reviewed by Eric Seidel.
69
70         EWS tries to process a security patch. Of course it can't, because the EWS isn't
71         the member of the security group. But the problem is that after it can't process
72         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
73         and push the security patch to the end of the queue.
74         Now it stays in the loop until it finds a patch or the queue gets empty.
75
76         * Scripts/webkitpy/tool/commands/queues.py:
77         (AbstractPatchQueue._next_patch):
78         * Scripts/webkitpy/tool/commands/queues_unittest.py:
79         (AbstractPatchQueueTest.test_next_patch):
80
81 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
82
83         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
84         https://bugs.webkit.org/show_bug.cgi?id=97014
85
86         Reviewed by Kenneth Rohde Christiansen.
87
88         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
89         be used for literals rather than WTF::StringBuilder::append().
90
91         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
92         (WTR::InjectedBundle::booleanForKey):
93
94 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
95
96         Update my e-mail address.
97
98         * Scripts/webkitpy/common/config/committers.py:
99
100 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
101
102         Update my e-mail address.
103
104         Unreviewed.
105
106         * Scripts/webkitpy/common/config/committers.py:
107
108 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
109
110         [Qt] qt_webkit.pri should not be listed in Tools.pro
111
112         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
113
114         Since r128751 the module pri file is auto-generated
115         but it was still listed in OTHER_FILES.
116
117         * Tools.pro: Remove unneeded line.
118
119 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
120
121         [Qt] Fix build with some versions of the gold linker
122
123         Reviewed by Tor Arne Vestbø.
124
125         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
126         Instead run a compile/link test first to see if it works.
127
128         * qmake/config.tests/gnuld/gnuld.pro: Added.
129         * qmake/config.tests/gnuld/main.cpp: Added.
130         (main):
131         * qmake/mkspecs/features/unix/default_post.prf:
132
133 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
134
135         [Qt] Remove forced use of gold.
136
137         Reviewed by Tor Arne Vestbø.
138
139         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
140         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
141         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
142
143         * qmake/mkspecs/features/unix/default_post.prf:
144
145 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
146
147         [Qt] Prospective Qt/Windows cross-compiling fix
148
149         Reviewed by Tor Arne Vestbø.
150
151         The win32 scope is not set when cross-compiling from Linux to Windows.
152
153         * qmake/mkspecs/features/functions.prf:
154
155 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
156
157         [EFL] Remove background view on EWebLauncher and MiniBrowser
158         https://bugs.webkit.org/show_bug.cgi?id=96905
159
160         Reviewed by Gyuyoung Kim.
161
162         The size of webview was changed after adding url bar.
163         And the background view is not necessary anymore, since it was used for debugging back in the day.
164
165         * EWebLauncher/main.c:
166         (_ELauncher):
167         (on_ecore_evas_resize):
168         (browserCreate):
169         * MiniBrowser/efl/main.c:
170         (_MiniBrowser):
171         (on_ecore_evas_resize):
172         (browserCreate):
173
174 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
175
176         [GTK] run-webkit-tests unable to find TestExpectations for WK2
177         https://bugs.webkit.org/show_bug.cgi?id=96998
178
179         Reviewed by Philippe Normand.
180
181         We should look for TestExpectations files in all the locations where
182         we currently look for Skipped files. This will allow
183         run-webkit-tests to look for TestExpectations files in
184         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
185
186         * Scripts/webkitpy/layout_tests/port/gtk.py:
187         (GtkPort.expectations_files):
188
189 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
190
191         [Qt] Fix build without the QtQuick module
192
193         Reviewed by Simon Hausmann.
194
195         * qmake/mkspecs/features/features.prf:
196
197 2012-09-18  Stephanie Lewis  <slewis@apple.com>
198
199         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
200
201         Unreviewed.
202
203         * DumpRenderTree/mac/DumpRenderTree.mm:
204         (poseAsClass):
205
206 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
207
208         Unreviewed update of email addresses for Berlin QtWebKit office.
209
210         * Scripts/webkitpy/common/config/committers.py:
211
212 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
213
214         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
215         https://bugs.webkit.org/show_bug.cgi?id=96899
216
217         Reviewed by Martin Robinson.
218
219         When overriding the 'WebKitDisplayImageKey' preference, use the
220         'auto-load-images' property of WebKitWebSettings as the property which
221         should be updated with the corresponding preference value.
222
223         * DumpRenderTree/gtk/DumpRenderTree.cpp:
224         (resetDefaultsToConsistentValues):
225         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
226         (TestRunner::overridePreference):
227
228 2012-09-17  Pratik Solanki  <psolanki@apple.com>
229
230         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
231         https://bugs.webkit.org/show_bug.cgi?id=96973
232
233         Reviewed by Dan Bernstein.
234
235         * DumpRenderTree/mac/Configurations/Base.xcconfig:
236         * WebKitTestRunner/Configurations/Base.xcconfig:
237         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
238
239 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
240
241         nrwt: remove "unexpected EOF" warnings
242         https://bugs.webkit.org/show_bug.cgi?id=96970
243
244         Reviewed by Ojan Vafai.
245
246         After debugging this a bit, it looks like there aren't any cases
247         that I can reproduce where a read() of zero indicates something
248         actually wrong; either it is a prelude to a crash, or a false
249         negative. So, I'm removing these warnings and adding a comment.
250
251         * Scripts/webkitpy/layout_tests/port/server_process.py:
252         (ServerProcess._wait_for_data_and_update_buffers_using_select):
253
254 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
255
256         [chromium] ASAN bot is crashing at the end of the run
257         https://bugs.webkit.org/show_bug.cgi?id=96967
258
259         Reviewed by Abhishek Arya.
260
261         The ASAN bot is crashing attempting to decode some output into
262         UTF-8; there's no reason to do this, so let's not do this and
263         see if something else is going on as well.
264
265         * Scripts/webkitpy/layout_tests/port/chromium.py:
266         (ChromiumPort._get_crash_log):
267
268 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
269
270         nrwt: --results-directory isn't getting printed properly
271         https://bugs.webkit.org/show_bug.cgi?id=96965
272
273         Reviewed by Ojan Vafai.
274
275         options.results_directory isn't actually initialized with the
276         default values until after we call print_config(), so this
277         changes things to print the value directly.
278
279         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
280         (run):
281         * Scripts/webkitpy/layout_tests/views/printing.py:
282         (Printer.print_config):
283         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
284         (Testprinter.test_print_config):
285
286 2012-09-17  Rob Buis  <rbuis@rim.com>
287
288         [BlackBerry] Enable VIDEO_TRACK
289         https://bugs.webkit.org/show_bug.cgi?id=96949
290
291         Reviewed by Antonio Gomes.
292
293         * Scripts/webkitperl/FeatureList.pm:
294
295 2012-09-17  Rick Byers  <rbyers@chromium.org>
296
297         Add handling of new GestureTapCancel in DRT
298
299         https://bugs.webkit.org/show_bug.cgi?id=96183
300
301         Reviewed by Antonio Gomes.
302
303         * DumpRenderTree/chromium/TestWebPlugin.cpp:
304         (TestWebPlugin::handleInputEvent):
305         * DumpRenderTree/chromium/EventSender.cpp:
306         (EventSender::gestureTapCancel):
307
308 2012-09-17  Philip Rogers  <pdr@google.com>
309
310         Teach style checker about preprocessor directive indentation rules
311         https://bugs.webkit.org/show_bug.cgi?id=96874
312
313         Reviewed by Adam Barth.
314
315         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
316         This is not explicit in our style guide but is generally followed in our code.
317         Searching for violations in our codebase shows these are rarely indented:
318             #include - indented in 6 files
319             #ifdef - indented in 0 files
320             #ifndef - indented in 1 file
321             #define - indented in 11 files
322             #if - indented in 7 files
323
324         * Scripts/webkitpy/style/checkers/cpp.py:
325         (check_directive_indentation):
326
327             This is the simple test where we look for spaces followed by a #.
328
329         (check_style):
330         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
331
332             A few tests needed to be modified because they had unintentionally indented
333             preprocessor directives.
334
335         (CppStyleTest.test_build_class.Foo):
336         (CppStyleTest.test_build_class):
337         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
338         (WebKitStyleTest.test_line_breaking):
339         (WebKitStyleTest.test_directive_indentation):
340
341 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
342
343         [Qt] Auto-generate the module pri file for QtWebKit
344
345         Reviewed by Simon Hausmann.
346
347         * qmake/qt_webkit.pri: Removed.
348
349 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
350
351         nrwt: --additional-platform-dir is broken on chromium ports
352         https://bugs.webkit.org/show_bug.cgi?id=96840
353
354         Reviewed by Ojan Vafai.
355
356         Looks like I broke this when cleaning things up as part of
357         adding ML support. Fixing and adding a test.
358
359         * Scripts/webkitpy/layout_tests/port/chromium.py:
360         (ChromiumPort.default_baseline_search_path):
361         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
362         (ChromiumAndroidPort.default_baseline_search_path):
363         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
364         (ChromiumLinuxPort.default_baseline_search_path):
365         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
366         (ChromiumMacPort.__init__):
367         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
368         (ChromiumWinPort.setup_environ_for_server):
369         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
370         (test_check_build):
371         (test_additional_platform_directory):
372
373 2012-09-13  Stephanie Lewis  <slewis@apple.com>
374
375         mac-future ignores previous platform TestExpectations.
376         https://bugs.webkit.org/show_bug.cgi?id=96718.
377
378         Reviewed by Dirk Pranke.
379
380         TestExpectations match an expectation's configuraton against a list of configurations that are 
381         valid for that port.  That list does not contain mac-future so none of the expectations can be
382         applied.
383
384         * Scripts/webkitpy/layout_tests/port/apple.py:
385         (ApplePort._generate_all_test_configurations):
386
387 2012-09-14  Adam Barth  <abarth@webkit.org>
388
389         Remove webkitPostMessage
390         https://bugs.webkit.org/show_bug.cgi?id=96577
391
392         Reviewed by Ojan Vafai.
393
394         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
395
396         * Scripts/webkitperl/FeatureList.pm:
397         * qmake/mkspecs/features/features.pri:
398
399 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
400
401         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
402         https://bugs.webkit.org/show_bug.cgi?id=96817
403
404         Reviewed by Kenneth Rohde Christiansen.
405
406         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
407         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
408         got overlooked when adding logging elsewhere.
409
410 2012-09-14  Peter Beverloo  <peter@chromium.org>
411
412         [Chromium] Build fix for DumpRenderTree following r128628
413         https://bugs.webkit.org/show_bug.cgi?id=96808
414
415         Reviewed by Tony Chang.
416
417         When building DumpRenderTree from the Chromium project, a compile error
418         shows up because including the header ForwardIOStreamsAndroid.h cannot
419         be located. TestWebKitAPI does this correctly.
420
421         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
422
423 2012-09-14  Dana Jansens  <danakj@chromium.org>
424
425         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
426         https://bugs.webkit.org/show_bug.cgi?id=96805
427
428         Reviewed by Dirk Pranke.
429
430         * Scripts/webkitpy/common/config/committers.py:
431         * Scripts/webkitpy/common/config/watchlist:
432
433 2012-09-14  Peter Beverloo  <peter@chromium.org>
434
435         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
436         https://bugs.webkit.org/show_bug.cgi?id=96687
437
438         Reviewed by Tony Chang.
439
440         Android's DumpRenderTree currently supports these arguments, implemented
441         as part of TestShellAndroid:
442         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
443
444         They're used by the layout test runner to get the STDOUT and STDERR while
445         a layout test run is in process, which is a safer alternative to parsing
446         all the logcat output manually. The implementation can be seen here:
447         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
448
449         This patch generalizes parsing of and applying the effects of these arguments
450         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
451         After this patch, this will make it possible to pull out the output-reading
452         code from Android's layout test port and generalize it so it can be re-used
453         in the new test-runner for the other two test suites.
454
455         This has no effect when compiling and running these tests as part of Chromium
456         code, which has a much more advanced test-runner that does parse complete log
457         output, but also directly depends on code licensed under Apache 2.
458
459         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
460         * DumpRenderTree/chromium/TestShellAndroid.cpp:
461         (platformInit):
462         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
463
464 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
465
466         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
467         https://bugs.webkit.org/show_bug.cgi?id=96656
468
469         Reviewed by Adam Barth.
470
471         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
472         macros in 1 line.
473
474         * Scripts/webkitpy/style/checkers/cpp.py:
475         (check_style.definitions):
476         (check_style): Add rule.
477         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
478         (WebKitStyleTest.test_line_breaking): Add unittest.
479
480 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
481
482         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
483         https://bugs.webkit.org/show_bug.cgi?id=57570
484
485         Reviewed by Kenneth Rohde Christiansen.
486
487         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
488         and dump the information expected by the test cases.
489
490         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
491         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
492         (WTR::InjectedBundle::beginTesting): Explicitly set the default
493         database quota.
494         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
495         (WTR::securityOriginToStr): New convenience function to convert
496         a security origin to the string expected in test results.
497         (WTR):
498         (WTR::InjectedBundlePage::InjectedBundlePage):
499         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
500         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
501         refactoring to share code with didExceedDatabaseQuota.
502         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
503         (InjectedBundlePage):
504         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
505         (WTR::TestRunner::TestRunner):
506         * WebKitTestRunner/InjectedBundle/TestRunner.h:
507         (WTR::TestRunner::dumpDatabaseCallbacks):
508         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
509         (TestRunner):
510
511 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
512
513         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
514
515         Rubber-stamped by Simon Hausmann.
516
517         * qmake/mkspecs/features/default_post.prf:
518
519 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
520
521         [Qt] Remove old cruft from the qmake build system
522
523         Rubber-stamped by Simon Hausmann.
524
525         * DumpRenderTree/qt/DumpRenderTree.pro:
526         * qmake/mkspecs/features/default_post.prf:
527
528 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
529
530         [Qt] Enable force_static_libs_as_shared for development
531
532         Not enabled for buildbots or production-builds (part of Qt5)
533
534         Reviewed by Simon Hausmann.
535
536         * qmake/mkspecs/features/default_post.prf:
537
538 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
539
540         [Qt] Make force_static_libs_as_shared work on Mac OS
541
542         We had to move a few LIBS += around that were in the wrong place,
543         and not caught when everything was just linked into the final
544         QtWebKit library.
545
546         Reviewed by Simon Hausmann.
547
548         * qmake/mkspecs/features/default_post.prf:
549         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
550
551 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
552
553         [Qt] Fix build of WTR on Windows
554
555         Reviewed by Tor Arne Vestbø.
556
557         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
558         With qmake's unix makefile generator as well as with the MingW generator,
559         the directory where the pro file lives (WTR/) is automatically added to
560         the include search path, but not so with MSVC. Instead of relying on qmake's
561         implicit feature here, add WTR/ explicitly to the include search path.
562
563         * WebKitTestRunner/Target.pri:
564
565 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
566
567         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
568         https://bugs.webkit.org/show_bug.cgi?id=42691
569
570         Reviewed by Kenneth Rohde Christiansen.
571
572         Add implementation for testrunner.setStopProvisionalFrameLoads()
573         in WebKitTestRunner.
574
575         Original patch by Alexey Proskuryakov.
576
577         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
578         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
579         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
580         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
581         (WTR::TestRunner::TestRunner):
582         * WebKitTestRunner/InjectedBundle/TestRunner.h:
583         (TestRunner):
584         (WTR::TestRunner::setStopProvisionalFrameLoads):
585         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
586
587 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
588
589         [Qt] Fix handling of debug/release/debug_and_release/build_all
590
591         We now pick up the defaults from Qt, in default_pre (CONFIG already
592         contains the appropriate values for debug and release). We then let
593         the command line arguments to qmake, or the project files themselves,
594         override the configuration, and finally we sanitize the configuration
595         in default_post.
596
597         Reviewed by Simon Hausmann.
598
599         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
600         * Scripts/webkitdirs.pm:
601         (buildQMakeProjects):
602         * qmake/mkspecs/features/default_post.prf:
603         * qmake/mkspecs/features/default_pre.prf:
604         * qmake/mkspecs/features/mac/default_pre.prf:
605
606 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
607
608         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
609         https://bugs.webkit.org/show_bug.cgi?id=42687
610
611         Reviewed by Kenneth Rohde Christiansen.
612
613         Implement testRunner.setTabKeyCyclesThroughElements for
614         WebKitTestRunner.
615
616         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
617         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
618         (WTR::InjectedBundle::beginTesting):
619         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
620         (WTR::TestRunner::setTabKeyCyclesThroughElements):
621         (WTR):
622         * WebKitTestRunner/InjectedBundle/TestRunner.h:
623         (TestRunner):
624
625 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
626
627         EventSendingController::keyDown does not support non-array modifier arguments
628         https://bugs.webkit.org/show_bug.cgi?id=96727
629
630         Reviewed by Kenneth Rohde Christiansen.
631
632         Add support for handling a string as modifier argument to
633         EventSendingController::keyDown.
634
635         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
636         (WTR::parseModifierArray):
637
638 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
639
640         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
641         https://bugs.webkit.org/show_bug.cgi?id=42546
642
643         Reviewed by Kenneth Rohde Christiansen.
644
645         Exported TestRunner::setCustomPolicyDelegate() method.
646         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
647
648         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
649         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
650         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
651
652 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
653
654         [GTK] Clear application cache between tests in DumpRenderTree
655         https://bugs.webkit.org/show_bug.cgi?id=96543
656
657         Reviewed by Philippe Normand.
658
659         Call the new DumpRenderTreeSupportGtk method to clear application cache
660         after each test in DumpRenderTree.
661
662         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
663         as well. It's now being set in XvfbDriver._start so that each driver is assigned
664         a cache directory that's constructed out of the driver's name and its worker
665         number. These directories are located in the layout tests results directory.
666         At least on the builders this ensures a driver-specific empty cache directory
667         with each test run.
668
669         * DumpRenderTree/gtk/DumpRenderTree.cpp:
670         (runTest):
671         * Scripts/webkitpy/layout_tests/port/gtk.py:
672         (GtkPort.setup_environ_for_server):
673         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
674         (XvfbDriver._start):
675
676 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
677
678         [Qt] Fix linking on Windows
679
680         Reviewed by Tor Arne Vestbø.
681
682         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
683         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
684         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
685         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
686
687         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
688         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
689         after the module. Therefore QT did never contain webkit anymore and we always passed
690         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
691
692         This patch introduces a creating_module configuration that is used to
693         scope the qt/pkgconfig sanitization.
694
695         * qmake/mkspecs/features/default_post.prf:
696
697 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
698
699         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
700         https://bugs.webkit.org/show_bug.cgi?id=96740
701
702         Reviewed by Kenneth Rohde Christiansen.
703
704         Dump information expected by the test cases about the following
705         frame load callbacks:
706         "didDisplayInsecureContentForFrame"
707         "didRunInsecureContentForFrame"
708         "didDetectXSSForFrame"
709
710         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
711         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
712         as expected by test results by calling pathSuitableForTestResult() instead
713         of printing raw URL.
714         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
715         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
716         (WTR::InjectedBundlePage::didDetectXSSForFrame):
717
718 2012-09-14  Peter Beverloo  <peter@chromium.org>
719
720         The runtime/unsigned category should be valid in the cpp style-checker.
721         https://bugs.webkit.org/show_bug.cgi?id=96748
722
723         Reviewed by Csaba Osztrogonác.
724
725         This is causing the webkitpy tests to fail because it's not listed in the
726         category array. Furthermore, change an "int" to "long" because it's
727         throwing a double error in one of the earlier asserts.
728
729         * Scripts/webkitpy/style/checkers/cpp.py:
730         (CppChecker):
731         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
732         (WebKitStyleTest.test_names):
733
734 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
735
736         Evas_Object* is a ref'ed structure, so tread it as such
737         https://bugs.webkit.org/show_bug.cgi?id=96659
738
739         Reviewed by Adam Barth.
740
741         Replace OwnPtr<Evas_Object> with RefPtr.
742
743         * DumpRenderTree/efl/ImageDiff.cpp:
744         (calculateDifference):
745         (printImageDifferences):
746         (readImageFromStdin):
747         (main):
748
749 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
750
751         Unreviewed, rolling out r128507.
752         http://trac.webkit.org/changeset/128507
753         https://bugs.webkit.org/show_bug.cgi?id=96659
754
755         Revert. r128507 makes too many crashes in EFL layout test bots.
756
757         * DumpRenderTree/efl/ImageDiff.cpp:
758         (calculateDifference):
759         (printImageDifferences):
760         (readImageFromStdin):
761         (main):
762
763 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
764
765         Make compile with both OS(WINCE) and PLATFORM(QT) support
766         https://bugs.webkit.org/show_bug.cgi?id=95536
767
768         Reviewed by Simon Hausmann.
769
770         Fix wince support in qmake files
771
772         * Tools.pro:
773         * qmake/mkspecs/features/configure.prf:
774         * qmake/mkspecs/features/default_post.prf:
775         * qmake/mkspecs/features/features.prf:
776         * qmake/mkspecs/features/functions.prf:
777
778 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
779
780         [WK2] Add color picker API support for WebKit2
781         https://bugs.webkit.org/show_bug.cgi?id=95058
782
783         Reviewed by Gyuyoung Kim.
784
785         Initialization code for color picker callbacks in UI client.
786
787         * MiniBrowser/mac/BrowserWindowController.m:
788         (-[BrowserWindowController awakeFromNib]):
789         * MiniBrowser/win/BrowserView.cpp:
790         (BrowserView::create):
791         * WebKitTestRunner/TestController.cpp:
792         (WTR::TestController::createOtherPage):
793         (WTR::TestController::initialize):
794
795 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
796
797         Upgrade yutak to reviewer
798         https://bugs.webkit.org/show_bug.cgi?id=96721
799
800         Reviewed by Kent Tamura.
801
802         * Scripts/webkitpy/common/config/committers.py:
803
804 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
805
806         Make the style checker report usage of "unsigned int"
807         https://bugs.webkit.org/show_bug.cgi?id=96693
808
809         Reviewed by Dirk Pranke.
810
811         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
812
813         * Scripts/webkitpy/style/checkers/cpp.py:
814         (check_language):
815
816 2012-09-13  Philip Rogers  <pdr@google.com>
817
818         Add gender-neutral form of webkit-patch land-cowboy
819         https://bugs.webkit.org/show_bug.cgi?id=96709
820
821         Reviewed by Adam Barth.
822
823         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
824
825         * Scripts/webkitpy/tool/commands/download.py:
826         (LandCowhand):
827
828 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
829
830         [EFL] Remove some parameters in browserCreate()
831         https://bugs.webkit.org/show_bug.cgi?id=96499
832
833         Reviewed by Kenneth Rohde Christiansen.
834
835         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
836         And I have moved some parameters into User_Arguments.
837
838         * EWebLauncher/main.c:
839         (_User_Arguments):
840         (_ELauncher):
841         (on_key_down):
842         (browserCreate):
843         (findThemePath):
844         (parseUserArguments):
845         (main):
846
847 2012-09-13  Mark Lam  <mark.lam@apple.com>
848
849         Unreviewed. Adding myself to the committers list.
850
851         * Scripts/webkitpy/common/config/committers.py:
852
853 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
854
855         run-perf-tests output cryptic error when the config file is missing.
856         https://bugs.webkit.org/show_bug.cgi?id=96453
857
858         Reviewed by Tony Chang.
859
860         Add a special error message when a configuration file is missing.
861
862         Also update the help message of --source-json-path to signify the fact it specifies
863         the configuration file on performance tests bots.
864
865         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
866         (PerfTestsRunner._parse_args):
867         (PerfTestsRunner._generate_and_show_results):
868         (PerfTestsRunner._merge_slave_config_json):
869         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
870         (_test_run_with_json_output): Make upload to fail by default and assert the result
871         in the function so that we can return logs instead.
872         (_test_run_with_json_output.mock_upload_json):
873         (test_run_with_json_output):
874         (test_run_with_description):
875         (test_run_respects_no_results):
876         (test_run_with_slave_config_json):
877         (test_run_with_bad_slave_config_json):
878         (test_run_with_multiple_repositories):
879
880 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
881
882         Evas_Object* is a ref'ed structure, so tread it as such
883         https://bugs.webkit.org/show_bug.cgi?id=96659
884
885         Reviewed by Adam Barth.
886
887         Replace OwnPtr<Evas_Object> with RefPtr.
888
889         * DumpRenderTree/efl/ImageDiff.cpp:
890         (calculateDifference):
891         (printImageDifferences):
892         (readImageFromStdin):
893         (main):
894
895 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
896
897         One more unreviewed trivial fix after r128399.
898
899         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
900
901 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
902
903         Unreviewed trivial fix after r128399.
904
905         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
906         (getLatestSVNRevision):
907         (waitForSVNRevision):
908
909 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
910
911         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
912         https://bugs.webkit.org/show_bug.cgi?id=96366
913
914         Reviewed by Anders Carlsson.
915
916         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
917         by calling shouldClose() on the FrameLoader.
918
919         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
920         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
921         (WTR::TestRunner::callShouldCloseOnWebView):
922         (WTR):
923         * WebKitTestRunner/InjectedBundle/TestRunner.h:
924         (TestRunner):
925
926 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
927
928         Unreviewed, rolling out r128453.
929         http://trac.webkit.org/changeset/128453
930         https://bugs.webkit.org/show_bug.cgi?id=96681
931
932         Having tests use the same appcache directory leads to timeouts
933         (Requested by zdobersek on #webkit).
934
935         * DumpRenderTree/gtk/DumpRenderTree.cpp:
936         (runTest):
937         * Scripts/webkitpy/layout_tests/port/gtk.py:
938         (GtkPort.setup_environ_for_server):
939
940 2012-09-13  James Robinson  <jamesr@chromium.org>
941
942         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
943         https://bugs.webkit.org/show_bug.cgi?id=96678
944
945         Reviewed by Dirk Pranke.
946
947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
948         (.):
949
950 2012-09-13  Rob Buis  <rbuis@rim.com>
951
952         Unreviewed changes to watchlist.
953
954         - Add myself to BlackBerry bugs
955
956         * Scripts/webkitpy/common/config/watchlist:
957
958 2012-09-13  Stephen Chenney  <schenney@chromium.org>
959
960         Add an SVG entry to the watchlist
961
962         Unreviewed config change.
963
964         * Scripts/webkitpy/common/config/watchlist:
965         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
966         - Added myself and pdr as watchers
967
968 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
969
970         [Qt] Make WebKit2 work on Windows with Qt 5
971         https://bugs.webkit.org/show_bug.cgi?id=76776
972
973         Reviewed by Tor Arne Vestbø.
974
975         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
976         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
977         that for the GL TextureMapper (it's only built when that feature is set).
978
979         * qmake/mkspecs/features/configure.prf:
980
981 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
982
983         [Qt] Ensure that QT is finalized before loading qt_module.prf
984
985         As qt_module.prf does dependency tracking based on the content of the
986         QT variable. The intermediate WebKit modules modify the variable in
987         their .pri files, so we have to ensure we've loaded all the modules
988         before loading qt_module.
989
990         Reviewed by Tor Arne Vestbø.
991         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
992
993         * qmake/mkspecs/features/default_post.prf:
994         * qmake/mkspecs/features/webkit_modules.prf: Added.
995
996 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
997
998         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
999         https://bugs.webkit.org/show_bug.cgi?id=96633
1000
1001         Reviewed by Csaba Osztrogonác.
1002
1003         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1004         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1005         It's the usual problem and the usual solution is to rename one of the conflicting files.
1006         This patch chooses to rename DRT instead of WTR and MBR.
1007
1008         Fixed include order at the same time to match style guide.
1009
1010         * DumpRenderTree/qt/DumpRenderTree.pro:
1011         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1012         (messageHandler):
1013         (isOption):
1014         (takeOptionValue):
1015         (printUsage):
1016         (main):
1017
1018 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1019
1020         The Script run-launcher should support -2 in combination with --efl
1021         https://bugs.webkit.org/show_bug.cgi?id=96639
1022
1023         Reviewed by Simon Hausmann.
1024
1025         Support running the MiniBrowser then supplied -2 as argument.
1026
1027         * Scripts/run-launcher:
1028
1029 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1030
1031         Unreviewed, add my Intel email address to the list.
1032
1033         * Scripts/webkitpy/common/config/committers.py:
1034
1035 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1036
1037         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1038
1039         Reviewed by Ossy.
1040
1041         * qmake/mkspecs/features/default_post.prf:
1042
1043 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1044
1045         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1046         https://bugs.webkit.org/show_bug.cgi?id=82294
1047
1048         Reviewed by Gyuyoung Kim.
1049
1050         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1051
1052         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1053         (TestRunner::layerTreeAsText):
1054
1055 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1056
1057         [GTK] Clear application cache between tests in DumpRenderTree
1058         https://bugs.webkit.org/show_bug.cgi?id=96543
1059
1060         Reviewed by Philippe Normand.
1061
1062         Call the new DumpRenderTreeSupportGtk method to clear application cache
1063         after each test.
1064
1065         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1066         as well. Currently it points to a subdirectory in the layout tests results
1067         directory. At least on the builders this ensures an empty cache directory
1068         with each test run.
1069
1070         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1071         (runTest):
1072         * Scripts/webkitpy/layout_tests/port/gtk.py:
1073         (GtkPort.setup_environ_for_server):
1074
1075 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1076
1077         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1078
1079         Unless it's actually a dependency of the public QtWebKit API.
1080
1081         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1082         files with their _PRIVATE equivivalent, but that's likely to break when
1083         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1084         clean up the variables in default_post.
1085
1086         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1087         longer needed, as it was a workaround for the intermediate libraries ending
1088         up in the prl file. And, since CONFIG -= staticlib was there to support
1089         the explicitlib option, we can remove that too (as well as the exception
1090         for gprof, since it would be empty). If gprof needs tweaks to always link
1091         statically they should go in gprof.prf.
1092
1093         Reviewed by Simon Hausmann.
1094
1095         * qmake/mkspecs/features/default_post.prf:
1096         * qmake/mkspecs/features/functions.prf:
1097
1098 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1099
1100         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1101         https://bugs.webkit.org/show_bug.cgi?id=96632
1102
1103         Reviewed by Carlos Garcia Campos.
1104
1105         Fix this by using atk_object_get_n_accessible_children instead of
1106         calling getChildren() from childCount.
1107
1108         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1109         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1110         loop by using atk_object_get_n_accessible_children().
1111
1112 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1113
1114         [Qt][Win] Enable USE(3D_GRAPHICS)
1115         https://bugs.webkit.org/show_bug.cgi?id=90879
1116
1117         Reviewed by Kenneth Rohde Christiansen.
1118
1119         Enable it on Windows as well as on QNX (bug fixed).
1120
1121         * qmake/mkspecs/features/features.prf:
1122
1123 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1124
1125         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1126         https://bugs.webkit.org/show_bug.cgi?id=96359
1127
1128         Reviewed by Tor Arne Vestbø.
1129
1130         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1131         lexer. The only viable alternative I could find on Windows that provides
1132         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1133         so let's use that one instead.
1134
1135         * Scripts/webkitdirs.pm:
1136         (checkRequiredSystemConfig):
1137         * qmake/mkspecs/features/default_pre.prf:
1138
1139 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1140
1141         [Qt] Add configuration for production builds
1142         https://bugs.webkit.org/show_bug.cgi?id=96607
1143
1144         Reviewed by Kenneth Rohde Christiansen.
1145
1146         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1147         and enable all-in-one-files optimizations.
1148
1149         * qmake/mkspecs/features/production_build.prf: Added.
1150
1151 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1152
1153         [Qt] GStreamer detection does not work when cross-compiling
1154         https://bugs.webkit.org/show_bug.cgi?id=96608
1155
1156         Reviewed by Kenneth Rohde Christiansen.
1157
1158         When cross-compiling it is not safe to just use system(pkg-config),
1159         because there is a high probability that it will find packages in the
1160         host system instead of in the target one. Instead use qmake's new
1161         packagesExist() function that takes care of this delicate aspect of
1162         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1163         PKG_CONFIG_LIBDIR accordingly.
1164
1165         * qmake/mkspecs/features/features.prf:
1166
1167 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1168
1169         [WK2][WTR] More efficient string handling in InjectedBundlePage
1170         https://bugs.webkit.org/show_bug.cgi?id=96609
1171
1172         Reviewed by Kenneth Rohde Christiansen.
1173
1174         Update StringBuilder usage in InjectedBundlePage to follow
1175         the latest recommandations for efficient string handling:
1176         http://trac.webkit.org/wiki/EfficientStrings
1177
1178         This involves using appendLiteral() or appendNumber()
1179         instead of append() whenever possible.
1180
1181         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1182         (WTR::dumpPath):
1183         (WTR::rangeToStr):
1184         (WTR::styleDecToStr):
1185         (WTR::frameToStr):
1186         (WTR::dumpResourceURL):
1187         (WTR):
1188         (WTR::dumpFrameDescriptionSuitableForTestResult):
1189         (WTR::dumpRequestDescriptionSuitableForTestResult):
1190         (WTR::dumpResponseDescriptionSuitableForTestResult):
1191         (WTR::dumpErrorDescriptionSuitableForTestResult):
1192         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1193         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1194         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1195         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1196         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1197         (WTR::InjectedBundlePage::didFinishProgress):
1198         (WTR::dumpFrameScrollPosition):
1199         (WTR::dumpFrameText):
1200         (WTR::dumpDescendantFramesText):
1201         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1202         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1203         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1204         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1205         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1206         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1207         (WTR::InjectedBundlePage::willSendRequestForFrame):
1208         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1209         (WTR::InjectedBundlePage::didFinishLoadForResource):
1210         (WTR::InjectedBundlePage::didFailLoadForResource):
1211         (WTR::InjectedBundlePage::shouldCacheResponse):
1212         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1213         (WTR::InjectedBundlePage::willAddMessageToConsole):
1214         (WTR::InjectedBundlePage::willSetStatusbarText):
1215         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1216         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1217         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1218         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1219         (WTR::InjectedBundlePage::shouldBeginEditing):
1220         (WTR::InjectedBundlePage::shouldEndEditing):
1221         (WTR::InjectedBundlePage::shouldInsertNode):
1222         (WTR::InjectedBundlePage::shouldInsertText):
1223         (WTR::InjectedBundlePage::shouldDeleteRange):
1224         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1225         (WTR::InjectedBundlePage::shouldApplyStyle):
1226         (WTR::InjectedBundlePage::didBeginEditing):
1227         (WTR::InjectedBundlePage::didEndEditing):
1228         (WTR::InjectedBundlePage::didChange):
1229         (WTR::InjectedBundlePage::didChangeSelection):
1230         (WTR::InjectedBundlePage::supportsFullScreen):
1231         (WTR::InjectedBundlePage::enterFullScreenForElement):
1232         (WTR::InjectedBundlePage::exitFullScreenForElement):
1233         (WTR::InjectedBundlePage::beganEnterFullScreen):
1234         (WTR::InjectedBundlePage::beganExitFullScreen):
1235         (WTR::InjectedBundlePage::closeFullScreen):
1236         (WTR::dumpBackForwardListItem):
1237         (WTR::InjectedBundlePage::dumpBackForwardList):
1238
1239 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1240
1241         [Qt][WK2] Memory leaks in Qt's TestRunner
1242         https://bugs.webkit.org/show_bug.cgi?id=96603
1243
1244         Reviewed by Csaba Osztrogonác.
1245
1246         Fix memory leaks in Qt's TestRunner code by adopting WKString
1247         created with WKStringCreateWithUTF8CString().
1248
1249         * WebKitTestRunner/qt/TestControllerQt.cpp:
1250         (WTR::TestController::initializeInjectedBundlePath):
1251         (WTR::TestController::initializeTestPluginDirectory):
1252
1253 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1254
1255         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1256         https://bugs.webkit.org/show_bug.cgi?id=96506
1257
1258         Reviewed by Dirk Pranke.
1259
1260         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1261         for debug configuration. These are the same values the Chromium port uses.
1262
1263         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1264         the layout tests under WebKit2 generally) requires more attention and gardening
1265         than what the current effort produces.
1266
1267         The unit test is updated as well to test these changes.
1268
1269         * Scripts/webkitpy/layout_tests/port/gtk.py:
1270         (GtkPort.default_timeout_ms):
1271         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1272         (GtkPortTest.test_default_timeout_ms):
1273         (GtkPortTest.assertLinesEqual):
1274
1275 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1276
1277         Add SVN mirror handling feature to build.webkit.org
1278         https://bugs.webkit.org/show_bug.cgi?id=85887
1279
1280         Reviewed by Dirk Pranke.
1281
1282         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1283         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1284         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1285         (ConfigureBuild.start):
1286         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1287         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1288         (Factory.__init__):
1289         (BuildFactory.__init__):
1290         (TestFactory.__init__):
1291         (BuildAndTestFactory.__init__):
1292         (BuildAndPerfTestFactory.__init__):
1293         (BuildAndPerfTestWebKit2Factory.__init__):
1294         (DownloadAndPerfTestFactory.__init__):
1295         (DownloadAndPerfTestWebKit2Factory.__init__):
1296         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1297         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1298         (SVNMirrorTest):
1299         (SVNMirrorTest.setUp): Load config.json once at startup.
1300         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1301         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1302         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1303         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1304         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1305                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1306
1307 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1308
1309         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1310         https://bugs.webkit.org/show_bug.cgi?id=81606
1311
1312         Reviewed by Tim Horton.
1313
1314         6 seconds is harsh for some jquery test cases.
1315         Therefore, adjust the value to match DumpRenderTree.
1316
1317         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1318         (WTR):
1319
1320 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1321
1322         [EFL] Support download attribute feature
1323         https://bugs.webkit.org/show_bug.cgi?id=96462
1324
1325         Reviewed by Gyuyoung Kim.
1326
1327         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1328         and add "download,request" callback to the DumpRenderTree for EFL.
1329
1330         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1331         (DumpRenderTreeChrome::createView):
1332         (DumpRenderTreeChrome::onDownloadRequest):
1333         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1334         (DumpRenderTreeChrome):
1335         * Scripts/webkitperl/FeatureList.pm:
1336
1337 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1338
1339         Reduce parallism on the wk2 testers.
1340         https://bugs.webkit.org/show_bug.cgi?id=95906
1341
1342         Reviewed by Dirk Pranke.
1343
1344         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1345         resource contention.  Reducing the number of processes alleviates the issue.  
1346
1347         Starting by reducing 25%.
1348
1349         * Scripts/webkitpy/layout_tests/port/mac.py:
1350         (MacPort.default_child_processes):
1351
1352 2012-09-12  Brady Eidson  <beidson@apple.com>
1353
1354         Assert in NetscapePlugin::destroy() with async plugin init
1355         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1356
1357         Reviewed by Anders Carlsson.
1358
1359         Expose NPN_Invoke to plug-in tests:
1360         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1361         (PluginTest::NPN_Invoke):
1362         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1363         (PluginTest):
1364
1365         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1366         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1367         (InvokeDestroysPluginWithinNPP_New):
1368         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1369         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1370         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1371
1372 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1373
1374         refactor TestExpectations tokenization slightly in preparation for the new syntax
1375         https://bugs.webkit.org/show_bug.cgi?id=96564
1376
1377         Reviewed by Ojan Vafai.
1378
1379         This change changes how we will tokenize/lex the
1380         TestExpectations files, in preparation for supporting both the
1381         old syntax and the new one. This change by itself should be a
1382         no-op.
1383
1384         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1385         (TestExpectationParser._tokenize_line):
1386         (TestExpectationParser):
1387         (TestExpectationParser._tokenize_line_using_old_format):
1388         (TestExpectationParser._tokenize_line_using_new_format):
1389
1390 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1391
1392         remove unused testexpectations editing code from webkitpy, garden-o-matic
1393         https://bugs.webkit.org/show_bug.cgi?id=96562
1394
1395         Reviewed by Adam Barth.
1396
1397         This code was prototyped but never fully realized. Removing
1398         until it reanimates :).
1399
1400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1402         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1403         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1404         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1405         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1406         (GardeningHTTPRequestHandler._run_webkit_patch):
1407         (GardeningHTTPRequestHandler.ping):
1408         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1409         (BuildCoverageExtrapolatorTest.test_extrapolate):
1410         (GardeningServerTest.test_rebaseline_new_port):
1411
1412 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1413
1414         Remove unused bot, apple-xserve-1.
1415         https://bugs.webkit.org/show_bug.cgi?id=96570
1416         
1417         Reviewed by Stephanie Lewis.
1418
1419         * BuildSlaveSupport/build.webkit.org-config/config.json:
1420
1421 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1422
1423         [GTK] We attempt to rebase documentation even if it's not present
1424         https://bugs.webkit.org/show_bug.cgi?id=96553
1425
1426         Reviewed by Martin Robinson.
1427
1428         Do not make the documentation rebase step fatal. This allows make
1429         install to succeed when there's no documentation generated.
1430
1431         * gtk/generate-gtkdoc:
1432
1433 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1434
1435         Respect WEBKITOUTPUTDIR when running EFL tests
1436         https://bugs.webkit.org/show_bug.cgi?id=96528
1437
1438         Reviewed by Dirk Pranke.
1439
1440         Expose user set WEBKITOUTPUTDIR to the web process.
1441
1442         * Scripts/webkitpy/layout_tests/port/driver.py:
1443         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1444         of the web process and its potential jhbuild wrapper.
1445
1446 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1447
1448         webkitdirs: fix uname version handling for cygwin
1449         https://bugs.webkit.org/show_bug.cgi?id=96436
1450
1451         Reviewed by Jon Honeycutt.
1452
1453         Newer versions of cygwin embed an additional version string
1454         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1455         Update the code to handle that.
1456
1457         * Scripts/webkitdirs.pm:
1458         (setupAppleWinEnv):
1459
1460 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1461
1462         Regression(r128338): Broke Windows build
1463         https://bugs.webkit.org/show_bug.cgi?id=96537
1464
1465         Unreviewed build fix.
1466
1467         Fix Apple-Win build by allocating array dynamically
1468         since its size is not constant.
1469
1470         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1471         (WTR::stringArrayToJS):
1472
1473 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1474
1475         [chromium] Add a virtual test suite for fast/hidpi
1476         https://bugs.webkit.org/show_bug.cgi?id=90192
1477
1478         Reviewed by Dirk Pranke.
1479
1480         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1481         on the hardware accelerated path as the software path.
1482
1483         * DumpRenderTree/chromium/WebPreferences.cpp:
1484         (WebPreferences::applyTo):
1485         * Scripts/webkitpy/layout_tests/port/chromium.py:
1486         (ChromiumPort.virtual_test_suites):
1487
1488 2012-09-12  Adam Klein  <adamk@chromium.org>
1489
1490         [chromium] Add content_browsertests to the flakiness dashboard
1491         https://bugs.webkit.org/show_bug.cgi?id=96535
1492
1493         Reviewed by Ojan Vafai.
1494
1495         * TestResultServer/static-dashboards/dashboard_base.js:
1496
1497 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1498
1499         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1500         https://bugs.webkit.org/show_bug.cgi?id=96496
1501
1502         Reviewed by Kenneth Rohde Christiansen.
1503
1504         Add implementation for originsWithApplicationCache to
1505         WebKitTestRunner.
1506
1507         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1508         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1509         (WTR::stringArrayToJS):
1510         (WTR):
1511         (WTR::TestRunner::originsWithApplicationCache):
1512         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1513         (TestRunner):
1514
1515 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1516
1517         Fix Qt/Windows build with Python3
1518         https://bugs.webkit.org/show_bug.cgi?id=96473
1519
1520         Reviewed by Csaba Osztrogonác.
1521
1522         In Python 3 print is a real function, so we must use parentheses around
1523         the function parameters. This is backwards compatible with Python 2.
1524
1525         * Scripts/generate-win32-export-forwards:
1526
1527 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1528
1529         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1530
1531         As pointed out by Kevin, we should inject the "set PATH=..." statement
1532         to add the GnuWin32 directory only if that directory actually exists.
1533
1534         * qmake/mkspecs/features/default_post.prf:
1535
1536 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1537
1538         [EFL] [WK2] Memory leaks in TestControllerEfl
1539         https://bugs.webkit.org/show_bug.cgi?id=96525
1540
1541         Reviewed by Kenneth Rohde Christiansen.
1542
1543         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1544         of WKString created with WKStringCreateWithUTF8CString().
1545
1546         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1547         (WTR::TestController::initializeInjectedBundlePath):
1548         (WTR::TestController::initializeTestPluginDirectory):
1549
1550 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1551
1552         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1553         https://bugs.webkit.org/show_bug.cgi?id=96374
1554
1555         Reviewed by Kenneth Rohde Christiansen.
1556
1557         Implement support for dumpApplicationCacheDelegateCallbacks
1558         and disallowIncreaseForApplicationCacheQuota in
1559         WebKitTestRunner and properly dump the information
1560         expected by the tests.
1561
1562         If the application cache quota is reached for a given
1563         security origin, WebKitTestRunner will reset the quota
1564         to its default value, unless intructed not to via
1565         disallowIncreaseForApplicationCacheQuota().
1566
1567         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1568         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1569         (WTR::InjectedBundlePage::InjectedBundlePage):
1570         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1571         (WTR):
1572         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1573         (InjectedBundlePage):
1574         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1575         (WTR::TestRunner::TestRunner):
1576         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1577         (WTR):
1578         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1579         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1580         (TestRunner):
1581         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1582         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1583
1584 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1585
1586         [chromium] remove deprecated and unused sets import from chromium_android driver
1587         https://bugs.webkit.org/show_bug.cgi?id=96485
1588
1589         Reviewed by Dirk Pranke.
1590
1591         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1592
1593 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1594
1595         Flakiness dashboard doesn't recognize new Chromium Android test builder
1596         https://bugs.webkit.org/show_bug.cgi?id=96523
1597
1598         Reviewed by Ojan Vafai.
1599
1600         Properly return 'ANDROID' as the Chromium platform for Android builders.
1601
1602         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1603         (chromiumPlatform):
1604         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1605         (test):
1606
1607 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1608
1609         [Qt] Build on Windows requires bison/flex in PATH
1610         https://bugs.webkit.org/show_bug.cgi?id=96358
1611
1612         Reviewed by Tor Arne Vestbø.
1613
1614         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1615         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1616         a separate installation of various GNU tools is required as the operating system doesn't come with
1617         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1618         the gnuwin32 directory of the qt5.git top-level repository.
1619
1620         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1621
1622         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1623         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1624         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1625         updated with the new tool.
1626
1627         * Scripts/webkitdirs.pm:
1628         (checkRequiredSystemConfig):
1629         * qmake/mkspecs/features/default_post.prf:
1630
1631 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1632
1633         [Qt] Update build-jsc after r128174
1634
1635         Reviewed by Ossy.
1636
1637         * Scripts/build-jsc:
1638
1639 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1640
1641         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1642
1643         By hard-coding the names of the targets we defined we ended up just
1644         redefining the previous target when using addStrictSubdirOrderBetween
1645         more than once in a single project file.
1646
1647         We now embed the two base targets into the target names.
1648
1649         Reviewed by Simon Hausmann.
1650
1651         * qmake/mkspecs/features/functions.prf:
1652
1653 2012-09-12  Philippe Liard  <pliard@google.com>
1654
1655         Depend on {base,net} GYP targets rather than {base,net}_java.
1656         https://bugs.webkit.org/show_bug.cgi?id=95690
1657
1658         Reviewed by Adam Barth.
1659
1660         {base,net}_java became 'private' targets on the Chromium side that
1661         clients should not depend on (see
1662         https://chromiumcodereview.appspot.com/10913083/).
1663         This removes a bunch of trailing white spaces additionally in
1664         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1665
1666         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1667         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1668
1669 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1670
1671         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1672         https://bugs.webkit.org/show_bug.cgi?id=96494
1673
1674         Reviewed by Tor Arne Vestbø.
1675
1676         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1677         plugin process feature if we don't have NPAPI.
1678
1679         * qmake/mkspecs/features/features.prf:
1680
1681 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1682
1683         Unreviewed, rolling out r128280.
1684         http://trac.webkit.org/changeset/128280
1685         https://bugs.webkit.org/show_bug.cgi?id=96498
1686
1687         it broke compilation on windows debug bot (Requested by loislo
1688         on #webkit).
1689
1690         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1691         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1692         (WTR::InjectedBundlePage::InjectedBundlePage):
1693         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1694         (InjectedBundlePage):
1695         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1696         (WTR::TestRunner::TestRunner):
1697         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1698         (TestRunner):
1699
1700 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1701
1702         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1703         https://bugs.webkit.org/show_bug.cgi?id=96488
1704
1705         Reviewed by Tor Arne Vestbø.
1706
1707         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1708         because there are no such targets. We want the generated sources to be independent from release
1709         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1710         redirect to the same general-purpose target (first) of creating the derived sources.
1711
1712         * qmake/mkspecs/features/default_post.prf:
1713
1714 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1715
1716         [EFL] Make DumpRenderTree smarter at finding the fonts
1717         http://webkit.org/b/96281
1718
1719         Reviewed by Gyuyoung Kim.
1720
1721         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1722         Use CString consistently.
1723
1724         * DumpRenderTree/efl/FontManagement.cpp:
1725         (buildPath):
1726         (getCoreFontFiles):
1727         (addFontDirectory):
1728         (addFontFiles):
1729         (getCustomBuildDir):
1730         (getPlatformFontsPath):
1731         (addFontsToEnvironment):
1732
1733 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1734
1735         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1736         https://bugs.webkit.org/show_bug.cgi?id=96374
1737
1738         Reviewed by Kenneth Rohde Christiansen.
1739
1740         Implement support for dumpApplicationCacheDelegateCallbacks
1741         and disallowIncreaseForApplicationCacheQuota in
1742         WebKitTestRunner and properly dump the information
1743         expected by the tests.
1744
1745         If the application cache quota is reached for a given
1746         security origin, WebKitTestRunner will reset the quota
1747         to its default value, unless intructed not to via
1748         disallowIncreaseForApplicationCacheQuota().
1749
1750         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1751         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1752         (WTR::InjectedBundlePage::InjectedBundlePage):
1753         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1754         (WTR):
1755         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1756         (InjectedBundlePage):
1757         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1758         (WTR::TestRunner::TestRunner):
1759         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1760         (WTR):
1761         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1762         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1763         (TestRunner):
1764         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1765         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1766
1767 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1768
1769         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1770         https://bugs.webkit.org/show_bug.cgi?id=96388
1771
1772         Reviewed by Kenneth Rohde Christiansen.
1773
1774         Exported TestRunner.workerThreadCount as readonly attribute.
1775
1776         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1777         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1778         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1779         (WTR):
1780         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1781         (TestRunner):
1782
1783 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1784
1785         [chromium] Consume a user gesture when creating a new view.
1786         https://bugs.webkit.org/show_bug.cgi?id=96373
1787
1788         Reviewed by Adam Barth.
1789
1790         * DumpRenderTree/chromium/WebViewHost.cpp:
1791         (WebViewHost::createView):
1792
1793 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1794
1795         [WK2][WTR] Some of TestRunner special options are not reset before testing
1796         https://bugs.webkit.org/show_bug.cgi?id=96384
1797
1798         Reviewed by Kenneth Rohde Christiansen.
1799
1800         Now values of the following special options are reset:
1801         void setAcceptsEditing(in boolean value);
1802         void setCloseRemainingWindowsWhenComplete(in boolean value);
1803         void setXSSAuditorEnabled(in boolean value);
1804         void setAllowFileAccessFromFileURLs(in boolean value);
1805         void setPluginsEnabled(in boolean value);
1806         void setPopupBlockingEnabled(in boolean value);
1807
1808         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1809         (WTR::InjectedBundle::beginTesting):
1810
1811 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1812
1813         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1814         https://bugs.webkit.org/show_bug.cgi?id=96273
1815
1816         Reviewed by Gyuyoung Kim.
1817
1818         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1819         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1820
1821         * WebKitTestRunner/CMakeLists.txt:
1822
1823 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1824
1825         [chromium] rename webkit_resources
1826         https://bugs.webkit.org/show_bug.cgi?id=95874
1827
1828         Reviewed by James Robinson.
1829
1830         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1831
1832 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1833
1834         [chromium] don't include content shell builders in the garden-o-matic view
1835         https://bugs.webkit.org/show_bug.cgi?id=96418
1836
1837         Reviewed by James Robinson.
1838
1839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1840
1841 2012-09-11  Adam Klein  <adamk@chromium.org>
1842
1843         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1844         https://bugs.webkit.org/show_bug.cgi?id=96411
1845
1846         Reviewed by Adam Barth.
1847
1848         Previously only the exact string "warning" was treated as a warning
1849         result. This patch treats any string with "warning" as a substring
1850         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1851
1852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1853         (.):
1854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1855
1856 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1857
1858         Restore original value of mock scrollbars enabled in InternalSettings
1859         https://bugs.webkit.org/show_bug.cgi?id=87680
1860
1861         Reviewed by Adam Barth.
1862
1863         Added backup support for mock scrollbars state in
1864         InternalSettings::Backup, and removed support for these
1865         from Qt's DumpRenderTree.
1866
1867         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1868         (WebCore::WebPage::resetSettings):
1869         * DumpRenderTree/qt/TestRunnerQt.cpp:
1870         (TestRunner::setFrameFlatteningEnabled):
1871         * DumpRenderTree/qt/TestRunnerQt.h:
1872         (TestRunner):
1873
1874 2012-09-11  Dan Bernstein  <mitz@apple.com>
1875
1876         Fixed a bug where kill-old-processes failed to kill clang++.
1877
1878         Rubber-stamped by Alexey Proskuryakov.
1879
1880         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1881         where it is passed as a regular expression to killall.
1882
1883 2012-09-11  Philippe Liard  <pliard@google.com>
1884
1885         Make sure that md5sum is not setup on non-Chromium Android platforms.
1886         https://bugs.webkit.org/show_bug.cgi?id=96393
1887
1888         Reviewed by Adam Barth.
1889
1890         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1891         which is also invoked on non-Chromium Android platforms. The following patch
1892         moves this logic to _startup_test() which is guaranteed to be invoked
1893         only on Android.
1894
1895         This also updates the prompt unit test in chromium_android_unittest.py.
1896
1897         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1898         (ChromiumAndroidDriver.__init__):
1899         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1900         (ChromiumAndroidDriver._setup_test):
1901
1902 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1903
1904         [EFL] Rewrite the EFL-related Find modules
1905         https://bugs.webkit.org/show_bug.cgi?id=95237
1906
1907         Reviewed by Kenneth Rohde Christiansen.
1908
1909         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1910         property and include all the Enlightenment Foundation Libraries
1911         required by the target.
1912         * EWebLauncher/CMakeLists.txt: Ditto.
1913         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1914         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1915         now that they are not added implicitly.
1916         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1917         property.
1918         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1919         property and include all the Enlightenment Foundation Libraries
1920         required by the target.
1921
1922 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1923
1924         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1925         https://bugs.webkit.org/show_bug.cgi?id=96379
1926
1927         Reviewed by Kenneth Rohde Christiansen.
1928
1929         Add implementation for setApplicationCacheOriginQuota
1930         to WebKitTestRunner.
1931
1932         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1933         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1934         (WTR::TestRunner::setApplicationCacheOriginQuota):
1935         (WTR):
1936         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1937         (TestRunner):
1938
1939 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1940
1941         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1942         https://bugs.webkit.org/show_bug.cgi?id=91988
1943
1944         Reviewed by Kenneth Rohde Christiansen.
1945
1946         Regular key events generated by Qt for the tab key fill both
1947         keyCode and keyText, so we should do the same for our fake events.
1948
1949         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1950         (WTR::EventSenderProxy::keyDown):
1951
1952 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1953
1954         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1955         https://bugs.webkit.org/show_bug.cgi?id=96269
1956
1957         Reviewed by Kenneth Rohde Christiansen.
1958
1959         Exported missing testRunner.setSpatialNavigationEnabled() method.
1960
1961         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1962         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1963         (WTR::InjectedBundle::beginTesting):
1964         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1965         (WTR::TestRunner::setSpatialNavigationEnabled):
1966         (WTR):
1967         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1968         (TestRunner):
1969
1970 2012-09-11  Philippe Liard  <pliard@chromium.org>
1971
1972         Support LayoutTests on non-rooted devices for Chromium Android.
1973         https://bugs.webkit.org/show_bug.cgi?id=95346
1974
1975         Reviewed by Dirk Pranke.
1976
1977         We were requiring root permissions to sync resource files with the
1978         device by comparing host and device files' timestamp after we
1979         synchronized the device and host clocks.
1980         We now rely on md5sum provided by Chromium to handle data files
1981         synchronization.
1982
1983         * Scripts/webkitpy/layout_tests/port/chromium.py:
1984         (ChromiumPort._check_driver_build_up_to_date):
1985         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1986         (ChromiumAndroidDriver.__init__):
1987         (ChromiumAndroidDriver._setup_test):
1988         (ChromiumAndroidDriver._push_executable):
1989         (ChromiumAndroidDriver._push_test_resources):
1990         (ChromiumAndroidDriver._read_prompt):
1991
1992 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
1993
1994         [Qt] Fix output paths on Windows
1995
1996         Reviewed by Tor Arne Vestbø.
1997
1998         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
1999         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2000         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2001         incorrect here and instead for the calculation we should use forward slashes.
2002
2003         * qmake/mkspecs/features/default_pre.prf:
2004
2005 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2006
2007         [Qt] Fix passing of defines from the build system
2008
2009         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2010         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2011         will add it's own defaults if the features are not defined.
2012
2013         At some point we might want to run a configure-test to inspect what
2014         Platform.h will do, so we can sync up the build system's view of
2015         the feature-defines with the compile-time situation.
2016
2017         Reviewed by Simon Hausmann.
2018
2019         * qmake/mkspecs/features/functions.prf:
2020
2021 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2022
2023         [Qt] Fix --qt option to build-webkit
2024
2025         Reviewed by Ossy.
2026
2027         * Scripts/webkitdirs.pm:
2028         (buildQMakeProjects):
2029
2030 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2031
2032         [Qt] Add a configure step to the Qt build system
2033
2034         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2035         the build-webkit script is still supported, and will add slightly more
2036         logic to the build, such as detecting the need for clean or incremental
2037         builds.
2038
2039         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2040         all things related to configuring the build, such as use/have/enable flags,
2041         and these are translated to defines in default_post. Project files should
2042         no longer check contains(DEFINES,...) to detect features, but use the new
2043         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2044         options have been translated into WEBKIT_CONFIG options as well, and can
2045         be checked using build?().
2046
2047         Reviewed by Simon Hausmann.
2048
2049         * DumpRenderTree/qt/DumpRenderTree.pro:
2050         * MiniBrowser/qt/MiniBrowser.pro:
2051         * QtTestBrowser/QtTestBrowser.pro:
2052         * Scripts/build-webkit:
2053         * Scripts/webkitdirs.pm:
2054         (qtFeatureDefaults):
2055         (buildQMakeProjects):
2056         * Tools.pro:
2057         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2058         * WebKitTestRunner/InjectedBundle/Target.pri:
2059         * WebKitTestRunner/Target.pri:
2060         * qmake/.qmake.cache: Added.
2061         * qmake/configure.pri: Removed.
2062         * qmake/configure.pro: Removed.
2063         * qmake/dump-features: Added.
2064         * qmake/mkspecs/features/configure.prf: Added.
2065         * qmake/mkspecs/features/default_post.prf:
2066         * qmake/mkspecs/features/default_pre.prf:
2067         * qmake/mkspecs/features/features.prf:
2068         * qmake/mkspecs/features/features.pri:
2069         * qmake/mkspecs/features/functions.prf:
2070         * qmake/mkspecs/features/gprof.prf:
2071         * qmake/mkspecs/features/mac/default_pre.prf:
2072         * qmake/mkspecs/features/win32/default_pre.prf:
2073
2074 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2075
2076         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2077         https://bugs.webkit.org/show_bug.cgi?id=96372
2078
2079         Reviewed by Kenneth Rohde Christiansen.
2080
2081         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2082
2083         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2084         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2085         (WTR::TestRunner::clearApplicationCacheForOrigin):
2086         (WTR):
2087         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2088         (TestRunner):
2089
2090 2012-09-11  Peter Beverloo  <peter@chromium.org>
2091
2092         Don't ignore .pak files when making an archive for Android
2093         https://bugs.webkit.org/show_bug.cgi?id=96375
2094
2095         Reviewed by Jochen Eisinger.
2096
2097         The .pak files do need to be pushed to the device, which is currently
2098         preventing the layout test runner from correctly pushing all files.
2099
2100         * BuildSlaveSupport/built-product-archive:
2101         (archiveBuiltProduct):
2102
2103 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2104
2105         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2106         https://bugs.webkit.org/show_bug.cgi?id=96256
2107
2108         Reviewed by Kenneth Rohde Christiansen.
2109
2110         Exported TestRunner::setMinimumTimerInterval() method.
2111
2112         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2113         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2114         (WTR::InjectedBundle::beginTesting):
2115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2116         (WTR::TestRunner::setMinimumTimerInterval):
2117         (WTR):
2118         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2119         (TestRunner):
2120
2121 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2122
2123         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2124         https://bugs.webkit.org/show_bug.cgi?id=96097
2125
2126         Reviewed by Adam Barth.
2127
2128         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2129         (MockWebRTCPeerConnectionHandler::addStream):
2130         (MockWebRTCPeerConnectionHandler::removeStream):
2131
2132 2012-09-11  Peter Beverloo  <peter@chromium.org>
2133
2134         Recognize the "--chromium-android" argument in run-webkit-tests
2135         https://bugs.webkit.org/show_bug.cgi?id=96369
2136
2137         Reviewed by Jochen Eisinger.
2138
2139         Chromium for the Android platform cannot determine the platform based on
2140         the host itself, so we'll use the --chromium-android argument as the build
2141         master passes to run-webkit-tests. Make sure the layout test runner
2142         can pick the right port when doing so.
2143
2144         * Scripts/run-webkit-tests:
2145         * Scripts/webkitpy/layout_tests/port/factory.py:
2146         (port_options):
2147
2148 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2149
2150         [QT] Fix build with newer qmake from Qt 5
2151
2152         Rubber-stamped by Tor Arne Vestbø.
2153
2154         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2155         it with the use of QT_HOST_DATA/mkspecs.
2156         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2157
2158         * Scripts/webkitdirs.pm:
2159         (builtDylibPathForName):
2160         (qtMakeCommand):
2161
2162 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2163
2164         [Qt] Remove Qt 4 syncqt, no longer needed
2165
2166         Reviewed by Simon Hausmann.
2167
2168         * qmake/syncqt-4.8: Removed.
2169
2170 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2171
2172         [Qt][WK2] Fix the build with recent Qt5
2173         https://bugs.webkit.org/show_bug.cgi?id=96283
2174
2175         Reviewed by Simon Hausmann.
2176
2177         We should not use deprecated Qt API because doing that results
2178         in build failure since all the deprecated API was disabled
2179         in qtbase (https://codereview.qt-project.org/#change,24890).
2180
2181         * DumpRenderTree/qt/main.cpp:
2182         (main):
2183         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2184         (MiniBrowserApplication::notify):
2185         * MiniBrowser/qt/raw/View.cpp:
2186         (View::exposeEvent):
2187         (main):
2188
2189 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2190
2191         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2192         https://bugs.webkit.org/show_bug.cgi?id=87188
2193
2194         Reviewed by Kenneth Rohde Christiansen.
2195
2196         Add implementation for applicationCacheDiskUsageForOrigin()
2197         in WebKitTestRunner.
2198
2199         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2200         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2201         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2202         (WTR):
2203         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2204         (TestRunner):
2205
2206 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2207
2208         Properly expose <legend> elements to ATs
2209         https://bugs.webkit.org/show_bug.cgi?id=84137
2210
2211         Reviewed by Chris Fleizach.
2212
2213         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2214         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2215         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2216
2217         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2218         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2219
2220 2012-09-10  Jer Noble  <jer.noble@apple.com>
2221
2222         Unreviewed; rolling out r128081.
2223         http://trac.webkit.org/changeset/128081
2224         https://bugs.webkit.org/show_bug.cgi?id=96134
2225
2226         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2227
2228         * DumpRenderTree/TestRunner.cpp:
2229         (TestRunner::TestRunner):
2230         (TestRunner::staticFunctions):
2231         * DumpRenderTree/TestRunner.h:
2232         (TestRunner):
2233         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2234         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2235         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2236         (WTR::InjectedBundlePage::InjectedBundlePage):
2237         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2238         (InjectedBundlePage):
2239         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2240         (WTR::TestRunner::TestRunner):
2241         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2242         (TestRunner):
2243
2244 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2245
2246         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2247         https://bugs.webkit.org/show_bug.cgi?id=96205
2248
2249         Reviewed by Tony Chang.
2250
2251         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2252         internally, which means that it would support only 1 TestExpectations file per port. This
2253         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2254         and efl-wk1 -> efl).
2255
2256         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2257         instead so that all the ports TestExpectations are recognized. The ports are also
2258         constructed twice, with "webkit_test_runner" option set to True and False so that we
2259         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2260
2261         * Scripts/webkitpy/style/checkers/test_expectations.py:
2262         (TestExpectationsChecker._determine_port_from_expectations_path):
2263         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2264         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2265
2266 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2267
2268         [WTR] Generated source files should include config.h
2269         https://bugs.webkit.org/show_bug.cgi?id=96254
2270
2271         Reviewed by Benjamin Poulain.
2272
2273         Current coding style has encouraged to include config.h at the first position,
2274         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2275         this rule.
2276         Therefore, this patch added it.
2277
2278         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2279         (_generateImplementationFile):
2280
2281 2012-09-10  Rick Byers  <rbyers@chromium.org>
2282
2283         Add handling of new GestureTapCancel in DRT
2284         
2285         https://bugs.webkit.org/show_bug.cgi?id=96183
2286
2287         Reviewed by Adam Barth.
2288
2289         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2290         (TestWebPlugin::handleInputEvent):
2291
2292 2012-09-10  Brady Eidson  <beidson@apple.com>
2293
2294         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2295         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2296
2297         Reviewed by Geoff Garen.
2298
2299         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2300
2301         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2302         (PluginObject):
2303         (SlowNPPNew::PluginObject::PluginObject):
2304         (SlowNPPNew::PluginObject::~PluginObject):
2305         (SlowNPPNew::PluginObject::hasProperty):
2306         (SlowNPPNew::PluginObject::getProperty):
2307         (SlowNPPNew::NPP_GetValue):
2308         (SlowNPPNew):
2309
2310 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2311
2312         WKTR often reports an unresponsive WebProcess on Mac bots
2313         https://bugs.webkit.org/show_bug.cgi?id=95906
2314
2315         Reviewed by Dan Bernstein.
2316
2317         Attempt to work around resource contention issues by increasing the NRWT
2318         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2319
2320         * Scripts/webkitpy/layout_tests/port/base.py:
2321         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2322         * WebKitTestRunner/TestController.cpp:
2323         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2324
2325 2012-09-07  Jer Noble  <jer.noble@apple.com>
2326
2327         <audio> and <video> should send Do Not Track when appropriate
2328         https://bugs.webkit.org/show_bug.cgi?id=96134
2329
2330         Reviewed by Eric Carlson.
2331
2332         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2333         WTR. Add FrameLoaderClient client methods for retrieving that value.
2334
2335         * DumpRenderTree/TestRunner.cpp:
2336         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2337         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2338         * DumpRenderTree/TestRunner.h:
2339         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2340         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2341         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2342         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2343             Pass the question on to the TestRunner.
2344         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2345         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2346         (WTR::InjectedBundlePage::InjectedBundlePage):
2347             Add the setShouldSendDoNotTrackHTTPHeader client function.
2348         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2349             Pass the question on to the TestRunner.
2350         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2351         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2352         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2353         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2354         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2355
2356 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2357
2358         Make EFL bots work on the flakiness dashboard
2359         https://bugs.webkit.org/show_bug.cgi?id=96164
2360
2361         Reviewed by Tony Chang.
2362
2363         Also, update outdated unittests that had started failing.
2364
2365         * TestResultServer/static-dashboards/builders.js:
2366         (isWebkitTestRunner):
2367         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2368         (nonChromiumPlatform):
2369         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2370         (test):
2371
2372 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
2373
2374         [chromium] MediaStream API: Remove the Descriptor postfix
2375         https://bugs.webkit.org/show_bug.cgi?id=96268
2376
2377         Reviewed by Adam Barth.
2378
2379         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
2380         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
2381
2382         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2383         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2384         (MockWebRTCPeerConnectionHandler::createOffer):
2385         (MockWebRTCPeerConnectionHandler::createAnswer):
2386         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2387         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2388         (MockWebRTCPeerConnectionHandler::localDescription):
2389         (MockWebRTCPeerConnectionHandler::remoteDescription):
2390         (MockWebRTCPeerConnectionHandler::addICECandidate):
2391         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2392         (MockWebRTCPeerConnectionHandler):
2393
2394 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2395
2396         [Gtk] failure to build jhbuild dependencies with cups 1.6
2397         https://bugs.webkit.org/show_bug.cgi?id=95991
2398
2399         Reviewed by Gustavo Noronha Silva.
2400
2401         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2402         building with cups >= 1.6 [GNOME #670373].
2403
2404         * gtk/jhbuild.modules:
2405
2406 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2407
2408         [EFL][DRT] Encoding issue in printed console messages
2409         https://bugs.webkit.org/show_bug.cgi?id=96263
2410
2411         Reviewed by Kenneth Rohde Christiansen.
2412
2413         Correctly handle CONSOLE messages that contain non-ascii
2414         characters in EFL's DRT. We need to use String::fromUTF8()
2415         to construct a WTF::String from a raw string.
2416
2417         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2418         (onConsoleMessage):
2419
2420 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2421
2422         [WK2][WTR] User style sheet location should be reset before each test
2423         https://bugs.webkit.org/show_bug.cgi?id=96262
2424
2425         Reviewed by Kenneth Rohde Christiansen.
2426
2427         User style sheet location is reset before each test now.
2428
2429         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2430         (WTR::InjectedBundle::beginTesting):
2431
2432 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2433
2434         Fix build of WTR with Qt on Windows
2435         https://bugs.webkit.org/show_bug.cgi?id=96249
2436
2437         Reviewed by Kenneth Rohde Christiansen.
2438
2439         Windows loves to define min and max as macros, which beautifully
2440         clashes in many places where min and max are used as variable or method
2441         names. It can be convinced not to do this when min and max are already
2442         define as macros (expanding to themselves). We have this kind of
2443         workaround in config.h files all over WebKit and as it turns out when
2444         building WTR with Qt on Windows we do end up with such a clash. Therefore
2445         we need the same workaround.
2446
2447         * WebKitTestRunner/config.h:
2448
2449 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2450
2451         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2452         https://bugs.webkit.org/show_bug.cgi?id=95936
2453
2454         Reviewed by Kenneth Rohde Christiansen.
2455
2456         Enable interactive form validation setting in WebKitTestRunner as
2457         we are currently doing in DumpRenderTree. This is needed for some
2458         tests to pass.
2459
2460         * WebKitTestRunner/TestController.cpp:
2461         (WTR::TestController::resetStateToConsistentValues):
2462
2463 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2464
2465         Clean up the code in XvfbDriver
2466         https://bugs.webkit.org/show_bug.cgi?id=96202
2467
2468         Reviewed by Philippe Normand.
2469
2470         Changes:
2471         - Remove unneeded imports,
2472         - assign the _lock_file member variable when the display number is determined,
2473         - no need for parentheses around a single string format argument,
2474         - use FileSystem.exists method when checking if lock file is present as it
2475         makes the intention much more clearer.
2476
2477         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2478         (XvfbDriver._start):
2479         (XvfbDriver.stop):
2480
2481 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2482
2483         Make the String initialization on the function side of String::number()
2484         https://bugs.webkit.org/show_bug.cgi?id=95940
2485
2486         Reviewed by Benjamin Poulain.
2487
2488         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2489         (testBoundaries):
2490         (testNumbers):
2491
2492 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2493
2494         [WK2] expose element rect for color input type
2495         https://bugs.webkit.org/show_bug.cgi?id=91664
2496
2497         Reviewed by Simon Hausmann.
2498
2499         Update the QML logic in MiniBrowser to take advantage of this.
2500         The picker size is now hardcoded and we try to place it below the
2501         input element if possible.
2502
2503         * MiniBrowser/qt/qml/ColorChooser.qml:
2504
2505 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2506
2507         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2508         https://bugs.webkit.org/show_bug.cgi?id=95329
2509
2510         Reviewed by Kenneth Rohde Christiansen.
2511
2512         Explicitely disable TabToLinks setting in WebKitTestRunner.
2513         Tests override the "WebKitTabToLinksPreferenceKey" preference
2514         to enable it.
2515
2516         * WebKitTestRunner/TestController.cpp:
2517         (WTR::TestController::resetStateToConsistentValues):
2518
2519 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2520
2521         webkit.py gdb pretty printer can't print CString
2522         https://bugs.webkit.org/show_bug.cgi?id=96068
2523
2524         Reviewed by Tony Chang.
2525
2526         Update WTFCStringPrinter to follow r126191.
2527
2528         * gdb/webkit.py:
2529         (WTFCStringPrinter.to_string):
2530
2531 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2532
2533         Rename the ustring() accessor to string()
2534         https://bugs.webkit.org/show_bug.cgi?id=95919
2535
2536         Reviewed by Geoffrey Garen.
2537
2538         Update EFL's DRT.
2539
2540         Fix some string conversion that have been made useless
2541         with recent changes.
2542
2543         * DumpRenderTree/efl/EventSender.cpp:
2544         (keyPadNameFromJSValue):
2545         (keyNameFromJSValue):
2546         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2547         (TestRunner::queueLoad):
2548         (TestRunner::addOriginAccessWhitelistEntry):
2549         (TestRunner::removeOriginAccessWhitelistEntry):
2550         (TestRunner::setUserStyleSheetLocation):
2551         (TestRunner::setValueForUser):
2552         (TestRunner::elementDoesAutoCompleteForElementWithId):
2553         (TestRunner::execCommand):
2554         (TestRunner::findString):
2555         (TestRunner::isCommandEnabled):
2556         (TestRunner::clearApplicationCacheForOrigin):
2557         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2558         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2559         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2560         (toInt):
2561         (TestRunner::overridePreference):
2562         (TestRunner::addUserScript):
2563         (TestRunner::addUserStyleSheet):
2564         (TestRunner::evaluateInWebInspector):
2565         (TestRunner::evaluateScriptInIsolatedWorld):
2566         (TestRunner::setTextDirection):
2567         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2568         (LoadItem::invoke):
2569         (LoadHTMLStringItem::invoke):
2570         (ScriptItem::invoke):
2571
2572 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2573
2574         Extend third-party storage blocking API to optionally allow blocking all storage
2575         https://bugs.webkit.org/show_bug.cgi?id=95915
2576
2577         Reviewed by Brady Eidson.
2578
2579         Modified API test to use new revised API.
2580
2581         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2582         (TestWebKitAPI::TEST):
2583
2584 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2585
2586         AX: WebCore accessibility roles should be cross-platform
2587         https://bugs.webkit.org/show_bug.cgi?id=94870
2588
2589         Reviewed by Chris Fleizach.
2590
2591         Add debug strings to Chromium for new accessibility roles.
2592
2593         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2594         (roleToString):
2595
2596 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2597
2598         AX: Chromium needs access to canvasHasFallbackContent
2599         https://bugs.webkit.org/show_bug.cgi?id=96124
2600
2601         Reviewed by Chris Fleizach.
2602
2603         Distinguish between canvas roles with and without fallback
2604         content on Chromium.
2605
2606         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2607         (getRole):
2608
2609 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2610
2611         Handle non-existant TestExpectations files gracefully
2612         https://bugs.webkit.org/show_bug.cgi?id=96149
2613
2614         Reviewed by Eric Seidel.
2615
2616         Even when we get rid of Skipped files, we shouldn't have each port
2617         require a TestExpectations file for each platform if it doesn't
2618         need one.
2619
2620         * Scripts/webkitpy/layout_tests/port/base.py:
2621         (Port.expectations_dict):
2622         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2623         (PortTest.test_nonexistant_expectations):
2624
2625 2012-09-07  Tony Chang  <tony@chromium.org>
2626
2627         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2628         https://bugs.webkit.org/show_bug.cgi?id=96136
2629
2630         Reviewed by Ojan Vafai.
2631
2632         When we renamed the file to TestExpectations, it was no longer considered a text file so
2633         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2634         from the port object, so I've removed that from the check. I'm not sure what it was
2635         supposed to do.
2636
2637         * Scripts/webkitpy/style/checker.py:
2638         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2639         * Scripts/webkitpy/style/checkers/test_expectations.py:
2640         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2641         (TestExpectationsChecker.check): Remove overrides param.
2642         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2643         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2644
2645 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2646
2647         [EFL] Use same default minimum logical font size in DRT and WTR
2648         https://bugs.webkit.org/show_bug.cgi?id=96116
2649
2650         Reviewed by Martin Robinson.
2651
2652         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2653         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2654         logical font size to 9 to match the value used in WTR.
2655         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2656         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2657         logical font size to 9 (default value in WK2)
2658
2659 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2660
2661         MediaStream API: add RTCPeerConnection::createAnswer
2662         https://bugs.webkit.org/show_bug.cgi?id=96092
2663
2664         Reviewed by Adam Barth.
2665
2666         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2667
2668         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2669         (MockWebRTCPeerConnectionHandler::createOffer):
2670         (MockWebRTCPeerConnectionHandler::createAnswer):
2671         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2672         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2673         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2674         (MockWebRTCPeerConnectionHandler):
2675
2676 2012-09-07  Dean Jackson  <dino@apple.com>
2677
2678         Unreviewed changes to watchlist.
2679
2680         - Add new WebGL and Filters definitions
2681         - Add myself to OpenGL bugs
2682
2683         * Scripts/webkitpy/common/config/watchlist:
2684
2685 2012-09-07  Peter Beverloo  <peter@chromium.org>
2686
2687         Actually trigger the Android Tester
2688         https://bugs.webkit.org/show_bug.cgi?id=96118
2689
2690         Reviewed by Adam Barth.
2691
2692         * BuildSlaveSupport/build.webkit.org-config/config.json:
2693
2694 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2695
2696         New time input needs accessibility
2697         https://bugs.webkit.org/show_bug.cgi?id=96032
2698
2699         Reviewed by Chris Fleizach.
2700
2701         Add support for valueDescription for testing.
2702
2703         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2704         (getValueDescription):
2705         (AccessibilityUIElement::AccessibilityUIElement):
2706         (AccessibilityUIElement::valueDescriptionGetterCallback):
2707         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2708         (AccessibilityUIElement):
2709
2710 2012-09-07  Peter Beverloo  <peter@chromium.org>
2711
2712         Add the google-android-tests build slave to the master's config
2713         https://bugs.webkit.org/show_bug.cgi?id=96113
2714
2715         Reviewed by Csaba Osztrogonác.
2716
2717         * BuildSlaveSupport/build.webkit.org-config/config.json:
2718
2719 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2720
2721         [WK2] [EFL] Set theme for WebKit2 API test runner
2722         https://bugs.webkit.org/show_bug.cgi?id=96100
2723
2724         Reviewed by Kenneth Rohde Christiansen.
2725
2726         Set the theme generated by the build for the WebKit2 API test runner.
2727
2728         * TestWebKitAPI/PlatformEfl.cmake:
2729         * TestWebKitAPI/efl/PlatformWebView.cpp:
2730         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2731
2732 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2733
2734         Unreviewed. Add Gábor Ballabás as contributor.
2735
2736         * Scripts/webkitpy/common/config/committers.py:
2737
2738 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2739
2740         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2741         https://bugs.webkit.org/show_bug.cgi?id=96078
2742
2743         Reviewed by Tor Arne Vestbø.
2744
2745         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2746
2747         * qmake/mkspecs/features/default_pre.prf:
2748
2749 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2750
2751         [EFL] Add TestExpectations file for efl-wk1
2752         https://bugs.webkit.org/show_bug.cgi?id=96019
2753
2754         Reviewed by Gyuyoung Kim.
2755
2756         Update TestExpectations cascading for EFL port
2757         so that we use efl-wk1 -> efl search paths
2758         for WebKit1 EFL.
2759
2760         * Scripts/webkitpy/layout_tests/port/efl.py:
2761         (EflPort._search_paths):
2762
2763 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2764
2765         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2766         https://bugs.webkit.org/show_bug.cgi?id=95097
2767
2768         Reviewed by Dirk Pranke.
2769
2770         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2771         terminating the process does not always work as expected, leading to timeouts
2772         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2773         as it's not removed by the killed Xvfb process.
2774
2775         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2776         is tested in different circumstances - whether pixel tests are enabled or not,
2777         with an arbitrary worker number or with an Xorg process already running on the system.
2778         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2779         and then set to None.
2780
2781         * BuildSlaveSupport/kill-old-processes:
2782         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2783         is left running, potentially clogging up a display at a certain position.
2784         * Scripts/webkitpy/common/system/executive_mock.py:
2785         (MockExecutive.__init__):
2786         The _running_pids is now a dictionary with process names as keys and pids
2787         as values.
2788         (MockExecutive.check_running_pid):
2789         Check whether the passed-in pid is in the _running_pids dictionary's values.
2790         (MockExecutive):
2791         (MockExecutive.running_pids):
2792         This method returns the list of all the process pids of which the name passes
2793         through the process_name_filter.
2794         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2795         Use the Executive object of the port's host to check for running pids and open
2796         new subprocesses or kill them throughout the class.
2797         (XvfbDriver._start):
2798         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2799         start the server process after it's created.
2800         (XvfbDriver.stop):
2801         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2802         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2803         (XvfbDriverTest):
2804         (XvfbDriverTest.make_driver):
2805         (XvfbDriverTest.assertDriverStartSuccessful):
2806         (XvfbDriverTest.test_start_no_pixel_tests):
2807         (XvfbDriverTest.test_start_pixel_tests):
2808         (XvfbDriverTest.test_start_arbitrary_worker_number):
2809         (XvfbDriverTest.test_start_existing_xorg_process):
2810         (XvfbDriverTest.test_stop):
2811         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2812
2813 2012-09-06  Peter Beverloo  <peter@chromium.org>
2814
2815         Introduce the Chromium Android Release (Tests) bot
2816         https://bugs.webkit.org/show_bug.cgi?id=95980
2817
2818         Reviewed by Adam Barth.
2819
2820         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2821         which will be running layout tests on actual Android devices. Right now,
2822         four Galaxy Nexus phones are attached.
2823
2824         * BuildSlaveSupport/build.webkit.org-config/config.json:
2825
2826 2012-09-06  James Robinson  <jamesr@chromium.org>
2827
2828         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2829         https://bugs.webkit.org/show_bug.cgi?id=96007
2830
2831         Reviewed by Adrienne Walker.
2832
2833         Fixes initialization / settings code to use WebCompositorSupport.
2834
2835         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2836         (main):
2837         * DumpRenderTree/chromium/TestShell.cpp:
2838         (TestShell::initialize):
2839         (TestShell::setPerTilePaintingEnabled):
2840
2841 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2842
2843         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2844         https://bugs.webkit.org/show_bug.cgi?id=95995
2845
2846         Reviewed by Kenneth Rohde Christiansen.
2847
2848         Provide proper implementation for PlatformWebView::windowFrame()
2849         in EFL's WebKitTestRunner.
2850
2851         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2852         (WTR::PlatformWebView::windowFrame):
2853
2854 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2855
2856         Fix WTF.Lrint on 32-bit platforms
2857         https://bugs.webkit.org/show_bug.cgi?id=96003
2858
2859         Reviewed by Benjamin Poulain.
2860
2861         Fixed failing WTF.Lrint test on 32-bit platforms.
2862
2863         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2864         (TestWebKitAPI::TEST):
2865
2866 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2867
2868         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2869         https://bugs.webkit.org/show_bug.cgi?id=95839
2870
2871         Reviewed by Adam Barth.
2872
2873         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2874         up the task definitions a bit. There was no need to have them in the header file.
2875
2876         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2877         (RTCSessionDescriptionRequestSuccededTask):
2878         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2879         (RTCSessionDescriptionRequestFailedTask):
2880         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2881         (RTCVoidRequestTask):
2882         (RTCVoidRequestTask::RTCVoidRequestTask):
2883         (MockWebRTCPeerConnectionHandler::createOffer):
2884         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2885         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2886         (MockWebRTCPeerConnectionHandler::localDescription):
2887         (MockWebRTCPeerConnectionHandler::remoteDescription):
2888         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2889         (MockWebRTCPeerConnectionHandler):
2890
2891 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2892
2893         [Qt] Fix build on Mac OS X 10.6
2894         https://bugs.webkit.org/show_bug.cgi?id=95200
2895
2896         Reviewed by Tor Arne Vestbø.
2897
2898         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2899         10.7 and newer.
2900
2901         * qmake/mkspecs/features/features.prf:
2902
2903 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2904
2905         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2906         https://bugs.webkit.org/show_bug.cgi?id=95973
2907
2908         Reviewed by Kenneth Rohde Christiansen.
2909
2910         Correctly map "addSelectionKey" to "Control" modifier
2911         in WKTR's EventSender on other OSes than Mac OS X,
2912         instead of mapping it to the "Meta" modifier.
2913
2914         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2915         (WTR::parseModifier):
2916
2917 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2918
2919         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2920         https://bugs.webkit.org/show_bug.cgi?id=95710
2921
2922         Reviewed by Dirk Pranke.
2923
2924         The stdout / stderr output can be None so make sure
2925         we won't raise an exception in this case.
2926
2927         * Scripts/webkitpy/layout_tests/port/driver.py:
2928         (Driver.run_test):
2929
2930 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2931
2932         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2933         https://bugs.webkit.org/show_bug.cgi?id=95849
2934
2935         Reviewed by Kenneth Rohde Christiansen.
2936
2937         Sanitize URLs passed by the user as program
2938         argument or typed in the URL bar in order to
2939         be more tolerant.
2940
2941         * EWebLauncher/CMakeLists.txt:
2942         * EWebLauncher/main.c:
2943         (main):
2944         * EWebLauncher/url_bar.c:
2945         (_url_bar_url_get_with_protocol):
2946         (on_urlbar_key_down):
2947         * EWebLauncher/url_utils.c: Added.
2948         (has_scheme):
2949         (url_from_user_input): Add utility function to construct a
2950         URL from user input.
2951         * EWebLauncher/url_utils.h: Added.
2952         * MiniBrowser/efl/CMakeLists.txt:
2953         * MiniBrowser/efl/main.c:
2954         (main):
2955
2956 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2957
2958         [Qt] Various small Windows / MSVC build fixes
2959         https://bugs.webkit.org/show_bug.cgi?id=95934
2960
2961         Reviewed by Kenneth Rohde Christiansen.
2962
2963         setFocus takes a boolean as argument: Don't try to implicitly convert
2964         an enum to a boolean, MSVC doesn't like that. The intent here is to
2965         enable focus, so just pass true.
2966
2967         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2968         (WTR::PlatformWebView::focus):
2969
2970 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2971
2972         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
2973         https://bugs.webkit.org/show_bug.cgi?id=95965
2974
2975         Reviewed by Tor Arne Vestbø.
2976
2977         Add ANGLE as a static library module to the Qt WebKit build system.
2978
2979         * qmake/mkspecs/features/default_post.prf:
2980         * qmake/mkspecs/modules/angle.prf: Added.
2981
2982 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
2983
2984         [WK2] Make [Qt]ViewportHandler cross platform
2985         https://bugs.webkit.org/show_bug.cgi?id=91257
2986
2987         Reviewed by Kenneth Rohde Christiansen.
2988
2989         Remove initial scale from viewport info item since it is
2990         set to -1 after applied thus it does not hold any valuable
2991         information.
2992
2993         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
2994
2995 2012-09-05  Tony Chang  <tony@chromium.org>
2996
2997         [chromium] Remove dependency on webkit_user_agent
2998         https://bugs.webkit.org/show_bug.cgi?id=95886
2999
3000         Reviewed by Adam Barth.
3001
3002         The code isn't used by DumpRenderTree.
3003
3004         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3005
3006 2012-09-05  Rick Byers  <rbyers@chromium.org>
3007
3008         Update chromium DumpRenderTree for new WebGestureEvent fields
3009         https://bugs.webkit.org/show_bug.cgi?id=95573
3010
3011         Reviewed by James Robinson.
3012
3013         Update EventSender to write gesture details into the appropriate
3014         type-specific WebGestureEvent fields.
3015         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3016         (EventSender::gestureEvent):
3017         (EventSender::gestureFlingStart):
3018
3019 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
3020
3021         NRWT lies about the number of tests that it's skipping when used with --repeat-each
3022         https://bugs.webkit.org/show_bug.cgi?id=95789
3023
3024         Reviewed by Ojan Vafai.
3025
3026         Fix miscalculation in log message.
3027
3028         * Scripts/webkitpy/layout_tests/views/printing.py:
3029         (Printer.print_found):
3030
3031 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
3032
3033         Unreviewed, rolling out r127612, r127660, and r127664.
3034         http://trac.webkit.org/changeset/127612
3035         http://trac.webkit.org/changeset/127660
3036         http://trac.webkit.org/changeset/127664
3037         https://bugs.webkit.org/show_bug.cgi?id=95920
3038
3039         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3040         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3041         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3042         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3043         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3044         (MockWebRTCPeerConnectionHandler::createOffer):
3045         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3046         (MockWebRTCPeerConnectionHandler):
3047         (SuccessCallbackTask):
3048         (FailureCallbackTask):
3049
3050 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3051
3052         Ignore-metrics includes scroll offsets.
3053         https://bugs.webkit.org/show_bug.cgi?id=95845
3054
3055         Reviewed by Dirk Pranke.
3056
3057         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
3058
3059         * Scripts/old-run-webkit-tests:
3060         (stripMetrics):
3061         * Scripts/webkitpy/layout_tests/port/driver.py:
3062         (DriverOutput):
3063
3064 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
3065
3066         Unreviewed test fix.
3067
3068         Including a plugin source file into the build that was added in r127595.
3069
3070         * GNUmakefile.am:
3071
3072 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
3073
3074         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3075         https://bugs.webkit.org/show_bug.cgi?id=95839
3076
3077         Reviewed by Adam Barth.
3078
3079         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3080         up the task definitions a bit. There was no need to have them in the header file.
3081
3082         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3083         (RTCSessionDescriptionRequestSuccededTask):
3084         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3085         (RTCSessionDescriptionRequestFailedTask):
3086         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3087         (RTCVoidRequestTask):
3088         (RTCVoidRequestTask::RTCVoidRequestTask):
3089         (MockWebRTCPeerConnectionHandler::createOffer):
3090         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3091         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3092         (MockWebRTCPeerConnectionHandler::localDescription):
3093         (MockWebRTCPeerConnectionHandler::remoteDescription):
3094         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3095         (MockWebRTCPeerConnectionHandler):
3096
3097 2012-09-05  Kangil Han  <kangil.han@samsung.com>
3098
3099         [EFL] Remove '+=' usage in String
3100         https://bugs.webkit.org/show_bug.cgi?id=95808
3101
3102         Reviewed by Benjamin Poulain.
3103
3104         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
3105
3106         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3107         (descriptionSuitableForTestResult):
3108
3109 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3110
3111         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
3112         https://bugs.webkit.org/show_bug.cgi?id=95842
3113
3114         Reviewed by Kenneth Rohde Christiansen.
3115
3116         Provide proper implementation for TestRunner::pathToLocalResource()
3117         in EFL WKTR, identical to the one for DumpRenderTree.
3118
3119         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3120         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3121         are found my WebKitTestRunner.
3122
3123         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3124         (WTR::TestRunner::pathToLocalResource):
3125
3126 2012-09-05  Brady Eidson  <beidson@apple.com>
3127
3128         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3129         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3130
3131         Reviewed by Andy Estes.
3132
3133         Add a plug-in that always fails to initialize:
3134         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3135         (NPPNewFails):
3136         (NPPNewFails::NPPNewFails):
3137         (NPPNewFails::NPP_New):
3138
3139         Add it to all the project files:
3140         * DumpRenderTree/DumpRenderTree.gypi:
3141         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3142         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3143         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3144         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3145
3146 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3147
3148         [Qt] Fix makefile race condition between derived sources and target
3149
3150         r121966 removed too much of the old qmake logic, including the rule
3151         that ensured that qmake_all would not trigger dual runs of qmake --
3152         one of the derived sources -qmake-all rule, and one for making the
3153         derived sources.
3154
3155         We now follow a similar pattern as before, by introducing a custom
3156         target that explicitly depends on the derived sources' qmake-all before
3157         doing a manual run of make. That ensures a single qmake run for the derived
3158         sources.
3159
3160         https://bugs.webkit.org/show_bug.cgi?id=93847
3161
3162         Reviewed by Csaba Osztrogonác.
3163
3164         * qmake/mkspecs/features/functions.prf:
3165
3166 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3167
3168         WKTR doesn't implement dumpWillCacheResponse()
3169         https://bugs.webkit.org/show_bug.cgi?id=94607
3170
3171         Reviewed by Kenneth Rohde Christiansen.
3172
3173         Define shouldCacheResponse() callback in resource
3174         load client and provide implementation for
3175         dumpWillCacheResponse() in WebKitTestRunner.
3176
3177         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3178         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3179         (WTR::InjectedBundlePage::InjectedBundlePage):
3180         (WTR::InjectedBundlePage::shouldCacheResponse):
3181         (WTR):
3182         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3183         (InjectedBundlePage):
3184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3185         (WTR::TestRunner::TestRunner):
3186         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3187         (WTR::TestRunner::dumpWillCacheResponse):
3188         (WTR::TestRunner::shouldDumpWillCacheResponse):
3189         (TestRunner):
3190
3191 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3192
3193         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3194         https://bugs.webkit.org/show_bug.cgi?id=92735
3195
3196         Reviewed by Hajime Morita.
3197
3198         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3199
3200         * DumpRenderTree/TestRunner.cpp:
3201         (TestRunner::staticFunctions):
3202         * DumpRenderTree/TestRunner.h:
3203         (TestRunner):
3204         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3205         (TestRunner::addUserStyleSheet):
3206         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3207         (DRTTestRunner::DRTTestRunner):
3208         (DRTTestRunner::hasCustomPageSizeStyle):
3209         * DumpRenderTree/chromium/DRTTestRunner.h:
3210         (DRTTestRunner):
3211         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3212         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3213         * DumpRenderTree/mac/TestRunnerMac.mm:
3214         * DumpRenderTree/qt/TestRunnerQt.cpp:
3215         (TestRunner::evaluateScriptInIsolatedWorld):
3216         * DumpRenderTree/qt/TestRunnerQt.h:
3217         (TestRunner):
3218         * DumpRenderTree/win/TestRunnerWin.cpp:
3219         * DumpRenderTree/wx/TestRunnerWx.cpp:
3220         (TestRunner::abortModal):
3221         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3222         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3223         (WTR):
3224         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3225         (TestRunner):
3226
3227 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3228
3229         [Qt] Automate the use of AllInOne files in the Qt build
3230         https://bugs.webkit.org/show_bug.cgi?id=95837
3231
3232         Reviewed by Tor Arne Vestbø.
3233
3234         New feature file that implements the all-in-one file automation by
3235         adding the requested all-in-one files to SOURCES and removing the files
3236         it includes from SOURCES.
3237
3238         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3239
3240 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3241
3242         Have NRWT log more output when crash logs are missing
3243         https://bugs.webkit.org/show_bug.cgi?id=95814
3244
3245         Reviewed by Dan Bernstein.
3246
3247         Log the stderr and stdout of the test, in order to provide slightly more
3248         context when the WebProcess times out while running tests.
3249
3250         * Scripts/webkitpy/layout_tests/port/driver.py:
3251         (Driver.run_test):
3252
3253 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3254
3255         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3256         https://bugs.webkit.org/show_bug.cgi?id=95770
3257
3258         Reviewed by Adam Barth.
3259
3260         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3261         (ChromiumAndroidDriver.__init__):
3262         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3263         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3264         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3265         (ChromiumAndroidDriver._push_executable):
3266         (ChromiumAndroidDriver._push_fonts):
3267         (ChromiumAndroidDriver._push_test_resources):
3268         (ChromiumAndroidDriver._run_adb_command):
3269         (ChromiumAndroidDriver._get_last_stacktrace):
3270         (ChromiumAndroidDriver._get_crash_log):
3271         (ChromiumAndroidDriver._start):
3272         (ChromiumAndroidDriver._start_once):
3273         (ChromiumAndroidDriver._start_once.deadlock_detector):
3274         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3275         (ChromiumAndroidDriverTest.test_get_crash_log):
3276
3277 2012-09-04  Satish Sampath  <satish@chromium.org>
3278
3279         Run git commands within the checkout directory
3280         https://bugs.webkit.org/show_bug.cgi?id=95742
3281
3282         Reviewed by Eric Seidel.
3283
3284         git commands run from scm/git.py are sometimes run with cwd set to the
3285         checkout_root and other times with whatever directory was the default cwd.
3286         Instead all these should run with the checkout root set as the cwd
3287         (except where we explicitly need a different path)
3288
3289         * Scripts/webkitpy/common/checkout/scm/git.py:
3290         (Git._run_git):
3291         (Git.find_checkout_root):
3292         (Git.discard_local_commits):
3293         (Git.local_commits):
3294         (Git.working_directory_is_clean):
3295         (Git.clean_working_directory):
3296         (Git.add_list):
3297         (Git.delete_list):
3298         (Git.exists):
3299         (Git._current_branch):
3300         (Git._changes_files_for_commit):
3301         (Git.revisions_changing_file):
3302         (Git.svn_revision):
3303         (Git._run_git_svn_find_rev):
3304         (Git.contents_at_revision):
3305         (Git.diff_for_file):
3306         (Git.show_head):
3307         (Git.committer_email_for_revision):
3308         (Git.apply_reverse_diff):
3309         (Git.revert_files):
3310         (Git.commit_with_message):
3311         (Git._commit_on_branch):
3312         (Git.svn_commit_log):
3313         (Git.last_svn_commit_log):
3314         (Git.svn_blame):
3315         (Git._branch_ref_exists):
3316         (Git.delete_branch):
3317         (Git.remote_merge_base):
3318         (Git.commit_locally_with_message):
3319         (Git.push_local_commits_to_server):
3320         (Git.commit_ids_from_commitish_arguments):
3321         (Git.commit_message_for_local_commit):
3322         (Git.files_changed_summary_for_commit):
3323
3324 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3325
3326         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3327         https://bugs.webkit.org/show_bug.cgi?id=95734
3328
3329         Reviewed by Adam Barth.
3330
3331         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3332         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3333         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3334         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3335         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3336         (MockWebRTCPeerConnectionHandler::createOffer):
3337         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3338         (MockWebRTCPeerConnectionHandler):
3339         (MockWebRTCPeerConnectionHandler::taskList):
3340         (SuccessCallbackTask):
3341         (FailureCallbackTask):
3342
3343 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3344
3345         [Chromium-Android] Output time and thread info in crash log
3346         https://bugs.webkit.org/show_bug.cgi?id=95768
3347
3348         Reviewed by Adam Barth.
3349
3350         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3351         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
3352
3353 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3354
3355         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3356         https://bugs.webkit.org/show_bug.cgi?id=95721
3357
3358         Reviewed by Adam Barth.
3359
3360         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3361         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
3362         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3363         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3364         (MockWebMediaStreamCenter):
3365
3366 2012-09-04  Tony Chang  <tony@chromium.org>
3367
3368         Elide test names when running new-run-webkit-tests
3369         https://bugs.webkit.org/show_bug.cgi?id=95626
3370
3371         Reviewed by Dirk Pranke.
3372
3373         When the test name exceeds the number of terminal columns, it leaves
3374         text on the screen. Avoid this by eliding the test name when running
3375         tests. This is similar to what ninja does when compiling.
3376
3377         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3378         (MeteredStream):
3379         (MeteredStream.number_of_columns): Helper method to get number of
3380         terminal columns. Won't work on Win32 python, but meh.
3381         * Scripts/webkitpy/layout_tests/views/printing.py:
3382         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
3383         because stderr appears to be ascii only.
3384         (Printer.print_started_test): Route through _test_status_line.
3385         (Printer.print_finished_test): Route through _test_status_line.
3386         (Printer._print_test_trace): Route through _test_status_line.
3387         (Printer._print_baseline): Route through _test_status_line.
3388         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3389         (test_test_status_line): Test for _test_status_line.
3390
3391 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
3392
3393         [GTK] Print API missing documentation when generating gtkdoc
3394         https://bugs.webkit.org/show_bug.cgi?id=95703
3395
3396         Reviewed by Carlos Garcia Campos.
3397
3398         Print out API missing documentation when generating gtkdoc. This makes it
3399         easier to fix documentation errors.
3400
3401         * gtk/generate-gtkdoc:
3402         (print_missing_api): Added.
3403         (generate_doc): Inline the rebase step, since it now reports an error
3404         when you try to rebase without generating documentation first.
3405         * gtk/gtkdoc.py:
3406         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
3407         generating documentation first to enable a small cleanup at the caller.
3408         (GTKDoc.api_missing_documentation): Added.
3409
3410 2012-09-04  Vincent Scheib  <scheib@chromium.org>
3411
3412         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
3413         https://bugs.webkit.org/show_bug.cgi?id=95628
3414
3415         Reviewed by James Robinson.
3416
3417         Future tests need the ability to respond asynchronously that
3418         pointer lock requests have been accepted or rejected. This patch
3419         adds the following:
3420             testRunner.setPointerLockWillRespondAsynchronously();
3421             testRunner.didAcquirePointerLock();
3422             testRunner.didNotAcquirePointerLock();
3423
3424         Tested in existing test:
3425             pointerlockchange-pointerlockerror-events.html
3426
3427         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3428         (DRTTestRunner::DRTTestRunner):
3429         (DRTTestRunner::didAcquirePointerLock):
3430         (DRTTestRunner::didNotAcquirePointerLock):
3431         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
3432         * DumpRenderTree/chromium/DRTTestRunner.h:
3433         (DRTTestRunner):
3434         * DumpRenderTree/chromium/WebViewHost.cpp:
3435         (WebViewHost::requestPointerLock):
3436         (WebViewHost::didAcquirePointerLock):
3437         (WebViewHost::didNotAcquirePointerLock):
3438         * DumpRenderTree/chromium/WebViewHost.h:
3439         (WebViewHost):
3440         (WebViewHost::setPointerLockWillRespondAsynchronously):
3441
3442 2012-09-04  Ojan Vafai  <ojan@chromium.org>
3443
3444         Move content shell bots to their own builder group
3445         https://bugs.webkit.org/show_bug.cgi?id=95765
3446
3447         Reviewed by Adam Barth.
3448
3449         In their current state of instability, they add too much noise. Once they get more stable,
3450         we can add them back to the regular group or just have them replace the other bots.
3451
3452         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
3453
3454         * TestResultServer/static-dashboards/builders.js:
3455         (isWebkitTestRunner):
3456         (isChromiumContentShellTestRunner):
3457         (isChromiumWebkitTipOfTreeTestRunner):
3458         (loadBuildersList):
3459
3460 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
3461
3462         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
3463         https://bugs.webkit.org/show_bug.cgi?id=95689
3464
3465         Reviewed by Kenneth Rohde Christiansen.
3466
3467         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
3468         So, there are bugs that key events are always generated in url bar although
3469         the user clicked the web view.
3470
3471         This patch recovers the focus of the web view when left button is pressed and
3472         adds for MiniBrowser to toggle the focus when middle button is pressed
3473         like EWebLauncher already did.
3474
3475         * EWebLauncher/main.c:
3476         (on_mouse_down):
3477         * MiniBrowser/efl/main.c:
3478         (on_mouse_down):
3479         (browserCreate):
3480
3481 2012-09-03  Tao Bai  <michaelbai@chromium.org>
3482
3483         Added ANDROID_GDBSERVER definition for Ant
3484         https://bugs.webkit.org/show_bug.cgi?id=95265
3485
3486         Reviewed by Adam Barth.
3487
3488         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
3489         is only used for finding the gdbserver.
3490
3491         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3492         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3493
3494 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
3495
3496         MediaStream API: Add Ice-related functionality to RTCPeerConnection
3497         https://bugs.webkit.org/show_bug.cgi?id=95565
3498
3499         Reviewed by Adam Barth.
3500
3501         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3502         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3503         (MockWebRTCPeerConnectionHandler::updateICE):
3504         (MockWebRTCPeerConnectionHandler::addICECandidate):
3505         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3506         (MockWebRTCPeerConnectionHandler):
3507
3508 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
3509
3510         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
3511         https://bugs.webkit.org/show_bug.cgi?id=95670
3512
3513         Reviewed by Kenneth Rohde Christiansen.
3514
3515         Fix layout issues related to the URL bar in Minibrowser
3516         and EWebLauncher when the window is resized.
3517
3518         The URL bar was not resized accordingly and the Web
3519         page was moved behing the URL bar, hiding part of it.
3520
3521         * EWebLauncher/main.c:
3522         (on_ecore_evas_resize):
3523         (closeWindow):
3524         * EWebLauncher/url_bar.c:
3525         (url_bar_width_set):
3526         (url_bar_add):
3527         * EWebLauncher/url_bar.h:
3528         * MiniBrowser/efl/main.c:
3529         (on_ecore_evas_resize):
3530         (main):
3531
3532 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3533
3534         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3535         https://bugs.webkit.org/show_bug.cgi?id=95605
3536
3537         Reviewed by Dirk Pranke.
3538
3539         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3540
3541         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3542         (ChromiumAndroidPort.check_sys_deps):
3543         (ChromiumAndroidPort.expectations_files):
3544         (ChromiumAndroidPort.clean_up_test_run):
3545
3546 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3547
3548         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3549         https://bugs.webkit.org/show_bug.cgi?id=95180
3550
3551         Reviewed by Chris Fleizach.
3552
3553         The bug that was fixed stood in the way of fully implementing stringValue().
3554         Testing that the bug is fixed requires stringValue() to be fully implemented
3555         and object replacement characters to be printable.
3556
3557         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3558         (replaceCharactersForResults): New method which turns object replacement
3559         characters into "<obj>" so that the characters can be properly shown in
3560         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3561         accessible text of a single object in the accessible tree doesn't mess up
3562         the readibility of the results.
3563         (AccessibilityUIElement::stringValue): Remove the code that immediately
3564         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3565         replaceCharactersForResults() prior to returning the accessible string
3566         value.
3567
3568 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3569
3570         MediaStream API: Add MediaStream management to RTCPeerConnection
3571         https://bugs.webkit.org/show_bug.cgi?id=95543
3572
3573         Reviewed by Adam Barth.
3574
3575         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
3576
3577         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3578         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3579         (MockWebRTCPeerConnectionHandler::addStream):
3580         (MockWebRTCPeerConnectionHandler::removeStream):
3581         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3582         (MockWebRTCPeerConnectionHandler):
3583
3584 2012-08-31  Tony Chang  <tony@chromium.org>
3585
3586         Remove ENABLE_CSS3_FLEXBOX compile time flag
3587         https://bugs.webkit.org/show_bug.cgi?id=95382
3588
3589         Reviewed by Ojan Vafai.
3590
3591         Everyone is already enabling this by default and the spec has stablized.
3592
3593         * Scripts/webkitperl/FeatureList.pm:
3594         * qmake/mkspecs/features/features.pri:
3595
3596 2012-08-31  Pratik Solanki  <psolanki@apple.com>
3597
3598         objc_msgSend and IMP should be cast appropriately before using
3599         https://bugs.webkit.org/show_bug.cgi?id=95242
3600
3601         Reviewed by Benjamin Poulain.
3602
3603         Fix for older compilers. Pass id as the return type to the template
3604         instead of relying on default type.
3605
3606         * DumpRenderTree/mac/DumpRenderTree.mm:
3607         (drt_NSFontManager_availableFontFamilies):
3608         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3609         (WTR::wtr_NSFontManager_availableFontFamilies):
3610
3611 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
3612
3613         nrwt: use scm instead of calling svn directly to get the revision in json results generator
3614         https://bugs.webkit.org/show_bug.cgi?id=89616
3615
3616         Reviewed by Eric Seidel.
3617
3618         Add the new 'executive' optional function argument to the SCM.in_working_directory
3619         class method. This way we get to reuse an Executive instance which is necessary in testing
3620         when we're operating with a mock version of the object.
3621
3622         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
3623         the SCMDetector with the generator's FileSystem and Executive instances.
3624
3625         * Scripts/webkitpy/common/checkout/scm/detection.py:
3626         (SCMDetector.detect_scm_system):
3627         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3628         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
3629         Executive output and test it against expected output.
3630         * Scripts/webkitpy/common/checkout/scm/git.py:
3631         (Git.in_working_directory):
3632         * Scripts/webkitpy/common/checkout/scm/scm.py:
3633         (SCM.in_working_directory):
3634         * Scripts/webkitpy/common/checkout/scm/svn.py:
3635         (SVN.in_working_directory):
3636         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3637         (JSONResultsGeneratorBase.__init__):
3638         (JSONResultsGeneratorBase._get_svn_revision):
3639
3640 2012-08-31  Jon Lee  <jonlee@apple.com>
3641
3642         [Tests] Add basic tests to http/tests/notifications
3643         https://bugs.webkit.org/show_bug.cgi?id=95493
3644         <rdar://problem/12209303>
3645
3646         Reviewed by Alexey Proskuryakov.
3647
3648         Add permission request support for WTR.
3649
3650         * WebKitTestRunner/TestController.cpp:
3651         (WTR::TestController::initialize):
3652         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3653         * WebKitTestRunner/TestController.h:
3654         (TestController):
3655
3656 2012-08-31  Jon Lee  <jonlee@apple.com>
3657
3658         [DRT] Make simulating a web click on a notification a queued task
3659         https://bugs.webkit.org/show_bug.cgi?id=95546
3660         <rdar://problem/12214170>
3661
3662         Reviewed by Alexey Proskuryakov.
3663
3664         Making the web click happen asynchronously better mimics user interaction with the platform.
3665
3666         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3667         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3668         not set.
3669         * DumpRenderTree/mac/DumpRenderTree.mm:
3670         (dump): Assert that the flag is not set.
3671         * DumpRenderTree/mac/TestRunnerMac.mm:
3672         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
3673         notification. In the case where the block gets executed after the flag has been unset, we avoid
3674         performing the click.
3675
3676 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3677
3678         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3679         https://bugs.webkit.org/show_bug.cgi?id=95575
3680
3681         Reviewed by Csaba Osztrogonác.
3682
3683         Output 100% difference in the case of differing image dimensions so
3684         the test harness knows that we won't produce any output further.
3685         This matches the behavior of other ports.
3686
3687         * DumpRenderTree/qt/ImageDiff.cpp:
3688         (main):
3689
3690 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3691
3692         Unreviewed, rolling out r127261.
3693         http://trac.webkit.org/changeset/127261
3694         https://bugs.webkit.org/show_bug.cgi?id=95572
3695
3696         This patch depends on other build fixes (see blockers of bug
3697         95466) which should land first (Requested by milian on
3698         #webkit).
3699
3700         * qmake/mkspecs/features/features.prf:
3701
3702 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3703
3704         [Qt] Support WebKit2/QML on QNX
3705         https://bugs.webkit.org/show_bug.cgi?id=95466
3706
3707         Reviewed by Noam Rosenthal.
3708
3709         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3710         this should finally work now.
3711
3712         * qmake/mkspecs/features/features.prf:
3713
3714 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3715
3716         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3717         https://bugs.webkit.org/show_bug.cgi?id=95400
3718
3719         Reviewed by Dirk Pranke.
3720
3721         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3722
3723         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3724         (ChromiumAndroidPort.skipped_layout_tests):
3725
3726 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3727
3728         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3729         https://bugs.webkit.org/show_bug.cgi?id=95499
3730
3731         Unreviewed. One more fix to avoid trying to run the empty string.
3732
3733         * Scripts/webkitdirs.pm:
3734         (buildAutotoolsProject):
3735
3736 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3737
3738         Unreviewed, rolling out r127171.
3739         http://trac.webkit.org/changeset/127171
3740         https://bugs.webkit.org/show_bug.cgi?id=95505
3741
3742         testRunner does not need dumpWebNotificationCallbacks().
3743         (Requested by jonlee on #webkit).
3744
3745         * DumpRenderTree/TestRunner.cpp:
3746         (TestRunner::TestRunner):
3747         (TestRunner::staticFunctions):
3748         * DumpRenderTree/TestRunner.h:
3749         (TestRunner):
3750         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3751         (-[MockWebNotificationProvider webView:didShowNotification:]):
3752         (-[MockWebNotificationProvider webView:didClickNotification:]):
3753         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3754         * DumpRenderTree/mac/UIDelegate.mm:
3755         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3756
3757 2012-08-30  Pratik Solanki  <psolanki@apple.com>
3758
3759         objc_msgSend and IMP should be cast appropriately before using
3760         https://bugs.webkit.org/show_bug.cgi?id=95242
3761
3762         Reviewed by Benjamin Poulain.
3763
3764         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
3765         to a function pointer with right types when calling objc_msgSend and an
3766         IMP method directly.
3767
3768         * DumpRenderTree/mac/DumpRenderTree.mm:
3769         (drt_NSFontManager_availableFontFamilies):
3770         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3771         (WTR::wtr_NSFontManager_availableFontFamilies):
3772
3773 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3774
3775         Replace JSC::UString by WTF::String
3776         https://bugs.webkit.org/show_bug.cgi?id=95271
3777
3778         Reviewed by Geoffrey Garen.
3779
3780         Get rid of UString.
3781
3782         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3783         * gdb/webkit.py:
3784         (WTFStringPrinter.to_string):
3785         (JSCIdentifierPrinter.to_string):
3786         (JSCJSStringPrinter.to_string):
3787         (add_pretty_printers):
3788
3789 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3790
3791         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
3792         https://bugs.webkit.org/show_bug.cgi?id=95495
3793
3794         Reviewed by Ojan Vafai.
3795
3796         This is a follow-on to bug 95370 that adds in support for
3797         platform/wk2/TestExpectations and
3798         platform/{mac,win}-$version/TestExpectations.
3799
3800         * Scripts/webkitpy/layout_tests/port/apple.py:
3801         (ApplePort.expectations_files):
3802         * Scripts/webkitpy/layout_tests/port/base.py:
3803         (Port._skipped_file_search_paths):
3804         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3805         (MacTest.test_expectations_files):
3806         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3807         (MockDRTPortTest.make_port):
3808         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3809         (WinPortTest.test_expectations_files):
3810
3811 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3812
3813         executive.run_in_parallel() hangs if given nothing to do
3814         https://bugs.webkit.org/show_bug.cgi?id=95387
3815
3816         Reviewed by Ojan Vafai.
3817
3818         Check to make sure that Executive.run_in_parallel() requires
3819         a non-empty list of commands to execute; passing an empty list
3820         seems surely like a programming error.
3821
3822         * Scripts/webkitpy/common/system/executive.py:
3823         (Executive.run_in_parallel):
3824         * Scripts/webkitpy/common/system/executive_unittest.py:
3825         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
3826
3827 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3828
3829         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
3830         https://bugs.webkit.org/show_bug.cgi?id=94746
3831
3832         Reviewed by Ojan Vafai.
3833
3834         Add an assertion to diff_image() to check that we are passing
3835         tolerance=0 explicitly when diffing ref test results.
3836
3837         * Scripts/webkitpy/layout_tests/port/test.py:
3838         (TestPort.diff_image):
3839
3840 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3841
3842         NRWT should look in mac-wk2 for a TestExpecations file
3843         https://bugs.webkit.org/show_bug.cgi?id=95370
3844
3845         Reviewed by Ojan Vafai.
3846
3847         Adds support for mac-wk2 and win-wk2 to expectations_files()
3848         for the apple mac and apple win ports.
3849         
3850         * Scripts/webkitpy/layout_tests/port/apple.py:
3851         (ApplePort.expectations_files):
3852         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3853         (MacTest.test_expectations_files):
3854         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3855         (WinTest.test_expectations_files):
3856         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3857         (PortTestCase.test_expectations_files):
3858
3859 2012-08-30  Jon Lee  <jonlee@apple.com>
3860
3861         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
3862         https://bugs.webkit.org/show_bug.cgi?id=95232
3863         <rdar://problem/12190776>
3864
3865         Reviewed by Alexey Proskuryakov.
3866
3867         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
3868
3869         * DumpRenderTree/TestRunner.cpp:
3870         (TestRunner::TestRunner):
3871         (dumpWebNotificationCallbacksCallback):
3872         (TestRunner::staticFunctions):
3873         * DumpRenderTree/TestRunner.h:
3874         (TestRunner):
3875         (TestRunner::dumpWebNotificationCallbacks):
3876         (TestRunner::setDumpWebNotificationCallbacks):
3877         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3878         (-[WebNotification _drt_descriptionSuitableForTestResult]):
3879         (-[MockWebNotificationProvider webView:didShowNotification:]):
3880         (-[MockWebNotificationProvider webView:didClickNotification:]):
3881         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3882         * DumpRenderTree/mac/UIDelegate.mm:
3883         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3884
3885 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
3886
3887         MediaStream API: Introduce MediaConstraints
3888         https://bugs.webkit.org/show_bug.cgi?id=95198
3889
3890         Reviewed by Adam Barth.
3891
3892         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
3893
3894         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3895         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3896         (isSupportedConstraint):
3897         (isValidConstraint):
3898         (MockWebRTCPeerConnectionHandler::initialize):
3899         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3900         (MockWebRTCPeerConnectionHandler):
3901
3902 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3903
3904         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
3905         https://bugs.webkit.org/show_bug.cgi?id=95454
3906
3907         Reviewed by Kenneth Rohde Christiansen.
3908
3909         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
3910
3911         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3912         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3913
3914 2012-08-30  Leo Yang  <leoyang@rim.com>
3915
3916         Update my email address.
3917
3918         Not reviewed.
3919
3920         * Scripts/webkitpy/common/config/committers.py:
3921
3922 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
3923
3924         [NRWT] Add support for recognizing arbitrary process names in crash lines
3925         https://bugs.webkit.org/show_bug.cgi?id=95435
3926
3927         Reviewed by Adam Barth.
3928
3929         When running layout tests in the chromium port using the content shell,
3930         we want to be able to report sub-process crashes as well.
3931
3932         * Scripts/webkitpy/layout_tests/port/driver.py:
3933         (Driver._check_for_driver_crash):
3934         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3935         (DriverTest.test_check_for_driver_crash):
3936
3937 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
3938
3939         Random test-webkitpy failures on the buildbot
3940         https://bugs.webkit.org/show_bug.cgi?id=95096
3941
3942         Reviewed by Dirk Pranke.
3943
3944         Suppress occasional errors when running test-webkitpy on GTK builders
3945         by running these tests serially. The 64-bit Release builder is especially
3946         prone to these as it can run up to 24 tests in parallel.
3947
3948         Despite the tests not being run in parallel, the testing only lasts a handful
3949         of seconds more, so this is a worthy trade-off to avoid unnecessary
3950         false-alarm redness on the GTK builders.
3951
3952         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3953         (RunPythonTests.start):
3954
3955 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
3956
3957         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
3958         https://bugs.webkit.org/show_bug.cgi?id=95380
3959
3960         Reviewed by Michael Saboff.
3961
3962         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3963         Add very basic tests for String::ascii(). This covers the case of null strings that caused
3964         the crash.
3965
3966 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3967
3968         AX: Canvas should have a distinct role
3969         https://bugs.webkit.org/show_bug.cgi?id=95248
3970
3971         Reviewed by Chris Fleizach.
3972
3973         Add support for canvas accessibility role.
3974
3975         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3976         (roleToString):
3977
3978 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
3979
3980         [Gtk] Process Gtk 3.4 smooth scroll events properly
3981         https://bugs.webkit.org/show_bug.cgi?id=88070
3982
3983         Added continousMouseScrollBy support in WebKitTestRunner, and added
3984         implementation for gtk, and stub for Qt, mac and EFL.
3985
3986         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
3987         scroll for emulating multi-tick mouseScrollBy events.
3988
3989         Reviewed by Martin Robinson.
3990
3991         * DumpRenderTree/gtk/EventSender.cpp:
3992         (mouseScrollByCallback):
3993         (continuousMouseScrollByCallback):
3994         * WebKitTestRunner/EventSenderProxy.h:
3995         (EventSenderProxy):
3996         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3997         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3998         (WTR::EventSendingController::mouseScrollBy):
3999         (WTR):
4000         (WTR::EventSendingController::continuousMouseScrollBy):
4001         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4002         (EventSendingController):
4003         * WebKitTestRunner/TestController.cpp:
4004         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
4005         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
4006         (WTR):
4007         (WTR::EventSenderProxy::mouseScrollBy):
4008         (WTR::EventSenderProxy::continuousMouseScrollBy):
4009         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
4010         (WTR):
4011         (WTR::EventSenderProxy::continuousMouseScrollBy):
4012         * WebKitTestRunner/mac/EventSenderProxy.mm:
4013         (WTR::EventSenderProxy::continuousScrollBy):
4014         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
4015         (WTR::EventSenderProxy::continuousMouseScrollBy):
4016         (WTR):
4017
4018 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
4019
4020         [chromium] Support high DIP pixel tests with DumpRenderTree
4021         https://bugs.webkit.org/show_bug.cgi?id=94935
4022
4023         Reviewed by James Robinson.
4024
4025         Adding device scale factor into the drt image dumping code
4026
4027         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4028         (DRTTestRunner::reset):
4029         (DRTTestRunner::setBackingScaleFactor):
4030         * DumpRenderTree/chromium/WebViewHost.cpp:
4031         (WebViewHost::setDeviceScaleFactor):
4032         (WebViewHost::paintInvalidatedRegion):
4033         (WebViewHost::canvas):
4034         * DumpRenderTree/chromium/WebViewHost.h:
4035         (WebViewHost):
4036
4037 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
4038
4039         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
4040         https://bugs.webkit.org/show_bug.cgi?id=95177
4041
4042         Reviewed by Dirk Pranke.
4043
4044         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
4045
4046         * Scripts/webkitpy/common/checkout/scm/git.py:
4047
4048 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
4049
4050         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
4051         https://bugs.webkit.org/show_bug.cgi?id=95222
4052
4053         Reviewed by Adam Barth.
4054
4055         The code we had to remove REBASELINE lines from the
4056         TestExpectations files did not handle multiple files (in a
4057         cascade) correctly; we weren't limiting lines to a particular
4058         file correctly in without_rebaseline_modifier(). This patch
4059         fixes that and corrects the tests (which weren't correct and
4060         didn't cover things very well).
4061
4062         Note also that the webkit-patch rebaseline-commands are still
4063         using the include_overrides=False option in a couple places;
4064         this is never correct or needed at this point. This patch fixes
4065         the usage for webkit-patch rebaseline-expectations, but I still
4066         need to fix rebaseline-test-internal, which I will do in a
4067         separate patch (see bug 95268).
4068
4069         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4070         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
4071         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4072         (RebaseliningTest.assertRemove):
4073         (RebaseliningTest.test_remove):
4074         * Scripts/webkitpy/tool/commands/rebaseline.py:
4075         (RebaselineExpectations._update_expectations_files):
4076
4077 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
4078
4079         webkit-patch rebaseline-expectations hangs
4080         https://bugs.webkit.org/show_bug.cgi?id=95243
4081
4082         Reviewed by Tony Chang.
4083
4084         Don't try to run no commands in parallel; report an error
4085         instead that we didn't find any tests to rebaseline.
4086
4087         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
4088
4089         * Scripts/webkitpy/tool/commands/rebaseline.py:
4090         (RebaselineExpectations.execute):
4091         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4092         (_assert_command):
4093         (test_rebaseline_expectations_noop):
4094
4095 2012-08-29  Brady Eidson  <beidson@apple.com>
4096
4097         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
4098         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
4099
4100         Reviewed by Sam Weinig.
4101
4102         Add a test plug-in that calls back into the page with info on the NPWindow passed
4103         in to NPP_SetWindow.
4104
4105         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4106         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
4107         (LogNPPSetWindow):
4108         (LogNPPSetWindow::LogNPPSetWindow):
4109         (LogNPPSetWindow::NPP_SetWindow):
4110
4111 2012-08-29  Jon Lee  <jonlee@apple.com>
4112
4113         [Mac] Basic DRT support for web notifications
4114         https://bugs.webkit.org/show_bug.cgi?id=79492
4115         <rdar://problem/10357639>
4116
4117         Reviewed by Alexey Proskuryakov.
4118
4119         This patch implements the stubs for web notification support on DRT. Assume that when
4120         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
4121         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
4122
4123         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
4124         * DumpRenderTree/mac/DumpRenderTree.mm:
4125         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
4126         web view.
4127         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
4128
4129         * DumpRenderTree/mac/TestRunnerMac.mm:
4130         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
4131         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
4132         (TestRunner::removeAllWebNotificationPermissions):
4133         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
4134         simulate the click. This is similar to how WTR performs the click.
4135         * DumpRenderTree/mac/UIDelegate.mm:
4136         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
4137         user allows web notifications.
4138
4139         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
4140         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
4141         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
4142         (+[MockWebNotificationProvider shared]): The provider is a singleton.
4143         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
4144         (-[MockWebNotificationProvider registerWebView:]):
4145         (-[MockWebNotificationProvider unregisterWebView:]):
4146         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
4147         notification did show.
4148         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
4149         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
4150         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
4151         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
4152         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
4153         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
4154         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
4155         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
4156         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
4157         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
4158         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
4159
4160 2012-08-29  Rob Buis  <rbuis@rim.com>
4161
4162         [BlackBerry] Adjust wtf include header style
4163         https://bugs.webkit.org/show_bug.cgi?id=95368
4164
4165         Reviewed by Yong Li.
4166
4167         Switch to #include <wtf/...> like the other ports.
4168
4169         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4170         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
4171         * DumpRenderTree/blackberry/PNGImageEncoder.h:
4172         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
4173         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
4174         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
4175
4176 2012-08-29  Roger Fong  <roger_fong@apple.com>
4177
4178         Update cygwin-downloader.zip to match modified downloader script.
4179         https://bugs.webkit.org/show_bug.cgi?id=76936
4180
4181         Rubber Stamped by Jon Honeycutt.
4182
4183         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
4184         Updating zip to reflect changes.
4185
4186         * CygwinDownloader/cygwin-downloader.zip:
4187
4188 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
4189
4190         Stylechecker warns about comparison to zero when comparing to 0.5
4191         https://bugs.webkit.org/show_bug.cgi?id=94913
4192
4193         Reviewed by Dirk Pranke.
4194
4195         According to the python documentation, \W is the character group with all
4196         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
4197         to [^\w]. We need to exclude the dot "." as well, so that floating point
4198         values do not trigger this warning. Adding a unit test that shows the problem.
4199
4200         * Scripts/webkitpy/style/checkers/cpp.py:
4201         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
4202         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4203         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
4204
4205 2012-08-29  Jon Lee  <jonlee@apple.com>
4206
4207         WTR build fixes.
4208
4209         * WebKitTestRunner/CMakeLists.txt:
4210         * WebKitTestRunner/GNUmakefile.am:
4211         * WebKitTestRunner/Target.pri:
4212         * WebKitTestRunner/WebNotificationProvider.cpp:
4213         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
4214         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4215
4216 2012-08-29  Jon Lee  <jonlee@apple.com>
4217
4218         [WK2] Basic WTR support for web notifications
4219         https://bugs.webkit.org/show_bug.cgi?id=95154
4220         <rdar://problem/12184492>
4221
4222         Reviewed by Alexey Proskuryakov.
4223
4224         Implement WTR support, without platform event output (bug 95233).
4225
4226         Legacy APIs will not be supported, since many of the tests are skipped
4227         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
4228         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
4229         the tests to http/tests/notifications.
4230
4231         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
4232         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
4233         be invoked from the UIProcess.
4234
4235         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4236         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4237         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
4238         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
4239         notification's internal ID.
4240         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4241         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4242         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
4243         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
4244         (WTR::TestRunner::removeAllWebNotificationPermissions):
4245         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
4246         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4247
4248         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
4249         class.
4250         * WebKitTestRunner/TestInvocation.cpp:
4251         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
4252         TestInvocation forwards that request to the TestController.
4253         * WebKitTestRunner/TestController.cpp:
4254         (WTR::TestController::initialize): Set the provider.
4255         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
4256         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
4257         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
4258
4259         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
4260         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
4261         * WebKitTestRunner/WebNotificationProvider.h: Added.
4262         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
4263         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
4264         the notification got shown.
4265         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
4266         got closed.
4267         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
4268         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
4269         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
4270         permissions. For testing purposes, we always want this set to be empty.
4271         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
4272         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
4273
4274         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
4275
4276 2012-08-29  Kamil Blank  <k.blank@samsung.com>
4277
4278         [EFL] Add setting API for allow universal/file access from file URLs.
4279         https://bugs.webkit.org/show_bug.cgi?id=83121
4280
4281         Reviewed by Eric Seidel.
4282
4283         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
4284
4285         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4286         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4287         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4288         (TestRunner::setAllowUniversalAccessFromFileURLs):
4289         (TestRunner::setAllowFileAccessFromFileURLs):
4290
4291 2012-08-29  Jon Lee  <jonlee@apple.com>
4292
4293         Update TestRunner API for web notifications
4294         https://bugs.webkit.org/show_bug.cgi?id=95093
4295         <rdar://problem/12179649>
4296
4297         Reviewed by Alexey Proskuryakov.
4298
4299         As it turns out the patch for this accidentally got squashed into the commit for
4300         bug 95099 (r126909). This amendment patch adds some comments about the renaming
4301         of the older TestRunner API for web notifications.
4302
4303         * DumpRenderTree/TestRunner.h:
4304         (TestRunner):
4305
4306 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
4307
4308         Unreviewed, rolling out r126972.
4309         http://trac.webkit.org/changeset/126972
4310         https://bugs.webkit.org/show_bug.cgi?id=95349
4311
4312         accessibility/canvas-description-and-role.html has been
4313         failing consistently on several bots and Dominic needs some
4314         time to investigate why (Requested by jchaffraix on #webkit).
4315
4316         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4317         (roleToString):
4318
4319 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
4320
4321         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
4322         https://bugs.webkit.org/show_bug.cgi?id=84707
4323
4324         Reviewed by Gustavo Noronha Silva.
4325
4326         Most of the warnings have been fixed now that FindCairo.cmake and
4327         FindGLIB.cmake have been rewritten. The remaining one, related to
4328         FindFontconfig.cmake, shows up when building on a 64-bit
4329         Debian-based systems.
4330
4331         jhbuild installs libraries into lib64/ by default on 64-bit Linux
4332         installations, while CMake does not look for libraries in lib64/
4333         when /etc/debian_version exists on the system. The FIND_LIBRARY()
4334         would then sometimes end up using the system installation instead of
4335       &nb