0d3e18a4205cc4b8a0696f462fa38b044a436059
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
2
3         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
4         https://bugs.webkit.org/show_bug.cgi?id=197171
5         <rdar://problem/47454979>
6
7         Reviewed by Youenn Fablet.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
11         (TestWebKitAPI::TEST):
12
13 2019-04-24  Brady Eidson  <beidson@apple.com>
14
15         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
16         https://bugs.webkit.org/show_bug.cgi?id=191362
17
18         Reviewed by Alex Christensen.
19
20         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
21           from an XHR to a custom protocol.
22
23 2019-04-24  John Wilander  <wilander@apple.com>
24
25         Age out unconverted Ad Click Attributions after one week.
26         https://bugs.webkit.org/show_bug.cgi?id=197238
27         <rdar://problem/50177349>
28
29         Reviewed by Chris Dumez.
30
31         This patch adds infrastructure to allow tests to expire all unconverted
32         attributions early.
33
34         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
35         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
36         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
37         * WebKitTestRunner/InjectedBundle/TestRunner.h:
38         * WebKitTestRunner/TestController.cpp:
39         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
40         * WebKitTestRunner/TestController.h:
41         * WebKitTestRunner/TestInvocation.cpp:
42         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
43
44 2019-04-24  Chris Dumez  <cdumez@apple.com>
45
46         Fix flaky crashes in a couple of PSON API tests
47         https://bugs.webkit.org/show_bug.cgi?id=197239
48
49         Reviewed by Tim Horton.
50
51         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
52
53         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
54
55 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
56
57         Make it possible to control the renderTreeAsText output by setting options on testRunner
58         https://bugs.webkit.org/show_bug.cgi?id=197133
59
60         Reviewed by Sam Weinig.
61
62         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
63         that make sense in testing (those that don't dump unstable data like addresses), and plumb
64         these flags through the various framework layers.
65
66         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
67
68         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
69         and hand-code DumpRenderTree bindings.
70
71         Some cleanup of the TestRunners, using member initializers.
72
73         * DumpRenderTree/TestRunner.cpp:
74         (TestRunner::TestRunner):
75         (setRenderTreeDumpOptionsCallback):
76         (TestRunner::staticFunctions):
77         (TestRunner::setRenderTreeDumpOptions):
78         * DumpRenderTree/TestRunner.h:
79         (TestRunner::renderTreeDumpOptions const):
80         * DumpRenderTree/mac/DumpRenderTree.mm:
81         (dump):
82         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
83         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
84         (WTR::InjectedBundlePage::dump):
85         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
86         (WTR::TestRunner::TestRunner):
87         (WTR::TestRunner::setRenderTreeDumpOptions):
88         * WebKitTestRunner/InjectedBundle/TestRunner.h:
89         (WTR::TestRunner::renderTreeDumpOptions const):
90
91 2019-04-24  Alex Christensen  <achristensen@webkit.org>
92
93         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
94         https://bugs.webkit.org/show_bug.cgi?id=197078
95         <rdar://problem/49564348>
96
97         Reviewed by Geoff Garen.
98
99         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
100         (TEST_F):
101         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
102         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
103         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
104
105 2019-04-24  Alex Christensen  <achristensen@webkit.org>
106
107         Add unit test for r239322
108         https://bugs.webkit.org/show_bug.cgi?id=197236
109
110         Reviewed by Chris Dumez.
111
112         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
113         May as well add the test infrastructure which was needed before and will be needed in the future.
114
115         * TestWebKitAPI/TCPServer.cpp:
116         (TestWebKitAPI::TCPServer::TCPServer):
117         * TestWebKitAPI/TCPServer.h:
118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
119         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
120         (TestWebKitAPI::TEST):
121         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
122         (TestWebKitAPI::downloadAtRate):
123         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
124         (TEST):
125         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
126         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
127         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
128         (TestWebKitAPI::TEST):
129         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
130         (TEST):
131
132 2019-04-24  Chris Dumez  <cdumez@apple.com>
133
134         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
135         https://bugs.webkit.org/show_bug.cgi?id=197214
136         <rdar://problem/49237544>
137
138         Reviewed by Alex Christensen.
139
140         Extend API test coverage.
141
142         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
143         (TEST):
144
145 2019-04-24  Philippe Normand  <pnormand@igalia.com>
146
147         [Build][GStreamer] Update to 1.16.0
148         https://bugs.webkit.org/show_bug.cgi?id=197157
149
150         Reviewed by Xabier Rodriguez-Calvar.
151
152         The upstreamed patches were removed and a new one was added for a
153         regression detected in the scaletempo GStreamer element. The GNOME
154         Flatpak was migrated to 3.32 and I switched a few modules to Meson
155         on the way, as it is the preferred build system now in GStreamer
156         1.16.
157
158         * flatpak/files/httpd-autogen.sh:
159         * flatpak/flatpakutils.py:
160         (FlatpakPackage.install):
161         (WebkitFlatpak.run_in_sandbox):
162         * flatpak/org.webkit.CommonModules.yaml:
163         * flatpak/org.webkit.WebKit.yaml:
164         * gstreamer/jhbuild.modules:
165         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
166         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
167         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
168         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
169         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
170         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
171         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
172         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
173         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
174         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
175         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
176         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
177         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
178         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
179         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
180         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
181         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
182         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
183         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
184         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
185         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
186         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
187
188 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
189
190         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
191         https://bugs.webkit.org/show_bug.cgi?id=197156
192
193         Reviewed by Michael Catanzaro.
194
195         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
196         support was added.
197
198         * MiniBrowser/gtk/BrowserTab.c:
199         (browser_tab_set_background_color): Set the passed in color as web view background color.
200         * MiniBrowser/gtk/BrowserTab.h:
201         * MiniBrowser/gtk/BrowserWindow.c:
202         (browser_window_init): Initialize backgroundColor.
203         (browser_window_append_view): Call browser_tab_set_background_color().
204         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
205         are added.
206         * MiniBrowser/gtk/main.c:
207         (main): Call browser_window_set_background_color() before creating the tabs.
208
209 2019-04-23  John Wilander  <wilander@apple.com>
210
211         Move Ad Click Attribution from internal feature to experimental feature
212         https://bugs.webkit.org/show_bug.cgi?id=197218
213         <rdar://problem/47651691>
214
215         Reviewed by Brent Fulgham.
216
217         * DumpRenderTree/TestOptions.cpp:
218         (TestOptions::TestOptions):
219
220 2019-04-23  Andy Estes  <aestes@apple.com>
221
222         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
223         https://bugs.webkit.org/show_bug.cgi?id=196749
224         <rdar://problem/35773454>
225
226         Reviewed by Daniel Bates.
227
228         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
229
230         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
231         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
232         (-[QuickLookDelegate webView:didFinishNavigation:]):
233         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
234         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
235         (runTest):
236         (runTestDecideBeforeLoading):
237         (runTestDecideAfterLoading):
238         (TEST):
239
240 2019-04-23  John Wilander  <wilander@apple.com>
241
242         Remove Ad Click Attribution data when removing website data
243         https://bugs.webkit.org/show_bug.cgi?id=197215
244         <rdar://problem/47668988>
245
246         Reviewed by Chris Dumez.
247
248         This patch adds test infrastructure to delete Ad Click Attribution data
249         through WebsiteDataStore::removeData().
250
251         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
252         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
253         (WTR::TestRunner::clearAdClickAttribution):
254         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
255         * WebKitTestRunner/InjectedBundle/TestRunner.h:
256         * WebKitTestRunner/TestController.cpp:
257         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
258         * WebKitTestRunner/TestController.h:
259         * WebKitTestRunner/TestInvocation.cpp:
260         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
261
262 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
263
264         webkitpy: Kill unresponsive worker processes
265         https://bugs.webkit.org/show_bug.cgi?id=197205
266         <rdar://problem/50104388>
267
268         Reviewed by Lucas Forschler.
269
270         * Scripts/webkitpy/common/message_pool.py:
271         (_MessagePool.__init__): Add close timeout.
272         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
273
274 2019-04-23  Alex Christensen  <achristensen@webkit.org>
275
276         Add unit tests for WKWebView.serverTrust
277         https://bugs.webkit.org/show_bug.cgi?id=197202
278
279         Reviewed by Youenn Fablet
280
281         * TestWebKitAPI/TCPServer.cpp:
282         (TestWebKitAPI::deleter<BIO>::operator()):
283         (TestWebKitAPI::deleter<SSL>::operator()):
284         (TestWebKitAPI::deleter<X509>::operator()):
285         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
286         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
287         (TestWebKitAPI::TCPServer::TCPServer):
288         (TestWebKitAPI::TCPServer::listenForConnections):
289         * TestWebKitAPI/TCPServer.h:
290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
291         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
292         (TestWebKitAPI::TEST):
293         (verifyCertificateAndPublicKey):
294         (-[ServerTrustDelegate webView:didFinishNavigation:]):
295         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
296         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
297         (TestWebKitAPI::downloadAtRate):
298         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
299         (TEST):
300         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
301         (TEST):
302
303 2019-04-23  Commit Queue  <commit-queue@webkit.org>
304
305         Unreviewed, rolling out r244556.
306         https://bugs.webkit.org/show_bug.cgi?id=197212
307
308         Causing build failures on multiple builders (Requested by
309         ShawnRoberts on #webkit).
310
311         Reverted changeset:
312
313         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
314         https://bugs.webkit.org/show_bug.cgi?id=197171
315         https://trac.webkit.org/changeset/244556
316
317 2019-04-23  Alex Christensen  <achristensen@webkit.org>
318
319         Fix iOS build.
320         https://bugs.webkit.org/show_bug.cgi?id=195537
321
322         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
323         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
324         AdoptWK constructor is private now.  Use adoptWK instead.
325
326 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
327
328         Accessibility text search and selection API enhancements.
329         https://bugs.webkit.org/show_bug.cgi?id=197095
330         <rdar://problem/48181791>
331
332         Reviewed by Chris Fleizach.
333
334         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
335
336         * DumpRenderTree/AccessibilityTextMarker.h:
337         * DumpRenderTree/AccessibilityUIElement.cpp:
338         (searchTextWithCriteriaCallback):
339         (AccessibilityUIElement::getJSClass):
340         * DumpRenderTree/AccessibilityUIElement.h:
341         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
342         (convertVectorToObjectArray):
343         (convertNSArrayToVector):
344         (searchTextParameterizedAttributeForCriteria):
345         (AccessibilityUIElement::getLinkedUIElements):
346         (AccessibilityUIElement::getDocumentLinks):
347         (AccessibilityUIElement::getChildren):
348         (AccessibilityUIElement::getChildrenWithRange):
349         (AccessibilityUIElement::rowHeaders const):
350         (AccessibilityUIElement::columnHeaders const):
351         (AccessibilityUIElement::uiElementArrayAttributeValue const):
352         (AccessibilityUIElement::searchTextWithCriteria):
353         (AccessibilityUIElement::attributesOfColumnHeaders):
354         (AccessibilityUIElement::attributesOfRowHeaders):
355         (AccessibilityUIElement::attributesOfColumns):
356         (AccessibilityUIElement::attributesOfRows):
357         (AccessibilityUIElement::attributesOfVisibleCells):
358         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
359         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
360         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
361         (WTR::convertVectorToObjectArray):
362         (WTR::convertNSArrayToVector):
363         (WTR::searchTextParameterizedAttributeForCriteria):
364         (WTR::AccessibilityUIElement::getLinkedUIElements):
365         (WTR::AccessibilityUIElement::getDocumentLinks):
366         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
367         (WTR::AccessibilityUIElement::getChildren):
368         (WTR::AccessibilityUIElement::getChildrenWithRange):
369         (WTR::AccessibilityUIElement::rowHeaders const):
370         (WTR::AccessibilityUIElement::columnHeaders const):
371         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
372         (WTR::AccessibilityUIElement::searchTextWithCriteria):
373         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
374         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
375         (WTR::AccessibilityUIElement::attributesOfColumns):
376         (WTR::AccessibilityUIElement::attributesOfRows):
377         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
378         (WTR::convertElementsToObjectArray): Deleted.
379
380 2019-04-23  Guy Lewin  <guy@lewin.co.il>
381
382         Multiple File Input Icon Set Regardless of File List
383         https://bugs.webkit.org/show_bug.cgi?id=195537
384
385         Reviewed by Alexey Proskuryakov.
386
387         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
388         display string in iOS file inputs
389
390         * DumpRenderTree/TestRunner.cpp:
391         (SetOpenPanelFilesMediaIconCallback):
392         (TestRunner::staticFunctions):
393         (TestRunner::setOpenPanelFilesMediaIcon):
394         * DumpRenderTree/TestRunner.h:
395         (TestRunner::openPanelFilesMediaIcon const):
396         * DumpRenderTree/mac/UIDelegate.mm:
397         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
398         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
399         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
400         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
401         * WebKitTestRunner/InjectedBundle/TestRunner.h:
402         * WebKitTestRunner/TestController.cpp:
403         (WTR::runOpenPanel):
404         (WTR::TestController::resetStateToConsistentValues):
405         * WebKitTestRunner/TestController.h:
406         (WTR::TestController::openPanelFileURLsMediaIcon const):
407         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
408         * WebKitTestRunner/TestInvocation.cpp:
409         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
410
411 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
412
413         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
414         https://bugs.webkit.org/show_bug.cgi?id=197171
415         <rdar://problem/47454979>
416
417         Reviewed by Youenn Fablet.
418
419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
420         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
421         (TestWebKitAPI::TEST):
422
423 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
424
425         [ews-build] Add unit tests for UnApplyPatchIfRequired
426         https://bugs.webkit.org/show_bug.cgi?id=197197
427
428         Reviewed by Lucas Forschler.
429
430         * BuildSlaveSupport/ews-build/steps_unittest.py:
431         (TestUnApplyPatchIfRequired):
432         (TestUnApplyPatchIfRequired.test_success):
433         (TestUnApplyPatchIfRequired.test_failure):
434         (TestUnApplyPatchIfRequired.test_skip):
435
436 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
437
438         [ews-build] Add unit tests for CleanWorkingDirectory
439         https://bugs.webkit.org/show_bug.cgi?id=197195
440
441         Reviewed by Lucas Forschler.
442
443         * BuildSlaveSupport/ews-build/steps_unittest.py:
444         (TestCleanWorkingDirectory):
445         (TestCleanWorkingDirectory.test_success):
446         (TestCleanWorkingDirectory.test_failure):
447
448 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
449
450         [ews-build] Use explicit imports instead of wildcard imports
451         https://bugs.webkit.org/show_bug.cgi?id=197194
452
453         Reviewed by Lucas Forschler.
454
455         * BuildSlaveSupport/ews-build/factories.py:
456         * BuildSlaveSupport/ews-build/loadConfig.py:
457         * BuildSlaveSupport/ews-build/steps_unittest.py:
458
459 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
460
461         [ews-build] Add unit tests for DownloadBuiltProduct
462         https://bugs.webkit.org/show_bug.cgi?id=197193
463
464         Reviewed by Lucas Forschler.
465
466         * BuildSlaveSupport/ews-build/steps_unittest.py:
467         (TestDownloadBuiltProduct):
468         (TestDownloadBuiltProduct.setUp):
469         (TestDownloadBuiltProduct.tearDown):
470         (TestDownloadBuiltProduct.test_success):
471         (TestDownloadBuiltProduct.test_failure):
472
473 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
474
475         [ews-app] Exception while loading status-bubble when no build step has started
476         https://bugs.webkit.org/show_bug.cgi?id=196676
477
478         Reviewed by Lucas Forschler.
479
480         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
481         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
482
483 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
484
485         [PlayStation] Support running of JSC tests on remote playstation devices
486         https://bugs.webkit.org/show_bug.cgi?id=197170
487
488         Reviewed by Ross Kirsling.
489
490         Script changes
491
492         * Scripts/run-javascriptcore-tests:
493         (runJSCStressTests): Pass arguments for playstation to
494         run-jsc-stress-tests
495         * Scripts/run-jsc-stress-tests:
496         Handle $hostOS=="playstation" for determineArchitecture, turning
497         off $isFTLPlatform and runProfiler and defaulting test writer.
498         * Scripts/webkitdirs.pm:
499         (jscPath): PlayStation WebKit executables have .elf extension
500         (executableProductDir): PlayStation builds on Windows hosts but
501         uses bin directory rather than bin64/bin32 for executable output
502         location.
503         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
504
505 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
506
507         [CMake][Win] Use target oriented design for WebKit
508         https://bugs.webkit.org/show_bug.cgi?id=197173
509
510         Reviewed by Alex Christensen.
511
512         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
513         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
514
515 2019-04-23  Chris Dumez  <cdumez@apple.com>
516
517         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
518         https://bugs.webkit.org/show_bug.cgi?id=197097
519         <rdar://problem/50048318>
520
521         Reviewed by Alex Christensen.
522
523         Add API test coverage.
524
525         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
526         (-[PSONScheme webView:startURLSchemeTask:]):
527
528 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
529
530         [ATK] Implement AtkComponentIface scroll_to methods
531         https://bugs.webkit.org/show_bug.cgi?id=196856
532
533         Reviewed by Michael Catanzaro.
534
535         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
536         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
537         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
538         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
539
540 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
541
542         [ews-build] Improve summary for UploadBuiltProduct step
543         https://bugs.webkit.org/show_bug.cgi?id=197182
544
545         Reviewed by Lucas Forschler.
546
547         * BuildSlaveSupport/ews-build/steps.py:
548         (UploadBuiltProduct): Added descriptionDone.
549         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
550         * BuildSlaveSupport/ews-build/steps_unittest.py:
551         (TestUploadBuiltProduct.test_success): Updated unit-test.
552         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
553
554 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
555
556         [ews-build] Trigger queues only after uploading the archive
557         https://bugs.webkit.org/show_bug.cgi?id=197180
558
559         Reviewed by Lucas Forschler.
560
561         * BuildSlaveSupport/ews-build/factories.py:
562         (Factory.__init__):
563         (BuildFactory.__init__): Remove trigger step from factories.
564         (BuildFactory.propertiesToPassToTriggers): Deleted.
565         * BuildSlaveSupport/ews-build/steps.py:
566         (ConfigureBuild.__init__): Confiure triggers property.
567         (Trigger): Step to trigger other queues.
568         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
569         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
570
571 2019-04-22  Alex Christensen  <achristensen@webkit.org>
572
573         Deprecate WKContextCreateWithInjectedBundlePath
574         https://bugs.webkit.org/show_bug.cgi?id=197169
575
576         Reviewed by Youenn Fablet.
577
578         * TestWebKitAPI/PlatformUtilities.cpp:
579         (TestWebKitAPI::Util::createContextWithInjectedBundle):
580         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
581
582 2019-04-22  Alex Christensen  <achristensen@webkit.org>
583
584         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
585         https://bugs.webkit.org/show_bug.cgi?id=197093
586         <rdar://problem/49708268>
587
588         Reviewed by Chris Dumez.
589
590         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
591         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
592         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
593         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
594         and one for loads without credentials, so there are two TCP connections to the same server in this test.
595
596         * TestWebKitAPI/TCPServer.cpp:
597         (TestWebKitAPI::TCPServer::TCPServer):
598         (TestWebKitAPI::TCPServer::~TCPServer):
599         (TestWebKitAPI::TCPServer::socketBindListen):
600         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
601         * TestWebKitAPI/TCPServer.h:
602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
603         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
604         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
605         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
606         (respondWithChallengeThenOK):
607         (TestWebKitAPI::TEST):
608         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
609         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
610         (TEST):
611
612 2019-04-22  Chris Dumez  <cdumez@apple.com>
613
614         Delayed WebProcessLaunch may break the _relatedWebView SPI
615         https://bugs.webkit.org/show_bug.cgi?id=197160
616
617         Reviewed by Alex Christensen.
618
619         Add API test coverage.
620
621         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
622
623 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
624
625         Use curl to download packages for webkitpy autoinstaller
626         https://bugs.webkit.org/show_bug.cgi?id=197164
627
628         Reviewed by Darin Adler.
629
630         * Scripts/webkitpy/common/system/autoinstall.py:
631         (AutoInstaller._download): Use curl(1) to download packages necessary for
632         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
633         errors which are not present when using curl(1).
634
635 2019-04-22  Chris Dumez  <cdumez@apple.com>
636
637         Unreviewed, rolling out r244502.
638
639         Caused crashes on the bots
640
641         Reverted changeset:
642
643         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
644         https://bugs.webkit.org/show_bug.cgi?id=197160
645         https://trac.webkit.org/changeset/244502
646
647 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
648
649         Unreviewed, rolling out r244437.
650
651         Still breaks internal tests.
652
653         Reverted changeset:
654
655         "InjectedBundle parameters often need initialization function
656         called before unarchiving"
657         https://bugs.webkit.org/show_bug.cgi?id=189709
658         https://trac.webkit.org/changeset/244437
659
660 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
661
662         [ews-build] Use singular verb in failure description in case of single api test failure
663         https://bugs.webkit.org/show_bug.cgi?id=197013
664
665         Reviewed by Lucas Forschler.
666
667         * BuildSlaveSupport/ews-build/steps.py:
668         (AnalyzeAPITestsResults.analyzeResults):
669
670 2019-04-22  Chris Dumez  <cdumez@apple.com>
671
672         Delayed WebProcessLaunch may break the _relatedWebView SPI
673         https://bugs.webkit.org/show_bug.cgi?id=197160
674
675         Reviewed by Alex Christensen.
676
677         Add API test coverage.
678
679         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
680
681 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
682
683         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
684         https://bugs.webkit.org/show_bug.cgi?id=194630
685
686         Reviewed by Michael Catanzaro.
687
688         Return early from getAttributeSet() is passed in accessible is nullptr.
689
690         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
691
692 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
693
694         Defer EditorState updates until the next layer tree flush in a few additional circumstances
695         https://bugs.webkit.org/show_bug.cgi?id=197145
696         <rdar://problem/50078170>
697
698         Reviewed by Darin Adler.
699
700         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
701         focus, or showing the font manager.
702
703         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
704         (TestWebKitAPI::TEST):
705         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
706         (TEST):
707         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
708         (TestWebKitAPI::TEST):
709
710 2019-04-21  Brian Burg  <bburg@apple.com>
711
712         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
713         https://bugs.webkit.org/show_bug.cgi?id=197125
714         <rdar://problem/50061468>
715
716         Reviewed by Darin Adler.
717
718         Sometimes I want to run wptserve independently of tests. Make it easier to script that
719         using this class rather than making our own ./wpt serve invocation.
720
721         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
722         (WebDriverW3CWebServer):
723         (WebDriverW3CWebServer.document_root): Expose this to clients.
724         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
725
726         (WebDriverW3CWebServer.__enter__):
727         (WebDriverW3CWebServer.__exit__):
728         Make it possible to use the web server with a 'with' statement.
729
730 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
731
732         [CMake][Win] Use target oriented design for WebKitLegacy
733         https://bugs.webkit.org/show_bug.cgi?id=197112
734
735         Reviewed by Konstantin Tokarev.
736
737         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
738
739         * DumpRenderTree/CMakeLists.txt:
740         * DumpRenderTree/PlatformWin.cmake:
741         * DumpRenderTree/win/EventSender.cpp:
742
743 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
744
745         Update text for old EWS submit button
746         https://bugs.webkit.org/show_bug.cgi?id=197140
747
748         Reviewed by Alexey Proskuryakov.
749
750         * QueueStatusServer/templates/statusbubble.html:
751
752 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
753
754         [ews-app] New EWS should poll bugzilla more frequently
755         https://bugs.webkit.org/show_bug.cgi?id=197138
756
757         Reviewed by Alexey Proskuryakov.
758
759         * BuildSlaveSupport/ews-app/ews/fetcher.py:
760         (FetchLoop.__init__):
761
762 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
763
764         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
765         https://bugs.webkit.org/show_bug.cgi?id=197139
766
767         Reviewed by Alexey Proskuryakov.
768
769         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
770         * QueueStatusServer/templates/statusbubble.html:
771
772 2019-04-20  Chris Dumez  <cdumez@apple.com>
773
774         Unreviewed, fix iOS build with recent SDKs.
775
776         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
777
778 2019-04-19  Keith Miller  <keith_miller@apple.com>
779
780         Add script to merge run_benchmark jsons
781         https://bugs.webkit.org/show_bug.cgi?id=197107
782
783         Reviewed by Michael Saboff.
784
785         The script basically recursively decends through all json objects until it gets
786         to an array or JSON primitive and concats or takes the first value, respectively.
787
788         This patch also adds +x bits to the compare-results script so it
789         can be run directly from the command line. I had to add a new line so that svn
790         will accept the change... yay svn!
791
792         * Scripts/compare-results:
793         * Scripts/merge-result-jsons: Added.
794         (readJSONFile):
795         (deepAppend):
796         (mergeJSONs):
797         (main):
798
799 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
800
801         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
802         https://bugs.webkit.org/show_bug.cgi?id=197079
803
804         Reviewed by Darin Adler.
805
806         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
807
808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
809         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
810
811 2019-04-18  Commit Queue  <commit-queue@webkit.org>
812
813         Unreviewed, rolling out r244434.
814         https://bugs.webkit.org/show_bug.cgi?id=197089
815
816         caused 1 API test failure (Requested by zalan on #webkit).
817
818         Reverted changeset:
819
820         "Regression (r244291): Broken API Test
821         AutoLayoutRenderingProgressRelativeOrdering"
822         https://bugs.webkit.org/show_bug.cgi?id=196948
823         https://trac.webkit.org/changeset/244434
824
825 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
826
827         Add new compatibility mode API on WKNavigation
828         https://bugs.webkit.org/show_bug.cgi?id=197069
829         <rdar://problem/50025800>
830
831         Reviewed by Tim Horton.
832
833         Add a block property for -didCommitNavigation to TestNavigationDelegate.
834
835         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
836         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
837         (-[TestNavigationDelegate webView:didCommitNavigation:]):
838
839 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
840
841         [CMake] Make WebCore headers copies
842         https://bugs.webkit.org/show_bug.cgi?id=182512
843         <rdar://problem/37510435>
844
845         Reviewed by Alex Christensen.
846
847         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
848         ports.
849
850         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
851         of WebCore headers using "*.h" were modified to <WebCore/*.h>
852
853         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
854         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
855         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
856         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
857         * TestWebKitAPI/CMakeLists.txt:
858         * TestWebKitAPI/PlatformWin.cmake:
859         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
860         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
861         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
862
863 2019-04-18  Jer Noble  <jer.noble@apple.com>
864
865         Add support for parsing FairPlayStreaming PSSH boxes.
866         https://bugs.webkit.org/show_bug.cgi?id=197064
867
868         Reviewed by Eric Carlson.
869
870         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
871         (TestWebKitAPI::TEST):
872
873 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
874
875         InjectedBundle parameters often need initialization function called before unarchiving
876         https://bugs.webkit.org/show_bug.cgi?id=189709
877         <rdar://problem/44573653>
878
879         Reviewed by Ryosuke Niwa.
880
881         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
882         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
883
884 2019-04-18  Zalan Bujtas  <zalan@apple.com>
885
886         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
887         https://bugs.webkit.org/show_bug.cgi?id=196948
888         <rdar://problem/49927131>
889
890         Reviewed by Tim Horton.
891
892         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
893         (TEST): 
894         The expected order of incoming events is
895         1. didInvalidateIntrinsicContentSize
896         2. didFirstLayout
897         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
898         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
899         (and remember, all we care about is ordering).
900
901 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
902
903         Unreviewed, rolling out r244299.
904
905         Breaks internal tests.
906
907         Reverted changeset:
908
909         "InjectedBundle parameters often need initialization function
910         called before unarchiving"
911         https://bugs.webkit.org/show_bug.cgi?id=189709
912         https://trac.webkit.org/changeset/244299
913
914 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
915
916         [WTF] StringBuilder should set correct m_is8Bit flag when merging
917         https://bugs.webkit.org/show_bug.cgi?id=197053
918
919         Reviewed by Saam Barati.
920
921         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
922         (TestWebKitAPI::TEST):
923
924 2019-04-17  Tim Horton  <timothy_horton@apple.com>
925
926         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
927         https://bugs.webkit.org/show_bug.cgi?id=197028
928         <rdar://problem/49985290>
929
930         Reviewed by Wenson Hsieh.
931
932         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
933         (TEST):
934         Liberal application of waitForNextPresentationUpdate works around a race
935         where if the page rapidly changes its viewport arguments (or an API client
936         rapidly changes its viewport arguments), we'd get stuck thinking that the
937         user had intentionally zoomed the page, and stop resetting the initial scale.
938         This deserves a separate bug, but no need to keep the test failing while
939         we think about it.
940
941 2019-04-17  Tim Horton  <timothy_horton@apple.com>
942
943         REGRESSION (r241988): Switching tabs is slow
944         https://bugs.webkit.org/show_bug.cgi?id=197037
945         <rdar://problem/49951473>
946
947         Reviewed by Simon Fraser.
948
949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
950         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
951         (TEST):
952         * TestWebKitAPI/cocoa/TestWKWebView.h:
953         * TestWebKitAPI/cocoa/TestWKWebView.mm:
954         (-[TestWKWebView addToTestWindow]):
955         Add a test that hangs without this fix.
956
957 2019-04-17  Truitt Savell  <tsavell@apple.com>
958
959         Unreviewed, rolling out r244400.
960
961         Caused testing to exit early with assertionon Debug WK2
962
963         Reverted changeset:
964
965         "UI↔Web deadlock when printing with a JavaScript alert
966         visible"
967         https://bugs.webkit.org/show_bug.cgi?id=196839
968         https://trac.webkit.org/changeset/244400
969
970 2019-04-17  Brady Eidson  <beidson@apple.com>
971
972         Link clicks in PDFs shouldn't send referrer headers.
973         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
974
975         Reviewed by Tim Horton.
976
977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
978         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
979         (putPDFBytesCallback):
980         (emptyReleaseInfoCallback):
981         (createPDFWithLinkToURL):
982         (TEST):
983
984 2019-04-17  Tim Horton  <timothy_horton@apple.com>
985
986         UI↔Web deadlock when printing with a JavaScript alert visible
987         https://bugs.webkit.org/show_bug.cgi?id=196839
988         <rdar://problem/49157642>
989
990         Reviewed by Andy Estes.
991
992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
993         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
994         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
995         (TEST):
996
997 2019-04-17  Alex Christensen  <achristensen@webkit.org>
998
999         WKRetainPtr's adoption constructor should be private
1000         https://bugs.webkit.org/show_bug.cgi?id=197019
1001
1002         Reviewed by Tim Horton.
1003
1004         * DumpRenderTree/mac/DumpRenderTree.mm:
1005         (dumpFramesAsText):
1006         * TestWebKitAPI/InjectedBundleController.cpp:
1007         (TestWebKitAPI::InjectedBundleController::initialize):
1008         * TestWebKitAPI/PlatformUtilities.cpp:
1009         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1010         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1011         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1012         (TestWebKitAPI::Util::toWK):
1013         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1014         (TestWebKitAPI::TEST):
1015         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1016         (TestWebKitAPI::TEST):
1017         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1018         (TestWebKitAPI::TEST):
1019         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1020         (TestWebKitAPI::TEST):
1021         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1022         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1023         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1024         (TestWebKitAPI::TEST):
1025         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1026         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1027         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1028         (TestWebKitAPI::TEST):
1029         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1030         (TestWebKitAPI::TEST):
1031         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1032         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1033         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1034         (TestWebKitAPI::TEST):
1035         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1036         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1037         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1038         (TestWebKitAPI::TEST):
1039         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1040         (TestWebKitAPI::TEST):
1041         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1042         (TestWebKitAPI::TEST):
1043         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1044         (TestWebKitAPI::TEST):
1045         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1046         (TestWebKitAPI::TEST):
1047         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1048         (TestWebKitAPI::TEST):
1049         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1050         (TestWebKitAPI::TEST):
1051         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1052         (TestWebKitAPI::TEST):
1053         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1054         (TestWebKitAPI::TEST):
1055         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1056         (TestWebKitAPI::TEST):
1057         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1058         (TestWebKitAPI::TEST):
1059         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1060         (TestWebKitAPI::TEST):
1061         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1062         (TestWebKitAPI::TEST):
1063         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1064         (TestWebKitAPI::TEST):
1065         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1066         (TestWebKitAPI::TEST):
1067         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1068         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1069         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1070         (TestWebKitAPI::TEST):
1071         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1072         (TestWebKitAPI::TEST):
1073         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1074         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1075         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1076         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1077         (TestWebKitAPI::TEST):
1078         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1079         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1080         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1081         (TestWebKitAPI::TEST):
1082         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1083         (TestWebKitAPI::TEST):
1084         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1085         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1086         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1087         (TestWebKitAPI::TEST):
1088         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1089         (TestWebKitAPI::loadAlternateHTMLString):
1090         (TestWebKitAPI::TEST):
1091         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1092         (TestWebKitAPI::TEST):
1093         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1094         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1095         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1096         (TestWebKitAPI::buildAndPerformTest):
1097         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1098         (TestWebKitAPI::TEST):
1099         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1100         (TestWebKitAPI::TEST):
1101         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1102         (TestWebKitAPI::TEST):
1103         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1104         (TestWebKitAPI::TEST):
1105         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1106         (TestWebKitAPI::TEST):
1107         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1108         (TestWebKitAPI::TEST):
1109         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1110         (TestWebKitAPI::TEST):
1111         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1112         (TestWebKitAPI::TEST):
1113         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1114         (TestWebKitAPI::TEST):
1115         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1116         (TestWebKitAPI::TEST):
1117         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1118         (TestWebKitAPI::TEST):
1119         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1120         (TestWebKitAPI::TEST):
1121         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1122         (TestWebKitAPI::TEST):
1123         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1124         (TestWebKitAPI::TEST):
1125         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1126         (TestWebKitAPI::TEST):
1127         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1128         (TestWebKitAPI::TEST):
1129         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1130         (TestWebKitAPI::TEST):
1131         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1132         (TestWebKitAPI::TEST):
1133         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1134         (TestWebKitAPI::TEST):
1135         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1136         (TestWebKitAPI::TEST):
1137         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1138         (TestWebKitAPI::TEST):
1139         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1140         (TestWebKitAPI::TEST):
1141         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1142         (TestWebKitAPI::TEST):
1143         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1144         (TestWebKitAPI::TEST):
1145         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1146         (TestWebKitAPI::TEST):
1147         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1148         (TestWebKitAPI::TEST):
1149         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1150         (TestWebKitAPI::TEST):
1151         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1152         (TestWebKitAPI::TEST):
1153         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1154         (TestWebKitAPI::TEST):
1155         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1156         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1157         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1158         (TestWebKitAPI::TEST):
1159         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1160         (TestWebKitAPI::TEST):
1161         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1162         (TestWebKitAPI::TEST):
1163         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1164         (TestWebKitAPI::TEST):
1165         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1166         (TestWebKitAPI::TEST):
1167         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1168         (TestWebKitAPI::TEST):
1169         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1170         (TestWebKitAPI::TEST):
1171         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1172         (TestWebKitAPI::TEST):
1173         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1174         (TestWebKitAPI::TEST):
1175         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1176         (TestWebKitAPI::TEST):
1177         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1179         (TEST):
1180         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1181         (TEST):
1182         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1183         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1184         (TEST):
1185         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1186         (TestWebKitAPI::TEST):
1187         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1188         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1189         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1190         (WTR::getMenuItemTitleCallback):
1191         (WTR::createMouseMessageBody):
1192         (WTR::EventSendingController::mouseDown):
1193         (WTR::EventSendingController::mouseUp):
1194         (WTR::EventSendingController::mouseMoveTo):
1195         (WTR::EventSendingController::mouseForceClick):
1196         (WTR::EventSendingController::startAndCancelMouseForceClick):
1197         (WTR::EventSendingController::mouseForceDown):
1198         (WTR::EventSendingController::mouseForceUp):
1199         (WTR::EventSendingController::mouseForceChanged):
1200         (WTR::EventSendingController::leapForward):
1201         (WTR::EventSendingController::scheduleAsynchronousClick):
1202         (WTR::createKeyDownMessageBody):
1203         (WTR::EventSendingController::keyDown):
1204         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1205         (WTR::EventSendingController::mouseScrollBy):
1206         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1207         (WTR::EventSendingController::continuousMouseScrollBy):
1208         (WTR::EventSendingController::addTouchPoint):
1209         (WTR::EventSendingController::updateTouchPoint):
1210         (WTR::EventSendingController::setTouchModifier):
1211         (WTR::EventSendingController::setTouchPointRadius):
1212         (WTR::EventSendingController::touchStart):
1213         (WTR::EventSendingController::touchMove):
1214         (WTR::EventSendingController::touchEnd):
1215         (WTR::EventSendingController::touchCancel):
1216         (WTR::EventSendingController::clearTouchPoints):
1217         (WTR::EventSendingController::releaseTouchPoint):
1218         (WTR::EventSendingController::cancelTouchPoint):
1219         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1220         (WTR::InjectedBundle::didCreatePage):
1221         (WTR::InjectedBundle::didReceiveMessage):
1222         (WTR::InjectedBundle::didReceiveMessageToPage):
1223         (WTR::InjectedBundle::booleanForKey):
1224         (WTR::InjectedBundle::done):
1225         (WTR::InjectedBundle::dumpToStdErr):
1226         (WTR::InjectedBundle::outputText):
1227         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1228         (WTR::InjectedBundle::postAddChromeInputField):
1229         (WTR::InjectedBundle::postRemoveChromeInputField):
1230         (WTR::InjectedBundle::postFocusWebView):
1231         (WTR::InjectedBundle::postSetBackingScaleFactor):
1232         (WTR::InjectedBundle::postSetWindowIsKey):
1233         (WTR::InjectedBundle::postSetViewSize):
1234         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1235         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1236         (WTR::InjectedBundle::setGeolocationPermission):
1237         (WTR::InjectedBundle::setMockGeolocationPosition):
1238         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1239         (WTR::InjectedBundle::isGeolocationProviderActive const):
1240         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1241         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1242         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1243         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1244         (WTR::InjectedBundle::setCustomPolicyDelegate):
1245         (WTR::InjectedBundle::setHidden):
1246         (WTR::InjectedBundle::setCacheModel):
1247         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1248         (WTR::InjectedBundle::processWorkQueue):
1249         (WTR::InjectedBundle::queueBackNavigation):
1250         (WTR::InjectedBundle::queueForwardNavigation):
1251         (WTR::InjectedBundle::queueLoad):
1252         (WTR::InjectedBundle::queueLoadHTMLString):
1253         (WTR::InjectedBundle::queueReload):
1254         (WTR::InjectedBundle::queueLoadingScript):
1255         (WTR::InjectedBundle::queueNonLoadingScript):
1256         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1257         (WTR::frameToStr):
1258         (WTR::InjectedBundlePage::InjectedBundlePage):
1259         (WTR::dumpFrameDescriptionSuitableForTestResult):
1260         (WTR::dumpFrameScrollPosition):
1261         (WTR::dumpDescendantFrameScrollPositions):
1262         (WTR::dumpFrameText):
1263         (WTR::dumpDescendantFramesText):
1264         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1265         (WTR::TestRunner::shouldDumpPixels const):
1266         (WTR::TestRunner::setDumpPixels):
1267         (WTR::TestRunner::whatToDump const):
1268         (WTR::TestRunner::setWhatToDump):
1269         (WTR::TestRunner::setWaitUntilDone):
1270         (WTR::TestRunner::shouldWaitUntilDone const):
1271         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1272         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1273         (WTR::TestRunner::clearAllDatabases):
1274         (WTR::TestRunner::setIDBPerOriginQuota):
1275         (WTR::TestRunner::originsWithApplicationCache):
1276         (WTR::TestRunner::setCanOpenWindows):
1277         (WTR::TestRunner::setXSSAuditorEnabled):
1278         (WTR::TestRunner::setMediaDevicesEnabled):
1279         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1280         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1281         (WTR::TestRunner::setCustomUserAgent):
1282         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1283         (WTR::TestRunner::setModernMediaControlsEnabled):
1284         (WTR::TestRunner::setWebGL2Enabled):
1285         (WTR::TestRunner::setWritableStreamAPIEnabled):
1286         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1287         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1288         (WTR::TestRunner::setAllowsAnySSLCertificate):
1289         (WTR::TestRunner::setPluginsEnabled):
1290         (WTR::TestRunner::setValueForUser):
1291         (WTR::TestRunner::setAudioResult):
1292         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1293         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1294         (WTR::TestRunner::setAlwaysAcceptCookies):
1295         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1296         (WTR::TestRunner::isDoingMediaCapture const):
1297         (WTR::TestRunner::queueLoad):
1298         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1299         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1300         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1301         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1302         (WTR::TestRunner::setAuthenticationUsername):
1303         (WTR::TestRunner::setAuthenticationPassword):
1304         (WTR::TestRunner::secureEventInputIsEnabled const):
1305         (WTR::TestRunner::setBlockAllPlugins):
1306         (WTR::TestRunner::setPluginSupportedMode):
1307         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1308         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1309         (WTR::TestRunner::setNavigationGesturesEnabled):
1310         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1311         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1312         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1313         (WTR::TestRunner::terminateNetworkProcess):
1314         (WTR::TestRunner::terminateServiceWorkerProcess):
1315         (WTR::TestRunner::runUIScript):
1316         (WTR::TestRunner::setStatisticsDebugMode):
1317         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1318         (WTR::TestRunner::setStatisticsLastSeen):
1319         (WTR::TestRunner::setStatisticsPrevalentResource):
1320         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1321         (WTR::TestRunner::dumpResourceLoadStatistics):
1322         (WTR::TestRunner::isStatisticsPrevalentResource):
1323         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1324         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1325         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1326         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1327         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1328         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1329         (WTR::TestRunner::setStatisticsGrandfathered):
1330         (WTR::TestRunner::isStatisticsGrandfathered):
1331         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1332         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1333         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1334         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1335         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1336         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1337         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1338         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1339         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1340         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1341         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1342         (WTR::TestRunner::statisticsSubmitTelemetry):
1343         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1344         (WTR::TestRunner::setStatisticsIsRunningTest):
1345         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1346         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1347         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1348         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1349         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1350         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1351         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1352         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1353         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1354         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1355         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1356         (WTR::TestRunner::statisticsResetToConsistentState):
1357         (WTR::TestRunner::setStorageAccessAPIEnabled):
1358         (WTR::TestRunner::getAllStorageAccessEntries):
1359         (WTR::TestRunner::addMockMediaDevice):
1360         (WTR::TestRunner::clearMockMediaDevices):
1361         (WTR::TestRunner::removeMockMediaDevice):
1362         (WTR::TestRunner::resetMockMediaDevices):
1363         (WTR::TestRunner::connectMockGamepad):
1364         (WTR::TestRunner::disconnectMockGamepad):
1365         (WTR::TestRunner::setMockGamepadDetails):
1366         (WTR::TestRunner::setMockGamepadAxisValue):
1367         (WTR::TestRunner::setMockGamepadButtonValue):
1368         (WTR::TestRunner::removeAllSessionCredentials):
1369         (WTR::TestRunner::clearDOMCache):
1370         (WTR::TestRunner::clearDOMCaches):
1371         (WTR::TestRunner::hasDOMCache):
1372         (WTR::TestRunner::domCacheSize):
1373         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1374         (WTR::TestRunner::getApplicationManifestThen):
1375         (WTR::TestRunner::injectUserScript):
1376         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1377         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1378         (WTR::TestRunner::addTestKeyToKeychain):
1379         (WTR::TestRunner::cleanUpKeychain):
1380         (WTR::TestRunner::keyExistsInKeychain):
1381         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1382         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1383         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1384         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1385         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1386         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1387         * WebKitTestRunner/TestController.cpp:
1388         (WTR::TestController::initialize):
1389         (WTR::parseStringTestHeaderValueAsRelativePath):
1390         (WTR::updateTestOptionsFromTestHeader):
1391         (WTR::TestController::runTest):
1392         (WTR::TestController::didReceiveLiveDocumentsList):
1393         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1394         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1395         (WTR::TestController::didFinishNavigation):
1396         (WTR::TestController::didReceiveAuthenticationChallenge):
1397         * WebKitTestRunner/TestInvocation.cpp:
1398         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1399         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1400         (WTR::TestInvocation::uiScriptDidComplete):
1401         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1402         * WebKitTestRunner/WebNotificationProvider.cpp:
1403         (WTR::WebNotificationProvider::closeWebNotification):
1404         * WebKitTestRunner/WorkQueueManager.cpp:
1405         (WTR::ScriptItem::ScriptItem):
1406         (WTR::WorkQueueManager::queueLoad):
1407         (WTR::WorkQueueManager::queueLoadHTMLString):
1408
1409 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1410
1411         Add a comment to make my test from r244139 less mysterious.
1412         https://bugs.webkit.org/show_bug.cgi?id=196744
1413
1414         As suggested by Darin Adler.
1415
1416         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1417         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1418
1419 2019-04-17  Chris Dumez  <cdumez@apple.com>
1420
1421         Remember device orientation permission for the duration of the browsing session
1422         https://bugs.webkit.org/show_bug.cgi?id=196992
1423         <rdar://problem/49946067>
1424
1425         Reviewed by Alex Christensen.
1426
1427         Add API test coverage.
1428
1429         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1430         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1431         (TEST):
1432
1433 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1434
1435         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1436         https://bugs.webkit.org/show_bug.cgi?id=196675
1437
1438         Reviewed by Lucas Forschler.
1439
1440         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1441         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1442
1443 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1444
1445         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1446         https://bugs.webkit.org/show_bug.cgi?id=196919
1447         <rdar://problem/41630459>
1448
1449         Reviewed by Tim Horton.
1450
1451         Add iOS support for several new testing hooks. See below for more detail.
1452
1453         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1454         (WTR::UIScriptController::isDismissingMenu const):
1455
1456         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1457         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1458         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1459
1460         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1461         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1462         (WTR::UIScriptController::isDismissingMenu const):
1463         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1464         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1465         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1466         (WTR::InjectedBundle::didReceiveMessageToPage):
1467         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1468         (WTR::TestRunner::setAllowedMenuActions):
1469
1470         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1471         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1472         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1473         against the name of the custom action.
1474
1475         (WTR::TestRunner::installCustomMenuAction):
1476
1477         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1478         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1479         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1480         triggered.
1481
1482         (WTR::TestRunner::performCustomMenuAction):
1483
1484         Invoked when the custom menu action is triggered.
1485
1486         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1487         * WebKitTestRunner/TestController.cpp:
1488         (WTR::TestController::installCustomMenuAction):
1489         (WTR::TestController::setAllowedMenuActions):
1490         * WebKitTestRunner/TestController.h:
1491         * WebKitTestRunner/TestInvocation.cpp:
1492         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1493         (WTR::TestInvocation::performCustomMenuAction):
1494
1495         Add plumbing to call back into the injected bundle when performing the custom action.
1496
1497         * WebKitTestRunner/TestInvocation.h:
1498         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1499         (WTR::TestController::installCustomMenuAction):
1500         (WTR::TestController::setAllowedMenuActions):
1501         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1502         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1503         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1504         (-[TestRunnerWKWebView becomeFirstResponder]):
1505         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1506
1507         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1508         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1509         in the Mail app on iOS.
1510
1511         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1512         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1513         (-[TestRunnerWKWebView resetCustomMenuAction]):
1514         (-[TestRunnerWKWebView performCustomAction:]):
1515         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1516         (-[TestRunnerWKWebView _willHideMenu]):
1517         (-[TestRunnerWKWebView _didHideMenu]):
1518         * WebKitTestRunner/ios/TestControllerIOS.mm:
1519         (WTR::TestController::platformResetStateToConsistentValues):
1520
1521         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1522         if specified.
1523
1524         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1525         (WTR::UIScriptController::isDismissingMenu const):
1526
1527 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1528
1529         Allow sharing from imageSheet on an image document
1530         https://bugs.webkit.org/show_bug.cgi?id=196891
1531         <rdar://problem/25377386>
1532
1533         Reviewed by Tim Horton.
1534
1535         Test to make sure that the correct imageURL is extracted from an image element.
1536
1537         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1538         (TestWebKitAPI::TEST):
1539
1540 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1541
1542         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1543         https://bugs.webkit.org/show_bug.cgi?id=196995
1544
1545         Reviewed by Brady Eidson.
1546
1547         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1548         (TEST):
1549
1550 2019-04-16  Chris Dumez  <cdumez@apple.com>
1551
1552         URL set by document.open() is not communicated to the UIProcess
1553         https://bugs.webkit.org/show_bug.cgi?id=196941
1554         <rdar://problem/49237544>
1555
1556         Reviewed by Geoff Garen.
1557
1558         Add API test coverage.
1559
1560         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1561         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1562         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1563         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1564         (TEST):
1565
1566 2019-04-16  Commit Queue  <commit-queue@webkit.org>
1567
1568         Unreviewed, rolling out r244321.
1569         https://bugs.webkit.org/show_bug.cgi?id=196968
1570
1571         Causing all WK2 Debug builds to exit early after Assertion
1572         failures. (Requested by ShawnRoberts on #webkit).
1573
1574         Reverted changeset:
1575
1576         "URL set by document.open() is not communicated to the
1577         UIProcess"
1578         https://bugs.webkit.org/show_bug.cgi?id=196941
1579         https://trac.webkit.org/changeset/244321
1580
1581 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1582
1583         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1584         https://bugs.webkit.org/show_bug.cgi?id=196948
1585
1586         Reviewed by Zalan Bujtas.
1587
1588         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1589         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1590
1591 2019-04-15  Chris Dumez  <cdumez@apple.com>
1592
1593         URL set by document.open() is not communicated to the UIProcess
1594         https://bugs.webkit.org/show_bug.cgi?id=196941
1595         <rdar://problem/49237544>
1596
1597         Reviewed by Geoffrey Garen.
1598
1599         Add API test coverage.
1600
1601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1602         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1603         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1604         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1605         (TEST):
1606
1607 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1608
1609         Using Tools/Scripts/clean-webkit should not install requests
1610         https://bugs.webkit.org/show_bug.cgi?id=196940
1611
1612         Reviewed by Lucas Forschler.
1613
1614         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1615         existing, depending on the path autoinstalled is run through.
1616         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1617         needed.
1618         (Port.configuration_for_upload):
1619         (Port.commits_for_upload):
1620
1621 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1622
1623         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1624         https://bugs.webkit.org/show_bug.cgi?id=196773
1625
1626         Reviewed by Jer Noble.
1627
1628         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1629         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1630         (TEST):
1631
1632 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1633
1634         ews-build should clearly indicate flaky test failures
1635         https://bugs.webkit.org/show_bug.cgi?id=196947
1636
1637         Reviewed by Lucas Forschler.
1638
1639         * BuildSlaveSupport/ews-build/steps.py:
1640         (AnalyzeAPITestsResults.analyzeResults):
1641
1642 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1643
1644         InjectedBundle parameters often need initialization function called before unarchiving
1645         https://bugs.webkit.org/show_bug.cgi?id=189709
1646         <rdar://problem/44573653>
1647
1648         Reviewed by Ryosuke Niwa.
1649
1650         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1651         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1652
1653 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1654
1655         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1656         https://bugs.webkit.org/show_bug.cgi?id=196681
1657
1658         Reviewed by Darin Adler.
1659
1660         Added tests.
1661
1662         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1663         (WTF_HashSet.RemoveIf):
1664         (WTF_HashSet.RemoveIfShrinkToBestSize):
1665
1666 2019-04-15  John Wilander  <wilander@apple.com>
1667
1668         Send delayed Ad Click Attribution conversion requests to the click source
1669         https://bugs.webkit.org/show_bug.cgi?id=196838
1670         <rdar://problem/47650157>
1671
1672         Reviewed by Chris Dumez and Youenn Fablet.
1673
1674         This patch adds test infrastructure to override the default behavior in
1675         WebKit::NetworkAdClickAttribution.
1676
1677         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1678         (TestWebKitAPI::TEST):
1679         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1680         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1681         (WTR::TestRunner::dumpAdClickAttribution):
1682         (WTR::TestRunner::clearAdClickAttribution):
1683         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1684         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1685         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1686         * WebKitTestRunner/TestController.cpp:
1687         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1688         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1689         * WebKitTestRunner/TestController.h:
1690         * WebKitTestRunner/TestInvocation.cpp:
1691         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1692
1693 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1694
1695         [ews-app] status-bubble should display position in queue
1696         https://bugs.webkit.org/show_bug.cgi?id=196607
1697
1698         Reviewed by Lucas Forschler.
1699
1700         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1701         (StatusBubble._build_bubble):
1702         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1703
1704 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1705
1706         [ews-build] Do not run clean build by default on EWS builders
1707         https://bugs.webkit.org/show_bug.cgi?id=196897
1708
1709         Reviewed by Lucas Forschler.
1710
1711         * BuildSlaveSupport/ews-build/steps.py:
1712         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1713         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1714         untracked directories like WebKitBuild).
1715         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1716         untracked files/directories (like WebKitBuild).
1717
1718 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1719
1720         TestRunner::notifyDone() should be safely reentrant
1721         https://bugs.webkit.org/show_bug.cgi?id=196898
1722
1723         Reviewed by Darin Adler.
1724
1725         It is currently possible that TestRunner::notifyDone() will call itself, since
1726         notifyDone() will force a repaint, which can start executing JavaScript, which
1727         may call notifyDone() again. This can lead to test failures and flakiness.
1728         Fix this by setting the m_waitToDump flag before calling the dump() method.
1729
1730         * DumpRenderTree/mac/TestRunnerMac.mm:
1731         (TestRunner::notifyDone):
1732         (TestRunner::forceImmediateCompletion):
1733         * DumpRenderTree/win/TestRunnerWin.cpp:
1734         (TestRunner::notifyDone):
1735         (TestRunner::forceImmediateCompletion):
1736
1737 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1738
1739         [GTK][WPE] Add enable-media websetting
1740         https://bugs.webkit.org/show_bug.cgi?id=196863
1741
1742         Reviewed by Michael Catanzaro.
1743
1744         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1745         (testWebKitSettings): Add test for the enable-media web-setting.
1746
1747 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1748
1749         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1750         https://bugs.webkit.org/show_bug.cgi?id=196905
1751         <rdar://problem/49886096>
1752
1753         Reviewed by Tim Horton.
1754
1755         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1756         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1757         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1758         delay timer, we end up with this sequence of events in the problematic (failure) case:
1759
1760         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1761             ...IPC from UI to web process...
1762         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1763             ...IPC from web to UI process...
1764         (c) [UI]    Invoke completion handler for script #1
1765         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1766             ...IPC from UI to web process...
1767         (e) [Web]   Evaluate script #2 in the web process
1768         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1769
1770         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1771         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1772         #2 is run in step (e).
1773
1774         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1775         the UI process by waiting on a script message posted by the web process, after attachment updates are
1776         dispatched.
1777
1778         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1779         (TestWebKitAPI::TEST):
1780
1781 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1782
1783         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1784         https://bugs.webkit.org/show_bug.cgi?id=196909
1785
1786         Reviewed by Wenson Hsieh.
1787
1788         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1789         (TestWebKitAPI::TEST):
1790
1791 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1792
1793         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1794         https://bugs.webkit.org/show_bug.cgi?id=196880
1795
1796         Reviewed by Yusuke Suzuki.
1797
1798         Add a new function for bytecode cache tests that does not forceDiskCache
1799         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1800         test added in this patch, since the code is invalid and therefore won't be
1801         cached. It should also be useful for tests that evaluate dynamically
1802         generated code.
1803
1804         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1805         * Scripts/run-jsc-stress-tests:
1806
1807 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1808
1809         Update AudioSession route sharing policy
1810         https://bugs.webkit.org/show_bug.cgi?id=196776
1811         <rdar://problem/46501611>
1812
1813         Reviewed by Jer Noble.
1814
1815         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1816         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1817         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1818         (TestWebKitAPI::TEST):
1819
1820 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1821
1822         [iOS] Software keyboard is shown too frequently on some websites
1823         https://bugs.webkit.org/show_bug.cgi?id=195856
1824         <rdar://problem/49191395>
1825
1826         Reviewed by Darin Adler.
1827
1828         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1829
1830         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1831         (WTR::UIScriptController::setHardwareKeyboardAttached):
1832         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1833         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1834         (WTR::UIScriptController::setHardwareKeyboardAttached):
1835         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1836         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1837
1838         Additionally link against GraphicsServices in WebKitTestRunner.
1839
1840         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1841         (WTR::TestController::platformResetStateToConsistentValues):
1842         (WTR::UIScriptController::setHardwareKeyboardAttached):
1843
1844 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1845
1846         [GTK][WPE] Fix pacman install-dependencies packages
1847         https://bugs.webkit.org/show_bug.cgi?id=196817
1848
1849         Reviewed by Žan Doberšek.
1850         
1851         python3-setuptools is called python-setuptools
1852         ruby-highline is only available on AUR
1853         libv4l-devel is incorporated in v4l-utils
1854
1855         * gtk/install-dependencies:
1856         * wpe/install-dependencies:
1857
1858 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1859
1860         [GTK] REGRESSION(r243860): Many tests failing
1861         https://bugs.webkit.org/show_bug.cgi?id=196791
1862
1863         Reviewed by Joanmarie Diggs.
1864
1865         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1866         multiple documents and check that accessibility hierarchy is updated after a navigation.
1867
1868         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1869         (loadChangedCallback):
1870         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1871         (AccessibilityTest::AccessibilityTest):
1872         (AccessibilityTest::~AccessibilityTest):
1873         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1874         (AccessibilityTest::findTestServerApplication):
1875         (AccessibilityTest::findDocumentWeb):
1876         (AccessibilityTest::findRootObject):
1877         (AccessibilityTest::waitUntilChildrenRemoved):
1878         (AccessibilityTest::ensureProxy):
1879         (testAtspiBasicHierarchy):
1880         (beforeAll):
1881         (afterAll):
1882
1883 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1884
1885         [ews-build] Handle bug titles with unicode characters
1886         https://bugs.webkit.org/show_bug.cgi?id=196802
1887
1888         Reviewed by Dewei Zhu.
1889
1890         * BuildSlaveSupport/ews-build/steps.py:
1891         (ValidatePatch._is_bug_closed):
1892
1893 2019-04-11  Michael Saboff  <msaboff@apple.com>
1894
1895         Improve the Inline Cache Stats code
1896         https://bugs.webkit.org/show_bug.cgi?id=196836
1897
1898         Reviewed by Saam Barati.
1899
1900         Added a new script to consolidate and arrange the output of --useICStats option.
1901
1902         This script merges the output from every group into one large table and sorts it from most common to
1903         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1904         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1905         Put together, this is useful to see what property accesses are not getting cached.
1906
1907         * Scripts/ic-stats.py: Added.
1908         (ICStats):
1909         (ICStats.__init__):
1910         (ICStats.parse):
1911         (ICStats.dumpStats):
1912         (usage):
1913
1914 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1915
1916         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1917         https://bugs.webkit.org/show_bug.cgi?id=196809
1918         <rdar://49800762>
1919
1920         Reviewed by Brady Eidson.
1921
1922         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1923         (TEST):
1924
1925 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1926
1927         requestAnimationFrame should execute before the next frame
1928         https://bugs.webkit.org/show_bug.cgi?id=177484
1929
1930         Reviewed by Simon Fraser.
1931
1932         Add trace points for the page RenderingUpdate.
1933
1934         * Tracing/SystemTracePoints.plist:
1935
1936 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1937
1938         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1939         https://bugs.webkit.org/show_bug.cgi?id=196760
1940
1941         Reviewed by Don Olmstead.
1942
1943         vswhere.exe has been bundled since Visual Studio 2017 version
1944         15.2. We shouldn't download vswhere.exe.
1945
1946         * Scripts/build-jsc: Do not call update-vswhere.py.
1947         * Scripts/build-webkit: Ditto.
1948         * Scripts/update-vswhere.py: Removed.
1949         * Scripts/webkitdirs.pm:
1950         (requireModulesForVSWhere): Deleted.
1951         (pickCurrentVisualStudioInstallation): Deleted.
1952         (visualStudioInstallDirVSWhere): Return the latest installed VS
1953         installation path by using the bundled vswhere.exe.
1954         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1955         (visualStudioInstallDirFallback): Removed.
1956
1957 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1958
1959         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1960         https://bugs.webkit.org/show_bug.cgi?id=196780
1961
1962         Reviewed by Alexey Proskuryakov.
1963
1964         * BuildSlaveSupport/ews-build/steps.py:
1965         * BuildSlaveSupport/ews-build/steps_unittest.py:
1966
1967 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1968
1969         Add SPI WKNavigationResponse._downloadAttribute
1970         https://bugs.webkit.org/show_bug.cgi?id=196755
1971         <rdar://49587365>
1972
1973         Reviewed by Brady Eidson.
1974
1975         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1976         (-[NavigationResponseTestDelegate navigationResponse]):
1977         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1978         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1979         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1980         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1981         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1982         (readRequest):
1983         (writeResponse):
1984         (TEST):
1985
1986 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1987
1988         Add modern API for overriding the page's specified viewport configuration
1989         https://bugs.webkit.org/show_bug.cgi?id=167734
1990         <rdar://problem/30331795>
1991
1992         Reviewed by Simon Fraser.
1993
1994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1995         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1996
1997 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1998
1999         Add support for incremental bytecode cache updates
2000         https://bugs.webkit.org/show_bug.cgi?id=195000
2001
2002         Reviewed by Filip Pizlo.
2003
2004         Exit when the initial run to generate bytecode fails.
2005
2006         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2007
2008 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2009
2010         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2011         https://bugs.webkit.org/show_bug.cgi?id=196744
2012         <rdar://49415309>
2013
2014         Reviewed by Chris Dumez.
2015
2016         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2017         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2018
2019 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2020
2021         Add a way to opt into modern compatibility mode in layout tests
2022         https://bugs.webkit.org/show_bug.cgi?id=196770
2023         <rdar://problem/49777550>
2024
2025         Reviewed by Antoine Quint.
2026
2027         Add a new test option to enable modern compatibility mode in layout tests.
2028
2029         * WebKitTestRunner/TestController.cpp:
2030         (WTR::updateTestOptionsFromTestHeader):
2031         * WebKitTestRunner/TestController.h:
2032         * WebKitTestRunner/TestOptions.h:
2033         (WTR::TestOptions::hasSameInitializationOptions const):
2034         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2035         (WTR::TestController::platformCreateWebView):
2036         (WTR::TestController::enableModernCompatibilityMode):
2037
2038 2019-04-10  Andy Estes  <aestes@apple.com>
2039
2040         Try to fix the 32-bit watchOS build.
2041
2042         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2043         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2044
2045 2019-04-10  Antoine Quint  <graouts@apple.com>
2046
2047         Enable Pointer Events on watchOS
2048         https://bugs.webkit.org/show_bug.cgi?id=196771
2049         <rdar://problem/49040909>
2050
2051         Reviewed by Dean Jackson.
2052
2053         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2054
2055 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2056
2057         Unreviewed. Fix WPE accessibility tests after r244059.
2058
2059         We are failing to load the injected bundle due to undefined symbol
2060         AccessibilityUIElement::replaceTextInRange().
2061
2062         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2063         (WTR::AccessibilityUIElement::replaceTextInRange):
2064
2065 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2066
2067         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2068         https://bugs.webkit.org/show_bug.cgi?id=196727
2069
2070         Reviewed by Fujii Hironori.
2071
2072         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2073         (WebKitBrowserWindow::create):
2074
2075 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2076
2077         [ews-build] Add unit tests for PrintConfiguration
2078         https://bugs.webkit.org/show_bug.cgi?id=196752
2079
2080         Reviewed by Dewei Zhu.
2081
2082         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2083
2084 2019-04-09  Keith Rollin  <krollin@apple.com>
2085
2086         Unreviewed build maintenance -- update .xcfilelists.
2087
2088         * DumpRenderTree/DerivedSources-input.xcfilelist:
2089         * DumpRenderTree/DerivedSources-output.xcfilelist:
2090
2091 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2092
2093         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2094         https://bugs.webkit.org/show_bug.cgi?id=196743
2095         <rdar://problem/43897551>
2096
2097         Reviewed by Tim Horton.
2098
2099         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2100         (TEST):
2101
2102 2019-04-09  Youenn Fablet  <youenn@apple.com>
2103
2104         Close service worker database on network process suspension
2105         https://bugs.webkit.org/show_bug.cgi?id=196623
2106         <rdar://problem/48930869>
2107
2108         Reviewed by Alex Christensen.
2109
2110         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2111
2112 2019-04-09  Daniel Bates  <dabates@apple.com>
2113
2114         [iPad] Should open popover when the spacebar is pressed
2115         https://bugs.webkit.org/show_bug.cgi?id=196360
2116         <rdar://problem/49389129>
2117
2118         Reviewed by Brent Fulgham.
2119
2120         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2121
2122         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2123         (WTR::UIScriptController::isShowingPopover const): Added.
2124         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2125         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2126         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2127         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2128         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2129         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2130         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2131         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2132         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2133         (WTR::UIScriptController::isShowingPopover const): Added.
2134         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2135         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2136         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2137         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2138         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2139         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2140         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2141         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2142         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2143         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2144         (WTR::UIScriptController::isShowingPopover const): Added.
2145         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2146         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2147
2148 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2149
2150         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2151         https://bugs.webkit.org/show_bug.cgi?id=196665
2152         <rdar://45115669>
2153
2154         Reviewed by Geoff Garen.
2155
2156         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2157         (goBack):
2158         (+[SimpleLookupContext sharedLookupContext]):
2159         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2160         (TEST):
2161         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2162         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2163
2164 2019-04-09  John Wilander  <wilander@apple.com>
2165
2166         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2167         https://bugs.webkit.org/show_bug.cgi?id=196558
2168         <rdar://problem/47650245>
2169
2170         Reviewed by Youenn Fablet.
2171
2172         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2173         (TestWebKitAPI::TEST):
2174             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2175
2176 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2177
2178         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2179         https://bugs.webkit.org/show_bug.cgi?id=196720
2180
2181         Reviewed by Konstantin Tokarev.
2182
2183         * TestWebKitAPI/PlatformMac.cmake:
2184
2185 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2186
2187         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2188         https://bugs.webkit.org/show_bug.cgi?id=196694
2189         <rdar://problem/48388734>
2190
2191         Rubber-stamped by Aakash Jain.
2192
2193         * Scripts/webkitpy/port/image_diff.py:
2194         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2195         * Scripts/webkitpy/port/server_process.py:
2196         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2197         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2198         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2199         * Scripts/webkitpy/port/server_process_mock.py:
2200         (MockServerProcess.has_available_stdout):
2201         * Scripts/webkitpy/port/server_process_unittest.py:
2202         (TestServerProcess.serial_test_basic):
2203
2204 2019-04-09  Jer Noble  <jer.noble@apple.com>
2205
2206         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2207         https://bugs.webkit.org/show_bug.cgi?id=196097
2208
2209         Reviewed by Eric Carlson.
2210
2211         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2212
2213         * DumpRenderTree/mac/DumpRenderTree.mm:
2214         (resetWebPreferencesToConsistentValues):
2215         * WebKitTestRunner/TestController.cpp:
2216         (WTR::TestController::resetPreferencesToConsistentValues):
2217
2218 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2219
2220         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2221         https://bugs.webkit.org/show_bug.cgi?id=196690
2222
2223         Reviewed by Michael Catanzaro.
2224
2225         * QueueStatusServer/config/queues.py:
2226         * Scripts/webkitpy/common/config/ews.json:
2227         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2228         (test_ews_name):
2229
2230 2019-04-09  Chris Dumez  <cdumez@apple.com>
2231
2232         Loads using loadHTMLString() cause flashing when process-swapping
2233         https://bugs.webkit.org/show_bug.cgi?id=196714
2234         <rdar://problem/49637354>
2235
2236         Reviewed by Antti Koivisto.
2237
2238         Add API test coverage.
2239
2240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2241
2242 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2243
2244         Unreviewed. Fix ATK accessibility tests after r244059.
2245
2246         We are failing to load the injected bundle due to undefined symbol
2247         AccessibilityUIElement::replaceTextInRange().
2248
2249         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2250         (WTR::AccessibilityUIElement::replaceTextInRange):
2251
2252 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2253
2254         AX: Support API: accessibilityReplaceRange:withText
2255         https://bugs.webkit.org/show_bug.cgi?id=196636
2256
2257         Unreviewed build fix for Windows port.
2258
2259         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2260         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2261
2262 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2263
2264         [CMake][WinCairo] Separate copied headers into different directories
2265         https://bugs.webkit.org/show_bug.cgi?id=196655
2266
2267         Reviewed by Michael Catanzaro.
2268
2269         * DumpRenderTree/CMakeLists.txt:
2270         * MiniBrowser/win/CMakeLists.txt:
2271         * TestWebKitAPI/CMakeLists.txt:
2272         * TestWebKitAPI/PlatformWin.cmake:
2273
2274 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2275
2276         Log stack-trace for run-webkit-tests when interrupted
2277         https://bugs.webkit.org/show_bug.cgi?id=176393
2278         <rdar://problem/34262310>
2279
2280         Reviewed by Lucas Forschler.
2281
2282         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2283         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2284         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2285         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2286         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2287         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2288         (main): Set handlers to log stack trace on interruption.
2289
2290 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2291
2292         AX: Support API: accessibilityReplaceRange:withText
2293         https://bugs.webkit.org/show_bug.cgi?id=196636
2294
2295         Unreviewed build fix for Windows port.
2296
2297         * DumpRenderTree/AccessibilityUIElement.cpp:
2298         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2299
2300 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2301
2302         [ews-build] Scripts using Buildbot API have CORS error
2303         https://bugs.webkit.org/show_bug.cgi?id=196709
2304
2305         Reviewed by Alexey Proskuryakov.
2306
2307         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2308
2309 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2310
2311         AX: Support API: accessibilityReplaceRange:withText
2312         https://bugs.webkit.org/show_bug.cgi?id=196636
2313
2314         Reviewed by Daniel Bates.
2315
2316         * DumpRenderTree/AccessibilityUIElement.cpp:
2317         (replaceTextInRangeCallback):
2318         (AccessibilityUIElement::replaceTextInRange):
2319         (AccessibilityUIElement::getJSClass):
2320         * DumpRenderTree/AccessibilityUIElement.h:
2321         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2322         (AccessibilityUIElement::replaceTextInRange):
2323         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2324         (AccessibilityUIElement::replaceTextInRange):
2325         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2326         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2327         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2328         (WTR::AccessibilityUIElement::replaceTextInRange):
2329         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2330         (WTR::AccessibilityUIElement::replaceTextInRange):
2331
2332 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2333
2334         [iOS] Do not allow starting selection drags when selection views are not visible
2335         https://bugs.webkit.org/show_bug.cgi?id=196686
2336         <rdar://problem/49399192>
2337
2338         Reviewed by Tim Horton.
2339
2340         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2341         also add some new API tests to cover scenarios where the web view is not first responder.
2342
2343         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2344         (TestWebKitAPI::TEST):
2345         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2346
2347         Add a switch to optionally make the web view first responder when starting the simulated drag.
2348
2349         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2350         (-[DragAndDropSimulator initWithWebView:]):
2351         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2352
2353 2019-04-08  Justin Fan  <justin_fan@apple.com>
2354
2355         [Web GPU] Fix Web GPU experimental feature on iOS
2356         https://bugs.webkit.org/show_bug.cgi?id=196632
2357
2358         Reviewed by Myles C. Maxfield.
2359
2360         Properly make Web GPU available on iOS 11+.
2361
2362         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2363
2364 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2365
2366         [ews-build] Do not upload archive when Compile Fails
2367         https://bugs.webkit.org/show_bug.cgi?id=196674
2368
2369         Reviewed by Alexey Proskuryakov.
2370
2371         * BuildSlaveSupport/ews-build/factories.py:
2372         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2373         * BuildSlaveSupport/ews-build/steps.py:
2374         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2375         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2376         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2377
2378 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2379
2380         Enable DFG on MIPS
2381         https://bugs.webkit.org/show_bug.cgi?id=196689
2382
2383         Reviewed by Žan Doberšek.
2384
2385         Since the bytecode change, we enabled the baseline JIT on mips in
2386         r240432, but DFG is still missing. With this change, all tests are
2387         passing on a ci20 board.
2388
2389         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2390
2391 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2392
2393         [Flatpak] Second run update-webkitwpe-flatpak fails
2394         https://bugs.webkit.org/show_bug.cgi?id=192702
2395
2396         Reviewed by Carlos Garcia Campos.
2397
2398         * flatpak/flatpakutils.py:
2399         (FlatpakObject.flatpak): Fix typo.
2400         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2401         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2402
2403 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2404
2405         [GTK][WPE] outlook.live.com displays old-fashioned UI
2406         https://bugs.webkit.org/show_bug.cgi?id=196642
2407
2408         Reviewed by Carlos Garcia Campos.
2409
2410         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2411         (TestWebKitAPI::TEST): New Mac platform quirk test.
2412
2413 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2414
2415         Unreviewed, rolling out r243956.
2416         https://bugs.webkit.org/show_bug.cgi?id=196688
2417
2418         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2419         by aakashjain on #webkit).
2420
2421         Reverted changeset:
2422
2423         "Clicking "Go Back" from a safe browsing warning from an
2424         iframe should navigate the WKWebView back to the previous
2425         page"
2426         https://bugs.webkit.org/show_bug.cgi?id=196665
2427         https://trac.webkit.org/changeset/243956
2428
2429 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2430
2431         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2432         https://bugs.webkit.org/show_bug.cgi?id=196669
2433
2434         Reviewed by Geoffrey Garen.
2435
2436         Added three new unit tests for WeakHashSet.
2437
2438         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2439         (WTF_WeakPtr.WeakHashSetConstObjects):
2440         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2441         (WTF_WeakPtr.WeakHashSetComputeSize):
2442
2443 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2444
2445         Hide next and previous form control buttons when WKWebView is editable
2446         https://bugs.webkit.org/show_bug.cgi?id=196672
2447         <rdar://problem/35625321>
2448
2449         Reviewed by Tim Horton.
2450
2451         Add a new API test.
2452
2453         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2454         (-[TestWKWebView lastTrailingBarButtonGroup]):
2455         (TestWebKitAPI::TEST):
2456         * TestWebKitAPI/ios/UIKitSPI.h:
2457
2458 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2459
2460         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2461         https://bugs.webkit.org/show_bug.cgi?id=196077
2462         <rdar://problem/49108202>
2463
2464         Reviewed by Chris Dumez.
2465
2466         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2467         on new web view.
2468
2469         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2470
2471 2019-04-05  Saam Barati  <sbarati@apple.com>
2472
2473         Make compare-results understand MotionMark
2474         https://bugs.webkit.org/show_bug.cgi?id=196666
2475
2476         Reviewed by Yusuke Suzuki.
2477
2478         * Scripts/compare-results:
2479         (PLT5Results):
2480         (detectMotionMark):
2481         (detectMotionMark1_1):
2482         (motionMarkResults):
2483         (motionMark1_1Results):
2484         (detectBenchmark):
2485         (biggerIsBetter):
2486         (main):
2487
2488 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2489
2490         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2491         https://bugs.webkit.org/show_bug.cgi?id=196665
2492         <rdar://45115669>
2493
2494         Reviewed by Geoff Garen.
2495
2496         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2497         (goBack):
2498         (+[SimpleLookupContext sharedLookupContext]):
2499         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2500         (TEST):
2501         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2502         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2503
2504 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2505
2506         [ews-build] Add configuration and architecture for windows builders
2507         https://bugs.webkit.org/show_bug.cgi?id=196660
2508
2509         Reviewed by Lucas Forschler.
2510
2511         * BuildSlaveSupport/ews-build/config.json:
2512
2513 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2514
2515         webkitpy: Don't run subsequent rounds if interrupted
2516         https://bugs.webkit.org/show_bug.cgi?id=196646
2517
2518         Reviewed by Aakash Jain.
2519
2520         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2521         (Manager.run): Bail out if interrupted.
2522
2523 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2524
2525         Test sessionStorage in PSON private browsing mode
2526         https://bugs.webkit.org/show_bug.cgi?id=196561
2527
2528         Reviewed by Alex Christensen.
2529
2530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2531
2532 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2533
2534         Unreviewed, rolling out r243833.
2535         https://bugs.webkit.org/show_bug.cgi?id=196645
2536
2537         This change breaks build of WPE and GTK ports (Requested by
2538         annulen on #webkit).
2539
2540         Reverted changeset:
2541
2542         "[CMake][WTF] Mirror XCode header directories"
2543         https://bugs.webkit.org/show_bug.cgi?id=191662
2544         https://trac.webkit.org/changeset/243833
2545
2546 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2547
2548         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2549         https://bugs.webkit.org/show_bug.cgi?id=196635
2550
2551         Reviewed by Antti Koivisto.
2552         
2553         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
2554         for a test to enable async frame scrolling via:
2555             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
2556         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
2557         
2558         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
2559
2560         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2561         (WTR::InjectedBundle::beginTesting):
2562         * WebKitTestRunner/TestController.cpp:
2563         (WTR::TestController::resetPreferencesToConsistentValues):
2564
2565 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2566
2567         Use a correct LC_RPATH when building with ASan
2568         https://bugs.webkit.org/show_bug.cgi?id=196576
2569
2570         Reviewed by David Kilzer.
2571
2572         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2573         so that ../Frameworks is checked. This is simpler and more reliable than updating
2574         each SPC service xcconfig.
2575
2576 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2577
2578         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2579         https://bugs.webkit.org/show_bug.cgi?id=196629
2580
2581         Reviewed by Lucas Forschler.
2582
2583         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2584
2585 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2586
2587         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2588         https://bugs.webkit.org/show_bug.cgi?id=196618
2589
2590         Reviewed by Lucas Forschler.
2591
2592         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2593         (StatusBubble): Added QUEUE_TRIGGERS.
2594         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2595         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2596         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2597         its parent(builder).
2598
2599 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2600
2601         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2602         https://bugs.webkit.org/show_bug.cgi?id=196625
2603
2604         Reviewed by Lucas Forschler.
2605
2606         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2607         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2608
2609 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2610
2611         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2612         https://bugs.webkit.org/show_bug.cgi?id=196630
2613
2614         Reviewed by Wenson Hsieh.
2615
2616         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2617
2618 2019-04-04  Youenn Fablet  <youenn@apple.com>
2619
2620         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2621         https://bugs.webkit.org/show_bug.cgi?id=196543
2622
2623         Reviewed by Alex Christensen.
2624
2625         * WebKitTestRunner/TestController.cpp:
2626         (WTR::TestController::generatePageConfiguration):
2627
2628 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2629
2630         [ews-app] Status bubble should not display skipped buildbot steps
2631         https://bugs.webkit.org/show_bug.cgi?id=196584
2632
2633         Reviewed by Lucas Forschler.
2634
2635         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2636
2637 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2638
2639         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2640         https://bugs.webkit.org/show_bug.cgi?id=196620
2641
2642         Reviewed by Lucas Forschler.
2643
2644         * BuildSlaveSupport/ews-app/ews/config.py:
2645
2646 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2647
2648         [Win] DumpRenderTreeWatchDog.py is not checked into source
2649         https://bugs.webkit.org/show_bug.cgi?id=196567
2650         <rdar://problem/49525901>
2651
2652         Reviewed by Lucas Forschler.
2653
2654         This script is used on Win EWS bots to terminate hanging DRT processes.
2655
2656         * EWSTools/dumprendertreewatchdog.py: Added.
2657
2658 2019-04-04  Chris Dumez  <cdumez@apple.com>
2659
2660         Unreviewed, roll out r243858 which made tests time out.
2661
2662         Disable new API tests on Windows instead.
2663
2664         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2665         (TestWebKitAPI::TEST):
2666
2667 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2668
2669         [ATK] Cleanup WebPageAccessibilityObjectAtk
2670         https://bugs.webkit.org/show_bug.cgi?id=196537
2671
2672         Reviewed by Michael Catanzaro.
2673
2674         Also consider files under atk directories as exceptions for GObject conventions.
2675
2676         * Scripts/webkitpy/style/checkers/cpp.py:
2677         (check_identifier_name_in_declaration):
2678
2679 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2680
2681         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2682         https://bugs.webkit.org/show_bug.cgi?id=196588
2683         <rdar://problem/49365787>
2684
2685         Unreviewed build fix for Windows port.
2686
2687         error C3861: 'kill': identifier not found
2688
2689         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2690         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2691
2692 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2693
2694         [ews-build] Cancel build and similar operations should have authentication
2695         https://bugs.webkit.org/show_bug.cgi?id=196520
2696
2697         Reviewed by Dewei Zhu.
2698
2699         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2700         environment variables.
2701
2702 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2703
2704         [ews-build] Do not trigger queues which are not in production yet
2705         https://bugs.webkit.org/show_bug.cgi?id=196581
2706
2707         Reviewed by Dewei Zhu.
2708
2709         * BuildSlaveSupport/ews-build/config.json:
2710
2711 2019-04-03  Chris Dumez  <cdumez@apple.com>
2712
2713         Unreviewed, fix typo in the name of API test added in r243848.
2714
2715         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2716         (TestWebKitAPI::TEST):
2717
2718 2019-04-03  Chris Dumez  <cdumez@apple.com>
2719
2720         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2721         https://bugs.webkit.org/show_bug.cgi?id=196588
2722         <rdar://problem/49365787>
2723
2724         Reviewed by Ryosuke Niwa.
2725
2726         Add API test coverage.
2727
2728         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2729         (TestWebKitAPI::nullJavaScriptCallback):
2730         (TestWebKitAPI::didCrashCheckFrames):
2731         (TestWebKitAPI::TEST):
2732
2733 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2734
2735         run-webkit-tests: Upload test results (new results database)
2736         https://bugs.webkit.org/show_bug.cgi?id=196577
2737         <rdar://problem/34841155>
2738
2739         Reviewed by Lucas Forschler.
2740
2741         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2742         (Manager.run): Upload results after each device shard, since the configuration will be
2743         different for each device.
2744         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2745         uploaded to a results database.
2746         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2747         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2748
2749 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2750
2751         -apple-trailing-word is needed for browser detection
2752         https://bugs.webkit.org/show_bug.cgi?id=196575
2753
2754         Unreviewed.
2755
2756         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2757
2758 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2759
2760         [CMake][WTF] Mirror XCode header directories
2761         https://bugs.webkit.org/show_bug.cgi?id=191662
2762
2763         Reviewed by Konstantin Tokarev.
2764
2765         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2766         builds.
2767
2768         * CMakeLists.txt:
2769         * DumpRenderTree/CMakeLists.txt:
2770         * DumpRenderTree/PlatformWin.cmake:
2771         * MiniBrowser/win/CMakeLists.txt:
2772         * TestWebKitAPI/CMakeLists.txt:
2773         * TestWebKitAPI/PlatformWin.cmake:
2774         * WebKitTestRunner/PlatformGTK.cmake:
2775         * WebKitTestRunner/PlatformWin.cmake:
2776
2777 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2778
2779         [ews-app] Status bubble should not display certain infrastructure status messages
2780         https://bugs.webkit.org/show_bug.cgi?id=196550
2781
2782         Reviewed by Lucas Forschler.
2783
2784         Do not display the steps which are un-needed for end-user. This information is still avaiable
2785         if the user click on the bubble and look at the Buildbot build.
2786         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2787         (StatusBubble._steps_messages):
2788         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2789
2790 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2791
2792         [ews-build] Use https for sending data to ews-app
2793         https://bugs.webkit.org/show_bug.cgi?id=196492
2794
2795         Reviewed by Lucas Forschler.
2796
2797         * BuildSlaveSupport/ews-build/events.py:
2798
2799 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2800
2801         Remove support for -apple-trailing-word
2802         https://bugs.webkit.org/show_bug.cgi?id=196525
2803
2804         Reviewed by Zalan Bujtas.
2805
2806         This CSS property is nonstandard and not used.
2807
2808         * Scripts/webkitperl/FeatureList.pm:
2809         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2810
2811 2019-04-03  Youenn Fablet  <youenn@apple.com>
2812
2813         Add a test for DOMCache on multiple browsing in case of private browsing
2814         https://bugs.webkit.org/show_bug.cgi?id=196524
2815
2816         Reviewed by Alex Christensen.
2817
2818         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2819         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2820
2821 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2822
2823         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2824         https://bugs.webkit.org/show_bug.cgi?id=196540
2825
2826         Reviewed by Aakash Jain.
2827
2828         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2829
2830 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2831
2832         Add plumbing for a compatibility mode preference in WebKit
2833         https://bugs.webkit.org/show_bug.cgi?id=196005
2834
2835         Reviewed by Tim Horton.
2836
2837         Add new API tests.
2838
2839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2840         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2841
2842 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2843
2844         [WPE][GTK] Update libsrtp dependency package for Debian
2845         https://bugs.webkit.org/show_bug.cgi?id=196528
2846
2847         Reviewed by Frédéric Wang.
2848
2849         * gtk/install-dependencies:
2850         * wpe/install-dependencies:
2851
2852 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2853
2854         [WK2] Add support for Window's beforeprint / afterprint events
2855         https://bugs.webkit.org/show_bug.cgi?id=196478
2856         <rdar://problem/49535124>
2857
2858         Unreviewed build fix for MSVC.
2859
2860         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2861
2862         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2863
2864         * WebKitTestRunner/TestController.cpp:
2865         (WTR::printFrame): Use int and float literals.
2866
2867 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2868
2869         [ews-build] Reassign bots to queues
2870
2871         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2872
2873 2019-04-02  Chris Dumez  <cdumez@apple.com>
2874
2875         [WK2] Add support for Window's beforeprint / afterprint events
2876         https://bugs.webkit.org/show_bug.cgi?id=196478
2877
2878         Reviewed by Alex Christensen.
2879
2880         Add minimal implementation for printFrame in WebKitTestRunner.
2881
2882         * WebKitTestRunner/TestController.cpp:
2883         (WTR::printFrame):
2884         (WTR::TestController::createOtherPage):
2885         (WTR::TestController::createWebViewWithOptions):
2886
2887 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2888
2889         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2890         https://bugs.webkit.org/show_bug.cgi?id=196491
2891
2892         Reviewed by Lucas Forschler.
2893
2894         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2895
2896 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2897
2898         [ews-build] Configure buildbot try credentials in environment variables
2899         https://bugs.webkit.org/show_bug.cgi?id=196501
2900
2901         Reviewed by Lucas Forschler.
2902
2903         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2904         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2905         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2906
2907 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2908
2909         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2910         https://bugs.webkit.org/show_bug.cgi?id=196496
2911         <rdar://problem/49521634>
2912
2913         Reviewed by Chris Dumez.
2914
2915         Add new API tests (see WebKit ChangeLog for more detail).
2916
2917         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2918         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2919         (TEST):
2920
2921 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2922
2923         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2924         <https://webkit.org/b/196499>
2925
2926         Reviewed by Alexey Proskuryakov.
2927
2928         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2929         ENABLE_ADDRESS_SANITIZER.
2930
2931 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2932
2933         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2934         https://bugs.webkit.org/show_bug.cgi?id=182757
2935
2936         Reviewed by Don Olmstead.
2937
2938         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2939         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2940
2941 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2942
2943         run-api-tests: Upload test results
2944         https://bugs.webkit.org/show_bug.cgi?id=196323
2945         <rdar://problem/49356714>
2946
2947         Reviewed by Lucas Forschler.
2948
2949         * Scripts/webkitpy/api_tests/manager.py:
2950         (Manager):
2951         (Manager.run): Upload results to a results database.
2952         * Scripts/webkitpy/api_tests/run_api_tests.py:
2953         (parse_args): Add upload arguments.
2954         * Scripts/webkitpy/port/base.py:
2955         (Port):
2956         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2957         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2958         with commits from any other associated repositories.
2959         * Scripts/webkitpy/port/device.py:
2960         (Device):
2961         (Device.build_version): Access build_versoin of underlying platform device.
2962         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2963         (IOSSimulatorTest):
2964         (IOSSimulatorTest.test_configuration_for_upload):
2965         * Scripts/webkitpy/port/device_port.py:
2966         (DevicePort):
2967         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2968         the same as the machine uploading results.
2969         * Scripts/webkitpy/port/mac.py:
2970         (MacPort):
2971         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2972         * Scripts/webkitpy/port/mac_unittest.py:
2973         (MacTest):
2974         (MacTest.test_configuration_for_upload):
2975         * Scripts/webkitpy/xcode/simulated_device.py:
2976         (SimulatedDeviceManager._create_device_with_runtime):
2977         (SimulatedDevice.__init__): Create simulated device with a build_version.
2978         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2979         (test_existing_simulator):
2980
2981 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2982
2983         Remove extra newline characters (Follow-up fix to r243707)
2984
2985         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2986
2987 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2988
2989         [ews-app] Use API_KEY to accept results data
2990         https://bugs.webkit.org/show_bug.cgi?id=196461
2991
2992         Reviewed by Dewei Zhu.
2993
2994         * BuildSlaveSupport/ews-app/ews/views/results.py:
2995         (Results.post): Validate EWS_API_KEY before accepting any data.
2996         * BuildSlaveSupport/ews-build/events.py:
2997         (Events.sendData): Send EWS_API_KEY if available along with event data.
2998
2999 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3000
3001         Unable to copy and paste a PDF from Notes into Mail compose body
3002         https://bugs.webkit.org/show_bug.cgi?id=196442
3003         <rdar://problem/48573098>
3004
3005         Reviewed by Tim Horton.
3006
3007         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3008         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3009         to be specified on the item providers.
3010
3011         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3012         (TestWebKitAPI::mapItemForTesting):
3013         (TestWebKitAPI::contactItemForTesting):
3014
3015 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3016
3017         Make UIWKDocumentContext rects per-character instead of per-word
3018         https://bugs.webkit.org/show_bug.cgi?id=196459
3019
3020         Reviewed by Wenson Hsieh.
3021
3022         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3023         (TEST):
3024         Adjust test results due to switching to per-character rects.
3025
3026 2019-04-01  Chris Dumez  <cdumez@apple.com>
3027
3028         UIProcess crash when a prewarmed process is terminated
3029         https://bugs.webkit.org/show_bug.cgi?id=196451
3030         <rdar://problem/49245471>
3031
3032         Reviewed by Geoffrey Garen.
3033
3034         Add API test coverage.
3035
3036         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3037         (TEST):
3038
3039 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3040
3041         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3042         https://bugs.webkit.org/show_bug.cgi?id=196449
3043
3044         Reviewed by Lucas Forschler.
3045
3046         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3047         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3048         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3049         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3050
3051 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3052
3053         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3054         https://bugs.webkit.org/show_bug.cgi?id=196444
3055
3056         Reviewed by Lucas Forschler.
3057
3058         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3059
3060 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3061
3062         Add SPI to canonicalize NSURLs with WTF::URL
3063         https://bugs.webkit.org/show_bug.cgi?id=196415
3064         <rdar://problem/44980271>
3065
3066         Reviewed by Darin Adler.
3067
3068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3069         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3070         (TestWebKitAPI::TEST):
3071
3072 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3073
3074         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3075         https://bugs.webkit.org/show_bug.cgi?id=196441
3076
3077         Reviewed by Carlos Garcia Campos.
3078
3079         Don't cache the wpe_view_backend object that might not exist yet at the
3080         time of EventSenderProxy constructor invocation, but instead retrieve
3081         that object whenever it's required for event dispatching. This should
3082         avoid crashes in this constructor now that it's invoked before any
3083         PlatformWindow has been set up (as changed in r243496).
3084
3085         * WebKitTestRunner/EventSenderProxy.h:
3086         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3087         (WTR::viewBackend):
3088         (WTR::EventSenderProxy::EventSenderProxy):
3089         (WTR::EventSenderProxy::mouseDown):
3090         (WTR::EventSenderProxy::mouseUp):
3091         (WTR::EventSenderProxy::mouseMoveTo):
3092         (WTR::EventSenderProxy::mouseScrollBy):
3093         (WTR::EventSenderProxy::keyDown):
3094         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3095
3096 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3097
3098         [Win][WebKit] MiniBrowser should support high DPI display
3099         https://bugs.webkit.org/show_bug.cgi?id=196391
3100
3101         Reviewed by Alex Christensen.
3102
3103         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3104         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3105         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3106         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3107
3108 2019-03-31  Sam Weinig  <weinig@apple.com>
3109
3110         Remove more i386 specific configurations
3111         https://bugs.webkit.org/show_bug.cgi?id=196430
3112
3113         Reviewed by Alexey Proskuryakov.
3114
3115         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3116         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3117
3118 2019-03-31  Andy Estes  <aestes@apple.com>
3119
3120         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3121         https://bugs.webkit.org/show_bug.cgi?id=196433
3122         <rdar://problem/49293305>
3123
3124         Reviewed by Tim Horton.
3125
3126         Enhanced API test coverage to include all navigation response policy decisions in both
3127         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3128
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3131         (TestWebKitAPI::TEST):
3132         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3133         (readFile):
3134         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3135         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3136         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3137         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3138         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3139         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3140         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3141         (-[QuickLookDelegate _downloadDidStart:]):
3142         (-[QuickLookDelegate _download:didReceiveResponse:]):
3143         (-[QuickLookDelegate _download:didReceiveData:]):
3144         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3145         (-[QuickLookDelegate _downloadDidFinish:]):
3146         (-[QuickLookDelegate _download:didFailWithError:]):
3147         (-[QuickLookDelegate _downloadDidCancel:]):
3148         (-[QuickLookDelegate verifyDownload]):
3149         (runTest):
3150         (runTestDecideBeforeLoading):
3151         (runTestDecideAfterLoading):
3152         (TEST):
3153         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3154         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3155         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3156         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3157         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3158         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3159         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3160         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3161         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3162         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3163         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3164         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3165         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3166         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3167
3168 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3169
3170         [CMake] add testdfg as target with build-jsc
3171         https://bugs.webkit.org/show_bug.cgi?id=196393
3172
3173         Reviewed by Saam Barati.
3174
3175         Added testdfg as one of the targets to build when
3176         using CMake.
3177
3178         * Scripts/build-jsc:
3179
3180 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3181
3182         Delete WebMetal implementation in favor of WebGPU
3183         https://bugs.webkit.org/show_bug.cgi?id=195418
3184
3185         Reviewed by Dean Jackson.
3186
3187         * DumpRenderTree/mac/DumpRenderTree.mm:
3188         (enableExperimentalFeatures):
3189         (resetWebPreferencesToConsistentValues):
3190         * Scripts/webkitperl/FeatureList.pm:
3191         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3193         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3194         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3195         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3196         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3197         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3198         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3199         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3200         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3201         (WTR::InjectedBundle::beginTesting):
3202         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3203         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3204         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3205
3206 2019-03-29  Chris Dumez  <cdumez@apple.com>
3207
3208         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3209         https://bugs.webkit.org/show_bug.cgi?id=196405
3210         <rdar://problem/49428130>
3211
3212         Reviewed by Wenson Hsieh.
3213
3214         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3215         the popover presentation methods to be no-ops. Use this in the new test added in
3216         r243523 so that we do not swizzle those methods for all tests. This is needed because
3217         those WatchOS tests rely on the popover getting presented and interactive.
3218
3219         * WebKitTestRunner/TestController.cpp:
3220         (WTR::updateTestOptionsFromTestHeader):
3221         * WebKitTestRunner/TestController.h:
3222         * WebKitTestRunner/TestOptions.h:
3223         (WTR::TestOptions::hasSameInitializationOptions const):
3224         * WebKitTestRunner/ios/TestControllerIOS.mm:
3225         (WTR::TestController::platformInitialize):
3226         (WTR::TestController::platformResetStateToConsistentValues):
3227
3228 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3229
3230         [Curl] Add Server Trust Evaluation Support.
3231         https://bugs.webkit.org/show_bug.cgi?id=191646
3232
3233         Reviewed by Fujii Hironori.
3234
3235         Implemented MiniBrowser UI for asking if user trusts the server.
3236
3237         * MiniBrowser/win/Common.cpp:
3238         (askServerTrustEvaluation):
3239         (replaceString):
3240         * MiniBrowser/win/Common.h:
3241         * MiniBrowser/win/MiniBrowserLib.rc:
3242         * MiniBrowser/win/MiniBrowserLibResource.h:
3243         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3244         (createPEMString):
3245         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3246         (WebKitBrowserWindow::canTrustServerCertificate):
3247         * MiniBrowser/win/WebKitBrowserWindow.h:
3248
3249 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3250
3251         Implement ResizeObserver.
3252         https://bugs.webkit.org/show_bug.cgi?id=157743
3253
3254         Reviewed by Simon Fraser.
3255
3256         Support resizeObserverEnabled webPreferences.
3257
3258         * DumpRenderTree/TestOptions.cpp:
3259         (TestOptions::TestOptions):
3260         * DumpRenderTree/TestOptions.h:
3261         * DumpRenderTree/mac/DumpRenderTree.mm:
3262         (setWebPreferencesForTestOptions):
3263         * DumpRenderTree/win/DumpRenderTree.cpp:
3264         (enableExperimentalFeatures):
3265         * Scripts/webkitperl/FeatureList.pm:
3266         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3267
3268 2019-03-28  John Wilander  <wilander@apple.com>
3269
3270         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3271         https://bugs.webkit.org/show_bug.cgi?id=196281
3272         <rdar://problem/48938748>
3273
3274         Reviewed by Alex Christensen.
3275
3276         This patch adds the function isStatisticsHasLocalStorage() to the
3277         TestRunner. With it, the page can query the WebsiteDataStore in the
3278         UI process to make sure that it sees LocalStorage.
3279
3280         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3281         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3282         (WTR::TestRunner::isStatisticsHasLocalStorage):
3283         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3284         * WebKitTestRunner/TestController.cpp:
3285         (WTR::TestController::isStatisticsHasLocalStorage):
3286         * WebKitTestRunner/TestController.h:
3287         * WebKitTestRunner/TestInvocation.cpp:
3288         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3289
3290 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3291
3292         API::Data::createWithoutCopying should do a null check before calling CFRelease
3293         https://bugs.webkit.org/show_bug.cgi?id=196276
3294         <rdar://problem/48059859>
3295
3296         Reviewed by Alex Christensen.
3297
3298         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3299
3300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3301         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3302         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3303         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3304         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3305         (TestWebKitAPI::TEST):
3306
3307 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3308
3309         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3310         https://bugs.webkit.org/show_bug.cgi?id=186276
3311
3312         Reviewed by Carlos Garcia Campos.
3313
3314         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3315         (webViewLoadChanged):
3316         (testWebResourceGetDataError):
3317         (testWebResourceGetDataEmpty):
3318         (beforeAll):
3319         (webViewloadChanged): Deleted.
3320
3321 2019-03-27  Andy Estes  <aestes@apple.com>
3322
3323         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3324         https://bugs.webkit.org/show_bug.cgi?id=196317
3325
3326         Reviewed by Dan Bernstein.
3327
3328         package-root copies built products into a staging directory using ditto(1), which does not
3329         follow symbolic links as it traverses a directory. Now that the files in
3330         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3331         itself, these become broken links when ditto'd into the staging directory.
3332
3333         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3334
3335         * Scripts/package-root:
3336
3337 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3338
3339         [ews-app] Update display text of Submit for ews analysis
3340         https://bugs.webkit.org/show_bug.cgi?id=196309
3341
3342         Reviewed by Dewei Zhu.
3343
3344         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3345
3346 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3347
3348         run-webkit-tests should check for leaks in WebKit processes
3349         <https://webkit.org/b/193772>
3350         <rdar://problem/46526680>
3351
3352         Reviewed by Ryosuke Niwa.
3353
3354         This works by doing the following:
3355         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3356           The list of child processes are returned one per line:
3357           process.name: pid
3358         - Run the "#LIST CHILD PROCESSES" command just before the
3359           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3360           processes on the ServerProcess object.
3361         - When the `--leaks` switch is handled, run check_for_leaks() on
3362           each child process after the main test harness.
3363
3364         * DumpRenderTree/mac/DumpRenderTree.mm:
3365         (handleControlCommand):
3366         - Use strncmp() instead of strcmp().
3367         - Add support for handling "#LIST CHILD PROCESSES" command.
3368
3369         * Scripts/webkitpy/port/base.py:
3370         (Port.check_for_leaks):
3371         * Scripts/webkitpy/port/darwin.py:
3372         (DarwinPort.check_for_leaks):
3373         - Rename redundant 'process_pid' argument to 'process_id'.
3374
3375         * Scripts/webkitpy/port/driver.py:
3376         (Driver.do_post_tests_work):
3377         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3378           longer the only command this sends to WebKitTestRunner.
3379         - If the `--leaks` switch is present, send the
3380           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3381           result using Port.set_webkit_processes().
3382         (Driver._parse_child_processes_output):
3383         - Add helper method to parse list of child process names and
3384           process IDs returned from WebKitTestRunner.
3385
3386         * Scripts/webkitpy/port/ios_device.py:
3387         (IOSDevicePort.check_for_leaks):
3388         - Rename redundant 'process_pid' argument to 'process_id'.
3389
3390         * Scripts/webkitpy/port/leakdetector.py:
3391         (LeakDetector._parse_leaks_output):
3392         - Return early if there is no leaks_output.
3393         (LeakDetector.check_for_leaks):
3394         - Rename redundant 'process_pid' argument to 'process_id'.
3395
3396         * Scripts/webkitpy/port/server_process.py:
3397         (ServerProcess.__init__):
3398         (ServerProcess.child_processes):
3399         (ServerProcess.set_child_processes):
3400         - Add instance variable to Port to store list of child process
3401           names and process IDs returned from WebKitTestRunner.
3402         (ServerProcess._start):
3403         - Clear self._child_processes.
3404         (ServerProcess.stop):
3405         - If self._child_processes is set, call
3406           self._port.check_for_leaks() for each child process.
3407
3408         * Scripts/webkitpy/port/server_process_unittest.py:
3409         (TrivialMockPort.check_for_leaks):
3410         - Rename redundant 'process_pid' argument to 'process_id'.
3411
3412         * Scripts/webkitpy/port/simulator_process.py:
3413         (SimulatorProcess.stop):
3414         - If self._child_processes is set, call
3415           self._port.check_for_leaks() for each child process.
3416
3417         * Scripts/webkitpy/port/watch_device.py:
3418         (WatchDevicePort.check_for_leaks):
3419         - Rename redundant 'process_pid' argument to 'process_id'.
3420
3421         * WebKitTestRunner/TestController.cpp:
3422         (WTR::TestController::dumpResponse):
3423         - Extract method from findAndDumpWorldLeaks() so that it may be
3424           reused by findAndDumpWebKitProcessIdentifiers().
3425         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3426         - Add method to output process name and process ID of both the
3427           WebContent and Networking processes.
3428         (WTR::TestController::findAndDumpWorldLeaks):
3429         - Fix missing newline in output when there were no abandoned
3430           documents.
3431         - Call dumpResponse() for extracted code.
3432         (WTR::TestController::handleControlCommand):
3433         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3434         - Use strncmp() instead of strcmp().
3435         - Call findAndDumpWebKitProcessIdentifiers() when
3436           "#LIST CHILD PROCESSES" command is sent.
3437         * WebKitTestRunner/TestController.h:
3438         (WTR::TestController::dumpResponse):
3439         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3440         - Declare methods.
3441
3442 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3443
3444         Unreviewed. Add GLib API test cases after r243434.
3445
3446         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3447         (testWebViewActiveURI):
3448         (serverCallback):
3449         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3450         (sendRequestCallback):
3451
3452 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3453
3454         Geolocation request not complete when watch request was started in a different web process
3455         https://bugs.webkit.org/show_bug.cgi?id=195996
3456
3457         Reviewed by Alex Christensen.
3458
3459         Add a test case.
3460
3461         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3462         (TestWebKitAPI::runJavaScriptAlert):
3463         (TestWebKitAPI::TEST):
3464
3465 2019-03-26  Keith Rollin  <krollin@apple.com>
3466
3467         Update the way generate-xcfilelists returns strings from functions
3468         https://bugs.webkit.org/show_bug.cgi?id=195975
3469         <rdar://problem/49040807>
3470
3471         Reviewed by Dean Jackson.
3472
3473         There are places where generate-xcfilelists executes assignments with
3474         statements like:
3475
3476             FOO=$(some_function)
3477
3478         where "some_function" return a string by echoing it. E.g.
3479
3480             some_function()
3481             {
3482                 echo "Hello, World"
3483             }
3484
3485         This is a common idiom, but it has a problem if "some_function" needs
3486         to call "exit" in an attempt to halt the entire script right then and
3487         there. Since "some_function" is called inside of $(), it's being
3488         executed in a sub-shell. Calling exit in that sub-shell simply exits
3489         that shell; it doesn't not exit the outer shell in which the main part
3490         of the script is still running. As such, the main script keeps
3491         executing when the intent was for the script to halt.
3492
3493         The solution to this is to use a different idiom for returning
3494         strings. The one we now is to pass in the name of the variable to
3495         receive the string result:
3496
3497             some_function()
3498             {
3499                 variable_name=$1
3500                 eval $variable_name ="Hello, World"
3501             }
3502
3503         The call site now looks like
3504
3505             some_function FOO
3506
3507         Because there's no invocation of a sub-shell, some_function can now
3508         call "exit" if it wants to, and the entire script will exit at that
3509         point.
3510
3511         * Scripts/generate-xcfilelists:
3512
3513 2019-03-26  Chris Dumez  <cdumez@apple.com>
3514
3515         Add basic layout test coverage for File Picker on iOS
3516         https://bugs.webkit.org/show_bug.cgi?id=196265
3517
3518         Reviewed by Wenson Hsieh.
3519
3520         Add layout test infrastructure to test the file picker on iOS.
3521
3522         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3523         (WTR::UIScriptController::dismissFilePicker):
3524         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3525         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3526         (WTR::UIScriptController::dismissFilePicker):
3527         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3528         * WebKitTestRunner/TestController.cpp:
3529         (WTR::TestController::createWebViewWithOptions):
3530         (WTR::updateTestOptionsFromTestHeader):
3531         * WebKitTestRunner/TestOptions.h:
3532         (WTR::TestOptions::hasSameInitializationOptions const):
3533         * WebKitTestRunner/ios/TestControllerIOS.mm:
3534         (overridePresentViewController):
3535         (WTR::TestController::platformInitialize):
3536         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3537         (WTR::UIScriptController::dismissFilePicker):
3538
3539 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3540
3541         Implement async paste method on UIWKInteractionViewProtocol
3542         https://bugs.webkit.org/show_bug.cgi?id=196267
3543         <rdar://problem/49236346>
3544
3545         Reviewed by Tim Horton.
3546
3547         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3548         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3549         are now a part of all iOS 12 internal SDKs.
3550
3551         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3552
3553         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
3554         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
3555
3556         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3557         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3558         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3559         * TestWebKitAPI/ios/UIKitSPI.h:
3560
3561 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3562
3563         [ews-build] Use PostgreSQL for ews.webkit.org database
3564         https://bugs.webkit.org/show_bug.cgi?id=196270
3565
3566         Reviewed by Lucas Forschler.
3567
3568         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3569
3570 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3571
3572         [ews] Reset simctl states on reboot
3573         https://bugs.webkit.org/show_bug.cgi?id=196260
3574
3575         Rubber-stamped by Aakash Jain.
3576
3577         * EWSTools/start-queue-mac.sh:
3578
3579 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3580
3581         [ews-build] Use PostgreSQL for ews-build database
3582         https://bugs.webkit.org/show_bug.cgi?id=196229
3583
3584         Reviewed by Lucas Forschler.
3585
3586         * BuildSlaveSupport/ews-build/master.cfg:
3587
3588 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3589
3590         [ews-build] Get master_hostname dynamically in master.cfg
3591         https://bugs.webkit.org/show_bug.cgi?id=196255
3592
3593         Reviewed by Lucas Forschler.
3594
3595         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3596         send events data in test mode.
3597
3598 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3599
3600         [ews-app] Set db_constraint to False for Foreign Keys
3601         https://bugs.webkit.org/show_bug.cgi?id=196252
3602
3603         Reviewed by Lucas Forschler.
3604
3605         * BuildSlaveSupport/ews-app/ews/models/build.py:
3606         * BuildSlaveSupport/ews-app/ews/models/step.py:
3607
3608 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3609
3610         [ews-build] is_test_mode_enabled should default to True
3611         https://bugs.webkit.org/show_bug.cgi?id=196248
3612
3613         Reviewed by Lucas Forschler.
3614
3615         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3616
3617 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3618
3619         [ews-app] Add webkitperl to ENABLED_QUEUES
3620         https://bugs.webkit.org/show_bug.cgi?id=196253
3621
3622         Reviewed by Lucas Forschler.
3623
3624         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3625
3626 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3627
3628         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3629         https://bugs.webkit.org/show_bug.cgi?id=196211
3630         rdar://problem/49110552
3631
3632         Reviewed by Tim Horton.
3633
3634         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3635         Make sure that EventSenderProxy always exists when running tests. We used to create
3636         it when resetting before the first test, which is a bit too late.
3637
3638         * WebKitTestRunner/TestController.h:
3639         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3640         (WTR::TestController::platformCreateWebView):
3641         (WTR::TestController::platformCreateOtherPage):
3642         (WTR::TestController::finishCreatingPlatformWebView):
3643         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3644         (WTR::PlatformWebView::PlatformWebView):
3645         Moved some code that made NSWindow use NSEvent during web view creation. We may
3646         need to move more if some other case us found, but this is enough for now.
3647
3648 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3649
3650         Unreviewed. Fix typo in GLib geolocation API after r243285.
3651
3652         gelocation -> geolocation.
3653
3654         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
3655         (testGeolocationManagerWatchPosition):
3656
3657 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3658
3659         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3660         https://bugs.webkit.org/show_bug.cgi?id=196213
3661
3662         Reviewed by Geoff Garen.
3663
3664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3665         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3666         (credentialWithIdentityAndKeychainPath):
3667         (-[ChallengeDelegate webView:didFinishNavigation:]):
3668         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3669         (TestWebKitAPI::TEST):
3670
3671 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3672
3673         Expected shouldn't assume its contained types are copyable
3674         https://bugs.webkit.org/show_bug.cgi?id=195986
3675
3676         Reviewed by JF Bastien.
3677
3678         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3679         (TestWebKitAPI::NonCopyable::operator== const):
3680         (TestWebKitAPI::NonCopyable::operator!= const):
3681         (TestWebKitAPI::TEST):
3682
3683 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3684
3685         Remove some now-unnecessary dynamic class lookup
3686         https://bugs.webkit.org/show_bug.cgi?id=196237
3687
3688         Reviewed by Simon Fraser.
3689
3690         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3691         (makeRequest):
3692         (TEST):
3693
3694 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3695
3696         Unreviewed, rolling out r243450.
3697
3698         AppleWin and WinCairo port builds get broken.
3699
3700         Reverted changeset:
3701
3702         "Add test for fix of #196095"
3703         https://bugs.webkit.org/show_bug.cgi?id=196097
3704         https://trac.webkit.org/changeset/243450
3705
3706 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3707
3708         Unreviewed, rolling out r243465.
3709         https://bugs.webkit.org/show_bug.cgi?id=196226
3710
3711         the test doesn't build (Requested by thorton on #webkit).
3712
3713         Reverted changeset:
3714
3715         "Do not terminate the NetworkProcess if a third party
3716         application sends a NSCredential with a SecIdentityRef"
3717         https://bugs.webkit.org/show_bug.cgi?id=196213
3718         https://trac.webkit.org/changeset/243465
3719
3720 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3721
3722         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3723         https://bugs.webkit.org/show_bug.cgi?id=196213
3724
3725         Reviewed by Geoff Garen.
3726
3727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3728         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3729         (credentialWithIdentityAndKeychainPath):
3730         (-[ChallengeDelegate webView:didFinishNavigation:]):
3731         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3732         (TestWebKitAPI::TEST):
3733
3734 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3735
3736         [ews-build] Gracefully handle missing patch_id in events
3737         https://bugs.webkit.org/show_bug.cgi?id=196216
3738
3739         Reviewed by Lucas Forschler.
3740
3741         * BuildSlaveSupport/ews-build/events.py:
3742
3743 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3744
3745         [ews-build] use lz4 compression for improving buildbot performance
3746         https://bugs.webkit.org/show_bug.cgi?id=196155
3747
3748         Reviewed by Lucas Forschler.
3749
3750         * BuildSlaveSupport/ews-build/master.cfg:
3751
3752 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3753
3754         Pull some API testing helper methods out of TestWKWebView
3755         https://bugs.webkit.org/show_bug.cgi?id=196212
3756
3757         Reviewed by Tim Horton.
3758
3759         Refactor some more API testing utility methods, so that they can be used in
3760         tests that do not use TestWKWebView.
3761
3762         * TestWebKitAPI/cocoa/TestWKWebView.h:
3763         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3764         (-[WKWebView loadTestPageNamed:]):
3765         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3766         (-[WKWebView synchronouslyLoadHTMLString:]):
3767         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3768         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3769         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3770         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3771         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3772
3773 2019-03-25  Jer Noble  <jer.noble@apple.com>
3774
3775         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3776         https://bugs.webkit.org/show_bug.cgi?id=196097
3777
3778         Reviewed by Eric Carlson.
3779
3780         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3781
3782         * DumpRenderTree/mac/DumpRenderTree.mm:
3783         (resetWebPreferencesToConsistentValues):
3784         * WebKitTestRunner/TestController.cpp:
3785         (WTR::TestController::resetPreferencesToConsistentValues):
3786
3787 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3788
3789         Pull IPadUserInterfaceSwizzler out into a separate header file
3790         https://bugs.webkit.org/show_bug.cgi?id=196193
3791
3792         Reviewed by Anders Carlsson.
3793
3794         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3795         be used in other API tests.
3796
3797         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3798         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3799         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3800         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3801         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3802         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3803         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3804
3805 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3806
3807         Remove NavigatorContentUtils in WebCore/Modules
3808         https://bugs.webkit.org/show_bug.cgi?id=196070
3809
3810         Reviewed by Alex Christensen.
3811
3812         NavigatorContentUtils was to support the custom scheme spec [1].
3813         However, in WebKit side, no port has supported the feature in
3814         WebKit layer after EFL port was removed. So there has been the
3815         only IDL implementation of the NavigatorContentUtils in WebCore.
3816         So we don't need to keep the implementation in WebCore anymore.
3817
3818         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3819
3820         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3821
3822 2019-03-24  Andy Estes  <aestes@apple.com>
3823
3824         [watchOS] Remove unused Proximity Networking code
3825         https://bugs.webkit.org/show_bug.cgi?id=196188
3826
3827         Reviewed by Tim Horton.
3828
3829         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3830         (TEST):
3831
3832 2019-03-23  Keith Miller  <keith_miller@apple.com>
3833
3834         Refactor clz/ctz and fix getLSBSet.
3835         https://bugs.webkit.org/show_bug.cgi?id=196162
3836
3837         Reviewed by Saam Barati.
3838
3839         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3840
3841         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3842         (TestWebKitAPI::TEST):
3843
3844 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3845
3846         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3847         https://bugs.webkit.org/show_bug.cgi?id=196143
3848
3849         Reviewed by Michael Catanzaro.
3850
3851         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3852         directories.
3853
3854         * Scripts/webkitpy/style/checkers/cpp.py:
3855         (check_identifier_name_in_declaration):
3856         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3857         (WebKitStyleTest.test_names):
3858
3859 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3860
3861         [Flatpak] Manifest expanding fails for qt WPE extension
3862         https://bugs.webkit.org/show_bug.cgi?id=196148
3863
3864         Reviewed by Alex Christensen.
3865
3866         * flatpak/flatpakutils.py:
3867         (expand_submodules_recurse): The last recurse manifest expand
3868         iteration might lead to a single module so take it into account
3869         and don't try to recurse further.
3870
3871 2019-03-22  Chris Dumez  <cdumez@apple.com>
3872
3873         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3874         https://bugs.webkit.org/show_bug.cgi?id=195348
3875         <rdar://problem/48622090>
3876
3877         Reviewed by Alex Christensen.
3878
3879         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3880         to NO when test.options().shouldIgnoreMetaViewport is false.
3881
3882         * WebKitTestRunner/ios/TestControllerIOS.mm:
3883         (WTR::TestController::platformConfigureViewForTest):
3884
3885 2019-03-22  Chris Dumez  <cdumez@apple.com>
3886
3887         Prewarmed processes should be usable with any website data store
3888         https://bugs.webkit.org/show_bug.cgi?id=196104
3889
3890         Reviewed by Alex Christensen.
3891
3892         Add API test coverage.
3893
3894         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3895         (runInitialWarmedProcessUsedTest):
3896         (TEST):
3897
3898 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3899
3900         Back out local changes to Alex's Subversion working directory
3901
3902         They were accidentally committed.
3903
3904         * Scripts/webkitpy/common/system/abstractexecutive.py:
3905         (AbstractExecutive.wait_newest):
3906         * Scripts/webkitpy/common/system/executive.py:
3907         (Executive.running_pids):
3908         * Scripts/webkitpy/common/system/executive_mock.py:
3909         (MockExecutive.running_pids):
3910         * Scripts/webkitpy/common/system/executive_unittest.py:
3911         (ExecutiveTest.serial_test_running_pids):
3912         * Scripts/webkitpy/port/darwin.py:
3913         (DarwinPort.check_for_leaks):
3914         * Scripts/webkitpy/port/leakdetector.py:
3915         (LeakDetector.check_for_leaks):
3916         - This was the hack attached to Bug 193772.
3917
3918         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3919         (+[WebKitTestRunnerEvent mouseLocation]):
3920         - This works around a crash on an internal build.
3921
3922 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3923
3924         Fix the build after r243354
3925         https://bugs.webkit.org/show_bug.cgi?id=196138
3926         <rdar://problem/49145951>
3927
3928         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3929         (TEST):
3930         * TestWebKitAPI/ios/UIKitSPI.h:
3931
3932 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3933
3934         Adopt UIWKDocumentContext
3935         https://bugs.webkit.org/show_bug.cgi?id=196040
3936         <rdar://problem/48642440>
3937
3938         Reviewed by Ryosuke Niwa.
3939
3940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3941         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3942         (makeRequest):
3943         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3944         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3945         (applyStyle):
3946         (TEST):
3947         Add tests for UIWKDocumentContext.
3948
3949         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3950         (TEST):
3951         (recursiveFindWKContentView): Deleted.
3952         * TestWebKitAPI/cocoa/TestWKWebView.h:
3953         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3954         (recursiveFindWKContentView):
3955         (-[TestWKWebView wkContentView]):
3956         * TestWebKitAPI/ios/UIKitSPI.h:
3957         Share the WKContentView finding code between tests.
3958
3959 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3960
3961         [iOS WK2] Turn on async overflow scrolling by default
3962         https://bugs.webkit.org/show_bug.cgi?id=196011
3963         rdar://problem/48453859
3964
3965         Reviewed by Antti Koivisto.
3966         
3967         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3968         since so many basic layout tests have different results when compositing is triggered for
3969         overflow.
3970         
3971         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3972
3973         * WebKitTestRunner/TestController.cpp:
3974         (WTR::TestController::resetPreferencesToConsistentValues):
3975
3976 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3977
3978         [ews-build] Retry API test in case of failures
3979         https://bugs.webkit.org/show_bug.cgi?id=196004
3980
3981         Reviewed by Lucas Forschler.
3982
3983         * BuildSlaveSupport/ews-build/steps.py:
3984         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3985         (CompileWebKitToT.doStepIf): Ditto.
3986         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3987         (ReRunAPITests): Re-run API tests.
3988         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3989         (RunAPITestsWithoutPatch): Run API tests without patch.
3990         (RunAPITestsWithoutPatch.doStepIf):
3991         (RunAPITestsWithoutPatch.hideStepIf):
3992         (RunAPITestsWithoutPatch.evaluateCommand):
3993         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3994         (AnalyzeAPITestsResults.start):
3995         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3996         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3997         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3998         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3999
4000 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
4001
4002         [ews-build] Update queues configurations
4003         https://bugs.webkit.org/show_bug.cgi?id=196074
4004
4005         Reviewed by Dewei Zhu.
4006
4007         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
4008         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
4009
4010 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
4011
4012         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
4013         https://bugs.webkit.org/show_bug.cgi?id=195680
4014         <rdar://problem/48903534>
4015
4016         Unreviewed infrastructure fix.
4017
4018         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4019         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
4020
4021 2019-03-21  Andy Estes  <aestes@apple.com>
4022
4023         [iOS] Apple Pay should be available in documents with no user agent scripts
4024         https://bugs.webkit.org/show_bug.cgi?id=196061
4025         <rdar://problem/48649391>
4026
4027         Reviewed by Brady Eidson.
4028
4029         Added API tests and related infrastructure.
4030
4031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4032         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
4033         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
4034         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
4035         (TestWebKitAPI::TEST):
4036         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
4037         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
4038         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
4039         * TestWebKitAPI/cocoa/TestProtocol.mm:
4040         (-[TestProtocol startLoading]):
4041         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
4042         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
4043         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
4044         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
4045
4046 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
4047
4048         REGRESSSION (r243297): webkitpy tests broken
4049         https://bugs.webkit.org/show_bug.cgi?id=196108
4050
4051         Reviewed by Aakash Jain.
4052
4053         r243297 updated contributors.json, which broke a few unit tests.
4054
4055         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4056         (IRCCommandTest.test_whois):
4057         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
4058
4059 2019-03-21  Chris Dumez  <cdumez@apple.com>
4060
4061         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
4062         https://bugs.webkit.org/show_bug.cgi?id=196041
4063         <rdar://problem/49083230>
4064
4065         Reviewed by Alex Christensen.
4066
4067         Add API test coverage.
4068
4069         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
4070         (TEST):
4071
4072 2019-03-21  Alex Christensen  <achristensen@webkit.org>
4073
4074         Add SPI to inform applications of WKContentRuleList actions
4075         https://bugs.webkit.org/show_bug.cgi?id=195965
4076         <rdar://problem/42664365>
4077
4078         Reviewed by Geoff Garen.
4079
4080         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4081         (TestWebKitAPI::allActionsForResourceLoad):
4082         (TestWebKitAPI::testRequest):
4083         (TestWebKitAPI::TEST_F):
4084         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
4085         (Notification::description):
4086         (Notification::operator== const):
4087         (toVector):
4088         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
4089         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
4090         (makeContentRuleList):
4091         (TEST):
4092         (makeWarnContentRuleList): Deleted.
4093
4094 2019-03-21  Timothy Hatcher  <timothy@apple.com>
4095
4096         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
4097         https://bugs.webkit.org/show_bug.cgi?id=196088
4098
4099         Reviewed by Brian Burg.
4100
4101         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
4102         Support checks when only one platform is specified. Also deprecate macosx() and
4103         force the use of macos() instead.
4104
4105         * Scripts/webkitpy/style/checkers/cpp.py:
4106         (check_min_versions_of_wk_api_available):
4107         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4108         (WebKitStyleTest.test_min_versions_of_wk_api_available):
4109
4110 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
4111
4112         Update status inactive committers' status to 'contributor'.
4113
4114         * Scripts/webkitpy/common/config/contributors.json:
4115
4116 2019-03-21  Xan Lopez  <xan@igalia.com>
4117
4118         [JSC][x86] Drop support for x87 floating point
4119         https://bugs.webkit.org/show_bug.cgi?id=194853
4120
4121         Reviewed by Don Olmstead.
4122
4123         Force SSE2 on x86/32bit builds.
4124
4125         * Scripts/webkitdirs.pm:
4126         (generateBuildSystemFromCMakeProject):
4127
4128 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
4129
4130         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
4131         https://bugs.webkit.org/show_bug.cgi?id=196073
4132
4133         Reviewed by Michael Catanzaro.
4134
4135         Add test cases to check functions and constructors with no arguments but receiving user data.
4136
4137         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4138         (checkUserData):
4139         (testJSCFunction):
4140         (fooCreateWithUserData):
4141         (testJSCClass):
4142
4143 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
4144
4145         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
4146
4147         Add g_assert_cmpfloat_with_epsilon macro if not defined.
4148
4149         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4150
4151 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
4152
4153         [GTK][WPE] Add API to provide geolocation information
4154         https://bugs.webkit.org/show_bug.cgi?id=195940
4155
4156         Reviewed by Michael Catanzaro.
4157
4158         Add a new test to check the new API.
4159
4160         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
4161         (testGeolocationManagerCurrentPosition):
4162         (testGeolocationManagerWatchPosition):
4163         (beforeAll):
4164         (afterAll):
4165         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4166         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
4167         (beforeAll): Ditto.
4168         * TestWebKitAPI/glib/CMakeLists.txt:
4169
4170 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
4171
4172         [GLib] Returning G_TYPE_OBJECT from a method does not work
4173         https://bugs.webkit.org/show_bug.cgi?id=195574
4174
4175         Reviewed by Michael Catanzaro.
4176
4177         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
4178
4179         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4180         (getGFile):
4181         (getParent):
4182         (createGString):
4183         (getGString):
4184         (getGStringCopyWillRaise):
4185         (getGStringCopy):
4186         (getGStringStr):
4187         (getGStringLen):
4188         (freeGString):
4189         (testJSCClass):
4190
4191 2019-03-20  Saam Barati  <sbarati@apple.com>
4192
4193         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
4194         https://bugs.webkit.org/show_bug.cgi?id=195721
4195
4196         Reviewed by Filip Pizlo.
4197
4198         * Scripts/run-javascriptcore-tests:
4199
4200 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
4201
4202         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
4203         https://bugs.webkit.org/show_bug.cgi?id=196049
4204
4205         Reviewed by Tim Horton.
4206
4207         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
4208         overflow scrolling in general, so rename it.
4209
4210         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4211
4212 2019-03-20  Daniel Bates  <dabates@apple.com>
4213
4214         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
4215         https://bugs.webkit.org/show_bug.cgi?id=196031
4216         <rdar://problem/49078172>
4217
4218         Reviewed by Tim Horton.
4219
4220         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
4221         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
4222         same code path used when the Done button is pressed to dismiss the <select> picker.
4223
4224         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
4225         (TestWebKitAPI::TEST):
4226
4227 2019-03-20  Chris Dumez  <cdumez@apple.com>
4228
4229         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
4230         https://bugs.webkit.org/show_bug.cgi?id=196029
4231         <rdar://problem/48954651>
4232
4233         Reviewed by Tim Horton.
4234
4235         Add API test coverage.
4236
4237         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4238
4239 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
4240
4241         [ews-build] Improve failure summary string for ApplyPatch step
4242         https://bugs.webkit.org/show_bug.cgi?id=195995
4243
4244         Reviewed by Alexey Proskuryakov.
4245
4246         * BuildSlaveSupport/ews-build/steps.py:
4247         (ApplyPatch.getResultSummary): Override getResultSummary.
4248
4249 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
4250
4251         AX: Implement support for new meter ARIA role
4252         https://bugs.webkit.org/show_bug.cgi?id=195966
4253
4254         Reviewed by Chris Fleizach.
4255
4256         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
4257         to AXLevelIndicator.
4258
4259         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4260
4261 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
4262
4263         [WebAuthN] Implement FIDO AppID extension
4264         https://bugs.webkit.org/show_bug.cgi?id=143491
4265         <rdar://problem/48298273>
4266
4267         Reviewed by Brent Fulgham.
4268
4269         Add a test that covers the new flag of convertToU2fSignCommand.
4270
4271         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
4272         (TestWebKitAPI::TEST):
4273         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4274         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
4275         (TestWebKitAPI::TEST):
4276
4277 2019-03-19  Keith Rollin  <krollin@apple.com>
4278
4279         Add support for more platforms to generate-xcfilelists
4280         https://bugs.webkit.org/show_bug.cgi?id=195977
4281
4282         Reviewed by Alexey Proskuryakov.
4283
4284         generate-xcfilelists incorrectly complains when involved with building
4285         WebKit for iphonesimulator:
4286
4287             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
4288             …
4289             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
4290
4291         Address this by teaching generate-xcfilelists about more platforms.
4292
4293         * Scripts/generate-xcfilelists:
4294
4295 2019-03-19  John Wilander  <wilander@apple.com>
4296
4297         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
4298         https://bugs.webkit.org/show_bug.cgi?id=195923
4299         <rdar://problem/49001272>
4300
4301         Reviewed by Alex Christensen.
4302
4303         This patch does the following to the TestRunner:
4304         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
4305         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
4306         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
4307
4308         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4310         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
4311         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4312         * WebKitTestRunner/TestController.cpp:
4313         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
4314         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
4315         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
4316         * WebKitTestRunner/TestController.h:
4317         * WebKitTestRunner/TestInvocation.cpp:
4318         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4319
4320 2019-03-19  Christopher Reid  <chris.reid@sony.com>
4321
4322         [CMake] Support more clang and gcc sanitizers
4323         https://bugs.webkit.org/show_bug.cgi?id=195956
4324
4325         Reviewed by Michael Catanzaro.
4326
4327         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
4328
4329 2019-03-19  Aakash Jain  <aakash_jain@apple.com>