new-run-webkit-websocketserver must handle TLS related arguments
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
2
3         new-run-webkit-websocketserver must handle TLS related arguments
4         https://bugs.webkit.org/show_bug.cgi?id=89079
5
6         Reviewed by Dirk Pranke.
7
8         PyWebSocket class must accept private_key, certificate, and
9         ca_certificate arguments and pass them to launching pywebsocket.
10         Also add ca_certificate handling to new-run-webkit-websocketserver.
11
12         * Scripts/new-run-webkit-websocketserver:
13         (main):
14         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
15         (PyWebSocket.__init__):
16         (PyWebSocket._prepare_config):
17
18 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
19
20         Unreviewed. Update my email.
21
22         * Scripts/webkitpy/common/config/committers.py:
23
24 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
25
26         Update pywebsocket to 0.7.6 from 0.7.4
27         https://bugs.webkit.org/show_bug.cgi?id=88975
28
29         Reviewed by Kent Tamura.
30
31         This new version of pywebsocket introduce following features.
32          - Allow handlers to send a close frame with empty body in response of
33              a client initiated closing handshake
34          - Implement perframe compression extension
35          - Support client certificate authentication
36
37         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
38         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
39         (_create_control_frame):
40         (Stream._receive_frame):
41         (Stream.send_message):
42         (Stream.receive_message):
43         (Stream._send_closing_handshake):
44         (Stream.close_connection):
45         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
46         (ExtensionParsingException):
47         (ExtensionParsingException.__init__):
48         (_parse_extension_param):
49         (_parse_extension):
50         (parse_extensions):
51         (format_extension):
52         (format_extensions):
53         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
54         (_parse_compression_method):
55         (_create_accepted_method_desc):
56         (PerFrameCompressionExtensionProcessor):
57         (PerFrameCompressionExtensionProcessor.__init__):
58         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
59         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
60         (PerFrameCompressionExtensionProcessor.get_extension_response):
61         (PerFrameCompressionExtensionProcessor.setup_stream_options):
62         (PerFrameCompressionExtensionProcessor.get_compression_processor):
63         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
64         (parse_token_list):
65         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
66         (Handshaker._parse_extensions):
67         (Handshaker._send_handshake):
68         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
69         (WebSocketServer._create_sockets):
70         (_get_logger_from_class):
71         (_configure_logging):
72         (_build_option_parser):
73         (_main.if):
74         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
75         (RepeatedXorMasker.mask):
76
77 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
78
79         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
80
81         Reviewed by Noam Rosenthal.
82
83         * qmake/mkspecs/features/features.prf:
84
85 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
86
87         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
88         https://bugs.webkit.org/show_bug.cgi?id=88399
89
90         Reviewed by Kenneth Rohde Christiansen.
91
92         Update initialization of WKPageLoaderClient.
93
94         * MiniBrowser/mac/BrowserWindowController.m:
95         (-[BrowserWindowController awakeFromNib]):
96         * WebKitTestRunner/TestController.cpp:
97         (WTR::TestController::initialize):
98
99 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
100
101         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
102         https://bugs.webkit.org/show_bug.cgi?id=84577
103
104         Reviewed by Ryosuke Niwa.
105
106         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
107         LayoutTestController.
108
109         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
110         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
111
112 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
113
114         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
115         https://bugs.webkit.org/show_bug.cgi?id=88340
116
117         Reviewed by Kenneth Rohde Christiansen.
118
119         Update initialization of WKPageLoaderClient.
120
121         * MiniBrowser/mac/BrowserWindowController.m:
122         (-[BrowserWindowController awakeFromNib]):
123         * WebKitTestRunner/TestController.cpp:
124         (WTR::TestController::initialize):
125
126 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
127
128         Unreviewed, rolling out r120268.
129         http://trac.webkit.org/changeset/120268
130         https://bugs.webkit.org/show_bug.cgi?id=89060
131
132         WebCompositor::setPerTilePaintingEnabled hits an assertion in
133         DEBUG (Requested by dominicc|work on #webkit).
134
135         * DumpRenderTree/chromium/WebPreferences.cpp:
136         (WebPreferences::applyTo):
137
138 2012-06-13  Tim Horton  <timothy_horton@apple.com>
139
140         REGRESSION (r120252): run-webkit-tests on Mac fails
141         https://bugs.webkit.org/show_bug.cgi?id=89057
142
143         Reviewed by Dan Bernstein.
144
145         get_option will happily return None (the default only kicks in if
146         the option is actually *not set*). We should instead check get_option's
147         return value and default to "x86_64" architecture ourselves.
148
149         * Scripts/webkitpy/layout_tests/port/mac.py:
150         (MacPort.__init__):
151
152 2012-06-13  Ian Vollick  <vollick@chromium.org>
153
154         [chromium] Certain settings in CCSettings could be global
155         https://bugs.webkit.org/show_bug.cgi?id=88384
156
157         Reviewed by James Robinson.
158
159         * DumpRenderTree/chromium/WebPreferences.cpp:
160         (WebPreferences::applyTo):
161
162 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
163
164         new-run-webkit-tests does not support --32-bit like ORWT did
165         https://bugs.webkit.org/show_bug.cgi?id=71634
166
167         Reviewed by Ojan Vafai.
168
169         This patch adds support for 32-bit apple mac builds, adding the
170         --32-bit flag for compatibility with ORWT and fixing the port
171         architecture() definition to actually return the correct values.
172
173         * Scripts/webkitpy/layout_tests/port/apple.py:
174         (ApplePort._generate_all_test_configurations):
175         * Scripts/webkitpy/layout_tests/port/factory.py:
176         (port_options):
177         * Scripts/webkitpy/layout_tests/port/mac.py:
178         (MacPort):
179         (MacPort.__init__):
180         (MacPort._build_driver_flags):
181         (MacPort.setup_environ_for_server):
182         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
183         (test_sample_process_throws_exception):
184         (test_32bit):
185         (test_32bit.run_script):
186         (test_64bit):
187         (test_64bit.run_script):
188         * Scripts/webkitpy/layout_tests/port/webkit.py:
189         (WebKitPort._build_driver):
190         (WebKitPort._build_driver_flags):
191         * Scripts/webkitpy/layout_tests/port/win.py:
192         (WinPort):
193
194 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
195
196         Remove webkitpy code to support legacy test_expectations.txt files
197         https://bugs.webkit.org/show_bug.cgi?id=89038
198
199         Reviewed by Dirk Pranke.
200
201         * Scripts/webkitpy/layout_tests/port/base.py:
202         (Port.path_to_test_expectations_file):
203         (Port.expectations_dict):
204         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
205         (PortTest.test_uses_test_expectations_file):
206         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
207         (WebKitPortTest.test_path_to_test_expectations_file):
208         (test_test_expectations):
209         * Scripts/webkitpy/style/checker.py:
210         (CheckerDispatcher.should_skip_without_warning):
211         (CheckerDispatcher._create_checker):
212         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
213         (TestExpectationsTestCase._expect_port_for_expectations_path):
214         * Scripts/webkitpy/tool/steps/commit.py:
215         (Commit._check_test_expectations):
216         * Scripts/webkitpy/tool/steps/commit_unittest.py:
217         (CommitTest.test_check_test_expectations):
218
219 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
220
221         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
222         https://bugs.webkit.org/show_bug.cgi?id=88948
223
224         Reviewed by Ojan Vafai.
225
226         In the final patch of this run, we remove the
227         test_expectations() and test_expectation_overrides() methods
228         from the Port class - callers must now use just
229         expectations_dict().
230
231         Note that support for the cascade in new-run-webkit-tests is
232         complete but only Chromium uses it; webkit-patch
233         rebaseline-expectations still does not support updating entries
234         in any file other than the first expectations file, however.
235
236         * Scripts/webkitpy/layout_tests/port/base.py:
237         (Port.path_to_test_expectations_file):
238         (Port.uses_test_expectations_file):
239         (Port.expectations_files):
240         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
241         (PortTest.test_additional_expectations):
242         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
243         (ChromiumPortTest.test_expectations_files):
244         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
245         (TestGoogleChromePort.test_get_google_chrome_port):
246         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
247         (test_test_expectations):
248         (test_legacy_test_expectations):
249
250 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
251
252         nrwt: implement the actual cascade of TestExpectations
253         https://bugs.webkit.org/show_bug.cgi?id=88947
254
255         Reviewed by Ojan Vafai.
256
257         This change implements the actual cascade by removing the
258         concept of 'overrides' from the TestExpectations object and
259         parsing each file separately.
260
261         There is an actual semantic change in this patch, in that
262         setting an expectation on a directory in one file will override
263         the expectations on any individual tests set in prior files. The
264         test_overrides__directory() unit test verifies this.
265
266         Otherwise, this patch mostly consists of deleting code :).
267
268         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
269         (TestExpectationsModel.__init__):
270         (TestExpectationsModel.add_expectation_line):
271         (TestExpectationsModel._add_test):
272         (TestExpectationsModel._already_seen_better_match):
273         (TestExpectations.__init__):
274         (TestExpectations._add_expectations):
275         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
276         (test_overrides__directory):
277
278 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
279
280         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
281         https://bugs.webkit.org/show_bug.cgi?id=88946
282
283         Reviewed by Ojan Vafai.
284
285         In preparation for fully supporting cascading expectations files
286         and removing the 'overrides' concept.
287
288         There should be no functional changes in this patch.
289
290         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
291         (ManagerTest.test_update_summary_with_result):
292         (ResultSummaryTest.get_result_summary):
293         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
294         (TestExpectations.__init__):
295         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
296         (parse_exp):
297         (SkippedTests.check):
298         (RemoveConfigurationsTest.test_remove):
299         (test_remove_line):
300         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
301         (LintTest.test_all_configurations.FakePort.__init__):
302         (LintTest.test_all_configurations.FakePort.expectations_dict):
303         (LintTest.test_lint_test_files__errors):
304         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
305         (test_overrides_are_included_correctly):
306
307 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
308
309         webkitpy: rework the TestExpectations style checker in preparation for the cascade
310         https://bugs.webkit.org/show_bug.cgi?id=88945
311
312         Reviewed by Ojan Vafai.
313
314         This patch changes the style checker to call the
315         TestExpectations parser directly and be oblivious as to what the
316         port's actual expectations are.
317
318         * Scripts/webkitpy/style/checkers/test_expectations.py:
319         (TestExpectationsChecker.__init__):
320         (TestExpectationsChecker.check_test_expectations):
321
322 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
323
324         nrwt: restructure the port classes to handle multiple expectations files
325         https://bugs.webkit.org/show_bug.cgi?id=88944
326
327         Reviewed by Ojan Vafai.
328
329         This patch restructures the Port classes so that each port
330         returns a list of TestExpectations files to be used (in a new, public,
331         expectations_files() method), and the base implementation rolls them
332         up into the ordered expectations_dict(), which becomes a public
333         method.
334
335         port.path_to_test_expectations_file(), port.test_expectations(),
336         and port.test_expectations_overrides() are then reimplemented as
337         wrappers around port.expectations_dict().
338         port.test_expectations() and port.test_expectations_overrides()
339         will eventually be removed when the cascade is fully completed,
340         and port.path_to_test_expectations_file() will be removed when
341         the rebaselining tool supports the cascade
342         (expectations_files() may also become private at that point).
343
344         There should be no functional changes in this patch, but a bunch
345         of custom logic gets deleted!
346
347         * Scripts/webkitpy/layout_tests/port/base.py:
348         (Port.expectations_dict):
349         (Port):
350         (Port.expectations_files):
351         (Port.test_expectations):
352         (Port.test_expectations_overrides):
353         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
354         (PortTest.test_additional_expectations):
355         (PortTest.test_uses_test_expectations_file):
356         * Scripts/webkitpy/layout_tests/port/chromium.py:
357         (ChromiumPort.all_baseline_variants):
358         (ChromiumPort.expectations_files):
359         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
360         (ChromiumPortTest.test_overrides_and_builder_names):
361         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
362         (_expectations_files):
363         (GoogleChromeLinux32Port.expectations_files):
364         (GoogleChromeLinux64Port.expectations_files):
365         (GoogleChromeMacPort.expectations_files):
366         (GoogleChromeWinPort.expectations_files):
367         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
368         (TestGoogleChromePort._verify_expectations_overrides):
369         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
370         (PortTestCase.test_expectations_ordering):
371         * Scripts/webkitpy/layout_tests/port/webkit.py:
372         (WebKitPort._skipped_file_search_paths):
373         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
374         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
375         (test_rebaseline_updates_expectations_file):
376         (test_rebaseline_does_not_include_overrides):
377         (test_rebaseline_expectations):
378         (test_overrides_are_included_correctly):
379
380 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
381
382         [WinCairo] Update URL of WinCairoRequirements.zip download.
383         https://bugs.webkit.org/show_bug.cgi?id=89009
384
385         Reviewed by Martin Robinson.
386
387         * Tools/Scripts/update-webkit-dependency: Put fallback code
388         to download a "last update" time from servers that don't properly
389         report Last-Modified in their HTTP header.
390         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
391         for the WinCairo build requirements bundle.
392
393 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
394
395         nrwt: preliminary cleanup before supporting cascading expectations files
396         https://bugs.webkit.org/show_bug.cgi?id=88942
397
398         Reviewed by Ojan Vafai.
399
400         This change just prepares the TestExpectations parser to get filenames
401         along with the expectations, and improves the warning messages so that
402         they contain the filenames along with the line numbers.
403
404         There should be no functional changes in this patch.
405
406         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
407         (TestExpectationEditorTests.make_parsed_expectation_lines):
408         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
409         (TestExpectationParser.parse):
410         (TestExpectationParser.expectation_for_skipped_test):
411         (TestExpectationParser._tokenize):
412         (TestExpectationParser._tokenize_list):
413         (TestExpectationLine):
414         (TestExpectationsModel.__init__):
415         (TestExpectationsModel._already_seen_better_match):
416         (TestExpectations.__init__):
417         (TestExpectations._shorten_filename):
418         (TestExpectations._report_warnings):
419         (TestExpectations._add_skipped_tests):
420         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
421         (TestExpectationParserTests._tokenize):
422         (TestExpectationParserTests.test_tokenize_blank):
423         (TestExpectationParserTests.test_tokenize_missing_colon):
424         (TestExpectationParserTests.test_tokenize_extra_colon):
425         (TestExpectationParserTests.test_tokenize_empty_comment):
426         (TestExpectationParserTests.test_tokenize_comment):
427         (TestExpectationParserTests.test_tokenize_missing_equal):
428         (TestExpectationParserTests.test_tokenize_extra_equal):
429         (TestExpectationParserTests.test_tokenize_valid):
430         (TestExpectationParserTests.test_tokenize_valid_with_comment):
431         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
432         (TestExpectationParserTests.test_parse_empty_string):
433         (TestExpectationSerializerTests._tokenize):
434         (TestExpectationSerializerTests.assert_round_trip):
435         (TestExpectationSerializerTests.assert_list_round_trip):
436         * Scripts/webkitpy/tool/servers/gardeningserver.py:
437         (GardeningExpectationsUpdater.update_expectations):
438
439 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
440
441         [Gtk] Enable link prefetch support in the developer builds
442         https://bugs.webkit.org/show_bug.cgi?id=89011
443
444         Reviewed by Martin Robinson.
445
446         Enable the link prefetch support for Gtk by default in developer
447         builds.
448
449         * Scripts/webkitperl/FeatureList.pm:
450
451 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
452
453         Update buildbot master in autoinstaller to match build.webkit.org
454         https://bugs.webkit.org/show_bug.cgi?id=88992
455
456         Reviewed by Adam Barth.
457
458         * Scripts/webkitpy/thirdparty/__init__.py:
459         (AutoinstallImportHook._install_buildbot):
460
461 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
462
463         Unreviewed, rolling out r120209.
464         http://trac.webkit.org/changeset/120209
465         https://bugs.webkit.org/show_bug.cgi?id=89007
466
467         Broke the WebKit2 mac build. (Requested by andersca on
468         #webkit).
469
470         * MiniBrowser/mac/BrowserWindowController.m:
471         (-[BrowserWindowController awakeFromNib]):
472         * WebKitTestRunner/TestController.cpp:
473         (WTR::TestController::initialize):
474
475 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
476
477         check-webkit-style needs to respect Qt API coding style
478         https://bugs.webkit.org/show_bug.cgi?id=88995
479
480         Reviewed by Csaba Osztrogonác.
481
482         Add -whitespace/declaration exception to Qt API files.
483
484         * Scripts/webkitpy/style/checker.py:
485
486 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
487
488         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
489         https://bugs.webkit.org/show_bug.cgi?id=88340
490
491         Reviewed by Kenneth Rohde Christiansen.
492
493         Update initialization of WKPageLoaderClient.
494
495         * MiniBrowser/mac/BrowserWindowController.m:
496         (-[BrowserWindowController awakeFromNib]):
497         * WebKitTestRunner/TestController.cpp:
498         (WTR::TestController::initialize):
499
500 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
501
502         [Qt] Handle multiple held buttons in touch mocking.
503         https://bugs.webkit.org/show_bug.cgi?id=88865
504
505         Reviewed by Kenneth Rohde Christiansen.
506
507         Add handling for multiple held mouse-buttons in the appropiate places.
508         To do this last-pos and start-pos are now also read from the last recorded
509         touch-point instead from object-global variables.
510
511         * MiniBrowser/qt/MiniBrowserApplication.cpp:
512         (MiniBrowserApplication::notify):
513         (MiniBrowserApplication::updateTouchPoint):
514         * MiniBrowser/qt/MiniBrowserApplication.h:
515         (MiniBrowserApplication):
516
517 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
518
519         [Qt] Make it possible to disable -Werror in production builds
520
521         Reviewed by Tor Arne Vestbø.
522
523         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
524         something qt5.git's qtwebkit.pri will soon do.
525
526         * qmake/mkspecs/features/unix/default_post.prf:
527
528 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
529
530         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
531         https://bugs.webkit.org/show_bug.cgi?id=85790
532
533         Reviewed by Gustavo Noronha Silva.
534
535         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
536         code in webkitdirs.pm.
537
538         * Scripts/webkitdirs.pm:
539         (jhbuildConfigurationChanged):
540         (saveJhbuildMd5):
541         (cleanJhbuild):
542         (buildAutotoolsProject):
543         (generateBuildSystemFromCMakeProject):
544
545 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
546
547         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
548         https://bugs.webkit.org/show_bug.cgi?id=88763
549
550         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
551         extension.
552
553         Reviewed by Simon Hausmann.
554
555         * qmake/config.tests/libzlib: Added.
556         * qmake/config.tests/libzlib/libzlib.cpp: Added.
557         (main):
558         * qmake/config.tests/libzlib/libzlib.pro: Added.
559         * qmake/mkspecs/features/features.prf:
560         * qmake/sync.profile:
561
562 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
563
564         [BlackBerry] Enable MEDIA_STREAM by default
565         https://bugs.webkit.org/show_bug.cgi?id=88849
566
567         Reviewed by Antonio Gomes.
568
569         * Scripts/webkitperl/FeatureList.pm:
570
571 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
572
573         Prevent stderr output from messing up detection of build path
574
575         https://bugs.webkit.org/show_bug.cgi?id=88075
576
577         Warnings such as 'perl: warning: Setting locale failed' will otherwise
578         end up as the build path when calling out to webkit-build-directory.
579
580         Reviewed by Ojan Vafai.
581
582         * Scripts/webkitpy/layout_tests/port/config.py:
583         (Config.build_directory):
584
585 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
586
587         Update the builder name for Apple Lion builders.
588
589         * Scripts/webkitpy/layout_tests/port/builders.py:
590
591 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
592
593         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
594         https://bugs.webkit.org/show_bug.cgi?id=88874
595
596         Reviewed by Simon Hausmann.
597
598         Rename main.cpp in QtTestBrowser because on Windows
599         it conflicts with main.cpp from DumpRenderTree.
600
601         * QtTestBrowser/QtTestBrowser.pro:
602         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
603         (launcherMain):
604         (LauncherApplication):
605         (LauncherApplication::urls):
606         (LauncherApplication::isRobotized):
607         (LauncherApplication::robotTimeout):
608         (LauncherApplication::robotExtraTime):
609         (LauncherApplication::applyDefaultSettings):
610         (LauncherApplication::LauncherApplication):
611         (requiresGraphicsView):
612         (LauncherApplication::handleUserOptions):
613         (main):
614
615 2012-06-12  Lucas Forschler  <lforschler@apple.com>
616
617         Wrap bot types inside ().
618         https://bugs.webkit.org/show_bug.cgi?id=88893
619         
620         Reviewed by Stephanie Lewis.
621
622         * BuildSlaveSupport/build.webkit.org-config/config.json:
623
624 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
625
626         [soup] Prevent setting or editing httpOnly cookies from JavaScript
627         https://bugs.webkit.org/show_bug.cgi?id=88760
628
629         Reviewed by Gustavo Noronha Silva.
630
631         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
632         to v2.33.2 for both GTK and EFL ports.
633
634         * efl/jhbuild.modules:
635         * gtk/jhbuild.modules:
636
637 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
638
639         [EFL] Enable SHADOW_DOM flag
640         https://bugs.webkit.org/show_bug.cgi?id=87732
641
642         Reviewed by Kentaro Hara.
643
644         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
645         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
646         SHADOW_DOM by default in DRT.
647         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
648         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
649         Chromium and Mac ports.
650         (drtViewAdd):
651         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
652         at compile time for EFL port.
653
654 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
655
656         WinLauncher should show loading errors
657         https://bugs.webkit.org/show_bug.cgi?id=80760
658
659         Reviewed by Brent Fulgham.
660
661         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
662         (WinLauncherWebHost::didFailProvisionalLoadWithError):
663         * WinLauncher/WinLauncher.h:
664         (WinLauncherWebHost::didFailProvisionalLoadWithError):
665         (WinLauncherWebHost):
666
667 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
668
669         [EFL][WK2] Add MiniBrowserEfl.
670         https://bugs.webkit.org/show_bug.cgi?id=61850
671
672         Reviewed by Chang Shu.
673
674         Implement MiniBrowser for EFL.
675
676         * CMakeLists.txt:
677         * MiniBrowser/efl/CMakeLists.txt: Added.
678         * MiniBrowser/efl/main.c: Added.
679         (_MiniBrowser):
680         (main_signal_exit):
681         (on_ecore_evas_resize):
682         (browserCreate):
683         (main):
684
685 2012-06-12  Helder Correia  <helder.correia@nokia.com>
686
687         Unreviewed. Update my email address in committers.py.
688
689         * Scripts/webkitpy/common/config/committers.py:
690
691 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
692
693         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
694         https://bugs.webkit.org/show_bug.cgi?id=84707
695
696         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
697         use_lib64 variable is preconfigured to True by jhbuild.
698
699         Reviewed by Dirk Pranke.
700
701         * efl/jhbuildrc:
702
703 2012-06-12  Dana Jansens  <danakj@chromium.org>
704
705         Add zlieber@chromium.org to contributors list
706         https://bugs.webkit.org/show_bug.cgi?id=88904
707
708         Unreviewed.
709
710         * Scripts/webkitpy/common/config/committers.py:
711
712 2012-06-12  Lucas Forschler  <lforschler@apple.com>
713
714         Rename Apple bots to a standard convention.
715         https://bugs.webkit.org/show_bug.cgi?id=88893
716         
717         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
718
719         Reviewed by Simon Fraser.
720
721         * BuildSlaveSupport/build.webkit.org-config/config.json:
722
723 2012-06-12  Mike West  <mkwst@chromium.org>
724
725         Make document.documentURI readonly from JavaScript
726         https://bugs.webkit.org/show_bug.cgi?id=65187
727
728         Reviewed by Alexey Proskuryakov.
729
730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
731         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
732         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
733         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
734         (TestWebKitAPI):
735         (TestWebKitAPI::TEST):
736
737 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
738
739         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
740         https://bugs.webkit.org/show_bug.cgi?id=88715
741
742         Reviewed by Noam Rosenthal.
743
744         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
745
746         * Scripts/webkitperl/FeatureList.pm:
747
748 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
749
750         [Qt] Fix -Werror for the buildbots
751         https://bugs.webkit.org/show_bug.cgi?id=88223
752
753         Rubber-stamped by Tor Arne Vestbø.
754
755         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
756
757         * qmake/mkspecs/features/unix/default_post.prf:
758
759 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
760
761         [REGRESSION][WTR] Build fail with werror after r120054
762         https://bugs.webkit.org/show_bug.cgi?id=88862
763
764         Reviewed by Csaba Osztrogonác.
765
766         Some static helpers become unused after counterValueForElementById
767         has moved to Internals. Let's remove them.
768
769         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
770         (WTR):
771
772 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
773
774         [Qt] Slave losts cause build break on bots
775         https://bugs.webkit.org/show_bug.cgi?id=38980
776
777         Minor fix after r59261.
778
779         Reviewed by Tor Arne Vestbø.
780
781         * Scripts/build-webkit:
782         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
783
784 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
785
786         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
787         https://bugs.webkit.org/show_bug.cgi?id=84406
788
789         Reviewed by Hajime Morita.
790
791         Move the counterValueForElementById from LayoutTestCotroller to Internals and
792         remove the old platform specific implementations as it exclusively tests WebCore functionality.
793
794         * DumpRenderTree/LayoutTestController.cpp:
795         (LayoutTestController::staticFunctions):
796         * DumpRenderTree/LayoutTestController.h:
797         (LayoutTestController):
798         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
799         * DumpRenderTree/chromium/LayoutTestController.cpp:
800         (LayoutTestController::LayoutTestController):
801         (LayoutTestController::setPOSIXLocale):
802         * DumpRenderTree/chromium/LayoutTestController.h:
803         (LayoutTestController):
804         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
805         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
806         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
807         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
808         * DumpRenderTree/qt/LayoutTestControllerQt.h:
809         (LayoutTestController):
810         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
811         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
812         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
813         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
814         (WTR):
815         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
816         (LayoutTestController):
817
818 2012-06-11  Hans Wennborg  <hans@chromium.org>
819
820         Speech JavaScript API: Make SpeechRecognitionError an Event
821         https://bugs.webkit.org/show_bug.cgi?id=88784
822
823         Reviewed by Adam Barth.
824
825         Make it possible to have MockWebSpeechRecognizer fire error events.
826
827         * DumpRenderTree/chromium/LayoutTestController.cpp:
828         (LayoutTestController::LayoutTestController):
829         (LayoutTestController::setMockSpeechRecognitionError):
830         * DumpRenderTree/chromium/LayoutTestController.h:
831         (LayoutTestController):
832         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
833         (WebKit):
834         (ErrorTask):
835         (WebKit::ErrorTask::ErrorTask):
836         (MockWebSpeechRecognizer::addMockResult):
837         (MockWebSpeechRecognizer::setError):
838         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
839         (MockWebSpeechRecognizer):
840
841 2012-06-11  Ojan Vafai  <ojan@chromium.org>
842
843         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
844         https://bugs.webkit.org/show_bug.cgi?id=88836
845
846         Reviewed by Dirk Pranke.
847
848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
850
851 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
852
853         [EFL] Remove CMakeCache.txt before building
854         https://bugs.webkit.org/show_bug.cgi?id=88717
855
856         Reviewed by Antonio Gomes.
857
858         Remove CMake cache file before every build to avoid using outdated
859         build flags when new features get enabled. This will avoid unexpected
860         failures on the bots due to outdated build flags.
861
862         * Scripts/webkitdirs.pm:
863         (generateBuildSystemFromCMakeProject):
864
865 2012-06-11  Vincent Scheib  <scheib@chromium.org>
866
867         Add new Pointer Lock spec attribute webkitPointerLockElement.
868         https://bugs.webkit.org/show_bug.cgi?id=88799
869
870         Reviewed by Dimitri Glazkov.
871
872         Part of a series of refactoring changes to update pointer lock API to
873         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
874
875         New attribute webkitPointerLockElement added. Follow up patches
876         will remove the previous isLocked attribute. Tests updated to use
877         the new attribute.
878
879         WebViewHost logic required modification to correctly repond to
880         a lock, unlock, pointerLockElement call series. Specifically,
881         unlocking must be queued after a lock command is issued always
882         as the lock state may not be set yet with a lock request in flight.
883
884         * DumpRenderTree/chromium/WebViewHost.cpp:
885         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
886         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
887
888 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
889
890         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
891         https://bugs.webkit.org/show_bug.cgi?id=88804
892
893         Reviewed by Tony Chang.
894
895         Protect box-decoration-break behind a feature flag enabled by default.
896
897         * Scripts/webkitperl/FeatureList.pm:
898         * qmake/mkspecs/features/features.pri:
899
900 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
901
902         [CMAKE][EFL] Remove duplicated executable output path
903         https://bugs.webkit.org/show_bug.cgi?id=88765
904
905         Reviewed by Daniel Bates.
906
907         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
908         need to define again because it is already defined in top-level CMake file.
909
910         * DumpRenderTree/efl/CMakeLists.txt:
911         * EWebLauncher/CMakeLists.txt:
912
913 2012-06-11  Ojan Vafai  <ojan@chromium.org>
914
915         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
916         https://bugs.webkit.org/show_bug.cgi?id=88816
917
918         Reviewed by Dirk Pranke.
919
920         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
921         Expose a way to clear AsynchronousCaches.
922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
924         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
925
926 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
927
928         nrwt exits early too frequently
929         https://bugs.webkit.org/show_bug.cgi?id=73843
930
931         Reviewed by Ryosuke Niwa.
932
933         Change the defaults for new-run-webkit-tests for both
934         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
935         to zero (i.e., we will never exit early by default).
936
937         If people want their buildbots to exit early it is their
938         responsibility to update their buildbot configs appropriately.
939
940         Note that we have tests that ensure that these flags work for
941         non-zero numbers, but we don't have tests that either test the
942         default or ensure that zero means "run all of the tests". I
943         think that's okay but can add tests if others disagree.
944
945         Also note that it looks like no changes on the build.webkit.org
946         master.cfg are necessary; all of the bots seem to be using the
947         RunWebKitTests wrapper which is already setting the flags. There
948         is a NewRunWebKitTests wrapper, but that looks to be unused; I
949         will delete that in a separate patch.
950
951         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
952         (parse_args):
953
954 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
955
956         [EFL] [DRT] Reset CacheModel before running each test
957         https://bugs.webkit.org/show_bug.cgi?id=87534
958
959         Reviewed by Gustavo Noronha Silva.
960
961         Reset cache model to default before running each test to fix some
962         flaky tests on EFL build bots. Also fix case value in setCacheModel.
963
964         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
965         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
966         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
967         (LayoutTestController::setCacheModel):
968
969 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
970
971         [GTK] Memory leaks in DRT EventSender.cpp
972         https://bugs.webkit.org/show_bug.cgi?id=88774
973
974         Reviewed by Martin Robinson.
975
976         Fix a few possible memory leaks in EventSender code.
977
978         * DumpRenderTree/gtk/EventSender.cpp:
979         (contextClickCallback): Free the event returned by gdk_event_new().
980         (mouseDownCallback): Ditto.
981         (mouseUpCallback): Ditto.
982
983 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
984
985         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
986         https://bugs.webkit.org/show_bug.cgi?id=88661
987
988         Reviewed by Dirk Pranke.
989
990         Pass string length explicitly when creating String object from
991         non-null-terminated UChar* returned by characters().
992
993         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
994         (LayoutTestController::pathToLocalResource):
995
996 2012-06-11  David Dorwin  <ddorwin@chromium.org>
997
998         [chromium] Provide access to the WebPlugin created by the helper plugin widget
999         https://bugs.webkit.org/show_bug.cgi?id=88028
1000
1001         Reviewed by Adam Barth.
1002
1003         Added isPlaceholder() to WebPlugin.
1004
1005         * DumpRenderTree/chromium/TestWebPlugin.h:
1006         (TestWebPlugin::isPlaceholder):
1007
1008 2012-06-11  Tony Chang  <tony@chromium.org>
1009
1010         rebaseline from garden-o-matic leaves N processes each time it is run
1011         https://bugs.webkit.org/show_bug.cgi?id=88586
1012
1013         Reviewed by Dirk Pranke.
1014
1015         This appears to only be a problem on python 2.7. Maybe a bug causing
1016         pools to not be garbage collected?
1017
1018         * Scripts/webkitpy/common/system/executive.py:
1019         (Executive.run_in_parallel): close() and join() the process pool.
1020         * Scripts/webkitpy/common/system/executive_unittest.py:
1021         (ExecutiveTest.test_run_in_parallel):
1022
1023 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
1024
1025         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
1026         https://bugs.webkit.org/show_bug.cgi?id=87841
1027
1028         Reviewed by Simon Hausmann.
1029
1030         * qmake/config.tests/libwebp/libwebp.cpp: Added.
1031         (main):
1032         * qmake/config.tests/libwebp/libwebp.pro: Added.
1033         * qmake/sync.profile:
1034
1035 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
1036
1037         Expose layoutTestController as testRunner
1038         https://bugs.webkit.org/show_bug.cgi?id=88210
1039
1040         Reviewed by Darin Adler.
1041
1042         * DumpRenderTree/LayoutTestController.cpp:
1043         (LayoutTestController::makeWindowObject):
1044         * DumpRenderTree/chromium/TestShell.cpp:
1045         (TestShell::bindJSObjectsToWindow):
1046         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1047         (WebCore::DumpRenderTree::initJSObjects):
1048         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1049         (WTR::LayoutTestController::makeWindowObject):
1050
1051 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
1052
1053         [Chromium] Remove JavaScriptCore dependencies from gyp
1054         https://bugs.webkit.org/show_bug.cgi?id=88510
1055
1056         Reviewed by Adam Barth.
1057
1058         Chromium doesn't support JSC any more and there doesn't seem to be
1059         a strong interest in using GYP as the common build system in other
1060         ports.
1061
1062         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1063         * Scripts/generate-project-files: Removed.
1064
1065 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
1066
1067         Add UNDO_MANAGER flag
1068         https://bugs.webkit.org/show_bug.cgi?id=87908
1069
1070         Reviewed by Tony Chang.
1071
1072         * Scripts/webkitperl/FeatureList.pm:
1073         * qmake/mkspecs/features/features.pri:
1074
1075 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1076
1077         webkit-patch land-safely should set cq? if the patch author is not in committers.py
1078         https://bugs.webkit.org/show_bug.cgi?id=88689
1079
1080         Reviewed by Dirk Pranke.
1081
1082         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
1083         in committers.py or the contributor cannot commit. If anything, the contributor can still
1084         set cq+ on thier patches manually so I don't think this will be an issue for people who
1085         don't list their Bugzille email on committers.py.
1086
1087         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1088         (Bugzilla._commit_queue_flag):
1089         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1090         (test_commit_queue_flag):
1091         (test_commit_queue_flag.assert_commit_queue_flag):
1092
1093 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
1094
1095         remove obsolete NewRunWebKitTests buildbot master factory classes
1096         https://bugs.webkit.org/show_bug.cgi?id=88693
1097
1098         Reviewed by Ryosuke Niwa.
1099
1100         I believe these aren't used any more ...
1101
1102         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1103         (RunWebKitTests.getText2):
1104         (BuildAndTestLeaksFactory):
1105
1106 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
1107
1108         [Chromium-Android] Build DumpRenderTree with Android SDK
1109         https://bugs.webkit.org/show_bug.cgi?id=88598
1110
1111         Change WebKit side of DRT related code according to some recent changes at chromium side.
1112
1113         Reviewed by Adam Barth.
1114
1115         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1116         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1117         (ChromiumAndroidPort.__init__):
1118         (ChromiumAndroidPort._path_to_driver):
1119
1120 2012-06-08  Wei James  <james.wei@intel.com>
1121
1122         Add app_abi option for DumpRenderTree_apk
1123         https://bugs.webkit.org/show_bug.cgi?id=88626
1124
1125         Reviewed by Adam Barth.
1126
1127         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1128
1129 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1130
1131         [GTK] Add API to get the library version to WebKit2 GTK+
1132         https://bugs.webkit.org/show_bug.cgi?id=88426
1133
1134         Reviewed by Martin Robinson.
1135
1136         * gtk/generate-gtkdoc:
1137         (get_webkit2_options): Add built sources to the list of files, but
1138         ignore enum types and marshallers.
1139
1140 2012-06-07  Vincent Scheib  <scheib@chromium.org>
1141
1142         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
1143         https://bugs.webkit.org/show_bug.cgi?id=88604
1144
1145         Reviewed by Kent Tamura.
1146
1147         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
1148         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
1149
1150         * DumpRenderTree/chromium/WebViewHost.cpp:
1151         (WebViewHost::requestPointerUnlock):
1152
1153 2012-06-08  Hans Wennborg  <hans@chromium.org>
1154
1155         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
1156         https://bugs.webkit.org/show_bug.cgi?id=87976
1157
1158         Reviewed by Kent Tamura.
1159
1160         Provide a mock implementation of WebSpeechRecognizer for
1161         DumpRenderTree. This will allow better testing of the API via layout
1162         tests.
1163
1164         * DumpRenderTree/DumpRenderTree.gypi:
1165         * DumpRenderTree/chromium/LayoutTestController.cpp:
1166         (LayoutTestController::LayoutTestController):
1167         (LayoutTestController::addMockSpeechRecognitionResult):
1168         * DumpRenderTree/chromium/LayoutTestController.h:
1169         (LayoutTestController):
1170         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
1171         (MockWebSpeechRecognizer::create):
1172         (MockWebSpeechRecognizer::start):
1173         (MockWebSpeechRecognizer::stop):
1174         (MockWebSpeechRecognizer::abort):
1175         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
1176         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
1177         (MockWebSpeechRecognizer::ResultTask::runIfValid):
1178         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
1179         (WebKit):
1180         (MockWebSpeechRecognizer):
1181         (MockWebSpeechRecognizer::addMockResult):
1182         (MockWebSpeechRecognizer::taskList):
1183         (ClientCallTask):
1184         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
1185         (ResultTask):
1186         (MockWebSpeechRecognizer::ResultTask::ResultTask):
1187         (NoMatchTask):
1188         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
1189         * DumpRenderTree/chromium/WebViewHost.cpp:
1190         (WebViewHost::speechRecognizer):
1191         * DumpRenderTree/chromium/WebViewHost.h:
1192         (WebViewHost):
1193         (WebViewHost::mockSpeechRecognizer):
1194
1195 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
1196
1197         check-webkit-style needs to be taught about <public/Foo.h>
1198         https://bugs.webkit.org/show_bug.cgi?id=88524
1199
1200         Reviewed by David Levin.
1201
1202         * Scripts/webkitpy/style/checkers/cpp.py:
1203         (_classify_include):
1204         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1205         (OrderOfIncludesTest.test_public_primary_header):
1206         (OrderOfIncludesTest.test_classify_include):
1207
1208 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
1209
1210         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1211         https://bugs.webkit.org/show_bug.cgi?id=67255
1212
1213         Reviewed by Dirk Pranke.
1214
1215         Implement pathToLocalResource to redirect file:///tmp URL's to
1216         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
1217         LayoutTests sub-directory of the WebKit source tree.
1218
1219         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1220         (LayoutTestController::pathToLocalResource):
1221
1222 2012-06-07  Tony Payne  <tpayne@chromium.org>
1223
1224         [chromium] Allow LayoutTests under new git workflow
1225         https://bugs.webkit.org/show_bug.cgi?id=88575
1226
1227         On Windows, chromium indirects through git.bat. Adds the same hack that
1228         is currently used for discovering svn.bat to support the new git
1229         workflow.
1230
1231         Reviewed by Dirk Pranke.
1232
1233         * Scripts/webkitpy/common/checkout/scm/git.py:
1234         (Git): Replaces all hard-coded references to 'git' with the class
1235         variable executable_name.
1236         (Git._check_git_architecture):
1237         (Git.in_working_directory):
1238         (Git.find_checkout_root):
1239         (Git.read_git_config):
1240         (Git.discard_local_commits):
1241         (Git.local_commits):
1242         (Git.working_directory_is_clean):
1243         (Git.clean_working_directory):
1244         (Git.status_command):
1245         (Git.add_list):
1246         (Git.delete_list):
1247         (Git.exists):
1248         (Git._current_branch):
1249         (Git.changed_files):
1250         (Git._changes_files_for_commit):
1251         (Git.revisions_changing_file):
1252         (Git.conflicted_files):
1253         (Git.svn_revision):
1254         (Git.create_patch):
1255         (Git._run_git_svn_find_rev):
1256         (Git.contents_at_revision):
1257         (Git.diff_for_file):
1258         (Git.show_head):
1259         (Git.committer_email_for_revision):
1260         (Git.apply_reverse_diff):
1261         (Git.revert_files):
1262         (Git.commit_with_message):
1263         (Git._commit_on_branch):
1264         (Git.svn_commit_log):
1265         (Git.last_svn_commit_log):
1266         (Git.svn_blame):
1267         (Git._branch_ref_exists):
1268         (Git.delete_branch):
1269         (Git.remote_merge_base):
1270         (Git.commit_locally_with_message):
1271         (Git.push_local_commits_to_server):
1272         (Git.commit_ids_from_commitish_arguments):
1273         (Git.commit_message_for_local_commit):
1274         (Git.files_changed_summary_for_commit):
1275         * Scripts/webkitpy/common/host.py:
1276         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
1277         that duplicates the logic in the existing 'svn.bat' hack.
1278
1279 2012-06-07  Ojan Vafai  <ojan@chromium.org>
1280
1281         Style build architectures like build versions for non-layout test failures
1282         https://bugs.webkit.org/show_bug.cgi?id=88590
1283
1284         Reviewed by Tony Chang.
1285
1286         Since we show the list of failing tests after the architecture, we want the
1287         buildtype and architecture to be grouped together visually.
1288
1289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
1290         (.effects a.failing-builder>span.architecture):
1291
1292 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
1293
1294         [Chromium] Remove header dependency of ImageDiff to WTF
1295         https://bugs.webkit.org/show_bug.cgi?id=88422
1296
1297         Reviewed by Ryosuke Niwa.
1298
1299         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1300         * DumpRenderTree/chromium/ImageDiff.cpp:
1301         (untestedCompareImages):
1302
1303 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
1304
1305         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
1306         https://bugs.webkit.org/show_bug.cgi?id=88491
1307
1308         Reviewed by Dirk Pranke.
1309
1310         DRT should enable WebAudio when WebAudio feature is enabled,
1311         so that the WebAudio feature could be tested by the Layouttest.
1312
1313         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
1314         (LayoutTestController::overridePreference):
1315
1316 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
1317
1318         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
1319         https://bugs.webkit.org/show_bug.cgi?id=88581
1320
1321         Reviewed by Ojan Vafai.
1322
1323         webkit-paptch rebaseline-expectations was ignoring what the
1324         expected results for a test were and pulling down all the result
1325         files from a bot. This could lead to us pulling down old,
1326         incorrect .txt or .png files. With this patch we will now only
1327         pull down expectations of the appropriate file types (so an
1328         IMAGE failure will only pull the png and not the txt file).
1329
1330         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1331         (has_pixel_failures):
1332         (suffixes_for_expectations):
1333         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1334         (FunctionsTest.test_suffixes_for_expectations):
1335         * Scripts/webkitpy/tool/commands/rebaseline.py:
1336         (AbstractRebaseliningCommand.__init__):
1337         (RebaselineExpectations._is_supported_port):
1338         (RebaselineExpectations._update_expectations_file):
1339         (RebaselineExpectations._tests_to_rebaseline):
1340         (RebaselineExpectations._rebaseline_port):
1341         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1342         (test_overrides_are_included_correctly):
1343
1344 2012-06-07  Ojan Vafai  <ojan@chromium.org>
1345
1346         Fix recent null pointer error regression in the flakiness dashboard
1347         https://bugs.webkit.org/show_bug.cgi?id=88573
1348
1349         Reviewed by Dirk Pranke.
1350
1351         * TestResultServer/static-dashboards/builders.js:
1352         (requestBuilderList):
1353         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1354
1355 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
1356
1357         Add Konrad Piascik to committers.py
1358         https://bugs.webkit.org/show_bug.cgi?id=88560
1359
1360         Unreviewed.
1361
1362         * Scripts/webkitpy/common/config/committers.py:
1363
1364 2012-06-07  Tony Chang  <tony@chromium.org>
1365
1366         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
1367         https://bugs.webkit.org/show_bug.cgi?id=77368
1368
1369         Reviewed by Ojan Vafai.
1370
1371         It doesn't look like we ever get a rect with width or height of 0.
1372         I ran css1, css2.1, fast/forms, and tables without any crashes.
1373
1374         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1375         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
1376
1377 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
1378
1379         run-webkit-tests --lint-test-files gives an error when run on linux
1380         https://bugs.webkit.org/show_bug.cgi?id=88551
1381
1382         Reviewed by Ojan Vafai.
1383
1384         We weren't mapping the expectations properly for the
1385         google-chrome ports.
1386
1387         * Scripts/webkitpy/layout_tests/port/base.py:
1388         (Port.path_to_test_expectations_file):
1389         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1390         (TestGoogleChromePort.test_path_to_expectations):
1391
1392 2012-06-07  Daniel Erat  <derat@chromium.org>
1393
1394         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
1395         https://bugs.webkit.org/show_bug.cgi?id=88263
1396
1397         Reviewed by Tony Chang.
1398
1399         * DumpRenderTree/chromium/LayoutTestController.cpp:
1400         (LayoutTestController::LayoutTestController):
1401         (LayoutTestController::reset):
1402         (LayoutTestController::setTextSubpixelPositioning):
1403         * DumpRenderTree/chromium/LayoutTestController.h:
1404         (LayoutTestController):
1405         * DumpRenderTree/chromium/fonts.conf:
1406
1407 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
1408
1409         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
1410         https://bugs.webkit.org/show_bug.cgi?id=88060
1411
1412         Reviewed by Martin Robinson.
1413
1414         Spin the main loop before acquiring the pixel content. This ensures things
1415         like late size allocations are finished before calling gtk_widget_draw,
1416         avoiding assertions and subsequent empty pixel results.
1417
1418         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1419         (createBitmapContextFromWebView):
1420
1421 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1422
1423         [Qt] Improve the visual of the viewport info box
1424         https://bugs.webkit.org/show_bug.cgi?id=88410
1425
1426         Reviewed by Tor Arne Vestbø.
1427
1428         Improve the visual and make it possible to see the content more easy.
1429
1430         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1431
1432 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
1433
1434         [EFL][WK2] Compile webkit1 and webkit2 by default.
1435         https://bugs.webkit.org/show_bug.cgi?id=85041
1436
1437         Reviewed by Chang Shu.
1438
1439         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
1440         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
1441
1442         * Scripts/build-webkit:
1443
1444 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1445
1446         Unreviewed, rolling out r119662.
1447         http://trac.webkit.org/changeset/119662
1448         https://bugs.webkit.org/show_bug.cgi?id=88487
1449
1450         Broke builds (Requested by rniwa on #webkit).
1451
1452         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1453         * DumpRenderTree/chromium/ImageDiff.cpp:
1454         (untestedCompareImages):
1455
1456 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
1457
1458         [Chromium] Remove header dependency of ImageDiff to WTF
1459         https://bugs.webkit.org/show_bug.cgi?id=88422
1460
1461         Reviewed by Adam Barth.
1462
1463         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1464         * DumpRenderTree/chromium/ImageDiff.cpp:
1465         (untestedCompareImages):
1466
1467 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
1468
1469         [WebKit] DeviceOrientation cleanup
1470         https://bugs.webkit.org/show_bug.cgi?id=88406
1471
1472         Reviewed by Kent Tamura.
1473
1474         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
1475
1476         * DumpRenderTree/chromium/LayoutTestController.cpp:
1477         (LayoutTestController::setMockDeviceOrientation):
1478
1479 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1480
1481         webkitpy: add support for an ordered dict of test expectations
1482         https://bugs.webkit.org/show_bug.cgi?id=87802
1483
1484         Reviewed by Ojan Vafai.
1485
1486         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
1487         support a cascaded list of test expectations files. An easy way
1488         to think of this is as an ordered dictionary of name -> contents
1489         for files, where the name is usually a path on disk (I say
1490         usually because we want to support other kinds of expectations
1491         like the compile-time skips for unsupported features in
1492         webkit.py, and we want to continue to support "in-memory" test
1493         expectations that don't require a filesystem).
1494
1495         Conveniently there is an OrderedDict implementation in Python
1496         2.7+ and it is available as a backport, so the first step in
1497         adding this support is to use that implementation. Subsequent
1498         patches will update the test_expectations.py module (and other
1499         callers) to access the dict directly.
1500
1501         This patch just changes the base internal implementation and
1502         provides wrappers for compatibility. The derived ports
1503         (WebKitPort, TestPort, etc.) still need to be updated.
1504
1505         * Scripts/webkitpy/layout_tests/port/base.py:
1506         (Port._expectations_dict):
1507         (Port.test_expectations):
1508         (Port):
1509         (Port._expectations_overrides_dict):
1510         (Port.test_expectations_overrides):
1511         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1512         (PortTestCase.test_expectations_ordering):
1513         (PortTestCase):
1514         (PortTestCase.test_expectations_overrides_ordering):
1515         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
1516         (OrderedDict):
1517         (OrderedDict.__init__):
1518         (OrderedDict.clear):
1519         (OrderedDict.__setitem__):
1520         (OrderedDict.__delitem__):
1521         (OrderedDict.__iter__):
1522         (OrderedDict.__reversed__):
1523         (OrderedDict.popitem):
1524         (OrderedDict.__reduce__):
1525         (OrderedDict.__repr__):
1526         (OrderedDict.copy):
1527         (OrderedDict.fromkeys):
1528
1529 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
1530
1531         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
1532
1533         * gtk/run-api-tests:
1534         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
1535
1536 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1537
1538         nrwt should look in 'out' for binaries on chromium win to support ninja
1539         https://bugs.webkit.org/show_bug.cgi?id=88273
1540
1541         Reviewed by Tony Chang.
1542
1543         This patch standardizes the search algorithm the chromium ports
1544         use to figure out which driver to run. We will look in a
1545         chromium location before a webkit location (e.g., in
1546         Source/WebKit/chromium/out before out/) and we will look in the
1547         "legacy" directory (xcodebuild) before the directory ninja uses
1548         (out).
1549
1550         Unfortunately due to the way the test code is set up testing the
1551         properly requires some duplication of test code. I will fix that
1552         in a followup patch.
1553
1554         * Scripts/webkitpy/layout_tests/port/chromium.py:
1555         (ChromiumPort):
1556         (ChromiumPort._static_build_path):
1557         (ChromiumPort._build_path):
1558         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1559         (ChromiumLinuxPort):
1560         (ChromiumLinuxPort._determine_driver_path_statically):
1561         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1562         (ChromiumLinuxPortTest.test_build_path):
1563         (ChromiumLinuxPortTest):
1564         (ChromiumLinuxPortTest.test_driver_name_option):
1565         (ChromiumLinuxPortTest.path_to_image_diff):
1566         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1567         (ChromiumMacPort):
1568         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1569         (ChromiumMacPortTest.test_build_path):
1570         (ChromiumMacPortTest):
1571         (ChromiumMacPortTest.test_driver_name_option):
1572         (ChromiumMacPortTest.path_to_image_diff):
1573         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1574         (ChromiumPortTest.test_overrides_and_builder_names):
1575         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1576         (ChromiumWinPort):
1577         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1578         (ChromiumWinTest.test_build_path):
1579         (ChromiumWinTest.test_operating_system):
1580         (ChromiumWinTest):
1581         (ChromiumWinTest.test_driver_name_option):
1582         (ChromiumWinPortTest.path_to_image_diff):
1583         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1584         (PortTestCase.assert_build_path):
1585
1586 2012-06-06  Jessie Berlin  <jberlin@apple.com>
1587
1588         Remove very red Windows WebKit2 testers
1589         https://bugs.webkit.org/show_bug.cgi?id=88452
1590
1591         Reviewed by Steve Falkenburg.
1592
1593         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
1594         need to focus on getting the WK1 testers green.
1595
1596         * BuildSlaveSupport/build.webkit.org-config/config.json:
1597
1598 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1599
1600         get rebaselining tools to kinda work with the skia overrides file
1601         https://bugs.webkit.org/show_bug.cgi?id=88456
1602
1603         Reviewed by Ryosuke Niwa.
1604
1605         Update rebaseline-expectations so that we read in the overrides
1606         when looking for tests to rebaseline, but don't read in the
1607         overrides when we are writing the expectations file back out.
1608         This prevents the overrides from getting written into the main
1609         file. This is kind of a hack but will have to do until we
1610         support multiple expectations files properly.
1611
1612         * Scripts/webkitpy/tool/commands/rebaseline.py:
1613         (RebaselineExpectations._expectations):
1614         (RebaselineExpectations._update_expectations_file):
1615         (RebaselineExpectations._tests_to_rebaseline):
1616         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1617         (test_overrides_are_included_correctly):
1618
1619 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1620
1621         webkitpy: two manager_worker_broker_unittest tests are broken
1622         https://bugs.webkit.org/show_bug.cgi?id=88445
1623
1624         Reviewed by Ojan Vafai.
1625
1626         These tests were never updated when we removed the
1627         --worker-model argument, and we were passing 'inline' instead of
1628         1 (for the number of workers) :(. As a result we were creating
1629         multiprocessing queues unnecessarily and that was failing on cygwin.
1630
1631         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1632         (InterfaceTest.test_managerconnection_is_abstract):
1633         (InterfaceTest.test_workerconnection_is_abstract):
1634
1635 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
1636
1637         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
1638         https://bugs.webkit.org/show_bug.cgi?id=87406
1639
1640         Reviewed by Dirk Pranke.
1641
1642         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1643         (TestExpectations.__init__):
1644         * Scripts/webkitpy/tool/commands/rebaseline.py:
1645         (RebaselineTest._update_expectations_file):
1646         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1647         (test_rebaseline_does_not_include_overrides):
1648
1649 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1650
1651         webkitpy: perf tests unit tests fail on chromium win
1652         https://bugs.webkit.org/show_bug.cgi?id=88279
1653
1654         Reviewed by Ryosuke Niwa.
1655
1656         I'm seeing weird failures running the unit tests in my win32
1657         checkout, and we don't really expect webpagereplay to work on
1658         win32 anyway, so I'm skipping the import of that module for now
1659         and adding a warning.
1660
1661         * Scripts/run-perf-tests:
1662         * Scripts/webkitpy/performance_tests/perftest.py:
1663
1664 2012-06-06  Yong Li <yoli@rim.com>
1665
1666         Unreviewed. Update my email address in committers.py.
1667
1668         * Scripts/webkitpy/common/config/committers.py:
1669
1670 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
1671
1672         Add Robert Kroeger  to commiters.py
1673         https://bugs.webkit.org/show_bug.cgi?id=88415
1674
1675         Unreviewed.
1676
1677         * Scripts/webkitpy/common/config/committers.py:
1678
1679 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1680
1681         [EFL][DRT] http/tests/globalhistory testcases do not pass
1682         https://bugs.webkit.org/show_bug.cgi?id=82579
1683
1684         Reviewed by Csaba Osztrogonác.
1685
1686         DRT has provided callbacks for ewk_view "global history delegate" signals.
1687
1688         * DumpRenderTree/efl/DumpRenderTree.cpp:
1689         (isGlobalHistoryTest): Aux function to ident global history testcase.
1690         (createLayoutTestController):
1691         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1692         (DumpRenderTreeChrome::createView):
1693         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
1694         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
1695         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
1696         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
1697         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
1698         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1699         (DumpRenderTreeChrome):
1700
1701 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
1702
1703         [Qt] run-qtwebkit-tests hangs with -j1
1704         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
1705         This could happen due to an uncancelled timer after results were returned. This timer was
1706         started only if --timeout was set.
1707         https://bugs.webkit.org/show_bug.cgi?id=85475
1708
1709         Reviewed by Csaba Osztrogonác.
1710
1711         * Scripts/run-qtwebkit-tests:
1712         (run_test):
1713
1714 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
1715
1716         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
1717         https://bugs.webkit.org/show_bug.cgi?id=88327
1718
1719         Reviewed by Kenneth Rohde Christiansen.
1720
1721         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
1722         * MiniBrowser/qt/icons/contents_width.png: Added.
1723         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
1724         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
1725
1726 2012-06-05  Jon Lee  <jonlee@apple.com>
1727
1728         Buildbot fix.
1729
1730         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
1731         in the function. Store in a local variable.
1732         (loadBuilderConfig):
1733
1734 2012-06-05  Jon Lee  <jonlee@apple.com>
1735
1736         Buildbot fix.
1737
1738         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1739         (loadBuilderConfig):
1740
1741 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1742
1743         webkitpy: clean up win-specific path handling and tests
1744         https://bugs.webkit.org/show_bug.cgi?id=88281
1745
1746         Reviewed by Adam Barth.
1747
1748         There was a bunch of inconsistent logic for handling path
1749         conversions for win32 and cygwin paths due to us sometimes
1750         looking at sys.platform and sometimes using mock hosts. This
1751         patch cleans everything up so that we are required to pass
1752         PlatformInfo objects to the path module and stop trying to do
1753         different things when running on cygwin or win32 hosts (except
1754         in the path_unittest module itself).
1755
1756         This may slightly reduce test coverage for the win32 code paths
1757         but will be a lot easier to follow and maintain.
1758
1759         * Scripts/webkitpy/common/system/path.py:
1760         (abspath_to_uri):
1761         (_convert_path):
1762         * Scripts/webkitpy/common/system/path_unittest.py:
1763         (AbspathTest.platforminfo):
1764         (AbspathTest.test_abspath_to_uri_cygwin):
1765         (AbspathTest.test_abspath_to_uri_unixy):
1766         (AbspathTest.test_abspath_to_uri_win):
1767         (AbspathTest.test_abspath_to_uri_escaping_unixy):
1768         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
1769         (AbspathTest.test_stop_cygpath_subprocess):
1770         * Scripts/webkitpy/common/system/platforminfo.py:
1771         (PlatformInfo.__init__):
1772         (PlatformInfo.is_cygwin):
1773         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1774         (MockPlatformInfo.is_cygwin):
1775         * Scripts/webkitpy/layout_tests/port/base.py:
1776         (Port.to.show_results_html_file):
1777         * Scripts/webkitpy/layout_tests/port/driver.py:
1778         (Driver.test_to_uri):
1779         (Driver.uri_to_test):
1780         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1781         (DriverTest.test_test_to_uri):
1782         (DriverTest.test_uri_to_test):
1783         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1784         (MockDRTPortTest.make_port):
1785         (MockDRTTest.input_line):
1786         (MockChromiumDRTTest.test_pixeltest__fails):
1787         * Scripts/webkitpy/layout_tests/port/test.py:
1788         * Scripts/webkitpy/layout_tests/port/win.py:
1789         (WinPort.show_results_html_file):
1790         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1791         (MainTest.test_unexpected_failures):
1792         (MainTest.test_results_directory_absolute):
1793         (MainTest.test_results_directory_default):
1794         (MainTest.test_results_directory_relative):
1795
1796 2012-06-05  Jon Lee  <jonlee@apple.com>
1797
1798         Workaround buildbot bug when merging build requests.
1799         https://bugs.webkit.org/show_bug.cgi?id=88158
1800
1801         Reviewed by Mark Rowe.
1802
1803         For expediency, we still want testers to pick the latest build to test, but to ensure
1804         that the builders are reporting the correct revision number, we should let the building bots
1805         run as they normally would. That is, the builder picks the oldest revision, and merges
1806         subsequent requests. Because merged requests get appended to the list of changes for a given
1807         build, the last change in that list is also the latest change. When we used pickLatestBuild
1808         for the builders, this was not the case (it would always report the penultimate change).
1809
1810         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
1811
1812         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
1813         for all Apple builders.
1814         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
1815         the latest build to run.
1816         (loadBuilderConfig):
1817
1818 2012-06-05  Jessie Berlin  <jberlin@apple.com>
1819
1820         [Win] DumpRenderTree should call resetInternalsObject
1821         https://bugs.webkit.org/show_bug.cgi?id=88346
1822
1823         Reviewed by Simon Fraser.
1824
1825         Invoke it on Windows in the same place it is invoked on Mac.
1826
1827         * DumpRenderTree/win/DumpRenderTree.cpp:
1828         (resetWebViewToConsistentStateBeforeTesting):
1829
1830 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1831
1832         [GTK] Fix two more memory leaks in DRT
1833         https://bugs.webkit.org/show_bug.cgi?id=88255
1834
1835         Reviewed by Martin Robinson.
1836
1837         Fixed memory leaks in GTK's DRT code.
1838
1839         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1840         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
1841         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
1842         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1843         (createBitmapContextFromWebView): Free the cairo surface.
1844
1845 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1846
1847         [Qt] Building when a top directory is named Source
1848         https://bugs.webkit.org/show_bug.cgi?id=77727
1849
1850         Reviewed by Tor Arne Vestbø.
1851
1852         Change regex to only replace the last instance of OUT_PWD.
1853
1854         * qmake/mkspecs/features/default_pre.prf:
1855
1856 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
1857
1858         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
1859         https://bugs.webkit.org/show_bug.cgi?id=73176
1860
1861         Reviewed by Adam Barth.
1862
1863         Two more APIs are added in Custom Scheme Handler specification.
1864         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
1865         One is 'isProtocolHandlerRegistered' to query whether the specific URL
1866         is registered or not.
1867         The other is 'unregisterProtocolHandler' to remove the registered URL.
1868
1869         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
1870
1871 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
1872
1873         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
1874         https://bugs.webkit.org/show_bug.cgi?id=83879
1875
1876         Reviewed by Carlos Garcia Campos.
1877
1878         Make minibrowser connect to the new 'permission requests' signal
1879         to allow users handle the Geolocation permission requests.
1880
1881         * MiniBrowser/gtk/BrowserWindow.c:
1882         (geolocationRequestDialogCallback): Callback for the dialog asking
1883         the user for allowing or not geolocation permission requests.
1884         (webViewDecidePermissionRequest): Launch a dialog to ask the user
1885         whether to allow or deny geolocation permission requests.
1886         (browserWindowConstructed): Connect to 'permission-request' signal.
1887
1888 2012-06-04  Chase Phillips  <cmp@google.com>
1889
1890         Make a builder group support+expect multiple loads.
1891         https://bugs.webkit.org/show_bug.cgi?id=88260
1892
1893         Change BuilderGroup to allow expecting multiple
1894         loads.  This allows merging results for a given set
1895         of builders into one group.
1896
1897         Add a test that verifies that the group count
1898         increments correctly based on successful and failed
1899         list loads.
1900
1901         Reviewed by Ojan Vafai.
1902
1903         * TestResultServer/static-dashboards/builders.js:
1904         (BuilderGroup):
1905         (BuilderGroup.prototype.setbuilder):
1906         (BuilderGroup.prototype.append):
1907         (BuilderGroup.prototype.loaded):
1908         (requestBuilderList.xhr.onload):
1909         (requestBuilderList.xhr.onerror):
1910         (onErrorLoadingBuilderList):
1911         (loadBuildersList):
1912         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1913         (test):
1914         * TestResultServer/static-dashboards/run-unittests.html:
1915
1916 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
1917
1918         Python test fix attempt for Chromium Windows.
1919
1920         * Scripts/webkitpy/layout_tests/port/driver.py:
1921         (Driver.uri_to_test):
1922
1923 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
1924
1925         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
1926         https://bugs.webkit.org/show_bug.cgi?id=88243
1927
1928         Reviewed by Adam Barth.
1929
1930         * qmake/mkspecs/features/features.prf:
1931
1932 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1933
1934         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
1935         https://bugs.webkit.org/show_bug.cgi?id=88280
1936
1937         Unreviewed, build fix.
1938
1939         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1940         (TestServerProcess.test_basic):
1941
1942 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1943
1944         test-webkitpy is hanging under cygwin
1945         https://bugs.webkit.org/show_bug.cgi?id=88269
1946
1947         Reviewed by Ryosuke Niwa.
1948
1949         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
1950         so we need to skip any tests that use it.
1951
1952         * Scripts/webkitpy/common/system/executive.py:
1953         (Executive.run_in_parallel):
1954         * Scripts/webkitpy/common/system/executive_unittest.py:
1955         (ExecutiveTest.test_run_in_parallel):
1956
1957 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1958
1959         test-webkitpy is failing on win32 after r115054
1960         https://bugs.webkit.org/show_bug.cgi?id=88264
1961
1962         Reviewed by Ryosuke Niwa.
1963
1964         The failing http_server test was improperly suppressed (the
1965         tuple was missing a comma, and so wasn't a tuple at all, just a
1966         string) and so we were skipping *all* tests on win32. The right
1967         way to skip a single test is to disable it inside the test
1968         itself.
1969
1970         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1971         (TestHttpServer.test_start_cmd):
1972         * Scripts/webkitpy/test/test_finder.py:
1973         (TestFinder._default_names):
1974         * Scripts/webkitpy/test/main.py:
1975         (Tester.run): Add error message if we don't find any tests to run.
1976         * Scripts/webkitpy/test/main_unittest.py:
1977             
1978
1979 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1980
1981         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
1982         https://bugs.webkit.org/show_bug.cgi?id=88215
1983
1984         Reviewed by Martin Robinson.
1985
1986         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
1987         for newly allocated strings.
1988
1989         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1990         (attributeSetToString):
1991         (AccessibilityUIElement::allAttributes):
1992
1993 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1994
1995         [GTK] Memory leaks in DumpRenderTree.cpp
1996         https://bugs.webkit.org/show_bug.cgi?id=88213
1997
1998         Reviewed by Martin Robinson.
1999
2000         Fixed memory leaks in DumpRenderTree.
2001
2002         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2003         (appendString): Accepts const gchar* as the second argument.
2004         (dumpFramesAsText): Free the string returned by g_strdup_printf().
2005         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
2006
2007 2012-06-04  David Dorwin  <ddorwin@chromium.org>
2008
2009         Enable Chromium media player to instantiate a plugin
2010         https://bugs.webkit.org/show_bug.cgi?id=87399
2011
2012         Reviewed by Kent Tamura.
2013
2014         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
2015
2016         * DumpRenderTree/chromium/WebViewHost.cpp:
2017         (WebViewHost::createPopupMenu):
2018
2019 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
2020
2021         [GTK][WK2] Implement geolocation provider for the GTK port
2022         https://bugs.webkit.org/show_bug.cgi?id=83877
2023
2024         Reviewed by Carlos Garcia Campos.
2025
2026         * gtk/generate-gtkdoc:
2027         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
2028
2029 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2030
2031         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
2032         https://bugs.webkit.org/show_bug.cgi?id=87668
2033
2034         Reviewed by Ryosuke Niwa.
2035
2036         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
2037         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
2038         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
2039
2040         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2041         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2042
2043 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
2044
2045         [EFL] Refactor ewk_view_context_paint code.
2046         https://bugs.webkit.org/show_bug.cgi?id=85588
2047
2048         Reviewed by Hajime Morita.
2049
2050         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
2051
2052 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
2053
2054         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
2055         https://bugs.webkit.org/show_bug.cgi?id=87869
2056
2057         Reviewed by Andreas Kling.
2058
2059         Replace %lld by PRId64 macro to print an int64_t value and silent a
2060         compilation warning on 64-Bit.
2061
2062         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2063         (onExceededApplicationCacheQuota):
2064
2065 2012-06-03  Varun Jain  <varunjain@google.com>
2066
2067         [chromium] Add new gesture type (two finger tap) that triggers context menu.
2068         https://bugs.webkit.org/show_bug.cgi?id=88173
2069
2070         Reviewed by Adam Barth.
2071
2072         * DumpRenderTree/chromium/EventSender.cpp:
2073         (EventSender::EventSender):
2074         (EventSender::gestureTwoFingerTap):
2075         (EventSender::gestureEvent):
2076         * DumpRenderTree/chromium/EventSender.h:
2077         (EventSender):
2078
2079 2012-06-02  Zeno Albisser  <zeno@webkit.org>
2080
2081         Fix and enable WebGL for WebKit2 on Qt.
2082         https://bugs.webkit.org/show_bug.cgi?id=86214
2083
2084         Enable WebGL by default for Qt MiniBrowser.
2085
2086         Reviewed by Noam Rosenthal.
2087
2088         * MiniBrowser/qt/qml/BrowserWindow.qml:
2089
2090 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
2091
2092         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
2093         https://bugs.webkit.org/show_bug.cgi?id=88164
2094
2095         Reviewed by Kentaro Hara.
2096
2097         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
2098         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
2099
2100         * Scripts/VCSUtils.pm:
2101         (adjustPathForRecentRenamings):
2102         (fixChangeLogPatch):
2103
2104 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
2105
2106         Rename test_expectations.txt to TestExpectations
2107         https://bugs.webkit.org/show_bug.cgi?id=86690
2108
2109         Reviewed by Dirk Pranke.
2110
2111         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
2112         We can the code to read test_expectations.txt once we've successfully transitioned.
2113
2114         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2115         (TestExpectationParser._check_path_does_not_exist):
2116         (TestExpectationParser._tokenize):
2117         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
2118         * Scripts/webkitpy/layout_tests/port/base.py:
2119         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
2120         test_expectations.txt if one exists and the path to TestExpectations otherwise.
2121         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2122         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
2123         virtual.
2124         * Scripts/webkitpy/layout_tests/port/chromium.py:
2125         (ChromiumPort.path_from_chromium_base):
2126         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2127         (ChromiumAndroidPort.test_expectations):
2128         * Scripts/webkitpy/layout_tests/port/test.py:
2129         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
2130         (TestPort.__init__):
2131         * Scripts/webkitpy/layout_tests/port/webkit.py:
2132         (WebKitPort.baseline_search_path):
2133         (WebKitPort.test_expectations):
2134         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
2135         tests to base as a follow up.
2136         (WebKitPortTest.test_path_to_test_expectations_file):
2137         (test_test_expectations):
2138         (test_legacy_test_expectations):
2139         * Scripts/webkitpy/style/checker.py:
2140         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
2141         with one for TestExpectations.
2142         * Scripts/webkitpy/style/checkers/test_expectations.py:
2143         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
2144         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2145         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
2146         test_expectations.txt.
2147         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2148         (TestExpectationsTestCase.assert_lines_lint):
2149         * Scripts/webkitpy/tool/commands/queries.py:
2150         (PrintExpectations.__init__):
2151         * Scripts/webkitpy/tool/commands/rebaseline.py:
2152         (RebaselineExpectations):
2153         * Scripts/webkitpy/tool/steps/commit.py:
2154         (Commit._check_test_expectations):
2155         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2156         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
2157         (CommitTest.test_check_test_expectations): For TestExpectations.
2158         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
2159         * TestResultServer/static-dashboards/dashboard_base.js:
2160         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
2161         Error only when neither exists.
2162         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2163         (processMissingAndExtraExpectations):
2164         (htmlForTestsWithExpectationsButNoFailures):
2165         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2166
2167 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
2168
2169         Remove dependency from ImageDiff to WTF
2170         https://bugs.webkit.org/show_bug.cgi?id=88147
2171
2172         Reviewed by Adam Barth.
2173
2174         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2175
2176 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
2177
2178         NRWT seems to leak (more?) temp dirs
2179         https://bugs.webkit.org/show_bug.cgi?id=88126
2180
2181         Re-land r119297 with chromium fix (weren't calling the
2182         super() method if not in --test-shell mode in start().
2183         Add unit tests to chromium_unittest as well to check.
2184
2185         * Scripts/webkitpy/layout_tests/port/chromium.py:
2186         (ChromiumDriver.start):
2187         * Scripts/webkitpy/layout_tests/port/webkit.py:
2188         (WebKitDriver.__del__):
2189         (WebKitDriver._start):
2190         (WebKitDriver.run_test):
2191         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2192         (WebKitDriverTest.test_check_for_driver_crash):
2193         (WebKitDriverTest.test_stop_cleans_up_properly):
2194         (WebKitDriverTest):
2195         (WebKitDriverTest.test_two_starts_cleans_up_properly):
2196         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2197         (ChromiumDriverTest.test_stop_cleans_up_properly):
2198         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
2199
2200 2012-06-01  Tim Horton  <timothy_horton@apple.com>
2201
2202         Lots of "failed download-built-product" on Apple bots
2203         https://bugs.webkit.org/show_bug.cgi?id=88158
2204
2205         Reviewed by Jessie Berlin.
2206         
2207         Disable mergeRequests on all Apple builders. This is a speculative fix.
2208
2209         * BuildSlaveSupport/build.webkit.org-config/config.json:
2210
2211 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2212
2213         Unreviewed, rolling out r119297.
2214         http://trac.webkit.org/changeset/119297
2215         https://bugs.webkit.org/show_bug.cgi?id=88156
2216
2217         May have broken Chromium bots (Requested by rniwa on #webkit).
2218
2219         * Scripts/webkitpy/layout_tests/port/webkit.py:
2220         (WebKitDriver.__del__):
2221         (WebKitDriver.run_test):
2222         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2223         (WebKitDriverTest.test_check_for_driver_crash):
2224         (WebKitDriverTest.test_stop_cleans_up_properly):
2225
2226 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
2227
2228         nrwt seems to leak tmpdirs
2229         https://bugs.webkit.org/show_bug.cgi?id=88126
2230
2231         Reviewed by Ojan Vafai.
2232
2233         Fix leak possibly introduced in r118979 - we now will
2234         make sure we clean up any stale temp directories during the
2235         start routine and attempt to clean up again in __del__. It
2236         turns out that asserting in __del__ logs a message but is
2237         caught by the runtime, so it's mostly useless.
2238
2239         * Scripts/webkitpy/layout_tests/port/webkit.py:
2240         (WebKitDriver.__del__):
2241         (WebKitDriver._start):
2242         (WebKitDriver.run_test):
2243         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2244         (WebKitDriverTest.test_check_for_driver_crash):
2245         (WebKitDriverTest.test_stop_cleans_up_properly):
2246         (WebKitDriverTest):
2247         (WebKitDriverTest.test_two_starts_cleans_up_properly):
2248
2249 2012-06-01  Michael Saboff  <msaboff@apple.com>
2250
2251         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
2252         https://bugs.webkit.org/show_bug.cgi?id=88109
2253
2254         Reviewed by Geoffrey Garen.
2255
2256         Additional test case.
2257
2258         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2259         (TestWebKitAPI::TEST):
2260
2261 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
2262
2263         [Qt] Use -Werror only in developer builds
2264
2265         Rubber-stamped by Tor Arne Vestbø.
2266
2267         In production builds -Werror with custom toolchains and wierd system
2268         headers, -Werror is of no use and just creates confusion. So use it
2269         only if Qt is configured with -developer-build.
2270
2271         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
2272         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
2273         only if qt_developer_build is set.
2274
2275 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
2276
2277         [watchlist] Add myself to loader and v8 bindings changes
2278         https://bugs.webkit.org/show_bug.cgi?id=88112
2279
2280         Reviewed by Adam Barth.
2281
2282         * Scripts/webkitpy/common/config/watchlist:
2283
2284 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
2285
2286         Adding Jacky Jiang to committers.py
2287         https://bugs.webkit.org/show_bug.cgi?id=88122
2288
2289         Reviewed by Rob Buis.
2290
2291         Adding myself to committers.py as a Committer.
2292
2293         * Scripts/webkitpy/common/config/committers.py:
2294
2295 2012-06-01  Jessie Berlin  <jberlin@apple.com>
2296
2297         Fix Windows build.
2298
2299         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2300
2301 2012-06-01  Jessie Berlin  <jberlin@apple.com>
2302
2303         Windows WK2 MouseMoveAfterCrash API test failing
2304         https://bugs.webkit.org/show_bug.cgi?id=69982
2305
2306         Disable the test on Windows to get the bots greener.
2307
2308         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2309         (TestWebKitAPI::TEST):
2310
2311 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
2312
2313         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
2314         https://bugs.webkit.org/show_bug.cgi?id=86866
2315
2316         Reviewed by Adam Barth.
2317
2318         Catch new "intent,service,register" signal on the frame and print out
2319         information about the Web Intent service in EFL's DumpRenderTree.
2320
2321         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2322         (DumpRenderTreeChrome::createView):
2323         (DumpRenderTreeChrome::onFrameCreated):
2324         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
2325         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2326         (DumpRenderTreeChrome):
2327
2328 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
2329
2330         The ChangeLog parser cannot handle reviewers with initials in their name
2331         https://bugs.webkit.org/show_bug.cgi?id=87864
2332
2333         Reviewed by Ryosuke Niwa.
2334
2335         Add support in the ChangeLog parser for reviewer names that have
2336         initials in them.
2337
2338         * Scripts/webkitpy/common/checkout/changelog.py:
2339         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
2340         in the replacement string. This allows for matching the word characters before a
2341         period, without totally throwing them away.
2342         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
2343         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2344         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
2345
2346 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
2347
2348         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
2349         https://bugs.webkit.org/show_bug.cgi?id=86865
2350
2351         Reviewed by Adam Barth.
2352
2353         Add deliverWebIntent method to LayoutTestController and provide
2354         implementation for EFL port.
2355
2356         * DumpRenderTree/LayoutTestController.cpp:
2357         (deliverWebIntentCallback):
2358         (LayoutTestController::staticFunctions):
2359         * DumpRenderTree/LayoutTestController.h:
2360         (LayoutTestController):
2361         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2362         (LayoutTestController::deliverWebIntent):
2363         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2364         (LayoutTestController::deliverWebIntent):
2365         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2366         (LayoutTestController::deliverWebIntent):
2367         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2368         (LayoutTestController::deliverWebIntent):
2369         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2370         (LayoutTestController::deliverWebIntent):
2371         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2372         (LayoutTestController::deliverWebIntent):
2373
2374 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2375
2376         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
2377
2378         Reviewed by Simon Hausmann.
2379
2380         * Tools.pro:
2381
2382 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
2383
2384         Add public page loading performance tests using web-page-replay
2385         https://bugs.webkit.org/show_bug.cgi?id=84008
2386
2387         Reviewed by Dirk Pranke.
2388
2389         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
2390         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
2391         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
2392
2393         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
2394         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
2395         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
2396         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
2397
2398         * Scripts/webkitpy/layout_tests/port/driver.py:
2399         (Driver.is_external_http_test): Added.
2400         * Scripts/webkitpy/layout_tests/port/webkit.py:
2401         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
2402         * Scripts/webkitpy/performance_tests/perftest.py:
2403         (PerfTest.__init__): Takes port.
2404         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
2405         (PerfTest):
2406         (PerfTest.run): Calls run_single.
2407         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
2408         (ChromiumStylePerfTest.__init__):
2409         (PageLoadingPerfTest.__init__):
2410         (PageLoadingPerfTest.run):
2411         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
2412         (ReplayServer.__init__):
2413         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
2414         but it caused a dead lock on some web pages.
2415         (ReplayServer.stop):
2416         (ReplayServer.__del__):
2417         (ReplayPerfTest):
2418         (ReplayPerfTest.__init__):
2419         (ReplayPerfTest._start_replay_server):
2420         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
2421         The subsequent runs of the same test will just use test.wpr.
2422         (ReplayPerfTest.run_single):
2423         (PerfTestFactory):
2424         (PerfTestFactory.create_perf_test):
2425         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2426         (MainTest.test_parse_output):
2427         (MainTest.test_parse_output_with_failing_line):
2428         (TestPageLoadingPerfTest.test_run):
2429         (TestPageLoadingPerfTest.test_run_with_bad_output):
2430         (TestReplayPerfTest):
2431         (TestReplayPerfTest.ReplayTestPort):
2432         (TestReplayPerfTest.ReplayTestPort.__init__):
2433         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
2434         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
2435         (TestReplayPerfTest.ReplayTestPort._driver_class):
2436         (TestReplayPerfTest.MockReplayServer):
2437         (TestReplayPerfTest.MockReplayServer.__init__):
2438         (TestReplayPerfTest.MockReplayServer.stop):
2439         (TestReplayPerfTest._add_file):
2440         (TestReplayPerfTest._setup_test):
2441         (TestReplayPerfTest.test_run_single):
2442         (TestReplayPerfTest.test_run_single.run_test):
2443         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
2444         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
2445         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
2446         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
2447         (TestReplayPerfTest.test_prepare):
2448         (TestReplayPerfTest.test_prepare.run_test):
2449         (TestReplayPerfTest.test_prepare_calls_run_single):
2450         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
2451         (TestPerfTestFactory.test_regular_test):
2452         (TestPerfTestFactory.test_inspector_test):
2453         (TestPerfTestFactory.test_page_loading_test):
2454         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2455         (PerfTestsRunner):
2456         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
2457         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
2458         (PerfTestsRunner._collect_tests._is_test_file):
2459         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
2460         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2461         (create_runner):
2462         (run_test):
2463         (_tests_for_runner):
2464         (test_run_test_set):
2465         (test_run_test_set_kills_drt_per_run):
2466         (test_run_test_pause_before_testing):
2467         (test_run_test_set_for_parser_tests):
2468         (test_run_test_set_with_json_output):
2469         (test_run_test_set_with_json_source):
2470         (test_run_test_set_with_multiple_repositories):
2471         (test_run_with_upload_json):
2472         (test_upload_json):
2473         (test_upload_json.MockFileUploader.upload_single_text_file):
2474         (_add_file):
2475         (test_collect_tests):
2476         (test_collect_tests_with_multile_files):
2477         (test_collect_tests_with_multile_files.add_file):
2478         (test_collect_tests_with_skipped_list):
2479         (test_collect_tests_with_page_load_svg):
2480         (test_collect_tests_should_ignore_replay_tests_by_default):
2481         (test_collect_tests_with_replay_tests):
2482         (test_parse_args):
2483         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
2484         (AutoinstallImportHook.find_module):
2485         (AutoinstallImportHook._install_webpagereplay):
2486
2487 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
2488
2489         Support building the Android port of chromium with Ninja
2490         https://bugs.webkit.org/show_bug.cgi?id=87545
2491
2492         Reviewed by Adam Barth.
2493
2494         Ensures that shared libraries are looked up in a generator-agnostic
2495         way and that output is placed in the correct directory.
2496
2497         Depends on http://codereview.chromium.org/10386188/
2498
2499         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2500
2501 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
2502
2503         [Chromium] Chromium DRT should be able to load external resources
2504         https://bugs.webkit.org/show_bug.cgi?id=87893
2505
2506         Reviewed by Dirk Pranke.
2507
2508         Allow external resources to be loaded when the main frame's URL is also an external resource.
2509         This change is analogous to r118231 for Mac port.
2510
2511         * DumpRenderTree/chromium/WebViewHost.cpp:
2512         (blockRequest):
2513         (isLocalhost):
2514         (hostIsUsedBySomeTestsToGenerateError):
2515         (WebViewHost::willSendRequest):
2516
2517 2012-05-31  Anders Carlsson  <andersca@apple.com>
2518
2519         Build fixes.
2520
2521         Disable the C++11 extensions warning.
2522
2523         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2524         * TestWebKitAPI/Configurations/Base.xcconfig:
2525         * WebKitTestRunner/Configurations/Base.xcconfig:
2526
2527 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
2528
2529         [WK2] window.internals settings are not reset between tests
2530         https://bugs.webkit.org/show_bug.cgi?id=87783
2531
2532         Reviewed by Mihai Parparita.
2533
2534         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2535         (WTR::InjectedBundle::done): Call resetAfterTest().
2536
2537         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2538         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
2539         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
2540         This needs to be done after a tets, because the code assumes that there is an object
2541         with this name in global scope.
2542
2543         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2544
2545 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2546
2547         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
2548         https://bugs.webkit.org/show_bug.cgi?id=85006
2549
2550         Reviewed by Tor Arne Vestbø.
2551
2552         Added navigation_policy_decision implementation for DumpRenderTreeView.
2553         Added LayoutTestController::setCustomPolicyDelegate implementation.
2554         Modified LayoutTestController::waitForPolicyDelegate.
2555
2556         * DumpRenderTree/efl/DumpRenderTree.cpp:
2557         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2558         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2559         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
2560         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2561         (navigationTypeToString): aux function
2562         (onNavigationPolicyDecision): navigation_policy_decision implementation
2563         (drtViewAdd):
2564         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2565         (LayoutTestController::setCustomPolicyDelegate):
2566         (LayoutTestController::waitForPolicyDelegate):
2567
2568 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2569
2570         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
2571         https://bugs.webkit.org/show_bug.cgi?id=86195
2572
2573         Reviewed by Gustavo Noronha Silva.
2574
2575         Implement clearApplicationCacheForOrigin in EFL
2576         LayoutTestController.
2577
2578         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2579         (LayoutTestController::clearApplicationCacheForOrigin):
2580
2581 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2582
2583         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
2584         https://bugs.webkit.org/show_bug.cgi?id=87955
2585
2586         Reviewed by Simon Hausmann.
2587
2588         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2589         * DumpRenderTree/qt/EventSenderQt.cpp:
2590         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
2591         * DumpRenderTree/qt/main.cpp:
2592         * QtTestBrowser/cookiejar.cpp:
2593         * QtTestBrowser/launcherwindow.cpp:
2594         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2595         * qmake/mkspecs/features/default_post.prf:
2596
2597 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
2598
2599         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
2600
2601         Rubber-stamped by Kenneth Rohde Christiansen.
2602
2603         * qmake/config.tests/libpng/libpng.pro:
2604
2605 2012-05-30  Peter Beverloo  <peter@chromium.org>
2606
2607         [Chromium] Automatically install 64-bit linker for Android
2608         https://bugs.webkit.org/show_bug.cgi?id=79780
2609
2610         Reviewed by Adam Barth.
2611
2612         Change the update-webkit-chromium script to check whether the 64-bit
2613         linker needs to be installed as part of the update process. The actual
2614         code for doing these checks and "installing" it has been added to the
2615         webkitdirs.pm script.
2616
2617         The linker itself is part of the third_party/aosp repository, which
2618         will be pulled in through the DEPS change.
2619
2620         * Scripts/update-webkit-chromium:
2621         * Scripts/webkitdirs.pm:
2622         (chromiumInstall64BitAndroidLinkerIfNeeded):
2623         (chromiumReplaceAndroidLinkerIfNeeded):
2624
2625 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2626
2627         https://bugs.webkit.org/show_bug.cgi?id=87803
2628         Layout tests often fail trying to stat nonexistent logs 
2629
2630         Reviewed by Dirk Pranke.
2631
2632         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
2633         try/catch block around accessing the logs as a precaution.
2634
2635         * Scripts/webkitpy/common/system/crashlogs.py:
2636         (CrashLogs._find_newest_log_darwin):
2637
2638 2012-05-30  Gavin Peters  <gavinp@chromium.org>
2639
2640         Add a LayoutTest for prerender remove after stop.
2641         https://bugs.webkit.org/show_bug.cgi?id=87860
2642
2643         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
2644         can be tested by LayoutTests now.
2645
2646         Reviewed by Adam Barth.
2647
2648         * DumpRenderTree/DumpRenderTree.gypi:
2649         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
2650         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
2651         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
2652         (MockWebPrerenderingSupport::add):
2653         (MockWebPrerenderingSupport::cancel):
2654         (MockWebPrerenderingSupport::abandon):
2655         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
2656         (MockWebPrerenderingSupport):
2657         * DumpRenderTree/chromium/TestShell.cpp:
2658         (TestShell::initialize):
2659         * DumpRenderTree/chromium/TestShell.h:
2660         (TestShell):
2661         * DumpRenderTree/chromium/WebViewHost.cpp:
2662         (WebViewHost::willAddPrerender):
2663         (WebViewHost::setWebWidget):
2664         * DumpRenderTree/chromium/WebViewHost.h:
2665         (WebViewHost):
2666
2667 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2668
2669         https://bugs.webkit.org/show_bug.cgi?id=87717
2670         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
2671
2672         Reviewed by Dirk Pranke.
2673
2674         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
2675         If there isn't a crash log found for the process add a message saying
2676         the process was unresponsive.
2677
2678         * Scripts/webkitpy/layout_tests/port/webkit.py:
2679         (WebKitDriver.__init__):
2680         (WebKitDriver._check_for_driver_crash):
2681         (WebKitDriver.run_test):
2682         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2683         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
2684         (WebKitDriverTest):
2685         (WebKitDriverTest.test_check_for_driver_crash):
2686         * WebKitTestRunner/TestController.cpp:
2687         (WTR):
2688         (WTR::TestController::runTest):
2689
2690 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2691
2692         https://bugs.webkit.org/show_bug.cgi?id=87714
2693         Mac crash logs can take a really long time to be written out.
2694
2695         Reviewed by Dirk Pranke.
2696
2697         Make a second pass looking for crash logs after the tests have completed running.
2698
2699         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2700         (use_trac_links_in_results_html):
2701         (Manager.run):
2702         * Scripts/webkitpy/layout_tests/port/base.py:
2703         (Port.repository_paths):
2704         (Port.look_for_new_crash_logs):
2705         * Scripts/webkitpy/layout_tests/port/mac.py:
2706         (MacPort.look_for_new_crash_logs):
2707         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2708         (test_get_crash_log):
2709         (test_look_for_new_crash_logs):
2710         (test_look_for_new_crash_logs.fake_time_cb):
2711
2712 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2713
2714         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
2715
2716         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2717         (LayoutWebViewEventHandler::OnAlertEvent):
2718         (LayoutWebViewEventHandler::OnConfirmEvent):
2719         (LayoutWebViewEventHandler):
2720         (LayoutWebViewEventHandler::OnPromptEvent):
2721         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2722         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2723
2724 2012-05-30  Ojan Vafai  <ojan@chromium.org>
2725
2726         Only give lint errors for -expected.png png files that lack a checksum
2727         https://bugs.webkit.org/show_bug.cgi?id=87875
2728
2729         Reviewed by Tony Chang.
2730
2731         We have other pngs in the tree, e.g. for the inspector, that legitimately
2732         lack a checksum.
2733
2734         * Scripts/webkitpy/style/checkers/png.py:
2735         (PNGChecker.check):
2736         * Scripts/webkitpy/style/checkers/png_unittest.py:
2737         (PNGCheckerTest.test_check):
2738
2739 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
2740
2741         nrwt: seems to leak temp dirs
2742         https://bugs.webkit.org/show_bug.cgi?id=87795
2743
2744         Reviewed by Ojan Vafai.
2745
2746         There appears to be a bug where the chromium bots are creating
2747         temporary directories and not cleaning them up that started
2748         after the switch to WebKitDriver. It's possible that __del__
2749         wasn't getting called in a timely manner (or at all), and it's
2750         generally bad style to rely on __del__ being called, so this
2751         code changes things so that we create a temp dir in
2752         driver.start() and remove it in driver.stop(). We could be
2753         paranoid and leave the __del__ code in, but there doesn't seem
2754         to be much advantage to it. If there are bugs that result in
2755         drivers being started but not stopped, we have other problems.
2756
2757         * Scripts/webkitpy/common/system/filesystem_mock.py:
2758         (MockFileSystem.__init__):
2759         (MockFileSystem._mktemp):
2760         (MockFileSystem.mkdtemp):
2761         * Scripts/webkitpy/layout_tests/port/webkit.py:
2762         (WebKitDriver.__init__):
2763         (WebKitDriver._start):
2764         (WebKitDriver.stop):
2765         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2766         (WebKitDriverTest.test_check_for_driver_crash):
2767         (WebKitDriverTest):
2768         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
2769         (WebKitDriverTest.test_stop_cleans_up_properly):
2770
2771 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2772
2773         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
2774         https://bugs.webkit.org/show_bug.cgi?id=86841
2775
2776         Reviewed by Adam Barth.
2777
2778         Print the number of MessagePorts for each new intent in EFL's DRT.
2779         This output is expected by several Web Intents test cases.
2780
2781         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2782         (DumpRenderTreeChrome::onFrameIntentNew):
2783
2784 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2785
2786         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
2787
2788         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2789
2790 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2791
2792         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
2793         https://bugs.webkit.org/show_bug.cgi?id=87829
2794
2795         Reviewed by Adam Barth.
2796
2797         EFL's LayoutTestController now makes uses of the new helper method in
2798         DumpRenderTreeSupportEfl in order to send the intent response. This is
2799         now needed because the Ewk_Intent_Request postResult / postFailure
2800         methods were made private.
2801
2802         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2803         (LayoutTestController::sendWebIntentResponse):
2804
2805 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
2806
2807         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
2808         https://bugs.webkit.org/show_bug.cgi?id=86296
2809
2810         Reviewed by Tony Chang.
2811
2812         * DumpRenderTree/win/DRTDataObject.cpp: Added.
2813         (cfHDropFormat):
2814         (cfFileNameWFormat):
2815         (cfUrlWFormat):
2816         (WCEnumFormatEtc):
2817         (WCEnumFormatEtc::WCEnumFormatEtc):
2818         (WCEnumFormatEtc::QueryInterface):
2819         (WCEnumFormatEtc::AddRef):
2820         (WCEnumFormatEtc::Release):
2821         (WCEnumFormatEtc::Next):
2822         (WCEnumFormatEtc::Skip):
2823         (WCEnumFormatEtc::Reset):
2824         (WCEnumFormatEtc::Clone):
2825         (DRTDataObject::createInstance):
2826         (DRTDataObject::DRTDataObject):
2827         (DRTDataObject::~DRTDataObject):
2828         (DRTDataObject::QueryInterface):
2829         (DRTDataObject::AddRef):
2830         (DRTDataObject::Release):
2831         (DRTDataObject::GetData):
2832         (DRTDataObject::GetDataHere):
2833         (DRTDataObject::QueryGetData):
2834         (DRTDataObject::GetCanonicalFormatEtc):
2835         (DRTDataObject::SetData):
2836         (DRTDataObject::CopyMedium):
2837         (DRTDataObject::EnumFormatEtc):
2838         (DRTDataObject::DAdvise):
2839         (DRTDataObject::DUnadvise):
2840         (DRTDataObject::EnumDAdvise):
2841         (DRTDataObject::clearData):
2842         * DumpRenderTree/win/DRTDataObject.h: Added.
2843         (DRTDataObject):
2844         * DumpRenderTree/win/DRTDropSource.cpp: Added.
2845         (DRTDropSource::DRTDropSource):
2846         (DRTDropSource::~DRTDropSource):
2847         (DRTDropSource::QueryInterface):
2848         (DRTDropSource::AddRef):
2849         (DRTDropSource::Release):
2850         (DRTDropSource::createInstance):
2851         (DRTDropSource::QueryContinueDrag):
2852         (DRTDropSource::GiveFeedback):
2853         * DumpRenderTree/win/DRTDropSource.h: Added.
2854         (DRTDropSource):
2855         * DumpRenderTree/win/DumpRenderTree.vcproj:
2856         * DumpRenderTree/win/EventSender.cpp:
2857         (beginDragWithFilesCallback):
2858
2859 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
2860
2861         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
2862         https://bugs.webkit.org/show_bug.cgi?id=58593
2863
2864         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
2865         to WebKitTestRunner's LayoutTestController. The flag is modified via the
2866         public C API of the WebProcess.
2867
2868         Reviewed by Darin Adler.
2869
2870         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2871         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2872         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
2873         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
2874         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2875
2876 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2877
2878         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
2879         https://bugs.webkit.org/show_bug.cgi?id=87848
2880
2881         Reviewed by Csaba Osztrogonác.
2882
2883         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
2884         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
2885         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
2886
2887         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2888         (DumpRenderTreeChrome::extraViews):
2889         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2890         (DumpRenderTreeChrome):
2891
2892 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2893
2894         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
2895         https://bugs.webkit.org/show_bug.cgi?id=87833
2896
2897         Reviewed by Tor Arne Vestbø.
2898
2899         Print "postProgressFinishedNotification" message if frame load finished 
2900         to unskip http/tests/loading/progress-finished-callback.html.
2901
2902         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2903         (DumpRenderTreeChrome::onFrameLoadFinished):
2904
2905 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
2906
2907         [EFL][WK2] Fix WebKit2-EFL build
2908         https://bugs.webkit.org/show_bug.cgi?id=83693
2909
2910         Reviewed by Carlos Garcia Campos.
2911
2912         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
2913
2914 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
2915
2916         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
2917         (They only used to check for Skipped in platform/qt-5.0-wk1)
2918         https://bugs.webkit.org/show_bug.cgi?id=87376
2919
2920         Reviewed by Csaba Osztrogonác.
2921
2922         * Scripts/old-run-webkit-tests:
2923         (buildPlatformResultHierarchy):
2924         * Scripts/webkitpy/layout_tests/port/qt.py:
2925         (QtPort.baseline_search_path):
2926
2927 2012-05-29  Ojan Vafai  <ojan@chromium.org>
2928
2929         Add a linter error for pngs that lack an embedded checksum
2930         https://bugs.webkit.org/show_bug.cgi?id=87793
2931
2932         Reviewed by Dirk Pranke.
2933
2934         * Scripts/read-checksum-from-png:
2935         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
2936         (read_checksum):
2937         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
2938         (ReadChecksumFromPngTest):
2939         (ReadChecksumFromPngTest.test_read_checksum):
2940         * Scripts/webkitpy/layout_tests/port/base.py:
2941         * Scripts/webkitpy/style/checkers/png.py:
2942         (PNGChecker.check):
2943         * Scripts/webkitpy/style/checkers/png_unittest.py:
2944         (PNGCheckerTest.test_check):
2945
2946 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2947
2948         https://bugs.webkit.org/show_bug.cgi?id=87720
2949         WebProcess is often killed due to being unresponsive on the bots
2950
2951         Reviewed by Alexey Proskuryakov.
2952
2953         Blind attempt to improve flakiness on the bots by reducing the number
2954         of crashes due to an unresponsive process.  This helped on my personal machine
2955         under stress conditions.  I don't have enough cores to hit the problem
2956         under normal conditions.
2957
2958         * WebKitTestRunner/TestController.cpp:
2959         (WTR):
2960
2961 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2962
2963         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
2964         https://bugs.webkit.org/show_bug.cgi?id=87779
2965
2966         Reviewed by Eric Seidel.
2967
2968         Update output to match the names in scm.py as per
2969         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
2970
2971         * Scripts/webkitpy/tool/commands/rebaseline.py:
2972         (RebaselineTest.execute):
2973         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2974         (test_rebaseline_test_and_print_scm_changes):
2975         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2976         (GardeningServerTest.test_rebaselineall):
2977
2978 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2979
2980         https://bugs.webkit.org/show_bug.cgi?id=87711
2981
2982         Reviewed by Jessie Berlin.
2983
2984         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
2985         are better maintained.
2986
2987         * BuildSlaveSupport/build.webkit.org-config/config.json:
2988
2989 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2990
2991         webkit-patch optimize-baselines should add/delete files in batches from the vcs
2992         https://bugs.webkit.org/show_bug.cgi?id=87538
2993
2994         Reviewed by Ojan Vafai.
2995
2996         Invoking git and svn on one file at a time is kinda slow. We
2997         should batch the add and rm operations together.
2998
2999         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3000         (BaselineOptimizer._move_baselines):
3001
3002 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
3003
3004         garden-o-matic should rebaseline baselines in parallel
3005         https://bugs.webkit.org/show_bug.cgi?id=87451
3006
3007         Reviewed by Ojan Vafai.
3008                                                                                
3009         This modifies garden-o-matic so that we will fetch all                  
3010         of the baselines in parallel from the bots, and then                    
3011         optimize the baselines serially (since that should be fairly            
3012         quick and we get into trouble if we optimize in parallel due            
3013         to concurrent access to the source control system).                     
3014
3015         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
3016         so that the files that need to be modified in the SCM are returned to 
3017         garden-o-matic rather than actually added or removed. This is done so that
3018         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
3019         concurrently). In order to safely return the files (as a JSON dict) I
3020         needed to shift all of the logging in rebaseline-test to use the logging
3021         module (and hence log to stderr).
3022
3023         I also had to stub out a line in chromium.py that would get confused if
3024         the skia overrides file didn't exist in a mock checkout.
3025
3026         * Scripts/webkitpy/common/system/executive.py:
3027         (Executive.popen):
3028         (Executive):
3029         (Executive.run_in_parallel):
3030         (_run_command_thunk):
3031         * Scripts/webkitpy/common/system/executive_mock.py:
3032         (MockExecutive.run_in_parallel):
3033         * Scripts/webkitpy/common/system/executive_unittest.py:
3034         (ExecutiveTest.test_run_in_parallel):
3035         * Scripts/webkitpy/layout_tests/port/chromium.py:
3036         (ChromiumPort._expectations_file_contents):
3037         * Scripts/webkitpy/tool/commands/rebaseline.py:
3038         (AbstractRebaseliningCommand.__init__):
3039         (RebaselineTest.__init__):
3040         (RebaselineTest._copy_existing_baseline):
3041         (RebaselineTest._save_baseline):
3042         (RebaselineTest):
3043         (RebaselineTest._add_to_scm):
3044         (RebaselineTest._rebaseline_test):
3045         (RebaselineTest.execute):
3046         (RebaselineExpectations._rebaseline_port):
3047         (RebaselineExpectations.execute):
3048         (Rebaseline._builder_to_pull_from):
3049         (Rebaseline.execute):
3050         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3051         (test_rebaseline_updates_expectations_file):
3052         (test_rebaseline_test):
3053         (test_rebaseline_test_and_print_scm_changes):
3054         (test_rebaseline_and_copy_test):
3055         (test_rebaseline_and_copy_test_no_existing_result):
3056         (test_rebaseline_and_copy_test_with_lion_result):
3057         (test_rebaseline_and_copy_no_overwrite_test):
3058         (test_rebaseline_expectations):
3059         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3060         (GardeningHTTPRequestHandler._rebaseline_commands):
3061         (GardeningHTTPRequestHandler):
3062         (GardeningHTTPRequestHandler._files_to_add):
3063         (GardeningHTTPRequestHandler._optimize_baselines):
3064         (GardeningHTTPRequestHandler.rebaselineall):
3065         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3066         (GardeningServerTest._post_to_path):
3067         (GardeningServerTest.test_rebaselineall):
3068         (GardeningServerTest.test_rebaselineall.run_command):
3069
3070 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
3071
3072         Fix the type of dispatch_time() offset
3073
3074         Rubber-stamped by Joseph Pecoraro.
3075
3076         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
3077
3078         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3079         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3080
3081 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
3082
3083         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
3084
3085         [BlackBerry] OpenGL content is not rendered on simulator
3086         https://bugs.webkit.org/show_bug.cgi?id=87721
3087
3088         Reviewed by George Staikos.
3089
3090         Fixed by enabling GLES2 support in simulator builds.
3091
3092         To experiment with building without OpenGL support, you can set the
3093         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
3094
3095         PR #150695
3096
3097         * Scripts/webkitdirs.pm:
3098         (blackberryCMakeArguments):
3099
3100 2012-05-29  David Barr  <davidbarr@chromium.org>
3101
3102         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
3103         https://bugs.webkit.org/show_bug.cgi?id=87685
3104
3105         Reviewed by Eric Seidel.
3106
3107         Add a configuration option for CSS image-resolution support, disabling it by default.
3108
3109         * Scripts/webkitperl/FeatureList.pm:
3110         * qmake/mkspecs/features/features.pri:
3111
3112 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3113
3114         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
3115
3116         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
3117             valid for C++/ObjC++ but not for C [enabled by default]"
3118
3119         Reviewed by Simon Hausmann.
3120
3121         * qmake/mkspecs/features/unix/default_post.prf:
3122
3123 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3124
3125         [Qt] Sync up favicon-implementation with WebView url changes in r118158
3126
3127         https://bugs.webkit.org/show_bug.cgi?id=87133
3128
3129         We now base64-encode the page url in the image-provider url, so that any
3130         normalization done by QUrl will not mess up the page-url. The logic of
3131         creating and parsing the provider-url has been moved into the image
3132         provider, to keep it in one place.
3133
3134         We were also releasing icons (even ones we hadn't retained), which we can't
3135         do since we don't know when the icon url is no longer in use.
3136
3137         Reviewed-by Simon Hausmann.
3138
3139         * MiniBrowser/qt/icons/favicon.png:
3140         * MiniBrowser/qt/qml/BrowserWindow.qml:
3141
3142 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3143
3144         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
3145         https://bugs.webkit.org/show_bug.cgi?id=87654
3146
3147         Reviewed by Csaba Osztrogonác.
3148
3149         Event sender provides strings for all the key events.
3150         Also KeyEventInfo constructor parameters order was changed to simplify the case when
3151         a key event has empty string.
3152
3153         * DumpRenderTree/efl/EventSender.cpp:
3154         (KeyEventInfo::KeyEventInfo):
3155         (keyPadNameFromJSValue):
3156         (keyNameFromJSValue):
3157
3158 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3159
3160         [Qt] Cancel potential url-edit when going back/forward
3161
3162         Reviewed by Kenneth Rohde Christiansen.
3163
3164         * MiniBrowser/qt/qml/BrowserWindow.qml:
3165
3166 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
3167
3168         [EFL] Compilation warning in DumpRenderTreeView.cpp
3169         https://bugs.webkit.org/show_bug.cgi?id=87636
3170
3171         Reviewed by Filip Pizlo.
3172
3173         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
3174         specifier in printf. Also fix the return type for
3175         onExceededApplicationCacheQuota callback.
3176
3177         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3178         (onExceededApplicationCacheQuota):
3179
3180 2012-05-29  Hironori Bono  <hbono@chromium.org>
3181
3182         Adding Hironori Bono to committers.py.
3183         https://bugs.webkit.org/show_bug.cgi?id=87697
3184
3185         * Scripts/webkitpy/common/config/committers.py:
3186
3187 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
3188
3189         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
3190         https://bugs.webkit.org/show_bug.cgi?id=80135
3191
3192         Reviewed by Rob Buis.
3193
3194         Implemented interface function didReceiveAuthenticationChallenge in class
3195         DumpRenderTree.
3196
3197         Resubmit the patch reverted by r115104 after the digest infinite loop
3198         issue for BlackBerry porting get identified and fixed.
3199
3200         Internally reviewed by Joe Mason <jmason@rim.com>
3201
3202         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3203         (drtCredentialDescription):
3204         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
3205         (WebKit):
3206         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3207         (WebCore):
3208         (DumpRenderTree):
3209
3210 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3211
3212         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
3213         https://bugs.webkit.org/show_bug.cgi?id=42328
3214
3215         Reviewed by Eric Seidel.
3216
3217         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
3218         move to windows.internals.settings.
3219
3220         * DumpRenderTree/LayoutTestController.cpp:
3221         (LayoutTestController::staticFunctions):
3222         * DumpRenderTree/LayoutTestController.h:
3223         (LayoutTestController):
3224         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3225         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3226         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3227         (DRTDevToolsAgent):
3228         * DumpRenderTree/chromium/LayoutTestController.cpp:
3229         (LayoutTestController::LayoutTestController):
3230         * DumpRenderTree/chromium/LayoutTestController.h:
3231         (LayoutTestController):
3232         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3233         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3234         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3235         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3236         * DumpRenderTree/mac/DumpRenderTree.mm:
3237         (resetWebViewToConsistentStateBeforeTesting):
3238         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3239         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3240         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3241         (LayoutTestController):
3242         * DumpRenderTree/win/DumpRenderTree.cpp:
3243         (resetWebViewToConsistentStateBeforeTesting):
3244         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3245         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3246         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3247         (LayoutTestController):
3248
3249 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3250
3251         Move allowRoundingHacks to Internals interface
3252         https://bugs.webkit.org/show_bug.cgi?id=87328
3253
3254         Reviewed by Hajime Morita.
3255
3256         Remove allowRoundingHacks functions, because it is able to work in the
3257         cross-port way through the Internals interface.
3258
3259         * DumpRenderTree/LayoutTestController.cpp:
3260         (LayoutTestController::staticFunctions):
3261         * DumpRenderTree/LayoutTestController.h:
3262         (LayoutTestController):
3263         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3264         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3265         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3266         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3267         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3268         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3269
3270 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
3271
3272         Fix mac build with older XCode by defining NSEC_PER_MSEC.
3273         https://bugs.webkit.org/show_bug.cgi?id=87616
3274
3275         Reviewed by Hajime Morita.
3276
3277         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
3278         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
3279         Patch just adds a #ifndef / #define check.
3280
3281         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3282         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3283
3284 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3285
3286         [EFL] Enable blob support for the EFL port
3287         https://bugs.webkit.org/show_bug.cgi?id=85363
3288
3289         Reviewed by Hajime Morita.
3290
3291         Enable Blob support by default for the EFL port.
3292
3293         * Scripts/webkitperl/FeatureList.pm:
3294
3295 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
3296
3297         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
3298         https://bugs.webkit.org/show_bug.cgi?id=87582
3299
3300         Reviewed by Darin Adler.
3301
3302         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
3303         possible to test pages in a similar way as they are loaded in Browsers.
3304
3305         * DumpRenderTree/LayoutTestController.cpp:
3306         (LayoutTestController::LayoutTestController):
3307         (setUseDeferredFrameLoadingCallback):
3308         (LayoutTestController::staticFunctions):
3309         * DumpRenderTree/LayoutTestController.h:
3310         (LayoutTestController::useDeferredFrameLoading):
3311         (LayoutTestController::setUseDeferredFrameLoading):
3312         (LayoutTestController):
3313         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3314         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3315
3316 2012-05-27  David Barton  <dbarton@mathscribe.com>
3317
3318         [watchlist] Improve MathML rule
3319         https://bugs.webkit.org/show_bug.cgi?id=87592
3320
3321         Reviewed by Adam Barth.
3322
3323         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
3324         but if this changed the rule would be slow. We protect against this, clarify the rule,
3325         and make it more similar to existing rules.
3326
3327         * Scripts/webkitpy/common/config/watchlist:
3328
3329 2012-05-27  David Barton  <dbarton@mathscribe.com>
3330
3331         [watchlist] Add myself & a rule for MathML
3332         https://bugs.webkit.org/show_bug.cgi?id=87586
3333
3334         Reviewed by Adam Barth.
3335
3336         * Scripts/webkitpy/common/config/watchlist:
3337
3338 2012-05-26  David Kilzer  <ddkilzer@apple.com>
3339
3340         Use xcrun to find path to nm for Mac port
3341         <http://webkit.org/b/87588>
3342
3343         Reviewed by Dan Bernstein.
3344
3345         * Scripts/webkitpy/layout_tests/port/mac.py:
3346         (MacPort.nm_command): Add. Tries to find a path for the nm
3347         command using xcrun.  Falls back to returning 'nm'.
3348         * Scripts/webkitpy/layout_tests/port/webkit.py:
3349         (WebKitPort.nm_command): Add. Returns 'nm'.
3350         (WebKitPort._webcore_symbols_string): Call self.nm_command().
3351
3352 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
3353
3354         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
3355
3356         Reviewed by Eric Seidel.
3357
3358         * DumpRenderTree/win/DumpRenderTree.vcproj:
3359         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3360         (FrameLoadDelegate::FrameLoadDelegate):
3361         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
3362         * DumpRenderTree/win/FrameLoadDelegate.h:
3363         (FrameLoadDelegate):
3364         * DumpRenderTree/win/TextInputController.cpp: Added.
3365         (setMarkedTextCallback):
3366         (hasMarkedTextCallback):
3367         (unmarkTextCallback):
3368         (markedRangeCallback):
3369         (insertTextCallback):
3370         (firstRectForCharacterRangeCallback):
3371         (selectedRangeCallback):
3372         (TextInputController::makeWindowObject):
3373         (TextInputController::getJSClass):
3374         (TextInputController::staticValues):
3375         (TextInputController::staticFunctions):
3376         * DumpRenderTree/win/TextInputController.h: Added.
3377         (TextInputController):
3378         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
3379         (TextInputController::setMarkedText):
3380         (TextInputController::hasMarkedText):
3381         (TextInputController::unmarkText):
3382         (TextInputController::markedRange):
3383         (TextInputController::insertText):
3384         (TextInputController::firstRectForCharacterRange):
3385         (TextInputController::selectedRange):
3386
3387 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
3388
3389         webkitpy: change scm.add(), scm.delete() to accept multiple paths
3390         https://bugs.webkit.org/show_bug.cgi?id=87528
3391
3392         Reviewed by Ojan Vafai.
3393
3394         launching git or svn for individual files can be slow; this
3395         change will hand multiple paths at once to git and svn so they
3396         can be added in a batch.
3397
3398         * Scripts/webkitpy/common/checkout/scm/git.py:
3399         (Git.add_list):
3400         (Git.delete_list):
3401         * Scripts/webkitpy/common/checkout/scm/scm.py:
3402         (SCM.add):
3403         (SCM):
3404         (SCM.add_list):
3405         (SCM.delete):
3406         (SCM.delete_list):
3407         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3408         (MockSCM.add):
3409         (MockSCM):
3410         (MockSCM.add_list):
3411         (MockSCM.delete):
3412         (MockSCM.delete_list):
3413         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3414         (_shared_test_exists):
3415         (_shared_test_added_files):
3416         (_test_delete_list):
3417         * Scripts/webkitpy/common/checkout/scm/svn.py:
3418         (SVN.add_list):
3419         (SVN.delete_list):
3420
3421 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3422
3423         [NRWT] Add unit testing for perf tests on locked shards
3424         https://bugs.webkit.org/show_bug.cgi?id=87489
3425
3426         Reviewed by Dirk Pranke.
3427
3428         Adding utests that makes sure that perf tests are running in locked
3429         shards and by passing --no-http won't break NRWT (r118421).
3430
3431         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3432         (ShardingTests):
3433         (ShardingTests.test_shard_by_dir):
3434         (ShardingTests.test_shard_every_file):
3435         (ShardingTests.test_shard_in_two):
3436         (ShardingTests.test_multiple_locked_shards):
3437         (LockCheckingManager):
3438         (LockCheckingManager.__init__):
3439         (LockCheckingManager.handle_finished_list):
3440         (ManagerTest.test_http_locking):
3441         (ManagerTest):
3442         (ManagerTest.test_perf_locking):
3443         * Scripts/webkitpy/layout_tests/port/test.py:
3444
3445 2012-05-25  Jessie Berlin  <jberlin@apple.com>
3446
3447         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
3448         https://bugs.webkit.org/show_bug.cgi?id=87511
3449
3450         Reviewed by Alexey Proskuryakov.
3451
3452         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
3453
3454         * DumpRenderTree/win/EventSender.cpp:
3455         (keyDownCallback):
3456
3457 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
3458
3459         Adding Ken Buchanan to committers.py
3460         https://bugs.webkit.org/show_bug.cgi?id=87443
3461
3462         Unreviewed.
3463
3464         Adding self to committers.py as a Committer.
3465
3466         * Scripts/webkitpy/common/config/committers.py:
3467
3468 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
3469
3470         [Qt] Buildfix for newer Qt5
3471         https://bugs.webkit.org/show_bug.cgi?id=87257
3472
3473         Reviewed by Simon Hausmann.
3474
3475         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
3476
3477 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
3478
3479         [Qt] Unreviewed fix after r118484.
3480
3481         Enable CSS_EXCLUSIONS and CSS_REGIONS.
3482         They were enabled uncoditinally before r118484.
3483
3484         * qmake/mkspecs/features/features.pri:
3485
3486 2012-05-24  Tim Horton  <timothy_horton@apple.com>
3487
3488         Add feature defines for web-facing parts of CSS Regions and Exclusions
3489         https://bugs.webkit.org/show_bug.cgi?id=87442
3490         <rdar://problem/10887709>
3491
3492         Reviewed by Dan Bernstein.
3493
3494         * Scripts/webkitperl/FeatureList.pm:
3495
3496 2012-05-24  Hironori Bono  <hbono@chromium.org>
3497
3498         Enable grammar checking on Chromium when we paste text (Take 2)
3499         https://bugs.webkit.org/show_bug.cgi?id=74393
3500
3501         Reviewed by Ryosuke Niwa.
3502
3503         This change enables grammar checking on Chromium and implements a mock grammar
3504         checker to fix a failing test.
3505
3506         * DumpRenderTree/DumpRenderTree.gypi:
3507         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
3508         (MockGrammarCheck::checkGrammarOfString):
3509         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
3510         (WebKit):
3511         (MockGrammarCheck):
3512         * DumpRenderTree/chromium/WebViewHost.cpp:
3513         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
3514
3515 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3516
3517         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
3518         https://bugs.webkit.org/show_bug.cgi?id=86842
3519
3520         Reviewed by Antonio Gomes.
3521
3522         Add support for overriding the application cache support preference
3523         through EFL's LayoutTestController.
3524
3525         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3526         (LayoutTestController::overridePreference):
3527
3528 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3529
3530         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
3531         https://bugs.webkit.org/show_bug.cgi?id=85209
3532
3533         Reviewed by Antonio Gomes.
3534
3535         Set developer extras setting called twice on the test startup. Hence, removing
3536         an unnecessary extra call which set wrong value. 
3537
3538         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3539         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3540
3541 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
3542
3543         garden-o-matic should not fetch from debug bots if it also knows about the release bots
3544         https://bugs.webkit.org/show_bug.cgi?id=86916
3545
3546         Reviewed by Adam Barth.
3547
3548         Note that if release and debug are failing differently, debug
3549         will be ignored ...
3550
3551         Note: also change the use of a fake port name from
3552         "mock-port-name" to "test-mac-leopard" to make it more friendly
3553         to the port factory ("mock" actually is a real port).
3554
3555         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3556         (GardeningHTTPRequestHandler._builders_to_fetch_from):
3557         (GardeningHTTPRequestHandler.rebaselineall):
3558         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3559         (GardeningServerTest.test_rebaselineall):
3560         (GardeningServerTest.test_rebaseline_new_port):
3561
3562 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
3563
3564         nrwt: fix baseline search path for official chrome builders
3565         https://bugs.webkit.org/show_bug.cgi?id=87432
3566
3567         Reviewed by Tony Chang.
3568
3569         The official chrome builders need to use the win7 and SL
3570         baseline paths, not the XP and Leopard paths. Linux is correct.
3571
3572         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3573         (GoogleChromeMacPort.determine_full_port_name):
3574         (GoogleChromeWinPort.determine_full_port_name):
3575         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3576         (TestGoogleChromePort._verify_baseline_search_path_startswith):
3577         (TestGoogleChromePort.test_get_google_chrome_port):
3578
3579 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3580
3581         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
3582         https://bugs.webkit.org/show_bug.cgi?id=86800
3583
3584         Reviewed by Dirk Pranke.
3585
3586         Don't launch a HTTP server with lock based only on the existence of
3587         locked shards since we now run perf on locked shards too.
3588
3589         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3590         (Manager._run_tests):
3591
3592 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
3593
3594         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
3595         https://bugs.webkit.org/show_bug.cgi?id=87128
3596
3597         Reviewed by Dirk Pranke.
3598
3599         * Scripts/webkitpy/layout_tests/port/base.py:
3600         (Port.driver_name):
3601         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3602         (ChromiumLinuxPort._path_to_driver):
3603         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3604         (ChromiumPortTest.test_driver_name_option):
3605         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3606         (ChromiumWinPort._path_to_driver):
3607         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3608         (parse_args):
3609
3610 2012-05-24  John Mellor  <johnme@chromium.org>
3611
3612         Font Boosting: Add compile flag and runtime setting
3613         https://bugs.webkit.org/show_bug.cgi?id=87394
3614
3615         Reviewed by Adam Barth.
3616
3617         Add ENABLE_FONT_BOOSTING.
3618
3619         * Scripts/webkitperl/FeatureList.pm:
3620         * qmake/mkspecs/features/features.pri:
3621
3622 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3623
3624         [EFL] [DRT] keyboard-related tests do not pass
3625         https://bugs.webkit.org/show_bug.cgi?id=85369
3626
3627         Reviewed by Gustavo Noronha Silva.
3628
3629         Add SHIFT modifier for capital letters as VK_ 
3630         codes do not distinguish between lows and caps and also to be consistent
3631         with other ports which send caps as lowercase letters with the shift key down.
3632
3633         * DumpRenderTree/efl/EventSender.cpp:
3634         (keyNameFromJSValue): 
3635
3636 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
3637
3638         [WK2] Let the client give local files universal access on a case by case basis
3639         https://bugs.webkit.org/show_bug.cgi?id=87174
3640         <rdar://problem/11024330>
3641
3642         Reviewed by Maciej Stachowiak.
3643
3644         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
3645         Added initialization of a new structure member to prevent build failure.
3646
3647 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
3648
3649         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
3650         https://bugs.webkit.org/show_bug.cgi?id=87203
3651
3652         Reviewed by Andreas Kling.
3653
3654         Add the required changes to make
3655         fast/events/keydown-leftright-keys.html pass after r118001.
3656
3657         * DumpRenderTree/efl/EventSender.cpp:
3658         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
3659         into the proper X11 keysym definitions.
3660
3661 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3662
3663         Unreviewed, rolling out r118352.
3664         http://trac.webkit.org/changeset/118352
3665         https://bugs.webkit.org/show_bug.cgi?id=87390
3666
3667         Caused 6 editing/spelling tests crash/fail on chromium in
3668         debug. (Requested by vsevik on #webkit).
3669
3670         * DumpRenderTree/DumpRenderTree.gypi:
3671         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
3672         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
3673         * DumpRenderTree/chromium/WebViewHost.cpp:
3674         (WebViewHost::finishLastTextCheck):
3675
3676 2012-05-24  Peter Beverloo  <peter@chromium.org>
3677