1 2016-01-21 Nan Wang <n_wang@apple.com>
3 AX: [IOS] Implement next/previous text marker functions using TextIterator
4 https://bugs.webkit.org/show_bug.cgi?id=153292
5 <rdar://problem/24268243>
7 Reviewed by Chris Fleizach.
9 Made text marker tests available on iOS.
11 * DumpRenderTree/AccessibilityTextMarker.h:
12 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
13 * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
14 (AccessibilityTextMarker::AccessibilityTextMarker):
15 (AccessibilityTextMarker::~AccessibilityTextMarker):
16 (AccessibilityTextMarker::isEqual):
17 (AccessibilityTextMarker::platformTextMarker):
18 (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
19 (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
20 (AccessibilityTextMarkerRange::isEqual):
21 (AccessibilityTextMarkerRange::platformTextMarkerRange):
22 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
23 (AccessibilityUIElement::pathDescription):
24 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
25 (AccessibilityUIElement::textMarkerRangeForElement):
26 (AccessibilityUIElement::selectedTextMarkerRange):
27 (AccessibilityUIElement::resetSelectedTextMarkerRange):
28 (AccessibilityUIElement::textMarkerRangeLength):
29 (AccessibilityUIElement::textMarkerRangeForMarkers):
30 (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
31 (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
32 (AccessibilityUIElement::accessibilityElementForTextMarker):
33 (AccessibilityUIElement::endTextMarkerForBounds):
34 (AccessibilityUIElement::startTextMarkerForBounds):
35 (AccessibilityUIElement::textMarkerForPoint):
36 (AccessibilityUIElement::previousTextMarker):
37 (AccessibilityUIElement::nextTextMarker):
38 (AccessibilityUIElement::stringForTextMarkerRange):
39 (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
40 (AccessibilityUIElement::indexForTextMarker):
41 (AccessibilityUIElement::isTextMarkerValid):
42 (AccessibilityUIElement::textMarkerForIndex):
43 (AccessibilityUIElement::startTextMarker):
44 (AccessibilityUIElement::endTextMarker):
45 (AccessibilityUIElement::setSelectedVisibleTextRange):
46 (AccessibilityUIElement::getLinkedUIElements):
47 * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
48 (AccessibilityTextMarkerRange::platformTextMarkerRange):
49 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
50 (AccessibilityUIElement::removeSelection):
51 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
52 (AccessibilityUIElement::setSelectedVisibleTextRange):
53 (AccessibilityUIElement::supportedActions):
54 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
55 (WTR::AccessibilityUIElement::textMarkerRangeForElement):
56 (WTR::AccessibilityUIElement::textMarkerRangeLength):
57 (WTR::AccessibilityUIElement::previousTextMarker):
58 (WTR::AccessibilityUIElement::nextTextMarker):
59 (WTR::AccessibilityUIElement::stringForTextMarkerRange):
60 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
61 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
62 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
63 (WTR::AccessibilityUIElement::endTextMarkerForBounds):
64 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
65 (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
67 2016-01-20 Filip Pizlo <fpizlo@apple.com>
69 Unreviewed, revert accidental unreviewed commit.
71 * Scripts/display-profiler-output:
73 2016-01-20 Jason Marcell <jmarcell@apple.com>
75 Refactor compareIterations to remove duplicate code.
76 https://bugs.webkit.org/show_bug.cgi?id=152913
78 Reviewed by Daniel Bates.
80 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
81 (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
82 (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
83 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
84 the same behavior before and after refactor.
86 2016-01-20 Dana Burkart <dburkart@apple.com>
88 Botwatcher's dashboard should show an 'X' when the build is broken
89 https://bugs.webkit.org/show_bug.cgi?id=152507
91 Reviewed by David Kilzer.
93 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
94 (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
95 (BuildbotStaticAnalyzerQueueView.prototype.update):
97 2016-01-19 Jason Marcell <jmarcell@apple.com>
99 Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
100 https://bugs.webkit.org/show_bug.cgi?id=153262
102 Reviewed by Alexey Proskuryakov.
104 Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
105 such cases this revisionContentForIteration method does not have any content to return, thus the
108 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
109 (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
111 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
113 [GTK] Runtime critical warnings when loading a URL after a session restore
114 https://bugs.webkit.org/show_bug.cgi?id=153233
116 Reviewed by Michael Catanzaro.
120 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
122 (testWebKitWebViewNavigationAfterSessionRestore):
125 2016-01-19 Michael Catanzaro <mcatanzaro@igalia.com>
127 [GTK] Remove jhbuild-optional.modules
128 https://bugs.webkit.org/show_bug.cgi?id=152964
130 Reviewed by Alex Christensen.
132 * gtk/jhbuild-optional.modules: Removed.
133 * gtk/jhbuild.modules:
135 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
137 [GTK] Add support to load/save session in MiniBrowser
138 https://bugs.webkit.org/show_bug.cgi?id=153201
140 Reviewed by Michael Catanzaro.
142 It makes it easier to test the new WebView session API.
144 * MiniBrowser/gtk/BrowserWindow.c:
145 (browserWindowFinalize): Free the session file path.
146 (browserWindowSaveSession): Save the current WebView session if
147 there's a session file path.
148 (browserWindowDeleteEvent): Call browserWindowSaveSession().
149 (browser_window_load_session): Try to load the session from the
150 given file path, otherwise fall back to homepage and keep the
151 session file to save the session on window close.
152 * MiniBrowser/gtk/BrowserWindow.h:
153 * MiniBrowser/gtk/main.c:
154 (createBrowserWindow): Pass the given session file path when
155 shouldLoadSession is TRUE.
156 (main): Only allow to restore/save session when MiniBrowser is
157 launched without URL arguments.
159 2016-01-19 Carlos Garcia Campos <cgarcia@igalia.com>
161 Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
163 Geolocation is no longer allowed for unique origins after r195075.
165 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
166 (testWebViewGeolocationPermissionRequests):
168 2016-01-18 Carlos Alberto Lopez Perez <clopez@igalia.com>
170 [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
171 https://bugs.webkit.org/show_bug.cgi?id=153216
173 Reviewed by Michael Catanzaro.
175 * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
176 (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
178 2016-01-18 Nan Wang <n_wang@apple.com>
180 AX: [Mac] Implement next/previous text marker functions using TextIterator
181 https://bugs.webkit.org/show_bug.cgi?id=152728
183 Reviewed by Chris Fleizach.
185 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
186 (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
188 2016-01-18 Csaba Osztrogonác <ossy@webkit.org>
190 [cmake] Add testair to the build system
191 https://bugs.webkit.org/show_bug.cgi?id=153126
193 Reviewed by Michael Catanzaro.
197 2016-01-16 Myles C. Maxfield <mmaxfield@apple.com>
199 Remove TextRun::allowsRoundingHacks()
200 https://bugs.webkit.org/show_bug.cgi?id=153185
202 Reviewed by Simon Fraser.
204 * DumpRenderTree/mac/DumpRenderTree.mm:
205 (resetWebViewToConsistentStateBeforeTesting): Deleted.
207 2016-01-15 Konstantin Tokarev <annulen@yandex.ru>
209 [webkitdirs] Avoid list form of open because it broke WinCairo
210 https://bugs.webkit.org/show_bug.cgi?id=153106
212 Reviewed by Alex Christensen.
214 * Scripts/webkitdirs.pm:
215 (determineArchitecture):
217 2016-01-15 Simon Fraser <simon.fraser@apple.com>
219 Add kdebug_trace signposts for a few WebCore operations
220 https://bugs.webkit.org/show_bug.cgi?id=153136
221 rdar://problem/24208487
223 Reviewed by Sam Weinig.
225 Plist used by kdebug_trace() viewing tools.
227 * Tracing/SystemTracePoints.plist: Added.
229 2016-01-14 Konstantin Tokarev <annulen@yandex.ru>
231 [webkitdirs] Replaced grep invocation with perl code
232 https://bugs.webkit.org/show_bug.cgi?id=153106
234 Reviewed by Alex Christensen.
236 * Scripts/webkitdirs.pm:
237 (determineArchitecture):
239 2016-01-14 Brian Burg <bburg@apple.com>
241 prepare-changelog does not read paths containing spaces properly
242 https://bugs.webkit.org/show_bug.cgi?id=137982
244 Reviewed by Joseph Pecoraro.
246 Escape whitespace in filenames before passing the file path to other functions.
248 * Scripts/prepare-ChangeLog:
249 (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
251 2016-01-14 Jason Marcell <jmarcell@apple.com>
253 Standardize the usage of "branch" vs. "branchName".
254 https://bugs.webkit.org/show_bug.cgi?id=152982
256 Reviewed by Daniel Bates.
258 In an earlier patch we started using the name "branch" to indicate a branch object, whereas
259 "branchName" implies that the variable or property in question is simply a string.
261 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
262 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
263 (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
264 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
265 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
266 (Trac.prototype.commitsOnBranch): Change branch to branchName.
267 (Trac.prototype._convertCommitInfoElementToObject): Ditto.
268 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
271 2016-01-14 Jason Marcell <jmarcell@apple.com>
273 Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
274 https://bugs.webkit.org/show_bug.cgi?id=152910
276 Reviewed by Daniel Bates.
278 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
279 (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
280 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
281 (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
282 the need to talk to a real Buildbot server.
283 (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
284 without the need to talk to a real Buildbot server.
285 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
286 (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
288 (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
289 (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
290 (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
291 trying to talk to Trac.
292 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
294 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
296 2016-01-14 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
298 [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
299 https://bugs.webkit.org/show_bug.cgi?id=132599
301 Reviewed by Michael Catanzaro.
303 Check if cmake Ninja generators are installed.
305 * Scripts/webkitdirs.pm:
306 (canUseNinjaGenerator):
307 (canUseEclipseNinjaGenerator):
308 (generateBuildSystemFromCMakeProject):
309 (canUseEclipse): Deleted.
311 2016-01-13 Myles C. Maxfield <mmaxfield@apple.com>
313 [Cocoa] Testing with font family name "System Font" is unused
314 https://bugs.webkit.org/show_bug.cgi?id=153073
315 <rdar://problem/24091683>
317 Reviewed by Brent Fulgham.
319 * DumpRenderTree/mac/DumpRenderTree.mm:
320 (allowedFontFamilySet): Deleted.
321 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
322 (WTR::allowedFontFamilySet): Deleted.
323 * WebKitTestRunner/mac/TestControllerMac.mm:
324 (WTR::allowedFontFamilySet): Deleted.
326 2016-01-13 Daniel Bates <dabates@apple.com>
328 [XSS Auditor] Add test when XSS payload is in the path portion of the URL
329 https://bugs.webkit.org/show_bug.cgi?id=152871
331 Reviewed by Brent Fulgham.
333 Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
334 <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
336 * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
338 2016-01-08 Andy Estes <aestes@apple.com>
340 [Content Filtering] Lazily load platform frameworks
341 https://bugs.webkit.org/show_bug.cgi?id=152881
342 rdar://problem/23270886
344 Reviewed by Brady Eidson.
346 Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
347 expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
348 loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
349 and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
350 is loaded after an HTTPS request.
352 To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
353 Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
354 WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
355 also re-enabled on iOS after mistakenly being disabled by r188892.
357 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
358 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
359 (TestWebKitAPI::TEST):
360 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
361 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
362 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
365 (-[LazilyLoadPlatformFrameworksController init]):
366 (-[LazilyLoadPlatformFrameworksController webView]):
367 (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
368 (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
369 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
370 (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
371 (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
372 (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
373 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
374 (TestWebKitAPI::TEST):
375 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
376 (TestWebKitAPI::TEST): Deleted.
377 * TestWebKitAPI/cocoa/TestProtocol.h:
378 * TestWebKitAPI/cocoa/TestProtocol.mm:
379 (+[TestProtocol registerWithScheme:]):
380 (+[TestProtocol unregister]):
382 2016-01-12 Dewei Zhu <dewei_zhu@apple.com>
384 Fix the Sunpider converage in slow device.
385 https://bugs.webkit.org/show_bug.cgi?id=152938
386 <rdar://problem/22511411>
388 Reviewed by Ryosuke Niwa.
390 Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
392 * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
394 2016-01-12 Ryosuke Niwa <rniwa@webkit.org>
396 Add a build flag for custom element
397 https://bugs.webkit.org/show_bug.cgi?id=153005
399 Reviewed by Alex Christensen.
401 Added --custom-elements option to enable custom elements support.
403 * Scripts/webkitperl/FeatureList.pm:
405 2016-01-12 Benjamin Poulain <bpoulain@apple.com>
407 [JSC] Add a help message when run-jsc-stress-tests fails
408 https://bugs.webkit.org/show_bug.cgi?id=153014
410 Reviewed by Csaba Osztrogonác.
412 * Scripts/run-jsc-stress-tests:
414 2016-01-11 Saam barati <sbarati@apple.com>
416 run-jsc-stress-tests should try to figure out a JSC path
417 https://bugs.webkit.org/show_bug.cgi?id=152971
419 Reviewed by Yusuke Suzuki.
421 This patch now allows run-jsc-stress-tests to be run
422 without a "--jsc <jsc-path>" argument. It tries
423 to take its best guess at a <jsc-path> automagically.
425 This makes it much easier to just run run-jsc-stress-tests
426 with a directory or a yaml file as an argument.
427 You now just do this:
428 `run-jsc-stress-tests <path-to-yaml>`
430 `run-jsc-stress-tests <path-to-directory-of-js-files>`
432 I wrote this patch because I'd often find myself hacking the
433 run-javascriptcore-tests file just to run a particular subset of tests.
434 Because I always forget the arguments to run-jsc-stress-tests (which means
435 I always forgot to provide a --jsc argument), I always found it easier to
436 just hack on that file instead of calling run-jsc-stress-tests directly.
437 No longer is this true!
439 * Scripts/run-jsc-stress-tests:
441 2016-01-09 Andy Estes <aestes@apple.com>
443 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
444 https://bugs.webkit.org/show_bug.cgi?id=152950
445 rdar://problem/24066652
447 Reviewed by Tim Horton.
451 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
452 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
453 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
454 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
455 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
456 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
457 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
458 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
461 2016-01-11 Commit Queue <commit-queue@webkit.org>
463 Unreviewed, rolling out r194866.
464 https://bugs.webkit.org/show_bug.cgi?id=152986
466 This change broke the mac build (Requested by ryanhaddad on
471 "[Cocoa] Add SPI to opt out a URL scheme from the memory
473 https://bugs.webkit.org/show_bug.cgi?id=152950
474 http://trac.webkit.org/changeset/194866
476 2016-01-11 Andy Estes <aestes@apple.com>
478 [Cocoa] Add SPI to opt out a URL scheme from the memory cache
479 https://bugs.webkit.org/show_bug.cgi?id=152950
480 rdar://problem/24066652
482 Reviewed by Tim Horton.
486 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
487 * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
488 (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
489 (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
490 (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
491 (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
492 (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
493 (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
496 2016-01-11 Konstantin Tokarev <annulen@yandex.ru>
498 [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
499 https://bugs.webkit.org/show_bug.cgi?id=152959
501 Reviewed by Brent Fulgham.
503 * Scripts/webkitdirs.pm:
504 (determineArchitecture):
506 2016-01-11 Michael Catanzaro <mcatanzaro@igalia.com>
508 [GTK] W3C CSS2.1 anonymous table tests are failing
509 https://bugs.webkit.org/show_bug.cgi?id=152455
511 Reviewed by Mario Sanchez Prada.
513 Add shared-mime-info to the jhbuild environment, since it affects the results of layout
514 tests. Add upstream patches to fix detection of XHTML files.
516 * gtk/jhbuild.modules:
517 * gtk/patches/shared-mime-info-xht-glob.patch: Added.
518 * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
520 2016-01-10 Saam barati <sbarati@apple.com>
522 Implement a sampling profiler
523 https://bugs.webkit.org/show_bug.cgi?id=151713
525 Reviewed by Filip Pizlo.
527 * Scripts/run-jsc-stress-tests:
529 2016-01-10 Konstantin Tokarev <annulen@yandex.ru>
531 [webkitdirs] Try arch and uname commands on non-windows OS
532 https://bugs.webkit.org/show_bug.cgi?id=152958
534 Reviewed by Michael Catanzaro.
536 Right now, determineArchitecture() uses `arch` and `uname -m`
537 commands to determine architecture in case of condition (isGtk() ||
538 isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
539 instead, because this code is applicable to any non-windows OS WebKit
540 supports (even Haiku which once was supported is moderately
541 POSIX-compliant and has uname command).
543 * Scripts/webkitdirs.pm:
544 (determineArchitecture):
546 2016-01-08 Aakash Jain <aakash_jain@apple.com>
548 run-webkit-tests mis-counts totals when there are other crashes
549 https://bugs.webkit.org/show_bug.cgi?id=152894
550 <rdar://problem/24098697>
552 Reviewed by Alexey Proskuryakov.
554 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
555 (TestRunResults.add): Do not update result counters for other crashes.
557 2016-01-08 Youenn Fablet <youenn.fablet@crf.canon.fr>
559 webkit-patch build-and-test should have an option to iterate over new tests
560 https://bugs.webkit.org/show_bug.cgi?id=143093
562 Reviewed by Michael Catanzaro.
564 This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
565 It allows running run-webkit-tests on modified or new paths in LayoutTests.
566 Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
567 It implements the translation of -expected.* paths to their related tests.
568 It also implements the removal of skipped tests.
570 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
571 (LayoutTestFinder.find_touched_tests):
572 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
576 (LayoutTestFinderTests):
577 (LayoutTestFinderTests.touched_files):
578 (LayoutTestFinderTests.test_touched_test):
579 (LayoutTestFinderTests.test_expected_touched_test):
580 (LayoutTestFinderTests.test_platform_expected_touched_test):
581 (LayoutTestFinderTests.test_platform_duplicate_touched_test):
582 (LayoutTestFinderTests.test_touched_but_skipped_test):
583 * Scripts/webkitpy/port/base.py:
584 (Port.potential_test_names_from_expected_file):
585 * Scripts/webkitpy/tool/commands/download_unittest.py:
586 (DownloadCommandsTest._default_options):
587 * Scripts/webkitpy/tool/steps/options.py:
589 * Scripts/webkitpy/tool/steps/runtests.py:
593 (RunTests._new_or_modified_tests):
594 (RunTests._run_webkit_tests):
595 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
596 (RunTestsTest.test_webkit_run_unit_tests):
597 * Scripts/webkitpy/tool/steps/steps_unittest.py:
598 (StepsTest._step_options):
600 2016-01-07 Joseph Pecoraro <pecoraro@apple.com>
602 prepare-ChangeLog should include radar number
603 https://bugs.webkit.org/show_bug.cgi?id=152839
604 <rdar://problem/24093563>
606 Reviewed by Daniel Bates.
608 When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
609 starts with a "<rdar://problem/####>" URL. If found, include that radar URL
610 in the ChangeLog description after the bug URL.
612 * Scripts/prepare-ChangeLog:
613 (main): Update signatures.
614 (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
615 (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
616 (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
617 (generateNewChangeLogs): Include radar URL if we found one.
619 * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
620 Tests for the radar URL extraction.
622 2016-01-07 Alexey Proskuryakov <ap@apple.com>
624 testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
625 https://bugs.webkit.org/show_bug.cgi?id=152390
626 <rdar://problem/23948321>
628 Reviewed by Simon Fraser.
630 Fix two use-after-frees.
632 1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
633 but we may have already progressed to another test by the time the callback fires,
634 having destroyed the TestInvocation.
635 2. UIScriptController is a RefCounted object, but it has a raw pointer to
636 UIScriptContext which has the same lifetime as a TestInvocation.
637 As a result, completion blocks of UIScriptController actions would use a destroyed
640 * WebKitTestRunner/TestInvocation.cpp:
641 (WTR::TestInvocation::~TestInvocation):
642 (WTR::TestInvocation::url):
643 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
644 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
645 (WTR::TestInvocation::runUISideScript):
646 * WebKitTestRunner/TestInvocation.h:
647 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
648 (UIScriptContext::UIScriptContext):
649 (UIScriptContext::~UIScriptContext):
650 (UIScriptContext::runUIScript):
651 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
652 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
653 (WTR::UIScriptController::UIScriptController):
654 (WTR::UIScriptController::contextDestroyed):
655 (WTR::UIScriptController::makeWindowObject):
656 (WTR::UIScriptController::setWillBeginZoomingCallback):
657 (WTR::UIScriptController::willBeginZoomingCallback):
658 (WTR::UIScriptController::setDidEndZoomingCallback):
659 (WTR::UIScriptController::didEndZoomingCallback):
660 (WTR::UIScriptController::setDidEndScrollingCallback):
661 (WTR::UIScriptController::didEndScrollingCallback):
662 (WTR::UIScriptController::setDidShowKeyboardCallback):
663 (WTR::UIScriptController::didShowKeyboardCallback):
664 (WTR::UIScriptController::setDidHideKeyboardCallback):
665 (WTR::UIScriptController::didHideKeyboardCallback):
666 (WTR::UIScriptController::uiScriptComplete):
667 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
668 (WTR::UIScriptController::create):
669 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
670 (WTR::UIScriptController::doAsyncTask):
671 (WTR::UIScriptController::zoomToScale):
672 (WTR::UIScriptController::singleTapAtPoint):
673 (WTR::UIScriptController::doubleTapAtPoint):
674 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
675 (WTR::UIScriptController::contentVisibleRect):
676 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
677 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
678 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
679 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
680 (WTR::UIScriptController::platformSetDidEndScrollingCallback):
681 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
682 (WTR::UIScriptController::doAsyncTask):
684 2016-01-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
686 [buildbot] clean-build script should remove untracked files and revert local changes too
687 https://bugs.webkit.org/show_bug.cgi?id=142400
689 Reviewed by Ryosuke Niwa.
691 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
692 A helper routine SCM.discard_untracked_files is added for that purpose.
694 * BuildSlaveSupport/clean-build:
695 (main): Making call to Scripts/clean-webkit
696 * Scripts/clean-webkit: Added.
697 (main): Revert changes and delete untracked files.
698 * Scripts/webkitpy/common/checkout/scm/scm.py:
699 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
700 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
701 (SCMTest._shared_test_discard_untracked_files):
702 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
704 2016-01-06 Simon Fraser <simon.fraser@apple.com>
706 Add a setting and preferences to enable display-list drawing. Does nothing yet.
707 https://bugs.webkit.org/show_bug.cgi?id=152807
709 Reviewed by Zalan Bujtas.
711 Add an item to the Settings menu to toggle display-list drawing.
713 * MiniBrowser/mac/SettingsController.h:
714 * MiniBrowser/mac/SettingsController.m:
715 (-[SettingsController _populateMenu]):
716 (-[SettingsController validateMenuItem:]):
717 (-[SettingsController toggleDisplayListDrawingEnabled:]):
718 (-[SettingsController displayListDrawingEnabled]):
719 * MiniBrowser/mac/WK2BrowserWindowController.m:
720 (-[WK2BrowserWindowController didChangeSettings]):
722 2016-01-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
724 Python SCM should be able to retrieve untracked files - Add GIT support
725 https://bugs.webkit.org/show_bug.cgi?id=143135
727 Reviewed by Michael Catanzaro.
729 * Scripts/webkitpy/common/checkout/scm/git.py:
730 (Git.untracked_files): Adding support for git.
731 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
733 (GitTest.test_untracked_files): Adding test.
735 2016-01-05 Mark Lam <mark.lam@apple.com>
737 Rename badly named JSC_timeout env var to JSCTEST_timeout.
738 https://bugs.webkit.org/show_bug.cgi?id=152748
740 Reviewed by Geoffrey Garen.
742 Now that we validate JSC options, the badly named JSC_timeout env var causes the
743 bots to have a bad time.
745 * Scripts/run-javascriptcore-tests:
746 * Scripts/run-jsc-stress-tests:
748 2016-01-04 Carlos Garcia Campos <cgarcia@igalia.com>
750 [GTK] Allow to save and restore session
751 https://bugs.webkit.org/show_bug.cgi?id=115600
753 Reviewed by Michael Catanzaro.
755 Add test case to check the new session API.
757 * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
758 (testWebKitWebViewSessionState):
759 (testWebKitWebViewSessionStateWithFormData):
762 2016-01-04 Csaba Osztrogonác <ossy@webkit.org>
764 [EFL] Bump EFL version to 1.16.1
765 https://bugs.webkit.org/show_bug.cgi?id=152688
767 Reviewed by Gyuyoung Kim.
769 * efl/jhbuild.modules:
771 2016-01-04 Aakash Jain <aakash_jain@apple.com>
773 error running layout tests on iOS simulator on latest build
774 https://bugs.webkit.org/show_bug.cgi?id=152719
775 <rdar://problem/24009549>
777 Reviewed by Alexey Proskuryakov.
779 * Scripts/webkitpy/xcode/simulator.py:
780 (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
781 before running simctl spawn command.
783 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
785 Unreviewed, move Frédéric Wang to committers list
787 He seems to be on the contributors list by accident. He has been landing his own commits for
790 * Scripts/webkitpy/common/config/contributors.json:
792 2016-01-03 Michael Catanzaro <mcatanzaro@igalia.com>
794 Unreviewed, move Sebastian Dröge to committers list harder
796 He accidentally added himself to the reviewers list because the file is confusing. Then I
797 accidentially moved him to the contributors list because the file is confusing, even though
798 I knew the contributors list existed in this file and was attempting to add him to the
799 committers list. Really move him to the committers list now.
801 * Scripts/webkitpy/common/config/contributors.json:
803 2016-01-02 Youenn Fablet <youenn.fablet@crf.canon.fr>
805 Python SCM should be able to retrieve untracked files - Add SVN support
806 https://bugs.webkit.org/show_bug.cgi?id=152546
808 Reviewed by Michael Catanzaro.
810 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
811 (test_untracked_files): Activating test for SVN.
812 * Scripts/webkitpy/common/checkout/scm/svn.py:
813 (SVN.untracked_files): Implementing untracked files retrieval for SVN.
815 2015-12-31 Andy Estes <aestes@apple.com>
817 Replace WTF::move with WTFMove
818 https://bugs.webkit.org/show_bug.cgi?id=152601
820 Reviewed by Brady Eidson.
822 * DumpRenderTree/TestRunner.h:
823 (TestRunner::setAllowedHosts):
824 * DumpRenderTree/win/DRTDataObject.cpp:
825 (DRTDataObject::SetData):
826 * TestWebKitAPI/Tests/WTF/Deque.cpp:
827 (TestWebKitAPI::TEST):
828 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
829 (TestWebKitAPI::TEST):
830 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
831 (TestWebKitAPI::TEST):
832 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
833 (TestWebKitAPI::TEST):
834 * TestWebKitAPI/Tests/WTF/Ref.cpp:
835 (TestWebKitAPI::passWithRef):
836 (TestWebKitAPI::TEST):
837 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
838 (TestWebKitAPI::TEST):
839 * TestWebKitAPI/Tests/WTF/Vector.cpp:
840 (TestWebKitAPI::TEST):
841 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
842 (TestWebKitAPI::TEST):
843 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
844 (TestWebKitAPI::TEST):
845 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
846 (TestWebKitAPI::createTestValue):
847 (TestWebKitAPI::TEST):
848 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
849 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
850 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
851 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
852 (TestWebKitAPI::createNFAs):
853 (TestWebKitAPI::TEST_F):
854 * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
855 (TestWebKitAPI::combine):
856 * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
857 (TestWebKitAPI::createNFAs):
858 * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
860 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
861 (WebProcessTest::add):
863 2016-01-01 Michael Catanzaro <mcatanzaro@igalia.com>
865 [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
866 https://bugs.webkit.org/show_bug.cgi?id=152634
868 Reviewed by Carlos Garcia Campos.
870 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
871 (testLoadFromGResource): Added test.
873 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
874 (registerGResource): Added.
875 (webkit_web_extension_initialize_with_user_data): Load the test gresource.
876 * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
877 * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
879 2015-12-31 David Kilzer <ddkilzer@apple.com>
881 REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
882 <https://bugs.webkit.org/show_bug.cgi?id=152601>
884 Ignore unknown pragmas on older clangs. Fixes the following
887 Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
888 #pragma clang diagnostic ignored "-Wself-move"
892 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
893 (TestWebKitAPI::TEST):
894 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
895 (TestWebKitAPI::TEST):
897 2015-12-31 Andy Estes <aestes@apple.com>
899 Update the style checker to advise using WTFMove() instead of WTF::move()
900 https://bugs.webkit.org/show_bug.cgi?id=152601
902 Reviewed by Daniel Bates.
904 * Scripts/webkitpy/style/checkers/cpp.py:
906 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
907 (WebKitStyleTest.test_wtf_move):
909 2015-12-31 Andy Estes <aestes@apple.com>
911 Fix warnings uncovered by migrating to WTF_MOVE
912 https://bugs.webkit.org/show_bug.cgi?id=152601
914 Reviewed by Daniel Bates.
916 Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
917 self-move, even if doing so would trigger a warning.
919 * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
920 (TestWebKitAPI::TEST):
921 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
922 (TestWebKitAPI::TEST):
924 2015-12-31 Martin Robinson <mrobinson@igalia.com>
926 [GTK] The install-dependencies script has a syntax error
927 https://bugs.webkit.org/show_bug.cgi?id=152613
929 Reviewed by Michael Catanzaro.
931 * gtk/install-dependencies: Add the missing 'then.'
933 2015-12-30 Philippe Normand <pnormand@igalia.com>
935 [Mac][GTK] Jhbuild support for OSX
936 https://bugs.webkit.org/show_bug.cgi?id=150799
938 Reviewed by Michael Catanzaro.
940 * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
941 * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
942 * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
943 * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
945 2015-12-28 Michael Catanzaro <mcatanzaro@igalia.com>
947 Unreviewed, move Sebastian Dröge to committers list
949 He accidentally added himself to the reviewers list because the file is confusing.
951 * Scripts/webkitpy/common/config/contributors.json:
953 2015-12-24 Simon Fraser <simon.fraser@apple.com>
955 Remove the unused #define _USE_MATH_DEFINES
956 https://bugs.webkit.org/show_bug.cgi?id=152034
958 Reviewed by Tim Horton.
960 Update this test to use piDouble from MathExtras.h, and
961 std::numeric_limits<>.
963 * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
965 2015-12-24 Youenn Fablet <youenn.fablet@crf.canon.fr>
967 Python SCM should be able to retrieve untracked files - Generic changes
968 https://bugs.webkit.org/show_bug.cgi?id=152536
970 Reviewed by Brent Fulgham.
972 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
973 No support is yet added to GIT and SVN specific implementations.
975 * Scripts/webkitpy/common/checkout/scm/scm.py:
976 (SCM.untracked_files):
977 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
978 (SCMTest._shared_test_untracked_files):
980 2015-12-23 Dewei Zhu <dewei_zhu@apple.com>
982 SVN checkout used by RunBenchmark should be non-interactive
983 https://bugs.webkit.org/show_bug.cgi?id=152542
985 Reviewed by Ryosuke Niwa.
987 RunBenchmark should not require user interaction while running.
989 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
990 (BenchmarkBuilder._checkout_with_subversion):
992 2015-12-23 Brent Fulgham <bfulgham@apple.com>
994 Web Inspector: add support for running protocol-test.js tests on Windows
995 https://bugs.webkit.org/show_bug.cgi?id=148037
996 <rdar://problem/22292237>
998 Reviewed by Simon Fraser.
1000 * DumpRenderTree/win/TestRunnerWin.cpp:
1001 (TestRunner::inspectorTestStubURL): Provide implementation.
1003 2015-12-23 Eric Carlson <eric.carlson@apple.com>
1005 [MediaStream] MediaDeviceInfo.label must be empty in some situations
1006 https://bugs.webkit.org/show_bug.cgi?id=152000
1008 Reviewed by Brent Fulgham.
1010 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1011 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1012 (WTR::InjectedBundle::setUserMediaPermission):
1013 (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1014 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1016 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1017 (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1018 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1020 * WebKitTestRunner/TestController.cpp:
1021 (WTR::TestController::setUserMediaPermissionForOrigin):
1022 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1023 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add
1024 persistent permission for origin, that can be done from script now.
1025 * WebKitTestRunner/TestController.h:
1027 * WebKitTestRunner/TestInvocation.cpp:
1028 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1029 SetUserMediaPermissionForOrigin.
1031 2015-12-23 Brent Fulgham <bfulgham@apple.com>
1033 [Win] Unreviewed build fix: Recognize Windows 10 variants.
1035 * Scripts/webkitpy/common/system/platforminfo.py:
1036 (PlatformInfo._determine_win_version):
1038 2015-12-23 Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1040 Content blockers should be able to promote http to https
1041 https://bugs.webkit.org/show_bug.cgi?id=148966
1043 Reviewed by Benjamin Poulain.
1045 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1046 (WebCore::ContentExtensions::operator<<):
1047 (TestWebKitAPI::TEST_F):
1049 2015-12-22 Hunseop Jeong <hs85.jeong@samsung.com>
1051 [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1052 https://bugs.webkit.org/show_bug.cgi?id=152516
1054 Reviewed by Gyuyoung Kim.
1056 * MiniBrowser/efl/main.c:
1058 2015-12-22 Brent Fulgham <bfulgham@apple.com>
1060 Unreviewed: Add John Wilander as a contributor.
1062 * Scripts/webkitpy/common/config/contributors.json:
1064 2015-12-22 Chris Fleizach <cfleizach@apple.com>
1066 [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1067 https://bugs.webkit.org/show_bug.cgi?id=152482
1069 Reviewed by Brent Fulgham.
1071 vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1072 for the same property. On WK2, the element returned will not be valid, but is still present and
1073 that can lead to looping.
1075 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1076 (AccessibilityUIElement::horizontalScrollbar):
1077 (AccessibilityUIElement::verticalScrollbar):
1078 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1079 (WTR::AccessibilityUIElement::horizontalScrollbar):
1080 (WTR::AccessibilityUIElement::verticalScrollbar):
1082 2015-12-22 Xabier Rodriguez Calvar <calvaris@igalia.com>
1086 * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1088 2015-12-21 Hunseop Jeong <hs85.jeong@samsung.com>
1090 [EFL] test_ewk2_context failed after r192808
1091 https://bugs.webkit.org/show_bug.cgi?id=151846
1093 Reviewed by Gyuyoung Kim.
1095 Used the added ewk_context_web_process_count_limit_set api
1096 instead of the deprecated ewk_context_process_model_set.
1098 * MiniBrowser/efl/main.c:
1101 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
1103 Unreviewed, move myself to reviewer list.
1105 * Scripts/webkitpy/common/config/contributors.json:
1107 2015-12-21 Aakash Jain <aakash_jain@apple.com>
1109 Unreviewed, add myself to the committers list.
1111 * Scripts/webkitpy/common/config/contributors.json:
1113 2015-12-21 Michael Catanzaro <mcatanzaro@igalia.com>
1115 [GTK] jquery.min.js violates DFSG
1116 https://bugs.webkit.org/show_bug.cgi?id=152428
1118 Reviewed by Joseph Pecoraro.
1120 Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1121 into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1123 * gtk/manifest.txt.in:
1125 2015-12-19 Dan Bernstein <mitz@apple.com>
1127 [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1128 https://bugs.webkit.org/show_bug.cgi?id=152462
1130 Reviewed by Alexey Proskuryakov.
1132 - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1135 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1136 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1137 * MiniBrowser/Configurations/DebugRelease.xcconfig:
1138 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1139 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1141 - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1142 never getting compiled:
1144 * DumpRenderTree/mac/TextInputController.m:
1145 * MiniBrowser/mac/BrowserWindowController.m:
1146 * TestWebKitAPI/Tests/mac/AttributedString.mm:
1147 * WebKitTestRunner/mac/EventSenderProxy.mm:
1149 2015-12-18 Michael Catanzaro <mcatanzaro@igalia.com>
1151 Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1153 This is to make it easy to CC it on Bugzilla.
1155 * Scripts/webkitpy/common/config/contributors.json:
1157 2015-12-18 Aakash Jain <aakash_jain@apple.com>
1159 Pasteboard get messed up after running kill-old-processes
1160 https://bugs.webkit.org/show_bug.cgi?id=152426
1162 Reviewed by Alexey Proskuryakov.
1164 * BuildSlaveSupport/kill-old-processes:
1165 (main): Do not kill pasteboard anymore.
1167 2015-12-17 Aakash Jain <aakash_jain@apple.com>
1169 run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1170 https://bugs.webkit.org/show_bug.cgi?id=152157
1171 <rdar://problem/23851817>
1173 Reviewed by Alexey Proskuryakov.
1175 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1176 (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1177 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1178 (Manager._get_test_inputs): Common method to calculate test_inputs.
1179 (Manager._update_worker_count): Calculate and update required number of workers.
1181 2015-12-16 Aakash Jain <aakash_jain@apple.com>
1183 run-webkit-tests fails to delete Simulator device during cleanup
1184 https://bugs.webkit.org/show_bug.cgi?id=152363
1186 Reviewed by Alexey Proskuryakov.
1188 * Scripts/webkitpy/xcode/simulator.py:
1189 (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1191 2015-12-16 Tim Horton <timothy_horton@apple.com>
1193 [mac-wk2] fast/events force click tests crashing
1194 https://bugs.webkit.org/show_bug.cgi?id=152339
1196 Reviewed by Beth Dakin.
1198 * WebKitTestRunner/mac/EventSenderProxy.mm:
1199 (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1200 Set the NSEvent's _type member in addition to overriding -type,
1201 because there are assertions in touch event handling code that depend on it.
1203 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1205 Enforce temporarily bots to sync WebKit and WPT testharness.js
1206 https://bugs.webkit.org/show_bug.cgi?id=152334
1208 Reviewed by Darin Adler.
1210 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1211 (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1213 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1215 [Fetch API] Add fetch API compile time flag
1216 https://bugs.webkit.org/show_bug.cgi?id=152254
1218 Reviewed by Darin Adler.
1220 * Scripts/webkitperl/FeatureList.pm:
1222 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1226 Added files that have impact in building Streams API to the watchlist.
1228 * Scripts/webkitpy/common/config/watchlist:
1230 2015-12-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
1234 Added imported tests to Streams API watchlist.
1236 * Scripts/webkitpy/common/config/watchlist:
1238 2015-12-16 Youenn Fablet <youenn.fablet@crf.canon.fr>
1240 Remove default copy of wpt testharness.js when launching wpt server
1241 https://bugs.webkit.org/show_bug.cgi?id=152298
1243 Reviewed by Darin Adler.
1245 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1246 (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1248 2015-12-15 David Kilzer <ddkilzer@apple.com>
1250 REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1251 <http://webkit.org/b/152314>
1253 Reviewed by Daniel Bates.
1255 The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1256 code path to exit immediately when calling main().
1257 Unfortunately, DumpRenderTreeMain.mm was used for both
1258 DumpRenderTree command-line binary and DumpRenderTree.app, which
1259 meant that the app would exit immediately with no error code
1262 The workaround is to introduce a separate source file called
1263 DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1266 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1267 DumpRenderTreeAppMain.mm to the project. Make it the only
1268 compiled source for the DumpRenderTree.app target.
1269 * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1270 (main): Call DumpRenderTreeMain() on iOS. Assert on OS X in
1271 case someone tries mistakenly to use the app.
1272 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1273 Link to JavaScriptCore.framework on iOS for the assert.
1274 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1275 Link to JavaScriptCore.framework on OS X for the assert. Remove
1276 unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1277 * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1278 (main): Add assert for iOS so that a crash occurs if someone
1279 tries to run the wrong command.
1281 2015-12-14 Tim Horton <timothy_horton@apple.com>
1283 Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1284 https://bugs.webkit.org/show_bug.cgi?id=152266
1285 <rdar://problem/22092676>
1287 Reviewed by Simon Fraser.
1289 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1290 * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1291 Add a test that crashed before this change, and doesn't crash after.
1293 2015-12-14 Chris Fleizach <cfleizach@apple.com>
1295 AX: iOS: Text field variations do not have the correct traits
1296 https://bugs.webkit.org/show_bug.cgi?id=152237
1298 Reviewed by Mario Sanchez Prada.
1300 Add iOS calls for determing if an object is a search field or a text area.
1302 * DumpRenderTree/AccessibilityUIElement.cpp:
1303 (getIsSearchFieldCallback):
1304 (getIsTextAreaCallback):
1305 (stringForSelectionCallback):
1306 (AccessibilityUIElement::getJSClass):
1307 * DumpRenderTree/AccessibilityUIElement.h:
1308 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1309 (AccessibilityUIElement::identifier):
1310 (AccessibilityUIElement::isTextArea):
1311 (AccessibilityUIElement::isSearchField):
1312 (AccessibilityUIElement::traits):
1313 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1314 (WTR::AccessibilityUIElement::scrollPageRight):
1315 (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1316 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1317 (WTR::AccessibilityUIElement::isSearchField):
1318 (WTR::AccessibilityUIElement::isTextArea):
1319 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1320 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1321 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1322 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1323 (WTR::AccessibilityUIElement::isTextArea):
1324 (WTR::AccessibilityUIElement::isSearchField):
1325 (WTR::AccessibilityUIElement::rowCount):
1327 2015-12-14 Carlos Alberto Lopez Perez <clopez@igalia.com>
1329 [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1330 https://bugs.webkit.org/show_bug.cgi?id=152252
1332 Reviewed by Sergio Villar Senin.
1334 * gtk/install-dependencies: Add libtool-bin to the list of packages required
1335 for building the JHBuild on Debian systems.
1337 2015-12-11 Joseph Pecoraro <pecoraro@apple.com>
1339 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1340 https://bugs.webkit.org/show_bug.cgi?id=152156
1342 Reviewed by Dan Bernstein.
1344 Our frameworks should appropriately prefix all ObjC classes,
1345 not just external symbols.
1347 * Scripts/check-for-inappropriate-objc-class-names:
1348 Remove the -g switch to check all ObjC class names.
1350 2015-12-10 Eric Carlson <eric.carlson@apple.com>
1352 [MediaStream] Expose media capture devices persistent permissions to WebCore
1353 https://bugs.webkit.org/show_bug.cgi?id=152087
1355 Add support for the new user media permission checker page UI client method.
1357 Reviewed by Chris Dumez.
1359 * WebKitTestRunner/TestController.cpp:
1360 (WTR::decidePolicyForUserMediaPermissionRequest):
1361 (WTR::checkUserMediaPermissionForOrigin):
1362 (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1363 (WTR::TestController::createWebViewWithOptions): Ditto.
1364 (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1365 (WTR::originUserVisibleName): New, create a string for the origin.
1366 (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1367 according to the state of the origin permission map.
1368 (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1369 request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1370 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1371 origin permission map.
1372 * WebKitTestRunner/TestController.h:
1374 2015-12-10 Alex Christensen <achristensen@webkit.org>
1376 REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1377 https://bugs.webkit.org/show_bug.cgi?id=152022
1378 rdar://problem/23763584
1380 Reviewed by Darin Adler.
1382 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1383 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1384 (WTR::InjectedBundlePage::willSendRequestForFrame):
1385 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1386 (WTR::TestRunner::setWillSendRequestReturnsNull):
1387 (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1388 (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1389 (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1390 (WTR::TestRunner::willSendRequestHTTPBody):
1391 Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1393 2015-12-10 Aakash Jain <aakash_jain@apple.com>
1395 Remove additional simulator checks before running layout-tests
1396 https://bugs.webkit.org/show_bug.cgi?id=152146
1398 Reviewed by Darin Adler.
1400 * Scripts/webkitpy/port/ios.py:
1401 (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1402 * Scripts/webkitpy/xcode/simulator.py:
1403 (Simulator._boot_and_shutdown_simulator_device): Deleted.
1404 (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1406 2015-12-09 Aakash Jain <aakash_jain@apple.com>
1408 Run atleast one simulator even if max process limit is low
1409 https://bugs.webkit.org/show_bug.cgi?id=152081
1410 <rdar://problem/23819694>
1412 Reviewed by Alexey Proskuryakov.
1414 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
1416 [GTK] Crash in WebProcess when loading large content with custom URI schemes
1417 https://bugs.webkit.org/show_bug.cgi?id=144262
1419 Reviewed by Carlos Garcia Campos.
1421 Added new unit test to check the additional scenarios we now
1422 handle for custom URI schemes.
1424 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1425 (generateHTMLContent): New helper function to generate big enough content.
1426 (testWebContextURIScheme): New unit test.
1428 2015-12-09 Ryuan Choi <ryuan.choi@navercorp.com>
1430 [EFL] Fix unhandled web process message when launching MiniBrowser
1431 https://bugs.webkit.org/show_bug.cgi?id=152048
1433 Reviewed by Gyuyoung Kim.
1435 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1436 (TestWebKitAPI::TEST):
1438 2015-12-09 Carlos Garcia Campos <cgarcia@igalia.com>
1440 [GTK] Add API to handle beforeunload events
1441 https://bugs.webkit.org/show_bug.cgi?id=139090
1443 Reviewed by Gustavo Noronha Silva.
1445 * MiniBrowser/gtk/BrowserWindow.c:
1446 (browserWindowConstructed):
1447 (browserWindowDeleteEvent):
1448 (browser_window_class_init):
1449 Handle delete-event to prevent the window from being closed when
1450 the page has beforeunload handlers. Use
1451 webkit_web_view_try_close() when the window is requested to be
1453 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1454 (testWebViewJavaScriptDialogs):
1455 Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1458 2015-12-09 Mario Sanchez Prada <mario@endlessm.com>
1460 Refactored initialization code in LoadTrackingTest.
1462 Rubber-stamped by Carlos Garcia Campos.
1464 Small refactoring to make sure that the state of a LoadTrackingTest
1465 gets properly reset before loading new web content.
1467 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1468 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1469 (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1470 functions and reset the remaining local variables.
1471 (LoadTrackingTest::loadURI): Call reset();
1472 (LoadTrackingTest::loadHtml): Ditto.
1473 (LoadTrackingTest::loadPlainText): Ditto.
1474 (LoadTrackingTest::loadBytes): Ditto.
1475 (LoadTrackingTest::loadRequest): Ditto.
1476 (LoadTrackingTest::reload): Ditto.
1477 (LoadTrackingTest::goBack): Ditto.
1478 (LoadTrackingTest::goForward): Ditto.
1480 2015-12-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1482 [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1483 https://bugs.webkit.org/show_bug.cgi?id=151942
1485 Reviewed by Darin Adler.
1487 * MiniBrowser/efl/main.c:
1488 (window_create): Enable offline web application cache feature on MiniBrowser.
1491 2015-12-08 Aakash Jain <aakash_jain@apple.com>
1493 https://bugs.webkit.org/show_bug.cgi?id=151243
1494 <rdar://problem/22955197>
1496 Reviewed by Alexey Proskuryakov.
1498 * LayoutTestRelay/LayoutTestRelay/main.m:
1499 (getTestingSimDevice): Use separate testing device for each worker.
1500 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1501 (Manager.run): Perform cleanup even if setup fails.
1502 * Scripts/webkitpy/port/ios.py:
1503 (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1504 (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1505 (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1506 (IOSSimulatorPort._quit_ios_simulator): Same
1507 (IOSSimulatorPort.clean_up_test_run): Same
1508 (IOSSimulatorPort.check_sys_deps): Same
1509 (IOSSimulatorPort.testing_device): Same
1510 (IOSSimulatorPort.reset_preferences): Same
1511 (IOSSimulatorPort.get_simulator_path): Return simulator path.
1512 (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1513 * Scripts/webkitpy/xcode/simulator.py:
1514 (Device.delete): Delete the simulator device.
1515 (Simulator.delete_device): Same
1516 (Simulator.wait_until_device_is_booted): Wait for device booting.
1518 2015-12-08 Ryuan Choi <ryuan.choi@navercorp.com>
1520 [EFL] Add API to provide preferences before creating ewk_view
1521 https://bugs.webkit.org/show_bug.cgi?id=151587
1523 Reviewed by Gyuyoung Kim.
1525 * MiniBrowser/efl/main.c:
1529 Moved settings related code to configuration() not to update settings
1530 whenever ewk_view is created.
1534 2015-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
1536 Unreviewed. Fix GTK+ API tests after r193639.
1538 The new jhbuild version needs some more variables ot be present in
1539 the builtin dict, even if they are set to None.
1541 * jhbuild/jhbuildutils.py:
1542 (enter_jhbuild_environment_if_available):
1544 2015-12-07 Gustavo Noronha Silva <gns@gnome.org>
1546 [GTK] Notify WebCore when notification is clicked
1547 https://bugs.webkit.org/show_bug.cgi?id=151951
1549 Reviewed by Carlos Garcia Campos.
1551 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1552 (testWebViewNotification): test the new API.
1554 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
1556 'jhbuild build' should fail immediately when building any module fails
1557 https://bugs.webkit.org/show_bug.cgi?id=145697
1559 Reviewed by Carlos Garcia Campos.
1561 * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1562 * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1563 Everything is placed under lib instead of lib64 now.
1564 * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1565 --exit-on-error when running 'jhbuild build'.
1566 * jhbuild/jhbuildrc_common.py:
1567 (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1568 jhbuild should be able to handle these for us without breaking things....
1570 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
1572 Add support to import w3c tests from a repository with a different root that the main repo dir
1573 https://bugs.webkit.org/show_bug.cgi?id=151751
1575 Reviewed by Ryosuke Niwa and Youenn Fablet.
1577 We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1578 in a different directory than the repository root.
1580 This patch introduces a new parameter tests_directory that we will use as root directory to search for
1581 tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1582 requires having the copy_path lists including tuples of origin and destination directories.
1584 * Scripts/webkitpy/w3c/test_downloader.py:
1585 (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1586 (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1587 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1588 (TestImporterTest.test_tests_directory): Test.
1590 2015-12-07 Xabier Rodriguez Calvar <calvaris@igalia.com>
1592 Mock TestRepositories in W3C importer tests
1593 https://bugs.webkit.org/show_bug.cgi?id=151938
1595 Reviewed by Youenn Fablet.
1597 The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1598 is because the test repository method reading the file was using the filesystem directly instead of taking the
1599 host one. This patch changes that.
1601 * Scripts/webkitpy/w3c/test_downloader.py:
1602 (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1604 (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1605 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1606 (TestImporterTest.test_harnesslinks_conversion):
1607 (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1609 2015-12-07 David Kilzer <ddkilzer@apple.com>
1611 TestNetscapePlugIn: Address review comment on 193607
1612 <http://webkit.org/b/151881>
1614 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1615 (testSetStatus): Initializing std::unique_ptr<char[]> with
1616 nullptr is redundant.
1618 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
1620 [GTK] Add webkit_uri_request_get_http_method
1621 https://bugs.webkit.org/show_bug.cgi?id=151601
1623 Reviewed by Martin Robinson.
1625 Add test case to check HTTP method of WebKitURIRequest.
1627 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1628 (testURIRequestHTTPMethod):
1631 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1632 (sendRequestCallback):
1634 2015-12-07 Carlos Garcia Campos <cgarcia@igalia.com>
1636 [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1637 https://bugs.webkit.org/show_bug.cgi?id=79918
1639 Reviewed by Gustavo Noronha Silva.
1641 Add unit tests to check the different console messages.
1643 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1644 * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1645 (ConsoleMessageTest::ConsoleMessage::operator==):
1646 (ConsoleMessageTest::consoleMessageReceivedCallback):
1647 (ConsoleMessageTest::ConsoleMessageTest):
1648 (ConsoleMessageTest::~ConsoleMessageTest):
1649 (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1650 (testWebKitConsoleMessageConsoleAPI):
1651 (testWebKitConsoleMessageJavaScriptException):
1652 (testWebKitConsoleMessageNetworkError):
1653 (testWebKitConsoleMessageSecurityError):
1656 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1657 (consoleMessageSentCallback):
1658 (pageCreatedCallback):
1660 2015-12-07 Ryuan Choi <ryuan.choi@navercorp.com>
1662 [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1663 https://bugs.webkit.org/show_bug.cgi?id=151934
1665 Reviewed by Csaba Osztrogonác.
1667 * MiniBrowser/efl/main.c:
1668 (on_window_deletion): Revert the changes of r192767.
1670 2015-12-07 Michael Catanzaro <mcatanzaro@igalia.com>
1672 [GTK] update-webkitgtk-libs cannot build mesa
1673 https://bugs.webkit.org/show_bug.cgi?id=151535
1675 Reviewed by Martin Robinson.
1677 Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1678 dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1679 on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1680 does not have a stable API and we cannot expect mesa to be buildable unless we control the
1681 LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1682 --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1684 * gtk/jhbuild.modules:
1686 2015-12-07 Philippe Normand <pnormand@igalia.com>
1688 [GTK][Mac] libWebExtensionTest link error
1689 https://bugs.webkit.org/show_bug.cgi?id=150802
1691 Reviewed by Carlos Garcia Campos.
1693 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1695 2015-12-06 David Kilzer <ddkilzer@apple.com>
1697 TestNetscapePlugIn: Fix leaks found by static analyzer
1698 <http://webkit.org/b/151881>
1700 Reviewed by Darin Adler.
1702 Fixes the following leaks found by the static analyzer:
1703 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1706 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1709 DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1713 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1714 (toCString): Switch to returning std::unique_ptr<char[]>. Add
1715 early return if allocation fails.
1716 (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1717 Make sure to call fclose() on filehandle, even for an early
1719 (testSetStatus): Switch to using std::unique_ptr<char[]>.
1721 2015-12-05 David Kilzer <ddkilzer@apple.com>
1723 prepare-ChangeLog: Fix some warning messages when using svn
1724 <http://webkit.org/b/151914>
1726 Reviewed by Daniel Bates.
1728 * Scripts/prepare-ChangeLog:
1729 (generateFunctionLists): Simplify logic so that we never call
1730 normalizePath() with an undefined value.
1731 (attributeCommand): Quote $subPath for the shell so that we
1732 don't try to run "svn propget" on invalid paths.
1734 2015-12-04 David Kilzer <ddkilzer@apple.com>
1736 TestNetscapePlugIn: Fix remaining static analyzer warnings
1737 <http://webkit.org/b/151888>
1739 Reviewed by Alexey Proskuryakov.
1741 Fixes the following static analyzer warnings:
1742 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1745 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1746 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1748 Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1749 return obj->pluginTest->NPP_SetWindow(window);
1751 2 warnings generated.
1753 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1754 (CRASH): Use __builtin_trap() for gcc/clang.
1755 (NPP_SetWindow): Add early return if obj is nullptr.
1757 2015-12-03 Carlos Garcia Campos <cgarcia@igalia.com>
1759 [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1760 https://bugs.webkit.org/show_bug.cgi?id=151797
1762 Reviewed by Martin Robinson.
1764 Since we switched to use the network process to run the unit tests
1765 the test /webkit2/WebKitWebResource/get-data sometimes fails and
1766 sometimes passes. We are now also getting the notification for the
1767 css image. Since we wait for 3 resources, sometimes the css image
1768 is loaded before and then checkResourceData is called for it, but
1769 not handled. When the css image is the last one loaded the test
1770 passes. So, we just need to wait for the 4 resources.
1772 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1773 (testWebResourceGetData):
1775 2015-12-03 David Kilzer <ddkilzer@apple.com>
1777 DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1778 <http://webkit.org/b/151845>
1780 Reviewed by Simon Fraser.
1782 Fixes the following static analyzer warning:
1783 DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1784 WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1785 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1787 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1788 (createBitmapContext): Free 'buffer' after using it in logging
1789 to fix the use-after-free. Assign a value of nullptr to buffer
1790 so we don't return with it set to a freed address.
1792 2015-12-03 Jer Noble <jer.noble@apple.com>
1794 Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1795 https://bugs.webkit.org/show_bug.cgi?id=151830
1797 Reviewed by Anders Carlsson.
1799 Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1801 * DumpRenderTree/mac/DumpRenderTree.mm:
1802 (resetWebPreferencesToConsistentValues):
1803 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1804 (WTR::initializeWebViewConfiguration):
1806 2015-12-03 Anders Carlsson <andersca@apple.com>
1808 Remove Objective-C GC support
1809 https://bugs.webkit.org/show_bug.cgi?id=151819
1810 rdar://problem/23746991
1812 Reviewed by Dan Bernstein.
1814 * asan/asan.xcconfig:
1816 2015-12-02 Yusuke Suzuki <utatane.tea@gmail.com>
1818 Allow nil for unspecified benchmark pathes
1819 https://bugs.webkit.org/show_bug.cgi?id=151784
1821 Reviewed by Filip Pizlo.
1823 `Pathname.new(nil)` will raise an error.
1824 Only generate Pathname if the benchmark path is specified.
1826 * Scripts/run-jsc-benchmarks:
1828 2015-12-02 Brent Fulgham <bfulgham@apple.com>
1830 [Win] Run non-http tests without Cygwin
1831 https://bugs.webkit.org/show_bug.cgi?id=151721
1833 Reviewed by Andy Estes.
1835 Support native 32-bit and 64-bit Python (and Perl) builds
1838 1. Use "startswith('win')", rather than "== 'win32'" to support
1839 various Windows build types.
1840 2. Supply full path for some native Windows utilities, since the
1841 path environment does not always have the specified, and they are
1842 guaranteed to exist in those specific locations.
1843 3. Make sure native Windows Python test runs pass proper environment
1844 variables to run programs.
1845 4. Append 'exe' suffix when running Windows executables.
1846 5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1847 command doesn't exist.
1849 * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1850 the current Perl executable, rather than requiring a new path search.
1851 * Scripts/webkitpy/common/find_files_unittest.py:
1852 (TestWinNormalize.test_win): Use startswith('win').
1853 * Scripts/webkitpy/common/prettypatch_unittest.py:
1854 (test_pretty_diff_encodings): Ditto.
1855 * Scripts/webkitpy/common/system/executive.py:
1856 (Executive._should_close_fds): Ditto.
1857 (Executive.shell_command_for_script): Use startswith('win').
1858 (Executive.kill_process): Use full path to killall executable.
1859 (Executive.check_running_pid): Use startswith('win').
1860 (Executive.running_pids): Ditto.
1861 (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1862 running under native Windows Python.
1863 (Executive._child_process_encoding): Use startswith('win').
1864 (Executive._should_encode_child_process_arguments): Ditto.
1865 (Executive.popen): Recognize proper script engine on Windows, since it
1866 does not support the shebang syntax.
1867 (Executive.run_in_parallel): Use startswith('win').
1868 * Scripts/webkitpy/common/system/executive_unittest.py:
1869 (never_ending_command): Ditto.
1870 (ExecutiveTest.test_run_command_with_unicode): Ditto.
1871 (ExecutiveTest.serial_test_kill_process): Ditto.
1872 (ExecutiveTest.serial_test_kill_all): Ditto.
1873 (ExecutiveTest.serial_test_check_running_pid): Ditto.
1874 (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1876 * Scripts/webkitpy/common/system/file_lock.py:
1877 (FileLock._create_lock): Ditto.
1878 (FileLock._remove_lock): Ditto.
1879 * Scripts/webkitpy/common/system/filesystem_unittest.py:
1880 (RealFileSystemTest.test_chdir): Ditto.
1881 (RealFileSystemTest.test_chdir__notexists): Ditto.
1882 (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1883 * Scripts/webkitpy/common/system/path_unittest.py:
1884 (AbspathTest.test_abspath_to_uri_win): Ditto.
1885 * Scripts/webkitpy/common/system/platforminfo.py:
1886 (PlatformInfo._determine_os_name): Ditto.
1887 * Scripts/webkitpy/common/system/user.py: Ditto.
1888 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1889 (ManagerTest.integration_test_needs_servers): Ditto.
1890 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1891 (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1893 (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1894 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1895 (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1896 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1897 (HttpServerBase._check_that_all_ports_are_available): Ditto.
1898 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1899 (TestHttpServer.test_start_cmd): Ditto.
1900 * Scripts/webkitpy/port/base.py:
1901 (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1902 and 'SYSTEMROOT' in environment passed to test runners.
1903 (Port._apache_config_file_name_for_platform): Use startswith('win').
1904 (Port._build_path): Ditto.
1905 (Port._path_to_driver): Include 'exe' suffix when running under native
1907 * Scripts/webkitpy/port/driver.py:
1908 (Driver._setup_environ_for_driver): Explicitly make some environment
1910 * Scripts/webkitpy/port/server_process.py:
1911 (ServerProcess.__init__): Use startswith('win').
1912 * Scripts/webkitpy/port/win.py:
1913 (WinPort): Use the win32 registry utilities on Windows, and appropriate
1914 registry key formats.
1915 (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1916 (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1917 and regtool on Cygwin.
1918 (WinPort.write_registry_value): Ditto.
1919 (WinPort.setup_crash_log_saving): Ditto.
1920 (WinPort.restore_crash_log_saving): Ditto.
1921 (WinPort.prevent_error_dialogs): Ditto.
1922 (WinPort.allow_error_dialogs): Ditto.
1923 (WinPort.find_system_pid): Revise to use Windows management
1924 infrastructure on native Windows, continue using 'ps' on Cygwin.
1925 (WinPort.read_registry_string): Deleted.
1926 (WinPort.write_registry_string): Deleted.
1927 * Scripts/webkitpy/test/main.py:
1928 (main): Use startswith('win').
1929 (Tester._parse_args): Ditto.
1931 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
1933 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1934 https://bugs.webkit.org/show_bug.cgi?id=150792
1936 Reviewed by Saam Barati.
1938 * Scripts/webkitperl/FeatureList.pm:
1940 2015-12-01 Commit Queue <commit-queue@webkit.org>
1942 Unreviewed, rolling out r192914.
1943 https://bugs.webkit.org/show_bug.cgi?id=151734
1945 JSC tests for this change are failing on 32 and 64-bit bots
1946 (Requested by ryanhaddad on #webkit).
1950 "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1951 enable this feature"
1952 https://bugs.webkit.org/show_bug.cgi?id=150792
1953 http://trac.webkit.org/changeset/192914
1955 2015-12-01 David Kilzer <ddkilzer@apple.com>
1957 EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1958 <http://webkit.org/b/151726>
1960 Reviewed by Simon Fraser.
1962 * WebKitTestRunner/mac/EventSenderProxy.mm:
1963 (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1964 Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1966 2015-12-01 Myles C. Maxfield <mmaxfield@apple.com>
1968 Give String and AtomicString an existingHash() function
1969 https://bugs.webkit.org/show_bug.cgi?id=151717
1971 Reviewed by Andreas Kling.
1973 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1974 (TestWebKitAPI::TEST):
1975 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1976 (TestWebKitAPI::TEST):
1978 2015-12-01 Yusuke Suzuki <utatane.tea@gmail.com>
1980 [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1981 https://bugs.webkit.org/show_bug.cgi?id=150792
1983 Reviewed by Saam Barati.
1985 * Scripts/webkitperl/FeatureList.pm:
1987 2015-12-01 Sam Weinig <sam@webkit.org>
1989 Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1990 <rdar://problem/23320863>
1991 https://bugs.webkit.org/show_bug.cgi?id=151708
1993 Reviewed by Anders Carlsson.
1995 * WebKitTestRunner/TestController.cpp:
1996 (WTR::TestController::createOtherPage):
1997 (WTR::TestController::createWebViewWithOptions):
1998 Update for new WKPageUIClient.
2000 2015-12-01 Anders Carlsson <andersca@apple.com>
2002 Remove WebKit2.framework
2003 https://bugs.webkit.org/show_bug.cgi?id=151715
2005 Reviewed by Dan Bernstein.
2007 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2008 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2009 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2010 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2011 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2012 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2013 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2015 2015-12-01 Joseph Pecoraro <pecoraro@apple.com>
2017 Unreviewed common typo fix "occurance" => "occurrence".
2019 * Scripts/webkitpy/tool/commands/queries.py:
2020 (FindFlakyTests._print_statistics):
2022 2015-11-30 Alex Christensen <achristensen@webkit.org>
2024 Make ProcessModel always MultipleSecondaryProcesses
2025 https://bugs.webkit.org/show_bug.cgi?id=151662
2027 Reviewed by Antti Koivisto.
2029 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2030 (TestWebKitAPI::TEST):
2031 * WebKitTestRunner/TestController.cpp:
2032 (WTR::TestController::generatePageConfiguration):
2034 2015-11-30 Alex Christensen <achristensen@webkit.org>
2036 Make usesNetworkProcess always true
2037 https://bugs.webkit.org/show_bug.cgi?id=151580
2039 Reviewed by Darin Adler.
2041 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2042 (TestWebKitAPI::TEST):
2043 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2044 (TestWebKitAPI::TEST):
2045 * WebKitTestRunner/TestController.cpp:
2046 (WTR::TestController::generatePageConfiguration):
2048 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
2050 Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2052 Add a way to skip unit tests only for Debug or Release builds and
2053 skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2055 * Scripts/run-gtk-tests:
2057 (SkippedTest.__init__):
2058 (SkippedTest.__str__):
2059 (SkippedTest.skip_entire_suite):
2060 (SkippedTest.skip_for_build_type):
2062 (TestRunner.__init__):
2064 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
2066 Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2068 It's an assert hit because we are reloading a view loaded with
2069 HTML data which is not supported. Use loadURI instead.
2071 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2072 (testWebViewCustomCharset):
2074 2015-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
2076 [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2077 https://bugs.webkit.org/show_bug.cgi?id=151633
2079 Reviewed by Csaba Osztrogonác.
2081 * TestWebKitAPI/PlatformGTK.cmake:
2082 * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2084 2015-11-27 Carlos Garcia Campos <cgarcia@igalia.com>
2086 [GTK] Remove the remaining uses of GMainLoopSource
2087 https://bugs.webkit.org/show_bug.cgi?id=151632
2089 Reviewed by Žan Doberšek.
2091 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2092 (testWebViewSyncRequestOnMaxConns):
2093 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2094 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2095 (WTR::TestRunner::TestRunner):
2096 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2097 * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2098 (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2099 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2100 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2101 (WTR::timeoutSource):
2102 (WTR::TestController::notifyDone):
2103 (WTR::TestController::platformRunUntil):
2105 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
2107 [cmake] Add testb3 to the build system
2108 https://bugs.webkit.org/show_bug.cgi?id=151619
2110 Reviewed by Gyuyoung Kim.
2112 * Scripts/build-jsc:
2114 2015-11-27 Csaba Osztrogonác <ossy@webkit.org>
2116 [jhbuild] Fix pixman build with clang
2117 https://bugs.webkit.org/show_bug.cgi?id=151441
2119 Reviewed by Carlos Garcia Campos.
2121 * efl/jhbuild.modules:
2122 * gtk/jhbuild.modules:
2124 2015-11-26 David Kilzer <ddkilzer@apple.com>
2126 Extract prependToEnvironmentVariableList
2127 <http://webkit.org/b/151536>
2129 Reviewed by Daniel Bates.
2131 Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2132 webkitdirs_unittest/prependToEnvironmentVariableList.pl
2134 * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2135 and prependToEnvironmentVariableList.
2136 (appendToEnvironmentVariableList): Simplify variable name.
2137 Switch to use $Config{path_sep}.
2138 (prependToEnvironmentVariableList): Add new method.
2139 (setupMacWebKitEnvironment): Switch to use
2140 prependToEnvironmentVariableList().
2141 (setupIOSWebKitEnvironment): Ditto.
2143 * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2144 * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2146 2015-11-24 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2148 REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2149 https://bugs.webkit.org/show_bug.cgi?id=151567
2151 Reviewed by Darin Adler.
2153 * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2154 (on_window_deletion):
2156 2015-11-23 Carlos Garcia Campos <cgarcia@igalia.com>
2158 [GTK] Use the network process unconditionally
2159 https://bugs.webkit.org/show_bug.cgi?id=151541
2161 Reviewed by Alex Christensen.
2163 Fix TestInspectorServer test. Do not assume we already have the
2164 title we want when the page has been loaded, since the title is
2165 changed afterwards. So, check if the title has already been set,
2166 and if not wait for it.
2168 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2169 (openRemoteDebuggingSession):
2171 2015-11-23 Alex Christensen <achristensen@webkit.org>
2173 Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2174 https://bugs.webkit.org/show_bug.cgi?id=151532
2176 Reviewed by Benjamin Poulain.
2178 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2179 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2180 (TestWebKitAPI::TEST):
2181 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2182 (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2183 (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2184 Properly load about:blank in all WebViews to clean up. Without this change, we had a
2185 Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2186 so it was calling a function on a test object that had gone out of scope.
2187 Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2188 but that will become the default soon and that call will be removed.
2190 2015-11-22 David Kilzer <ddkilzer@apple.com>
2192 run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2193 <http://webkit.org/b/151542>
2195 Reviewed by Daniel Bates.
2197 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2198 (base_url): Use the Port object (already passed in) to give us
2199 the path to the LayoutTests directory, which already checks for a
2200 --layout-tests-directory command-line switch.
2201 (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2202 argument since we can get this from the Port object already
2203 passed in via Port.results_directory(). Also switch to use
2204 Port.layout_tests_dir() to get the LayoutTests directory.
2206 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2207 (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2208 Add test case for custom LayoutTests directory.
2209 (TestWebPlatformTestServer.test_previously_spawned_instance):
2210 Update Port object to set mock results directory as if it was
2211 set on the command-line. Remove unneeded argument from
2212 WebPlatformTestServer constructor.
2213 (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2215 * Scripts/webkitpy/port/base.py:
2216 (Port.to.start_web_platform_test_server): Remove unneeded
2217 argument from WebPlatformTestServer constuctor.
2219 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
2221 [GTK] Some unit tests fail when using the network process
2222 https://bugs.webkit.org/show_bug.cgi?id=151490
2224 Reviewed by Martin Robinson.
2226 Run the soup server in a separate thread in TestResources test to
2229 This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2230 /webkit2/WebKitWebResource/get-data when using the network process.
2232 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2233 (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2234 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2235 (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2236 present, create a WorkQueue to run the server.
2237 (WebKitTestServer::run): Run the server in the work queue if it
2239 * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2240 type into server options as flags.
2242 2015-11-22 Carlos Garcia Campos <cgarcia@igalia.com>
2244 [GTK] ImageDiff should normalize the diff image
2245 https://bugs.webkit.org/show_bug.cgi?id=151261
2247 Reviewed by Sergio Villar Senin.
2249 * ImageDiff/gtk/ImageDiff.cpp:
2250 (readPixbufFromStdin): Fix memory leak.
2251 (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2252 (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2254 == Rolled over to ChangeLog-2015-11-21 ==