[Chromium] Unreviewed build fix, do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
[WebKit-https.git] / Tools / ChangeLog
1 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
2
3         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
4         until the port begins using those export macros.
5
6         * DumpRenderTree/chromium/config.h:
7
8 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
9
10         Unreviewed, rolling out r87257.
11         http://trac.webkit.org/changeset/87257
12         https://bugs.webkit.org/show_bug.cgi?id=61457
13
14         This broke layout tests, see bug 61431. (Requested by
15         hwennborg on #webkit).
16
17         * DumpRenderTree/chromium/LayoutTestController.cpp:
18         (LayoutTestController::LayoutTestController):
19         (LayoutTestController::clearAllDatabases):
20         * DumpRenderTree/chromium/LayoutTestController.h:
21
22 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
23
24         Reviewed by Andreas Kling.
25
26         [Qt] fast/css/disabled-author-styles.html failed
27         https://bugs.webkit.org/show_bug.cgi?id=61438
28
29         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
30
31         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
32         (WebCore::WebPage::resetSettings):
33         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
34         (LayoutTestController::setAuthorAndUserStylesEnabled):
35         * DumpRenderTree/qt/LayoutTestControllerQt.h:
36
37 2011-05-25  Adam Roben  <aroben@apple.com>
38
39         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
40
41         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
42         started exiting early due to too many crashes, timeouts, or failures
43
44         Reviewed by David Kilzer.
45
46         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
47         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
48         run-webkit-tests exits early due to too many failures, pass that information in another
49         argument to the callback.
50         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
51         the new structure of the object passed to the callback.
52         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
53         getNumberOfFailingTests and to pass that along to our own callbacks.
54         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
55         from _getFailingTests and to store that value in the history object.
56
57         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
58         (.info): Added.
59
60         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
61         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
62         object and to add a note when run-webkit-tests exited early due to too many failures.
63         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
64         latestBuildInfos since each entry now contains more than just the tester and failure count.
65         Now displays a message for testers where the latest build exited early due to too many
66         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
67         store that value in latestBuildInfos.
68
69 2011-05-24  Keishi Hattori  <keishi@webkit.org>
70
71         Reviewed by Kent Tamura.
72
73         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
74         https://bugs.webkit.org/show_bug.cgi?id=61273
75
76         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
77
78 2011-05-24  Greg Simon  <gregsimon@chromium.org>
79
80         Reviewed by Dimitri Glazkov.
81
82         Control Indexeddb backends from LayoutTestController
83         https://bugs.webkit.org/show_bug.cgi?id=61000
84
85         * DumpRenderTree/chromium/LayoutTestController.cpp:
86         (LayoutTestController::LayoutTestController):
87         (LayoutTestController::setOverrideIndexedDBBackingStore):
88         (LayoutTestController::clearAllDatabases):
89         * DumpRenderTree/chromium/LayoutTestController.h:
90
91 2011-05-24  Robert Hogan  <robert@webkit.org>
92
93         Reviewed by Ryosuke Niwa.
94
95         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
96         https://bugs.webkit.org/show_bug.cgi?id=61393
97
98         * DumpRenderTree/qt/EventSenderQt.h:
99         * DumpRenderTree/qt/EventSenderQt.cpp:
100         (getModifiers): static function for interpreting modifiers
101         (EventSender::mouseDown): Respect keyboard modifiers
102         (EventSender::keyDown): use new static function
103         (EventSender::sendOrQueueEvent): whitespace fix
104
105 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
106
107         Reviewed by Adam Barth.
108
109         Adding MHTML reading support.
110         https://bugs.webkit.org/show_bug.cgi?id=7168
111
112         * Scripts/build-webkit:
113         * Scripts/old-run-webkit-tests:
114         * Scripts/webkitperl/features.pm:
115         * Scripts/webkitpy/layout_tests/port/test_files.py:
116         * Scripts/webkitpy/layout_tests/port/webkit.py:
117
118 2011-05-24  Stephen White  <senorblanco@chromium.org>
119
120         Reviewed by Kenneth Russell.
121
122         Remove most style checks on Source/ThirdParty/glu, since it doesn't
123         follow WebKit style.
124         https://bugs.webkit.org/show_bug.cgi?id=61365
125
126         * Scripts/webkitpy/style/checker.py:
127
128 2011-05-24  Adam Roben  <aroben@apple.com>
129
130         Don't allow forcing builds through the build.webkit.org web interface
131
132         Someone has been forcing bogus builds.
133
134         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
135
136 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
137
138         Reviewed by Adam Roben.
139
140         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
141         https://bugs.webkit.org/show_bug.cgi?id=42669
142
143         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
144         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
145         Because that case changed the setting.
146
147         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
148         (WTR::InjectedBundle::beginTesting):
149
150 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
151
152         Reviewed by Kenneth Rohde Christiansen.
153
154         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
155         https://bugs.webkit.org/show_bug.cgi?id=61052
156
157         * Scripts/old-run-webkit-tests:
158
159 2011-05-24  Adam Roben  <aroben@apple.com>
160
161         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
162
163         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
164         that don't have any failing tests, which isn't useful
165
166         Reviewed by David Kilzer.
167
168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
169         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
170         instead of name strings.
171         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
172         builder names into an array of builders.
173
174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
175         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
176         the most recently completed build, or -1 if there is no such build.
177         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
178         in the given build, or -1 if the number could not be determined. Some of this code came from
179         _getFailingTests.
180         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
181         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
182         getNumberOfFailingTests functions.
183
184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
185         (ViewController.prototype._displayTesters): Get the current number of test failures for each
186         tester and show it in the list. Omit testers that have no failures at all. We keep the
187         testers and failure counts in an array and sort it before displaying the current data, as
188         the order in which data will be fetched is unpredictable.
189
190 2011-05-23  Tony Chang  <tony@chromium.org>
191
192         Reviewed by Ojan Vafai.
193
194         [nrwt] don't use NetworkTranslation when uploading results
195         https://bugs.webkit.org/show_bug.cgi?id=61315
196
197         This avoids autoinstalling mechanize.  It didn't matter anyway
198         because test_results_uploader.py wasn't using mechanize to make the
199         request so NetworkTransaction::run wasn't doing anything extra
200         (it only matters if it catches mechanize.HTTPError).
201
202         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
203
204 2011-05-23  Tony Chang  <tony@chromium.org>
205
206         Reviewed by Dirk Pranke.
207
208         [chromium] fix the rebaseline tool to work with Linux GPU failures
209         https://bugs.webkit.org/show_bug.cgi?id=61312
210
211         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
212
213 2011-05-23  Darin Adler  <darin@apple.com>
214
215         Ignore generated .pyc files in a directory full of python code.
216
217         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
218
219 2011-05-23  Adam Barth  <abarth@webkit.org>
220
221         Reviewed by Eric Seidel.
222
223         sheriffbot should give more details about the failures in IRC
224         https://bugs.webkit.org/show_bug.cgi?id=61233
225
226         With this patch, sheriffbot will annonce the set of failing tests,
227         which might help folks triage the problem.
228
229         * Scripts/webkitpy/tool/commands/sheriffbot.py:
230         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
231
232 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
233
234         Unreviewed, rolling out r87078.
235         http://trac.webkit.org/changeset/87078
236         https://bugs.webkit.org/show_bug.cgi?id=61294
237
238         Patch contains errors and seems likely to break a bunch of
239         bots (Requested by abarth on #webkit).
240
241         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
242         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
243         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
244
245 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
246
247         Reviewed by Ojan Vafai.
248
249         Convert json_results_generator.py to output version 4 JSON.
250         https://bugs.webkit.org/show_bug.cgi?id=60869
251
252         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
253         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
254         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
255
256 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
257
258         Reviewed by Adam Barth.
259
260         Move generation of shell_command from port to executive
261         https://bugs.webkit.org/show_bug.cgi?id=61251
262
263         After move it's possible to use the code in other places too.
264
265         * Scripts/webkitpy/common/config/ports.py:
266         * Scripts/webkitpy/common/system/executive.py:
267
268 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
269
270         Reviewed by Darin Adler.
271
272         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
273         https://bugs.webkit.org/show_bug.cgi?id=42669
274
275         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
276
277         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
278         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
279         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
280         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
281
282 2011-05-22  Robert Hogan  <robert@webkit.org>
283
284         Reviewed by Kenneth Rohde Christiansen.
285
286         Fix policyDelegate in Qt DRT
287         https://bugs.webkit.org/show_bug.cgi?id=61247
288
289         Use the 'policy delegate' implemented in FrameLoaderClient
290         for layout tests. The partial implementation in DumpRenderTreeQt
291         is redundant, so remove it.
292
293         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
294         (WebCore::WebPage::acceptNavigationRequest):
295         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
296         (LayoutTestController::waitForPolicyDelegate):
297
298 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
299
300         Reviewed by Darin Adler.
301
302         Use double quotes for filename arguments
303         https://bugs.webkit.org/show_bug.cgi?id=61250
304
305         Windows does not support single quotes on the command line,
306         so replace them with double quotes.
307
308         * Scripts/prepare-ChangeLog:
309
310 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
311
312         Reviewed by Sam Weinig.
313
314         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
315         https://bugs.webkit.org/show_bug.cgi?id=42550
316         
317         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
318
319         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
320         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
321         Copy the code for pausing animations, FIXME comments and all.
322         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
323         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
324
325 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
326
327         Reviewed by Stephen White.
328
329         Adding myself to the committers list.
330
331         * Scripts/webkitpy/common/config/committers.py:
332
333 2011-05-19  Adam Roben  <aroben@apple.com>
334
335         Test that the WebKit2 UI process doesn't crash when starting a download
336
337         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
338         (preceded by assertion) in fastMalloc when downloading a file
339
340         Reviewed by Darin Adler.
341
342         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
343
344         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
345         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
346         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
347         started, cancel the download, and return a bogus string.
348
349         (TestWebKitAPI::setContextDownloadClient):
350         (TestWebKitAPI::setPagePolicyClient):
351         Simple helper functions.
352
353         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
354         our policy client, and run until we know that the download was started. If we haven't
355         crashed, we win!
356
357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
358         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
359         * TestWebKitAPI/win/copy-resources.cmd:
360         Added new files.
361
362 2011-05-20  Kent Tamura  <tkent@chromium.org>
363
364         Reviewed by Ryosuke Niwa.
365
366         Fix style errors in DumpRenderTree/chromium/.
367         https://bugs.webkit.org/show_bug.cgi?id=61172
368
369         * DumpRenderTree/chromium/CppBoundClass.cpp:
370         (CppBoundClass::getAsCppVariant):
371         (CppBoundClass::bindToJavascript):
372         * DumpRenderTree/chromium/CppBoundClass.h:
373         (CppBoundClass::GetterCallback::~GetterCallback):
374         (CppBoundClass::CppBoundClass):
375         (CppBoundClass::Callback::~Callback):
376         (CppBoundClass::MemberCallback::MemberCallback):
377         (CppBoundClass::MemberCallback::~MemberCallback):
378         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
379         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
380         * DumpRenderTree/chromium/CppVariant.h:
381         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
382         (DRTDevToolsAgent::~DRTDevToolsAgent):
383         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
384         (DRTDevToolsClient::sendFrontendLoaded):
385         * DumpRenderTree/chromium/DRTDevToolsClient.h:
386         * DumpRenderTree/chromium/DumpRenderTree.cpp:
387         (main):
388         * DumpRenderTree/chromium/EventSender.cpp:
389         (SavedEvent::SavedEvent):
390         (EventSender::EventSender):
391         (EventSender::keyDown):
392         * DumpRenderTree/chromium/EventSender.h:
393         * DumpRenderTree/chromium/ImageDiff.cpp:
394         (Image::Image):
395         * DumpRenderTree/chromium/LayoutTestController.cpp:
396         (LayoutTestController::LayoutTestController):
397         (LayoutTestController::WorkQueue::reset):
398         (WorkItemBackForward::WorkItemBackForward):
399         (WorkItemLoadingScript::WorkItemLoadingScript):
400         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
401         (WorkItemLoad::WorkItemLoad):
402         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
403         (LayoutTestController::pathToLocalResource):
404         * DumpRenderTree/chromium/LayoutTestController.h:
405         (LayoutTestController::WorkItem::~WorkItem):
406         (LayoutTestController::WorkQueue::WorkQueue):
407         * DumpRenderTree/chromium/MockSpellCheck.cpp:
408         (MockSpellCheck::MockSpellCheck):
409         (MockSpellCheck::~MockSpellCheck):
410         * DumpRenderTree/chromium/MockSpellCheck.h:
411         * DumpRenderTree/chromium/NotificationPresenter.h:
412         (NotificationPresenter::NotificationPresenter):
413         * DumpRenderTree/chromium/Task.cpp:
414         (WebTask::WebTask):
415         * DumpRenderTree/chromium/Task.h:
416         (TaskList::TaskList):
417         * DumpRenderTree/chromium/TestEventPrinter.cpp:
418         (DRTPrinter::DRTPrinter):
419         (TestShellPrinter::TestShellPrinter):
420         * DumpRenderTree/chromium/TestNavigationController.cpp:
421         (TestNavigationEntry::TestNavigationEntry):
422         (TestNavigationEntry::~TestNavigationEntry):
423         (TestNavigationController::TestNavigationController):
424         (TestNavigationController::reload):
425         (TestNavigationController::loadEntry):
426         (TestNavigationController::didNavigateToEntry):
427         * DumpRenderTree/chromium/TestNavigationController.h:
428         (TestShellExtraData::TestShellExtraData):
429         * DumpRenderTree/chromium/TestShell.cpp:
430         (dumpHistoryItem):
431         * DumpRenderTree/chromium/TestShell.h:
432         (TestParams::TestParams):
433         * DumpRenderTree/chromium/TestShellWin.cpp:
434         (TestShell::waitTestFinished):
435         * DumpRenderTree/chromium/TestWebWorker.h:
436         (TestWebWorker::startWorkerContext):
437         (TestWebWorker::terminateWorkerContext):
438         (TestWebWorker::postMessageToWorkerContext):
439         (TestWebWorker::clientDestroyed):
440         (TestWebWorker::postMessageToWorkerObject):
441         (TestWebWorker::postExceptionToWorkerObject):
442         (TestWebWorker::postConsoleMessageToWorkerObject):
443         (TestWebWorker::confirmMessageFromWorkerObject):
444         (TestWebWorker::reportPendingActivity):
445         (TestWebWorker::workerContextClosed):
446         (TestWebWorker::~TestWebWorker):
447         * DumpRenderTree/chromium/TextInputController.cpp:
448         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
449         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
450         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
451         (WebThemeEngineDRTWin::paintButton):
452         (WebThemeEngineDRTWin::paintMenuList):
453         (WebThemeEngineDRTWin::paintTrackbar):
454         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
455         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
456         * DumpRenderTree/chromium/WebViewHost.cpp:
457         (WebViewHost::navigate):
458         (WebViewHost::updateSessionHistory):
459         (WebViewHost::paintInvalidatedRegion):
460         * DumpRenderTree/chromium/WebViewHost.h:
461
462 2011-05-19  Dmitry Lomov  <dslomov@google.com>
463
464         Reviewed by Adam Roben.
465
466         Detect hangs in run-api-tests
467         https://bugs.webkit.org/show_bug.cgi?id=48043
468
469         * Scripts/run-api-tests: Added test timeouts
470
471 2011-05-19  Dmitry Lomov  <dslomov@google.com>
472
473         Reviewed by Adam Roben.
474
475         run-api-tests should run one test per process
476         https://bugs.webkit.org/show_bug.cgi?id=61088
477
478         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
479         return code, and parsing GTest output format.
480
481 2011-05-15  Robert Hogan  <robert@webkit.org>
482
483         Reviewed by Antonio Gomes.
484
485         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
486         https://bugs.webkit.org/show_bug.cgi?id=60834
487         Fix unix test plugin for plugins/get-url-with-javascript-url.html
488
489         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
490         (webkit_test_plugin_new_stream):
491         (webkit_test_plugin_write_ready):
492         (webkit_test_plugin_write):
493
494 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
495
496         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
497         http://trac.webkit.org/changeset/86869
498         http://trac.webkit.org/changeset/86873
499         http://trac.webkit.org/changeset/86875
500         http://trac.webkit.org/changeset/86877
501         https://bugs.webkit.org/show_bug.cgi?id=61139
502
503         broke builds and debug DRT (Requested by rniwa on #webkit).
504
505         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
506         * DumpRenderTree/chromium/TestShell.cpp:
507         (TestShell::bindJSObjectsToWindow):
508         * DumpRenderTree/mac/FrameLoadDelegate.mm:
509         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
510
511 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
512
513         Reviewed by Darin Adler.
514
515         Add build logistics and plumbing for window.internals object.
516         https://bugs.webkit.org/show_bug.cgi?id=60313
517
518         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
519         * DumpRenderTree/chromium/TestShell.cpp:
520         (TestShell::bindJSObjectsToWindow): Added injection code.
521         * DumpRenderTree/mac/FrameLoadDelegate.mm:
522         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
523
524 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
525
526         Reviewed by Csaba Osztrogonác.
527
528         [Qt] Implement eventSender.scalePageBy
529         https://bugs.webkit.org/show_bug.cgi?id=60015
530
531         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
532         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
533         * DumpRenderTree/qt/EventSenderQt.cpp:
534         (EventSender::scalePageBy):
535         * DumpRenderTree/qt/EventSenderQt.h:
536
537 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
538
539         Reviewed by Kent Tamura.
540
541         [Chromium] IME candidate window appears wrong position in an iframe
542         https://bugs.webkit.org/show_bug.cgi?id=61023
543
544         Call the focused frame's firstRectForCharacterRange() instead of the
545         main frame so that DRT behaves as the same as Chromium.
546
547         * DumpRenderTree/chromium/TextInputController.cpp:
548         (TextInputController::firstRectForCharacterRange):
549
550 2011-05-18  Adam Roben  <aroben@apple.com>
551
552         Add a new page to build.webkit.org to help find when tests started failing
553
554         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
555         right now, but already shows some useful information. It's somewhat similar to webkit-patch
556         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
557         little more convenient than either of them, though, because it's all done in the browser
558         (and thus it's easy to go directly to the relevant test results).
559
560         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
561         (Buildbot): This class represents a Buildbot server.
562         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
563         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
564         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
565         callback.
566         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
567         be implemented by a derived class that understands this server's build naming scheme.
568         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
569         particular build.
570
571         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
572         (Builder): This class represents one builder on the buildbot.
573         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
574         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
575         information about a particular test failure.
576         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
577         information about when tests started failing.
578         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
579         particular build.
580         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
581         callback.
582         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
583         extracts all the failing tests listed in it, passing them to the callback.
584         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
585         build, merges them into the build history, and calls the callback telling it whether the
586         next build should be fetched to provide more information.
587
588         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
589         Added. Just some simple styles.
590
591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
592         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
593         (getResource): Wrapper around XMLHttpRequest.
594         (Array.prototype.findFirst): Finds the first element matching the given predicate and
595         returns it.
596         (Array.prototype.last): Returns the last element of the array.
597
598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
599         (ViewController): This class contains the main logic for displaying the page.
600         (ViewController.loaded): Just calls through to parseHash.
601         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
602         shows the list of all testers so one can be chosen. This function is called when the page
603         loads and whenever we get a hashchange event.
604         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
605         as it is fetched. The display ends up grouping tests by when they started failing.
606         (ViewController._displayTesters): Gets the list of testers and displays it.
607
608         (ViewController._domForBuildName):
609         (ViewController._domForFailedTest):
610         Helper functions to create descriptions and links for a particular build or failed test.
611
612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
613         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
614         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
615
616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
617         loads all the files and sets up a ViewController, which does the rest.
618
619         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
620         page.
621
622 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
623
624         Reviewed by Csaba Osztrogonác.
625
626         [Qt] Implement layoutTestController.setValueForUser()
627         https://bugs.webkit.org/show_bug.cgi?id=60956
628
629         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
630         (LayoutTestController::setValueForUser):
631         * DumpRenderTree/qt/LayoutTestControllerQt.h:
632
633 2011-05-16  Robert Hogan  <robert@webkit.org>
634
635         Reviewed by Kenneth Rohde Christiansen.
636
637         plugins/invalidate_rect.html fails on linux ports
638
639         - Make the unix test netscape plugin recognize the onPaintEvent
640           and windowedPlugin parameters.
641
642         https://bugs.webkit.org/show_bug.cgi?id=54051
643
644         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
645         (handleEventX11):
646         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
647         (LayoutTestController::displayInvalidatedRegion):
648         * DumpRenderTree/qt/LayoutTestControllerQt.h:
649         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
650         (webkit_test_plugin_new_instance):
651         (webkit_test_plugin_handle_event):
652
653 2011-05-17  Tony Chang  <tony@chromium.org>
654
655         Reviewed by Ojan Vafai.
656
657         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
658         https://bugs.webkit.org/show_bug.cgi?id=60895
659
660         Update the tools to handle the move.  Lucid 32 results now go in
661         chromium-linux-x86 and the default platform on Linux is now x86_64.
662
663         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
664         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
665         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
666         * Scripts/webkitpy/layout_tests/port/base.py: ditto
667         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
668         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
669         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
670         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
671         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
672
673 2011-05-17  Adam Roben  <aroben@apple.com>
674
675         Make run-api-tests work on Windows when there are spaces in the path
676
677         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
678         spaces in the path to TestWebKitAPI.exe
679
680         Reviewed by David Levin.
681
682         * Scripts/run-api-tests:
683         (runTestTool): Use the "direct object" form of system() to avoid having the path to
684         TestWebKitAPI.exe be split by the shell.
685
686 2011-05-16  Ian Henderson  <ianh@apple.com>
687
688         Reviewed by Joseph Pecoraro.
689
690         Page::goToItem doesn't work while loading is deferred
691         https://bugs.webkit.org/show_bug.cgi?id=60412
692
693         Add setDefersLoading and goBack methods to LayoutTestController.  We
694         need to use goBack() instead of history.back() because the latter goes
695         through NavigationScheduler, hence doesn't exhibit the bug.
696
697         * DumpRenderTree/LayoutTestController.cpp:
698         (goBackCallback):
699         (setDefersLoadingCallback):
700         (LayoutTestController::staticFunctions):
701         * DumpRenderTree/LayoutTestController.h:
702         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
703         (LayoutTestController::goBack):
704         (LayoutTestController::setDefersLoading):
705         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
706         (LayoutTestController::goBack):
707         (LayoutTestController::setDefersLoading):
708         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
709         (LayoutTestController::goBack):
710         (LayoutTestController::setDefersLoading):
711         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
712         (LayoutTestController::goBack):
713         (LayoutTestController::setDefersLoading):
714
715 2011-05-16  Sam Weinig  <sam@webkit.org>
716
717         Reviewed by Anders Carlsson.
718
719         TestWebKitAPI should build with clang if it can
720         https://bugs.webkit.org/show_bug.cgi?id=60918
721
722         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
723         Update CompilerVersion.xcconfig to match others.
724
725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
726         Add CompilerVersion.xcconfig to the project.
727
728         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
729         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
730         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
731         (TestWebKitAPI::didSameDocumentNavigationForFrame):
732         Add some casts to quiet warnings from clang.
733
734 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
735
736         Reviewed by David Levin.
737
738         add dpranke as a reviewer
739         https://bugs.webkit.org/show_bug.cgi?id=60919
740
741         * Scripts/webkitpy/common/config/committers.py:
742
743 2011-05-16  Robert Hogan  <robert@webkit.org>
744
745         Reviewed by Anders Carlsson.
746
747         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
748
749         https://bugs.webkit.org/show_bug.cgi?id=60838
750
751         The unix test plugin needs to call the test's NPP_URLNotify
752         rather than the browsers.
753
754         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
755         (webkit_test_plugin_url_notify):
756
757 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
758
759         Rubber-stamped by Adam Roben.
760
761         Adding myself as a reviewer.
762         * Scripts/webkitpy/common/config/committers.py:
763
764 2011-05-16  Sam Weinig  <sam@webkit.org>
765
766         Fix typo pointed out by Dave Levin.
767
768         * TestWebKitAPI/PlatformUtilities.h:
769         (TestWebKitAPI::Util::assertWKStringEqual):
770         Strig -> String.
771
772 2011-05-16  Sam Weinig  <sam@webkit.org>
773
774         Reviewed by David Levin.
775
776         Convert api tester over to using gtest expectations directly
777         https://bugs.webkit.org/show_bug.cgi?id=60862
778
779         * TestWebKitAPI/PlatformUtilities.cpp:
780         (TestWebKitAPI::Util::toSTD):
781         * TestWebKitAPI/PlatformUtilities.h:
782         (TestWebKitAPI::Util::assertWKStrigEqual):
783         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
784         the implementation of the macro simpler.
785
786         * TestWebKitAPI/Test.h:
787         Remove TEST_ASSERT forwarder.
788
789         [Test changes elided]
790
791 2011-05-16  David Kilzer  <ddkilzer@apple.com>
792
793         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
794         <rdar://problem/9446430>
795
796         Reviewed by Mark Rowe.
797
798         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
799         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
800         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
801
802 2011-05-16  Jon Lee  <jonlee@apple.com>
803
804         Reviewed by Simon Fraser.
805
806         Can't horizontally scroll iframes and overflow because wheel events are always accepted
807         https://bugs.webkit.org/show_bug.cgi?id=60779
808
809         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
810         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
811
812 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
813
814         Reviewed by Csaba Osztrogonác.
815
816         [Qt] Tools.pro misses include(common.pri)
817         https://bugs.webkit.org/show_bug.cgi?id=60883
818
819         It includes features.pri, which depends on common.pri (the build is
820         not broken today with the default options, but this is the right
821         thing to do).
822
823         * Tools.pro:
824
825 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
826
827         Unreviewed: adding myself to committers.py.
828
829         * Scripts/webkitpy/common/config/committers.py:
830
831 2011-05-15  Daniel Bates  <dbates@webkit.org>
832
833         Reviewed by Chris Jerdonek.
834
835         svn-apply can't handle Git diff that only changes executable bit
836         https://bugs.webkit.org/show_bug.cgi?id=60848
837
838         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
839         that only has an executable bit change.
840
841         * Scripts/VCSUtils.pm:
842           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
843         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
844         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
845         * Scripts/svn-apply:
846         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
847         * Scripts/svn-unapply:
848         (patch): Ditto.
849         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
850           - Updated expected results for test cases to account for numTextChunks.
851           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
852           - Added test case "Git: file that only has an executable bit change".
853         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
854           - Updated expected results for test cases to account for numTextChunks.
855
856 2011-05-15  Sam Weinig  <sam@webkit.org>
857
858         Fix windows build.
859
860         * TestWebKitAPI/win/main.cpp:
861         (main):
862
863 2011-05-15  Sam Weinig  <sam@webkit.org>
864
865         Reviewed by David Levin.
866
867         Make API tester more gtest friendly
868         https://bugs.webkit.org/show_bug.cgi?id=60859
869
870         * Scripts/run-api-tests:
871         Numerous changes:
872         - Remove logic to run tests one at a time.
873         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
874           the test runner and allow gtest to print it for us.
875         - Forward stdout from the test tool to stdout, even in non-verbose runs.
876         - Run test tool from the current working directory instead of the root webkit
877           directory.
878
879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
880         Move plist to be with other bundle sources.
881
882         * TestWebKitAPI/TestsController.cpp:
883         (TestWebKitAPI::TestsController::TestsController):
884         (TestWebKitAPI::TestsController::run):
885         * TestWebKitAPI/TestsController.h:
886         * TestWebKitAPI/mac/main.mm:
887         Simplify TestController down to a single run function. We should consider removing the class
888         entirely at some point.
889
890 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
891
892         Unreviewed, rolling out r86504.
893         http://trac.webkit.org/changeset/86504
894         https://bugs.webkit.org/show_bug.cgi?id=60853
895
896         "Broke Qt EventSender in editing/selection tests" (Requested
897         by mwenge on #webkit).
898
899         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
900         (WebCore::WebPage::WebPage):
901         (WebCore::DumpRenderTree::DumpRenderTree):
902         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
903         (WebCore::DumpRenderTree::initJSObjects):
904         * DumpRenderTree/qt/DumpRenderTreeQt.h:
905         (WebCore::DumpRenderTree::eventSender):
906         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
907         (webkit_test_plugin_new_instance):
908         (webkit_test_plugin_set_window):
909         (webkit_test_plugin_handle_event):
910
911 2011-05-12  Robert Hogan  <robert@webkit.org>
912
913         Reviewed by Benjamin Poulain.
914
915         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
916
917         The support for this test added to the unix test plugin here
918         may allow other platforms to pass it (nearly everyone
919         skips it). On Qt it required a bit of trickiness with
920         the page's EventSender object to get it working fully though,
921         so only unskipping Qt here.
922
923         https://bugs.webkit.org/show_bug.cgi?id=60722
924
925         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
926         (WebCore::WebPage::WebPage):
927         (WebCore::WebPage::eventSender):
928         (WebCore::DumpRenderTree::DumpRenderTree):
929         (WebCore::DumpRenderTree::initJSObjects):
930         (WebCore::DumpRenderTree::createWindow):
931         * DumpRenderTree/qt/DumpRenderTreeQt.h:
932         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
933         (webkit_test_plugin_new_instance):
934         (webkit_test_plugin_set_window):
935         (webkit_test_plugin_handle_event):
936
937 2011-05-14  Arno Renevier  <arno@renevier.net>
938
939         Reviewed by Martin Robinson.
940
941         make run-gtk-tests executable
942         https://bugs.webkit.org/show_bug.cgi?id=59278
943
944         * Scripts/run-gtk-tests:
945
946 2011-05-14  Anders Carlsson  <andersca@apple.com>
947
948         Reviewed by Kevin Decker.
949
950         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
951         https://bugs.webkit.org/show_bug.cgi?id=60823
952         <rdar://problem/9430386>
953
954         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
955
956         * DumpRenderTree/DumpRenderTree.gypi:
957         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
958         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
959         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
960         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
961         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
962         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
963         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
964         * GNUmakefile.am:
965
966 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
967
968         Unreviewed, rolling out r86476.
969         http://trac.webkit.org/changeset/86476
970         https://bugs.webkit.org/show_bug.cgi?id=60832
971
972         It made plugins/get-url-notify-with-url-that-fails-to-
973         load.html crash on GTK (Requested by Ossy on #webkit).
974
975         * DumpRenderTree/DumpRenderTree.gypi:
976         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
977         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
978         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
979         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
980         * GNUmakefile.am:
981
982 2011-05-13  Anders Carlsson  <andersca@apple.com>
983
984         Reviewed by Sam Weinig.
985
986         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
987         https://bugs.webkit.org/show_bug.cgi?id=60823
988         <rdar://problem/9430386>
989
990         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
991
992         * DumpRenderTree/DumpRenderTree.gypi:
993         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
994         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
995         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
996         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
997         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
998         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
999         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1000         * GNUmakefile.am:
1001
1002 2011-05-13  Anders Carlsson  <andersca@apple.com>
1003
1004         Build fix.
1005
1006         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
1007
1008 2011-05-13  Anders Carlsson  <andersca@apple.com>
1009
1010         Reviewed by Sam Weinig.
1011
1012         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
1013         https://bugs.webkit.org/show_bug.cgi?id=60810
1014
1015         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
1016
1017         * DumpRenderTree/DumpRenderTree.gypi:
1018         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1019         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1020         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1021         * GNUmakefile.am:
1022         Add files.
1023
1024         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1025         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1026         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
1027
1028         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
1029         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
1030         (GetURLWithJavaScriptURL::NPP_New):
1031         (GetURLWithJavaScriptURL::NPP_NewStream):
1032         (GetURLWithJavaScriptURL::NPP_DestroyStream):
1033         (GetURLWithJavaScriptURL::NPP_WriteReady):
1034         (GetURLWithJavaScriptURL::NPP_Write):
1035         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1036         (NPP_NewStream):
1037         (NPP_WriteReady):
1038         (NPP_Write):
1039         (NPP_URLNotify):
1040         call the PluginTest NPP wrappers.
1041
1042 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1043
1044         Unreviewed, rolling out r86447.
1045         http://trac.webkit.org/changeset/86447
1046         https://bugs.webkit.org/show_bug.cgi?id=60809
1047
1048         "Broke some uses of EventSender object on Qt" (Requested by
1049         mwenge on #webkit).
1050
1051         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1052         (WebCore::WebPage::WebPage):
1053         (WebCore::DumpRenderTree::DumpRenderTree):
1054         (WebCore::DumpRenderTree::initJSObjects):
1055         (WebCore::DumpRenderTree::createWindow):
1056         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1057         (WebCore::DumpRenderTree::eventSender):
1058         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1059         (webkit_test_plugin_new_instance):
1060         (webkit_test_plugin_set_window):
1061         (webkit_test_plugin_handle_event):
1062
1063 2011-05-13  Robert Hogan  <robert@webkit.org>
1064
1065         Reviewed by Benjamin Poulain.
1066
1067         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1068
1069         The support for this test added to the unix test plugin here
1070         may allow other platforms to pass it (nearly everyone
1071         skips it). On Qt it required a bit of trickiness with
1072         the page's EventSender object to get it working fully though,
1073         so only unskipping Qt here.
1074
1075         https://bugs.webkit.org/show_bug.cgi?id=60722
1076
1077         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1078         (WebCore::WebPage::WebPage):
1079         (WebCore::WebPage::eventSender):
1080         (WebCore::DumpRenderTree::DumpRenderTree):
1081         (WebCore::DumpRenderTree::initJSObjects):
1082         (WebCore::DumpRenderTree::createWindow):
1083         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1084         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1085         (webkit_test_plugin_new_instance):
1086         (webkit_test_plugin_set_window):
1087         (webkit_test_plugin_handle_event):
1088
1089 2011-05-13  Adam Roben  <aroben@apple.com>
1090
1091         Exclude the Leopard NRWT bot from the core builder set
1092
1093         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
1094
1095         Reviewed by Darin Adler.
1096
1097         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1098         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
1099         in the core builder set.
1100
1101         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1102         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
1103         regexps.
1104
1105 2011-05-13  Adam Roben  <aroben@apple.com>
1106
1107         Group all the NRWT bots together
1108
1109         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
1110         bots are experimental, it seems best not to clutter up the non-experimental bots with
1111         experimental ones.
1112
1113         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
1114         on build.webkit.org
1115
1116         Reviewed by Dan Bernstein.
1117
1118         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
1119         Chromium testers, which also use new-run-webkit-tests.
1120
1121 2011-05-13  Adam Roben  <aroben@apple.com>
1122
1123         Add a plugin test that dumps the plugin window's rect
1124
1125         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
1126         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
1127
1128         Reviewed by Dan Bernstein.
1129
1130         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
1131         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
1132         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
1133         harness window and log it.
1134
1135         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
1136
1137 2011-05-13  Adam Roben  <aroben@apple.com>
1138
1139         Move code required for most tests of plugin window geometry into a base class
1140
1141         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
1142         having all the trickiness in a shared base class, writing new window geometry tests will be
1143         much easier.
1144
1145         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
1146
1147         Reviewed by Anders Carlsson.
1148
1149         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
1150         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
1151         WindowGeometryTest base class. Most of the code from this class was moved to the new base
1152         class.
1153         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
1154         This is called by the base class when it is safe to check the window's geometry. Note that
1155         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
1156         just vestigial code from an earlier version of this test.
1157
1158         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
1159         WindowGeometryTest class.
1160
1161         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
1162         WindowRegionIsSetToClipRect.
1163         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
1164         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
1165         Subclasses can implement that function to perform their own tests.
1166
1167         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
1168
1169 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
1170
1171         Reviewed by Csaba Osztrogonác.
1172
1173         Missing 2nd #EOF if WebProcess is killed.
1174         https://bugs.webkit.org/show_bug.cgi?id=60761
1175
1176         If the WebProcess is killed, only one #EOF is yielded
1177         by WebKitTestRunner. However, run-webkit-test wait for
1178         a second #EOF, which signals the finishing of pixel dump.
1179         Since this never happens, run-webkit-test waits forever.
1180
1181         * WebKitTestRunner/TestInvocation.cpp:
1182         (WTR::TestInvocation::dump):
1183         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1184         * WebKitTestRunner/TestInvocation.h:
1185
1186 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1187
1188         Reviewed by Csaba Osztrogonác.
1189
1190         [NRWT] chromium-linux tests shouldn't run on other platforms
1191         https://bugs.webkit.org/show_bug.cgi?id=60162
1192
1193         Remove _tests_for_other_platforms defs because r82753
1194         implemented it properly in the baseclass in webkit.py.
1195
1196         * Scripts/webkitpy/layout_tests/port/gtk.py:
1197         * Scripts/webkitpy/layout_tests/port/qt.py:
1198         * Scripts/webkitpy/layout_tests/port/win.py:
1199
1200 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
1201
1202         Reviewed by Antonio Gomes.
1203
1204         [EFL] Remove unused option of EWeblauncher
1205         https://bugs.webkit.org/show_bug.cgi?id=60747
1206
1207         Remove sudo-workaround option.
1208         This option is not used and make other option wrong.
1209
1210         * EWebLauncher/main.c:
1211
1212 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1213
1214         Reviewed by Stephanie Lewis.
1215
1216         Fix config.json to address missing WK2 builder/tester config.
1217         Fix naming of machines (xserve not macpro)
1218
1219         * BuildSlaveSupport/build.webkit.org-config/config.json:
1220
1221 2011-05-12  Lucas Forschler  <lforschler@apple.com>
1222
1223         Reviewed by Stephanie Lewis.
1224
1225         Add SnowLeopard Debug builder and Test bot.
1226         apple-xserve-8 = SL Debug Tester.
1227         apple-xserve-9 = SL Debug Builder.
1228         
1229         * BuildSlaveSupport/build.webkit.org-config/config.json:
1230
1231 2011-05-12  Adam Barth  <abarth@webkit.org>
1232
1233         This patch disables sheriffbot's bug postings.  He's just been way too
1234         spammy recently due to test flakiness.
1235
1236         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1237         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1238
1239 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
1240
1241         Reviewed by Anders Carlsson.
1242
1243         After relaunching an unresponsive web process, web page stops responding to mouse movement
1244         https://bugs.webkit.org/show_bug.cgi?id=60669
1245         <rdar://problem/9409934>
1246         
1247         This test follows the steps needed to reproduce this bug:
1248         1) Hang the web process
1249         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
1250         3) Kill and restart the WebProcess
1251         4) Move the mouse
1252         
1253         We are testing that we receive mouse move events after the WebProcess has restarted.
1254
1255         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
1256         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
1257         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
1258         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
1259         (TestWebKitAPI::setPageLoaderClient):
1260         (TestWebKitAPI::TEST):
1261         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
1262         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
1263         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
1264         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
1265
1266         * TestWebKitAPI/PlatformWebView.h:
1267         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1268         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
1269         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1270         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
1271
1272         Add new files.
1273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1274         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1275         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1276         * TestWebKitAPI/win/copy-resources.cmd:
1277
1278 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
1279
1280         Reviewed by Antonio Gomes.
1281
1282         [EFL] Added initialization/shutdown for ecore_file library
1283         https://bugs.webkit.org/show_bug.cgi?id=60457
1284
1285         Added initialization and shuthown for ecore_file library and replaced
1286         realpath function to ecore_file_realpath.
1287
1288         * EWebLauncher/main.c:
1289         (quit):
1290         (findThemePath):
1291         (main):
1292
1293 2011-05-12  Young Han Lee  <joybro@company100.net>
1294
1295         Reviewed by Kenneth Rohde Christiansen.
1296
1297         [Qt] Implement layoutTestController.layerTreeAsText()
1298         https://bugs.webkit.org/show_bug.cgi?id=60367
1299
1300         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1301         (LayoutTestController::layerTreeAsText):
1302         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1303
1304 2011-05-11  Eric Seidel  <eric@webkit.org>
1305
1306         Reviewed by David Levin.
1307
1308         Teach validate-committer-lists how to validate committers bugzilla_email()
1309         https://bugs.webkit.org/show_bug.cgi?id=60651
1310
1311         It turns out we currently have 9 committers with invalid values for their
1312         bugzilla_email field (meaning we don't know what email is their bugzilla account).
1313         "Alexander Kellett" <lypanov@mac.com>
1314         "Andre Boule" <aboule@apple.com>
1315         "Cameron McCormack" <cam@webkit.org>
1316         "Chris Petersen" <cpetersen@apple.com>
1317         "Eli Fidler" <eli@staikos.net>
1318         "Matt Lilek" <webkit@mattlilek.com>
1319         "Pierre d'Herbemont" <pdherbemont@free.fr>
1320         "Scott Violet" <sky@chromium.org>
1321         "Adam Treat" <treat@kde.org>
1322
1323         Most of those haven't committed in a very long time, so it's not suprising
1324         that we haven't noticed that their bugzilla emails are bogus.
1325
1326         * Scripts/validate-committer-lists:
1327         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1328         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1329
1330 2011-05-11  Dmitry Lomov  <dslomov@google.com>
1331
1332         Reviewed by David Levin.
1333
1334         https://bugs.webkit.org/show_bug.cgi?id=59561
1335         Switch TestWebKitAPI to GTest
1336
1337         Fixes Makefiles and WinCairo build as well
1338
1339         * Makefile:
1340         * Scripts/build-api-tests:
1341         * Scripts/run-api-tests:
1342         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1343         * TestWebKitAPI/Test.h:
1344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1345         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1346         (TestWebKitAPI::TEST):
1347         * TestWebKitAPI/TestsController.cpp:
1348         (TestWebKitAPI::TestsController::TestsController):
1349         (TestWebKitAPI::TestsController::dumpTestNames):
1350         (TestWebKitAPI::TestsController::runTestNamed):
1351         (TestWebKitAPI::TestsController::runAllTests):
1352         * TestWebKitAPI/TestsController.h:
1353         * TestWebKitAPI/mac/main.mm:
1354         (main):
1355
1356 2011-05-11  Eric Seidel  <eric@webkit.org>
1357
1358         Reviewed by Alexey Proskuryakov.
1359
1360         Add Luke Macpherson to committers.py as a Contributor
1361         https://bugs.webkit.org/show_bug.cgi?id=60639
1362
1363         * Scripts/webkitpy/common/config/committers.py:
1364
1365 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
1366
1367         Reviewed by Kenneth Rohde Christiansen.
1368
1369         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
1370         https://bugs.webkit.org/show_bug.cgi?id=60439
1371
1372         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
1373
1374         * Scripts/build-webkit:
1375
1376 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
1377
1378         Reviewed by Adam Roben.
1379
1380         REGRESSION (r86161): WKPreferences API test failing on Windows
1381         https://bugs.webkit.org/show_bug.cgi?id=60658
1382
1383         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1384         (TestWebKitAPI::TEST):
1385
1386 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
1387
1388         Reviewed by Ojan Vafai.
1389
1390         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
1391         https://bugs.webkit.org/show_bug.cgi?id=60521
1392
1393         First steps towards making the results JSON all hierarchical.
1394
1395         * TestResultServer/model/jsonresults.py:
1396         * TestResultServer/model/jsonresults_unittest.py:
1397
1398 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
1399
1400         [wx] Build fix, adding new LayoutTestController method stubs.
1401
1402         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1403         (LayoutTestController::localStorageDiskUsageForOrigin):
1404         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1405
1406 2011-05-11  Jessie Berlin  <jberlin@apple.com>
1407
1408         Reviewed by Darin Adler.
1409
1410         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
1411         about the usage for both the origin overall and the database in question.
1412         https://bugs.webkit.org/show_bug.cgi?id=60573
1413
1414         * WebKitTestRunner/TestController.cpp:
1415         (WTR::exceededDatabaseQuota):
1416
1417 2011-05-10  Stephen White  <senorblanco@chromium.org>
1418
1419         Reviewed by David Levin.
1420
1421         Adding myself as a reviewer.
1422         https://bugs.webkit.org/show_bug.cgi?id=60587
1423
1424         * Scripts/webkitpy/common/config/committers.py:
1425
1426 2011-05-11  Eric Seidel  <eric@webkit.org>
1427
1428         Reviewed by Csaba Osztrogonác.
1429
1430         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
1431         https://bugs.webkit.org/show_bug.cgi?id=60614
1432
1433         AppEngine has a result limit of 1000.  We hit that when trying
1434         to find out how many patches the style-queue (and other queues)
1435         have passed in the last 30 days.  So lets display 1000+ instead
1436         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
1437
1438         I also made the status pages show "never" instead of just "ago" when we
1439         haven't seen a pass or boot message in the last 1000 messages.
1440
1441         * QueueStatusServer/handlers/queuestatus.py:
1442         * QueueStatusServer/templates/queuestatus.html:
1443
1444 2011-05-11  Adam Barth  <abarth@webkit.org>
1445
1446         Reviewed by Eric Seidel.
1447
1448         sheriffbot shouldn't spam bugs when it can't figure out who to blame
1449         https://bugs.webkit.org/show_bug.cgi?id=60613
1450
1451         This patch limits the number of bugs sheriffbot will spam to three.
1452         Ideally, we'd come up with some smarter huerstics, but hopefully this
1453         will cut down on the bugmail spam for slow bots.
1454
1455         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1456
1457 2011-05-10  Eric Seidel  <eric@webkit.org>
1458
1459         Reviewed by Adam Barth.
1460
1461         EWS bots should be robust against test-webkitpy hangs
1462         https://bugs.webkit.org/show_bug.cgi?id=60579
1463
1464         Added a killAfterTimeout subroutine, which takes a child_pid
1465         and timeout, and will setup a watchdog process to kill that child
1466         after the timeout.  killAfterTimeout will waitpid on the child.
1467
1468         * EWSTools/start-queue.sh:
1469
1470 2011-05-10  MORITA Hajime  <morrita@google.com>
1471
1472         Unreviewed, moved myself to the reviewers list.
1473
1474         * Scripts/webkitpy/common/config/committers.py:
1475
1476 2011-05-10  Anton D'Auria  <adauria@apple.com>
1477
1478         Reviewed by David Levin.
1479
1480         StorageTracker should report actual local storage usage on disk
1481         https://bugs.webkit.org/show_bug.cgi?id=60558
1482
1483         * DumpRenderTree/LayoutTestController.cpp:
1484         (localStorageDiskUsageForOriginCallback):
1485         (LayoutTestController::staticFunctions):
1486         * DumpRenderTree/LayoutTestController.h:
1487         * DumpRenderTree/chromium/LayoutTestController.cpp:
1488         (LayoutTestController::LayoutTestController):
1489         (LayoutTestController::localStorageDiskUsageForOrigin):
1490         * DumpRenderTree/chromium/LayoutTestController.h:
1491         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1492         (LayoutTestController::localStorageDiskUsageForOrigin):
1493         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1494         (LayoutTestController::localStorageDiskUsageForOrigin):
1495         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1496         (LayoutTestController::localStorageDiskUsageForOrigin):
1497         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1498         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1499         (LayoutTestController::localStorageDiskUsageForOrigin):
1500
1501 2011-05-10  Anton D'Auria  <adauria@apple.com>
1502
1503         Reviewed by Alexey Proskuryakov.
1504
1505         Add ApplicationCache API to get disk usage per origin
1506         https://bugs.webkit.org/show_bug.cgi?id=57127
1507
1508         Added test that loads two frames with ~15Kb image, checks usage,
1509         deletes app cache, verifies usage is 0.
1510
1511         * DumpRenderTree/LayoutTestController.cpp:
1512         (applicationCacheDiskUsageForOriginCallback):
1513         (LayoutTestController::staticFunctions):
1514         * DumpRenderTree/LayoutTestController.h:
1515         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1516         (LayoutTestController::LayoutTestController):
1517         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1518         * DumpRenderTree/chromium/LayoutTestController.h:
1519         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1520         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1521         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1522         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1523         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1524         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1525         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1526         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1527         (LayoutTestController::applicationCacheDiskUsageForOrigin):
1528
1529 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1530
1531         Unreviewed, adding Rafael Antognolli as a committer.
1532
1533         * Scripts/webkitpy/common/config/committers.py:
1534
1535 2011-05-10  Chris Evans  <cevans@chromium.org>
1536
1537         Reviewed by Adam Barth.
1538
1539         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
1540         https://bugs.webkit.org/show_bug.cgi?id=58378
1541
1542         * DumpRenderTree/chromium/LayoutTestController.cpp:
1543         (LayoutTestController::LayoutTestController):
1544         (LayoutTestController::setAllowDisplayOfInsecureContent):
1545         (LayoutTestController::setAllowRunningOfInsecureContent):
1546         * DumpRenderTree/chromium/LayoutTestController.h:
1547         * DumpRenderTree/chromium/WebPreferences.cpp:
1548         (WebPreferences::reset):
1549         (WebPreferences::applyTo):
1550         * DumpRenderTree/chromium/WebPreferences.h:
1551         Add plumbing for new settings to Chromium DRT.
1552
1553 2011-05-10  Enrica Casucci  <enrica@apple.com>
1554
1555         Reviewed by Beth Dakin.
1556
1557         Added my name to the reviewers list and removed my name from
1558         to committer-only list.
1559
1560         * Scripts/webkitpy/common/config/committers.py:
1561
1562 2011-05-10  David Levin  <levin@chromium.org>
1563
1564         Reviewed by Shinichiro Hamaji.
1565
1566         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
1567         https://bugs.webkit.org/show_bug.cgi?id=60466
1568
1569         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
1570         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
1571           that property was removed.
1572         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
1573           filtering for errors.
1574         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
1575           verify that the line filtering is turned off.
1576         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
1577           and remove the unused file_path parameter.
1578         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
1579           line filtering is turned off (and fix test_no_error).
1580         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
1581           of errors based on the lines changed in the patch.
1582         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
1583           the filtering.
1584
1585 2011-05-10  Adam Roben  <aroben@apple.com>
1586
1587         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
1588
1589         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
1590         platform/win/plugins/window-geometry-initialized-before-set-window.html and
1591         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
1592         (WebKit2 Tests)
1593
1594         Reviewed by Anders Carlsson.
1595
1596         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
1597         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
1598         WindowedPluginTest::testHarnessWindow function.
1599
1600         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1601         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
1602         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
1603         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
1604         created for.
1605
1606         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
1607         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
1608         WindowedPluginTest, and initialized new members.
1609         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
1610         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
1611         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
1612         then clean up and tell the test harness we're done.
1613         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
1614         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
1615         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
1616         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
1617         window becomes visible.
1618         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
1619         if it was hidden at the start of the test.
1620         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
1621         This should cause our window to become visible and our window region to get set. When we get
1622         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
1623         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
1624         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
1625         "startTest".
1626         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
1627
1628         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
1629         (WindowedPluginTest::testHarnessWindow):
1630         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
1631         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
1632
1633 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
1634
1635         Reviewed by Kenneth Rohde Christiansen.
1636
1637         [Qt] Add new qt-4.8 platform for layout testing
1638         https://bugs.webkit.org/show_bug.cgi?id=60544
1639
1640         * Scripts/old-run-webkit-tests:
1641         * Scripts/webkitdirs.pm:
1642
1643 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1644
1645         Unreviewed, rolling out r86108.
1646         http://trac.webkit.org/changeset/86108
1647         https://bugs.webkit.org/show_bug.cgi?id=60533
1648
1649         Broke makefile based builds and Cairo (Requested by weinig on
1650         #webkit).
1651
1652         * Scripts/build-api-tests:
1653         * Scripts/run-api-tests:
1654         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1655         * TestWebKitAPI/Test.h:
1656         (TestWebKitAPI::Test::~Test):
1657         (TestWebKitAPI::Test::name):
1658         (TestWebKitAPI::Test::Register::Register):
1659         (TestWebKitAPI::Test::Register::create):
1660         (TestWebKitAPI::Test::Test):
1661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1662         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1663         (TestWebKitAPI::TEST):
1664         * TestWebKitAPI/TestsController.cpp:
1665         (TestWebKitAPI::TestsController::TestsController):
1666         (TestWebKitAPI::TestsController::dumpTestNames):
1667         (TestWebKitAPI::TestsController::runTestNamed):
1668         (TestWebKitAPI::TestsController::testFailed):
1669         (TestWebKitAPI::TestsController::registerCreateTestFunction):
1670         * TestWebKitAPI/TestsController.h:
1671         * TestWebKitAPI/mac/main.mm:
1672         (main):
1673
1674 2011-05-09  Hayato Ito  <hayato@chromium.org>
1675
1676         Reviewed by Ojan Vafai.
1677
1678         Skip reftests if pixel tests are disabled.
1679
1680         https://bugs.webkit.org/show_bug.cgi?id=59078
1681
1682         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1683         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1684         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1685         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1686
1687 2011-05-09  Chang Shu  <cshu@webkit.org>
1688
1689         Reviewed by Kenneth Rohde Christiansen.
1690
1691         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
1692         https://bugs.webkit.org/show_bug.cgi?id=60499
1693
1694         The implementation is similar to gtk.
1695
1696         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1697         (TextInputController::unmarkText):
1698         * DumpRenderTree/qt/TextInputControllerQt.h:
1699
1700 2011-05-09  James Robinson  <jamesr@chromium.org>
1701
1702         Reviewed by Eric Seidel.
1703
1704         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
1705         https://bugs.webkit.org/show_bug.cgi?id=60520
1706
1707         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1708
1709 2011-05-09  Dmitry Lomov  <dslomov@google.com>
1710
1711         Reviewed by Sam Weinig.
1712
1713         Switch TestWebKitAPI to GTest
1714         https://bugs.webkit.org/show_bug.cgi?id=59561
1715
1716         * Scripts/build-api-tests:
1717         * Scripts/run-api-tests:
1718         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1719         * TestWebKitAPI/Test.h:
1720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1721         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1722         (TestWebKitAPI::TEST):
1723         * TestWebKitAPI/TestsController.cpp:
1724         (TestWebKitAPI::TestsController::TestsController):
1725         (TestWebKitAPI::TestsController::dumpTestNames):
1726         (TestWebKitAPI::TestsController::runTestNamed):
1727         (TestWebKitAPI::TestsController::runAllTests):
1728         * TestWebKitAPI/TestsController.h:
1729         * TestWebKitAPI/mac/main.mm:
1730         (main):
1731
1732 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
1733
1734         Reviewed by Andreas Kling.
1735
1736         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
1737         https://bugs.webkit.org/show_bug.cgi?id=60487
1738
1739         When adding a new touch point, the start position of this point needs to be set.
1740
1741         * DumpRenderTree/qt/EventSenderQt.cpp:
1742         (EventSender::addTouchPoint):
1743
1744 2011-05-09  Robert Hogan  <robert@webkit.org>
1745
1746         Reviewed by Adam Roben.
1747
1748         https://bugs.webkit.org/show_bug.cgi?id=57137
1749
1750         Unskip plugins/embed-prefers-plugins-for-images.html
1751
1752         Add image/png mime-type to test netscape plugin on Unix.
1753
1754         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1755         (NP_GetMIMEDescription):
1756
1757 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
1758
1759         Reviewed by Ojan Vafai.
1760
1761         Pull jsonresults_unittest test cases out into separate test methods.
1762         https://bugs.webkit.org/show_bug.cgi?id=60418
1763
1764         * TestResultServer/model/jsonresults_unittest.py:
1765
1766 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1767
1768         Reviewed by Andreas Kling.
1769
1770         [Qt] fix fast/dom/Geolocation/window-close-crash.html
1771         https://bugs.webkit.org/show_bug.cgi?id=60458
1772
1773         Update all pages with Mock position/error/permission.
1774
1775         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1776         (LayoutTestController::setGeolocationPermission):
1777         (LayoutTestController::setMockGeolocationError):
1778         (LayoutTestController::setMockGeolocationPosition):
1779
1780 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
1781
1782         Reviewed by Tony Gentilcore.
1783
1784         Implement Page Visibility API.
1785         https://bugs.webkit.org/show_bug.cgi?id=54181
1786
1787         * DumpRenderTree/LayoutTestController.cpp:
1788         (setPageVisibilityCallback):
1789         (resetPageVisibilityCallback):
1790         (LayoutTestController::staticFunctions):
1791         * DumpRenderTree/LayoutTestController.h:
1792         (LayoutTestController::setPageVisibility):
1793         (LayoutTestController::resetPageVisibility):
1794         * DumpRenderTree/chromium/LayoutTestController.cpp:
1795         (LayoutTestController::LayoutTestController):
1796         (LayoutTestController::resetPageVisibility):
1797         (LayoutTestController::setPageVisibility):
1798         * DumpRenderTree/chromium/LayoutTestController.h:
1799
1800 2011-05-07  Adam Barth  <abarth@webkit.org>
1801
1802         Reviewed by Eric Seidel.
1803
1804         Testing EWS spins on patches with a large number of failures
1805         https://bugs.webkit.org/show_bug.cgi?id=60441
1806
1807         In cases where the tree has a small number of persistent failures but a
1808         patch has a large number of failures, we weren't believing any results.
1809         That lead to us retrying the patch forever while we waited for
1810         trustworthy results that would never come.
1811
1812         This patch loosens the semantics of unexpected_failures to return a
1813         subset (rather than the exact set) of unexpected failures.  In the case
1814         where the tree has a bounded number of failures and the patch has an
1815         unbounded number of failures, we can accurately compute such a subset
1816         and reject the patch.
1817
1818         * Scripts/webkitpy/tool/bot/expectedfailures.py:
1819         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1820         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1821         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1822         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1823
1824 2011-05-07  Joe Mason  <jmason@rim.com>
1825
1826         Reviewed by Daniel Bates.
1827
1828         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
1829         https://bugs.webkit.org/show_bug.cgi?id=52211
1830
1831         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
1832         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
1833
1834         * DumpRenderTree/chromium/WebViewHost.cpp:
1835         (WebViewHost::willPerformClientRedirect):
1836         (WebViewHost::didStartProvisionalLoad):
1837         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1838         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1839
1840 2011-05-07  Daniel Bates  <dbates@webkit.org>
1841
1842         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
1843         <http://trac.webkit.org/changeset/86007> (bug #60438).
1844
1845         * Scripts/old-run-webkit-tests:
1846           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
1847             file local variable. 
1848
1849 2011-05-07  Pratik Solanki  <psolanki@apple.com>
1850
1851         Reviewed by Darin Adler.
1852
1853         Remove references to Tiger in scripts
1854         https://bugs.webkit.org/show_bug.cgi?id=60438
1855
1856         Remove isTiger() and all of the code that depends on it.
1857
1858         * Scripts/build-webkit:
1859         * Scripts/ensure-valid-python:
1860         * Scripts/gdb-safari:
1861         * Scripts/webkitdirs.pm:
1862
1863 2011-05-06  David Grogan  <dgrogan@chromium.org>
1864
1865         Reviewed by Eric Seidel.
1866
1867         update link to message about mac 64bit git binaries
1868         https://bugs.webkit.org/show_bug.cgi?id=60411
1869
1870         The original message implied (correctly, at-the-time) that
1871         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
1872         binaries. The new message notes that they do. This might prevent someone
1873         else from spending a few minutes confused.
1874
1875         * Scripts/webkitpy/common/checkout/scm/git.py:
1876
1877 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
1878
1879         Reviewed by Ojan Vafai.
1880
1881         new-run-webkit-tests: crashes in race with crashing DRT
1882         https://bugs.webkit.org/show_bug.cgi?id=60238
1883
1884         This fixes a race where if we wrote the URL to DRT and
1885         DRT crashed immediately, we could get a broken pipe
1886         error back during the write() and not handle it correctly,
1887         causing NRWT to also crash.
1888
1889         * Scripts/webkitpy/layout_tests/port/server_process.py:
1890         * Scripts/webkitpy/layout_tests/port/webkit.py:
1891
1892 2011-05-06  Adam Barth  <abarth@webkit.org>
1893
1894         Reviewed by Eric Seidel.
1895
1896         Add a --skip-integrationtests mode to test-webkitpy
1897         https://bugs.webkit.org/show_bug.cgi?id=60354
1898
1899         These two test suites account for 2/3 of test-webkitpy's running time
1900         because they're not actually unit tests.  They're integration tests.
1901         This patch adds the ability to skip integration tests by passing a
1902         command line argument to test-webkitpy.  The buildbots will continue to
1903         run these integration tests to make sure they don't regress.  This
1904         option is for use by developers when working on parts of the code that
1905         are well-covered by unit tests.
1906
1907         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
1908         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
1909         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
1910         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
1911         * Scripts/webkitpy/test/main.py:
1912
1913 2011-05-06  Adam Barth  <abarth@webkit.org>
1914
1915         Reviewed by Eric Seidel.
1916
1917         The results.zip generated by the Chromium EWS are too big
1918         https://bugs.webkit.org/show_bug.cgi?id=60352
1919
1920         Currently results.zip created by the Chromium EWS bot contain roughly
1921         1000 tests that we expect to fail.  These test results are not helpful
1922         to contributors.
1923
1924         There are several approaches to solving this problem:
1925
1926         1) We could be more selective about which files to include in the zip.
1927         2) We could ask new-run-webkit-tests not to generate results for
1928            expected failures.
1929         3) We could ask new-run-webkit-tests not to run tests that we expect to
1930            fail.
1931
1932         This patch takes approach (3).  Currently, we're ignoring the outcome
1933         of failing tests anyway, so there's not much point in actually running
1934         them.  As a side benefit, this will speed up the test run by about 6%.
1935         In the future, we might revisit this decision and choose another
1936         approach.
1937
1938         * Scripts/webkitpy/common/config/ports.py:
1939         * Scripts/webkitpy/common/config/ports_unittest.py:
1940
1941 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
1942
1943         Reviewed by Csaba Osztrogonác.
1944
1945         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
1946
1947         * Scripts/old-run-webkit-tests:
1948
1949 2011-05-06  Adam Barth  <abarth@webkit.org>
1950
1951         Reviewed by Ojan Vafai.
1952
1953         Add an option to NRWT to skip failing tests
1954         https://bugs.webkit.org/show_bug.cgi?id=60295
1955
1956         This option is similar to the way old-run-webkit-tests works.  We're
1957         planning to use this option on the testing EWS bots because they don't
1958         use information from failing tests yet.
1959
1960         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1961         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1962         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1963
1964 2011-05-04  Philippe Normand  <pnormand@igalia.com>
1965
1966         Reviewed by Dimitri Glazkov.
1967
1968         Implement LayoutTestController::pseudoShadowId()
1969         https://bugs.webkit.org/show_bug.cgi?id=60034
1970
1971         shadowPseudoId support in the various LayoutTestController
1972         implementations.
1973
1974         * DumpRenderTree/LayoutTestController.cpp:
1975         (shadowPseudoIdCallback):
1976         (LayoutTestController::staticFunctions):
1977         * DumpRenderTree/LayoutTestController.h:
1978         * DumpRenderTree/chromium/LayoutTestController.cpp:
1979         (LayoutTestController::LayoutTestController):
1980         (LayoutTestController::shadowPseudoId):
1981         * DumpRenderTree/chromium/LayoutTestController.h:
1982         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1983         (LayoutTestController::shadowPseudoId):
1984         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1985         (LayoutTestController::shadowPseudoId):
1986         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1987         (LayoutTestController::shadowPseudoId):
1988         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1989         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1990         (LayoutTestController::shadowPseudoId):
1991         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1992         (LayoutTestController::shadowPseudoId):
1993         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1994         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1995         (WTR::LayoutTestController::shadowPseudoId):
1996         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1997
1998 2011-05-06  Adam Barth  <abarth@webkit.org>
1999
2000         EWS can't reject patches
2001         https://bugs.webkit.org/show_bug.cgi?id=60345
2002
2003         We're supposed to use patch.id() for the attachment ID, silly.
2004
2005         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2006         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2007
2008 2011-05-05  Steve Lacey  <sjl@chromium.org>
2009
2010         Reviewed by Ojan Vafai.
2011
2012         Fix generation of results html file by passing relative path to scm
2013         methods.
2014         Generate diff images for results html file.
2015
2016         https://bugs.webkit.org/show_bug.cgi?id=60086
2017
2018         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2019         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2020
2021 2011-05-05  Andy Estes  <aestes@apple.com>
2022
2023         Reviewed by Daniel Bates.
2024
2025         update-webkit should handle Internal using a different VCS than OpenSource.
2026         https://bugs.webkit.org/show_bug.cgi?id=60310
2027
2028         isGit() and isSVN() cache their results, so Internal will always be
2029         updated using the VCS commands used for OpenSource. If Internal uses a
2030         different VCS, this will fail. Fix this by calling isGitDirectory() and
2031         isSVNDirectory() instead, which do not cache their results.
2032
2033         * Scripts/update-webkit:
2034
2035 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2036
2037         Reviewed by Ojan Vafai.
2038
2039         nrwt: revamp integration tests incl. tests for servers
2040         https://bugs.webkit.org/show_bug.cgi?id=59985
2041
2042         This change adds the ability to run "integration tests" that
2043         depend on (and affect) the local environment on your machine.
2044         These tests can be run manually by invoking python on the
2045         test file in question and passing the '-i' flag, but are
2046         not run automatically as part of test-webkitpy.
2047
2048         Integration tests are identified by being methods named as
2049         "integration_test_*" instead of "test_*", and we use a
2050         custom TestLoader instead of the default one provided by
2051         unittest.
2052
2053         This change also adds a protected "_default_to_apache" method
2054         to the port object so we can do the right thing when starting
2055         and stopping web servers with less mechanism.
2056
2057         * Scripts/webkitpy/layout_tests/port/base.py:
2058         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2059         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2060         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2061         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2062         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2063
2064 2011-05-05  Adam Roben  <aroben@apple.com>
2065
2066         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
2067
2068         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
2069         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
2070         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
2071         safeguard against this, we fill the alpha channel with constant full opacity after the
2072         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
2073         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
2074         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
2075         results need an alpha channel, too.)
2076
2077         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
2078         generated due to alpha channel weirdness
2079
2080         Reviewed by Sam Weinig.
2081
2082         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2083         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
2084         constant full opacity.
2085         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
2086         in a CGContext or cairo_surface.
2087
2088 2011-05-05  Adam Roben  <aroben@apple.com>
2089
2090         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
2091
2092         Passing true tells the test harness to dump pixels even though we're not dumping a render
2093         tree.
2094
2095         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
2096         WebKitTestRunner doesn't result in pixel results being generated
2097
2098         Reviewed by Sam Weinig.
2099
2100         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
2101         argument to dumpAsText.
2102
2103         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2104         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
2105
2106         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2107         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
2108
2109         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
2110
2111         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
2112         developers.
2113
2114 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2115
2116         Reviewed by Ojan Vafai.
2117
2118         new-run-webkit-tests: merge os, version fields in test config
2119         https://bugs.webkit.org/show_bug.cgi?id=60004
2120
2121         This change removes the 'o/s' field from the TestConfiguration
2122         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
2123         the expectations file to macros that expand to the version names
2124         for each platform.
2125
2126         This means that you can once again put any subset of the
2127         operating system versions on a single line, e.g.:
2128           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
2129
2130         This change will break any existing test_expectations.txt
2131         file that uses the "OS-VERSION" macros, which are no longer
2132         needed. It turns out they were never needed, as just VERSION
2133         by itself was sufficient. The test_expectations.txt file should
2134         be updated accordingly prior to landing this change.
2135
2136         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2137         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2138         * Scripts/webkitpy/layout_tests/port/base.py:
2139
2140 2011-05-05  Tony Chang  <tony@chromium.org>
2141
2142         Reviewed by Adam Barth.
2143
2144         [chromium] switch from Lucida to free fonts for Hindi and Thai
2145         https://bugs.webkit.org/show_bug.cgi?id=60287
2146
2147         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
2148         packages on Lucid. There are actually multiple Thai fonts in the
2149         package, so I just picked one.
2150
2151         * DumpRenderTree/chromium/TestShellGtk.cpp:
2152         (setupFontconfig):
2153
2154 2011-05-05  Tony Chang  <tony@chromium.org>
2155
2156         Reviewed by Ojan Vafai.
2157
2158         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
2159         https://bugs.webkit.org/show_bug.cgi?id=60290
2160
2161         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
2162         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
2163         lucid64.  Because of that, google-chrome-64 used to skip the
2164         chromium-linux-x86_64 results since they were more incorrect.
2165
2166         Now that we're switching to lucid for google-chrome, we want
2167         google-chrome-64 to fall back to chromium-linux-x86_64.
2168
2169         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2170
2171 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
2172
2173         Reviewed by Ojan Vafai.
2174
2175         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
2176         https://bugs.webkit.org/show_bug.cgi?id=60002
2177
2178         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2179         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2180         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2181         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2182         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2183         * Scripts/webkitpy/style/checkers/test_expectations.py:
2184
2185 2011-05-05  Eric Seidel  <eric@webkit.org>
2186
2187         Reviewed by Adam Barth.
2188
2189         commit-queue should reject patches which fail ewses
2190         https://bugs.webkit.org/show_bug.cgi?id=47534
2191
2192         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2193         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2194         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2195
2196 2011-05-05  Chang Shu  <cshu@webkit.org>
2197
2198         Reviewed by Andreas Kling.
2199
2200         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
2201         https://bugs.webkit.org/show_bug.cgi?id=59638
2202
2203         1. Call QGraphicsWKView constructor with pageGroupRef.
2204         2. Disable setFontFamily calls as it breaks Qt test fonts.
2205
2206         * WebKitTestRunner/TestController.cpp:
2207         (WTR::TestController::resetStateToConsistentValues):
2208         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2209         (WTR::WebView::WebView):
2210         (WTR::PlatformWebView::PlatformWebView):
2211
2212 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
2213
2214         Reviewed by David Kilzer.
2215
2216         Add --only-webkit option to build-webkit
2217         https://bugs.webkit.org/show_bug.cgi?id=60245
2218
2219         * Scripts/build-webkit: If --only-webkit was specified
2220         just build the WebKit project, and not its dependencies.
2221
2222 2011-05-05  Jeff Miller  <jeffm@apple.com>
2223
2224         Reviewed by Darin Adler.
2225
2226         Add didNotHandleWheelEvent callback to WKPageUIClient
2227         https://bugs.webkit.org/show_bug.cgi?id=60203
2228
2229         * MiniBrowser/gtk/BrowserWindow.c:
2230         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
2231         * MiniBrowser/mac/BrowserWindowController.m:
2232         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
2233         * MiniBrowser/win/BrowserView.cpp:
2234         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
2235         * WebKitTestRunner/TestController.cpp:
2236         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
2237         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
2238
2239 2011-05-04  Eric Seidel  <eric@webkit.org>
2240
2241         Reviewed by Adam Barth.
2242
2243         Add more missing imports from scm refactor
2244         https://bugs.webkit.org/show_bug.cgi?id=60239
2245
2246         * Scripts/webkitpy/common/checkout/scm/git.py:
2247         * Scripts/webkitpy/common/checkout/scm/svn.py:
2248
2249 2011-05-04  Eric Seidel  <eric@webkit.org>
2250
2251         Reviewed by Adam Barth.
2252
2253         sheriff-bot is having more exception trouble
2254         https://bugs.webkit.org/show_bug.cgi?id=60233
2255
2256         A webpage-forced build was causing SB to throw an exception.
2257         We've long had this bug, but we just didn't notice it until now.
2258
2259         In debugging this I found we fetch an absurd amount of data now
2260         that we use buildbot's json (instead of xmlrpc), so I added
2261         the filter=1 parameter to reduce it a little.  That required
2262         me to handle the case where filter=1 would strip
2263         result=0 in some cases (it's unclear why it does that).
2264
2265         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2266         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2267
2268 2011-05-04  Cris Neckar  <cdn@chromium.org>
2269
2270         Unreviewed, Adding Cris Neckar as a committer
2271
2272         * Scripts/webkitpy/common/config/committers.py:
2273
2274 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
2275
2276         Reviewed by Laszlo Gombos.
2277
2278         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
2279         https://bugs.webkit.org/show_bug.cgi?id=59462
2280
2281         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging. 
2282
2283 2011-05-04  Eric Seidel  <eric@webkit.org>
2284
2285         Reviewed by Adam Barth.
2286
2287         The testing EWS bots should upload layout-test-results.zip to bugs after failures
2288         https://bugs.webkit.org/show_bug.cgi?id=60223
2289
2290         This required sharing a bit of code between the commit-queue
2291         (which already knew how to do this) and the new EWS testing bots.
2292
2293         In the process I also cleaned up EWS testing a little and
2294         removed some dead code from the commit-queue.
2295
2296         * Scripts/webkitpy/common/config/committervalidator.py:
2297         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2298         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2299         * Scripts/webkitpy/tool/commands/queues.py:
2300         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2301
2302 2011-05-04  James Kozianski  <koz@chromium.org>
2303
2304         Reviewed by Eric Seidel.
2305
2306         Add method to make a Port able to retrieve TestOutputSets from its builders.
2307         https://bugs.webkit.org/show_bug.cgi?id=58211
2308
2309         This will be used in the new rebaseline script - TestOutputs are
2310         potential new baselines.
2311
2312         * Scripts/webkitpy/common/config/urls.py:
2313         * Scripts/webkitpy/layout_tests/port/base.py:
2314         * Scripts/webkitpy/layout_tests/port/chromium.py:
2315         * Scripts/webkitpy/layout_tests/port/factory.py:
2316         * Scripts/webkitpy/layout_tests/port/webkit.py:
2317
2318 2011-05-04  Eric Seidel  <eric@webkit.org>
2319
2320         Reviewed by Ojan Vafai.
2321
2322         sheriff-bot can't parse results.html
2323         https://bugs.webkit.org/show_bug.cgi?id=60196
2324
2325         The problem was that the NRWT bots are currently core
2326         and so sheriff-bot was trying to diagnose failures on
2327         them.  It was trying to parse their results.html file
2328         and BeautifulSoup was throwing an exception.
2329
2330         It seems our version of BeautifulSoup was quite old
2331         and unable to handle <script> tags correctly.
2332         This moves us to 3.2 which doesn't seem to have this bug.
2333
2334         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
2335
2336 2011-05-04  Adam Barth  <abarth@webkit.org>
2337
2338         Reviewed by Eric Seidel.
2339
2340         Make the EWS test logging less verbose
2341         https://bugs.webkit.org/show_bug.cgi?id=60201
2342
2343         This should help us generate less than a hundred MB of logs per hour.
2344
2345         * Scripts/webkitpy/common/config/ports.py:
2346         * Scripts/webkitpy/common/config/ports_unittest.py:
2347
2348 2011-05-04  Tao Bai  <michaelbai@chromium.org>
2349
2350         Reviewed by David Kilzer.
2351
2352         Populate touch-icon url to FrameLoaderClient
2353         https://bugs.webkit.org/show_bug.cgi?id=59143
2354
2355         Disable touch icon by default. 
2356
2357         * Scripts/build-webkit:
2358
2359 2011-05-04  Justin Novosad  <junov@chromium.org>
2360
2361         Reviewed by Kenneth Russell.
2362
2363         [Chromium] Add gpu acceleration flags to DumpRenderTree
2364         https://bugs.webkit.org/show_bug.cgi?id=60168
2365         Adding support for command line flags 
2366         enable-accelerated-2d-canvas an
2367         enable-accelerated-drawing in DumpRenderTree.
2368
2369         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2370         (main):
2371         * DumpRenderTree/chromium/TestShell.cpp:
2372         (TestShell::TestShell):
2373         (TestShell::resetWebSettings):
2374         * DumpRenderTree/chromium/TestShell.h:
2375         (TestShell::setLegacyAccelerated2dCanvasEnabled):
2376         (TestShell::setAcceleratedDrawingEnabled):
2377         * DumpRenderTree/chromium/WebPreferences.cpp:
2378         (WebPreferences::reset):
2379         (WebPreferences::applyTo):
2380         * DumpRenderTree/chromium/WebPreferences.h:
2381
2382 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2383
2384         Reviewed by Csaba Osztrogonác.
2385
2386         [Qt] run-qtwebkit-tests misses exec bit
2387         https://bugs.webkit.org/show_bug.cgi?id=60188
2388
2389         Also removing an unecessary import (mostly to let this bugfix goes
2390         through the system, as this is just a chmod).
2391
2392         * Scripts/run-qtwebkit-tests:
2393
2394 2011-05-04  Adam Barth  <abarth@webkit.org>
2395
2396         Fix import of ircproxy module to actually import the module.  I don't
2397         really understand how this code could have worked before.
2398
2399         * Scripts/webkitpy/common/host.py:
2400
2401 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
2402
2403         Reviewed by Andreas Kling.
2404
2405         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
2406         https://bugs.webkit.org/show_bug.cgi?id=60172
2407
2408         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
2409         (BrowserWindow::BrowserWindow):
2410
2411 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
2412
2413         Reviewed by Ojan Vafai.
2414
2415         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
2416         https://bugs.webkit.org/show_bug.cgi?id=60088
2417         
2418         Makes --new-baseline put new baselines into the first entry in the
2419         baseline search path, including any additional directories passed in via
2420         --additional-platform-directory.
2421         
2422         Simplifies baseline_path() by making it return the first entry in the
2423         baseline search path instead of requiring each port to have an
2424         implementation (should not result in any behavior change).
2425
2426         * Scripts/webkitpy/layout_tests/port/base.py:
2427         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2428         * Scripts/webkitpy/layout_tests/port/chromium.py:
2429         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2430         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2431         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2432         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2433         * Scripts/webkitpy/layout_tests/port/mac.py:
2434         * Scripts/webkitpy/layout_tests/port/test.py:
2435         * Scripts/webkitpy/layout_tests/port/webkit.py:
2436
2437 2011-05-04  Adam Barth  <abarth@webkit.org>
2438
2439         Reviewed by Eric Seidel.
2440
2441         Fix circular dependency in webkitpy
2442         https://bugs.webkit.org/show_bug.cgi?id=60075
2443
2444         These functions don't belong in bugzilla.py.  They only exist there
2445         because they are old.  Really, these functions shouldn't be free
2446         functions at all, but that's a patch for another day.
2447
2448         * Scripts/webkitpy/common/checkout/changelog.py:
2449         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2450         * Scripts/webkitpy/common/checkout/checkout.py:
2451         * Scripts/webkitpy/common/config/urls.py:
2452         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2453         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2454         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2455         * Scripts/webkitpy/style/checkers/changelog.py:
2456         * Scripts/webkitpy/tool/bot/irc_command.py:
2457         * Scripts/webkitpy/tool/bot/sheriff.py:
2458         * Scripts/webkitpy/tool/commands/upload.py:
2459
2460 2011-05-03  Pratik Solanki  <psolanki@apple.com>
2461
2462         Reviewed by Dan Bernstein.
2463
2464         https://bugs.webkit.org/show_bug.cgi?id=60141
2465         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
2466
2467         * Scripts/build-webkit:
2468
2469 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
2470
2471         Reviewed by Ojan Vafai.
2472
2473         Update rebaseline queue server to handle hierarchical test results
2474         https://bugs.webkit.org/show_bug.cgi?id=60063
2475         
2476         Update test result parsing done by the rebaseline queue server to handle
2477         the hierarchical test result output that is generated as of r85254.
2478
2479         * RebaselineQueueServer/templates/builder-queue-edit.html:
2480
2481 2011-05-03  Eric Seidel  <eric@webkit.org>
2482
2483         Reviewed by Adam Roben.
2484
2485         webkit-patch post-commits HEAD^.. throws an exception
2486         https://bugs.webkit.org/show_bug.cgi?id=60027
2487
2488         * Scripts/webkitpy/common/checkout/scm/git.py:
2489
2490 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
2491
2492         Reviewed by Kenneth Rohde Christiansen.
2493
2494         [Qt] Layout tests may timeout if loadFinished receives false
2495         https://bugs.webkit.org/show_bug.cgi?id=60064
2496
2497         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
2498         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
2499         a response is ignored, like it should be for 204 responses. It is a problem for creating
2500         tests for 204 responses for example.
2501
2502         This change has been tested and it causes no regressions in layout tests.
2503
2504         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2505         (LayoutTestController::maybeDump):
2506
2507 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
2508
2509         Unreviewed, rolling out r85659.
2510         http://trac.webkit.org/changeset/85659
2511         https://bugs.webkit.org/show_bug.cgi?id=59977
2512
2513         restarting isn't working correctly
2514
2515         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2516         * Scripts/webkitpy/layout_tests/port/http_server.py:
2517         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2518         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2519
2520 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
2521
2522         Reviewed by Ojan Vafai.
2523
2524         new-run-webkit-tests: fix http server startup/shutdown
2525
2526         Previous versions of the code had three problems that made startup
2527         and shutdown flaky. The first is that it would throw exceptions
2528         if it couldn't delete stale log files, which was overly
2529         paranoid. The second is that some of the exceptions weren't
2530         defined properly. The third, and most important, is that it was
2531         using urllib to check if ports were available, which was leaving
2532         sockets in a half-closed state, and keeping ports from being
2533         reused. By switching to raw sockets, we are able to now reliably
2534         restart.
2535
2536         This change also switches the code to using Executives to stop
2537         processes, which will let us delete a bunch of code in the
2538         port/* implementations and fix a weird layering problem in a
2539         subsequent patch.
2540
2541         https://bugs.webkit.org/show_bug.cgi?id=59977
2542
2543         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2544         * Scripts/webkitpy/layout_tests/port/http_server.py:
2545         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2546         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2547
2548 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
2549
2550         Reviewed by Adam Barth.
2551
2552         fix failing printing_unittest on win32
2553         https://bugs.webkit.org/show_bug.cgi?id=59963
2554
2555         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2556
2557 2011-05-03  Adam Roben  <aroben@apple.com>
2558
2559         Fix most strict PassOwnPtr violations on Windows
2560
2561         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
2562         enabled
2563
2564         Reviewed by Anders Carlsson.
2565
2566         * WebKitAPITest/Test.h: Use adoptPtr.
2567
2568 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2569
2570         Reviewed by Andreas Kling.
2571
2572         Add myself to the committers list.
2573
2574         * Scripts/webkitpy/common/config/committers.py:
2575
2576 2011-05-03  James Robinson  <jamesr@chromium.org>
2577
2578         Reviewed by Kenneth Russell.
2579
2580         [chromium] Layout test animations/3d/replace-filling-transform.html failing
2581         https://bugs.webkit.org/show_bug.cgi?id=59839
2582
2583         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
2584
2585         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2586
2587 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2588
2589         Unreviewed, rolling out r85471.
2590         http://trac.webkit.org/changeset/85471
2591         https://bugs.webkit.org/show_bug.cgi?id=59922
2592
2593         The rule of thumb in EFL is that you init in all the places
2594         you use it. So, if in your application you call ecore_evas_*
2595         functions, you have to call ecore_evas_init() first.
2596
2597         * EWebLauncher/main.c: always call *_init() functions when you use
2598         that namespace.
2599         (quit):
2600         (main):
2601
2602 2011-05-02  Ojan Vafai  <ojan@chromium.org>
2603
2604         Reviewed by Tony Chang.
2605
2606         remove no longer used method
2607         https://bugs.webkit.org/show_bug.cgi?id=59981
2608
2609         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2610         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2611
2612 2011-05-02  Ojan Vafai  <ojan@chromium.org>
2613
2614         Reviewed by Tony Chang.
2615
2616         add image toggling behavior from old-run-webkit-tests
2617         https://bugs.webkit.org/show_bug.cgi?id=59978
2618
2619         Output -diffs.html files. This matches old-run-webkit-tests.
2620         In theory, we could use data urls in the results.html file, but
2621         data urls don't currently have access to local files.
2622
2623         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2624
2625 2011-05-02  Tony Chang  <tony@chromium.org>
2626
2627         Reviewed by Ojan Vafai.
2628
2629         [nrwt] remove some obsolete references to .checksum files
2630         https://bugs.webkit.org/show_bug.cgi?id=59971
2631
2632         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2633         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2634         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2635         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2636         * Scripts/webkitpy/layout_tests/port/test.py:
2637         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2638
2639 2011-05-02  Adam Roben  <aroben@apple.com>
2640
2641         Take advantage of implicit nullptr_t -> PassOwnPtr conversion
2642
2643         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
2644         doesn't work, but should
2645
2646         Reviewed by Adam Barth.
2647
2648         * DumpRenderTree/chromium/CppBoundClass.h:
2649         * DumpRenderTree/chromium/WebViewHost.cpp:
2650
2651 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2652
2653         Reviewed by Xan Lopez.
2654
2655         [GTK] Compiler warning in Tools/MiniBrowser/main.c
2656         https://bugs.webkit.org/show_bug.cgi?id=59986
2657
2658         Remove a compiler warning.
2659
2660         * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
2661         from complaining.
2662
2663 2011-05-02  Adam Barth  <abarth@webkit.org>
2664
2665         Reviewed by Eric Seidel.
2666
2667         Add runtests_unittest.py
2668         https://bugs.webkit.org/show_bug.cgi?id=59955
2669
2670         I forgot to add this file in a previous patch.
2671
2672         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
2673
2674 2011-05-02  Adam Barth  <abarth@webkit.org>
2675
2676         Change the testing EWS to log failures explicitly to avoid an infinite loop.
2677
2678         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2679
2680 2011-05-02  Adrienne Walker  <enne@google.com>
2681
2682         Unreviewed, fix misspelled contributor name.
2683
2684         * Scripts/webkitpy/common/config/committers.py:
2685
2686 2011-05-02  Adam Barth  <abarth@webkit.org>
2687
2688         Reviewed by Eric Seidel.
2689
2690         cr-linux-ews should run tests
2691         https://bugs.webkit.org/show_bug.cgi?id=59272
2692
2693         This patch turns on testing for the cr-linux-ews.  Yay!
2694
2695         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2696         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2697         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2698         * Scripts/webkitpy/tool/steps/runtests.py:
2699         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2700
2701 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2702
2703         Incorporate a review comment that I mistakenly omitted from my last commit.
2704
2705         * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
2706
2707 2011-05-02  Adam Barth  <abarth@webkit.org>
2708
2709         Reviewed by Eric Seidel.
2710
2711         EWS should report the list of unexpected failures
2712         https://bugs.webkit.org/show_bug.cgi?id=59923
2713
2714         We cache the results of the first layout test results run on the task
2715         so the EWS can grab them later.  Another option is to include them in
2716         the exception that's thrown, but this approach seemed slightly more
2717         aesthetic.
2718
2719         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2720         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2721
2722 2011-05-02  Adam Barth  <abarth@webkit.org>
2723
2724         Reviewed by Eric Seidel.
2725
2726         Add base case for a test-running EWS
2727         https://bugs.webkit.org/show_bug.cgi?id=59920
2728
2729         Later I will subclass this to run the Chromium Linux EWS.
2730
2731         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
2732         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2733         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2734
2735 2011-05-02  Anders Carlsson  <andersca@apple.com>
2736
2737         Build fix.
2738
2739         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2740         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2741
2742 2011-05-02  Nico Weber  <thakis@chromium.org>
2743
2744         Reviewed by Mihai Parparita.
2745
2746         Add --no-webkit2 to the output of "build-webkit -h"
2747         https://bugs.webkit.org/show_bug.cgi?id=59942
2748
2749         * Scripts/build-webkit:
2750
2751 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2752
2753         Reviewed by Xan Lopez.
2754
2755         [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
2756         https://bugs.webkit.org/show_bug.cgi?id=59943
2757
2758         Disable the Ubuntu overlay scrollbar while testing, by injecting the
2759         LIBOVERLAY_SCROLLBAR=0 environment variable.
2760
2761         * Scripts/old-run-webkit-tests:
2762
2763 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
2764
2765         Reviewed by Eric Seidel.
2766
2767         [GTK] editing/selection/select-out-of-editable.html failing after r83967
2768         https://bugs.webkit.org/show_bug.cgi?id=58667
2769
2770         Do not trigger mouse down events when the EventSender knows that a mouse button is
2771         already down. These type of situations can confuse Xvfb and cause dragging failures.
2772
2773         * DumpRenderTree/gtk/EventSender.cpp:
2774         (mouseDownCallback): Do not trigger another mouse button down event if the mouse button
2775         is already down. This can interfere with drags in Xvfb.
2776
2777 2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2778
2779         Reviewed by Csaba Osztrogonác.
2780
2781         DRT sideeffect revealed by r71268.
2782         https://bugs.webkit.org/show_bug.cgi?id=48958
2783
2784         Reset QWebSettings::ZoomTextOnly attribute before all tests. 
2785
2786         Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and 
2787         PageZoomFactor too. It should be done before resetsettings() 
2788         to guarantee resetting QWebSettings::ZoomTextOnly correctly.
2789
2790         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2791         (WebCore::WebPage::resetSettings):
2792         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2793
2794 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2795
2796         Unreviewed, rolling out r85469.
2797         http://trac.webkit.org/changeset/85469
2798         https://bugs.webkit.org/show_bug.cgi?id=59928
2799
2800         Broke  webkitpy-tests on Windows 7, GTK and Qt. (Requested by
2801         bbandix on #webkit).
2802
2803         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
2804         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2805         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2806
2807 2011-05-02  Tomasz Morawski  <t.morawski@samsung.com>
2808
2809         Reviewed by Kenneth Rohde Christiansen.
2810
2811         Cleanup EFL initialization/shutdown in the EWebLauncher
2812         https://bugs.webkit.org/show_bug.cgi?id=59922
2813
2814         Removed ecore_evas_init and edje_init form main function due to they
2815         are also called in the ewk_init. Moved ewk_shutdown to quit function.
2816
2817         * EWebLauncher/main.c:
2818         (quit):
2819         (main):
2820
2821 2011-05-02  Adam Barth  <abarth@webkit.org>
2822
2823         Reviewed by Eric Seidel.
2824
2825         Add base case for a test-running EWS
2826         https://bugs.webkit.org/show_bug.cgi?id=59920
2827
2828         Later I will subclass this to run the Chromium Linux EWS.
2829
2830         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
2831         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2832         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2833
2834 2011-05-02  Adam Barth  <abarth@webkit.org>
2835
2836         Reviewed by Eric Seidel.
2837
2838         Add the ability to skip python and perl unit tests on EC2
2839         https://bugs.webkit.org/show_bug.cgi?id=59918
2840
2841         * Scripts/webkitpy/common/config/ports.py:
2842             - This is slightly ugly, but it's useful...
2843         * Scripts/webkitpy/common/config/ports_unittest.py:
2844         * Scripts/webkitpy/tool/mocktool.py:
2845         * Scripts/webkitpy/tool/steps/runtests.py:
2846
2847 2011-05-02  Adam Barth  <abarth@webkit.org>
2848
2849         Reviewed by Eric Seidel.
2850
2851         webkit-patch --non-interactive is incompatible with new-run-webkit-tests
2852         https://bugs.webkit.org/show_bug.cgi?id=59919
2853
2854         new-run-webkit-tests doesn't support --wait-for-httpd (because it
2855         always waits for HTTPD, as I understand things).  It turns out we're
2856         not really using this flag for anything, so we should just remove it.
2857
2858         * Scripts/webkitpy/tool/steps/runtests.py:
2859         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2860
2861 2011-05-01  Eric Seidel  <eric@webkit.org>
2862
2863         Reviewed by Adam Barth.
2864
2865         The bots should learn from expected failures without having to retry
2866         https://bugs.webkit.org/show_bug.cgi?id=59279
2867
2868         Rather than re-trying the whole patch, we can just check whether we now
2869         expect the failures we see with the patch applied, saving a lot of time.
2870
2871         This patch also teaches the CommitQueue how to reject patches even
2872         when the tree is red using the new unexpected_failures() method on
2873         ExpectedFailures.
2874
2875         Finally in testing we found a bug in ExpectedFailures where it would
2876         "trust" results which had many many failures, due to using an
2877         equal sign instead of a less-than sign.
2878
2879         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
2880         * Scripts/webkitpy/tool/bot/expectedfailures.py
2881         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
2882         * Scripts/webkitpy/tool/bot/patchanalysistask.py
2883
2884
2885 2011-05-02  Adam Barth  <abarth@webkit.org>
2886
2887         Reviewed by Eric Seidel.
2888
2889         workspace.py fails to import ScriptError
2890         https://bugs.webkit.org/show_bug.cgi?id=59915
2891
2892         If the workspace fails to create a zip, webkitpy crashes instead of
2893         handling the error as expected.
2894
2895         * Scripts/webkitpy/common/system/workspace.py:
2896         * Scripts/webkitpy/common/system/workspace_unittest.py:
2897         * Scripts/webkitpy/tool/mocktool.py:
2898
2899 2011-05-01  Adam Barth  <abarth@webkit.org>
2900
2901         Remove unadvertantly added file.
2902
2903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2904
2905 2011-05-01  Adam Barth  <abarth@webkit.org>
2906
2907         Reviewed by Eric Seidel.
2908
2909         expectedfailures.py should report the unexpected failures when asked
2910         https://bugs.webkit.org/show_bug.cgi?id=59916
2911
2912         This information is useful when the EWS runs tests.
2913
2914         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2915         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2916
2917 2011-05-01  Adam Barth  <abarth@webkit.org>
2918
2919         Reviewed by Eric Seidel.
2920
2921         JSONTestResult needs to handle multiple results
2922         https://bugs.webkit.org/show_bug.cgi?id=59269
2923
2924         This case occurs when a test is flaky because NRWT will run the test
2925         twice and report both results as "actual."
2926
2927         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2928         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2929
2930 2011-05-01  Adam Barth  <abarth@webkit.org>
2931
2932         Reviewed by Eric Seidel.
2933
2934         Move checkout/api.py to checkout/checkout.py
2935         https://bugs.webkit.org/show_bug.cgi?id=59906
2936
2937         This is more consistent with Python style.
2938
2939         * Scripts/webkitpy/common/checkout/__init__.py:
2940         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2941         * Scripts/webkitpy/common/host.py:
2942         * Scripts/webkitpy/tool/main.py:
2943
2944 2011-05-01  Eric Seidel  <eric@webkit.org>
2945
2946         Reviewed by Adam Barth.
2947
2948         scm.py should be split into many pieces
2949         https://bugs.webkit.org/show_bug.cgi?id=59908
2950
2951         Forgot an AuthenticationError import.
2952
2953         * Scripts/webkitpy/common/checkout/scm/git.py:
2954         * Scripts/webkitpy/common/checkout/scm/svn.py:
2955
2956 2011-05-01  Arno Renevier  <arno@renevier.net>
2957
2958         Reviewed by Eric Seidel.
2959
2960         wrong exception raised in Lighttpd start method
2961         https://bugs.webkit.org/show_bug.cgi?id=59283
2962
2963         raise standard Exception instead of non existent
2964         google.httpd_utils.HttpdNotStarted
2965
2966         * Scripts/webkitpy/layout_tests/port/http_server.py:
2967
2968 2011-05-01  Eric Seidel  <eric@webkit.org>
2969
2970         Reviewed by Adam Barth.
2971
2972         scm.py should be split into many pieces
2973         https://bugs.webkit.org/show_bug.cgi?id=59908
2974
2975         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2976         * Scripts/webkitpy/common/checkout/scm/commitmessage.py: Added.
2977         * Scripts/webkitpy/common/checkout/scm/git.py: Added.
2978         * Scripts/webkitpy/common/checkout/scm/scm.py:
2979         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2980         * Scripts/webkitpy/common/checkout/scm/svn.py: Added.
2981
2982 2011-05-01  Eric Seidel  <eric@webkit.org>
2983
2984         Reviewed by Adam Barth.
2985
2986         Make most scm.py tests pass in preparation for splitting them up
2987         https://bugs.webkit.org/show_bug.cgi?id=59904
2988
2989         There is one remaining failure:
2990         webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
2991         which identifies a difference between the SVN and Git versions of the
2992         SCM api.  I'm not going to bother fixing that until we split out all
2993         the tests.
2994
2995         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2996
2997 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
2998
2999         [WIN] Unreviewed buildfix after r85440.
3000
3001         * DumpRenderTree/win/UIDelegate.cpp:
3002         (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
3003
3004 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3005
3006         [WIN] Unreviewed buildfix after r85434.
3007
3008         * DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
3009         * DumpRenderTree/win/UIDelegate.cpp: Ditto.
3010
3011 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
3012
3013         [WIN] Unreviewed buildfix after r85434.
3014
3015         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3016         (FrameLoadDelegate::FrameLoadDelegate):
3017         * DumpRenderTree/win/UIDelegate.cpp:
3018         (DRTUndoManager::DRTUndoManager):
3019         (UIDelegate::UIDelegate):
3020         (UIDelegate::resetUndoManager):
3021
3022 2011-05-01  Eric Seidel  <eric@webkit.org>
3023
3024         Reviewed by Adam Barth.
3025
3026         Move scm.py into its own module in preparation for splitting it up
3027         https://bugs.webkit.org/show_bug.cgi?id=59884
3028
3029         * Scripts/webkitpy/common/checkout/scm/__init__.py: Added.
3030         * Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
3031         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
3032         * Scripts/webkitpy/test/main.py:
3033
3034 2011-05-01  Adam Barth  <abarth@webkit.org>
3035
3036         Reviewed by Eric Seidel.
3037
3038         webkit-patch fails when not run from root
3039         https://bugs.webkit.org/show_bug.cgi?id=59882
3040
3041         We need to set the CWD when running svn so that svn interprets file
3042         paths relative to the root of the working copy.
3043
3044         * Scripts/webkitpy/common/checkout/scm.py:
3045
3046 2011-04-29  Eric Seidel  <eric@webkit.org>
3047
3048         Reviewed by Adam Barth.
3049
3050         land-safely patches should show show their place in the commit-queue
3051         https://bugs.webkit.org/show_bug.cgi?id=59853
3052
3053         This complicated the "should we show the bubbles or the submit-to-ews button"
3054         logic substantially. :(  But now we'll show both the commit-queue position
3055         as well as the submit-to-ews button for land-safely (cq+ only) patches.
3056         Previously we would only show the submit-to-ews button.
3057
3058         * QueueStatusServer/handlers/statusbubble.py:
3059         * QueueStatusServer/templates/statusbubble.html:
3060
3061 2011-04-29  Naoki Takano  <takano.naoki@gmail.com>
3062
3063         Reviewed by Adam Barth.
3064
3065         Add my name to contributers.
3066         https://bugs.webkit.org/show_bug.cgi?id=59854
3067
3068         * Scripts/webkitpy/common/config/committers.py:
3069
3070 2011-04-29  Keith Kyzivat  <keith.kyzivat@nokia.com>
3071
3072         Reviewed by Csaba Osztrogonác.
3073
3074         [Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0
3075         https://bugs.webkit.org/show_bug.cgi?id=59772
3076
3077         * Tools.pro:
3078
3079 2011-04-29  Stephanie Lewis  <slewis@apple.com>
3080
3081         Rubber-stamped by Adam Roben.   
3082
3083         Remove the production configuration guard since installs only happen in production anyway.  
3084         Works around a bug in Xcode
3085
3086         * DumpRenderTree/mac/PerlSupport/Makefile:
3087
3088 2011-04-29  Adam Roben  <aroben@apple.com>
3089
3090         Remove a PHP setting that is now provided by httpd.conf
3091
3092         r85155 added this setting, but putting it in httpd.conf makes more sense (since the setting
3093         isn't dependent on paths that could be different on each user's machine).
3094
3095         Reviewed by Sam Weinig.
3096
3097         * Scripts/webkitperl/httpd.pm:
3098         (getDefaultConfigForTestDirectory): Removed log_errors setting.
3099
3100 2011-04-29  Jon Lee  <jonlee@apple.com>
3101
3102         Unreviewed, Adding Jon Lee as a committer
3103
3104         * Scripts/webkitpy/common/config/committers.py:
3105
3106 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3107
3108         Reviewed by Tony Chang.
3109
3110         fix pretty_patch_available and wdiff_available
3111         https://bugs.webkit.org/show_bug.cgi?id=59761
3112
3113         These methods rely on the check_* method being called first.
3114         This would only happen when we actually tried to compute a diff,
3115         but computing the diff happens on a different process.
3116         
3117         Also fix setting _wdiff_avialable to True by default.
3118
3119         * Scripts/webkitpy/layout_tests/port/base.py:
3120         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3121         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3122
3123 2011-04-29  Ojan Vafai  <ojan@chromium.org>
3124
3125         Reviewed by Eric Seidel.
3126
3127         exclude skipped tests from the summarized results
3128         https://bugs.webkit.org/show_bug.cgi?id=59813
3129
3130         If we find a need fo skipped tests later, we should either create
3131         a skipped.json file or expose this some other way. As it is, the data
3132         is unused and is hugely bloating the size of full_results.json.
3133
3134         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3135
3136 2011-04-29  Adam Roben  <aroben@apple.com>
3137
3138         Make DumpRenderTreeSupport get installed when the default configuration is built
3139
3140         The default configuration is Production, but in that case the CONFIGURATION environment
3141         variable is set to the empty string.
3142
3143         Reviewed by Sam Weinig.
3144
3145         * DumpRenderTree/mac/PerlSupport/Makefile: Set CONFIGURATION to Production if it isn't
3146         already set so that later logic that depends on CONFIGURATION having that value will work.
3147
3148 2011-04-29  Dean Jackson  <dino@apple.com>
3149
3150         Reviewed by Simon Fraser.
3151
3152         Add ENABLE macro for WebKitAnimation
3153         https://bugs.webkit.org/show_bug.cgi?id=59729
3154
3155         Add new feature to toggle WebKit Animation API.
3156
3157         * Scripts/build-webkit:
3158
3159 2011-04-29  Sam Weinig  <sam@webkit.org>
3160
3161         Reviewed by Adam Roben.
3162
3163         Make production the default build type for WebKitTestRunner, matching
3164         all other projects.
3165
3166         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3167
3168 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
3169
3170         [wx] Unreviewed build fix, add new directory to the build.
3171
3172         * waf/build/settings.py:
3173
3174 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3175
3176         Reviewed by Martin Robinson.
3177
3178         [GTK] Implement UI client in minibrowser
3179         https://bugs.webkit.org/show_bug.cgi?id=58416
3180
3181         It also allows to open more than one minibrowser window from the
3182         command line.
3183
3184         * MiniBrowser/gtk/BrowserWindow.c:
3185         (browserWindowFinalize):
3186         (browser_window_init):
3187         (browserWindowConstructed):
3188         (createNewPage):
3189         (showPage):
3190         (closePage):
3191         (runJavaScriptAlert):
3192         (browserWindowUIClientInit):
3193         * MiniBrowser/gtk/main.c:
3194         (loadURI):
3195         (main):
3196
3197 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3198
3199         Reviewed by Martin Robinson.
3200
3201         [GTK] Implement page loader client in MiniBrowser
3202         https://bugs.webkit.org/show_bug.cgi?id=58024
3203
3204         A new class BrowserWindow has been added to implement the page
3205         loader client. It makes supporting multiple windows easier. Window
3206         title and url entry are now updated during the loading process.
3207
3208         * MiniBrowser/gtk/BrowserWindow.c: Added.
3209         (activateUriEntryCallback):
3210         (goBackCallback):
3211         (goForwardCallback):
3212         (browserWindowFinalize):
3213         (browserWindowGetProperty):
3214         (browserWindowSetProperty):
3215         (browser_window_init):
3216         (browserWindowConstructed):
3217         (browser_window_class_init):
3218         (browserWindowUpdateTitle):
3219         (browserWindowSetTitle):
3220         (browserWindowSetLoadProgress):
3221         (browserWindowUpdateURL):
3222         (didStartProvisionalLoadForFrame):
3223         (didReceiveServerRedirectForProvisionalLoadForFrame):
3224         (didFailProvisionalLoadWithErrorForFrame):
3225         (didCommitLoadForFrame):
3226         (didFinishDocumentLoadForFrame):
3227         (didFinishLoadForFrame):
3228         (didFailLoadWithErrorForFrame):
3229         (didReceiveTitleForFrame):
3230         (didFirstLayoutForFrame):
3231         (didFirstVisuallyNonEmptyLayoutForFrame):
3232         (didRemoveFrameFromHierarchy):
3233         (didStartProgress):
3234         (didChangeProgress):
3235         (didFinishProgress):
3236         (didBecomeUnresponsive):
3237         (didBecomeResponsive):
3238         (browserWindowLoaderClientInit):
3239         (browser_window_new):
3240         (browser_window_get_view):
3241         * MiniBrowser/gtk/BrowserWindow.h: Added.
3242         * MiniBrowser/gtk/GNUmakefile.am:
3243         * MiniBrowser/gtk/main.c:
3244         (createWindow):
3245
3246 2011-04-28  Stephanie Lewis  <slewis@apple.com>
3247
3248         Reviewed by Mark Rowe.
3249
3250         http://bugs.webkit.org/show_bug.cgi?id=59743
3251         <rdar://problem/9040413> Add an install target for production builds.
3252
3253         * DumpRenderTree/mac/PerlSupport/Makefile:
3254
3255 2011-04-28  Adam Roben  <aroben@apple.com>
3256
3257         Stop and restart ATSServer before each test run on Leopard
3258
3259         This is to work around an ATSServer leak that eventually causes tests
3260         to fail.
3261
3262         Fixes <http://webkit.org/b/51807> <rdar://problem/9273894>
3263         fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots
3264         (due to ATSServer leak)
3265
3266         Reviewed by Dan Bernstein.
3267
3268         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3269         (StopATSServer):
3270         (StartATSServer):
3271         Added these new commands to stop and start ATSServer.
3272
3273         (TestFactory.__init__): Stop and start ATSServer on Leopard before running tests.
3274
3275 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
3276
3277         Reviewed by Adam Roben.
3278
3279         add Leopard NRWT bot to the scheduler
3280         https://bugs.webkit.org/show_bug.cgi?id=59766
3281
3282         * BuildSlaveSupport/build.webkit.org-config/config.json:
3283
3284 2011-04-28  Sam Weinig  <sam@webkit.org>
3285
3286         Fix WebKitTestRunner build.
3287
3288         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3289         The Derived Sources target needs a product name.
3290
3291 2011-04-28  Sam Weinig  <sam@webkit.org>
3292
3293         Reviewed by Mark Rowe.
3294
3295         Add install support for WebKitTestRunner.
3296         <rdar://problem/9349055>
3297
3298         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3299         Add missing CompilerVersion.xcconfig.
3300
3301         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3302         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3303         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3304         Add install path and tell it not to skip installation.
3305
3306         Add missing CompilerVersion.xcconfig.
3307
3308 2011-04-28  David Levin  <levin@chromium.org>
3309
3310         Reviewed by Adam Barth.
3311
3312         Remove IMAGE_RESIZER related code.
3313         https://bugs.webkit.org/show_bug.cgi?id=59735
3314
3315         * Scripts/build-webkit:
3316
3317 2011-04-28  Sam Weinig  <sam@webkit.org>
3318
3319         Reviewed by Adam Roben.
3320
3321         Make reading skipped files from additional platform
3322         directories work in WebKit2 mode.
3323
3324         * Scripts/old-run-webkit-tests:
3325         (buildPlatformTestHierarchy): Simplify logic to always use the first
3326         and last platforms in the build hierarchy as the test hierarchy, and to
3327         insert the WebKit2 platform in the middle if it exists. Yum.
3328
3329 2011-04-28  Adam Barth  <abarth@webkit.org>
3330
3331         Reviewed by Eric Seidel.
3332
3333         Remove WML
3334         https://bugs.webkit.org/show_bug.cgi?id=59678
3335
3336         Remove build system integration and test harness integration for WML.
3337
3338         * Scripts/build-webkit:
3339         * Scripts/old-run-webkit-tests:
3340         * Scripts/webkitperl/features.pm:
3341         * Scripts/webkitpy/layout_tests/port/webkit.py:
3342         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3343
3344 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3345
3346         Reviewed by Mihai Parparita.
3347
3348         use a hierarchical data structure to store results json
3349         https://bugs.webkit.org/show_bug.cgi?id=59736
3350
3351         Instead of a map from test name to results dict, we now store a hierarchical
3352         data structure.
3353
3354         Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
3355         New:
3356         { foo: {
3357             bar: {
3358               baz.html: results_dict,
3359               baz2.html: results_dict } } }
3360
3361         This cut ~52% of the size of times_ms.json. I expect it will cut
3362         30-40% of full_results.json and unexpected_results.json.
3363
3364         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3365         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3366         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3367         Using os.sep was just wrong since relative_test_filename canonicalizes separators.
3368         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3369         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3370         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3371         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3372         Instead of plumbing through the change to all of the rebaselineserver
3373         python and JS, just convert to the old format after reading in the json.
3374
3375 2011-04-28  Eric Seidel  <eric@webkit.org>
3376
3377         Reviewed by Adam Barth.
3378
3379         EWS Bubbles should show commit-queue position when patch is in the commit-queue
3380         https://bugs.webkit.org/show_bug.cgi?id=59744
3381
3382         Add target="_top" to the bubble links.  This was
3383         forgotten when I moved from using an onclick to a normal link.
3384
3385         * QueueStatusServer/templates/statusbubble.html:
3386
3387 2011-04-28  Eric Seidel  <eric@webkit.org>
3388
3389         Reviewed by Adam Barth.
3390
3391         EWS bubbles should show "submit to ews" button if they've not been processed
3392         https://bugs.webkit.org/show_bug.cgi?id=59751
3393
3394         * QueueStatusServer/handlers/statusbubble.py:
3395         * QueueStatusServer/handlers/submittoews.py:
3396         * QueueStatusServer/templates/statusbubble.html:
3397         * QueueStatusServer/templates/submittoews.html:
3398
3399 2011-04-28  Eric Seidel  <eric@webkit.org>
3400
3401         Reviewed by Adam Barth.
3402
3403         EWS Bubbles should show commit-queue position when patch is in the commit-queue
3404         https://bugs.webkit.org/show_bug.cgi?id=59744
3405
3406         This was actually just a 2 line change to statusbubble.py.
3407         I also cleaned up statusbubble.html a little while I was there
3408         (the links are now actual <a> tags and have hover).
3409
3410         * QueueStatusServer/handlers/statusbubble.py:
3411         * QueueStatusServer/templates/statusbubble.html:
3412
3413 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
3414
3415         Reviewed by Eric Seidel.
3416
3417         add a mac leopard release NRWT bot
3418         https://bugs.webkit.org/show_bug.cgi?id=59733
3419
3420         * BuildSlaveSupport/build.webkit.org-config/config.json:
3421
3422 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3423
3424         Avoid crashing when running new-run-webkit-tests outside of
3425         version control.
3426
3427         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3428
3429 2011-04-28  Xan Lopez  <xlopez@igalia.com>
3430
3431         Unreviewed build fix.
3432
3433         * GNUmakefile.am:
3434
3435 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3436
3437         Reviewed by Eric Seidel.
3438
3439         fix python printing test
3440         https://bugs.webkit.org/show_bug.cgi?id=59719
3441
3442         Now that we run scm commands in summarize_results, --verbose prints
3443         debug logging to stderr.
3444
3445         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3446
3447 2011-04-28  Ojan Vafai  <ojan@chromium.org>
3448
3449         Reviewed by Tony Chang.
3450
3451         link to tests at a specific revision in the results.html file
3452         https://bugs.webkit.org/show_bug.cgi?id=59711
3453
3454         * Scripts/webkitpy/common/checkout/scm.py:
3455         Add a method to get the head svn revision.
3456         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3457         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3458         Include the svn revision in the results json.
3459
3460 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3461
3462         Reviewed by Sam Weinig.
3463
3464         [GTK] Remove WKURLCreateWithURL()
3465         https://bugs.webkit.org/show_bug.cgi?id=59691
3466
3467         Use WKURLCreateWithUTF8CString() instead of WKURLCreateWithURL().
3468
3469         * MiniBrowser/gtk/main.c:
3470         (activateUriEntryCallback):
3471         (main):
3472
3473 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3474
3475         Reviewed by Martin Robinson.
3476
3477         [GTK] WKView should be a GtkWidget
3478         https://bugs.webkit.org/show_bug.cgi?id=59603
3479
3480         Don't use WKViewGetWindow(), use WKView as a GtkWidget instead.
3481
3482         * MiniBrowser/gtk/main.c:
3483         (createWindow):
3484         (main):
3485
3486 2011-04-28  Gabor Rapcsanyi  <rgabor@webkit.org>
3487
3488         Reviewed by Csaba Osztrogonác.
3489
3490         [Qt] Add ARM specific Skipped list
3491         https://bugs.webkit.org/show_bug.cgi?id=59680
3492
3493         * Scripts/old-run-webkit-tests:
3494         * Scripts/webkitdirs.pm:
3495
3496 2011-04-27  Eric Seidel  <eric@webkit.org>
3497
3498         Reviewed by Adam Barth.
3499
3500         error_log.txt should include PHP errors
3501         https://bugs.webkit.org/show_bug.cgi?id=59643
3502
3503         Turns out this was really easy after I finally learned
3504         enough about PHP to do it...
3505
3506         I'm adding this in hopes of better tracking down
3507         our random http failures.
3508
3509         * Scripts/webkitperl/httpd.pm:
3510
3511 2011-04-27  David Levin  <levin@chromium.org>
3512
3513         Reviewed by Adam Barth.
3514
3515         check-webkit-style should flags spacing errors for braces on the same line.
3516         https://bugs.webkit.org/show_bug.cgi?id=59665
3517
3518         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
3519         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for the check
3520           and fixed some test cases to not trigger this error since it isn't what they are verifying.
3521
3522 2011-04-27  David Levin  <levin@chromium.org>
3523
3524         Reviewed by Adam Barth.
3525
3526         check-webkit-style error for spaces after periods in a comment has a bad error
3527         message and warns about end of line spaces.
3528         https://bugs.webkit.org/show_bug.cgi?id=59663
3529
3530         * Scripts/webkitpy/style/checkers/cpp.py: Fix both issues.
3531         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for spaces at the end of line
3532         and changed the error messages.
3533
3534 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3535
3536         remove assertion now that platform/mac-tiger no longer exists
3537         https://bugs.webkit.org/show_bug.cgi?id=59660
3538
3539         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3540
3541 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3542
3543         Reviewed by Eric Seidel.
3544
3545         remove test that didn't make sense
3546         https://bugs.webkit.org/show_bug.cgi?id=59658
3547
3548         It was artifically saying the test wasn't expected to pass,
3549         but the expectations string was empty. The case of unexpected
3550         passes with a real expectations string is tested later in the
3551         same test.
3552
3553         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3554
3555 2011-04-27  Sam Weinig  <sam@webkit.org>
3556
3557         Reviewed by Adam Roben.
3558
3559         WebKit2 needs to notify the client when a plugin fails to initialize
3560         https://bugs.webkit.org/show_bug.cgi?id=59657
3561
3562         * MiniBrowser/mac/BrowserWindowController.m:
3563         (-[BrowserWindowController awakeFromNib]):
3564         * WebKitTestRunner/TestController.cpp:
3565         (WTR::TestController::initialize):
3566         Add stubs.
3567
3568 2011-04-26  Sam Weinig  <sam@webkit.org>
3569
3570         Reviewed by David Levin.
3571
3572         Add a few more missing options to new-run-webkit-tests
3573         https://bugs.webkit.org/show_bug.cgi?id=59567
3574
3575         Add support for:
3576             --threaded
3577             --gc-between-tests
3578             --complex-text
3579
3580         * Scripts/webkitpy/layout_tests/port/webkit.py:
3581         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3582         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3583
3584 2011-04-27  Mark Rowe  <mrowe@apple.com>
3585
3586         Build fix.
3587
3588         Fix an OwnPtr-related issue that was missed before the strictness was turned on.
3589         
3590         * WebKitTestRunner/TestController.cpp:
3591         (WTR::TestController::runTest):
3592
3593 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3594
3595         Forgot to upload the new times_ms.json file after splitting
3596         it out from full_results.json.
3597
3598         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3599
3600 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3601
3602         Fix snafu in generating the JSON for the chromium tests.
3603
3604         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3605
3606 2011-04-27  Ojan Vafai  <ojan@chromium.org>
3607
3608         Fix bad merge. This broke the chromium tests generating JSON files.
3609         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3610
3611 2011-04-27  Mark Rowe  <mrowe@apple.com>
3612
3613         Rubber-stamped by Geoff Garen.
3614
3615         Don't look for results in a location that no longer exists.
3616
3617         * Scripts/old-run-webkit-tests:
3618
3619 2011-04-27  Adrienne Walker  <enne@google.com>
3620
3621         Unreviewed, add Chrome GPU folks to contributors that I'm tired of manually CCing
3622
3623         * Scripts/webkitpy/common/config/committers.py:
3624
3625 2011-04-22  Ojan Vafai  <ojan@chromium.org>
3626
3627         Reviewed by Tony Chang.
3628
3629         only include failures in full_results.json
3630         https://bugs.webkit.org/show_bug.cgi?id=59256
3631
3632         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3633
3634 2011-04-22  Ojan Vafai  <ojan@chromium.org>
3635
3636         Reviewed by Adam Roben.
3637
3638         move times into their own json file
3639         https://bugs.webkit.org/show_bug.cgi?id=59239
3640
3641         The test runtimes are the only case where we need an entry for
3642         every test that was run, including passing tests. Move them into
3643         their own json file so we can prune the other json files to only
3644         include failing tests.
3645
3646         Use a trie-like data structure to hold the tests to avoid including
3647         full test paths. This cuts 52% of the filesize. The end result is ~700k
3648         pre-gzip.
3649
3650         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3651         Exclude times from the parsed TestResults.
3652         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3653         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3654         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3655         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3656
3657 2011-04-27  Anders Carlsson  <andersca@apple.com>
3658
3659         More casts and more clang++ build fixes.
3660
3661         * DumpRenderTree/mac/DumpRenderTree.mm:
3662         (createWebViewAndOffscreenWindow):
3663         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3664         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3665         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3666         (WTR::PlatformWebView::PlatformWebView):
3667
3668 2011-04-27  Tony Chang  <tony@chromium.org>
3669
3670         Reviewed by Ojan Vafai.
3671
3672         lazily autoinstall thirdparty python libraries
3673         https://bugs.webkit.org/show_bug.cgi?id=55723
3674
3675         This helps by only having pywebsocket installed when the bots run.  It