[Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPoo...
[WebKit-https.git] / Tools / ChangeLog
1 2018-08-02  Sihui Liu  <sihui_liu@apple.com>
2
3         [Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPool created but not used
4         https://bugs.webkit.org/show_bug.cgi?id=188209
5
6         Reviewed by Geoffrey Garen.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
9         (TEST):
10
11 2018-08-02  Dan Bernstein  <mitz@apple.com>
12
13         Fixed WebKit.AttrStyle timing out on build.webkit.org.
14
15         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Changed from a URL that requires network
16           access to one that doesn’t.
17         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
18         (TEST): Updated expected value.
19
20 2018-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
21
22         [iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
23         https://bugs.webkit.org/show_bug.cgi?id=188251
24         <rdar://problem/37842108>
25
26         Reviewed by Tim Horton.
27
28         Adds a new API test to verify that clients (in this case, UIKit) is allowed to invoke
29         -handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.
30
31         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
32         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added.
33         (TestWebKitAPI::TEST):
34         * TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.
35
36         Pull some logic used to force an input session to start out from an existing API test file
37         (WKWebViewAutofillTests) and into a separate helper class that is used by both the existing API tests and the
38         new keyboard input test.
39
40         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
41         (-[AutofillTestView initWithFrame:]):
42         (TestWebKitAPI::TEST):
43         (-[TestInputDelegate init]): Deleted.
44         (-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
45         * TestWebKitAPI/ios/UIKitSPI.h:
46
47         Add some UIKit SPI utilized by the new API test.
48
49 2018-08-01  Dan Bernstein  <mitz@apple.com>
50
51         Optionally expose Attr::style to JavaScript
52         https://bugs.webkit.org/show_bug.cgi?id=188226
53         <rdar://problem/42818113>
54
55         Reviewed by Darin Adler.
56
57         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
58         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Added.
59         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm: Added.
60         (TEST):
61
62 2018-08-02  David Fenton  <david_fenton@apple.com>
63
64         Unreviewed, rolling out r234489.
65
66         Caused 50+ crashes and 60+ API failures on iOS
67
68         Reverted changeset:
69
70         "[WTF] Rename String::format to String::deprecatedFormat"
71         https://bugs.webkit.org/show_bug.cgi?id=188191
72         https://trac.webkit.org/changeset/234489
73
74 2018-08-01  Ross Kirsling  <ross.kirsling@sony.com>
75
76         TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
77         https://bugs.webkit.org/show_bug.cgi?id=188244
78
79         Reviewed by Daniel Bates.
80
81         Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mode. 
82
83         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
84
85 2018-08-01  Tomas Popela  <tpopela@redhat.com>
86
87         [WTF] Rename String::format to String::deprecatedFormat
88         https://bugs.webkit.org/show_bug.cgi?id=188191
89
90         Reviewed by Darin Adler.
91
92         It should be replaced with string concatenation.
93
94         * DumpRenderTree/win/DumpRenderTree.cpp:
95         (applicationId):
96         (main):
97         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
98         (TestWebKitAPI::Util::createURLForResource):
99         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
100         (WTR::cacheTestRunnerCallback):
101         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
102         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
103         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
104         (WTR::AccessibilityUIElement::attributedStringForRange):
105         (WTR::AccessibilityUIElement::url):
106         (WTR::stringAtOffset):
107         * WebKitTestRunner/TestController.cpp:
108         (WTR::TestController::didReceiveAuthenticationChallenge):
109         (WTR::TestController::downloadDidFail):
110         (WTR::originUserVisibleName):
111         (WTR::userMediaOriginHash):
112         (WTR::TestController::didNavigateWithNavigationData):
113         (WTR::TestController::didPerformClientRedirect):
114         (WTR::TestController::didPerformServerRedirect):
115         (WTR::TestController::didUpdateHistoryTitle):
116
117 2018-08-01  Nan Wang  <n_wang@apple.com>
118
119         AX: AOM: Add ARIA IDL Attribute Reflection
120         https://bugs.webkit.org/show_bug.cgi?id=184676
121         <rdar://problem/39476882>
122
123         Reviewed by Chris Fleizach.
124
125         * DumpRenderTree/mac/DumpRenderTree.mm:
126         (enableExperimentalFeatures):
127         * WebKitTestRunner/TestController.cpp:
128         (WTR::TestController::resetPreferencesToConsistentValues):
129
130 2018-08-01  Jonathan Bedard  <jbedard@apple.com>
131
132         Use iPhone SE as the default simulated device
133         https://bugs.webkit.org/show_bug.cgi?id=188227
134
135         Reviewed by Aakash Jain.
136
137         * Scripts/webkitpy/port/ios_simulator.py:
138         (IOSSimulatorPort):
139
140 2018-08-01  Commit Queue  <commit-queue@webkit.org>
141
142         Unreviewed, rolling out r234443 and r234445.
143         https://bugs.webkit.org/show_bug.cgi?id=188224
144
145         Revision caused 3 api failures across all platforms.
146         (Requested by Truitt on #webkit).
147
148         Reverted changesets:
149
150         "Add configuration for automatic process pre-warming"
151         https://bugs.webkit.org/show_bug.cgi?id=187108
152         https://trac.webkit.org/changeset/234443
153
154         "Add configuration for automatic process pre-warming"
155         https://bugs.webkit.org/show_bug.cgi?id=187108
156         https://trac.webkit.org/changeset/234445
157
158 2018-07-31  Ben Richards  <benton_richards@apple.com>
159
160         Add configuration for automatic process pre-warming
161         https://bugs.webkit.org/show_bug.cgi?id=187108
162
163         Reviewed by Ryosuke Niwa.
164
165         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
166
167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
169         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Added.
170         (TEST):
171
172 2018-07-31  John Wilander  <wilander@apple.com>
173
174         Resource Load Statistics: Remove partitioned cookies for reduced complexity, lower memory footprint, and ability to support more platforms
175         https://bugs.webkit.org/show_bug.cgi?id=188109
176         <rdar://problem/42664391>
177
178         Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
179
180         This patch removes cookie partitioning which reduces the model to just
181         blocked cookies (in third-party contexts) and first-party cookie access.
182
183         Several of the changes are renaming to reflect that there are no more
184         cookie partitions.
185
186         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
187            Removed or renamed functions to reflect that there are no more
188            partitioned cookies.
189         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
190         (WTR::InjectedBundle::didReceiveMessageToPage):
191         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
192         (WTR::TestRunner::statisticsUpdateCookieBlocking):
193         (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
194         (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
195         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
196         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
197         (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
198         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
199         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
200         * WebKitTestRunner/InjectedBundle/TestRunner.h:
201         * WebKitTestRunner/TestController.cpp:
202         (WTR::TestController::statisticsUpdateCookieBlocking):
203         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
204         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
205         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
206         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
207         * WebKitTestRunner/TestController.h:
208         * WebKitTestRunner/TestInvocation.cpp:
209         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
210         (WTR::TestInvocation::didSetBlockCookiesForHost):
211         (WTR::TestInvocation::didSetHasHadUserInteraction):
212         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
213         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
214         * WebKitTestRunner/TestInvocation.h:
215         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
216         (WTR::initializeWebViewConfiguration):
217
218 2018-07-31  Alex Christensen  <achristensen@webkit.org>
219
220         Build fix.  Remove unused variable.
221
222         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
223         (TestWebKitAPI::TEST):
224         transform was never used. It was introduced in r205871
225         Apparently I'm the first one to build in a certain configuration that found it.
226
227 2018-07-31  Fujii Hironori  <Hironori.Fujii@sony.com>
228
229         server_process.py should print returncode in debug log if the process crashed
230         https://bugs.webkit.org/show_bug.cgi?id=188160
231
232         Reviewed by Konstantin Tokarev.
233
234         * Scripts/webkitpy/port/server_process.py:
235         (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message.
236
237 2018-07-31  Tomas Popela  <tpopela@redhat.com>
238
239         [WTF] String::formatWithArguments() is unused
240         https://bugs.webkit.org/show_bug.cgi?id=187955
241
242         Reviewed by Darin Adler.
243
244         Remove tests for WTF::String::formatWithArguments() as it's unused and
245         we are removing it.
246
247         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
248
249 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
250
251         [ews-build] Fix typo in builder name for Bindings-tests-EWS.
252
253         * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
254         other builders.
255
256 2018-07-30 Aakash Jain  <aakash_jain@apple.com>
257
258         [ews-build] Add support for API tests in OpenSource EWS
259         https://bugs.webkit.org/show_bug.cgi?id=188156
260
261         Reviewed by Lucas Forschler.
262
263         * BuildSlaveSupport/ews-build/config.json:
264         * BuildSlaveSupport/ews-build/factories.py:
265         (BuildFactory.__init__): Added triggers parameter.
266         (BuildFactory): If trigger is defined, create and upload archive and trigger appropriate queues.
267         (BuildFactory.propertiesToPassToTriggers): Pass all the required properties to triggered queue.
268         (APITestsFactory): Factory for running API tests.
269         * BuildSlaveSupport/ews-build/steps.py:
270         (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the 
271         source of the property.
272
273 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
274
275         [ews-build] loadConfig should ensure that the triggers are valid
276         https://bugs.webkit.org/show_bug.cgi?id=188134
277
278         Reviewed by Lucas Forschler.
279
280         * BuildSlaveSupport/ews-build/loadConfig.py:
281         (checkValidBuilder): Added a check to ensure that the builder doesn't refernce non-existing scheduler.
282         (checkValidSchedulers): Ensures that the scheduler is not un-used.
283         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
284
285 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
286
287         Unreviewed, fix typo in test expectations and mark another test as timing out
288
289         * TestWebKitAPI/glib/TestExpectations.json:
290
291 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
292
293         More unreviewed GTK test gardening
294
295         * TestWebKitAPI/glib/TestExpectations.json:
296
297 2018-07-27  Simon Fraser  <simon.fraser@apple.com>
298
299         Be more conservative with compositing layer creation when memory is low
300         https://bugs.webkit.org/show_bug.cgi?id=187866
301         rdar://problem/42366345
302
303         Reviewed by Zalan Bujtas.
304         
305         When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
306         compositing layers. We avoid compositing for these situations:
307         1. Layers with 3D transforms which are affine (like translateZ(0)).
308         2. Layers with will-change
309         3. Layers for canvases (other than WebGL/WebGPU)
310         
311         We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
312         falling into "conservative mode" at 50% of jetsam limit, and "strict mode" at 65%.
313         Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
314         
315         Plumb through a "compositingPolicyOverride" both so that on-device testing isn't
316         flakily falling into a different mode, and so that we can impose the conservative
317         mode for testing.
318
319         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
320         (WTR::InjectedBundlePage::prepare):
321
322 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
323
324         Unreviewed GTK test gardening
325
326         * TestWebKitAPI/glib/TestExpectations.json:
327
328 2018-07-27  Alex Christensen  <achristensen@webkit.org>
329
330         Fix API tests after r234314
331         https://bugs.webkit.org/show_bug.cgi?id=188077
332
333         Make API tests use new delegate method.
334
335         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
336         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
337         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
338
339 2018-07-27  Alex Christensen  <achristensen@webkit.org>
340
341         Fix API tests after r234314
342         https://bugs.webkit.org/show_bug.cgi?id=188077
343
344         Make API tests use new delegate method.
345
346         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
347         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
348         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
349         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
350         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
351         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
352         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
353         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
354         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
355         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
356         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
357
358 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
359
360         [INTL] Remove INTL sub-feature compile flags
361         https://bugs.webkit.org/show_bug.cgi?id=188081
362
363         Reviewed by Michael Catanzaro.
364
365         * Scripts/webkitperl/FeatureList.pm:
366         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
367
368 2018-07-26  Chris Dumez  <cdumez@apple.com>
369
370         Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
371         https://bugs.webkit.org/show_bug.cgi?id=188078
372         <rdar://problem/42562493>
373
374         Reviewed by Geoff Garen.
375
376         Add API test coverage. It exercises the right code path but unfortunately is not yet a regression
377         test because TestWebKitAPI does not appear to be sandboxed (rdar://problem/42638129).
378
379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
380         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
381         (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
382         (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withError:]):
383         (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
384         (TEST):
385
386 2018-07-26  Aaron Chu  <aaron_chu@apple.com>
387
388         Add Aaron Chu as a committer to contributors.json
389         https://bugs.webkit.org/show_bug.cgi?id=188066
390
391         Unreviwed. Added myself as committer.
392
393         * Scripts/webkitpy/common/config/contributors.json:
394
395 2018-07-26  Aakash Jain  <aakash_jain@apple.com>
396
397         [ews-build] Add build step to run API Tests
398         https://bugs.webkit.org/show_bug.cgi?id=188079
399
400         Reviewed by Lucas Forschler.
401
402         * BuildSlaveSupport/ews-build/steps.py:
403         (TestWithFailureCount): Common class for various tests with failure count.
404         (TestWithFailureCount.start): Configure Buildbot's logobserver.
405         (TestWithFailureCount.commandComplete): Updates the failure count.
406         (TestWithFailureCount.evaluateCommand): Set the step status appropriately.
407         (TestWithFailureCount.getResultSummary): Set the step summary appropriately.
408         (RunAPITests): Build step to run API tests.
409         (RunAPITests.countFailures): Count the failures by parsing the output.
410         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
411
412 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
413
414         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
415         https://bugs.webkit.org/show_bug.cgi?id=187963
416
417         Reviewed by Alex Christensen.
418
419         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
420         Add tests for String::split and String::splitAllowingEmptyEntries.
421
422         * TestWebKitAPI/Tests/WTF/StringView.cpp:
423         * WebKitTestRunner/TestController.cpp:
424         (WTR::updateTestOptionsFromTestHeader):
425         Update split/splitAllowingEmptyEntries usage.
426
427 2018-07-26  Commit Queue  <commit-queue@webkit.org>
428
429         Unreviewed, rolling out r234181 and r234189.
430         https://bugs.webkit.org/show_bug.cgi?id=188075
431
432         These are not needed right now (Requested by thorton on
433         #webkit).
434
435         Reverted changesets:
436
437         "Enable Web Content Filtering on watchOS"
438         https://bugs.webkit.org/show_bug.cgi?id=187979
439         https://trac.webkit.org/changeset/234181
440
441         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
442         https://bugs.webkit.org/show_bug.cgi?id=187985
443         https://trac.webkit.org/changeset/234189
444
445 2018-07-04  Darin Adler  <darin@apple.com>
446
447         Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
448         https://bugs.webkit.org/show_bug.cgi?id=187333
449
450         Reviewed by Sam Weinig.
451
452         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
453         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
454         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
455         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
456         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
457
458 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
459
460         [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
461         https://bugs.webkit.org/show_bug.cgi?id=188031
462
463         Reviewed by Lucas Forschler.
464
465         * BuildSlaveSupport/ews-build/steps.py:
466         (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
467         (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
468         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
469
470 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
471
472         [ews-build] Add build step UploadBuiltProduct
473         https://bugs.webkit.org/show_bug.cgi?id=188016
474
475         Reviewed by Lucas Forschler.
476
477         * BuildSlaveSupport/ews-build/steps.py:
478         (UploadBuiltProduct): Added build step UploadBuiltProduct.
479         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
480
481 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
482
483         [ews-build] Add build step ArchiveBuiltProduct
484         https://bugs.webkit.org/show_bug.cgi?id=188014
485
486         Reviewed by Lucas Forschler.
487
488         * BuildSlaveSupport/ews-build/steps.py:
489         (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
490         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
491
492 2018-07-25  Chris Dumez  <cdumez@apple.com>
493
494         navigator.userAgent may return outdated value after webView.customUserAgent is set
495         https://bugs.webkit.org/show_bug.cgi?id=188009
496         <rdar://problem/42566456>
497
498         Reviewed by Alex Christensen.
499
500         Add API test coverage.
501
502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
503         * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
504         (TEST):
505
506 2018-07-25  Charlie Turner  <cturner@igalia.com>
507
508         [Flatpak] Pass more environment variables to sandbox
509         https://bugs.webkit.org/show_bug.cgi?id=188002
510
511         Reviewed by Michael Catanzaro.
512
513         * flatpak/flatpakutils.py:
514         (WebkitFlatpak.run_in_sandbox):
515
516 2018-07-25  Zan Dobersek  <zdobersek@igalia.com>
517
518         [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
519         https://bugs.webkit.org/show_bug.cgi?id=187997
520
521         Reviewed by Carlos Garcia Campos.
522
523         Instead of the raw wpe_view_backend_exportable_fdo API, switch to using
524         the EGL-oriented API that simply serves EGLImageKHR objects instead of
525         raw buffer resources. This allows us not to wrangle with creating and
526         managing lifetime of the same EGLImageKHR by ourselves.
527
528         ViewBackend now defines a wpe_view_backend_exportable_fdo_egl_client
529         struct and uses wpe_view_backend_exportable_fdo_egl_create() to create
530         the exportable object. This means that for each frame we're served an
531         EGLImageKHR object that is passed on to the displayBuffer()
532         implementation.
533
534         HeadlessViewBackend now just manages the pending and committed image
535         objects. Width and height values used during pixel data retrieval are
536         gathered from the ViewBackend's size that was specified when
537         constructed.
538
539         WindowViewBackend similarly only manages the committed image object,
540         not having to create an equivalent EGLImageKHR object from the raw
541         buffer resource anymore.
542
543         Unused EGL entrypoints in both HeadlessViewBackend and WindowViewBackend
544         classes are removed, and destructors for both classes are made virtual.
545
546         The WPEBackend-fdo version is bumped in order to have the EGL-specific
547         export API available.
548
549         * flatpak/org.webkit.WPE.yaml:
550         * wpe/backends/HeadlessViewBackend.cpp:
551         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
552         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
553         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
554         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
555         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
556         * wpe/backends/HeadlessViewBackend.h:
557         * wpe/backends/ViewBackend.cpp:
558         (WPEToolingBackends::ViewBackend::initialize):
559         * wpe/backends/ViewBackend.h:
560         * wpe/backends/WindowViewBackend.cpp:
561         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
562         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
563         (WPEToolingBackends::WindowViewBackend::displayBuffer):
564         * wpe/backends/WindowViewBackend.h:
565         * wpe/jhbuild.modules:
566
567 2018-07-24  Thomas Denney  <tdenney@apple.com>
568
569         Remove support for the double type from WHLSL
570         https://bugs.webkit.org/show_bug.cgi?id=187977
571
572         Reviewed by Myles C. Maxfield.
573
574         * WebGPUShadingLanguageRI/All.js: Removed DoubleLiteral.js and DoubleLiteralType.js include.
575         * WebGPUShadingLanguageRI/DoubleLiteral.js: Removed.
576         * WebGPUShadingLanguageRI/DoubleLiteralType.js: Removed.
577         * WebGPUShadingLanguageRI/Intrinsics.js: Removed double arithmetic functions.
578         * WebGPUShadingLanguageRI/Parse.js:
579         (parseTerm): Removed parsing of double literals.
580         * WebGPUShadingLanguageRI/SPIRV.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
581         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed double type logic.
582         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed double type declarations.
583         * WebGPUShadingLanguageRI/Test.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
584         * WebGPUShadingLanguageRI/Test.js: Removed tests that test doubles or ported them to use floats.
585         * WebGPUShadingLanguageRI/index.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
586
587 2018-07-24  Tim Horton  <timothy_horton@apple.com>
588
589         Enable Web Content Filtering on watchOS
590         https://bugs.webkit.org/show_bug.cgi?id=187979
591         <rdar://problem/42559346>
592
593         Reviewed by Wenson Hsieh.
594
595         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
596
597 2018-07-24  Daniel Bates  <dabates@apple.com>
598
599         Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it
600         https://bugs.webkit.org/show_bug.cgi?id=187971
601
602         Reviewed by Saam Barati.
603
604         Add unit tests to cover move constructing a NeverDestroyed with a non-const and const data type
605         as well as invoking makeNeverDestroyed() with the result of a function that returns a move-only
606         data type.
607
608         * TestWebKitAPI/CMakeLists.txt:
609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
610         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.cpp: Added.
611         (TestWebKitAPI::MoveOnlyLifecycleLogger::MoveOnlyLifecycleLogger):
612         (TestWebKitAPI::MoveOnlyLifecycleLogger::~MoveOnlyLifecycleLogger):
613         (TestWebKitAPI::MoveOnlyLifecycleLogger::operator=):
614         (TestWebKitAPI::MoveOnlyLifecycleLogger::setName):
615         (TestWebKitAPI::TEST):
616         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.h: Added.
617         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
618         (TestWebKitAPI::TEST):
619
620 2018-07-24  Thomas Denney  <tdenney@apple.com>
621         Minor changes to the WHLSL interpreter to support the new compiler
622         https://bugs.webkit.org/show_bug.cgi?id=187728
623
624         Reviewed by Myles C. Maxfield.
625
626         This bug contains small changes that are make minor changes to the
627         behaviour of the existing interpreter (the tests are unaffected and all
628         still pass).
629
630         * WebGPUShadingLanguageRI/EnumType.js:
631         (EnumType.prototype.get isEnum): Property added to EnumType and Type
632         * WebGPUShadingLanguageRI/Evaluator.js: Correct typo
633         * WebGPUShadingLanguageRI/Func.js:
634         (Func.prototype.get isEntryPoint): Add boolean property
635         * WebGPUShadingLanguageRI/FuncInstantiator.js:
636         (FuncInstantiator.prototype.get instances): Public accessor for existing
637         private field
638         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Refactored the class so
639         that it directly wraps a Func instance (therefore the only interface
640         change is to the constructor and the addition of the func accessor).
641         This change allows the de-inlining of functions.
642         (FunctionLikeBlock):
643         (FunctionLikeBlock.prototype.get func):
644         (FunctionLikeBlock.prototype.get returnType):
645         (FunctionLikeBlock.prototype.get parameters):
646         (FunctionLikeBlock.prototype.get body):
647         * WebGPUShadingLanguageRI/Inliner.js: Use the new FunctionLikeBlock
648         constructor
649         (Inliner.prototype.visitCallExpression):
650         (Inliner):
651         * WebGPUShadingLanguageRI/Intrinsics.js: Migrate the swizzle operators
652         to native functions (with additional support in StandardLibrary.js).
653         This reduces first-time compile-time from around 4s to around 0.1s.
654         (Intrinsics):
655         * WebGPUShadingLanguageRI/Lexer.js: Ensure that the parsing of multiline
656         comments completes correctly
657         (Lexer.prototype.next):
658         (Lexer):
659         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Addition of type
660         property, which is based on the type of the lValue and the semantics of
661         the language (the @ operator yields an array reference with the thread
662         scope).
663         (MakeArrayRefExpression):
664         (MakeArrayRefExpression.prototype.get type):
665         * WebGPUShadingLanguageRI/NativeFunc.js: Add setter/getter for
666         implementationData to support swizzle operator change
667         (NativeFunc.prototype.get implementationData):
668         (NativeFunc.prototype.set implementationData):
669         * WebGPUShadingLanguageRI/Rewriter.js: Use new FunctionLikeBlock
670         constructor
671         (Rewriter.prototype.visitFunctionLikeBlock):
672         * WebGPUShadingLanguageRI/StandardLibrary.js:
673         (_generateSwizzle): Deleted.
674         * WebGPUShadingLanguageRI/SwizzleOp.js: Introduces a new class for
675         carrying metadata about swizzle operators so that they are implemented
676         as native functions rather than generated at compile time.
677         (SwizzleOp):
678         (SwizzleOp.prototype.get outSize):
679         (SwizzleOp.prototype.get components):
680         (SwizzleOp.prototype.get inSize):
681         (SwizzleOp.prototype.toString):
682         (SwizzleOp.allSwizzleOperators.):
683         (SwizzleOp.allSwizzleOperators):
684         * WebGPUShadingLanguageRI/StandardLibrary.js: +        (SwizzleOp):
685         (SwizzleOp.prototype.get outSize):
686         (SwizzleOp.prototype.get components):
687         (SwizzleOp.prototype.get inSize):
688         (SwizzleOp.prototype.toString):
689         (generateSwizzles):
690         (_generateSwizzle): Deleted.
691         * WebGPUShadingLanguageRI/Type.js: Addition of isEnum property, as
692         above.
693         (Type.prototype.get isEnum):
694
695 2018-07-24  Ryan Haddad  <ryanhaddad@apple.com>
696
697         Unreviewed, rolling out r234121.
698
699         Caused perf test failures.
700
701         Reverted changeset:
702
703         "We should cache the compiled sandbox profile in a data vault"
704         https://bugs.webkit.org/show_bug.cgi?id=184991
705         https://trac.webkit.org/changeset/234121
706
707 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
708
709         [Flatpak] Add openh264 as needed by WebRTC
710         https://bugs.webkit.org/show_bug.cgi?id=187956
711
712         Reviewed by Philippe Normand.
713
714         * flatpak/org.webkit.WebKit.yaml:
715
716 2018-07-24  Ross Kirsling  <ross.kirsling@sony.com>
717
718         WebCore::URL::hostIsIPAddress needs a Windows implementation
719         https://bugs.webkit.org/show_bug.cgi?id=187859
720
721         Reviewed by Fujii Hironori.
722
723         * TestWebKitAPI/Tests/WebCore/URL.cpp:
724         Check for a few other ways an IP address could be invalid.
725
726 2018-07-24  Charlie Turner  <cturner@igalia.com>
727
728         [Flatpak] Avoid consuming unknown arguments in flatpak wrapper
729         https://bugs.webkit.org/show_bug.cgi?id=187951
730
731         When running run-webkit-tests --wpe --debug, it was observed that
732         both self.platform != 'wpe' and self.debug != True. This turned
733         out to be because of the "args" argument consuming the remainder
734         of future arguments that came after it. Since the first argument
735         to load_from_args was the test script to run, it would end up
736         never processing the other arguments supplied to the wrapper
737         script.
738
739         Tested this by rebuilding GTK in debug mode, running the
740         minibrowser with various extra options, and running some tests
741         with various extra options.
742
743         Reviewed by Michael Catanzaro.
744
745         * flatpak/flatpakutils.py:
746         (WebkitFlatpak.load_from_args):
747
748 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
749
750         [Flatpak] Remove now unnecessary 'hacks' for running tests
751         https://bugs.webkit.org/show_bug.cgi?id=187608
752
753         Reviewed by Philippe Normand.
754
755         We used to need to not share X11 with the sandbox when running tests
756         but it is not needed anymore as we do not mount `/tmp` on `/tmp` in the
757         sandbox (we mount it on `/run/host/tmp` now).
758
759         This has the advantage of making running the MiniBrowser to display test
760         results working again.
761
762         * flatpak/flatpakutils.py:
763         (WebkitFlatpak.clean_args):
764         (WebkitFlatpak.run_in_sandbox):
765         (WebkitFlatpak._cleanup_faltpak_args_for_tests_if_needed): Deleted.
766
767 2018-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
768
769         webkitpy.port.server_process_unittest.TestServerProcess.test_basic failed on Windows Python
770         https://bugs.webkit.org/show_bug.cgi?id=187581
771
772         Reviewed by Daniel Bates.
773
774         There are two failures in this test case:
775         1. proc.poll() doesn't return 0.
776         2. stderr is not output.
777
778         For failure #1, this is expected. the process should not exit at
779         the time. proc.poll() should return None because the process is
780         still alive.
781
782         This change added a new test to check proc.poll() becomes 0 after
783         the process successfully exits.
784
785         For failure #2, stderr is not flushed even though stdout is
786         flushed. This change uses '-u' command switch to force stdin,
787         stdout and stderr to be totally unbuffered.
788
789         * Scripts/webkitpy/port/server_process_unittest.py:
790         (TestServerProcess.test_basic): Added -u command switch. Do not
791         flush stdout. Removed the special condition for Windows. Add a new
792         test to check proc.poll() returns 0.
793         (TestServerProcess.test_process_crashing): Added -u command
794         switch. Do not flush stdout.
795
796 2018-07-23  Ross Kirsling  <ross.kirsling@sony.com>
797
798         WTF::StringView::split should have an allowEmptyEntries flag
799         https://bugs.webkit.org/show_bug.cgi?id=187864
800
801         Reviewed by Konstantin Tokarev.
802
803         * TestWebKitAPI/Tests/WTF/StringView.cpp: Add test.
804
805 2018-07-23  Ben Richards  <benton_richards@apple.com>
806
807         We should cache the compiled sandbox profile in a data vault
808         https://bugs.webkit.org/show_bug.cgi?id=184991
809
810         Reviewed by Ryosuke Niwa.
811
812         Added trace points for sandbox initialization
813
814         * Tracing/SystemTracePoints.plist:
815
816 2018-07-23  Zalan Bujtas  <zalan@apple.com>
817
818         DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
819         https://bugs.webkit.org/show_bug.cgi?id=187924
820         <rdar://problem/41745884>
821
822         Reviewed by Simon Fraser.
823
824         WebKit relies on -viewWillDraw getting called on WebHTMLView, even though that view has not been marked as needing display.
825
826         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
827         (createBitmapContextFromWebView):
828
829 2018-07-23  Chris Dumez  <cdumez@apple.com>
830
831         WebResourceLoadStatisticsStore fails to unregister itself as a MessageReceiver in its destructor
832         https://bugs.webkit.org/show_bug.cgi?id=187910
833         <rdar://problem/42356526>
834
835         Reviewed by Brent Fulgham.
836
837         Add API test coverage.
838
839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
840         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
841         (-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]):
842         (-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]):
843         (TEST):
844         * TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Added.
845
846 2018-07-23  Daniel Bates  <dabates@apple.com>
847
848         test-webkitpy should take configuration command line options
849         https://bugs.webkit.org/show_bug.cgi?id=187872
850
851         Reviewed by David Kilzer.
852
853         Add --debug and --release optional command line options and teach the test bots to invoke test-webkitpy
854         with the appropriate configuration. At the moment these options are only meaningful on Mac since they
855         effect the configuration lldbWebKitTester is built with and we only build lldbWebKitTester on Mac.
856
857         * BuildSlaveSupport/build.webkit.org-config/steps.py:
858         (RunPythonTests): Pass the configuration to test-webkitpy. On Mac this will effect
859         how lldbWebKitTester is built. All other ports do not make use of the specified configuration.
860         * Scripts/webkitpy/test/main.py:
861         (_build_lldb_webkit_tester): Modified to take the configuration to build lldbWebKitTester. If
862         the specified configuration is None then we fall back to using the default configuration (as set
863         by script set-webkit-configuration).
864         (Tester._parse_args): Add command line options --debug and --release to build lldbWebKitTester
865         with a Debug configuration and a Release configuration, respectively
866         (Tester._run_tests): Pass the configuration to build lldbWebKitTester that we parsed from
867         the command line options. It may be None if neither --debug nor --release were passed.
868
869 2018-07-23  Commit Queue  <commit-queue@webkit.org>
870
871         Unreviewed, rolling out r233030.
872         https://bugs.webkit.org/show_bug.cgi?id=187904
873
874         Broke tarball builds (Requested by mcatanzaro on #webkit).
875
876         Reverted changeset:
877
878         "run-gtk-tests (glib/common.py) cannot determine build
879         directory when webKitBranchBuild=true"
880         https://bugs.webkit.org/show_bug.cgi?id=185643
881         https://trac.webkit.org/changeset/233030
882
883 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
884
885         Fix lldb summarizers for HashMaps and HashSets
886         https://bugs.webkit.org/show_bug.cgi?id=187883
887
888         Reviewed by Dan Bates.
889         
890         HashMap and HashSet summarizers were broken in various ways.
891         
892         The 'type summary add -x' regexp needs to match at the start and end of the string
893         to avoid finding types nested inside other templates.
894         
895         The HashTable synthetic child code incorrectly used the type of the key, rather than
896         the value when synthesizing children.
897         
898         Add HashMap and HashSet summarizers.
899
900         I tried to get synthetic children working directly for HashMap and HashSet, but was unable.
901
902         * lldb/lldbWebKitTester/main.cpp:
903         (testSummaryProviders):
904         * lldb/lldb_webkit.py:
905         (__lldb_init_module):
906         (__lldb_init_module.lldb_webkit):
907         (WTFHashMap_SummaryProvider):
908         (WTFHashSet_SummaryProvider):
909         (WebCoreColorProvider._to_string_extended):
910         (WebCoreURLProvider.to_string):
911         (WTFHashMapProvider):
912         (WTFHashMapProvider.__init__):
913         (WTFHashMapProvider.tableSize):
914         (WTFHashMapProvider.keyCount):
915         (WTFHashSetProvider):
916         (WTFHashSetProvider.__init__):
917         (WTFHashSetProvider.tableSize):
918         (WTFHashSetProvider.keyCount):
919         (WTFHashTableProvider.tableSize):
920         (WTFHashTableProvider):
921         (WTFHashTableProvider.keyCount):
922         (WTFHashTableProvider.get_child_at_index):
923         (WTFHashTableProvider.update):
924         * lldb/lldb_webkit_unittest.py:
925         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
926         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
927         (TestSummaryProviders):
928         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
929         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
930         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
931
932 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
933
934         Add lldb formatters for WebCore geometry types
935         https://bugs.webkit.org/show_bug.cgi?id=187884
936
937         Reviewed by Daniel Bates.
938         
939         Add lldb formatters for IntPoint, IntSize, IntRect, FloatPoint, FloatSize, FloatRect
940         and LayoutRect.
941         
942         Testing is blocked by webkit.org/b/187872.
943
944         * lldb/lldbWebKitTester/main.cpp:
945         (testSummaryProviders):
946         * lldb/lldb_webkit.py:
947         (__lldb_init_module.lldb_webkit):
948         (__lldb_init_module):
949         (WebCoreLayoutRect_SummaryProvider):
950         (WebCoreIntSize_SummaryProvider):
951         (WebCoreIntPoint_SummaryProvider):
952         (WebCoreFloatSize_SummaryProvider):
953         (WebCoreFloatPoint_SummaryProvider):
954         (WebCoreIntRect_SummaryProvider):
955         (WebCoreFloatRect_SummaryProvider):
956         (WebCoreLayoutRectProvider):
957         (WebCoreLayoutRectProvider.__init__):
958         (WebCoreLayoutRectProvider.get_x):
959         (WebCoreLayoutRectProvider.get_y):
960         (WebCoreLayoutRectProvider.get_width):
961         (WebCoreLayoutRectProvider.get_height):
962         (WebCoreIntPointProvider):
963         (WebCoreIntPointProvider.__init__):
964         (WebCoreIntPointProvider.get_x):
965         (WebCoreIntPointProvider.get_y):
966         (WebCoreIntSizeProvider):
967         (WebCoreIntSizeProvider.__init__):
968         (WebCoreIntSizeProvider.get_width):
969         (WebCoreIntSizeProvider.get_height):
970         (WebCoreIntRectProvider):
971         (WebCoreIntRectProvider.__init__):
972         (WebCoreIntRectProvider.get_x):
973         (WebCoreIntRectProvider.get_y):
974         (WebCoreIntRectProvider.get_width):
975         (WebCoreIntRectProvider.get_height):
976         (WebCoreFloatPointProvider):
977         (WebCoreFloatPointProvider.__init__):
978         (WebCoreFloatPointProvider.get_x):
979         (WebCoreFloatPointProvider.get_y):
980         (WebCoreFloatSizeProvider):
981         (WebCoreFloatSizeProvider.__init__):
982         (WebCoreFloatSizeProvider.get_width):
983         (WebCoreFloatSizeProvider.get_height):
984         (WebCoreFloatRectProvider):
985         (WebCoreFloatRectProvider.__init__):
986         (WebCoreFloatRectProvider.get_x):
987         (WebCoreFloatRectProvider.get_y):
988         (WebCoreFloatRectProvider.get_width):
989         (WebCoreFloatRectProvider.get_height):
990
991 2018-07-20  John Wilander  <wilander@apple.com>
992
993         Resource Load Statistics: Enable basic functionality in experimental debug mode
994         https://bugs.webkit.org/show_bug.cgi?id=187835
995         <rdar://problem/42408590>
996
997         Reviewed by Chris Dumez.
998
999         This patch makes the experimental ITP Debug Mode feature work, at least
1000         to a basic level. All of the changes to TestRunner are to support the
1001         layout tests for the functionality.
1002
1003         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1004         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1005         (WTR::InjectedBundle::didReceiveMessageToPage):
1006         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1007         (WTR::TestRunner::setStatisticsDebugMode):
1008         (WTR::TestRunner::statisticsCallDidSetDebugModeCallback):
1009         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1010         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceForDebugModeCallback):
1011         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1012         * WebKitTestRunner/TestController.cpp:
1013         (WTR::TestController::setStatisticsDebugMode):
1014         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1015         * WebKitTestRunner/TestController.h:
1016         * WebKitTestRunner/TestInvocation.cpp:
1017         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1018         (WTR::TestInvocation::didSetStatisticsDebugMode):
1019         (WTR::TestInvocation::didSetPrevalentResourceForDebugMode):
1020         * WebKitTestRunner/TestInvocation.h:
1021
1022 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
1023
1024         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
1025         https://bugs.webkit.org/show_bug.cgi?id=187846
1026
1027         Reviewed by Simon Fraser.
1028
1029         Fixed the bug that testRunner.execCommand was using the second argument as the value.
1030
1031         The second argument, aShowDefaultUI, should always be ignored in testRunner.execCommand,
1032         and the third argument should be used as the value. DumpRenderTree's implementation does this already.
1033
1034         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1035         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1036         (WTR::TestRunner::execCommand):
1037         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1038
1039 2018-07-20  Dean Jackson  <dino@apple.com>
1040
1041         Accidentally checked in the wrong version of these files.
1042
1043         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1044         * lldb/lldbWebKitTester/main.cpp:
1045         (testSummaryProviders):
1046         * lldb/lldb_webkit_unittest.py:
1047         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1048         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color): Deleted.
1049         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color): Deleted.
1050         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color): Deleted.
1051         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color): Deleted.
1052         (TestSummaryProviders.serial_test_WebCoreColorProvider_semantic_color): Deleted.
1053
1054 2018-07-20  Dean Jackson  <dino@apple.com>
1055
1056         Provide an lldb type summary for WebCore::Color
1057         https://bugs.webkit.org/show_bug.cgi?id=187776
1058
1059         Reviewed by Dan Bates.
1060
1061         This time without the tests because we don't want to build
1062         all of WebKit just for python tests.
1063
1064         * lldb/lldb_webkit.py: Add a Color summary provider.
1065         (__lldb_init_module):
1066         (WebCoreColor_SummaryProvider):
1067         (WebCoreColorProvider):
1068         (WebCoreColorProvider.__init__):
1069         (WebCoreColorProvider._is_extended):
1070         (WebCoreColorProvider._is_valid):
1071         (WebCoreColorProvider._is_semantic):
1072         (WebCoreColorProvider._to_string_extended):
1073         (WebCoreColorProvider.to_string):
1074
1075 2018-07-20  Brady Eidson  <beidson@apple.com>
1076
1077         Add WKNavigation/WKNavigationAction related SPI.
1078         https://bugs.webkit.org/show_bug.cgi?id=187826
1079
1080         Reviewed by Chris Dumez.
1081
1082         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1083         (-[NavigationActionHasNavigationDelegate webView:didFinishNavigation:]):
1084         (-[NavigationActionHasNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1085         (TEST):
1086
1087 2018-07-20  Commit Queue  <commit-queue@webkit.org>
1088
1089         Unreviewed, rolling out r233943, r233988, r234004, and
1090         r234012.
1091         https://bugs.webkit.org/show_bug.cgi?id=187856
1092
1093         webkitpy tests are failing to build lldbWebKitTester
1094         (Requested by ryanhaddad on #webkit).
1095
1096         Reverted changesets:
1097
1098         "Provide an lldb type summary for WebCore::Color"
1099         https://bugs.webkit.org/show_bug.cgi?id=187776
1100         https://trac.webkit.org/changeset/233943
1101
1102         "Provide an lldb type summary for WebCore::Color"
1103         https://bugs.webkit.org/show_bug.cgi?id=187776
1104         https://trac.webkit.org/changeset/233988
1105
1106         "Provide an lldb type summary for WebCore::Color"
1107         https://bugs.webkit.org/show_bug.cgi?id=187776
1108         https://trac.webkit.org/changeset/234004
1109
1110         "Provide an lldb type summary for WebCore::Color"
1111         https://bugs.webkit.org/show_bug.cgi?id=187776
1112         https://trac.webkit.org/changeset/234012
1113
1114 2018-07-20  Philippe Normand  <pnormand@igalia.com>
1115
1116         [GTK][WPE] enable-media-capabilities websetting
1117         https://bugs.webkit.org/show_bug.cgi?id=187847
1118
1119         Reviewed by Carlos Garcia Campos.
1120
1121         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1122         (testWebKitSettings): Unit test for the new enable-media-capabilities setting.
1123
1124 2018-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1125
1126         [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSCClass is given
1127         https://bugs.webkit.org/show_bug.cgi?id=187798
1128
1129         Reviewed by Michael Catanzaro.
1130
1131         Update test cases to the new API and use a destroy function and vtable in the test case of calling
1132         jsc_context_evaluate_in_object() with a JSCClass.
1133
1134         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1135         (testJSCEvaluateInObject):
1136
1137 2018-07-19  Ross Kirsling  <ross.kirsling@sony.com>
1138
1139         TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
1140         https://bugs.webkit.org/show_bug.cgi?id=187712
1141
1142         Reviewed by Fujii Hironori.
1143
1144         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1145         Mark result of unsigned short test case as platform-specific,
1146         since Windows' behavior is actually *less* surprising here.
1147
1148 2018-07-19  Lucas Forschler  <lforschler@apple.com>
1149
1150         Teach the AWS Lambda to use the [minified]-platforms database
1151         https://bugs.webkit.org/show_bug.cgi?id=187817
1152         
1153         Reviewed by David Kilzer.
1154
1155         * WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:
1156         (lambda_handler): Add support for the platforms.webkit.org database
1157         * WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:
1158         (lambda_handler): Add support for the minified-platforms.webkit.org database
1159
1160 2018-07-19  Dean Jackson  <dino@apple.com>
1161
1162         Provide an lldb type summary for WebCore::Color
1163         https://bugs.webkit.org/show_bug.cgi?id=187776
1164
1165         Dan Bates helped me with this attempted fix. Fingers crossed!
1166
1167         * Scripts/build-lldbwebkittester:
1168
1169 2018-07-19  Stephan Szabo  <stephan.szabo@sony.com>
1170
1171         [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
1172         https://bugs.webkit.org/show_bug.cgi?id=187786
1173
1174         Reviewed by Fujii Hironori.
1175
1176         * Scripts/webkitdirs.pm:
1177         (generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
1178         for WinCairo builds.
1179
1180 2018-07-19  Dean Jackson  <dino@apple.com>
1181
1182         Provide an lldb type summary for WebCore::Color
1183         https://bugs.webkit.org/show_bug.cgi?id=187776
1184
1185         Another attempted build fix for Debug.
1186
1187         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1188         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1189
1190 2018-07-19  Thomas Denney  <tdenney@apple.com>
1191
1192         [WHLSL] The interpreter doesn't support boolean short-circuiting
1193         https://bugs.webkit.org/show_bug.cgi?id=187779
1194
1195         Reviewed by Alex Christensen.
1196
1197         * WebGPUShadingLanguageRI/Evaluator.js:
1198         (Evaluator.prototype.visitLogicalExpression): RHS is only evaluated when necessary
1199         * WebGPUShadingLanguageRI/Test.js:
1200         (tests.booleanShortcircuiting): Adds 4 tests for the evaluation of logical expresions
1201
1202 2018-07-19  Dean Jackson  <dino@apple.com>
1203
1204         Provide an lldb type summary for WebCore::Color
1205         https://bugs.webkit.org/show_bug.cgi?id=187776
1206
1207         Attempted build fix.
1208
1209         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1210
1211 2018-07-19  Brady Eidson  <beidson@apple.com>
1212
1213         Add an SPI policy action to allow clients to explicitly ask for a new process on a navigation.
1214         https://bugs.webkit.org/show_bug.cgi?id=187789
1215
1216         Reviewed by Andy Estes.
1217
1218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1219         (-[PSONNavigationDelegate init]):
1220         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1221
1222 2018-07-19  Thibault Saunier  <tsaunier@igalia.com>
1223
1224         [Flatpak] Let flatpak process handle SIGINT
1225         https://bugs.webkit.org/show_bug.cgi?id=187521
1226
1227         Reviewed by Philippe Normand.
1228
1229         Ensuring that flatpak process ends properly and that the sandbox is teard down.
1230         It also avoids showing usless backtrace to the end user and makes gdb
1231         much more usable.
1232
1233         Also make flatpakutils not verbose by default
1234
1235         * flatpak/flatpakutils.py:
1236         (disable_signals):
1237         (WebkitFlatpak.run_in_sandbox):
1238         (WebkitFlatpak.run_gdb):
1239
1240 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
1241
1242         Unreviewed. Fix contributors entry.
1243
1244         * Scripts/webkitpy/common/config/contributors.json:
1245
1246 2018-07-18  Dean Jackson  <dino@apple.com>
1247
1248         Provide an lldb type summary for WebCore::Color
1249         https://bugs.webkit.org/show_bug.cgi?id=187776
1250
1251         Reviewed by Dan Bates.
1252
1253         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
1254             to get to WebCore.
1255         * lldb/lldbWebKitTester/main.cpp:
1256         (testSummaryProviders): Create some Color objects for testing.
1257
1258         * lldb/lldb_webkit.py: Add a Color summary provider.
1259         (__lldb_init_module):
1260         (WebCoreColor_SummaryProvider):
1261         (WebCoreColorProvider):
1262         (WebCoreColorProvider.__init__):
1263         (WebCoreColorProvider._is_extended):
1264         (WebCoreColorProvider._is_valid):
1265         (WebCoreColorProvider._is_semantic):
1266         (WebCoreColorProvider._to_string_extended):
1267         (WebCoreColorProvider.to_string):
1268
1269         * lldb/lldb_webkit_unittest.py: Tests.
1270         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1271         (TestSummaryProviders):
1272         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
1273         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
1274         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
1275         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
1276
1277 2018-07-18  Truitt Savell  <tsavell@apple.com>
1278
1279         Unreviewed, rolling out r233934.
1280
1281         Revision caused 5 webkitpy failures on Mac and broke webkitpy
1282         testing on iOS simulator
1283
1284         Reverted changeset:
1285
1286         "Provide an lldb type summary for WebCore::Color"
1287         https://bugs.webkit.org/show_bug.cgi?id=187776
1288         https://trac.webkit.org/changeset/233934
1289
1290 2018-07-18  Chris Dumez  <cdumez@apple.com>
1291
1292         REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9
1293         https://bugs.webkit.org/show_bug.cgi?id=187784
1294         <rdar://problem/42329230>
1295
1296         Reviewed by Brady Eidson.
1297
1298         When process swapping on navigation, WebPageProxy::reattachToWebProcess() unregisters the page as a MessageReceiver
1299         from the old WebProcessProxy and registers itself as a MessageReceiver for the new WebProcessProxy instead. This
1300         means that after this point, IPC sent by the previous WebProcess to its WebPageProxy will fail.
1301
1302         When we process swap, we also navigate the page in the old WebProcess to about:blank, when the navigation to
1303         about:blank would complete, the WebKitTestRunner's injected bundle would try and send IPC to the WebPageProxy
1304         which would fail and would cause WKBundlePagePostSynchronousMessageForTesting() to return a null result. WKTR
1305         would crash when dereferencing this null result. This patch addresses this by dealing with the potential null
1306         result.
1307
1308         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1309         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1310
1311 2018-07-18  Dean Jackson  <dino@apple.com>
1312
1313         Provide an lldb type summary for WebCore::Color
1314         https://bugs.webkit.org/show_bug.cgi?id=187776
1315
1316         Reviewed by Dan Bates.
1317
1318         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
1319             to get to WebCore.
1320         * lldb/lldbWebKitTester/main.cpp:
1321         (testSummaryProviders): Create some Color objects for testing.
1322
1323         * lldb/lldb_webkit.py: Add a Color summary provider.
1324         (__lldb_init_module):
1325         (WebCoreColor_SummaryProvider):
1326         (WebCoreColorProvider):
1327         (WebCoreColorProvider.__init__):
1328         (WebCoreColorProvider._is_extended):
1329         (WebCoreColorProvider._is_valid):
1330         (WebCoreColorProvider._is_semantic):
1331         (WebCoreColorProvider._to_string_extended):
1332         (WebCoreColorProvider.to_string):
1333
1334         * lldb/lldb_webkit_unittest.py: Tests.
1335         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1336         (TestSummaryProviders):
1337         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
1338         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
1339         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
1340         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
1341
1342 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
1343
1344         Adding myself to contributors.json
1345
1346         Unreviewed contributors.json change.
1347
1348         * Scripts/webkitpy/common/config/contributors.json:
1349
1350 2018-07-18  Jer Noble  <jer.noble@apple.com>
1351
1352         -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation
1353         https://bugs.webkit.org/show_bug.cgi?id=187739
1354         <rdar://problem/42304518>
1355
1356         Reviewed by Tim Horton.
1357
1358         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1359         (TEST):
1360
1361 2018-07-18  Jer Noble  <jer.noble@apple.com>
1362
1363         PiP from Element Fullscreen should match AVKit's behavior
1364         https://bugs.webkit.org/show_bug.cgi?id=187623
1365         <rdar://problem/41212379>
1366
1367         Reviewed by Jon Lee.
1368
1369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1370         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html: Added.
1371         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: Added.
1372         (-[ExitFullscreenOnEnterPiPUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
1373         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidEnterFullscreen:]):
1374         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidExitFullscreen:]):
1375         (TestWebKitAPI::TEST):
1376
1377 2018-07-18  Aakash Jain  <aakash_jain@apple.com>
1378
1379         [ews-build] Add build step to run layout-test
1380         https://bugs.webkit.org/show_bug.cgi?id=187674
1381
1382         Reviewed by Lucas Forschler.
1383
1384         * BuildSlaveSupport/ews-build/steps.py:
1385         (RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.
1386         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1387         * BuildSlaveSupport/ews-build/factories.py: Added build-step to run layout-test in iOSSimulatorFactory.
1388
1389 2018-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1390
1391         Add SPI to defer running async script until after document load
1392         https://bugs.webkit.org/show_bug.cgi?id=187748
1393         <rdar://problem/42317378>
1394
1395         Reviewed by Ryosuke Niwa and Tim Horton.
1396
1397         Add an API test to verify that when the deferred async script configuration is set, async scripts will be
1398         executed after the DOMContentLoaded event.
1399
1400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1401         * TestWebKitAPI/Tests/WebKitCocoa/RunScriptAfterDocumentLoad.mm: Added.
1402         (TEST):
1403
1404 2018-07-18  Charlie Turner  <cturner@igalia.com>
1405
1406         [WPE] Update WPEBackend in flatpak
1407         https://bugs.webkit.org/show_bug.cgi?id=187753
1408
1409         r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
1410         caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
1411         in the version guard,
1412
1413         #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
1414
1415         This doesn't work as intended, since the C preprocessor first expands
1416         all macro arguments in the #if expression before evaluating the
1417         expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
1418         lead to a syntax error and some head scratching.
1419
1420         A future patch should address the buggy macro check, when it is
1421         decided whether the assume the macro is always defined and bump
1422         the API requirements on WPEBackend, or to move the check into two
1423         conditionals to avoid the expansion problem.
1424
1425         Unreviewed build fix.
1426         
1427         * flatpak/org.webkit.WPE.yaml:
1428
1429 2018-07-18  Simon Fraser  <simon.fraser@apple.com>
1430
1431         Fix the parsing of colors in attributed string tests, and make it possible to dump the typing attributes
1432         https://bugs.webkit.org/show_bug.cgi?id=187747
1433
1434         Reviewed by Ryosuke Niwa.
1435         
1436         Add textInputController.attributedStringForTyping(), which returns a one-character
1437         attributed string whose attributes are the typing attributes, making it possible to
1438         test -[WebView typingAttributes].
1439         
1440         Sadly WebCore's convertObjcValueToValue() doesn't know how to convert NSDictionary,
1441         so we can't return -typingAttributes directly.
1442
1443         * DumpRenderTree/mac/TextInputControllerMac.m:
1444         (+[TextInputController isSelectorExcludedFromWebScript:]):
1445         (-[TextInputController attributedStringForTyping]):
1446
1447 2018-07-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1448
1449         [GLIB] Add jsc_context_check_syntax() to GLib API
1450         https://bugs.webkit.org/show_bug.cgi?id=187694
1451
1452         Reviewed by Yusuke Suzuki.
1453
1454         Add a new test case.
1455
1456         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1457         (testJSCCheckSyntax):
1458         (main):
1459
1460 2018-07-17  Sihui Liu  <sihui_liu@apple.com>
1461
1462         REGRESSION: [macOS Sierra] TestWebKitAPI.WebKit.WebsiteDataStoreCustomPaths is a flaky failure
1463         https://bugs.webkit.org/show_bug.cgi?id=187066
1464         <rdar://problem/41609065>
1465
1466         Reviewed by Chris Dumez.
1467
1468         In r232668 we started to do reload if web process crashes by default. As we killed the web 
1469         process explicitly in this test, if web page got reloaded, messages would be sent again, 
1470         and flag set in message handler could keep the test continue to evaluate the expectation 
1471         without waiting for removeDataOfTypes to finish.
1472
1473         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1474         (-[WebsiteDataStoreCustomPathsMessageHandler webViewWebContentProcessDidTerminate:]):
1475         (TEST):
1476
1477 2018-07-17  Chris Dumez  <cdumez@apple.com>
1478
1479         Turn on PSON in WebKitTestRunner
1480         https://bugs.webkit.org/show_bug.cgi?id=186542
1481
1482         Reviewed by Brady Eidson.
1483
1484         Turn on PSON by default in WebKitTestRunner.
1485
1486         * WebKitTestRunner/TestOptions.h:
1487
1488 2018-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1489
1490         Add an SPI hook to allow clients to yield document parsing and script execution
1491         https://bugs.webkit.org/show_bug.cgi?id=187682
1492         <rdar://problem/42207453>
1493
1494         Reviewed by Ryosuke Niwa.
1495
1496         Add a few tests to exercise the new document yield token SPI, verifying that clients can use the SPI to defer
1497         document load, and that doing so doesn't cause deferred `script` to execute in the wrong order (i.e. before
1498         synchronous script, or after "DOMContentLoaded").
1499
1500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1501         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm: Added.
1502         (-[ParserYieldTokenPlugIn takeDocumentParserTokenAfterCommittingLoad]):
1503         (-[ParserYieldTokenPlugIn releaseDocumentParserToken]):
1504         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1505         (-[ParserYieldTokenPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1506         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1507         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
1508
1509         Add an injected bundle object that knows how to take and release multiple document parser yield tokens.
1510
1511         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.h: Added.
1512         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm: Added.
1513         (+[ParserYieldTokenTestWebView webView]):
1514         (-[ParserYieldTokenTestWebView bundle]):
1515         (-[ParserYieldTokenTestWebView schemeHandler]):
1516         (-[ParserYieldTokenTestWebView didFinishDocumentLoad]):
1517         (-[ParserYieldTokenTestWebView didFinishLoad]):
1518         (waitForDelay):
1519         (TEST):
1520         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h: Added.
1521         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm: Added.
1522         (-[TestURLSchemeHandler webView:startURLSchemeTask:]):
1523         (-[TestURLSchemeHandler webView:stopURLSchemeTask:]):
1524         (-[TestURLSchemeHandler setStartURLSchemeTaskHandler:]):
1525         (-[TestURLSchemeHandler startURLSchemeTaskHandler]):
1526         (-[TestURLSchemeHandler setStopURLSchemeTaskHandler:]):
1527         (-[TestURLSchemeHandler stopURLSchemeTaskHandler]):
1528
1529         Add a new test helper class to handle custom schemes via a block-based API.
1530
1531         * TestWebKitAPI/Tests/WebKitCocoa/text-with-async-script.html: Added.
1532
1533         New test HTML page that contains a deferred script element, a synchronous script element, another deferred
1534         script element, and then some text, images, and links.
1535
1536         * TestWebKitAPI/Tests/WebKitCocoa/text-with-deferred-script.html: Added.
1537
1538 2018-07-17  Truitt Savell  <tsavell@apple.com>
1539
1540         Adding myself to Contributors.json
1541
1542         Unreviewed
1543
1544         * Scripts/webkitpy/common/config/contributors.json:
1545
1546 2018-07-17  Aditya Keerthi  <akeerthi@apple.com>
1547
1548         [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
1549         https://bugs.webkit.org/show_bug.cgi?id=187730
1550
1551         Reviewed by Jer Noble.
1552
1553         This regression was introduced by r233865. PIP can now only be initiated from a
1554         window that is on screen.
1555
1556         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1557         (TestWebKitAPI::TEST):
1558
1559 2018-07-17  John Wilander  <wilander@apple.com>
1560
1561         Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction()
1562         https://bugs.webkit.org/show_bug.cgi?id=187710
1563         <rdar://problem/42252757>
1564
1565         Reviewed by Chris Dumez.
1566
1567         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1568         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1569         (WTR::InjectedBundle::didReceiveMessageToPage):
1570         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1571         (WTR::TestRunner::setStatisticsLastSeen):
1572         (WTR::TestRunner::statisticsCallDidSetLastSeenCallback):
1573         (WTR::TestRunner::setStatisticsPrevalentResource):
1574         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceCallback):
1575         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1576         (WTR::TestRunner::statisticsCallDidSetVeryPrevalentResourceCallback):
1577         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1578         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
1579         (WTR::TestRunner::statisticsCallDidSetHasHadUserInteractionCallback):
1580         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1581         * WebKitTestRunner/TestController.cpp:
1582         (WTR::TestController::setStatisticsLastSeen):
1583         (WTR::TestController::setStatisticsPrevalentResource):
1584         (WTR::TestController::setStatisticsVeryPrevalentResource):
1585         (WTR::TestController::setStatisticsHasHadUserInteraction):
1586         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
1587         * WebKitTestRunner/TestInvocation.cpp:
1588         (WTR::TestInvocation::didSetLastSeen):
1589         (WTR::TestInvocation::didSetPrevalentResource):
1590         (WTR::TestInvocation::didSetVeryPrevalentResource):
1591         (WTR::TestInvocation::didSetHasHadUserInteraction):
1592         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction):
1593         * WebKitTestRunner/TestInvocation.h:
1594
1595 2018-07-16  Jeremy Jones  <jeremyj@apple.com>
1596
1597         Fix API Test failures introduced by r233865
1598         https://bugs.webkit.org/show_bug.cgi?id=187720
1599
1600         Unreviewed APITest fix after r233865.
1601
1602         Fullscreen can now only be initiated from a window that is on screen.
1603
1604         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1605         (TestWebKitAPI::TEST):
1606         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
1607         (TestWebKitAPI::TEST):
1608
1609 2018-07-11  Dean Jackson  <dino@apple.com>
1610
1611         Allow removal of white backgrounds
1612         https://bugs.webkit.org/show_bug.cgi?id=187574
1613         <rdar://problem/41146792>
1614
1615         Reviewed by Simon Fraser.
1616
1617         Add a new menu item for punching out white backgrounds in MiniBrowser.
1618         In WebKitTestRunner, expose the new setting and hook that up to
1619         drawing a background in the WebView.
1620
1621         * MiniBrowser/mac/AppDelegate.m:
1622         (defaultConfiguration): Add _punchOutWhiteBackgroundsInDarkMode.
1623
1624         * MiniBrowser/mac/SettingsController.h: Ditto.
1625         * MiniBrowser/mac/SettingsController.m:
1626         (-[SettingsController _populateMenu]):
1627         (-[SettingsController validateMenuItem:]):
1628         (-[SettingsController togglePunchOutWhiteBackgroundsInDarkMode:]):
1629         (-[SettingsController punchOutWhiteBackgroundsInDarkMode]):
1630
1631         * MiniBrowser/mac/WK1BrowserWindowController.m:
1632         (-[WK1BrowserWindowController didChangeSettings]): Set the new preference.
1633
1634         * WebKitTestRunner/PlatformWebView.h: Expose a drawsBackground property.
1635         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Null implementation.
1636         (WTR::PlatformWebView::drawsBackground const):
1637         (WTR::PlatformWebView::setDrawsBackground):
1638         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Ditto.
1639         (WTR::PlatformWebView::drawsBackground const):
1640         (WTR::PlatformWebView::setDrawsBackground):
1641         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Call into the WKWebView and
1642         set its SPI.
1643         (WTR::PlatformWebView::drawsBackground const):
1644         (WTR::PlatformWebView::setDrawsBackground):
1645         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Ditto.
1646         (WTR::PlatformWebView::drawsBackground const):
1647         (WTR::PlatformWebView::setDrawsBackground):
1648
1649         * WebKitTestRunner/TestController.cpp: Reset and copy the new preference.
1650         (WTR::TestController::resetPreferencesToConsistentValues):
1651         (WTR::updateTestOptionsFromTestHeader):
1652         * WebKitTestRunner/TestOptions.h:
1653         (WTR::TestOptions::hasSameInitializationOptions const):
1654
1655         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1656         (WTR::TestController::platformCreateWebView): If the option for punching
1657         out the background was set, tell the WebView to not draw its background.
1658
1659 2018-07-16  Aditya Keerthi  <akeerthi@apple.com>
1660
1661         [Datalist][macOS] Add suggestions UI for TextFieldInputTypes
1662         https://bugs.webkit.org/show_bug.cgi?id=186531
1663
1664         Reviewed by Tim Horton.
1665
1666         Added isShowingDatalistSuggestions testing hook in order to enable testing of the
1667         visibility of the suggestions view.
1668
1669         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1670         (WTR::UIScriptController::isShowingDataListSuggestions const):
1671         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1672         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1673         (WTR::UIScriptController::isShowingDataListSuggestions const):
1674         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1675         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1676         (WTR::UIScriptController::isShowingDataListSuggestions const):
1677
1678 2018-07-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1679
1680         Add --target-path option to dump-class-layout
1681         https://bugs.webkit.org/show_bug.cgi?id=187687
1682
1683         Reviewed by Simon Fraser.
1684
1685         We add an escape hatch to dump-class-layout for specifying target path directly.
1686         This `--target-path` allows us to use dump-class-layout in the other ports
1687         like JSCOnly.
1688
1689         We can dump class layout if we build the target with clang by using the following command.
1690
1691         Tools/Scripts/dump-class-layout \
1692             --architecture=x86_64 \
1693             --target-path=path/to/libJavaScriptCore.so \
1694             JavaScriptCore \
1695             ScopeNode
1696
1697         * Scripts/dump-class-layout:
1698         (main):
1699
1700 2018-07-16  Sihui Liu  <sihui_liu@apple.com>
1701
1702         IndexedDB: closeAndDeleteDatabasesForOrigins should remove all databases for those origins
1703         https://bugs.webkit.org/show_bug.cgi?id=187631
1704         <rdar://problem/42164227>
1705
1706         Reviewed by Brady Eidson.
1707
1708         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1709         (TEST):
1710
1711 2018-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1712
1713         [GLIB] Add API to evaluate code using a given object to store global symbols
1714         https://bugs.webkit.org/show_bug.cgi?id=187639
1715
1716         Reviewed by Michael Catanzaro.
1717
1718         Add a new test case.
1719
1720         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1721         (testJSCEvaluateInObject):
1722         (testJSCExceptions):
1723         (main):
1724
1725 2018-07-15  Zan Dobersek  <zdobersek@igalia.com>
1726
1727         [webkitpy] run-web-platform-tests should allow specifying custom WPT metadata directories
1728         https://bugs.webkit.org/show_bug.cgi?id=187353
1729
1730         Reviewed by Youenn Fablet.
1731
1732         When using run-web-platform-tests, allow specifying custom WPT metadata
1733         directory. This will avoid generating such metadata-filled directory
1734         from the port-specific JSON expectations file, and instead will search
1735         for the metadata files and the include manifest inside the specified
1736         directory. The MANIFEST.json file will also be generated under there.
1737
1738         Rationale for this change is prototyping using custom metadata
1739         directories and avoiding generating all this content from a JSON file.
1740         Using this by default in the future would avoid sporradic changes in how
1741         WPT handles metadata .ini files and releases us from the obligation of
1742         adjusting the generator for every such change. This would also allow
1743         managing this metadata content in a separate repository, avoiding
1744         polluting the main webkit.org repository with thousands of .ini files.
1745
1746         If this turns out to be the preferable way of managing the metadata
1747         content, the JSON files under WebPlatformTests/ and the related code in
1748         wpt_runner.py would be removed.
1749
1750         * Scripts/webkitpy/w3c/wpt_runner.py:
1751         (parse_args):
1752         (WPTRunner._wpt_run_paths):
1753         (WPTRunner.run):
1754         * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
1755         (WPTRunnerTest.test_run_with_specified_options):
1756
1757 2018-07-13  Ross Kirsling  <ross.kirsling@sony.com>
1758
1759         [WinCairo] run-api-tests is timing out for almost all test cases
1760         https://bugs.webkit.org/show_bug.cgi?id=187547
1761
1762         Reviewed by Fujii Hironori.
1763
1764         * Scripts/webkitpy/port/server_process.py:
1765         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1766         Still attempt to read from stdout/stderr even if the process has exited, as long as it's before the deadline.
1767
1768         * Scripts/webkitpy/port/server_process_unittest.py:
1769         (TestServerProcess.test_read_after_process_exits):
1770         Add test case.
1771
1772 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
1773
1774         Add TestExpectations and baselines for iOS 12
1775         https://bugs.webkit.org/show_bug.cgi?id=187628
1776
1777         Reviewed by Alexey Proskuryakov.
1778
1779         * Scripts/webkitpy/port/ios.py:
1780         (IOSPort): Bump current version to 12.
1781
1782 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
1783
1784         Add TestExpectations and baselines for Mojave.
1785         https://bugs.webkit.org/show_bug.cgi?id=187620
1786
1787         Reviewed by Alexey Proskuryakov.
1788
1789         * Scripts/webkitpy/port/mac.py:
1790         (MacPort): Bump current version to 10.14.
1791
1792 2018-07-13  Timothy Hatcher  <timothy@apple.com>
1793
1794         Add _drawsBackground to WKWebViewConfiguration.
1795         https://bugs.webkit.org/show_bug.cgi?id=187665
1796         rdar://problem/42182268
1797
1798         Reviewed by Tim Horton.
1799
1800         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
1801         (TestWebKitAPI.WebKit.ConfigurationDrawsBackground): Added.
1802
1803 2018-07-13  Chris Dumez  <cdumez@apple.com>
1804
1805         Add a FrameLoaderClient willInjectUserScriptForFrame callback
1806         https://bugs.webkit.org/show_bug.cgi?id=187565
1807         <rdar://problem/42095701>
1808
1809         Unreviewed WKTR fix after r233782.
1810
1811         * WebKitTestRunner/TestInvocation.cpp:
1812         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1813
1814 2018-07-13  Chris Dumez  <cdumez@apple.com>
1815
1816         Reduce size of WebCore::URL
1817         https://bugs.webkit.org/show_bug.cgi?id=186820
1818         <rdar://problem/42087508>
1819
1820         Unreviewed, re-generates Service worker registrations database used by API tests after r233789.
1821
1822         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1823         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3: Removed.
1824         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-shm: Removed.
1825         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-wal.
1826         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1827         (TEST):
1828
1829 2018-07-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1830
1831         Make it easier to hit the significant rendered text layout milestone on pages with main article elements
1832         https://bugs.webkit.org/show_bug.cgi?id=187578
1833         <rdar://problem/42104637>
1834
1835         Reviewed by Ryosuke Niwa.
1836
1837         Tweak an existing layout test to additionally check that the significant text layout milestone is fired on a
1838         page with an article element that is clearly the "main" content on the page (i.e. much taller than all other
1839         articles).
1840
1841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1842         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone-article.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html.
1843         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html:
1844         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
1845         (TEST):
1846
1847 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1848
1849         Change my status to be a WebKit reviewer.
1850
1851         Unreviewed status update.
1852
1853         * Scripts/webkitpy/common/config/contributors.json:
1854
1855 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1856
1857         Unreviewed contributors.json update
1858
1859         Just run "validate-committer-lists -c" to canonicalize the style.
1860
1861         * Scripts/webkitpy/common/config/contributors.json:
1862
1863 2018-07-12  Alex Christensen  <achristensen@webkit.org>
1864
1865         Reduce size of WebCore::URL
1866         https://bugs.webkit.org/show_bug.cgi?id=186820
1867
1868         Reviewed by Yusuke Suzuki and Youenn Fablet.
1869
1870         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1871         (TestWebKitAPI::TEST_F):
1872
1873 2018-07-12  Brady Eidson  <beidson@apple.com>
1874
1875         Make process-swap-on-navigation an experimental feature.
1876         <rdar://problem/41995053> and https://bugs.webkit.org/show_bug.cgi?id=187558
1877
1878         Reviewed by Chris Dumez.
1879
1880         Make sure WKTR doesn't enable ProcessSwapOnNavigation by default simply because it's an experimental feature.
1881
1882         * WebKitTestRunner/TestController.cpp:
1883         (WTR::TestController::createWebViewWithOptions):
1884         (WTR::TestController::resetPreferencesToConsistentValues):
1885
1886         * WebKitTestRunner/TestOptions.h:
1887         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const):
1888
1889 2018-07-12  Youenn Fablet  <youenn@apple.com>
1890
1891         Add a FrameLoaderClient willInjectUserScriptForFrame callback
1892         https://bugs.webkit.org/show_bug.cgi?id=187565
1893
1894         Reviewed by Alex Christensen.
1895
1896         Added new test runner API to check for willInjectUserScriptForFrame callback.
1897
1898         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1899         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1900         (WTR::InjectedBundle::resetUserScriptInjectedCount):
1901         (WTR::InjectedBundle::increaseUserScriptInjectedCount):
1902         (WTR::InjectedBundle::userScriptInjectedCount const):
1903         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1904         (WTR::InjectedBundlePage::InjectedBundlePage):
1905         (WTR::InjectedBundlePage::resetAfterTest):
1906         (WTR::InjectedBundlePage::willInjectUserScriptForFrame):
1907         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1908         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1909         (WTR::TestRunner::userScriptInjectedCount const):
1910         (WTR::TestRunner::injectUserScript):
1911         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1912         * WebKitTestRunner/TestController.cpp:
1913         (WTR::TestController::injectUserScript):
1914         * WebKitTestRunner/TestController.h:
1915         * WebKitTestRunner/TestInvocation.cpp:
1916         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1917         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1918         (WTR::TestController::injectUserScript):
1919
1920 2018-07-12  Sihui Liu  <sihui_liu@apple.com>
1921
1922         IndexedDB: database file of subframe cannot be removed
1923         https://bugs.webkit.org/show_bug.cgi?id=187564
1924
1925         Reviewed by Youenn Fablet.
1926
1927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1928         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1929         (TEST):
1930
1931 2018-07-12  Timothy Hatcher  <timothy@apple.com>
1932
1933         Make WebKit.LinkColorWithSystemAppearance work across system versions.
1934         https://bugs.webkit.org/show_bug.cgi?id=187573
1935
1936         Reviewed by Wenson Hsieh.
1937
1938         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1939         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Dynamically generate the expected string.
1940
1941 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1942
1943         [WPE] Pass the backend library name as command line parameter to the web process
1944         https://bugs.webkit.org/show_bug.cgi?id=186841
1945
1946         Reviewed by Žan Doberšek.
1947
1948         * MiniBrowser/wpe/main.cpp:
1949         (main): Stop using WPE_BACKEND_LIBRARY env var.
1950         * Scripts/run-wpe-tests:
1951         (WPETestRunner.__init__): Ditto.
1952         * Scripts/webkitpy/port/wpe.py:
1953         (WPEPort.setup_environ_for_server): Ditto.
1954         * wpe/backends/ViewBackend.cpp:
1955         (WPEToolingBackends::ViewBackend::ViewBackend): Call wpe_loader_init() to ensure WPEBackend-fdo is used.
1956         * wpe/jhbuild.modules: Upgrade WPEBackend to version 0.2.0.
1957
1958 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1959
1960         [GLIB] Add API to allow creating variadic functions
1961         https://bugs.webkit.org/show_bug.cgi?id=187517
1962
1963         Reviewed by Michael Catanzaro.
1964
1965         Add test cases.
1966
1967         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1968         (testJSCFunction):
1969         (fooCreateWithFooV):
1970         (multiplyFooV):
1971
1972 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1973
1974         [GLIB] Add jsc_context_get_global_object() to GLib API
1975         https://bugs.webkit.org/show_bug.cgi?id=187515
1976
1977         Reviewed by Michael Catanzaro.
1978
1979         Add test cases.
1980
1981         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1982         (testJSCGlobalObject):
1983         (main):
1984
1985 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1986
1987         [GLIB] Handle G_TYPE_STRV in glib API
1988         https://bugs.webkit.org/show_bug.cgi?id=187512
1989
1990         Reviewed by Michael Catanzaro.
1991
1992         Add test cases.
1993
1994         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1995         (testJSCTypes):
1996         (joinFunction):
1997         (testJSCFunction):
1998
1999 2018-07-11  Aakash Jain  <aakash_jain@apple.com>
2000
2001         [ews-build] EWS should unapply patch and re-run jsc tests when patch fails jsc tests
2002         https://bugs.webkit.org/show_bug.cgi?id=187549
2003
2004         Reviewed by Alexey Proskuryakov.
2005
2006         * BuildSlaveSupport/ews-build/factories.py:
2007         (JSCTestsFactory.__init__):
2008         * BuildSlaveSupport/ews-build/steps.py:
2009         (CompileJSCOnlyToT): Build ToT without patch.
2010         (CompileJSCOnlyToT.doStepIf): Run this step only if patch failed to build.
2011         (RunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
2012         (ReRunJavaScriptCoreTests): Re-runs JSC tests.
2013         (ReRunJavaScriptCoreTests.doStepIf): Run this step only if patch failed JSC tests.
2014         (ReRunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
2015         (RunJavaScriptCoreTestsToT): Run JSC tests on ToT without patch.
2016         (RunJavaScriptCoreTestsToT.doStepIf): Run this step only if patch failed JSC tests.
2017         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2018
2019 2018-07-11  Commit Queue  <commit-queue@webkit.org>
2020
2021         Unreviewed, rolling out r233742.
2022         https://bugs.webkit.org/show_bug.cgi?id=187577
2023
2024         Binary incompatible change with respect to Service Worker
2025         registration map (Requested by dydz on #webkit).
2026
2027         Reverted changeset:
2028
2029         "Reduce size of WebCore::URL"
2030         https://bugs.webkit.org/show_bug.cgi?id=186820
2031         https://trac.webkit.org/changeset/233742
2032
2033 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
2034
2035         REGRESSION (231276): Attempting to copy an image fails
2036         https://bugs.webkit.org/show_bug.cgi?id=187212
2037
2038         Reviewed by Ryosuke Niwa.
2039         <rdar://problem/41540074>
2040
2041         Augmented test to include a URL where the lastPathComponent looks similar to a
2042         file URL.
2043
2044         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2045         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2046         (TestWebKitAPI::TEST):
2047
2048 2018-07-11  Alex Christensen  <achristensen@webkit.org>
2049
2050         Add SPI for immediate injection of user scripts
2051         https://bugs.webkit.org/show_bug.cgi?id=173342
2052         <rdar://problem/29202285>
2053
2054         Reviewed by Brady Eidson, Youenn Fablet, and Geoff Garen.
2055
2056         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2057         (waitForMessage):
2058         (TEST):
2059
2060 2018-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2061
2062         Move WHLSL spec work to the W3C GPUWeb GitHub repository
2063
2064         See https://github.com/gpuweb/WHLSL
2065
2066         * WebGPUShadingLanguageRI/SpecWork/Makefile: Removed.
2067         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Removed.
2068         * WebGPUShadingLanguageRI/SpecWork/WSL.ott: Removed.
2069         * WebGPUShadingLanguageRI/SpecWork/source/conf.py: Removed.
2070         * WebGPUShadingLanguageRI/SpecWork/source/index.rst: Removed.
2071
2072 2018-07-11  Dean Jackson  <dino@apple.com>
2073
2074         Force WKTR to use the light appearance
2075         https://bugs.webkit.org/show_bug.cgi?id=187572
2076         <rdar://problem/42097805>
2077
2078         Reviewed by Simon Fraser.
2079
2080         Set the NSAppearance on the NSWindow to light mode.
2081
2082         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2083         (WTR::PlatformWebView::PlatformWebView): Use the Aqua appearance.
2084
2085 2018-07-11  Alex Christensen  <achristensen@webkit.org>
2086
2087         Reduce size of WebCore::URL
2088         https://bugs.webkit.org/show_bug.cgi?id=186820
2089
2090         Reviewed by Yusuke Suzuki.
2091
2092         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2093         (TestWebKitAPI::TEST_F):
2094
2095 2018-07-11  Youenn Fablet  <youenn@apple.com>
2096
2097         Fix remaining Cross-Origin-Resource-Policy failures, if any
2098         https://bugs.webkit.org/show_bug.cgi?id=186761
2099         <rdar://problem/41209829>
2100
2101         Reviewed by Alex Christensen.
2102
2103         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
2104         (TestWebKitAPI::TEST):
2105
2106  2018-07-11  Aakash Jain  <aakash_jain@apple.com>
2107  
2108         [ews-build] EWS should unapply the patch and build ToT when patch fails to build
2109         https://bugs.webkit.org/show_bug.cgi?id=187358
2110  
2111         Reviewed by Alexey Proskuryakov.
2112  
2113         * BuildSlaveSupport/ews-build/factories.py:
2114         (BuildFactory.__init__):
2115         * BuildSlaveSupport/ews-build/steps.py:
2116         (CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g.: un-apply patch, compile ToT).
2117         (CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
2118         (CompileWebKitToT): Build ToT without patch.
2119         (CompileWebKitToT.doStepIf): Run this step only if patch failed to build.
2120         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.
2121
2122 2018-07-11  Robin Morisset  <rmorisset@apple.com>
2123
2124         [WSL] WIP, more of the spec
2125         https://bugs.webkit.org/show_bug.cgi?id=186310
2126
2127         Rubberstamped by Filip Pizlo.
2128
2129         Fixed a few issues with the formal rules (such as adding the restrictions on pointers for compilation to SpirV),
2130         and started writing some of the english in the spec.
2131
2132         * WebGPUShadingLanguageRI/SpecWork/WSL.ott:
2133         * WebGPUShadingLanguageRI/SpecWork/source/index.rst:
2134
2135 2018-07-10  Aakash Jain  <aakash_jain@apple.com>
2136
2137         [ews-build] Add build step to UnApply patch
2138         https://bugs.webkit.org/show_bug.cgi?id=187357
2139
2140         Reviewed by Alexey Proskuryakov.
2141
2142         * BuildSlaveSupport/ews-build/steps.py:
2143         (UnApplyPatchIfRequired.__init__): Pass alwaysUseLatest parameter in order to unapply the patch.
2144         (UnApplyPatchIfRequired.doStepIf): Run this step only if patch failed to build or failed test. These
2145         properties will be set by build-steps for build and test.
2146         (UnApplyPatchIfRequired.hideStepIf): Hide this step if it is not run.
2147
2148 2018-07-10  Dewei Zhu  <dewei_zhu@apple.com>
2149
2150         Update ARES-6.patch file accordingly for r233631.
2151         https://bugs.webkit.org/show_bug.cgi?id=187534
2152
2153         Reviewed by Saam Barati.
2154
2155         Update ARES-6.patch file acoordingly after ARES-6 plan file change to
2156         avoid warning while applying the patch.
2157
2158         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2159
2160 2018-07-10  Tim Horton  <timothy_horton@apple.com>
2161
2162         doAfterNextPresentationUpdate should not be called while content is hidden due to animated resize
2163         https://bugs.webkit.org/show_bug.cgi?id=187500
2164         <rdar://problem/41294139>
2165
2166         Reviewed by Simon Fraser.
2167
2168         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2169         (-[AnimatedResizeWebView _endAnimatedResize]):
2170         Set didEndAnimatedResize before calling super, because it makes the
2171         new test easier and doesn't affect any of the existing ones.
2172
2173         (AnimatedResizeBlocksViewportFitChanges):
2174         This doAfterNextPresentationUpdate is always called during animated resize,
2175         and then synchronously waited for, so it /must/ use
2176         _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeWithTesting.
2177         
2178         (AnimatedResizeBlocksDoAfterNextPresentationUpdate):
2179         Add a test ensuring that doAfterNextPresentationUpdate is deferred
2180         until endAnimatedResize is called.
2181
2182         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2183         (-[WKWebView _test_waitForDidFinishNavigation]):
2184         _test_waitForDidFinishNavigation is sometimes called during animated resize,
2185         and synchronously waits for a doAfterNextPresentationUpdate, so
2186         it cannot wait for the animated resize to complete.
2187
2188 2018-07-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2189
2190         [GTK][WPE] TestWTF and TestJSC fail to compile due to missing forwarding headers
2191         https://bugs.webkit.org/show_bug.cgi?id=184441
2192
2193         Reviewed by Michael Catanzaro.
2194
2195         All executables of TestWebKitAPI need the forwarding headers of
2196         WebCore and PAL because config.h includes
2197         <WebCore/PlatformExportMacros.h> and <pal/ExportMacros.h>.
2198
2199         The forwarding headers of WebCore are generated by
2200         generate-forwarding-headers.pl in GTK and WPE ports. The
2201         forwarding headers of PAL are generated by
2202         WEBKIT_MAKE_FORWARDING_HEADERS in all CMake ports.
2203
2204         * TestWebKitAPI/PlatformGTK.cmake: Added PALForwardingHeaders to
2205         ForwardingHeadersForTestWebKitAPI_NAME. Added dependencies of
2206         ${ForwardingHeadersForTestWebKitAPI_NAME} to TestJSC.
2207         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2208
2209 2018-07-10  Stephan Szabo  <stephan.szabo@sony.com>
2210
2211         [WinCairo] Support display of webinspector ui on non-legacy minibrowser
2212         https://bugs.webkit.org/show_bug.cgi?id=187415
2213
2214         Reviewed by Brian Burg.
2215
2216         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2217         (WebKitBrowserWindow::WebKitBrowserWindow):
2218
2219 2018-07-10  John Wilander  <wilander@apple.com>
2220
2221         Resource Load Statistics: Make testRunner.statisticsResetToConsistentState() take a completion handler
2222         https://bugs.webkit.org/show_bug.cgi?id=187499
2223         <rdar://problem/41999431>
2224
2225         Reviewed by Chris Dumez.
2226
2227         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2228         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2229         (WTR::InjectedBundle::didReceiveMessageToPage):
2230         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2231         (WTR::TestRunner::statisticsResetToConsistentState):
2232         (WTR::TestRunner::statisticsCallDidResetToConsistentStateCallback):
2233         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2234         * WebKitTestRunner/TestController.cpp:
2235         (WTR::TestController::statisticsResetToConsistentState):
2236         * WebKitTestRunner/TestInvocation.cpp:
2237         (WTR::TestInvocation::didResetStatisticsToConsistentState):
2238         * WebKitTestRunner/TestInvocation.h:
2239
2240 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2241
2242         Disable cross-origin-window-policy by default
2243         https://bugs.webkit.org/show_bug.cgi?id=187509
2244
2245         Reviewed by Chris Dumez.
2246
2247         Enable the feature for testing purposes. DumpRenderTree does this already in enableExperimentalFeatures.
2248
2249         * WebKitTestRunner/TestController.cpp:
2250         (WTR::TestController::resetPreferencesToConsistentValues):
2251
2252 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2253
2254         [Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
2255         https://bugs.webkit.org/show_bug.cgi?id=187470
2256
2257         Reviewed by Philippe Normand.
2258
2259         Never force building, the user is responsible to make that decision and the workflow is
2260         now based on external scripts so it doesn't make sense anymore. Doing that leads
2261         to ignoring the options the user passed in.
2262
2263         * flatpak/flatpakutils.py:
2264         (WebkitFlatpak.setup_dev_env):
2265
2266 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2267
2268         [Flatpak] Fix running wpt tests inside flatpak
2269         https://bugs.webkit.org/show_bug.cgi?id=187490
2270
2271         Reviewed by Philippe Normand.
2272
2273         Still not *all* passing but a big majority do.
2274
2275         * Scripts/webkitpy/w3c/wpt_runner.py:
2276         (main): Generate the /etc/hosts and mount it in flatpak as required.
2277         (WPTRunner.prepare_wpt_checkout): Renamed as we need to first checkout WPT code before generating /etc/hosts.
2278         (WPTRunner._prepare_wpt_checkout): Deleted.
2279         * flatpak/flatpakutils.py: Added a stdout= argument to run_in_sandbox() and
2280         added a way to pass extra env to flatpak itself (so we can mount /etc/hosts).
2281         Stopped passing `--device=all` as it is not required since r233638 (Bug 187400).
2282         * flatpak/org.webkit.WebKit.yaml: Added virtualenv for python2 as required by wpt.
2283
2284 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
2285
2286         [Flatpak] Use logging to print debug information
2287         https://bugs.webkit.org/show_bug.cgi?id=187496
2288
2289         Reviewed by Philippe Normand.
2290
2291         * flatpak/flatpakutils.py:
2292         (WebkitFlatpak.load_from_args):
2293         (WebkitFlatpak.clean_args):
2294         (WebkitFlatpak.run_in_sandbox):
2295
2296 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2297
2298         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2299         https://bugs.webkit.org/show_bug.cgi?id=187425
2300         rdar://problem/39948240
2301         rdar://problem/41796865
2302
2303         Reviewed by Tim Horton.
2304
2305         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2306         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Use new color value.
2307
2308 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2309
2310         Fix dump-class-layout to show bit padding, and fix issues with padding offsets
2311         https://bugs.webkit.org/show_bug.cgi?id=187442
2312
2313         Reviewed by Daniel Bates.
2314         
2315         Synthetic padding members were shown with the wrong offset because they used the
2316         absolute offset rather than the class-relative offset. This didn't change the padding
2317         math, but made the output confusing.
2318         
2319         Also add support for showing empty bits in bitfields, and fix computation of padding
2320         after bitfields. Empty bits are computed by inserting a bit padding member after
2321         a bitfield that is not followed by another bitfield (making the assumption that bit
2322         padding will fill to the next byte boundary).
2323         
2324         The computation of padding after bitfields was also wrong, since lldb's member_type.GetByteSize()
2325         just reports the size of the type without the bitfield modifier (e.g. for "unsigned : 2" it returned 4).
2326         Fix by setting the byte size for bitfield fields to the number of bits rounded up to the next byte;
2327         this allows byte padding following the bitfield to be computed correctly.
2328         
2329         Add or modify test to cover these issues.
2330
2331         * lldb/dump_class_layout_unittest.py:
2332         (serial_test_ClassWithPaddedBitfields):
2333         (serial_test_MemberHasBitfieldPadding):
2334         (serial_test_InheritsFromClassWithPaddedBitfields):
2335         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
2336         (avoidClassDeadStripping):
2337         * lldb/lldb_dump_class_layout.py:
2338         (ClassLayoutBase):
2339         (ClassLayoutBase._to_string_recursive):
2340         (ClassLayout._parse):
2341         (ClassLayout._compute_padding_recursive):
2342
2343 2018-07-09  Youenn Fablet  <youenn@apple.com>
2344
2345         StringView operator==(char*) should check the length of the string
2346         https://bugs.webkit.org/show_bug.cgi?id=187422
2347
2348         Reviewed by Chris Dumez.
2349
2350         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2351         (TestWebKitAPI::equal2):
2352         (TestWebKitAPI::TEST):
2353
2354 2018-07-09  Ross Kirsling  <rkirsling@gmail.com>
2355
2356         [WinCairo] httpd service install needs to precede server start
2357         https://bugs.webkit.org/show_bug.cgi?id=187283
2358
2359         Reviewed by Daniel Bates.
2360
2361         * Scripts/webkitpy/port/base.py:
2362         (Port.check_build):
2363         Remove unused parameter `needs_http`.
2364         
2365         (Port.check_sys_deps):
2366         (Port.start_http_server):
2367         Move `check_httpd` call.
2368
2369         * Scripts/webkitpy/port/win.py:
2370         (WinPort.check_httpd): Added.
2371         (WinCairoPort.check_httpd): Deleted.
2372         Move `httpd -k install` logic to common Windows location.
2373
2374         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2375         (Manager._set_up_run):
2376         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2377         * Scripts/webkitpy/port/gtk.py:
2378         (GtkPort.check_sys_deps):
2379         * Scripts/webkitpy/port/ios_simulator.py:
2380         (IOSSimulatorPort.check_sys_deps):
2381         * Scripts/webkitpy/port/mock_drt.py:
2382         (MockDRTPort.check_build):
2383         (MockDRTPort.check_sys_deps):
2384         * Scripts/webkitpy/port/port_testcase.py:
2385         (PortTestCase.integration_test_check_sys_deps):
2386         (test_check_build):
2387         * Scripts/webkitpy/port/test.py:
2388         * Scripts/webkitpy/port/wpe.py:
2389         (WPEPort.check_sys_deps):
2390         * Scripts/webkitpy/tool/commands/perfalizer.py:
2391         (PerfalizerTask.run):
2392         Remove `needs_http` arguments.
2393
2394 2018-07-09  Philippe Normand  <pnormand@igalia.com>
2395
2396         [Flatpak] Unreviewed, switch to https for the gst-libav tarball.
2397         
2398         * flatpak/org.webkit.WebKit.yaml:
2399
2400 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
2401
2402         [Flatpak] HTTP layout tests broken due to missing CGI.pm in the sandbox
2403         https://bugs.webkit.org/show_bug.cgi?id=187384
2404
2405         Reviewed by Philippe Normand.
2406
2407         And make it usable inside the sandbox even when
2408         perl is launched "tainted" (as the PERL5LIB won't
2409         work otherwise).
2410
2411         * flatpak/flatpakutils.py:
2412         (WebkitFlatpak.run_in_sandbox):
2413         * flatpak/org.webkit.WebKit.yaml:
2414
2415 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
2416
2417         [WPE][GTK] Mount /dev/shm on /run/shm in sandbox
2418         https://bugs.webkit.org/show_bug.cgi?id=187400
2419
2420         Reviewed by Philippe Normand.
2421
2422         This is where it is expected to be when it is a symlink,
2423         without mounting it the websocket python server can't work
2424         inside the sandbox.
2425
2426         * flatpak/flatpakutils.py:
2427         (WebkitFlatpak.run_in_sandbox):
2428
2429 2018-07-08  Filip Pizlo  <fpizlo@apple.com>
2430
2431         run-benchmark should run ARES-6 1.0.1
2432         https://bugs.webkit.org/show_bug.cgi?id=187452
2433
2434         Reviewed by Sam Weinig.
2435         
2436         We forgot to update this when we released 1.0.1!
2437
2438         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2439
2440 2018-07-07  Youenn Fablet  <youenn@apple.com>
2441
2442         WPT importer should create dummy HTML files for *.window.js script files
2443         https://bugs.webkit.org/show_bug.cgi?id=187426
2444
2445         Reviewed by Ryosuke Niwa.
2446
2447         Some WPT tests use *.window.js tests, which should be accessed as *.window.html.
2448         Do the same strategy as done for worker.js/any.js files.
2449
2450         * Scripts/webkitpy/w3c/test_importer.py:
2451         (TestImporter.write_html_files_for_templated_js_tests):
2452
2453 2018-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2454
2455         Introduce a layout milestone to track when the document contains a large number of rendered characters
2456         https://bugs.webkit.org/show_bug.cgi?id=187412
2457         <rdar://problem/41744338>
2458
2459         Reviewed by Ryosuke Niwa.
2460
2461         Add a new API test to check that we observe the new rendering milestone in an article-like document.
2462
2463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2464         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html: Added.
2465         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2466         (TEST):
2467
2468 2018-06-30  Simon Fraser  <simon.fraser@apple.com>
2469
2470         dump-class-layout reports wrong padding in many cases
2471         https://bugs.webkit.org/show_bug.cgi?id=185801
2472
2473         Reviewed by Dan Bates.
2474         
2475         Enhance dump-class-layout, fixing bugs and adding unit tests. This also includes
2476         the patch from bug 187141.
2477         
2478         Move the code that uses lldb to fetch the class layout to its own module,
2479         lldb_dump_class_layout.py, so it can be unit tested. Change this code
2480         to build up a data structure for the class. This is necessary since correct
2481         padding computation is easier with second traversal over the data structure.
2482         
2483         Try to deal with the empty base class optimization, which is necessary to report
2484         correct padding in classes using std::unique_ptr, and correctly handle virtual base classes.
2485         
2486         The ClassLayoutBase class knows how to test for equality and generate a string
2487         or string list representation of itself. The derived ClassLayout class knows
2488         how to build up the class layout using the lldb Python bindings.
2489         
2490         Finally we wrap the lldb debugger instance in LLDBDebuggerInstance so that we don't
2491         have to make a new one for each unit test. The tests have to run serially.
2492         
2493         Add to lldbWebKitTester a .cpp file that contains a set of C++ classes to unit-test
2494         dump-class-layout.
2495
2496         * Scripts/dump-class-layout:
2497         (main):
2498         * lldb/dump_class_layout_unittest.py:
2499         (destroy_cached_debug_session):
2500         (TestDumpClassLayout):
2501         (TestDumpClassLayout.setUpClass):
2502         (TestDumpClassLayout.setUp):
2503         (TestDumpClassLayout.serial_test_BasicClassLayout):
2504         (serial_test_PaddingBetweenClassMembers):
2505         (serial_test_BoolPaddingClass):
2506         (serial_test_ClassWithEmptyClassMembers):
2507         (serial_test_SimpleVirtualClass):
2508         (serial_test_SimpleVirtualClassWithNonVirtualBase):
2509         (serial_test_InterleavedVirtualNonVirtual):
2510         (serial_test_ClassWithTwoVirtualBaseClasses):
2511         (serial_test_ClassWithClassMembers):
2512         (serial_test_ClassWithBitfields):
2513         (serial_test_ClassWithUniquePtrs):
2514         (serial_test_ClassWithOptionals):
2515         (TestDumpClassLayout.test_BasicClassLayout): Deleted.
2516         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
2517         (EmptyClass::doStuff):
2518         (VirtualBaseClass::~VirtualBaseClass):
2519         (VirtualBaseClass2::~VirtualBaseClass2):
2520         (SimpleVirtualClass::~SimpleVirtualClass):
2521         (SimpleVirtualClass::doStuff):
2522         (SimpleVirtualClassWithNonVirtualBase::~SimpleVirtualClassWithNonVirtualBase):
2523         (SimpleVirtualClassWithNonVirtualBase::doStuff):
2524         (avoidClassDeadStripping):
2525         * lldb/lldb_dump_class_layout.py:
2526         (ansi_colors):
2527         (ClassLayoutBase):
2528         (ClassLayoutBase.__init__):
2529         (ClassLayoutBase.__ne__):
2530         (ClassLayoutBase.__eq__):
2531         (ClassLayoutBase._to_string_recursive):
2532         (ClassLayoutBase.as_string_list):
2533         (ClassLayoutBase.as_string):
2534         (ClassLayoutBase.dump):
2535         (ClassLayoutExpected):
2536         (ClassLayoutExpected.__init__):
2537         (ClassLayout):
2538         (ClassLayout.__init__):
2539         (ClassLayout._has_polymorphic_base_class):
2540         (ClassLayout._parse):
2541         (ClassLayout._probably_has_empty_base_class_optimization):
2542         (ClassLayout._compute_padding_recursive):
2543         (ClassLayout._compute_padding):
2544         (LLDBDebuggerInstance):
2545         (LLDBDebuggerInstance.__init__):
2546         (LLDBDebuggerInstance.__del__):
2547         (LLDBDebuggerInstance._get_first_file_architecture):
2548         (LLDBDebuggerInstance.layout_for_classname):
2549         (ClassLayoutDumper): Deleted.
2550         (ClassLayoutDumper.__init__): Deleted.
2551         (ClassLayoutDumper._get_first_file_architecture): Deleted.
2552         (ClassLayoutDumper.verify_type): Deleted.
2553         (ClassLayoutDumper.verify_type_recursive): Deleted.
2554         (ClassLayoutDumper._class_layout_as_string): Deleted.
2555         (ClassLayoutDumper.dump_to_string): Deleted.
2556         (ClassLayoutDumper.dump): Deleted.
2557
2558 2018-07-06  Christopher Reid  <chris.reid@sony.com>
2559
2560         [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to certain URLs
2561         https://bugs.webkit.org/show_bug.cgi?id=187167
2562
2563         Reviewed by Alex Christensen.
2564
2565         A null byte was written past the end of the buffer causing the crash.
2566         Some of the heap allocated buffers were also not getting deleted.
2567
2568         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2569
2570 2018-07-06  Thibault Saunier  <tsaunier@igalia.com>
2571
2572         [WPE][GTK] Build php zlib plugin and enable sockets in flatpak
2573         https://bugs.webkit.org/show_bug.cgi?id=187401
2574
2575         Reviewed by Philippe Normand.
2576
2577         * flatpak/org.webkit.WebKit.yaml:
2578
2579 2018-07-06  Aakash Jain  <aakash_jain@apple.com>
2580
2581         [ews-build] EWS should run javascriptcore tests
2582         https://bugs.webkit.org/show_bug.cgi?id=187365
2583
2584         Reviewed by David Kilzer.
2585
2586         * BuildSlaveSupport/ews-build/steps.py: Added step to run JavaScriptCoreTests.
2587         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2588         * BuildSlaveSupport/ews-build/factories.py:
2589
2590 2018-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2591
2592         [GTK][WPE] REGRESSION(r233111): Test /webkit/WebKitUserContentManager/script-message-received fails
2593         https://bugs.webkit.org/show_bug.cgi?id=187383
2594
2595         Reviewed by Žan Doberšek.
2596
2597         This is actually a problem in the test itself. The problem is that we run js, connect to message-received and
2598         quite the main loop when the message is received, which happens before the run js operation has been
2599         completed. The test finishes early and since r233111 an IPC message is still pending (I guess the run js
2600         callback) and the web page is still protected. Just adding a run loop operation before finishing the test would
2601         fix it. We should wait for the js run to complete, instead of the message.
2602
2603         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2604         (UserScriptMessageTest::scriptMessageReceived):
2605         (UserScriptMessageTest::waitUntilMessageReceived):
2606         (UserScriptMessageTest::runJavaScriptFinished):
2607         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
2608
2609 2018-07-05  Youenn Fablet  <youenn@apple.com>
2610
2611         REGRESSION (r230843): Flash doesn't work; Produces blue box on page
2612         https://bugs.webkit.org/show_bug.cgi?id=187346
2613         <rdar://problem/41773974>
2614
2615         Reviewed by Ryosuke Niwa.
2616
2617         * WebKitTestRunner/TestController.cpp:
2618         (WTR::TestController::resetStateToConsistentValues):
2619         (WTR::TestController::setBlockAllPlugins):
2620         When not blocked, set the load policy to allow once.
2621         * WebKitTestRunner/TestController.h:
2622
2623 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2624
2625         [ews-build] Bindings-tests-EWS should output result in json
2626         https://bugs.webkit.org/show_bug.cgi?id=187330
2627
2628         Reviewed by David Kilzer.
2629
2630         * BuildSlaveSupport/ews-build/steps.py:
2631         (RunBindingsTests):  Passed --json-output parameter to run-bindings-tests.
2632         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2633
2634 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2635
2636         [ews-build] WebKitPy-Tests-EWS should output result in json
2637         https://bugs.webkit.org/show_bug.cgi?id=187331
2638
2639         Follow-up fix to r233527. Extracting jsonFileName as a variable and re-using it.
2640
2641 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2642
2643         [ews-build] WebKitPy-Tests-EWS should output result in json
2644         https://bugs.webkit.org/show_bug.cgi?id=187331
2645
2646         Reviewed by David Kilzer.
2647
2648         * BuildSlaveSupport/ews-build/steps.py:
2649         (RunWebKitPyTests): Passed --json-output parameter to test-webkitpy.
2650         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2651
2652 2018-07-05  Philippe Normand  <pnormand@igalia.com>
2653
2654         [Flatpak] Add gst-libav to dependencies
2655         https://bugs.webkit.org/show_bug.cgi?id=187340
2656
2657         Reviewed by Žan Doberšek.
2658
2659         * flatpak/org.webkit.WebKit.yaml: Use tarballs instead of git
2660         clones because the FFMPeg git server doesn't support shallow
2661         clones.
2662
2663 2018-07-05  Thibault Saunier  <tsaunier@igalia.com>
2664
2665         [WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects
2666         https://bugs.webkit.org/show_bug.cgi?id=187322
2667
2668         Reviewed by Žan Doberšek.
2669
2670         * flatpak/flatpakutils.py:
2671         (WebkitFlatpak.__init__):
2672
2673 2018-07-05  Zan Dobersek  <zdobersek@igalia.com>
2674
2675         Unreviewed, rolling out r233511.
2676
2677         Proper fix provided in bug #187322
2678
2679         Reverted changeset:
2680
2681         "Unreviewed. Fixing a call in flatpakutils.py to
2682         PortFactory.get(),"
2683         https://trac.webkit.org/changeset/233511
2684
2685 2018-07-04  Zan Dobersek  <zdobersek@igalia.com>
2686
2687         Unreviewed. Fixing a call in flatpakutils.py to PortFactory.get(),
2688         enforcing the passed platform argument to always be lowercase, as is
2689         expected from the PortFactory code.
2690
2691         * flatpak/flatpakutils.py:
2692         (WebkitFlatpak.clean_args):
2693
2694 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2695
2696         Introduce PLATFORM(IOSMAC)
2697         https://bugs.webkit.org/show_bug.cgi?id=187315
2698
2699         Reviewed by Dan Bernstein.
2700
2701         * TestWebKitAPI/Configurations/Base.xcconfig:
2702         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2703
2704 2018-07-03  Brady Eidson  <beidson@apple.com>
2705
2706         WebKit.ResponsivenessTimerCrash sometimes fails.
2707         https://bugs.webkit.org/show_bug.cgi?id=187314
2708
2709         Reviewed by Tim Horton.
2710
2711         Actually unregister observers from objects we're about to destroy before destroying them.
2712
2713         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
2714         (-[ResponsivenessTimerObserver observeValueForKeyPath:ofObject:change:context:]): 
2715
2716 2018-07-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2717
2718         update-webkitgtk-flatpak fails if running with python2
2719         https://bugs.webkit.org/show_bug.cgi?id=187240
2720
2721         Reviewed by Michael Catanzaro.
2722
2723         urllib.urlretrieve of Python2 sends invalid requests. Use
2724         urllib2.urlopen instead.
2725
2726         * flatpak/flatpakutils.py: Import urllib2.urlopen for Python2,
2727         urllib.request.urlopen for Python3.
2728         (FlatpakRepo.repo_file): Copy the content of urlopen result to the
2729         temporary file.
2730
2731 2018-07-03  Chris Dumez  <cdumez@apple.com>
2732
2733         Make CallbackMap::invalidate() safe to re-enter
2734         https://bugs.webkit.org/show_bug.cgi?id=187298
2735         <rdar://problem/41057167>
2736
2737         Reviewed by Geoffrey Garen.
2738
2739         Add API test coverage.
2740
2741         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
2742         (TEST):
2743
2744 2018-07-03  Chris Dumez  <cdumez@apple.com>
2745
2746         [Cocoa] Disable vnode guard related simulated crashes for WKTR / DRT and WebSQL
2747         https://bugs.webkit.org/show_bug.cgi?id=187270
2748         <rdar://problem/40674034>
2749
2750         Reviewed by Geoffrey Garen.
2751
2752         Disable vnode guard related simulated crashes for WKTR / DRT by setting the
2753         expected environment variable in the test driver.
2754
2755         * Scripts/webkitpy/port/driver.py:
2756         (Driver._setup_environ_for_driver):
2757
2758 2018-07-03  Eric Carlson  <eric.carlson@apple.com>
2759
2760         Video sometimes flickers when playing to AppleTV
2761         https://bugs.webkit.org/show_bug.cgi?id=187193
2762         <rdar://problem/40153865>
2763
2764         Unreviewed, fix test broken by r233435.
2765
2766         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2767         (TestWebKitAPI::waitUntilAudioSessionCategoryIsEqualTo): Poll for a change in audio session 
2768         category because it doesn't necessarily happen synchronously.
2769         (TestWebKitAPI::TEST):
2770
2771 2018-07-03  Thibault Saunier  <tsaunier@igalia.com>
2772
2773         Unreviewed, add myself as a WebKit committer.
2774
2775         And canonicalize the file as suggested by `check-webkit-style`
2776
2777         * Scripts/webkitpy/common/config/contributors.json:
2778
2779 2018-07-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2780
2781         check-webkit-style: Run the tool without SVN client.
2782         https://bugs.webkit.org/show_bug.cgi?id=187294
2783
2784         Reviewed by Daniel Bates.
2785
2786         When invoking check-webkit-style without SVN client, the exception was raised and terminated.
2787         Using Git repository is acceptable workflow according to the wording on:
2788         <https://webkit.org/getting-the-code/#checking-out-with-git>
2789         and using Subversion is considered optional by following link:
2790         <https://webkit.org/webkit-on-windows/#installing-developer-tools>.
2791         This patch makes it so that people with only a Git checkout of WebKit that commit using
2792         the commit-queue (or another machine with an SVN checkout) can run check-webkit-style.
2793
2794         * Scripts/webkitpy/common/checkout/scm/svn.py:
2795         (SVN.in_working_directory):
2796
2797 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
2798
2799         Remove old JSCTestsFactory
2800
2801         Follow-up fix to r233471.
2802
2803 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
2804
2805         [ews-build] Add support for JSC-Tests-EWS
2806         https://bugs.webkit.org/show_bug.cgi?id=187201
2807
2808         Reviewed by Lucas Forschler.
2809
2810         * BuildSlaveSupport/ews-build/factories.py:
2811         (JSCTestsFactory): Added JSCTestsFactory.
2812         * BuildSlaveSupport/ews-build/steps.py:
2813         (CompileJSCOnly): Command to compile JSC.
2814         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2815         * BuildSlaveSupport/ews-build/config.json: Changed platform to jsc-only. This matches with build.webkit.org configuration.
2816
2817 2018-07-03  Zalan Bujtas  <zalan@apple.com>
2818
2819         [LFC] Add test-list file for regression testing
2820         https://bugs.webkit.org/show_bug.cgi?id=187296
2821
2822         Reviewed by Antti Koivisto.
2823
2824         run-webkit-tests --test-list=./Tools/LayoutReloaded/misc/LFC-passing-tests.txt
2825
2826         * LayoutReloaded/misc/LFC-passing-tests.txt: Added.
2827
2828 2018-07-03  John Wilander  <wilander@apple.com>
2829
2830         Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools
2831         https://bugs.webkit.org/show_bug.cgi?id=187277
2832         <rdar://problem/41745510>
2833
2834         Reviewed by Chris Dumez.
2835
2836         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2837         (WTR::TestController::getAllStorageAccessEntries):
2838
2839 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2840
2841         Fix a leak in ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController
2842         https://bugs.webkit.org/show_bug.cgi?id=187280
2843
2844         Reviewed by Tim Horton.
2845
2846         Add a missing `adoptNS()`.
2847
2848         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2849         (TestWebKitAPI::TEST):
2850
2851 2018-07-02  Myles C. Maxfield  <mmaxfield@apple.com>
2852
2853         [Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed
2854         https://bugs.webkit.org/show_bug.cgi?id=187228
2855         <rdar://problem/40967280>
2856
2857         Reviewed by Brent Fulgham.
2858
2859         The test only fails before the patch if the lookup for Helvetica2 is allowed to occur.
2860
2861         * WebKitTestRunner/mac/TestControllerMac.mm:
2862         (WTR::allowedFontFamilySet):
2863
2864 2018-07-02  Ryosuke Niwa  <rniwa@webkit.org>
2865
2866         run-benchmark should include the version number of MotionMark's results
2867         https://bugs.webkit.org/show_bug.cgi?id=187274
2868
2869         Reviewed by Jon Lee.
2870
2871         Append the version number as a part of the suite name.
2872
2873         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2874
2875 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2876
2877         [WK1] editing/spelling/markers.html is failing on recent builds of macOS Mojave
2878         https://bugs.webkit.org/show_bug.cgi?id=187253
2879
2880         Reviewed by Tim Horton.
2881
2882         Enhances and refactors LayoutTestSpellChecker, which was introduced in r233412.
2883
2884         * DumpRenderTree/TestRunner.cpp:
2885         (setSpellCheckerResultsCallback):
2886
2887         Rename setSpellCheckerTextReplacements to setSpellCheckerResults.
2888
2889         (TestRunner::staticFunctions):
2890         (setSpellCheckerTextReplacementsCallback): Deleted.
2891         * DumpRenderTree/TestRunner.h:
2892         * DumpRenderTree/mac/TestRunnerMac.mm:
2893         (TestRunner::setSpellCheckerResults):
2894         (TestRunner::setSpellCheckerTextReplacements): Deleted.
2895         * DumpRenderTree/win/TestRunnerWin.cpp:
2896         (TestRunner::setSpellCheckerResults):
2897         (TestRunner::setSpellCheckerTextReplacements): Deleted.
2898         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
2899         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2900         (-[LayoutTestTextCheckingResult initWithType:range:replacement:details:]):
2901         (-[LayoutTestTextCheckingResult grammarDetails]):
2902         (-[LayoutTestSpellChecker reset]):
2903         (-[LayoutTestSpellChecker results]):
2904         (-[LayoutTestSpellChecker setResults:]):
2905         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]):
2906
2907         Add support for passing in a list of grammar correction detail ranges. Necessary for simulating grammar errors.
2908
2909         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
2910
2911         Tweaked to always call the superclass method. This ensures that we set the `orthography` and `wordCount`
2912         outpointers if applicable.
2913
2914         (-[LayoutTestSpellChecker requestCheckingOfString:range:types:options:inSpellDocumentWithTag:completionHandler:]):
2915
2916         Added support for simulating asynchronous spell checking.
2917
2918         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]): Deleted.
2919         (-[LayoutTestSpellChecker replacements]): Deleted.
2920         (-[LayoutTestSpellChecker setReplacements:]): Deleted.
2921         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]): Deleted.
2922
2923 2018-07-02  Brady Eidson  <beidson@apple.com>
2924
2925         Another unreviewed followup to:
2926         Crash notifying observers of responsiveness state change
2927
2928         * TestWebKitAPI/cocoa/TestWKWebView.h:
2929         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2930         (-[TestWKWebView typeCharacter:]): Move this back to the Mac-only category, as we won't be running this
2931           test on iOS for other reasons.
2932
2933 2018-07-02  Brady Eidson  <beidson@apple.com>
2934
2935         Unreviewed followup to:
2936         Crash notifying observers of responsiveness state change
2937
2938         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Need the C-SPI for this test.
2939
2940 2018-07-02  Brady Eidson  <beidson@apple.com>
2941
2942         Crash notifying observers of responsiveness state change
2943         <rdar://problem/41267796> and https://bugs.webkit.org/show_bug.cgi?id=187262
2944
2945         Reviewed by Tim Horton.
2946
2947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2948         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Added.
2949         (-[RTObserver observeValueForKeyPath:ofObject:change:context:]):
2950         (TestWebKitAPI::TEST):
2951         * TestWebKitAPI/cocoa/TestWKWebView.h:
2952         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2953         (-[TestWKWebView typeCharacter:]):
2954         (-[TestWKWebView hostWindow]):
2955
2956 2018-07-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2957
2958         [WPE][GTK] flatpakutils.py should respect set-webkit-configuration build type
2959         https://bugs.webkit.org/show_bug.cgi?id=187218
2960
2961         Reviewed by Philippe Normand.
2962
2963         Using the webkitpy Config module, if the build type is not passed on the command line, we
2964         read it from WebKitBuild/Configuration and respect it.
2965
2966         * flatpak/flatpakutils.py:
2967         (WebkitFlatpak.__init__):
2968         (WebkitFlatpak.clean_args):
2969
2970 2018-07-02  Zan Dobersek  <zdobersek@igalia.com>
2971
2972         [WPE] Add touch support to WindowViewBackend
2973         https://bugs.webkit.org/show_bug.cgi?id=187245
2974
2975         Reviewed by Carlos Garcia Campos.
2976
2977         Add touch input support to the WindowViewBackend implementation,
2978         plugging into the Wayland protocol in order to get properly notified
2979         about these events, and then dispatching them against the appropriate
2980         wpe_view_backend object so that WebKit can process them.
2981
2982         * wpe/backends/ViewBackend.cpp:
2983         (WPEToolingBackends::ViewBackend::dispatchInputTouchEvent):
2984         * wpe/backends/ViewBackend.h:
2985         * wpe/backends/WindowViewBackend.cpp:
2986         * wpe/backends/WindowViewBackend.h:
2987
2988 2018-07-02  Rob Buis  <rbuis@igalia.com>
2989
2990         [GTK] ASSERTION FAILED: url == m_string in UserAgentQuirks test
2991         https://bugs.webkit.org/show_bug.cgi?id=186838
2992
2993         This URL constructor expects canonicalized input, so fix the passed URL. I missed
2994         this one some weeks ago since I had an older checkout.
2995
2996         Reviewed by Michael Catanzaro.
2997
2998         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2999         (TestWebKitAPI::TEST):
3000
3001 2018-07-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3002
3003         [macOS] Text replacements that end with symbols are expanded immediately
3004         https://bugs.webkit.org/show_bug.cgi?id=187225
3005         <rdar://problem/41112433>
3006
3007         Reviewed by Darin Adler.
3008
3009         Adds testing support for mocking NSSpellChecker's text checking results. See below for more details, and the new
3010         layout test for an example of its usage.
3011
3012         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3013         * DumpRenderTree/TestRunner.cpp:
3014         (setSpellCheckerTextReplacementsCallback):
3015
3016         Add bindings support in TestRunner to specify a set of text replacement mappings. Each entry in the dictionary
3017         maps a string representing an input to the NSSpellChecker to some information describing the spell checking
3018         result that LayoutTestSpellChecker will return.
3019
3020         (TestRunner::staticFunctions):
3021         * DumpRenderTree/TestRunner.h:
3022         * DumpRenderTree/mac/DumpRenderTree.mm:
3023         (resetWebViewToConsistentStateBeforeTesting):
3024
3025         Restore the original shared NSSpellchecker before transitioning to the next layout test, if needed.
3026
3027         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Removed.
3028         * DumpRenderTree/mac/TestRunnerMac.mm:
3029         (TestRunner::setSpellCheckerLoggingEnabled):
3030         (TestRunner::setSpellCheckerTextReplacements):
3031
3032         These testRunner methods ensure that `-[NSSpellChecker sharedSpellChecker]` is swizzled to return our mock
3033         LayoutTestSpellChecker instance before calling into it.
3034
3035         * DumpRenderTree/win/TestRunnerWin.cpp:
3036         (TestRunner::setSpellCheckerTextReplacements):
3037         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreeSpellChecker.h.
3038         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm: Added.
3039
3040         Moved DumpRenderTreeSpellChecker to LayoutTestSpellChecker, and made it compile for both WebKitTestRunner
3041         (modern WebKit) and DumpRenderTree (legacy WebKit) by putting it in TestRunnerShared.
3042
3043         (existingGlobalLayoutTestSpellChecker):
3044         (ensureGlobalLayoutTestSpellChecker):
3045         (stringForCorrectionResponse):
3046         (nsTextCheckingType):
3047         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]):
3048         (-[LayoutTestTextCheckingResult range]):
3049         (-[LayoutTestTextCheckingResult resultType]):
3050         (-[LayoutTestTextCheckingResult replacementString]):
3051         (-[LayoutTestTextCheckingResult description]):
3052
3053         LayoutTestTextCheckingResult represents a fake NSTextCheckingResult containing spell checking results supplied
3054         by the layout test.
3055
3056         (+[LayoutTestSpellChecker installIfNecessary]):
3057         (+[LayoutTestSpellChecker uninstallAndReset]):
3058
3059         Helper methods to begin and end swizzling the shared NSSpellChecker.
3060
3061         (-[LayoutTestSpellChecker reset]):
3062
3063         Resets the state of the LayoutTestSpellChecker (this entails clearing the fake replacements dictionary and
3064         turning off logging for recorded spellchecking responses).
3065
3066         (-[LayoutTestSpellChecker replacements]):
3067         (-[LayoutTestSpellChecker setReplacements:]):
3068         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]):
3069
3070         Helper method to take a `JSObjectRef` supplied by the test runner and transform it into a map of spell checking
3071         string inputs to LayoutTestTextCheckingResults.
3072
3073         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
3074
3075         Consult the text replacement map and bail early if a match is found, before calling into real NSSpellChecker
3076         logic to perform spellchecking.
3077
3078         (-[LayoutTestSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:]):
3079
3080         Reimplement the original functionality in DumpRenderTreeSpellChecker to make `-recordResponse:…` print to stdout
3081         by overriding the method and printing if the `-spellCheckerLoggingEnabled` property has been set to YES.
3082
3083         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3084
3085 2018-07-01  Thibault Saunier  <tsaunier@igalia.com>
3086
3087         [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner
3088         https://bugs.webkit.org/show_bug.cgi?id=187232
3089
3090         Reviewed by Michael Catanzaro.
3091
3092         The place where host tmp folder is mounted changed to /run/host/ we
3093         need to take that into account.
3094
3095         Also explicitely close temporary files as relying on garbage collection to
3096         remove them is a bad idea.
3097
3098         Also minor optimization avoiding to compile regex for each backtrace
3099         retrieval.
3100
3101         * Scripts/webkitpy/port/linux_get_crash_log.py:
3102         (GDBCrashLogGenerator):
3103         (GDBCrashLogGenerator._get_tmp_file_name):
3104         (GDBCrashLogGenerator._get_trace_from_systemd):
3105
3106 2018-06-30  Daniel Bates  <dabates@apple.com>
3107
3108         test-webkitpy never rebuilds lldbWebKitTester
3109         https://bugs.webkit.org/show_bug.cgi?id=187229
3110
3111         Reviewed by David Kilzer.
3112
3113         Have test-webkitpy always call script build-lldbwebkittester to build lldbWebKitTester, if needed.
3114
3115         Currently test-webkitpy only calls script build-lldbwebkittester if lldbWebKitTester does not
3116         exist in the build products directory for the active configuration (e.g. Debug); => we do not
3117         build lldbWebKitTester again if its source changes (say, as a result of hacking on lldbWebKitTester).
3118         Instead we should have test-webkitpy unconditionally call build-lldbwebkittester to ensure
3119         that we have an up-to-date build of lldbWebKitTester.
3120
3121         * Scripts/webkitpy/test/main.py:
3122         (Tester._run_tests):
3123         (_find_lldb_webkit_tester): Deleted.
3124
3125 2018-06-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3126
3127         [CMake] build-webkit should be able to enable address sanitizer
3128         https://bugs.webkit.org/show_bug.cgi?id=187222
3129
3130         Reviewed by Daniel Bates.
3131
3132         If 'set-webkit-configuration --asan' has been run, then build-webkit should pass
3133         -DENABLE_ADDRESS_SANITIZER=ON to CMake, so that it actually does something.
3134
3135         This also works for build-jsc.
3136
3137         * Scripts/webkitdirs.pm:
3138         (generateBuildSystemFromCMakeProject):
3139
3140 2018-06-30  Thibault Saunier  <tsaunier@igalia.com>
3141
3142         Make check_flatpak() not verbose when only trying to run command inside flatpak
3143         https://bugs.webkit.org/show_bug.cgi?id=187187
3144
3145         Reviewed by Michael Catanzaro.
3146
3147         * flatpak/flatpakutils.py:
3148         (run_in_sandbox_if_available):
3149
3150 2018-06-29  Daniel Bates  <dabates@apple.com>
3151
3152         build-webkit: Perl "use of uninitialized value $previousContents"
3153         https://bugs.webkit.org/show_bug.cgi?id=185776
3154
3155         Reviewed by Michael Catanzaro.
3156
3157         Fixes an issue where reading an empty cached argument file would cause
3158         Perl "uninitialized value" warnings of the form:
3159             Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969.
3160             Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972.
3161
3162         * Scripts/webkitdirs.pm:
3163         (isCachedArgumentfileOutOfDate):
3164
3165 2018-06-29  Daniel Bates  <dabates@apple.com>
3166
3167         Perl uninitialized value $isEnabled when running build-jsc using a CMake build
3168         https://bugs.webkit.org/show_bug.cgi?id=187208
3169
3170         Reviewed by Tim Horton.
3171
3172         Share logic for computing the feature flags to enable in CMake with both script
3173         build-webkit and script build-jsc instead of duplicating it. This also fixes a
3174         bug in the version of this logic in build-jsc that was inadvertently not updated
3175         in r222394. In r222394 we removed the notion of a default value for a feature flag
3176         listed in webkitperl::FeatureList.
3177
3178         We keep the current behavior of build-jsc and leave it up to the build system
3179         to determine whether to enable or disable ENABLE_EXPERIMENTAL_FEATURES.
3180
3181         * Scripts/build-jsc:
3182         (buildMyProject):
3183         (cMakeArgsFromFeatures): Deleted.
3184         * Scripts/build-webkit:
3185         (cMakeArgsFromFeatures): Deleted; moved to webkitdirs.pm.
3186         * Scripts/webkitdirs.pm:
3187         (cmakeArgsFromFeatures): Moved code from script build-webkit so that it can be shared
3188         with build-jsc.
3189
3190 2018-06-29  Tim Horton  <timothy_horton@apple.com>
3191
3192         Add -apple-color-filter and system appearance toggles to MiniBrowser
3193         https://bugs.webkit.org/show_bug.cgi?id=187210
3194
3195         Reviewed by Simon Fraser.
3196
3197         * MiniBrowser/mac/AppDelegate.m:
3198         (defaultConfiguration):
3199         * MiniBrowser/mac/SettingsController.h:
3200         * MiniBrowser/mac/SettingsController.m:
3201         (-[SettingsController _populateMenu]):
3202         (-[SettingsController validateMenuItem:]):
3203         (-[SettingsController toggleAppleColorFilterEnabled:]):
3204         (-[SettingsController appleColorFilterEnabled]):
3205         (-[SettingsController toggleUseSystemAppearance:]):
3206         (-[SettingsController useSystemAppearance]):
3207         * MiniBrowser/mac/WK1BrowserWindowController.m:
3208         (-[WK1BrowserWindowController didChangeSettings]):
3209         * MiniBrowser/mac/WK2BrowserWindowController.m:
3210         (-[WK2BrowserWindowController didChangeSettings]):
3211
3212 2018-06-29  Aditya Keerthi  <akeerthi@apple.com>
3213
3214         [macOS] Do not crash if there is an attempt to copy a file URL to the clipboard
3215         https://bugs.webkit.org/show_bug.cgi?id=187183
3216
3217         Reviewed by Wenson Hsieh.
3218
3219         Added a 'runSingly' option to the TestOptions struct. Setting this option to true
3220         will force a new PlatformWebView to be created before running a test. This ensures
3221         that any state set by previous tests are not preserved.
3222
3223         One example of the importance of having this ability is in the case where we want
3224         to test functionality that deals with read access to files. If a test were to
3225         load a valid file URL, universal read access will be granted in WebProcessProxy.
3226         This prevents us from testing cases that rely on us not have universal read
3227         access. Now, if we write the test using the 'runSingly' option, any state set
3228         by previous tests is cleared. Consequently, our test will behave as expected.
3229
3230         * WebKitTestRunner/PlatformWebView.h:
3231         (WTR::PlatformWebView::viewSupportsOptions const):
3232         * WebKitTestRunner/TestController.cpp:
3233         (WTR::updateTestOptionsFromTestHeader):
3234         * WebKitTestRunner/TestOptions.h:
3235         (WTR::TestOptions::hasSameInitializationOptions const):
3236
3237 2018-06-29  Daniel Bates  <dabates@apple.com>
3238
3239         [lldb-webkit] Non-empty strings may be pretty-printed as empty
3240         https://bugs.webkit.org/show_bug.cgi?id=187185
3241
3242         Reviewed by Simon Fraser.
3243
3244         For some reason lldb(1) sometimes has an issue accessing members of WTF::StringImplShape
3245         via a WTF::StringImpl pointer (why?). Explicitly casting a WTF::StringImpl* to a
3246         WTF::StringImplShape* before accessing such members makes LLDB happy.
3247
3248         I tried writing a test for this both for the LLVM project and to add to our lldb_webkit unit
3249         tests to no avail. I have only been able to reproduce this bug sporadically during my WebCore/WebKit
3250         debugging sessions so far.
3251
3252         * lldb/lldb_webkit.py:
3253         (WTFStringImplProvider.__init__): Explicitly cast the WTF::StringImpl* to WTF::StringImplShape*.
3254         (WTFStringImplProvider.get_data8): Update code now that we are directly accessing WTF::StringImplShape*.
3255         (WTFStringImplProvider.get_data16): Ditto.
3256
3257 2018-06-29  Chris Dumez  <cdumez@apple.com>
3258
3259         WebKitLegacy: Can trigger recursive loads triggering debug assertions
3260         https://bugs.webkit.org/show_bug.cgi?id=187121
3261         <rdar://problem/41259430>
3262
3263         Reviewed by Brent Fulgham.
3264
3265         Add API test coverage.
3266
3267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3268         * TestWebKitAPI/Tests/mac/StartLoadInDidFailProvisionalLoad.mm: Added.
3269         (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3270         (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFinishLoadForFrame:]):
3271         (TestWebKitAPI::TEST):
3272
3273 2018-06-29  Lucas Forschler  <lforschler@apple.com>
3274
3275         Teach bisect-builds to retrieve supported platforms from the rest api.
3276         https://bugs.webkit.org/show_bug.cgi?id=187195
3277         
3278         This patch updates bisect-builds to use v2_2 of the API. v2_2 adds two api endpoints: /platforms, and /minified-platforms.
3279         These endpoints scan a dynamoDB database, returning the identifier key for all available platforms.
3280         The identifier keys are in the format: platform-architecture-configuration.
3281
3282         Reviewed by Aakash Jain.
3283
3284         * Scripts/bisect-builds:
3285         (get_api_archive_url): refactored from get_api_url.
3286         (get_platforms): helper function to retrieve from the platforms api.
3287         (minified_platforms): returns a list of minified platforms currently in the database
3288         (unminified_platforms): returns a list of unminified platforms currently in the database
3289         (is_supported_platform): checks if the platform-architecture-configuration combo is supported
3290         (fetch_revision_list): refactored to use get_api_archive_url
3291         (get_api_url): Deleted/refactored to get_api_archive_url.
3292
3293 2018-06-29  Keith Miller  <keith_miller@apple.com>
3294
3295         run-jsc should print when jsc exits with non-zero status
3296         https://bugs.webkit.org/show_bug.cgi?id=187192
3297
3298         Reviewed by Saam Barati.
3299
3300         * Scripts/run-jsc:
3301
3302 2018-06-29  Aakash Jain  <aakash_jain@apple.com>
3303
3304         [ews-build] Add timeout to webkitpy and webkitperl tests
3305         https://bugs.webkit.org/show_bug.cgi?id=187191
3306
3307         Reviewed by Lucas Forschler.
3308
3309         * BuildSlaveSupport/ews-build/steps.py:
3310         (RunWebKitPerlTests.__init__): Set timeout of 2 minutes.
3311         (RunWebKitPyTests.__init__): Ditto.
3312         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3313
3314 2018-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3315
3316         [WPE]: Fix exception handling when flatpak is not installed
3317         https://bugs.webkit.org/show_bug.cgi?id=186771
3318
3319         Unreviewed followup-fix after r233362
3320
3321         This was causing failures when flatpak is not installed.
3322
3323         * flatpak/flatpakutils.py:
3324         (check_flatpak):
3325
3326 2018-06-29  Ross Kirsling  <ross.kirsling@sony.com>
3327
3328         [JSCOnly] Restore Windows build.
3329         https://bugs.webkit.org/show_bug.cgi?id=187127
3330
3331         Reviewed by Michael Catanzaro.
3332
3333         * Scripts/build-jsc:
3334         Fix condition for disabling FTL JIT on Windows.
3335
3336         * Scripts/webkitdirs.pm:
3337         (executableProductDir):
3338         JSCOnly should still use bin64 on Windows (for consistency with full WebKit build).
3339         (determineIsWin64):
3340         JSCOnly already defaults to 64-bit on Windows with Ninja -- ensure that this is true even with MSBuild.
3341
3342 2018-06-29  Thibault Saunier  <tsaunier@igalia.com>
3343
3344         [GTK][WPE]: Add a way to setup our development environment inside flatpak
3345         https://bugs.webkit.org/show_bug.cgi?id=186771
3346
3347         Reviewed by Carlos Alberto Lopez Perez.
3348
3349         This patch introduce a way to setup the development environment inside flatpak[0]
3350         removing the need for jhbuild when doing so. Anything needed to build/run minibrowser/ run
3351         layout tests is provided either but the org.gnome.Sdk runtime or built with flatpak-builder.
3352
3353         The workflow is very similar to the "jhbuild based" one except that you should use update-webkit$PORTNAME-flatpak instead
3354         of update-webkit$PORTNAME-libs and that script requires to specify a build configuration (--release is default).
3355
3356         Our scripts have been updated to be able to run inside that new build environment.
3357
3358         Since everything runs inside a flatpak sandbox, gdb needs to be run from within the sandbox, the script exposes a way to do it
3359         easily with the `--gdb` option:
3360
3361           $ webkit-flatpak --gdb [-m COREDUMPCTL MATCHES]
3362
3363         The Layout test `GDBCrashLogGenerator` has been taugth how to use that and is able to retrieve stacktrace as with the jhbuild based workflow.
3364
3365         [0] http://flatpak.org
3366
3367         * Scripts/build-webkit:
3368         * Scripts/generate-jsc-bundle:
3369         (main):
3370         * Scripts/run-gtk-tests:
3371         * Scripts/run-minibrowser:
3372         * Scripts/run-webdriver-tests:
3373         * Scripts/run-webkit-tests:
3374         * Scripts/run-wpe-tests:
3375         * Scripts/update-webkitgtk-libs:
3376         * Scripts/update-webkitwpe-libs:
3377         * Scripts/webkit-flatpak: Added.
3378         * Scripts/webkitdirs.pm:
3379         (getJhbuildPath):
3380         (getFlatpakPath):
3381         (inFlatpakSandbox):
3382         (runInFlatpak):
3383         (runInFlatpakIfAvalaible):
3384         (wrapperPrefixIfNeeded):
3385         (shouldUseFlatpak):
3386         * Scripts/webkitpy/port/base.py:
3387         (Port._path_to_apache):
3388         (Port._is_flatpak):
3389         (Port._apache_config_file_name_for_platform):
3390         (Port._should_use_flatpak):
3391         (Port):
3392         (Port._in_flatpak_sandbox):
3393         (Port._should_use_jhbuild):
3394         * Scripts/webkitpy/port/gtk.py:
3395         (GtkPort.setup_environ_for_server):
3396         * Scripts/webkitpy/port/linux_get_crash_log.py:
3397         (GDBCrashLogGenerator._get_trace_from_systemd):
3398         (GDBCrashLogGenerator.generate_crash_log):
3399         * Scripts/webkitpy/port/wpe.py:
3400         (WPEPort.setup_environ_for_server):
3401         * Scripts/webkitpy/w3c/wpt_runner.py:
3402         (main):
3403         * flatpak/files/default.xkm: Added.
3404         * flatpak/files/httpd-autogen.sh: Added.
3405         * flatpak/flatpakutils.py: Added.
3406         (Colors):
3407         (Console):
3408         (Console.message):
3409         (remove_extension_points):
3410         (remove_comments):
3411         (remove_comments._replacer):
3412         (load_manifest):
3413         (expand_manifest):
3414         (FlatpakObject):
3415         (FlatpakObject.__init__):
3416         (FlatpakObject.flatpak):
3417         (FlatpakPackages):
3418         (FlatpakPackages.__init__):
3419         (FlatpakPackages.__detect_packages):
3420         (FlatpakPackages.__detect_packages.in):
3421         (FlatpakPackages.__detect_runtimes):
3422         (FlatpakPackages.__detect_apps):
3423         (FlatpakPackages.__iter__):
3424         (FlatpakRepos):
3425         (FlatpakRepos.__init__):
3426         (FlatpakRepos.update):
3427         (FlatpakRepos.add):
3428         (FlatpakRepo):
3429         (FlatpakRepo.__init__):
3430         (FlatpakRepo.repo_file):
3431         (FlatpakPackage):
3432         (FlatpakPackage.__init__):
3433         (FlatpakPackage.__str__):
3434         (FlatpakPackage.is_installed):
3435         (FlatpakPackage.install):
3436         (FlatpakPackage.update):
3437         (WebkitFlatpak):
3438         (WebkitFlatpak.load_from_args):
3439         (WebkitFlatpak.__init__):
3440         (WebkitFlatpak.check_flatpak):
3441         (WebkitFlatpak.check_flatpak.comparable_version):
3442         (WebkitFlatpak.clean_args):
3443         (WebkitFlatpak.run_in_sandbox):
3444         (WebkitFlatpak.run):
3445         (WebkitFlatpak.has_environment):
3446         (WebkitFlatpak.setup_dev_env):
3447         (WebkitFlatpak.install_all):
3448         (WebkitFlatpak.run_gdb):
3449         (WebkitFlatpak.update_all):
3450         (is_sandboxed):
3451         (run_in_sandbox_if_available):
3452         * flatpak/org.webkit.GTK.yaml: Added.
3453         * flatpak/org.webkit.WPE.yaml: Added.
3454         * flatpak/org.webkit.WebKit.yaml: Added.
3455         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
3456         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Added.
3457
3458 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3459
3460         [iOS] DataTransfer.getData always returns the empty string when dropping text
3461         https://bugs.webkit.org/show_bug.cgi?id=187130
3462         <rdar://problem/41014117>
3463
3464         Reviewed by Ryosuke Niwa.
3465
3466         Add 2 new API tests to verify that:
3467         -   When dropping an item with text, markup, and URL representations, the page is allowed to get "text/html",
3468             "text/plain" and "text/uri-list" data.
3469         -   Adding a suggested name to a plain text item causes WebKit to treat it as a file, and suppress access to
3470             DataTransfer.getData().
3471
3472         Additionally tweaks a couple of existing API tests. Namely, in two API tests
3473         (ExternalSourceOverrideDropFileUpload and ExternalSourceHTMLToUploadArea) only a markup string is dropped, and
3474         we previously expected to handle the drop as a file. To allow this test to continue serving its purpose, tweak
3475         them such that the registered items appear to be file-backed (i.e. by adding a suggested filename in one of the
3476         tests, and specifying UIPreferredPresentationStyleAttachment in the other).
3477
3478         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3479         (TestWebKitAPI::TEST):
3480
3481 2018-06-28  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3482
3483         Unreviewed, rolling out r226652.
3484         https://bugs.webkit.org/show_bug.cgi?id=180827
3485
3486         "PlatformInfo should never be instantiated in isolation. So, PlatformInfo should
3487         not have default argument values. The preferred way to get a PlatformInfo object
3488         is to instantiate a Host object." (Requested by dbates).
3489
3490         Reverted changeset:
3491
3492         "[webkitpy] PlatformInfo should have default argument for casual use"
3493         https://bugs.webkit.org/show_bug.cgi?id=180827
3494
3495 2018-06-28  Simon Fraser  <simon.fraser@apple.com>
3496
3497         Try to address test failures on the bots.
3498
3499         Allow the test to distinguish between a failure to find the variable, and an error
3500         reporting vector capacity.
3501
3502         * lldb/lldb_webkit_unittest.py:
3503         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
3504         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3505
3506 2018-06-28  Lucas Forschler  <lforschler@apple.com>
3507
3508         Add Windows support for WEBKIT_API_KEY.
3509         https://bugs.webkit.org/show_bug.cgi?id=187155
3510
3511         Reviewed by Daniel Bates.
3512
3513         * EWSTools/start-queue-win.sh:
3514
3515 2018-06-28  Aakash Jain  <aakash_jain@apple.com>
3516
3517         [ews-build] Add support for WebKitPy-Tests-EWS
3518         https://bugs.webkit.org/show_bug.cgi?id=187148
3519
3520         Reviewed by Lucas Forschler.
3521
3522         * BuildSlaveSupport/ews-build/factories.py: Added WebKitPyFactory.
3523         * BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPyTests.
3524         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3525         * BuildSlaveSupport/ews-build/config.json: Updated to use CamelCase. 
3526
3527 2018-06-28  Daniel Bates  <dabates@apple.com>
3528
3529         Fix the iOS build following r233299
3530         (https://bugs.webkit.org/show_bug.cgi?id=183744)
3531
3532         Only build lldbWebKitTester on Mac as that is the only supported platform at the time of writing.
3533
3534         * Makefile:
3535
3536 2018-06-28  Sihui Liu  <sihui_liu@apple.com>
3537
3538         Cookie API: cookie creation time is wrong
3539         https://bugs.webkit.org/show_bug.cgi?id=187101
3540
3541         Reviewed by Geoffrey Garen.
3542
3543         Add test coverage: make sure the cookie creation time returned is the same as set.
3544
3545         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3546         (TEST):
3547
3548 2018-06-28  Simon Fraser  <simon.fraser@apple.com>
3549
3550         The lldb vector summary provider always shows zero capacity
3551         https://bugs.webkit.org/show_bug.cgi?id=187132
3552
3553         Reviewed by Daniel Bates.
3554         
3555         WTFVectorProvider in lldb_webkit.py was calling GetChildMemberWithName('m_capacity')
3556         on the buffer instead of the valobj.
3557
3558         * lldb/lldbWebKitTester/main.cpp:
3559         (testSummaryProviders):
3560         * lldb/lldb_webkit.py:
3561         (WTFVectorProvider.update):
3562         * lldb/lldb_webkit_unittest.py:
3563         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
3564         (TestSummaryProviders):
3565         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
3566         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3567
3568 2018-06-28  Adam Barth  <abarth@webkit.org>
3569
3570         Switch OS(FUCHSIA) to using JSCOnly
3571         https://bugs.webkit.org/show_bug.cgi?id=187133
3572
3573         Reviewed by Yusuke Suzuki.
3574
3575         Switch Fuchsia from being a port to just being an OS. We now use a
3576         CMAKE_TOOLCHAIN_FILE to configure the toolchain and the target triple.
3577
3578         * Scripts/webkitdirs.pm: Remove isFuchsia() and clients. Turns out we
3579         can do everything we need using a CMAKE_TOOLCHAIN_FILE via the
3580         --cmakeargs flag.
3581
3582 2018-06-27  Ryosuke Niwa  <rniwa@webkit.org>
3583
3584         Make MotionMark's plan file more robust against code changes
3585         https://bugs.webkit.org/show_bug.cgi?id=187116
3586         <rdar://problem/41533956>
3587
3588         Reviewed by Saam Barati.
3589
3590         Moved the code to auto-start the test to the load event listener.
3591
3592         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
3593
3594 2018-06-27  Daniel Bates  <dabates@apple.com>
3595
3596         Add some tests for lldb_webkit.py
3597         https://bugs.webkit.org/show_bug.cgi?id=183744
3598
3599         Reviewed by Alexey Proskuryakov.
3600
3601         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
3602         and WTF::String objects.
3603
3604         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
3605         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
3606         on Mac.
3607
3608         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
3609         * Scripts/build-lldbwebkittester: Added.
3610         (buildProjectOrDie):
3611         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
3612         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
3613         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
3614         the file and take advantage of Python's default error semantics to throw an exception
3615         if the import fails instead of handling it ourself. This has the side effect that we
3616         now always import the LLDB Python module even if this script is invoked with --help.
3617         If this turns out to be a significant annoyance then we can look to dynamically import
3618         the module as we did before this change.
3619         (webkit_build_dir):
3620         (main):
3621         (developer_dir): Deleted.
3622         (import_lldb): Deleted.
3623         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
3624         that fact that test-webkitpy does not support class and module fixtures. This is because
3625         test-webkitpy currently implements parallelism by breaking down existing test classes
3626         into individual test methods itself and having each worker run exactly one test method (via
3627         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
3628         setUpModule()/setUpClass() are called for each test method as opposed to once per test
3629         class/test module.
3630         (remove_dir): Ditto.
3631         * Scripts/webkitpy/common/system/systemhost.py: