Add API test to validate setting of service worker and cache storage directories
[WebKit-https.git] / Tools / ChangeLog
1 2018-03-01  Youenn Fablet  <youenn@apple.com>
2
3         Add API test to validate setting of service worker and cache storage directories
4         https://bugs.webkit.org/show_bug.cgi?id=182543
5
6         Reviewed by Chris Dumez.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
9
10 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
11
12         [Win][DRT] Implement setSpatialNavigationEnabled.
13         https://bugs.webkit.org/show_bug.cgi?id=183166
14
15         Reviewed by Per Arne Vollan.
16
17         * DumpRenderTree/TestRunner.cpp:
18         (setSpatialNavigationEnabledCallback):
19         * DumpRenderTree/win/DumpRenderTree.cpp:
20         (resetWebPreferencesToConsistentValues):
21         * DumpRenderTree/win/TestRunnerWin.cpp:
22         (TestRunner::setSpatialNavigationEnabled):
23
24 2018-03-01  Basuke Suzuki  <Basuke.Suzuki@sony.com>
25
26         [webkitpy] Use shell=False to launch apache http server.
27         https://bugs.webkit.org/show_bug.cgi?id=183191
28
29         Reviewed by Aakash Jain.
30
31         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
32         (LayoutTestApacheHttpd.__init__):
33         (LayoutTestApacheHttpd._run):
34
35 2018-03-01  Chris Dumez  <cdumez@apple.com>
36
37         Unreviewed, update WebKit.CustomHeaderFields API test after r229133.
38
39         We no longer do policy checks for 'about:blank'.
40
41         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
42         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
43         (TEST):
44
45 2018-02-28  Jonathan Bedard  <jbedard@apple.com>
46
47         [webkitpy] Remove concept of 'future' versions (Follow-up fix 2)
48         https://bugs.webkit.org/show_bug.cgi?id=183184
49         <rdar://problem/37958594>
50
51         Reviewed by Aakash Jain.
52
53         Unlisted Apple versions can't run webkitpy tests because they don't
54         have specified port names.
55
56         * Scripts/webkitpy/port/apple.py:
57         (ApplePort.determine_full_port_name): Return valid port name for unnamed
58         versions.
59         * Scripts/webkitpy/port/base.py:
60         (Port.version_name): Check both public and internal version mapping
61         when returning a version name.
62         * Scripts/webkitpy/port/mac.py:
63         (MacPort.__init__): If no os version is defined, use the current version.
64
65 2018-02-28  John Wilander  <wilander@apple.com>
66
67         Add a second tier of prevalence to facilitate telemetry on very prevalent domains
68         https://bugs.webkit.org/show_bug.cgi?id=183218
69         <rdar://problem/37992388>
70
71         Reviewed by Brent Fulgham.
72
73         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
74             Added two new testRunner functions:
75             - setStatisticsVeryPrevalentResource()
76             - isStatisticsVeryPrevalentResource()
77         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
78         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
79         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
80         * WebKitTestRunner/InjectedBundle/TestRunner.h:
81         * WebKitTestRunner/TestController.cpp:
82         (WTR::TestController::setStatisticsVeryPrevalentResource):
83         (WTR::TestController::isStatisticsVeryPrevalentResource):
84         * WebKitTestRunner/TestController.h:
85         * WebKitTestRunner/TestInvocation.cpp:
86         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
87
88 2018-02-28  Jonathan Bedard  <jbedard@apple.com>
89
90         [webkitpy] Remove concept of 'future' versions (Follow-up fix)
91         https://bugs.webkit.org/show_bug.cgi?id=183184
92         <rdar://problem/37958594>
93
94         Reviewed by David Kilzer.
95
96         The factory also relies on future in a non-obvious way.
97
98         * Scripts/webkitpy/common/system/platforminfo.py:
99         (PlatformInfo.os_version_name): Check both public and internal version mapping
100         when returning a version name.
101         * Scripts/webkitpy/common/system/platforminfo_mock.py:
102         (MockPlatformInfo.os_version_name): Ditto.
103
104 2018-02-28  Zan Dobersek  <zdobersek@igalia.com>
105
106         Unreviewed WPE fixup after r229080.
107
108         Add empty definitions for two AccessibilityUIElement methods,
109         avoiding undefined symbols in the WKTR injected bundle.
110
111         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
112         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
113         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
114
115 2018-02-27  Jonathan Bedard  <jbedard@apple.com>
116
117         Remove concept of 'future'
118         https://bugs.webkit.org/show_bug.cgi?id=183184
119         <rdar://problem/37958594>
120
121         Reviewed by Aakash Jain.
122
123         Remove concept of 'future' from expectations and instead
124         use a system of inheritance centered around the current version
125         of an OS for Mac and iOS.
126
127         Inheritance works like so:
128
129         | ....
130         V Future
131         > High Sierra (mac)
132         ^ mac-sierra
133         | mac-elcapitan
134         | ....
135
136         This does not change expectation inheritance for any currently running
137         configurations, it generalizes the logic already used.
138
139         * Scripts/webkitpy/common/version_name_map.py:
140         (VersionNameMap.__init__): Remove all future versions.
141         (VersionNameMap.mapping_for_platform): Return empty dicts instead of
142         asserting.
143         * Scripts/webkitpy/port/apple.py:
144         (ApplePort):
145         (ApplePort._allowed_versions): Return all available versions.
146         (ApplePort._generate_all_test_configurations): Instead of picking from a set
147         of allowed versions, assume that every specified version is allowed.
148         (ApplePort._port_name_with_version): Deleted.
149         * Scripts/webkitpy/port/darwin.py: Add CURRENT_VERSION overridden by subclasses.
150         (DarwinPort):
151         * Scripts/webkitpy/port/ios.py:
152         (IOSPort):
153         (IOSPort.default_baseline_search_path): Use system of inheritance centered around
154         the current version.
155         * Scripts/webkitpy/port/mac.py:
156         (MacPort):
157         (MacPort.__init__): Use current version by default.
158         (MacPort.default_baseline_search_path): Use system of inheritance centered around
159         the current version.
160         (MacPort.configuration_specifier_macros): Use the same set of version names
161         supported in default_baseline_search_path.
162         * Scripts/webkitpy/port/mac_unittest.py:
163         (MacTest.test_versions): Remove 'future' tests.
164
165 2018-02-27  Michael Catanzaro  <mcatanzaro@igalia.com>
166
167         Unreviewed GTK test gardening
168
169         * TestWebKitAPI/glib/TestExpectations.json:
170
171 2018-02-27  Doug Russell  <doug@getitdownonpaper.com>
172
173         AX: Spell check and style attributes should be optional when fetching attributed string
174         https://bugs.webkit.org/show_bug.cgi?id=160744
175
176         Reviewed by Chris Fleizach.
177
178         The overhead of fetching a spell checked attributed string via AX API is substantial. 
179         In some cases on the order of 7/8 of the total time spent fetching the string.
180
181         This change introduces the new attribute AXAttributedStringForTextMarkerRangeWithOptions which accepts an NSDictionary as it's parameter with keys "AXTextMarkerRange" (AXTextMarkerRangeRef) and "AXSpellCheck" (NSNumber(BOOL)).
182
183         AXAttributedStringForTextMarkerRange will remain unchanged.
184
185         * DumpRenderTree/AccessibilityUIElement.cpp:
186         (attributedStringForTextMarkerRangeCallback):
187         (attributedStringForTextMarkerRangeWithOptionsCallback):
188         (AccessibilityUIElement::attributedStringForTextMarkerRange):
189         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
190         (AccessibilityUIElement::getJSClass):
191         * DumpRenderTree/AccessibilityUIElement.h:
192         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
193         (AccessibilityUIElement::attributedStringForTextMarkerRange):
194         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
195         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
196         (createJSStringRef):
197         (AccessibilityUIElement::attributedStringForTextMarkerRange):
198         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
199         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
200         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
201         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
202         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
203         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
204         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
205         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
206         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
207         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
208         (WTR::createJSStringRef):
209         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
210         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
211
212 2018-02-27  Daniel Bates  <dabates@apple.com>
213
214         Standardize terminology for marked text
215         https://bugs.webkit.org/show_bug.cgi?id=180999
216
217         Reviewed by Zalan Bujtas.
218
219         The name MarkerSubrange is a misnomer for a data structure that associates a text subrange with a type
220         and optional document marker. In particular, a MarkerSubrange may not always correspond to a document
221         marker. For instance, selected text is represented using a MarkerSubrange that does not have a
222         corresponding document marker. Let's standardize on the phrase "marked text" as the canonical way to
223         describe these tagged text subranges.
224
225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
226         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp: Added.
227         (WebCore::operator<<):
228         (TestWebKitAPI::TEST):
229         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp: Removed.
230
231 2018-02-27  Aakash Jain  <aakash_jain@apple.com>
232
233         webkitpy Bugzilla transactions should retry on URLError
234         https://bugs.webkit.org/show_bug.cgi?id=183156
235
236         Reviewed by Alexey Proskuryakov.
237
238         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
239         (Bugzilla): Use NetworkTransaction.
240         (Bugzilla._fetch_bug_page_by_url):
241         (Bugzilla.bug_id_for_attachment_id):
242         (Bugzilla.get_bug_id_for_attachment_id):
243
244 2018-02-27  Wenson Hsieh  <wenson_hsieh@apple.com>
245
246         [Extra zoom mode] Implement additional SPI for adjusting viewport shrink-to-fit behavior
247         https://bugs.webkit.org/show_bug.cgi?id=183100
248         <rdar://problem/37840987>
249
250         Reviewed by Tim Horton.
251
252         Add API tests that exercise -_setMinimumAllowedLayoutWidth: and -_setForceHorizontalViewportShrinkToFit:. See
253         WebKit ChangeLog for more detail.
254
255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
256         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Added.
257         (TestWebKitAPI::while):
258         (viewportTestPageMarkup):
259         (TestWebKitAPI::TEST):
260
261 2018-02-27  Yusuke Suzuki  <utatane.tea@gmail.com>
262
263         Unreviewed, skip FTL tests if FTL is disabled
264         https://bugs.webkit.org/show_bug.cgi?id=183071
265
266         * Scripts/run-jsc-stress-tests:
267
268 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
269
270         Fix WebCore includes within WebKitLegacy
271         https://bugs.webkit.org/show_bug.cgi?id=183147
272
273         Reviewed by Tim Horton.
274
275         * MiniBrowser/win/ResourceLoadDelegate.cpp:
276
277 2018-02-26  Yousuke Kimoto  <yousuke.kimoto@sony.com>
278
279         [WinCairo] WebKit2_C.h should be included for TestWebKit
280         https://bugs.webkit.org/show_bug.cgi?id=182682
281
282         Reviewed by Yusuke Suzuki.
283
284         * TestWebKitAPI/config.h:
285
286 2018-02-25  Fujii Hironori  <Hironori.Fujii@sony.com>
287
288         [WK2] http/tests/navigation/new-window-redirect-history.html crashes
289         https://bugs.webkit.org/show_bug.cgi?id=127683
290
291         Reviewed by Dan Bernstein.
292
293         m_previousTestBackForwardListItem was null for the new window.
294         m_previousTestBackForwardListItem is initialized only for the main
295         window in InjectedBundlePage::prepare.
296
297         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
298         (WTR::InjectedBundlePage::dumpBackForwardList):
299         Do null-check of m_previousTestBackForwardListItem.
300
301 2018-02-25  Alexey Proskuryakov  <ap@apple.com>
302
303         Various crashes in WebKitTestRunner, especially when system is under heavy load
304         https://bugs.webkit.org/show_bug.cgi?id=183109
305
306         Reviewed by Tim Horton.
307
308         WebKitTestRunner had many places where it sent messages to WebContent with a timeout,
309         but it didn't handle the timeout when it did occur. Nearly all of those would result
310         in logic errors and failing tests, and most would even result in stack corruption,
311         as the response handler modified local variables.
312
313         There is only one timeout scenario that we actually mean to handle in WKTR. That's
314         when a test freezes after it is done (e.g. an infinite loop in beforeunload) - we don't
315         want to blame the next test for freezing, so we silently relaunch WebContent.
316         Everything else is cargo cult code that never worked.
317
318         This patch addresses the crashes, and actually makes tests pass a lot more on an
319         overloaded system.
320
321         * WebKitTestRunner/TestController.cpp:
322         (WTR::TestController::resetStateToConsistentValues): Moved m_doneResetting assignment
323         to where it's actually needed, for clarity.
324         (WTR::TestController::reattachPageToWebProcess): This function used to always hit
325         and ignore message timeout, as m_doneResetting is only updated by navigation callback
326         when the state is Resetting. This change makes it faster.
327         (WTR::TestController::platformResetStateToConsistentValues): Style fix.
328         (WTR::TestController::clearServiceWorkerRegistrations): Timing out here wasn't
329         handled in a meaningful manner, and would even corrupt the stack.
330         (WTR::TestController::clearDOMCache): Ditto.
331         (WTR::TestController::clearDOMCaches): Ditto.
332         (WTR::TestController::hasDOMCache): Ditto.
333         (WTR::TestController::domCacheSize): Ditto.
334         (WTR::TestController::isStatisticsPrevalentResource): Ditto.
335         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder): Ditto.
336         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo): Ditto.
337         (WTR::TestController::isStatisticsHasHadUserInteraction): Ditto.
338         (WTR::TestController::isStatisticsGrandfathered): Ditto.
339         (WTR::TestController::statisticsUpdateCookiePartitioning): Ditto.
340         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Ditto.
341         (WTR::TestController::statisticsClearInMemoryAndPersistentStore): Ditto.
342         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): Ditto.
343         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): Ditto.
344
345         * WebKitTestRunner/TestInvocation.cpp:
346         (WTR::TestInvocation::shortTimeout const): Made shortTimeout shorter (on a hunch).
347         (WTR::TestInvocation::invoke): Removed a timeout waiting for initial response. There
348         is never a logical reason for such a timeout, as we always have a new or responsive
349         WebContent process here.
350         (WTR::TestInvocation::dumpResults): Removed another timeout that we don't know how to
351         properly handle.
352         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Removed assignment to
353         m_errorMessage, which had no effect in this context.
354
355         * WebKitTestRunner/TestInvocation.h: Removed no longer used code.
356
357         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
358         (WTR::TestController::cocoaResetStateToConsistentValues): Use a named constant for
359         no timeout.
360         
361         * WebKitTestRunner/ios/TestControllerIOS.mm:
362         (WTR::TestController::platformConfigureViewForTest): Removed a useless timeout.
363         Not sure if timing out here would corrupt the stack or not, but there is no reason
364         to impose arbitrary limits on individual steps of a test.
365
366         * WebKitTestRunner/mac/TestControllerMac.mm:
367         (WTR::TestController::platformConfigureViewForTest): Use a named constant for
368         no timeout.
369
370 2018-02-25  Ali Juma  <ajuma@chromium.org>
371
372         Unreviewed. Change my status to committer.
373
374         * Scripts/webkitpy/common/config/contributors.json:
375
376 2018-02-25  Chris Dumez  <cdumez@apple.com>
377
378         Service workers do not work well inside Web.app
379         https://bugs.webkit.org/show_bug.cgi?id=183105
380         <rdar://problem/37864140>
381
382         Reviewed by Youenn Fablet.
383
384         Add API test coverage.
385
386         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
387
388 2018-02-25  Aakash Jain  <aakash_jain@apple.com>
389
390         [build.webkit.org] unit-tests fail if buildbot 0.8.6p1 is not installed locally
391         https://bugs.webkit.org/show_bug.cgi?id=183103
392
393         Reviewed by Alexey Proskuryakov.
394
395         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Removed extra imports.
396
397 2018-02-24  Wenson Hsieh  <wenson_hsieh@apple.com>
398
399         Unreviewed, fix the TestWebKitAPI build after r228825.
400
401         I removed a `>= iOS 11` check in r228825, but forgot that this was also neeed to guard against tvOS and watchOS
402         builds. This fixes the build by restoring the compile-time guard and also makes it explicit for these platforms.
403
404         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
405
406 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
407
408         Remove currentTime() / currentTimeMS()
409         https://bugs.webkit.org/show_bug.cgi?id=183052
410
411         Reviewed by Mark Lam.
412
413         * DumpRenderTree/TestRunner.cpp:
414         (preciseTimeCallback):
415         * DumpRenderTree/mac/TestRunnerMac.mm:
416         (TestRunner::setMockGeolocationPosition):
417         * TestWebKitAPI/Tests/WTF/Condition.cpp:
418         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
419         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
420         * WebKitTestRunner/GeolocationProviderMock.cpp:
421         (WTR::GeolocationProviderMock::setPosition):
422         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
423         (WTR::TestRunner::preciseTime):
424
425 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
426
427         Remove sleep(double) and sleepMS(double) interfaces
428         https://bugs.webkit.org/show_bug.cgi?id=183038
429
430         Reviewed by Mark Lam.
431
432         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
433         (PluginTest::indicateTestFailure):
434         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp:
435         (EvaluteJSWithinNPP_New::NPP_New):
436         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp:
437         (InvokeDestroysPluginWithinNPP_New::NPP_New):
438         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
439         * TestWebKitAPI/Tests/WTF/Signals.cpp:
440         (TEST):
441         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
442         (TestWebKitAPI::testThreadGroup):
443         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
444         (TestWebKitAPI::TEST):
445         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
446         (TestWebKitAPI::TEST):
447         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
448         (TestWebKitAPI::TEST):
449         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp:
450         (TestWebKitAPI::Util::sleep):
451
452 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
453
454         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
455         https://bugs.webkit.org/show_bug.cgi?id=182883
456
457         Reviewed by Per Arne Vollan.
458
459         * DumpRenderTree/config.h:
460         * TestWebKitAPI/config.h:
461
462 2018-02-21  Michael Catanzaro  <mcatanzaro@igalia.com>
463
464         [GTK] Unsafe g_setenv use in MiniBrowser main
465         https://bugs.webkit.org/show_bug.cgi?id=182978
466
467         Reviewed by Carlos Garcia Campos.
468
469         setenv (and g_setenv) will randomly crash if called too late.
470
471         * MiniBrowser/gtk/main.c:
472         (main):
473
474 2018-02-21  Aakash Jain  <aakash_jain@apple.com>
475
476         webkitpy NetworkTransaction should retry on URLError
477         https://bugs.webkit.org/show_bug.cgi?id=182987
478
479         Reviewed by Alexey Proskuryakov.
480
481         * Scripts/webkitpy/common/net/networktransaction.py:
482         (NetworkTransaction.run): Retry on urllib2.URLError.
483
484 2018-02-21  Ms2ger  <Ms2ger@igalia.com>
485
486         [WTR][WPE] Correct the process names in TestController.
487         https://bugs.webkit.org/show_bug.cgi?id=178700
488
489         Reviewed by Michael Catanzaro.
490
491         Similar to r228731 for GTK.
492
493         * Scripts/webkitpy/port/wpe.py:
494         (WPEPort._get_crash_log): removed the code to convert WebProcess name.
495         * WebKitTestRunner/TestController.cpp: return the correct process names for WPE.
496         (WTR::TestController::webProcessName):
497         (WTR::TestController::networkProcessName):
498         (WTR::TestController::databaseProcessName):
499
500 2018-02-21  Ms2ger  <Ms2ger@igalia.com>
501
502         [ATK] Remove attributeSet variable from AccessibilityUIElement::attributedStringForRange().
503         https://bugs.webkit.org/show_bug.cgi?id=183000
504
505         Reviewed by Joanmarie Diggs.
506
507         It is never initialized, but is passed to atk_attribute_set_free.
508         This caused a crash in accessibility/content-editable-as-textarea.html on the debug bots.
509
510         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
511         (WTR::AccessibilityUIElement::attributedStringForRange):
512
513 2018-02-21  Myles C. Maxfield  <mmaxfield@apple.com>
514
515         [Cocoa] Make system-ui obey the user-installed-font policy
516         https://bugs.webkit.org/show_bug.cgi?id=182860
517         <rdar://problem/36158249>
518
519         Reviewed by Antti Koivisto.
520
521         Create a font, FakeHelvetica-ArmenianCharacter.ttf, which supports a particular Armenian
522         character which isn't isn't supported by any other font on the system.
523
524         * WebKitTestRunner/FakeHelvetica-ArmenianCharacter.ttf:
525         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
526
527 2018-02-20  Timothy Horton  <timothy_horton@apple.com>
528
529         Try to fix the 32-bit build after r228857
530
531         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
532         (WTR::UIScriptController::firstResponderSuppressionForWebView):
533
534 2018-02-20  Nan Wang  <n_wang@apple.com>
535
536         AX: Keyboard focus not following VoiceOver cursor into web content or within web content.
537         https://bugs.webkit.org/show_bug.cgi?id=182752
538         <rdar://problem/37518233>
539
540         Reviewed by Ryosuke Niwa.
541
542         * DumpRenderTree/mac/UIScriptControllerMac.mm:
543         (WTR::UIScriptController::firstResponderSuppressionForWebView):
544         (WTR::UIScriptController::makeWindowContentViewFirstResponder):
545         (WTR::UIScriptController::isWindowContentViewFirstResponder const):
546         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
547         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
548         (WTR::UIScriptController::firstResponderSuppressionForWebView):
549         (WTR::UIScriptController::makeWindowContentViewFirstResponder):
550         (WTR::UIScriptController::isWindowContentViewFirstResponder const):
551         * TestRunnerShared/UIScriptContext/UIScriptController.h:
552         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
553         (WTR::UIScriptController::firstResponderSuppressionForWebView):
554         (WTR::UIScriptController::makeWindowContentViewFirstResponder):
555         (WTR::UIScriptController::isWindowContentViewFirstResponder const):
556
557 2018-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
558
559         [GTK] jhbuild: Remove gtk-doc
560         https://bugs.webkit.org/show_bug.cgi?id=182956
561
562         Reviewed by Michael Catanzaro.
563
564         jhbuild doesn't need to build gtk-doc because major LTS Linux
565         distributions have gtk-doc v1.25, and
566         Tools/gtk/install-dependencies installs gtk-doc.
567
568         * gtk/jhbuild.modules: Removed gtk-doc.
569
570 2018-02-20  Tim Horton  <timothy_horton@apple.com>
571
572         Introduce HAVE(IOSURFACE_ACCELERATOR)
573         https://bugs.webkit.org/show_bug.cgi?id=182955
574         <rdar://problem/37699510>
575
576         Reviewed by Sam Weinig.
577
578         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
579         (createBitmapContextFromWebView):
580         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
581         (WTR::PlatformWebView::windowSnapshotImage):
582
583 2018-02-20  Chris Dumez  <cdumez@apple.com>
584
585         Provisional load may get committed before receiving the decidePolicyForNavigationResponse response
586         https://bugs.webkit.org/show_bug.cgi?id=182720
587         <rdar://problem/37515204>
588
589         Reviewed by Alex Christensen.
590
591         Add API test coverage.
592
593         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm:
594         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
595         (TestWebKitAPI::TEST):
596
597 2018-02-20  Nan Wang  <n_wang@apple.com>
598
599         AX: AOM: Dispatch accessibleclick event
600         https://bugs.webkit.org/show_bug.cgi?id=180898
601         <rdar://problem/36086710>
602
603         Reviewed by Ryosuke Niwa.
604
605         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
606         (WTR::AccessibilityUIElement::syncPress):
607         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
608         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
609         (WTR::AccessibilityUIElement::syncPress):
610
611 2018-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
612
613         [iOS 11.3 Beta] Can't copy a URL from Safari and paste it into the Gmail app
614         https://bugs.webkit.org/show_bug.cgi?id=182952
615         <rdar://problem/37636190>
616
617         Reviewed by Tim Horton.
618
619         Adds a new iOS copy/paste test that copies an anchor element via action sheet, and checks that upon pasting,
620         both "text/plain" and "text/uri-list" are provided. Additionally tweaks an existing iOS drag and drop test to
621         check for the same behavior.
622
623         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
624         (TestWebKitAPI::TEST):
625         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
626         (TestWebKitAPI::TEST):
627
628 2018-02-20  Philippe Normand  <pnormand@igalia.com>
629
630         [GStreamer][MiniBrowser] Honor GStreamer command line parameters in MiniBrowser
631         https://bugs.webkit.org/show_bug.cgi?id=173655
632
633         Reviewed by Xabier Rodriguez-Calvar.
634
635         The FIXME in GStreamerUtilities.cpp asks to pass the command line
636         parameters to the GStreamer initialization function.
637
638         Based on initial patch by: Vanessa Chipirrás Navalón  <vchipirras@igalia.com>
639
640         * MiniBrowser/gtk/main.c:
641         (main): Add the group containing the Gstreamer options that the console displays.
642
643 2018-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
644
645         [WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
646         https://bugs.webkit.org/show_bug.cgi?id=182953
647
648         Reviewed by Carlos Garcia Campos.
649
650         * Scripts/webkitpy/port/gtk.py:
651         (GtkPort._get_crash_log): Removed the code to convert WebProcess name.
652         * WebKitTestRunner/TestController.cpp:
653         (WTR::TestController::webProcessName): Return the correct program name for GTK+ port.
654         (WTR::TestController::networkProcessName): Ditto.
655         (WTR::TestController::databaseProcessName): Ditto.
656
657 2018-02-19  Ryan Haddad  <ryanhaddad@apple.com>
658
659         Unreviewed, rolling out r228696.
660
661         The API test added with this change is timing out on macOS.
662
663         Reverted changeset:
664
665         "Null pointer dereference in
666         WebPageProxy::urlSchemeHandlerForScheme()"
667         https://bugs.webkit.org/show_bug.cgi?id=182905
668         https://trac.webkit.org/changeset/228696
669
670 2018-02-16  Ryosuke Niwa  <rniwa@webkit.org>
671
672         Add an entitlement check for service worker on iOS
673         https://bugs.webkit.org/show_bug.cgi?id=182865
674         <rdar://problem/37505903>
675
676         Reviewed by Brady Eidson.
677
678         Added the service worker entitlements to WebKitTestRunner and TestWebKitAPI on iOS.
679
680         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
681         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
682         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
683         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
684
685 2018-02-16  Youenn Fablet  <youenn@apple.com>
686
687         Allow specifying which plug-ins are supported
688         https://bugs.webkit.org/show_bug.cgi?id=182748
689
690         Reviewed by Chris Dumez.
691
692         Add support for a test runner API to specificy supported plug-ins.
693
694         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
695         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
696         (WTR::TestRunner::setPluginsAsUnsupported):
697         * WebKitTestRunner/InjectedBundle/TestRunner.h:
698         * WebKitTestRunner/TestController.cpp:
699         (WTR::TestController::resetStateToConsistentValues):
700         (WTR::TestController::setPluginsAsUnsupported):
701         * WebKitTestRunner/TestController.h:
702         * WebKitTestRunner/TestInvocation.cpp:
703         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
704
705 2018-02-16  Per Arne Vollan  <pvollan@apple.com>
706
707         Implement stopping of run loop in the WebContent process when using NSRunLoop.
708         https://bugs.webkit.org/show_bug.cgi?id=182499
709         <rdar://problem/37247424>
710
711         Reviewed by Brent Fulgham.
712
713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
714         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessTerminate.mm: Added.
715         (TEST):
716
717 2018-02-15  Alexey Proskuryakov  <ap@apple.com>
718
719         Speed up dSYM generation on build.webkit.org with -gline-tables-only
720         https://bugs.webkit.org/show_bug.cgi?id=182841
721         rdar://problem/34579649
722
723         Reviewed by Aakash Jain.
724
725         Build speed and binary size improvements are so substantial that I'm willing to make
726         CI builds less suitable for debugging, which is not a common scenario anyway.
727         Crash logs will still have line numbers in them.
728
729         * BuildSlaveSupport/build.webkit.org-config/steps.py: (CompileWebKit.start):
730
731 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
732
733         WebCore headers should not be included relatively within dependent projects
734         https://bugs.webkit.org/show_bug.cgi?id=182805
735
736         Reviewed by Chris Dumez.
737
738         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
739         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
740         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
741         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
742         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
743         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
744
745 2018-02-15  Tomas Popela  <tpopela@redhat.com>
746
747         run-jsc-stress-tests - skip a test if any of the run commands evals to skip
748         https://bugs.webkit.org/show_bug.cgi?id=182729
749
750         If multiple run commands are specified and one of them evals to skip,
751         then the test is not skipped, because the run is scheduled while
752         evaluating other commands.
753
754         Remember if the test is going to be skipped - if yes, just stop
755         evaluating the other run commands.
756
757         Reviewed by Saam Barati.
758
759         * Scripts/run-jsc-stress-tests:
760
761 2018-02-14  Charlie Turner  <cturner@igalia.com>
762
763         Get Garden-O-Matic running again.
764         https://bugs.webkit.org/show_bug.cgi?id=179089
765
766         Reviewed by Carlos Alberto Lopez Perez.
767
768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
769         (parseCommitData): Author field is not always spelled 'author' these days.
770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
771         No longer have a 32-bit builder.
772         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
773         (ui.perf.View.base.init): createElement has a required parameter these days.
774         * Scripts/webkitpy/tool/commands/gardenomatic.py:
775         (GardenOMatic): Override use_globs so that platform lookup in config.js works.
776
777 2018-02-14  Don Olmstead  <don.olmstead@sony.com>
778
779         Remove unused ForwardingHeaders directories from Tools
780         https://bugs.webkit.org/show_bug.cgi?id=182813
781
782         Reviewed by Konstantin Tokarev.
783
784         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Removed.
785         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Removed.
786         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed.
787         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Removed.
788         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Removed.
789
790 2018-02-14  Daniel Bates  <dabates@apple.com>
791
792         Disallow cross-origin subresources from asking for credentials
793         https://bugs.webkit.org/show_bug.cgi?id=182579
794         <rdar://problem/36162271>
795
796         Reviewed by Andy Estes.
797
798         Add test option allowCrossOriginSubresourcesToAskForCredential (defaults to false)
799         so that tests can toggle between the old behavior and new behavior.
800
801         * DumpRenderTree/TestOptions.h:
802         * DumpRenderTree/TestOptions.mm:
803         (TestOptions::TestOptions):
804         * DumpRenderTree/mac/DumpRenderTree.mm:
805         (setWebPreferencesForTestOptions):
806         * WebKitTestRunner/TestController.cpp:
807         (WTR::TestController::resetPreferencesToConsistentValues):
808         (WTR::updateTestOptionsFromTestHeader):
809         * WebKitTestRunner/TestOptions.h:
810         (WTR::TestOptions::hasSameInitializationOptions const):
811
812 2018-02-12  Ryosuke Niwa  <rniwa@webkit.org>
813
814         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
815         https://bugs.webkit.org/show_bug.cgi?id=182564
816
817         Reviewed by Wenson Hsieh.
818
819         Updated assertions to make sure the trailing "}" of @list rules is includd in the style, the "style" element
820         is wrapped by "head" element (not present in the pasted markup since the fragment parsing algorithm strips away),
821         and the style content is enclosed in "<!--" and "-->".
822
823         Also use execCommand('insertHTML', ~) to insert the HTML obtained via dataTransfer.getData instead of innerHTML
824         to make sure our pasting code preserves the special style element for MSO list quirks.
825
826         Finally, added two more test cases for pasting content from Microsoft Word's compatibility mode.
827
828         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
829         (TEST):
830         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
831         (TEST):
832
833 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
834
835         [Tools] --wincairo should imply --64-bit by default.
836         https://bugs.webkit.org/show_bug.cgi?id=182753
837
838         Reviewed by Daniel Bates.
839
840         WinCairo does not currently support 32-bit and `--wincairo` itself should refer to a working platform.
841         This patch ensures x64 is determined correctly for `build-webkit --no-ninja` and `run-webkit-tests`.
842
843         * Scripts/webkitdirs.pm:
844         (determinePassedArchitecture):
845         (shouldBuild32Bit):
846         (determineShouldBuild32Bit):
847         (determineIsWin64):
848         * Scripts/webkitpy/common/config/ports.py:
849         (WinCairoPort.build_webkit_command):
850         * Scripts/webkitpy/common/config/ports_unittest.py:
851         (DeprecatedPortTest.test_wincairo_port):
852         * Scripts/webkitpy/port/win.py:
853         (WinCairoPort):
854
855 2018-02-13  Commit Queue  <commit-queue@webkit.org>
856
857         Unreviewed, rolling out r228431.
858         https://bugs.webkit.org/show_bug.cgi?id=182766
859
860         Regressed CMake build stability (Requested by dolmstead on
861         #webkit).
862
863         Reverted changeset:
864
865         "[CMake] Make WebCore headers copies"
866         https://bugs.webkit.org/show_bug.cgi?id=182512
867         https://trac.webkit.org/changeset/228431
868
869 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
870
871         [CMake] Make WebCore headers copies
872         https://bugs.webkit.org/show_bug.cgi?id=182512
873
874         Reviewed by Keith Miller.
875
876         * DumpRenderTree/CMakeLists.txt:
877         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
878         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
879         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
880         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
881         * TestWebKitAPI/PlatformGTK.cmake:
882         * TestWebKitAPI/PlatformWPE.cmake:
883         * TestWebKitAPI/PlatformWin.cmake:
884         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
885         (loadResourceIntoBuffer):
886         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
887         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
888         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
889         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
890         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
891
892 2018-02-13  Chris Dumez  <cdumez@apple.com>
893
894         REGRESSION (r228299): Broke reader mode in Safari
895         https://bugs.webkit.org/show_bug.cgi?id=182697
896         <rdar://problem/37399012>
897
898         Reviewed by Ryosuke Niwa.
899
900         Add API test coverage for responding asynchronously to the decidePolicyForNavigationResponse
901         delegate.
902
903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
904         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm: Added.
905         (-[TestAsyncNavigationDelegate webView:didFinishNavigation:]):
906         (-[TestAsyncNavigationDelegate webView:didFailNavigation:withError:]):
907         (-[TestAsyncNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
908         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
909         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
910         (TestWebKitAPI::TEST):
911
912 2018-02-12  John Wilander  <wilander@apple.com>
913
914         Resource Load Statistics: Classify resources as prevalent based on redirects to other prevalent resources
915         https://bugs.webkit.org/show_bug.cgi?id=182664
916         <rdar://problem/37372572>
917
918         Reviewed by Brent Fulgham.
919
920         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
921         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
922         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
923         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
924         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
925         * WebKitTestRunner/InjectedBundle/TestRunner.h:
926         * WebKitTestRunner/TestController.cpp:
927         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
928         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
929         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
930         * WebKitTestRunner/TestController.h:
931         * WebKitTestRunner/TestInvocation.cpp:
932         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
933
934 2018-02-12  Ross Kirsling  <ross.kirsling@sony.com>
935
936         download-latest-github-release .py should not use "browser download URL".
937         https://bugs.webkit.org/show_bug.cgi?id=182646
938
939         Reviewed by Per Arne Vollan.
940
941         * Scripts/download-latest-github-release.py:
942         Download request should be a proper GitHub API call and should actually include the token when applicable.
943         (Also clean up usage of args and print while we're in here.)
944
945 2018-02-12  Per Arne Vollan  <pvollan@apple.com>
946
947         EWS should run Windows tests.
948         https://bugs.webkit.org/show_bug.cgi?id=177967
949
950         Reviewed by Lucas Forschler.
951
952         This will help catch regressions at an early stage.
953
954         * Scripts/webkitpy/common/config/ews.json:
955
956 2018-02-08  Ryosuke Niwa  <rniwa@webkit.org>
957
958         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
959         https://bugs.webkit.org/show_bug.cgi?id=182564
960
961         Reviewed by Wenson Hsieh.
962
963         Added tests for pasting HTML with list items generated by Microsoft Word as well as HTML which looks like
964         the one generated by Microsoft Word but missing a proper "html" element at the beginning.
965
966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
967         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added test cases.
968         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm: Added test cases.
969         (msoListMarkupWithoutProperHTMLElement): Added.
970         * TestWebKitAPI/Tests/WebKitCocoa/mso-list.html: Added.
971
972 2018-02-09  Don Olmstead  <don.olmstead@sony.com>
973
974         [CMake] Make PAL headers copies
975         https://bugs.webkit.org/show_bug.cgi?id=182645
976
977         Reviewed by Alex Christensen.
978
979         * TestWebKitAPI/CMakeLists.txt:
980
981 2018-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
982
983         Pasting from Excel no longer provides text/html data
984         https://bugs.webkit.org/show_bug.cgi?id=182636
985         <rdar://problem/37087060>
986
987         Reviewed by Ryosuke Niwa.
988
989         Add new API tests to exercise pasting images with various other content types on macOS, and when dropping images
990         and HTML markup on iOS. See the WebCore ChangeLog for more detail.
991
992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
993         * TestWebKitAPI/Tests/WebKitCocoa/DataTransfer.html: Added.
994
995         Add a new API test harness that dumps various bits of information about a DataTransfer upon paste and drop.
996         While somewhat similar to some existing harnesses, this makes a distinction between the raw HTML data on the
997         pasteboard and the actual result of inserting said HTML into the DOM. This allows us to check that the HTML has
998         been sanitized, while making checks for the actual content of the HTML robust against inline style changes.
999
1000         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1001         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm: Added.
1002
1003         Add a new test suite to exercise pasting mixed content types. In these test cases, the pasteboard contains a
1004         file, with some combination of plain text, rich text, and URLs.
1005
1006         (imagePath):
1007         (writeTypesAndDataToPasteboard):
1008
1009         Add a helper to write a var-arg list of content types and data to the general NSPasteboard.
1010
1011         (setUpWebView):
1012         (markupString):
1013         (TestWebKitAPI::TEST):
1014         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1015         (TestWebKitAPI::testIconImageData):
1016         (TestWebKitAPI::TEST):
1017         * TestWebKitAPI/cocoa/TestWKWebView.h:
1018
1019         Move a private declaration of -[WKWebView paste:] out to TestWKWebView.h, so that it can be shared across
1020         multiple tests. Currently, it only resides in PasteImage.mm, but I need it in PasteMixedContent.mm as well.
1021
1022 2018-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1023
1024         Add a way to check if a host is an IP address
1025         https://bugs.webkit.org/show_bug.cgi?id=182427
1026
1027         Reviewed by Alex Christensen.
1028
1029         Add unit test for URL::hostIsIPAddress().
1030
1031         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1032         (TestWebKitAPI::TEST_F):
1033
1034 2018-02-09  Philippe Normand  <pnormand@igalia.com>
1035
1036         [GStreamer] Layout test fast/replaced/border-radius-clip.html crashes with GStreamer-CRITICAL **: gst_segment_to_stream_time: assertion 'segment->format == format' failed in gst_segment_to_stream_time()
1037         https://bugs.webkit.org/show_bug.cgi?id=176802
1038
1039         Reviewed by Xabier Rodriguez-Calvar.
1040
1041         * gstreamer/jhbuild.modules:
1042         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Added.
1043
1044 2018-02-09  Philippe Normand  <pnormand@igalia.com>
1045
1046         [JHBuild] Update Mesa to version 17
1047         https://bugs.webkit.org/show_bug.cgi?id=182599
1048
1049         Reviewed by Carlos Alberto Lopez Perez.
1050
1051         * gtk/jhbuild.modules: Update Mesa (and its dependencies, hopefully) to version 17.3.3.
1052
1053 2018-02-08  Chris Dumez  <cdumez@apple.com>
1054
1055         There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld
1056         https://bugs.webkit.org/show_bug.cgi?id=182524
1057         <rdar://problem/9057327>
1058
1059         Reviewed by Ryosuke Niwa.
1060
1061         Add API test coverage.
1062
1063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1064         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp: Added.
1065         (TestWebKitAPI::runJavaScriptAlert):
1066         (TestWebKitAPI::TEST):
1067         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp: Added.
1068         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::InjectedBundleDisableOverrideBuiltinsBehaviorTest):
1069         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1070         * TestWebKitAPI/Tests/WebKit/override-builtins-test.html: Added.
1071
1072 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1073
1074         TestController should not exercise cocoa-specific resource load statistics APIs
1075         https://bugs.webkit.org/show_bug.cgi?id=182355
1076
1077         Reviewed by Alex Christensen.
1078
1079         Remove unnecessary use of platform-specific APIs in the TestController, since there are
1080         cross-platform APIs to do the same thing.
1081
1082         Also, ensure callbacks execute before returning from TestController's functions, since
1083         otherwise the tests are guaranteed to be flaky at best, and also since there's nothing to
1084         prevent the TestController from being destroyed before the callbacks execute.
1085
1086         * WebKitTestRunner/TestController.cpp:
1087         (WTR::resourceStatisticsVoidResultCallback):
1088         (WTR::resourceStatisticsBooleanResultCallback):
1089         (WTR::TestController::isStatisticsPrevalentResource):
1090         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1091         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1092         (WTR::TestController::isStatisticsHasHadUserInteraction):
1093         (WTR::TestController::isStatisticsGrandfathered):
1094         (WTR::TestController::statisticsUpdateCookiePartitioning):
1095         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1096         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1097         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1098         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1099         (WTR::resourceStatisticsCallback): Deleted.
1100         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback): Deleted.
1101         * WebKitTestRunner/TestController.h:
1102         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1103         (WTR::toNSString): Deleted.
1104         (WTR::TestController::setStatisticsLastSeen): Deleted.
1105         (WTR::TestController::setStatisticsPrevalentResource): Deleted.
1106         (WTR::TestController::isStatisticsPrevalentResource): Deleted.
1107         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder): Deleted.
1108         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo): Deleted.
1109         (WTR::TestController::setStatisticsHasHadUserInteraction): Deleted.
1110         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
1111         (WTR::TestController::isStatisticsHasHadUserInteraction): Deleted.
1112         (WTR::TestController::setStatisticsGrandfathered): Deleted.
1113         (WTR::TestController::isStatisticsGrandfathered): Deleted.
1114         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin): Deleted.
1115         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin): Deleted.
1116         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo): Deleted.
1117         (WTR::TestController::setStatisticsTimeToLiveUserInteraction): Deleted.
1118         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
1119         (WTR::TestController::statisticsProcessStatisticsAndDataRecords): Deleted.
1120         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
1121         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
1122         (WTR::TestController::statisticsSubmitTelemetry): Deleted.
1123         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned): Deleted.
1124         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval): Deleted.
1125         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured): Deleted.
1126         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval): Deleted.
1127         (WTR::TestController::setStatisticsGrandfatheringTime): Deleted.
1128         (WTR::TestController::setStatisticsMaxStatisticsEntries): Deleted.
1129         (WTR::TestController::setStatisticsPruneEntriesDownTo): Deleted.
1130         (WTR::TestController::statisticsClearInMemoryAndPersistentStore): Deleted.
1131         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): Deleted.
1132         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): Deleted.
1133         (WTR::TestController::statisticsResetToConsistentState): Deleted.
1134
1135 2018-02-08  Jonathan Bedard  <jbedard@apple.com>
1136
1137         webkit-patch suggest-reviewers dies with AttributeError: 'NoneType' object has no attribute 'revision'
1138         https://bugs.webkit.org/show_bug.cgi?id=182584
1139
1140         Reviewed by Daniel Bates.
1141
1142         It is possible that a specific revision has an empty ChangeLog. In this case, Checkout.commit_info_for_revision
1143         will return 'None'. Checkout.recent_commit_infos_for_files should never return a set with 'None' in it.
1144
1145         * Scripts/webkitpy/common/checkout/checkout.py:
1146         (Checkout.recent_commit_infos_for_files): Remove any empty commit information from the set.
1147         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Add a file which references an empty ChangeLog.
1148
1149 2018-02-08  Matt Lewis  <jlewis3@apple.com>
1150
1151         Unreviewed, rolling out r228261.
1152
1153         This broke an internal build
1154
1155         Reverted changeset:
1156
1157         "Add a way to check if a host is an IP address"
1158         https://bugs.webkit.org/show_bug.cgi?id=182427
1159         https://trac.webkit.org/changeset/228261
1160
1161 2018-02-08  Commit Queue  <commit-queue@webkit.org>
1162
1163         Unreviewed, rolling out r228267, r228268, and r228269.
1164         https://bugs.webkit.org/show_bug.cgi?id=182601
1165
1166         jhbuild socks (Requested by philn on #webkit).
1167
1168         Reverted changesets:
1169
1170         "[JHBuild] Update Mesa to version 17"
1171         https://bugs.webkit.org/show_bug.cgi?id=182599
1172         https://trac.webkit.org/changeset/228267
1173
1174         "Unreviewed, GTK build fix attempt after r228267."
1175         https://trac.webkit.org/changeset/228268
1176
1177         "Unreviewed, final GTK build fix attempt after r228267."
1178         https://trac.webkit.org/changeset/228269
1179
1180 2018-02-08  Philippe Normand  <pnormand@igalia.com>
1181
1182         Unreviewed, final GTK build fix attempt after r228267.
1183
1184         * gtk/jhbuild.modules: sha256sum for libdrm was for the tar.gz archive. Oops.
1185
1186 2018-02-08  Philippe Normand  <pnormand@igalia.com>
1187
1188         Unreviewed, GTK build fix attempt after r228267.
1189
1190         * gtk/jhbuild.modules: Update to libdrm version 2.4.89, Mesa 17 requires at least version 2.4.75.
1191
1192 2018-02-08  Philippe Normand  <pnormand@igalia.com>
1193
1194         [JHBuild] Update Mesa to version 17
1195         https://bugs.webkit.org/show_bug.cgi?id=182599
1196
1197         Reviewed by Carlos Alberto Lopez Perez.
1198
1199         * gtk/jhbuild.modules: Update Mesa to version 17.3.3.
1200
1201 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1202
1203         Add a way to check if a host is an IP address
1204         https://bugs.webkit.org/show_bug.cgi?id=182427
1205
1206         Reviewed by Alex Christensen.
1207
1208         Add unit test for URL::hostIsIPAddress().
1209
1210         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1211         (TestWebKitAPI::TEST_F):
1212
1213 2018-02-07  Tim Horton  <timothy_horton@apple.com>
1214
1215         Evernote device management web view sometimes displays at the wrong scale
1216         https://bugs.webkit.org/show_bug.cgi?id=182590
1217         <rdar://problem/36633687>
1218
1219         Reviewed by Simon Fraser.
1220
1221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1222         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm.
1223         (-[TestDelegateForScrollView dealloc]):
1224         (TestWebKitAPI::TEST):
1225         (-[WKScrollViewDelegateWithViewForZoomingOverridden viewForZoomingInScrollView:]):
1226         Add a test that failed before the change that ensures that we don't
1227         consult the external delegate for viewForZoomingInScrollView:, and that
1228         we succesfully update the scale even if it matches that of the view
1229         the external delegate returns for viewForZoomingInScrollView:.
1230
1231 2018-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1232
1233         REGRESSION(r226396): File paths are inserted when dropping image files
1234         https://bugs.webkit.org/show_bug.cgi?id=182557
1235         <rdar://problem/37294120>
1236
1237         Reviewed by Ryosuke Niwa.
1238
1239         Tweak some image pasting API tests to ensure that file paths are not inserted when pasting images backed by
1240         file paths on disk.
1241
1242         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1243         (TEST):
1244
1245 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1246
1247         [GTK] Enable WebKit.GeolocationTransitionTo{High,Low}Accuracy tests
1248         https://bugs.webkit.org/show_bug.cgi?id=125068
1249
1250         Unreviewed test gardening.
1251
1252         They do not appear to have failed since we started running them again in r226944.
1253
1254         * TestWebKitAPI/glib/TestExpectations.json:
1255
1256 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1257
1258         [GTK] Enable WebKit.InjectedBundleFrameHitTest test
1259         https://bugs.webkit.org/show_bug.cgi?id=120303
1260
1261         Unreviewed test gardening.
1262
1263         It does not appear to have failed since we started running it again in r226944.
1264
1265         * TestWebKitAPI/glib/TestExpectations.json:
1266
1267 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1268
1269         [GTK] Enable WebKit.ForceRepaint test
1270         https://bugs.webkit.org/show_bug.cgi?id=105532
1271
1272         Unreviewed test gardening.
1273
1274         It does not appear to have failed since we started running it again in r226944.
1275
1276         * TestWebKitAPI/glib/TestExpectations.json:
1277
1278 2018-02-07  Philippe Normand  <pnormand@igalia.com>
1279
1280         [JHBuild] Add libva in moduleset
1281         https://bugs.webkit.org/show_bug.cgi?id=182384
1282
1283         Reviewed by Xabier Rodriguez-Calvar.
1284
1285         * gstreamer/jhbuild.modules: Add libva and disable spurious message output.
1286         * gtk/install-dependencies: Remove libva from dependencies.
1287         * wpe/install-dependencies: Ditto.
1288
1289 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
1290
1291         [GTK] Enable WebKit.NewFirstVisuallyNonEmptyLayoutFrames test
1292         https://bugs.webkit.org/show_bug.cgi?id=85037
1293
1294         Unreviewed test gardening.
1295
1296         It does not appear to have failed since we started running it again in r226944.
1297
1298         * TestWebKitAPI/glib/TestExpectations.json:
1299
1300 2018-02-06  Leo Balter  <leonardo.balter@gmail.com>
1301
1302         Nit fix for ruby script called through Perl
1303         https://bugs.webkit.org/show_bug.cgi?id=182552
1304
1305         Reviewed by Yusuke Suzuki.
1306
1307         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1308         (RunTest262Tests):
1309
1310 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1311
1312         Remove WebCore/ForwardingHeaders directory
1313         https://bugs.webkit.org/show_bug.cgi?id=182347
1314
1315         Reviewed by Keith Miller.
1316
1317         * WebKitTestRunner/TestController.cpp:
1318
1319 2018-02-06  Ross Kirsling  <ross.kirsling@sony.com>
1320
1321         webkit-patch upload should ask for confirmation before creating a new bug
1322         https://bugs.webkit.org/show_bug.cgi?id=182551
1323
1324         Reviewed by Daniel Bates.
1325
1326         It is quite easy to paste unintended text into the bug number prompt. This creates a junk bug with an uneditable
1327         first comment, which could result in embarrassment or potentially even a proprietary information leak.
1328
1329         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1330         (test_prepare):
1331         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
1332         (PromptForBugOrTitle):
1333         (PromptForBugOrTitle.options):
1334         (PromptForBugOrTitle.run):
1335
1336 2018-02-06  Youenn Fablet  <youenn@apple.com>
1337
1338         HasServiceWorkerRegistration bit should be sent when creating a new page
1339         https://bugs.webkit.org/show_bug.cgi?id=182410
1340
1341         Reviewed by Chris Dumez.
1342
1343         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1344
1345 2018-02-06  Andres Gomez  <agomez@igalia.com>
1346
1347         [GTK][WPE] Add dependencies watching lists for WKGTK+ and WPE
1348         https://bugs.webkit.org/show_bug.cgi?id=182346
1349
1350         Reviewed by Michael Catanzaro.
1351
1352         Loren, Carlos and Andres are interested on the WKGTK+ dependencies
1353         watchlist since they are running WKGTK+ EWS.
1354
1355         Similarly, Adrian and Carlos are running a WPE EWS.
1356
1357         * Scripts/webkitpy/common/config/watchlist: Added WPEDependencies
1358           and WebKitGTKDependencies watchlists with the proper people.
1359
1360 2018-02-06  Andres Gomez  <agomez@igalia.com>
1361
1362         Unreviewed, canonicalize contributors.json
1363
1364         After Thibault's addition, automatic checks complain about
1365         contributors.json with:
1366
1367         "[...] Use "validate-committer-lists --canonicalize" to reformat
1368         it. [...]"
1369
1370         * Scripts/webkitpy/common/config/contributors.json: Canonicalize.
1371
1372 2018-02-06  Andres Gomez  <agomez@igalia.com>
1373
1374         Unreviewed, add Lorenzo Tilve to contributors.json
1375
1376         We need to add Loren to the contributors list in order to CC him
1377         in Bugzilla.
1378
1379         * Scripts/webkitpy/common/config/contributors.json: Added Lorenzo
1380           Tilve.
1381
1382 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
1383
1384         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
1385         https://bugs.webkit.org/show_bug.cgi?id=182478
1386
1387         Reviewed by Alex Christensen.
1388
1389         For TestWebKitAPI, sources related to WebKitLegacy are built
1390         at WebKit build. Those files should be reffered for WebKitLegacy build.
1391
1392         * TestWebKitAPI/PlatformWin.cmake:
1393
1394 2018-02-05  Daniel Bates  <dabates@apple.com>
1395
1396         REGRESSION (r217572): run-webkit-tests exits without emitting newline character
1397         https://bugs.webkit.org/show_bug.cgi?id=182360
1398
1399         Rubber-stamped by Aakash Jain.
1400
1401         Fixes an annoyance where run-webkit-tests always exits without printing a newline character.
1402         In the terminal this looks like:
1403
1404             $ Tools/Scripts/run-webkit-tests
1405             Expected to fail, but passed: (7)
1406             ...
1407             Stopping WebSocket server ...$
1408
1409         This bug was caused by code added in r217572 to stop all run-webkit-tests started servers (e.g. an HTTP
1410         server) from an at-exit handler. When run-webkit-tests runs successfully (i.e. without error or
1411         control-C interruption) we would stop all such servers twice: once as part of ending the test
1412         run and once from the at-exit handler. The latter never prints a trailing newline character hence
1413         the state of the terminal (as depicted above). Instead LayoutTestRunner.stop_servers() should only
1414         stop servers that it started in LayoutTestRunner.start_servers().
1415
1416         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1417         (LayoutTestRunner.__init__):
1418         (LayoutTestRunner.start_servers):
1419         (LayoutTestRunner.stop_servers):
1420         Only start servers that run-webkit-tests has not already started and only stop servers that
1421         run-webkit-tests started.
1422
1423         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1424         (LayoutTestRunnerTests.test_servers_started.is_websocket_server_running):
1425         (LayoutTestRunnerTests.test_servers_started):
1426         (LayoutTestRunnerTests.test_servers_started.is_websocket_servers_running): Deleted.
1427         Update due to rename below.
1428
1429         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1430         (is_web_socket_server_running): Added.
1431         (PyWebSocket.is_running): Deleted.
1432
1433         * Scripts/webkitpy/port/base.py:
1434         (Port.is_http_server_running): Check if we already started the server ourself.
1435         (Port.is_websocket_server_running): Formerly named is_websocket_servers_running. Modified
1436         to check if we already started the server ourself. Take a similar approach as the other
1437         Port.is_*_running methods and only check if an existing WebSocket server is running on the
1438         non-secure server port. This is a simple heuristic and should be sufficient in practice.
1439         (Port.is_wpt_server_running): Check if we already started the server ourself.
1440         (Port.is_websocket_servers_running): Deleted; renamed to is_websocket_server_running().
1441
1442 2018-02-05  Daniel Bates  <dabates@apple.com>
1443
1444         prepare-ChangeLog gets confused about Python docstrings that contain the word "class" or "def"
1445         https://bugs.webkit.org/show_bug.cgi?id=182405
1446
1447         Reviewed by David Kilzer.
1448
1449         String literal statements, including docstrings, do not demarcate a new scope in Python.
1450         So, do not treat them like they do when building up the list of modified functions.
1451
1452         * Scripts/prepare-ChangeLog:
1453         (get_function_line_ranges_for_python):
1454         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
1455         The expected ending line number for the last "pass" statement inside the scope of Class5 changed
1456         from 97 to 98 because empty lines do not effect scope. This is consistent with the parsing
1457         of the second "pass" statement in the scope of class Class5. A "pass" is a null operation that
1458         is used as a syntactic placeholder when a statement is required. Ideally we would make
1459         the parsing code smarter so as to avoid emitting ranges for "pass" statements that serve
1460         not syntactic purpose.
1461         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
1462         (Class5):
1463         (Class6):
1464         (Class6.__init__):
1465         (Class7):
1466         (Class7.__init__):
1467         (Class8):
1468         (Class8.__init__):
1469         Add some more tests.
1470
1471 2018-02-05  Matt Lewis  <jlewis3@apple.com>
1472
1473         Unreviewed, rolling out r228086.
1474
1475         This introduced a failure with API test
1476         URLTest.HostIsIPAddress.
1477
1478         Reverted changeset:
1479
1480         "Add a way to check if a host is an IP address"
1481         https://bugs.webkit.org/show_bug.cgi?id=182427
1482         https://trac.webkit.org/changeset/228086
1483
1484 2018-02-05  John Wilander  <wilander@apple.com>
1485
1486         Storage Access API: Add testRunner.getAllStorageAccessEntries() to make testing easier and more explicit
1487         https://bugs.webkit.org/show_bug.cgi?id=181601
1488         <rdar://problem/36475837>
1489
1490         Reviewed by Alex Christensen.
1491
1492         http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html
1493         was found to be flaky. With the testRunner.hasStorageAccessEntry() getter
1494         it's possible to check access even if a frame doesn't respond timely to
1495         postMessage after detach and attach.
1496
1497         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1498         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1499         (WTR::InjectedBundle::didReceiveMessageToPage):
1500         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1501         (WTR::TestRunner::setStorageAccessAPIEnabled):
1502             Just moved for source file grouping.
1503         (WTR::TestRunner::getAllStorageAccessEntries):
1504         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback):
1505         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1506         * WebKitTestRunner/TestController.cpp:
1507         (WTR::TestController::getAllStorageAccessEntries):
1508             Note that this is just stubbed out, i.e. not implemented.
1509         * WebKitTestRunner/TestController.h:
1510         * WebKitTestRunner/TestInvocation.cpp:
1511         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1512         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1513         * WebKitTestRunner/TestInvocation.h:
1514         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1515         (WTR::TestController::getAllStorageAccessEntries):
1516             This is the Cocoa-specific version of this test infrastructure.
1517
1518 2018-02-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1519
1520         [Win] Enable multi CPU building on MSBuild.
1521         https://bugs.webkit.org/show_bug.cgi?id=182446
1522
1523         Compiling itself already uses multi cores, but other stuff is still on single core.
1524         This patch enables that by passing an argument to MSBuild.exe.
1525
1526         Reviewed by Alex Christensen.
1527
1528         * Scripts/webkitdirs.pm:
1529         (determineNumberOfCPUs):
1530         (buildVisualStudioProject):
1531
1532 2018-02-05  Alicia Boya García  <aboya@igalia.com>
1533
1534         Fix bug in MediaTime comparison for negative values with different scale.
1535         https://bugs.webkit.org/show_bug.cgi?id=182433
1536
1537         Improved test coverage for MediaTime::compare().
1538
1539         Reviewed by Xabier Rodriguez-Calvar.
1540
1541         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1542         (TestWebKitAPI::TEST):
1543
1544 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1545
1546         [SOUP] WebSockets must use system proxy settings
1547         https://bugs.webkit.org/show_bug.cgi?id=126384
1548
1549         Reviewed by Michael Catanzaro.
1550
1551         Check also WebSockets in /webkit2/WebKitWebContext/proxy.
1552
1553         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1554         (ProxyTest::webSocketProxyServerCallback):
1555         (ProxyTest::ProxyTest):
1556         (ProxyTest::webSocketConnected):
1557         (ProxyTest::createWebSocketAndWaitUntilConnected):
1558         (webSocketServerCallback):
1559         (testWebContextProxySettings):
1560         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1561         (WebKitTestServer::~WebKitTestServer):
1562         (WebKitTestServer::addWebSocketHandler):
1563         (WebKitTestServer::removeWebSocketHandler):
1564         (WebKitTestServer::getWebSocketURIForPath const):
1565         (WebKitTestServer::getURIForPath const):
1566         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
1567         (WebKitTestServer::baseURI const):
1568         (WebKitTestServer::baseWebSocketURI const):
1569
1570 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1571
1572         Add a way to check if a host is an IP address
1573         https://bugs.webkit.org/show_bug.cgi?id=182427
1574
1575         Reviewed by Alex Christensen.
1576
1577         Add unit test for URL::hostIsIPAddress().
1578
1579         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1580         (TestWebKitAPI::TEST_F):
1581
1582 2018-02-03  Charlie Turner  <cturner@igalia.com>
1583
1584         Add libmount to WPE dependencies
1585         https://bugs.webkit.org/show_bug.cgi?id=182345
1586
1587         Reviewed by Michael Catanzaro.
1588
1589         * wpe/install-dependencies:
1590
1591 2018-02-02  Youenn Fablet  <youenn@apple.com>
1592
1593         W3C test exporter should allow exporting newly added files
1594         https://bugs.webkit.org/show_bug.cgi?id=182369
1595
1596         Reviewed by Ryosuke Niwa.
1597
1598         * Scripts/webkitpy/common/checkout/scm/git.py:
1599         (Git.apply_mail_patch):
1600
1601 2018-02-02  David Quesada  <david_quesada@apple.com>
1602
1603         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
1604         https://bugs.webkit.org/show_bug.cgi?id=182363
1605         rdar://problem/37093498
1606
1607         Reviewed by Ryosuke Niwa.
1608
1609         Updated ApplicationManifestParserTests to account for the new default scope behavior.
1610
1611         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1612         (assertManifestHasDefaultValues):
1613         (TEST_F):
1614
1615 2018-02-02  Youenn Fablet  <youenn@apple.com>
1616
1617         Clearing all service worker registrations should wait for importing service worker registration to finish
1618         https://bugs.webkit.org/show_bug.cgi?id=182407
1619
1620         Reviewed by Chris Dumez.
1621
1622         Make sure we finish clearing service worker registrations before running tests.
1623
1624         * WebKitTestRunner/TestController.cpp:
1625         (WTR::TestController::resetStateToConsistentValues):
1626         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
1627         (WTR::clearServiceWorkerRegistrationsCallback):
1628         (WTR::TestController::clearServiceWorkerRegistrations):
1629         * WebKitTestRunner/TestController.h:
1630
1631 2018-02-02  Youenn Fablet  <youenn@apple.com>
1632
1633         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
1634         https://bugs.webkit.org/show_bug.cgi?id=182403
1635
1636         Reviewed by Alex Christensen.
1637
1638         * WebKitTestRunner/TestController.cpp:
1639         (WTR::TestController::generateContextConfiguration const):
1640         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1641         (WTR::initializeWebViewConfiguration):
1642
1643 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1644
1645         [GTK] WebDriver: tests step always times out in the bot
1646         https://bugs.webkit.org/show_bug.cgi?id=182437
1647
1648         Reviewed by Carlos Alberto Lopez Perez.
1649
1650         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
1651         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
1652
1653         * Scripts/run-webdriver-tests: Call teardown() after run().
1654         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1655         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
1656         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1657         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
1658         the display driver once and pass it to the test runners.
1659         (WebDriverTestRunner.teardown): Stop the display server.
1660         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1661         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
1662         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
1663         (WebDriverTestRunnerSelenium.run): Ditto.
1664         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1665         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
1666         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
1667         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1668         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
1669
1670 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1671
1672         Unreviewed, rolling out r227999.
1673
1674         It didn't fix the problem
1675
1676         Reverted changeset:
1677
1678         "Unreviewed. Try to avoid webdriver tests step timing out in
1679         the bots."
1680         https://trac.webkit.org/changeset/227999
1681
1682 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1683
1684         Start timeout for the run-buildbot-test script is too aggressive
1685         https://bugs.webkit.org/show_bug.cgi?id=182429
1686
1687         Reviewed by Carlos Garcia Campos.
1688
1689         15 seconds is not enough waiting for the update database process
1690         to complete on a system backed with rotational HDDs. Raise it to 60.
1691
1692         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
1693         (wait_for_master_ready):
1694
1695 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1696
1697         re-add ARM JSCOnly bots on buildbot waterfall
1698         https://bugs.webkit.org/show_bug.cgi?id=182428
1699
1700         Reviewed by Csaba Osztrogonác.
1701
1702         * BuildSlaveSupport/build.webkit.org-config/config.json:
1703         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1704
1705 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1706
1707         Remove ARM JSCOnly bots from buildbot waterfall
1708         https://bugs.webkit.org/show_bug.cgi?id=182398
1709
1710         Reviewed by Alexey Proskuryakov.
1711
1712         * BuildSlaveSupport/build.webkit.org-config/config.json:
1713         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1714
1715 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1716
1717         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
1718
1719         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
1720         workaround for a bug in python2.7 when using multiprocess module.
1721
1722         * Scripts/run-webdriver-tests:
1723
1724 2018-02-01  Youenn Fablet  <youenn@apple.com>
1725
1726         Delay service worker process creation until actually needed by SWServer
1727         https://bugs.webkit.org/show_bug.cgi?id=182301
1728
1729         Reviewed by Chris Dumez.
1730
1731         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1732         (function):
1733
1734 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
1735
1736         Bubbles intermittently disappear from bot watchers dashboard
1737         https://bugs.webkit.org/show_bug.cgi?id=182085
1738
1739         Reviewed by Alexey Proskuryakov.
1740
1741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1742         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
1743         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
1744         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
1745
1746 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1747
1748         [GTK] Problem with Washington Post images
1749         https://bugs.webkit.org/show_bug.cgi?id=181421
1750
1751         Reviewed by Carlos Alberto Lopez Perez.
1752
1753         Add test case for the new user agent quirk.
1754
1755         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1756         (TestWebKitAPI::TEST):
1757
1758 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1759
1760         [GTK] MiniBrowser settings are just a list of names
1761         https://bugs.webkit.org/show_bug.cgi?id=182005
1762
1763         Reviewed by Sergio Villar Senin.
1764
1765         The default size we are using is too small to show the values column, and the window is not resizable because
1766         GObjectClass::constructed() is not called in the parent class.
1767
1768         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1769         (browser_settings_dialog_init): Use 600x400 as default size.
1770         (browserSettingsDialogConstructed): Chain up to parent constructed.
1771
1772 2018-01-31  Andres Gomez  <agomez@igalia.com>
1773
1774         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
1775
1776         * Scripts/webkitpy/common/config/watchlist:
1777
1778 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
1779
1780         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
1781         https://bugs.webkit.org/show_bug.cgi?id=181204
1782         <rdar://problem/36256274>
1783
1784         Reviewed by Ryosuke Niwa.
1785
1786         Implement 'testRunner.forceImmediateCompletion()' for WK1.
1787
1788         * DumpRenderTree/TestRunner.cpp:
1789         (forceImmediateCompletionCallback):
1790         (TestRunner::staticFunctions):
1791
1792 2018-01-31  Alex Christensen  <achristensen@webkit.org>
1793
1794         Unreviewed, rolling out r227942.
1795
1796         r227875 should not have been rolled out.
1797
1798         Reverted changeset:
1799
1800         "Unreviewed, rolling out r227875."
1801         https://bugs.webkit.org/show_bug.cgi?id=182357
1802         https://trac.webkit.org/changeset/227942
1803
1804 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1805
1806         Unreviewed, rolling out r227875.
1807         https://bugs.webkit.org/show_bug.cgi?id=182357
1808
1809         Missing cross-platform TestController implementation
1810
1811         Reverted changeset:
1812
1813         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
1814         https://bugs.webkit.org/show_bug.cgi?id=181958
1815         https://trac.webkit.org/changeset/227875
1816
1817         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1818         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1819         (WTR::InjectedBundle::didReceiveMessageToPage):
1820         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1821         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1822         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1823         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
1824         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1825         * WebKitTestRunner/TestInvocation.cpp:
1826         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
1827         * WebKitTestRunner/TestInvocation.h:
1828         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1829         (WTR::TestController::statisticsUpdateCookiePartitioning):
1830         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1831
1832 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1833
1834         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
1835         https://bugs.webkit.org/show_bug.cgi?id=182222
1836
1837         Reviewed by Alex Christensen.
1838
1839         Use the new API to notify when resource load statistics deletion is complete.
1840
1841         * WebKitTestRunner/TestController.cpp:
1842         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
1843         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1844         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1845
1846 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
1847
1848         Add the support for running StyleBench to run-benchmark
1849         https://bugs.webkit.org/show_bug.cgi?id=182323
1850
1851         Reviewed by Antti Koivisto.
1852
1853         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
1854
1855         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
1856         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
1857
1858 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1859
1860         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
1861         https://bugs.webkit.org/show_bug.cgi?id=182339
1862         <rdar://problem/36041396>
1863
1864         Reviewed by Andy Estes.
1865
1866         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
1867         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
1868         check against the length of the data written.
1869
1870         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1871         (testIconImageData):
1872         (runTestWithTemporaryFolder):
1873         (TestWebKitAPI::TEST):
1874
1875 2018-01-31  Dan Bernstein  <mitz@apple.com>
1876
1877         [macOS] MiniBrowser isn’t app-sandboxed
1878         https://bugs.webkit.org/show_bug.cgi?id=182147
1879
1880         Reviewed by Sam Weinig.
1881
1882         Enable App Sandbox and add a temporary exception allowing read access to all files.
1883
1884         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
1885         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
1886         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
1887           and read access from /.
1888         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
1889
1890 2018-01-31  Philippe Normand  <pnormand@igalia.com>
1891
1892         [JHBuild] Add gstreamer-vaapi in moduleset
1893         https://bugs.webkit.org/show_bug.cgi?id=182283
1894
1895         Reviewed by Carlos Alberto Lopez Perez.
1896
1897         GStreamer-VAAPI is required for hardware-accelerated video
1898         playback support on Intel and AMD (using radeosi driver)
1899         platforms.
1900
1901         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
1902         * gtk/install-dependencies: Install libva.
1903         * wpe/install-dependencies: Ditto.
1904         * Scripts/webkitpy/port/gtk.py:
1905         (GtkPort.setup_environ_for_server): Disable va-api support when
1906         testing because it's incompatible with Mesa's softGL driver.
1907
1908 2018-01-31  Charlie Turner  <cturner@igalia.com>
1909
1910         [WPE] Update jhbuild dependencies
1911         https://bugs.webkit.org/show_bug.cgi?id=182286
1912
1913         This upgrades the following packages,
1914         glib 2.44.1 -> 2.54.3
1915         glib-networking 2.42.0 -> 2.54.1
1916         libsoup 2.48.0 -> 2.60.3
1917
1918         The initial reason for performing these upgrades was that when
1919         visiting https://youtube.com, WPE was getting TLS certificate
1920         errors. After upgrading glib-networking, these were fixed, but the
1921         upgrade introduced dependencies on newer versions of the other
1922         packages upgraded in this commit.
1923
1924         The upgrade to glib caused a linking error in gstreamer, the
1925         following errors were being logged during linking,
1926
1927         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
1928         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
1929         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
1930
1931         This was fixed by adding the glib package built in the jhbuild to
1932         harfbuzz.
1933
1934         Finally, the upgrade of glib caused the glib-warning-fix.patch to
1935         no longer apply, so this patch was removed.
1936
1937         Reviewed by Michael Catanzaro.
1938
1939         * wpe/jhbuild.modules: Added dependecies.
1940         * wpe/patches/glib-warning-fix.patch: Removed.
1941
1942 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1943
1944         Unreviewed, rolling out r227782.
1945
1946         It didn't fix the problem
1947
1948         Reverted changeset:
1949
1950         "Unreviewed. Try to avoid webdriver tests step timing out in
1951         the bots."
1952         https://trac.webkit.org/changeset/227782
1953
1954 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1955
1956         WebDriver: add domains to server config in w3c tests
1957         https://bugs.webkit.org/show_bug.cgi?id=182294
1958
1959         Reviewed by Carlos Alberto Lopez Perez.
1960
1961         Several cookie tests expect server_config to have a domains key.
1962
1963         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
1964                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
1965
1966         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1967         (WebDriverW3CExecutor.__init__):
1968
1969 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1970
1971         Unreviewed. Update W3C WebDriver imported tests.
1972
1973         Show full pytest failure logs.
1974
1975         pytest truncates long lists when printing a failed assertion.
1976         This is not great for debugging and arguably it should be the
1977         default to show the full diff when comparing lists.
1978
1979         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1980         (run):
1981
1982 2018-01-30  John Wilander  <wilander@apple.com>
1983
1984         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
1985         https://bugs.webkit.org/show_bug.cgi?id=181958
1986         https://bugs.webkit.org/show_bug.cgi?id=182072
1987         <rdar://problem/36801804>
1988         <rdar://problem/36845795>
1989
1990         Reviewed by Brent Fulgham.
1991
1992         Because of the asynchronous nature of XPC and cookies,
1993         we need callbacks in these TestRunner functions so that
1994         the layout tests can wait for state changes to finish
1995         before checking test conditions.
1996
1997         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1998         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1999         (WTR::InjectedBundle::didReceiveMessageToPage):
2000         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2001         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2002         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2003         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
2004         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2005         * WebKitTestRunner/TestInvocation.cpp:
2006         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
2007         * WebKitTestRunner/TestInvocation.h:
2008         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2009         (WTR::TestController::statisticsUpdateCookiePartitioning):
2010         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2011
2012 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2013
2014         [webkitpy] Config file for apache is copied twice.
2015         https://bugs.webkit.org/show_bug.cgi?id=182131
2016
2017         Reviewed by Daniel Bates.
2018
2019         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2020         (LayoutTestApacheHttpd.__init__):
2021         (LayoutTestApacheHttpd._copy_apache_config_file):
2022         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
2023
2024 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
2025
2026         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
2027         https://bugs.webkit.org/show_bug.cgi?id=182312
2028
2029         Reviewed by Michael Catanzaro.
2030
2031         * DumpRenderTree/config.h:
2032         * TestWebKitAPI/config.h:
2033         * WebKitTestRunner/config.h:
2034
2035 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2036
2037         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
2038         https://bugs.webkit.org/show_bug.cgi?id=182307
2039         <rdar://problem/36041485>
2040
2041         Reviewed by Ryosuke Niwa.
2042
2043         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
2044         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
2045         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
2046         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
2047
2048         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
2049         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2050         (TestWebKitAPI::TEST):
2051
2052 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
2053
2054         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
2055         https://bugs.webkit.org/show_bug.cgi?id=182284
2056
2057         Reviewed by Michael Catanzaro.
2058
2059         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
2060         * wpe/manifest.txt.in: Ditto.
2061
2062 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2063
2064         Unreviewed, try to fix JSCOnly build
2065         https://bugs.webkit.org/show_bug.cgi?id=177202
2066
2067         * CMakeLists.txt:
2068
2069 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2070
2071         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
2072
2073         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
2074         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
2075         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
2076         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
2077
2078         * Scripts/run-webdriver-tests:
2079         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2080         (WebDriverTestRunner.dump_results_to_json_file):
2081
2082 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2083
2084         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
2085         https://bugs.webkit.org/show_bug.cgi?id=177202
2086
2087         Reviewed by Alex Christensen.
2088
2089         * CMakeLists.txt:
2090
2091 2018-01-29  Alex Christensen  <achristensen@webkit.org>
2092
2093         Clean up API after bugs 178240 and 176474
2094         https://bugs.webkit.org/show_bug.cgi?id=182259
2095
2096         Reviewed by Dan Bernstein.
2097
2098         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2099         (TEST):
2100         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
2101
2102 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
2103
2104         [WebAuthN] Add a compile-time feature flag
2105         https://bugs.webkit.org/show_bug.cgi?id=182211
2106         <rdar://problem/36936365>
2107
2108         Reviewed by Brent Fulgham.
2109
2110         * Scripts/webkitperl/FeatureList.pm:
2111         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2112
2113 2018-01-29  Brady Eidson  <beidson@apple.com>
2114
2115         Make the API test added in r227737 be Mac-only.
2116
2117         Unreviewed gardening.
2118
2119         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
2120
2121 2018-01-29  Matt Lewis  <jlewis3@apple.com>
2122
2123         Unreviewed, rolling out r227731.
2124
2125         This caused and assertion failure in API tests.
2126
2127         Reverted changeset:
2128
2129         "Layout Test fast/events/beforeunload-dom-manipulation-
2130         crash.html is crashing"
2131         https://bugs.webkit.org/show_bug.cgi?id=181204
2132         https://trac.webkit.org/changeset/227731
2133
2134 2018-01-29  Youenn Fablet  <youenn@apple.com>
2135
2136         WPT test exporter should add WebKit export in its PR description
2137         https://bugs.webkit.org/show_bug.cgi?id=182246
2138
2139         Reviewed by Chris Dumez.
2140
2141         Updating PR description body to contain the words 'WebKit export'.
2142         That way, WPT PR bot will mark the PR as reviewed downstream.
2143
2144         * Scripts/webkitpy/w3c/test_exporter.py:
2145         (TestExporter.__init__):
2146         (TestExporter.make_pull_request):
2147         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
2148         (TestExporterTest.test_export):
2149
2150 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
2151
2152         Add the support for running Speedometer 2.0 to run-benchmark
2153         https://bugs.webkit.org/show_bug.cgi?id=182231
2154
2155         Reviewed by Antti Koivisto.
2156
2157         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
2158         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
2159         requires aggregating the geometric mean out of total time spent in each suite.
2160
2161         Also added --show-iteration-values to show individual measured values in each iteration.
2162
2163         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2164         (BenchmarkResults.format): Added show_iteration_values as an option.
2165         (BenchmarkResults._format_tests): Ditto.
2166         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
2167         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
2168         is easily parsable as a JSON array.
2169         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
2170         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
2171         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
2172         had exactly one aggregator.
2173         (BenchmarkResults._lint_results):
2174         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
2175         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
2176         parent_aggregator_list.
2177         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
2178         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
2179         (BenchmarkResults._lint_configuration):
2180         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
2181         (test_format_values_with_no_unit_scaling): Added.
2182         (test_format_values_with_iteration_values): Added.
2183         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
2184         (test_aggregate_results_from_another_aggregator): Added.
2185         (test_lint_results): Added a test case.
2186         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2187         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
2188         (BenchmarkRunner._run_benchmark): Ditto.
2189         (BenchmarkRunner.show_results): Ditto.
2190         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
2191         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
2192         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2193         (parse_args): Added --show-iteration-values as a boolean argument.
2194         (run_benchmark_plan): Ditto.
2195         (start): Ditto.
2196         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2197         (WebServerBenchmarkRunner.__init__): Ditto.
2198
2199 2018-01-29  Brady Eidson  <beidson@apple.com>
2200
2201         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
2202         https://bugs.webkit.org/show_bug.cgi?id=182229
2203
2204         Reviewed by Chris Dumez.
2205
2206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2207         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
2208
2209 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2210
2211         WebDriver: properly recover w3c tests after a webdriver server crash
2212         https://bugs.webkit.org/show_bug.cgi?id=182242
2213
2214         Reviewed by Carlos Alberto Lopez Perez.
2215
2216         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
2217         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
2218         relaunching the server after every test failure, because other failures, even when not crashing the server,
2219         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
2220         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
2221
2222         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2223         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
2224         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2225         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
2226         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
2227         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
2228         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
2229         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
2230
2231 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
2232
2233         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
2234         https://bugs.webkit.org/show_bug.cgi?id=181204
2235         <rdar://problem/36256274>
2236
2237         Reviewed by Ryosuke Niwa.
2238
2239         Implement 'testRunner.forceImmediateCompletion()' for WK1.
2240
2241         * DumpRenderTree/TestRunner.cpp:
2242         (forceImmediateCompletionCallback):
2243         (TestRunner::staticFunctions):
2244
2245 2018-01-29  Frederic Wang  <fwang@igalia.com>
2246
2247         Unreviewed, add myself to some watch lists.
2248
2249         * Scripts/webkitpy/common/config/watchlist:
2250
2251 2018-01-27  Dan Bernstein  <mitz@apple.com>
2252
2253         HaveInternalSDK includes should be "#include?"
2254         https://bugs.webkit.org/show_bug.cgi?id=179670
2255
2256         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2257
2258 2018-01-26  Chris Dumez  <cdumez@apple.com>
2259
2260         Make sure service worker code does not launch a StorageProcess unnecessarily
2261         https://bugs.webkit.org/show_bug.cgi?id=182192
2262         <rdar://problem/36927427>
2263
2264         Reviewed by Geoffrey Garen.
2265
2266         Add API test coverage.
2267
2268         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2269
2270 2018-01-26  Chris Dumez  <cdumez@apple.com>
2271
2272         Offlined content does not work for apps on home screen
2273         https://bugs.webkit.org/show_bug.cgi?id=182070
2274         <rdar://problem/36843906>
2275
2276         Reviewed by Youenn Fablet.
2277
2278         Add API test coverage to make sure an already registered service worker is able to intercept
2279         the very first load.
2280
2281         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2282         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
2283
2284 2018-01-26  Chris Nardi  <cnardi@chromium.org>
2285
2286         Addressing post-review comments after r226614
2287         https://bugs.webkit.org/show_bug.cgi?id=182151
2288
2289         Reviewed by Myles C. Maxfield.
2290
2291         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
2292         (TestWebKitAPI::TEST):
2293
2294 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
2295
2296         Unreviewed, rolling out r224920.
2297
2298         Some Win EWS bots are not coming back up after starting reboot.
2299
2300         * EWSTools/start-queue-win.sh:
2301
2302 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2303
2304         WebDriver: simplify the tests json report
2305         https://bugs.webkit.org/show_bug.cgi?id=182171
2306
2307         Reviewed by Carlos Alberto Lopez Perez.
2308
2309         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
2310         form the subtest name. We should do the same for simplicity and compatibility with WPT.
2311
2312         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2313         (WebDriverTestRunner.dump_results_to_json_file):
2314
2315 2018-01-25  Alex Christensen  <achristensen@webkit.org>
2316
2317         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
2318         https://bugs.webkit.org/show_bug.cgi?id=182152
2319
2320         Reviewed by Joseph Pecoraro.
2321
2322         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2323         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2324         (TEST):
2325
2326 2018-01-25  Youenn Fablet  <youenn@apple.com>
2327
2328         WebPluginInfoProvider should handle null host queries
2329         https://bugs.webkit.org/show_bug.cgi?id=182112
2330
2331         Reviewed by Chris Dumez.
2332
2333         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
2334         (TEST):
2335
2336 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2337
2338         [webkitpy] Stop modifying path information only when running on Cygwin
2339         https://bugs.webkit.org/show_bug.cgi?id=182136
2340
2341         On LayoutTestApacheHttpd, some path configuration is modified when platform
2342         is Windows. This modification is only required for AppleWin running on Cygwin.
2343         WinCairo uses native Windows environment, so the condition should be changed.
2344
2345         Reviewed by Per Arne Vollan.
2346
2347         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2348         (LayoutTestApacheHttpd.__init__):
2349         (LayoutTestApacheHttpd._get_apache_config_file_path):
2350
2351 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
2352
2353         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
2354         https://bugs.webkit.org/show_bug.cgi?id=182038
2355         <rdar://problem/36812083>
2356
2357         Reviewed by Jer Noble.
2358
2359         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2360         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
2361
2362 2018-01-24  Daniel Bates  <dabates@apple.com>
2363
2364         webkit-patch upload emits irrelevant simulator warnings
2365         https://bugs.webkit.org/show_bug.cgi?id=181702
2366         <rdar://problem/36556359>
2367
2368         Reviewed by Aakash Jain.
2369
2370         Remove warning when a person explicitly passes --child-processes with a value greater than
2371         the default number of simulator instances webkitpy would have used had --child-processes
2372         been omitted. Moreover, the placement of the warning logic to support printing such a message
2373         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
2374
2375         By default, webkitpy will parallelize running tests using the maximum number of simulator
2376         instances that can be supported based on available system resources at the time run-webkit-tests
2377         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
2378         by specifying --child-processes knows what they are doing. The effects of picking a large
2379         value be obvious, the system may become sluggish.
2380
2381         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
2382         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
2383
2384         * Scripts/webkitpy/port/ios_simulator.py:
2385         (IOSSimulatorPort.__init__):
2386
2387 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
2388
2389         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
2390         https://bugs.webkit.org/show_bug.cgi?id=182102
2391
2392         Reviewed by Carlos Garcia Campos.
2393
2394         * MiniBrowser/gtk/main.c:
2395         (main): Removed the call to set_enable_webvr().
2396
2397 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2398
2399         WebDriver: add support for slow tests
2400         https://bugs.webkit.org/show_bug.cgi?id=182095
2401
2402         Reviewed by Carlos Alberto Lopez Perez.
2403
2404         Add timeout mark to slow tests.
2405
2406         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2407         (TestExpectationsMarker.__init__): Save the timeout.
2408         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
2409         (run): Pass timeout to TestExpectationsMarker constructor.
2410
2411 2018-01-24  Alex Christensen  <achristensen@webkit.org>
2412
2413         Gracefully recover from NetworkProcess crashes in private browsing
2414         https://bugs.webkit.org/show_bug.cgi?id=182073
2415         <rdar://problem/36572023>
2416
2417         Reviewed by Geoff Garen.
2418
2419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2420         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
2421         (-[CrashDelegate webView:didFinishNavigation:]):
2422         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
2423         (-[CrashDelegate webView:didFailNavigation:withError:]):
2424         (TEST):
2425
2426 2018-01-24  Ali Juma  <ajuma@chromium.org>
2427
2428         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
2429         https://bugs.webkit.org/show_bug.cgi?id=182052
2430
2431         Reviewed by Simon Fraser.
2432
2433         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
2434         immediately.
2435
2436         Test: fast/visual-viewport/viewport-dimensions.html
2437
2438         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2439         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2440
2441 2018-01-24  Alex Christensen  <achristensen@webkit.org>
2442
2443         Remove pre-Sierra-OS-specific code in Tools
2444         https://bugs.webkit.org/show_bug.cgi?id=182034
2445
2446         Reviewed by Tim Horton.
2447
2448         * DumpRenderTree/mac/DumpRenderTree.mm:
2449         (setDefaultsToConsistentValuesForTesting):
2450         * MiniBrowser/mac/BrowserWindowController.m:
2451         (-[BrowserWindowController windowDidLoad]):
2452         (-[BrowserWindowController share:]):
2453         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2454         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
2455         (-[EventStreamPlayer playbackTimerFired:]):
2456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2457         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
2458         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
2459         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2460         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2461         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2462         (WTR::InjectedBundle::platformInitialize):
2463         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2464         (WTR::initializeWebViewConfiguration):
2465
2466 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
2467
2468         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
2469         https://bugs.webkit.org/show_bug.cgi?id=181400
2470         <rdar://problem/36358768>
2471
2472         Reviewed by Joseph Pecoraro.
2473
2474         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
2475
2476         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
2477         Always disable poisoning when running with --leaks, as this should work locally,
2478         not just on bots.
2479
2480 2018-01-24  Daniel Bates  <dabates@apple.com>
2481
2482         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
2483         https://bugs.webkit.org/show_bug.cgi?id=181993
2484         <rdar://problem/36421080>
2485
2486         Reviewed by David Hyatt.
2487
2488         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
2489         as we no longer support this strategy.
2490
2491         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
2492
2493 2018-01-24  David Kilzer  <ddkilzer@apple.com>
2494
2495         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
2496         <https://webkit.org/b/182015>
2497         <rdar://problem/36449728>
2498
2499         Reviewed by Tim Horton.
2500
2501         * Scripts/webkitpy/style/checkers/cpp.py:
2502         (regex_for_lambdas_and_blocks): Update regex to include
2503         optional return type for block argument in Objective-C.
2504         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2505         (WebKitStyleTest.test_braces): Add test.
2506
2507 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
2508
2509         WPE-focused test gardening.
2510         https://bugs.webkit.org/show_bug.cgi?id=182051
2511
2512         Unreviewed test gardening.
2513
2514         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
2515
2516 2018-01-23  Mark Lam  <mark.lam@apple.com>
2517
2518         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
2519         https://bugs.webkit.org/show_bug.cgi?id=182017
2520         <rdar://problem/36795513>
2521
2522         Reviewed by Filip Pizlo and JF Bastien.
2523
2524         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2525         (TestWebKitAPI::TEST):
2526         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2527         (TestWebKitAPI::TEST):
2528         (TestWebKitAPI::passWithRef):
2529         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2530         (TestWebKitAPI::TEST):
2531         (TestWebKitAPI::f1):
2532         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2533         (TestWebKitAPI::TEST):
2534         (TestWebKitAPI::poisonedPtrFoo):
2535         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2536         (TestWebKitAPI::TEST):
2537         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2538         (TestWebKitAPI::TEST):
2539
2540 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
2541
2542         [WebVR] Add OpenVR to the tree and to the build
2543         https://bugs.webkit.org/show_bug.cgi?id=177298
2544
2545         Reviewed by Žan Doberšek.
2546
2547         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
2548         with reduced style checks.
2549
2550 2018-01-24  Chris Nardi  <cnardi@chromium.org>
2551
2552         Add Chris Nardi to contributors list
2553         https://bugs.webkit.org/show_bug.cgi?id=182029
2554
2555         Reviewed by Antti Koivisto.
2556
2557         * Scripts/webkitpy/common/config/contributors.json:
2558
2559 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2560
2561         Mac Sierra perf bots have been failing due to CG errors
2562         https://bugs.webkit.org/show_bug.cgi?id=181955
2563
2564         Reviewed by Antti Koivisto.
2565
2566         Ignore the CoreGraphics error messages on macOS Sierra.
2567
2568         Also added tests for ignoring lines in stdout and stderr.
2569
2570         * Scripts/webkitpy/performance_tests/perftest.py:
2571         (PerfTest.run_failed): Refactored for clarity.
2572         (PerfTest):
2573         (PerfTest.filter_ignored_lines): Added.
2574         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
2575         are now used to ignore lines in other kinds of tests than parser tests.
2576         (PerfTest._errors_to_ignore_in_sierra): Added.
2577         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
2578         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2579         (test_parse_output_with_ignored_stdout): Added.
2580         (test_parse_output_with_ignored_stderr): Added.
2581         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
2582
2583 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
2584
2585         Resign NowPlaying status when no media element is eligible
2586         https://bugs.webkit.org/show_bug.cgi?id=181914
2587         <rdar://problem/35294116>
2588
2589         Reviewed by Jer Noble.
2590
2591         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2592         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
2593         (TestWebKitAPI::TEST):
2594         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
2595
2596 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2597
2598         [WinCairo] Use 64-bit toolset
2599         https://bugs.webkit.org/show_bug.cgi?id=181979
2600
2601         Reviewed by Alex Christensen.
2602
2603         Use 64-bit toolset for 64-bit build in order to improve build time. 
2604
2605         * Scripts/webkitdirs.pm:
2606         (generateBuildSystemFromCMakeProject):
2607
2608 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
2609
2610         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
2611         https://bugs.webkit.org/show_bug.cgi?id=181741
2612         rdar://problem/36593581
2613
2614         Reviewed by Tim Horton.
2615         
2616         If zoomToScale:animated: is called with the current zoom level, call the callback
2617         rather than doing nothing.
2618
2619         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2620         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2621
2622 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2623
2624         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
2625         https://bugs.webkit.org/show_bug.cgi?id=180820
2626
2627         Reviewed by David Kilzer.
2628
2629         * Scripts/webkitpy/common/checkout/scm/git.py:
2630         (Git.in_working_directory):
2631         (Git.clone):
2632         (Git.read_git_config):
2633         (Git.apply_reverse_diff):
2634         * Scripts/webkitpy/common/checkout/scm/scm.py:
2635         (SCM.run):
2636         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2637         * Scripts/webkitpy/common/checkout/scm/svn.py:
2638         (SVNRepository.has_authorization_for_realm):
2639         * Scripts/webkitpy/common/net/credentials_unittest.py:
2640         * Scripts/webkitpy/common/system/abstractexecutive.py:
2641         (AbstractExecutive.run_command):
2642         * Scripts/webkitpy/common/system/executive.py:
2643         (Executive.kill_process.is):
2644         (Executive.running_pids):
2645         (Executive.kill_all):
2646         (Executive.run_command):
2647         * Scripts/webkitpy/common/system/executive_mock.py:
2648         (MockExecutive.run_command):
2649         (MockExecutive2.run_command):
2650         * Scripts/webkitpy/common/system/executive_unittest.py:
2651         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
2652         * Scripts/webkitpy/common/system/platforminfo.py:
2653         (PlatformInfo.xcode_sdk_version):
2654         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2655         (Lighttpd._check_and_kill):
2656         * Scripts/webkitpy/port/base.py:
2657         (Port._symbols_string):
2658         * Scripts/webkitpy/port/gtk.py:
2659         (GtkPort.setup_environ_for_server):
2660         * Scripts/webkitpy/port/win.py:
2661         (WinPort._runtime_feature_list):
2662         (WinPort.read_registry_value):
2663         * Scripts/webkitpy/port/win_unittest.py:
2664         (WinPortTest.test_runtime_feature_list):
2665         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2666         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
2667
2668 2018-01-23  Commit Queue  <commit-queue@webkit.org>
2669
2670         Unreviewed, rolling out r227279 and r227373.
2671         https://bugs.webkit.org/show_bug.cgi?id=181988
2672
2673         The LayoutTest crash fix introduced an API test failure.
2674         (Requested by ryanhaddad on #webkit).
2675
2676         Reverted changesets:
2677
2678         "Resign NowPlaying status when no media element is eligible"
2679         https://bugs.webkit.org/show_bug.cgi?id=181914
2680         https://trac.webkit.org/changeset/227279
2681
2682         "Resign NowPlaying status when no media element is eligible"
2683         https://bugs.webkit.org/show_bug.cgi?id=181914
2684         https://trac.webkit.org/changeset/227373
2685
2686 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2687
2688         Unreviewed. Add test case for slow in test_expectations.py.
2689
2690         I forgot to also check slow tests in test_expectations.py unit tests.
2691
2692         * Scripts/webkitpy/common/test_expectations_unittest.py:
2693         (assert_slow):
2694         (test_build_type):
2695         (test_slow):
2696
2697 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2698
2699         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
2700
2701         * TestWebKitAPI/glib/TestExpectations.json:
2702
2703 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2704
2705         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
2706         https://bugs.webkit.org/show_bug.cgi?id=181616
2707         <rdar://problem/36484908>
2708
2709         Reviewed by Wenson Hsieh.
2710
2711         Added tests to make sure we sanitize plain HTML, not just web archives,
2712         when and only when custom pasteboard data is enabled.
2713
2714         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2715         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
2716         (writeHTMLToPasteboard): Added.
2717         (createWebViewWithCustomPasteboardDataSetting): Added.
2718
2719 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
2720
2721         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
2722         https://bugs.webkit.org/show_bug.cgi?id=181400
2723         rdar://problem/36358768
2724
2725         Reviewed by JF Bastien.
2726
2727         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
2728
2729 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2730
2731         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
2732         https://bugs.webkit.org/show_bug.cgi?id=181929
2733
2734         Reviewed by Michael Catanzaro.
2735
2736         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
2737         the website data completion callback is not called immediately, and a new file is created when the operation
2738         finishes. We need to check that the file was removing after calling clear.
2739
2740         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2741         (fileChangedCallback):
2742         (testWebsiteDataResourceLoadStatistics):
2743
2744 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2745
2746         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
2747
2748         * TestWebKitAPI/glib/TestExpectations.json:
2749
2750 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2751
2752         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
2753
2754         Partially revert r226782, the fix was wrong for the GLib version we currently use.
2755
2756         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2757         (testWebKitConsoleMessageNetworkError):
2758
2759 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2760
2761         Unreviewed. Remove unused verbose mode from GLib API tests runner.
2762
2763         * glib/api_test_runner.py:
2764         (add_options):
2765
2766 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2767
2768         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
2769         https://bugs.webkit.org/show_bug.cgi?id=181918
2770
2771         Reviewed by Tim Horton.
2772
2773         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
2774
2775         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2776
2777 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
2778
2779         Resign NowPlaying status when no media element is eligible
2780         https://bugs.webkit.org/show_bug.cgi?id=181914
2781         <rdar://problem/35294116>
2782
2783         Reviewed by Jer Noble.
2784
2785         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2786         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
2787         (TestWebKitAPI::TEST):
2788         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
2789
2790 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
2791
2792         Fix broken unit-tests after r227192
2793         https://bugs.webkit.org/show_bug.cgi?id=181909
2794
2795         Reviewed by Carlos Garcia Campos.
2796
2797         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2798
2799 2018-01-20  Chris Dumez  <cdumez@apple.com>
2800
2801         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
2802         https://bugs.webkit.org/show_bug.cgi?id=174984
2803         <rdar://problem/33665676>
2804
2805         Reviewed by Alexey Proskuryakov.
2806
2807         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
2808
2809         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2810         (TEST):
2811
2812 2018-01-20  Brian Burg  <bburg@apple.com>
2813
2814         WebDriver: fix some nits that prevent running W3C tests on Mac
2815         https://bugs.webkit.org/show_bug.cgi?id=181864
2816
2817         Reviewed by Carlos Garcia Campos.
2818
2819         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2820         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
2821         as we assume that the property exists later.
2822
2823         (WebDriverW3CWebServer.stop): If the temporary file doesn't
2824         exist for some reason, the remove call will raise and exception.
2825         Gracefully handle the case where the file isn't created due to
2826         a problem/exception that happened elsewhere.
2827
2828 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
2829
2830         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
2831         https://bugs.webkit.org/show_bug.cgi?id=181881
2832
2833         Reviewed by Alexey Proskuryakov.
2834
2835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2836         (BubbleQueueServer):
2837         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2839         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
2840
2841 2018-01-19  Youenn Fablet  <youenn@apple.com>
2842
2843         Do not go to the storage process when registering a service worker client if there is no service worker registered
2844         https://bugs.webkit.org/show_bug.cgi?id=181740
2845         <rdar://problem/36650400>
2846
2847         Reviewed by Chris Dumez.
2848
2849         Add support for internals inside API tests.
2850
2851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2852         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
2853         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
2854         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
2855         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
2856         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
2857         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2858         (setConfigurationInjectedBundlePath):
2859         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
2860
2861 2018-01-19  John Wilander  <wilander@apple.com>
2862
2863         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
2864         https://bugs.webkit.org/show_bug.cgi?id=181822
2865         https://bugs.webkit.org/show_bug.cgi?id=175263
2866         https://bugs.webkit.org/show_bug.cgi?id=178536
2867         https://bugs.webkit.org/show_bug.cgi?id=181223
2868         https://bugs.webkit.org/show_bug.cgi?id=181482
2869         <rdar://problem/33491222>
2870         <rdar://problem/33805293>
2871         <rdar://problem/36332683>
2872         <rdar://problem/36549026>
2873
2874         Reviewed by Alex Christensen.
2875
2876         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2877         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2878         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2879         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2880         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2881         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2882         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2883         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2884
2885 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
2886
2887         run-webkit-tests fails when there is a curly brace in Xcode build output
2888         https://bugs.webkit.org/show_bug.cgi?id=181254
2889         <rdar://problem/36453374>
2890
2891         Reviewed by Daniel Bates.
2892
2893         * Scripts/webkitpy/port/base.py:
2894         (Port._run_script): Encode script output before logging it.
2895
2896 2018-01-19  Chris Dumez  <cdumez@apple.com>
2897
2898         Service worker registrations restored from disk may not be reused when the JS calls register() again
2899         https://bugs.webkit.org/show_bug.cgi?id=181810
2900         <rdar://problem/36591711>
2901
2902         Reviewed by Youenn Fablet.
2903
2904         Add API test coverage.
2905
2906         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2907         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
2908         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
2909
2910 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
2911
2912         Remove El Capitan queues from flakiness dashboard
2913         https://bugs.webkit.org/show_bug.cgi?id=181860
2914
2915         Reviewed by Aakash Jain.
2916
2917         * TestResultServer/static-dashboards/builders.jsonp:
2918
2919 2018-01-19  Keith Miller  <keith_miller@apple.com>
2920
2921         HaveInternalSDK includes should be "#include?"
2922         https://bugs.webkit.org/show_bug.cgi?id=179670
2923
2924         Reviewed by Dan Bernstein.
2925
2926         * MiniBrowser/Configurations/Base.xcconfig:
2927         * MobileMiniBrowser/Configurations/Base.xcconfig:
2928         * TestWebKitAPI/Configurations/Base.xcconfig:
2929         * WebKitTestRunner/Configurations/Base.xcconfig:
2930
2931 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2932
2933         WebDriver: driver environment not passed to pytest when running w3c tests
2934         https://bugs.webkit.org/show_bug.cgi?id=181852
2935
2936         Reviewed by Carlos Alberto Lopez Perez.
2937
2938         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
2939
2940         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2941         (WebDriverW3CExecutor.run):
2942
2943 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2944
2945         [GTK] WebDriver: wayland display no used in wayland bot
2946         https://bugs.webkit.org/show_bug.cgi?id=181851
2947
2948         Reviewed by Carlos Alberto Lopez Perez.
2949
2950         We need to handle the additionalArguments property in the WebDriverTests step.
2951
2952         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2953         (RunWebDriverTests.start):
2954
2955 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2956
2957         [GTK] TERM environment variable is not passed to the test driver.
2958         https://bugs.webkit.org/show_bug.cgi?id=181847
2959
2960         Rubber-stamped by by Carlos Garcia Campos.
2961
2962         * Scripts/webkitpy/port/base.py:
2963         (Port.to.setup_environ_for_server):
2964
2965 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2966
2967         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
2968         https://bugs.webkit.org/show_bug.cgi?id=181844
2969
2970         Reviewed by Carlos Alberto Lopez Perez.
2971
2972         We always try to create the directory where to store the json file, but when the filename is given directly,
2973         like in the bots, the current dir is used.
2974
2975         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2976         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
2977         empty string.
2978
2979 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2980
2981         [GTK] WebDriver tests are running outside the jhbuild env
2982         https://bugs.webkit.org/show_bug.cgi?id=181842
2983
2984         Reviewed by Žan Doberšek.
2985
2986         We need to enter jhbuild env in run-webdriver-tests.
2987
2988         * Scripts/run-webdriver-tests:
2989
2990 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2991
2992         [GTK] Run WebDriver tests in the bots
2993         https://bugs.webkit.org/show_bug.cgi?id=181787
2994
2995         Reviewed by Michael Catanzaro.
2996
2997         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
2998         factory for the GTK port for now.
2999
3000         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3001         (TestFactory.__init__):
3002         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3003         (RunWebDriverTests):
3004         (RunWebDriverTests.start):
3005         (RunWebDriverTests.commandComplete):
3006         (RunWebDriverTests.evaluateCommand):
3007         (RunWebDriverTests.getText):
3008         (RunWebDriverTests.getText2):
3009
3010 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3011
3012         [WinCairo] Pass correct url for http test to test driver.
3013         https://bugs.webkit.org/show_bug.cgi?id=181814
3014
3015         Reviewed by Alex Christensen.
3016
3017         * Scripts/webkitpy/port/driver.py:
3018         (Driver):
3019         (Driver.http_test_path_to_uri):
3020         (Driver.is_secure_path):
3021         (Driver.http_base_url):
3022         (Driver.uri_to_test):
3023
3024 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3025
3026         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
3027
3028         * BuildSlaveSupport/build.webkit.org-config/config.json:
3029
3030 2018-01-18  Dan Bernstein  <mitz@apple.com>
3031
3032         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
3033         https://bugs.webkit.org/show_bug.cgi?id=181803
3034
3035         Reviewed by Tim Horton.
3036
3037         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
3038         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
3039         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
3040         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
3041         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
3042         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3043         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3044         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3045         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
3046           helpers.
3047         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
3048           settings useful for defining settings that depend on the target macOS version.
3049         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
3050         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
3051
3052 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
3053
3054         Remove Opensource El Capitan queues from buildbot
3055         https://bugs.webkit.org/show_bug.cgi?id=181712
3056
3057         Reviewed by Aakash Jain.
3058
3059         * BuildSlaveSupport/build.webkit.org-config/config.json:
3060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3061         (WebKitBuildbot):
3062         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3063
3064 2018-01-18  Chris Dumez  <cdumez@apple.com>
3065
3066         Service Workers restored from persistent storage have 'redundant' state
3067         https://bugs.webkit.org/show_bug.cgi?id=181749
3068         <rdar://problem/36556486>
3069
3070         Reviewed by Youenn Fablet.
3071
3072         Add API test coverage.
3073
3074         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3075         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
3076
3077 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3078
3079         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
3080         https://bugs.webkit.org/show_bug.cgi?id=176796
3081
3082         Reviewed by Chris Fleizach.
3083
3084         Add sanity check that we have a URL before calling g_strstr_len().
3085
3086         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3087         (WTR::AccessibilityUIElement::url):
3088
3089 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3090
3091         Add triggers for Sierra test262 and perf queues
3092         https://bugs.webkit.org/show_bug.cgi?id=181799
3093
3094         Reviewed by Aakash Jain.
3095
3096         * BuildSlaveSupport/build.webkit.org-config/config.json:
3097
3098 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3099
3100         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
3101         https://bugs.webkit.org/show_bug.cgi?id=181783
3102         <rdar://problem/35785445>
3103
3104         Reviewed by Ryosuke Niwa.
3105
3106         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
3107         copying an image contains a relevant title.
3108
3109         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3110         (TestWebKitAPI::TEST):
3111         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3112         * TestWebKitAPI/ios/UIKitSPI.h:
3113
3114 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3115
3116         WebDriver: ignore the driver in selenium test names when getting expectations
3117         https://bugs.webkit.org/show_bug.cgi?id=181738
3118
3119         Reviewed by Carlos Alberto Lopez Perez.
3120
3121         In selenium tests, the driver is added as a parameter to every test which results in tests names like
3122         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
3123         driver name in the test expectations file, so we need to remove it when querying the expectations.
3124
3125         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3126         (TestExpectationsMarker.__init__): Save the param to ignore.
3127         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
3128         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
3129         (run): Pass param to ignore to TestExpectationsMarker().
3130         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3131         (WebDriverSeleniumExecutor.__init__): Save the driver name.
3132         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
3133
3134 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3135
3136         [GTK][WPE] Show unit tests unexpectedly passing in the bots
3137         https://bugs.webkit.org/show_bug.cgi?id=181726
3138
3139         Reviewed by Michael Catanzaro.
3140
3141         Now that we have the info, let's show it also in the bots.
3142
3143         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3144         (RunGLibAPITests.commandComplete):
3145
3146 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
3147
3148         Fix broken unittest after r227048
3149         https://bugs.webkit.org/show_bug.cgi?id=181760
3150
3151         Reviewed by Aakash Jain.
3152
3153
3154 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3155
3156         WEBKIT_FRAMEWORK should not modify file-global include directories
3157         https://bugs.webkit.org/show_bug.cgi?id=181656
3158
3159         Reviewed by Konstantin Tokarev.
3160
3161         * TestWebKitAPI/PlatformWPE.cmake:
3162         * TestWebKitAPI/glib/CMakeLists.txt:
3163
3164 2018-01-17  Alicia Boya García  <aboya@igalia.com>
3165
3166         Unreviewed, mark Alicia as committer in contributors.json
3167
3168         * Scripts/webkitpy/common/config/contributors.json:
3169
3170 2018-01-17  Youenn Fablet  <youenn@apple.com>
3171
3172         Put fetch Request.keepalive behind a runtime flag
3173         https://bugs.webkit.org/show_bug.cgi?id=181592
3174
3175         Reviewed by Chris Dumez.
3176
3177         * DumpRenderTree/mac/DumpRenderTree.mm:
3178         (enableExperimentalFeatures):
3179         * DumpRenderTree/win/DumpRenderTree.cpp:
3180         (enableExperimentalFeatures):
3181         * WebKitTestRunner/TestController.cpp:
3182         (WTR::TestController::resetPreferencesToConsistentValues):
3183
3184 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3185
3186         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
3187         https://bugs.webkit.org/show_bug.cgi?id=181637
3188         <rdar://problem/36508471>
3189
3190         Reviewed by Tim Horton.
3191
3192         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
3193         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
3194
3195         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3196         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3197         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
3198
3199         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
3200         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
3201
3202         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3203         (webViewForTestingAttachments):
3204         (-[TestWKWebView tagsInBody]):
3205         (-[TestWKWebView expectElementTagsInOrder:]):
3206         (-[TestWKWebView expectElementTag:toComeBefore:]):
3207
3208         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
3209         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
3210
3211         (TestWebKitAPI::TEST):
3212         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3213         (WTR::InjectedBundlePage::InjectedBundlePage):
3214
3215 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3216
3217         WebDriver: add support for test expectations
3218         https://bugs.webkit.org/show_bug.cgi?id=180420
3219
3220         Reviewed by Carlos Alberto Lopez Perez.
3221
3222         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
3223
3224         * Scripts/run-webdriver-tests: Get the retval from process_results().
3225         * Scripts/webkitpy/thirdparty/__init__.py:
3226         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
3227         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3228         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
3229         (TestExpectationsMarker.__init__): Initialize expectations.
3230         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
3231         (run): Create and use TestExpectationsMarker plugin.
3232         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3233         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
3234         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3235         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
3236         (WebDriverTestRunner.run): Do not count results here.
3237         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
3238         amount of failures. Printing the test summary while processing results will be made optional in a follow up
3239         patch.
3240         (WebDriverTestRunner.process_results.report): Return the amount of failures.
3241         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3242         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
3243         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
3244         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
3245         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3246         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
3247         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
3248         (WebDriverTestRunnerW3C._scan_directory): Ditto.
3249         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
3250         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
3251         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
3252
3253 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3254
3255         Unreviewed WPE gardening. Mark some known unit test failures.
3256
3257         * TestWebKitAPI/glib/TestExpectations.json:
3258
3259 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3260
3261         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
3262         https://bugs.webkit.org/show_bug.cgi?id=181724
3263
3264         Reviewed by Philippe Normand.
3265
3266         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
3267         reason to use different names. This way we can refer to the same test names for both and we can share the
3268         expectations in the TestExpectations.json file.
3269
3270         * TestWebKitAPI/glib/TestExpectations.json:
3271         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
3272
3273 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3274
3275         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
3276
3277         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
3278         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
3279
3280         * glib/api_test_runner.py:
3281         (TestRunner._run_test_glib):
3282         (TestRunner._run_google_test):
3283
3284 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3285
3286         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
3287         https://bugs.webkit.org/show_bug.cgi?id=179914
3288
3289         Reviewed by Žan Doberšek.
3290
3291         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
3292         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
3293         all symbols listed in the script are present in the library.
3294
3295         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
3296         (bss_symbols):
3297         * Scripts/check-for-invalid-symbols-in-version-script: Added.
3298         (script_symbols):
3299         * Scripts/make-dist:
3300         (Distcheck.build):
3301         (Distcheck):
3302         (Distcheck.check_symbols):
3303         (Distcheck.check):
3304
3305 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3306
3307         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
3308         https://bugs.webkit.org/show_bug.cgi?id=181722
3309
3310         Reviewed by Žan Doberšek.
3311
3312         I forgot to pass the parameters to run() when restarting.
3313
3314         * glib/glib_test_runner.py:
3315         (GLibTestRunner.run):
3316
3317 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
3318
3319         [CMake] Remove WebCoreDerivedSources library target
3320         https://bugs.webkit.org/show_bug.cgi?id=181664
3321
3322         Reviewed by Carlos Garcia Campos.
3323
3324         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
3325         * TestWebKitAPI/PlatformWin.cmake: Ditto.
3326
3327 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
3328
3329         Move Debug Test262, Release Test262 and Performance queues to Sierra
3330         https://bugs.webkit.org/show_bug.cgi?id=181692
3331
3332         Unreviewed
3333
3334 2018-01-16  Zach Li  <zachli@apple.com>
3335
3336         Add pop-up policy support in website policies.
3337         https://bugs.webkit.org/show_bug.cgi?id=181544.
3338         rdar://problem/30521400.
3339
3340         Reviewed by Alex Christensen.
3341
3342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3343         Added pop-up-check.html.
3344
3345         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
3346
3347         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3348         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3349         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3350         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3351         (TEST):
3352
3353 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3354
3355         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
3356         https://bugs.webkit.org/show_bug.cgi?id=181638
3357         <rdar://problem/36508702>
3358
3359         Reviewed by Dan Bernstein.
3360
3361         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
3362         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
3363
3364         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3365         (-[AttachmentUpdateObserver init]):
3366         (-[AttachmentUpdateObserver sourceForIdentifier:]):
3367         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
3368         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
3369         (TestWebKitAPI::TEST):
3370         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
3371
3372 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3373
3374         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
3375
3376         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
3377
3378         * glib/api_test_runner.py:
3379         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
3380         * glib/glib_test_runner.py:
3381         (GLibTestRunner.run): Use given env.
3382
3383 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3384
3385         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
3386         https://bugs.webkit.org/show_bug.cgi?id=181676
3387
3388         Reviewed by Carlos Alberto Lopez Perez.
3389
3390         The option was removed in r226967.
3391
3392         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3393         (RunGtkAPITests):
3394         (RunWPEAPITests):
3395
3396 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3397
3398         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
3399
3400         The bots are still passing that option and the step is failing because it was removed in r226967.
3401
3402         * glib/api_test_runner.py:
3403         (add_options):
3404
3405 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3406
3407         [GTK][WPE] Improve the way glib tests are run
3408         https://bugs.webkit.org/show_bug.cgi?id=181674
3409
3410         Reviewed by Žan Doberšek.
3411
3412         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
3413         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
3414         tests failing due to an expected assert in the test and unexpected crashes.
3415         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
3416         not showing the subtest name in stdout in case of timeouts.
3417         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
3418         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
3419         of every test case.
3420
3421         * glib/api_test_runner.py:
3422         (TestRunner._run_test_glib): Use GLibTestRunner.
3423         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
3424         (add_options):
3425         * glib/glib_test_runner.py: Added.
3426         (TestTimeout):
3427         (Message):
3428         (Message.__init__):
3429         (Message.create):
3430         (Message.create.read_unsigned):
3431         (Message.create.read_double):
3432         (Message.create.read_string):
3433         (GLibTestRunner):
3434         (GLibTestRunner.__init__):
3435         (GLibTestRunner._process_data):
3436         (GLibTestRunner._process_message):
3437         (GLibTestRunner._read_from_pipe):
3438         (GLibTestRunner._read_from_stderr):
3439         (GLibTestRunner._start_timeout):
3440         (GLibTestRunner._start_timeout._alarm_handler):
3441         (GLibTestRunner._stop_timeout):
3442         (GLibTestRunner._subtest_start):
3443         (GLibTestRunner._subtest_message):
3444         (GLibTestRunner._subtest_stderr):
3445         (GLibTestRunner._subtest_end):
3446         (GLibTestRunner.run):
3447
3448 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3449
3450         Unreviewed, add Thibault to contributors.json
3451
3452         It's a bit weird to add someone here before their first contribution, but this affects
3453         Bugzilla autocomplete, and that is serious business.
3454
3455         * Scripts/webkitpy/common/config/contributors.json:
3456
3457 2018-01-15  JF Bastien  <jfbastien@apple.com>
3458
3459         Remove makePoisonedUnique
3460         https://bugs.webkit.org/show_bug.cgi?id=181630
3461         <rdar://problem/36498623>
3462
3463         Reviewed by Mark Lam.
3464
3465         Update tests.
3466
3467         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
3468         (TestWebKitAPI::TEST):
3469         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
3470         (TestWebKitAPI::TEST):
3471
3472 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
3473
3474         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
3475         https://bugs.webkit.org/show_bug.cgi?id=181476
3476
3477         Reviewed by Michael Catanzaro.
3478
3479         Update to xorg-server 1.19.6 which depends on libxfont2, and change
3480         the lists of packages to install libxfont2-devel (or equivalent).
3481
3482         * gtk/install-dependencies:
3483         * gtk/jhbuild.modules:
3484
3485 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3486
3487         [GTK][WPE] Add support for unit test expectations
3488         https://bugs.webkit.org/show_bug.cgi?id=181589
3489
3490         Reviewed by Michael Catanzaro.
3491
3492         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
3493         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
3494         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
3495         script itself is not a good idea either.
3496
3497         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
3498         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
3499         convenient methods to query them.
3500
3501         * Scripts/run-gtk-tests:
3502         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
3503         * Scripts/run-wpe-tests:
3504         (WPETestRunner): Ditto.
3505         * Scripts/webkitpy/common/test_expectations.py: Added.
3506         (TestExpectations):
3507         (TestExpectations.__init__):
3508         (TestExpectations._port_name_for_expected):
3509         (TestExpectations._expected_value):
3510         (TestExpectations.skipped_tests):
3511         (TestExpectations.skipped_subtests):
3512         (TestExpectations._expectation_value):
3513         (TestExpectations.is_slow):
3514         (TestExpectations.get_expectation):
3515         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
3516         (MockTestExpectations):
3517         (MockTestExpectations.__init__):
3518         (MockTestExpectations.is_skip):
3519         (ExpectationsTest):
3520         (assert_exp):
3521         (assert_not_exp):
3522         (assert_bad_exp):
3523         (assert_skip):
3524         (test_basic):
3525         (test_skip):
3526         (test_flaky):
3527         (test_build_type):
3528         * TestWebKitAPI/glib/TestExpectations.json: Added.
3529         * glib/api_test_runner.py:
3530         (TestRunner): Remove SkippedTest implementation.
3531         (TestRunner.__init__): Create a TestExpectations.
3532         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
3533         (TestRunner._should_run_test_program): Ditto.
3534         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
3535         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
3536         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
3537         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
3538         (TestRunner.run_tests.report): Helper to write report to stdout.
3539
3540 2018-01-13  Mark Lam  <mark.lam@apple.com>
3541
3542         Replace all use of ConstExprPoisoned with Poisoned.
3543         https://bugs.webkit.org/show_bug.cgi?id=181542
3544         <rdar://problem/36442138>
3545
3546         Reviewed by JF Bastien.
3547
3548         1. Converted tests to using new uintptr_t& poison type.
3549         2. Added tests for Poisoned comparison operators.
3550
3551         * TestWebKitAPI/CMakeLists.txt:
3552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3553         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
3554         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3555         (TestWebKitAPI::TEST):
3556         (TestWebKitAPI::initializeTestPoison): Deleted.
3557         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
3558         (TestWebKitAPI::TEST):
3559         (TestWebKitAPI::passWithRef):
3560         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
3561         (TestWebKitAPI::TEST):
3562         (TestWebKitAPI::f1):
3563         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
3564         (TestWebKitAPI::TEST):
3565         (TestWebKitAPI::poisonedPtrFoo):
3566         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
3567         (TestWebKitAPI::TEST):
3568         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
3569         (TestWebKitAPI::TEST):
3570
3571 2018-01-13  David Kilzer  <ddkilzer@apple.com>
3572
3573         check-webkit-style: false positive for [whitespace/braces] with os_log format string
3574         <https://webkit.org/b/181606>
3575
3576         Reviewed by Darin Adler.
3577
3578         * Scripts/webkitpy/style/checkers/cpp.py:
3579         (check_spacing): Modify regular expression to ignore
3580         os_log format strings like '%{public}'.
3581         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3582         (CppStyleTest.test_spacing_before_braces): Add os_log
3583         format string test.
3584
3585 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3586
3587         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
3588         https://bugs.webkit.org/show_bug.cgi?id=181626
3589
3590         Reviewed by Joseph Pecoraro.
3591
3592         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
3593         Additionally, write a new API test covering the change in r226915.
3594
3595         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3596         (webViewForTestingAttachments):
3597         (TestWebKitAPI::TEST):
3598
3599 2018-01-12  Alex Christensen  <achristensen@webkit.org>
3600
3601         History state should be updated during client redirects with asynchronous policy decisions
3602         https://bugs.webkit.org/show_bug.cgi?id=181358
3603         <rdar://problem/35547689>
3604
3605         Reviewed by Andy Estes.
3606
3607         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3608         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
3609         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3610         (TEST):
3611
3612 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
3613
3614         webkitpy: Refactor simulator code (Part 4)
3615         https://bugs.webkit.org/show_bug.cgi?id=180555
3616         <rdar://problem/36131381>
3617
3618         Reviewed by Aakash Jain.
3619
3620         Move new_simulated_device.py to simulated_device.py.
3621
3622         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
3623         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
3624         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
3625         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
3626         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
3627
3628 2018-01-12  Alex Christensen  <achristensen@webkit.org>
3629
3630         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
3631         https://bugs.webkit.org/show_bug.cgi?id=181595
3632
3633         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
3634         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
3635         I change the < and > to $ to make this test pass and continue to test what it used to.
3636
3637         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
3638         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3639         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3640