Unreviewed, fix iOS build with recent SDKs.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-20  Chris Dumez  <cdumez@apple.com>
2
3         Unreviewed, fix iOS build with recent SDKs.
4
5         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
6
7 2019-04-19  Keith Miller  <keith_miller@apple.com>
8
9         Add script to merge run_benchmark jsons
10         https://bugs.webkit.org/show_bug.cgi?id=197107
11
12         Reviewed by Michael Saboff.
13
14         The script basically recursively decends through all json objects until it gets
15         to an array or JSON primitive and concats or takes the first value, respectively.
16
17         This patch also adds +x bits to the compare-results script so it
18         can be run directly from the command line. I had to add a new line so that svn
19         will accept the change... yay svn!
20
21         * Scripts/compare-results:
22         * Scripts/merge-result-jsons: Added.
23         (readJSONFile):
24         (deepAppend):
25         (mergeJSONs):
26         (main):
27
28 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
29
30         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
31         https://bugs.webkit.org/show_bug.cgi?id=197079
32
33         Reviewed by Darin Adler.
34
35         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
36
37         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
38         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
39
40 2019-04-18  Commit Queue  <commit-queue@webkit.org>
41
42         Unreviewed, rolling out r244434.
43         https://bugs.webkit.org/show_bug.cgi?id=197089
44
45         caused 1 API test failure (Requested by zalan on #webkit).
46
47         Reverted changeset:
48
49         "Regression (r244291): Broken API Test
50         AutoLayoutRenderingProgressRelativeOrdering"
51         https://bugs.webkit.org/show_bug.cgi?id=196948
52         https://trac.webkit.org/changeset/244434
53
54 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
55
56         Add new compatibility mode API on WKNavigation
57         https://bugs.webkit.org/show_bug.cgi?id=197069
58         <rdar://problem/50025800>
59
60         Reviewed by Tim Horton.
61
62         Add a block property for -didCommitNavigation to TestNavigationDelegate.
63
64         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
65         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
66         (-[TestNavigationDelegate webView:didCommitNavigation:]):
67
68 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
69
70         [CMake] Make WebCore headers copies
71         https://bugs.webkit.org/show_bug.cgi?id=182512
72         <rdar://problem/37510435>
73
74         Reviewed by Alex Christensen.
75
76         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
77         ports.
78
79         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
80         of WebCore headers using "*.h" were modified to <WebCore/*.h>
81
82         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
83         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
84         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
85         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
86         * TestWebKitAPI/CMakeLists.txt:
87         * TestWebKitAPI/PlatformWin.cmake:
88         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
89         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
90         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
91
92 2019-04-18  Jer Noble  <jer.noble@apple.com>
93
94         Add support for parsing FairPlayStreaming PSSH boxes.
95         https://bugs.webkit.org/show_bug.cgi?id=197064
96
97         Reviewed by Eric Carlson.
98
99         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
100         (TestWebKitAPI::TEST):
101
102 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
103
104         InjectedBundle parameters often need initialization function called before unarchiving
105         https://bugs.webkit.org/show_bug.cgi?id=189709
106         <rdar://problem/44573653>
107
108         Reviewed by Ryosuke Niwa.
109
110         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
111         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
112
113 2019-04-18  Zalan Bujtas  <zalan@apple.com>
114
115         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
116         https://bugs.webkit.org/show_bug.cgi?id=196948
117         <rdar://problem/49927131>
118
119         Reviewed by Tim Horton.
120
121         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
122         (TEST): 
123         The expected order of incoming events is
124         1. didInvalidateIntrinsicContentSize
125         2. didFirstLayout
126         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
127         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
128         (and remember, all we care about is ordering).
129
130 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
131
132         Unreviewed, rolling out r244299.
133
134         Breaks internal tests.
135
136         Reverted changeset:
137
138         "InjectedBundle parameters often need initialization function
139         called before unarchiving"
140         https://bugs.webkit.org/show_bug.cgi?id=189709
141         https://trac.webkit.org/changeset/244299
142
143 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
144
145         [WTF] StringBuilder should set correct m_is8Bit flag when merging
146         https://bugs.webkit.org/show_bug.cgi?id=197053
147
148         Reviewed by Saam Barati.
149
150         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
151         (TestWebKitAPI::TEST):
152
153 2019-04-17  Tim Horton  <timothy_horton@apple.com>
154
155         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
156         https://bugs.webkit.org/show_bug.cgi?id=197028
157         <rdar://problem/49985290>
158
159         Reviewed by Wenson Hsieh.
160
161         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
162         (TEST):
163         Liberal application of waitForNextPresentationUpdate works around a race
164         where if the page rapidly changes its viewport arguments (or an API client
165         rapidly changes its viewport arguments), we'd get stuck thinking that the
166         user had intentionally zoomed the page, and stop resetting the initial scale.
167         This deserves a separate bug, but no need to keep the test failing while
168         we think about it.
169
170 2019-04-17  Tim Horton  <timothy_horton@apple.com>
171
172         REGRESSION (r241988): Switching tabs is slow
173         https://bugs.webkit.org/show_bug.cgi?id=197037
174         <rdar://problem/49951473>
175
176         Reviewed by Simon Fraser.
177
178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
179         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
180         (TEST):
181         * TestWebKitAPI/cocoa/TestWKWebView.h:
182         * TestWebKitAPI/cocoa/TestWKWebView.mm:
183         (-[TestWKWebView addToTestWindow]):
184         Add a test that hangs without this fix.
185
186 2019-04-17  Truitt Savell  <tsavell@apple.com>
187
188         Unreviewed, rolling out r244400.
189
190         Caused testing to exit early with assertionon Debug WK2
191
192         Reverted changeset:
193
194         "UI↔Web deadlock when printing with a JavaScript alert
195         visible"
196         https://bugs.webkit.org/show_bug.cgi?id=196839
197         https://trac.webkit.org/changeset/244400
198
199 2019-04-17  Brady Eidson  <beidson@apple.com>
200
201         Link clicks in PDFs shouldn't send referrer headers.
202         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
203
204         Reviewed by Tim Horton.
205
206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
207         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
208         (putPDFBytesCallback):
209         (emptyReleaseInfoCallback):
210         (createPDFWithLinkToURL):
211         (TEST):
212
213 2019-04-17  Tim Horton  <timothy_horton@apple.com>
214
215         UI↔Web deadlock when printing with a JavaScript alert visible
216         https://bugs.webkit.org/show_bug.cgi?id=196839
217         <rdar://problem/49157642>
218
219         Reviewed by Andy Estes.
220
221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
222         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
223         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
224         (TEST):
225
226 2019-04-17  Alex Christensen  <achristensen@webkit.org>
227
228         WKRetainPtr's adoption constructor should be private
229         https://bugs.webkit.org/show_bug.cgi?id=197019
230
231         Reviewed by Tim Horton.
232
233         * DumpRenderTree/mac/DumpRenderTree.mm:
234         (dumpFramesAsText):
235         * TestWebKitAPI/InjectedBundleController.cpp:
236         (TestWebKitAPI::InjectedBundleController::initialize):
237         * TestWebKitAPI/PlatformUtilities.cpp:
238         (TestWebKitAPI::Util::createContextWithInjectedBundle):
239         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
240         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
241         (TestWebKitAPI::Util::toWK):
242         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
243         (TestWebKitAPI::TEST):
244         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
245         (TestWebKitAPI::TEST):
246         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
247         (TestWebKitAPI::TEST):
248         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
249         (TestWebKitAPI::TEST):
250         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
251         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
252         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
253         (TestWebKitAPI::TEST):
254         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
255         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
256         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
257         (TestWebKitAPI::TEST):
258         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
259         (TestWebKitAPI::TEST):
260         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
261         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
262         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
263         (TestWebKitAPI::TEST):
264         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
265         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
266         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
267         (TestWebKitAPI::TEST):
268         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
269         (TestWebKitAPI::TEST):
270         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
271         (TestWebKitAPI::TEST):
272         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
273         (TestWebKitAPI::TEST):
274         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
275         (TestWebKitAPI::TEST):
276         * TestWebKitAPI/Tests/WebKit/Find.cpp:
277         (TestWebKitAPI::TEST):
278         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
279         (TestWebKitAPI::TEST):
280         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
281         (TestWebKitAPI::TEST):
282         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
283         (TestWebKitAPI::TEST):
284         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
285         (TestWebKitAPI::TEST):
286         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
287         (TestWebKitAPI::TEST):
288         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
289         (TestWebKitAPI::TEST):
290         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
291         (TestWebKitAPI::TEST):
292         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
293         (TestWebKitAPI::TEST):
294         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
295         (TestWebKitAPI::TEST):
296         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
297         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
298         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
299         (TestWebKitAPI::TEST):
300         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
301         (TestWebKitAPI::TEST):
302         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
303         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
304         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
305         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
306         (TestWebKitAPI::TEST):
307         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
308         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
309         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
310         (TestWebKitAPI::TEST):
311         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
312         (TestWebKitAPI::TEST):
313         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
314         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
315         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
316         (TestWebKitAPI::TEST):
317         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
318         (TestWebKitAPI::loadAlternateHTMLString):
319         (TestWebKitAPI::TEST):
320         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
321         (TestWebKitAPI::TEST):
322         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
323         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
324         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
325         (TestWebKitAPI::buildAndPerformTest):
326         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
327         (TestWebKitAPI::TEST):
328         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
329         (TestWebKitAPI::TEST):
330         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
331         (TestWebKitAPI::TEST):
332         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
333         (TestWebKitAPI::TEST):
334         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
335         (TestWebKitAPI::TEST):
336         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
337         (TestWebKitAPI::TEST):
338         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
339         (TestWebKitAPI::TEST):
340         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
341         (TestWebKitAPI::TEST):
342         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
343         (TestWebKitAPI::TEST):
344         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
345         (TestWebKitAPI::TEST):
346         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
347         (TestWebKitAPI::TEST):
348         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
349         (TestWebKitAPI::TEST):
350         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
351         (TestWebKitAPI::TEST):
352         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
353         (TestWebKitAPI::TEST):
354         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
355         (TestWebKitAPI::TEST):
356         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
357         (TestWebKitAPI::TEST):
358         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
359         (TestWebKitAPI::TEST):
360         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
361         (TestWebKitAPI::TEST):
362         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
363         (TestWebKitAPI::TEST):
364         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
365         (TestWebKitAPI::TEST):
366         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
367         (TestWebKitAPI::TEST):
368         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
369         (TestWebKitAPI::TEST):
370         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
371         (TestWebKitAPI::TEST):
372         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
373         (TestWebKitAPI::TEST):
374         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
375         (TestWebKitAPI::TEST):
376         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
377         (TestWebKitAPI::TEST):
378         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
379         (TestWebKitAPI::TEST):
380         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
381         (TestWebKitAPI::TEST):
382         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
383         (TestWebKitAPI::TEST):
384         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
385         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
386         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
387         (TestWebKitAPI::TEST):
388         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
389         (TestWebKitAPI::TEST):
390         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
391         (TestWebKitAPI::TEST):
392         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
393         (TestWebKitAPI::TEST):
394         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
395         (TestWebKitAPI::TEST):
396         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
397         (TestWebKitAPI::TEST):
398         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
399         (TestWebKitAPI::TEST):
400         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
401         (TestWebKitAPI::TEST):
402         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
403         (TestWebKitAPI::TEST):
404         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
405         (TestWebKitAPI::TEST):
406         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
407         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
408         (TEST):
409         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
410         (TEST):
411         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
412         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
413         (TEST):
414         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
415         (TestWebKitAPI::TEST):
416         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
417         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
418         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
419         (WTR::getMenuItemTitleCallback):
420         (WTR::createMouseMessageBody):
421         (WTR::EventSendingController::mouseDown):
422         (WTR::EventSendingController::mouseUp):
423         (WTR::EventSendingController::mouseMoveTo):
424         (WTR::EventSendingController::mouseForceClick):
425         (WTR::EventSendingController::startAndCancelMouseForceClick):
426         (WTR::EventSendingController::mouseForceDown):
427         (WTR::EventSendingController::mouseForceUp):
428         (WTR::EventSendingController::mouseForceChanged):
429         (WTR::EventSendingController::leapForward):
430         (WTR::EventSendingController::scheduleAsynchronousClick):
431         (WTR::createKeyDownMessageBody):
432         (WTR::EventSendingController::keyDown):
433         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
434         (WTR::EventSendingController::mouseScrollBy):
435         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
436         (WTR::EventSendingController::continuousMouseScrollBy):
437         (WTR::EventSendingController::addTouchPoint):
438         (WTR::EventSendingController::updateTouchPoint):
439         (WTR::EventSendingController::setTouchModifier):
440         (WTR::EventSendingController::setTouchPointRadius):
441         (WTR::EventSendingController::touchStart):
442         (WTR::EventSendingController::touchMove):
443         (WTR::EventSendingController::touchEnd):
444         (WTR::EventSendingController::touchCancel):
445         (WTR::EventSendingController::clearTouchPoints):
446         (WTR::EventSendingController::releaseTouchPoint):
447         (WTR::EventSendingController::cancelTouchPoint):
448         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
449         (WTR::InjectedBundle::didCreatePage):
450         (WTR::InjectedBundle::didReceiveMessage):
451         (WTR::InjectedBundle::didReceiveMessageToPage):
452         (WTR::InjectedBundle::booleanForKey):
453         (WTR::InjectedBundle::done):
454         (WTR::InjectedBundle::dumpToStdErr):
455         (WTR::InjectedBundle::outputText):
456         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
457         (WTR::InjectedBundle::postAddChromeInputField):
458         (WTR::InjectedBundle::postRemoveChromeInputField):
459         (WTR::InjectedBundle::postFocusWebView):
460         (WTR::InjectedBundle::postSetBackingScaleFactor):
461         (WTR::InjectedBundle::postSetWindowIsKey):
462         (WTR::InjectedBundle::postSetViewSize):
463         (WTR::InjectedBundle::postSimulateWebNotificationClick):
464         (WTR::InjectedBundle::postSetAddsVisitedLinks):
465         (WTR::InjectedBundle::setGeolocationPermission):
466         (WTR::InjectedBundle::setMockGeolocationPosition):
467         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
468         (WTR::InjectedBundle::isGeolocationProviderActive const):
469         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
470         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
471         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
472         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
473         (WTR::InjectedBundle::setCustomPolicyDelegate):
474         (WTR::InjectedBundle::setHidden):
475         (WTR::InjectedBundle::setCacheModel):
476         (WTR::InjectedBundle::shouldProcessWorkQueue const):
477         (WTR::InjectedBundle::processWorkQueue):
478         (WTR::InjectedBundle::queueBackNavigation):
479         (WTR::InjectedBundle::queueForwardNavigation):
480         (WTR::InjectedBundle::queueLoad):
481         (WTR::InjectedBundle::queueLoadHTMLString):
482         (WTR::InjectedBundle::queueReload):
483         (WTR::InjectedBundle::queueLoadingScript):
484         (WTR::InjectedBundle::queueNonLoadingScript):
485         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
486         (WTR::frameToStr):
487         (WTR::InjectedBundlePage::InjectedBundlePage):
488         (WTR::dumpFrameDescriptionSuitableForTestResult):
489         (WTR::dumpFrameScrollPosition):
490         (WTR::dumpDescendantFrameScrollPositions):
491         (WTR::dumpFrameText):
492         (WTR::dumpDescendantFramesText):
493         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
494         (WTR::TestRunner::shouldDumpPixels const):
495         (WTR::TestRunner::setDumpPixels):
496         (WTR::TestRunner::whatToDump const):
497         (WTR::TestRunner::setWhatToDump):
498         (WTR::TestRunner::setWaitUntilDone):
499         (WTR::TestRunner::shouldWaitUntilDone const):
500         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
501         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
502         (WTR::TestRunner::clearAllDatabases):
503         (WTR::TestRunner::setIDBPerOriginQuota):
504         (WTR::TestRunner::originsWithApplicationCache):
505         (WTR::TestRunner::setCanOpenWindows):
506         (WTR::TestRunner::setXSSAuditorEnabled):
507         (WTR::TestRunner::setMediaDevicesEnabled):
508         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
509         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
510         (WTR::TestRunner::setCustomUserAgent):
511         (WTR::TestRunner::setWebAPIStatisticsEnabled):
512         (WTR::TestRunner::setModernMediaControlsEnabled):
513         (WTR::TestRunner::setWebGL2Enabled):
514         (WTR::TestRunner::setWritableStreamAPIEnabled):
515         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
516         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
517         (WTR::TestRunner::setAllowsAnySSLCertificate):
518         (WTR::TestRunner::setPluginsEnabled):
519         (WTR::TestRunner::setValueForUser):
520         (WTR::TestRunner::setAudioResult):
521         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
522         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
523         (WTR::TestRunner::setAlwaysAcceptCookies):
524         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
525         (WTR::TestRunner::isDoingMediaCapture const):
526         (WTR::TestRunner::queueLoad):
527         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
528         (WTR::TestRunner::setHandlesAuthenticationChallenges):
529         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
530         (WTR::TestRunner::setShouldLogDownloadCallbacks):
531         (WTR::TestRunner::setAuthenticationUsername):
532         (WTR::TestRunner::setAuthenticationPassword):
533         (WTR::TestRunner::secureEventInputIsEnabled const):
534         (WTR::TestRunner::setBlockAllPlugins):
535         (WTR::TestRunner::setPluginSupportedMode):
536         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
537         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
538         (WTR::TestRunner::setNavigationGesturesEnabled):
539         (WTR::TestRunner::setIgnoresViewportScaleLimits):
540         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
541         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
542         (WTR::TestRunner::terminateNetworkProcess):
543         (WTR::TestRunner::terminateServiceWorkerProcess):
544         (WTR::TestRunner::runUIScript):
545         (WTR::TestRunner::setStatisticsDebugMode):
546         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
547         (WTR::TestRunner::setStatisticsLastSeen):
548         (WTR::TestRunner::setStatisticsPrevalentResource):
549         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
550         (WTR::TestRunner::dumpResourceLoadStatistics):
551         (WTR::TestRunner::isStatisticsPrevalentResource):
552         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
553         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
554         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
555         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
556         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
557         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
558         (WTR::TestRunner::setStatisticsGrandfathered):
559         (WTR::TestRunner::isStatisticsGrandfathered):
560         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
561         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
562         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
563         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
564         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
565         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
566         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
567         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
568         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
569         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
570         (WTR::TestRunner::statisticsUpdateCookieBlocking):
571         (WTR::TestRunner::statisticsSubmitTelemetry):
572         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
573         (WTR::TestRunner::setStatisticsIsRunningTest):
574         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
575         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
576         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
577         (WTR::TestRunner::setStatisticsGrandfatheringTime):
578         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
579         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
580         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
581         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
582         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
583         (WTR::TestRunner::statisticsDeleteCookiesForHost):
584         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
585         (WTR::TestRunner::statisticsResetToConsistentState):
586         (WTR::TestRunner::setStorageAccessAPIEnabled):
587         (WTR::TestRunner::getAllStorageAccessEntries):
588         (WTR::TestRunner::addMockMediaDevice):
589         (WTR::TestRunner::clearMockMediaDevices):
590         (WTR::TestRunner::removeMockMediaDevice):
591         (WTR::TestRunner::resetMockMediaDevices):
592         (WTR::TestRunner::connectMockGamepad):
593         (WTR::TestRunner::disconnectMockGamepad):
594         (WTR::TestRunner::setMockGamepadDetails):
595         (WTR::TestRunner::setMockGamepadAxisValue):
596         (WTR::TestRunner::setMockGamepadButtonValue):
597         (WTR::TestRunner::removeAllSessionCredentials):
598         (WTR::TestRunner::clearDOMCache):
599         (WTR::TestRunner::clearDOMCaches):
600         (WTR::TestRunner::hasDOMCache):
601         (WTR::TestRunner::domCacheSize):
602         (WTR::TestRunner::setAllowStorageQuotaIncrease):
603         (WTR::TestRunner::getApplicationManifestThen):
604         (WTR::TestRunner::injectUserScript):
605         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
606         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
607         (WTR::TestRunner::addTestKeyToKeychain):
608         (WTR::TestRunner::cleanUpKeychain):
609         (WTR::TestRunner::keyExistsInKeychain):
610         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
611         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
612         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
613         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
614         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
615         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
616         * WebKitTestRunner/TestController.cpp:
617         (WTR::TestController::initialize):
618         (WTR::parseStringTestHeaderValueAsRelativePath):
619         (WTR::updateTestOptionsFromTestHeader):
620         (WTR::TestController::runTest):
621         (WTR::TestController::didReceiveLiveDocumentsList):
622         (WTR::TestController::didReceiveMessageFromInjectedBundle):
623         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
624         (WTR::TestController::didFinishNavigation):
625         (WTR::TestController::didReceiveAuthenticationChallenge):
626         * WebKitTestRunner/TestInvocation.cpp:
627         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
628         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
629         (WTR::TestInvocation::uiScriptDidComplete):
630         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
631         * WebKitTestRunner/WebNotificationProvider.cpp:
632         (WTR::WebNotificationProvider::closeWebNotification):
633         * WebKitTestRunner/WorkQueueManager.cpp:
634         (WTR::ScriptItem::ScriptItem):
635         (WTR::WorkQueueManager::queueLoad):
636         (WTR::WorkQueueManager::queueLoadHTMLString):
637
638 2019-04-17  Alex Christensen  <achristensen@webkit.org>
639
640         Add a comment to make my test from r244139 less mysterious.
641         https://bugs.webkit.org/show_bug.cgi?id=196744
642
643         As suggested by Darin Adler.
644
645         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
646         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
647
648 2019-04-17  Chris Dumez  <cdumez@apple.com>
649
650         Remember device orientation permission for the duration of the browsing session
651         https://bugs.webkit.org/show_bug.cgi?id=196992
652         <rdar://problem/49946067>
653
654         Reviewed by Alex Christensen.
655
656         Add API test coverage.
657
658         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
659         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
660         (TEST):
661
662 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
663
664         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
665         https://bugs.webkit.org/show_bug.cgi?id=196675
666
667         Reviewed by Lucas Forschler.
668
669         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
670         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
671
672 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
673
674         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
675         https://bugs.webkit.org/show_bug.cgi?id=196919
676         <rdar://problem/41630459>
677
678         Reviewed by Tim Horton.
679
680         Add iOS support for several new testing hooks. See below for more detail.
681
682         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
683         (WTR::UIScriptController::isDismissingMenu const):
684
685         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
686         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
687         by UIKit when dismissing the callout bar (i.e. UIMenuController).
688
689         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
690         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
691         (WTR::UIScriptController::isDismissingMenu const):
692         * TestRunnerShared/UIScriptContext/UIScriptController.h:
693         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
694         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
695         (WTR::InjectedBundle::didReceiveMessageToPage):
696         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
697         (WTR::TestRunner::setAllowedMenuActions):
698
699         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
700         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
701         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
702         against the name of the custom action.
703
704         (WTR::TestRunner::installCustomMenuAction):
705
706         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
707         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
708         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
709         triggered.
710
711         (WTR::TestRunner::performCustomMenuAction):
712
713         Invoked when the custom menu action is triggered.
714
715         * WebKitTestRunner/InjectedBundle/TestRunner.h:
716         * WebKitTestRunner/TestController.cpp:
717         (WTR::TestController::installCustomMenuAction):
718         (WTR::TestController::setAllowedMenuActions):
719         * WebKitTestRunner/TestController.h:
720         * WebKitTestRunner/TestInvocation.cpp:
721         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
722         (WTR::TestInvocation::performCustomMenuAction):
723
724         Add plumbing to call back into the injected bundle when performing the custom action.
725
726         * WebKitTestRunner/TestInvocation.h:
727         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
728         (WTR::TestController::installCustomMenuAction):
729         (WTR::TestController::setAllowedMenuActions):
730         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
731         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
732         (-[TestRunnerWKWebView initWithFrame:configuration:]):
733         (-[TestRunnerWKWebView becomeFirstResponder]):
734         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
735
736         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
737         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
738         in the Mail app on iOS.
739
740         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
741         (-[TestRunnerWKWebView setAllowedMenuActions:]):
742         (-[TestRunnerWKWebView resetCustomMenuAction]):
743         (-[TestRunnerWKWebView performCustomAction:]):
744         (-[TestRunnerWKWebView canPerformAction:withSender:]):
745         (-[TestRunnerWKWebView _willHideMenu]):
746         (-[TestRunnerWKWebView _didHideMenu]):
747         * WebKitTestRunner/ios/TestControllerIOS.mm:
748         (WTR::TestController::platformResetStateToConsistentValues):
749
750         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
751         if specified.
752
753         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
754         (WTR::UIScriptController::isDismissingMenu const):
755
756 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
757
758         Allow sharing from imageSheet on an image document
759         https://bugs.webkit.org/show_bug.cgi?id=196891
760         <rdar://problem/25377386>
761
762         Reviewed by Tim Horton.
763
764         Test to make sure that the correct imageURL is extracted from an image element.
765
766         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
767         (TestWebKitAPI::TEST):
768
769 2019-04-16  Alex Christensen  <achristensen@webkit.org>
770
771         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
772         https://bugs.webkit.org/show_bug.cgi?id=196995
773
774         Reviewed by Brady Eidson.
775
776         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
777         (TEST):
778
779 2019-04-16  Chris Dumez  <cdumez@apple.com>
780
781         URL set by document.open() is not communicated to the UIProcess
782         https://bugs.webkit.org/show_bug.cgi?id=196941
783         <rdar://problem/49237544>
784
785         Reviewed by Geoff Garen.
786
787         Add API test coverage.
788
789         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
790         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
791         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
792         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
793         (TEST):
794
795 2019-04-16  Commit Queue  <commit-queue@webkit.org>
796
797         Unreviewed, rolling out r244321.
798         https://bugs.webkit.org/show_bug.cgi?id=196968
799
800         Causing all WK2 Debug builds to exit early after Assertion
801         failures. (Requested by ShawnRoberts on #webkit).
802
803         Reverted changeset:
804
805         "URL set by document.open() is not communicated to the
806         UIProcess"
807         https://bugs.webkit.org/show_bug.cgi?id=196941
808         https://trac.webkit.org/changeset/244321
809
810 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
811
812         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
813         https://bugs.webkit.org/show_bug.cgi?id=196948
814
815         Reviewed by Zalan Bujtas.
816
817         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
818         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
819
820 2019-04-15  Chris Dumez  <cdumez@apple.com>
821
822         URL set by document.open() is not communicated to the UIProcess
823         https://bugs.webkit.org/show_bug.cgi?id=196941
824         <rdar://problem/49237544>
825
826         Reviewed by Geoffrey Garen.
827
828         Add API test coverage.
829
830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
831         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
832         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
833         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
834         (TEST):
835
836 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
837
838         Using Tools/Scripts/clean-webkit should not install requests
839         https://bugs.webkit.org/show_bug.cgi?id=196940
840
841         Reviewed by Lucas Forschler.
842
843         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
844         existing, depending on the path autoinstalled is run through.
845         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
846         needed.
847         (Port.configuration_for_upload):
848         (Port.commits_for_upload):
849
850 2019-04-15  Alex Christensen  <achristensen@webkit.org>
851
852         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
853         https://bugs.webkit.org/show_bug.cgi?id=196773
854
855         Reviewed by Jer Noble.
856
857         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
858         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
859         (TEST):
860
861 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
862
863         ews-build should clearly indicate flaky test failures
864         https://bugs.webkit.org/show_bug.cgi?id=196947
865
866         Reviewed by Lucas Forschler.
867
868         * BuildSlaveSupport/ews-build/steps.py:
869         (AnalyzeAPITestsResults.analyzeResults):
870
871 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
872
873         InjectedBundle parameters often need initialization function called before unarchiving
874         https://bugs.webkit.org/show_bug.cgi?id=189709
875         <rdar://problem/44573653>
876
877         Reviewed by Ryosuke Niwa.
878
879         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
880         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
881
882 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
883
884         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
885         https://bugs.webkit.org/show_bug.cgi?id=196681
886
887         Reviewed by Darin Adler.
888
889         Added tests.
890
891         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
892         (WTF_HashSet.RemoveIf):
893         (WTF_HashSet.RemoveIfShrinkToBestSize):
894
895 2019-04-15  John Wilander  <wilander@apple.com>
896
897         Send delayed Ad Click Attribution conversion requests to the click source
898         https://bugs.webkit.org/show_bug.cgi?id=196838
899         <rdar://problem/47650157>
900
901         Reviewed by Chris Dumez and Youenn Fablet.
902
903         This patch adds test infrastructure to override the default behavior in
904         WebKit::NetworkAdClickAttribution.
905
906         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
907         (TestWebKitAPI::TEST):
908         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
909         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
910         (WTR::TestRunner::dumpAdClickAttribution):
911         (WTR::TestRunner::clearAdClickAttribution):
912         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
913         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
914         * WebKitTestRunner/InjectedBundle/TestRunner.h:
915         * WebKitTestRunner/TestController.cpp:
916         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
917         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
918         * WebKitTestRunner/TestController.h:
919         * WebKitTestRunner/TestInvocation.cpp:
920         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
921
922 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
923
924         [ews-app] status-bubble should display position in queue
925         https://bugs.webkit.org/show_bug.cgi?id=196607
926
927         Reviewed by Lucas Forschler.
928
929         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
930         (StatusBubble._build_bubble):
931         (StatusBubble._queue_position): Method to calculate patch's position in queue.
932
933 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
934
935         [ews-build] Do not run clean build by default on EWS builders
936         https://bugs.webkit.org/show_bug.cgi?id=196897
937
938         Reviewed by Lucas Forschler.
939
940         * BuildSlaveSupport/ews-build/steps.py:
941         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
942         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
943         untracked directories like WebKitBuild).
944         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
945         untracked files/directories (like WebKitBuild).
946
947 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
948
949         TestRunner::notifyDone() should be safely reentrant
950         https://bugs.webkit.org/show_bug.cgi?id=196898
951
952         Reviewed by Darin Adler.
953
954         It is currently possible that TestRunner::notifyDone() will call itself, since
955         notifyDone() will force a repaint, which can start executing JavaScript, which
956         may call notifyDone() again. This can lead to test failures and flakiness.
957         Fix this by setting the m_waitToDump flag before calling the dump() method.
958
959         * DumpRenderTree/mac/TestRunnerMac.mm:
960         (TestRunner::notifyDone):
961         (TestRunner::forceImmediateCompletion):
962         * DumpRenderTree/win/TestRunnerWin.cpp:
963         (TestRunner::notifyDone):
964         (TestRunner::forceImmediateCompletion):
965
966 2019-04-15  Philippe Normand  <pnormand@igalia.com>
967
968         [GTK][WPE] Add enable-media websetting
969         https://bugs.webkit.org/show_bug.cgi?id=196863
970
971         Reviewed by Michael Catanzaro.
972
973         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
974         (testWebKitSettings): Add test for the enable-media web-setting.
975
976 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
977
978         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
979         https://bugs.webkit.org/show_bug.cgi?id=196905
980         <rdar://problem/49886096>
981
982         Reviewed by Tim Horton.
983
984         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
985         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
986         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
987         delay timer, we end up with this sequence of events in the problematic (failure) case:
988
989         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
990             ...IPC from UI to web process...
991         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
992             ...IPC from web to UI process...
993         (c) [UI]    Invoke completion handler for script #1
994         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
995             ...IPC from UI to web process...
996         (e) [Web]   Evaluate script #2 in the web process
997         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
998
999         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1000         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1001         #2 is run in step (e).
1002
1003         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1004         the UI process by waiting on a script message posted by the web process, after attachment updates are
1005         dispatched.
1006
1007         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1008         (TestWebKitAPI::TEST):
1009
1010 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1011
1012         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1013         https://bugs.webkit.org/show_bug.cgi?id=196909
1014
1015         Reviewed by Wenson Hsieh.
1016
1017         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1018         (TestWebKitAPI::TEST):
1019
1020 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1021
1022         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1023         https://bugs.webkit.org/show_bug.cgi?id=196880
1024
1025         Reviewed by Yusuke Suzuki.
1026
1027         Add a new function for bytecode cache tests that does not forceDiskCache
1028         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1029         test added in this patch, since the code is invalid and therefore won't be
1030         cached. It should also be useful for tests that evaluate dynamically
1031         generated code.
1032
1033         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1034         * Scripts/run-jsc-stress-tests:
1035
1036 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1037
1038         Update AudioSession route sharing policy
1039         https://bugs.webkit.org/show_bug.cgi?id=196776
1040         <rdar://problem/46501611>
1041
1042         Reviewed by Jer Noble.
1043
1044         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1045         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1046         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1047         (TestWebKitAPI::TEST):
1048
1049 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1050
1051         [iOS] Software keyboard is shown too frequently on some websites
1052         https://bugs.webkit.org/show_bug.cgi?id=195856
1053         <rdar://problem/49191395>
1054
1055         Reviewed by Darin Adler.
1056
1057         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1058
1059         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1060         (WTR::UIScriptController::setHardwareKeyboardAttached):
1061         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1062         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1063         (WTR::UIScriptController::setHardwareKeyboardAttached):
1064         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1065         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1066
1067         Additionally link against GraphicsServices in WebKitTestRunner.
1068
1069         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1070         (WTR::TestController::platformResetStateToConsistentValues):
1071         (WTR::UIScriptController::setHardwareKeyboardAttached):
1072
1073 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1074
1075         [GTK][WPE] Fix pacman install-dependencies packages
1076         https://bugs.webkit.org/show_bug.cgi?id=196817
1077
1078         Reviewed by Žan Doberšek.
1079         
1080         python3-setuptools is called python-setuptools
1081         ruby-highline is only available on AUR
1082         libv4l-devel is incorporated in v4l-utils
1083
1084         * gtk/install-dependencies:
1085         * wpe/install-dependencies:
1086
1087 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1088
1089         [GTK] REGRESSION(r243860): Many tests failing
1090         https://bugs.webkit.org/show_bug.cgi?id=196791
1091
1092         Reviewed by Joanmarie Diggs.
1093
1094         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1095         multiple documents and check that accessibility hierarchy is updated after a navigation.
1096
1097         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1098         (loadChangedCallback):
1099         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1100         (AccessibilityTest::AccessibilityTest):
1101         (AccessibilityTest::~AccessibilityTest):
1102         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1103         (AccessibilityTest::findTestServerApplication):
1104         (AccessibilityTest::findDocumentWeb):
1105         (AccessibilityTest::findRootObject):
1106         (AccessibilityTest::waitUntilChildrenRemoved):
1107         (AccessibilityTest::ensureProxy):
1108         (testAtspiBasicHierarchy):
1109         (beforeAll):
1110         (afterAll):
1111
1112 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1113
1114         [ews-build] Handle bug titles with unicode characters
1115         https://bugs.webkit.org/show_bug.cgi?id=196802
1116
1117         Reviewed by Dewei Zhu.
1118
1119         * BuildSlaveSupport/ews-build/steps.py:
1120         (ValidatePatch._is_bug_closed):
1121
1122 2019-04-11  Michael Saboff  <msaboff@apple.com>
1123
1124         Improve the Inline Cache Stats code
1125         https://bugs.webkit.org/show_bug.cgi?id=196836
1126
1127         Reviewed by Saam Barati.
1128
1129         Added a new script to consolidate and arrange the output of --useICStats option.
1130
1131         This script merges the output from every group into one large table and sorts it from most common to
1132         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1133         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1134         Put together, this is useful to see what property accesses are not getting cached.
1135
1136         * Scripts/ic-stats.py: Added.
1137         (ICStats):
1138         (ICStats.__init__):
1139         (ICStats.parse):
1140         (ICStats.dumpStats):
1141         (usage):
1142
1143 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1144
1145         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1146         https://bugs.webkit.org/show_bug.cgi?id=196809
1147         <rdar://49800762>
1148
1149         Reviewed by Brady Eidson.
1150
1151         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1152         (TEST):
1153
1154 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1155
1156         requestAnimationFrame should execute before the next frame
1157         https://bugs.webkit.org/show_bug.cgi?id=177484
1158
1159         Reviewed by Simon Fraser.
1160
1161         Add trace points for the page RenderingUpdate.
1162
1163         * Tracing/SystemTracePoints.plist:
1164
1165 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1166
1167         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1168         https://bugs.webkit.org/show_bug.cgi?id=196760
1169
1170         Reviewed by Don Olmstead.
1171
1172         vswhere.exe has been bundled since Visual Studio 2017 version
1173         15.2. We shouldn't download vswhere.exe.
1174
1175         * Scripts/build-jsc: Do not call update-vswhere.py.
1176         * Scripts/build-webkit: Ditto.
1177         * Scripts/update-vswhere.py: Removed.
1178         * Scripts/webkitdirs.pm:
1179         (requireModulesForVSWhere): Deleted.
1180         (pickCurrentVisualStudioInstallation): Deleted.
1181         (visualStudioInstallDirVSWhere): Return the latest installed VS
1182         installation path by using the bundled vswhere.exe.
1183         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1184         (visualStudioInstallDirFallback): Removed.
1185
1186 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1187
1188         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1189         https://bugs.webkit.org/show_bug.cgi?id=196780
1190
1191         Reviewed by Alexey Proskuryakov.
1192
1193         * BuildSlaveSupport/ews-build/steps.py:
1194         * BuildSlaveSupport/ews-build/steps_unittest.py:
1195
1196 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1197
1198         Add SPI WKNavigationResponse._downloadAttribute
1199         https://bugs.webkit.org/show_bug.cgi?id=196755
1200         <rdar://49587365>
1201
1202         Reviewed by Brady Eidson.
1203
1204         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1205         (-[NavigationResponseTestDelegate navigationResponse]):
1206         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1207         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1208         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1209         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1210         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1211         (readRequest):
1212         (writeResponse):
1213         (TEST):
1214
1215 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1216
1217         Add modern API for overriding the page's specified viewport configuration
1218         https://bugs.webkit.org/show_bug.cgi?id=167734
1219         <rdar://problem/30331795>
1220
1221         Reviewed by Simon Fraser.
1222
1223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1224         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1225
1226 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1227
1228         Add support for incremental bytecode cache updates
1229         https://bugs.webkit.org/show_bug.cgi?id=195000
1230
1231         Reviewed by Filip Pizlo.
1232
1233         Exit when the initial run to generate bytecode fails.
1234
1235         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1236
1237 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1238
1239         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1240         https://bugs.webkit.org/show_bug.cgi?id=196744
1241         <rdar://49415309>
1242
1243         Reviewed by Chris Dumez.
1244
1245         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1246         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1247
1248 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1249
1250         Add a way to opt into modern compatibility mode in layout tests
1251         https://bugs.webkit.org/show_bug.cgi?id=196770
1252         <rdar://problem/49777550>
1253
1254         Reviewed by Antoine Quint.
1255
1256         Add a new test option to enable modern compatibility mode in layout tests.
1257
1258         * WebKitTestRunner/TestController.cpp:
1259         (WTR::updateTestOptionsFromTestHeader):
1260         * WebKitTestRunner/TestController.h:
1261         * WebKitTestRunner/TestOptions.h:
1262         (WTR::TestOptions::hasSameInitializationOptions const):
1263         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1264         (WTR::TestController::platformCreateWebView):
1265         (WTR::TestController::enableModernCompatibilityMode):
1266
1267 2019-04-10  Andy Estes  <aestes@apple.com>
1268
1269         Try to fix the 32-bit watchOS build.
1270
1271         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1272         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1273
1274 2019-04-10  Antoine Quint  <graouts@apple.com>
1275
1276         Enable Pointer Events on watchOS
1277         https://bugs.webkit.org/show_bug.cgi?id=196771
1278         <rdar://problem/49040909>
1279
1280         Reviewed by Dean Jackson.
1281
1282         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1283
1284 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1285
1286         Unreviewed. Fix WPE accessibility tests after r244059.
1287
1288         We are failing to load the injected bundle due to undefined symbol
1289         AccessibilityUIElement::replaceTextInRange().
1290
1291         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1292         (WTR::AccessibilityUIElement::replaceTextInRange):
1293
1294 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1295
1296         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1297         https://bugs.webkit.org/show_bug.cgi?id=196727
1298
1299         Reviewed by Fujii Hironori.
1300
1301         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1302         (WebKitBrowserWindow::create):
1303
1304 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1305
1306         [ews-build] Add unit tests for PrintConfiguration
1307         https://bugs.webkit.org/show_bug.cgi?id=196752
1308
1309         Reviewed by Dewei Zhu.
1310
1311         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1312
1313 2019-04-09  Keith Rollin  <krollin@apple.com>
1314
1315         Unreviewed build maintenance -- update .xcfilelists.
1316
1317         * DumpRenderTree/DerivedSources-input.xcfilelist:
1318         * DumpRenderTree/DerivedSources-output.xcfilelist:
1319
1320 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1321
1322         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1323         https://bugs.webkit.org/show_bug.cgi?id=196743
1324         <rdar://problem/43897551>
1325
1326         Reviewed by Tim Horton.
1327
1328         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1329         (TEST):
1330
1331 2019-04-09  Youenn Fablet  <youenn@apple.com>
1332
1333         Close service worker database on network process suspension
1334         https://bugs.webkit.org/show_bug.cgi?id=196623
1335         <rdar://problem/48930869>
1336
1337         Reviewed by Alex Christensen.
1338
1339         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1340
1341 2019-04-09  Daniel Bates  <dabates@apple.com>
1342
1343         [iPad] Should open popover when the spacebar is pressed
1344         https://bugs.webkit.org/show_bug.cgi?id=196360
1345         <rdar://problem/49389129>
1346
1347         Reviewed by Brent Fulgham.
1348
1349         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1350
1351         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1352         (WTR::UIScriptController::isShowingPopover const): Added.
1353         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1354         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1355         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1356         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1357         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1358         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1359         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1360         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1361         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1362         (WTR::UIScriptController::isShowingPopover const): Added.
1363         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1364         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1365         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1366         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1367         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1368         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1369         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1370         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1371         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1372         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1373         (WTR::UIScriptController::isShowingPopover const): Added.
1374         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1375         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1376
1377 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1378
1379         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1380         https://bugs.webkit.org/show_bug.cgi?id=196665
1381         <rdar://45115669>
1382
1383         Reviewed by Geoff Garen.
1384
1385         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1386         (goBack):
1387         (+[SimpleLookupContext sharedLookupContext]):
1388         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1389         (TEST):
1390         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1391         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1392
1393 2019-04-09  John Wilander  <wilander@apple.com>
1394
1395         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1396         https://bugs.webkit.org/show_bug.cgi?id=196558
1397         <rdar://problem/47650245>
1398
1399         Reviewed by Youenn Fablet.
1400
1401         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1402         (TestWebKitAPI::TEST):
1403             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1404
1405 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1406
1407         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1408         https://bugs.webkit.org/show_bug.cgi?id=196720
1409
1410         Reviewed by Konstantin Tokarev.
1411
1412         * TestWebKitAPI/PlatformMac.cmake:
1413
1414 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1415
1416         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1417         https://bugs.webkit.org/show_bug.cgi?id=196694
1418         <rdar://problem/48388734>
1419
1420         Rubber-stamped by Aakash Jain.
1421
1422         * Scripts/webkitpy/port/image_diff.py:
1423         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1424         * Scripts/webkitpy/port/server_process.py:
1425         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1426         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1427         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1428         * Scripts/webkitpy/port/server_process_mock.py:
1429         (MockServerProcess.has_available_stdout):
1430         * Scripts/webkitpy/port/server_process_unittest.py:
1431         (TestServerProcess.serial_test_basic):
1432
1433 2019-04-09  Jer Noble  <jer.noble@apple.com>
1434
1435         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1436         https://bugs.webkit.org/show_bug.cgi?id=196097
1437
1438         Reviewed by Eric Carlson.
1439
1440         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1441
1442         * DumpRenderTree/mac/DumpRenderTree.mm:
1443         (resetWebPreferencesToConsistentValues):
1444         * WebKitTestRunner/TestController.cpp:
1445         (WTR::TestController::resetPreferencesToConsistentValues):
1446
1447 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1448
1449         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1450         https://bugs.webkit.org/show_bug.cgi?id=196690
1451
1452         Reviewed by Michael Catanzaro.
1453
1454         * QueueStatusServer/config/queues.py:
1455         * Scripts/webkitpy/common/config/ews.json:
1456         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1457         (test_ews_name):
1458
1459 2019-04-09  Chris Dumez  <cdumez@apple.com>
1460
1461         Loads using loadHTMLString() cause flashing when process-swapping
1462         https://bugs.webkit.org/show_bug.cgi?id=196714
1463         <rdar://problem/49637354>
1464
1465         Reviewed by Antti Koivisto.
1466
1467         Add API test coverage.
1468
1469         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1470
1471 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1472
1473         Unreviewed. Fix ATK accessibility tests after r244059.
1474
1475         We are failing to load the injected bundle due to undefined symbol
1476         AccessibilityUIElement::replaceTextInRange().
1477
1478         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1479         (WTR::AccessibilityUIElement::replaceTextInRange):
1480
1481 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1482
1483         AX: Support API: accessibilityReplaceRange:withText
1484         https://bugs.webkit.org/show_bug.cgi?id=196636
1485
1486         Unreviewed build fix for Windows port.
1487
1488         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1489         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1490
1491 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1492
1493         [CMake][WinCairo] Separate copied headers into different directories
1494         https://bugs.webkit.org/show_bug.cgi?id=196655
1495
1496         Reviewed by Michael Catanzaro.
1497
1498         * DumpRenderTree/CMakeLists.txt:
1499         * MiniBrowser/win/CMakeLists.txt:
1500         * TestWebKitAPI/CMakeLists.txt:
1501         * TestWebKitAPI/PlatformWin.cmake:
1502
1503 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1504
1505         Log stack-trace for run-webkit-tests when interrupted
1506         https://bugs.webkit.org/show_bug.cgi?id=176393
1507         <rdar://problem/34262310>
1508
1509         Reviewed by Lucas Forschler.
1510
1511         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1512         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1513         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1514         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1515         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1516         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1517         (main): Set handlers to log stack trace on interruption.
1518
1519 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1520
1521         AX: Support API: accessibilityReplaceRange:withText
1522         https://bugs.webkit.org/show_bug.cgi?id=196636
1523
1524         Unreviewed build fix for Windows port.
1525
1526         * DumpRenderTree/AccessibilityUIElement.cpp:
1527         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1528
1529 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1530
1531         [ews-build] Scripts using Buildbot API have CORS error
1532         https://bugs.webkit.org/show_bug.cgi?id=196709
1533
1534         Reviewed by Alexey Proskuryakov.
1535
1536         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1537
1538 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1539
1540         AX: Support API: accessibilityReplaceRange:withText
1541         https://bugs.webkit.org/show_bug.cgi?id=196636
1542
1543         Reviewed by Daniel Bates.
1544
1545         * DumpRenderTree/AccessibilityUIElement.cpp:
1546         (replaceTextInRangeCallback):
1547         (AccessibilityUIElement::replaceTextInRange):
1548         (AccessibilityUIElement::getJSClass):
1549         * DumpRenderTree/AccessibilityUIElement.h:
1550         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1551         (AccessibilityUIElement::replaceTextInRange):
1552         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1553         (AccessibilityUIElement::replaceTextInRange):
1554         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1555         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1556         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1557         (WTR::AccessibilityUIElement::replaceTextInRange):
1558         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1559         (WTR::AccessibilityUIElement::replaceTextInRange):
1560
1561 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1562
1563         [iOS] Do not allow starting selection drags when selection views are not visible
1564         https://bugs.webkit.org/show_bug.cgi?id=196686
1565         <rdar://problem/49399192>
1566
1567         Reviewed by Tim Horton.
1568
1569         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1570         also add some new API tests to cover scenarios where the web view is not first responder.
1571
1572         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1573         (TestWebKitAPI::TEST):
1574         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1575
1576         Add a switch to optionally make the web view first responder when starting the simulated drag.
1577
1578         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1579         (-[DragAndDropSimulator initWithWebView:]):
1580         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1581
1582 2019-04-08  Justin Fan  <justin_fan@apple.com>
1583
1584         [Web GPU] Fix Web GPU experimental feature on iOS
1585         https://bugs.webkit.org/show_bug.cgi?id=196632
1586
1587         Reviewed by Myles C. Maxfield.
1588
1589         Properly make Web GPU available on iOS 11+.
1590
1591         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1592
1593 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1594
1595         [ews-build] Do not upload archive when Compile Fails
1596         https://bugs.webkit.org/show_bug.cgi?id=196674
1597
1598         Reviewed by Alexey Proskuryakov.
1599
1600         * BuildSlaveSupport/ews-build/factories.py:
1601         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1602         * BuildSlaveSupport/ews-build/steps.py:
1603         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1604         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1605         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1606
1607 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1608
1609         Enable DFG on MIPS
1610         https://bugs.webkit.org/show_bug.cgi?id=196689
1611
1612         Reviewed by Žan Doberšek.
1613
1614         Since the bytecode change, we enabled the baseline JIT on mips in
1615         r240432, but DFG is still missing. With this change, all tests are
1616         passing on a ci20 board.
1617
1618         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1619
1620 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1621
1622         [Flatpak] Second run update-webkitwpe-flatpak fails
1623         https://bugs.webkit.org/show_bug.cgi?id=192702
1624
1625         Reviewed by Carlos Garcia Campos.
1626
1627         * flatpak/flatpakutils.py:
1628         (FlatpakObject.flatpak): Fix typo.
1629         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1630         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1631
1632 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1633
1634         [GTK][WPE] outlook.live.com displays old-fashioned UI
1635         https://bugs.webkit.org/show_bug.cgi?id=196642
1636
1637         Reviewed by Carlos Garcia Campos.
1638
1639         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1640         (TestWebKitAPI::TEST): New Mac platform quirk test.
1641
1642 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1643
1644         Unreviewed, rolling out r243956.
1645         https://bugs.webkit.org/show_bug.cgi?id=196688
1646
1647         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1648         by aakashjain on #webkit).
1649
1650         Reverted changeset:
1651
1652         "Clicking "Go Back" from a safe browsing warning from an
1653         iframe should navigate the WKWebView back to the previous
1654         page"
1655         https://bugs.webkit.org/show_bug.cgi?id=196665
1656         https://trac.webkit.org/changeset/243956
1657
1658 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1659
1660         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1661         https://bugs.webkit.org/show_bug.cgi?id=196669
1662
1663         Reviewed by Geoffrey Garen.
1664
1665         Added three new unit tests for WeakHashSet.
1666
1667         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1668         (WTF_WeakPtr.WeakHashSetConstObjects):
1669         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1670         (WTF_WeakPtr.WeakHashSetComputeSize):
1671
1672 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1673
1674         Hide next and previous form control buttons when WKWebView is editable
1675         https://bugs.webkit.org/show_bug.cgi?id=196672
1676         <rdar://problem/35625321>
1677
1678         Reviewed by Tim Horton.
1679
1680         Add a new API test.
1681
1682         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1683         (-[TestWKWebView lastTrailingBarButtonGroup]):
1684         (TestWebKitAPI::TEST):
1685         * TestWebKitAPI/ios/UIKitSPI.h:
1686
1687 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1688
1689         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1690         https://bugs.webkit.org/show_bug.cgi?id=196077
1691         <rdar://problem/49108202>
1692
1693         Reviewed by Chris Dumez.
1694
1695         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1696         on new web view.
1697
1698         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1699
1700 2019-04-05  Saam Barati  <sbarati@apple.com>
1701
1702         Make compare-results understand MotionMark
1703         https://bugs.webkit.org/show_bug.cgi?id=196666
1704
1705         Reviewed by Yusuke Suzuki.
1706
1707         * Scripts/compare-results:
1708         (PLT5Results):
1709         (detectMotionMark):
1710         (detectMotionMark1_1):
1711         (motionMarkResults):
1712         (motionMark1_1Results):
1713         (detectBenchmark):
1714         (biggerIsBetter):
1715         (main):
1716
1717 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1718
1719         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1720         https://bugs.webkit.org/show_bug.cgi?id=196665
1721         <rdar://45115669>
1722
1723         Reviewed by Geoff Garen.
1724
1725         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1726         (goBack):
1727         (+[SimpleLookupContext sharedLookupContext]):
1728         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1729         (TEST):
1730         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1731         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1732
1733 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1734
1735         [ews-build] Add configuration and architecture for windows builders
1736         https://bugs.webkit.org/show_bug.cgi?id=196660
1737
1738         Reviewed by Lucas Forschler.
1739
1740         * BuildSlaveSupport/ews-build/config.json:
1741
1742 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1743
1744         webkitpy: Don't run subsequent rounds if interrupted
1745         https://bugs.webkit.org/show_bug.cgi?id=196646
1746
1747         Reviewed by Aakash Jain.
1748
1749         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1750         (Manager.run): Bail out if interrupted.
1751
1752 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1753
1754         Test sessionStorage in PSON private browsing mode
1755         https://bugs.webkit.org/show_bug.cgi?id=196561
1756
1757         Reviewed by Alex Christensen.
1758
1759         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1760
1761 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1762
1763         Unreviewed, rolling out r243833.
1764         https://bugs.webkit.org/show_bug.cgi?id=196645
1765
1766         This change breaks build of WPE and GTK ports (Requested by
1767         annulen on #webkit).
1768
1769         Reverted changeset:
1770
1771         "[CMake][WTF] Mirror XCode header directories"
1772         https://bugs.webkit.org/show_bug.cgi?id=191662
1773         https://trac.webkit.org/changeset/243833
1774
1775 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1776
1777         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1778         https://bugs.webkit.org/show_bug.cgi?id=196635
1779
1780         Reviewed by Antti Koivisto.
1781         
1782         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1783         for a test to enable async frame scrolling via:
1784             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1785         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1786         
1787         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1788
1789         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1790         (WTR::InjectedBundle::beginTesting):
1791         * WebKitTestRunner/TestController.cpp:
1792         (WTR::TestController::resetPreferencesToConsistentValues):
1793
1794 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1795
1796         Use a correct LC_RPATH when building with ASan
1797         https://bugs.webkit.org/show_bug.cgi?id=196576
1798
1799         Reviewed by David Kilzer.
1800
1801         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1802         so that ../Frameworks is checked. This is simpler and more reliable than updating
1803         each SPC service xcconfig.
1804
1805 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1806
1807         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1808         https://bugs.webkit.org/show_bug.cgi?id=196629
1809
1810         Reviewed by Lucas Forschler.
1811
1812         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1813
1814 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1815
1816         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1817         https://bugs.webkit.org/show_bug.cgi?id=196618
1818
1819         Reviewed by Lucas Forschler.
1820
1821         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1822         (StatusBubble): Added QUEUE_TRIGGERS.
1823         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1824         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1825         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1826         its parent(builder).
1827
1828 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1829
1830         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1831         https://bugs.webkit.org/show_bug.cgi?id=196625
1832
1833         Reviewed by Lucas Forschler.
1834
1835         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1836         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1837
1838 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1839
1840         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1841         https://bugs.webkit.org/show_bug.cgi?id=196630
1842
1843         Reviewed by Wenson Hsieh.
1844
1845         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1846
1847 2019-04-04  Youenn Fablet  <youenn@apple.com>
1848
1849         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1850         https://bugs.webkit.org/show_bug.cgi?id=196543
1851
1852         Reviewed by Alex Christensen.
1853
1854         * WebKitTestRunner/TestController.cpp:
1855         (WTR::TestController::generatePageConfiguration):
1856
1857 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1858
1859         [ews-app] Status bubble should not display skipped buildbot steps
1860         https://bugs.webkit.org/show_bug.cgi?id=196584
1861
1862         Reviewed by Lucas Forschler.
1863
1864         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1865
1866 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1867
1868         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1869         https://bugs.webkit.org/show_bug.cgi?id=196620
1870
1871         Reviewed by Lucas Forschler.
1872
1873         * BuildSlaveSupport/ews-app/ews/config.py:
1874
1875 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1876
1877         [Win] DumpRenderTreeWatchDog.py is not checked into source
1878         https://bugs.webkit.org/show_bug.cgi?id=196567
1879         <rdar://problem/49525901>
1880
1881         Reviewed by Lucas Forschler.
1882
1883         This script is used on Win EWS bots to terminate hanging DRT processes.
1884
1885         * EWSTools/dumprendertreewatchdog.py: Added.
1886
1887 2019-04-04  Chris Dumez  <cdumez@apple.com>
1888
1889         Unreviewed, roll out r243858 which made tests time out.
1890
1891         Disable new API tests on Windows instead.
1892
1893         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1894         (TestWebKitAPI::TEST):
1895
1896 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1897
1898         [ATK] Cleanup WebPageAccessibilityObjectAtk
1899         https://bugs.webkit.org/show_bug.cgi?id=196537
1900
1901         Reviewed by Michael Catanzaro.
1902
1903         Also consider files under atk directories as exceptions for GObject conventions.
1904
1905         * Scripts/webkitpy/style/checkers/cpp.py:
1906         (check_identifier_name_in_declaration):
1907
1908 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1909
1910         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1911         https://bugs.webkit.org/show_bug.cgi?id=196588
1912         <rdar://problem/49365787>
1913
1914         Unreviewed build fix for Windows port.
1915
1916         error C3861: 'kill': identifier not found
1917
1918         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1919         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1920
1921 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1922
1923         [ews-build] Cancel build and similar operations should have authentication
1924         https://bugs.webkit.org/show_bug.cgi?id=196520
1925
1926         Reviewed by Dewei Zhu.
1927
1928         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1929         environment variables.
1930
1931 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1932
1933         [ews-build] Do not trigger queues which are not in production yet
1934         https://bugs.webkit.org/show_bug.cgi?id=196581
1935
1936         Reviewed by Dewei Zhu.
1937
1938         * BuildSlaveSupport/ews-build/config.json:
1939
1940 2019-04-03  Chris Dumez  <cdumez@apple.com>
1941
1942         Unreviewed, fix typo in the name of API test added in r243848.
1943
1944         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1945         (TestWebKitAPI::TEST):
1946
1947 2019-04-03  Chris Dumez  <cdumez@apple.com>
1948
1949         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1950         https://bugs.webkit.org/show_bug.cgi?id=196588
1951         <rdar://problem/49365787>
1952
1953         Reviewed by Ryosuke Niwa.
1954
1955         Add API test coverage.
1956
1957         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1958         (TestWebKitAPI::nullJavaScriptCallback):
1959         (TestWebKitAPI::didCrashCheckFrames):
1960         (TestWebKitAPI::TEST):
1961
1962 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1963
1964         run-webkit-tests: Upload test results (new results database)
1965         https://bugs.webkit.org/show_bug.cgi?id=196577
1966         <rdar://problem/34841155>
1967
1968         Reviewed by Lucas Forschler.
1969
1970         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1971         (Manager.run): Upload results after each device shard, since the configuration will be
1972         different for each device.
1973         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1974         uploaded to a results database.
1975         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1976         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1977
1978 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1979
1980         -apple-trailing-word is needed for browser detection
1981         https://bugs.webkit.org/show_bug.cgi?id=196575
1982
1983         Unreviewed.
1984
1985         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1986
1987 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1988
1989         [CMake][WTF] Mirror XCode header directories
1990         https://bugs.webkit.org/show_bug.cgi?id=191662
1991
1992         Reviewed by Konstantin Tokarev.
1993
1994         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1995         builds.
1996
1997         * CMakeLists.txt:
1998         * DumpRenderTree/CMakeLists.txt:
1999         * DumpRenderTree/PlatformWin.cmake:
2000         * MiniBrowser/win/CMakeLists.txt:
2001         * TestWebKitAPI/CMakeLists.txt:
2002         * TestWebKitAPI/PlatformWin.cmake:
2003         * WebKitTestRunner/PlatformGTK.cmake:
2004         * WebKitTestRunner/PlatformWin.cmake:
2005
2006 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2007
2008         [ews-app] Status bubble should not display certain infrastructure status messages
2009         https://bugs.webkit.org/show_bug.cgi?id=196550
2010
2011         Reviewed by Lucas Forschler.
2012
2013         Do not display the steps which are un-needed for end-user. This information is still avaiable
2014         if the user click on the bubble and look at the Buildbot build.
2015         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2016         (StatusBubble._steps_messages):
2017         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2018
2019 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2020
2021         [ews-build] Use https for sending data to ews-app
2022         https://bugs.webkit.org/show_bug.cgi?id=196492
2023
2024         Reviewed by Lucas Forschler.
2025
2026         * BuildSlaveSupport/ews-build/events.py:
2027
2028 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2029
2030         Remove support for -apple-trailing-word
2031         https://bugs.webkit.org/show_bug.cgi?id=196525
2032
2033         Reviewed by Zalan Bujtas.
2034
2035         This CSS property is nonstandard and not used.
2036
2037         * Scripts/webkitperl/FeatureList.pm:
2038         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2039
2040 2019-04-03  Youenn Fablet  <youenn@apple.com>
2041
2042         Add a test for DOMCache on multiple browsing in case of private browsing
2043         https://bugs.webkit.org/show_bug.cgi?id=196524
2044
2045         Reviewed by Alex Christensen.
2046
2047         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2048         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2049
2050 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2051
2052         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2053         https://bugs.webkit.org/show_bug.cgi?id=196540
2054
2055         Reviewed by Aakash Jain.
2056
2057         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2058
2059 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2060
2061         Add plumbing for a compatibility mode preference in WebKit
2062         https://bugs.webkit.org/show_bug.cgi?id=196005
2063
2064         Reviewed by Tim Horton.
2065
2066         Add new API tests.
2067
2068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2069         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2070
2071 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2072
2073         [WPE][GTK] Update libsrtp dependency package for Debian
2074         https://bugs.webkit.org/show_bug.cgi?id=196528
2075
2076         Reviewed by Frédéric Wang.
2077
2078         * gtk/install-dependencies:
2079         * wpe/install-dependencies:
2080
2081 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2082
2083         [WK2] Add support for Window's beforeprint / afterprint events
2084         https://bugs.webkit.org/show_bug.cgi?id=196478
2085         <rdar://problem/49535124>
2086
2087         Unreviewed build fix for MSVC.
2088
2089         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2090
2091         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2092
2093         * WebKitTestRunner/TestController.cpp:
2094         (WTR::printFrame): Use int and float literals.
2095
2096 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2097
2098         [ews-build] Reassign bots to queues
2099
2100         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2101
2102 2019-04-02  Chris Dumez  <cdumez@apple.com>
2103
2104         [WK2] Add support for Window's beforeprint / afterprint events
2105         https://bugs.webkit.org/show_bug.cgi?id=196478
2106
2107         Reviewed by Alex Christensen.
2108
2109         Add minimal implementation for printFrame in WebKitTestRunner.
2110
2111         * WebKitTestRunner/TestController.cpp:
2112         (WTR::printFrame):
2113         (WTR::TestController::createOtherPage):
2114         (WTR::TestController::createWebViewWithOptions):
2115
2116 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2117
2118         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2119         https://bugs.webkit.org/show_bug.cgi?id=196491
2120
2121         Reviewed by Lucas Forschler.
2122
2123         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2124
2125 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2126
2127         [ews-build] Configure buildbot try credentials in environment variables
2128         https://bugs.webkit.org/show_bug.cgi?id=196501
2129
2130         Reviewed by Lucas Forschler.
2131
2132         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2133         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2134         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2135
2136 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2137
2138         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2139         https://bugs.webkit.org/show_bug.cgi?id=196496
2140         <rdar://problem/49521634>
2141
2142         Reviewed by Chris Dumez.
2143
2144         Add new API tests (see WebKit ChangeLog for more detail).
2145
2146         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2147         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2148         (TEST):
2149
2150 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2151
2152         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2153         <https://webkit.org/b/196499>
2154
2155         Reviewed by Alexey Proskuryakov.
2156
2157         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2158         ENABLE_ADDRESS_SANITIZER.
2159
2160 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2161
2162         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2163         https://bugs.webkit.org/show_bug.cgi?id=182757
2164
2165         Reviewed by Don Olmstead.
2166
2167         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2168         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2169
2170 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2171
2172         run-api-tests: Upload test results
2173         https://bugs.webkit.org/show_bug.cgi?id=196323
2174         <rdar://problem/49356714>
2175
2176         Reviewed by Lucas Forschler.
2177
2178         * Scripts/webkitpy/api_tests/manager.py:
2179         (Manager):
2180         (Manager.run): Upload results to a results database.
2181         * Scripts/webkitpy/api_tests/run_api_tests.py:
2182         (parse_args): Add upload arguments.
2183         * Scripts/webkitpy/port/base.py:
2184         (Port):
2185         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2186         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2187         with commits from any other associated repositories.
2188         * Scripts/webkitpy/port/device.py:
2189         (Device):
2190         (Device.build_version): Access build_versoin of underlying platform device.
2191         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2192         (IOSSimulatorTest):
2193         (IOSSimulatorTest.test_configuration_for_upload):
2194         * Scripts/webkitpy/port/device_port.py:
2195         (DevicePort):
2196         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2197         the same as the machine uploading results.
2198         * Scripts/webkitpy/port/mac.py:
2199         (MacPort):
2200         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2201         * Scripts/webkitpy/port/mac_unittest.py:
2202         (MacTest):
2203         (MacTest.test_configuration_for_upload):
2204         * Scripts/webkitpy/xcode/simulated_device.py:
2205         (SimulatedDeviceManager._create_device_with_runtime):
2206         (SimulatedDevice.__init__): Create simulated device with a build_version.
2207         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2208         (test_existing_simulator):
2209
2210 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2211
2212         Remove extra newline characters (Follow-up fix to r243707)
2213
2214         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2215
2216 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2217
2218         [ews-app] Use API_KEY to accept results data
2219         https://bugs.webkit.org/show_bug.cgi?id=196461
2220
2221         Reviewed by Dewei Zhu.
2222
2223         * BuildSlaveSupport/ews-app/ews/views/results.py:
2224         (Results.post): Validate EWS_API_KEY before accepting any data.
2225         * BuildSlaveSupport/ews-build/events.py:
2226         (Events.sendData): Send EWS_API_KEY if available along with event data.
2227
2228 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2229
2230         Unable to copy and paste a PDF from Notes into Mail compose body
2231         https://bugs.webkit.org/show_bug.cgi?id=196442
2232         <rdar://problem/48573098>
2233
2234         Reviewed by Tim Horton.
2235
2236         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2237         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2238         to be specified on the item providers.
2239
2240         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2241         (TestWebKitAPI::mapItemForTesting):
2242         (TestWebKitAPI::contactItemForTesting):
2243
2244 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2245
2246         Make UIWKDocumentContext rects per-character instead of per-word
2247         https://bugs.webkit.org/show_bug.cgi?id=196459
2248
2249         Reviewed by Wenson Hsieh.
2250
2251         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2252         (TEST):
2253         Adjust test results due to switching to per-character rects.
2254
2255 2019-04-01  Chris Dumez  <cdumez@apple.com>
2256
2257         UIProcess crash when a prewarmed process is terminated
2258         https://bugs.webkit.org/show_bug.cgi?id=196451
2259         <rdar://problem/49245471>
2260
2261         Reviewed by Geoffrey Garen.
2262
2263         Add API test coverage.
2264
2265         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2266         (TEST):
2267
2268 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2269
2270         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2271         https://bugs.webkit.org/show_bug.cgi?id=196449
2272
2273         Reviewed by Lucas Forschler.
2274
2275         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2276         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2277         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2278         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2279
2280 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2281
2282         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2283         https://bugs.webkit.org/show_bug.cgi?id=196444
2284
2285         Reviewed by Lucas Forschler.
2286
2287         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2288
2289 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2290
2291         Add SPI to canonicalize NSURLs with WTF::URL
2292         https://bugs.webkit.org/show_bug.cgi?id=196415
2293         <rdar://problem/44980271>
2294
2295         Reviewed by Darin Adler.
2296
2297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2298         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2299         (TestWebKitAPI::TEST):
2300
2301 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2302
2303         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2304         https://bugs.webkit.org/show_bug.cgi?id=196441
2305
2306         Reviewed by Carlos Garcia Campos.
2307
2308         Don't cache the wpe_view_backend object that might not exist yet at the
2309         time of EventSenderProxy constructor invocation, but instead retrieve
2310         that object whenever it's required for event dispatching. This should
2311         avoid crashes in this constructor now that it's invoked before any
2312         PlatformWindow has been set up (as changed in r243496).
2313
2314         * WebKitTestRunner/EventSenderProxy.h:
2315         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2316         (WTR::viewBackend):
2317         (WTR::EventSenderProxy::EventSenderProxy):
2318         (WTR::EventSenderProxy::mouseDown):
2319         (WTR::EventSenderProxy::mouseUp):
2320         (WTR::EventSenderProxy::mouseMoveTo):
2321         (WTR::EventSenderProxy::mouseScrollBy):
2322         (WTR::EventSenderProxy::keyDown):
2323         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2324
2325 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2326
2327         [Win][WebKit] MiniBrowser should support high DPI display
2328         https://bugs.webkit.org/show_bug.cgi?id=196391
2329
2330         Reviewed by Alex Christensen.
2331
2332         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2333         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2334         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2335         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2336
2337 2019-03-31  Sam Weinig  <weinig@apple.com>
2338
2339         Remove more i386 specific configurations
2340         https://bugs.webkit.org/show_bug.cgi?id=196430
2341
2342         Reviewed by Alexey Proskuryakov.
2343
2344         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2345         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2346
2347 2019-03-31  Andy Estes  <aestes@apple.com>
2348
2349         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2350         https://bugs.webkit.org/show_bug.cgi?id=196433
2351         <rdar://problem/49293305>
2352
2353         Reviewed by Tim Horton.
2354
2355         Enhanced API test coverage to include all navigation response policy decisions in both
2356         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2357
2358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2359         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2360         (TestWebKitAPI::TEST):
2361         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2362         (readFile):
2363         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2364         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2365         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2366         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2367         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2368         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2369         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2370         (-[QuickLookDelegate _downloadDidStart:]):
2371         (-[QuickLookDelegate _download:didReceiveResponse:]):
2372         (-[QuickLookDelegate _download:didReceiveData:]):
2373         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2374         (-[QuickLookDelegate _downloadDidFinish:]):
2375         (-[QuickLookDelegate _download:didFailWithError:]):
2376         (-[QuickLookDelegate _downloadDidCancel:]):
2377         (-[QuickLookDelegate verifyDownload]):
2378         (runTest):
2379         (runTestDecideBeforeLoading):
2380         (runTestDecideAfterLoading):
2381         (TEST):
2382         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2383         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2384         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2385         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2386         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2387         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2388         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2389         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2390         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2391         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2392         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2393         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2394         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2395         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2396
2397 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2398
2399         [CMake] add testdfg as target with build-jsc
2400         https://bugs.webkit.org/show_bug.cgi?id=196393
2401
2402         Reviewed by Saam Barati.
2403
2404         Added testdfg as one of the targets to build when
2405         using CMake.
2406
2407         * Scripts/build-jsc:
2408
2409 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2410
2411         Delete WebMetal implementation in favor of WebGPU
2412         https://bugs.webkit.org/show_bug.cgi?id=195418
2413
2414         Reviewed by Dean Jackson.
2415
2416         * DumpRenderTree/mac/DumpRenderTree.mm:
2417         (enableExperimentalFeatures):
2418         (resetWebPreferencesToConsistentValues):
2419         * Scripts/webkitperl/FeatureList.pm:
2420         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2422         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2423         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2424         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2425         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2426         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2427         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2428         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2429         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2430         (WTR::InjectedBundle::beginTesting):
2431         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2432         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2433         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2434
2435 2019-03-29  Chris Dumez  <cdumez@apple.com>
2436
2437         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2438         https://bugs.webkit.org/show_bug.cgi?id=196405
2439         <rdar://problem/49428130>
2440
2441         Reviewed by Wenson Hsieh.
2442
2443         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2444         the popover presentation methods to be no-ops. Use this in the new test added in
2445         r243523 so that we do not swizzle those methods for all tests. This is needed because
2446         those WatchOS tests rely on the popover getting presented and interactive.
2447
2448         * WebKitTestRunner/TestController.cpp:
2449         (WTR::updateTestOptionsFromTestHeader):
2450         * WebKitTestRunner/TestController.h:
2451         * WebKitTestRunner/TestOptions.h:
2452         (WTR::TestOptions::hasSameInitializationOptions const):
2453         * WebKitTestRunner/ios/TestControllerIOS.mm:
2454         (WTR::TestController::platformInitialize):
2455         (WTR::TestController::platformResetStateToConsistentValues):
2456
2457 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2458
2459         [Curl] Add Server Trust Evaluation Support.
2460         https://bugs.webkit.org/show_bug.cgi?id=191646
2461
2462         Reviewed by Fujii Hironori.
2463
2464         Implemented MiniBrowser UI for asking if user trusts the server.
2465
2466         * MiniBrowser/win/Common.cpp:
2467         (askServerTrustEvaluation):
2468         (replaceString):
2469         * MiniBrowser/win/Common.h:
2470         * MiniBrowser/win/MiniBrowserLib.rc:
2471         * MiniBrowser/win/MiniBrowserLibResource.h:
2472         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2473         (createPEMString):
2474         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2475         (WebKitBrowserWindow::canTrustServerCertificate):
2476         * MiniBrowser/win/WebKitBrowserWindow.h:
2477
2478 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2479
2480         Implement ResizeObserver.
2481         https://bugs.webkit.org/show_bug.cgi?id=157743
2482
2483         Reviewed by Simon Fraser.
2484
2485         Support resizeObserverEnabled webPreferences.
2486
2487         * DumpRenderTree/TestOptions.cpp:
2488         (TestOptions::TestOptions):
2489         * DumpRenderTree/TestOptions.h:
2490         * DumpRenderTree/mac/DumpRenderTree.mm:
2491         (setWebPreferencesForTestOptions):
2492         * DumpRenderTree/win/DumpRenderTree.cpp:
2493         (enableExperimentalFeatures):
2494         * Scripts/webkitperl/FeatureList.pm:
2495         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2496
2497 2019-03-28  John Wilander  <wilander@apple.com>
2498
2499         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2500         https://bugs.webkit.org/show_bug.cgi?id=196281
2501         <rdar://problem/48938748>
2502
2503         Reviewed by Alex Christensen.
2504
2505         This patch adds the function isStatisticsHasLocalStorage() to the
2506         TestRunner. With it, the page can query the WebsiteDataStore in the
2507         UI process to make sure that it sees LocalStorage.
2508
2509         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2510         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2511         (WTR::TestRunner::isStatisticsHasLocalStorage):
2512         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2513         * WebKitTestRunner/TestController.cpp:
2514         (WTR::TestController::isStatisticsHasLocalStorage):
2515         * WebKitTestRunner/TestController.h:
2516         * WebKitTestRunner/TestInvocation.cpp:
2517         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2518
2519 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2520
2521         API::Data::createWithoutCopying should do a null check before calling CFRelease
2522         https://bugs.webkit.org/show_bug.cgi?id=196276
2523         <rdar://problem/48059859>
2524
2525         Reviewed by Alex Christensen.
2526
2527         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2528
2529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2530         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2531         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2532         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2533         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2534         (TestWebKitAPI::TEST):
2535
2536 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2537
2538         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2539         https://bugs.webkit.org/show_bug.cgi?id=186276
2540
2541         Reviewed by Carlos Garcia Campos.
2542
2543         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2544         (webViewLoadChanged):
2545         (testWebResourceGetDataError):
2546         (testWebResourceGetDataEmpty):
2547         (beforeAll):
2548         (webViewloadChanged): Deleted.
2549
2550 2019-03-27  Andy Estes  <aestes@apple.com>
2551
2552         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2553         https://bugs.webkit.org/show_bug.cgi?id=196317
2554
2555         Reviewed by Dan Bernstein.
2556
2557         package-root copies built products into a staging directory using ditto(1), which does not
2558         follow symbolic links as it traverses a directory. Now that the files in
2559         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2560         itself, these become broken links when ditto'd into the staging directory.
2561
2562         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2563
2564         * Scripts/package-root:
2565
2566 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2567
2568         [ews-app] Update display text of Submit for ews analysis
2569         https://bugs.webkit.org/show_bug.cgi?id=196309
2570
2571         Reviewed by Dewei Zhu.
2572
2573         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2574
2575 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2576
2577         run-webkit-tests should check for leaks in WebKit processes
2578         <https://webkit.org/b/193772>
2579         <rdar://problem/46526680>
2580
2581         Reviewed by Ryosuke Niwa.
2582
2583         This works by doing the following:
2584         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2585           The list of child processes are returned one per line:
2586           process.name: pid
2587         - Run the "#LIST CHILD PROCESSES" command just before the
2588           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2589           processes on the ServerProcess object.
2590         - When the `--leaks` switch is handled, run check_for_leaks() on
2591           each child process after the main test harness.
2592
2593         * DumpRenderTree/mac/DumpRenderTree.mm:
2594         (handleControlCommand):
2595         - Use strncmp() instead of strcmp().
2596         - Add support for handling "#LIST CHILD PROCESSES" command.
2597
2598         * Scripts/webkitpy/port/base.py:
2599         (Port.check_for_leaks):
2600         * Scripts/webkitpy/port/darwin.py:
2601         (DarwinPort.check_for_leaks):
2602         - Rename redundant 'process_pid' argument to 'process_id'.
2603
2604         * Scripts/webkitpy/port/driver.py:
2605         (Driver.do_post_tests_work):
2606         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2607           longer the only command this sends to WebKitTestRunner.
2608         - If the `--leaks` switch is present, send the
2609           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2610           result using Port.set_webkit_processes().
2611         (Driver._parse_child_processes_output):
2612         - Add helper method to parse list of child process names and
2613           process IDs returned from WebKitTestRunner.
2614
2615         * Scripts/webkitpy/port/ios_device.py:
2616         (IOSDevicePort.check_for_leaks):
2617         - Rename redundant 'process_pid' argument to 'process_id'.
2618
2619         * Scripts/webkitpy/port/leakdetector.py:
2620         (LeakDetector._parse_leaks_output):
2621         - Return early if there is no leaks_output.
2622         (LeakDetector.check_for_leaks):
2623         - Rename redundant 'process_pid' argument to 'process_id'.
2624
2625         * Scripts/webkitpy/port/server_process.py:
2626         (ServerProcess.__init__):
2627         (ServerProcess.child_processes):
2628         (ServerProcess.set_child_processes):
2629         - Add instance variable to Port to store list of child process
2630           names and process IDs returned from WebKitTestRunner.
2631         (ServerProcess._start):
2632         - Clear self._child_processes.
2633         (ServerProcess.stop):
2634         - If self._child_processes is set, call
2635           self._port.check_for_leaks() for each child process.
2636
2637         * Scripts/webkitpy/port/server_process_unittest.py:
2638         (TrivialMockPort.check_for_leaks):
2639         - Rename redundant 'process_pid' argument to 'process_id'.
2640
2641         * Scripts/webkitpy/port/simulator_process.py:
2642         (SimulatorProcess.stop):
2643         - If self._child_processes is set, call
2644           self._port.check_for_leaks() for each child process.
2645
2646         * Scripts/webkitpy/port/watch_device.py:
2647         (WatchDevicePort.check_for_leaks):
2648         - Rename redundant 'process_pid' argument to 'process_id'.
2649
2650         * WebKitTestRunner/TestController.cpp:
2651         (WTR::TestController::dumpResponse):
2652         - Extract method from findAndDumpWorldLeaks() so that it may be
2653           reused by findAndDumpWebKitProcessIdentifiers().
2654         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2655         - Add method to output process name and process ID of both the
2656           WebContent and Networking processes.
2657         (WTR::TestController::findAndDumpWorldLeaks):
2658         - Fix missing newline in output when there were no abandoned
2659           documents.
2660         - Call dumpResponse() for extracted code.
2661         (WTR::TestController::handleControlCommand):
2662         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2663         - Use strncmp() instead of strcmp().
2664         - Call findAndDumpWebKitProcessIdentifiers() when
2665           "#LIST CHILD PROCESSES" command is sent.
2666         * WebKitTestRunner/TestController.h:
2667         (WTR::TestController::dumpResponse):
2668         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2669         - Declare methods.
2670
2671 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2672
2673         Unreviewed. Add GLib API test cases after r243434.
2674
2675         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2676         (testWebViewActiveURI):
2677         (serverCallback):
2678         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2679         (sendRequestCallback):
2680
2681 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2682
2683         Geolocation request not complete when watch request was started in a different web process
2684         https://bugs.webkit.org/show_bug.cgi?id=195996
2685
2686         Reviewed by Alex Christensen.
2687
2688         Add a test case.
2689
2690         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2691         (TestWebKitAPI::runJavaScriptAlert):
2692         (TestWebKitAPI::TEST):
2693
2694 2019-03-26  Keith Rollin  <krollin@apple.com>
2695
2696         Update the way generate-xcfilelists returns strings from functions
2697         https://bugs.webkit.org/show_bug.cgi?id=195975
2698         <rdar://problem/49040807>
2699
2700         Reviewed by Dean Jackson.
2701
2702         There are places where generate-xcfilelists executes assignments with
2703         statements like:
2704
2705             FOO=$(some_function)
2706
2707         where "some_function" return a string by echoing it. E.g.
2708
2709             some_function()
2710             {
2711                 echo "Hello, World"
2712             }
2713
2714         This is a common idiom, but it has a problem if "some_function" needs
2715         to call "exit" in an attempt to halt the entire script right then and
2716         there. Since "some_function" is called inside of $(), it's being
2717         executed in a sub-shell. Calling exit in that sub-shell simply exits
2718         that shell; it doesn't not exit the outer shell in which the main part
2719         of the script is still running. As such, the main script keeps
2720         executing when the intent was for the script to halt.
2721
2722         The solution to this is to use a different idiom for returning
2723         strings. The one we now is to pass in the name of the variable to
2724         receive the string result:
2725
2726             some_function()
2727             {
2728                 variable_name=$1
2729                 eval $variable_name ="Hello, World"
2730             }
2731
2732         The call site now looks like
2733
2734             some_function FOO
2735
2736         Because there's no invocation of a sub-shell, some_function can now
2737         call "exit" if it wants to, and the entire script will exit at that
2738         point.
2739
2740         * Scripts/generate-xcfilelists:
2741
2742 2019-03-26  Chris Dumez  <cdumez@apple.com>
2743
2744         Add basic layout test coverage for File Picker on iOS
2745         https://bugs.webkit.org/show_bug.cgi?id=196265
2746
2747         Reviewed by Wenson Hsieh.
2748
2749         Add layout test infrastructure to test the file picker on iOS.
2750
2751         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2752         (WTR::UIScriptController::dismissFilePicker):
2753         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2754         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2755         (WTR::UIScriptController::dismissFilePicker):
2756         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2757         * WebKitTestRunner/TestController.cpp:
2758         (WTR::TestController::createWebViewWithOptions):
2759         (WTR::updateTestOptionsFromTestHeader):
2760         * WebKitTestRunner/TestOptions.h:
2761         (WTR::TestOptions::hasSameInitializationOptions const):
2762         * WebKitTestRunner/ios/TestControllerIOS.mm:
2763         (overridePresentViewController):
2764         (WTR::TestController::platformInitialize):
2765         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2766         (WTR::UIScriptController::dismissFilePicker):
2767
2768 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2769
2770         Implement async paste method on UIWKInteractionViewProtocol
2771         https://bugs.webkit.org/show_bug.cgi?id=196267
2772         <rdar://problem/49236346>
2773
2774         Reviewed by Tim Horton.
2775
2776         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2777         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2778         are now a part of all iOS 12 internal SDKs.
2779
2780         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2781
2782         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2783         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2784
2785         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2786         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2787         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2788         * TestWebKitAPI/ios/UIKitSPI.h:
2789
2790 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2791
2792         [ews-build] Use PostgreSQL for ews.webkit.org database
2793         https://bugs.webkit.org/show_bug.cgi?id=196270
2794
2795         Reviewed by Lucas Forschler.
2796
2797         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2798
2799 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2800
2801         [ews] Reset simctl states on reboot
2802         https://bugs.webkit.org/show_bug.cgi?id=196260
2803
2804         Rubber-stamped by Aakash Jain.
2805
2806         * EWSTools/start-queue-mac.sh:
2807
2808 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2809
2810         [ews-build] Use PostgreSQL for ews-build database
2811         https://bugs.webkit.org/show_bug.cgi?id=196229
2812
2813         Reviewed by Lucas Forschler.
2814
2815         * BuildSlaveSupport/ews-build/master.cfg:
2816
2817 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2818
2819         [ews-build] Get master_hostname dynamically in master.cfg
2820         https://bugs.webkit.org/show_bug.cgi?id=196255
2821
2822         Reviewed by Lucas Forschler.
2823
2824         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2825         send events data in test mode.
2826
2827 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2828
2829         [ews-app] Set db_constraint to False for Foreign Keys
2830         https://bugs.webkit.org/show_bug.cgi?id=196252
2831
2832         Reviewed by Lucas Forschler.
2833
2834         * BuildSlaveSupport/ews-app/ews/models/build.py:
2835         * BuildSlaveSupport/ews-app/ews/models/step.py:
2836
2837 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2838
2839         [ews-build] is_test_mode_enabled should default to True
2840         https://bugs.webkit.org/show_bug.cgi?id=196248
2841
2842         Reviewed by Lucas Forschler.
2843
2844         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2845
2846 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2847
2848         [ews-app] Add webkitperl to ENABLED_QUEUES
2849         https://bugs.webkit.org/show_bug.cgi?id=196253
2850
2851         Reviewed by Lucas Forschler.
2852
2853         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2854
2855 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2856
2857         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2858         https://bugs.webkit.org/show_bug.cgi?id=196211
2859         rdar://problem/49110552
2860
2861         Reviewed by Tim Horton.
2862
2863         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2864         Make sure that EventSenderProxy always exists when running tests. We used to create
2865         it when resetting before the first test, which is a bit too late.
2866
2867         * WebKitTestRunner/TestController.h:
2868         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2869         (WTR::TestController::platformCreateWebView):
2870         (WTR::TestController::platformCreateOtherPage):
2871         (WTR::TestController::finishCreatingPlatformWebView):
2872         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2873         (WTR::PlatformWebView::PlatformWebView):
2874         Moved some code that made NSWindow use NSEvent during web view creation. We may
2875         need to move more if some other case us found, but this is enough for now.
2876
2877 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2878
2879         Unreviewed. Fix typo in GLib geolocation API after r243285.
2880
2881         gelocation -> geolocation.
2882
2883         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2884         (testGeolocationManagerWatchPosition):
2885
2886 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2887
2888         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2889         https://bugs.webkit.org/show_bug.cgi?id=196213
2890
2891         Reviewed by Geoff Garen.
2892
2893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2894         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2895         (credentialWithIdentityAndKeychainPath):
2896         (-[ChallengeDelegate webView:didFinishNavigation:]):
2897         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2898         (TestWebKitAPI::TEST):
2899
2900 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2901
2902         Expected shouldn't assume its contained types are copyable
2903         https://bugs.webkit.org/show_bug.cgi?id=195986
2904
2905         Reviewed by JF Bastien.
2906
2907         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2908         (TestWebKitAPI::NonCopyable::operator== const):
2909         (TestWebKitAPI::NonCopyable::operator!= const):
2910         (TestWebKitAPI::TEST):
2911
2912 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2913
2914         Remove some now-unnecessary dynamic class lookup
2915         https://bugs.webkit.org/show_bug.cgi?id=196237
2916
2917         Reviewed by Simon Fraser.
2918
2919         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2920         (makeRequest):
2921         (TEST):
2922
2923 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2924
2925         Unreviewed, rolling out r243450.
2926
2927         AppleWin and WinCairo port builds get broken.
2928
2929         Reverted changeset:
2930
2931         "Add test for fix of #196095"
2932         https://bugs.webkit.org/show_bug.cgi?id=196097
2933         https://trac.webkit.org/changeset/243450
2934
2935 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2936
2937         Unreviewed, rolling out r243465.
2938         https://bugs.webkit.org/show_bug.cgi?id=196226
2939
2940         the test doesn't build (Requested by thorton on #webkit).
2941
2942         Reverted changeset:
2943
2944         "Do not terminate the NetworkProcess if a third party
2945         application sends a NSCredential with a SecIdentityRef"
2946         https://bugs.webkit.org/show_bug.cgi?id=196213
2947         https://trac.webkit.org/changeset/243465
2948
2949 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2950
2951         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2952         https://bugs.webkit.org/show_bug.cgi?id=196213
2953
2954         Reviewed by Geoff Garen.
2955
2956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2957         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2958         (credentialWithIdentityAndKeychainPath):
2959         (-[ChallengeDelegate webView:didFinishNavigation:]):
2960         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2961         (TestWebKitAPI::TEST):
2962
2963 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2964
2965         [ews-build] Gracefully handle missing patch_id in events
2966         https://bugs.webkit.org/show_bug.cgi?id=196216
2967
2968         Reviewed by Lucas Forschler.
2969
2970         * BuildSlaveSupport/ews-build/events.py:
2971
2972 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2973
2974         [ews-build] use lz4 compression for improving buildbot performance
2975         https://bugs.webkit.org/show_bug.cgi?id=196155
2976
2977         Reviewed by Lucas Forschler.
2978
2979         * BuildSlaveSupport/ews-build/master.cfg:
2980
2981 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2982
2983         Pull some API testing helper methods out of TestWKWebView
2984         https://bugs.webkit.org/show_bug.cgi?id=196212
2985
2986         Reviewed by Tim Horton.
2987
2988         Refactor some more API testing utility methods, so that they can be used in
2989         tests that do not use TestWKWebView.
2990
2991         * TestWebKitAPI/cocoa/TestWKWebView.h:
2992         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2993         (-[WKWebView loadTestPageNamed:]):
2994         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2995         (-[WKWebView synchronouslyLoadHTMLString:]):
2996         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2997         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2998         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2999         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3000         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3001
3002 2019-03-25  Jer Noble  <jer.noble@apple.com>
3003
3004         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3005         https://bugs.webkit.org/show_bug.cgi?id=196097
3006
3007         Reviewed by Eric Carlson.
3008
3009         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3010
3011         * DumpRenderTree/mac/DumpRenderTree.mm:
3012         (resetWebPreferencesToConsistentValues):
3013         * WebKitTestRunner/TestController.cpp:
3014         (WTR::TestController::resetPreferencesToConsistentValues):
3015
3016 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3017
3018         Pull IPadUserInterfaceSwizzler out into a separate header file
3019         https://bugs.webkit.org/show_bug.cgi?id=196193
3020
3021         Reviewed by Anders Carlsson.
3022
3023         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3024         be used in other API tests.
3025
3026         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3027         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3028         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3029         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3030         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3031         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3032         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3033
3034 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3035
3036         Remove NavigatorContentUtils in WebCore/Modules
3037         https://bugs.webkit.org/show_bug.cgi?id=196070
3038
3039         Reviewed by Alex Christensen.
3040
3041         NavigatorContentUtils was to support the custom scheme spec [1].
3042         However, in WebKit side, no port has supported the feature in
3043         WebKit layer after EFL port was removed. So there has been the
3044         only IDL implementation of the NavigatorContentUtils in WebCore.
3045         So we don't need to keep the implementation in WebCore anymore.
3046
3047         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3048
3049         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3050
3051 2019-03-24  Andy Estes  <aestes@apple.com>
3052
3053         [watchOS] Remove unused Proximity Networking code
3054         https://bugs.webkit.org/show_bug.cgi?id=196188
3055
3056         Reviewed by Tim Horton.
3057
3058         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3059         (TEST):
3060
3061 2019-03-23  Keith Miller  <keith_miller@apple.com>
3062
3063         Refactor clz/ctz and fix getLSBSet.
3064         https://bugs.webkit.org/show_bug.cgi?id=196162
3065
3066         Reviewed by Saam Barati.
3067
3068         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3069
3070         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3071         (TestWebKitAPI::TEST):
3072
3073 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3074
3075         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3076         https://bugs.webkit.org/show_bug.cgi?id=196143
3077
3078         Reviewed by Michael Catanzaro.
3079
3080         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3081         directories.
3082
3083         * Scripts/webkitpy/style/checkers/cpp.py:
3084         (check_identifier_name_in_declaration):
3085         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3086         (WebKitStyleTest.test_names):
3087
3088 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3089
3090         [Flatpak] Manifest expanding fails for qt WPE extension
3091         https://bugs.webkit.org/show_bug.cgi?id=196148
3092
3093         Reviewed by Alex Christensen.
3094
3095         * flatpak/flatpakutils.py:
3096         (expand_submodules_recurse): The last recurse manifest expand
3097         iteration might lead to a single module so take it into account
3098         and don't try to recurse further.
3099
3100 2019-03-22  Chris Dumez  <cdumez@apple.com>
3101
3102         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3103         https://bugs.webkit.org/show_bug.cgi?id=195348
3104         <rdar://problem/48622090>
3105
3106         Reviewed by Alex Christensen.
3107
3108         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3109         to NO when test.options().shouldIgnoreMetaViewport is false.
3110
3111         * WebKitTestRunner/ios/TestControllerIOS.mm:
3112         (WTR::TestController::platformConfigureViewForTest):
3113
3114 2019-03-22  Chris Dumez  <cdumez@apple.com>
3115
3116         Prewarmed processes should be usable with any website data store
3117         https://bugs.webkit.org/show_bug.cgi?id=196104
3118
3119         Reviewed by Alex Christensen.
3120
3121         Add API test coverage.
3122
3123         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3124         (runInitialWarmedProcessUsedTest):
3125         (TEST):
3126
3127 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3128
3129         Back out local changes to Alex's Subversion working directory
3130
3131         They were accidentally committed.
3132
3133         * Scripts/webkitpy/common/system/abstractexecutive.py:
3134         (AbstractExecutive.wait_newest):
3135         * Scripts/webkitpy/common/system/executive.py:
3136         (Executive.running_pids):
3137         * Scripts/webkitpy/common/system/executive_mock.py:
3138         (MockExecutive.running_pids):
3139         * Scripts/webkitpy/common/system/executive_unittest.py:
3140         (ExecutiveTest.serial_test_running_pids):
3141         * Scripts/webkitpy/port/darwin.py:
3142         (DarwinPort.check_for_leaks):
3143         * Scripts/webkitpy/port/leakdetector.py:
3144         (LeakDetector.check_for_leaks):
3145         - This was the hack attached to Bug 193772.
3146
3147         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3148         (+[WebKitTestRunnerEvent mouseLocation]):
3149         - This works around a crash on an internal build.
3150
3151 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3152
3153         Fix the build after r243354
3154         https://bugs.webkit.org/show_bug.cgi?id=196138
3155         <rdar://problem/49145951>
3156
3157         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3158         (TEST):
3159         * TestWebKitAPI/ios/UIKitSPI.h:
3160
3161 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3162
3163         Adopt UIWKDocumentContext
3164         https://bugs.webkit.org/show_bug.cgi?id=196040
3165         <rdar://problem/48642440>
3166
3167         Reviewed by Ryosuke Niwa.
3168
3169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3170         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3171         (makeRequest):
3172         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3173         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3174         (applyStyle):
3175         (TEST):
3176         Add tests for UIWKDocumentContext.
3177
3178         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3179         (TEST):
3180         (recursiveFindWKContentView): Deleted.
3181         * TestWebKitAPI/cocoa/TestWKWebView.h:
3182         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3183         (recursiveFindWKContentView):
3184         (-[TestWKWebView wkContentView]):
3185         * TestWebKitAPI/ios/UIKitSPI.h:
3186         Share the WKContentView finding code between tests.
3187
3188 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3189
3190         [iOS WK2] Turn on async overflow scrolling by default
3191         https://bugs.webkit.org/show_bug.cgi?id=196011
3192         rdar://problem/48453859
3193
3194         Reviewed by Antti Koivisto.
3195         
3196         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3197         since so many basic layout tests have different results when compositing is triggered for
3198         overflow.
3199         
3200         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3201
3202         * WebKitTestRunner/TestController.cpp:
3203         (WTR::TestController::resetPreferencesToConsistentValues):
3204
3205 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3206
3207         [ews-build] Retry API test in case of failures
3208         https://bugs.webkit.org/show_bug.cgi?id=196004
3209
3210         Reviewed by Lucas Forschler.
3211
3212         * BuildSlaveSupport/ews-build/steps.py:
3213         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3214         (CompileWebKitToT.doStepIf): Ditto.
3215         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3216         (ReRunAPITests): Re-run API tests.
3217         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3218         (RunAPITestsWithoutPatch): Run API tests without patch.
3219         (RunAPITestsWithoutPatch.doStepIf):
3220         (RunAPITestsWithoutPatch.hideStepIf):
3221         (RunAPITestsWithoutPatch.evaluateCommand):
3222         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3223         (AnalyzeAPITestsResults.start):
3224         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3225         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3226         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3227         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3228
3229 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3230
3231         [ews-build] Update queues configurations
3232         https://bugs.webkit.org/show_bug.cgi?id=196074
3233
3234         Reviewed by Dewei Zhu.
3235
3236         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3237         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3238
3239 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3240
3241         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3242         https://bugs.webkit.org/show_bug.cgi?id=195680
3243         <rdar://problem/48903534>
3244
3245         Unreviewed infrastructure fix.
3246
3247         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3248         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3249
3250 2019-03-21  Andy Estes  <aestes@apple.com>
3251
3252         [iOS] Apple Pay should be available in documents with no user agent scripts
3253         https://bugs.webkit.org/show_bug.cgi?id=196061
3254         <rdar://problem/48649391>
3255
3256         Reviewed by Brady Eidson.
3257
3258         Added API tests and related infrastructure.
3259
3260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3261         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3262         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3263         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3264         (TestWebKitAPI::TEST):
3265         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3266         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3267         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3268         * TestWebKitAPI/cocoa/TestProtocol.mm:
3269         (-[TestProtocol startLoading]):
3270         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3271         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3272         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3273         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3274
3275 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3276
3277         REGRESSSION (r243297): webkitpy tests broken
3278         https://bugs.webkit.org/show_bug.cgi?id=196108
3279
3280         Reviewed by Aakash Jain.
3281
3282         r243297 updated contributors.json, which broke a few unit tests.
3283
3284         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3285         (IRCCommandTest.test_whois):
3286         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3287
3288 2019-03-21  Chris Dumez  <cdumez@apple.com>
3289
3290         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3291         https://bugs.webkit.org/show_bug.cgi?id=196041
3292         <rdar://problem/49083230>
3293
3294         Reviewed by Alex Christensen.
3295
3296         Add API test coverage.
3297
3298         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3299         (TEST):
3300
3301 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3302
3303         Add SPI to inform applications of WKContentRuleList actions
3304         https://bugs.webkit.org/show_bug.cgi?id=195965
3305         <rdar://problem/42664365>
3306
3307         Reviewed by Geoff Garen.
3308
3309         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3310         (TestWebKitAPI::allActionsForResourceLoad):
3311         (TestWebKitAPI::testRequest):
3312         (TestWebKitAPI::TEST_F):
3313         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3314         (Notification::description):
3315         (Notification::operator== const):
3316         (toVector):
3317         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3318         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3319         (makeContentRuleList):
3320         (TEST):
3321         (makeWarnContentRuleList): Deleted.
3322
3323 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3324
3325         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3326         https://bugs.webkit.org/show_bug.cgi?id=196088
3327
3328         Reviewed by Brian Burg.
3329
3330         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3331         Support checks when only one platform is specified. Also deprecate macosx() and
3332         force the use of macos() instead.
3333
3334         * Scripts/webkitpy/style/checkers/cpp.py:
3335         (check_min_versions_of_wk_api_available):
3336         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3337         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3338
3339 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3340
3341         Update status inactive committers' status to 'contributor'.
3342
3343         * Scripts/webkitpy/common/config/contributors.json:
3344
3345 2019-03-21  Xan Lopez  <xan@igalia.com>
3346
3347         [JSC][x86] Drop support for x87 floating point
3348         https://bugs.webkit.org/show_bug.cgi?id=194853
3349
3350         Reviewed by Don Olmstead.
3351
3352         Force SSE2 on x86/32bit builds.
3353
3354         * Scripts/webkitdirs.pm:
3355         (generateBuildSystemFromCMakeProject):
3356
3357 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3358
3359         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3360         https://bugs.webkit.org/show_bug.cgi?id=196073
3361
3362         Reviewed by Michael Catanzaro.
3363
3364         Add test cases to check functions and constructors with no arguments but receiving user data.
3365
3366         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3367         (checkUserData):
3368         (testJSCFunction):
3369         (fooCreateWithUserData):
3370         (testJSCClass):
3371
3372 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3373
3374         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3375
3376         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3377
3378         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3379
3380 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3381
3382         [GTK][WPE] Add API to provide geolocation information
3383         https://bugs.webkit.org/show_bug.cgi?id=195940
3384
3385         Reviewed by Michael Catanzaro.
3386
3387         Add a new test to check the new API.
3388
3389         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3390         (testGeolocationManagerCurrentPosition):
3391         (testGeolocationManagerWatchPosition):
3392         (beforeAll):
3393         (afterAll):
3394         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3395         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3396         (beforeAll): Ditto.
3397         * TestWebKitAPI/glib/CMakeLists.txt:
3398
3399 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3400
3401         [GLib] Returning G_TYPE_OBJECT from a method does not work
3402         https://bugs.webkit.org/show_bug.cgi?id=195574
3403
3404         Reviewed by Michael Catanzaro.
3405
3406         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3407
3408         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3409         (getGFile):
3410         (getParent):
3411         (createGString):
3412         (getGString):
3413         (getGStringCopyWillRaise):
3414         (getGStringCopy):
3415         (getGStringStr):
3416         (getGStringLen):
3417         (freeGString):
3418         (testJSCClass):
3419
3420 2019-03-20  Saam Barati  <sbarati@apple.com>
3421
3422         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3423         https://bugs.webkit.org/show_bug.cgi?id=195721
3424
3425         Reviewed by Filip Pizlo.
3426
3427         * Scripts/run-javascriptcore-tests:
3428
3429 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3430
3431         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3432         https://bugs.webkit.org/show_bug.cgi?id=196049
3433
3434         Reviewed by Tim Horton.
3435
3436         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3437         overflow scrolling in general, so rename it.
3438
3439         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3440
3441 2019-03-20  Daniel Bates  <dabates@apple.com>
3442
3443         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3444         https://bugs.webkit.org/show_bug.cgi?id=196031
3445         <rdar://problem/49078172>
3446
3447         Reviewed by Tim Horton.
3448
3449         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3450         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3451         same code path used when the Done button is pressed to dismiss the <select> picker.
3452
3453         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3454         (TestWebKitAPI::TEST):
3455
3456 2019-03-20  Chris Dumez  <cdumez@apple.com>
3457
3458         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3459         https://bugs.webkit.org/show_bug.cgi?id=196029
3460         <rdar://problem/48954651>
3461
3462         Reviewed by Tim Horton.
3463
3464         Add API test coverage.
3465
3466         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3467
3468 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3469
3470         [ews-build] Improve failure summary string for ApplyPatch step
3471         https://bugs.webkit.org/show_bug.cgi?id=195995
3472
3473         Reviewed by Alexey Proskuryakov.
3474
3475         * BuildSlaveSupport/ews-build/steps.py:
3476         (ApplyPatch.getResultSummary): Override getResultSummary.
3477
3478 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3479
3480         AX: Implement support for new meter ARIA role
3481         https://bugs.webkit.org/show_bug.cgi?id=195966
3482
3483         Reviewed by Chris Fleizach.
3484
3485         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3486         to AXLevelIndicator.
3487
3488         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3489
3490 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3491
3492         [WebAuthN] Implement FIDO AppID extension
3493         https://bugs.webkit.org/show_bug.cgi?id=143491
3494         <rdar://problem/48298273>
3495
3496         Reviewed by Brent Fulgham.
3497
3498         Add a test that covers the new flag of convertToU2fSignCommand.
3499
3500         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3501         (TestWebKitAPI::TEST):
3502         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3503         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3504         (TestWebKitAPI::TEST):
3505
3506 2019-03-19  Keith Rollin  <krollin@apple.com>
3507
3508         Add support for more platforms to generate-xcfilelists
3509         https://bugs.webkit.org/show_bug.cgi?id=195977
3510
3511         Reviewed by Alexey Proskuryakov.
3512
3513         generate-xcfilelists incorrectly complains when involved with building
3514         WebKit for iphonesimulator:
3515
3516             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3517             …
3518             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3519
3520         Address this by teaching generate-xcfilelists about more platforms.
3521
3522         * Scripts/generate-xcfilelists:
3523
3524 2019-03-19  John Wilander  <wilander@apple.com>
3525
3526         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3527         https://bugs.webkit.org/show_bug.cgi?id=195923
3528         <rdar://problem/49001272>
3529
3530         Reviewed by Alex Christensen.
3531
3532         This patch does the following to the TestRunner:
3533         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3534         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3535         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3536
3537         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3538         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3539         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3540         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3541         * WebKitTestRunner/TestController.cpp:
3542         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3543         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3544         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3545         * WebKitTestRunner/TestController.h:
3546         * WebKitTestRunner/TestInvocation.cpp:
3547         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3548
3549 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3550
3551         [CMake] Support more clang and gcc sanitizers
3552         https://bugs.webkit.org/show_bug.cgi?id=195956
3553
3554         Reviewed by Michael Catanzaro.
3555
3556         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3557
3558 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3559
3560         [ews-build] Improve summary for PrintConfiguration step
3561         https://bugs.webkit.org/show_bug.cgi?id=195945
3562
3563         Reviewed by Lucas Forschler.
3564
3565         * BuildSlaveSupport/ews-build/steps.py:
3566         (PrintConfiguration.getResultSummary): Override getResultSummary.
3567
3568 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3569
3570         [ews-build] Improve summary for CheckOutSource step
3571         https://bugs.webkit.org/show_bug.cgi?id=195963
3572
3573         Reviewed by Lucas Forschler.
3574
3575         * BuildSlaveSupport/ews-build/steps.py:
3576         (CheckOutSource.getResultSummary):
3577
3578 2019-03-19  Daniel Bates  <dabates@apple.com>
3579
3580         [iOS] Focus not preserved when switching between tabs
3581         https://bugs.webkit.org/show_bug.cgi?id=195820
3582         <rdar://problem/43614450>
3583
3584         Reviewed by Brent Fulgham.
3585
3586         Add tests to ensure that we restore focus when resigning and becoming first responder.
3587
3588         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3589         (TestWebKitAPI::TEST):
3590
3591 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3592
3593         Make WTFLogChannelState and WTFLogLevel enum classes
3594         https://bugs.webkit.org/show_bug.cgi?id=195904
3595
3596         Reviewed by Eric Carlson.
3597
3598         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3599         (TestWebKitAPI::TEST_F):
3600
3601 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3602
3603         [GStreamer][EME] Backported mssdemux protection data crash fix
3604         https://bugs.webkit.org/show_bug.cgi?id=195918
3605
3606         Reviewed by Philippe Normand.
3607
3608         * gstreamer/jhbuild.modules:
3609         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3610
3611 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3612
3613         Unreviewed, rolling out r243132.
3614
3615         Broke GTK build
3616
3617         Reverted changeset:
3618
3619         "Make WTFLogChannelState and WTFLogLevel enum classes"
3620         https://bugs.webkit.org/show_bug.cgi?id=195904
3621         https://trac.webkit.org/changeset/243132
3622
3623 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3624
3625         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3626
3627         * Scripts/webkitdirs.pm:
3628         (builtDylibPathForName): Adjust the shared library name that's changed
3629         with the API version bump in r243073.
3630
3631 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3632
3633         Make WTFLogChannelState and WTFLogLevel enum classes
3634         https://bugs.webkit.org/show_bug.cgi?id=195904
3635
3636         Reviewed by Eric Carlson.
3637
3638         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3639         (TestWebKitAPI::TEST_F):
3640
3641 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3642
3643         Disable flaky test added in r2431100
3644         https://webkit.org/b/195785
3645
3646         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3647         (TestWebKitAPI::TEST):
3648         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3649
3650 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3651
3652         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3653         https://bugs.webkit.org/show_bug.cgi?id=195916
3654
3655         Reviewed by Tim Horton.
3656
3657         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3658         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3659
3660 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3661
3662         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3663
3664         * Scripts/webkitpy/common/config/contributors.json:
3665
3666 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3667
3668         Implement DownloadMonitor to prevent long-running slow downloads from background apps