1 2016-08-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3 Skip to check directories existence in build-webkit
4 https://bugs.webkit.org/show_bug.cgi?id=160691
6 Reviewed by Alex Christensen.
8 CMake checks if directories are there itself. So CMake ports
9 don't need to check it in the build-webkit script.
11 * Scripts/build-webkit:
12 * Scripts/webkitdirs.pm:
16 2016-08-12 Alex Christensen <achristensen@webkit.org>
18 Make URLParser work with URLs missing URL parts
19 https://bugs.webkit.org/show_bug.cgi?id=160824
21 Reviewed by Brady Eidson.
23 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
25 (TestWebKitAPI::checkURL):
26 (TestWebKitAPI::TEST_F):
27 (TestWebKitAPI::eq): Deleted.
29 2016-08-12 John Wilander <wilander@apple.com>
31 Add HashCountedSet API tests to TestWTFLibrary target
32 https://bugs.webkit.org/show_bug.cgi?id=160815
34 Reviewed by Alex Christensen.
36 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
37 Added HashCountedSet.cpp and sorted the file reference section
38 according to UNIX sort.
40 2016-08-12 Ryosuke Niwa <rniwa@webkit.org>
42 run-benchmark should run JetStream 1.1 instead of 1.0.1
43 https://bugs.webkit.org/show_bug.cgi?id=160816
45 Reviewed by Filip Pizlo.
47 Use the latest JetStream 1.1 in run-benchmark.
49 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
50 (BenchmarkBuilder.__exit__):
51 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
52 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
53 change to JetStream directory.
55 2016-08-12 Alex Christensen <achristensen@webkit.org>
57 Initial URLParser implementation
58 https://bugs.webkit.org/show_bug.cgi?id=160811
60 Reviewed by Brady Eidson.
62 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
64 (TestWebKitAPI::checkURL):
65 (TestWebKitAPI::TEST_F):
67 2016-08-12 Brady Eidson <beidson@apple.com>
69 Fix the 32-bit Mac build after:
70 Add WK2 ExperimentalFeature support to MiniBrowser
71 https://bugs.webkit.org/show_bug.cgi?id=160788
75 Sprinkle "#if WK_API_ENABLED"s liberally.
77 * MiniBrowser/mac/AppDelegate.m:
78 (defaultConfiguration):
79 * MiniBrowser/mac/SettingsController.m:
80 (-[SettingsController _populateMenu]):
81 (-[SettingsController validateMenuItem:]):
83 2016-08-12 Philippe Normand <pnormand@igalia.com>
85 [GStreamer][OWR] Video rendering fixes
86 https://bugs.webkit.org/show_bug.cgi?id=160764
88 Reviewed by Xabier Rodriguez-Calvar.
90 * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
92 2016-08-12 Per Arne Vollan <pvollan@apple.com>
94 Add missing return statement in convertFast function added in r204376.
98 * Scripts/webkitpy/common/system/path.py:
99 (_CygPath.convertFast):
101 2016-08-11 Brady Eidson <beidson@apple.com>
103 Add WK2 ExperimentalFeature support to MiniBrowser.
104 https://bugs.webkit.org/show_bug.cgi?id=160788
106 Reviewed by Alex Christensen.
108 * MiniBrowser/mac/AppDelegate.h:
109 * MiniBrowser/mac/AppDelegate.m:
110 (defaultConfiguration):
111 (defaultPreferences):
113 * MiniBrowser/mac/SettingsController.m:
114 (-[SettingsController _populateMenu]):
115 (-[SettingsController validateMenuItem:]):
116 (-[SettingsController toggleExperimentalFeature:]):
118 2016-08-11 Aakash Jain <aakash_jain@apple.com>
120 Keep EWS logs for longer
121 https://bugs.webkit.org/show_bug.cgi?id=160776
123 Reviewed by Daniel Bates.
125 * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
127 2016-08-11 Simon Fraser <simon.fraser@apple.com>
129 iOS DRT/WTR project cleanup
130 https://bugs.webkit.org/show_bug.cgi?id=160778
132 Reviewed by Tim Horton.
134 Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
136 Remove AppDelegate.* which were unused.
138 Exclude ios/Launch.storyboard on more platforms.
140 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
141 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
142 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
143 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
144 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
145 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
146 (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
148 2016-08-11 Alex Christensen <achristensen@webkit.org>
150 Fix Yosemite bots' cookie accept policies after r204365.
151 https://bugs.webkit.org/show_bug.cgi?id=160758
153 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
155 This makes the test fully clean up after itself.
157 2016-08-11 Alex Christensen <achristensen@webkit.org>
159 Fix Yosemite bots' cookie accept policies after r204365.
160 https://bugs.webkit.org/show_bug.cgi?id=160758
162 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
164 I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
165 On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
166 On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
167 causing any problems because there are no other API tests that do anything with cookies.
168 My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
169 but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
170 to reset any bots that have run tests since r204365. I will commit a followup that sets it to originalCookieAcceptPolicy.
172 2016-08-11 Aakash Jain <aakash_jain@apple.com>
174 EWS should check if the patch is still valid before executing every major step
175 https://bugs.webkit.org/show_bug.cgi?id=160739
176 rdar://problem/27768813
178 Reviewed by Alexey Proskuryakov.
180 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
181 (CommitQueueTask.run): validate method is now executed in base class.
182 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
183 (EarlyWarningSystemTask.run): validate method is now executed in base class.
184 * Scripts/webkitpy/tool/bot/stylequeuetask.py:
185 (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
186 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
187 (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
188 that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
189 * Scripts/webkitpy/tool/commands/perfalizer.py:
190 (PerfalizerTask.validate): Added.
191 * Scripts/webkitpy/tool/commands/queues_unittest.py:
192 (test_manual_reject_during_processing): Updated test case.
194 2016-08-11 Alex Christensen <achristensen@webkit.org>
197 https://bugs.webkit.org/show_bug.cgi?id=160770
199 Reviewed by Sam Weinig.
201 * TestWebKitAPI/PlatformGTK.cmake:
202 * TestWebKitAPI/PlatformWin.cmake:
203 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
204 * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
205 (TestWebKitAPI::TEST_F):
207 2016-08-10 Simon Fraser <simon.fraser@apple.com>
209 [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
210 https://bugs.webkit.org/show_bug.cgi?id=160761
212 Reviewed by Tim Horton.
214 Give iOS DRT a Launch storyboard.
216 Have it use a UIViewController so future forms testing works correctly.
218 Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
219 can run in iPad mode.
221 Remove empty InfoPlist.strings files.
223 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
224 * DumpRenderTree/ios/Info.plist:
225 * DumpRenderTree/ios/Launch.storyboard: Added.
226 * DumpRenderTree/mac/DumpRenderTree.mm:
227 (createWebViewAndOffscreenWindow):
228 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
229 * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
230 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
231 (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
233 2016-08-11 Per Arne Vollan <pvollan@apple.com>
235 [Win] Unable to reliably run tests in parallel
236 https://bugs.webkit.org/show_bug.cgi?id=140914
238 Reviewed by Brent Fulgham.
240 The cygpath utility function can fail badly when running with multiple DumpRenderTree
241 processes. We can use string replacement to convert the Cygwin path to a Windows path
244 * Scripts/webkitpy/common/system/path.py:
246 * Scripts/webkitpy/port/driver.py:
247 (Driver._command_from_driver_input):
249 2016-08-10 Alex Christensen <achristensen@webkit.org>
251 Fix crash when changing cookie accept policy after r204327
252 https://bugs.webkit.org/show_bug.cgi?id=160758
254 Reviewed by Simon Fraser.
256 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
257 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
258 (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
260 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
262 2016-08-10 Simon Fraser <simon.fraser@apple.com>
264 [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
265 https://bugs.webkit.org/show_bug.cgi?id=160757
267 Reviewed by Tim Horton.
269 When programmatically creating the test UIWindow, make a root UIViewController and parent
270 the WKWebView in its view. This makes the app more like a normal UIKit application.
272 Move the WKWebView down 20px to avoid the status bar.
274 Give the UIWindow a gray background so it's obvious where the window and view positioned.
276 Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
278 Remove duplicate references to Launch.storyboard.
280 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
281 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
282 * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
283 (-[AppDelegate applicationWillResignActive:]): Deleted.
284 (-[AppDelegate applicationDidEnterBackground:]): Deleted.
285 (-[AppDelegate applicationWillEnterForeground:]): Deleted.
286 (-[AppDelegate applicationDidBecomeActive:]): Deleted.
287 (-[AppDelegate applicationWillTerminate:]): Deleted.
288 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
289 (WTR::viewRectForWindowRect):
290 (WTR::PlatformWebView::PlatformWebView):
291 (WTR::PlatformWebView::setWindowFrame):
293 2016-08-10 Simon Fraser <simon.fraser@apple.com>
295 [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
296 https://bugs.webkit.org/show_bug.cgi?id=160748
298 Reviewed by Tim Horton.
300 Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
301 opens the door for tests using other device sizes.
303 * WebKitTestRunner/ios/TestControllerIOS.mm:
304 (WTR::TestController::platformConfigureViewForTest):
306 2016-08-10 Simon Fraser <simon.fraser@apple.com>
308 Sort the feature flags in the FEATURE_DEFINES lines
309 https://bugs.webkit.org/show_bug.cgi?id=160742
311 Reviewed by Anders Carlsson.
313 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
315 2016-08-09 Simon Fraser <simon.fraser@apple.com>
317 Logging and other minor improvements to iOS webkitpy
318 https://bugs.webkit.org/show_bug.cgi?id=160722
320 Reviewed by Dan Bates.
322 Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
323 to make it easier to debug launching issues.
325 Have reset_preferences() reset the device, rather than just nuking the data
326 directory (which broke some versions of the simulator).
328 Make the Simulator.app launch in the background with open -g.
330 Wait for the simulator device to be in a known state in some more places.
332 * Scripts/webkitpy/port/ios.py:
333 (IOSSimulatorPort.setup_test_run):
334 (IOSSimulatorPort._quit_ios_simulator):
335 (IOSSimulatorPort.clean_up_test_run):
336 (IOSSimulatorPort.setup_environ_for_server):
337 (IOSSimulatorPort.reset_preferences):
338 * Scripts/webkitpy/xcode/simulator.py:
343 (Simulator.wait_until_device_is_booted):
344 (Simulator.wait_until_device_is_in_state):
346 (Simulator.delete_device):
347 (Simulator.reset_device):
348 (Simulator.lookup_or_create_device):
350 2016-08-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
352 [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
353 https://bugs.webkit.org/show_bug.cgi?id=160697
355 Reviewed by Antonio Gomes.
357 * Scripts/webkitpy/port/base.py:
358 (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
359 list of environment variables to copy.
361 2016-08-09 George Ruan <gruan@apple.com>
363 Implement functionality of media capture on iOS
364 https://bugs.webkit.org/show_bug.cgi?id=158945
365 <rdar://problem/26893343>
367 Reviewed by Tim Horton.
369 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
370 Capture feature on iOS.
372 2016-08-09 Saam Barati <sbarati@apple.com>
374 Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
375 https://bugs.webkit.org/show_bug.cgi?id=160671
376 <rdar://problem/27756112>
378 Reviewed by Mark Lam.
380 * Scripts/run-jsc-stress-tests:
382 2016-08-09 Alexey Proskuryakov <ap@apple.com>
384 Make directory reading code in iOSSimulatorDevices() more strict
385 https://bugs.webkit.org/show_bug.cgi?id=160702
387 Reviewed by Tim Horton.
389 * Scripts/webkitdirs.pm:
390 (iOSSimulatorDevices):
392 2016-08-06 Sam Weinig <sam@webkit.org>
394 Replace NodeOrString with std::variant<RefPtr<Node>, String>
395 https://bugs.webkit.org/show_bug.cgi?id=160638
397 Reviewed by Anders Carlsson.
399 * TestWebKitAPI/CMakeLists.txt:
400 * TestWebKitAPI/Tests/WTF/Variant.cpp:
401 Add additional tests for the initial state of std::variant and using
402 makeVisitor for visiting.
404 2016-08-09 Aakash Jain <aakash_jain@apple.com>
406 EWS logging should ensure the logging to file is stopped on queue termination
407 https://bugs.webkit.org/show_bug.cgi?id=160698
408 rdar://problem/24464570
410 Reviewed by Daniel Bates.
412 * Scripts/webkitpy/tool/bot/queueengine.py:
413 (QueueEngine._stopping): Stop logging to file on queue termination.
414 (QueueEngine._begin_logging): Configure the Python logger to log to file.
415 * Scripts/webkitpy/common/system/logutils.py:
416 (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
417 * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
418 (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
419 * Scripts/webkitpy/tool/commands/queues.py:
420 (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
421 (AbstractQueue.queue_log_path): Same.
422 (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
423 (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
424 which moved to QueueEngine now.
425 (PatchProcessingQueue.__init__): Same.
426 (CommitQueue.__init__): Same.
427 (AbstractReviewQueue.__init__): Same.
428 (StyleQueue.__init__): Same.
429 * Scripts/webkitpy/tool/commands/queues_unittest.py:
430 (TestCommitQueue): Removed host parameter.
431 (TestCommitQueue.__init__): Same.
432 (AbstractPatchQueueTest.test_next_patch): Same.
433 (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
434 (test_commit_queue_failure): Same.
435 (mock_run_webkit_patch):
436 (MockCommitQueueTask.results_from_patch_test_run): Same.
437 (test_rollout_lands): Same.
438 (test_non_valid_patch): Same.
439 (test_auto_retry): Same.
440 (test_style_queue_with_watch_list_exception): Same.
441 (TestQueue.__init__): Deleted.
442 (TestReviewQueue.__init__): Deleted.
443 (TestFeederQueue.__init__): Deleted.
445 2016-08-09 Konstantin Tokarev <annulen@yandex.ru>
447 webkit-gtk tarball fails to build due to missing files
448 https://bugs.webkit.org/show_bug.cgi?id=160684
450 Reviewed by Alex Christensen.
452 * gtk/manifest.txt.in: Added back spi directories.
454 2016-08-09 Carlos Alberto Lopez Perez <clopez@igalia.com>
456 [GTK] Build the jhbuild with -O2 optimization level by default
457 https://bugs.webkit.org/show_bug.cgi?id=160544
459 Reviewed by Michael Catanzaro.
461 * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
462 which don't increases the required disk space significatively and
463 provides better debug information than no passing it.
465 2016-08-09 Csaba Osztrogonác <ossy@webkit.org>
467 Allow more --cmakeargs option in build-jsc and build-webkit
468 https://bugs.webkit.org/show_bug.cgi?id=160340
470 Reviewed by Michael Catanzaro.
473 * Scripts/build-webkit:
475 2016-08-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
477 Do not check if WebKitLibraries folder exists on EFL and GTK
478 https://bugs.webkit.org/show_bug.cgi?id=160659
480 Reviewed by Csaba Osztrogonác.
482 Though WebKitLibraries is only needed by mac and win ports,
483 EFL and GTK ports have checked whether it exists.
485 * Scripts/build-webkit:
487 2016-08-08 Aakash Jain <aakash_jain@apple.com>
489 Some EWS console logs doesn't go to log file
490 https://bugs.webkit.org/show_bug.cgi?id=160585
491 rdar://problem/24464570
493 Reviewed by Daniel Bates.
495 * Scripts/webkitpy/common/system/logutils.py:
496 (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
497 any possible overwriting.
498 * Scripts/webkitpy/common/system/filesystem.py:
499 (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
500 * Scripts/webkitpy/common/system/filesystem_mock.py:
501 (MockFileSystem.open_text_file_for_writing): Same.
502 * Scripts/webkitpy/common/system/filesystem_unittest.py:
503 (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
504 (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
505 * Scripts/webkitpy/tool/commands/queues.py:
506 (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
507 This will ensure that all the sub-modules inside webkitpy will log to file.
509 2016-08-08 Simon Fraser <simon.fraser@apple.com>
511 Have the iOS platform interit from the Apple platform in webkitpy
512 https://bugs.webkit.org/show_bug.cgi?id=160672
514 Reviewed by Dan Bates.
516 The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
517 Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
520 Since WinPort also inherits from ApplePort, it needs to stub out some things
521 that are unavailable on Windows (leaks, sampling).
523 Some SnowLeopard-related code and the associated test were removed.
525 * Scripts/webkitpy/port/apple.py:
526 (ApplePort.__init__):
528 (ApplePort._make_leak_detector):
529 (ApplePort.default_timeout_ms):
530 (ApplePort.supports_per_test_timeout):
531 (ApplePort.should_retry_crashes):
532 (ApplePort._generate_all_test_configurations):
533 (ApplePort.check_for_leaks):
534 (ApplePort.print_leaks_summary):
535 (ApplePort._path_to_webcore_library):
536 (ApplePort.show_results_html_file):
537 (ApplePort._merge_crash_logs):
538 (ApplePort._look_for_all_crash_logs_in_log_dir):
539 (ApplePort._get_crash_log):
540 (ApplePort.look_for_new_crash_logs):
541 (ApplePort.sample_process):
542 (ApplePort.sample_file_path):
543 (ApplePort.look_for_new_samples):
544 (ApplePort._path_to_helper):
545 (ApplePort.determine_full_port_name): Deleted.
546 * Scripts/webkitpy/port/ios.py:
548 (IOSSimulatorPort.__init__):
549 (IOSSimulatorPort.default_timeout_ms): Deleted.
550 (IOSSimulatorPort.supports_per_test_timeout): Deleted.
551 (IOSSimulatorPort.should_retry_crashes): Deleted.
552 (IOSSimulatorPort.check_for_leaks): Deleted.
553 (IOSSimulatorPort.print_leaks_summary): Deleted.
554 (IOSSimulatorPort._path_to_webcore_library): Deleted.
555 (IOSSimulatorPort.show_results_html_file): Deleted.
556 (IOSSimulatorPort.sample_file_path): Deleted.
557 (IOSSimulatorPort._merge_crash_logs): Deleted.
558 (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
559 (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
560 (IOSSimulatorPort.look_for_new_samples): Deleted.
561 (IOSSimulatorPort.sample_process): Deleted.
562 (IOSSimulatorPort._path_to_helper): Deleted.
563 (IOSSimulatorPort.make_command): Deleted.
564 * Scripts/webkitpy/port/mac.py:
566 (MacPort.make_command):
567 (MacPort._build_java_test_support):
569 (MacPort.default_timeout_ms): Deleted.
570 (MacPort.supports_per_test_timeout): Deleted.
571 (MacPort.should_retry_crashes): Deleted.
572 (MacPort.default_child_processes): Deleted.
573 (MacPort.check_for_leaks): Deleted.
574 (MacPort.print_leaks_summary): Deleted.
575 (MacPort._path_to_webcore_library): Deleted.
576 (MacPort.show_results_html_file): Deleted.
577 (MacPort.sample_file_path): Deleted.
578 (MacPort._merge_crash_logs): Deleted.
579 (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
580 (MacPort.look_for_new_crash_logs): Deleted.
581 (MacPort.look_for_new_samples): Deleted.
582 (MacPort.sample_process): Deleted.
583 (MacPort._path_to_helper): Deleted.
584 * Scripts/webkitpy/port/mac_unittest.py:
585 (MacTest.test_default_child_processes): Deleted.
586 * Scripts/webkitpy/port/win.py:
587 (WinPort.look_for_new_samples):
589 (WinPort.sample_process):
590 (WinPort._make_leak_detector):
591 (WinPort.check_for_leaks):
592 (WinPort.print_leaks_summary):
593 (WinPort._path_to_webcore_library):
595 2016-08-08 Matt Baker <mattbaker@apple.com>
597 Unreviewed: moved myself to the reviewers list.
599 * Scripts/webkitpy/common/config/contributors.json:
601 2016-08-08 Chris Dumez <cdumez@apple.com>
603 Update API tests in mac/SetDocumentURI.mm after r204247
604 https://bugs.webkit.org/show_bug.cgi?id=160660
606 Reviewed by Alex Christensen.
608 * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
609 (TestWebKitAPI::TEST):
611 2016-08-08 Jonathan Bedard <jbedard@apple.com>
613 run-webkit-tests should trigger a spindump when WebContent process is unresponsive
614 https://bugs.webkit.org/show_bug.cgi?id=159827
616 Reviewed by Daniel Bates.
618 This change was spurred by a process hang which occurred between tests and did
619 not produce a meaningful crashlog.
621 * Scripts/webkitpy/port/driver.py:
622 (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
624 * Scripts/webkitpy/port/ios.py:
626 (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
627 * Scripts/webkitpy/port/mac.py:
629 (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
631 * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
632 * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
634 * WebKitTestRunner/TestController.h:
635 (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
636 * WebKitTestRunner/TestInvocation.cpp:
637 (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
639 2016-08-07 Dan Bernstein <mitz@apple.com>
641 [Cocoa] Reply block leaks if the remote object doesn’t call it
642 https://bugs.webkit.org/show_bug.cgi?id=160642
644 Reviewed by Sam Weinig.
646 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
647 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
648 (TEST): Added a test case that checks that the reply block is released even when it’s not
650 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
651 (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
652 calling the completion handler.
654 2016-08-07 Chris Dumez <cdumez@apple.com>
656 Write API test to cover crash fix in r204135
657 https://bugs.webkit.org/show_bug.cgi?id=160587
659 Reviewed by Darin Adler.
661 Add API test to cover crash fix in r204135. This reproduces the crash
662 by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
665 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
666 (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
669 2016-08-06 Chris Dumez <cdumez@apple.com>
671 Unreviewed, rolling out r204226.
677 "Write API test to cover crash fix in r204135"
678 https://bugs.webkit.org/show_bug.cgi?id=160587
679 http://trac.webkit.org/changeset/204226
681 2016-08-06 Aakash Jain <aakash_jain@apple.com>
683 EWS Style Queue fails to process patches which fails validation
684 https://bugs.webkit.org/show_bug.cgi?id=160632
686 Reviewed by Alexey Proskuryakov.
688 * Scripts/webkitpy/tool/bot/stylequeuetask.py:
689 (StyleQueueTask.validate): Add more information about validation failure.
690 (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
691 * Scripts/webkitpy/tool/commands/queues_unittest.py:
692 (test_non_valid_patch): Add a unit test to test the above code path.
694 2016-08-06 Sam Weinig <sam@webkit.org>
696 WTF needs a variant implementation
697 https://bugs.webkit.org/show_bug.cgi?id=160618
699 Reviewed by Darin Adler.
701 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
702 * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
703 Add tests for the variant implementation.
705 2016-08-06 Chris Dumez <cdumez@apple.com>
707 Write API test to cover crash fix in r204135
708 https://bugs.webkit.org/show_bug.cgi?id=160587
710 Reviewed by Darin Adler.
712 Add API test to cover crash fix in r204135. This reproduces the crash
713 by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
716 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
717 (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
720 2016-08-05 Tim Horton <timothy_horton@apple.com>
722 run-api-tests should use a headed simulator
723 https://bugs.webkit.org/show_bug.cgi?id=160611
725 Reviewed by Sam Weinig.
727 CADisplayLink doesn't work in a headless simulator, but is
728 vital for the proper functioning of WebKit2 painting on iOS.
729 So, we should not use a headless simulator.
731 * Scripts/run-api-tests:
732 Launch a simulator app, don't just boot the simulator.
734 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
735 Re-enable a test that works now.
737 2016-08-05 Dan Bernstein <mitz@apple.com>
739 [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
740 https://bugs.webkit.org/show_bug.cgi?id=160589
742 Reviewed by Tim Horton.
744 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
745 (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
746 blocks, which wasn’t caught because the test wasn’t run correctly.
747 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
748 (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
749 added a test that sends over an NSRange.
750 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
751 (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
752 handler with the range‘s location and length.
754 2016-08-05 Enrica Casucci <enrica@apple.com>
756 Fixing tests failing after r204175.
760 * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
762 2016-08-05 Enrica Casucci <enrica@apple.com>
764 Build fix after 204053.
768 * TestWebKitAPI/Configurations/Base.xcconfig:
769 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
770 (-[MockContentFilterEnabler initWithCoder:]):
771 (-[MockContentFilterEnabler dealloc]):
773 2016-08-05 Konstantin Tokarev <annulen@yandex.ru>
775 Print test name in "Last character read from DRT..." error message.
776 https://bugs.webkit.org/show_bug.cgi?id=160559
778 Reviewed by Michael Catanzaro.
780 * Scripts/webkitpy/port/driver.py:
782 (Driver._read_first_block):
783 (Driver._read_optional_image_block):
784 (Driver._read_block):
785 * Scripts/webkitpy/port/driver_unittest.py:
786 (DriverTest.test_read_block):
787 (DriverTest.test_read_binary_block):
788 (DriverTest.test_read_base64_block):
790 2016-08-05 Commit Queue <commit-queue@webkit.org>
792 Unreviewed, rolling out r204123.
793 https://bugs.webkit.org/show_bug.cgi?id=160597
795 Caused layout test timeouts on Windows. (Requested by perarne
800 "[Win] Unable to reliably run tests in parallel"
801 https://bugs.webkit.org/show_bug.cgi?id=140914
802 http://trac.webkit.org/changeset/204123
804 2016-08-04 Saam Barati <sbarati@apple.com>
806 Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
807 https://bugs.webkit.org/show_bug.cgi?id=151241
809 Reviewed by Benjamin Poulain.
811 * Scripts/run-jsc-stress-tests:
813 2016-08-04 Dean Johnson <dean_johnson@apple.com>
815 UI improvements to Flakiness Dashboard.
816 https://bugs.webkit.org/show_bug.cgi?id=153295
818 Reviewed by Alexey Proskuryakov.
820 * TestResultServer/static-dashboards/flakiness_dashboard.css:
821 (td.options-container): Center text in most fields.
822 * TestResultServer/static-dashboards/flakiness_dashboard.js:
823 (createBugHTML): Text/Grammar updates.
824 (tableHeaders): Ditto.
825 (htmlForSingleTestRow): Ditto.
826 (headerForTestTableHtml): Ditto.
827 * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
828 (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
830 2016-08-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
832 [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
833 https://bugs.webkit.org/show_bug.cgi?id=160518
835 Reviewed by Michael Catanzaro.
837 * Scripts/webkitpy/thirdparty/__init__.py:
838 (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
839 * gtk/install-dependencies:
841 2016-08-04 Alexey Proskuryakov <ap@apple.com>
843 Optimize bot watcher's dashboard a little
844 https://bugs.webkit.org/show_bug.cgi?id=160515
845 rdar://problem/26096900
847 Reviewed by Lucas Forschler.
849 Made re-sorting after loading an iteration more efficient.
851 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
852 (BuildbotIteration.prototype._updateWithData):
853 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
854 (BuildbotQueue.prototype.updateIterationPosition):
856 2016-08-04 Per Arne Vollan <pvollan@apple.com>
858 [Win] Unable to reliably run tests in parallel
859 https://bugs.webkit.org/show_bug.cgi?id=140914
861 Reviewed by Brent Fulgham.
863 The cygpath utility function can fail badly when running with multiple DumpRenderTree
864 processes. We can use string replacement to convert the Cygwin path to a Windows path
867 * Scripts/webkitpy/common/system/path.py:
869 * Scripts/webkitpy/port/driver.py:
870 (Driver._command_from_driver_input):
872 2016-08-03 Aakash Jain <aakash_jain@apple.com>
874 Document instructions for increasing process and file limits
875 https://bugs.webkit.org/show_bug.cgi?id=160528
876 rdar://problem/24777576
878 Reviewed by Alexey Proskuryakov.
880 * Scripts/webkitpy/port/ios.py:
881 (IOSSimulatorPort.default_child_processes):
883 2016-08-03 Anders Carlsson <andersca@apple.com>
885 Remove the Objective-C bindings generator
886 https://bugs.webkit.org/show_bug.cgi?id=160526
888 Reviewed by Sam Weinig.
890 * Scripts/run-bindings-tests:
893 2016-08-03 Tim Horton <timothy_horton@apple.com>
895 Revise a TestWebKitAPI comment to mention the actual underlying problem
897 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
898 Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
900 2016-08-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
902 Benchmark test content-animation timeouts always
903 https://bugs.webkit.org/show_bug.cgi?id=160057
905 Reviewed by Simon Fraser.
907 * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
908 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
911 2016-08-02 Nan Wang <n_wang@apple.com>
913 AX: Simulated touch events are not working on iOS
914 https://bugs.webkit.org/show_bug.cgi?id=160395
915 <rdar://problem/27633597>
917 Reviewed by Chris Fleizach.
919 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
920 (WTR::AccessibilityUIElement::press):
921 (WTR::AccessibilityUIElement::setSelectedChild):
923 2016-08-02 Filip Pizlo <fpizlo@apple.com>
925 run-javascriptcore-tests should accept multiple --extra-tests
926 https://bugs.webkit.org/show_bug.cgi?id=160486
928 Reviewed by Saam Barati.
930 We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
931 test suites. This does it by using GetOpt::Long's array support.
933 * Scripts/run-javascriptcore-tests:
936 2016-08-02 Enrica Casucci <enrica@apple.com>
938 Allow building with content filtering disabled.
939 https://bugs.webkit.org/show_bug.cgi?id=160454
941 Reviewed by Simon Fraser.
943 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
945 2016-08-02 Brady Eidson <beidson@apple.com>
947 Removing IndexedDB WebsiteData can fail for some users.
948 https://bugs.webkit.org/show_bug.cgi?id=160463
950 Reviewed by Alex Christensen.
952 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
954 2016-08-01 Alex Christensen <achristensen@webkit.org>
956 _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
957 https://bugs.webkit.org/show_bug.cgi?id=160437
958 <rdar://problem/27578272>
960 Reviewed by Brady Eidson.
962 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
963 (-[DownloadDelegate _download:didReceiveResponse:]):
964 (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
966 Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
968 2016-08-01 Carlos Alberto Lopez Perez <clopez@igalia.com>
970 [Tools] The GDB backtrace report tool don't checks the gdb return code.
971 https://bugs.webkit.org/show_bug.cgi?id=160414
973 Reviewed by Michael Catanzaro.
975 * Scripts/webkitpy/port/linux_get_crash_log.py:
976 (GDBCrashLogGenerator._wait_for_corefile):
978 2016-08-01 Youenn Fablet <youenn@apple.com>
980 Make wpt server generate its certificates in layout test results folder
981 https://bugs.webkit.org/show_bug.cgi?id=160422
983 Reviewed by Chris Dumez.
985 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
986 (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
988 2016-08-01 Jonathan Bedard <jbedard@apple.com>
990 Function Call on NULL Object
991 https://bugs.webkit.org/show_bug.cgi?id=160325
993 Reviewed by Darin Adler.
995 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
996 (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
997 * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
999 2016-08-01 Keith Miller <keith_miller@apple.com>
1001 We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1002 https://bugs.webkit.org/show_bug.cgi?id=160372
1004 Rubber stamped by Geoffrey Garen.
1006 This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1007 a new top level directory, JSTests. Having the tests in the Source directory
1008 was both confusing an inconvenient for people that just want to checkout the
1009 source code of WebKit. Since there is no other obvious place to put all the
1010 JavaScript tests a new top level directory seemed the most sensible.
1012 * Scripts/import-test262-tests:
1013 * Scripts/run-javascriptcore-tests:
1014 * Scripts/update-javascriptcore-test-res:
1016 2016-07-31 Nan Wang <n_wang@apple.com>
1018 AX: Add a check for touch event listener on iOS accessibility object
1019 https://bugs.webkit.org/show_bug.cgi?id=160388
1021 Reviewed by Chris Fleizach.
1023 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1024 (AccessibilityUIElement::boolAttributeValue):
1025 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1026 (WTR::AccessibilityUIElement::boolAttributeValue):
1028 2016-07-30 Manuel Rego Casasnovas <rego@igalia.com>
1030 Unreviewed: add myself to the reviewers list.
1032 * Scripts/webkitpy/common/config/contributors.json:
1034 2016-07-29 Alexey Proskuryakov <ap@apple.com>
1036 Undo r203939, and copy over a rule that clips the logos.
1038 Sierra wasn't the only logo without transparency.
1040 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1041 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1042 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1044 2016-07-29 Alan Sien Wei Hshieh <hshieh@apple.com>
1046 The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1047 https://bugs.webkit.org/show_bug.cgi?id=160377
1049 Reviewed by Brian Weinstein.
1051 Update assets to remove the white background and use a transparent background instead.
1053 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1054 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1056 2016-07-29 David Kilzer <ddkilzer@apple.com>
1058 Ignore most check-webkit-style checks for ANGLE project
1059 <https://webkit.org/b/160333>
1061 Reviewed by Daniel Bates.
1063 * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1065 - No spaces at the end of lines.
1066 - No carriage returns (DOS line endings).
1068 2016-07-29 Wenson Hsieh <wenson_hsieh@apple.com>
1070 Media controls are not displayed for some autoplaying videos at certain browser dimensions
1071 https://bugs.webkit.org/show_bug.cgi?id=160360
1072 <rdar://problem/27179484>
1074 Reviewed by Myles C. Maxfield.
1076 Adds two tests verifying that videos may be considered main content as long as they
1077 are large enough and cover a majority of the mainframe's viewport.
1079 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1080 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1081 (TestWebKitAPI::TEST):
1082 * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1083 * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1085 2016-07-29 Mark Lam <mark.lam@apple.com>
1087 Gardening: removed unused variable.
1091 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1092 (TestWebKitAPI::TEST):
1094 2016-07-29 Wenson Hsieh <wenson_hsieh@apple.com>
1096 Add TestWebKitAPI support for interacting with media controls
1097 https://bugs.webkit.org/show_bug.cgi?id=160342
1098 <rdar://problem/27610246>
1100 Reviewed by Beth Dakin.
1102 Adds support for testing interaction with some media controls, as well as a basic test
1103 verifying that media control teardown after interaction does not result in a crash.
1105 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1106 (-[WKWebView mouseDownAtPoint:]):
1107 (-[WKWebView performAfterLoading:]):
1108 (TestWebKitAPI::TEST):
1110 2016-07-29 Jonathan Bedard <jbedard@apple.com>
1112 Crash Log Clobbering on Unbound Crashes
1113 https://bugs.webkit.org/show_bug.cgi?id=160198
1114 <rdar://problem/27472618>
1116 Reviewed by Alexey Proskuryakov.
1118 * Scripts/webkitpy/common/system/crashlogs.py:
1119 (CrashLogs): Fix header order.
1120 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1121 (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1123 2016-07-29 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
1125 Update for contributors.json
1126 https://bugs.webkit.org/show_bug.cgi?id=160294
1128 * Scripts/webkitpy/common/config/contributors.json:
1130 2016-07-28 Myles C. Maxfield <mmaxfield@apple.com>
1132 Remove deprecated SPI for video inline / fullscreen controls
1133 https://bugs.webkit.org/show_bug.cgi?id=160318
1135 Reviewed by Tim Horton.
1137 * DumpRenderTree/mac/DumpRenderTree.mm:
1138 (setDefaultsToConsistentValuesForTesting): Deleted.
1139 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1140 (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1141 * WebKitTestRunner/TestController.cpp:
1142 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1143 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1144 (WTR::initializeWebViewConfiguration): Deleted.
1146 2016-07-28 Daniel Bates <dabates@apple.com>
1148 [iOS] TestWebKitAPI bundle targets are not code signed
1149 https://bugs.webkit.org/show_bug.cgi?id=160328
1150 <rdar://problem/27409246>
1152 Reviewed by Andy Estes.
1154 Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1155 CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1156 the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1158 * TestWebKitAPI/Configurations/Base.xcconfig:
1160 2016-07-28 Tim Horton <timothy_horton@apple.com>
1162 Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1164 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1165 (animatedResizeWebView):
1167 This test times out only when run in the WebKit Testing simulator environment,
1168 but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1170 2016-07-28 Tim Horton <timothy_horton@apple.com>
1172 Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1173 https://bugs.webkit.org/show_bug.cgi?id=160289
1174 <rdar://problem/27553464>
1176 Reviewed by Simon Fraser.
1178 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1179 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1180 * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1181 (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1182 (-[AnimatedResizeWebView _endAnimatedResize]):
1183 (animatedResizeWebView):
1185 * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1186 Add two tests that ensure that hidden-content and animated resizes
1187 don't cause unnecessary synchronous waits. Only the hidden-content
1188 one fails before my patch, but it seemed reasonable to add both anyway.
1190 2016-07-28 David Kilzer <ddkilzer@apple.com>
1192 webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1193 <https://webkit.org/b/83342>
1195 Reviewed by Ryosuke Niwa.
1197 * Scripts/webkitpy/common/checkout/scm/git.py:
1198 (Git.revisions_changing_file): Remove code to raise an exception
1199 when the file doesn't exist. If a file was moved or renamed,
1200 then this caused the script to terminate, which was very
1201 frustrating when you wanted a list of reviewers.
1202 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1203 (SCMTest._shared_test_revisions_changing_file): Update test
1204 expectation to return an empty list of revisions.
1205 (test_create_patch_is_full_patch): Drive-by fix when running all
1206 webkitpy tests (including scm tests).
1207 * Scripts/webkitpy/common/checkout/scm/svn.py:
1208 (SVN.revisions_changing_file): Catch ScriptError exceptions and
1209 return an empty array of revisions if this occurs.
1211 2016-07-28 Aakash Jain <aakash_jain@apple.com>
1213 EWS error message "Error: * did not process patch" should include explanation
1214 https://bugs.webkit.org/show_bug.cgi?id=159903
1215 <rdar://problem/27410788>
1217 Reviewed by Alexey Proskuryakov.
1219 * QueueStatusServer/handlers/statusbubble.py:
1220 (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1222 * QueueStatusServer/handlers/processingtimesjson.py:
1223 (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1225 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1226 (CommitQueueTask.validate): Add more information about validation failure.
1227 (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1228 * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1229 (EarlyWarningSystemTask.validate): Add more information about validation failure.
1230 (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1231 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1232 (PatchIsNotValid.__init__): Add the failure_message argument.
1233 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1234 (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1236 * Scripts/webkitpy/tool/commands/queues.py:
1237 (CommitQueue.process_work_item): Same.
1238 (StyleQueue.review_patch): Same.
1239 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1240 (test_non_valid_patch): Updated test-cases messages to match the above changes.
1242 2016-07-27 Alexey Proskuryakov <ap@apple.com>
1244 LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1245 https://bugs.webkit.org/show_bug.cgi?id=160262
1247 Reviewed by Daniel Bates.
1249 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1250 (-[LTRelayController installApp]):
1252 2016-07-27 Ryan Haddad <ryanhaddad@apple.com>
1254 Disable WebCoreNSURLSessionTest API tests on ios-simulator
1255 https://bugs.webkit.org/show_bug.cgi?id=160225
1257 Reviewed by Alexey Proskuryakov.
1259 * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1261 2016-07-27 Miguel Gomez <magomez@igalia.com>
1263 [GTK] Fix some video/canvas tests that should be passing
1264 https://bugs.webkit.org/show_bug.cgi?id=160023
1266 Reviewed by Carlos Garcia Campos.
1268 Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1269 EFL or GTK platforms.
1271 * WebKitTestRunner/efl/TestControllerEfl.cpp:
1272 (WTR::TestController::platformConfigureViewForTest):
1273 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1274 (WTR::TestController::platformConfigureViewForTest):
1276 2016-07-27 Carlos Alberto Lopez Perez <clopez@igalia.com>
1278 [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1279 https://bugs.webkit.org/show_bug.cgi?id=160247
1281 Reviewed by Michael Catanzaro.
1283 * BuildSlaveSupport/built-product-archive:
1286 (archiveBuiltProduct):
1288 2016-07-26 Alex Christensen <achristensen@webkit.org>
1290 Fix tests after r203743.
1291 https://bugs.webkit.org/show_bug.cgi?id=156947
1293 * WebKitTestRunner/TestController.cpp:
1294 (WTR::TestController::resetStateToConsistentValues):
1295 Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1297 2016-07-26 Myles C. Maxfield <mmaxfield@apple.com>
1299 [iPhone] Playing a video on tudou.com plays only sound, no video
1300 https://bugs.webkit.org/show_bug.cgi?id=160178
1301 <rdar://problem/27535468>
1303 Reviewed by Dan Bernstein.
1305 * DumpRenderTree/mac/DumpRenderTree.mm:
1306 (setDefaultsToConsistentValuesForTesting):
1307 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1308 (RequiresUserActionForPlaybackTest::SetUp):
1309 * WebKitTestRunner/TestController.cpp:
1310 (WTR::TestController::resetPreferencesToConsistentValues):
1311 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1312 (WTR::initializeWebViewConfiguration):
1314 2016-07-26 Simon Fraser <simon.fraser@apple.com>
1316 Allow LOG macros to be used outside the namespace, and other logging cleanup
1317 https://bugs.webkit.org/show_bug.cgi?id=160216
1319 Reviewed by Anders Carlsson.
1321 initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1323 * DumpRenderTree/TestRunner.cpp:
1324 * DumpRenderTree/mac/DumpRenderTree.mm:
1325 (resetWebViewToConsistentStateBeforeTesting):
1327 2016-07-26 David Kilzer <ddkilzer@apple.com>
1329 Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1330 https://bugs.webkit.org/show_bug.cgi?id=156947
1331 <rdar://problem/23325160>
1333 Reviewed by Alex Christensen.
1335 * DumpRenderTree/TestRunner.cpp:
1336 (TestRunner::TestRunner):
1337 (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1338 * DumpRenderTree/TestRunner.h:
1339 (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1340 (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1341 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1342 (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1343 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1344 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1345 (WTR::TestRunner::queueNonLoadingScript):
1346 (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1347 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1348 * WebKitTestRunner/TestController.cpp:
1349 (WTR::TestController::didReceiveAuthenticationChallenge):
1350 * WebKitTestRunner/TestController.h:
1351 (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1352 * WebKitTestRunner/TestInvocation.cpp:
1353 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1354 Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1356 2016-07-26 David Kilzer <ddkilzer@apple.com>
1358 check-for-exit-time-destructors should be usable outside Xcode
1359 <https://webkit.org/b/160195>
1361 Reviewed by Darin Adler.
1363 * Scripts/check-for-exit-time-destructors: Update to parse
1364 -h|--help switch, or to take one argument to a binary to check
1365 for exit time destructors on the command-line. The clang
1366 compiler will find these at compile-time with the
1367 -Wexit-time-destructors switch, but this script will check for
1368 them after-the-fact.
1370 2016-07-26 Lucas Forschler <lforschler@apple.com>
1372 Test svn.webkit.org functionality after maintenance.
1374 2016-07-25 Brady Eidson <beidson@apple.com>
1376 Modern IDB: Make sure IndexedDB works from file:// url documents by default
1377 https://bugs.webkit.org/show_bug.cgi?id=153783
1379 Reviewed by Alex Christensen.
1381 Previously, to grant IndexedDB access to file:// urls for testing purposes,
1382 we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1384 As of https://trac.webkit.org/changeset/203695 this is no longer required.
1386 Change the relevant API tests to make sure this continues to be no longer required.
1388 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1389 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1390 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1391 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1392 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1393 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1395 2016-07-25 Wenson Hsieh <wenson_hsieh@apple.com>
1397 Media controls should not be displayed for a video until it starts playing
1398 https://bugs.webkit.org/show_bug.cgi?id=160092
1399 <rdar://problem/26986673>
1401 Reviewed by Beth Dakin.
1403 Verify that multiple videos do or don't show the media controller depending on whether videos
1404 are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1405 passing because we were always showing media controls for large videos with audio, even if they
1406 had not played back yet. This change ensures that large videos with audio show media controls
1407 only after they begin to play back, and not by virtue of being large enough for main content.
1409 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1410 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1411 (TestWebKitAPI::TEST):
1412 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1413 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1414 * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1416 2016-07-25 Wenson Hsieh <wenson_hsieh@apple.com>
1418 Media controls on apple.com don't disappear when movie finishes playing
1419 https://bugs.webkit.org/show_bug.cgi?id=160068
1420 <rdar://problem/26668526>
1422 Reviewed by Darin Adler.
1424 Adds new API tests. Please see WebCore ChangeLog for more details.
1426 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1427 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1428 (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1429 (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1430 (TestWebKitAPI::TEST):
1431 (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1432 (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1433 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1434 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1435 * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1437 2016-07-25 Philippe Normand <pnormand@igalia.com>
1439 Unreviewed, fix test-webkitpy after r203674.
1441 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1442 (GDBCrashLogGeneratorTest.test_generate_crash_log):
1444 2016-07-24 Philippe Normand <pnormand@igalia.com>
1446 Unreviewed, forgot to commit this file in r203674.
1448 * Scripts/process-linux-coredump: Added.
1451 2016-07-25 Philippe Normand <pnormand@igalia.com>
1453 Improve GDB backtrace generation for GTK/EFL
1454 https://bugs.webkit.org/show_bug.cgi?id=128928
1456 Reviewed by Carlos Garcia Campos.
1458 The PID of the crashed process is now correctly supplied to the
1459 crash log reporter. The kernel core_pattern needs to be updated
1460 after this change to something like:
1462 echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1464 * Scripts/process-linux-coredump: Added.
1465 (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1466 * Scripts/webkitpy/port/efl.py:
1467 (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1468 * Scripts/webkitpy/port/gtk.py:
1469 (GtkPort._get_crash_log): Ditto.
1470 * Scripts/webkitpy/port/linux_get_crash_log.py:
1471 (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1472 (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1473 (GDBCrashLogGenerator): Deleted.
1474 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1475 (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1476 * WebKitTestRunner/TestController.cpp:
1477 (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1478 (WTR::TestController::databaseProcessDidCrash): Ditto.
1479 (WTR::TestController::processDidCrash): Ditto.
1481 2016-07-23 Youenn Fablet <youenn@apple.com>
1483 WPT stash server should be kept running when launching wpt server
1484 https://bugs.webkit.org/show_bug.cgi?id=160052
1486 Reviewed by Sam Weinig.
1488 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1489 (main): waiting to read stdin while stash server is started.
1491 2016-07-22 Wenson Hsieh <wenson_hsieh@apple.com>
1493 Media controls should be displayed for media in media documents
1494 https://bugs.webkit.org/show_bug.cgi?id=160104
1495 <rdar://problem/27438936>
1497 Reviewed by Myles C. Maxfield.
1499 Verifies that even a small video with audio in a media document gets media controls.
1501 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1502 (TestWebKitAPI::TEST):
1504 2016-07-22 Michael Saboff <msaboff@apple.com>
1506 REGRESSION(203616): no FTL testing was inadvertently removed
1507 https://bugs.webkit.org/show_bug.cgi?id=160100
1509 Rubber-stamped by Filip Pizlo.
1511 Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1512 Renamed runLayoutTestNoFTL to runLayoutTestDefault. Restructured the test
1513 logic for the runLayout and runNoisy variants to match the run test logic,
1514 that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1517 * Scripts/run-jsc-stress-tests:
1519 2016-07-22 Brady Eidson <beidson@apple.com>
1521 Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1522 https://bugs.webkit.org/show_bug.cgi?id=160089
1524 Reviewed by Darin Adler.
1526 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1527 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1528 * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1530 2016-07-22 Konstantin Tokarev <annulen@yandex.ru>
1532 [GTK] Improved exclusion patterns in make-dist.py manifest.
1533 https://bugs.webkit.org/show_bug.cgi?id=160094
1535 Reviewed by Michael Catanzaro.
1537 * gtk/manifest.txt.in:
1538 Exclude Platform*.cmake files for more ports.
1539 Removed obsolete .gyp and .pro.user patterns.
1540 Exclude 'Configurations' and 'spi' directories.
1541 Exclude CMakeLists.txt.user (Qt Creator IDE).
1543 2016-07-22 Michael Saboff <msaboff@apple.com>
1545 Don't run FTL related JSC stress tests on non-FTL platforms
1546 https://bugs.webkit.org/show_bug.cgi?id=160033
1548 Reviewed by Mark Lam.
1550 Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1551 Refactored several of the runXXX test methods to always runXXXDefault and made those
1552 runXXXDefault to pass FTL_OPTIONS. For platforms that don't enable the FTL, FTL_OPTIONS
1553 doesn't cause a problem.
1555 * Scripts/run-jsc-stress-tests:
1557 2016-07-22 Per Arne Vollan <pvollan@apple.com>
1559 IWebView::mainFrame crashes if called after IWebView::close
1560 https://bugs.webkit.org/show_bug.cgi?id=32868
1562 Reviewed by Brent Fulgham.
1564 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1565 (TestWebKitAPI::TEST_F): Added test.
1567 2016-07-22 Carlos Garcia Campos <cgarcia@igalia.com>
1569 [GTK] Enable threaded compositor by default
1570 https://bugs.webkit.org/show_bug.cgi?id=160079
1572 Reviewed by Žan Doberšek.
1574 * Scripts/webkitperl/FeatureList.pm:
1576 2016-07-22 Youenn Fablet <youenn@apple.com>
1578 run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1579 https://bugs.webkit.org/show_bug.cgi?id=159921
1581 Reviewed by Brian Burg.
1583 Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1585 * Scripts/webkitpy/codegen/main.py:
1586 (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1587 (BuiltinsGeneratorTests):
1588 (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1589 (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1590 (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1591 (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1593 2016-07-21 Dan Bernstein <mitz@apple.com>
1595 [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1596 https://bugs.webkit.org/show_bug.cgi?id=160072
1598 Reviewed by Andy Estes.
1600 * Scripts/webkitdirs.pm:
1601 (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1602 for old Xcode versions.
1603 (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1604 to readXcodeUserDefault.
1605 (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1607 (determineDebugger): Ditto.
1608 (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1610 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1612 (execMacWebKitAppForDebugging): Removed support for GDB.
1614 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
1616 Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1617 https://bugs.webkit.org/show_bug.cgi?id=160066
1619 Reviewed by Dean Jackson.
1621 * DumpRenderTree/mac/DumpRenderTree.mm:
1622 (setDefaultsToConsistentValuesForTesting): Deleted.
1623 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1624 (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1625 * WebKitTestRunner/TestController.cpp:
1626 (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1627 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1628 (WTR::initializeWebViewConfiguration): Deleted.
1630 2016-07-21 Chelsea Pugh <cpugh@apple.com>
1632 [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1633 https://bugs.webkit.org/show_bug.cgi?id=159980
1634 rdar://problem/27450825
1636 Reviewed by Dan Bernstein.
1638 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1639 * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1640 (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1641 when our delegate has hit -dealloc.
1642 (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1643 and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1644 will not be messaged.
1646 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
1648 Follow-up patch to r203520
1649 https://bugs.webkit.org/show_bug.cgi?id=159967
1650 <rdar://problem/26964090>
1654 * DumpRenderTree/mac/DumpRenderTree.mm:
1655 (setDefaultsToConsistentValuesForTesting):
1656 * WebKitTestRunner/TestController.cpp:
1657 (WTR::TestController::resetPreferencesToConsistentValues):
1659 2016-07-21 Myles C. Maxfield <mmaxfield@apple.com>
1661 [iPhone] Playing a video on tudou.com plays only sound, no video
1662 https://bugs.webkit.org/show_bug.cgi?id=159967
1663 <rdar://problem/26964090>
1665 Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
1667 Migrate tests to use new SPI.
1669 * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1670 (RequiresUserActionForPlaybackTest::SetUp):
1671 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1672 (WTR::initializeWebViewConfiguration):
1674 2016-07-21 Csaba Osztrogonác <ossy@webkit.org>
1676 Clarify testing mode names in run-jsc-stress-tests
1677 https://bugs.webkit.org/show_bug.cgi?id=160021
1679 Reviewed by Mark Lam.
1681 Default should mean really default, not default with disabled FTL, renamed
1682 - runMozillaTestDefault to runMozillaTestNoFTL
1683 - runMozillaTestDefaultFTL to runMozillaTestDefault
1684 - runDefault to runNoFTL
1685 - runDefaultFTL to runDefault
1686 - runLayoutTestDefault to runLayoutTestNoFTL
1687 - runLayoutTestDefaultFTL to runLayoutTestDefault
1688 - runNoisyTestDefault to runNoisyTestNoFTL
1689 - runNoisyTestDefaultFTL to runNoisyTestDefault
1691 * Scripts/run-jsc-stress-tests:
1693 2016-07-21 Yongjun Zhang <yongjun_zhang@apple.com>
1695 WebBackForwardList's currentIndex could get out of bounds when filtering items.
1696 https://bugs.webkit.org/show_bug.cgi?id=159986
1698 Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
1701 Reviewed by Dan Bernstein.
1703 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1704 * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
1705 (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
1708 2016-07-21 Carlos Garcia Campos <cgarcia@igalia.com>
1710 [GTK] Web view background colors don't work in accelerated compositing mode
1711 https://bugs.webkit.org/show_bug.cgi?id=159455
1713 Reviewed by Michael Catanzaro.
1715 Set always RGBA visual to the view widget when setting a background color.
1717 * MiniBrowser/gtk/BrowserWindow.c:
1718 (browser_window_set_background_color):
1720 2016-07-20 Youenn Fablet <youenn@apple.com>
1722 Bots should run built-ins generator tests
1723 https://bugs.webkit.org/show_bug.cgi?id=159971
1725 Reviewed by Alexey Proskuryakov.
1727 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1728 (RunBuiltinsTests): New step to run built-in generator tests.
1729 (TestFactory.__init__): Adding an additional step for bultin generator tests.
1730 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
1731 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
1733 2016-07-20 Aakash Jain <aakash_jain@apple.com>
1735 Revert temporary fix r203417
1736 https://bugs.webkit.org/show_bug.cgi?id=160001
1738 Reviewed by Alexey Proskuryakov.
1740 * EWSTools/start-queue-mac.sh: Revert the temporary fix.
1742 2016-07-20 Aakash Jain <aakash_jain@apple.com>
1744 REGRESSION(r148588): ews classes might get garbage collected
1745 https://bugs.webkit.org/show_bug.cgi?id=159990
1747 Reviewed by Ryosuke Niwa.
1749 * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
1750 in a variable so that they do not get garbage collected.
1752 2016-07-20 Jeremy Jones <jeremyj@apple.com>
1754 Add API test for layout constraints after exit fullscreen
1755 https://bugs.webkit.org/show_bug.cgi?id=159900
1757 Reviewed by Jon Lee.
1759 Added Fullscreen.LaytoutConstraints API test.
1760 Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
1762 This test compares layout constraints on the web view before and after fullscreen to make sure
1765 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
1766 * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
1767 (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1768 (TestWebKitAPI::TEST):
1770 2016-07-20 Ryan Haddad <ryanhaddad@apple.com>
1772 Disable two failing API tests.
1774 Unreviewed test gardening.
1776 * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1777 (TestWebKitAPI::TEST):
1779 2016-07-20 Wenson Hsieh <wenson_hsieh@apple.com>
1781 Unreviewed iOS build fix.
1783 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
1785 2016-07-20 Wenson Hsieh <wenson_hsieh@apple.com>
1787 Media controls don't appear when pausing a small autoplaying video
1788 https://bugs.webkit.org/show_bug.cgi?id=159972
1789 <rdar://problem/27180657>
1791 Reviewed by Beth Dakin.
1793 Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
1794 for simulating basic user interaction in VideoControlsManager.
1796 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1797 * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1798 (-[WKWebView mouseDownAtPoint:]):
1799 (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
1800 (-[OnLoadMessageHandler initWithWKWebView:handler:]):
1801 (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
1802 (TestWebKitAPI::TEST):
1803 * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
1805 2016-07-20 Per Arne Vollan <pvollan@apple.com>
1807 [Win] MathML fonts are not found.
1808 https://bugs.webkit.org/show_bug.cgi?id=159920
1810 Reviewed by Alex Christensen.
1812 When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
1813 for a specific registry key value.
1815 * Scripts/webkitdirs.pm:
1818 2016-07-20 Joseph Pecoraro <pecoraro@apple.com>
1820 Improve prepare-ChangeLog for @media blocks
1821 https://bugs.webkit.org/show_bug.cgi?id=159907
1823 Reviewed by Timothy Hatcher.
1825 * Scripts/prepare-ChangeLog:
1826 (get_selector_line_ranges_for_css):
1827 Get a range for @media blocks just like a selector.
1828 Start Line = line with '{'
1829 End line = line with '}'
1832 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
1833 Improved error messages for unbalanced portions.
1835 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
1836 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
1837 (.media-query::before):
1838 (@media only screen and (max-width: 980px)):
1840 (@media (-webkit-min-device-pixel-ratio: 2)):
1844 (.media-query::after):
1846 2016-07-20 Csaba Osztrogonác <ossy@webkit.org>
1848 Fix expectedFailErrorHandler in run-jsc-stress-tests
1849 https://bugs.webkit.org/show_bug.cgi?id=159811
1851 Reviewed by Yusuke Suzuki.
1853 * Scripts/run-jsc-stress-tests:
1855 2016-07-20 Csaba Osztrogonác <ossy@webkit.org>
1857 Unreviewed Mac cmake buildfix after r203426. Just for fun.
1859 * TestWebKitAPI/PlatformMac.cmake:
1861 2016-07-19 Filip Pizlo <fpizlo@apple.com>
1863 The default testing mode should not involve disabling the FTL JIT
1864 https://bugs.webkit.org/show_bug.cgi?id=159929
1866 Rubber stamped by Mark Lam and Saam Barati.
1868 It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
1869 Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
1870 FTL was not the default. You had to enable it with an option.
1872 For some reason we have kept this arrangement even though the FTL JIT is now the default on
1873 all of the major ports. This has become a serious pain. For example, it's useful to be able
1874 to say that a test should only run in the default config that is representative of what a
1875 normal user would see if they ran JSC. Clearly, this would be a config that does not
1876 explicitly disable the FTL JIT on the command line. However, if you try to specify this then
1877 your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
1879 So, this change gets rid of all of this logic. I think it's better to get rid of it then to
1880 try to fix it, because:
1882 - I don't know what the fix would look like. Presumably it would ensure that ports that don't
1883 have the FTL enabled never run any tests that explicitly disable the FTL, since that
1884 doesn't do anything. The code is not really structured to allow this.
1886 - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
1887 disabled in testing. On the other hand there are already build bots that do FTL tests
1888 despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
1889 preserving this broken feature, we should create something that (a) acknowledges the fact
1890 that the FTL is the default on those platforms that support it and (b) avoids running
1891 no-ftl tests on precisely those platforms that don't have FTL.
1893 - To the extent that some bots benefited from disabling FTL tests, they were doing it by
1894 relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
1895 default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
1896 pretending that the FTL JIT is not the default just because some bots used that as an
1899 This change allows me to speed up some debug tests and paint some bots green.
1901 * Scripts/run-javascriptcore-tests:
1902 (runJSCStressTests):
1903 * Scripts/run-jsc-stress-tests:
1905 2016-07-19 Alex Christensen <achristensen@webkit.org>
1907 Fix API test after r203426.
1908 https://bugs.webkit.org/show_bug.cgi?id=159949
1910 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1912 If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
1913 This is no problem. We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
1915 2016-07-19 Andy Estes <aestes@apple.com>
1917 Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
1918 https://bugs.webkit.org/show_bug.cgi?id=159956
1920 Reviewed by Dan Bernstein.
1922 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
1923 (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1924 Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
1925 * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
1927 2016-07-19 Alex Christensen <achristensen@webkit.org>
1929 Add regression test for r203392
1930 https://bugs.webkit.org/show_bug.cgi?id=159949
1932 Reviewed by Brady Eidson.
1934 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1936 (swizzledBundleIdentifierWebBookmarksD):
1937 (defaultApplicationCacheDirectory):
1939 (swizzledBundleIdentifierMobileSafari): Deleted.
1940 This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
1941 I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
1942 problems with the static bools that are set once in RuntimeApplicationChecks.mm.
1944 2016-07-19 Alex Christensen <achristensen@webkit.org>
1946 Add regression test for r203392
1947 https://bugs.webkit.org/show_bug.cgi?id=159949
1949 Reviewed by Brady Eidson.
1951 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1952 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
1953 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
1954 * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
1955 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1958 (swizzledBundleIdentifierMobileSafari):
1959 (swizzledBundleIdentifierWebBookmarksD):
1960 (defaultApplicationCacheDirectory):
1961 * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
1962 * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
1963 * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
1964 * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
1966 2016-07-19 Keith Miller <keith_miller@apple.com>
1968 Test262 should have a file with the revision and url
1969 https://bugs.webkit.org/show_bug.cgi?id=159937
1971 Reviewed by Mark Lam.
1973 The import script should update the information from
1974 the path to the test262 repository it gets.
1976 * Scripts/import-test262-tests:
1978 2016-07-19 Alexey Proskuryakov <ap@apple.com>
1980 Temporary workaround for iOS EWS failing after the fix for bug 159539.
1981 To be deleted once the root cause is found and addressed.
1983 * EWSTools/start-queue-mac.sh:
1985 2016-07-19 Frederic Wang <fwang@igalia.com>
1987 [win] Fixup the register name for STIX Math and Latin Modern Math
1989 Unreviewed follow-up of r203406
1991 * Scripts/webkitdirs.pm:
1992 (checkInstalledTools):
1994 2016-07-19 Frederic Wang <fwang@igalia.com>
1996 [win] Update the list of MathML fonts
1997 https://bugs.webkit.org/show_bug.cgi?id=156838
1999 The set of recommended math fonts is now described at
2000 https://trac.webkit.org/wiki/MathML/Fonts
2001 We update the Perl script to use the latest list of fonts.
2003 Reviewed by Brent Fulgham.
2005 * Scripts/webkitdirs.pm:
2006 (checkInstalledTools):
2008 2016-07-19 Per Arne Vollan <pvollan@apple.com>
2010 [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2011 https://bugs.webkit.org/show_bug.cgi?id=159342
2013 Reviewed by Darin Adler.
2015 Implement required functions in event sender.
2017 * DumpRenderTree/PlatformWin.cmake:
2018 * DumpRenderTree/win/EventSender.cpp:
2019 (monitorWheelEvents): Added.
2020 (callAfterScrollingCompletes): Added.
2022 2016-07-19 Youenn Fablet <youenn@apple.com>
2024 Add new aliases to http test server
2025 https://bugs.webkit.org/show_bug.cgi?id=159878
2027 Reviewed by Darin Adler.
2029 Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2030 Adding explicitly these links to perl script.
2031 Extracting default alias in an aliases.json file.
2032 Reading that file from python scripts to initialize aliases from that file.
2034 Python script changes covered by unit tests and changed layout test.
2036 * Scripts/webkitperl/httpd.pm:
2037 (getDefaultConfigForTestDirectory): Adding 3 new aliases
2038 * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2039 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2040 (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2041 Adding -c directives for each alias.
2042 * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2043 (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2044 * Scripts/webkitpy/layout_tests/servers/http_server.py:
2045 (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2046 Adding alias directive for each alias.
2047 (Lighttpd._prepare_config):
2048 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2049 (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2050 (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2051 layout tests directory.
2052 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2053 (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2054 (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2056 2016-07-18 Aakash Jain <aakash_jain@apple.com>
2058 EWS console logs doesn't go to log file
2059 https://bugs.webkit.org/show_bug.cgi?id=159539
2060 <rdar://problem/24464570>
2062 Reviewed by David Kilzer.
2064 * Scripts/webkitpy/common/system/logutils.py:
2065 (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2066 (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2067 to filesystem. It also supports passing MockFilesystem.
2068 (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2069 (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2070 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2071 (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2073 * Scripts/webkitpy/tool/commands/queues.py:
2074 (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2075 (AbstractQueue._log_directory): Using filesystem object instead of os.
2076 (AbstractQueue.queue_log_path): Same.
2077 (AbstractQueue.__init__): Passed host parameter.
2078 (PatchProcessingQueue.__init__): Same.
2079 (CommitQueue.__init__): Same.
2080 (AbstractReviewQueue.__init__): Same.
2081 (StyleQueue.__init__): Same.
2082 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2083 (TestCommitQueue): Passed MockHost() as host.
2084 (TestCommitQueue.__init__): Same.
2085 (TestQueue.__init__): Same.
2086 (TestReviewQueue.__init__): Same.
2087 (TestFeederQueue.__init__): Same.
2088 (AbstractPatchQueueTest.test_next_patch): Same.
2089 (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2090 (test_commit_queue_failure): Same.
2091 (MockCommitQueueTask.results_from_patch_test_run): Same.
2092 (test_rollout_lands): Same.
2093 (test_non_valid_patch): Same.
2094 (test_auto_retry): Same.
2095 (test_style_queue_with_watch_list_exception): Same.
2097 2016-07-02 Filip Pizlo <fpizlo@apple.com>
2099 WTF::Lock should be fair eventually
2100 https://bugs.webkit.org/show_bug.cgi?id=159384
2102 Reviewed by Geoffrey Garen.
2104 * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2106 2016-07-17 Sam Weinig <sam@webkit.org>
2108 [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2109 <rdar://problem/26554137>
2110 https://bugs.webkit.org/show_bug.cgi?id=159856
2112 Reviewed by Dan Bernstein.
2114 * MiniBrowser/mac/WK2BrowserWindowController.m:
2115 (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2116 Add basic window.open implementation.
2118 (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2119 Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2120 to open a single non-web URL, all others are dropped.
2122 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2123 * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2124 * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2125 Add API for the new SPI.
2127 2016-07-17 Yusuke Suzuki <utatane.tea@gmail.com>
2129 [JSC] Enable test262 module tests
2130 https://bugs.webkit.org/show_bug.cgi?id=159854
2132 Reviewed by Saam Barati.
2134 Use --module-file instead.
2136 * Scripts/run-jsc-stress-tests:
2138 2016-07-16 Chris Dumez <cdumez@apple.com>
2140 Unreviewed, rolling out r203318.
2142 Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2147 "[JSC] Change some parameters based on a random search"
2148 https://bugs.webkit.org/show_bug.cgi?id=158514
2149 http://trac.webkit.org/changeset/203318
2151 2016-07-16 Chris Dumez <cdumez@apple.com>
2153 Add move constructor / assignment operator to ListHashSet
2154 https://bugs.webkit.org/show_bug.cgi?id=159837
2156 Reviewed by Darin Adler.
2160 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2161 (TestWebKitAPI::TEST):
2163 2016-07-15 Benjamin Poulain <bpoulain@apple.com>
2165 [JSC] Change some parameters based on a random search
2166 https://bugs.webkit.org/show_bug.cgi?id=158514
2168 Reviewed by Saam Barati.
2170 * Scripts/run-jsc-stress-tests:
2172 2016-07-15 Jon Davis <jond@apple.com>
2174 Changed the start page URL for WebKit Nightly builds.
2175 https://bugs.webkit.org/show_bug.cgi?id=159816
2177 Reviewed by Timothy Hatcher.
2179 * WebKitLauncher/start.html:
2181 2016-07-15 Per Arne Vollan <pvollan@apple.com>
2183 Uninitialized variable in DIBPixelData can cause a dangerous memory write
2184 https://bugs.webkit.org/show_bug.cgi?id=159414
2186 Reviewed by Brent Fulgham.
2188 Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2189 when the HDC parameter is invalid.
2191 * TestWebKitAPI/PlatformWin.cmake:
2192 * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2193 (TestWebKitAPI::TEST):
2195 2016-07-15 Carlos Garcia Campos <cgarcia@igalia.com>
2197 [GTK] Add basic tabs support to MiniBrowser
2198 https://bugs.webkit.org/show_bug.cgi?id=159803
2200 Reviewed by Sergio Villar Senin.
2202 It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2203 like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2205 * MiniBrowser/gtk/BrowserTab.c: Added.
2209 (removeChildIfInfoBar):
2211 (createInfoBarQuestionMessage):
2212 (tlsErrorsDialogResponse):
2213 (loadFailedWithTLSerrors):
2214 (permissionRequestDialogResponse):
2215 (decidePermissionRequest):
2216 (colorChooserRGBAChanged):
2217 (popoverColorClosed):
2218 (colorChooserRequestFinished):
2219 (runColorChooserCallback):
2220 (inspectorOpenedInWindow):
2222 (browserTabSetProperty):
2223 (browserTabFinalize):
2225 (browserTabConstructed):
2226 (browser_tab_class_init):
2229 (browser_tab_get_web_view):
2230 (browser_tab_load_uri):
2231 (browser_tab_get_title_widget):
2232 (browser_tab_set_status_text):
2233 (browser_tab_toggle_inspector):
2234 (browser_tab_start_search):
2235 (browser_tab_stop_search):
2236 (browser_tab_add_accelerators):
2237 (fullScreenMessageTimeoutCallback):
2238 (browser_tab_enter_fullscreen):
2239 (browser_tab_leave_fullscreen):
2240 * MiniBrowser/gtk/BrowserTab.h: Added.
2241 * MiniBrowser/gtk/BrowserWindow.c:
2243 (browserWindowSetStatusText):
2244 (reloadOrStopCallback):
2246 (goForwardCallback):
2248 (webViewURIChanged):
2249 (browserWindowHistoryItemActivated):
2250 (browserWindowUpdateNavigationActions):
2252 (webViewEnterFullScreen):
2253 (webViewLeaveFullScreen):
2254 (webViewDecidePolicy):
2255 (browserWindowCanZoomIn):
2256 (browserWindowCanZoomOut):
2257 (browserWindowZoomIn):
2258 (browserWindowZoomOut):
2259 (scrollEventCallback):
2261 (webViewIsLoadingChanged):
2262 (defaultZoomCallback):
2265 (toggleWebInspector):
2267 (reloadPageIgnoringCache):
2270 (editingCommandCallback):
2271 (insertImageCommandCallback):
2272 (insertLinkCommandCallback):
2273 (browserWindowSetupEditorToolbar):
2274 (browserWindowSwitchTab):
2275 (browserWindowTabAddedOrRemoved):
2276 (browser_window_init):
2277 (browserWindowConstructed):
2278 (browserWindowSaveSession):
2279 (browserWindowDeleteEvent):
2280 (browser_window_new):
2281 (browser_window_append_view):
2282 (browser_window_load_uri):
2283 (browser_window_load_session):
2284 (browser_window_set_background_color):
2285 (resetStatusText): Deleted.
2286 (activateUriEntryCallback): Deleted.
2287 (webViewTitleChanged): Deleted.
2288 (resetEntryProgress): Deleted.
2289 (browserWindowCreateBackForwardMenu): Deleted.
2290 (webViewReadyToShow): Deleted.
2291 (webViewLoadFailed): Deleted.
2292 (webViewMouseTargetChanged): Deleted.
2293 (browserWindowUpdateZoomActions): Deleted.
2294 (webViewZoomLevelChanged): Deleted.
2295 (updateUriEntryIcon): Deleted.
2296 (zoomInCallback): Deleted.
2297 (zoomOutCallback): Deleted.
2298 (toggleFullScreen): Deleted.
2299 (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2300 (browserWindowFinalize): Deleted.
2301 (browser_window_class_init): Deleted.
2302 * MiniBrowser/gtk/BrowserWindow.h:
2303 * MiniBrowser/gtk/CMakeLists.txt:
2304 * MiniBrowser/gtk/main.c:
2306 (aboutURISchemeRequestCallback):
2308 (parseBackgroundColor): Deleted.
2310 2016-07-14 Alex Christensen <achristensen@webkit.org>
2312 Allow RefPtrs of const RefCounted types
2313 https://bugs.webkit.org/show_bug.cgi?id=158269
2315 Reviewed by Anders Carlsson.
2317 * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2318 (TestWebKitAPI::TEST):
2319 (TestWebKitAPI::ConstRefCounted::create):
2320 (TestWebKitAPI::returnConstRefCountedRef):
2321 (TestWebKitAPI::returnRefCountedRef):
2323 2016-07-13 Carlos Garcia Campos <cgarcia@igalia.com>
2325 Test WTF.StringViewIterators is crashing since r203119
2326 https://bugs.webkit.org/show_bug.cgi?id=159710
2328 Reviewed by Darin Adler.
2330 There are two problems in the test case added in r203119. First is that it's testing
2331 StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2332 StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2333 const reference to the string view member of the deleted CodePoints object.
2335 * TestWebKitAPI/Tests/WTF/StringView.cpp:
2336 (TestWebKitAPI::TEST):
2338 2016-07-13 Daniel Bates <dabates@apple.com>
2340 [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2341 https://bugs.webkit.org/show_bug.cgi?id=159738
2342 <rdar://problem/27304649>
2344 Reviewed by Dan Bernstein.
2346 The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2347 code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2348 of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2349 PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2351 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2352 * WebKitTestRunner/ios/TestControllerIOS.mm:
2353 (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2354 bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2356 2016-07-13 Beth Dakin <bdakin@apple.com>
2358 Attempted build fix.
2360 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2362 2016-07-12 Ryosuke Niwa <rniwa@webkit.org>
2364 REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2365 https://bugs.webkit.org/show_bug.cgi?id=159686
2367 Reviewed by Chris Dumez.
2369 Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2371 * WebKitTestRunner/TestController.cpp:
2372 (WTR::runOpenPanel):
2373 (WTR::TestController::createOtherPage):
2374 (WTR::TestController::createWebViewWithOptions):
2376 2016-07-13 Beth Dakin <bdakin@apple.com>
2378 Add more candidate tests
2379 https://bugs.webkit.org/show_bug.cgi?id=159730
2381 Reviewed by Tim Horton.
2383 This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds
2384 two new tests to that file.
2385 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2386 * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2387 * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2388 (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2389 (TestWebKitAPI::TEST):
2390 * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2392 2016-07-13 Joanmarie Diggs <jdiggs@igalia.com>
2394 AX: [ATK] spinbutton-crash.html fails
2395 https://bugs.webkit.org/show_bug.cgi?id=159723
2397 Reviewed by Chris Fleizach.
2399 Implement support for AXDecrementButton and AXIncrementButton in
2400 ATK's AccessibilityUIElement::uiElementAttributeValue().
2402 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2403 (WTR::AccessibilityUIElement::uiElementAttributeValue):
2405 2016-07-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
2407 [EFL] [GTK] Enable back crypto subtle on development builds.
2408 https://bugs.webkit.org/show_bug.cgi?id=159260
2410 Reviewed by Carlos Garcia Campos.
2412 * Scripts/webkitperl/FeatureList.pm:
2414 2016-07-12 Mark Lam <mark.lam@apple.com>
2416 We should use different stack limits for stack checks from JS and host code.
2417 https://bugs.webkit.org/show_bug.cgi?id=159442
2418 <rdar://problem/26889188>
2420 Reviewed by Geoffrey Garen.
2422 In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2423 run with to keep stack overflow tests sane. Turns out, we also need to teach the
2424 LayoutTestRelay to pass env vars over to the iOS simulator. This is needed in
2425 order to keep the js/regress-139548.html test happy with this patch.
2427 Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2428 JSC_maxPerThreadStackUsage option. Otherwise, it will pass a float value.
2430 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2431 (-[LTRelayController _environmentVariables]):
2432 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2435 2016-07-12 Filip Pizlo <fpizlo@apple.com>
2437 platformUserPreferredLanguages on Mac should not try to put the region into the language
2438 https://bugs.webkit.org/show_bug.cgi?id=159693
2440 Rubber stamped by Alexey Proskuryakov.
2442 Revert the test change in r200105.
2444 * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2445 (TestWebKitAPI::languageForSystemLanguage):
2447 2016-07-12 Chris Dumez <cdumez@apple.com>
2449 [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2450 https://bugs.webkit.org/show_bug.cgi?id=159663
2451 <rdar://problem/18995873>
2453 Reviewed by Benjamin Poulain.
2455 Add API test coverage.
2457 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2458 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2459 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2460 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2461 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2462 (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2465 2016-07-12 Myles C. Maxfield <mmaxfield@apple.com>
2467 Relax ordering requirements on StringView::CodePoints iterator
2468 https://bugs.webkit.org/show_bug.cgi?id=159609
2470 Reviewed by Darin Adler.
2472 * TestWebKitAPI/Tests/WTF/StringView.cpp:
2473 (TestWebKitAPI::TEST):
2475 2016-07-12 Youenn Fablet <youenn@apple.com>
2477 Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2478 https://bugs.webkit.org/show_bug.cgi?id=159564
2480 Reviewed by Brian Burg.
2482 * Scripts/webkitpy/codegen/main.py:
2483 (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2485 2016-07-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2487 Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2488 https://bugs.webkit.org/show_bug.cgi?id=159671
2490 Reviewed by Csaba Osztrogonác.
2492 ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2493 https://bugs.webkit.org/show_bug.cgi?id=89235
2495 So this guard can be removed in build scripts.
2497 * Scripts/webkitperl/FeatureList.pm:
2498 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2500 2016-07-11 Jason Marcell <jmarcell@apple.com>
2502 SVN.create_patch should find svn-create-patch relative to the WebKit root.
2503 https://bugs.webkit.org/show_bug.cgi?id=159652
2505 Reviewed by Daniel Bates.
2507 * Scripts/webkitpy/common/checkout/scm/svn.py:
2508 (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2510 2016-07-11 Myles C. Maxfield <mmaxfield@apple.com>
2512 Implement grapheme cluster iterator on StringView
2513 https://bugs.webkit.org/show_bug.cgi?id=159598
2515 Reviewed by Anders Carlsson.
2517 This is in preparation for honoring the second argument to FontFaceSet.load().
2519 * TestWebKitAPI/Tests/WTF/StringView.cpp:
2520 (TestWebKitAPI::compareLoopIterations):
2521 (TestWebKitAPI::TEST):
2523 2016-07-11 Nan Wang <n_wang@apple.com>
2525 AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2526 https://bugs.webkit.org/show_bug.cgi?id=158364
2528 Reviewed by Anders Carlsson.
2530 Added a function in TestRunner so that we can toggle the ignoring viewport
2531 scale limits setting. Also added a test option for that in order to change the
2532 configuration of the webview in test.
2534 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2535 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2536 (WTR::TestRunner::setNavigationGesturesEnabled):
2537 (WTR::TestRunner::setIgnoresViewportScaleLimits):
2538 (WTR::nextUIScriptCallbackID):
2539 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2540 (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2541 * WebKitTestRunner/TestController.cpp:
2542 (WTR::TestController::resetStateToConsistentValues):
2543 (WTR::updateTestOptionsFromTestHeader):
2544 (WTR::TestController::setNavigationGesturesEnabled):
2545 (WTR::TestController::setIgnoresViewportScaleLimits):
2546 (WTR::TestController::platformWillRunTest):
2547 * WebKitTestRunner/TestController.h:
2548 (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2549 * WebKitTestRunner/TestInvocation.cpp:
2550 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2551 * WebKitTestRunner/TestOptions.h:
2552 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2553 (WTR::TestController::platformCreateWebView):
2555 2016-07-11 Konstantin Tokarev <annulen@yandex.ru>
2557 [GTK] install-dependencies should not install packages built by jhbuild.
2558 https://bugs.webkit.org/show_bug.cgi?id=159628
2560 Reviewed by Michael Catanzaro.
2562 * gtk/install-dependencies:
2563 Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2565 2016-07-11 Olivier Blin <olivier.blin@softathome.com>
2567 System proxy settings not used when building deps with jhbuild
2568 https://bugs.webkit.org/show_bug.cgi?id=159567
2570 Reviewed by Michael Catanzaro.
2572 This adds the gsettings-desktop-schemas-devel build dep to enable
2573 the libgiognomeproxy.so gio module in glib-networking, which uses
2574 GSettings on org.gnome.system.proxy.
2575 This is needed to query system proxy settings for Gnome desktops.
2577 dconf can be manually added to jhbuild to build the
2578 libdconfsettings.so gio module for GSettings, so that
2579 libgiognomeproxy.so can access system settings.
2580 https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2582 As an alternative to dconf settings, this commit also adds the
2583 libproxy-devel build dep to enable the libgiolibproxy.so module in
2584 glib-networking (suggested by Fujii Hironori).
2586 It is useful to read proxy settings from environment variables.
2587 From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2588 environment variable to force using the envvar module in libproxy.
2590 * gtk/install-dependencies:
2592 2016-07-11 Mark Lam <mark.lam@apple.com>
2594 Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2595 https://bugs.webkit.org/show_bug.cgi?id=159524
2597 Reviewed by Michael Saboff.
2599 Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2600 Also fixed up some tests to behave better to work with this new limit. This
2601 should make stack overflow tests complete sooner.
2603 * Scripts/run-jsc-stress-tests:
2604 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2607 2016-07-11 Michael Catanzaro <mcatanzaro@igalia.com>
2609 [GTK] Whitespace fixes in install-dependencies script
2613 * gtk/install-dependencies:
2615 2016-07-11 Michael Catanzaro <mcatanzaro@igalia.com>
2617 [GTK] Install missing Fedora dependencies
2621 * gtk/install-dependencies:
2623 2016-07-09 Dan Bernstein <mitz@apple.com>
2625 Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2626 https://bugs.webkit.org/show_bug.cgi?id=159600
2628 Reviewed by Daniel Bates.
2630 * Scripts/git-add-reviewer:
2631 Added the -s|--rubber-stamp option.
2632 (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2635 2016-07-08 Andy Estes <aestes@apple.com>
2637 [Content Filtering] Load blocked pages more like other error pages are loaded
2638 https://bugs.webkit.org/show_bug.cgi?id=159485
2639 <rdar://problem/26014076>
2641 Reviewed by Brady Eidson.
2643 Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2644 to a content filtering provisional navigation failure is ignored in preference of
2645 ContentFilter's own error page.
2647 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2648 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2649 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2650 (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2651 (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2652 (loadAlternateTest):
2654 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2655 (-[MockContentFilterEnabler initWithCoder:]):
2656 * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2657 (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2658 (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2659 (TestWebKitAPI::loadAlternateTest):
2660 (TestWebKitAPI::TEST):
2662 2016-07-08 Commit Queue <commit-queue@webkit.org>
2664 Unreviewed, rolling out r202944.
2665 https://bugs.webkit.org/show_bug.cgi?id=159570
2667 caused some tests to crash under GuardMalloc (Requested by
2672 "[Content Filtering] Load blocked pages more like other error
2674 https://bugs.webkit.org/show_bug.cgi?id=159485
2675 http://trac.webkit.org/changeset/202944
2677 2016-07-08 Martin Robinson <mrobinson@igalia.com>
2679 Remove mrobinson from the MathML watchlist
2680 https://bugs.webkit.org/show_bug.cgi?id=159559
2682 Reviewed by Philippe Normand.
2684 * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
2686 2016-07-08 Brady Eidson <beidson@apple.com>
2688 Clearing LocalStorage doesn't also delete -wal and -shm files.
2689 <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
2691 Reviewed by Brent Fulgham.
2692 Also helpfully picked over by Andy "Never Forgets" Estes.
2694 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2695 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
2696 * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
2698 2016-07-08 Konstantin Tokarev <annulen@yandex.ru>
2700 Removed Qt leftovers from Tools.
2701 https://bugs.webkit.org/show_bug.cgi?id=159557
2703 Reviewed by Csaba Osztrogonác.
2705 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2706 Removed 'qt' platform config.
2707 * Scripts/webkitpy/common/net/bugzilla/bug.py:
2708 Deleted non-functional e-mail address.
2710 2016-07-08 Commit Queue <commit-queue@webkit.org>
2712 Unreviewed, rolling out r202967.
2713 https://bugs.webkit.org/show_bug.cgi?id=159556
2715 This patch caused crashes in https tests on Windows (Requested
2716 by perarne on #webkit).
2720 "[Win] The test http/tests/security/contentSecurityPolicy
2721 /upgrade-insecure-requests/basic-upgrade.https.html is
2723 https://bugs.webkit.org/show_bug.cgi?id=159510
2724 http://trac.webkit.org/changeset/202967
2726 2016-07-08 Youenn Fablet <youenn@apple.com>
2728 Generate WebCore builtin wrapper files
2729 https://bugs.webkit.org/show_bug.cgi?id=159461
2731 Reviewed by Brian Burg.
2733 * Scripts/webkitpy/codegen/main.py:
2734 (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
2735 (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
2737 2016-07-08 Hunseop Jeong <hs85.jeong@samsung.com>
2739 [EFL] Fix build when media-stream is enabled.
2740 https://bugs.webkit.org/show_bug.cgi?id=159206
2742 Bump up the openwebrtc to find the correct package.
2744 Reviewed by Gyuyoung Kim.
2746 * efl/jhbuild.modules:
2747 * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
2749 2016-07-07 Per Arne Vollan <pvollan@apple.com>
2751 [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2752 https://bugs.webkit.org/show_bug.cgi?id=159510
2754 Reviewed by Brent Fulgham.
2756 Allow any https certificate when running tests.
2758 * DumpRenderTree/win/DumpRenderTree.cpp:
2761 2016-07-07 Beth Dakin <bdakin@apple.com>
2763 API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2764 https://bugs.webkit.org/show_bug.cgi?id=159532
2766 rdar://problem/27177179
2768 Reviewed by Tim Horton.
2770 * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
2771 (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2773 2016-07-07 Andy Estes <aestes@apple.com>
2775 [Content Filtering] Load blocked pages more like other error pages are loaded
2776 https://bugs.webkit.org/show_bug.cgi?id=159485
2777 <rdar://problem/26014076>
2779 Reviewed by Brady Eidson.
2781 Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2782 to a content filtering provisional navigation failure is ignored in preference of
2783 ContentFilter's own error page.
2785 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2786 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2787 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2788 (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2789 (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2790 (loadAlternateTest):
2792 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2793 (-[MockContentFilterEnabler initWithCoder:]):
2794 * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2795 (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2796 (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2797 (TestWebKitAPI::loadAlternateTest):
2798 (TestWebKitAPI::TEST):
2800 2016-07-07 Per Arne Vollan <pvollan@apple.com>
2802 Unreviewed: add myself to the reviewers list.
2804 * Scripts/webkitpy/common/config/contributors.json:
2806 2016-07-07 Per Arne Vollan <pvollan@apple.com>
2808 [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
2809 https://bugs.webkit.org/show_bug.cgi?id=159509
2811 Reviewed by Alex Christensen.
2813 We should always insert the url in the url map when identifierForInitialRequest
2814 is called. Otherwise we can end up with identifiers not having an entry in the
2815 url map when urls are written to the test output file.
2817 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2818 (ResourceLoadDelegate::identifierForInitialRequest):
2820 2016-07-06 Tim Horton <timothy_horton@apple.com>
2822 Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
2823 https://bugs.webkit.org/show_bug.cgi?id=159498
2824 <rdar://problem/26719903>
2826 Reviewed by Sam Weinig.
2828 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2829 * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
2830 (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
2831 (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
2834 Add a test ensuring that ReferenceDate in the DataDetectors context is respected
2835 when deciding what to linkify.
2837 2016-07-06 Alexey Proskuryakov <ap@apple.com>
2839 Build fix - work around rdar://problem/27196668.
2841 * LayoutTestRelay/Configurations/Base.xcconfig:
2843 2016-07-05 Per Arne Vollan <pvollan@apple.com>
2845 Enhance Windows DRT implementation to support platform scroll wheel events.
2846 https://bugs.webkit.org/show_bug.cgi?id=36002
2848 Reviewed by Brent Fulgham.
2850 Implement function continuousMouseScrollBy in Windows event sender.
2852 * DumpRenderTree/win/EventSender.cpp:
2854 (continuousMouseScrollBy):
2856 2016-07-05 Myles C. Maxfield <mmaxfield@apple.com>
2858 [Sierra] Rebaseline tests to use un-mocked system font metrics
2859 https://bugs.webkit.org/show_bug.cgi?id=159311
2860 <rdar://problem/24138411>
2862 Reviewed in person by Alexey Proskuryakov.
2864 Stop mocking the system font on Sierra.
2866 * DumpRenderTree/mac/DumpRenderTree.mm:
2867 (setDefaultsToConsistentValuesForTesting):
2868 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2869 (WTR::InjectedBundle::platformInitialize):
2871 2016-07-05 Brady Eidson <beidson@apple.com>
2873 Database process crashes deleting a corrupt SQLite database file (null deref).
2874 https://bugs.webkit.org/show_bug.cgi?id=155506.
2876 Reviewed by Alex Christensen.
2878 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2879 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
2880 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
2881 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
2882 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
2883 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
2885 2016-07-05 Alexey Proskuryakov <ap@apple.com>
2887 run-webkit-tests should print more complete baseline search paths
2888 https://bugs.webkit.org/show_bug.cgi?id=159354
2890 Reviewed by Daniel Bates.
2892 run-webkit-tests used to only print directory names in baseline search paths.
2893 This was ok in basic usage, but quickly got confusing when using
2894 --additional-platform-directory flags.
2896 * Scripts/webkitpy/layout_tests/views/printing.py:
2897 (Printer.print_config):
2898 * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2899 (Testprinter.test_print_config):
2900 (Testprinter.test_print_one_line_summary):
2902 2016-07-04 Brady Eidson <beidson@apple.com>
2904 WebProcesses don't handle DatabaseProcess going away uncleanly..
2905 https://bugs.webkit.org/show_bug.cgi?id=159371
2907 Reviewed by Alex Christensen.
2909 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2910 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
2911 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
2912 (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
2913 (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
2915 2016-07-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
2917 [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
2918 https://bugs.webkit.org/show_bug.cgi?id=158141
2920 Rubber-stamped by Michael Catanzaro.
2922 Instead of checking for an specific Ubuntu version, query the apt
2923 database to see which version of PHP is available.
2925 * efl/install-dependencies:
2926 * gtk/install-dependencies:
2928 2016-07-04 Fujii Hironori <Hironori.Fujii@sony.com>
2930 webkit-patch failure-reason always raises TypeError
2931 https://bugs.webkit.org/show_bug.cgi?id=159394
2933 Reviewed by Benjamin Poulain.
2935 In r170637 (Bug 133067), the first and second arguments of
2936 pluralize were swapped.
2938 * Scripts/webkitpy/tool/commands/queries.py:
2939 (FailureReason._builder_to_explain): Swap the first and second
2940 arguments of pluralize.
2942 2016-07-02 Youenn Fablet <youennf@gmail.com>
2944 Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
2945 https://bugs.webkit.org/show_bug.cgi?id=152486
2947 Reviewed by Daniel Bates.
2949 Add launch of web-platform-tests server by run-webkit-httpd.
2950 Add two options to disable starting httpd and web-platform-tests servers.
2952 * Scripts/run-webkit-httpd:
2956 2016-07-01 Myles C. Maxfield <mmaxfield@apple.com>
2958 REGRESSION(r189668): Notification tests are flakey
2959 https://bugs.webkit.org/show_bug.cgi?id=159375
2960 <rdar://problem/22760990>
2962 Reviewed by Alexey Proskuryakov.
2964 Notifications are objects which must exist in both the UI Process and the Web Process. Each process
2965 identifies a notification object by a unique ID. When the Web Process sends a message regarding a
2966 notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
2967 (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
2969 Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
2970 by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
2971 to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
2972 global notification ID mapping, causing the wrong notification to be investigated.
2974 The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
2975 manually perform this same mapping. Luckily, this object already receives callbacks every time a
2976 notification is created or destroyed. However, because this object is implemented outside WebKit,
2977 it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
2978 this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
2979 WebNotificationProvider can properly map between the different IDs.
2981 * WebKitTestRunner/TestController.cpp:
2982 (WTR::TestController::runTestingServerLoop):
2983 (WTR::TestController::simulateWebNotificationClick):
2984 * WebKitTestRunner/WebNotificationProvider.cpp:
2985 (WTR::WebNotificationProvider::showWebNotification):
2986 (WTR::removeGlobalIDFromIDMap):
2987 (WTR::WebNotificationProvider::closeWebNotification):
2988 (WTR::WebNotificationProvider::removeNotificationManager):
2989 (WTR::WebNotificationProvider::simulateWebNotificationClick):
2990 (WTR::WebNotificationProvider::reset):
2991 * WebKitTestRunner/WebNotificationProvider.h:
2993 2016-07-01 Alexey Proskuryakov <ap@apple.com>
2995 Simplify LayoutTestRelay
2996 https://bugs.webkit.org/show_bug.cgi?id=159353
2998 Reviewed by Daniel Bates.
3000 1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3001 by name and runtime makes no sense.
3002 2. Removed code to create devices, webkitpy always does this in advance.
3003 3. Don't create copies of testing apps - we can install the same one into
3004 each simulator, now that we don't run multiple tester processes in a single simulator.
3005 4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3006 5. Removed code that kept testing apps alive in the background.
3007 6. Slightly updated coding style in functions that I touched.
3009 * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3010 Updated for what we acually use at this point.
3012 * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3013 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3014 (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3015 (-[LTRelayController ipcIdentifier]):
3016 (-[LTRelayController processName]):
3017 (-[LTRelayController didReceiveStdoutData:]):
3018 (-[LTRelayController didCrashWithMessage:]):
3019 (-[LTRelayController installApp]):
3020 (-[LTRelayController _environmentVariables]):
3021 (-[LTRelayController launchApp]):
3022 (-[LTRelayController start]):
3023 (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3024 (-[LTRelayController uniqueAppPath]): Deleted.
3025 (-[LTRelayController uniqueAppURL]): Deleted.
3026 (-[LTRelayController uniqueAppIdentifier]): Deleted.
3027 (-[LTRelayController createUniqueApp]): Deleted.
3028 * LayoutTestRelay/LayoutTestRelay/main.m:
3030 (getRequiredStringArgument):
3032 (getTestingSimDevice): Deleted.
3033 * Scripts/webkitpy/port/driver.py:
3034 (IOSSimulatorDriver.cmd_line):
3035 * WebKitTestRunner/ios/TestControllerIOS.mm:
3036 (WTR::TestController::platformInitialize):
3037 * WebKitTestRunner/ios/mainIOS.mm:
3038 (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3039 * DumpRenderTree/mac/DumpRenderTree.mm:
3041 (-[DumpRenderTree applicationDidEnterBackground:]):
3043 2016-07-01 Konstantin Tokarev <annulen@yandex.ru>
3045 [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3046 https://bugs.webkit.org/show_bug.cgi?id=159344
3048 Reviewed by Alex Christensen.
3050 * DumpRenderTree/CMakeLists.txt:
3052 2016-07-01 Youenn Fablet <youennf@gmail.com>
3054 Add a runtime flag for DOM iterators
3055 https://bugs.webkit.org/show_bug.cgi?id=159300
3057 Reviewed by Alex Christensen.
3059 * DumpRenderTree/mac/DumpRenderTree.mm:
3060 (resetWebPreferencesToConsistentValues):
3061 * DumpRenderTree/win/DumpRenderTree.cpp:
3062 (resetWebPreferencesToConsistentValues):
3063 * Scripts/webkitperl/FeatureList.pm:
3064 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3065 (WTR::InjectedBundle::beginTesting):
3066 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3067 (WTR::TestRunner::setDOMIteratorEnabled):
3068 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3070 2016-06-30 Tina Liu <iting_liu@apple.com>
3072 Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3073 https://bugs.webkit.org/show_bug.cgi?id=159326
3075 Reviewed by Brady Eidson.
3077 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3078 * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3079 (TestWebKitAPI::didFinishLoadForFrame):
3080 (TestWebKitAPI::didChangeBackForwardListForPage):
3081 (TestWebKitAPI::setPageLoaderClient):
3082 Set the page loader client and register for didFinishLoadForFrame and
3083 didChangeBackForwardList callbacks.
3084 (TestWebKitAPI::createSessionStateData):
3085 Load a webpage ("simple.html") and return the session state for this page.
3086 (TestWebKitAPI::TEST):
3087 Restore the page session state with that of "simple.html" without navigation.
3088 Verify that the committed URL is NULL since there's no navigation involved.
3089 Verify that the current item in the back forward list, which should be what
3090 we restored from the session state, has the expected URL.
3092 2016-06-29 Filip Pizlo <fpizlo@apple.com>
3094 Generators violate bytecode liveness validation
3095 https://bugs.webkit.org/show_bug.cgi?id=159279
3097 Reviewed by Yusuke Suzuki.
3099 Add Basic to our test harness.
3101 * Scripts/run-javascriptcore-tests:
3102 (runJSCStressTests):
3104 2016-06-30 Per Arne Vollan <pvollan@apple.com>
3106 [Win][Debug] Assertion fails in TestWTF.
3107 https://bugs.webkit.org/show_bug.cgi?id=159299
3109 Reviewed by Alex Christensen.
3111 The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3112 The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3113 the assertion failure. Since the variable is actually used, there is no need to use the
3116 * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3117 (TestWebKitAPI::TEST):
3119 2016-06-30 Youenn Fablet <youennf@gmail.com>
3121 LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3122 https://bugs.webkit.org/show_bug.cgi?id=159166
3123 <rdar://problem/27051759>
3125 Reviewed by Alexey Proskuryakov.
3127 Setting the certificate directory to the copied config.json.
3129 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3130 (WebPlatformTestServer._copy_webkit_test_files):
3132 2016-06-29 Mark Lam <mark.lam@apple.com>
3134 Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3135 https://bugs.webkit.org/show_bug.cgi?id=159274
3137 Reviewed by Keith Miller.
3139 * DumpRenderTree/mac/DumpRenderTree.mm:
3140 (DumpRenderTreeMain):
3142 2016-06-29 Alex Christensen <achristensen@webkit.org>
3144 WKWebView should ask WKNavigationDelegate about bad ssl certificates
3145 https://bugs.webkit.org/show_bug.cgi?id=159176
3147 Reviewed by Sam Weinig.
3149 * MiniBrowser/mac/WK2BrowserWindowController.m:
3150 (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3151 (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3152 (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3154 2016-06-29 Carlos Alberto Lopez Perez <clopez@igalia.com>
3156 [GTK] Add missing install dependency after r202619
3157 https://bugs.webkit.org/show_bug.cgi?id=156716
3161 * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3163 2016-06-29 Carlos Alberto Lopez Perez <clopez@igalia.com>
3165 [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3166 https://bugs.webkit.org/show_bug.cgi?id=156716
3168 Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3170 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3172 * Scripts/webkitpy/port/gtk.py:
3174 (GtkPort._driver_class):
3175 (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3176 (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3177 platform directory for storing the wayland specific layout test results and expectations for ${port}.
3178 For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3179 test expectations file on the GTK port when running the tests with the --wayland command line switch.
3180 Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3181 * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3182 (WestonDriver.check_driver):
3183 (WestonDriver.__init__):
3184 (WestonDriver._start):
3185 * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3186 (WestonXvfbDriverDisplayTest):
3187 (WestonXvfbDriverDisplayTest.__init__):
3188 (WestonXvfbDriverDisplayTest._xvfb_run):
3189 (WestonDriverTest.make_driver):
3190 (WestonDriverTest.test_start):
3191 * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3192 or to satisfy the pkg-config check of the new added modules in JHBuild.
3193 * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3194 and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3195 provided by the system are already new enough.
3196 Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3197 It was the only way to get the software EGL rasterizer working without depending on user drivers.
3198 Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3199 feature to avoid building libdrm when the one provided by the system is new enough.
3201 * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3202 Xorg had no support for searching the DRI drivers on a custom path at runtime.
3203 This patch implements support for that reusing the same variable that we use with Mesa to set the
3204 custom path for the DRI drivers path.
3206 2016-06-29 Alejandro G. Castro <alex@igalia.com>
3208 [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3209 https://bugs.webkit.org/show_bug.cgi?id=159256
3211 Reviewed by Philippe Normand.
3213 We need the last fixes in the repository to make the scream queue
3216 * gtk/jhbuild.modules:
3218 2016-06-28 Commit Queue <commit-queue@webkit.org>
3220 Unreviewed, rolling out r202580.
3221 https://bugs.webkit.org/show_bug.cgi?id=159245
3223 Caused all WKTR tests to fail on GuardMalloc and Production
3224 only for unknown reasons, investigating offline. (Requested by
3229 "RunLoop::Timer should use constructor templates instead of
3231 https://bugs.webkit.org/show_bug.cgi?id=159153
3232 http://trac.webkit.org/changeset/202580
3234 2016-06-28 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
3236 Use a regex to check if a test step is for JavaScriptCore
3237 https://bugs.webkit.org/show_bug.cgi?id=159224
3239 Reviewed by Geoffrey Garen.
3241 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3242 (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3243 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3244 (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3245 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3246 (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3248 2016-06-28 Michael Saboff <msaboff@apple.com>
3250 btjs no longer accepts optional frame count argument
3251 https://bugs.webkit.org/show_bug.cgi?id=159235
3253 Reviewed by Saam Barati.
3255 Fix the detection of optional backtrace-depth parameter to use the length
3258 * lldb/lldb_webkit.py:
3261 2016-06-28 Jon Lee <jonlee@apple.com>
3263 Update animometer.plan
3265 Rubber-stamped by Said Abou-Hallawa.
3267 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3269 2016-06-28 Filip Pizlo <fpizlo@apple.com>
3271 Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3273 * Scripts/run-javascriptcore-tests:
3274 (runJSCStressTests):
3276 2016-06-28 Brian Burg <bburg@apple.com>
3278 RunLoop::Timer should use constructor templates instead of class templates
3279 https://bugs.webkit.org/show_bug.cgi?id=159153
3281 Reviewed by Alex Christensen.
3283 Remove the RunLoop::Timer class template argument, and pass its constructor
3284 a reference to `this` instead of a pointer to `this`.
3286 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3287 (WTR::TestRunner::TestRunner):
3288 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3289 * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3290 (TestWebKitAPI::TEST):
3292 2016-06-28 Ryosuke Niwa <rniwa@webkit.org>
3294 REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3295 https://bugs.webkit.org/show_bug.cgi?id=159199
3297 Reviewed by Alexey Proskuryakov.
3299 Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3301 * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3302 * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3303 * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3304 an input element getting automatically focused on Mac.
3306 2016-06-28 Per Arne Vollan <pvollan@apple.com>
3308 [Win] Custom elements tests are failing.
3309 https://bugs.webkit.org/show_bug.cgi?id=159139
3311 Reviewed by Alex Christensen.
3313 Enable custom element API when running tests.
3315 * DumpRenderTree/win/DumpRenderTree.cpp:
3316 (resetWebPreferencesToConsistentValues):
3318 2016-06-27 Lucas Forschler <lforschler@apple.com>
3320 Test commit. Please ignore.
3322 2016-06-27 Michael Catanzaro <mcatanzaro@igalia.com>
3324 [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3325 https://bugs.webkit.org/show_bug.cgi?id=155073
3327 Reviewed by Daniel Bates.
3329 * Scripts/webkitperl/FeatureList.pm:
3331 2016-06-27 Simon Fraser <simon.fraser@apple.com>
3333 [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3334 https://bugs.webkit.org/show_bug.cgi?id=159077
3336 Reviewed by Tim Horton.
3338 Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3340 Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3341 which is necessary for UI-side compositing.
3343 Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3344 seems to happen for some tests that call window.resizeTo().
3346 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3347 (WTR::InjectedBundlePage::dump): Deleted.
3348 * WebKitTestRunner/TestInvocation.cpp:
3349 (WTR::TestInvocation::dumpResults):
3350 * WebKitTestRunner/cg/TestInvocationCG.cpp:
3351 (WTR::createCGContextFromImage):
3352 (WTR::computeMD5HashStringForContext):
3353 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3354 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3355 (WTR::PlatformWebView::windowSnapshotImage):
3357 2016-06-27 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3359 [EFL] Support to build on Debian linux
3360 https://bugs.webkit.org/show_bug.cgi?id=159123
3362 Reviewed by Antonio Gomes.
3364 * efl/install-dependencies: Install libgnutls28-dev.
3366 2016-06-27 Alex Christensen <achristensen@webkit.org>
3368 Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3369 https://bugs.webkit.org/show_bug.cgi?id=159071
3371 Reviewed by Brady Eidson.
3373 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3374 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3375 (WTR::TestRunner::setHandlesAuthenticationChallenges):
3376 (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3377 (WTR::TestRunner::setAuthenticationUsername):
3378 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3379 * WebKitTestRunner/TestController.cpp:
3380 (WTR::TestController::TestController):
3381 (WTR::TestController::resetStateToConsistentValues):
3382 (WTR::TestController::didFinishNavigation):
3383 (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3384 (WTR::TestController::didReceiveAuthenticationChallenge):
3385 (WTR::TestController::didCommitNavigation):
3386 * WebKitTestRunner/TestController.h:
3387 (WTR::TestController::setBlockAllPlugins):
3388 (WTR::TestController::setShouldLogHistoryClientCallbacks):
3389 (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3390 (WTR::TestController::isCurrentInvocation):
3391 * WebKitTestRunner/TestInvocation.cpp:
3392 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3393 Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3395 2016-06-27 Per Arne Vollan <pvollan@apple.com>
3397 [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3398 https://bugs.webkit.org/show_bug.cgi?id=159129
3400 Reviewed by Alex Christensen.
3402 Implement the function mouseScrollBy in the Windows event sender.
3404 * DumpRenderTree/win/EventSender.cpp:
3406 (mouseScrollByWithWheelAndMomentumPhasesCallback):
3408 2016-06-25 Filip Pizlo <fpizlo@apple.com>
3410 REGRESSION: Weak symbol warning when linking TestWebKitAPI
3411 https://bugs.webkit.org/show_bug.cgi?id=159104
3413 Reviewed by Dan Bernstein.
3415 This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3416 this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3418 * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3419 * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3420 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3422 2016-06-25 Per Arne Vollan <pvollan@apple.com>
3424 [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3425 https://bugs.webkit.org/show_bug.cgi?id=159086
3427 Reviewed by Alex Christensen.
3429 Implement required wheel event function in event sender.
3431 * DumpRenderTree/win/EventSender.cpp:
3432 (mouseScrollByWithWheelAndMomentumPhasesCallback):
3434 2016-06-24 Filip Pizlo <fpizlo@apple.com>
3436 REGRESSION: Weak symbol warning when linking TestWebKitAPI
3437 https://bugs.webkit.org/show_bug.cgi?id=159104
3439 Reviewed by Mark Lam.
3441 The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3444 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3446 2016-06-24 David Kilzer <ddkilzer@apple.com>
3448 parser_unittests.pl should not hardcode list of tests
3449 <https://webkit.org/b/159074>
3451 Reviewed by Daniel Bates.
3453 * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3454 Update to read the list of tests from the 'resources' directory,
3455 and instead map file extensions to subroutine names. Switch to
3456 use File::Basename::fileparse() to get basename and file
3457 extension for each test.
3458 (readTestFiles): Added. Reads files from the directory passed
3459 in and ignores: hidden files, anything that isn't a plain file,
3460 and expected test results files.
3462 2016-06-23 Simon Fraser <simon.fraser@apple.com>
3466 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3467 * DumpRenderTree/cg/PixelDumpSupportCG.h:
3469 2016-06-23 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3471 [EFL] Change download path of libxslt
3473 Unreviewed EFL build fix.
3475 In Korea current download path can't be accessed. Change it.
3477 * efl/jhbuild.modules:
3479 2016-06-23 Simon Fraser <simon.fraser@apple.com>
3481 https://bugs.webkit.org/show_bug.cgi?id=159077
3483 Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3484 snapshot the final state of the test in release builds.
3486 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3487 (WTR::InjectedBundlePage::dump):
3489 2016-06-23 Simon Fraser <simon.fraser@apple.com>
3491 Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3493 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3494 (createBitmapContextFromWebView):
3495 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3496 (WTR::PlatformWebView::windowSnapshotImage):
3498 2016-06-23 Simon Fraser <simon.fraser@apple.com>
3500 [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3501 https://bugs.webkit.org/show_bug.cgi?id=159077
3503 Reviewed by Tim Horton.
3505 Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3506 This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3507 thus enabling testing of more things.
3509 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3510 (createBitmapContext): Moved to this file to share it.
3511 * DumpRenderTree/cg/PixelDumpSupportCG.h:
3512 * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3513 (createBitmapContextFromWebView):
3514 (BitmapContext::createFromUIImage): Deleted.
3515 (BitmapContext::pixelData): Deleted.
3516 (BitmapContext::BitmapContext): Deleted.
3517 (computeMD5HashStringForBitmapContext): Deleted.
3518 (dumpBitmap): Deleted.
3519 * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3520 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3521 (createPagedBitmapContext):
3522 (createBitmapContext): Deleted.
3523 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3524 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3525 (WTR::InjectedBundlePage::dump): Deleted.
3526 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3527 (WTR::PlatformWebView::windowSnapshotImage):
3529 2016-06-23 Konstantin Tokarev <annulen@yandex.ru>
3531 [jhbuild] Added libxslt module.
3532 https://bugs.webkit.org/show_bug.cgi?id=159034
3534 Unreviewed, followup for r202373.
3536 * efl/install-dependencies: Removed libxslt
3537 * gtk/install-dependencies: Ditto.
3539 2016-06-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3541 [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3542 https://bugs.webkit.org/show_bug.cgi?id=159050
3544 Reviewed by Antonio Gomes.
3546 To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3548 * efl/jhbuild.modules:
3549 * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3550 * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3552 2016-06-23 Konstantin Tokarev <annulen@yandex.ru>
3554 [jhbuild] Added libxslt module.
3555 https://bugs.webkit.org/show_bug.cgi?id=159034
3557 Reviewed by Michael Catanzaro.
3559 * efl/jhbuild.modules:
3560 * gtk/jhbuild.modules:
3562 2016-06-22 Per Arne Vollan <pvollan@apple.com>
3564 [Win] Use Windows api function to find top level parent.
3565 https://bugs.webkit.org/show_bug.cgi?id=159021
3567 Reviewed by Brent Fulgham.
3569 Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3571 * DumpRenderTree/win/UIDelegate.cpp:
3572 (UIDelegate::runModal):
3573 (findTopLevelParent): Deleted.
3574 * MiniBrowser/win/PrintWebUIDelegate.cpp:
3575 (PrintWebUIDelegate::runModal):
3576 (findTopLevelParent): Deleted.
3578 2016-06-22 Per Arne Vollan <pvollan@apple.com>
3580 [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3581 https://bugs.webkit.org/show_bug.cgi?id=158934
3583 Reviewed by Brent Fulgham.
3585 DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3587 * DumpRenderTree/win/TestRunnerWin.cpp:
3588 (TestRunner::clearAllDatabases):
3590 2016-06-22 Saam Barati <sbarati@apple.com>
3592 run-javascriptcore-tests should have some environment variables for commonly used settings
3593 https://bugs.webkit.org/show_bug.cgi?id=159047
3595 Reviewed by Keith Miller.
3597 This patch adds three environment variables that run-javascriptcore-tests
3599 - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3600 determines if we should run the api tests or not.
3601 - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3602 determines if we will perform a build or not before running the tests.
3603 to set the default should-build setting.
3604 - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3605 a yaml file. If set, we will run the extra tests it refers to.
3607 All the values in these environment variables will be overridden if an
3608 option is explicitly passed in. For example, the following will run
3610 `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3612 * Scripts/run-javascriptcore-tests:
3614 2016-06-22 Saam barati <sbarati@apple.com>
3616 TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3617 https://bugs.webkit.org/show_bug.cgi?id=159037
3618 <rdar://problem/26935349>
3620 Reviewed by Benjamin Poulain.
3622 Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3624 * Scripts/run-jsc-stress-tests:
3626 2016-06-22 Aakash Jain <aakash_jain@apple.com>
3628 Fix style issues in webkitpy
3629 https://bugs.webkit.org/show_bug.cgi?id=159019
3631 Reviewed by Daniel Bates.
3633 Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3634 There is no functionality change.
3635 Only affected file names retained below for brevity.
3637 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3638 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3639 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3640 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3641 * Scripts/webkitpy/benchmark_runner/utils.py:
3642 * Scripts/webkitpy/common/checkout/changelog.py:
3643 * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3644 * Scripts/webkitpy/common/checkout/checkout.py:
3645 * Scripts/webkitpy/common/checkout/checkout_mock.py: