09bd6576fef29087517bcf59a57d69cf489baee6
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-29  Keith Rollin  <krollin@apple.com>
2
3         Update .xcconfig symbols to reflect the current set of past and future product versions.
4         https://bugs.webkit.org/show_bug.cgi?id=200720
5         <rdar://problem/54305032>
6
7         Reviewed by Alex Christensen.
8
9         Remove version symbols related to old OS's we no longer support,
10         ensure that version symbols are defined for OS's we do support.
11
12         * ContentExtensionTester/Configurations/Base.xcconfig:
13         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
14         * DumpRenderTree/mac/Configurations/Base.xcconfig:
15         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
16         * ImageDiff/cg/Configurations/Base.xcconfig:
17         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
18         * MiniBrowser/Configurations/Base.xcconfig:
19         * MiniBrowser/Configurations/DebugRelease.xcconfig:
20         * TestWebKitAPI/Configurations/Base.xcconfig:
21         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
22         * WebEditingTester/Configurations/Base.xcconfig:
23         * WebEditingTester/Configurations/DebugRelease.xcconfig:
24         * WebKitTestRunner/Configurations/Base.xcconfig:
25         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
26         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
27         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
28
29 2019-08-29  Keith Rollin  <krollin@apple.com>
30
31         Remove empty FontCache.cpp file in TestWebKitAPI
32         https://bugs.webkit.org/show_bug.cgi?id=201277
33         <rdar://problem/54820726>
34
35         Reviewed by Alex Christensen.
36
37         Bug 200694 emptied out the contents of FontCache.cpp. This patch
38         removes the file from the project.
39
40         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
41         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
42
43 2019-08-29  Aakash Jain  <aakash_jain@apple.com>
44
45         [ews-app] Status bubble should only display important messages in pop-over
46         https://bugs.webkit.org/show_bug.cgi?id=201308
47
48         Reviewed by Jonathan Bedard.
49
50         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added various build-steps which are of low interest
51         to end-users in STEPS_TO_HIDE. If any of these steps fail, it will not be hidden.
52
53 2019-08-29  Keith Rollin  <krollin@apple.com>
54
55         Remove support for macOS < 10.13 (part 3)
56         https://bugs.webkit.org/show_bug.cgi?id=201224
57         <rdar://problem/54795934>
58
59         Reviewed by Darin Adler.
60
61         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
62         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
63         like _MACOS_SINCE_1013.
64
65         Also added some macOS target numbers.
66
67         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
68
69 2019-08-29  Jonathan Bedard  <jbedard@apple.com>
70
71         results.webkit.org: Remove border from tooltip
72         https://bugs.webkit.org/show_bug.cgi?id=201239
73
74         Reviewed by Alex Christensen.
75
76         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
77         (.tooltip-content): Remove border.
78
79 2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
80
81         [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
82         https://bugs.webkit.org/show_bug.cgi?id=201215
83
84         Reviewed by Don Olmstead.
85
86         MiniBrowser crashed if it was going to go to a unreachable page
87         because WKPageCopyActiveURL returned a nullptr.
88
89         * MiniBrowser/win/WebKitBrowserWindow.cpp:
90         (createString): Added null checking of the argument.
91
92 2019-08-28  Tim Horton  <timothy_horton@apple.com>
93
94         Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
95         https://bugs.webkit.org/show_bug.cgi?id=201256
96         <rdar://problem/54809509>
97
98         Reviewed by Simon Fraser.
99
100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
101         * TestWebKitAPI/Tests/WebKit/long-email-viewport.html: Added.
102         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm: Added.
103         (TestWebKitAPI::TEST):
104         Add a test. I left many comments because I had a great deal of trouble
105         writing this test and wanted to document my findings.
106
107 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
108
109         results.webkit.org: Do not display branch selector if only one branches available
110         https://bugs.webkit.org/show_bug.cgi?id=201244
111
112         Rubber-stamped by Aakash Jain.
113
114         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Hide the branch selector's
115         container if there aren't multiple branches to choose from.
116
117 2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
118
119         WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
120         https://bugs.webkit.org/show_bug.cgi?id=201241
121         <rdar://problem/54317588>
122
123         Reviewed by Tim Horton.
124
125         For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
126         communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
127         the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
128         -dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
129         it believes that the web view has rejected the drop from being handled.
130
131         Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
132         to make sure that the web process has had time to send a response after each update.
133
134         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
135         (-[DragAndDropSimulator _advanceProgress]):
136
137 2019-08-28  Megan Gardner  <megan_gardner@apple.com>
138
139         Null check webFrame when creating a print preview to prevent a crash.
140         https://bugs.webkit.org/show_bug.cgi?id=201237
141         <rdar://problem/51618863>
142
143         Reviewed by Tim Horton.
144
145         Test to verify that if we don't have the WebPageProxy, we will not crash when making a print preview.
146
147         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
148         (TEST):
149
150 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
151
152         results.webkit.org: Move drawer to the right, open by default
153         https://bugs.webkit.org/show_bug.cgi?id=200977
154
155         Rubber-stamped by Aakash Jain.
156
157         The drawer was both unpopular and not discoverable. After feedback from bot watchers,
158         moving the drawer to the right side of the screen, opening it by default and have it displace
159         instead of hide the main content.
160
161         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py:
162         (CommitViewUnittest.test_drawer): Support new drawer style.
163         (CommitViewUnittest.test_range_slider): Ditto.
164         (CommitViewUnittest.test_one_line_switch): Ditto.
165         (CommitViewUnittest.test_branch_selection): Ditto.
166         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Removed.
167         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
168         (setEnableRecursive): Disable all elements underneath this one 
169         (Drawer): Make drawer a sidebar.
170         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
171         (.header>.title, .topbar>.title): Overflow of titles should be hidden.
172         (:root): Move boldInverseColor into webkit.css.
173         (@media (prefers-color-scheme: dark)):
174         (.sidebar): Sidebars on mobile should behave like drawers.
175         (.sidebar.hidden): Add concept of hidden sidebar.
176         (.mobile-sidebar-control): Add a control to collapse sidebar that only exists on mobile.
177         (.mobile-sidebar-control.display):
178         (.main.under-topbar-with-actions):
179         (@media screen and (min-width: 600px) and (orientation: landscape)):
180         (.sidebar.left.hidden):
181         (.sidebar.right.hidden):
182         (.main.right.hidden):
183         (.main.left.hidden):
184         (@media screen and (min-width: 768px) and (orientation: landscape)):
185         (.sidebar.right):
186         (a.disabled): Add ability to disable a link.
187         (.desktop-control): Add a control which only exists on desktop.
188         * resultsdbpy/resultsdbpy/view/templates/base.html: Add hamburger drawer-button for mobile.
189         * resultsdbpy/resultsdbpy/view/templates/commits.html: Use main since Drawer is now a sidebar.
190         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Ditto.
191         * resultsdbpy/resultsdbpy/view/templates/search.html: Ditto.
192         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
193         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
194         (WebSiteTestCase.toggle_drawer): Support new drawer style.
195         (WebSiteTestCase.find_input_with_name): Ditto.
196
197 2019-08-28  Keith Rollin  <krollin@apple.com>
198
199         Remove support for macOS < 10.13 (part 2)
200         https://bugs.webkit.org/show_bug.cgi?id=201197
201         <rdar://problem/54759985>
202
203         Reviewed by Darin Adler.
204
205         Update conditionals that reference WK_MACOS_1013 and suffixes like
206         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
207         later and that these conditionals are always True or False.
208
209         See Bug 200694 for earlier changes in this area.
210
211         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
212
213 2019-08-28  Alicia Boya García  <aboya@igalia.com>
214
215         [MSE][GStreamer] WebKitMediaSrc rework
216         https://bugs.webkit.org/show_bug.cgi?id=199719
217
218         Reviewed by Xabier Rodriguez-Calvar.
219
220         Added WebKitMediaSourceGStreamer.cpp to the GStreamer-style coding
221         whitelist.
222
223         * Scripts/webkitpy/style/checker.py:
224
225 2019-08-28  Alexey Proskuryakov  <ap@apple.com>
226
227         Updating inactive contributors in contributors.json.
228
229         * Scripts/webkitpy/common/config/contributors.json:
230
231 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
232
233         results.webkit.org: Auto-expand single configurations
234         https://bugs.webkit.org/show_bug.cgi?id=201218
235
236         Rubber-stamped by Aakash Jain.
237
238         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
239         (TimelineFromEndpoint.toString): Automatically expand timeline when only one
240         configuration has been specified.
241         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
242         (prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
243         is expanded or collapsed by default.
244
245 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
246
247         results.webkit.org: Sanitize all commit arguments on upload
248         https://bugs.webkit.org/show_bug.cgi?id=201189
249         <rdar://problem/54564837>
250
251         Reviewed by Aakash Jain.
252
253         * resultsdbpy/resultsdbpy/controller/commit.py:
254         (Commit.__init__): Only allow commits to be constructed with valid values.
255         * resultsdbpy/resultsdbpy/controller/commit_controller.py:
256         (CommitController.register): Strip potential API key.
257         * resultsdbpy/resultsdbpy/controller/commit_unittest.py:
258         (CommitUnittest.test_invalid): Test that commits which contain html inside the
259         repository_id, branch or commit id are rejected.
260
261 2019-08-02  Claudio Saavedra  <csaavedra@igalia.com>
262
263         [GTK][WPE] Implement HSTS for the soup network backend
264         https://bugs.webkit.org/show_bug.cgi?id=192074
265
266         Reviewed by Carlos Garcia Campos.
267
268         libsoup 2.67.1 introduced HSTS support via a SoupSessionFeature.
269         Add support to the soup network backend by adding the feature to
270         SoupNetworkSession and handling HSTS protocol upgrades, by
271         propagating the scheme change further to clients. This patch adds
272         the HSTS feature unconditionally, but it still possible to add
273         a boolean property to the web context class if desired.
274
275         Additionally, add API to the WebKitWebsiteDataManager to specify
276         the directory where the HSTS database is saved. If the directory
277         is not set or if the data manager is ephemeral, use a
278         non-persistent, memory only HSTS enforcer.
279
280         Implement as well the methods needed to clean-up and delete HSTS
281         policies from the storage and expose the feature in GTK+
282         MiniBrowser's about:data.
283
284         * MiniBrowser/gtk/main.c:
285         (gotWebsiteDataCallback):
286         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
287         (serverCallback):
288         (testWebsiteDataConfiguration):
289         (testWebsiteDataEphemeral):
290         (prepopulateHstsData):
291         (testWebsiteDataHsts):
292         (beforeAll):
293         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
294         (Test::Test):
295         * gtk/jhbuild.modules: Bump libsoup to 2.67.91 for the new APIs
296         * wpe/jhbuild.modules: Ditto
297         * MiniBrowser/gtk/main.c:
298         (gotWebsiteDataCallback):
299
300 2019-08-27  James Darpinian  <jdarpinian@google.com>
301
302         Fix applying diffs that only change file mode
303         https://bugs.webkit.org/show_bug.cgi?id=201191
304
305         Reviewed by Daniel Bates.
306
307         * Scripts/svn-apply:
308         (patch): Handle case of file mode change without content change
309
310 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
311
312         [ews] Status bubble should be red for CANCELLED builds
313         https://bugs.webkit.org/show_bug.cgi?id=201204
314
315         Reviewed by Jonathan Bedard.
316
317         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
318         (StatusBubble._build_bubble):
319
320 2019-08-27  Zhifei Fang  <zhifei_fang@apple.com>
321
322         [results.webkit.org Webkit.css] Center the legend symbols
323         https://bugs.webkit.org/show_bug.cgi?id=201187
324
325         Reviewed by Jonathan Bedard.
326
327         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
328         (.lengend>.item .dot .text): center the dot symbol vertically
329
330 2019-08-27  Jonathan Bedard  <jbedard@apple.com>
331
332         run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
333         https://bugs.webkit.org/show_bug.cgi?id=201000
334         <rdar://problem/53778938>
335
336         Unreviewed follow-up fix.
337
338         * Scripts/webkitpy/port/darwin.py:
339         (DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
340         spindump call failed.
341         * Scripts/webkitpy/port/darwin_testcase.py:
342         * Scripts/webkitpy/port/ios_device_unittest.py:
343
344 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
345
346         [ews-build] Use update-webkit script in Apply-WatchList EWS
347         https://bugs.webkit.org/show_bug.cgi?id=201179
348
349         Reviewed by Jonathan Bedard.
350
351         * BuildSlaveSupport/ews-build/factories.py:
352         (WatchListFactory): Updated to use CheckOutSource step as well.
353
354 2019-08-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
355
356         W3C test importer should be able to handle expected references with an absolute path.
357         https://bugs.webkit.org/show_bug.cgi?id=200717
358
359         Reviewed by Youenn Fablet.
360
361         This patch implements the logic to resolve test references with absolute paths
362         when importing w3c tests (like web-platform-tests).
363         When an absolute path is found for a test reference, the parser now
364         tries to find the right file by looking for a relative path inside
365         the root directory of the source test repository.
366         It works when the tool is run in download-mode as well as when the
367         tool is run to import the tests from a local directory.
368
369         This fixes the import of test references for tests like
370         web-platform-tests/css/css-images/multiple-position-color-stop-linear-2.html
371
372         * Scripts/webkitpy/w3c/test_importer.py:
373         (TestImporter._source_root_directory_for_path):
374         (TestImporter.find_importable_tests):
375         * Scripts/webkitpy/w3c/test_importer_unittest.py:
376         (TestImporterTest.import_directory):
377         (test_webkit_test_runner_options):
378         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
379         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
380         * Scripts/webkitpy/w3c/test_parser.py:
381         (TestParser.__init__):
382         (TestParser.analyze_test):
383
384 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
385
386         Remove UIHelper.activateElementAtHumanSpeed
387         https://bugs.webkit.org/show_bug.cgi?id=201147
388
389         Reviewed by Tim Horton.
390
391         Add plumbing for a new script controller hook to wait for the double tap delay to pass. On non-iOS, this
392         resolves immediately; on iOS, we inspect the content view for tap gestures that require more than one tap, and
393         find the value of the maximum double tap delay. We then delay for this amount of time before resolving.
394
395         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
396         * TestRunnerShared/UIScriptContext/UIScriptController.h:
397         (WTR::UIScriptController::doAfterDoubleTapDelay):
398         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
399         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
400         (WTR::UIScriptControllerIOS::doAfterDoubleTapDelay):
401
402 2019-08-26  Zhifei Fang  <zhifei_fang@apple.com>
403
404         [results.webkit.org Timline] Add symbols to the timeline dot
405         https://bugs.webkit.org/show_bug.cgi?id=201105
406
407         Reviewed by Jonathan Bedard.
408
409         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
410         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
411         (Timeline.CanvasSeriesComponent): Modify the drawDot api to provide user ability to add symbol to the dots, it supports unicode symbol
412         * resultsdbpy/resultsdbpy/view/templates/base.html: Add the encoding UTF-8 for the page, so that we can add unicode symbol to the dots
413
414 2019-08-26  Yusuke Suzuki  <ysuzuki@apple.com>
415
416         Unreviewed, remove useMaximalFlushInsertionPhase use
417         https://bugs.webkit.org/show_bug.cgi?id=201036
418
419         * Scripts/run-jsc-stress-tests:
420
421 2019-08-26  David Kilzer  <ddkilzer@apple.com>
422
423         Don't compute upconverted characters twice in buildQuery() in DataDetection.mm
424         <https://webkit.org/b/201144>
425         <rdar://problem/54689399>
426
427         Reviewed by Brent Fulgham.
428
429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
430         DataDetectorsTestIOS.mm to the project.
431         * TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm: Add a new
432         test for Data Detectors for phone numbers.
433
434 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
435
436         REGRESSION (iOS 13): Tests that simulate multiple back-to-back single taps fail or time out
437         https://bugs.webkit.org/show_bug.cgi?id=201129
438         <rdar://problem/51857277>
439
440         Reviewed by Tim Horton.
441
442         The tests in editing/pasteboard/ios were timing out on iOS 13 before this change. This is because they simulate
443         back-to-back single taps; while this is recognized as two single taps on iOS 12 and prior, only the first single
444         tap is recognized on iOS 13 (and the second is simply dropped on the floor). This occurs because the synthetic
445         single tap gesture is reset slightly later on iOS 13 compared to iOS 12, so when the second tap is dispatched,
446         the gesture recognizer is still in "ended" state after the first tap on iOS 13, which means the gesture isn't
447         capable of recognizing further touches yet.
448
449         In UIKit, a gesture recognizer is only reset once its UIGestureEnvironment's containing dependency subgraph no
450         longer contains gestures that are active. In iOS 12, the synthetic click gesture is a part of a dependency
451         subgraph that contains only itself and the normal (blocking) double tap gesture which requires the click to fail
452         before it can be recognized; immediately after simulating the tap, both these gestures are inactive, which
453         allows both of them to be reset.
454
455         However, in iOS 13, the synthetic click gesture is part of a gesture dependency graph that contains the double
456         tap for double click gesture, as well as the non-blocking double tap gesture, both of which are still active
457         immediately after sending the first tap. This change in dependencies is caused by the introduction of
458         UIUndoGestureInteraction's single and double three-finger tap gestures, which (in -[UIUndoGestureInteraction
459         gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]) explicitly add all other taps as failure
460         requirements. This effectively links the synthetic single tap gesture to most of the other gestures in
461         WKContentView's dependency graph by way of these tap gestures for the undo interaction.
462
463         All this means that there is now a short (~50 ms) delay after the synthetic single tap gestures is recognized,
464         before it can be recognized again. To account for this new delay in our test infrastructure, simply wait for
465         single tap gestures that have ended to reset before attempting to send subsequent single taps. We do this by
466         introducing WebKit testing SPI to invoke a completion handler after resetting the synthetic click gesture (only
467         if necessary - i.e., if the gesture is in ended state when we are about to begin simulating the tap). This
468         allows calls to `UIScriptController::singleTapAtPoint` to be reliably recognized as single taps without
469         requiring arbitrary 120 ms "human speed" delays.
470
471         This fixes a number of flaky or failing layout tests, including the tests in editing/pasteboard/ios.
472
473         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
474         * TestRunnerShared/UIScriptContext/UIScriptController.h:
475         (WTR::UIScriptController::doubleTapAtPoint):
476
477         Add a `delay` parameter to `doubleTapAtPoint`. A number of layout tests were actually simulating double click
478         gestures by simulating two back-to-back single taps; this is done for the purposes of being able to add a "human
479         speed" delay prior to the second single tap gesture. After the change to wait for the single tap gesture to
480         reset before attempting to simulate the next tap, this strategy no longer works, since the second gesture is
481         recognized only as a single tap instead of a double tap.
482
483         Instead, we add a delay parameter to `UIScriptController::doubleTapAtPoint`, which the "human speed" double tap
484         gestures use instead to wait after simulating the first tap.
485
486         * WebKitTestRunner/ios/HIDEventGenerator.h:
487         * WebKitTestRunner/ios/HIDEventGenerator.mm:
488         (-[HIDEventGenerator _waitFor:]):
489         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:delay:completionBlock:]):
490
491         Plumb the tap gesture delay through to this helper method.
492
493         (-[HIDEventGenerator tap:completionBlock:]):
494         (-[HIDEventGenerator doubleTap:delay:completionBlock:]):
495         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
496         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]): Deleted.
497         (-[HIDEventGenerator doubleTap:completionBlock:]): Deleted.
498         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
499         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
500         (WTR::UIScriptControllerIOS::waitForSingleTapToReset const):
501
502         Add a new helper to wait for the content view's single tap gesture to reset if needed; call this before
503         attempting to simulate single taps (either using a stylus, or with a regular touch).
504
505         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
506         (WTR::UIScriptControllerIOS::doubleTapAtPoint):
507         (WTR::UIScriptControllerIOS::stylusTapAtPointWithModifiers):
508
509 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
510
511         results.webkit.org: Allow clicking on the tooltip arrow
512         https://bugs.webkit.org/show_bug.cgi?id=201103
513
514         Rubber-stamped by Aakash Jain.
515
516         By design, the arrow sits above the canvas and intercepts mouse events from it.
517         This will often make an element that has a tooltip unclickable.
518
519         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
520         (xAxisFromScale):
521         (TimelineFromEndpoint.prototype.render.onDotEnterFactory):
522         (TimelineFromEndpoint.prototype.render):
523         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
524         (_ToolTip):
525         (_ToolTip.prototype.toString): Trigger onClick callback when the arrow is clicked.
526         (_ToolTip.prototype.set): Set the onClick callback.
527
528 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
529
530         [EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot
531         https://bugs.webkit.org/show_bug.cgi?id=201140
532
533         Reviewed by Jonathan Bedard.
534
535         * BuildSlaveSupport/ews-build/steps.py:
536         (TestWithFailureCount.getResultSummary): Do not append (failure) when in case of custom status.
537         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
538
539 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
540
541         run-webkit-tests: Cap the number of automatically booted simulators at 12
542         https://bugs.webkit.org/show_bug.cgi?id=201139
543
544         Reviewed by Aakash Jain.
545
546         To make local development with simulators more pleasant, machines should
547         never automatically boot more than 12 simulators.
548
549         * Scripts/webkitpy/xcode/simulated_device.py:
550         (SimulatedDeviceManager.max_supported_simulators):
551
552 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
553
554         [ews] Add EWS queue for applying watchlist
555         https://bugs.webkit.org/show_bug.cgi?id=201072
556
557         Reviewed by Jonathan Bedard.
558
559         * BuildSlaveSupport/ews-build/steps.py:
560         (ApplyWatchList): Build step to apply watchlist.
561         (ApplyWatchList.__init__): Set logEnviron to False.
562         (ApplyWatchList.getResultSummary): Updated the description in case of failure.
563         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
564         * BuildSlaveSupport/ews-build/factories.py:
565         (WatchListFactory): Build factory for WatchList.
566         * BuildSlaveSupport/ews-build/loadConfig.py:
567         * BuildSlaveSupport/ews-build/config.json:
568
569 2019-08-26  Youenn Fablet  <youenn@apple.com>
570
571         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
572         https://bugs.webkit.org/show_bug.cgi?id=196870
573
574         Reviewed by Alex Christensen.
575
576         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
577         Accept any server certificate by default.
578
579         * WebKitTestRunner/TestController.cpp:
580         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
581         (WTR::TestController::cocoaResetStateToConsistentValues):
582         (WTR::TestController::setAllowsAnySSLCertificate):
583         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
584         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
585         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
586         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
587
588 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
589
590         Increase log level for watchlist result
591         https://bugs.webkit.org/show_bug.cgi?id=201081
592
593         Reviewed by Jonathan Bedard.
594
595         * Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
596         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
597         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
598
599 2019-08-23  Chris Dumez  <cdumez@apple.com>
600
601         [geolocation] Rename interfaces and remove [NoInterfaceObject]
602         https://bugs.webkit.org/show_bug.cgi?id=200885
603
604         Reviewed by Alex Christensen.
605
606         * DumpRenderTree/mac/TestRunnerMac.mm:
607         (TestRunner::setMockGeolocationPosition):
608
609 2019-08-23  Ryan Haddad  <ryanhaddad@apple.com>
610
611         Unreviewed, rolling out r249001.
612
613         Caused one layout test to fail on all configurations and
614         another to time out on Catalina / iOS 13.
615
616         Reverted changeset:
617
618         "Add a WebsiteDataStore delegate to handle
619         AuthenticationChallenge that do not come from pages"
620         https://bugs.webkit.org/show_bug.cgi?id=196870
621         https://trac.webkit.org/changeset/249001
622
623 2019-08-23  Jonathan Bedard  <jbedard@apple.com>
624
625         results.webkit.org: Escape html in changelog
626         https://bugs.webkit.org/show_bug.cgi?id=201025
627         <rdar://problem/54564837>
628
629         Reviewed by Darin Adler.
630
631         * resultsdbpy/resultsdbpy/view/commit_view.py:
632         (CommitView.commit): Output a dictionary instead of a JSON encoded string.
633         * resultsdbpy/resultsdbpy/view/templates/commit.html: Unpack commits dictionary
634         directly into a JavaScript dictionary.
635
636 2019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
637
638         [WebAuthn] Support NFC authenticators for iOS
639         https://bugs.webkit.org/show_bug.cgi?id=188624
640         <rdar://problem/43354214>
641
642         Reviewed by Chris Dumez.
643
644         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
645         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
646         Setup NFC mock testing configuration.
647
648 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
649
650         [ews] Enable Style queue on new EWS
651         https://bugs.webkit.org/show_bug.cgi?id=201071
652
653         Reviewed by Jonathan Bedard.
654
655         * BuildSlaveSupport/ews-build/config.json: Enabled the scheduler for Style queue.
656         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled style queue bubble on new EWS.
657         * QueueStatusServer/config/queues.py: Removed style queue from old EWS.
658         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
659         (BubbleQueueServer): Removed style queue from bot-watcher's dashboard.
660
661 2019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
662
663         [Win][MiniBrowser] URL bar should be updated for in-page navigations
664         https://bugs.webkit.org/show_bug.cgi?id=201032
665
666         Reviewed by Darin Adler.
667
668         * MiniBrowser/win/BrowserWindow.h: Added activeURLChanged to BrowserWindowClient interface.
669         * MiniBrowser/win/MainWindow.cpp:
670         (MainWindow::init):
671         (MainWindow::activeURLChanged): Added.
672         * MiniBrowser/win/MainWindow.h:
673         * MiniBrowser/win/MiniBrowserWebHost.cpp:
674         (MiniBrowserWebHost::didCommitLoadForFrame):
675         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Added.
676         (MiniBrowserWebHost::updateAddressBar): Deleted.
677         (MiniBrowserWebHost::loadURL): Deleted.
678         * MiniBrowser/win/MiniBrowserWebHost.h:
679         (MiniBrowserWebHost::MiniBrowserWebHost):
680         (MiniBrowserWebHost::didCommitLoadForFrame): Deleted.
681         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Deleted.
682         * MiniBrowser/win/PrintWebUIDelegate.cpp:
683         * MiniBrowser/win/WebKitBrowserWindow.cpp:
684         (WebKitBrowserWindow::create):
685         (WebKitBrowserWindow::WebKitBrowserWindow):
686         (WebKitBrowserWindow::didChangeIsLoading): Removed an unused variable.
687         (WebKitBrowserWindow::didChangeActiveURL): Added.
688         (WebKitBrowserWindow::createNewPage):
689         (WebKitBrowserWindow::didCommitNavigation): Deleted.
690         * MiniBrowser/win/WebKitBrowserWindow.h: Removed m_urlBarWnd.
691         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
692         (WebKitLegacyBrowserWindow::create):
693         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
694         (WebKitLegacyBrowserWindow::init):
695         (WebKitLegacyBrowserWindow::navigateToHistory):
696         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Removed m_urlBarWnd.
697
698 2019-08-22  Andy Estes  <aestes@apple.com>
699
700         [watchOS] Disable Content Filtering in the simulator build
701         https://bugs.webkit.org/show_bug.cgi?id=201047
702
703         Reviewed by Tim Horton.
704
705         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
706
707 2019-08-22  Chris Dumez  <cdumez@apple.com>
708
709         Try to recover nicely when getting an unexpected schema in the service workers database
710         https://bugs.webkit.org/show_bug.cgi?id=201002
711         <rdar://problem/54574991>
712
713         Reviewed by Youenn Fablet.
714
715         Add API test coverage.
716
717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
718         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
719
720 2019-08-22  Keith Rollin  <krollin@apple.com>
721
722         Remove support for tvOS < 13.0
723         https://bugs.webkit.org/show_bug.cgi?id=200963
724         <rdar://problem/54541355>
725
726         Reviewed by Tim Horton.
727
728         Update conditionals that reference __TV_OS_VERSION_MIN_REQUIRED and
729         __TV_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
730         130000. This means that expressions like "__TV_OS_VERSION_MIN_REQUIRED
731         < 130000" are always False and "__TV_OS_VERSION_MIN_REQUIRED >=
732         130000" are always True.
733
734         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
735         (TestWebKitAPI::TEST):
736
737 2019-08-22  Daniel Bates  <dabates@apple.com>
738
739         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
740         https://bugs.webkit.org/show_bug.cgi?id=200742
741
742         Reviewed by Simon Fraser.
743
744         The OptionSet synthetic provider must respond to requests for the value of m_storage
745         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
746         of the type summary.
747
748         Synthetic providers substitute alternative debug information (children) for the default
749         information for a variable. The OptionSet type summary is implemented in terms of the
750         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
751         before invoking the type summary handler then evaluating GetChildMemberWithName() on
752         the SBValue passed to the type summary handler will access the substitute information
753         instead of the original debug information. As a result OptionSet's synthetic provider's
754         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
755         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
756         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
757         should return a valid value.
758
759         * lldb/lldb_webkit.py:
760         (FlagEnumerationProvider.__init__):
761         (FlagEnumerationProvider):
762         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
763         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
764         (FlagEnumerationProvider.size): Added.
765         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
766         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
767         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
768         and removed self.size. For the latter we can just expose a getter that returns the size of
769         the list self._elements.
770         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
771         value of m_storage.
772         (WTFOptionSetProvider):
773         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
774         matches the specified index.
775         * lldb/lldb_webkit_unittest.py:
776         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Update expected result now
777         that we return the value of m_storage as the last synthetic child.
778
779 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
780
781         results.webkit.org: Remove branch and repository information from commit tooltip
782         https://bugs.webkit.org/show_bug.cgi?id=201035
783
784         Reviewed by Aakash Jain.
785
786         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
787         (xAxisFromScale): Remove branch and repository information from tooltip.
788
789 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
790
791         run-webkit-tests: Use -noBulkSymbolication when calling spindump
792         https://bugs.webkit.org/show_bug.cgi?id=201000
793         <rdar://problem/53778938>
794
795         Reviewed by Alexey Proskuryakov.
796
797         * Scripts/webkitpy/port/darwin.py:
798         (DarwinPort.sample_process): Attempt to symbolicate with -noBulkSymbolication first.
799         * Scripts/webkitpy/port/darwin_testcase.py:
800         (DarwinTest.test_tailspin):
801         (DarwinTest.test_get_crash_log): Deleted.
802         * Scripts/webkitpy/port/ios_device_unittest.py:
803         (IOSDeviceTest.test_tailspin):
804
805 2019-08-22  Zhifei Fang  <zhifei_fang@apple.com>
806
807         [results.webkit.org Webkit.css] Change input's disable style
808         The disable input style will always show the label like it has a value 
809         https://bugs.webkit.org/show_bug.cgi?id=200998
810
811         Reviewed by Jonathan Bedard.
812
813         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value
814         *resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs:
815         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
816         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
817         (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value
818         (.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,):
819         (@media (prefers-color-scheme: dark)):
820
821 2019-08-17  Darin Adler  <darin@apple.com>
822
823         Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends
824         https://bugs.webkit.org/show_bug.cgi?id=200862
825
826         Reviewed by Ryosuke Niwa.
827
828         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
829         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Use makeString.
830         * WebKitTestRunner/TestController.cpp:
831         (WTR::TestController::findAndDumpWebKitProcessIdentifiers): Ditto.
832         (WTR::TestController::downloadDidReceiveServerRedirectToURL): Ditto.
833         (WTR::TestController::downloadDidFail): Ditto.
834
835 2019-08-22  clopez@igalia.com  <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
836
837         [GTK][WPE] Support for command "--version" on the MiniBrowser (follow-up fix)
838         https://bugs.webkit.org/show_bug.cgi?id=200978
839
840         Unreviewed follow-up fix.
841
842         Update the string format specifier for unsigned it.
843
844         * MiniBrowser/gtk/main.c:
845         (main):
846         * MiniBrowser/wpe/main.cpp:
847         (main):
848
849 2019-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
850
851         [GTK][WPE] Support for command "--version" on the MiniBrowser
852         https://bugs.webkit.org/show_bug.cgi?id=200978
853
854         Reviewed by Žan Doberšek.
855
856         Printing the engine version used from the MiniBrowser is useful.
857         For example, the test scripts on WPT can use this info to better
858         tag the generated results.
859
860         * MiniBrowser/gtk/main.c: Print the engine version when called with --version or -v.
861         (main):
862         * MiniBrowser/wpe/main.cpp: Ditto.
863         (main):
864
865 2019-08-22  Youenn Fablet  <youenn@apple.com>
866
867         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
868         https://bugs.webkit.org/show_bug.cgi?id=196870
869
870         Reviewed by Alex Christensen.
871
872         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
873         Accept any server certificate by default.
874
875         * WebKitTestRunner/TestController.cpp:
876         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
877         (WTR::TestController::cocoaResetStateToConsistentValues):
878         (WTR::TestController::setAllowsAnySSLCertificate):
879         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
880         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
881         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
882         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
883
884 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
885
886         results.webkit.org: Fix drawer style
887         https://bugs.webkit.org/show_bug.cgi?id=200988
888
889         Rubber-stamped by Aakash Jain.
890
891         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
892         (Drawer): Nothing in the drawer should be selectable.
893         (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
894         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
895         (.action:hover): Disable underline on 'links' which are actually actions
896         (.unselectable): Make a div unselectable.
897         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
898         (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
899
900 2019-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
901
902         [Win][MiniBrowser] Add a progress indicator to the main window
903         https://bugs.webkit.org/show_bug.cgi?id=200970
904
905         Reviewed by Alex Christensen.
906
907         * MiniBrowser/win/BrowserWindow.h: Added BrowserWindowClient class.
908         * MiniBrowser/win/MainWindow.cpp:
909         (MainWindow::init):
910         (MainWindow::resizeSubViews):
911         (MainWindow::progressChanged):
912         (MainWindow::progressFinished):
913         * MiniBrowser/win/MainWindow.h: Inherited BrowserWindowClient.
914         Added m_hProgressIndicator.
915         (MainWindow::hwnd const): Deleted.
916         (MainWindow::browserWindow const): Deleted.
917         (): Deleted.
918         * MiniBrowser/win/MiniBrowserWebHost.cpp:
919         (MiniBrowserWebHost::onNotify):
920         * MiniBrowser/win/MiniBrowserWebHost.h:
921         * MiniBrowser/win/WebKitBrowserWindow.cpp:
922         (WebKitBrowserWindow::create):
923         (WebKitBrowserWindow::WebKitBrowserWindow):
924         (WebKitBrowserWindow::didChangeIsLoading):
925         (WebKitBrowserWindow::didChangeEstimatedProgress):
926         (WebKitBrowserWindow::createNewPage):
927         * MiniBrowser/win/WebKitBrowserWindow.h:
928         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
929         (WebKitLegacyBrowserWindow::create):
930         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
931         (WebKitLegacyBrowserWindow::init):
932         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
933
934 2019-08-21  Ryan Haddad  <ryanhaddad@apple.com>
935
936         Unreviewed, rolling out r248970.
937
938         Caused
939         lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
940         to fail.
941
942         Reverted changeset:
943
944         "[lldb-webkit] OptionSet summary shows size 0 sometimes for
945         non-empty set"
946         https://bugs.webkit.org/show_bug.cgi?id=200742
947         https://trac.webkit.org/changeset/248970
948
949 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
950
951         results.webkit.org: Add database table to save zip archives to
952         https://bugs.webkit.org/show_bug.cgi?id=200718
953
954         Rubber-stamped by Aakash Jain.
955
956         * resultsdbpy/resultsdbpy/model/archive_context.py: Added.
957         (ArchiveContext):
958         (ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
959         (ArchiveContext.ArchivesByCommit.unpack):
960         (ArchiveContext.assert_zipfile):
961         (ArchiveContext.open_zipfile):
962         (ArchiveContext.__init__):
963         (ArchiveContext.__enter__):
964         (ArchiveContext.__exit__):
965         (ArchiveContext.register): Save the provided archive to Cassandra.
966         (ArchiveContext.find_archive): Find all archives matching the specified criteria.
967         (ArchiveContext._files_for_archive):
968         (ArchiveContext.ls): List all files in the matching archives.
969         (ArchiveContext.file): Extract a file from the matching archives.
970         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
971         (ArchiveContextTest):
972         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
973         (MockModelFactory):
974         (MockModelFactory.process_results):
975         (MockModelFactory.add_mock_archives):
976         * resultsdbpy/resultsdbpy/model/model.py:
977         (Model.__init__): Add an ArchiveContext to the model.
978
979 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
980
981         [ews-build] view layout test results option should be displayed next to layout-test build step
982         https://bugs.webkit.org/show_bug.cgi?id=200048
983
984         Reviewed by Jonathan Bedard.
985
986         * BuildSlaveSupport/ews-build/steps.py:
987         (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
988         (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
989
990 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
991
992         [ews] Fix capitalization in Found x new Test failure message
993         https://bugs.webkit.org/show_bug.cgi?id=201004
994
995         Reviewed by Alexey Proskuryakov.
996
997         * BuildSlaveSupport/ews-build/steps.py:
998         (AnalyzeLayoutTestsResults.report_failure):
999         (AnalyzeAPITestsResults.analyzeResults):
1000         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
1001
1002 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
1003
1004         Assign ews117 to EWS High-Sierra Debug queues
1005         https://bugs.webkit.org/show_bug.cgi?id=200993
1006
1007         Reviewed by Jonathan Bedard.
1008
1009         * BuildSlaveSupport/ews-build/config.json:
1010
1011 2019-08-21  Daniel Bates  <dabates@apple.com>
1012
1013         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
1014         https://bugs.webkit.org/show_bug.cgi?id=200742
1015
1016         Reviewed by Simon Fraser.
1017
1018         The OptionSet synthetic provider must respond to requests for the value of m_storage
1019         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
1020         of the type summary.
1021
1022         Synthetic providers substitute alternative debug information (children) for the default
1023         information for a variable. The OptionSet type summary is implemented in terms of the
1024         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
1025         before invoking the type summary handler then evaluating GetChildMemberWithName() on
1026         the SBValue passed to the type summary handler will access the substitute information
1027         instead of the original debug information. As a result OptionSet's synthetic provider's
1028         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
1029         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
1030         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
1031         should return a valid value.
1032
1033         * lldb/lldb_webkit.py:
1034         (FlagEnumerationProvider.__init__):
1035         (FlagEnumerationProvider):
1036         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
1037         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
1038         (FlagEnumerationProvider.size): Added.
1039         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
1040         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
1041         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
1042         and removed self.size. For the latter we can just expose a getter that returns the size of
1043         the list self._elements.
1044         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
1045         value of m_storage.
1046         (WTFOptionSetProvider):
1047         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
1048         matches the specified index.
1049
1050 2019-08-21  Alex Christensen  <achristensen@webkit.org>
1051
1052         Disabling text autosizing should prevent text autosizing
1053         https://bugs.webkit.org/show_bug.cgi?id=200955
1054         <rdar://problem/48095374>
1055
1056         Reviewed by Simon Fraser.
1057
1058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1059         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
1060         (TEST):
1061
1062 2019-08-21  Adrian Perez de Castro  <aperez@igalia.com>
1063
1064         [GTK][WPE] Make debug-test-runner work
1065         https://bugs.webkit.org/show_bug.cgi?id=193576
1066
1067         Reviewed by Michael Catanzaro.
1068
1069         * Scripts/webkitdirs.pm:
1070         (wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
1071         (setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
1072         TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
1073         (execUnixAppForDebugging): Added.
1074         (debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
1075
1076 2019-08-20  Ryosuke Niwa  <rniwa@webkit.org>
1077
1078         Put keygen element behind a runtime flag and disable it by default
1079         https://bugs.webkit.org/show_bug.cgi?id=200850
1080
1081         Reviewed by Antti Koivisto.
1082
1083         Added the support for enableKeygenElement test runner option, which enables keygen element in layout tests.
1084
1085         * DumpRenderTree/TestOptions.cpp:
1086         (TestOptions::TestOptions):
1087         * DumpRenderTree/TestOptions.h:
1088         * DumpRenderTree/mac/DumpRenderTree.mm:
1089         (setWebPreferencesForTestOptions):
1090         * DumpRenderTree/win/DumpRenderTree.cpp:
1091         (setWebPreferencesForTestOptions):
1092         * WebKitTestRunner/TestController.cpp:
1093         (WTR::TestController::resetPreferencesToConsistentValues):
1094         (WTR::updateTestOptionsFromTestHeader):
1095         * WebKitTestRunner/TestOptions.h:
1096         (WTR::TestOptions::hasSameInitializationOptions const):
1097
1098 2019-08-21  Chris Dumez  <cdumez@apple.com>
1099
1100         Add internal setting to disable SecureContext checks
1101         https://bugs.webkit.org/show_bug.cgi?id=200980
1102         <rdar://problem/54438512>
1103
1104         Reviewed by Alex Christensen.
1105
1106         Add API test coverage.
1107
1108         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1109         (log):
1110         (requestPermission):
1111
1112 2019-08-21  Keith Rollin  <krollin@apple.com>
1113
1114         Remove support for watchOS < 6.0
1115         https://bugs.webkit.org/show_bug.cgi?id=200937
1116         <rdar://problem/54524009>
1117
1118         Reviewed by Darin Adler.
1119
1120         Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and
1121         __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
1122         60000. This means that expressions like
1123         "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and
1124         "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True.
1125
1126         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1127         (TestWebKitAPI::TEST):
1128
1129 2019-08-20  Zhifei Fang  <zhifei_fang@apple.com>
1130
1131         [results.webkit.org Webkit.css] Add right sidebar
1132         https://bugs.webkit.org/show_bug.cgi?id=200946
1133
1134         Reviewed by Jonathan Bedard.
1135
1136         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1137         (@media screen and (min-width: 600px) and (orientation: landscape)):
1138         (.main.left):
1139         (@media screen and (min-width: 768px) and (orientation: landscape)):
1140         (.sidebar.right):
1141
1142 2019-08-20  Jonathan Bedard  <jbedard@apple.com>
1143
1144         results.webkit.org: Add ToolTips
1145         https://bugs.webkit.org/show_bug.cgi?id=200801
1146
1147         Rubber-stamped by Aakash Jain.
1148
1149         When dots or scale labels are hovered over, we should display a tool tip with additional information about
1150         The specific element.
1151
1152         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Added.
1153         (.tooltip): Add class for ToolTip text box.
1154         (.tooltip-arrow-up): Add class for ToolTip arrow pointing up.
1155         (.tooltip-arrow-down): Add class for ToolTip arrow pointing down.
1156         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
1157         (_CommitBank.prototype.commitsDuringUuid): Return a list of commits which were the trunk of their respective
1158         repositories at a given time.
1159         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1160         (xAxisFromScale): Add callbacks triggered when the mouse enters or leaves elements in the scale canvas.
1161         (TimelineFromEndpoint.render): Add callbacks triggered when the mouse enters or leaves dot elements.
1162         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js: Added.
1163         (isPointInElement): Given an element and a point, return true if that point is within the bounds of the element.
1164         (_ToolTip):
1165         (_ToolTip.prototype.set): Set the content and location of the ToolTip.
1166         (_ToolTip.prototype.toString): Return the html needed to render the ToolTip.
1167         (_ToolTip.prototype.unset): Clear and hide the ToolTip.
1168         (_ToolTip.prototype.isIn): Check if a given point is contained within the ToolTip.
1169         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1170         (Timeline.CanvasSeriesComponent): Convert onHover events to onEnter/onLeave events. Add toolTips points to both
1171         dot and scale elements.
1172         * resultsdbpy/resultsdbpy/view/templates/search.html: Add ToolTip.
1173         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1174
1175 2019-08-20  Justin Michaud  <justin_michaud@apple.com>
1176
1177         Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
1178         https://bugs.webkit.org/show_bug.cgi?id=200782
1179
1180         Reviewed by Saam Barati.
1181
1182         * Scripts/run-jsc-stress-tests:
1183
1184 2019-08-20  Darin Adler  <darin@apple.com>
1185
1186         Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly
1187         https://bugs.webkit.org/show_bug.cgi?id=200921
1188
1189         Reviewed by Saam Barati.
1190
1191         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1192         Changed tests to use EXPECT macros instead of ASSERT macros since we don't
1193         need to abort after the first failure. Added three new tests to the VariadicAppend
1194         test to cover various cases of upconverting from 8-bit to 16-bit strings.
1195
1196 2019-08-20  Dean Jackson  <dino@apple.com>
1197
1198         REGRESSION: Open in New Tab is missing from context menu
1199         https://bugs.webkit.org/show_bug.cgi?id=200909
1200         <rdar://problem/54476169>
1201
1202         Reviewed by Simon Fraser.
1203
1204         Add a new test that runs through the legacy context menu
1205         flow, and verifies that it will be called if there aren't
1206         appropriate delegates for the new API.
1207
1208         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1209         (contextMenuWebViewDriver):
1210         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1211         (TEST):
1212         (-[LegacyPreviewViewController previewActionItems]):
1213         (-[LegacyContextMenuUIDelegate webView:shouldPreviewElement:]):
1214         (-[LegacyContextMenuUIDelegate webView:previewingViewControllerForElement:defaultActions:]):
1215         (-[LegacyContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
1216         (-[LegacyContextMenuUIDelegate _webView:contextMenuDidEndForElement:]):
1217         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
1218
1219 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
1220
1221         [JSC] OSR entry to Wasm OMG
1222         https://bugs.webkit.org/show_bug.cgi?id=200362
1223
1224         Reviewed by Michael Saboff.
1225
1226         * Scripts/run-jsc-stress-tests:
1227
1228 2019-08-19  Zhifei Fang  <zhifei_fang@apple.com>
1229
1230         [results.webkit.org Timeline] Disable back gesture
1231         https://bugs.webkit.org/show_bug.cgi?id=200839
1232
1233         Reviewed by Jonathan Bedard.
1234
1235         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
1236         * resultsdbpy/resultsdbpy/view/templates/base.html:
1237
1238 2019-08-19  Jonathan Bedard  <jbedard@apple.com>
1239
1240         results-webkit.org: Add timeout to Redis locks
1241         https://bugs.webkit.org/show_bug.cgi?id=200890
1242
1243         Reviewed by Aakash Jain.
1244
1245         * resultsdbpy/resultsdbpy/model/upload_context.py:
1246         (UploadContext._find_job_with_attempts): Add timeout to Redis lock.
1247
1248 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
1249
1250         Remove IDB-specific quota
1251         https://bugs.webkit.org/show_bug.cgi?id=196545
1252         <rdar://problem/54201783>
1253
1254         Reviewed by Youenn Fablet.
1255
1256         * DumpRenderTree/TestRunner.cpp:
1257         (TestRunner::staticFunctions):
1258         (setIDBPerOriginQuotaCallback): Deleted.
1259         * DumpRenderTree/TestRunner.h:
1260         * DumpRenderTree/mac/DumpRenderTree.mm:
1261         (runTest):
1262         * DumpRenderTree/mac/TestRunnerMac.mm:
1263         (TestRunner::setIDBPerOriginQuota): Deleted.
1264         * DumpRenderTree/win/TestRunnerWin.cpp:
1265         (TestRunner::setIDBPerOriginQuota): Deleted.
1266         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1267         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1268         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
1269         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1270         * WebKitTestRunner/TestController.cpp:
1271         (WTR::TestController::resetStateToConsistentValues):
1272         (WTR::TestController::setIDBPerOriginQuota): Deleted.
1273         * WebKitTestRunner/TestController.h:
1274         * WebKitTestRunner/TestInvocation.cpp:
1275         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1276
1277 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
1278
1279         [WTF] Style checker should tell errors when it finds std::make_unique
1280         https://bugs.webkit.org/show_bug.cgi?id=200878
1281
1282         Reviewed by Ross Kirsling.
1283
1284         * Scripts/webkitpy/style/checkers/cpp.py:
1285         (check_wtf_make_unique):
1286         (check_style):
1287         (CppChecker):
1288
1289 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
1290
1291         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
1292         https://bugs.webkit.org/show_bug.cgi?id=200620
1293
1294         Reviewed by Geoffrey Garen.
1295
1296         * DumpRenderTree/TestRunner.cpp:
1297         (addURLToRedirectCallback):
1298         (setWillSendRequestClearHeaderCallback):
1299         (TestRunner::setAccummulateLogsForChannel):
1300         (TestRunner::runUIScript):
1301         (TestRunner::setOpenPanelFiles):
1302         * DumpRenderTree/mac/DumpRenderTree.mm:
1303         (dumpFramesAsText):
1304         * DumpRenderTree/mac/EventSendingController.mm:
1305         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
1306         * DumpRenderTree/win/DRTDataObject.cpp:
1307         (DRTDataObject::SetData):
1308         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1309         (FrameLoadDelegate::FrameLoadDelegate):
1310         * DumpRenderTree/win/UIDelegate.cpp:
1311         (DRTUndoManager::DRTUndoManager):
1312         (UIDelegate::UIDelegate):
1313         (UIDelegate::resetUndoManager):
1314         * TestWebKitAPI/JavaScriptTest.cpp:
1315         (TestWebKitAPI::runJSTest):
1316         * TestWebKitAPI/PlatformUtilities.cpp:
1317         (TestWebKitAPI::Util::toSTD):
1318         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1319         (TestWebKitAPI::TEST):
1320         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
1321         (TestWebKitAPI::TEST):
1322         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1323         (TestWebKitAPI::TEST):
1324         (TestWebKitAPI::testMovingUsingEnsure):
1325         (TestWebKitAPI::testMovingUsingAdd):
1326         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1327         (TestWebKitAPI::TEST):
1328         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1329         (TestWebKitAPI::TEST):
1330         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1331         (TestWebKitAPI::runLockTest):
1332         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1333         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1334         (TestWebKitAPI::TEST):
1335         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1336         (TestWebKitAPI::TEST):
1337         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1338         (TestWebKitAPI::TEST):
1339         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1340         (TestWebKitAPI::TEST):
1341         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:
1342         (TestWebKitAPI::CARingBufferTest::SetUp):
1343         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1344         (TestWebKitAPI::createTestValue):
1345         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1346         (TestWebKitAPI::TEST):
1347         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1348         (TestWebKitAPI::TEST_F):
1349         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1350         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1351         (TestWebKitAPI::createNewPage):
1352         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1353         (TestWebKitAPI::createNewPage):
1354         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
1355         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
1356         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
1357         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
1358         (TestWebKitAPI::WebKit2WillLoadTest::SetUp):
1359         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1360         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1361         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1362         (serverCallback):
1363         (testWebViewAuthenticationProxyHTTPS):
1364         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1365         (WebKitDOMDOMWindowTest::create):
1366         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
1367         (TestWebKitAPI::Util::toSTD):
1368         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1369         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
1370         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1371         * TestWebKitAPI/mac/TestFontOptions.mm:
1372         (-[TestFontOptions initWithFontOptions:]):
1373         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1374         (WTR::EventSendingController::callAfterScrollingCompletes):
1375         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1376         (WTR::InjectedBundle::didCreatePage):
1377         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1378         (WTR::TestRunner::setOpenPanelFiles):
1379         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1380         * WebKitTestRunner/StringFunctions.h:
1381         (WTR::toSTD):
1382         (WTR::toWTFString):
1383         * WebKitTestRunner/TestController.cpp:
1384         (WTR::TestController::initialize):
1385         (WTR::TestController::generatePageConfiguration):
1386         (WTR::TestController::resetStateToConsistentValues):
1387         (WTR::createTestURL):
1388         (WTR::TestController::runTest):
1389         (WTR::TestController::platformCreateWebView):
1390         * WebKitTestRunner/TestInvocation.cpp:
1391         (WTR::TestInvocation::runUISideScript):
1392         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1393         (WTR::TestController::platformCreateWebView):
1394         (WTR::TestController::setDefaultCalendarType):
1395         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1396         (WTR::getGDKKeySymForKeyRef):
1397         * WebKitTestRunner/ios/TestControllerIOS.mm:
1398         (WTR::TestController::platformResetStateToConsistentValues):
1399         (WTR::TestController::setKeyboardInputModeIdentifier):
1400         * WebKitTestRunner/mac/EventSenderProxy.mm:
1401         (WTR::EventSenderProxy::mouseDown):
1402         (WTR::EventSenderProxy::mouseUp):
1403         (WTR::EventSenderProxy::mouseMoveTo):
1404         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1405         (WTR::wpeKeySymForKeyRef):
1406
1407 2019-08-17  Ross Kirsling  <ross.kirsling@sony.com>
1408
1409         [ESNext] Implement optional chaining
1410         https://bugs.webkit.org/show_bug.cgi?id=200199
1411
1412         Reviewed by Yusuke Suzuki.
1413
1414         * Scripts/run-jsc-stress-tests:
1415
1416 2019-08-17  Tim Horton  <timothy_horton@apple.com>
1417
1418         Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
1419         https://bugs.webkit.org/show_bug.cgi?id=200866
1420         <rdar://problem/50254021>
1421
1422         Reviewed by Simon Fraser.
1423
1424         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1425         (WTR::PlatformWebView::windowSnapshotImage):
1426         Replace some logging with release assertions that we are snapshotting a reasonable
1427         view and get a reasonable snapshot back. Failing to snapshot is a big deal, and
1428         "silently" failing with just a log that will be ignored is not helpful.
1429
1430 2019-08-17  Yusuke Suzuki  <ysuzuki@apple.com>
1431
1432         [WTF] ThreadGroupRemove test is flaky
1433         https://bugs.webkit.org/show_bug.cgi?id=200763
1434
1435         Reviewed by Mark Lam.
1436
1437         ThreadGroup.ThreadGroupRemove test is flaky since its `threadRunning` modification and check in Thread are racy.
1438         It can lead to infinite wait on waitForCompletion. We should do more idiomatic to avoid race: When notifying condition
1439         variables, we should first take a lock, modify the condition shared and notify the condition change while taking a lock,
1440         and releasing the lock after that.
1441
1442         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1443         (TestWebKitAPI::TEST):
1444
1445 2019-08-17  Eric Liang  <ericliang@apple.com>
1446
1447         Tested that accessibility WebProcessLoader bundle is loaded for the correct path.
1448         https://bugs.webkit.org/show_bug.cgi?id=200367
1449
1450         Reviewed by Darin Adler.
1451
1452         Added AccessibilityTestPlugin on the web process to report whether a bundle is loaded and its path, so that it can be tested on WKContentView. 
1453
1454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1455         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestPlugin.mm: Added.
1456         (-[AccessibilityTestPlugin webProcessPlugIn:didCreateBrowserContextController:]):
1457         (-[AccessibilityTestPlugin checkAccessibilityWebProcessLoaderBundleIsLoaded:]):
1458         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestSupportProtocol.h: Added.
1459         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1460         (TestWebKitAPI::TEST):
1461
1462 2019-08-17  Sam Weinig  <weinig@apple.com>
1463
1464         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
1465         https://bugs.webkit.org/show_bug.cgi?id=200756
1466
1467         Reviewed by Darin Adler.
1468
1469         Update call sites for rename from StringBuilder::flexibleAppend(...) to 
1470         StringBuilder::append(...).
1471
1472         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1473         (TestWebKitAPI::TEST):
1474
1475 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
1476
1477         [iOS WK2] Scroll indicators disappear sometimes
1478         https://bugs.webkit.org/show_bug.cgi?id=200791
1479
1480         Reviewed by Tim Horton.
1481
1482         Tests that test that scroll indicators survive subview replacement, and that
1483         a custom view also survives subview replacement.
1484
1485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1486         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
1487         (TestWebKitAPI::TEST):
1488         * TestWebKitAPI/cocoa/TestWKWebView.h:
1489         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1490         (-[TestWKWebView performAfterLoading:]):
1491         (-[UIView wkFirstSubviewWithClass:]):
1492         (-[UIView wkFirstSubviewWithBoundsSize:]):
1493         * TestWebKitAPI/ios/composited.html: Added.
1494         * TestWebKitAPI/ios/overflow-scroll.html: Added.
1495
1496 2019-08-16  John Wilander  <wilander@apple.com>
1497
1498         Add John Wilander as WebKit Reviewer
1499         https://bugs.webkit.org/show_bug.cgi?id=200837
1500
1501         Unreviewed update to contributors.json to change my status to reviewer.
1502         See email on reviewers mailing list for proof of granted privileges.
1503
1504         * Scripts/webkitpy/common/config/contributors.json:
1505
1506 2019-08-16  Timothy Hatcher  <timothy@apple.com>
1507
1508         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
1509         https://bugs.webkit.org/show_bug.cgi?id=200802
1510         rdar://problem/54357818
1511
1512         Reviewed by Tim Horton.
1513
1514         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
1515         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
1516         (-[OpaqueTestWKWebView isOpaque]): Added.
1517         (-[NonOpaqueTestWKWebView isOpaque]): Added.
1518         (isOpaque): Added.
1519         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
1520         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
1521         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
1522
1523 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
1524
1525         [ews] Add build steps for Windows Factory
1526         https://bugs.webkit.org/show_bug.cgi?id=200813
1527
1528         Reviewed by Jonathan Bedard.
1529
1530         * BuildSlaveSupport/ews-build/factories.py:
1531         (WindowsFactory.__init__):
1532
1533 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
1534
1535         [ews] Report machine uptime in PrintConfiguration
1536         https://bugs.webkit.org/show_bug.cgi?id=200812
1537
1538         Reviewed by Jonathan Bedard.
1539
1540         * BuildSlaveSupport/ews-build/steps.py:
1541         (PrintConfiguration): Added uptime command.
1542         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1543
1544 2019-08-16  Chris Lord  <clord@igalia.com>
1545
1546         Add shared-mime-info to WPE WebKit jhbuild
1547         https://bugs.webkit.org/show_bug.cgi?id=200768
1548
1549         Reviewed by Carlos Alberto Lopez Perez.
1550
1551         * wpe/jhbuild.modules:
1552
1553 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
1554
1555         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
1556         https://bugs.webkit.org/show_bug.cgi?id=200620
1557
1558         Reviewed by Geoffrey Garen.
1559
1560         * DumpRenderTree/AccessibilityController.h:
1561         * DumpRenderTree/GCController.h:
1562         * DumpRenderTree/win/DRTDataObject.cpp:
1563         * DumpRenderTree/win/DRTDataObject.h:
1564         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1565         * DumpRenderTree/win/DRTDropSource.h:
1566         * DumpRenderTree/win/DraggingInfo.h:
1567         * DumpRenderTree/win/EditingDelegate.h:
1568         * DumpRenderTree/win/EventSender.cpp:
1569         * DumpRenderTree/win/FrameLoadDelegate.h:
1570         * DumpRenderTree/win/HistoryDelegate.h:
1571         * DumpRenderTree/win/MD5.h:
1572         * DumpRenderTree/win/PolicyDelegate.h:
1573         * DumpRenderTree/win/ResourceLoadDelegate.h:
1574         * DumpRenderTree/win/TextInputController.h:
1575         * DumpRenderTree/win/UIDelegate.cpp:
1576         * DumpRenderTree/win/UIDelegate.h:
1577         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1578         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
1579         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
1580         * TestWebKitAPI/Counters.h:
1581         * TestWebKitAPI/PlatformWebView.h:
1582         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1583         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1584         (TestWebKitAPI::DerefObserver::ref):
1585         (TestWebKitAPI::DerefObserver::deref):
1586         (TestWebKitAPI::TEST):
1587         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1588         (TestWebKitAPI::DerefObserver::ref):
1589         (TestWebKitAPI::DerefObserver::deref):
1590         (TestWebKitAPI::TEST):
1591         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
1592         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1593         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1594         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1595         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
1596         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
1597         * WebKitTestRunner/EventSenderProxy.h:
1598         * WebKitTestRunner/GeolocationProviderMock.h:
1599         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1600         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1601         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1602         * WebKitTestRunner/PlatformWebView.h:
1603         * WebKitTestRunner/TestInvocation.h:
1604
1605 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
1606
1607         Some improvements on web storage
1608         https://bugs.webkit.org/show_bug.cgi?id=200373
1609
1610         Reviewed by Geoffrey Garen.
1611
1612         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1613         (TEST): update expectation for behavior change.
1614
1615         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to 
1616         database file.
1617         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1618         (WTR::TestRunner::syncLocalStorage):
1619         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1620
1621         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
1622         (WTR::TestController::resetStateToConsistentValues):
1623         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
1624         (WTR::StorageVoidCallback):
1625         (WTR::TestController::clearIndexedDatabases):
1626         (WTR::TestController::clearLocalStorage):
1627         (WTR::TestController::syncLocalStorage):
1628         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
1629         with StorageVoidCallbackContext for general usage.
1630         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
1631         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
1632         * WebKitTestRunner/TestController.h:
1633
1634         * WebKitTestRunner/TestInvocation.cpp:
1635         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message 
1636         SyncLocalStorage.
1637
1638 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
1639
1640         results.webkit.org: Add content hook to FlaskRequestsResponse
1641         https://bugs.webkit.org/show_bug.cgi?id=200721
1642
1643         Rubber-stamped by Aakash Jain.
1644
1645         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
1646         (FlaskRequestsResponse):
1647         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
1648         Response, conforming to request's API.
1649
1650 2019-08-15  Alex Christensen  <achristensen@webkit.org>
1651
1652         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
1653         https://bugs.webkit.org/show_bug.cgi?id=200750
1654         <rdar://problem/54232261> and <rdar://problem/52355829>
1655
1656         Reviewed by Tim Horton.
1657
1658         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1659         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1660         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1661         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
1662         (contextMenuWebViewDriver):
1663         (TEST):
1664
1665 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
1666
1667         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
1668         https://bugs.webkit.org/show_bug.cgi?id=200726
1669
1670         Reviewed by Simon Fraser.
1671
1672         To get the pixels as an array of colors, draw the image into a memory
1673         context. The backing memory buffer can then be accessed to get the image
1674         pixels' colors.
1675
1676         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1677         (TestWebKitAPI::TEST):
1678
1679 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
1680
1681         Unreviewed, rolling out r248526.
1682
1683         Caused two IndexedDB perf tests to fail
1684
1685         Reverted changeset:
1686
1687         "Remove IDB-specific quota"
1688         https://bugs.webkit.org/show_bug.cgi?id=196545
1689         https://trac.webkit.org/changeset/248526
1690
1691 2019-08-14  Keith Rollin  <krollin@apple.com>
1692
1693         Remove support for macOS < 10.13
1694         https://bugs.webkit.org/show_bug.cgi?id=200694
1695         <rdar://problem/54278851>
1696
1697         Reviewed by Youenn Fablet.
1698
1699         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
1700         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
1701         101300. This means that expressions like
1702         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
1703         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
1704
1705         * MiniBrowser/AppKitCompatibilityDeclarations.h:
1706         * MiniBrowser/mac/SettingsController.m:
1707         (-[SettingsController init]):
1708         * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
1709         (TestWebKitAPI::FontCacheTest::SetUp): Deleted.
1710         (TestWebKitAPI::createPlatformFont): Deleted.
1711         (TestWebKitAPI::compareFonts): Deleted.
1712         (TestWebKitAPI::TEST_F): Deleted.
1713         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1714         (TestWebKitAPI::TEST):
1715         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1716         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1717         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1718         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1719         (runWebsiteDataStoreCustomPaths):
1720         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
1721
1722 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
1723
1724         [JSC] Less contended MetaAllocator
1725         https://bugs.webkit.org/show_bug.cgi?id=200278
1726
1727         Reviewed by Mark Lam.
1728
1729         Update the interface.
1730
1731         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1732
1733 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
1734
1735         results.webkit.org: 500 errors on API endpoints don't return JSON
1736         https://bugs.webkit.org/show_bug.cgi?id=200722
1737
1738         Reviewed by Aakash Jain.
1739
1740         * resultsdbpy/resultsdbpy/controller/api_routes.py:
1741         (APIRoutes.response_500): We should return the response, instead of abort.
1742
1743 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
1744
1745         results.webkit.org: Don't save configuration multiple times in upload
1746         https://bugs.webkit.org/show_bug.cgi?id=200719
1747
1748         Reviewed by Aakash Jain.
1749
1750         * resultsdbpy/resultsdbpy/model/upload_context.py:
1751         (UploadContext.upload_test_results): Move registering of the configuration out
1752         of the branch loop.
1753
1754 2019-08-14  Youenn Fablet  <youenn@apple.com>
1755
1756         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
1757         https://bugs.webkit.org/show_bug.cgi?id=200706
1758
1759         Reviewed by Alex Christensen.
1760
1761         Libwebrtc is now soft-linked so we can reenable this test.
1762
1763         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
1764         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
1765
1766 2019-08-13  Sam Weinig  <weinig@apple.com>
1767
1768         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
1769         https://bugs.webkit.org/show_bug.cgi?id=200675
1770
1771         Reviewed by Darin Adler.
1772
1773         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1774         (TestWebKitAPI::TEST):
1775         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
1776
1777 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
1778
1779         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
1780         https://bugs.webkit.org/show_bug.cgi?id=200456
1781
1782         Reviewed by Jonathan Bedard.
1783
1784         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
1785
1786         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
1787
1788         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
1789         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1790         (pointPolygonCollisionDetect): Detact
1791         (pointRightRayLineSegmentCollisionDetect):
1792         (ColorBatchRender):
1793         (ColorBatchRender.prototype.lazyCreateColorSeqs):
1794         (ColorBatchRender.prototype.addSeq):
1795         (ColorBatchRender.prototype.batchRender):
1796         (ColorBatchRender.prototype.clear):
1797         (xScrollStreamRenderFactory):
1798         (Timeline.CanvasSeriesComponent):
1799         (offscreenCachedRenderFactory): Deleted.
1800
1801 2019-08-13  John Wilander  <wilander@apple.com>
1802
1803         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
1804         https://bugs.webkit.org/show_bug.cgi?id=200642
1805         <rdar://problem/53962073>
1806
1807         Reviewed by Alex Christensen.
1808
1809         This patch adds test infrastructure to query whether an origin has an
1810         isolated NSURLSession or not.
1811
1812         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1813         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1814         (WTR::TestRunner::hasStatisticsIsolatedSession):
1815         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1816         * WebKitTestRunner/TestController.cpp:
1817         (WTR::TestController::hasStatisticsIsolatedSession):
1818         * WebKitTestRunner/TestController.h:
1819         * WebKitTestRunner/TestInvocation.cpp:
1820         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1821
1822 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
1823
1824         Update my status in contributors.json to committer.
1825
1826         Reviewed by Unreviewed
1827
1828         * Scripts/webkitpy/common/config/contributors.json:
1829
1830 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
1831
1832         Adds WebAuthn and AppSSO into watchlist
1833         https://bugs.webkit.org/show_bug.cgi?id=200647
1834
1835         Reviewed by Dewei Zhu.
1836
1837         * Scripts/webkitpy/common/config/watchlist:
1838
1839 2019-08-13  Chris Dumez  <cdumez@apple.com>
1840
1841         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
1842         https://bugs.webkit.org/show_bug.cgi?id=200674
1843         <rdar://problem/50692748>
1844
1845         Reviewed by Geoff Garen.
1846
1847         Add API test coverage.
1848
1849         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1850
1851 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
1852
1853         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
1854         https://bugs.webkit.org/show_bug.cgi?id=199857
1855
1856         Reviewed by Yusuke Suzuki.
1857
1858         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1859         (TestWebKitAPI::countThreadGroups):
1860         (TestWebKitAPI::TEST):
1861
1862 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
1863
1864         AX: Homebrew is not allowed to run any script under sudo.
1865         https://bugs.webkit.org/show_bug.cgi?id=173801
1866
1867         Reviewed by Carlos Alberto Lopez Perez.
1868
1869         Latest versions of Homebrew throw an error when run as root.
1870         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
1871
1872         * gtk/install-dependencies:
1873
1874 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
1875
1876         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
1877         https://bugs.webkit.org/show_bug.cgi?id=200644
1878
1879         Reviewed by Aakash Jain.
1880
1881         * Scripts/webkitpy/port/simulator_process.py:
1882         (SimulatorProcess._start): Define system PID after launching app.
1883
1884 2019-08-12  Sam Weinig  <weinig@apple.com>
1885
1886         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
1887         https://bugs.webkit.org/show_bug.cgi?id=200614
1888
1889         Reviewed by Darin Adler.
1890
1891         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
1892         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
1893         
1894         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
1895         StringBuilder::appendSubstring(...).
1896
1897         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1898         (TestWebKitAPI::TEST):
1899         Update for renames.
1900
1901 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
1902
1903         Fix Crash in Mail Search
1904         https://bugs.webkit.org/show_bug.cgi?id=200589
1905
1906         Reviewed by Tim Horton.
1907
1908         If you search backwards first in mail, we would crash,
1909         this tests that codepath.
1910
1911         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1912         (TEST):
1913
1914 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1915
1916         [iPadOS] Web pages sometimes load at half width in Safari
1917         https://bugs.webkit.org/show_bug.cgi?id=200624
1918         <rdar://problem/52694257>
1919
1920         Reviewed by Simon Fraser.
1921
1922         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
1923         web page is created using the post-animated-resize web view dimensions, rather than the original layout
1924         dimensions.
1925
1926         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1927
1928 2019-08-12  Daniel Bates  <dabates@apple.com>
1929
1930         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
1931         https://bugs.webkit.org/show_bug.cgi?id=200548
1932
1933         Reviewed by Darin Adler.
1934
1935         Expose infrastructure to simulate a literal raw key down and a literal key up event.
1936
1937         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1938         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1939         (WTR::UIScriptController::rawKeyDown):
1940         (WTR::UIScriptController::rawKeyUp):
1941         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
1942         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1943         (WTR::UIScriptControllerIOS::rawKeyDown):
1944         (WTR::UIScriptControllerIOS::rawKeyUp):
1945
1946 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
1947
1948         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
1949         https://bugs.webkit.org/show_bug.cgi?id=200584
1950
1951         Reviewed by Philippe Normand.
1952
1953         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
1954         Ignore style libwebrtc optionnal 'style issue'
1955
1956         * Scripts/webkitpy/style/checker.py:
1957         * gstreamer/jhbuild.modules:
1958         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
1959
1960 2019-08-12  Youenn Fablet  <youenn@apple.com>
1961
1962         Remove IDB-specific quota
1963         https://bugs.webkit.org/show_bug.cgi?id=196545
1964
1965         Reviewed by Alex Christensen.
1966
1967         * DumpRenderTree/TestRunner.cpp:
1968         (TestRunner::staticFunctions):
1969         (setIDBPerOriginQuotaCallback): Deleted.
1970         * DumpRenderTree/TestRunner.h:
1971         * DumpRenderTree/mac/DumpRenderTree.mm:
1972         (runTest):
1973         * DumpRenderTree/mac/TestRunnerMac.mm:
1974         (TestRunner::setIDBPerOriginQuota): Deleted.
1975         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1976         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1977         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
1978         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1979         * WebKitTestRunner/TestController.cpp:
1980         (WTR::TestController::resetStateToConsistentValues):
1981         (WTR::TestController::setIDBPerOriginQuota): Deleted.
1982         * WebKitTestRunner/TestController.h:
1983         * WebKitTestRunner/TestInvocation.cpp:
1984         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1985
1986 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
1987
1988         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
1989         https://bugs.webkit.org/show_bug.cgi?id=200621
1990
1991         Reviewed by Dan Bernstein.
1992
1993         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1994
1995 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1996
1997         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
1998         https://bugs.webkit.org/show_bug.cgi?id=200604
1999         <rdar://problem/51273130>
2000
2001         Reviewed by Megan Gardner.
2002
2003         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
2004         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
2005         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
2006         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
2007         remains the same.
2008
2009         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
2010         the caret rect at initial scale 1.
2011
2012         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2013
2014 2019-08-09  Ali Juma  <ajuma@chromium.org>
2015
2016         Don't allow cross-origin iframes to autofocus
2017         https://bugs.webkit.org/show_bug.cgi?id=200515
2018         <rdar://problem/54092988>
2019
2020         Reviewed by Ryosuke Niwa.
2021
2022         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
2023         of cross-origin iframes, since it depends on focusing one of the
2024         frames.
2025
2026         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2027         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2028         (TestWebKitAPI::TEST):
2029         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
2030
2031 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2032
2033         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
2034         https://bugs.webkit.org/show_bug.cgi?id=200591
2035         <rdar://problem/54102238>
2036
2037         Reviewed by Ryosuke Niwa and Tim Horton.
2038
2039         Add a new API test to exercise -supportsImagePaste.
2040
2041         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2042         (TestWebKitAPI::TEST):
2043         * TestWebKitAPI/ios/UIKitSPI.h:
2044
2045 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2046
2047         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
2048         [ews-build] Set svn:ignore to various EWS Buildbot files
2049         https://bugs.webkit.org/show_bug.cgi?id=200581
2050
2051         Reviewed by Jonathan Bedard.
2052
2053         * BuildSlaveSupport/ews-build: Added property svn:ignore.
2054
2055 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2056
2057         [ews-build] Set svn:ignore to various EWS Buildbot files
2058         https://bugs.webkit.org/show_bug.cgi?id=200581
2059
2060         Reviewed by Jonathan Bedard.
2061
2062         * BuildSlaveSupport/ews-build: Added property svn:ignore.
2063
2064 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
2065
2066         [ews] Add buildbot.tac to repository
2067         https://bugs.webkit.org/show_bug.cgi?id=200580
2068
2069         Reviewed by Jonathan Bedard.
2070
2071         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
2072
2073 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
2074
2075         [GTK] Add missing spellchecking packages to dependencies script
2076         https://bugs.webkit.org/show_bug.cgi?id=200574
2077
2078         Reviewed by Philippe Normand.
2079
2080         These are needed for the spellchecking test in WebContext API tests.
2081
2082         * gtk/install-dependencies:
2083
2084 2019-08-08  Jon Lee  <jonlee@apple.com>
2085
2086         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
2087
2088 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
2089
2090         webkitpy: Disable shared clipboard between Simulators
2091         https://bugs.webkit.org/show_bug.cgi?id=200546
2092
2093         Reviewed by Aakash Jain.
2094
2095         * Scripts/webkitpy/xcode/simulated_device.py:
2096         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
2097         managed by run-webkit-tests.
2098
2099 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
2100
2101         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
2102         https://bugs.webkit.org/show_bug.cgi?id=200539
2103         <rdar://problem/54082550>
2104
2105         Reviewed by Dean Jackson.
2106
2107         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2108         * PlatformFTW.cmake: Added.
2109
2110 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2111
2112         [iOS] Position image information should respect the image orientation
2113         https://bugs.webkit.org/show_bug.cgi?id=200487
2114
2115         Reviewed by Simon Fraser.
2116
2117         Add an API test to verify the position image information is drawn rotated
2118         because of respecting its image orientation.
2119
2120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2121         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2122         (TestWebKitAPI::TEST):
2123         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
2124         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
2125
2126 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
2127
2128         [GTK] Fix WebContext languages test
2129         https://bugs.webkit.org/show_bug.cgi?id=200538
2130
2131         Reviewed by Alex Christensen.
2132
2133         This test broke after the format of Accepted-Languages
2134         was changed in r238236, update.
2135
2136         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2137         (testWebContextLanguages):
2138
2139 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
2140
2141         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
2142         https://bugs.webkit.org/show_bug.cgi?id=200536
2143
2144         Reviewed by Carlos Alberto Lopez Perez.
2145
2146         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2147         (testWebsiteDataDatabases): Databases take a moment to be written,
2148         wait before fetching the data as it's done in other tests.
2149
2150 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
2151
2152         results.webkit.org: Use canvas for timeline
2153         https://bugs.webkit.org/show_bug.cgi?id=200172
2154
2155         Rubber-stamped by Aakash Jain.
2156
2157         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
2158         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
2159         (Commit.compare): Ditto.
2160         (_CommitBank.commitByUuid): Ditto.
2161         (_CommitBank._loadSiblings): Ditto.
2162         (_CommitBank._load): Ditto.
2163         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2164         (tickForCommit): Deleted.
2165         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
2166         which encompasses all results. Crucially, this function must exclude an UUIDs which may
2167         refer to results excluded because of the limit argument.
2168         (renderTimeline): Deleted.
2169         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
2170         with those results.
2171         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
2172         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
2173         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
2174         (inPlaceCombine): Combine result objects together.
2175         (statsForSingleResult): Turn a single result into a stat object.
2176         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
2177         (Dot): Deleted.
2178         (TimelineFromEndpoint): Renamed from Timeline.
2179         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
2180         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
2181         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
2182         cache contents.
2183         (TimelineFromEndpoint.reload): Remove management of nested timelines.
2184         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
2185         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
2186         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
2187
2188 2019-08-08  Brady Eidson  <beidson@apple.com>
2189
2190         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
2191         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
2192
2193         Reviewed by Geoff Garen.
2194
2195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2196         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
2197
2198 2019-08-08  Rob Buis  <rbuis@igalia.com>
2199
2200         Add runtime flag for lazy image loading
2201         https://bugs.webkit.org/show_bug.cgi?id=199794
2202
2203         Reviewed by Darin Adler.
2204
2205         Set lazyImageLoading preference as part of experimental features. Add
2206         TestOption for lazy image loading.
2207
2208         * DumpRenderTree/TestOptions.cpp:
2209         (TestOptions::TestOptions):
2210         * DumpRenderTree/TestOptions.h:
2211         * DumpRenderTree/mac/DumpRenderTree.mm:
2212         (enableExperimentalFeatures):
2213         (setWebPreferencesForTestOptions):
2214         * DumpRenderTree/win/DumpRenderTree.cpp:
2215         (enableExperimentalFeatures):
2216
2217 2019-08-08  Rob Buis  <rbuis@igalia.com>
2218
2219         Import lazy loading WPT tests
2220         https://bugs.webkit.org/show_bug.cgi?id=199795
2221
2222         Reviewed by Darin Adler.
2223
2224         Only do loading/ exception for WebKit specific, non WPT tests.
2225
2226         * DumpRenderTree/mac/DumpRenderTree.mm:
2227         (shouldLogFrameLoadDelegates):
2228         * WebKitTestRunner/TestInvocation.cpp:
2229         (WTR::TestInvocation::TestInvocation):
2230
2231 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2232
2233         [Win][MiniBrowser] Add key accelerators for reload and close window
2234         https://bugs.webkit.org/show_bug.cgi?id=200497
2235
2236         Reviewed by Brent Fulgham.
2237
2238         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
2239
2240         * MiniBrowser/win/MainWindow.cpp:
2241         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
2242         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
2243         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
2244
2245 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
2246
2247         Add WHLSL and WebGPU to the watchlist file
2248         https://bugs.webkit.org/show_bug.cgi?id=200509
2249
2250         Reviewed by Robin Morisset.
2251
2252         * Scripts/webkitpy/common/config/watchlist:
2253
2254 2019-08-07  Keith Rollin  <krollin@apple.com>
2255
2256         Unreviewed build fix after r248317 -- disable XCBuild because it
2257         breaks incremental builds.
2258
2259         * Scripts/webkitdirs.pm:
2260         (canUseXCBuild):
2261
2262 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2263
2264         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
2265         https://bugs.webkit.org/show_bug.cgi?id=200465
2266
2267         Reviewed by Alex Christensen.
2268
2269         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
2270         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
2271         finishing the test.
2272         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2273         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
2274
2275 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2276
2277         Unreviewed, a build fix after r248308
2278
2279         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
2280
2281         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2282
2283 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2284
2285         Unreviewed, a build fix after r248319
2286
2287         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
2288
2289         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2290         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2291         (WTR::TestController::addTestKeyToKeychain):
2292         (WTR::TestController::cleanUpKeychain):
2293         (WTR::TestController::keyExistsInKeychain):
2294
2295 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2296
2297         Unreviewed, a build fix after r248308
2298
2299         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
2300
2301         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2302         (WTR::TestController::addTestKeyToKeychain):
2303         (WTR::TestController::cleanUpKeychain):
2304         (WTR::TestController::keyExistsInKeychain):
2305
2306 2019-08-06  Keith Rollin  <krollin@apple.com>
2307
2308         Enable XCBuild for `make` and `build-webkit` builds
2309         https://bugs.webkit.org/show_bug.cgi?id=200476
2310         <rdar://problem/50771065>
2311
2312         Reviewed by Jonathan Bedard.
2313
2314         All projects have now been tested under XCBuild and successfully
2315         build. Enable the use of XCBuild when performing builds with `make` or
2316         `build-webkit` and when using a sufficient version of Xcode. We set
2317         this version to Xcode 11 since Xcode 10 -- even though it supports
2318         XCBuild -- does not support a build facility needed to build WebKit
2319         (Bug 197072, Bug 197116, Bug 197340).
2320
2321         Do not enable XCBuild in the Xcode projects themselves since these
2322         projects may need to be used under older versions of Xcode and there's
2323         no way to make those project changes sensitive to the version of Xcode
2324         being used. This means that builds performed in the Xcode IDE will not
2325         use XCBuild.
2326
2327         * Scripts/webkitdirs.pm:
2328         (canUseXCBuild):
2329
2330 2019-08-06  Chris Dumez  <cdumez@apple.com>
2331
2332         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
2333         https://bugs.webkit.org/show_bug.cgi?id=200475
2334
2335         Reviewed by Darin Adler.
2336
2337         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2338         (TestWebKitAPI::stringViewFromLiteral):
2339         (TestWebKitAPI::stringViewFromUTF8):
2340
2341 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2342
2343         Update my status in contributors.json to reviewer.
2344
2345         Regained the status after following the procedure for inactive contributors.
2346         See r247136 for further explanation.
2347
2348         * Scripts/webkitpy/common/config/contributors.json:
2349
2350 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
2351
2352         [WebAuthN] Enable LocalAuthenticator for macOS
2353         https://bugs.webkit.org/show_bug.cgi?id=182772
2354         <rdar://problem/43347920>
2355
2356         Reviewed by Brent Fulgham.
2357
2358         Add an entitlement file to WebKitTestRunner such that it can access
2359         the modern macOS keychain.
2360
2361         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
2362         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2363         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2364         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2365         (WTR::TestController::addTestKeyToKeychain):
2366         (WTR::TestController::cleanUpKeychain):
2367         (WTR::TestController::keyExistsInKeychain):
2368
2369 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
2370
2371         [results.webkit.org Timeline] Performance improvements
2372         https://bugs.webkit.org/show_bug.cgi?id=200406
2373
2374         Reviewed by Jonathan Bedard.
2375
2376         1. Unhook the scroll event when a series/axis have been removed from the container
2377         2. Fix the axis's cache data structure out of sync.
2378         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
2379         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
2380
2381
2382         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
2383         (Signal.prototype.removeListener):
2384         (prototype.stopAction): Unregsiter an action handler
2385         (Ref):
2386         (Ref.prototype.apply):
2387         (Ref.prototype.destory):
2388         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
2389         (ApplyNewChildren):
2390         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2391         (Timeline.CanvasSeriesComponent):
2392
2393 2019-08-06  Jer Noble  <jer.noble@apple.com>
2394
2395         Add test for behavior introduced in r248174
2396         https://bugs.webkit.org/show_bug.cgi?id=200446
2397
2398         Reviewed by Eric Carlson.
2399
2400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2401         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
2402         (WebKit::configureSecheuristic):
2403         (WebKit::TEST):
2404
2405 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
2406
2407         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
2408         https://bugs.webkit.org/show_bug.cgi?id=200464
2409
2410         Reviewed by Ross Kirsling.
2411
2412         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
2413         menu, Alt-F4 to close window, and etc) don't work.
2414
2415         WK1 WebView doesn't have this issue because it processes key events
2416         properly.
2417
2418         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2419         (WebKitBrowserWindow::WebKitBrowserWindow):
2420         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
2421         unhandled key events to the main window.
2422         * MiniBrowser/win/WebKitBrowserWindow.h:
2423
2424 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
2425
2426         iOS 13: Overflow:hidden on body prevents PDF scroll
2427         https://bugs.webkit.org/show_bug.cgi?id=200435
2428         rdar://problem/53942888
2429
2430         Reviewed by Tim Horton.
2431
2432         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
2433         to make sure that the scroll view is scrollable.
2434
2435         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
2436         (TestWebKitAPI::TEST):
2437
2438 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
2439
2440         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
2441         https://bugs.webkit.org/show_bug.cgi?id=200400
2442
2443         Reviewed by Jonathan Bedard.
2444
2445         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2446         (StatusBubble._build_bubble):
2447         (StatusBubble._queue_position):
2448
2449 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
2450
2451         run-webkit-tests asserts when the iPhone XR simulator is running
2452         https://bugs.webkit.org/show_bug.cgi?id=200404
2453         <rdar://problem/53878739>
2454
2455         Reviewed by Dean Jackson.
2456
2457         Support unicode in all logging statements tied to device model.
2458
2459         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2460         (Manager.run):
2461         * Scripts/webkitpy/layout_tests/views/printing.py:
2462         (Printer.print_baseline_search_path):
2463         * Scripts/webkitpy/port/device.py:
2464         (Device.__repr__):
2465         * Scripts/webkitpy/port/device_port.py:
2466         (DevicePort._install):
2467         (DevicePort.setup_test_run):
2468         (DevicePort.clean_up_test_run):
2469         (DevicePort.configuration_for_upload):
2470         * Scripts/webkitpy/port/ios.py:
2471         (IOSPort.default_baseline_search_path):
2472         * Scripts/webkitpy/xcode/device_type.py:
2473         (DeviceType.__str__):
2474         * Scripts/webkitpy/xcode/simulated_device.py:
2475         (SimulatedDeviceManager.populate_available_devices):
2476         (SimulatedDeviceManager._find_available_name):
2477         (SimulatedDeviceManager._get_device_identifier_for_type):
2478         (SimulatedDeviceManager._create_or_find_device_for_request):
2479         (SimulatedDeviceManager._does_fulfill_request):
2480         (SimulatedDeviceManager._wait_until_device_in_state):
2481         (SimulatedDeviceManager._wait_until_device_is_usable):
2482         (SimulatedDeviceManager._boot_device):
2483         (SimulatedDeviceManager.initialize_devices):
2484         (SimulatedDeviceManager.max_supported_simulators):
2485         (SimulatedDeviceManager.swap):
2486         (SimulatedDevice.is_usable):
2487         (SimulatedDevice._shut_down):
2488         (SimulatedDevice._delete):
2489         (SimulatedDevice.launch_app):
2490         (SimulatedDevice.__repr__):
2491
2492 2019-08-04  Chris Dumez  <cdumez@apple.com>
2493
2494         Ping loads should not prevent page caching
2495         https://bugs.webkit.org/show_bug.cgi?id=200418
2496         <rdar://problem/53901632>
2497
2498         Reviewed by Darin Adler.
2499
2500         Add TestOption to enable PageCache at UIProcess-level so that we can test
2501         page caching when navigating cross-origin with PSON enabled.
2502
2503         * WebKitTestRunner/TestController.cpp:
2504         (WTR::TestController::resetPreferencesToConsistentValues):
2505         (WTR::updateTestOptionsFromTestHeader):
2506         * WebKitTestRunner/TestOptions.h:
2507         (WTR::TestOptions::hasSameInitializationOptions const):
2508
2509 2019-08-02  Keith Rollin  <krollin@apple.com>
2510
2511         Consistently use Obj-C boolean literals
2512         https://bugs.webkit.org/show_bug.cgi?id=200405
2513         <rdar://problem/53880043>
2514
2515         Reviewed by Simon Fraser, Joseph Pecoraro.
2516
2517         There are places where we use equivalent but different expressions for
2518         Obj-C boolean objects. For example, we use both [NSNumber
2519         numberWithBool:YES] and @YES. There are places where both are used in
2520         the same function, such as -[WebPreferences initialize]. The boolean
2521         literal is in greater use and is more succinct, so standardize on
2522         that. Also, change @(YES/NO) to @YES/NO.
2523
2524         * DumpRenderTree/mac/ObjCController.m:
2525         (-[ObjCController objectOfClass:]):
2526         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2527         (TEST):
2528         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2529         (overrideAddObserverForName):
2530         * TestWebKitAPI/ios/mainIOS.mm:
2531         (main):
2532         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2533         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2534         * TestWebKitAPI/mac/mainMac.mm:
2535         (main):
2536         * WebKitLauncher/WebKitNightlyEnabler.m:
2537         (enableWebKitNightlyBehaviour):
2538
2539 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2540
2541         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
2542         https://bugs.webkit.org/show_bug.cgi?id=200402
2543         <rdar://problem/53823368>
2544
2545         Reviewed by Tim Horton.
2546
2547         Make it possible to run this test using the iPad simulator.
2548
2549         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2550
2551         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
2552         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
2553         since this would result in differently sized text.
2554
2555         (mainScreenReferenceBoundsOverride):
2556         * TestWebKitAPI/ios/UIKitSPI.h:
2557
2558 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
2559
2560         API tests using permanent credentials should clear credentials left by previous tests
2561         https://bugs.webkit.org/show_bug.cgi?id=199729
2562
2563         Reviewed by Alex Christensen.
2564
2565         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
2566         credentials will not affect tests running after. There is a case where permanent credentials were left on the
2567         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
2568         failure. To prevent this from happening again, add cleanup at the begining of the tests.
2569
2570         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2571         (TEST):
2572         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2573         (TestWebKitAPI::TEST):
2574
2575 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
2576
2577         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
2578         https://bugs.webkit.org/show_bug.cgi?id=200394
2579         <rdar://problem/52914964>
2580
2581         Reviewed by Chris Fleizach.
2582
2583         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
2584
2585         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2586         (WTR::AccessibilityUIElement::isInTableCell const):
2587         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2588         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2589         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2590         (WTR::AccessibilityUIElement::isInTableCell const):
2591
2592 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
2593
2594         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
2595         https://bugs.webkit.org/show_bug.cgi?id=200397
2596
2597         Reviewed by Jonathan Bedard.
2598
2599         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2600
2601 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2602
2603         [macOS 10.15] Image dragged from Safari does not appear in Notes
2604         https://bugs.webkit.org/show_bug.cgi?id=188490
2605         <rdar://problem/39462717>
2606
2607         Reviewed by Andy Estes.
2608
2609         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
2610
2611         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2612
2613 2019-08-02  Alex Christensen  <achristensen@webkit.org>
2614
2615         Fix API test after r248139
2616         https://bugs.webkit.org/show_bug.cgi?id=200102
2617
2618         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
2619         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2620         This was supposed to be removed as part of reverting r245322.
2621
2622 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2623
2624         results.webkit.org: Force update cache when timeline updated
2625         https://bugs.webkit.org/show_bug.cgi?id=200363
2626
2627         Reviewed by Jonathan Bedard.
2628
2629         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2630         (offscreenCachedRenderFactory): Add ability to force the redraw.
2631         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
2632         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
2633
2634 2019-08-01  Alex Christensen  <achristensen@webkit.org>
2635
2636         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
2637         https://bugs.webkit.org/show_bug.cgi?id=200360
2638
2639         Reviewed by Tim Horton.
2640
2641         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2642         (cleanupITPDatabase):
2643         (TEST):
2644
2645 2019-08-01  Alex Christensen  <achristensen@webkit.org>
2646
2647         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
2648         https://bugs.webkit.org/show_bug.cgi?id=200102
2649         <rdar://problem/53275114>
2650
2651         Reviewed by Darin Adler.
2652
2653         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
2654         and because clicking on a TestWKWebView only works on Mac.
2655
2656         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2657         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
2658         (-[UploadDelegate initWithDirectory:]):
2659         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2660         (-[UploadDelegate sentDirectory]):
2661         (TEST):
2662         * TestWebKitAPI/cocoa/TestWKWebView.h:
2663         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2664         (-[TestWKWebView sendClickAtPoint:]):
2665
2666 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2667
2668         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
2669         https://bugs.webkit.org/show_bug.cgi?id=200321
2670
2671         Reviewed by Jonathan Bedard.
2672
2673         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2674         Let the axis' height be defined in the option. Timeine component will use this value as
2675         padding-top for headers which allows headers start in the right position, even with multiple
2676         top axises.
2677         (Timeline.CanvasSeriesComponent):
2678         (prototype.Timeline.CanvasContainer):
2679
2680 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2681
2682         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
2683         https://bugs.webkit.org/show_bug.cgi?id=200347
2684
2685         Reviewed by Jonathan Bedard.
2686
2687         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2688         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
2689
2690 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
2691
2692         Improve flakiness of SOAuthorizationRedirect tests
2693         https://bugs.webkit.org/show_bug.cgi?id=200320
2694         <rdar://problem/53767057>
2695
2696         Reviewed by Alex Christensen.
2697
2698         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
2699         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
2700         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
2701         is executed.
2702
2703         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2704         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2705         (resetState):
2706         (TestWebKitAPI::TEST):
2707
2708 2019-08-01  Keith Rollin  <krollin@apple.com>
2709
2710         Update TestWebKitAPI for XCBuild
2711         https://bugs.webkit.org/show_bug.cgi?id=200311
2712         <rdar://problem/53773804>
2713
2714         Reviewed by Alex Christensen.
2715
2716         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
2717         technique. Now update WebKitLegacy to build under XCBuild after those
2718         changes. This work involves adding an "Apply Configuration to
2719         XCFileLists" build target, adding a check-xcfilelists.sh script,
2720         adding a "Check xcfilelists" build phase that calls that script,
2721         adding knowledge of the project to the generate-xcfilelists script,
2722         creating new .xcfilelist files, and adding those to the project.
2723
2724         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
2725         (Application.__init__):
2726         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2727         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
2728         (TestWebKitAPIGenerator):
2729         (TestWebKitAPIGenerator._get_project_file_path):
2730         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
2731         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
2732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2733         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
2734
2735 2019-08-01  Youenn Fablet  <youenn@apple.com>
2736
2737         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
2738         https://bugs.webkit.org/show_bug.cgi?id=200317
2739
2740         Reviewed by Eric Carlson.
2741
2742         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
2743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2744         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2745         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
2746         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2747         (TestWebKitAPI::TEST):
2748
2749 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
2750
2751         New EWS: Cannot see build status page when patch is waiting for tester
2752         https://bugs.webkit.org/show_bug.cgi?id=200333
2753
2754         Reviewed by Jonathan Bedard.
2755
2756         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2757         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
2758
2759 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2760
2761         [SOUP] Switch to use libsoup WebSockets API
2762         https://bugs.webkit.org/show_bug.cgi?id=200162
2763
2764         Reviewed by Michael Catanzaro.
2765
2766         Update libsoup version to 2.67.90.
2767
2768         * gtk/jhbuild.modules:
2769         * wpe/jhbuild.modules:
2770
2771 2019-07-31  Andy Estes  <aestes@apple.com>
2772
2773         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
2774         https://bugs.webkit.org/show_bug.cgi?id=200293
2775         <rdar://problem/52937749>
2776
2777         Reviewed by Alex Christensen.
2778
2779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2780         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
2781         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2782         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2783         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
2784         (TEST):
2785
2786 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
2787
2788         [ews-build] Enable all macOS queues on new EWS
2789         https://bugs.webkit.org/show_bug.cgi?id=199944
2790
2791         Reviewed by Jonathan Bedard.
2792
2793         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
2794         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2795         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
2796         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
2797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
2798         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
2799
2800 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
2801
2802         Unreviewed test gardening, disable failing test for rdar://51752593.
2803
2804         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2805
2806 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
2807
2808         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
2809         https://bugs.webkit.org/show_bug.cgi?id=200318
2810
2811         Reviewed by Aakash Jain.
2812
2813         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2814         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
2815         (Timeline.CanvasXAxisComponent): Use getLabel function.
2816
2817 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
2818
2819         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
2820         https://bugs.webkit.org/show_bug.cgi?id=200306
2821
2822         Reviewed by Michael Catanzaro.
2823
2824         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
2825         jsc-glib-4.0-scan for example).
2826
2827         * Scripts/webkitdirs.pm:
2828         (generateBuildSystemFromCMakeProject):
2829
2830 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
2831
2832         Unreviewed test gardening, disable failing test for rdar://52355829.
2833
2834         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
2835         (TEST):
2836
2837 2019-07-31  Keith Rollin  <krollin@apple.com>
2838
2839         Update WebKitLegacy for XCBuild
2840         https://bugs.webkit.org/show_bug.cgi?id=200310
2841         <rdar://problem/53773708>
2842
2843         Reviewed by Alex Christensen.
2844
2845         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
2846         technique. Now update WebKitLegacy to build under XCBuild after those
2847         changes. This work involves adding an "Apply Configuration to
2848         XCFileLists" build target, adding a check-xcfilelists.sh script,
2849         adding a "Check xcfilelists" build phase that calls that script,
2850         adding knowledge of the project to the generate-xcfilelists script,
2851         creating new .xcfilelist files, and adding those to the project.
2852
2853         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
2854         (Application.__init__):
2855         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2856         (JavaScriptCoreGenerator):
2857         (WebCoreGenerator):
2858         (WebKitGenerator):
2859         (WebKitGenerator._get_generate_unified_sources_script):
2860         (WebKitLegacyGenerator):
2861         (WebKitLegacyGenerator._get_project_file_path):
2862         (WebKitLegacyGenerator._get_generate_unified_sources_script):
2863
2864 2019-07-31  Chris Dumez  <cdumez@apple.com>
2865
2866         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
2867         https://bugs.webkit.org/show_bug.cgi?id=200086
2868         <rdar://problem/53501721>
2869
2870         Reviewed by Alex Christensen.
2871
2872         re-enable the API test.
2873
2874         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
2875         (TEST):
2876
2877 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
2878
2879         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
2880         https://bugs.webkit.org/show_bug.cgi?id=200291
2881         <rdar://problem/53717946>
2882
2883         Reviewed by Megan Gardner.
2884
2885         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
2886         after closing the web view, while the web view's content view isn't the first responder.
2887
2888         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
2889         * TestWebKitAPI/ios/UIKitSPI.h:
2890
2891 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2892
2893         [GTK] Datalist element support for TextFieldInputType
2894         https://bugs.webkit.org/show_bug.cgi?id=98934
2895
2896         Reviewed by Michael Catanzaro.
2897
2898         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
2899
2900         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
2901         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
2902         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
2903
2904 2019-07-30  Tim Horton  <timothy_horton@apple.com>
2905
2906         Remove some needless comments that snuck into the tree
2907
2908         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2909         (WTR::UIScriptController::setHardwareKeyboardAttached):
2910         (WTR::UIScriptController::playBackEventStream):
2911
2912 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2913
2914         [WebKit] Add PageLoadState::Observer C API
2915         https://bugs.webkit.org/show_bug.cgi?id=199848
2916
2917         Reviewed by Alex Christensen.
2918
2919         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2920         (WebKitBrowserWindow::WebKitBrowserWindow):
2921         (WebKitBrowserWindow::didChangeTitle):
2922         (WebKitBrowserWindow::didFinishNavigation): Deleted.
2923         * MiniBrowser/win/WebKitBrowserWindow.h:
2924         * TestWebKitAPI/CMakeLists.txt:
2925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2926         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
2927         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
2928         (TestWebKitAPI::didChangeActiveURL):
2929         (TestWebKitAPI::didChangeCanGoBack):
2930         (TestWebKitAPI::didChangeCanGoForward):
2931         (TestWebKitAPI::didChangeCertificateInfo):
2932         (TestWebKitAPI::didChangeEstimatedProgress):
2933         (TestWebKitAPI::didChangeHasOnlySecureContent):
2934         (TestWebKitAPI::didChangeIsLoading):
2935         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
2936         (TestWebKitAPI::didChangeTitle):
2937         (TestWebKitAPI::didChangeWebProcessIsResponsive):
2938         (TestWebKitAPI::didSwapWebProcesses):
2939         (TestWebKitAPI::willChangeActiveURL):
2940         (TestWebKitAPI::willChangeCanGoBack):
2941         (TestWebKitAPI::willChangeCanGoForward):
2942         (TestWebKitAPI::willChangeCertificateInfo):
2943         (TestWebKitAPI::willChangeEstimatedProgress):
2944         (TestWebKitAPI::willChangeHasOnlySecureContent):
2945         (TestWebKitAPI::willChangeIsLoading):
2946         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
2947         (TestWebKitAPI::willChangeTitle):
2948         (TestWebKitAPI::willChangeWebProcessIsResponsive):
2949         (TestWebKitAPI::didFinishNavigation):
2950         (TestWebKitAPI::TEST):
2951
2952 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
2953
2954         DumpRenderTree.app: Add CFBundleShortVersionString
2955         https://bugs.webkit.org/show_bug.cgi?id=200269
2956         <rdar://problem/53412596>
2957
2958         Rubber-stamped by Aakash Jain.
2959
2960         * DumpRenderTree/ios/Info.plist:
2961
2962 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2963
2964         Add layout test coverage for <https://webkit.org/b/200215>
2965         https://bugs.webkit.org/show_bug.cgi?id=200245
2966         <rdar://problem/52976965>
2967
2968         Reviewed by Tim Horton.
2969
2970         Add new testing infrastructure. See below for more details.
2971
2972         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2973         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2974         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2975         (WTR::UIScriptController::setWillCreateNewPageCallback):
2976         (WTR::UIScriptController::willCreateNewPageCallback const):
2977
2978         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
2979         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
2980
2981         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2982         (WTR::UIScriptController::becomeFirstResponder):
2983
2984         Add and implement a Cocoa platform hook to make the web view first responder.
2985
2986         * WebKitTestRunner/TestController.cpp:
2987         (WTR::TestController::createOtherPage):
2988         * WebKitTestRunner/TestInvocation.cpp:
2989         (WTR::TestInvocation::willCreateNewPage):
2990         * WebKitTestRunner/TestInvocation.h:
2991         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
2992         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
2993         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
2994
2995 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
2996
2997         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
2998         https://bugs.webkit.org/show_bug.cgi?id=200217
2999
3000         Reviewed by Alex Christensen.
3001
3002         * MiniBrowser/win/BrowserWindow.h:
3003         * MiniBrowser/win/MainWindow.cpp:
3004         (MainWindow::init):
3005         (MainWindow::resizeSubViews):
3006         (MainWindow::WndProc):
3007         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
3008         * MiniBrowser/win/MiniBrowserLib.rc:
3009         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
3010         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3011         (WebKitBrowserWindow::reload):
3012         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
3013         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3014         (WebKitLegacyBrowserWindow::reload):
3015         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3016
3017 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
3018
3019         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
3020         https://bugs.webkit.org/show_bug.cgi?id=200218
3021
3022         Reviewed by Alex Christensen.
3023
3024         Moved the scheme supplementing logic from
3025         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
3026
3027         * MiniBrowser/win/MainWindow.cpp:
3028         (MainWindow::loadURL):
3029         (MainWindow::onURLBarEnter):
3030         * MiniBrowser/win/MainWindow.h:
3031         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3032         (WebKitLegacyBrowserWindow::loadURL):
3033
3034 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
3035
3036         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
3037         https://bugs.webkit.org/show_bug.cgi?id=200254
3038
3039         Unreviewed infrastructure fix.
3040
3041         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
3042
3043 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
3044
3045         [Canvas Timeline] Compact canvas timeline
3046         https://bugs.webkit.org/show_bug.cgi?id=200177
3047
3048         Reviewed by Jonathan Bedard.
3049
3050         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
3051         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3052         (Timeline.CanvasSeriesComponent):
3053
3054 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3055
3056         Multiple context menu actions broken for YouTube videos
3057         https://bugs.webkit.org/show_bug.cgi?id=199999
3058
3059         Reviewed by Eric Carlson.
3060
3061         Add a test case to check copy link address, open in new window and download options are not included in the
3062         context menu for non-downloadable media.
3063
3064         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3065         (writeNextChunk):
3066         (serverCallback):
3067         (testContextMenuLiveStream):
3068         (beforeAll):
3069         (afterAll):
3070
3071 2019-07-28  Tim Horton  <timothy_horton@apple.com>
3072
3073         Reorganize UIScriptController into platform-specific subclasses
3074         https://bugs.webkit.org/show_bug.cgi?id=200027
3075
3076         Reviewed by Simon Fraser.
3077
3078         Instead of a mishmash of #ifdefs and extraneous empty functions,
3079         reorganize UIScriptController so that we have a base class
3080         with functions that assert if called (to make it harder to
3081         accidentally write a test that depends on unimplemented
3082         functionality), and override them in platform specific subclasses
3083         as functionality is added.
3084
3085         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3086         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
3087         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3088         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
3089         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3090         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3091         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3092         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3093         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
3094         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
3095         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
3096         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
3097         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
3098         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3099         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
3100         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3101
3102 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3103
3104         [Win][MiniBrowser] Remove PageLoadTestClient
3105         https://bugs.webkit.org/show_bug.cgi?id=200155
3106
3107         Reviewed by Brent Fulgham.
3108
3109         It is not used nowadays.
3110
3111         * MiniBrowser/win/CMakeLists.txt:
3112         * MiniBrowser/win/Common.cpp:
3113         (parseCommandLine):
3114         * MiniBrowser/win/Common.h:
3115         * MiniBrowser/win/MainWindow.cpp:
3116         (MainWindow::init):
3117         * MiniBrowser/win/MainWindow.h:
3118         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3119         (MiniBrowserWebHost::updateAddressBar):
3120         (MiniBrowserWebHost::didFinishLoadForFrame):
3121         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
3122         (MiniBrowserWebHost::didFailLoadWithError):
3123         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
3124         (MiniBrowserWebHost::didFirstLayoutInFrame):
3125         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
3126         * MiniBrowser/win/PageLoadTestClient.h: Removed.
3127         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3128         (ResourceLoadDelegate::identifierForInitialRequest):
3129         (ResourceLoadDelegate::willSendRequest):
3130         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3131         (ResourceLoadDelegate::didFailLoadingWithError):
3132         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3133         (WebKitBrowserWindow::create):
3134         (WebKitBrowserWindow::createNewPage):
3135         * MiniBrowser/win/WebKitBrowserWindow.h:
3136         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3137         (WebKitLegacyBrowserWindow::create):
3138         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
3139         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
3140         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3141         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
3142         * MiniBrowser/win/WinMain.cpp:
3143         (wWinMain):
3144
3145 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
3146
3147         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
3148         https://bugs.webkit.org/show_bug.cgi?id=200150
3149         <rdar://problem/53280170>
3150
3151         Reviewed by Brent Fulgham.
3152
3153         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3154         (TestWebKitAPI::TEST):
3155
3156 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3157
3158         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
3159         https://bugs.webkit.org/show_bug.cgi?id=200090
3160
3161         Unreviewed follow-up fix.
3162
3163         * resultsdbpy/resultsdbpy/view/view_routes.py:
3164         (ViewRoutes.__init__): Keep /search endpoint for existing links
3165
3166 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3167
3168         results.webkit.org: Add switch to filter results by expectation
3169         https://bugs.webkit.org/show_bug.cgi?id=200134
3170
3171         Rubber-stamped by Aakash Jain.
3172
3173         Users of the results database should be able to easily differentiate tests which are expected
3174         to fail verse tests which are unexpectedly failing.
3175
3176         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3177         (Timeline.render): Respect the willFilterExpected variable.
3178         (LegendLabel): Generates html for label in the legend.
3179         (Legend): Add switch for filter results.
3180         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
3181         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
3182
3183 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
3184
3185         [ews-build] Use update-webkit script in Style EWS
3186         https://bugs.webkit.org/show_bug.cgi?id=193196
3187
3188         Reviewed by Jonathan Bedard.
3189
3190         * BuildSlaveSupport/ews-build/factories.py:
3191         (StyleFactory): Updated to use CheckOutSource step as well.
3192         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
3193         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3194
3195 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3196
3197         results.webkit.org: Support buildbot 0.8 CI links
3198         https://bugs.webkit.org/show_bug.cgi?id=200146
3199
3200         Reviewed by Aakash Jain.
3201
3202         * resultsdbpy/resultsdbpy/model/ci_context.py:
3203         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
3204         (BuildbotEightURLFactory.__init__):
3205         (BuildbotEightURLFactory.url):
3206         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
3207         (URLFactoryTest.test_old_builder_url):
3208         (URLFactoryTest):
3209         (URLFactoryTest.test_old_worker_url):
3210
3211 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3212
3213         results.webkit.org: Suite results shouldn't be the landing page
3214         https://bugs.webkit.org/show_bug.cgi?id=200090
3215
3216         Reviewed by Aakash Jain.
3217
3218         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
3219         * resultsdbpy/resultsdbpy/view/view_routes.py:
3220         (ViewRoutes.__init__): Make search the landing page instead of suite results.
3221         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
3222         (WebSiteUnittest.test_main):
3223
3224 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
3225
3226         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
3227         https://bugs.webkit.org/show_bug.cgi?id=200127
3228
3229         Unreviewed follow-up fix.
3230
3231         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3232         (Dot.toString): Use self instead of this in render callback.
3233
3234 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
3235
3236         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
3237         https://bugs.webkit.org/show_bug.cgi?id=200108
3238         <rdar://problem/53521238>
3239
3240         Reviewed by Chris Dumez.
3241
3242         Added an API test.
3243
3244         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3245         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3246         (TEST):
3247
3248 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
3249
3250         results.webkit.org: Color should be the worst result, count should include all results
3251         https://bugs.webkit.org/show_bug.cgi?id=200127
3252
3253         Rubber-stamped by Aakash Jain.
3254
3255         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3256         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
3257
3258 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
3259
3260         [Timeline]: Make timeline header width automatic, instead of fixed width
3261         https://bugs.webkit.org/show_bug.cgi?id=200059
3262
3263         Reviewed by Jonathan Bedard.
3264
3265         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
3266         (.dot.crash):
3267         (.timeline>.header): Deleted.
3268         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3269         (.timeline>.content):
3270         (.timeline>.header):
3271
3272 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
3273
3274         [ESNext] Implement nullish coalescing
3275         https://bugs.webkit.org/show_bug.cgi?id=200072
3276
3277         Reviewed by Darin Adler.
3278
3279         * Scripts/run-jsc-stress-tests:
3280
3281 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3282
3283         Add Takashi Komori and Tomoki Imai as contributors
3284
3285         Unreviewed.
3286
3287         * Scripts/webkitpy/common/config/contributors.json:
3288
3289 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
3290
3291         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
3292         https://bugs.webkit.org/show_bug.cgi?id=200103
3293
3294         Reviewed by Mark Lam.
3295
3296         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
3297         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
3298
3299         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
3300         to the future implementation changes while it catches the severe issues we had.
3301
3302         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3303         (assertEmptyPointerSet):
3304         (assertHasOnlyObjects):
3305         (assertClean):
3306         (TEST):
3307         (allocateAndDeallocate):
3308
3309 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
3310
3311         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
3312         https://bugs.webkit.org/show_bug.cgi?id=200074
3313
3314         Reviewed by Michael Catanzaro.
3315
3316         There was a latent issue. PluginTest::indicateTestFailure was
3317         using WTF::sleep without linking WTF.
3318
3319         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3320         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
3321
3322 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
3323
3324         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
3325         https://bugs.webkit.org/show_bug.cgi?id=200073
3326
3327         Reviewed by Michael Catanzaro.
3328
3329         * TestWebKitAPI/PlatformGTK.cmake:
3330         * TestWebKitAPI/PlatformWPE.cmake:
3331         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
3332
3333 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3334
3335         [webkitperl] runCommand doesn't work in Windows Perl
3336         https://bugs.webkit.org/show_bug.cgi?id=199900
3337
3338         Reviewed by Don Olmstead.
3339
3340         runCommand was always failing implicit fork by using 'open' with
3341         '-|' in Windows Perl. Explicitly specify the command to 'open' not
3342         to do the implicit fork.
3343
3344         There is one more difference between Windows and Unix. 'open'
3345         successes on Windows even for non existent command while it fails
3346         on Unix. So, return the same error code on Unix as well as
3347         Windows.
3348
3349         * Scripts/VCSUtils.pm: Specified the command to 'open'.
3350         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
3351         command is not available on Windows. Use Perl ($^X) instead.
3352
3353 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
3354
3355         Allow Clients to Add Fields to the AutoFillContext Dictionary.
3356         https://bugs.webkit.org/show_bug.cgi?id=199326
3357         rdar://problem/42816957
3358
3359         Reviewed by Wenson Hsieh.
3360
3361         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3362         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
3363         is being properly populated with additional context dictionary.
3364
3365         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
3366         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
3367         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
3368         which will populate the additional autofill context dictionary.
3369
3370         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
3371         populates the additional autofill context dictionary.
3372
3373         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
3374         context dictionary.
3375
3376         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
3377         input field requires strong password work.
3378
3379         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
3380         input field requires strong password work.
3381
3382         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
3383         password work.
3384
3385 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
3386
3387         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
3388         https://bugs.webkit.org/show_bug.cgi?id=199489
3389
3390         Reviewed by Aakash Jain.
3391
3392         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3393         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
3394         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
3395         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3396         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
3397         (runTest): Record test binary failure
3398         (reportTestFailures): Report test binary failure
3399         (runJSCStressTests):
3400         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
3401         (JscOnlyPort.build_jsc_command):
3402         (JscOnlyPort):
3403         (JscOnlyPort.run_javascriptcore_tests_command):
3404         * Scripts/webkitpy/common/config/ports_unittest.py:
3405         (DeprecatedPortTest.test_jsconly_port):
3406
3407 2019-07-24  Zalan Bujtas  <zalan@apple.com>
3408
3409         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
3410         https://bugs.webkit.org/show_bug.cgi?id=200079
3411         <rdar://problem/53474325>
3412
3413         Reviewed by Wenson Hsieh.
3414
3415         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
3416
3417         * WebKitTestRunner/ios/TestControllerIOS.mm:
3418         (WTR::TestController::platformResetPreferencesToConsistentValues):
3419
3420 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
3421
3422         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
3423         https://bugs.webkit.org/show_bug.cgi?id=199927
3424
3425         Reviewed by Alex Christensen.
3426
3427         convertAbsolutepathToWebKitPath was failing to convert paths on
3428         Windows Perl due to path separators mismatch.
3429
3430         Renamed convertAbsolutepathToWebKitPath to
3431         convertAbsolutePathToRelativeUnixPath, and changed it to replace
3432         paths to relative Unix paths.
3433
3434         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3435         (convertAbsolutePathToRelativeUnixPath): Added.
3436         (convertAbsolutepathToWebKitPath): Deleted.
3437
3438 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3439
3440         Fix iOS API test after r247759
3441         https://bugs.webkit.org/show_bug.cgi?id=200045
3442
3443         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3444         (TEST):
3445         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
3446         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
3447
3448 2019-07-23  Keith Rollin  <krollin@apple.com>
3449
3450         Remove rest of NavigatorContentUtils support
3451         https://bugs.webkit.org/show_bug.cgi?id=200052
3452         <rdar://problem/53467357>
3453
3454         Reviewed by Alex Christensen.
3455
3456         Bug 196070 removes most of the support for the never-used
3457         NavigatorContentUtils facility. However, there were still a couple of
3458         left-over references after that change. This patch sweeps those up.
3459
3460         * Scripts/webkitperl/FeatureList.pm:
3461
3462 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3463
3464         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
3465         https://bugs.webkit.org/show_bug.cgi?id=200045
3466
3467         Reviewed by Mark Lam.
3468
3469         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3470         (TEST):
3471
3472 2019-07-23  Russell Epstein  <repstein@apple.com>
3473
3474         Unreviewed, rolling out r247745.
3475
3476         This broke API test
3477         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
3478         indicated by EWS
3479
3480         Reverted changeset:
3481
3482         "Move javaScriptConfigurationDirectory SPI from
3483         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
3484         runtime switchable"
3485         https://bugs.webkit.org/show_bug.cgi?id=200045
3486         https://trac.webkit.org/changeset/247745
3487
3488 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3489
3490         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
3491         https://bugs.webkit.org/show_bug.cgi?id=200045
3492
3493         Reviewed by Mark Lam.
3494
3495         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3496         (TEST):
3497
3498 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3499
3500         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
3501         https://bugs.webkit.org/show_bug.cgi?id=199972
3502
3503         Reviewed by Jer Noble.
3504
3505         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3506         (TEST):
3507
3508 2019-07-23  Alicia Boya García  <aboya@igalia.com>
3509
3510         [WTF] Add DataMutex and MainThreadData wrappers
3511         https://bugs.webkit.org/show_bug.cgi?id=199831
3512
3513         Reviewed by Alex Christensen.
3514
3515         Added a very simple test that checks that DataMutex<T> indeed takes
3516         the lock and indeed holds data.
3517
3518         * TestWebKitAPI/CMakeLists.txt:
3519         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
3520         (TestWebKitAPI::TEST):
3521
3522 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3523
3524         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
3525         https://bugs.webkit.org/show_bug.cgi?id=200021
3526         <rdar://problem/53301325>
3527
3528         Reviewed by Ryosuke Niwa.
3529
3530         Add support for grabbing the child menu items of a context menu item.
3531
3532         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3533         (WTR::getMenuItemChildrenCallback):
3534
3535 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
3536
3537         WebKit should strip away system font names from the pasted content
3538         https://bugs.webkit.org/show_bug.cgi?id=199975
3539         <rdar://problem/53336353>
3540
3541         Reviewed by Darin Adler.
3542
3543         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
3544
3545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3546         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3547         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
3548
3549 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3550
3551         [ews-build] EWS fails to parse multi-line full_results.json
3552         https://bugs.webkit.org/show_bug.cgi?id=199992
3553
3554         Reviewed by Alexey Proskuryakov.
3555
3556         * BuildSlaveSupport/ews-build/layout_test_failures.py:
3557         (LayoutTestFailures.results_from_string): Concatenate content into single line.
3558         * BuildSlaveSupport/ews-build/steps_unittest.py:
3559         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
3560
3561 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
3562
3563         resultsdbpy: Handle case where the previous commit doesn't have the changelog
3564         https://bugs.webkit.org/show_bug.cgi?id=200015
3565
3566         Reviewed by Aakash Jain.
3567
3568         * resultsdbpy/resultsdbpy/model/repository.py:
3569         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
3570
3571 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3572
3573         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
3574         https://bugs.webkit.org/show_bug.cgi?id=200013
3575         <rdar://problem/52526901>
3576
3577         Reviewed by Simon Fraser.
3578
3579         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
3580
3581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3582         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
3583         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
3584         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
3585         * TestWebKitAPI/ios/UIKitSPI.h:
3586
3587 2019-07-22  Jer Noble  <jer.noble@apple.com>
3588
3589         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
3590         https://bugs.webkit.org/show_bug.cgi?id=199971
3591         <rdar://problem/51951218>
3592
3593         Reviewed by Alex Christensen.
3594
3595         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3596         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
3597         (TestWebKitAPI::TEST):
3598
3599 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3600
3601         [ews-build] Add an EWS to run services tests
3602         https://bugs.webkit.org/show_bug.cgi?id=199994
3603
3604         Reviewed by Jonathan Bedard.
3605
3606         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
3607         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
3608         * BuildSlaveSupport/ews-build/steps.py:
3609         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
3610         (RunEWSUnitTests): Build step to run EWS unit-tests.
3611         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
3612         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3613         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
3614
3615 2019-07-22  Youenn Fablet  <youenn@apple.com>
3616
3617         Disable MediaRecorder for legacy WebKit
3618         https://bugs.webkit.org/show_bug.cgi?id=200001
3619         <rdar://problem/53400030>
3620
3621         Reviewed by Eric Carlson.
3622
3623         Enable MediaRecorder for testing purposes.
3624
3625         * DumpRenderTree/mac/DumpRenderTree.mm:
3626         (createWebViewAndOffscreenWindow):
3627
3628 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
3629
3630         results.webkit.org: Timeline header is too small
3631         https://bugs.webkit.org/show_bug.cgi?id=199955
3632
3633         Reviewed by Aakash Jain.
3634
3635         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
3636         (.timeline>.header): Make timeline header larder to fit configuration names.
3637
3638 2019-07-22  Alex Christensen  <achristensen@webkit.org>
3639
3640         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
3641         https://bugs.webkit.org/show_bug.cgi?id=199954
3642
3643         Reviewed by Geoff Garen.
3644
3645         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3646         (TEST):
3647
3648 2019-07-22  Alex Christensen  <achristensen@webkit.org>
3649
3650         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
3651         https://bugs.webkit.org/show_bug.cgi?id=199917
3652
3653         Reviewed by Sam Weinig.
3654
3655         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3656         (TEST):
3657
3658 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3659
3660         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
3661         https://bugs.webkit.org/show_bug.cgi?id=199980
3662
3663         Reviewed by Jonathan Bedard.
3664
3665         * BuildSlaveSupport/ews-build/steps.py:
3666         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
3667         * BuildSlaveSupport/ews-build/steps_unittest.py:
3668         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
3669         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
3670
3671 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3672
3673         [webkitpy] Add an unit test for setting up the driver environment without starting it.
3674         https://bugs.webkit.org/show_bug.cgi?id=199945
3675
3676         Reviewed by Michael Catanzaro.
3677
3678         This adds an unit test for the change implemented in r247663.
3679
3680         * Scripts/webkitpy/port/driver_unittest.py:
3681         (DriverTest.test_setup_environ_base_vars):
3682         (DriverTest):
3683         (DriverTest.test_setup_environ_without_starting_driver):
3684
3685 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3686
3687         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
3688         https://bugs.webkit.org/show_bug.cgi?id=199993
3689         <rdar://problem/49523528>
3690
3691         Reviewed by Beth Dakin.
3692
3693         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
3694
3695         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3696         (TestWebKitAPI::TEST):
3697         * TestWebKitAPI/cocoa/TestWKWebView.h:
3698
3699 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
3700
3701         Add accessibilityInsertText for text insertion in edit fields.
3702         https://bugs.webkit.org/show_bug.cgi?id=199973
3703
3704         Reviewed by Chris Fleizach.
3705
3706         Renamed accessibilityInsertText to _accessibilityInsertText.
3707
3708         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3709         (AccessibilityUIElement::insertText):
3710         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3711         (AccessibilityUIElement::insertText):
3712         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3713         (WTR::AccessibilityUIElement::insertText):
3714         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3715         (WTR::AccessibilityUIElement::insertText):
3716
3717 2019-07-20  Chris Dumez  <cdumez@apple.com>
3718
3719         Speed up HashTable decoding by reserving capacity and avoiding rehashing
3720         https://bugs.webkit.org/show_bug.cgi?id=199982
3721
3722         Reviewed by Saam Barati.
3723
3724         Add API test coverage.
3725
3726         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3727         (TestWebKitAPI::TEST):
3728
3729 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
3730
3731         Add accessibilityInsertText for text insertion in edit fields.
3732         https://bugs.webkit.org/show_bug.cgi?id=199973
3733
3734         Reviewed by Chris Fleizach.
3735
3736         Glue code to run new LayoutTests.
3737         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3738         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3739         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3740         (WTR::AccessibilityUIElement::insertText):
3741         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3742         (WTR::AccessibilityUIElement::insertText):
3743         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3744         (WTR::AccessibilityUIElement::insertText):
3745         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3746         (WTR::AccessibilityUIElement::insertText):
3747
3748 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
3749
3750         Move webkit.css to opensource to support resultsdbpy's frontend
3751         https://bugs.webkit.org/show_bug.cgi?id=199957
3752
3753         Reviewed by Jonathan Bedard.
3754
3755         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
3756         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
3757         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
3758         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
3759
3760 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
3761
3762         Move Ref.js to WebKit to support resultsdbpy's frontend
3763         https://bugs.webkit.org/show_bug.cgi?id=199956
3764
3765         Reviewed by Jonathan Bedard.
3766
3767         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
3768         * resultsdbpy/resultsdbpy/view/static/js/search.js:
3769         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3770         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
3771         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
3772         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
3773         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
3774         * resultsdbpy/resultsdbpy/view/templates/base.html:
3775         * resultsdbpy/resultsdbpy/view/templates/commits.html:
3776         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
3777         * resultsdbpy/resultsdbpy/view/templates/search.html:
3778         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
3779         * resultsdbpy/resultsdbpy/view/view_routes.py:
3780
3781 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3782
3783         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
3784         https://bugs.webkit.org/show_bug.cgi?id=199945
3785
3786         Reviewed by Michael Catanzaro.
3787
3788         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
3789         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
3790         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
3791
3792         * Scripts/webkitpy/port/driver.py:
3793         (Driver._setup_environ_for_driver):
3794         (Driver._create_temporal_directories):
3795         (Driver):
3796         (Driver._start):
3797         (Driver._delete_temporal_directories):
3798         (Driver.stop):
3799         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
3800         (main):
3801         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
3802         (WebDriverTestRunner.__init__):
3803         * glib/api_test_runner.py:
3804         (TestRunner._setup_testing_environment): Ditto.
3805
3806 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
3807
3808         [ews-build] Display pre-existing Layout test failure names in the build summary
3809         https://bugs.webkit.org/show_bug.cgi?id=199941
3810
3811         Reviewed by Jonathan Bedard.
3812
3813         * BuildSlaveSupport/ews-build/steps.py:
3814         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
3815
3816 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3817
3818         [GTK][WPE] run-webkit-tests should run with a temporal homedir
3819         https://bugs.webkit.org/show_bug.cgi?id=199738
3820
3821         Reviewed by Michael Catanzaro.
3822
3823         Run the tests with an empty homedir that is created inside the driver tmpdir.
3824         The driver tmpdir is a random directory created for each test runner that is purged after the run.
3825
3826         This is done to ensure that the test results are not affected by the user settings of any library.
3827
3828         * Scripts/webkitpy/port/driver.py:
3829         (Driver._setup_environ_for_driver):
3830         * Scripts/webkitpy/port/driver_unittest.py:
3831         (DriverTest.test_setup_environ_base_vars):
3832         (DriverTest):
3833         (DriverTest.test_create_temporal_home_dir):
3834
3835 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3836
3837         Remove pywebsockets from thirdparty
3838         https://bugs.webkit.org/show_bug.cgi?id=199710
3839
3840         Reviewed by Jonathan Bedard.
3841
3842         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
3843         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
3844
3845         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3846         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
3847         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
3848         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
3849         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
3850         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
3851         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
3852         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
3853         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
3854         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
3855         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
3856         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
3857         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
3858         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
3859         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
3860         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
3861         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
3862         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
3863         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
3864         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
3865         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
3866         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
3867
3868 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
3869
3870         results.webkit.org: Move resultsdbpy to WebKit
3871         https://bugs.webkit.org/show_bug.cgi?id=199837
3872         <rdar://problem/53172130>
3873
3874         Rubber-stamped by Aakash Jain.
3875
3876         Moving the entirety of the resultsdbpy library, which provides utilities to build
3877         a database designed to store, visualize and organize test results, into WebKit.
3878
3879         * Scripts/webkitpy/style/checker.py:
3880         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
3881         * resultsdbpy: Added.
3882         * resultsdbpy/MANIFEST.in: Added.
3883         * resultsdbpy/README.md: Added.
3884         * resultsdbpy/resultsdbpy: Added.
3885         * resultsdbpy/resultsdbpy/__init__.py: Added.
3886         * resultsdbpy/resultsdbpy/controller: Added.
3887         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
3888         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
3889         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
3890         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
3891         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
3892         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
3893         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
3894         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
3895         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
3896         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
3897         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
3898         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
3899         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
3900         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
3901         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
3902         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
3903         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
3904         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
3905         * resultsdbpy/resultsdbpy/flask_support: Added.
3906         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
3907         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
3908         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
3909         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
3910         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
3911         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
3912         * resultsdbpy/resultsdbpy/model: Added.
3913         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
3914         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
3915         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
3916         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
3917         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
3918         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
3919         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
3920         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
3921         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
3922         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
3923         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
3924         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
3925         * resultsdbpy/resultsdbpy/model/docker.py: Added.
3926         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
3927         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
3928         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
3929         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
3930         * resultsdbpy/resultsdbpy/model/model.py: Added.
3931         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
3932         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
3933         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
3934         * resultsdbpy/resultsdbpy/model/repository.py: Added.
3935         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
3936         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
3937         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
3938         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
3939         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
3940         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
3941         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
3942         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
3943         * resultsdbpy/resultsdbpy/run-tests: Added.
3944         * resultsdbpy/resultsdbpy/view: Added.
3945         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
3946         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
3947         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
3948         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
3949         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
3950         * resultsdbpy/resultsdbpy/view/static: Added.
3951         * resultsdbpy/resultsdbpy/view/static/css: Added.
3952         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
3953         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
3954         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
3955         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
3956         * resultsdbpy/resultsdbpy/view/static/js: Added.
3957         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
3958         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
3959         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
3960         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
3961         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
3962         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
3963         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
3964         * resultsdbpy/resultsdbpy/view/templates: Added.
3965         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
3966         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
3967         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
3968         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
3969         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
3970         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
3971         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
3972         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
3973         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
3974         * resultsdbpy/setup.py: Added.
3975
3976 2019-07-18  Alex Christensen  <achristensen@webkit.org>
3977
3978         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
3979         https://bugs.webkit.org/show_bug.cgi?id=199923
3980
3981         Reviewed by Youenn Fablet.
3982
3983         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3984         (TestWebKitAPI::TEST):
3985
3986 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
3987
3988         [ews-build] Enable iOS WK2 tester queue on new EWS
3989         https://bugs.webkit.org/show_bug.cgi?id=199867
3990
3991         Reviewed by Jonathan Bedard.
3992
3993         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
3994         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
3995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
3996         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
3997
3998 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
3999
4000         [ews-build] Add build step to AnalyzeLayoutTestsResults
4001         https://bugs.webkit.org/show_bug.cgi?id=199877
4002
4003         Reviewed by Jonathan Bedard.
4004
4005         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
4006
4007         * BuildSlaveSupport/ews-build/steps.py:
4008         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
4009         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
4010         (AnalyzeLayoutTestsResults.report_failure):
4011         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
4012         (AnalyzeLayoutTestsResults.retry_build):
4013         (AnalyzeLayoutTestsResults._results_failed_different_tests):
4014         (AnalyzeLayoutTestsResults._report_flaky_tests):
4015         (AnalyzeLayoutTestsResults.start):
4016         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
4017
4018 2019-07-18  Alex Christensen  <achristensen@webkit.org>
4019
4020         Move NetworkCache ownership from NetworkProcess to NetworkSession
4021         https://bugs.webkit.org/show_bug.cgi?id=199817
4022
4023         Reviewed by Geoff Garen.
4024
4025         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4026         (TEST):
4027         * TestWebKitAPI/cocoa/TestWKWebView.h:
4028         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4029         (-[WKWebView synchronouslyLoadRequest:]):
4030
4031 2019-07-18  Youenn Fablet  <youenn@apple.com>
4032
4033         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
4034         https://bugs.webkit.org/show_bug.cgi?id=199769
4035         <rdar://problem/49390297>
4036
4037         Reviewed by Myles C. Maxfield.
4038
4039         Add a font containing one extended character not found in system fonts.
4040
4041         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4042         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
4043
4044 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
4045
4046         Unreviewed, Add Olivier Blin as contributor
4047
4048         * Scripts/webkitpy/common/config/contributors.json:
4049
4050 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4051
4052         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
4053         https://bugs.webkit.org/show_bug.cgi?id=199855
4054
4055         Reviewed by Michael Catanzaro.
4056
4057         The webkitpy drivers for GTK and WPE use their own versions for setting
4058         up the environment and starting/stopping the drivers.
4059         This refactors those drivers to use the base class driver functions.
4060         As a benefit we get some fixes like support for setting the profiler
4061         environment variables, and a simpler code.
4062
4063         * Scripts/webkitpy/port/driver.py:
4064         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
4065         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
4066         * Scripts/webkitpy/port/headlessdriver.py:
4067         (HeadlessDriver._setup_environ_for_test):
4068         * Scripts/webkitpy/port/waylanddriver.py:
4069         (WaylandDriver._setup_environ_for_test):
4070         * Scripts/webkitpy/port/westondriver.py:
4071         (WestonDriver._setup_environ_for_test):
4072         (WestonDriver.stop):
4073         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
4074         (WestonDriverTest.make_driver):
4075         * Scripts/webkitpy/port/xorgdriver.py:
4076         (XorgDriver._setup_environ_for_test):
4077         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
4078         (XvfbDriver._setup_environ_for_test):
4079         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
4080         (XvfbDriverTest.make_driver):
4081         (XvfbDriverTest.test_start):
4082         (XvfbDriverTest.test_start_arbitrary_worker_number):
4083         * Scripts/webkitpy/w3c/wpt_runner.py:
4084         (main): Start the driver before trying to get its environment to define all the environment variables.
4085         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
4086         (WebDriverTestRunner.__init__): Ditto.
4087         * glib/api_test_runner.py:
4088         (TestRunner._setup_testing_environment): Ditto.
4089
4090 2019-07-17  Antoine Quint  <graouts@apple.com>
4091
4092         Disable Pointer Events prior to watchOS 6
4093         https://bugs.webkit.org/show_bug.cgi?id=199890
4094         <rdar://problem/53206113>
4095
4096         Reviewed by Dean Jackson.
4097
4098         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4099
4100 2019-07-17  Christopher Reid  <chris.reid@sony.com>
4101
4102         Bytecode cache should use FileSystem
4103         https://bugs.webkit.org/show_bug.cgi?id=199759
4104
4105         Reviewed by Yusuke Suzuki.
4106
4107         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
4108
4109 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
4110
4111         check-webkit-style: Add limited Python3 support
4112         https://bugs.webkit.org/show_bug.cgi?id=199870
4113
4114         Rubber-stamped by Aakash Jain.
4115
4116         Since new services will be added in the near future which are Python 3, we
4117         need to support Python 3 style checks. For now, assume all Python files are
4118         Python 2 unless otherwise specified.
4119
4120         * Scripts/webkitpy/style/checker.py:
4121         (_all_categories): Add pycodestyle to valid categories for testing.
4122         (CheckerDispatcher._create_checker): Check that the provided Python file is in
4123         one of the declared Python 3 directories.
4124         * Scripts/webkitpy/style/checkers/python.py:
4125         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
4126         instead of pep8.
4127         (Python3Checker.__init__):
4128         (Python3Checker.check):
4129         * Scripts/webkitpy/thirdparty/__init__.py:
4130         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
4131         (AutoinstallImportHook._install_pycodestyle):
4132
4133 2019-07-17  Sam Weinig  <weinig@apple.com>
4134
4135         Add StringBuilder member function which allows makeString() style variadic argument construction
4136         https://bugs.webkit.org/show_bug.cgi?id=198997
4137
4138         Reviewed by Darin Adler.
4139
4140         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
4141         Add basic test showing that StringBuilder::flexibleAppend can be used to
4142         append one or more string adaptable types.
4143
4144         * TestWebKitAPI/CMakeLists.txt:
4145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4146         Add WTFStringUtilities.cpp
4147
4148         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
4149         Add basic test showing that StringBuilder::flexibleAppend can be used to
4150         append one or more string adaptable types.
4151
4152         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4153         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
4154         * TestWebKitAPI/WTFStringUtilities.h:
4155         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
4156         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
4157
4158 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
4159
4160         Remove the file superfluously added in r247535.
4161
4162         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
4163         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
4164
4165 2019-07-17  Alex Christensen  <achristensen@webkit.org>
4166
4167         Add a runtime-disabled dialog element skeleton
4168         https://bugs.webkit.org/show_bug.cgi?id=199839
4169
4170         Reviewed by Ryosuke Niwa.
4171
4172         * DumpRenderTree/mac/DumpRenderTree.mm:
4173         (resetWebPreferencesToConsistentValues):
4174         * WebKitTestRunner/TestController.cpp:
4175         (WTR::TestController::resetPreferencesToConsistentValues):
4176         Enable the dialog element for layout tests.
4177
4178 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
4179
4180         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
4181         https://bugs.webkit.org/show_bug.cgi?id=199851
4182
4183         Reviewed by Wenson Hsieh.
4184
4185         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
4186         this code is getting directly triggered from UIKeyboard's code.
4187
4188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4189         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
4190         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
4191         * TestWebKitAPI/ios/UIKitSPI.h:
4192
4193 2019-07-17  Commit Queue  <commit-queue@webkit.org>
4194
4195         Unreviewed, rolling out r247505.
4196         https://bugs.webkit.org/show_bug.cgi?id=199871
4197
4198         "Caused failed ASSERT in stress test" (Requested by creid on
4199         #webkit).
4200
4201         Reverted changeset:
4202
4203         "Bytecode cache should use FileSystem"
4204         https://bugs.webkit.org/show_bug.cgi?id=199759
4205         https://trac.webkit.org/changeset/247505
4206
4207 2019-07-17  Russell Epstein  <russell_e@apple.com>
4208
4209         Adding self to contributors.json
4210
4211         Unreviewed.
4212
4213         * Scripts/webkitpy/common/config/contributors.json:
4214
4215 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
4216
4217         [ews-build] Parse full_results.json for layout-tests
4218         https://bugs.webkit.org/show_bug.cgi?id=199804
4219
4220         Reviewed by Jonathan Bedard.
4221
4222         * BuildSlaveSupport/ews-build/steps.py:
4223         (RunWebKitTests.start): Monitor json output.
4224         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
4225         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
4226         by the patch or are pre-existing.
4227         (ReRunWebKitTests.commandComplete): Ditto.
4228         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
4229         * BuildSlaveSupport/ews-build/steps_unittest.py:
4230         (BuildStepMixinAdditions.getProperty): Added.
4231         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
4232         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
4233
4234 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
4235
4236         Unreviewed, rolling out r247512.
4237
4238         Broke API test runners
4239
4240         Reverted changeset:
4241
4242         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
4243         for setting up the environment and start the drivers."
4244         https://bugs.webkit.org/show_bug.cgi?id=199855
4245         https://trac.webkit.org/changeset/247512
4246
4247 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4248
4249         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
4250         https://bugs.webkit.org/show_bug.cgi?id=199855
4251
4252         Reviewed by Carlos Garcia Campos.
4253
4254         The webkitpy drivers for GTK and WPE use their own versions for setting
4255         up the environment and starting/stopping the drivers.
4256         This refactors those drivers to use the base class driver functions.
4257         As a benefit we get some fixes like support for setting the profiler