096ab302fac06a5b06a6cbab611fde7af1f65da7
[WebKit-https.git] / Tools / ChangeLog
1 2011-03-29  Kent Tamura  <tkent@chromium.org>
2
3         Reviewed by Dimitri Glazkov.
4
5         [Mac] Enable interactive-validation tests on Mac DRT
6         https://bugs.webkit.org/show_bug.cgi?id=57308
7
8         * DumpRenderTree/mac/DumpRenderTree.mm:
9         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
10
11 2011-03-29  Chang Shu  <cshu@webkit.org>
12
13         Reviewed by Kenneth Rohde Christiansen.
14
15         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
16         https://bugs.webkit.org/show_bug.cgi?id=42692
17
18         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
19         (WTR::InjectedBundle::beginTesting):
20         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
21         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
22         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
23
24 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
25
26         Reviewed by Xan Lopez.
27
28         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
29         https://bugs.webkit.org/show_bug.cgi?id=57067
30
31         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
32         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
33         update DRT and pixel results as hundreds of results will need to be updated.
34
35         * DumpRenderTree/gtk/DumpRenderTree.cpp:
36         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
37         by overriding the theme RC/CSS files.
38
39 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
40
41         Reviewed by Adam Roben.
42
43         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
44         https://bugs.webkit.org/show_bug.cgi?id=57394
45
46         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
47         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
48         the IDE. To avoid this, add a separate vsprops file for each project configuration that
49         contains the required inherited property sheets.
50
51         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
52         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
53         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
54         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
55         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
56         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
57         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
58         * DumpRenderTree/win/DumpRenderTree.vcproj:
59         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
60         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
61         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
62         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
63         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
64         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
65         * DumpRenderTree/win/ImageDiff.vcproj:
66         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
67         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
68         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
69         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
70         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
71         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
72         * FindSafari/FindSafari.vcproj:
73         * FindSafari/FindSafariDebug.vsprops: Added.
74         * FindSafari/FindSafariDebugAll.vsprops: Added.
75         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
76         * FindSafari/FindSafariRelease.vsprops: Added.
77         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
78         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
79         * FindSafari/FindSafariReleasePGO.vsprops: Added.
80         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
81         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
82         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
83         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
84         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
85         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
86         * MiniBrowser/MiniBrowser.vcproj:
87         * WebKitAPITest/WebKitAPITest.vcproj:
88         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
89         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
90         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
91         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
92         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
93         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
94         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
95         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
96         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
97         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
98         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
99         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
100         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
101         * WebKitTestRunner/win/InjectedBundle.vcproj:
102         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
103         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
104         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
105         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
106         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
107         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
108         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
109         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
110         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
111         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
112         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
113         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
114         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
115         * WinLauncher/WinLauncher.vcproj:
116         * WinLauncher/WinLauncherDebug.vsprops: Added.
117         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
118         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
119         * WinLauncher/WinLauncherRelease.vsprops: Added.
120         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
121         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
122         * record-memory-win/record-memory-win.vcproj:
123         * record-memory-win/record-memory-winDebug.vsprops: Added.
124         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
125         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
126         * record-memory-win/record-memory-winRelease.vsprops: Added.
127         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
128         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
129
130 2011-03-29  Adam Barth  <abarth@webkit.org>
131
132         Reviewed by Darin Adler.
133
134         test_runner2.py can crash due to undefined variable
135         https://bugs.webkit.org/show_bug.cgi?id=57356
136
137         Replace reference to undefined variable with a variable that's actually
138         defined.  AFAICT, there's no way to test this code.
139
140         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
141
142 2011-03-29  Tony Chang  <tony@chromium.org>
143
144         Reviewed by Eric Seidel.
145
146         cleanup rebaseline-chromium-webkit-tests
147         https://bugs.webkit.org/show_bug.cgi?id=57375
148
149         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
150             - Split _extract_and_add_new_baselines into 3 functions
151             - Reduce the amount of line wrapping (the file already has lines
152               over 80 col, so may as well try to make the file consistent)
153             - Remove unnecessary ()s
154
155 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
156
157         Reviewed by Adam Roben.
158
159         Make WinCairo a core builder.
160         https://bugs.webkit.org/show_bug.cgi?id=57373
161
162         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
163         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
164
165 2011-03-29  Timothy Hatcher  <timothy@apple.com>
166
167         Update update-webkit-localizable-strings to understand that WebKit and
168         WebKit2 strings go in WebCore.
169
170         Also make extract-localizable-strings optionally use an exclude file. No individual
171         warnings are produced about unlocalized strings when there is no exclude file. This
172         is needed for WebCore, since there are too many bare strings.
173
174         https://webkit.org/b/57354
175
176         Reviewed by Sam Weinig.
177
178         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
179         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
180
181 2011-03-29  Darin Adler  <darin@apple.com>
182
183         Reviewed by Adam Roben.
184
185         WebKit2 bundle page needs to offer generated file hooks
186         https://bugs.webkit.org/show_bug.cgi?id=57279
187
188         (Land missing part of the original patch after r82289.)
189
190         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
191         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
192
193 2011-03-29  Tony Chang  <tony@chromium.org>
194
195         Reviewed by Ojan Vafai.
196
197         [chromium] NRWT should be able to read checksums from png comments
198         https://bugs.webkit.org/show_bug.cgi?id=57280
199
200         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
201             from a file.
202         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
203         * Scripts/webkitpy/common/system/filesystem_mock.py:
204         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
205             if the -checksum.txt file doesn't exist, try looking in the png.
206         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
207         * Scripts/webkitpy/layout_tests/port/test.py:
208         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
209             2k for a png comment with the checksum
210         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
211
212 2011-03-29  Philippe Normand  <pnormand@igalia.com>
213
214         Rubber-stamped by Gustavo Noronha Silva.
215
216         [GTK] http/tests/uri/username-with-no-hostname.html fails
217         https://bugs.webkit.org/show_bug.cgi?id=57325
218
219         * DumpRenderTree/gtk/DumpRenderTree.cpp:
220         (willSendRequestCallback): URI host value check done case-insensitively.
221
222 2011-03-29  Philippe Normand  <pnormand@igalia.com>
223
224         Reviewed by Martin Robinson.
225
226         [GTK] http/tests/uri/username-with-no-hostname.html fails
227         https://bugs.webkit.org/show_bug.cgi?id=57325
228
229         * DumpRenderTree/gtk/DumpRenderTree.cpp:
230         (willSendRequestCallback): Check URI before submitting the request
231         to WebCore.
232
233 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
234
235         Reviewed by Ojan Vafai.
236
237         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
238         https://bugs.webkit.org/show_bug.cgi?id=57303
239
240         * DumpRenderTree/chromium/EventSender.cpp:
241         (EventSender::doDragDrop):
242         (EventSender::beginDragWithFiles):
243
244 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
245
246         Reviewed by Andreas Kling.
247
248         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
249         https://bugs.webkit.org/show_bug.cgi?id=57314
250
251         Provide possibility to print loaded urls to the standard output.
252
253         * MiniBrowser/qt/BrowserWindow.cpp:
254         (BrowserWindow::BrowserWindow):
255         (BrowserWindow::printURL):
256         * MiniBrowser/qt/BrowserWindow.h:
257         * MiniBrowser/qt/MiniBrowserApplication.cpp:
258         (MiniBrowserApplication::handleUserOptions):
259         * MiniBrowser/qt/MiniBrowserApplication.h:
260         (WindowOptions::WindowOptions):
261         * QtTestBrowser/launcherwindow.cpp:
262         (LauncherWindow::initializeView):
263         (LauncherWindow::printURL):
264         (LauncherWindow::cloneWindow):
265         * QtTestBrowser/launcherwindow.h:
266         (WindowOptions::WindowOptions):
267         * QtTestBrowser/main.cpp:
268         (LauncherApplication::handleUserOptions):
269
270 2011-03-29  Gabor Loki  <loki@webkit.org>
271
272         Rubber-stamped by Csaba Osztrogonác.
273
274         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
275         https://bugs.webkit.org/show_bug.cgi?id=56918
276
277         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
278
279 2011-03-28  Gabor Loki  <loki@webkit.org>
280
281         Reviewed by Csaba Osztrogonác.
282
283         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
284         https://bugs.webkit.org/show_bug.cgi?id=56918
285
286         * Scripts/build-jsc:
287         * Scripts/webkitdirs.pm:
288
289 2011-03-28  Andrew Foster  <andrewf@chromium.org>
290
291         Reviewed by Ojan Vafai.
292
293         webkit-patch should be more intelligent about whether a bug applies to a patch
294         Create a new function, parse_bug_id_from_changelog() which determines
295         that a bug is related to a patch by parsing the output generated from
296         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
297         the description of a patch.
298         https://bugs.webkit.org/show_bug.cgi?id=56989
299
300         * Scripts/webkitpy/common/checkout/api.py:
301         * Scripts/webkitpy/common/checkout/changelog.py:
302         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
303         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
304         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
305         * Scripts/webkitpy/style/checkers/changelog.py:
306         * Scripts/webkitpy/tool/commands/upload.py:
307
308 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
309
310         Revert accidentally commited change.
311
312         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
313         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
314
315 2011-03-28  Tony Chang  <tony@chromium.org>
316
317         Reviewed by Adam Barth.
318
319         [chromium] have DRT write the png checksum into a png comment
320         https://bugs.webkit.org/show_bug.cgi?id=57255
321
322         * DumpRenderTree/chromium/TestShell.cpp:
323         (TestShell::dumpImage):
324
325 2011-03-28  Adele Peterson  <adele@apple.com>
326
327         Removing Qt stub, since it doesn't use the same header as the others.
328
329         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
330
331 2011-03-28  Adele Peterson  <adele@apple.com>
332
333         Added a few more stubs.
334
335         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
336         (LayoutTestController::hasGrammarMarker):
337         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
338         (LayoutTestController::hasGrammarMarker):
339         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
340         (LayoutTestController::hasGrammarMarker):
341
342 2011-03-28  Adele Peterson  <adele@apple.com>
343
344         Build fix.
345
346         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
347         (LayoutTestController::hasGrammarMarker):
348
349 2011-03-28  Adele Peterson  <adele@apple.com>
350
351         Reviewed by Eric Seidel.
352
353         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
354         https://bugs.webkit.org/show_bug.cgi?id=57173
355
356         * DumpRenderTree/LayoutTestController.cpp:
357         (hasGrammarMarkerCallback): Added.
358         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
359         * DumpRenderTree/LayoutTestController.h:
360         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
361         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
362
363 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
364
365         Reviewed by Benjamin Poulain.
366
367         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
368         https://bugs.webkit.org/show_bug.cgi?id=57087
369
370         Trivial typo fix after r82082.
371
372         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
373         (WTR::activateFonts):
374
375 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
376
377         Reviewed by Andreas Kling.
378
379         Add myself to the committers list.
380
381         * Scripts/webkitpy/common/config/committers.py:
382
383 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
384
385         Reviewed by Sam Weinig.
386
387         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
388         to link against WebKit.framework for now.
389
390         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
391
392 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
393
394         Reviewed by Andreas Kling.
395
396         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
397         https://bugs.webkit.org/show_bug.cgi?id=57087
398
399         Disable QT_ASCII_CAST_WARNINGS for applications.
400
401         * DumpRenderTree/qt/DumpRenderTree.pro:
402         * DumpRenderTree/qt/ImageDiff.pro:
403         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
404         * MiniBrowser/qt/MiniBrowser.pro:
405         * QtTestBrowser/QtTestBrowser.pro:
406         * WebKitTestRunner/qt/WebKitTestRunner.pro:
407
408 2011-03-28  Andreas Kling  <kling@webkit.org>
409
410         Reviewed by Kenneth Rohde Christiansen.
411
412         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
413         https://bugs.webkit.org/show_bug.cgi?id=57224
414
415         * QtTestBrowser/mainwindow.cpp:
416         (MainWindow::buildUI):
417         (MainWindow::onTitleChanged):
418         * QtTestBrowser/mainwindow.h:
419
420 2011-03-27  Jer Noble  <jer.noble@apple.com>
421
422         Reviewed by Maciej Stachowiak.
423
424         Full Screen: disable keyboard access by default
425         https://bugs.webkit.org/show_bug.cgi?id=56684
426
427         Accept the withKeyboard parameter to supportsFullScreenForElement.
428
429         * DumpRenderTree/mac/UIDelegate.mm:
430         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
431
432 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
433
434         Reviewed by David Levin.
435
436         check-webkit-style should check ChangeLog for a valid bug number
437         https://bugs.webkit.org/show_bug.cgi?id=57184
438
439         * Scripts/webkitpy/style/checker.py:
440         * Scripts/webkitpy/style/checker_unittest.py:
441         * Scripts/webkitpy/style/checkers/changelog.py: Added.
442         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
443
444 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
445
446         Reviewed by Andreas Kling.
447
448         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
449         https://bugs.webkit.org/show_bug.cgi?id=57087
450
451         Use explicit conversion for string to avoid depending on the default codec
452         installed by the user code.
453
454         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
455         (WTR::activateFonts):
456
457 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
458
459         Revert inadvertantly committed changes.
460
461         * Scripts/old-run-webkit-tests:
462         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
463
464 2011-03-26  Andreas Kling  <kling@webkit.org>
465
466         Reviewed by Kenneth Rohde Christiansen.
467
468         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
469         https://bugs.webkit.org/show_bug.cgi?id=57162
470
471         * QtTestBrowser/QtTestBrowser.qrc:
472         * QtTestBrowser/favicon.png: Added.
473         * QtTestBrowser/locationedit.cpp:
474         (defaultPageIcon):
475         (LocationEdit::LocationEdit):
476         (LocationEdit::setPageIcon):
477         (LocationEdit::resizeEvent):
478         (LocationEdit::updateInternalGeometry):
479         * QtTestBrowser/locationedit.h:
480         * QtTestBrowser/mainwindow.cpp:
481         (MainWindow::buildUI):
482         (MainWindow::onIconChanged):
483         (MainWindow::onLoadStarted):
484         * QtTestBrowser/mainwindow.h:
485
486 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
487
488         Reviewed by Xan Lopez.
489
490         [GTK] Force DumpRenderTree to use 96 DPI
491         https://bugs.webkit.org/show_bug.cgi?id=56866
492
493         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
494         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
495
496         * DumpRenderTree/gtk/DumpRenderTree.cpp:
497         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
498         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
499         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
500
501 2011-03-25  Andy Estes  <aestes@apple.com>
502
503         Reviewed by Adele Peterson.
504
505         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
506         https://bugs.webkit.org/show_bug.cgi?id=49016
507
508         TestNetscapePlugIn needs to register support for an image MIME type so
509         we can test that the embed tag prefers plug-ins to render image MIME
510         types.
511
512         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
513         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
514         (NP_GetMIMEDescription): Ditto.
515         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
516
517 2011-03-25  Jessie Berlin  <jberlin@apple.com>
518
519         Reviewed by Sam Weinig.
520
521         WebKit2: Need to be able to set and get the Cookie Storage Policy.
522         https://bugs.webkit.org/show_bug.cgi?id=50780
523
524         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
525
526         The test is named "CookieManager" so that we can eventually exercise more of the
527         CookieManager functionality in the test.
528
529         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
530         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
531         Assert that the policy returned is equal to the policy set in
532         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
533         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
534         Set the policy to something different than the user's policy and get the policy again.
535         (TestWebKitAPI::didFinishLoadForFrame):
536         Get the user's policy so that it can be restored at the end of the test.
537         (TestWebKitAPI::TEST):
538         Load about:blank so that the Web Process gets instatiated (needed to get the
539         CookieManager).
540
541         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
542         Add CookieManager.cpp.
543
544 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
545
546         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
547
548         * wx/build/settings.py:
549
550 2011-03-24  Ilya Sherman  <isherman@chromium.org>
551
552         Reviewed by Adam Roben.
553
554         Implement layoutTestController.setAutoFilled in DRT on Windows
555         https://bugs.webkit.org/show_bug.cgi?id=56828
556
557         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
558         (LayoutTestController::setAutofilled): Implemented.
559
560 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
561
562         Unreviewed build correction.
563
564         Correct vsprops file for Debug variant of the CFLite build.
565         Disable a CFNETWORK-specific test when building for CFLite.
566
567         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
568         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
569
570 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
571
572         Reviewed by Adam Barth.
573
574         fix regressions introduced in 81908 - there were a couple of
575         code paths that only fired under python 2.5 that I missed.
576
577         Also change a couple of 'python' references to sys.executable
578         in order to handle runing test-webkitpy with a binary other than
579         something called 'python'.
580
581         https://bugs.webkit.org/show_bug.cgi?id=57063
582
583         * Scripts/webkitpy/layout_tests/port/mac.py:
584         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
585         * Scripts/webkitpy/test/cat.py:
586         * Scripts/webkitpy/test/echo.py:
587
588 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
589
590         Unreviewed build correction.
591
592         Add a stub implementation of the TestInvocation dumping logic.
593         Update project files to reflect new file.
594
595         * WebKitTestRunner/cairo: Added.
596         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
597         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
598         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
599
600 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
601
602         Reviewed by Tony Chang.
603
604         new-run-webkit-tests: clean up worker model defaults. This
605         changes the default behavior to 'threads' instead of
606         'old-threads', and clarifies that chromium-win-* and
607         chromium-mac-leopard are exceptions.
608
609         https://bugs.webkit.org/show_bug.cgi?id=56971
610
611         * Scripts/webkitpy/layout_tests/port/base.py:
612         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
613         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
614         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
615         * Scripts/webkitpy/layout_tests/port/test.py:
616         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
617
618 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
619
620         Reviewed by Darin Adler.
621
622         Media Stream API: fix the order of the options in build-webkit.
623         https://bugs.webkit.org/show_bug.cgi?id=56949
624
625         Fix the order of the options in build-webkit.
626
627         * Scripts/build-webkit:
628
629 2011-03-23  Adam Klein  <adamk@chromium.org>
630
631         Reviewed by Mihai Parparita.
632
633         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
634         https://bugs.webkit.org/show_bug.cgi?id=56884
635
636         This option will be utilized by Chromium's ui_tests to allow
637         referencing js-test-resources from a layout test over HTTP.
638
639         * Scripts/new-run-webkit-httpd:
640         Added --layout_tests_dir option.
641         * Scripts/webkitpy/layout_tests/port/http_server.py:
642         Plumbed through as layout_tests_dir param.
643
644 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
645
646         Reviewed by Mihai Parparita.
647
648         new-run-webkit-tests: run tests in ascending alphabetical order per
649         dir. This is a second attempt at the fix; the first attempt, in 
650         r81597, broke the behavior on the old-inline and old-threads
651         worker models.
652
653         https://bugs.webkit.org/show_bug.cgi?id=56760
654
655         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
656         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
657         * Scripts/webkitpy/layout_tests/port/test.py:
658         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
659
660 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
661
662         Reviewed by Martin Robinson.
663
664         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
665         https://bugs.webkit.org/show_bug.cgi?id=56953
666
667         Print the string for the detail of 'property-change' signal.
668
669         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
670         (axObjectEventListener): Print the detail string.
671
672 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
673
674         Reviewed by Pavel Feldman.
675
676         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
677         https://bugs.webkit.org/show_bug.cgi?id=56843
678
679         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
680         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
681
682 2011-03-22  Eric Seidel  <eric@webkit.org>
683
684         Reviewed by Adam Barth.
685
686         Teach update-webkit about gyp
687         https://bugs.webkit.org/show_bug.cgi?id=56881
688
689         This makes it possible for someone who builds from Xcode
690         to just run update-webkit --gyp and have the project files
691         generated after update automatically.
692
693         I also added a stand-alone "generate-project-files" script
694         wrapping Source/gyp/configure.  This makes running gyp simpler
695         since most people will not have gyp or Source/gyp in their path.
696
697         * Scripts/build-webkit:
698         * Scripts/generate-project-files: Added.
699         * Scripts/update-webkit:
700
701 2011-03-22  Anton D'Auria  <adauria@apple.com>
702
703         Reviewed by Alexey Proskuryakov.
704
705         Add +[WebApplicationCache getOriginsWithCache]
706         https://bugs.webkit.org/show_bug.cgi?id=56722
707
708         * DumpRenderTree/LayoutTestController.cpp:
709         (originsWithApplicationCacheCallback):
710         (LayoutTestController::staticFunctions):
711         * DumpRenderTree/LayoutTestController.h:
712         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
713         (LayoutTestController::originsWithApplicationCache):
714         * DumpRenderTree/chromium/LayoutTestController.h:
715         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
716         (LayoutTestController::originsWithApplicationCache):
717         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
718         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
719         (LayoutTestController::originsWithApplicationCache):
720         (LayoutTestController::originsWithLocalStorage):
721         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
722         (LayoutTestController::originsWithApplicationCache):
723         * DumpRenderTree/qt/LayoutTestControllerQt.h:
724         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
725         (LayoutTestController::originsWithApplicationCache):
726         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
727         (LayoutTestController::originsWithApplicationCache):
728
729 2011-03-22  Eric Seidel  <eric@webkit.org>
730
731         Reviewed by Adam Barth.
732
733         Add support to build-webkit for building with gyp-generated project files
734         https://bugs.webkit.org/show_bug.cgi?id=56877
735
736         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
737         Eventually we'll want to support gyp-generated projects in a more general manner.
738
739         * Scripts/build-webkit:
740
741 2011-03-22  David Kilzer  <ddkilzer@apple.com>
742
743         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
744
745         Reviewed by Joseph Pecoraro.
746
747         * Scripts/build-webkit: Updated usage statement to include
748         --dsym.
749         * Scripts/webkitdirs.pm: Added $generateDsym variable.
750         (generateDsym): Added. Call determineGenerateDsym() and
751         return $generateDsym.
752         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
753         $generateDsym.
754         (argumentsForXcode): Added.  Returns additional arguments for
755         xcodebuild based on command-line switches.
756         (XcodeOptions): Updated to include argumentsForXcode() in the
757         array returned.
758
759 2011-03-22  Adam Roben  <aroben@apple.com>
760
761         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
762
763         These bots are consistently green again.
764
765         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
766         core builders
767
768         Rubber-stamped by Antti Koivisto.
769
770         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
771         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
772
773         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
774         (BuildBotTest.test_builder_name_regexps): Updated expectations.
775
776 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
777
778         Unreviewed, rolling out r81597.
779         http://trac.webkit.org/changeset/81597
780         https://bugs.webkit.org/show_bug.cgi?id=56801
781
782         Change results in lots of unexpected flaky on the dashboard.
783         (Requested by pfeldman on #webkit).
784
785         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
786         * Scripts/webkitpy/layout_tests/port/test.py:
787         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
788
789 2011-03-21  Sam Weinig  <sam@webkit.org>
790
791         Fix failing tests on the WebKit2 bots.
792
793         * WebKitTestRunner/TestController.cpp:
794         (WTR::TestController::resetStateToConsistentValues):
795
796 2011-03-21  Daniel Sievers  <sievers@google.com>
797
798         Reviewed by Simon Fraser.
799
800         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
801         https://bugs.webkit.org/show_bug.cgi?id=56139
802
803         * DumpRenderTree/chromium/DumpRenderTree.cpp:
804         (main):
805         * DumpRenderTree/chromium/LayoutTestController.cpp:
806         (LayoutTestController::LayoutTestController):
807         (LayoutTestController::layerTreeAsText):
808         * DumpRenderTree/chromium/LayoutTestController.h:
809         (LayoutTestController::setShowDebugLayerTree):
810         * DumpRenderTree/chromium/TestShell.cpp:
811         (TestShell::runFileTest):
812         (TestShell::dump):
813         * DumpRenderTree/chromium/TestShell.h:
814         (TestParams::TestParams):
815
816 2011-03-21  Adam Roben  <aroben@apple.com>
817
818         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
819
820         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
821         output as plain text
822
823         Reviewed by David Kilzer.
824
825         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
826         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
827         to the master.
828         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
829         since we're running on the build master, not the slave. Instead, turn the raw source of
830         actual.html which the build slave uploaded into an HTML log.
831
832 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
833
834         Reviewed by Mihai Parparita.
835
836         new-run-webkit-tests: run tests in ascending alphabetical order per dir
837         https://bugs.webkit.org/show_bug.cgi?id=56760
838
839         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
840         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
841         * Scripts/webkitpy/layout_tests/port/test.py:
842
843 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
844
845         Reviewed by Steve Block.
846
847         Media Stream API patch 0: adding compilation guards.
848         https://bugs.webkit.org/show_bug.cgi?id=56458
849
850         Adding options to enable the media stream API feature in Chromium.
851
852         * Scripts/build-webkit:
853
854 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
855
856         Reviewed by Laszlo Gombos.
857
858         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
859         https://bugs.webkit.org/show_bug.cgi?id=56323
860
861         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
862         "--stdout" or "--stderr" option.
863
864         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
865         (WebCore::DumpRenderTree::~DumpRenderTree):
866         (WebCore::DumpRenderTree::processArgsLine):
867         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
868         * DumpRenderTree/qt/DumpRenderTreeQt.h:
869         (WebCore::DumpRenderTree::setRedirectOutputFileName):
870         (WebCore::DumpRenderTree::setRedirectErrorFileName):
871         * DumpRenderTree/qt/main.cpp:
872         (isOption):
873         (takeOptionValue):
874         (printUsage):
875         (main):
876
877 2011-03-21  Adam Roben  <aroben@apple.com>
878
879         Fix exceptions on the buildbot due to my last change
880
881         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
882         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
883
884 2011-03-21  Adam Roben  <aroben@apple.com>
885
886         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
887
888         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
889         output as plain text
890
891         Reviewed by Darin Adler.
892
893         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
894         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
895         logs.
896         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
897         the build master. This will correctly treat it as HTML.
898
899 2011-03-20  Bill Budge  <bbudge@chromium.org>
900
901         Reviewed by Adam Barth.
902
903         Rename ThreadSafeShared to ThreadSafeRefCounted
904         https://bugs.webkit.org/show_bug.cgi?id=56714
905
906         No new tests. Exposes no new functionality.
907
908         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
909         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
910         * Scripts/do-webcore-rename:
911
912 2011-03-19  Anton D'Auria  <adauria@apple.com>
913
914         Reviewed by Dan Bernstein.
915
916         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
917         https://bugs.webkit.org/show_bug.cgi?id=56719
918
919         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
920         (LayoutTestController::clearApplicationCacheForOrigin):
921
922 2011-03-19  Anton D'Auria  <adauria@apple.com>
923
924         Reviewed by Alexey Proskuryakov.
925
926         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
927         https://bugs.webkit.org/show_bug.cgi?id=56415
928
929         * DumpRenderTree/LayoutTestController.cpp:
930         (clearApplicationCacheForOriginCallback):
931         (LayoutTestController::staticFunctions):
932         * DumpRenderTree/LayoutTestController.h:
933         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
934         (LayoutTestController::LayoutTestController):
935         (LayoutTestController::clearAllApplicationCaches):
936         (LayoutTestController::clearApplicationCacheForOrigin): 
937         * DumpRenderTree/chromium/LayoutTestController.h:
938         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
939         (LayoutTestController::clearApplicationCacheForOrigin):
940         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
941         (LayoutTestController::clearApplicationCacheForOrigin):
942         * DumpRenderTree/qt/LayoutTestControllerQt.h:
943         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
944         (LayoutTestController::clearApplicationCacheForOrigin):
945         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
946         (LayoutTestController::clearApplicationCacheForOrigin):
947
948 2011-03-18  Dan Bernstein  <mitz@apple.com>
949
950         Revised build fix for r81135.
951
952         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
953         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
954
955 2011-03-18  Adam Roben  <aroben@apple.com>
956
957         Windows build fix
958
959         * WebKitTestRunner/config.h: Add a missing #endif.
960
961 2011-03-18  Andreas Kling  <kling@webkit.org>
962
963         Unbreak Qt build after r81494.
964
965         * WebKitTestRunner/qt/TestInvocationQt.cpp:
966         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
967
968 2011-03-18  Sam Weinig  <sam@webkit.org>
969
970         Fix windows build. This was really Adam Roben's fault. I swear!
971
972         * WebKitTestRunner/config.h:
973
974 2011-03-18  Sam Weinig  <sam@webkit.org>
975
976         Reviewed by Adam Roben.
977
978         Pixel tests don't work in WebKitTestRunner on Windows
979         https://bugs.webkit.org/show_bug.cgi?id=56630
980
981         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
982         built-in snapshotting instead of using the window server on the Mac.
983
984         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
985         (WTR::InjectedBundle::InjectedBundle):
986         (WTR::InjectedBundle::didReceiveMessage):
987         (WTR::InjectedBundle::beginTesting):
988         (WTR::InjectedBundle::done):
989         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
990         (WTR::InjectedBundle::setPixelResult):
991         (WTR::InjectedBundle::shouldDumpPixels):
992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
993         (WTR::InjectedBundlePage::dump):
994         Take the snapshot in the bundle and send it to the UIProcess for dumping.
995
996         * WebKitTestRunner/TestInvocation.cpp:
997         (WTR::TestInvocation::invoke):
998         (WTR::TestInvocation::dump):
999         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1000         * WebKitTestRunner/TestInvocation.h:
1001         * WebKitTestRunner/cg: Added.
1002         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1003         (WTR::createCGContextFromImage):
1004         (WTR::computeMD5HashStringForContext):
1005         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1006         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1007         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1008
1009         * WebKitTestRunner/win/TestInvocationWin.cpp:
1010         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1011         Keep stub for Cairo build.
1012
1013         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1014         Add CG configuration.
1015
1016         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1017         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1018         Add new files.
1019
1020 2011-03-18  Adam Roben  <aroben@apple.com>
1021
1022         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1023
1024         Rubber-stamped by Simon Fraser.
1025
1026         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1027         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1028         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1029
1030 2011-03-18  Adam Roben  <aroben@apple.com>
1031
1032         Don't ellipsize long or indented function names in Leaks Viewer
1033
1034         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1035         scrollbar
1036
1037         Reviewed by Simon Fraser.
1038
1039         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1040         (.data-grid .data-container):
1041         (.data-grid td > div, .data-grid th > div):
1042         Allow the contents to extend to the right.
1043
1044 2011-03-18  Adam Roben  <aroben@apple.com>
1045
1046         Fix some leaks in DRT seen on the leaks bot
1047
1048         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1049         setWillSendRequestClearHeaderCallback in DRT are leaky
1050
1051         Reviewed by Alexey Proskuryakov.
1052
1053         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1054
1055         * DumpRenderTree/LayoutTestController.cpp:
1056         (addURLToRedirectCallback):
1057         (setWillSendRequestClearHeaderCallback):
1058         Use OwnArrayPtr to cause the strings to be deleted.
1059
1060 2011-03-18  Adam Roben  <aroben@apple.com>
1061
1062         Fix a NSURLCredential leak seen on the leaks bot
1063
1064         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1065         connection:didReceiveAuthenticationChallenge:] is leaky
1066
1067         Reviewed by John Sullivan.
1068
1069         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1070         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1071         cause the NSURLCredential to be released.
1072
1073 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1074
1075         Unreviewed.
1076
1077         Remove unnecessary brackets around my email address.
1078
1079         * Scripts/webkitpy/common/config/committers.py:
1080
1081 2011-03-18  Adam Roben  <aroben@apple.com>
1082         
1083         Remove some files I accidentally added in r81454
1084
1085         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1086         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1087
1088 2011-03-18  Adam Roben  <aroben@apple.com>
1089
1090         Ignore an NSNumberFormatter leak on SnowLeopard
1091
1092         * Scripts/old-run-webkit-tests:
1093         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1094         getObjectValue:forString:errorDescription:].
1095
1096 2011-03-18  Adam Roben  <aroben@apple.com>
1097
1098         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1099
1100         Rubber-stamped by Mark Rowe.
1101
1102         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1103         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1104         released.
1105
1106 2011-03-17  Adam Roben  <aroben@apple.com>
1107
1108         Address a review comment I missed in r81445
1109
1110         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1111         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1112         leaked bytes to speed up searching on long lines.
1113
1114 2011-03-17  Adam Roben  <aroben@apple.com>
1115
1116         Mark leaky builds orange, even if all regression tests passed
1117
1118         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1119         build.webkit.org when all tests pass even though there are still leaks
1120
1121         Reviewed by Dan Bernstein.
1122
1123         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1124         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1125         be marked orange if this build step generates warnings.
1126
1127 2011-03-17  Adam Roben  <aroben@apple.com>
1128
1129         Allow values in Leaks Viewer to be shown as percentages
1130
1131         Double-clicking on a column will toggle between showing percentages and showing real values.
1132
1133         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1134         number of leaked bytes in Leaks Viewer
1135
1136         Reviewed by Joe Pecoraro.
1137
1138         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1139         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
1140         node's totalTime, which is used in calculating percentages.
1141
1142         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1143         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
1144         showing them as percentages.
1145
1146 2011-03-17  Adam Roben  <aroben@apple.com>
1147
1148         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
1149
1150         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
1151         the number of leaked allocations. And the new Average column shows the average number of
1152         leaked bytes per call.
1153
1154         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
1155         just how many allocations
1156
1157         Reviewed by Joe Pecoraro.
1158
1159         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1160         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
1161         line and store it with the leak stack.
1162         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
1163         properties.
1164         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
1165         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
1166         .numberOfCalls now holds the number of leaked allocations.
1167
1168         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1169         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
1170         appear.
1171         (monkeyPatchInspectorObjects): Format the values as bytes.
1172
1173 2011-03-17  Adam Roben  <aroben@apple.com>
1174
1175         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
1176
1177         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
1178         regression tests
1179
1180         Reviewed by James Robinson.
1181
1182         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1183         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
1184         is always populated, even when all regression tests pass.
1185
1186 2011-03-10  Hayato Ito  <hayato@chromium.org>
1187
1188         Reviewed by Tony Chang.
1189
1190         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
1191
1192         https://bugs.webkit.org/show_bug.cgi?id=56076
1193
1194         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1195
1196 2011-03-17  Adam Roben  <aroben@apple.com>
1197
1198         Skip a compositing-sensitive test when accelerated compositing is disabled
1199
1200         Reviewed by Sam Weinig.
1201
1202         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
1203         accelerated compositing is disabled.
1204
1205 2011-03-17  Adam Roben  <aroben@apple.com>
1206
1207         Start using PlatformSpecificScheduler for the Mac builders
1208
1209         The current set of file/directory patterns should work for Mac builders. We may discover
1210         that there are more files and directories we can exclude from the Mac builds, but they can
1211         be added later.
1212
1213         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
1214
1215         Reviewed by Mark Rowe.
1216
1217         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
1218         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
1219
1220         * Scripts/webkitpy/common/config/build.py:
1221         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
1222         cleaned up patterns a little bit.
1223
1224         * Scripts/webkitpy/common/config/build_unittest.py:
1225         (ShouldBuildTest): Fixed some expected results.
1226         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
1227         platforms.
1228
1229 2011-03-17  Jeff Miller  <jeffm@apple.com>
1230
1231         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
1232         
1233         *.mode*
1234         *.pbxuser
1235         *.perspective*
1236         project.xcworkspace
1237         xcuserdata
1238
1239         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1240         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1241         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1242         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1243         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1244
1245 2011-03-17  Adam Roben  <aroben@apple.com>
1246
1247         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
1248
1249         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
1250         mac-wk2
1251
1252         Reviewed by Anders Carlsson.
1253
1254         * Scripts/old-run-webkit-tests:
1255         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
1256         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
1257         we're running in WebKit2 mode.
1258
1259 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
1260
1261         Reviewed by Yury Semikhatsky.
1262
1263         Web Inspector: Clean up Inspector strings.
1264         https://bugs.webkit.org/show_bug.cgi?id=56557
1265
1266         Modify the script to deal correctly with "\xNN" escapes, and to
1267         check strings in Chromium's DevTools.js.
1268
1269         * Scripts/check-inspector-strings:
1270
1271 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
1272
1273         Reviewed by Benjamin Poulain.
1274
1275         Update autoinstall to install mechanize 0.2.4
1276         https://bugs.webkit.org/show_bug.cgi?id=56499
1277
1278         Newer versions of mechanize support HTTPS proxies, which is necessary
1279         for people using webkit-patch behind firewalls.
1280
1281         * Scripts/webkitpy/common/system/autoinstall.py:
1282         * Scripts/webkitpy/thirdparty/__init__.py:
1283
1284 2011-03-16  Sam Weinig  <sam@webkit.org>
1285
1286         Reviewed by Adam Roben.
1287
1288         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
1289         https://bugs.webkit.org/show_bug.cgi?id=56541
1290
1291         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1292         (WTR::InjectedBundlePage::willSendRequestForFrame):
1293         Check for an empty host in addition to a null host.  This bug was introduced
1294         when porting off of the KURL code and onto the WKURLRef version.
1295
1296 2011-03-16  Sam Weinig  <sam@webkit.org>
1297
1298         Reviewed by Adam Roben.
1299
1300         Add Lucas Forschler to the list of WebKit committers.
1301
1302         * Scripts/webkitpy/common/config/committers.py:
1303
1304 2011-03-16  Sam Weinig  <sam@webkit.org>
1305
1306         Reviewed upon and dictated through Adam Roben.
1307
1308         Escape crashing function names in results.html. This fixes an issue
1309         when a crash involves a type with templates.
1310
1311         * Scripts/old-run-webkit-tests:
1312
1313 2011-03-16  Daniel Sievers  <sievers@google.com>
1314
1315         Reviewed by James Robinson.
1316
1317         Add setting to always force compositing mode
1318         https://bugs.webkit.org/show_bug.cgi?id=56156
1319
1320         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1321         (main):
1322         * DumpRenderTree/chromium/TestShell.cpp:
1323         (TestShell::TestShell):
1324         (TestShell::resetWebSettings):
1325         * DumpRenderTree/chromium/TestShell.h:
1326         (TestShell::setForceCompositingMode):
1327         * DumpRenderTree/chromium/WebPreferences.cpp:
1328         (WebPreferences::reset):
1329         (WebPreferences::applyTo):
1330         * DumpRenderTree/chromium/WebPreferences.h:
1331
1332 2011-03-15  Hayato Ito  <hayato@chromium.org>
1333
1334         Reviewed by Ojan Vafai.
1335
1336         Ignore files that will be used by reftests in old-run-webkit-tests.
1337
1338         https://bugs.webkit.org/show_bug.cgi?id=55936
1339
1340         * Scripts/old-run-webkit-tests:
1341
1342 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1343
1344         Reviewed by Adam Roben.
1345
1346         Function relativeScriptsDir doesn't return the correct relative
1347         Scripts directory.
1348
1349         * Scripts/webkitdirs.pm:
1350         (relativeScriptsDir): Ensure we use the directory that contains
1351         webkitdirs.pm, not the one that contains the original script that
1352         was invoked.
1353
1354 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1355
1356         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1357         fix to link against the Security framework after recent WebKitSystemInterface changes.
1358
1359         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1360         (LayoutTestController::originsWithLocalStorage):
1361         * wx/build/settings.py:
1362         * wx/build/waf_extensions.py:
1363
1364 2011-03-15  Sam Weinig  <sam@webkit.org>
1365
1366         Reviewed by Darin Adler.
1367
1368         Add script to convert a patch to a prettypatch and show in the default browser
1369         https://bugs.webkit.org/show_bug.cgi?id=56416
1370
1371         This can be used either like
1372             $ svn-create-patch | show-pretty-diff
1373         or
1374             $ show-pretty-diff patch.diff
1375
1376         * Scripts/show-pretty-diff: Added.
1377
1378 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
1379
1380         Rubber-stamped by Adam Roben.
1381
1382         Adding myself as a reviewer.
1383
1384         * Scripts/webkitpy/common/config/committers.py:
1385
1386 2011-03-15  Anders Carlsson  <andersca@apple.com>
1387
1388         Try to fix the Windows build.
1389
1390         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1391         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1392
1393 2011-03-15  Anders Carlsson  <andersca@apple.com>
1394
1395         Reviewed by Sam Weinig.
1396
1397         Make sure that NP_Shutdown is always the last NPP function called
1398         https://bugs.webkit.org/show_bug.cgi?id=56391
1399
1400         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
1401
1402         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1403         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1404         (PluginTest::PluginTest):
1405         (PluginTest::NP_Shutdown):
1406         (PluginTest::registerNPShutdownFunction):
1407         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1408         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
1409         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
1410         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1411         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
1412         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
1413         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
1414         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
1415         (NPDeallocateCalledBeforeNPShutdown::shutdown):
1416         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1417         (NP_Shutdown):
1418         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1419         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1420         * GNUmakefile.am:
1421
1422 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1423
1424         Reviewed by Tony Chang.
1425
1426         Autofilled form elements are assigned fixed background color but not text color
1427         https://bugs.webkit.org/show_bug.cgi?id=48382
1428
1429         * DumpRenderTree/LayoutTestController.cpp:
1430         (setAutofilledCallback): Added.
1431         (LayoutTestController::staticFunctions):
1432         * DumpRenderTree/LayoutTestController.h:
1433         * DumpRenderTree/chromium/LayoutTestController.cpp:
1434         (LayoutTestController::LayoutTestController):
1435         (LayoutTestController::setAutofilled): Added.
1436         * DumpRenderTree/chromium/LayoutTestController.h:
1437         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1438         (LayoutTestController::setAutofilled): Added.
1439         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1440         (LayoutTestController::setAutofilled): Added.
1441         (LayoutTestController::setValueForUser): Style tweak.
1442         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1443         (LayoutTestController::setAutofilled): Added (stub).
1444         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1445         (LayoutTestController::setAutofilled): Added (stub).
1446
1447 2011-03-15  Dan Bernstein  <mitz@apple.com>
1448
1449         Build fix after r81135.
1450
1451         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1452
1453 2011-03-15  Dan Bernstein  <mitz@apple.com>
1454
1455         Build fix after r81135.
1456
1457         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1458         * WebKitTestRunner/mac/TestControllerMac.mm:
1459         * WebKitTestRunner/mac/TestInvocationMac.mm:
1460         * WebKitTestRunner/mac/main.mm:
1461
1462 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
1463
1464         Reviewed by Adam Barth.
1465
1466         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
1467         https://bugs.webkit.org/show_bug.cgi?id=56349
1468
1469         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
1470         on platforms where we use it. Copied from DumpRenderTree.pro.
1471
1472 2011-03-15  Dan Bernstein  <mitz@apple.com>
1473
1474         Build fix after r81135.
1475
1476         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1477         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1478
1479 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1480
1481         Reviewed by Darin Adler.
1482
1483         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1484         info into the headers rather than in export symbol definition files, but disable it on 
1485         all platforms initially so we can deal with port build issues one port at a time.
1486         
1487         https://bugs.webkit.org/show_bug.cgi?id=27551
1488
1489         * DumpRenderTree/cg/ImageDiffCG.cpp:
1490         * DumpRenderTree/chromium/config.h:
1491         * DumpRenderTree/config.h:
1492         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1493         * TestWebKitAPI/TestWebKitAPIPrefix.h:
1494         * WebKitAPITest/HostWindow.cpp:
1495         * WebKitAPITest/TestsController.cpp:
1496         * WebKitAPITest/config.h: Added.
1497         * WebKitAPITest/main.cpp:
1498         * WebKitAPITest/tests/WebViewDestruction.cpp:
1499         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1500         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1501         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1502         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1503         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1504         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1505         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1506         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1507         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1508         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1509         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1510         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
1511         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1512         * WebKitTestRunner/TestController.cpp:
1513         * WebKitTestRunner/TestInvocation.cpp:
1514         * WebKitTestRunner/config.h: Added.
1515         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1516         * WebKitTestRunner/qt/TestControllerQt.cpp:
1517         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1518         * WebKitTestRunner/qt/main.cpp:
1519         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1520         * WebKitTestRunner/win/TestControllerWin.cpp:
1521         * WebKitTestRunner/win/TestInvocationWin.cpp:
1522         * WebKitTestRunner/win/main.cpp:
1523         * wx/build/settings.py:
1524
1525 2011-03-15  Hayato Ito  <hayato@chromium.org>
1526
1527         Reviewed by Shinichiro Hamaji.
1528
1529         [NRWT] Add support for reftests to new-run-webkit-tests.
1530
1531         https://bugs.webkit.org/show_bug.cgi?id=55457
1532
1533         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1534         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1535         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1536         * Scripts/webkitpy/layout_tests/port/base.py:
1537         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1538         * Scripts/webkitpy/layout_tests/port/test.py:
1539         * Scripts/webkitpy/layout_tests/port/test_files.py:
1540         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1541
1542 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
1543
1544         Reviewed by Martin Robinson.
1545
1546         [GTK] Fix compilation warning after r80892
1547         https://bugs.webkit.org/show_bug.cgi?id=56302
1548
1549         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1550         (LayoutTestController::originsWithLocalStorage):
1551
1552 2011-03-15  Robert Hogan  <robert@webkit.org>
1553
1554         Reviewed by Adam Barth.
1555
1556         Document the qmakearg argument, and hint how to build webkit2 on Qt
1557         https://bugs.webkit.org/show_bug.cgi?id=56326
1558
1559         * Scripts/build-webkit: add --qmakearg to build-webkit --help
1560
1561 2011-03-15  Adam Roben  <aroben@apple.com>
1562
1563         Make Windows 7 Release (Tests) a core builder
1564
1565         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1566         give it a few more days of greenness first.
1567
1568         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1569
1570         Reviewed by Sam Weinig.
1571
1572         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1573         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1574
1575         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1576         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1577         Updated the core regexps to match the buildbot module. Updated the expected results to match
1578         the current set of core builders.
1579
1580 2011-03-14  Adam Roben  <aroben@apple.com>
1581
1582         Add forgotten file from r81116
1583
1584         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
1585
1586 2011-03-14  Sam Weinig  <sam@webkit.org>
1587
1588         Reviewed by Adam Roben.
1589
1590         about:blank fake responses don't get serialized when sent the UIProcess
1591         <rdar://problem/9108119>
1592         https://bugs.webkit.org/show_bug.cgi?id=56357
1593
1594         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
1595         (TestWebKitAPI::decidePolicyForResponse):
1596         (TestWebKitAPI::TEST):
1597         Add test that loads of about:blank have a response with a MIMEType of text/html.
1598
1599         * TestWebKitAPI/PlatformUtilities.h:
1600         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1601         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1602         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1603         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1604         Add helper to get the MIMEType from a WKURLResponse.
1605
1606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1607         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1608         Add new files.
1609
1610 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
1611
1612         Reviewed by Kenneth Rohde Christiansen.
1613
1614         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
1615         https://bugs.webkit.org/show_bug.cgi?id=56006
1616
1617         * QtTestBrowser/launcherwindow.cpp:
1618         (LauncherWindow::initializeView):
1619         * QtTestBrowser/main.cpp:
1620         (LauncherApplication::handleUserOptions):
1621
1622 2011-03-14  James Kozianski  <koz@chromium.org>
1623
1624         Reviewed by Ojan Vafai.
1625
1626         Add method to make BuildBot return test outputs
1627         https://bugs.webkit.org/show_bug.cgi?id=54374
1628
1629         The Builder.latest_cached_build will be used by the new rebaseline
1630         script to determine the build to use baselines from.
1631
1632         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1633         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1634
1635 2011-03-14  Adam Roben  <aroben@apple.com>
1636
1637         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
1638
1639         Reviewed by Sam Weinig.
1640
1641         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
1642         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
1643         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
1644         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
1645         ensure the web process is initialized, then ask the bundle to run the test and assert that
1646         it succeeded.
1647
1648         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
1649         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
1650         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
1651         handle a given URL.
1652         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
1653         URL type cannot be handled).
1654         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
1655         result.
1656
1657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1658         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1659         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1660         Added new files to the project.
1661
1662 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1663
1664         Unreviewed, rolling out r81094.
1665         http://trac.webkit.org/changeset/81094
1666         https://bugs.webkit.org/show_bug.cgi?id=56355
1667
1668         Broke the chromium DRT related build. (Requested by dave_levin
1669         on #webkit).
1670
1671         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1672         (main):
1673         * DumpRenderTree/chromium/LayoutTestController.cpp:
1674         (LayoutTestController::LayoutTestController):
1675         (LayoutTestController::layerTreeAsText):
1676         * DumpRenderTree/chromium/LayoutTestController.h:
1677         * DumpRenderTree/chromium/TestShell.cpp:
1678         (TestShell::runFileTest):
1679         (TestShell::dump):
1680         * DumpRenderTree/chromium/TestShell.h:
1681         (TestParams::TestParams):
1682
1683 2011-03-14  Daniel Sievers  <sievers@google.com>
1684
1685         Reviewed by Simon Fraser.
1686
1687         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1688         https://bugs.webkit.org/show_bug.cgi?id=56139
1689
1690         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1691         (main):
1692         * DumpRenderTree/chromium/LayoutTestController.cpp:
1693         (LayoutTestController::LayoutTestController):
1694         (LayoutTestController::layerTreeAsText):
1695         * DumpRenderTree/chromium/LayoutTestController.h:
1696         (LayoutTestController::setShowDebugLayerTree):
1697         * DumpRenderTree/chromium/TestShell.cpp:
1698         (TestShell::runFileTest):
1699         (TestShell::dump):
1700         * DumpRenderTree/chromium/TestShell.h:
1701         (TestParams::TestParams):
1702
1703 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1704
1705         Reviewed by Adam Roben.
1706
1707         [Qt][WK2]Unbreak InjectedBundle on Qt
1708         https://bugs.webkit.org/show_bug.cgi?id=54109
1709
1710         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1711         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
1712         API's instead of KURL to analyze the URL.
1713         * WebKitTestRunner/StringFunctions.h:
1714         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
1715         in the WebKitTestRunner project.
1716         (WTR::toWK): Use adoptWK.
1717         (WTR::operator<<): Added helper for printing a WKURL.
1718         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
1719         against WebCore.
1720
1721 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1722
1723         Reviewed by Kenneth Rohde Christiansen.
1724
1725         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
1726         https://bugs.webkit.org/show_bug.cgi?id=56321
1727
1728         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
1729         to the list of exceptions for WebKit2 C API headers.
1730
1731 2011-03-14  Adam Roben  <aroben@apple.com>
1732
1733         Show the list of recent leaky builds in reverse chronological order
1734
1735         Previously they were being shown in a deterministic but surprising order based on
1736         lexicographically sorting the build offsets (-1, -10, -2, -3...).
1737
1738         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
1739
1740         Reviewed by Darin Adler.
1741
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1743         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
1744         callback.
1745
1746 2011-03-14  Adam Roben  <aroben@apple.com>
1747
1748         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
1749
1750         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
1751         analyze
1752
1753         Reviewed by David Kilzer and Joe Pecoraro.
1754
1755         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1756         (#url-prompt): Made this a bit taller to make room for the list of builds.
1757
1758         (#recent-builds-loading-indicator):
1759         (#recent-builds-list):
1760         Added styles for the build list and loading indicator.
1761
1762         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1763         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
1764         it. This will unescape it.
1765         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
1766         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
1767         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
1768         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
1769         prompt UI.
1770         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
1771         now also used when a recent build is clicked.
1772
1773         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
1774         (RecentBuildsLoader): Store the callback.
1775         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
1776         builder. Find the revision number, leak count, and results URL for each one. Pass the
1777         resulting info to our callback.
1778
1779         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1780         (range): Added this helper function to return an array containing the integers [0, n).
1781
1782         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
1783         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
1784
1785 2011-03-14  Mark Rowe  <mrowe@apple.com>
1786
1787         Reviewed by Adam Roben.
1788
1789         Fix two memory leaks within LayoutTestController's storage support.
1790
1791         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1792         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
1793         by JSStringCreateWithCFString.
1794         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
1795         allocate.
1796
1797 2011-03-14  Mark Rowe  <mrowe@apple.com>
1798
1799         Reviewed by Oliver Hunt.
1800
1801         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
1802
1803         * DumpRenderTree/LayoutTestController.cpp:
1804         (LayoutTestController::staticFunctions): Remove duplicate entries.
1805
1806 2011-03-14  Alice Liu  <alice.liu@apple.com>
1807
1808         Reviewed by Dan Bernstein.
1809
1810         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
1811
1812         * DumpRenderTree/mac/PerlSupport/Makefile:
1813         Add whitespace when joining "-arch" with the architectures passed in as arguments.
1814
1815 2011-03-14  Daniel Bates  <dbates@rim.com>
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=55438
1818         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
1819         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
1820
1821         * Scripts/build-webkit:
1822
1823 2011-03-14  Daniel Bates  <dbates@rim.com>
1824
1825         Reviewed by David Kilzer.
1826
1827         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
1828         https://bugs.webkit.org/show_bug.cgi?id=55438
1829
1830         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
1831         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
1832         CMake arguments for feature defines.
1833
1834         * Scripts/build-webkit:
1835           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
1836           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
1837           - Sorted forward declarations.
1838           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
1839             Modified call sites as needed.
1840         * Scripts/webkitdirs.pm:
1841           - Added cleanCMakeGeneratedProject() to clean a CMake build.
1842           - Added buildCMakeGeneratedProject() to build using generated build system.
1843           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
1844           - Added generateBuildSystemFromCMakeProject() to generate the build system from
1845             a CMake project.
1846           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
1847
1848 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
1849
1850         Reviewed by Steve Block.
1851
1852         Detach Geolocation from Frame when Page destroyed.
1853         https://bugs.webkit.org/show_bug.cgi?id=52877
1854
1855         Extend the layout test controller to expose the number of pending
1856         geolocation requests, so that we can test that the requests have
1857         been cancelled on page close.
1858
1859         * DumpRenderTree/LayoutTestController.cpp:
1860         (numberOfPendingGeolocationPermissionRequestsCallback):
1861         (LayoutTestController::staticFunctions):
1862         * DumpRenderTree/LayoutTestController.h:
1863         * DumpRenderTree/chromium/LayoutTestController.cpp:
1864         (LayoutTestController::LayoutTestController):
1865         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1866         * DumpRenderTree/chromium/LayoutTestController.h:
1867         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1868         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1869         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1870         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1871         * DumpRenderTree/mac/UIDelegate.h:
1872         * DumpRenderTree/mac/UIDelegate.mm:
1873         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1874         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1875         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1876         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1877         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1878         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1879         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1880         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1881
1882
1883 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1884
1885         Unreviewed. Modify my email address in committers.py.
1886
1887         * Scripts/webkitpy/common/config/committers.py:
1888
1889 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
1890
1891         Reviewed by Kenneth Rohde Christiansen.
1892
1893         [Qt] QtLauncher does not load the same set of fonts as the DRT
1894         https://bugs.webkit.org/show_bug.cgi?id=34959
1895
1896         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
1897         When this option is used the webkit fonts are loaded the same
1898         as they are in DumpRenderTree.  This option can be used on
1899         QtTestBrowser and run-launcher.  It can only be used
1900         on Linux systems with FcInit and is configured as such.
1901
1902         * QtTestBrowser/launcherwindow.h:
1903         (WindowOptions::WindowOptions):
1904         * QtTestBrowser/main.cpp:
1905         (initWebKitTestFonts):
1906         (launcherMain):
1907         (LauncherApplication::handleUserOptions):
1908
1909 2011-03-12  Dan Bernstein  <mitz@apple.com>
1910
1911         Reviewed by Mark Rowe.
1912
1913         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
1914         DumpRenderTree is being built for.
1915
1916         * DumpRenderTree/mac/PerlSupport/Makefile:
1917
1918 2011-03-12  Dan Bernstein  <mitz@apple.com>
1919
1920         Suggested by Mark Rowe.
1921
1922         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
1923         as they were before r80915.
1924
1925 2011-03-12  Anders Carlsson  <andersca@apple.com>
1926
1927         Reviewed by Sam Weinig.
1928
1929         Should be able to download a PDF to the Downloads folder
1930         https://bugs.webkit.org/show_bug.cgi?id=56256
1931
1932         * MiniBrowser/mac/BrowserWindowController.m:
1933         (-[BrowserWindowController awakeFromNib]):
1934         * WebKitTestRunner/TestController.cpp:
1935         (WTR::TestController::createOtherPage):
1936         (WTR::TestController::initialize):
1937         Update for API changes.
1938
1939 2011-03-11  Anton D'Auria  <adauria@apple.com>
1940
1941         Reviewed and landed by Brady Eidson.
1942
1943         https://bugs.webkit.org/show_bug.cgi?id=51878
1944         Add WebKit1 API to view and delete local storage
1945
1946         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
1947
1948         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1949         * DumpRenderTree/LayoutTestController.cpp:
1950         (syncLocalStorageCallback):
1951         (observeStorageTrackerNotificationsCallback):
1952         (deleteAllLocalStorageCallback):
1953         (deleteLocalStorageForOriginCallback):
1954         (originsWithLocalStorageCallback):
1955         (LayoutTestController::staticFunctions):
1956         * DumpRenderTree/LayoutTestController.h:
1957         * DumpRenderTree/StorageTrackerDelegate.h: Added.
1958         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
1959         (-[StorageTrackerDelegate init]):
1960         (-[StorageTrackerDelegate logNotifications:controller:]):
1961         (-[StorageTrackerDelegate originModified:]):
1962         (-[StorageTrackerDelegate dealloc]):
1963         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
1964         * DumpRenderTree/chromium/LayoutTestController.cpp:
1965         (LayoutTestController::LayoutTestController):
1966         (LayoutTestController::deleteAllLocalStorage):
1967         (LayoutTestController::originsWithLocalStorage):
1968         (LayoutTestController::deleteLocalStorageForOrigin):
1969         (observeStorageTrackerNotifications):
1970         (syncLocalStorage):
1971         * DumpRenderTree/chromium/LayoutTestController.h:
1972         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1973         (LayoutTestController::originsWithLocalStorage):
1974         (LayoutTestController::deleteAllLocalStorage):
1975         (LayoutTestController::deleteLocalStorageForOrigin):
1976         (LayoutTestController::observeStorageTrackerNotifications):
1977         (LayoutTestController::syncLocalStorage):
1978         * DumpRenderTree/mac/DumpRenderTree.mm:
1979         (resetDefaultsToConsistentValues):
1980         (allocateGlobalControllers):
1981         (releaseGlobalControllers):
1982         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1983         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1984         (LayoutTestController::syncLocalStorage):
1985         (LayoutTestController::observeStorageTrackerNotifications):
1986         (LayoutTestController::deleteAllLocalStorage):
1987         (LayoutTestController::originsWithLocalStorage):
1988         (LayoutTestController::deleteLocalStorageForOrigin):
1989         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1990         (LayoutTestController::originsWithLocalStorage):
1991         (LayoutTestController::deleteAllLocalStorage):
1992         (LayoutTestController::deleteLocalStorageForOrigin):
1993         (LayoutTestController::observeStorageTrackerNotifications):
1994         (LayoutTestController::syncLocalStorage):
1995         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1996         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1997         (LayoutTestController::clearAllApplicationCaches):
1998         (LayoutTestController::syncLocalStorage):
1999         (LayoutTestController::observeStorageTrackerNotifications):
2000         (LayoutTestController::clearAllDatabases):
2001         (LayoutTestController::deleteAllLocalStorage):
2002         (LayoutTestController::originsWithLocalStorage):
2003         (LayoutTestController::deleteLocalStorageForOrigin):
2004         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2005         (LayoutTestController::syncLocalStorage):
2006         (LayoutTestController::observeStorageTrackerNotifications):
2007         (LayoutTestController::clearAllDatabases):
2008         (LayoutTestController::deleteAllLocalStorage):
2009         (LayoutTestController::originsWithLocalStorage):
2010         (LayoutTestController::deleteLocalStorageForOrigin):
2011
2012 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2013
2014         Reviewed by Adam Roben.
2015
2016         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2017         Process has finished launching.
2018         https://bugs.webkit.org/show_bug.cgi?id=56208
2019
2020         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2021         (TestWebKitAPI::TEST):
2022         Test that calling WKContextClearResourceCaches works with both options when called before
2023         the Web Process is valid.
2024
2025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2026         Add the new test.
2027         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2028         Ditto.
2029
2030 2011-03-11  Adam Roben  <aroben@apple.com>
2031
2032         Make it possible to view all leaks from a build at once in Leaks Viewer
2033
2034         You can now give Leaks Viewer the URL of a build results page (e.g.,
2035         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2036         will load all the leaks files from that build.
2037
2038         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2039         files from a particular build at once, rather than one at a time
2040
2041         Reviewed by David Kilzer.
2042
2043         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2044         (LeaksLoader): Initialize our properties.
2045         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2046         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2047         from that page.
2048         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2049         so it can provide feedback. Then load each one and pass it to the client.
2050         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2051         it into a DOM, pull out all the links to leaks files, and load each one.
2052
2053         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2054         (LeaksParser): Initialize our worker.
2055         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2056
2057         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2058         This code mostly came from Worker.js.
2059         (LeaksParserWorker): Initialize our profile.
2060         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2061         profile.
2062         (LeaksParserWorker.prototype._parseLeaks):
2063         (LeaksParserWorker.prototype._createNode):
2064         (LeaksParserWorker.prototype._incorporateLeaks):
2065         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2066         version of createProfile which adds to this.profile instead of making a new profile each
2067         time.
2068         (onmessage): Parse the file and send back the new profile.
2069
2070         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2071         (#loading-indicator):
2072         (#spinner):
2073         (#loading-indicator-label):
2074         Tweaked styles to accomodate a longer label.
2075
2076         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2077         (LeaksViewer.loaded): Set up a loader and parser.
2078
2079         (LeaksViewer.get filesLeftToParse):
2080         (LeaksViewer.set filesLeftToParse):
2081         Added these simple accessors.
2082
2083         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2084         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2085         the parser.
2086         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2087         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2088         _loadLeaksFromURL function).
2089         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2090         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2091         loading indicator, including the number of files being loaded.
2092         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2093         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2094         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2095         _loadingIndicatorText.
2096
2097         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2098         (getResource): Moved here from LeaksViewer.js.
2099
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2101         LeaksParserWorker.js.
2102
2103         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2104         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2105
2106 2011-03-11  Adam Roben  <aroben@apple.com>
2107
2108         Don't trigger a build when build.webkit.org's HTML files are modified
2109
2110         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2111
2112         Reviewed by Dan Bernstein.
2113
2114         * Scripts/webkitpy/common/config/build.py:
2115         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2116         directories that shouldn't trigger builds. Re-sorted the list.
2117
2118         * Scripts/webkitpy/common/config/build_unittest.py:
2119         (ShouldBuildTest): Added a test to cover the above change.
2120
2121 2011-03-11  Adam Roben  <aroben@apple.com>
2122
2123         Roll out r80848
2124
2125         It was accidentally committed.
2126
2127         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2128         (LeaksViewer._loadLeaksFromURL):
2129
2130 2011-03-11  Tony Chang  <tony@chromium.org>
2131
2132         Reviewed by Ojan Vafai.
2133
2134         kill hung lighttpd processes on the chromium win bot
2135         https://bugs.webkit.org/show_bug.cgi?id=56152
2136
2137         Sometimes this process doesn't exit and it holds on to
2138         a log file that we can't delete or copy, causing the tests
2139         to go red.
2140
2141         * BuildSlaveSupport/win/kill-old-processes:
2142
2143 2011-03-11  Ilya Sherman  <isherman@chromium.org>
2144
2145         Reviewed by Kent Tamura.
2146
2147         [Chromium] missing HTMLInputElement::setValueForUser() to tests
2148         https://bugs.webkit.org/show_bug.cgi?id=55854
2149
2150         * DumpRenderTree/chromium/LayoutTestController.cpp:
2151         (LayoutTestController::LayoutTestController):
2152         (LayoutTestController::setValueForUser): Added.
2153         * DumpRenderTree/chromium/LayoutTestController.h:
2154
2155 2011-03-10  Peter Kasting  <pkasting@google.com>
2156
2157         Reviewed by Dimitri Glazkov.
2158
2159         Clean up some gross code in TestShellWin.cpp.  No functional change.
2160         https://bugs.webkit.org/show_bug.cgi?id=56048
2161
2162         * DumpRenderTree/chromium/TestShellWin.cpp:
2163         (checkLayoutTestSystemDependencies):
2164
2165 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
2166
2167         Reviewed by Laszlo Gombos.
2168
2169         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
2170
2171         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2172         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
2173
2174 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2175
2176         Reviewed by Kenneth Rohde Christiansen.
2177
2178         [EFL] Make single backing store the default for EWebLauncher
2179         https://bugs.webkit.org/show_bug.cgi?id=55753
2180
2181         Set single backing store the default for EWebLauncher.
2182
2183         * EWebLauncher/main.c:
2184         (main):
2185
2186 2011-03-10  Adam Roben  <aroben@apple.com>
2187
2188         Ignore errors from files being held open when creating a test result archive
2189
2190         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
2191         fails to delete the results directory
2192
2193         Reviewed by Mark Rowe.
2194
2195         * BuildSlaveSupport/test-result-archive:
2196         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
2197         thrown when a process is holding a file open.
2198
2199 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2200
2201         Unreviewed, rolling out r80701.
2202         http://trac.webkit.org/changeset/80701
2203         https://bugs.webkit.org/show_bug.cgi?id=56126
2204
2205         fast/dom/Geolocation/window-close-crash.html fails on Snow
2206         Leopard release builds (Requested by mihaip on #webkit).
2207
2208         * DumpRenderTree/LayoutTestController.cpp:
2209         (LayoutTestController::staticFunctions):
2210         * DumpRenderTree/LayoutTestController.h:
2211         * DumpRenderTree/chromium/LayoutTestController.cpp:
2212         (LayoutTestController::LayoutTestController):
2213         * DumpRenderTree/chromium/LayoutTestController.h:
2214         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2215         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2216         * DumpRenderTree/mac/UIDelegate.h:
2217         * DumpRenderTree/mac/UIDelegate.mm:
2218         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2219         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2220         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2221         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2222
2223 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2224
2225         Reviewed by Gustavo Noronha Silva.
2226
2227         [GTK] run-gtk-tests doesn't fail if a test crashes
2228         https://bugs.webkit.org/show_bug.cgi?id=56089
2229
2230         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
2231         even if a test crashes. So run the tests individually and if a
2232         test fails remember its exit code so run-gtk-test fails too, if
2233         required.
2234
2235 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2236
2237         Reviewed by Dmitry Titov.
2238
2239         Detach Geolocation from Frame when Page destroyed.
2240         https://bugs.webkit.org/show_bug.cgi?id=52877
2241
2242         Extend the layout test controller to expose the number of pending
2243         geolocation requests, so that we can test that the requests have
2244         been cancelled on page close.
2245
2246         * DumpRenderTree/LayoutTestController.cpp:
2247         (numberOfPendingGeolocationPermissionRequestsCallback):
2248         (LayoutTestController::staticFunctions):
2249         * DumpRenderTree/LayoutTestController.h:
2250         * DumpRenderTree/chromium/LayoutTestController.cpp:
2251         (LayoutTestController::LayoutTestController):
2252         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2253         * DumpRenderTree/chromium/LayoutTestController.h:
2254         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2255         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2256         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2257         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2258         * DumpRenderTree/mac/UIDelegate.h:
2259         * DumpRenderTree/mac/UIDelegate.mm:
2260         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2261         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2262         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2263         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2264         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2265         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2266         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2267         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2268
2269
2270 2011-03-09  Adam Roben  <aroben@apple.com>
2271
2272         Hide Leaks Viewer's URL prompt by default
2273
2274         We will show it as needed. I think I left it visible by default by accident after doing some
2275         testing.
2276
2277         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
2278         URL is passed as a query parameter, but does
2279
2280         Reviewed by Simon Fraser.
2281
2282         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2283
2284 2011-03-09  Adam Roben  <aroben@apple.com>
2285
2286         Don't use Element.classList or box-shadow in Leaks Viewer
2287
2288         They aren't supported by Safari 5. Luckily we have substitutes for them!
2289
2290         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
2291
2292         Reviewed by Simon Fraser.
2293
2294         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2295         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
2296
2297         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2298         (LeaksViewer.urlPromptButtonClicked):
2299         (LeaksViewer._displayURLPrompt):
2300         (LeaksViewer._setLoadingIndicatorHidden):
2301         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
2302
2303 2011-03-09  Adam Roben  <aroben@apple.com>
2304
2305         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
2306
2307         Rubber-stamped by David Kilzer.
2308
2309         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2310
2311 2011-03-09  Adam Roben  <aroben@apple.com>
2312
2313         Add a Leaks Viewer tool to build.webkit.org
2314
2315         This tool parses leaks from the files generated by the leaks bot and displays them in a
2316         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2317         code).
2318
2319         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2320         be passed to the tool via the "url" query parameter.
2321
2322         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2323         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2324         Inspector's Heavy profile view. But it's still pretty useful as-is.
2325
2326         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2327
2328         Reviewed by Darin Adler.
2329
2330         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2331         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2332         (#url-prompt): This is the prompt itself.
2333
2334         (#loading-indicator):
2335         (#loading-indicator > img):
2336         These show a spinner in the bottom-right when we're loading a leaks file.
2337
2338         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2339         as percentages.
2340
2341         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2342         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2343         URL if one wasn't given to us as a query parameter).
2344
2345         (LeaksViewer.get loading):
2346         (LeaksViewer.set loading):
2347         (LeaksViewer.get url):
2348         (LeaksViewer.set url):
2349         Pretty simple accessors.
2350
2351         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2352         prompt.
2353         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2354         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2355         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2356         the profile to the Web Inspector code once it's been created.
2357         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2358         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2359         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2360         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2361
2362         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
2363         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
2364         (ProfilerAgent.getProfile): Store the callback.
2365         (ProfilerAgent.profileReady): Call the callback.
2366         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
2367         count and total leak counts as real values, not percentages or milliseconds.
2368
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
2370         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
2371         (parseLeaks): Extract call stacks out of a leaks file.
2372         (createNode): Helper function to create a new empty profile node.
2373         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
2374         WebInspector.ProfileView.
2375
2376         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
2377
2378 2011-03-09  Dan Bernstein  <mitz@apple.com>
2379
2380         Reviewed by Adam Roben.
2381
2382         Combine multiple --ignore-tests values
2383         https://bugs.webkit.org/show_bug.cgi?id=56016
2384
2385         * Scripts/old-run-webkit-tests:
2386
2387 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
2388
2389         Reviewed by David Levin.
2390
2391         Adding myself to the committer file.
2392
2393         * Scripts/webkitpy/common/config/committers.py:
2394
2395 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2396
2397         Rubber-stamped by Adam Roben.
2398
2399         Fix two leaks I introduced into the API tests.
2400
2401         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2402         (TestWebKitAPI::TEST):
2403
2404 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2405
2406         Reviewed by Anders Carlsson.
2407
2408         Crash in CFNetwork visiting google.com
2409         https://bugs.webkit.org/show_bug.cgi?id=55958
2410
2411         Add a test for not trying to copy a null CFURLResponse.
2412
2413         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
2414         (TestWebKitAPI::TEST):
2415         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2416
2417 2011-03-08  Hayato Ito  <hayato@chromium.org>
2418
2419         Reviewed by Ojan Vafai.
2420
2421         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
2422
2423         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
2424
2425         https://bugs.webkit.org/show_bug.cgi?id=55450
2426
2427         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2428
2429 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2430
2431         Reviewed by Martin Robinson.
2432
2433         [GTK] Add layoutTestController.setValueForUser() after r80412
2434         https://bugs.webkit.org/show_bug.cgi?id=55862
2435
2436         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2437         (LayoutTestController::setValueForUser): Implement setValueForUser()
2438
2439 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
2440
2441         Reviewed by Adam Barth.
2442
2443         Add script_shell_command to WebKitPort
2444         https://bugs.webkit.org/show_bug.cgi?id=55925
2445
2446         Add a central place where we generate the shell command from the script name.
2447         This function will be used later to detect the correct script interpreter on Win32.
2448
2449         * Scripts/webkitpy/common/config/ports.py:
2450         * Scripts/webkitpy/layout_tests/port/base.py:
2451         * Scripts/webkitpy/tool/steps/abstractstep.py:
2452         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2453
2454 2011-03-07  Ojan Vafai  <ojan@chromium.org>
2455
2456         Reviewed by Adam Barth.
2457
2458         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
2459         https://bugs.webkit.org/show_bug.cgi?id=55749
2460
2461         * Scripts/webkitpy/tool/commands/upload.py:
2462         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2463         * Scripts/webkitpy/tool/steps/__init__.py:
2464         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
2465         * Scripts/webkitpy/tool/steps/options.py:
2466
2467 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
2468
2469         Reviewed by David Levin.
2470
2471         Add support for DataTransferItems
2472         https://bugs.webkit.org/show_bug.cgi?id=55115
2473
2474         Enable data transfer items in DRT.
2475
2476         * DumpRenderTree/chromium/TestShell.cpp:
2477         (TestShell::TestShell):
2478
2479 2011-03-06  Ojan Vafai  <ojan@chromium.org>
2480
2481         Reviewed by Tony Chang.
2482
2483         [test dashboard] pull treemap files
2484         https://bugs.webkit.org/show_bug.cgi?id=55852
2485
2486         * TestResultServer/handlers/dashboardhandler.py:
2487
2488 2011-03-03  Hayato Ito  <hayato@chromium.org>
2489
2490         Reviewed by Mihai Parparita.
2491
2492         [NRWT] Clear output image file used by DumpRenderTree to make sure the
2493         previous image should not be used in the ChromiumDriver.
2494
2495         Also make sure that output image from the ChromiumDriver should be ''
2496         (empty string) if a test crashes for consistency with the WebKitDriver
2497         implementation.
2498
2499         https://bugs.webkit.org/show_bug.cgi?id=55746
2500
2501         * Scripts/webkitpy/layout_tests/port/chromium.py:
2502
2503 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
2504
2505         Reviewed by Martin Robinson.
2506
2507         [Gtk] fast/js/navigator-language.html fails locally
2508         https://bugs.webkit.org/show_bug.cgi?id=55880
2509
2510         Add LANG variable to the clean environment when running
2511         old-run-webkit-tests script.
2512
2513         * Scripts/old-run-webkit-tests:
2514
2515 2011-03-07  Tony Chang  <tony@chromium.org>
2516
2517         Reviewed by Mihai Parparita.
2518
2519         [Chromium] Find .checksum files without .pngs and vice-versa
2520         https://bugs.webkit.org/show_bug.cgi?id=55236
2521
2522         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
2523             mismatched results.
2524
2525 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2526
2527         Reviewed by Beth Dakin.
2528
2529         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
2530         https://bugs.webkit.org/show_bug.cgi?id=55706
2531
2532         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
2533
2534         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2535         (AccessibilityController::focusedElement):
2536            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
2537            because it could change at any time.
2538         (AccessibilityController::rootElement):
2539
2540 2011-03-07  Sam Weinig  <sam@webkit.org>
2541
2542         Reviewed by Anders Carlsson.
2543
2544         Add unableToImplementPolicy callback for WebKit2 policy client
2545         <rdar://problem/9071902>
2546         https://bugs.webkit.org/show_bug.cgi?id=55884
2547
2548         * MiniBrowser/mac/BrowserWindowController.m:
2549         (-[BrowserWindowController awakeFromNib]):
2550         Update policy client initialization struct for new member.
2551
2552 2011-03-07  Sam Weinig  <sam@webkit.org>
2553
2554         Reviewed by Anders Carlsson.
2555
2556         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2557         https://bugs.webkit.org/show_bug.cgi?id=55827
2558
2559         * MiniBrowser/mac/BrowserWindowController.m:
2560         (decidePolicyForResponse):
2561         (-[BrowserWindowController awakeFromNib]):
2562         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2563         (TestWebKitAPI::decidePolicyForResponse):
2564         (TestWebKitAPI::TEST):
2565         Update tools for new name.
2566
2567 2011-03-06  Daniel Bates  <dbates@rim.com>
2568
2569         Reviewed by Eric Seidel and David Kilzer.
2570
2571         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
2572         https://bugs.webkit.org/show_bug.cgi?id=55503
2573
2574         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
2575         in checkForJavaSDK().
2576
2577         Also, remove extraneous space in function prototype for unlinkZeroFiles.
2578
2579         * Scripts/build-webkit:
2580
2581 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
2582
2583         Reviewed by Sam Weinig.
2584
2585         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
2586
2587         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2588         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
2589             by willSendRequestForFrame. The API expects a retained reference to the URL request.
2590
2591 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2592
2593         Reviewed by Darin Adler.
2594
2595         HTMLInputElement::setValue() should schedule change event when the element is focused
2596         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2597         https://bugs.webkit.org/show_bug.cgi?id=53160
2598
2599         * DumpRenderTree/LayoutTestController.cpp:
2600         (setValueForUserCallback):
2601         (LayoutTestController::staticFunctions):
2602         * DumpRenderTree/LayoutTestController.h:
2603         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2604         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2605         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2606         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
2607         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2608         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2609         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2610         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2611         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2612         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2613
2614 2011-03-04  Mark Rowe  <mrowe@apple.com>
2615
2616         Reviewed by Alexey Proskuryakov.
2617
2618         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
2619
2620         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
2621         
2622         * DumpRenderTree/mac/CheckedMalloc.cpp:
2623         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
2624         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
2625         and then restore the initial protection flags when we're done.
2626
2627 2011-03-04  Evan Martin  <evan@chromium.org>
2628
2629         Reviewed by Tony Chang.
2630
2631         [gdb] pretty-print KURL in gdb
2632         https://bugs.webkit.org/show_bug.cgi?id=55788
2633
2634         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
2635         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
2636         pretty-printing.
2637
2638 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2639
2640         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
2641
2642         Reviewed by Darin Adler.
2643
2644         * TestWebKitAPI/JavaScriptTest.cpp:
2645         (TestWebKitAPI::javaScriptCallback):
2646         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2647         (TestWebKitAPI::didRunJavaScript):
2648         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2649         (TestWebKitAPI::nullJavaScriptCallback):
2650         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2651         (TestWebKitAPI::didRunJavaScript):
2652
2653 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2654
2655         Make run-api-tests show failed if a test fails.
2656
2657         https://webkit.org/b/55725
2658
2659         Reviewed by Sam Weinig.
2660
2661         * Scripts/run-api-tests:
2662         (runTest): Remove "my" from the nested $result assignment so the
2663         check outside the condition sees the real result.
2664
2665 2011-03-02  MORITA Hajime  <morrita@google.com>
2666
2667         Reviewed by Kent Tamura.
2668
2669         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
2670         https://bugs.webkit.org/show_bug.cgi?id=55434
2671
2672         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
2673         and passed the object webkit_support::PostDelayedTask directly.
2674
2675         Note that the change keeps postTask() as is because it has a
2676         semantics taht webkit_support::PostDelayedTask() has; It jumps to
2677         the main thread.
2678
2679         * DumpRenderTree/chromium/Task.cpp:
2680         (postDelayedTask):
2681         * DumpRenderTree/chromium/Task.h:
2682         (WebTask::Run):
2683
2684 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2685
2686         Reviewed by Kenneth Rohde Christiansen.
2687
2688         [QT] Implement mock client-based geolocation for layout testing
2689         https://bugs.webkit.org/show_bug.cgi?id=54334
2690
2691         Implement testing for Client-Based geolocation for QtWebkit.
2692
2693         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2694         (WebCore::DumpRenderTree::DumpRenderTree):
2695         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2696         (LayoutTestController::reset):
2697         (LayoutTestController::setGeolocationPermission):
2698         (LayoutTestController::setMockGeolocationError):
2699         (LayoutTestController::setMockGeolocationPosition):
2700
2701 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2702
2703         Unreviewed, rolling out r80237.
2704         http://trac.webkit.org/changeset/80237
2705         https://bugs.webkit.org/show_bug.cgi?id=55714
2706
2707         Windows bots aren't ready to be core (Requested by aroben on
2708         #webkit).
2709
2710         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2711         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2712
2713 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
2714
2715         Reviewed by Tony Chang.
2716
2717         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
2718         https://bugs.webkit.org/show_bug.cgi?id=55694
2719         
2720         Fixes for interruptions in NRWT:
2721         - Make TestRunInterruptedException be pickleable correctly (the base
2722           Exception class defines a __reduce__ that does not include the reason)
2723         - Fix ordering of returned arguments from TestRunner2._run_tests
2724           (interrupted and keyboard_interrupted were reversed)
2725         - Fix cancel_workers callsites (was using old name).
2726         - In handle_exception re-raise actual exception instance that was thrown
2727
2728         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2729         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2730         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2731         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2732
2733 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
2734
2735         Unreviewed.
2736
2737         Adding myself as a committer.
2738
2739         * Scripts/webkitpy/common/config/committers.py:
2740
2741 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
2742
2743         Reviewed by Mihai Parparita.
2744
2745         Teach sheriffbot to answer whois commands
2746         https://bugs.webkit.org/show_bug.cgi?id=55687
2747
2748         * Scripts/webkitpy/tool/bot/irc_command.py:
2749         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2750         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2751
2752 2011-03-03  Victoria Kirst  <vrk@google.com>
2753
2754         Reviewed by Eric Carlson.
2755
2756         Enable media tests in chromium-gpu/test_expectations
2757         https://bugs.webkit.org/show_bug.cgi?id=53608
2758
2759         Add media folder to the list of GPU test paths.
2760
2761         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2762
2763 2011-03-03  Adam Roben  <aroben@apple.com>
2764
2765         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
2766
2767         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
2768         incorrect parsing of absolute Windows-style file: URLs
2769
2770         Reviewed by Tim Hatcher.
2771
2772         * WebKitTestRunner/TestInvocation.cpp:
2773         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
2774         <http://webkit.org/b/55683>.
2775
2776 2011-03-03  Tony Chang  <tony@chromium.org>
2777
2778         Reviewed by Dimitri Glazkov.
2779
2780         [chromium] Run kill-old-processes on the chromium-win bot too
2781         https://bugs.webkit.org/show_bug.cgi?id=55630
2782
2783         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2784         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
2785
2786 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2787
2788         Reviewed by Martin Robinson.
2789
2790         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
2791         https://bugs.webkit.org/show_bug.cgi?id=53960
2792
2793         * DumpRenderTree/gtk/EventSender.cpp:
2794         (sendClick):
2795         (scheduleAsynchronousClickCallback):
2796
2797 2011-03-03  Adam Roben  <aroben@apple.com>
2798
2799         Look for Windows-style paths when checking whether a test is an Inspector test
2800
2801         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
2802         out or crash on Windows 7 Release (WebKit2 Tests)
2803
2804         Reviewed by Darin Adler.
2805
2806         * WebKitTestRunner/TestInvocation.cpp:
2807         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
2808         Windows.
2809
2810 2011-03-03  Adam Roben  <aroben@apple.com>
2811
2812         Make Windows 7 Release (Tests) a core builder
2813
2814         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2815         give it a few more days of greenness first.
2816
2817         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2818
2819         Reviewed by Andreas Kling.
2820
2821         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2822         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2823
2824         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2825         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2826         Updated the core regexps to match the buildbot module. Updated the expected results to match
2827         the current set of core builders.
2828
2829 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
2830
2831         Reviewed by Andreas Kling.
2832
2833         Adding myself as a reviewer.
2834
2835         * Scripts/webkitpy/common/config/committers.py:
2836
2837 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
2838
2839         Reviewed by Xan Lopez.
2840
2841         [GTK] Extended application cache database API and added unit tests file.
2842         https://bugs.webkit.org/show_bug.cgi?id=55335
2843
2844         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
2845         of webkit_application_cache_set_maximum_size due to API exposal.
2846
2847 2011-03-02  Ojan Vafai  <ojan@chromium.org>
2848
2849         Reviewed by Adam Barth.
2850
2851         make webkit-patch upload work for security bugs
2852         https://bugs.webkit.org/show_bug.cgi?id=55655
2853
2854         The problem is that we shell out to prepare-ChangeLog,
2855         which does not authenticate with bugzilla. All it needs from
2856         bugzilla is the bug title though. We just pass it through from
2857         webkit-patch instead.
2858
2859         * Scripts/prepare-ChangeLog:
2860         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2861         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2862
2863 2011-03-01  Ojan Vafai  <ojan@chromium.org>
2864
2865         Reviewed by Tony Chang.
2866
2867         [test-dashboard] make gtest JSON match layout-tests JSON
2868         https://bugs.webkit.org/show_bug.cgi?id=55556
2869
2870         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
2871         Make this code match.
2872
2873         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2874
2875 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
2876
2877         Reviewed by Tony Chang.
2878
2879         NRWT - implement Linux Hardy 64-bit port support. This involves
2880         adding support for non-'x86' architectures and updating the
2881         "deduplicate_tests" script to correctly understand that
2882         port.name() is not always equal to basename(port.baseline_path()).
2883
2884         This change introduces two new port names: 'chromium-linux-x86'
2885         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
2886         flag will cause the code to determine which one to use at
2887         runtime, just like we currently do with 'chromium-win'.
2888
2889         https://bugs.webkit.org/show_bug.cgi?id=55535
2890
2891         * Scripts/webkitpy/common/system/executive_mock.py:
2892           Handle 'return_stderr' keyword arg to run_command()
2893         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2894         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2895         * Scripts/webkitpy/layout_tests/port/base.py:
2896         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2897         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2898         * Scripts/webkitpy/layout_tests/port/factory.py:
2899         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2900
2901 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
2902
2903         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
2904         update symlinks accordingly.
2905
2906         * wx/packaging/build-mac-installer.py:
2907
2908 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2909
2910         Unreviewed, rolling out r80139.
2911         http://trac.webkit.org/changeset/80139
2912         https://bugs.webkit.org/show_bug.cgi?id=55620
2913
2914         failing and crashing tests on Snow Leopard bot (Requested by
2915         mihaip1 on #webkit).
2916
2917         * DumpRenderTree/LayoutTestController.cpp:
2918         (LayoutTestController::staticFunctions):
2919         * DumpRenderTree/LayoutTestController.h:
2920         * DumpRenderTree/chromium/LayoutTestController.cpp:
2921         (LayoutTestController::LayoutTestController):
2922         * DumpRenderTree/chromium/LayoutTestController.h:
2923         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2924         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2925         * DumpRenderTree/mac/UIDelegate.h:
2926         * DumpRenderTree/mac/UIDelegate.mm:
2927         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2928         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2929         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2930         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2931
2932 2011-03-02  Adam Roben  <aroben@apple.com>
2933
2934         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
2935
2936         This matches DumpRenderTree on Windows.
2937
2938         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
2939         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
2940         in WebKit2
2941
2942         Reviewed by Beth Dakin.
2943
2944         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2945         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
2946         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
2947
2948 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
2949
2950         Reviewed by David Levin.
2951
2952         Add feature define for data transfer items
2953         https://bugs.webkit.org/show_bug.cgi?id=55510
2954
2955         * Scripts/build-webkit:
2956
2957 2011-03-02  Adam Roben  <aroben@apple.com>
2958
2959         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
2960
2961         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
2962         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
2963         the former location, but was getting lucky on some SnowLeopard machines because symlinks
2964         were being created there pointing into DiagnosticReports. For machines without these
2965         symlinks, crash logs were not getting captured.
2966
2967         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
2968         SnowLeopard machines
2969
2970         Reviewed by Eric Seidel.
2971
2972         * Scripts/old-run-webkit-tests:
2973         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
2974
2975 2011-03-02  Adam Roben  <aroben@apple.com>
2976
2977         Don't try to capture crash logs on platforms that haven't implemented that feature
2978
2979         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
2980         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
2981
2982         Reviewed by Joseph Pecoraro.
2983
2984         * Scripts/old-run-webkit-tests:
2985         (captureSavedCrashLog): Bail if we don't have a crash log glob.
2986         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
2987         strictly required to fix bug 55504, but seems worthwhile.
2988
2989 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2990
2991         Reviewed by Dmitry Titov.
2992
2993         Detach Geolocation from Frame when Page destroyed.
2994         https://bugs.webkit.org/show_bug.cgi?id=52877
2995
2996         Extend the layout test controller to expose the number of pending
2997         geolocation requests, so that we can test that the requests have
2998         been cancelled on page close.
2999
3000         * DumpRenderTree/LayoutTestController.cpp:
3001         (numberOfPendingGeolocationPermissionRequestsCallback):
3002         (LayoutTestController::staticFunctions):
3003         * DumpRenderTree/LayoutTestController.h:
3004         * DumpRenderTree/chromium/LayoutTestController.cpp:
3005         (LayoutTestController::LayoutTestController):
3006         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3007         * DumpRenderTree/chromium/LayoutTestController.h:
3008         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3009         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3010         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3011         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3012         * DumpRenderTree/mac/UIDelegate.h:
3013         * DumpRenderTree/mac/UIDelegate.mm:
3014         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3015         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3016         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3017         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3018         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3019         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3020         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3021         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3022
3023
3024 2011-03-01  Kent Tamura  <tkent@chromium.org>
3025
3026         Reviewed by Dimitri Glazkov.
3027
3028         Assertion fails when a form validation bubble appears
3029         https://bugs.webkit.org/show_bug.cgi?id=55550
3030
3031         Test: fast/forms/interactive-validation-attach-assertion.html
3032
3033         * DumpRenderTree/chromium/WebPreferences.cpp:
3034         (WebPreferences::applyTo): Enable the interactive validation feature by
3035           default. This matches to Chromium browser.
3036
3037 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3038
3039         Reviewed by Kent Tamura.
3040
3041         Remove efl port style exception of Webcore/JavaScriptCore
3042         https://bugs.webkit.org/show_bug.cgi?id=55549
3043
3044         WebCore and JavaScriptCore need to adhere WebKit coding style.
3045
3046         * Scripts/webkitpy/style/checker.py:
3047
3048 2011-03-01  Tony Chang  <tony@chromium.org>
3049
3050         Reviewed by Ojan Vafai.
3051
3052         [chromium] clean up temp files on chromium-mac builder too
3053         https://bugs.webkit.org/show_bug.cgi?id=55525
3054
3055         * BuildSlaveSupport/chromium/remove-crash-logs:
3056
3057 2011-02-28  Ojan Vafai  <ojan@chromium.org>
3058
3059         Reviewed by Tony Chang.
3060
3061         wrap json in a function call to afford cross-domain loading
3062         https://bugs.webkit.org/show_bug.cgi?id=55353
3063
3064         Also delete the code that compacts the JSON. It turns out this
3065         breaks the rebaseline tool and is probably a premature optimization anyways.
3066
3067         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3068         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3069         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3070         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3071
3072 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3073
3074         Unreviewed, rolling out r80079.
3075         http://trac.webkit.org/changeset/80079
3076         https://bugs.webkit.org/show_bug.cgi?id=55547
3077
3078         "Broke the Win debug build?" (Requested by dcheng on #webkit).
3079
3080         * Scripts/build-webkit:
3081
3082 2011-03-01  Mark Rowe  <mrowe@apple.com>
3083
3084         Reviewed by Sam Weinig.
3085
3086         Update verification scripts to handle WebKit2.
3087
3088         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
3089         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
3090         WebKit2.
3091
3092 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
3093
3094         Reviewed by David Levin.
3095
3096         Add feature define for data transfer items
3097         https://bugs.webkit.org/show_bug.cgi?id=55510
3098
3099         * Scripts/build-webkit:
3100
3101 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3102
3103         Reviewed by Timothy Hatcher.
3104
3105         All Console Messages should be passed to ChromeClients.
3106         https://bugs.webkit.org/show_bug.cgi?id=54926
3107
3108         Update DumpRenderTree's UIDelegate to use the new console message delegate.
3109
3110         * DumpRenderTree/mac/UIDelegate.mm:
3111         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3112
3113 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3114
3115         Reviewed by Adam Barth.
3116
3117         Tragically, we stopped running the python unit tests
3118         on Chromium Win just as I was getting them to be green.
3119         This patch turns them back on.
3120
3121         https://bugs.webkit.org/show_bug.cgi?id=55521
3122
3123         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3124
3125 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3126
3127         Reviewed by Adam Roben.
3128
3129         Disable
3130         webkitpy.common.system.executive_unittest.ExecutiveTest.\
3131            test_kill_all fails on win until it can be properly triaged.
3132
3133         https://bugs.webkit.org/show_bug.cgi?id=54790
3134
3135         * Scripts/webkitpy/common/system/executive_unittest.py:
3136
3137     2011-03-01  Helder Correia  <helder@sencha.com>
3138
3139             Unreviewed. Add myself to committers.py.
3140
3141             * Scripts/webkitpy/common/config/committers.py:
3142
3143 2011-03-01  Adam Roben  <aroben@apple.com>
3144
3145         Give up if a crash log for the web process is taking too long to be saved on Windows
3146
3147         This should keep the bots from getting stuck while waiting for a crash log, if writing a
3148         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
3149
3150         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
3151         to be saved for the web process
3152
3153         Reviewed by Steve Falkenburg.
3154
3155         * WebKitTestRunner/win/TestControllerWin.cpp:
3156         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
3157         Generalized the code slightly to handle the optional object to wait on.
3158         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
3159         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
3160         prevent us from waiting forever.
3161
3162 2011-03-01  Adam Roben  <aroben@apple.com>
3163
3164         Give WebKitLauncherWin's PDB file a name different from WebKit's
3165
3166         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
3167         fighting over the same PDB file, meaning that one of them was going to lose and not have
3168         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
3169
3170         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
3171         runs (due to missing symbols)
3172
3173         Reviewed by David Kilzer.
3174
3175         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
3176         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
3177
3178 2011-03-01  Adam Roben  <aroben@apple.com>
3179
3180         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
3181
3182         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
3183         --exit-after-n-crashes-or-timeouts limit
3184
3185         Reviewed by David Kilzer.
3186
3187         * Scripts/old-run-webkit-tests:
3188         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
3189         the number of tests that caused the web process to crash when exiting early.
3190
3191 2011-03-01  Adam Roben  <aroben@apple.com>
3192
3193         Save a crash log when the web process crashes
3194
3195         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
3196         until it has finished crashing, which guarantees that the crash log will have had time to be
3197         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
3198         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
3199
3200         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
3201         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
3202
3203         Reviewed by Sam Weinig.
3204
3205         * Scripts/old-run-webkit-tests:
3206         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
3207         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
3208         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
3209         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
3210         WebProces_*.crash files when the web process crashes.
3211
3212         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3213         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
3214         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
3215         along to platformInitialize.
3216
3217         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
3218
3219         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3220         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
3221
3222         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3223         (WTR::InjectedBundle::platformInitialize):
3224         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3225         (WTR::InjectedBundle::platformInitialize):
3226         Updated function signature.
3227
3228         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3229         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
3230         webProcessCrashingEvent, then lets the crash continue as normal.
3231
3232         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
3233         event we should use to tell the UI process we're crashing from the initializationUserData,
3234         and get a handle to that event.
3235
3236         * WebKitTestRunner/TestController.cpp:
3237         (WTR::TestController::TestController): Initialize new members.
3238         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
3239         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
3240         when a crash log is being saved on Windows. Exit right away if specified. (This is the
3241         default.)
3242
3243         * WebKitTestRunner/TestController.h: Added new members.
3244
3245         * WebKitTestRunner/win/TestControllerWin.cpp:
3246         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
3247         us it's crashing.
3248         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
3249         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
3250         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
3251         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
3252         so the test harness will know the web process has crashed and not try to kill us, then wait
3253         for the web process to finish crashing so a crash log will have time to be saved.
3254         (WTR::toWK): Simple hepler function.
3255         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
3256         process should use to tell us it is crashing in the context's initialization user data.
3257
3258 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
3259
3260         Reviewed by Tony Gentilcore.
3261
3262         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
3263         https://bugs.webkit.org/show_bug.cgi?id=55476
3264
3265         Chromium Win uses BuildAndTestFactory, not TestFactory.
3266
3267         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
3268
3269 2011-03-01  Adam Roben  <aroben@apple.com>
3270
3271         Test that the WebKit2 responsiveness timer doesn't fire too early
3272
3273         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
3274         early on Windows
3275
3276         Reviewed by Anders Carlsson.
3277
3278         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
3279
3280         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
3281         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3282         (TestWebKitAPI::didFinishLoadForFrame):
3283         (TestWebKitAPI::processDidBecomeUnresponsive):
3284         (TestWebKitAPI::setInjectedBundleClient):
3285         (TestWebKitAPI::setPageLoaderClient):
3286         Simple helper functions.
3287
3288         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
3289         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
3290         the responsiveness timer to start, but the web process should unpause before it has a chance
3291         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
3292
3293         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
3294         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
3295         Call up to the base class.
3296         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
3297         pause, sleep for 0.5 seconds, then send back a message saying we paused.
3298
3299         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3300         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
3301         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3302         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
3303
3304         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3305         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3306         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3307         Added new files.
3308
3309 2011-03-01  Andras Becsi  <abecsi@webkit.org>
3310
3311         Reviewed by Csaba Osztrogonác.
3312
3313         [Qt] Clean up the project files and move common options to WebKit.pri.
3314
3315         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
3316
3317
3318 2011-03-01  Adam Roben  <aroben@apple.com>
3319
3320         Skip another multiprocessing test on Windows
3321
3322         It is sometimes failing (and may be leaving child Python processes around).
3323         <http://webkit.org/b/55087> tracks the failure.
3324
3325         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3326         (FuncitonTests.test_get__processes): Skip this test on Windows.
3327
3328 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
3329
3330         Reviewed by Pavel Feldman.
3331
3332         Web Inspector: reduce inspector tests flakiness.
3333         https://bugs.webkit.org/show_bug.cgi?id=55401
3334
3335         * DumpRenderTree/chromium/TestShell.cpp:
3336         (TestShell::runFileTest):
3337         * DumpRenderTree/chromium/WebPreferences.cpp:
3338         (WebPreferences::reset):
3339
3340 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
3341
3342         Reviewed by James Robinson.
3343
3344         NRWT should still upload results when it exits early due to too many failures
3345         https://bugs.webkit.org/show_bug.cgi?id=55432
3346         
3347         Only keyboard interrupts should prevent results from being uploaded.
3348
3349         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3350         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3351
3352 2011-02-28  Alice Liu  <alice.liu@apple.com>
3353
3354         Reviewed by Adam Roben and Gavin Barraclough.
3355
3356         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
3357         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
3358
3359         * TestWebKitAPI/InjectedBundleController.h:
3360         (TestWebKitAPI::InjectedBundleController::bundle):
3361         * TestWebKitAPI/PlatformWebView.h:
3362         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
3363         (TestWebKitAPI::didFinishLoadForFrame):
3364         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3365         (TestWebKitAPI::setPageLoaderClient):
3366         (TestWebKitAPI::TEST):
3367         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
3368         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
3369         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3370         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
3371         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3372         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3373         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3374         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3375         
3376         Added files to:
3377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3378         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3379         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3380
3381 2011-02-28  Adam Roben  <aroben@apple.com>
3382
3383         Start running InjectedBundle API tests on Windows
3384
3385         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
3386
3387         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
3388
3389         Reviewed by Darin Adler.
3390
3391         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
3392         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
3393         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
3394         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
3395         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
3396         These are just extracted from TestWebKitAPI.vcproj.
3397
3398         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
3399         up the DLL's filename.
3400
3401         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
3402         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
3403         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
3404
3405         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
3406         "all" configuration.
3407
3408         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
3409         injected bundle tests. Let VS resort things.
3410
3411         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
3412
3413 2011-02-28  Adam Roben  <aroben@apple.com>
3414
3415         Add a test for the paint rect passed via WM_PAINT to windowless plugins
3416
3417         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
3418         Large portions of pages with plugins paint black
3419
3420         Reviewed by Anders Carlsson.
3421
3422         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3423         (PluginTest::NPP_HandleEvent):
3424         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3425         Added NPP_HandleEvent. Just returns 0 at this level.
3426
3427         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
3428         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
3429         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
3430         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
3431         WM_PAINT has the expected coordinates.
3432
3433         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3434         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
3435         else.
3436
3437         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
3438         resort things.
3439
3440         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3441         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
3442         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
3443         webView:didFinishLoadForFrame:] in DumpRenderTree.
3444
3445         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3446         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
3447         can start running.
3448
3449 2011-02-28  Adam Roben  <aroben@apple.com>
3450
3451         Tell MiniBrowser's WKViews that they're in a window
3452
3453         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
3454
3455         Reviewed by Anders Carlsson.
3456
3457         * MiniBrowser/win/BrowserView.cpp:
3458         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
3459
3460 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
3461
3462         Reviewed by Csaba Osztrogonác.
3463
3464         The new QML tests require QML_IMPORT_PATH variable to be set in order to
3465         load the proper plugin.
3466
3467         * Scripts/run-qtwebkit-tests:
3468
3469 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
3470
3471         Unreviewed, fix spelling mistake.
3472
3473         hardware-accelated => hardware-accelerated.
3474
3475         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3476
3477 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
3478
3479         Reviewed by Andreas Kling.
3480
3481         Made sure that the build-webkit --qmake argument is always respected.
3482
3483         Previously, it would be respected during the build, but not during
3484         the early feature detection. The build would also fail if qmake was
3485         not in your path, even if you specified --qmake with a valid qmake
3486         binary.
3487
3488         [Qt] WebKit patches required to work with a modularized version of Qt
3489         https://bugs.webkit.org/show_bug.cgi?id=53916
3490
3491         * Scripts/build-webkit:
3492         * Scripts/webkitdirs.pm:
3493
3494 2011-02-27  Ojan Vafai  <ojan@chromium.org>
3495
3496         Fix failing tests from http://trac.webkit.org/changeset/79837.
3497
3498         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3499         This was just a mistake that would break if someone tried printing with this configuration.
3500         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3501         Method signature changed. Didn't notice that this method was being calling in a unittest.
3502
3503 2011-02-24  Hayato Ito  <hayato@chromium.org>
3504
3505         Reviewed by Eric Seidel.
3506
3507         [NRWT] Remove test_types/* classes.
3508
3509         This is the last patch in the series of efforts which tried to remove test_types classes.
3510         A single_test_runner module will take over responsibilities of test_type classes.
3511
3512         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
3513
3514         https://bugs.webkit.org/show_bug.cgi?id=55123
3515
3516         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3517         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3518         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3519         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3520         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
3521         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
3522         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
3523         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
3524         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
3525         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
3526
3527 2011-02-25  Ojan Vafai  <ojan@chromium.org>
3528
3529         Reviewed by Tony Chang.
3530
3531         Change results.json format to the one used by unexpected_results.json
3532         https://bugs.webkit.org/show_bug.cgi?id=52267
3533
3534         Also add runtimes in milliseconds to the JSON and make the output format more compact.
3535         Named the file full_results.json to avoid conflicting with the results.json
3536         file the test-results server currently serves up.
3537
3538         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3539         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3540         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3541         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3542         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3543         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3544
3545 2011-02-27  Adam Roben  <aroben@apple.com>
3546
3547         Followup fix to r79827
3548
3549         * DumpRenderTree/win/UIDelegate.cpp:
3550         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
3551         lastPathComponent. This matches what we did here before r79827, and matches Mac.
3552
3553 2011-02-27  Dan Bernstein  <mitz@apple.com>
3554
3555         Reviewed by Adam Roben.
3556
3557         Make bisect-builds print a trac link for the regression range
3558         https://bugs.webkit.org/show_bug.cgi?id=55331
3559
3560         * Scripts/bisect-builds:
3561
3562 2011-02-27  Adam Roben  <aroben@apple.com>
3563
3564         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
3565
3566         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
3567         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
3568         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
3569
3570         Reviewed by Anders Carlsson.
3571
3572         * DumpRenderTree/win/EditingDelegate.cpp:
3573         (indexOfFirstWordCharacter):
3574         (wordLength):
3575         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
3576
3577 2011-02-27  Adam Roben  <aroben@apple.com>
3578
3579         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
3580
3581         This matches Mac. (In fact, the code was ported from Mac!)
3582
3583         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
3584         match Mac
3585
3586         Reviewed by Anders Carlsson.
3587
3588         * DumpRenderTree/win/DumpRenderTree.cpp:
3589         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
3590         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
3591         _drt_descriptionSuitableForTestResult].
3592         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
3593
3594         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
3595
3596         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
3597         DumpRenderTree.cpp.
3598
3599 2011-02-27  Adam Roben  <aroben@apple.com>
3600
3601         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
3602
3603         This makes Bugzilla autocompletion work correctly.
3604
3605         * Scripts/webkitpy/common/config/committers.py:
3606
3607 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
3608
3609         Reviewed by Andreas Kling.
3610
3611         [Qt] fast/loader/user-stylesheet-fast-path.html fails
3612         https://bugs.webkit.org/show_bug.cgi?id=50911
3613
3614         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3615         (LayoutTestController::setUserStyleSheetLocation):
3616         Use QUrl::fromEncoded since the passed string is already encoded.
3617
3618 2011-02-27  Adam Roben  <aroben@apple.com>
3619
3620         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
3621
3622         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
3623         is different from old-run-webkit-test's. Because of this, the path to the crash log file
3624         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
3625         details.
3626
3627         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
3628         --results-directory path is used (like on the test slaves)
3629
3630         Reviewed by Dan Bernstein.
3631
3632         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
3633         made $testResultsDirectory an absolute path.
3634
3635 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
3636
3637         Reviewed by Adam Barth.
3638
3639         m_dumpAccessibilityNotifications should be initialized.
3640         https://bugs.webkit.org/show_bug.cgi?id=54874
3641
3642         * DumpRenderTree/chromium/AccessibilityController.cpp:
3643         (AccessibilityController::AccessibilityController):
3644
3645 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3646
3647         Reviewed by Pavel Feldman.
3648
3649         DumpRenderTree should reset frame opener between tests.
3650         https://bugs.webkit.org/show_bug.cgi?id=54874
3651
3652         Added clearOpener() calls between tests.
3653         Some tests are using window.open() to change current window location.
3654         This changes window.opener property whose nullity is checked before
3655         showing xml viewer.
3656
3657         * DumpRenderTree/chromium/TestShell.cpp:
3658         (TestShell::resetTestController):
3659         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3660         (resetDefaultsToConsistentValues):
3661         * DumpRenderTree/mac/DumpRenderTree.mm:
3662         (resetWebViewToConsistentStateBeforeTesting):
3663         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3664         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3665         * DumpRenderTree/win/DumpRenderTree.cpp:
3666         (resetWebViewToConsistentStateBeforeTesting):
3667         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3668         (WTR::InjectedBundlePage::reset):
3669
3670 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
3671
3672         Reviewed by Andreas Kling.
3673
3674         [Qt] Fix the focus in MiniBrowser.
3675         https://bugs.webkit.org/show_bug.cgi?id=55288
3676
3677         Give focus to the web view when a load starts.
3678
3679         * MiniBrowser/qt/BrowserWindow.cpp:
3680         (BrowserWindow::urlChanged):
3681
3682 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3683
3684         Reviewed by Adam Barth.
3685
3686         [EFL] Add coding style exceptions for EFL port
3687         https://bugs.webkit.org/show_bug.cgi?id=54733
3688
3689         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
3690         underscore-sparated values. But, style checking rule have found parameter_name errors
3691         in efl directories so far.
3692
3693         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
3694
3695 2011-02-26  David Levin  <levin@chromium.org>
3696
3697         Reviewed by Darin Adler.
3698
3699         check-webkit-style should check for spaces after periods in comments
3700         https://bugs.webkit.org/show_bug.cgi?id=55253
3701
3702         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
3703         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
3704           and fixed the name of one related test.
3705
3706 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3707
3708         Reviewed by Andreas Kling.
3709
3710         Make it possible to test the targetdensity-dpi support
3711         https://bugs.webkit.org/show_bug.cgi?id=55142
3712
3713         Test the viewport meta tag feature targetdensity-dpi by
3714         adding extra arguments to dumpConfigurationForViewport
3715
3716         Add the new arguments to the shared header and all
3717         implementation.
3718
3719         * DumpRenderTree/LayoutTestController.cpp:
3720         (dumpConfigurationForViewportCallback):
3721         * DumpRenderTree/LayoutTestController.h:
3722         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3723         (LayoutTestController::dumpConfigurationForViewport):
3724         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3725         (LayoutTestController::dumpConfigurationForViewport):
3726         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3727         (LayoutTestController::dumpConfigurationForViewport):
3728         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3729         (LayoutTestController::dumpConfigurationForViewport):
3730         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3731         (LayoutTestController::dumpConfigurationForViewport):
3732         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3733
3734 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3735
3736         Unreviewed, rolling out r79764.
3737         http://trac.webkit.org/changeset/79764
3738         https://bugs.webkit.org/show_bug.cgi?id=55295
3739
3740         "broke Chromium builds" (Requested by rniwa on #webkit).
3741
3742         * DumpRenderTree/chromium/TestShell.cpp:
3743         (TestShell::resetTestController):
3744         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3745         (resetDefaultsToConsistentValues):
3746         * DumpRenderTree/mac/DumpRenderTree.mm:
3747         (resetWebViewToConsistentStateBeforeTesting):
3748         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3749         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3750         * DumpRenderTree/win/DumpRenderTree.cpp:
3751         (resetWebViewToConsistentStateBeforeTesting):
3752         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3753         (WTR::InjectedBundlePage::reset):
3754
3755 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
3756
3757         Reviewed by David Kilzer.
3758
3759         https://bugs.webkit.org/show_bug.cgi?id=48781
3760
3761         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
3762
3763         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
3764         should paint the default broken image when an image fails to load or decode.
3765
3766         * DumpRenderTree/LayoutTestController.cpp:
3767         (LayoutTestController::LayoutTestController):
3768         (setShouldPaintBrokenImageCallback):
3769         (LayoutTestController::staticFunctions):
3770         (LayoutTestController::setShouldPaintBrokenImage):
3771         * DumpRenderTree/LayoutTestController.h:
3772         (LayoutTestController::shouldPaintBrokenImage):
3773         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3774         (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
3775
3776 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3777
3778         Reviewed by Pavel Feldman.
3779
3780         DumpRenderTree should reset frame opener between tests.
3781         https://bugs.webkit.org/show_bug.cgi?id=54874
3782
3783         Added clearOpener() calls between tests.
3784         Some tests are using window.open() to change current window location.
3785         This changes window.opener property whose nullity is checked before
3786         showing xml viewer.
3787
3788         * DumpRenderTree/chromium/TestShell.cpp:
3789         (TestShell::resetTestController):
3790         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3791         (resetDefaultsToConsistentValues):
3792         * DumpRenderTree/mac/DumpRenderTree.mm:
3793         (resetWebViewToConsistentStateBeforeTesting):
3794         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3795         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3796         * DumpRenderTree/win/DumpRenderTree.cpp:
3797         (resetWebViewToConsistentStateBeforeTesting):
3798         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3799         (WTR::InjectedBundlePage::reset):
3800
3801 2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>
3802
3803         Reviewed by Kenneth Rohde Christiansen.
3804
3805         [EFL] Added EWebLauncher command line option to turn on/off frame flattening
3806         https://bugs.webkit.org/show_bug.cgi?id=54809
3807
3808         * EWebLauncher/main.c: Handling -f option added.
3809         (on_key_down):
3810         (browserCreate):
3811         (main):
3812
3813 2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3814
3815         Unreviewed, rolling out r79324.
3816         http://trac.webkit.org/changeset/79324
3817         https://bugs.webkit.org/show_bug.cgi?id=55260
3818
3819         Leopard Debug is once again running out of address space while
3820         linking (Requested by aroben on #webkit).
3821
3822         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3823         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3824
3825 2011-02-25  Tony Chang  <tony@chromium.org>
3826
3827         Reviewed by James Robinson.
3828
3829         Clean up temp files left by crashing DRTs on chromium-win
3830         https://bugs.webkit.org/show_bug.cgi?id=55182
3831
3832         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3833         * BuildSlaveSupport/chromium/remove-crash-logs: Added.
3834
3835 2011-02-25  Adam Roben  <aroben@apple.com>
3836
3837         Double-check that modifying the registry worked
3838
3839         On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
3840         still return a successful exit code. So we double-check here that the value we tried to
3841         write to the registry was really written.
3842
3843         Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
3844         logs on Windows Vista/7
3845
3846         Reviewed by Darin Adler.
3847
3848         * Scripts/old-run-webkit-tests:
3849         (writeRegistryString): After trying to write the string value, check that it was really
3850         written.
3851
3852 2011-02-25  Adam Roben  <aroben@apple.com>
3853
3854         Set the 32-bit post-mortem debugger on 64-bit OSes
3855
3856         The post-mortem debugger is controlled by some registry values in
3857         HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
3858         set the values in that key, which will be used for 64-bit apps, or in the equivalent key
3859         under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
3860         WebKitTestRunner are 32-bit, we want to use the latter location.
3861
3862         Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
3863         64-bit apps, but should set it for 32-bit apps instead
3864
3865         Reviewed by Darin Adler.
3866
3867         * Scripts/old-run-webkit-tests:
3868         (readRegistryString):
3869         (writeRegistryString):
3870         Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
3871         Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
3872         Passing --wow32 on a 32-bit OS will not have any effect.
3873
3874 2011-02-25  Adam Roben  <aroben@apple.com>
3875
3876         Clean up code to set up crash log saving on Windows
3877
3878         Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
3879
3880         Reviewed by David Kilzer.
3881
3882         * Scripts/old-run-webkit-tests:
3883         (readRegistryString):
3884         (writeRegistryString):
3885         Moved code to read strings from and write strings to the registry here...
3886
3887         (setUpWindowsCrashLogSaving): ...from here.
3888
3889 2011-02-25  Adam Roben  <aroben@apple.com>
3890
3891         Work around Cygwin's crash-suppression behavior
3892
3893         Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
3894         inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
3895         invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
3896         when our test apps launch to work around Cygwin's behavior.
3897
3898         Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
3899         debugger) when launched from Cygwin 1.7
3900
3901         Reviewed by Darin Adler.
3902
3903         * DumpRenderTree/win/DumpRenderTree.cpp:
3904         (main):
3905         * TestWebKitAPI/win/main.cpp:
3906         (main):
3907         * WebKitAPITest/main.cpp:
3908         (main):
3909         * WebKitTestRunner/win/TestControllerWin.cpp:
3910         (WTR::TestController::platformInitialize):
3911         Call ::SetErrorMode(0) to undo Cygwin's folly.
3912
3913 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3914
3915         Reviewed by Andreas Kling.
3916
3917         [Qt] Revert the support for QNAM affined to a different thread.
3918         https://bugs.webkit.org/show_bug.cgi?id=55149
3919
3920         Qt 4.8 will have QNAM use its own thread internally by default,
3921         no need to keep this complexity in WebKit.
3922
3923         This mainly reverts:
3924         http://trac.webkit.org/changeset/73710
3925         http://trac.webkit.org/changeset/73712
3926
3927         * QtTestBrowser/launcherwindow.cpp:
3928         (LauncherWindow::~LauncherWindow):
3929         (LauncherWindow::initializeView):
3930         (LauncherWindow::createChrome):
3931         * QtTestBrowser/launcherwindow.h:
3932         (WindowOptions::WindowOptions):
3933         * QtTestBrowser/webpage.cpp:
3934         (WebPage::WebPage):
3935         * QtTestBrowser/webpage.h:
3936
3937 2011-02-24  Adam Barth  <abarth@webkit.org>
3938
3939         Reviewed by Eric Seidel.
3940
3941         Add a script for creating gypi files
3942         https://bugs.webkit.org/show_bug.cgi?id=55113
3943
3944         This is a trivial script to create gypi files from the source code in
3945         the current directory.
3946
3947         * Scripts/make-gypi: Added.
3948
3949 2011-02-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3950
3951         Unreviewed, rolling out r79628.
3952         http://trac.webkit.org/changeset/79628
3953         https://bugs.webkit.org/show_bug.cgi?id=55195
3954
3955         "broke chromium win tests" (Requested by dpranke on #webkit).
3956
3957         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3958         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3959
3960 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3961
3962         Reviewed by Mihai Parparita.
3963
3964         rebaseline-chromium-webkit-tests can't handle GPU variants
3965         https://bugs.webkit.org/show_bug.cgi?id=55002
3966
3967         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3968         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3969
3970 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3971
3972         Reviewed by Mihai Parparita.
3973
3974         nrwt: log command used to start web server to --verbose
3975
3976         https://bugs.webkit.org/show_bug.cgi?id=55188
3977
3978         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3979         * Scripts/webkitpy/layout_tests/port/http_server.py:
3980
3981 2011-02-24  Victoria Kirst  <vrk@google.com>
3982
3983         Reviewed by Mihai Parparita.
3984
3985         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
3986         https://bugs.webkit.org/show_bug.cgi?id=55089
3987
3988         This adds an alias into the media/ directory so that http/tests/media
3989         tests can access the media resources when running in an httpd process.
3990
3991         * Scripts/webkitperl/httpd.pm:
3992         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3993         * Scripts/webkitpy/layout_tests/port/http_server.py:
3994
3995 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3996
3997         Reviewed by Mihai Parparita.
3998
3999         nrwt: enable multiple processes by default on Chromium Win.
4000
4001         https://bugs.webkit.org/show_bug.cgi?id=55163
4002
4003         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4004         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4005
4006 2011-02-24  Sam Weinig  <sam@webkit.org>
4007
4008         Attempt to fix Qt.
4009
4010         * WebKitTestRunner/TestInvocation.cpp:
4011
4012 2011-02-24  James Robinson  <jamesr@chromium.org>
4013
4014         Unreviewed, rolling out r79598.
4015         http://trac.webkit.org/changeset/79598
4016         https://bugs.webkit.org/show_bug.cgi?id=55089
4017
4018         Appears to be causing trouble with httpd on windows
4019
4020         * Scripts/webkitperl/httpd.pm:
4021         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
4022         * Scripts/webkitpy/layout_tests/port/http_server.py:
4023
4024 2011-02-24  Sam Weinig  <sam@webkit.org>
4025
4026         Reviewed by Darin Adler.
4027
4028         Add basic pixel testing support to WebKitTestRunner
4029         https://bugs.webkit.org/show_bug.cgi?id=55161
4030
4031         * Scripts/old-run-webkit-tests:
4032         Don't print color space information when using WebKitTestRunner since
4033         we don't need to change the screen.
4034
4035         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4036         (WTR::InjectedBundle::initialize):
4037         Add call to initializePlatformDefaults.
4038         
4039         (WTR::InjectedBundle::done):
4040         Return a dictionary on completion with both the text output and pixel dump override.
4041
4042         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4043         Add declaration for initializePlatformDefaults.
4044
4045         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4046         (WTR::LayoutTestController::LayoutTestController):
4047         (WTR::LayoutTestController::dumpAsText):
4048         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4049         (WTR::LayoutTestController::shouldDumpPixels):
4050         Make setting dumpAsText override the dump pixels preference.
4051
4052         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.
4053         (WTR::InjectedBundle::initializePlatformDefaults):
4054         Set platform defaults matching DumpRenderTree.
4055
4056         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.
4057         (WTR::InjectedBundle::initializePlatformDefaults):
4058         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.
4059         (WTR::InjectedBundle::initializePlatformDefaults):
4060         Add stubs for initializePlatformDefaults.
4061
4062         * WebKitTestRunner/TestController.cpp:
4063         (WTR::TestController::runTest):
4064         (WTR::TestController::runTestingServerLoop):
4065         (WTR::TestController::run):
4066         Parse expected pixel results out of stdin and setup the invocation with it.
4067
4068         * WebKitTestRunner/TestInvocation.cpp:
4069         (WTR::TestInvocation::TestInvocation):
4070         Initialize new members.
4071
4072         (WTR::TestInvocation::~TestInvocation):
4073         (WTR::TestInvocation::setIsPixelTest):
4074         (WTR::sizeWebViewForCurrentTest):
4075         (WTR::TestInvocation::invoke):
4076         (WTR::TestInvocation::dump):
4077         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4078         * WebKitTestRunner/TestInvocation.h:
4079         Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.
4080
4081         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4082         (WTR::PlatformWebView::PlatformWebView):
4083         Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.
4084
4085         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
4086         (WTR::createCGContextFromPlatformView):
4087         (WTR::computeMD5HashStringForContext):
4088         (WTR::dumpBitmap):
4089         (WTR::forceRepaintFunction):
4090         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
4091         Add mac specific pixel dumping support. Right now, we always pull pixels
4092         from the window server.
4093
4094         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4095         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4096         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4097         * WebKitTestRunner/win/InjectedBundle.vcproj:
4098         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4099         Add new files.
4100
4101 2011-02-24  Chang Shu  <cshu@webkit.org>
4102
4103         Reviewed by Kenneth Rohde Christiansen.
4104
4105         [Qt] Launch MiniBrowser if the test run is WebKit2. 
4106         https://bugs.webkit.org/show_bug.cgi?id=55145
4107
4108         * Scripts/old-run-webkit-tests:
4109         * Scripts/run-launcher:
4110         * Scripts/webkitdirs.pm:
4111
4112 2011-02-24  Victoria Kirst  <vrk@google.com>
4113
4114         Reviewed by Mihai Parparita.
4115
4116         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
4117         https://bugs.webkit.org/show_bug.cgi?id=55089
4118
4119         This adds an alias into the media/ directory so that http/tests/media
4120         tests can access the media resources when running in an httpd process.
4121
4122         * Scripts/webkitperl/httpd.pm:
4123         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
4124         * Scripts/webkitpy/layout_tests/port/http_server.py:
4125
4126 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
4127
4128         Unreviewed, rolling out r79570.
4129         http://trac.webkit.org/changeset/79570
4130         https://bugs.webkit.org/show_bug.cgi?id=54874
4131
4132         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
4133         was not updated
4134
4135         * DumpRenderTree/chromium/TestShell.cpp:
4136         (TestShell::resetTestController):
4137         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4138         (resetDefaultsToConsistentValues):
4139         * DumpRenderTree/mac/DumpRenderTree.mm:
4140         (resetWebViewToConsistentStateBeforeTesting):
4141         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4142         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4143         * DumpRenderTree/win/DumpRenderTree.cpp:
4144         (resetWebViewToConsistentStateBeforeTesting):
4145         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4146         (WTR::InjectedBundlePage::reset):
4147
4148 2011-02-24  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
4149
4150         Reviewed by Laszlo Gombos.
4151
4152         [Qt] add android 2.2 user agent to QtTestBrowser
4153         https://bugs.webkit.org/show_bug.cgi?id=55085
4154
4155         Credit to Forrest Hodgkins to find right user-agent which works for youtube.
4156         * QtTestBrowser/useragentlist.txt:
4157
4158 2011-02-24  Adam Roben  <aroben@apple.com>
4159
4160         Change FrameLoadDelegate to support any number of delegates with delayed work to process
4161
4162         This makes our behavior match Mac more closely, and allows us to remove an incorrect
4163         assertion that was firing during some tests. (The assertion was claiming that there was
4164         never more than one delegate with delayed work to process, but that was not the case.)
4165
4166         Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
4167         when running http/tests/navigation/back-twice-without-commit.html
4168
4169         Reviewed by Eric Carlson.
4170
4171         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4172         (delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
4173         process. A single delegate may appear in this Vector more than once (just as, on Mac, a
4174         single delegate may have multiple performSelector requests).
4175         (processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
4176         assertion that the timer firing is the shared process work timer. Instead of using the
4177         single, global "delegate waiting for timer" delegate, give all delegates that have delayed
4178         work to process a chance to process their work.
4179         (FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
4180         processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
4181         Vector so our processWork function will be called when the timer fires.
4182
4183 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
4184
4185         Reviewed by Alexey Proskuryakov.
4186
4187         DumpRenderTree should reset frame opener between tests.
4188         https://bugs.webkit.org/show_bug.cgi?id=54874
4189
4190         Added clearOpener() calls between tests.
4191         Some tests are using window.open() to change current window location.
4192         This changes window.opener property whose nullity is checked before
4193         showing xml viewer.
4194
4195         * DumpRenderTree/chromium/TestShell.cpp:
4196         (TestShell::resetTestController):
4197         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4198         (resetDefaultsToConsistentValues):
4199         * DumpRenderTree/mac/DumpRenderTree.mm:
4200         (resetWebViewToConsistentStateBeforeTesting):
4201         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4202         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4203         * DumpRenderTree/win/DumpRenderTree.cpp:
4204         (resetWebViewToConsistentStateBeforeTesting):
4205         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4206         (WTR::InjectedBundlePage::reset):
4207
4208 2011-02-24  Adam Roben  <aroben@apple.com>
4209
4210         Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am
4211
4212         Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
4213         but did
4214
4215         Reviewed by Anders Carlsson.
4216
4217         * Scripts/webkitpy/common/config/build.py:
4218         (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
4219         top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.
4220
4221         * Scripts/webkitpy/common/config/build_unittest.py:
4222         (ShouldBuildTest): Added some more tests.
4223
4224 2011-02-24  Andras Becsi  <abecsi@webkit.org>
4225
4226         Reviewed by Laszlo Gombos.
4227
4228         [Qt] MinGW build fails to link
4229         https://bugs.webkit.org/show_bug.cgi?id=55050
4230
4231         Prepend the libraries of subcomponents instead of appending them
4232         to fix the library order according to the dependency of the libraries
4233
4234         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4235         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4236
4237 2011-02-24  Gabor Loki  <loki@webkit.org>
4238
4239         Reviewed by Csaba Osztrogonác.
4240
4241         [Qt] Remove ARMv5 Release buildbot.
4242
4243         Remove ARMv5 Release buildbot, because there is very little difference
4244         between ARMv5 and ARMv7 Release bots, and there is also very little
4245         interest in ARMv5 build slave (compared to ARMv7).
4246
4247         * BuildSlaveSupport/build.webkit.org-config/config.json:
4248         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4249
4250 2011-02-22  Ojan Vafai  <ojan@chromium.org>
4251
4252         Reviewed by Tony Chang.
4253
4254         fix revision number finding when creating git patches
4255         https://bugs.webkit.org/show_bug.cgi?id=55024
4256
4257         HEAD~n does not walk merge commits correctly. git log however does.
4258
4259         * Scripts/webkitpy/common/checkout/scm.py:
4260         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4261
4262 2011-02-23  Kenneth Russell  <kbr@google.com>
4263
4264         Unreviewed, rolling out r79387.
4265         https://bugs.webkit.org/show_bug.cgi?id=54885
4266
4267         Reapply the code changes from r79038 since they weren't the root
4268         cause of the test timeouts.
4269
4270         * DumpRenderTree/chromium/WebViewHost.cpp:
4271         (WebViewHost::reset):
4272
4273 2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>
4274
4275         Reviewed by Laszlo Gombos.
4276
4277         [Qt] Make sure Symbian binary UIDs are unique
4278
4279         * MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with
4280         QtTestBrowser.pro by changing the UID.
4281
4282 2011-02-23  Patrick Gansterer  <paroga@webkit.org>
4283
4284         Reviewed by Darin Adler.
4285
4286         Rename PLATFORM(CF) to USE(CF)
4287         https://bugs.webkit.org/show_bug.cgi?id=53540
4288
4289         * DumpRenderTree/config.h:
4290
4291 2011-02-23  Dirk Pranke  <dpranke@chromium.org>
4292
4293         Reviewed by Ojan Vafai.
4294
4295         nrwt: turn on multiprocessing on chromium_linux, clean up unit tests for worker model defaults
4296         https://bugs.webkit.org/show_bug.cgi?id=55016
4297
4298         * Scripts/webkitpy/layout_tests/port/base.py:
4299         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4300         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Added.
4301         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4302         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4303         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4304         * Scripts/webkitpy/layout_tests/port/mac.py:
4305         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4306         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4307         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4308
4309 2011-02-23  Tony Chang  <tony@chromium.org>
4310
4311         Reviewed by Kent Tamura.