085da65fa28e3e69220de7e60486fc6292acab40
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Add configuration and architecture for windows builders
4         https://bugs.webkit.org/show_bug.cgi?id=196660
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/config.json:
9
10 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
11
12         webkitpy: Don't run subsequent rounds if interrupted
13         https://bugs.webkit.org/show_bug.cgi?id=196646
14
15         Reviewed by Aakash Jain.
16
17         * Scripts/webkitpy/layout_tests/controllers/manager.py:
18         (Manager.run): Bail out if interrupted.
19
20 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
21
22         Test sessionStorage in PSON private browsing mode
23         https://bugs.webkit.org/show_bug.cgi?id=196561
24
25         Reviewed by Alex Christensen.
26
27         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
28
29 2019-04-05  Commit Queue  <commit-queue@webkit.org>
30
31         Unreviewed, rolling out r243833.
32         https://bugs.webkit.org/show_bug.cgi?id=196645
33
34         This change breaks build of WPE and GTK ports (Requested by
35         annulen on #webkit).
36
37         Reverted changeset:
38
39         "[CMake][WTF] Mirror XCode header directories"
40         https://bugs.webkit.org/show_bug.cgi?id=191662
41         https://trac.webkit.org/changeset/243833
42
43 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
44
45         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
46         https://bugs.webkit.org/show_bug.cgi?id=196635
47
48         Reviewed by Antti Koivisto.
49         
50         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
51         for a test to enable async frame scrolling via:
52             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
53         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
54         
55         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
56
57         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
58         (WTR::InjectedBundle::beginTesting):
59         * WebKitTestRunner/TestController.cpp:
60         (WTR::TestController::resetPreferencesToConsistentValues):
61
62 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
63
64         Use a correct LC_RPATH when building with ASan
65         https://bugs.webkit.org/show_bug.cgi?id=196576
66
67         Reviewed by David Kilzer.
68
69         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
70         so that ../Frameworks is checked. This is simpler and more reliable than updating
71         each SPC service xcconfig.
72
73 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
74
75         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
76         https://bugs.webkit.org/show_bug.cgi?id=196629
77
78         Reviewed by Lucas Forschler.
79
80         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
81
82 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
83
84         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
85         https://bugs.webkit.org/show_bug.cgi?id=196618
86
87         Reviewed by Lucas Forschler.
88
89         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
90         (StatusBubble): Added QUEUE_TRIGGERS.
91         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
92         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
93         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
94         its parent(builder).
95
96 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
97
98         [ews-app] Status-bubble steps are sometimes displayed in reverse order
99         https://bugs.webkit.org/show_bug.cgi?id=196625
100
101         Reviewed by Lucas Forschler.
102
103         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
104         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
105
106 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
107
108         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
109         https://bugs.webkit.org/show_bug.cgi?id=196630
110
111         Reviewed by Wenson Hsieh.
112
113         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
114
115 2019-04-04  Youenn Fablet  <youenn@apple.com>
116
117         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
118         https://bugs.webkit.org/show_bug.cgi?id=196543
119
120         Reviewed by Alex Christensen.
121
122         * WebKitTestRunner/TestController.cpp:
123         (WTR::TestController::generatePageConfiguration):
124
125 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
126
127         [ews-app] Status bubble should not display skipped buildbot steps
128         https://bugs.webkit.org/show_bug.cgi?id=196584
129
130         Reviewed by Lucas Forschler.
131
132         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
133
134 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
135
136         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
137         https://bugs.webkit.org/show_bug.cgi?id=196620
138
139         Reviewed by Lucas Forschler.
140
141         * BuildSlaveSupport/ews-app/ews/config.py:
142
143 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
144
145         [Win] DumpRenderTreeWatchDog.py is not checked into source
146         https://bugs.webkit.org/show_bug.cgi?id=196567
147         <rdar://problem/49525901>
148
149         Reviewed by Lucas Forschler.
150
151         This script is used on Win EWS bots to terminate hanging DRT processes.
152
153         * EWSTools/dumprendertreewatchdog.py: Added.
154
155 2019-04-04  Chris Dumez  <cdumez@apple.com>
156
157         Unreviewed, roll out r243858 which made tests time out.
158
159         Disable new API tests on Windows instead.
160
161         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
162         (TestWebKitAPI::TEST):
163
164 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
165
166         [ATK] Cleanup WebPageAccessibilityObjectAtk
167         https://bugs.webkit.org/show_bug.cgi?id=196537
168
169         Reviewed by Michael Catanzaro.
170
171         Also consider files under atk directories as exceptions for GObject conventions.
172
173         * Scripts/webkitpy/style/checkers/cpp.py:
174         (check_identifier_name_in_declaration):
175
176 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
177
178         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
179         https://bugs.webkit.org/show_bug.cgi?id=196588
180         <rdar://problem/49365787>
181
182         Unreviewed build fix for Windows port.
183
184         error C3861: 'kill': identifier not found
185
186         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
187         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
188
189 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
190
191         [ews-build] Cancel build and similar operations should have authentication
192         https://bugs.webkit.org/show_bug.cgi?id=196520
193
194         Reviewed by Dewei Zhu.
195
196         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
197         environment variables.
198
199 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
200
201         [ews-build] Do not trigger queues which are not in production yet
202         https://bugs.webkit.org/show_bug.cgi?id=196581
203
204         Reviewed by Dewei Zhu.
205
206         * BuildSlaveSupport/ews-build/config.json:
207
208 2019-04-03  Chris Dumez  <cdumez@apple.com>
209
210         Unreviewed, fix typo in the name of API test added in r243848.
211
212         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
213         (TestWebKitAPI::TEST):
214
215 2019-04-03  Chris Dumez  <cdumez@apple.com>
216
217         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
218         https://bugs.webkit.org/show_bug.cgi?id=196588
219         <rdar://problem/49365787>
220
221         Reviewed by Ryosuke Niwa.
222
223         Add API test coverage.
224
225         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
226         (TestWebKitAPI::nullJavaScriptCallback):
227         (TestWebKitAPI::didCrashCheckFrames):
228         (TestWebKitAPI::TEST):
229
230 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
231
232         run-webkit-tests: Upload test results (new results database)
233         https://bugs.webkit.org/show_bug.cgi?id=196577
234         <rdar://problem/34841155>
235
236         Reviewed by Lucas Forschler.
237
238         * Scripts/webkitpy/layout_tests/controllers/manager.py:
239         (Manager.run): Upload results after each device shard, since the configuration will be
240         different for each device.
241         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
242         uploaded to a results database.
243         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
244         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
245
246 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
247
248         -apple-trailing-word is needed for browser detection
249         https://bugs.webkit.org/show_bug.cgi?id=196575
250
251         Unreviewed.
252
253         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
254
255 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
256
257         [CMake][WTF] Mirror XCode header directories
258         https://bugs.webkit.org/show_bug.cgi?id=191662
259
260         Reviewed by Konstantin Tokarev.
261
262         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
263         builds.
264
265         * CMakeLists.txt:
266         * DumpRenderTree/CMakeLists.txt:
267         * DumpRenderTree/PlatformWin.cmake:
268         * MiniBrowser/win/CMakeLists.txt:
269         * TestWebKitAPI/CMakeLists.txt:
270         * TestWebKitAPI/PlatformWin.cmake:
271         * WebKitTestRunner/PlatformGTK.cmake:
272         * WebKitTestRunner/PlatformWin.cmake:
273
274 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
275
276         [ews-app] Status bubble should not display certain infrastructure status messages
277         https://bugs.webkit.org/show_bug.cgi?id=196550
278
279         Reviewed by Lucas Forschler.
280
281         Do not display the steps which are un-needed for end-user. This information is still avaiable
282         if the user click on the bubble and look at the Buildbot build.
283         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
284         (StatusBubble._steps_messages):
285         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
286
287 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
288
289         [ews-build] Use https for sending data to ews-app
290         https://bugs.webkit.org/show_bug.cgi?id=196492
291
292         Reviewed by Lucas Forschler.
293
294         * BuildSlaveSupport/ews-build/events.py:
295
296 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
297
298         Remove support for -apple-trailing-word
299         https://bugs.webkit.org/show_bug.cgi?id=196525
300
301         Reviewed by Zalan Bujtas.
302
303         This CSS property is nonstandard and not used.
304
305         * Scripts/webkitperl/FeatureList.pm:
306         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
307
308 2019-04-03  Youenn Fablet  <youenn@apple.com>
309
310         Add a test for DOMCache on multiple browsing in case of private browsing
311         https://bugs.webkit.org/show_bug.cgi?id=196524
312
313         Reviewed by Alex Christensen.
314
315         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
316         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
317
318 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
319
320         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
321         https://bugs.webkit.org/show_bug.cgi?id=196540
322
323         Reviewed by Aakash Jain.
324
325         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
326
327 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
328
329         Add plumbing for a compatibility mode preference in WebKit
330         https://bugs.webkit.org/show_bug.cgi?id=196005
331
332         Reviewed by Tim Horton.
333
334         Add new API tests.
335
336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
337         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
338
339 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
340
341         [WPE][GTK] Update libsrtp dependency package for Debian
342         https://bugs.webkit.org/show_bug.cgi?id=196528
343
344         Reviewed by Frédéric Wang.
345
346         * gtk/install-dependencies:
347         * wpe/install-dependencies:
348
349 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
350
351         [WK2] Add support for Window's beforeprint / afterprint events
352         https://bugs.webkit.org/show_bug.cgi?id=196478
353         <rdar://problem/49535124>
354
355         Unreviewed build fix for MSVC.
356
357         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
358
359         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
360
361         * WebKitTestRunner/TestController.cpp:
362         (WTR::printFrame): Use int and float literals.
363
364 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
365
366         [ews-build] Reassign bots to queues
367
368         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
369
370 2019-04-02  Chris Dumez  <cdumez@apple.com>
371
372         [WK2] Add support for Window's beforeprint / afterprint events
373         https://bugs.webkit.org/show_bug.cgi?id=196478
374
375         Reviewed by Alex Christensen.
376
377         Add minimal implementation for printFrame in WebKitTestRunner.
378
379         * WebKitTestRunner/TestController.cpp:
380         (WTR::printFrame):
381         (WTR::TestController::createOtherPage):
382         (WTR::TestController::createWebViewWithOptions):
383
384 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
385
386         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
387         https://bugs.webkit.org/show_bug.cgi?id=196491
388
389         Reviewed by Lucas Forschler.
390
391         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
392
393 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
394
395         [ews-build] Configure buildbot try credentials in environment variables
396         https://bugs.webkit.org/show_bug.cgi?id=196501
397
398         Reviewed by Lucas Forschler.
399
400         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
401         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
402         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
403
404 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
405
406         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
407         https://bugs.webkit.org/show_bug.cgi?id=196496
408         <rdar://problem/49521634>
409
410         Reviewed by Chris Dumez.
411
412         Add new API tests (see WebKit ChangeLog for more detail).
413
414         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
415         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
416         (TEST):
417
418 2019-04-02  David Kilzer  <ddkilzer@apple.com>
419
420         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
421         <https://webkit.org/b/196499>
422
423         Reviewed by Alexey Proskuryakov.
424
425         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
426         ENABLE_ADDRESS_SANITIZER.
427
428 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
429
430         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
431         https://bugs.webkit.org/show_bug.cgi?id=182757
432
433         Reviewed by Don Olmstead.
434
435         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
436         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
437
438 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
439
440         run-api-tests: Upload test results
441         https://bugs.webkit.org/show_bug.cgi?id=196323
442         <rdar://problem/49356714>
443
444         Reviewed by Lucas Forschler.
445
446         * Scripts/webkitpy/api_tests/manager.py:
447         (Manager):
448         (Manager.run): Upload results to a results database.
449         * Scripts/webkitpy/api_tests/run_api_tests.py:
450         (parse_args): Add upload arguments.
451         * Scripts/webkitpy/port/base.py:
452         (Port):
453         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
454         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
455         with commits from any other associated repositories.
456         * Scripts/webkitpy/port/device.py:
457         (Device):
458         (Device.build_version): Access build_versoin of underlying platform device.
459         * Scripts/webkitpy/port/ios_simulator_unittest.py:
460         (IOSSimulatorTest):
461         (IOSSimulatorTest.test_configuration_for_upload):
462         * Scripts/webkitpy/port/device_port.py:
463         (DevicePort):
464         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
465         the same as the machine uploading results.
466         * Scripts/webkitpy/port/mac.py:
467         (MacPort):
468         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
469         * Scripts/webkitpy/port/mac_unittest.py:
470         (MacTest):
471         (MacTest.test_configuration_for_upload):
472         * Scripts/webkitpy/xcode/simulated_device.py:
473         (SimulatedDeviceManager._create_device_with_runtime):
474         (SimulatedDevice.__init__): Create simulated device with a build_version.
475         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
476         (test_existing_simulator):
477
478 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
479
480         Remove extra newline characters (Follow-up fix to r243707)
481
482         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
483
484 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
485
486         [ews-app] Use API_KEY to accept results data
487         https://bugs.webkit.org/show_bug.cgi?id=196461
488
489         Reviewed by Dewei Zhu.
490
491         * BuildSlaveSupport/ews-app/ews/views/results.py:
492         (Results.post): Validate EWS_API_KEY before accepting any data.
493         * BuildSlaveSupport/ews-build/events.py:
494         (Events.sendData): Send EWS_API_KEY if available along with event data.
495
496 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
497
498         Unable to copy and paste a PDF from Notes into Mail compose body
499         https://bugs.webkit.org/show_bug.cgi?id=196442
500         <rdar://problem/48573098>
501
502         Reviewed by Tim Horton.
503
504         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
505         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
506         to be specified on the item providers.
507
508         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
509         (TestWebKitAPI::mapItemForTesting):
510         (TestWebKitAPI::contactItemForTesting):
511
512 2019-04-01  Tim Horton  <timothy_horton@apple.com>
513
514         Make UIWKDocumentContext rects per-character instead of per-word
515         https://bugs.webkit.org/show_bug.cgi?id=196459
516
517         Reviewed by Wenson Hsieh.
518
519         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
520         (TEST):
521         Adjust test results due to switching to per-character rects.
522
523 2019-04-01  Chris Dumez  <cdumez@apple.com>
524
525         UIProcess crash when a prewarmed process is terminated
526         https://bugs.webkit.org/show_bug.cgi?id=196451
527         <rdar://problem/49245471>
528
529         Reviewed by Geoffrey Garen.
530
531         Add API test coverage.
532
533         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
534         (TEST):
535
536 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
537
538         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
539         https://bugs.webkit.org/show_bug.cgi?id=196449
540
541         Reviewed by Lucas Forschler.
542
543         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
544         (StatusBubble.get_os_details): Method to get OS and Xcode details.
545         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
546         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
547
548 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
549
550         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
551         https://bugs.webkit.org/show_bug.cgi?id=196444
552
553         Reviewed by Lucas Forschler.
554
555         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
556
557 2019-04-01  Alex Christensen  <achristensen@webkit.org>
558
559         Add SPI to canonicalize NSURLs with WTF::URL
560         https://bugs.webkit.org/show_bug.cgi?id=196415
561         <rdar://problem/44980271>
562
563         Reviewed by Darin Adler.
564
565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
566         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
567         (TestWebKitAPI::TEST):
568
569 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
570
571         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
572         https://bugs.webkit.org/show_bug.cgi?id=196441
573
574         Reviewed by Carlos Garcia Campos.
575
576         Don't cache the wpe_view_backend object that might not exist yet at the
577         time of EventSenderProxy constructor invocation, but instead retrieve
578         that object whenever it's required for event dispatching. This should
579         avoid crashes in this constructor now that it's invoked before any
580         PlatformWindow has been set up (as changed in r243496).
581
582         * WebKitTestRunner/EventSenderProxy.h:
583         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
584         (WTR::viewBackend):
585         (WTR::EventSenderProxy::EventSenderProxy):
586         (WTR::EventSenderProxy::mouseDown):
587         (WTR::EventSenderProxy::mouseUp):
588         (WTR::EventSenderProxy::mouseMoveTo):
589         (WTR::EventSenderProxy::mouseScrollBy):
590         (WTR::EventSenderProxy::keyDown):
591         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
592
593 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
594
595         [Win][WebKit] MiniBrowser should support high DPI display
596         https://bugs.webkit.org/show_bug.cgi?id=196391
597
598         Reviewed by Alex Christensen.
599
600         * MiniBrowser/win/WebKitBrowserWindow.cpp:
601         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
602         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
603         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
604
605 2019-03-31  Sam Weinig  <weinig@apple.com>
606
607         Remove more i386 specific configurations
608         https://bugs.webkit.org/show_bug.cgi?id=196430
609
610         Reviewed by Alexey Proskuryakov.
611
612         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
613         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
614
615 2019-03-31  Andy Estes  <aestes@apple.com>
616
617         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
618         https://bugs.webkit.org/show_bug.cgi?id=196433
619         <rdar://problem/49293305>
620
621         Reviewed by Tim Horton.
622
623         Enhanced API test coverage to include all navigation response policy decisions in both
624         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
625
626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
627         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
628         (TestWebKitAPI::TEST):
629         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
630         (readFile):
631         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
632         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
633         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
634         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
635         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
636         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
637         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
638         (-[QuickLookDelegate _downloadDidStart:]):
639         (-[QuickLookDelegate _download:didReceiveResponse:]):
640         (-[QuickLookDelegate _download:didReceiveData:]):
641         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
642         (-[QuickLookDelegate _downloadDidFinish:]):
643         (-[QuickLookDelegate _download:didFailWithError:]):
644         (-[QuickLookDelegate _downloadDidCancel:]):
645         (-[QuickLookDelegate verifyDownload]):
646         (runTest):
647         (runTestDecideBeforeLoading):
648         (runTestDecideAfterLoading):
649         (TEST):
650         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
651         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
652         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
653         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
654         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
655         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
656         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
657         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
658         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
659         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
660         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
661         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
662         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
663         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
664
665 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
666
667         [CMake] add testdfg as target with build-jsc
668         https://bugs.webkit.org/show_bug.cgi?id=196393
669
670         Reviewed by Saam Barati.
671
672         Added testdfg as one of the targets to build when
673         using CMake.
674
675         * Scripts/build-jsc:
676
677 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
678
679         Delete WebMetal implementation in favor of WebGPU
680         https://bugs.webkit.org/show_bug.cgi?id=195418
681
682         Reviewed by Dean Jackson.
683
684         * DumpRenderTree/mac/DumpRenderTree.mm:
685         (enableExperimentalFeatures):
686         (resetWebPreferencesToConsistentValues):
687         * Scripts/webkitperl/FeatureList.pm:
688         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
690         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
691         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
692         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
693         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
694         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
695         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
696         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
697         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
698         (WTR::InjectedBundle::beginTesting):
699         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
700         (WTR::TestRunner::setWebMetalEnabled): Deleted.
701         * WebKitTestRunner/InjectedBundle/TestRunner.h:
702
703 2019-03-29  Chris Dumez  <cdumez@apple.com>
704
705         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
706         https://bugs.webkit.org/show_bug.cgi?id=196405
707         <rdar://problem/49428130>
708
709         Reviewed by Wenson Hsieh.
710
711         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
712         the popover presentation methods to be no-ops. Use this in the new test added in
713         r243523 so that we do not swizzle those methods for all tests. This is needed because
714         those WatchOS tests rely on the popover getting presented and interactive.
715
716         * WebKitTestRunner/TestController.cpp:
717         (WTR::updateTestOptionsFromTestHeader):
718         * WebKitTestRunner/TestController.h:
719         * WebKitTestRunner/TestOptions.h:
720         (WTR::TestOptions::hasSameInitializationOptions const):
721         * WebKitTestRunner/ios/TestControllerIOS.mm:
722         (WTR::TestController::platformInitialize):
723         (WTR::TestController::platformResetStateToConsistentValues):
724
725 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
726
727         [Curl] Add Server Trust Evaluation Support.
728         https://bugs.webkit.org/show_bug.cgi?id=191646
729
730         Reviewed by Fujii Hironori.
731
732         Implemented MiniBrowser UI for asking if user trusts the server.
733
734         * MiniBrowser/win/Common.cpp:
735         (askServerTrustEvaluation):
736         (replaceString):
737         * MiniBrowser/win/Common.h:
738         * MiniBrowser/win/MiniBrowserLib.rc:
739         * MiniBrowser/win/MiniBrowserLibResource.h:
740         * MiniBrowser/win/WebKitBrowserWindow.cpp:
741         (createPEMString):
742         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
743         (WebKitBrowserWindow::canTrustServerCertificate):
744         * MiniBrowser/win/WebKitBrowserWindow.h:
745
746 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
747
748         Implement ResizeObserver.
749         https://bugs.webkit.org/show_bug.cgi?id=157743
750
751         Reviewed by Simon Fraser.
752
753         Support resizeObserverEnabled webPreferences.
754
755         * DumpRenderTree/TestOptions.cpp:
756         (TestOptions::TestOptions):
757         * DumpRenderTree/TestOptions.h:
758         * DumpRenderTree/mac/DumpRenderTree.mm:
759         (setWebPreferencesForTestOptions):
760         * DumpRenderTree/win/DumpRenderTree.cpp:
761         (enableExperimentalFeatures):
762         * Scripts/webkitperl/FeatureList.pm:
763         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
764
765 2019-03-28  John Wilander  <wilander@apple.com>
766
767         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
768         https://bugs.webkit.org/show_bug.cgi?id=196281
769         <rdar://problem/48938748>
770
771         Reviewed by Alex Christensen.
772
773         This patch adds the function isStatisticsHasLocalStorage() to the
774         TestRunner. With it, the page can query the WebsiteDataStore in the
775         UI process to make sure that it sees LocalStorage.
776
777         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
778         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
779         (WTR::TestRunner::isStatisticsHasLocalStorage):
780         * WebKitTestRunner/InjectedBundle/TestRunner.h:
781         * WebKitTestRunner/TestController.cpp:
782         (WTR::TestController::isStatisticsHasLocalStorage):
783         * WebKitTestRunner/TestController.h:
784         * WebKitTestRunner/TestInvocation.cpp:
785         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
786
787 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
788
789         API::Data::createWithoutCopying should do a null check before calling CFRelease
790         https://bugs.webkit.org/show_bug.cgi?id=196276
791         <rdar://problem/48059859>
792
793         Reviewed by Alex Christensen.
794
795         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
796
797         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
798         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
799         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
800         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
801         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
802         (TestWebKitAPI::TEST):
803
804 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
805
806         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
807         https://bugs.webkit.org/show_bug.cgi?id=186276
808
809         Reviewed by Carlos Garcia Campos.
810
811         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
812         (webViewLoadChanged):
813         (testWebResourceGetDataError):
814         (testWebResourceGetDataEmpty):
815         (beforeAll):
816         (webViewloadChanged): Deleted.
817
818 2019-03-27  Andy Estes  <aestes@apple.com>
819
820         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
821         https://bugs.webkit.org/show_bug.cgi?id=196317
822
823         Reviewed by Dan Bernstein.
824
825         package-root copies built products into a staging directory using ditto(1), which does not
826         follow symbolic links as it traverses a directory. Now that the files in
827         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
828         itself, these become broken links when ditto'd into the staging directory.
829
830         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
831
832         * Scripts/package-root:
833
834 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
835
836         [ews-app] Update display text of Submit for ews analysis
837         https://bugs.webkit.org/show_bug.cgi?id=196309
838
839         Reviewed by Dewei Zhu.
840
841         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
842
843 2019-03-27  David Kilzer  <ddkilzer@apple.com>
844
845         run-webkit-tests should check for leaks in WebKit processes
846         <https://webkit.org/b/193772>
847         <rdar://problem/46526680>
848
849         Reviewed by Ryosuke Niwa.
850
851         This works by doing the following:
852         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
853           The list of child processes are returned one per line:
854           process.name: pid
855         - Run the "#LIST CHILD PROCESSES" command just before the
856           "#CHECK FOR WORLD LEAKS" command, and store the list of child
857           processes on the ServerProcess object.
858         - When the `--leaks` switch is handled, run check_for_leaks() on
859           each child process after the main test harness.
860
861         * DumpRenderTree/mac/DumpRenderTree.mm:
862         (handleControlCommand):
863         - Use strncmp() instead of strcmp().
864         - Add support for handling "#LIST CHILD PROCESSES" command.
865
866         * Scripts/webkitpy/port/base.py:
867         (Port.check_for_leaks):
868         * Scripts/webkitpy/port/darwin.py:
869         (DarwinPort.check_for_leaks):
870         - Rename redundant 'process_pid' argument to 'process_id'.
871
872         * Scripts/webkitpy/port/driver.py:
873         (Driver.do_post_tests_work):
874         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
875           longer the only command this sends to WebKitTestRunner.
876         - If the `--leaks` switch is present, send the
877           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
878           result using Port.set_webkit_processes().
879         (Driver._parse_child_processes_output):
880         - Add helper method to parse list of child process names and
881           process IDs returned from WebKitTestRunner.
882
883         * Scripts/webkitpy/port/ios_device.py:
884         (IOSDevicePort.check_for_leaks):
885         - Rename redundant 'process_pid' argument to 'process_id'.
886
887         * Scripts/webkitpy/port/leakdetector.py:
888         (LeakDetector._parse_leaks_output):
889         - Return early if there is no leaks_output.
890         (LeakDetector.check_for_leaks):
891         - Rename redundant 'process_pid' argument to 'process_id'.
892
893         * Scripts/webkitpy/port/server_process.py:
894         (ServerProcess.__init__):
895         (ServerProcess.child_processes):
896         (ServerProcess.set_child_processes):
897         - Add instance variable to Port to store list of child process
898           names and process IDs returned from WebKitTestRunner.
899         (ServerProcess._start):
900         - Clear self._child_processes.
901         (ServerProcess.stop):
902         - If self._child_processes is set, call
903           self._port.check_for_leaks() for each child process.
904
905         * Scripts/webkitpy/port/server_process_unittest.py:
906         (TrivialMockPort.check_for_leaks):
907         - Rename redundant 'process_pid' argument to 'process_id'.
908
909         * Scripts/webkitpy/port/simulator_process.py:
910         (SimulatorProcess.stop):
911         - If self._child_processes is set, call
912           self._port.check_for_leaks() for each child process.
913
914         * Scripts/webkitpy/port/watch_device.py:
915         (WatchDevicePort.check_for_leaks):
916         - Rename redundant 'process_pid' argument to 'process_id'.
917
918         * WebKitTestRunner/TestController.cpp:
919         (WTR::TestController::dumpResponse):
920         - Extract method from findAndDumpWorldLeaks() so that it may be
921           reused by findAndDumpWebKitProcessIdentifiers().
922         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
923         - Add method to output process name and process ID of both the
924           WebContent and Networking processes.
925         (WTR::TestController::findAndDumpWorldLeaks):
926         - Fix missing newline in output when there were no abandoned
927           documents.
928         - Call dumpResponse() for extracted code.
929         (WTR::TestController::handleControlCommand):
930         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
931         - Use strncmp() instead of strcmp().
932         - Call findAndDumpWebKitProcessIdentifiers() when
933           "#LIST CHILD PROCESSES" command is sent.
934         * WebKitTestRunner/TestController.h:
935         (WTR::TestController::dumpResponse):
936         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
937         - Declare methods.
938
939 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
940
941         Unreviewed. Add GLib API test cases after r243434.
942
943         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
944         (testWebViewActiveURI):
945         (serverCallback):
946         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
947         (sendRequestCallback):
948
949 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
950
951         Geolocation request not complete when watch request was started in a different web process
952         https://bugs.webkit.org/show_bug.cgi?id=195996
953
954         Reviewed by Alex Christensen.
955
956         Add a test case.
957
958         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
959         (TestWebKitAPI::runJavaScriptAlert):
960         (TestWebKitAPI::TEST):
961
962 2019-03-26  Keith Rollin  <krollin@apple.com>
963
964         Update the way generate-xcfilelists returns strings from functions
965         https://bugs.webkit.org/show_bug.cgi?id=195975
966         <rdar://problem/49040807>
967
968         Reviewed by Dean Jackson.
969
970         There are places where generate-xcfilelists executes assignments with
971         statements like:
972
973             FOO=$(some_function)
974
975         where "some_function" return a string by echoing it. E.g.
976
977             some_function()
978             {
979                 echo "Hello, World"
980             }
981
982         This is a common idiom, but it has a problem if "some_function" needs
983         to call "exit" in an attempt to halt the entire script right then and
984         there. Since "some_function" is called inside of $(), it's being
985         executed in a sub-shell. Calling exit in that sub-shell simply exits
986         that shell; it doesn't not exit the outer shell in which the main part
987         of the script is still running. As such, the main script keeps
988         executing when the intent was for the script to halt.
989
990         The solution to this is to use a different idiom for returning
991         strings. The one we now is to pass in the name of the variable to
992         receive the string result:
993
994             some_function()
995             {
996                 variable_name=$1
997                 eval $variable_name ="Hello, World"
998             }
999
1000         The call site now looks like
1001
1002             some_function FOO
1003
1004         Because there's no invocation of a sub-shell, some_function can now
1005         call "exit" if it wants to, and the entire script will exit at that
1006         point.
1007
1008         * Scripts/generate-xcfilelists:
1009
1010 2019-03-26  Chris Dumez  <cdumez@apple.com>
1011
1012         Add basic layout test coverage for File Picker on iOS
1013         https://bugs.webkit.org/show_bug.cgi?id=196265
1014
1015         Reviewed by Wenson Hsieh.
1016
1017         Add layout test infrastructure to test the file picker on iOS.
1018
1019         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1020         (WTR::UIScriptController::dismissFilePicker):
1021         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1022         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1023         (WTR::UIScriptController::dismissFilePicker):
1024         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1025         * WebKitTestRunner/TestController.cpp:
1026         (WTR::TestController::createWebViewWithOptions):
1027         (WTR::updateTestOptionsFromTestHeader):
1028         * WebKitTestRunner/TestOptions.h:
1029         (WTR::TestOptions::hasSameInitializationOptions const):
1030         * WebKitTestRunner/ios/TestControllerIOS.mm:
1031         (overridePresentViewController):
1032         (WTR::TestController::platformInitialize):
1033         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1034         (WTR::UIScriptController::dismissFilePicker):
1035
1036 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1037
1038         Implement async paste method on UIWKInteractionViewProtocol
1039         https://bugs.webkit.org/show_bug.cgi?id=196267
1040         <rdar://problem/49236346>
1041
1042         Reviewed by Tim Horton.
1043
1044         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1045         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1046         are now a part of all iOS 12 internal SDKs.
1047
1048         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1049
1050         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1051         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1052
1053         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1054         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1055         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1056         * TestWebKitAPI/ios/UIKitSPI.h:
1057
1058 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1059
1060         [ews-build] Use PostgreSQL for ews.webkit.org database
1061         https://bugs.webkit.org/show_bug.cgi?id=196270
1062
1063         Reviewed by Lucas Forschler.
1064
1065         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1066
1067 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1068
1069         [ews] Reset simctl states on reboot
1070         https://bugs.webkit.org/show_bug.cgi?id=196260
1071
1072         Rubber-stamped by Aakash Jain.
1073
1074         * EWSTools/start-queue-mac.sh:
1075
1076 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1077
1078         [ews-build] Use PostgreSQL for ews-build database
1079         https://bugs.webkit.org/show_bug.cgi?id=196229
1080
1081         Reviewed by Lucas Forschler.
1082
1083         * BuildSlaveSupport/ews-build/master.cfg:
1084
1085 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1086
1087         [ews-build] Get master_hostname dynamically in master.cfg
1088         https://bugs.webkit.org/show_bug.cgi?id=196255
1089
1090         Reviewed by Lucas Forschler.
1091
1092         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1093         send events data in test mode.
1094
1095 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1096
1097         [ews-app] Set db_constraint to False for Foreign Keys
1098         https://bugs.webkit.org/show_bug.cgi?id=196252
1099
1100         Reviewed by Lucas Forschler.
1101
1102         * BuildSlaveSupport/ews-app/ews/models/build.py:
1103         * BuildSlaveSupport/ews-app/ews/models/step.py:
1104
1105 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1106
1107         [ews-build] is_test_mode_enabled should default to True
1108         https://bugs.webkit.org/show_bug.cgi?id=196248
1109
1110         Reviewed by Lucas Forschler.
1111
1112         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1113
1114 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1115
1116         [ews-app] Add webkitperl to ENABLED_QUEUES
1117         https://bugs.webkit.org/show_bug.cgi?id=196253
1118
1119         Reviewed by Lucas Forschler.
1120
1121         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1122
1123 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1124
1125         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1126         https://bugs.webkit.org/show_bug.cgi?id=196211
1127         rdar://problem/49110552
1128
1129         Reviewed by Tim Horton.
1130
1131         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1132         Make sure that EventSenderProxy always exists when running tests. We used to create
1133         it when resetting before the first test, which is a bit too late.
1134
1135         * WebKitTestRunner/TestController.h:
1136         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1137         (WTR::TestController::platformCreateWebView):
1138         (WTR::TestController::platformCreateOtherPage):
1139         (WTR::TestController::finishCreatingPlatformWebView):
1140         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1141         (WTR::PlatformWebView::PlatformWebView):
1142         Moved some code that made NSWindow use NSEvent during web view creation. We may
1143         need to move more if some other case us found, but this is enough for now.
1144
1145 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1146
1147         Unreviewed. Fix typo in GLib geolocation API after r243285.
1148
1149         gelocation -> geolocation.
1150
1151         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1152         (testGeolocationManagerWatchPosition):
1153
1154 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1155
1156         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1157         https://bugs.webkit.org/show_bug.cgi?id=196213
1158
1159         Reviewed by Geoff Garen.
1160
1161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1162         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1163         (credentialWithIdentityAndKeychainPath):
1164         (-[ChallengeDelegate webView:didFinishNavigation:]):
1165         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1166         (TestWebKitAPI::TEST):
1167
1168 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1169
1170         Expected shouldn't assume its contained types are copyable
1171         https://bugs.webkit.org/show_bug.cgi?id=195986
1172
1173         Reviewed by JF Bastien.
1174
1175         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1176         (TestWebKitAPI::NonCopyable::operator== const):
1177         (TestWebKitAPI::NonCopyable::operator!= const):
1178         (TestWebKitAPI::TEST):
1179
1180 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1181
1182         Remove some now-unnecessary dynamic class lookup
1183         https://bugs.webkit.org/show_bug.cgi?id=196237
1184
1185         Reviewed by Simon Fraser.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1188         (makeRequest):
1189         (TEST):
1190
1191 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1192
1193         Unreviewed, rolling out r243450.
1194
1195         AppleWin and WinCairo port builds get broken.
1196
1197         Reverted changeset:
1198
1199         "Add test for fix of #196095"
1200         https://bugs.webkit.org/show_bug.cgi?id=196097
1201         https://trac.webkit.org/changeset/243450
1202
1203 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1204
1205         Unreviewed, rolling out r243465.
1206         https://bugs.webkit.org/show_bug.cgi?id=196226
1207
1208         the test doesn't build (Requested by thorton on #webkit).
1209
1210         Reverted changeset:
1211
1212         "Do not terminate the NetworkProcess if a third party
1213         application sends a NSCredential with a SecIdentityRef"
1214         https://bugs.webkit.org/show_bug.cgi?id=196213
1215         https://trac.webkit.org/changeset/243465
1216
1217 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1218
1219         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1220         https://bugs.webkit.org/show_bug.cgi?id=196213
1221
1222         Reviewed by Geoff Garen.
1223
1224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1225         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1226         (credentialWithIdentityAndKeychainPath):
1227         (-[ChallengeDelegate webView:didFinishNavigation:]):
1228         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1229         (TestWebKitAPI::TEST):
1230
1231 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1232
1233         [ews-build] Gracefully handle missing patch_id in events
1234         https://bugs.webkit.org/show_bug.cgi?id=196216
1235
1236         Reviewed by Lucas Forschler.
1237
1238         * BuildSlaveSupport/ews-build/events.py:
1239
1240 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1241
1242         [ews-build] use lz4 compression for improving buildbot performance
1243         https://bugs.webkit.org/show_bug.cgi?id=196155
1244
1245         Reviewed by Lucas Forschler.
1246
1247         * BuildSlaveSupport/ews-build/master.cfg:
1248
1249 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1250
1251         Pull some API testing helper methods out of TestWKWebView
1252         https://bugs.webkit.org/show_bug.cgi?id=196212
1253
1254         Reviewed by Tim Horton.
1255
1256         Refactor some more API testing utility methods, so that they can be used in
1257         tests that do not use TestWKWebView.
1258
1259         * TestWebKitAPI/cocoa/TestWKWebView.h:
1260         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1261         (-[WKWebView loadTestPageNamed:]):
1262         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1263         (-[WKWebView synchronouslyLoadHTMLString:]):
1264         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1265         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1266         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1267         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1268         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1269
1270 2019-03-25  Jer Noble  <jer.noble@apple.com>
1271
1272         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1273         https://bugs.webkit.org/show_bug.cgi?id=196097
1274
1275         Reviewed by Eric Carlson.
1276
1277         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1278
1279         * DumpRenderTree/mac/DumpRenderTree.mm:
1280         (resetWebPreferencesToConsistentValues):
1281         * WebKitTestRunner/TestController.cpp:
1282         (WTR::TestController::resetPreferencesToConsistentValues):
1283
1284 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1285
1286         Pull IPadUserInterfaceSwizzler out into a separate header file
1287         https://bugs.webkit.org/show_bug.cgi?id=196193
1288
1289         Reviewed by Anders Carlsson.
1290
1291         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1292         be used in other API tests.
1293
1294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1295         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1296         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1297         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1298         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1299         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1300         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1301
1302 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1303
1304         Remove NavigatorContentUtils in WebCore/Modules
1305         https://bugs.webkit.org/show_bug.cgi?id=196070
1306
1307         Reviewed by Alex Christensen.
1308
1309         NavigatorContentUtils was to support the custom scheme spec [1].
1310         However, in WebKit side, no port has supported the feature in
1311         WebKit layer after EFL port was removed. So there has been the
1312         only IDL implementation of the NavigatorContentUtils in WebCore.
1313         So we don't need to keep the implementation in WebCore anymore.
1314
1315         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1316
1317         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1318
1319 2019-03-24  Andy Estes  <aestes@apple.com>
1320
1321         [watchOS] Remove unused Proximity Networking code
1322         https://bugs.webkit.org/show_bug.cgi?id=196188
1323
1324         Reviewed by Tim Horton.
1325
1326         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1327         (TEST):
1328
1329 2019-03-23  Keith Miller  <keith_miller@apple.com>
1330
1331         Refactor clz/ctz and fix getLSBSet.
1332         https://bugs.webkit.org/show_bug.cgi?id=196162
1333
1334         Reviewed by Saam Barati.
1335
1336         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1337
1338         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1339         (TestWebKitAPI::TEST):
1340
1341 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1342
1343         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1344         https://bugs.webkit.org/show_bug.cgi?id=196143
1345
1346         Reviewed by Michael Catanzaro.
1347
1348         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1349         directories.
1350
1351         * Scripts/webkitpy/style/checkers/cpp.py:
1352         (check_identifier_name_in_declaration):
1353         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1354         (WebKitStyleTest.test_names):
1355
1356 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1357
1358         [Flatpak] Manifest expanding fails for qt WPE extension
1359         https://bugs.webkit.org/show_bug.cgi?id=196148
1360
1361         Reviewed by Alex Christensen.
1362
1363         * flatpak/flatpakutils.py:
1364         (expand_submodules_recurse): The last recurse manifest expand
1365         iteration might lead to a single module so take it into account
1366         and don't try to recurse further.
1367
1368 2019-03-22  Chris Dumez  <cdumez@apple.com>
1369
1370         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1371         https://bugs.webkit.org/show_bug.cgi?id=195348
1372         <rdar://problem/48622090>
1373
1374         Reviewed by Alex Christensen.
1375
1376         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1377         to NO when test.options().shouldIgnoreMetaViewport is false.
1378
1379         * WebKitTestRunner/ios/TestControllerIOS.mm:
1380         (WTR::TestController::platformConfigureViewForTest):
1381
1382 2019-03-22  Chris Dumez  <cdumez@apple.com>
1383
1384         Prewarmed processes should be usable with any website data store
1385         https://bugs.webkit.org/show_bug.cgi?id=196104
1386
1387         Reviewed by Alex Christensen.
1388
1389         Add API test coverage.
1390
1391         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1392         (runInitialWarmedProcessUsedTest):
1393         (TEST):
1394
1395 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1396
1397         Back out local changes to Alex's Subversion working directory
1398
1399         They were accidentally committed.
1400
1401         * Scripts/webkitpy/common/system/abstractexecutive.py:
1402         (AbstractExecutive.wait_newest):
1403         * Scripts/webkitpy/common/system/executive.py:
1404         (Executive.running_pids):
1405         * Scripts/webkitpy/common/system/executive_mock.py:
1406         (MockExecutive.running_pids):
1407         * Scripts/webkitpy/common/system/executive_unittest.py:
1408         (ExecutiveTest.serial_test_running_pids):
1409         * Scripts/webkitpy/port/darwin.py:
1410         (DarwinPort.check_for_leaks):
1411         * Scripts/webkitpy/port/leakdetector.py:
1412         (LeakDetector.check_for_leaks):
1413         - This was the hack attached to Bug 193772.
1414
1415         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1416         (+[WebKitTestRunnerEvent mouseLocation]):
1417         - This works around a crash on an internal build.
1418
1419 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1420
1421         Fix the build after r243354
1422         https://bugs.webkit.org/show_bug.cgi?id=196138
1423         <rdar://problem/49145951>
1424
1425         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1426         (TEST):
1427         * TestWebKitAPI/ios/UIKitSPI.h:
1428
1429 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1430
1431         Adopt UIWKDocumentContext
1432         https://bugs.webkit.org/show_bug.cgi?id=196040
1433         <rdar://problem/48642440>
1434
1435         Reviewed by Ryosuke Niwa.
1436
1437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1438         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1439         (makeRequest):
1440         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1441         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1442         (applyStyle):
1443         (TEST):
1444         Add tests for UIWKDocumentContext.
1445
1446         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1447         (TEST):
1448         (recursiveFindWKContentView): Deleted.
1449         * TestWebKitAPI/cocoa/TestWKWebView.h:
1450         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1451         (recursiveFindWKContentView):
1452         (-[TestWKWebView wkContentView]):
1453         * TestWebKitAPI/ios/UIKitSPI.h:
1454         Share the WKContentView finding code between tests.
1455
1456 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1457
1458         [iOS WK2] Turn on async overflow scrolling by default
1459         https://bugs.webkit.org/show_bug.cgi?id=196011
1460         rdar://problem/48453859
1461
1462         Reviewed by Antti Koivisto.
1463         
1464         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1465         since so many basic layout tests have different results when compositing is triggered for
1466         overflow.
1467         
1468         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1469
1470         * WebKitTestRunner/TestController.cpp:
1471         (WTR::TestController::resetPreferencesToConsistentValues):
1472
1473 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1474
1475         [ews-build] Retry API test in case of failures
1476         https://bugs.webkit.org/show_bug.cgi?id=196004
1477
1478         Reviewed by Lucas Forschler.
1479
1480         * BuildSlaveSupport/ews-build/steps.py:
1481         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1482         (CompileWebKitToT.doStepIf): Ditto.
1483         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1484         (ReRunAPITests): Re-run API tests.
1485         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1486         (RunAPITestsWithoutPatch): Run API tests without patch.
1487         (RunAPITestsWithoutPatch.doStepIf):
1488         (RunAPITestsWithoutPatch.hideStepIf):
1489         (RunAPITestsWithoutPatch.evaluateCommand):
1490         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1491         (AnalyzeAPITestsResults.start):
1492         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1493         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1494         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1495         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1496
1497 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1498
1499         [ews-build] Update queues configurations
1500         https://bugs.webkit.org/show_bug.cgi?id=196074
1501
1502         Reviewed by Dewei Zhu.
1503
1504         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1505         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1506
1507 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1508
1509         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1510         https://bugs.webkit.org/show_bug.cgi?id=195680
1511         <rdar://problem/48903534>
1512
1513         Unreviewed infrastructure fix.
1514
1515         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1516         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1517
1518 2019-03-21  Andy Estes  <aestes@apple.com>
1519
1520         [iOS] Apple Pay should be available in documents with no user agent scripts
1521         https://bugs.webkit.org/show_bug.cgi?id=196061
1522         <rdar://problem/48649391>
1523
1524         Reviewed by Brady Eidson.
1525
1526         Added API tests and related infrastructure.
1527
1528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1529         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1530         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1531         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1532         (TestWebKitAPI::TEST):
1533         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1534         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1535         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1536         * TestWebKitAPI/cocoa/TestProtocol.mm:
1537         (-[TestProtocol startLoading]):
1538         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1539         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1540         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1541         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1542
1543 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1544
1545         REGRESSSION (r243297): webkitpy tests broken
1546         https://bugs.webkit.org/show_bug.cgi?id=196108
1547
1548         Reviewed by Aakash Jain.
1549
1550         r243297 updated contributors.json, which broke a few unit tests.
1551
1552         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1553         (IRCCommandTest.test_whois):
1554         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1555
1556 2019-03-21  Chris Dumez  <cdumez@apple.com>
1557
1558         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1559         https://bugs.webkit.org/show_bug.cgi?id=196041
1560         <rdar://problem/49083230>
1561
1562         Reviewed by Alex Christensen.
1563
1564         Add API test coverage.
1565
1566         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1567         (TEST):
1568
1569 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1570
1571         Add SPI to inform applications of WKContentRuleList actions
1572         https://bugs.webkit.org/show_bug.cgi?id=195965
1573         <rdar://problem/42664365>
1574
1575         Reviewed by Geoff Garen.
1576
1577         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1578         (TestWebKitAPI::allActionsForResourceLoad):
1579         (TestWebKitAPI::testRequest):
1580         (TestWebKitAPI::TEST_F):
1581         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1582         (Notification::description):
1583         (Notification::operator== const):
1584         (toVector):
1585         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1586         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1587         (makeContentRuleList):
1588         (TEST):
1589         (makeWarnContentRuleList): Deleted.
1590
1591 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1592
1593         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1594         https://bugs.webkit.org/show_bug.cgi?id=196088
1595
1596         Reviewed by Brian Burg.
1597
1598         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1599         Support checks when only one platform is specified. Also deprecate macosx() and
1600         force the use of macos() instead.
1601
1602         * Scripts/webkitpy/style/checkers/cpp.py:
1603         (check_min_versions_of_wk_api_available):
1604         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1605         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1606
1607 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1608
1609         Update status inactive committers' status to 'contributor'.
1610
1611         * Scripts/webkitpy/common/config/contributors.json:
1612
1613 2019-03-21  Xan Lopez  <xan@igalia.com>
1614
1615         [JSC][x86] Drop support for x87 floating point
1616         https://bugs.webkit.org/show_bug.cgi?id=194853
1617
1618         Reviewed by Don Olmstead.
1619
1620         Force SSE2 on x86/32bit builds.
1621
1622         * Scripts/webkitdirs.pm:
1623         (generateBuildSystemFromCMakeProject):
1624
1625 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1626
1627         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1628         https://bugs.webkit.org/show_bug.cgi?id=196073
1629
1630         Reviewed by Michael Catanzaro.
1631
1632         Add test cases to check functions and constructors with no arguments but receiving user data.
1633
1634         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1635         (checkUserData):
1636         (testJSCFunction):
1637         (fooCreateWithUserData):
1638         (testJSCClass):
1639
1640 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1641
1642         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1643
1644         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1645
1646         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1647
1648 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1649
1650         [GTK][WPE] Add API to provide geolocation information
1651         https://bugs.webkit.org/show_bug.cgi?id=195940
1652
1653         Reviewed by Michael Catanzaro.
1654
1655         Add a new test to check the new API.
1656
1657         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1658         (testGeolocationManagerCurrentPosition):
1659         (testGeolocationManagerWatchPosition):
1660         (beforeAll):
1661         (afterAll):
1662         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1663         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1664         (beforeAll): Ditto.
1665         * TestWebKitAPI/glib/CMakeLists.txt:
1666
1667 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1668
1669         [GLib] Returning G_TYPE_OBJECT from a method does not work
1670         https://bugs.webkit.org/show_bug.cgi?id=195574
1671
1672         Reviewed by Michael Catanzaro.
1673
1674         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1675
1676         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1677         (getGFile):
1678         (getParent):
1679         (createGString):
1680         (getGString):
1681         (getGStringCopyWillRaise):
1682         (getGStringCopy):
1683         (getGStringStr):
1684         (getGStringLen):
1685         (freeGString):
1686         (testJSCClass):
1687
1688 2019-03-20  Saam Barati  <sbarati@apple.com>
1689
1690         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1691         https://bugs.webkit.org/show_bug.cgi?id=195721
1692
1693         Reviewed by Filip Pizlo.
1694
1695         * Scripts/run-javascriptcore-tests:
1696
1697 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1698
1699         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1700         https://bugs.webkit.org/show_bug.cgi?id=196049
1701
1702         Reviewed by Tim Horton.
1703
1704         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1705         overflow scrolling in general, so rename it.
1706
1707         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1708
1709 2019-03-20  Daniel Bates  <dabates@apple.com>
1710
1711         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1712         https://bugs.webkit.org/show_bug.cgi?id=196031
1713         <rdar://problem/49078172>
1714
1715         Reviewed by Tim Horton.
1716
1717         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1718         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1719         same code path used when the Done button is pressed to dismiss the <select> picker.
1720
1721         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1722         (TestWebKitAPI::TEST):
1723
1724 2019-03-20  Chris Dumez  <cdumez@apple.com>
1725
1726         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1727         https://bugs.webkit.org/show_bug.cgi?id=196029
1728         <rdar://problem/48954651>
1729
1730         Reviewed by Tim Horton.
1731
1732         Add API test coverage.
1733
1734         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1735
1736 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1737
1738         [ews-build] Improve failure summary string for ApplyPatch step
1739         https://bugs.webkit.org/show_bug.cgi?id=195995
1740
1741         Reviewed by Alexey Proskuryakov.
1742
1743         * BuildSlaveSupport/ews-build/steps.py:
1744         (ApplyPatch.getResultSummary): Override getResultSummary.
1745
1746 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1747
1748         AX: Implement support for new meter ARIA role
1749         https://bugs.webkit.org/show_bug.cgi?id=195966
1750
1751         Reviewed by Chris Fleizach.
1752
1753         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1754         to AXLevelIndicator.
1755
1756         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1757
1758 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1759
1760         [WebAuthN] Implement FIDO AppID extension
1761         https://bugs.webkit.org/show_bug.cgi?id=143491
1762         <rdar://problem/48298273>
1763
1764         Reviewed by Brent Fulgham.
1765
1766         Add a test that covers the new flag of convertToU2fSignCommand.
1767
1768         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1769         (TestWebKitAPI::TEST):
1770         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1771         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1772         (TestWebKitAPI::TEST):
1773
1774 2019-03-19  Keith Rollin  <krollin@apple.com>
1775
1776         Add support for more platforms to generate-xcfilelists
1777         https://bugs.webkit.org/show_bug.cgi?id=195977
1778
1779         Reviewed by Alexey Proskuryakov.
1780
1781         generate-xcfilelists incorrectly complains when involved with building
1782         WebKit for iphonesimulator:
1783
1784             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1785             …
1786             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1787
1788         Address this by teaching generate-xcfilelists about more platforms.
1789
1790         * Scripts/generate-xcfilelists:
1791
1792 2019-03-19  John Wilander  <wilander@apple.com>
1793
1794         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1795         https://bugs.webkit.org/show_bug.cgi?id=195923
1796         <rdar://problem/49001272>
1797
1798         Reviewed by Alex Christensen.
1799
1800         This patch does the following to the TestRunner:
1801         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1802         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1803         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1804
1805         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1806         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1807         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1808         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1809         * WebKitTestRunner/TestController.cpp:
1810         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1811         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1812         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1813         * WebKitTestRunner/TestController.h:
1814         * WebKitTestRunner/TestInvocation.cpp:
1815         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1816
1817 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1818
1819         [CMake] Support more clang and gcc sanitizers
1820         https://bugs.webkit.org/show_bug.cgi?id=195956
1821
1822         Reviewed by Michael Catanzaro.
1823
1824         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1825
1826 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1827
1828         [ews-build] Improve summary for PrintConfiguration step
1829         https://bugs.webkit.org/show_bug.cgi?id=195945
1830
1831         Reviewed by Lucas Forschler.
1832
1833         * BuildSlaveSupport/ews-build/steps.py:
1834         (PrintConfiguration.getResultSummary): Override getResultSummary.
1835
1836 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1837
1838         [ews-build] Improve summary for CheckOutSource step
1839         https://bugs.webkit.org/show_bug.cgi?id=195963
1840
1841         Reviewed by Lucas Forschler.
1842
1843         * BuildSlaveSupport/ews-build/steps.py:
1844         (CheckOutSource.getResultSummary):
1845
1846 2019-03-19  Daniel Bates  <dabates@apple.com>
1847
1848         [iOS] Focus not preserved when switching between tabs
1849         https://bugs.webkit.org/show_bug.cgi?id=195820
1850         <rdar://problem/43614450>
1851
1852         Reviewed by Brent Fulgham.
1853
1854         Add tests to ensure that we restore focus when resigning and becoming first responder.
1855
1856         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1857         (TestWebKitAPI::TEST):
1858
1859 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1860
1861         Make WTFLogChannelState and WTFLogLevel enum classes
1862         https://bugs.webkit.org/show_bug.cgi?id=195904
1863
1864         Reviewed by Eric Carlson.
1865
1866         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1867         (TestWebKitAPI::TEST_F):
1868
1869 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1870
1871         [GStreamer][EME] Backported mssdemux protection data crash fix
1872         https://bugs.webkit.org/show_bug.cgi?id=195918
1873
1874         Reviewed by Philippe Normand.
1875
1876         * gstreamer/jhbuild.modules:
1877         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1878
1879 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1880
1881         Unreviewed, rolling out r243132.
1882
1883         Broke GTK build
1884
1885         Reverted changeset:
1886
1887         "Make WTFLogChannelState and WTFLogLevel enum classes"
1888         https://bugs.webkit.org/show_bug.cgi?id=195904
1889         https://trac.webkit.org/changeset/243132
1890
1891 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1892
1893         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1894
1895         * Scripts/webkitdirs.pm:
1896         (builtDylibPathForName): Adjust the shared library name that's changed
1897         with the API version bump in r243073.
1898
1899 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1900
1901         Make WTFLogChannelState and WTFLogLevel enum classes
1902         https://bugs.webkit.org/show_bug.cgi?id=195904
1903
1904         Reviewed by Eric Carlson.
1905
1906         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1907         (TestWebKitAPI::TEST_F):
1908
1909 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1910
1911         Disable flaky test added in r2431100
1912         https://webkit.org/b/195785
1913
1914         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1915         (TestWebKitAPI::TEST):
1916         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1917
1918 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1919
1920         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1921         https://bugs.webkit.org/show_bug.cgi?id=195916
1922
1923         Reviewed by Tim Horton.
1924
1925         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1926         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1927
1928 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1929
1930         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1931
1932         * Scripts/webkitpy/common/config/contributors.json:
1933
1934 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1935
1936         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1937         https://bugs.webkit.org/show_bug.cgi?id=195785
1938
1939         Reviewed by Geoffrey Garen.
1940
1941         * TestWebKitAPI/TCPServer.cpp: Added.
1942         (TestWebKitAPI::TCPServer::TCPServer):
1943         (TestWebKitAPI::TCPServer::~TCPServer):
1944         (TestWebKitAPI::TCPServer::socketBindListen):
1945         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1946         * TestWebKitAPI/TCPServer.h: Added.
1947         (TestWebKitAPI::TCPServer::port const):
1948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1949         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1950         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1951         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1952         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1953         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1954         (TestWebKitAPI::respondSlowly):
1955         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1956         (TestWebKitAPI::downloadAtRate):
1957         (TestWebKitAPI::TEST):
1958
1959 2019-03-18  Saam Barati  <sbarati@apple.com>
1960
1961         Add a plan file for JetStream 2
1962         https://bugs.webkit.org/show_bug.cgi?id=190734
1963
1964         Reviewed by Mark Lam.
1965
1966         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1967
1968 2019-03-18  Chris Dumez  <cdumez@apple.com>
1969
1970         Delay WebProcess launch until a load is triggered in a Web view
1971         https://bugs.webkit.org/show_bug.cgi?id=195758
1972         <rdar://problem/48126013>
1973
1974         Reviewed by Geoff Garen.
1975
1976         Add API test coverage. Also update some existing API tests to not expect
1977         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1978
1979         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1980         (TestWebKitAPI::TEST):
1981         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1982         (TestWebKitAPI::TEST):
1983         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1984         (TEST):
1985         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1986         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1987         (TEST):
1988         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1989         (TEST):
1990         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1991
1992 2019-03-18  Xan Lopez  <xan@igalia.com>
1993
1994         [CMake] Prevent potential warning when determining $architecture
1995         https://bugs.webkit.org/show_bug.cgi?id=195891
1996
1997         Reviewed by Michael Catanzaro.
1998
1999         It's possible for generateBuildSystemForCMakeProject to be called
2000         before determineArchitecture() is ever called. This will make the
2001         first eq check with $architecture to be bogus (and print a
2002         warning). Change that to an eq check with architecture(), which
2003         implicitly calls determineArchitecture() if needed, and change all
2004         the other similar cases in the method in the same way to prevent
2005         future bugs like this one.
2006
2007         * Scripts/webkitdirs.pm:
2008         (generateBuildSystemFromCMakeProject):
2009
2010 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2011
2012         [WPE] Tarballs generated with “make dist” cannot build documentation
2013         https://bugs.webkit.org/show_bug.cgi?id=195885
2014
2015         Reviewed by Carlos Garcia Campos.
2016
2017         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2018
2019 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2020
2021         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2022         https://bugs.webkit.org/show_bug.cgi?id=195883
2023
2024         Reviewed by Carlos Garcia Campos.
2025
2026         * gtkdoc/gtkdoc.py:
2027         (GTKDoc._run_command): When commands fail to run, include the full command line for
2028         the program invocation and the output it has generated on the standard error stream.
2029
2030 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2031
2032         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2033         https://bugs.webkit.org/show_bug.cgi?id=195786
2034
2035         Reviewed by Philippe Normand.
2036
2037         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2038         * wpe/jhbuild.modules: Ditto.
2039
2040 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2041
2042         [ews-build] Don't run clean builds on EWS builders
2043         https://bugs.webkit.org/show_bug.cgi?id=195851
2044
2045         Reviewed by Geoffrey Garen.
2046
2047         * BuildSlaveSupport/ews-build/factories.py:
2048
2049 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2050
2051         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2052         https://bugs.webkit.org/show_bug.cgi?id=195849
2053
2054         Reviewed by Chris Dumez.
2055
2056         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2057
2058         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2059         (runWebsiteDataStoreCustomPaths):
2060
2061 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2062
2063         webkitpy: Upload test results
2064         https://bugs.webkit.org/show_bug.cgi?id=195755
2065         <rdar://problem/48896182>
2066
2067         Reviewed by Aakash Jain.
2068
2069         Establish a new format for uploading results that is not tied to layout tests, apply
2070         that format to webkitpy tests.
2071
2072         * Scripts/webkitpy/common/checkout/scm/git.py:
2073         (Git.native_branch): Return what branch the current checkout is on.
2074         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2075         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2076         * Scripts/webkitpy/common/checkout/scm/svn.py:
2077         (SVN.native_branch): Ditto.
2078         * Scripts/webkitpy/common/system/platforminfo.py:
2079         (PlatformInfo.build_version): Return a build version for Mac.
2080         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2081         (MockPlatformInfo.__init__):
2082         (MockPlatformInfo.build_version):
2083         * Scripts/webkitpy/results: Added.
2084         * Scripts/webkitpy/results/__init__.py: Added.
2085         * Scripts/webkitpy/results/options.py: Added.
2086         (upload_options): OptParse list for upload options.
2087         * Scripts/webkitpy/results/upload.py: Added.
2088         (Upload): Class which enforces the upload format expected by the results server.
2089         (Upload.Expectations):
2090         (Upload.create_configuration):
2091         (Upload.create_commit):
2092         (Upload.create_details):
2093         (Upload.create_run_stats):
2094         (Upload.create_test_result):
2095         (Upload.__init__):
2096         (Upload.Encoder): Encode Upload object as json.
2097         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2098         * Scripts/webkitpy/results/upload_unittest.py: Added.
2099         * Scripts/webkitpy/test/main.py:
2100         (Tester._parse_args): Add upload arguments.
2101         (Tester._run_tests): Allow results to be uploaded.
2102         * Scripts/webkitpy/test/runner.py:
2103         (Runner.__init__): Record which tests were run, rather than just counting them.
2104         (Runner.handle):
2105         * Scripts/webkitpy/test/runner_unittest.py:
2106         (RunnerTest.test_run):
2107         * Scripts/webkitpy/thirdparty/__init__.py:
2108         (AutoinstallImportHook.find_module): Add requests auto-install.
2109         (AutoinstallImportHook._install_requests):
2110         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2111         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2112
2113 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2114
2115         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2116         https://bugs.webkit.org/show_bug.cgi?id=195810
2117
2118         Reviewed by Tim Horton.
2119
2120         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2121         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2122         ending certain layout tests.
2123
2124         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2125         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2126         (-[TestRunnerWKWebView dealloc]):
2127         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2128
2129         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2130         helper method when destroying the web view, and when resetting state between tests.
2131
2132         * WebKitTestRunner/ios/TestControllerIOS.mm:
2133         (WTR::TestController::platformResetStateToConsistentValues):
2134
2135         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2136
2137 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2138
2139         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2140         https://bugs.webkit.org/show_bug.cgi?id=190350
2141         <rdar://problem/45089503>
2142
2143         Reviewed by Geoffrey Garen.
2144
2145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2146         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2147         (TEST):
2148         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2149         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2150         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2151         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2152         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2153         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2154         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2155         (runTest):
2156         (createDirectories):
2157         (TEST):
2158         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2159         (TEST):
2160         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2161         (TEST):
2162
2163 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2164
2165         Add support to WebPage for getting the contents as an attributed string.
2166         https://bugs.webkit.org/show_bug.cgi?id=195636
2167         rdar://problem/45055697
2168
2169         Reviewed by Tim Horton.
2170
2171         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2172         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2173
2174 2019-03-15  Chris Dumez  <cdumez@apple.com>
2175
2176         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2177         https://bugs.webkit.org/show_bug.cgi?id=195747
2178
2179         Reviewed by Geoff Garen.
2180
2181         Add API test coverage.
2182
2183         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2184
2185 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2186
2187         Unreviewed, rolling out r242952.
2188
2189         Causing API failures on iOS Simulator
2190
2191         Reverted changeset:
2192
2193         "[PSON] Make sure the WebProcessCache is leverage when
2194         relaunching a process after termination"
2195         https://bugs.webkit.org/show_bug.cgi?id=195747
2196         https://trac.webkit.org/changeset/242952
2197
2198 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2199
2200         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2201         https://bugs.webkit.org/show_bug.cgi?id=195740
2202
2203         Reviewed by Ross Kirsling.
2204
2205         window.open doesn't work for WebKitBrowserWindow because it is not
2206         implemented yet.
2207
2208         1. Implemented createNewPage callback of WKPageUIClient.
2209         2. Changed MainWindow to take a BrowserWindow factory function
2210           instead of BrowserWindowType to be flexible to create
2211           BrowserWindow with extra settings.
2212         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2213           because it is not relevant with MainWindow anymore.
2214
2215         * MiniBrowser/win/Common.cpp:
2216         (parseCommandLine):
2217         * MiniBrowser/win/Common.h:
2218         (CommandLineOptions::CommandLineOptions):
2219         * MiniBrowser/win/MainWindow.cpp:
2220         (MainWindow::MainWindow):
2221         (MainWindow::create):
2222         (MainWindow::init):
2223         (MainWindow::WndProc):
2224         * MiniBrowser/win/MainWindow.h:
2225         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2226         (PrintWebUIDelegate::createWebViewWithRequest):
2227         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2228         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2229         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2230         (WebKitBrowserWindow::updateProxySettings):
2231         (WebKitBrowserWindow::createNewPage):
2232         * MiniBrowser/win/WebKitBrowserWindow.h:
2233         * MiniBrowser/win/WinMain.cpp:
2234         (wWinMain):
2235
2236 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2237
2238         Make it possible to test scrolling tree layer manipulation more easily
2239         https://bugs.webkit.org/show_bug.cgi?id=195780
2240
2241         Reviewed by Tim Horton.
2242         
2243         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2244         cuts off communication of scrolling tree scrolls back to the web process
2245         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2246         allows tests to trigger scrolls which run the scrolling tree layer positioning
2247         logic, but never get another commit from the web process that might mask
2248         scrolling tree bugs.
2249         
2250         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2251         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2252         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2253
2254         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2255         (WTR::UIScriptController::scrollUpdatesDisabled const):
2256         (WTR::UIScriptController::setScrollUpdatesDisabled):
2257         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2258         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2259         (WTR::UIScriptController::scrollUpdatesDisabled const):
2260         (WTR::UIScriptController::setScrollUpdatesDisabled):
2261         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2262         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2263         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2264         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2265         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2266         * WebKitTestRunner/ios/TestControllerIOS.mm:
2267         (WTR::TestController::platformResetStateToConsistentValues):
2268         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2269         (WTR::UIScriptController::scrollUpdatesDisabled const):
2270         (WTR::UIScriptController::setScrollUpdatesDisabled):
2271
2272 2019-03-14  Youenn Fablet  <youenn@apple.com>
2273
2274         Move IDB storage in private browsing mode to NetworkProcess
2275         https://bugs.webkit.org/show_bug.cgi?id=195602
2276
2277         Reviewed by Brady Eidson.
2278
2279         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2280         (TEST):
2281
2282 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2283
2284         [ews-build] Make descriptionDone messages more readable
2285         https://bugs.webkit.org/show_bug.cgi?id=195760
2286
2287         Reviewed by Lucas Forschler.
2288
2289         * BuildSlaveSupport/ews-build/steps.py:
2290         * BuildSlaveSupport/ews-build/steps_unittest.py:
2291
2292 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2293
2294         [ews-build] Generate status-bubble hover-over messages
2295         https://bugs.webkit.org/show_bug.cgi?id=195680
2296
2297         Reviewed by Lucas Forschler.
2298
2299         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2300         (StatusBubble):
2301         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2302         on hover-over.
2303         (StatusBubble._iso_time):
2304         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2305         hover-over message.
2306         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2307
2308 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2309
2310         [ews-app] Gracefully handle the case when state_string is None
2311         https://bugs.webkit.org/show_bug.cgi?id=195753
2312
2313         Reviewed by Lucas Forschler.
2314
2315         * BuildSlaveSupport/ews-app/ews/models/build.py:
2316         * BuildSlaveSupport/ews-app/ews/models/step.py:
2317
2318 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2319
2320         [ews-app] Status bubble display pending for currently running build step
2321         https://bugs.webkit.org/show_bug.cgi?id=195744
2322
2323         Reviewed by Lucas Forschler.
2324
2325         * BuildSlaveSupport/ews-build/events.py:
2326         (Events.stepStarted): If state_string is pending, replace it with step name.
2327
2328 2019-03-14  Chris Dumez  <cdumez@apple.com>
2329
2330         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2331         https://bugs.webkit.org/show_bug.cgi?id=195750
2332
2333         Reviewed by Geoffrey Garen.
2334
2335         Add API test coverage.
2336
2337         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2338         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2339         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2340         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2341
2342 2019-03-14  Chris Dumez  <cdumez@apple.com>
2343
2344         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2345         https://bugs.webkit.org/show_bug.cgi?id=195747
2346
2347         Reviewed by Geoff Garen.
2348
2349         Add API test coverage.
2350
2351         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2352
2353 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2354
2355         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2356         https://bugs.webkit.org/show_bug.cgi?id=195725
2357         <rdar://problem/48545062>
2358
2359         Reviewed by Tim Horton.
2360
2361         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2362         handler is nil.
2363
2364         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2365         (TestWebKitAPI::TEST):
2366
2367 2019-03-13  Sam Weinig  <sam@webkit.org>
2368
2369         Add utility function to allow easy reverse range-based iteration of a container
2370         https://bugs.webkit.org/show_bug.cgi?id=195542
2371
2372         Reviewed by Antti Koivisto.
2373
2374         * TestWebKitAPI/CMakeLists.txt:
2375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2376         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2377         (TestWebKitAPI::TEST):
2378         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2379
2380 2019-03-13  Chris Dumez  <cdumez@apple.com>
2381
2382         Use a ServiceWorker process per registrable domain
2383         https://bugs.webkit.org/show_bug.cgi?id=195649
2384
2385         Reviewed by Youenn Fablet.
2386
2387         Update API test coverage.
2388
2389         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2390
2391 2019-03-13  Chris Dumez  <cdumez@apple.com>
2392
2393         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2394         https://bugs.webkit.org/show_bug.cgi?id=195684
2395         <rdar://problem/48294714>
2396
2397         Reviewed by Antti Koivisto.
2398
2399         Add API test coverage.
2400
2401         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2402
2403 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2404
2405         [ews-app] Remove unused patch view
2406         https://bugs.webkit.org/show_bug.cgi?id=195669
2407
2408         Reviewed by Lucas Forschler.
2409
2410         * BuildSlaveSupport/ews-app/ews/urls.py:
2411         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2412
2413 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2414
2415         [ews-app] Use Buildbot result code variables
2416         https://bugs.webkit.org/show_bug.cgi?id=195668
2417
2418         Reviewed by Alexey Proskuryakov.
2419
2420         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2421         (Buildbot): Added Buildbot result code variables.
2422         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2423         (StatusBubble._build_bubble): Used Buildbot result code variables.
2424
2425 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2426
2427         [Flatpak] Expand submodule recursively
2428         https://bugs.webkit.org/show_bug.cgi?id=195672
2429
2430         Building WPE with flatpak was impossible without that as it was raising an exception.
2431         Also update wpebackend-fdo to match what is built in jhbuild
2432
2433         Reviewed by Philippe Normand.
2434
2435         * flatpak/flatpakutils.py:
2436         (expand_submodules_recurse):
2437         (expand_manifest):
2438         * flatpak/org.webkit.WPEModules.yaml:
2439
2440 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2441
2442         [ews-app] status bubble should be hidden for certain builds
2443         https://bugs.webkit.org/show_bug.cgi?id=194597
2444
2445         Reviewed by Dewei Zhu.
2446
2447         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2448         (StatusBubble._build_bubble):
2449         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2450         because the patch didn't have relevant changes.
2451         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2452         in production yet.
2453
2454 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2455
2456         [Win] Fix a slew of simple clang-cl warnings.
2457         https://bugs.webkit.org/show_bug.cgi?id=195652
2458
2459         Reviewed by Don Olmstead.
2460
2461         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2462         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2463
2464 2019-03-12  Justin Fan  <justin_fan@apple.com>
2465
2466         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2467         https://bugs.webkit.org/show_bug.cgi?id=195518
2468         <rdar://problem/46322356>
2469
2470         Reviewed by Myles C. Maxfield.
2471
2472         * DumpRenderTree/DerivedSources-input.xcfilelist:
2473         * DumpRenderTree/DerivedSources-output.xcfilelist:
2474
2475 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2476
2477         Unreviewed, rolling out r242825.
2478         https://bugs.webkit.org/show_bug.cgi?id=195648
2479
2480         "Broke webkitpy tests with my change to
2481         lldb_dump_class_layout.py" (Requested by rmorisset on
2482         #webkit).
2483
2484         Reverted changeset:
2485
2486         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2487         classes with suspicious padding"
2488         https://bugs.webkit.org/show_bug.cgi?id=195573
2489         https://trac.webkit.org/changeset/242825
2490
2491 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2492
2493         [ews-build] Show status bubbles while the patch is waiting in queue
2494         https://bugs.webkit.org/show_bug.cgi?id=195618
2495
2496         Reviewed by Lucas Forschler.
2497
2498         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2499         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2500         enabled in initial deployment.
2501         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2502         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2503         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2504         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2505         (StatusBubble._build_bubbles_for_patch):
2506
2507 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2508
2509         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2510         https://bugs.webkit.org/show_bug.cgi?id=195573
2511
2512         Reviewed by Simon Fraser.
2513
2514         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2515
2516         * Scripts/dump-class-layout:
2517         (main):
2518         * lldb/lldb_dump_class_layout.py:
2519         (ClassLayout.__init__):
2520         (ClassLayout._compute_padding_recursive):
2521         (LLDBDebuggerInstance.dump_layout_for_classname):
2522         (LLDBDebuggerInstance):
2523         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2524         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2525
2526 2019-03-12  Chris Dumez  <cdumez@apple.com>
2527
2528         Device Orientation access permission should be denied unless explicitly granted by the client
2529         https://bugs.webkit.org/show_bug.cgi?id=195625
2530
2531         Reviewed by Youenn Fablet.
2532
2533         add API test coverage.
2534
2535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2536         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2537         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2538         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2539         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2540         (runDeviceOrientationTest):
2541         (TEST):
2542         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2543         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2544
2545 2019-03-12  Jer Noble  <jer.noble@apple.com>
2546
2547         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2548         https://bugs.webkit.org/show_bug.cgi?id=195137
2549         <rdar://problem/48810307>
2550
2551         Reviewed by Eric Carlson.
2552
2553         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2554         (TestWebKitAPI::TEST):
2555
2556 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2557
2558         [ews-build] Change urls from uat to production
2559         https://bugs.webkit.org/show_bug.cgi?id=195566
2560
2561         Reviewed by Lucas Forschler.
2562
2563         * BuildSlaveSupport/ews-app/ews/config.py:
2564         * BuildSlaveSupport/ews-build/events.py:
2565         * BuildSlaveSupport/ews-build/steps.py:
2566
2567 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2568
2569         [ews-build] change max_builds for local-worker to 1
2570         https://bugs.webkit.org/show_bug.cgi?id=195568
2571
2572         Reviewed by Lucas Forschler.
2573
2574         * BuildSlaveSupport/ews-build/loadConfig.py:
2575
2576 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2577
2578         Fix the build
2579
2580         * TestRunnerShared/spi/PencilKitTestSPI.h:
2581         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2582
2583 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2584
2585         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2586         https://bugs.webkit.org/show_bug.cgi?id=194131
2587
2588         Reviewed by Michael Catanzaro.
2589
2590         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2591         (uriChanged):
2592         (testUnfinishedSubresourceLoad):
2593         (serverCallback):
2594         (beforeAll):
2595
2596 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2597
2598         WTF::Expected should use std::addressof instead of operator&
2599         https://bugs.webkit.org/show_bug.cgi?id=195604
2600
2601         Reviewed by Myles Maxfield.
2602
2603         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2604         (TestWebKitAPI::Unique::Unique):
2605         (TestWebKitAPI::Unique::operator&):
2606         (TestWebKitAPI::TEST):
2607
2608 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2609
2610         Add Optional to Forward.h.
2611         https://bugs.webkit.org/show_bug.cgi?id=195586
2612
2613         Reviewed by Darin Adler.
2614
2615         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2616         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2617         Remove unnecessary includes from headers.
2618
2619 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2620
2621         Add testing API to hit-test and scroll overflow scrollers
2622         https://bugs.webkit.org/show_bug.cgi?id=195278
2623
2624         Reviewed by Antti Koivisto.
2625         
2626         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2627         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2628         
2629         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2630
2631         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2632         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2633         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2634         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2635         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2636         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2637         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2638         (WTR::enclosingScrollViewIncludingSelf):
2639         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2640
2641 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2642
2643         API test WebKit.RequestTextInputContext fails on iOS
2644         https://bugs.webkit.org/show_bug.cgi?id=195585
2645
2646         Reviewed by Wenson Hsieh and Simon Fraser.
2647
2648         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2649         (applyStyle):
2650         (TEST):
2651         Add a viewport, so that the coordinates match up on iOS.
2652         Scroll by moving the UIScrollView's contentOffset.
2653
2654 2019-03-11  Chris Dumez  <cdumez@apple.com>
2655
2656         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2657         https://bugs.webkit.org/show_bug.cgi?id=195506
2658         <rdar://problem/48733477>
2659
2660         Reviewed by Alex Christensen.
2661
2662         Add API test coverage.
2663
2664         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2665
2666 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2667
2668         Adding myself to contributors.json
2669
2670         Unreviewed, addming myself to contributors.json .
2671
2672         * Scripts/webkitpy/common/config/contributors.json:
2673
2674 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2675
2676         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2677         https://bugs.webkit.org/show_bug.cgi?id=195511
2678         <rdar://problem/44873269>
2679
2680         Reviewed by Darin Adler.
2681
2682         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2683         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2684         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2685         (TEST_F):
2686
2687 2019-03-11  Chris Dumez  <cdumez@apple.com>
2688
2689         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2690         https://bugs.webkit.org/show_bug.cgi?id=195561
2691
2692         Reviewed by Youenn Fablet.
2693
2694         Make sure the JS in the test requests for permission to receive device orientation events.
2695
2696         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2697
2698 2019-03-11  Youenn Fablet  <youenn@apple.com>
2699
2700         Allow storage quota increase by default in WTR
2701         https://bugs.webkit.org/show_bug.cgi?id=195541
2702
2703         Reviewed by Geoffrey Garen.
2704
2705         Allow storage quota increase by default in WTR.
2706         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2707         Use this for tests that explicitly need cache increase.
2708
2709         Instead of increasing quota by 2, make sure the next request is
2710         granted by adding all given parameters.
2711
2712         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2713         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2714         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2715         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2716         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2717         * WebKitTestRunner/TestController.cpp:
2718         (WTR::TestController::setAllowStorageQuotaIncrease):
2719         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2720         * WebKitTestRunner/TestController.h:
2721         * WebKitTestRunner/TestInvocation.cpp:
2722         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2723         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2724         (WTR::TestController::cocoaResetStateToConsistentValues):
2725         (WTR::TestController::setAllowStorageQuotaIncrease):
2726         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2727         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2728         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2729
2730 2019-03-11  Xan Lopez  <xan@igalia.com>
2731
2732         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2733         https://bugs.webkit.org/show_bug.cgi?id=194147
2734
2735         Reviewed by Michael Saboff.
2736
2737         To make --32-bit work correctly on Linux/64bit we need to:
2738
2739         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2740         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2741         unfortunately CMake only allows us to do this during
2742         crosscompilation, which is overkill here.
2743         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2744         pkg-config detection module uses the x86 .pc files instead of the
2745         x86_64 ones.
2746         - Set the -m32 flags for the compiler.
2747
2748         * Scripts/webkitdirs.pm:
2749         (generateBuildSystemFromCMakeProject):
2750
2751 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2752
2753         Add MotionMark-1.1 plan file for run-benchmark script.
2754         https://bugs.webkit.org/show_bug.cgi?id=195481
2755
2756         Rubber-stamped by Darin Adler.
2757
2758         Run-benchmark script should support MontionMark-1.1.
2759
2760         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2761
2762 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2763
2764         [ews-app] Add support for submit-to-ews url
2765         https://bugs.webkit.org/show_bug.cgi?id=195477
2766
2767         Reviewed by Lucas Forschler.
2768
2769         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2770         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2771         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2772         * BuildSlaveSupport/ews-app/ews/urls.py:
2773         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2774
2775 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2776
2777         Unreviewed, rolling out r242688, r242643, r242624.
2778
2779         Caused multiple layout test failures and crashes on iOS and macOS.
2780
2781         Reverted changeset:
2782
2783         "requestAnimationFrame should execute before the next frame"
2784         https://bugs.webkit.org/show_bug.cgi?id=177484
2785         https://trac.webkit.org/changeset/242624/webkit
2786
2787         * Tracing/SystemTracePoints.plist:
2788
2789 2019-03-11  John Wilander  <wilander@apple.com>
2790
2791         Resource Load Statistics: Make it possible exclude localhost from classification
2792         https://bugs.webkit.org/show_bug.cgi?id=195474
2793         <rdar://problem/47520577>
2794
2795         Reviewed by Brent Fulgham.
2796
2797         This patch allows for localhost to be excluded from classification and
2798         treatment as a prevalent resource.
2799
2800         The WebKit Tools change adds a new function called
2801         testRunner.setStatisticsIsRunningTest() which can be used to control this
2802         behavior.
2803
2804         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2805         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2806         (WTR::TestRunner::setStatisticsIsRunningTest):
2807         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2808         * WebKitTestRunner/TestController.cpp:
2809         (WTR::TestController::setStatisticsIsRunningTest):
2810         * WebKitTestRunner/TestController.h:
2811         * WebKitTestRunner/TestInvocation.cpp:
2812         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2813
2814 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2815
2816         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2817         https://bugs.webkit.org/show_bug.cgi?id=195560
2818
2819         Reviewed by Lucas Forschler.
2820
2821         * BuildSlaveSupport/ews-build/master.cfg:
2822
2823 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2824
2825         Unreviewed, rolling out r242698.
2826
2827         API test crashes on bots.
2828
2829         Reverted changeset:
2830
2831         "Add a WKContentRuleList variant that uses copied memory
2832         instead of mmap'd shared memory for class A containerized
2833         apps"
2834         https://bugs.webkit.org/show_bug.cgi?id=195511
2835         https://trac.webkit.org/changeset/242698
2836
2837 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2838
2839         [WPE] Enable web process sandbox
2840         https://bugs.webkit.org/show_bug.cgi?id=195169
2841
2842         Reviewed by Daniel Bates.
2843
2844         * wpe/install-dependencies:
2845         * wpe/jhbuild.modules:
2846
2847 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2848
2849         [ews-app] Use port 17000 for worker communication
2850         https://bugs.webkit.org/show_bug.cgi?id=195558
2851
2852         Reviewed by Lucas Forschler.
2853
2854         * BuildSlaveSupport/ews-build/master.cfg:
2855
2856 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2857
2858         [ews-build] unit-tests fail when passwords.json is missing
2859         https://bugs.webkit.org/show_bug.cgi?id=195557
2860
2861         Reviewed by Lucas Forschler.
2862
2863         * BuildSlaveSupport/ews-build/loadConfig.py:
2864         (loadBuilderConfig):
2865         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2866         (ConfigDotJSONTest.test_configuration):
2867         * BuildSlaveSupport/ews-build/master.cfg:
2868
2869 2019-03-11  Truitt Savell  <tsavell@apple.com>
2870
2871         Unreviewed, rolling out r242702.
2872
2873         Broke High Sierra builders.
2874
2875         Reverted changeset:
2876
2877         "Add utility function to allow easy reverse range-based
2878         iteration of a container"
2879         https://bugs.webkit.org/show_bug.cgi?id=195542
2880         https://trac.webkit.org/changeset/242702
2881
2882 2019-03-11  Sam Weinig  <sam@webkit.org>
2883
2884         Add utility function to allow easy reverse range-based iteration of a container
2885         https://bugs.webkit.org/show_bug.cgi?id=195542
2886
2887         Reviewed by Antti Koivisto.
2888
2889         * TestWebKitAPI/CMakeLists.txt:
2890         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2891         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2892         (TestWebKitAPI::TEST):
2893         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2894
2895 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2896
2897         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2898         https://bugs.webkit.org/show_bug.cgi?id=195511
2899         <rdar://problem/44873269>
2900
2901         Reviewed by Darin Adler.
2902
2903         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2904         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2905         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2906         (TEST_F):
2907
2908 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2909
2910         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2911         https://bugs.webkit.org/show_bug.cgi?id=195499
2912
2913         Reviewed by Darin Adler.
2914
2915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2916         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2917         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2918         (-[WKWebView synchronouslyFocusTextInputContext:]):
2919         (applyStyle):
2920         (applyIframe):
2921         (TEST):
2922         Add some tests for this SPI.
2923
2924 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2925
2926         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2927         https://bugs.webkit.org/show_bug.cgi?id=181151
2928
2929         Reviewed by Don Olmstead.
2930
2931         * TestWebKitAPI/CMakeLists.txt:
2932         * TestWebKitAPI/PlatformWin.cmake:
2933         Enable TestWTF RunLoop tests in all platforms.
2934
2935         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2936         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2937         (TestWebKitAPI::DerivedOneShotTimer::fired):
2938         (TestWebKitAPI::TEST):
2939         Only a few platforms support nested RunLoop.
2940
2941         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2942         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2943
2944 2019-03-10  David Quesada  <david_quesada@apple.com>
2945
2946         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2947         https://bugs.webkit.org/show_bug.cgi?id=152480
2948
2949         Reviewed by Chris Dumez.
2950
2951         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2952         there are no additional references to the process pool besides the one held by
2953         the download, waits for the download to finish (in the sense that the
2954         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2955         measure, also check that the process pool has been deallocated at the end of the
2956         test. The test wouldn't be meaningful if the process pool were still alive.
2957
2958         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2959         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2960         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2961             The download will be canceled because the delegate does not implement the
2962             method to decide the download's destination, so this is where we know the
2963             DownloadProxyMap is done with the DownloadProxy.
2964         (TEST):
2965
2966 2019-03-08  Chris Dumez  <cdumez@apple.com>
2967
2968         Add support for Device Orientation / Motion permission API
2969         https://bugs.webkit.org/show_bug.cgi?id=195329
2970         <rdar://problem/47645367>
2971
2972         Reviewed by Geoffrey Garen.
2973
2974         Add test infrastructure to help test the Device Orientation / Motion permission API.
2975
2976         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2977         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2978         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2979         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2980         * WebKitTestRunner/TestController.cpp:
2981         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2982         (WTR::TestController::createWebViewWithOptions):
2983         (WTR::TestController::resetStateToConsistentValues):
2984         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2985         * WebKitTestRunner/TestController.h:
2986         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2987         * WebKitTestRunner/TestInvocation.cpp:
2988         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2989
2990 2019-03-08  Saam barati  <sbarati@apple.com>
2991
2992         Add a compare-results script to compare benchmark results
2993         https://bugs.webkit.org/show_bug.cgi?id=195486
2994         <rdar://problem/48723397>
2995
2996         Reviewed by Geoffrey Garen.
2997
2998         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2999         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3000         to extend it to learn about our other benchmarks.
3001
3002         * Scripts/compare-results: Added.
3003         (readJSONFile):
3004         (detectJetStream2):
3005         (JetStream2Results):
3006         (detectSpeedometer2):
3007         (Speedometer2Results):
3008         (detectPLT5):
3009         (PLT5Results):
3010         (detectBenchmark):
3011         (biggerIsBetter):
3012         (ttest):
3013         (getOptions):
3014         (main):
3015
3016 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3017
3018         Ensure old tab state is cleared between iterations of run-benchmark
3019         https://bugs.webkit.org/show_bug.cgi?id=195393
3020         <rdar://problem/46885583>
3021
3022         Reviewed by Dewei Zhu.
3023
3024         a) ensure the default to restore state is not set
3025         b) terminate Safari correctly
3026         c) Set the system default to ignore Persistent State in Safari
3027
3028         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3029         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3030         (OSXBrowserDriver.prepare_env): 
3031         (OSXBrowserDriver.restore_env):
3032         (OSXBrowserDriver.close_browsers):
3033         (OSXBrowserDriver._terminate_processes):
3034         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3035         (OSXChromeDriver):
3036         (OSXChromeCanaryDriver):
3037         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3038         (OSXFirefoxDriver):
3039         (OSXFirefoxNightlyDriver):
3040         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3041         (OSXSafariDriver):
3042         (OSXSafariDriver.prepare_env):
3043
3044 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3045
3046         [GTK] Several InputMethodFilter tests are failing
3047         https://bugs.webkit.org/show_bug.cgi?id=195408
3048
3049         Reviewed by Carlos Garcia Campos.
3050
3051         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3052         Regressed in r241751.
3053         Hexadecimal values of keycodes are expressed now in upper letters.
3054         Composited characters should be cast to UTF8 strings.
3055
3056         (TestWebKitAPI::TEST):
3057
3058 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3059
3060         [GTK] Make Tools/gtkdoc python3 compatible
3061         https://bugs.webkit.org/show_bug.cgi?id=195359
3062
3063         Reviewed by Carlos Garcia Campos.
3064
3065         * gtkdoc/generate-gtkdoc:
3066         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3067         work with Python 2 and 3.
3068         (get_gtkdoc_module_paths):
3069         The iteritems() was removed in Python 3, so let's use items() that's
3070         available in Python 2 and 3.
3071         (get_generator_for_config):
3072         * gtkdoc/gtkdoc.py:
3073         (GTKDoc._run_command):
3074         The sys.stdout.write() is expecting str in Python 3 and not bytes
3075         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3076         for passing the bytes there.
3077
3078 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3079
3080         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3081         https://bugs.webkit.org/show_bug.cgi?id=195346
3082         <rdar://problem/48667048>
3083
3084         Unreviewed build fix for clang-cl.
3085
3086         * DumpRenderTree/win/DumpRenderTree.cpp:
3087         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3088
3089 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3090
3091         requestAnimationFrame should execute before the next frame
3092         https://bugs.webkit.org/show_bug.cgi?id=177484
3093
3094         Reviewed by Simon Fraser.
3095
3096         Add trace points for the page RenderingUpdate.
3097
3098         * Tracing/SystemTracePoints.plist:
3099
3100 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3101
3102         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3103         https://bugs.webkit.org/show_bug.cgi?id=195353
3104         <rdar://problem/48626394>
3105
3106         Reviewed by Simon Fraser.
3107
3108         * WebKitTestRunner/ios/TestControllerIOS.mm:
3109         (WTR::TestController::platformResetPreferencesToConsistentValues):
3110
3111 2019-03-07  John Wilander  <wilander@apple.com>
3112
3113         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3114         https://bugs.webkit.org/show_bug.cgi?id=195383
3115         <rdar://problem/48570136>
3116
3117         Reviewed by Brent Fulgham.
3118
3119         This patch adds test infrastructure to purge only script-accessible cookies,
3120         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3121
3122         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3123         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3124         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3125         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3126         * WebKitTestRunner/TestController.cpp:
3127         (WTR::TestController::statisticsDeleteCookiesForHost):
3128         * WebKitTestRunner/TestController.h:
3129         * WebKitTestRunner/TestInvocation.cpp:
3130         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3131
3132 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3133
3134         Unreviewed, rolling out r242354.
3135         https://bugs.webkit.org/show_bug.cgi?id=195402
3136
3137         breaks layout tests in all configurations (Requested by
3138         zdobersek on #webkit).
3139
3140         Reverted changeset:
3141
3142         "[WPE] Enable web process sandbox"
3143         https://bugs.webkit.org/show_bug.cgi?id=195169
3144         https://trac.webkit.org/changeset/242354
3145
3146 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3147
3148         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3149         https://bugs.webkit.org/show_bug.cgi?id=195346
3150
3151         Reviewed by Fujii Hironori.
3152
3153         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3154         (TestWebKitAPI::TEST):
3155         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3156
3157         * DumpRenderTree/win/DumpRenderTree.cpp:
3158         (findFontFallback):
3159         (addFontFallbackIfPresent):
3160         (removeFontFallbackIfPresent):
3161         (main):
3162         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3163         (TestWebKitAPI::Util::moduleDirectory):
3164         (TestWebKitAPI::Util::createInjectedBundlePath):
3165         Use wchar helpers as needed.
3166
3167 2019-03-06  Rob Buis  <rbuis@igalia.com>
3168
3169         Consider supporting the `referrerpolicy` attribute.
3170         https://bugs.webkit.org/show_bug.cgi?id=179053
3171
3172         Reviewed by Darin Adler.
3173
3174         Add a runtime flag for referrerpolicy attribute.
3175
3176         * DumpRenderTree/mac/DumpRenderTree.mm:
3177         (enableExperimentalFeatures):
3178
3179 2019-03-05  Daniel Bates  <dabates@apple.com>
3180
3181         Update expected API test result following r242379
3182         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3183
3184         Update expected x-coordinate of selection rect now that the left padding of
3185         a textarea is sized in ems (so dependent on the font size) just like the left
3186         padding of a text field.
3187
3188         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3189         (TestWebKitAPI::TEST):
3190
3191 2019-03-05  David Quesada  <david_quesada@apple.com>
3192
3193         [WK2] It should be possible to follow links with 'download' attributes
3194         https://bugs.webkit.org/show_bug.cgi?id=195145
3195         rdar://problem/48462642
3196
3197         Reviewed by Alex Christensen.
3198
3199         Add a unit test to verify that activating links with 'download' attributes now
3200         navigates to the linked resource, rather than starts downloading it. Add another
3201         to verify that it is still possible to explicitly download the link via the
3202         'Download' navigation action policy.
3203
3204         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3205         (-[DownloadAttributeTestDelegate init]):
3206         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3207         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3208         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3209         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3210         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3211         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3212         (TEST):
3213         * WebKitTestRunner/TestController.cpp:
3214         (WTR::TestController::decidePolicyForNavigationAction):
3215         * WebKitTestRunner/TestController.h:
3216
3217 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3218
3219         [Curl] Implement Cookie Accept Policy.
3220         https://bugs.webkit.org/show_bug.cgi?id=191645
3221
3222         Reviewed by Fujii Hironori.
3223
3224         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3225         (TestWebKitAPI::Curl::TEST_F):
3226
3227 2019-03-05  Youenn Fablet  <youenn@apple.com>
3228
3229         Rename requestCacheStorageSpace to requestStorageSpace
3230         https://bugs.webkit.org/show_bug.cgi?id=195282
3231
3232         Reviewed by Chris Dumez.
3233
3234         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3235         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3236         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3237
3238 2019-03-05  Brady Eidson  <beidson@apple.com>
3239
3240         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3241         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3242
3243         Reviewed by Tim Horton.
3244
3245         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3246         different directory into that same WKWebView should work.
3247
3248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3249         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3250
3251 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3252
3253         Add WeakHashSet
3254         https://bugs.webkit.org/show_bug.cgi?id=195152
3255
3256         Reviewed by Antti Koivisto.
3257
3258         Added tests for WeakHashSet.
3259
3260         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3261         (TestWebKitAPI::Base::Base): Moved.
3262         (TestWebKitAPI::Derived::foo): Moved.
3263         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3264         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3265         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3266         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3267
3268 2019-03-04  Chris Dumez  <cdumez@apple.com>
3269
3270         Do not share WebProcesses between private and regular sessions
3271         https://bugs.webkit.org/show_bug.cgi?id=195189
3272         <rdar://problem/48421064>
3273
3274         Reviewed by Alex Christensen.
3275
3276         Add API test coverage.
3277
3278         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3279         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3280
3281 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3282
3283         [WPE] Enable web process sandbox
3284         https://bugs.webkit.org/show_bug.cgi?id=195169
3285
3286         Reviewed by Daniel Bates.
3287
3288         * wpe/install-dependencies:
3289         * wpe/jhbuild.modules:
3290
3291 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3292
3293         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3294         https://bugs.webkit.org/show_bug.cgi?id=195206
3295
3296         Reviewed by Žan Doberšek.
3297
3298         Add a new test case.
3299
3300         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3301         (testJSCClass):
3302
3303 2019-03-04  Charlie Turner  <cturner@igalia.com>
3304
3305         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3306         https://bugs.webkit.org/show_bug.cgi?id=194898
3307
3308         Reviewed by Žan Doberšek.
3309
3310         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3311         a GCC extension that permits arithmetic on void* pointer. Inline
3312         the macro until this issue is fixed upstream.
3313
3314 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3315
3316         Rid the world of WK_API_ENABLED
3317         https://bugs.webkit.org/show_bug.cgi?id=195263
3318
3319         Reviewed by Dan Bernstein.
3320
3321         List of changed files elided because it's useless.
3322
3323 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3324
3325         Unreviewed follow-up to r242292.
3326
3327         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3328
3329         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3330         (TestWebKitAPI::testStrip): Renamed from strip.
3331         (TestWebKitAPI::TEST):
3332
3333 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3334
3335         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3336
3337         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3338         and bug #194272 for details.
3339
3340         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3341
3342 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3343
3344         Remove some more unused 32-bit code
3345         https://bugs.webkit.org/show_bug.cgi?id=195255
3346
3347         Reviewed by Darin Adler.
3348
3349         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3350         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3351         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3352         (NPP_New):
3353         (NPP_HandleEvent):
3354         (handleEventCarbon): Deleted.
3355
3356 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3357
3358         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3359
3360         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3361         (TestWebKitAPI::TEST):
3362
3363 2019-03-01  Darin Adler  <darin@apple.com>
3364
3365         Finish removing String::format
3366         https://bugs.webkit.org/show_bug.cgi?id=194893
3367
3368         Reviewed by Daniel Bates.
3369 '
3370         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3371
3372 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3373
3374         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3375         https://bugs.webkit.org/show_bug.cgi?id=195229
3376         <rdar://problem/48520362>
3377
3378         Reviewed by Chris Dumez.
3379
3380         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3381         (TEST):
3382
3383 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3384
3385         Add a system trace scope for event region building
3386         https://bugs.webkit.org/show_bug.cgi?id=195226
3387
3388         Reviewed by Jon Lee.
3389
3390         This trace scope measures the time spend converting element rects into Region objects,
3391         which can be large on some pages.
3392
3393         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3394
3395         * Tracing/SystemTracePoints.plist:
3396
3397 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3398
3399         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3400         https://bugs.webkit.org/show_bug.cgi?id=194612
3401
3402         Reviewed by Alex Christensen.
3403
3404         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3405         Just test the new string-processing function and don't touch the actual environment.
3406         (Test cases are all as before, but based on operator== instead of strcmp.)
3407
3408 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3409
3410         [ews-app] Update primary keys for handling multiple Buildbot instances
3411         https://bugs.webkit.org/show_bug.cgi?id=195120
3412
3413         Reviewed by Stephanie Lewis.
3414
3415         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3416         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3417         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3418
3419         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3420         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3421         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3422         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3423         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3424         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3425
3426 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3427
3428         [WinCairo] Enable service worker
3429         https://bugs.webkit.org/show_bug.cgi?id=188318
3430
3431         Reviewed by Youenn Fablet.
3432
3433         * DumpRenderTree/DumpRenderTreePrefix.h:
3434         * TestWebKitAPI/PlatformWin.cmake:
3435         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3436         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3437         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3438
3439 2019-03-01  Justin Fan  <justin_fan@apple.com>
3440
3441         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3442         https://bugs.webkit.org/show_bug.cgi?id=195191
3443
3444         Rubber-stamped by Dean Jackson.
3445
3446         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3447
3448         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3449
3450 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3451
3452         Unreviewed, fix lldb webkitpy tests
3453         https://bugs.webkit.org/show_bug.cgi?id=194375
3454
3455         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3456
3457         * lldb/lldb_webkit.py:
3458         (WTFStringImplProvider.is_8bit):
3459
3460 2019-02-28  David Quesada  <david_quesada@apple.com>
3461
3462         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3463         https://bugs.webkit.org/show_bug.cgi?id=195121
3464         rdar://problem/48450302
3465
3466         Reviewed by Alex Christensen.
3467
3468         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3469         configurations where the 'download' attribute is absent, blank, or populated
3470         with a filename, and where the anchor element is same-origin or cross-origin
3471         (meaning the 'download' attribute shouldn't be honored).
3472
3473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3474         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3475         (-[NavigationActionTestDelegate init]):
3476         (-[NavigationActionTestDelegate navigationAction]):
3477         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3478         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3479         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3480         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3481         (TEST):
3482
3483 2019-02-28  Antoine Quint  <graouts@apple.com>
3484
3485         Enable the Pointer Events runtime flag by default
3486         https://bugs.webkit.org/show_bug.cgi?id=195156
3487
3488         Reviewed by Dean Jackson.
3489
3490         * DumpRenderTree/mac/DumpRenderTree.mm:
3491         (enableExperimentalFeatures):
3492
3493 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3494
3495         Several PasteImage API tests are flaky
3496         https://bugs.webkit.org/show_bug.cgi?id=195160
3497
3498         Reviewed by Tim Horton.
3499
3500         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3501         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3502         listening for a "load" event after image load is already complete.
3503
3504         To address this, make these tests first register a "load" event handler, then run script to insert an image
3505         element into the document, and finally wait until the load event is observed before checking image size.
3506
3507         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3508
3509 2019-02-28  Chris Dumez  <cdumez@apple.com>
3510
3511         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3512         https://bugs.webkit.org/show_bug.cgi?id=195107
3513
3514         Reviewed by Alex Christensen.
3515
3516         Give some time for the zoom level to get restored.
3517
3518         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3519
3520 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3521
3522         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3523         https://bugs.webkit.org/show_bug.cgi?id=194958
3524
3525         Reviewed by Geoffrey Garen.
3526
3527         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3528         (TEST):
3529
3530 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3531
3532         [ews-app] Update method to save build to handle builder_display_name
3533         https://bugs.webkit.org/show_bug.cgi?id=195047
3534
3535         Reviewed by Dewei Zhu.
3536
3537         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3538         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3539
3540 2019-02-28  Justin Fan  <justin_fan@apple.com>
3541
3542         [Web GPU] Enable Web GPU only on 64-bit
3543         https://bugs.webkit.org/show_bug.cgi?id=195139
3544
3545         Because Metal is only supported on 64 bit apps.
3546
3547         Unreviewed build fix.
3548
3549         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3550
3551 2019-02-27  Youenn Fablet  <youenn@apple.com>
3552
3553         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3554         https://bugs.webkit.org/show_bug.cgi?id=194959
3555
3556         Reviewed by Chris Dumez.
3557
3558         Spin loop until getting the condition to remove flakiness.
3559
3560         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3561
3562 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3563
3564         [ews-build] Buildbot should include builder_display_name in the build events
3565         https://bugs.webkit.org/show_bug.cgi?id=195045
3566
3567         Reviewed by Dewei Zhu.
3568
3569         * BuildSlaveSupport/ews-build/events.py:
3570         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3571         buildername to builder_name to be consistent in naming style.
3572         (Events.buildFinished): Ditto.
3573
3574 2019-02-27  Chris Dumez  <cdumez@apple.com>
3575
3576         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3577         https://bugs.webkit.org/show_bug.cgi?id=194480
3578
3579         Reviewed by Brady Eidson.
3580
3581         Update existing API test to make it more likely to reproduce the issue.
3582
3583         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3584
3585 2019-02-27  Brady Eidson  <beidson@apple.com>
3586
3587         Universal links from Google search results pages don't open the app.
3588         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3589
3590         Reviewed by Geoffrey Garen.
3591
3592         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3593         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3594         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3595         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3596
3597 2019-02-27  Chris Dumez  <cdumez@apple.com>
3598
3599         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3600         https://bugs.webkit.org/show_bug.cgi?id=195102
3601
3602         Reviewed by Geoffrey Garen.
3603
3604         If the number of processes is not yet what we expect, wait a bit and check again to give
3605         processes some time to exit.
3606
3607         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3608
3609 2019-02-27  Chris Dumez  <cdumez@apple.com>
3610
3611         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3612         https://bugs.webkit.org/show_bug.cgi?id=194545
3613
3614         Reviewed by Brady Eidson.
3615
3616         Make sure the test navigates forward and then back only once. Previously, navigating
3617         back would trigger a navigation again in a timer.
3618
3619         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3620
3621 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3622
3623         High Sierra Debug JSC test queue should use faster hardware
3624         https://bugs.webkit.org/show_bug.cgi?id=194603
3625
3626         Rubber-stamped by Alexey Proskuryakov.
3627
3628         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3629
3630         * BuildSlaveSupport/build.webkit.org-config/config.json:
3631         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3632         (BubbleQueueServer):
3633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3634         (WebKitBuildbot):
3635         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3636         * QueueStatusServer/config/queues.py:
3637         * Scripts/webkitpy/common/config/ews.json:
3638         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3639         (test_ews_name):
3640
3641 2019-02-27  John Wilander  <wilander@apple.com>
3642
3643         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3644         https://bugs.webkit.org/show_bug.cgi?id=195071
3645         <rdar://problem/48417690>
3646
3647         Reviewed by Alex Christensen and Brent Fulgham.
3648
3649         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3650         (TestWebKitAPI::createURL):
3651             Convenience function.
3652         (TestWebKitAPI::TEST):
3653             WebCore::AdClickAttribution now takes a URL when creating Source and
3654             Destination.
3655         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3656         (TestWebKitAPI::TEST):
3657             WebCore::AdClickAttribution now takes a URL when creating Source and
3658             Destination.
3659
3660 2019-02-27  Antoine Quint  <graouts@apple.com>
3661
3662         Support Pointer Events on macOS
3663         https://bugs.webkit.org/show_bug.cgi?id=195008
3664         <rdar://problem/47454419>
3665
3666         Reviewed by Dean Jackson.
3667
3668         * DumpRenderTree/mac/DumpRenderTree.mm:
3669         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3670         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3671
3672 2019-02-26  Mark Lam  <mark.lam@apple.com>
3673
3674         Remove remaining poisoning code.
3675         https://bugs.webkit.org/show_bug.cgi?id=194138
3676
3677         Reviewed by Saam Barati.
3678
3679         * TestWebKitAPI/CMakeLists.txt:
3680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3681         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3682         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3683         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3684         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3685         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3686         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3687
3688 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3689
3690         Move ephemeral local storage from WebProcess to UIProcess
3691         https://bugs.webkit.org/show_bug.cgi?id=195074
3692         <rdar://problem/47937975>
3693
3694         Reviewed by Geoff Garen.
3695
3696         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3697
3698 2019-02-20  Jer Noble  <jer.noble@apple.com>
3699
3700         [Cocoa] Media elements will restart network buffering just before suspending
3701         https://bugs.webkit.org/show_bug.cgi?id=193691
3702
3703         Reviewed by Eric Carlson.
3704
3705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3706         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3707         (TEST):
3708
3709 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3710
3711         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3712         https://bugs.webkit.org/show_bug.cgi?id=191652
3713
3714         Reviewed by Alex Christensen.
3715
3716         Fix WinCairo MiniBrowser behavior of authentication dialog.
3717
3718         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3719         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3720
3721 2019-02-26  Youenn Fablet  <youenn@apple.com>
3722
3723         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3724         https://bugs.webkit.org/show_bug.cgi?id=195028
3725         <rdar://problem/48243733>
3726
3727         Reviewed by Eric Carlson.
3728
3729         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3730
3731 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3732
3733         [WPE] Add API for webview background color configuration
3734         https://bugs.webkit.org/show_bug.cgi?id=192305
3735
3736         Reviewed by Michael Catanzaro.
3737
3738         * MiniBrowser/wpe/main.cpp:
3739         (main): Add a new option to configure the webview background
3740         color. Example: --bg-color=transparent.
3741         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3742         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3743         (beforeAll): Ditto.
3744
3745 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3746
3747         scalableNativeWebpageParameters() is not preserved on new page navigation.
3748         https://bugs.webkit.org/show_bug.cgi?id=194892
3749         <rdar://problem/47538280>
3750
3751         Reviewed by Wenson Hsieh.
3752         
3753         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3754
3755         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3756         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3757         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3758         (WTR::UIScriptController::allowsViewportShrinkToFit):
3759         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3760         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3761         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3762         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3763         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3764         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3765
3766 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3767
3768         [ews-app] Add model for handling multiple Buildbot instances
3769         https://bugs.webkit.org/show_bug.cgi?id=194863
3770
3771         Reviewed by Stephanie Lewis.
3772
3773         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3774
3775 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3776
3777         [ews-app] Remove BuilderMapping table
3778         https://bugs.webkit.org/show_bug.cgi?id=194961
3779
3780         Reviewed by Stephanie Lewis.
3781
3782         Store builder name directly in build table, instead of having a separate
3783         table for it.
3784
3785         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3786         * BuildSlaveSupport/ews-app/ews/models/build.py:
3787         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3788         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3789
3790 2019-02-25  John Wilander  <wilander@apple.com>
3791
3792         Introduce and adopt new class RegistrableDomain for eTLD+1
3793         https://bugs.webkit.org/show_bug.cgi?id=194791
3794         <rdar://problem/48179240>
3795
3796         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3797
3798         This patch adds an API test and replaces two instances of
3799         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3800
3801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3802         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3803         (TestWebKitAPI::TEST):
3804             Changed two strings to make sure the registrable domains are still considered
3805             invalid and pass the test.
3806         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3807         (TestWebKitAPI::TEST):
3808         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3809         (WTR::InjectedBundle::didReceiveMessageToPage):
3810
3811 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3812
3813         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3814         https://bugs.webkit.org/show_bug.cgi?id=195001
3815
3816         Reviewed by Carlos Garcia Campos.
3817
3818         API version 1.0 always includes the functionality previously guarded with
3819         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3820         unconditionally.
3821
3822         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3823         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3824         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3825         (WebViewTest::showInWindow): Ditto.
3826         (WebViewTest::hideView): Ditto.
3827         * wpe/backends/HeadlessViewBackend.cpp:
3828         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3829         * wpe/backends/ViewBackend.cpp:
3830         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3831         * wpe/backends/WindowViewBackend.cpp:
3832         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3833         WPE_BACKEND_CHECK_VERSION().
3834         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3835
3836 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3837
3838         [Flatpak] Add support for flatpak > 1.1.2
3839         https://bugs.webkit.org/show_bug.cgi?id=194088
3840
3841         Flatpak 1.2 is now out so we need to support that
3842         version now.
3843
3844         Reviewed by Michael Catanzaro.
3845
3846         * flatpak/flatpakutils.py:
3847         (check_flatpak):
3848         (FlatpakPackages.__init__):
3849         (FlatpakPackages.__detect_packages):
3850         (FlatpakPackages.__detect_packages.in):
3851         (FlatpakRepos.update):
3852
3853 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3854
3855         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3856         https://bugs.webkit.org/show_bug.cgi?id=194998
3857
3858         Reviewed by Carlos Garcia Campos.
3859
3860         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3861         to a Git checkout and using the latest commit containing various fixes
3862         and improvements.
3863
3864 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3865
3866         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3867         https://bugs.webkit.org/show_bug.cgi?id=194981
3868
3869         Reviewed by Žan Doberšek.
3870
3871         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3872         (TestWebKitAPI::TEST):
3873
3874 2019-02-23  Keith Miller  <keith_miller@apple.com>
3875
3876         Add new mac target numbers
3877         https://bugs.webkit.org/show_bug.cgi?id=194955
3878
3879         Reviewed by Tim Horton.
3880
3881         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3882         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3883         * MiniBrowser/Configurations/Base.xcconfig:
3884         * TestWebKitAPI/Configurations/Base.xcconfig:
3885         * WebKitTestRunner/Configurations/Base.xcconfig:
3886
3887 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3888
3889         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3890         https://bugs.webkit.org/show_bug.cgi?id=194846
3891
3892         Reviewed by Don Olmstead.
3893
3894         Added _search_paths() and _port_specific_expectations_files() for
3895         WinCairoPort.
3896
3897         * Scripts/webkitpy/port/win.py:
3898         (WinCairoPort.default_baseline_search_path):
3899         (WinCairoPort):
3900         (WinCairoPort._port_specific_expectations_files):
3901         (WinCairoPort._search_paths):
3902
3903 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3904
3905         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3906         https://bugs.webkit.org/show_bug.cgi?id=194963
3907
3908         Reviewed by Dean Jackson.
3909
3910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3911         Do a `contains` check instead of `equals`, because in debug builds we
3912         put the GraphicsLayer pointer in a prefix.
3913
3914 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3915
3916         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3917         https://bugs.webkit.org/show_bug.cgi?id=194873
3918         <rdar://problem/46701974>
3919
3920         Reviewed by Tim Horton.
3921
3922         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3923
3924         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3925         (WTR::UIScriptController::menuRect const):
3926         (WTR::UIScriptController::isShowingMenu const):
3927         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3928         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3929         (WTR::UIScriptController::menuRect const):
3930
3931         Add a function to query the bounds of the callout menu in content coordinates.
3932
3933         (WTR::UIScriptController::isShowingMenu const):
3934
3935         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3936
3937         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3938         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3939         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3940         (WTR::UIScriptController::rectForMenuAction const):
3941         (WTR::UIScriptController::menuRect const):
3942         (WTR::UIScriptController::isShowingMenu const):
3943         (WTR::findViewInHierarchyOfType): Deleted.
3944
3945 2019-02-22  Chris Dumez  <cdumez@apple.com>
3946
3947         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3948         https://bugs.webkit.org/show_bug.cgi?id=194954
3949         <rdar://problem/48127957>
3950
3951         Reviewed by Alex Christensen.
3952
3953         Add API test coverage.
3954
3955         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3956         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3957         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3958         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3959
3960 2019-02-22  Chris Dumez  <cdumez@apple.com>
3961
3962         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3963         https://bugs.webkit.org/show_bug.cgi?id=194924
3964         <rdar://problem/48216125>
3965
3966         Reviewed by Geoffrey Garen.
3967
3968         Add API test coverage.
3969
3970         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3971
3972 2019-02-22  Chris Dumez  <cdumez@apple.com>
3973
3974         Unreviewed, disable API test added in r241928 on iOS.
3975
3976         The cache is not enabled on devices with less than 3GB of RAM.
3977
3978         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3979
3980 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3981
3982         Hardcode Visual Viewports on everywhere except iOS WK1
3983         https://bugs.webkit.org/show_bug.cgi?id=194928
3984
3985         Reviewed by Zalan Bujtas.
3986
3987         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3988         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3989         set it to false. The setting has shipped for several years and there's no need to turn
3990         it off now.
3991
3992         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3993         Visual Viewports are not enabled.
3994         
3995         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3996         that only runs in WK2
3997
3998         * MiniBrowser/mac/SettingsController.h:
3999         * MiniBrowser/mac/SettingsController.m:
4000         (-[SettingsController init]):
4001         (-[SettingsController _populateMenu]):
4002         (-[SettingsController validateMenuItem:]):
4003         (-[SettingsController visualViewportEnabled]): Deleted.
4004         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4005         * MiniBrowser/mac/WK1BrowserWindowController.m:
4006         (-[WK1BrowserWindowController didChangeSettings]):
4007         * MiniBrowser/mac/WK2BrowserWindowController.m:
4008         (-[WK2BrowserWindowController didChangeSettings]):
4009
4010 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4011
4012         Discard cached processes when clearing website data store
4013         https://bugs.webkit.org/show_bug.cgi?id=194894
4014
4015         Reviewed by Chris Dumez.
4016
4017         Added a test case.
4018
4019         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4020         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4021
4022 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4023
4024         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4025         https://bugs.webkit.org/show_bug.cgi?id=194914
4026         <rdar://problem/47586889>
4027
4028         Reviewed by Geoffrey Garen.
4029
4030         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4031         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4032         (TEST):
4033         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4034
4035 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4036
4037         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4038         <https://webkit.org/b/194761>
4039
4040         Reviewed by Myles Maxfield.
4041
4042         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4043         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4044         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4045         to use ARC-compliant cast.
4046         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4047         ARC-compliant cast.
4048         (WTR::installFakeHelvetica): Log `error` to console if
4049         CTFontManagerRegisterFontsForURL() fails, but only on supported
4050         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4051         Call CFRelease() on `error` to fix the leak.  Update to use
4052         ARC-compliant cast.
4053         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4054         cast.
4055
4056 2019-02-21  Chris Dumez  <cdumez@apple.com>
4057
4058         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4059         https://bugs.webkit.org/show_bug.cgi?id=194481
4060
4061         Reviewed by Alex Christensen.
4062
4063         Give the processes a chance to shutdown and wait until we reached the expected number
4064         of processes.
4065
4066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4067
4068 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4069
4070         Fix the macOS build
4071
4072         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4073
4074 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4075
4076         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4077
4078         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4079         I am a backwards.
4080
4081 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4082
4083         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4084
4085         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4086         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4087         We could force on UI-side compositing, but I feel like the test might be more
4088         valuable exercising the normal path on each platform (though the original
4089         bug was also UI-side specific). Though we can't validate that the overlay
4090         layer was installed successfully, there are layout tests that do that.
4091
4092 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4093
4094         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4095         https://bugs.webkit.org/show_bug.cgi?id=194845
4096         <rdar://problem/47944579>
4097
4098         Reviewed by Antti Koivisto.
4099
4100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4101         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4102
4103 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4104
4105         [LFC][Floats] Add support for placing formatting roots in-between floats.
4106         https://bugs.webkit.org/show_bug.cgi?id=194902
4107
4108         Reviewed by Antti Koivisto.
4109
4110         * LayoutReloaded/misc/LFC-passing-tests.txt:
4111
4112 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4113
4114         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4115         https://bugs.webkit.org/show_bug.cgi?id=194901
4116
4117         Unreviewed build fix.
4118
4119         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4120         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4121         WPEBackend-fdo-0.1 as library name.
4122
4123 2019-02-21  Rob Buis  <rbuis@igalia.com>
4124
4125         Update MIME type parser
4126         https://bugs.webkit.org/show_bug.cgi?id=180526
4127
4128         Reviewed by Darin Adler.
4129
4130         Add tests involving leading and trailing whitespace, non-token
4131         characters and quoted strings.
4132
4133         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4134         (TestWebKitAPI::TEST):
4135
4136 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4137
4138         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4139         https://bugs.webkit.org/show_bug.cgi?id=194884
4140
4141         Reviewed by Michael Catanzaro.
4142
4143         * PlatformWin.cmake:
4144
4145 2019-02-20  Chris Dumez  <cdumez@apple.com>
4146
4147         Add API test for <rdar://problem/47471222>
4148         https://bugs.webkit.org/show_bug.cgi?id=194847
4149
4150         Reviewed by Alex Christensen.
4151
4152         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4153
4154 2019-02-20  Chris Dumez  <cdumez@apple.com>
4155
4156         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4157         https://bugs.webkit.org/show_bug.cgi?id=194872
4158         <rdar://problem/47924500>
4159
4160         Reviewed by Alex Christensen.
4161
4162         Add API test coverage.
4163
4164         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4165
4166 2019-02-20  Jer Noble  <jer.noble@apple.com>
4167
4168         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4169         https://bugs.webkit.org/show_bug.cgi?id=191332
4170
4171         Reviewed by Dean Jackson.
4172
4173         * Scripts/git-is-in-range: Added.
4174
4175 2019-02-20  Andy Estes  <aestes@apple.com>
4176
4177         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4178         https://bugs.webkit.org/show_bug.cgi?id=194869
4179
4180         Rubber-stamped by Jer Noble.
4181
4182         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4183         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4184         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4185         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4187         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4188
4189 2019-02-20  Chris Dumez  <cdumez@apple.com>
4190
4191         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4192         https://bugs.webkit.org/show_bug.cgi?id=194857
4193         <rdar://problem/47759323>
4194
4195         Reviewed by Alex Christensen.
4196
4197         Add API test coverage.
4198
4199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4200
4201 2019-02-20  Chris Dumez  <cdumez@apple.com>
4202
4203         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4204         https://bugs.webkit.org/show_bug.cgi?id=194829
4205         <rdar://problem/47889906>
4206
4207         Reviewed by Alexey Proskuryakov.
4208
4209         Every time the TestOptions were changing we were creating both a new Web view and
4210         a new WKContext, which would start a new Network process. In most cases, we only
4211         need to contruct a new Web view and we do can keep reusing the same WKContext.
4212         This patch implements this optimization and thus avoids spinning a lot of new
4213         Network processes while running the layout tests.
4214
4215         * WebKitTestRunner/TestController.cpp:
4216         (WTR::TestController::generateContextConfiguration const):
4217         (WTR::TestController::generatePageConfiguration):
4218         (WTR::TestController::createWebViewWithOptions):
4219         (WTR::TestController::resetPreferencesToConsistentValues):
4220         (WTR::updateTestOptionsFromTestHeader):
4221         * WebKitTestRunner/TestController.h:
4222         * WebKitTestRunner/TestOptions.h:
4223         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4224         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4225         (WTR::TestOptions::hasSameInitializationOptions const):
4226         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4227         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4228         (WTR::TestController::platformAddTestOptions const):
4229
4230 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4231
4232         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4233         https://bugs.webkit.org/show_bug.cgi?id=167941
4234
4235         Reviewed by Carlos Garcia Campos.
4236
4237         * MiniBrowser/gtk/main.c:
4238         (filterSavedCallback): Added.
4239         (main): Support loading a JSON rule set file for content filtering.
4240         * MiniBrowser/wpe/main.cpp:
4241         (filterSavedCallback): Added.
4242         (main): Support loading a JSON rule set file for content filtering.
4243         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4244         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4245         (WTF::derefGPtr): Ditto.
4246         (testEmptyStore):
4247         (testSaveInvalidFilter):
4248         (testSaveLoadFilter):
4249         (testSavedFilterIdentifierMatch):
4250         (testRemoveFilter):
4251         (testSaveMultipleFilters):
4252         (testSaveFilterFromFile):
4253         (testFilterPersistence):
4254         (beforeAll):
4255         (afterAll):
4256         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4257         (removeOldInjectedContentAndResetLists): Also reset content filters.
4258         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4259         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4260         the element affected by the style sheet.
4261         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4262         and returns it to be used by tests.
4263         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4264         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4265         (serverCallback): Add support for serving a CSS style sheet for testing.
4266         (beforeAll): Add call to testUserContentManagerContentFilter().
4267         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4268
4269 2019-02-19  Keith Rollin  <krollin@apple.com>
4270
4271         Add timing information to build output
4272         https://bugs.webkit.org/show_bug.cgi?id=194839
4273         <rdar://problem/48219609>
4274
4275         Reviewed by Alexey Proskuryakov.
4276
4277         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4278         emit each project's build time to its output. E.g.,
4279
4280             ** BUILD SUCCEEDED ** [0.132 sec]
4281
4282         * Scripts/webkitdirs.pm:
4283         (XcodeOptions):
4284
4285 2019-02-19  Truitt Savell  <tsavell@apple.com>
4286
4287         Unreviewed, rolling out r241784.
4288
4289         Broke all OpenSource builds.
4290
4291         Reverted changeset:
4292
4293         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4294         instances view"
4295         https://bugs.webkit.org/show_bug.cgi?id=172848
4296         https://trac.webkit.org/changeset/241784
4297
4298 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4299
4300         [LFC][Floats] Remove redundant intersecting logic
4301         https://bugs.webkit.org/show_bug.cgi?id=194804
4302
4303         Reviewed by Antti Koivisto.
4304
4305         * LayoutReloaded/misc/LFC-passing-tests.txt:
4306
4307 2019-02-19  Dean Jackson  <dino@apple.com>
4308
4309         Clean-up output from generate-xcfilelists so it can be filtered
4310         https://bugs.webkit.org/show_bug.cgi?id=194795
4311
4312         Reviewed by Joseph Pecoraro (and Keith Rollin).
4313
4314         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4315         make a slight tweak to filter-build-webkit so such lines are marked
4316         as plain.
4317
4318         * Scripts/filter-build-webkit:
4319         * Scripts/generate-xcfilelists:
4320
4321 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4322
4323         pytest is not correctly auto-installed
4324         https://bugs.webkit.org/show_bug.cgi?id=194707
4325
4326         Reviewed by Carlos Garcia Campos.
4327
4328         * Scripts/webkitpy/thirdparty/__init__.py:
4329         (AutoinstallImportHook._install_pytest):
4330
4331 2019-02-18  Chris Dumez  <cdumez@apple.com>
4332
4333         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4334         https://bugs.webkit.org/show_bug.cgi?id=194797
4335         <rdar://problem/48055151>
4336
4337         Reviewed by Geoffrey Garen.
4338
4339         Add API test coverage.
4340
4341         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4342
4343 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4344
4345         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4346         https://bugs.webkit.org/show_bug.cgi?id=194670
4347         <rdar://problem/39066529>
4348
4349         Reviewed by Tim Horton.
4350
4351         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4352         pasted in an editable area as attachment elements.
4353
4354         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4355         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4356         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4357         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4358         (TestWebKitAPI::TEST):
4359         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4360         (WTR::InjectedBundlePage::InjectedBundlePage):
4361
4362 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4363
4364         Fix API test after r241728
4365        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4366
4367         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4368         (TEST):
4369         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4370
4371 2019-02-18  Daniel Bates  <dabates@apple.com>
4372
4373         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4374         https://bugs.webkit.org/show_bug.cgi?id=192824
4375         <rdar://problem/47100332>
4376
4377         Reviewed by Wenson Hsieh.
4378
4379         Fix a bug where the wrong usage code was used for F13 thru F24.
4380
4381         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4382         (keyCodeForDOMFunctionKey):
4383
4384 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4385
4386         Bytecode cache should a have a boot-specific validation
4387         https://bugs.webkit.org/show_bug.cgi?id=194769