Cleanup: Move flatten-trie to loader.
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-12  Julie Parent  <jparent@chromium.org>
2
3         Cleanup: Move flatten-trie to loader.
4         https://bugs.webkit.org/show_bug.cgi?id=112196
5
6         Reviewed by Dirk Pranke.
7
8         flatten-trie is used only by the loader, so move it there and make it
9         private, rather than global in dashbaord_base. Moved the corresponding
10         unit test from flakiness_dashboard_unittests to loader_unittests.
11         
12         * TestResultServer/static-dashboards/dashboard_base.js:
13         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
14         * TestResultServer/static-dashboards/loader.js:
15         (.):
16         * TestResultServer/static-dashboards/loader_unittests.js:
17
18 2013-03-12  Oliver Hunt  <oliver@apple.com>
19
20         Unbreak api tests
21
22         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
23         (TestWebKitAPI):
24
25 2013-03-12  Tim Horton  <timothy_horton@apple.com>
26
27         Unreviewed, disabling tests for Win EWS.
28
29         win-ews obviously cannot keep up with running tests, it's >300 behind.
30         Probably doesn't help that its (likely) running tests serially.
31
32         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
33         (WinEWS):
34
35 2013-03-12  Tim Horton  <timothy_horton@apple.com>
36
37         Add a --build-directory argument to delete-stale-build-files
38         https://bugs.webkit.org/show_bug.cgi?id=112198
39
40         Reviewed by Ryosuke Niwa.
41
42         * BuildSlaveSupport/delete-stale-build-files:
43         (main): Add --build-directory argument.
44
45 2013-03-12  Oliver Hunt  <oliver@apple.com>
46
47         Appease MSVC
48
49         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
50         (TestWebKitAPI):
51
52 2013-03-12  Oliver Hunt  <oliver@apple.com>
53
54         Add more Checked<> tests
55         https://bugs.webkit.org/show_bug.cgi?id=112190
56
57         Reviewed by Geoffrey Garen.
58
59         Tests!
60
61         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
62         (TestWebKitAPI):
63
64 2013-03-12  Julie Parent  <jparent@chromium.org>
65
66         Cleanup: Move loading complete function into callback, rather than global.
67         https://bugs.webkit.org/show_bug.cgi?id=112167
68
69         Reviewed by Dirk Pranke.
70         
71         Stop calling global functions, pass in proper handler to Loader
72         constructor. Note that the callback is optional, as tests, and
73         some potential dashboards, do not need one.
74
75         * TestResultServer/static-dashboards/dashboard_base.js:
76         * TestResultServer/static-dashboards/loader.js:
77         (.):
78         * TestResultServer/static-dashboards/loader_unittests.js:
79
80 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
81
82         [EFL][WK2] Add popup menu support to MiniBrowser
83         https://bugs.webkit.org/show_bug.cgi?id=108934
84
85         Reviewed by Kenneth Rohde Christiansen.
86
87         Implement popup menu support in MiniBrowser by handling popup_menu_show
88         and popup_menu_hide smart functions on the view and using the Ewk popup
89         menu API.
90
91         * MiniBrowser/efl/main.c:
92         (_Browser_Window):
93         (on_popup_menu_discarded):
94         (on_popup_menu_item_clicked):
95         (popup_menu_populate):
96         (on_popup_menu_show):
97         (on_popup_menu_hide):
98         (window_create): Use calloc() instead of malloc() to allocate memory for
99         Browser_Window. This makes sure all the structs members are initialized
100         to 0 (such as the new elm_popup_menu pointer).
101
102 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
103
104         [GTK] Set up the libPlatformGtk.la library
105         https://bugs.webkit.org/show_bug.cgi?id=111738
106
107         Reviewed by Martin Robinson.
108
109         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
110         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
111         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
112
113 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
114
115         [GTK] Enable Web Audio in development builds
116         https://bugs.webkit.org/show_bug.cgi?id=111831
117
118         Reviewed by Philippe Normand.
119
120         Web Audio is already quite well supported on the GTK port but still has a few issues
121         that must be addressed before it is enabled by default. Despite that it should be enabled
122         in development builds just so we are up-to-date with future feature infrastructure changes.
123         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
124         that's an obvious goal before enabling the feature in release builds.
125
126         * Scripts/webkitperl/FeatureList.pm:
127
128 2013-03-11  Andreas Kling  <akling@apple.com>
129
130         [Mac][WK1] Add support for alert() in MiniBrowser.
131         <http://webkit.org/b/112090>
132
133         Reviewed by Anders Carlsson.
134
135         * MiniBrowser/mac/WK1BrowserWindowController.m:
136         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
137
138 2013-03-11  Julie Parent  <jparent@chromium.org>
139
140         Dashboard cleanup: Create ui.Errors
141         https://bugs.webkit.org/show_bug.cgi?id=111785
142
143         Reviewed by Ojan Vafai.
144         
145         Create ui.Errors for handling errors the dashboards
146         encounter. Loader now has a Error object that it can add to,
147         and individual dashboards can show errors when desired.
148         Currently, only flakiness_db shows errors, but this is 
149         generic and there is no reason why other dbs wouldn't want to
150         show errors.
151
152         * TestResultServer/static-dashboards/dashboard_base.js:
153         (resourceLoadingComplete):
154         * TestResultServer/static-dashboards/flakiness_dashboard.js:
155         (generatePage):
156         * TestResultServer/static-dashboards/loader.js:
157         (.):
158         * TestResultServer/static-dashboards/ui.js:
159         (.):
160
161 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
162
163         Some StringHasher tests are broken because of missing null termination
164         https://bugs.webkit.org/show_bug.cgi?id=111284
165
166         Reviewed by Darin Adler.
167
168         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
169         (TestWebKitAPI): Added null termination since C strings are null-terminated.
170         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
171         the bug caught by it is now fixed.
172
173 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
174
175         Unreviewed, rolling out r145200.
176         http://trac.webkit.org/changeset/145200
177         https://bugs.webkit.org/show_bug.cgi?id=112063
178
179         Broke a couple of unit tests (Requested by zdobersek on
180         #webkit).
181
182         * Scripts/webkitperl/FeatureList.pm:
183
184 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
185
186         [GTK] WebKit2-only build fails
187         https://bugs.webkit.org/show_bug.cgi?id=112033
188
189         Reviewed by Gustavo Noronha Silva.
190
191         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
192         generic part, WebKit1-specific part and WebKit2-specific part.
193         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
194         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
195         directly.
196
197 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
198
199         Adding myself to the committers list.
200
201         Unreviewed.
202
203         * Scripts/webkitpy/common/config/committers.py:
204
205 2013-03-11  Jeff Rogers  <jrogers@rim.com>
206
207         [BlackBerry] Disable MathML support
208         https://bugs.webkit.org/show_bug.cgi?id=111929
209
210         Reviewed by Rob Buis.
211
212         * Scripts/webkitperl/FeatureList.pm:
213
214 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
215
216         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
217         https://bugs.webkit.org/show_bug.cgi?id=111970
218
219         Reviewed by Chris Fleizach.
220
221         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
222         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
223         undefined symbol.
224
225         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
226         (WTR::AccessibilityUIElement::supportedActions):
227         (WTR):
228
229 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
230
231         [chromium] Android apk targets should depend directly on Java library targets
232         https://bugs.webkit.org/show_bug.cgi?id=111746
233
234         Reviewed by Eric Seidel.
235
236         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
237         Make DumpRenderTree_apk depend directly on base_java and net_java.
238         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
239         Make TestWebKitAPI_apk depend directly on base_java.
240
241 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
242
243         [chromium] remove obsolete user gesture methods from WebFrame
244         https://bugs.webkit.org/show_bug.cgi?id=111696
245
246         Reviewed by Adam Barth.
247
248         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
249         (WebTestRunner::TestPlugin::handleInputEvent):
250         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
251
252 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
253
254         Unreviewed, add myself to commiters.py.
255
256         * Scripts/webkitpy/common/config/committers.py:
257
258 2013-03-08  Julie Parent  <jparent@chromium.org>
259
260         Cleanup: Remove dead code.
261         https://bugs.webkit.org/show_bug.cgi?id=111900
262
263         Reviewed by Dirk Pranke.
264         
265         Treemap overrides a global function that used to be in 
266         dashboard_base, but was removed months ago in
267         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
268         no caller. 
269
270         * TestResultServer/static-dashboards/treemap.html:
271
272 2013-03-08  Harald Alvestrand  <hta@chromium.org>
273
274         Implemented new API for RTCStatsReport object.
275         https://bugs.webkit.org/show_bug.cgi?id=110333
276
277         Reviewed by Adam Barth.
278
279         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
280         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
281
282 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
283
284         [chromium] use custom freetype on linux asan builds again
285         https://bugs.webkit.org/show_bug.cgi?id=111884
286
287         Reviewed by Tony Chang.
288
289         We no longer need the workaround after chromium r186540.
290
291         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
292
293 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
294
295         Warning about the user not having edit rights on Bugzilla is confusing new contributors
296         https://bugs.webkit.org/show_bug.cgi?id=111798
297
298         Reviewed by Dirk Pranke.
299
300         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
301
302         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
303
304 2013-03-08  James Robinson  <jamesr@chromium.org>
305
306         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
307         https://bugs.webkit.org/show_bug.cgi?id=111632
308
309         Reviewed by Adrienne Walker.
310
311         * DumpRenderTree/chromium/WebViewHost.cpp:
312         (WebViewHost::initializeLayerTreeView):
313         * DumpRenderTree/chromium/WebViewHost.h:
314         (WebViewHost):
315
316 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
317
318         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
319         https://bugs.webkit.org/show_bug.cgi?id=111297
320
321         Reviewed by Kenneth Rohde Christiansen.
322
323         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
324         (WTR::TestRunner::setViewModeMediaFeature):
325
326 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
327
328         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
329         https://bugs.webkit.org/show_bug.cgi?id=111814
330
331         Reviewed by Ryosuke Niwa.
332
333         Add the needed supportedActions() attribute to WKTestRunner.
334
335         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
336         (WTR::AccessibilityUIElement::supportedActions):
337         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
338         (AccessibilityUIElement):
339         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
340         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
341         (WTR::AccessibilityUIElement::supportedActions):
342
343 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
344
345         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
346         https://bugs.webkit.org/show_bug.cgi?id=111851
347
348         Reviewed by Kenneth Rohde Christiansen.
349
350         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
351         (TestWebKitAPI::TEST):
352
353             Fixed WKURLRef instance leaking.
354
355 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
356
357         [EFL] [WK2] Some authentication tests fail in WebKit2
358         https://bugs.webkit.org/show_bug.cgi?id=106407
359
360         Reviewed by Kenneth Rohde Christiansen.
361
362         Add patch from upstream for libsoup 2.40 to fix several authentication
363         test cases.
364
365         * efl/jhbuild.modules:
366         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
367
368 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
369
370         [GTK] Enable Web Audio in development builds
371         https://bugs.webkit.org/show_bug.cgi?id=111831
372
373         Reviewed by Philippe Normand.
374
375         Web Audio is already quite well supported on the GTK port but still has a few issues
376         that must be addressed before it is enabled by default. Despite that it should be enabled
377         in development builds just so we are up-to-date with future feature infrastructure changes.
378         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
379         that's an obvious goal before enabling the feature in release builds.
380
381         * Scripts/webkitperl/FeatureList.pm:
382
383 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
384
385         [chromium] delay clearing the TestRunners until the main view was deleted
386         https://bugs.webkit.org/show_bug.cgi?id=111823
387
388         Reviewed by Eric Seidel.
389
390         During WebViewHost::shutdown, we navigate the WebView to about:blank.
391         This may call into the test runners which assume that the delegate is
392         always non-NULL.
393
394         * DumpRenderTree/chromium/TestShell.cpp:
395         (TestShell::~TestShell):
396
397 2013-03-07  Alan Cutter  <alancutter@chromium.org>
398
399         Sheriffbot whois command can't search by full name
400         https://bugs.webkit.org/show_bug.cgi?id=111825
401
402         Reviewed by Eric Seidel.
403
404         Allowed multiple arguments to Sheriffbot's whois command.
405         Updated test expectations.
406
407         * Scripts/webkitpy/tool/bot/irc_command.py:
408         (Whois.execute):
409         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
410         (IRCCommandTest.test_whois):
411
412 2013-03-07  Nils Barth  <nbarth@chromium.org>
413
414         Add Nils Barth and Koji Hara to committers.py
415         https://bugs.webkit.org/show_bug.cgi?id=111806
416
417         Reviewed by Eric Seidel.
418
419         * Scripts/webkitpy/common/config/committers.py:
420
421 2013-03-07  Glenn Adams  <glenn@skynav.com>
422
423         run-pert-tests should have a --test-runner-count option
424         https://bugs.webkit.org/show_bug.cgi?id=111726
425
426         Reviewed by Ryosuke Niwa.
427
428         Add --test-runner-count option to run-perf-tests, with default value of 4.
429         This option allows command line configuration of the number of times to invoke
430         the test runner (serially, not in parallel) when running a specific test in
431         a test set.
432
433         * Scripts/webkitpy/performance_tests/perftest.py:
434         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
435         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
436         (PerfTest.run): Rename process_run_count to test_runner_count.
437         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
438         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
439         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
440         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
441         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
442         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
443         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
444         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
445         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
446         (MainTest.test_run_with_repeat):
447         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
448         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
449         (MainTest.test_default_args): Add test for default option argument values.
450         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
451
452 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
453
454         Add myself to reviewers.py
455         https://bugs.webkit.org/show_bug.cgi?id=111757
456
457         Reviewed by Eric Seidel.
458
459         * Scripts/webkitpy/common/config/committers.py:
460
461 2013-03-07  Glenn Adams  <glenn@skynav.com>
462
463         run-perf-tests should have a --repeat option
464         https://bugs.webkit.org/show_bug.cgi?id=100030
465
466         Reviewed by Ryosuke Niwa.
467
468         Add --repeat option to run-perf-tests, with default value of 1. When greater
469         than 1, runs test set specified number of times. Note that multiple runs are
470         not aggregated for statistical purposes.
471
472         Incidentally fixed typo: s/suceeds/succeeds/.
473
474         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
475         (PerfTestsRunner._parse_args): Add repeat option.
476         (PerfTestsRunner.run): Add outer repeat loop.
477         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
478         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
479         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
480         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
481         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
482         (MainTest.test_run_with_json_output): Fix typo.
483         (MainTest.test_run_with_description): Fix typo.
484         (MainTest.test_run_respects_no_results): Fix typo.
485         (MainTest.test_run_with_slave_config_json): Fix typo.
486         (MainTest.test_run_with_multiple_repositories): Fix typo.
487         (MainTest.test_run_with_upload_json): Fix typo.
488         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
489         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
490         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
491         (MainTest.test_parse_args): Add test for repeat option parsing.
492
493 2013-03-07  Julie Parent  <jparent@chromium.org>
494
495         showAllRuns checkbox no longer works on the stats dashboard
496         https://bugs.webkit.org/show_bug.cgi?id=111673
497
498         Reviewed by Ojan Vafai.
499
500         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
501         so we were trying to index into an undefined object.
502         
503         * TestResultServer/static-dashboards/dashboard_base.js:
504         (invalidateQueryParameters):
505
506 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
507
508         [Chromium] Update #include for WebStorageNamespace.h
509         https://bugs.webkit.org/show_bug.cgi?id=111748
510
511         Reviewed by Adam Barth.
512
513         In anticipation of removing
514         WK/chromium/public/WebStorageNamespace.h (once downstream
515         references have been updated)
516
517         * DumpRenderTree/chromium/WebViewHost.cpp:
518
519 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
520
521         run-perf-tests fails due to svn_revision not working on a pure git clone
522         https://bugs.webkit.org/show_bug.cgi?id=110839
523
524         Reviewed by Ryosuke Niwa.
525
526         Previously we would call git svn find-rev to look up the commit for
527         a given revision, and that'll hang in a pure git checkout.
528
529         This patch changes the way we look up svn revisions in a git
530         repository to use git log --grep 'git-svn-id', which is much faster
531         than grepping ourselves. It also renames timestamp_of_latest_commit()
532         to timestamp_of_revision() in order to accurately reflect what
533         the method is doing. Note that this patch only changes the logic
534         inside latest_revision() and svn_revision(). I'll file a separate
535         bug to change git_commit_from_svn_revision().
536
537         This patch also contains some fixes to unit tests that had bit-rotted
538         or were otherwise fragile, so that test-webkitpy --all would pass
539         cleanly, and a fix to outputcapture so that
540         test-webkitpy -p would work correctly again.
541
542         * Scripts/webkitpy/common/checkout/scm/git.py:
543         (Git.svn_revision):
544         (Git.timestamp_of_revision):
545         * Scripts/webkitpy/common/checkout/scm/scm.py:
546         (SCM.svn_revision):
547         (SCM.timestamp_of_revision):
548         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
549         (MockSCM.timestamp_of_revision):
550         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
551         (_shared_test_commit_with_message):
552         (test_commit_without_authorization):
553         (test_timestamp_of_revision):
554         * Scripts/webkitpy/common/checkout/scm/svn.py:
555         (SVN.timestamp_of_revision):
556         * Scripts/webkitpy/common/system/outputcapture.py:
557           Importing unittest2 directly may not be safe if this module is
558           imported before the autoinstaller gets a chance to set things up
559           properly. We don't actually need unittest2 here.
560         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
561         (PerfTestsRunner._generate_results_dict):
562
563 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
564
565         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
566         https://bugs.webkit.org/show_bug.cgi?id=111756
567
568         Reviewed by Kenneth Rohde Christiansen.
569
570         Bump libsoup to v2.40.3 to fix the regressions introduced by
571         previous v2.40.0 bump.
572
573         * efl/jhbuild.modules:
574
575 2013-03-07  Roger Fong  <roger_fong@apple.com>
576
577         Re-enable Win EWS tests.
578
579         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
580         (WinEWS):
581
582 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
583
584         [nrwt] handle corrupt http server pid files cleanly
585         https://bugs.webkit.org/show_bug.cgi?id=111628
586
587         Reviewed by Eric Seidel.
588
589         If the pid file from a previous http server is corrupt for some
590         reason, NRWT will just raise errors and not clean it up or recover.
591         This patch fixes that to at least delete the pid file and
592         not throw; not that we may still have stale http servers left on
593         the system, since there's no way to know which pid to kill if
594         the file was corrupted.
595
596         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
597         (HttpServerBase.start):
598         (HttpServerBase.stop):
599         (HttpServerBase._remove_pid_file):
600         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
601         (TestHttpServerBase):
602         (TestHttpServerBase.test_corrupt_pid_file):
603
604 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
605
606         AX: Can't activate links with VoiceOver in Safari
607         https://bugs.webkit.org/show_bug.cgi?id=111755
608
609         Reviewed by Tim Horton.
610
611         * DumpRenderTree/AccessibilityUIElement.cpp:
612         (supportedActionsCallback):
613         (AccessibilityUIElement::getJSClass):
614         * DumpRenderTree/AccessibilityUIElement.h:
615         (AccessibilityUIElement):
616         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
617         (AccessibilityUIElement::supportedActions):
618
619 2013-03-07  Roger Fong  <roger_fong@apple.com>
620
621         Windows debug layout tests are crashing like crazy again.
622         Disable tests on Win EWS bots temporarily.
623
624         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
625         (WinEWS):
626
627 2013-03-07  Roger Fong  <roger_fong@apple.com>
628
629         Make EWS bots build and test in release.
630
631         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
632         (WinEWS):
633         * Scripts/webkitpy/tool/steps/runtests.py:
634         (RunTests.run):
635
636 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
637
638         [chromium] don't track the top loading frame if no layout test is currently running
639         https://bugs.webkit.org/show_bug.cgi?id=111716
640
641         Reviewed by Kentaro Hara.
642
643         In DRT, we synchronously stop the test and start loading the next test
644         URL. However, in content_shell, this happens asynchronously. It's
645         important that the top loading frame is not changed due to stray
646         navigation events before the next test starts.
647
648         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
649         (WebTestRunner::TestRunner::setTopLoadingFrame):
650
651 2013-03-06  Julie Parent  <jparent@chromium.org>
652
653         Dashboard cleanup: Move all dashboard ui related code into ui.js.
654         https://bugs.webkit.org/show_bug.cgi?id=111621
655
656         Reviewed by Ojan Vafai.
657         
658         Creates ui.js, a package for the common UI code the various
659         dashboards use. HTML generation is now in the ui.html namespace
660         and popup handling is in ui.popup.
661         Also moves the event listening for popups to ui.popup.show and
662         removes it on ui.popup.hid rather than having listener always
663         around.
664
665         * TestResultServer/static-dashboards/aggregate_results.html:
666         * TestResultServer/static-dashboards/dashboard_base.js:
667         * TestResultServer/static-dashboards/flakiness_dashboard.html:
668         * TestResultServer/static-dashboards/flakiness_dashboard.js:
669         (showPopupForBuild):
670         (htmlForNavBar):
671         (generatePageForIndividualTests.if):
672         (generatePageForIndividualTests):
673         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
674         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
675         * TestResultServer/static-dashboards/run-embedded-unittests.html:
676         * TestResultServer/static-dashboards/run-unittests.html:
677         * TestResultServer/static-dashboards/timeline_explorer.html:
678         * TestResultServer/static-dashboards/treemap.html:
679         * TestResultServer/static-dashboards/ui.js: Added.
680         (.):
681
682 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
683
684         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
685         https://bugs.webkit.org/show_bug.cgi?id=110584
686
687         Reviewed by Gyuyoung Kim.
688
689         Adds missing implementation of AccessibilityControllerEfl
690         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
691         so that it can make accessibilityController as a js object.
692
693         * DumpRenderTree/AccessibilityController.h:
694         (AccessibilityController):
695         * DumpRenderTree/AccessibilityUIElement.h:
696         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
697         (AccessibilityController::childElementById): Moved declaration to base class.
698         Implementation can be shared among other ports.
699         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
700         (AccessibilityController::focusedElement):
701         (AccessibilityController::rootElement):
702         (AccessibilityController::accessibleElementById):
703         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
704         (AccessibilityUIElement::helpText):
705         * DumpRenderTree/efl/CMakeLists.txt:
706         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
707         (DumpRenderTreeChrome::DumpRenderTreeChrome):
708         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
709         (DumpRenderTreeChrome::onWindowObjectCleared):
710         (DumpRenderTreeChrome::accessibilityController):
711         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
712         (DumpRenderTreeChrome):
713         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
714
715 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
716
717         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
718         https://bugs.webkit.org/show_bug.cgi?id=42696
719
720         Reviewed by Andreas Kling.
721
722         * DumpRenderTree/TestRunner.cpp:
723         (TestRunner::staticFunctions):
724         * DumpRenderTree/TestRunner.h:
725         (TestRunner):
726         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
727         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
728         (WebTestRunner::TestRunner::TestRunner):
729         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
730         (TestRunner):
731         * DumpRenderTree/efl/TestRunnerEfl.cpp:
732         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
733         * DumpRenderTree/mac/TestRunnerMac.mm:
734         * DumpRenderTree/qt/TestRunnerQt.cpp:
735         * DumpRenderTree/qt/TestRunnerQt.h:
736         (TestRunnerQt):
737         * DumpRenderTree/win/TestRunnerWin.cpp:
738         * DumpRenderTree/wx/TestRunnerWx.cpp:
739
740 2013-03-06  Roger Fong  <roger_fong@apple.com>
741
742         Re-enable WinEWS test and decrease iterations before clean build back to 10.
743
744         * EWSTools/start-queue-win.sh:
745         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
746         (WinEWS):
747
748 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
749
750         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
751         https://bugs.webkit.org/show_bug.cgi?id=82866
752
753         Reviewed by Martin Robinson.
754
755         * Scripts/run-gtk-tests:
756         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
757         it is passing now.
758
759 2013-03-06  Julie Parent  <jparent@chromium.org>
760
761         Dashboard cleanup: remove dashboard time logging.
762         https://bugs.webkit.org/show_bug.cgi?id=111608
763
764         Reviewed by Dirk Pranke.
765
766         Remove logTime.  It was never accurate, and the dev tools
767         have better ways to measure this if anyone cares to look
768         into dashboard perf.
769         
770         * TestResultServer/static-dashboards/dashboard_base.js:
771         * TestResultServer/static-dashboards/flakiness_dashboard.js:
772         (processTestRunsForBuilder):
773         (appendHTML):
774
775 2013-03-06  Tony Chang  <tony@chromium.org>
776
777         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
778         https://bugs.webkit.org/show_bug.cgi?id=111509
779
780         Reviewed by Dirk Pranke.
781
782         Add DumpRenderTree.pak to DumpRenderTree.app again.
783
784         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
785
786 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
787
788         [chromium] introduce WebUserGestureIndicator
789         https://bugs.webkit.org/show_bug.cgi?id=111531
790
791         Reviewed by Adam Barth.
792
793         * DumpRenderTree/chromium/WebViewHost.cpp:
794         (WebViewHost::createView):
795
796 2013-03-06  Alan Cutter  <alancutter@chromium.org>
797
798         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
799         https://bugs.webkit.org/show_bug.cgi?id=73482
800
801         Reviewed by Ryosuke Niwa.
802
803         Added input checking to the UpdateChromiumDEPS step.
804         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
805
806         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
807         (RollChromiumDEPS):
808         (RollChromiumDEPS._parse_args):
809         (RollChromiumDEPS.execute):
810         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
811         (IRCCommandTest.test_roll_chromium_deps):
812         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
813         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
814         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
815         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
816         (UpdateChromiumDEPS._fetch_last_known_good_revision):
817         (UpdateChromiumDEPS):
818         (UpdateChromiumDEPS._parse_revision_number):
819         (UpdateChromiumDEPS._validate_revisions):
820         (UpdateChromiumDEPS.run):
821         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
822         (UpdateChromiumDEPSTest):
823         (UpdateChromiumDEPSTest.test_parse_revision_number):
824         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
825         (RollChromiumDEPS):
826         (PostChromiumDEPSRoll):
827
828 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
829
830         [Qt][MiniBrowser] Touch mocking broken for chained getures
831         https://bugs.webkit.org/show_bug.cgi?id=111430
832
833         Reviewed by Jocelyn Turcotte.
834
835         Make it possible again to use touch mocking to test gesture chains
836         like pan->pinch->pan->pinch without lifting the primary "finger".
837         For this to work we need to track the pressed mouse buttons and
838         only synthesize touch release events when the ctrl key is released
839         if no mouse button is pressed. Else the pressed mouse button(s)
840         should result in a stationary touch point in a touch update event.
841         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
842         to check for the state of the ctrl key modifier instead of getting
843         it from the mouse events.
844
845         * MiniBrowser/qt/MiniBrowserApplication.cpp:
846         (MiniBrowserApplication::MiniBrowserApplication):
847         (MiniBrowserApplication::notify):
848
849 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
850
851         [chromium] don't use custom freetype on linux asan for now
852         https://bugs.webkit.org/show_bug.cgi?id=111516
853
854         Unreviewed, build fix.
855
856         Turns out the custom lib is getting picked up by other binaries
857         on our bot, which is bad.
858
859         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
860
861 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
862
863         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
864         https://bugs.webkit.org/show_bug.cgi?id=111509
865
866         Unreviewed, build fix.
867
868         Actually comment out the flag :(.
869
870         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
871
872 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
873
874         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
875         https://bugs.webkit.org/show_bug.cgi?id=111509
876
877         Unreviewed, build fix.
878
879         r144863 appears to have broken the xcode build; I'm temporarily
880         trying this instead, and if this doesn't work, I'll revert the
881         other changes.
882
883         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
884
885 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
886
887         [chromium] build a DumpRenderTree.pak even on windows
888         https://bugs.webkit.org/show_bug.cgi?id=111504
889
890         Reviewed by Tony Chang.
891
892         The Chromium Aura build uses the default theme to draw
893         controls, and that theme requires the ui ResourceBundle
894         to be initialized. On every other platform, we build
895         a DumpRenderTree.pak that works for this, but on Windows we
896         still compile the resources directly into DRT. As a first step,
897         let's build the pak file. I will then need to land a patch
898         in Chromium to actually load it. Then I can go back and move
899         the resources over to just use the .pak file and no longer need
900         the .rc's.
901
902         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
903
904 2013-03-05  Julie Parent  <jparent@chromium.org>
905         Dashboard cleanup: move string utilities into their own namespace.
906         
907         https://bugs.webkit.org/show_bug.cgi?id=111485
908
909         Reviewed by Ojan Vafai.
910         
911         One of many pieces to clean up dashboard_base.
912         
913         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
914
915         * TestResultServer/static-dashboards/aggregate_results.html:
916         * TestResultServer/static-dashboards/dashboard_base.js:
917         (isTreeMap):
918         (isFlakinessDashboard):
919         * TestResultServer/static-dashboards/flakiness_dashboard.html:
920         * TestResultServer/static-dashboards/flakiness_dashboard.js:
921         (determineWKPlatform):
922         (chromiumPlatform):
923         (platformAndBuildType):
924         (substringList):
925         (individualTestsForSubstringList):
926         (filterBugs):
927         (populateExpectationsData):
928         (processMissingTestsWithExpectations):
929         (processMissingAndExtraExpectations):
930         (htmlForSingleTestRow):
931         (.dummyNode.onload):
932         (expectationsTitle):
933         * TestResultServer/static-dashboards/run-embedded-unittests.html:
934         * TestResultServer/static-dashboards/run-unittests.html:
935         * TestResultServer/static-dashboards/string.js: Added.
936         * TestResultServer/static-dashboards/timeline_explorer.html:
937         * TestResultServer/static-dashboards/treemap.html:
938
939 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
940
941         [EFL] Build break with latest EFL libraries
942         https://bugs.webkit.org/show_bug.cgi?id=111028
943
944         Reviewed by Dirk Pranke.
945
946         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
947         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
948         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
949
950 2013-03-05  Roger Fong  <roger_fong@apple.com>
951
952         Increase number of WinEWS iterations to 20.
953         Don't reboot after each iteration set.
954         Make EWS bots just build temporarily so that the queue catches up again.
955
956         * EWSTools/start-queue-win.sh:
957         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
958         (WinEWS):
959
960 2013-03-04  James Robinson  <jamesr@chromium.org>
961
962         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
963         https://bugs.webkit.org/show_bug.cgi?id=111386
964
965         Reviewed by Adrienne Walker.
966
967         * DumpRenderTree/chromium/TestShell.cpp:
968         (TestShell::initialize):
969
970 2013-03-05  Min Qin  <qinmin@chromium.org>
971
972         Copy dictionary to the external storage before running layout test on android
973         https://bugs.webkit.org/show_bug.cgi?id=111480
974
975         Reviewed by Adam Barth.
976
977         TestWebKitPlatformSupport now needs to read an external dictionary file.
978         This file does not exist on the device. We need to copy it before running layout tests.
979
980         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
981         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
982         (ChromiumAndroidDriver._push_platform_resources):
983
984 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
985
986         [chromium] DRT crashes in an Aura/Win build
987         https://bugs.webkit.org/show_bug.cgi?id=111394
988
989         Reviewed by Tony Chang.
990
991         When building (and running) with use_aura=1, we assume that
992         we're using the default theme engine, but DRT creates the
993         DRTWin theme engine and overwrites the default, leading to crashes
994         in basically every test from the mismatch.
995
996         This fix gets us down to at least "lots of crashes" :).
997
998         * DumpRenderTree/chromium/TestShellWin.cpp:
999         (platformInit):
1000
1001 2013-03-05  Eric Seidel  <eric@webkit.org>
1002
1003         Add html-parser-threaded perf test now that the threaded parser is enabled by default
1004         https://bugs.webkit.org/show_bug.cgi?id=111200
1005
1006         Reviewed by Ryosuke Niwa.
1007
1008         Had to teach run-perf-tests to ignore one more warning.
1009
1010         * Scripts/webkitpy/performance_tests/perftest.py:
1011         (PerfTest):
1012
1013 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1014
1015         Update list of builders for test results server
1016         https://bugs.webkit.org/show_bug.cgi?id=111166
1017
1018         Reviewed by Ojan Vafai.
1019
1020         * TestResultServer/static-dashboards/builders.jsonp:
1021
1022 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
1023
1024         [GTK] Move basic dependency installation to a script
1025         https://bugs.webkit.org/show_bug.cgi?id=110692
1026
1027         Reviewed by Gustavo Noronha Silva.
1028
1029         * gtk/install-dependencies: Added. A Script which installs all dependencies
1030         necessary for building for Debian-based distributions and Fedora.
1031
1032 2013-03-05  James Robinson  <jamesr@chromium.org>
1033
1034         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
1035         https://bugs.webkit.org/show_bug.cgi?id=111440
1036
1037         Reviewed by Adrienne Walker.
1038
1039         Remove unnecessary WebCompositorSupport::shutdown call
1040
1041         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1042         (main):
1043
1044 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
1045
1046         Unreviewed build fix.
1047
1048         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
1049
1050 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
1051
1052         [Qt][MiniBrowser] Improve the update of touch indicators
1053         https://bugs.webkit.org/show_bug.cgi?id=111429
1054
1055         Reviewed by Jocelyn Turcotte.
1056
1057         MiniBrowserApplication::sendTouchEvent sends an empty list
1058         to BrowserWindow::updateVisualMockTouchPoints if the control
1059         button is released, in which case the touch indicators should
1060         be hidden so that we never end up with a leftover indicator
1061         sticking on the screen.
1062         This patch also simplifies the lookup of the indicator items by
1063         replacing the findChild search in the item tree with a QHash
1064         that stores the touch ID's and the pointers to the corresponding
1065         indicator items.
1066
1067         * MiniBrowser/qt/BrowserWindow.cpp:
1068         (BrowserWindow::updateVisualMockTouchPoints):
1069         * MiniBrowser/qt/BrowserWindow.h:
1070         (BrowserWindow):
1071
1072 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1073
1074         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
1075         https://bugs.webkit.org/show_bug.cgi?id=81042
1076
1077         Reviewed by Enrica Casucci.
1078
1079         Add setAsynchronousSpellCheckingEnabled implementation for
1080         WebKitTestRunner to have the possibility to test asynchronous
1081         spell checking implementation from bug 109577.
1082
1083         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1084         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1085         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
1086         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1087         * WebKitTestRunner/TestController.cpp:
1088         (WTR::TestController::resetStateToConsistentValues):
1089
1090 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
1091
1092         MediaStream API: Add the getStreamById method on RTCPeerConnection
1093         https://bugs.webkit.org/show_bug.cgi?id=111311
1094
1095         Reviewed by Adam Barth.
1096
1097         Changing mocks to be more realistic.
1098
1099         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
1100         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
1101         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
1102         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
1103         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
1104
1105 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1106
1107         Add content shell bots to garden-o-matic for general failurse
1108         https://bugs.webkit.org/show_bug.cgi?id=111168
1109
1110         Reviewed by Adam Barth.
1111
1112         All but the WebKit (Content Shell) Android bot is stable enough. While
1113         they're not green yet, there must not be any non-layout test failures on
1114         them.
1115
1116         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1117         (.):
1118
1119 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1120
1121         [chromium] remove deprecated WebTestRunner::setFocus API
1122         https://bugs.webkit.org/show_bug.cgi?id=111354
1123
1124         Reviewed by James Robinson.
1125
1126         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1127         (WebTestDelegate):
1128
1129 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1130
1131         Run the bindings generation tests on EWS and CQ bots
1132         https://bugs.webkit.org/show_bug.cgi?id=111358
1133
1134         Reviewed by Adam Barth.
1135
1136         The tests are super fast and not flaky.
1137
1138         * Scripts/webkitpy/common/config/ports.py:
1139         (DeprecatedPort.run_bindings_tests_command):
1140         * Scripts/webkitpy/common/config/ports_mock.py:
1141         (MockPort.run_webkit_tests_command):
1142         (MockPort):
1143         (MockPort.run_bindings_tests_command):
1144         * Scripts/webkitpy/tool/commands/download_unittest.py:
1145         * Scripts/webkitpy/tool/steps/runtests.py:
1146         (RunTests.run):
1147         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1148         (RunTestsTest.test_webkit_run_unit_tests):
1149         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1150
1151 2013-03-04  Eric Seidel  <eric@webkit.org>
1152
1153         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
1154         https://bugs.webkit.org/show_bug.cgi?id=111384
1155
1156         Reviewed by Ryosuke Niwa.
1157
1158         Sometimes I want to know why various LayoutTests are slow
1159         without having to convert them into PerformanceTests in order
1160         to use our fancy profiling.  The Driver already knows how to
1161         do the right thing, we just need to expose the options to the user.
1162
1163         Handling of these options is already unittested in the perftests_unittest.
1164
1165         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1166         (parse_args):
1167
1168 2013-03-04  Alan Cutter  <alancutter@chromium.org>
1169
1170         check-webkit-style says "Have to enable auto props in the subversion config file"
1171         https://bugs.webkit.org/show_bug.cgi?id=107724
1172
1173         Reviewed by Tony Chang.
1174
1175         Added a standard svn config file for WebKit developers to use.
1176         Updated the style and commit queue bot build scripts to load this file.
1177
1178         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1179         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1180         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1181         * svn-config: Added.
1182
1183 2013-03-04  James Robinson  <jamesr@chromium.org>
1184
1185         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
1186         https://bugs.webkit.org/show_bug.cgi?id=111285
1187
1188         Reviewed by Adrienne Walker.
1189
1190         This removes the need for WebCompositorSupport::initialize and exposes
1191         slightly fewer entry points across the repository boundary.
1192
1193         * DumpRenderTree/chromium/TestShell.cpp:
1194         (TestShell::initialize):
1195         * DumpRenderTree/chromium/TestShell.h:
1196         (TestShell::webCompositorThread):
1197         (TestShell):
1198         * DumpRenderTree/chromium/WebViewHost.cpp:
1199         (WebViewHost::initializeLayerTreeView):
1200
1201 2013-03-04  Roger Fong  <roger_fong@apple.com>
1202
1203         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
1204
1205         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
1206
1207 2013-03-04  David Kilzer  <ddkilzer@apple.com>
1208
1209         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
1210
1211             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
1212                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
1213                                         ^         ~~~~~~~~~~~~~~~~~~~~~
1214             1 error generated.
1215
1216         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
1217         AccessibilityCommonMac.h.
1218
1219 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1220
1221         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
1222         https://bugs.webkit.org/show_bug.cgi?id=109828
1223
1224         Reviewed by Kenneth Rohde Christiansen.
1225
1226         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
1227         callbacks.
1228
1229         * TestWebKitAPI/CMakeLists.txt:
1230
1231             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
1232             considered.
1233
1234         * TestWebKitAPI/PlatformEfl.cmake:
1235         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
1236         (TestWebKitAPI):
1237         (TestWebKitAPI::didFinishLoadForFrame):
1238         (TestWebKitAPI::setPageLoaderClient):
1239         (TestWebKitAPI::webProcessCrashed):
1240         (TestWebKitAPI::webProcessDidRelaunch):
1241         (TestWebKitAPI::setViewClient):
1242         (TestWebKitAPI::TEST):
1243
1244 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
1245
1246         AX: Upstream iOS Accessibility DumpRenderTree changes
1247         https://bugs.webkit.org/show_bug.cgi?id=111220
1248
1249         Reviewed by David Kilzer.
1250
1251         Upstream the iOS changes for accessibility in DumpRenderTree.
1252
1253         * DumpRenderTree/AccessibilityUIElement.cpp:
1254         (headerElementAtIndexCallback):
1255         (linkedElementCallback):
1256         (elementsForRangeCallback):
1257         (increaseTextSelectionCallback):
1258         (decreaseTextSelectionCallback):
1259         (assistiveTechnologySimulatedFocusCallback):
1260         (stringForSelectionCallback):
1261         (getIPhoneLabelCallback):
1262         (getIPhoneHintCallback):
1263         (getIPhoneValueCallback):
1264         (getIPhoneIdentifierCallback):
1265         (getIPhoneTraitsCallback):
1266         (getIPhoneIsElementCallback):
1267         (getIPhoneElementTextPositionCallback):
1268         (getIPhoneElementTextLengthCallback):
1269         (AccessibilityUIElement::getJSClass):
1270         * DumpRenderTree/AccessibilityUIElement.h:
1271         (AccessibilityUIElement):
1272         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1273         * DumpRenderTree/ios: Added.
1274         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
1275         (AccessibilityController::AccessibilityController):
1276         (AccessibilityController::~AccessibilityController):
1277         (AccessibilityController::elementAtPoint):
1278         (AccessibilityController::focusedElement):
1279         (AccessibilityController::rootElement):
1280         (findAccessibleObjectById):
1281         (AccessibilityController::accessibleElementById):
1282         (AccessibilityController::setLogFocusEvents):
1283         (AccessibilityController::setLogScrollingStartEvents):
1284         (AccessibilityController::setLogValueChangeEvents):
1285         (AccessibilityController::setLogAccessibilityEvents):
1286         (AccessibilityController::addNotificationListener):
1287         (AccessibilityController::removeNotificationListener):
1288         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
1289         (AccessibilityUIElement::AccessibilityUIElement):
1290         (AccessibilityUIElement::~AccessibilityUIElement):
1291         (concatenateAttributeAndValue):
1292         (AccessibilityUIElement::iphoneLabel):
1293         (AccessibilityUIElement::iphoneHint):
1294         (AccessibilityUIElement::iphoneValue):
1295         (AccessibilityUIElement::iphoneIdentifier):
1296         (AccessibilityUIElement::iphoneTraits):
1297         (AccessibilityUIElement::iphoneIsElement):
1298         (AccessibilityUIElement::iphoneElementTextPosition):
1299         (AccessibilityUIElement::iphoneElementTextLength):
1300         (AccessibilityUIElement::url):
1301         (AccessibilityUIElement::x):
1302         (AccessibilityUIElement::y):
1303         (AccessibilityUIElement::width):
1304         (AccessibilityUIElement::height):
1305         (AccessibilityUIElement::clickPointX):
1306         (AccessibilityUIElement::clickPointY):
1307         (AccessibilityUIElement::getChildren):
1308         (AccessibilityUIElement::getChildrenWithRange):
1309         (AccessibilityUIElement::childrenCount):
1310         (AccessibilityUIElement::elementAtPoint):
1311         (AccessibilityUIElement::indexOfChild):
1312         (AccessibilityUIElement::getChildAtIndex):
1313         (AccessibilityUIElement::headerElementAtIndex):
1314         (AccessibilityUIElement::linkedElement):
1315         (AccessibilityUIElement::linkedUIElementAtIndex):
1316         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1317         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1318         (AccessibilityUIElement::disclosedRowAtIndex):
1319         (AccessibilityUIElement::selectedRowAtIndex):
1320         (AccessibilityUIElement::rowAtIndex):
1321         (AccessibilityUIElement::titleUIElement):
1322         (AccessibilityUIElement::parentElement):
1323         (AccessibilityUIElement::disclosedByRow):
1324         (AccessibilityUIElement::increaseTextSelection):
1325         (AccessibilityUIElement::decreaseTextSelection):
1326         (AccessibilityUIElement::stringForSelection):
1327         (AccessibilityUIElement::stringForRange):
1328         (AccessibilityUIElement::attributedStringForRange):
1329         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1330         (AccessibilityUIElement::elementsForRange):
1331         (AccessibilityUIElement::getLinkedUIElements):
1332         (AccessibilityUIElement::getDocumentLinks):
1333         (AccessibilityUIElement::attributesOfLinkedUIElements):
1334         (AccessibilityUIElement::attributesOfDocumentLinks):
1335         (AccessibilityUIElement::attributesOfChildren):
1336         (AccessibilityUIElement::allAttributes):
1337         (AccessibilityUIElement::stringAttributeValue):
1338         (AccessibilityUIElement::isPressActionSupported):
1339         (AccessibilityUIElement::isIncrementActionSupported):
1340         (AccessibilityUIElement::isDecrementActionSupported):
1341         (AccessibilityUIElement::boolAttributeValue):
1342         (AccessibilityUIElement::isAttributeSettable):
1343         (AccessibilityUIElement::isAttributeSupported):
1344         (AccessibilityUIElement::parameterizedAttributeNames):
1345         (AccessibilityUIElement::role):
1346         (AccessibilityUIElement::subrole):
1347         (AccessibilityUIElement::roleDescription):
1348         (AccessibilityUIElement::title):
1349         (AccessibilityUIElement::description):
1350         (AccessibilityUIElement::orientation):
1351         (AccessibilityUIElement::stringValue):
1352         (AccessibilityUIElement::language):
1353         (AccessibilityUIElement::helpText):
1354         (AccessibilityUIElement::intValue):
1355         (AccessibilityUIElement::minValue):
1356         (AccessibilityUIElement::maxValue):
1357         (AccessibilityUIElement::valueDescription):
1358         (AccessibilityUIElement::insertionPointLineNumber):
1359         (AccessibilityUIElement::isEnabled):
1360         (AccessibilityUIElement::isRequired):
1361         (AccessibilityUIElement::isFocused):
1362         (AccessibilityUIElement::isSelected):
1363         (AccessibilityUIElement::isExpanded):
1364         (AccessibilityUIElement::isChecked):
1365         (AccessibilityUIElement::hierarchicalLevel):
1366         (AccessibilityUIElement::ariaIsGrabbed):
1367         (AccessibilityUIElement::ariaDropEffects):
1368         (AccessibilityUIElement::lineForIndex):
1369         (AccessibilityUIElement::boundsForRange):
1370         (AccessibilityUIElement::attributesOfColumnHeaders):
1371         (AccessibilityUIElement::attributesOfRowHeaders):
1372         (AccessibilityUIElement::attributesOfColumns):
1373         (AccessibilityUIElement::attributesOfRows):
1374         (AccessibilityUIElement::attributesOfVisibleCells):
1375         (AccessibilityUIElement::attributesOfHeader):
1376         (AccessibilityUIElement::rowCount):
1377         (AccessibilityUIElement::columnCount):
1378         (AccessibilityUIElement::indexInTable):
1379         (AccessibilityUIElement::rowIndexRange):
1380         (AccessibilityUIElement::columnIndexRange):
1381         (AccessibilityUIElement::cellForColumnAndRow):
1382         (AccessibilityUIElement::selectedTextRange):
1383         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1384         (AccessibilityUIElement::setSelectedTextRange):
1385         (AccessibilityUIElement::increment):
1386         (AccessibilityUIElement::decrement):
1387         (AccessibilityUIElement::showMenu):
1388         (AccessibilityUIElement::press):
1389         (AccessibilityUIElement::accessibilityValue):
1390         (AccessibilityUIElement::documentEncoding):
1391         (AccessibilityUIElement::documentURI):
1392         (_accessibilityNotificationCallback):
1393         (AccessibilityUIElement::addNotificationListener):
1394         (AccessibilityUIElement::removeNotificationListener):
1395         (AccessibilityUIElement::isFocusable):
1396         (AccessibilityUIElement::isSelectable):
1397         (AccessibilityUIElement::isMultiSelectable):
1398         (AccessibilityUIElement::isSelectedOptionActive):
1399         (AccessibilityUIElement::isVisible):
1400         (AccessibilityUIElement::isOffScreen):
1401         (AccessibilityUIElement::isCollapsed):
1402         (AccessibilityUIElement::isIgnored):
1403         (AccessibilityUIElement::hasPopup):
1404         (AccessibilityUIElement::takeFocus):
1405         (AccessibilityUIElement::takeSelection):
1406         (AccessibilityUIElement::addSelection):
1407         (AccessibilityUIElement::removeSelection):
1408         (AccessibilityUIElement::uiElementForSearchPredicate):
1409         (AccessibilityUIElement::numberAttributeValue):
1410
1411 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1412
1413         [chromium] pass all focus handling methods through the WebTestDelegate
1414         https://bugs.webkit.org/show_bug.cgi?id=111328
1415
1416         Reviewed by Nico Weber.
1417
1418         In content_shell, the focus handling is asynchronous. To allow for
1419         switching the focus synchronously between WebViews, we need to intercept
1420         didFocus and didBlur and forward it to the WebTestDelegate.
1421
1422         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1423         (WebTestDelegate):
1424         (WebTestRunner::WebTestDelegate::setFocus):
1425         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1426         (WebTestRunner::WebTestProxy::didFocus):
1427         (WebTestRunner::WebTestProxy::didBlur):
1428         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1429         (WebTestRunner::TestRunner::setWindowIsKey):
1430         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1431         (WebTestRunner::WebTestProxyBase::didFocus):
1432         (WebTestRunner):
1433         (WebTestRunner::WebTestProxyBase::didBlur):
1434         * DumpRenderTree/chromium/WebViewHost.cpp:
1435         (WebViewHost::didFocus):
1436         (WebViewHost::didBlur):
1437         (WebViewHost::setFocus):
1438         * DumpRenderTree/chromium/WebViewHost.h:
1439         (WebViewHost):
1440
1441 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
1442
1443         [GTK] No need to manually add system paths to jhbuildrc
1444         https://bugs.webkit.org/show_bug.cgi?id=110850
1445
1446         Reviewed by Gustavo Noronha Silva.
1447
1448         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
1449         already takes care of.
1450
1451 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
1452
1453         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
1454         https://bugs.webkit.org/show_bug.cgi?id=111284
1455
1456         Disabling the failing two tests on Android.
1457
1458         Reviewed by Jochen Eisinger.
1459
1460         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1461         (TestWebKitAPI):
1462         (TestWebKitAPI::TEST):
1463
1464 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
1465
1466         Add build flag for FontLoader
1467         https://bugs.webkit.org/show_bug.cgi?id=111289
1468
1469         Reviewed by Benjamin Poulain.
1470
1471         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
1472
1473         * Scripts/webkitperl/FeatureList.pm:
1474         * qmake/mkspecs/features/features.pri:
1475
1476 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
1477
1478         [Mac] Get rid of a useless method from DOMHTMLInputElement
1479         https://bugs.webkit.org/show_bug.cgi?id=111279
1480
1481         Reviewed by Sam Weinig.
1482
1483         * DumpRenderTree/mac/TestRunnerMac.mm:
1484         (TestRunner::setValueForUser):
1485         The method _setValueForUser: was added for testing. This feature is already
1486         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
1487         in real use cases. Get rid of the method created for testing, use the real thing
1488         instead.
1489
1490 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1491
1492         Some perf. tests have variances that differ greatly between runs
1493         https://bugs.webkit.org/show_bug.cgi?id=97510
1494
1495         Reviewed by Benjamin Poulain.
1496
1497         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
1498         environment on test results (we run each instance after one another, not in parallel).
1499
1500         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
1501         iterations as it was done previously in single process. These values are hard-coded in perftest.py
1502         and runner.js but they are to be configurable in the future.
1503
1504         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
1505         metric now reports an array of the length 4 with each element containing an array of 5 iteration
1506         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
1507
1508         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
1509         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
1510         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
1511
1512         * Scripts/webkitpy/performance_tests/perftest.py:
1513         (PerfTestMetric.append_group): Renamed from append.
1514         (PerfTestMetric.grouped_iteration_values): Added.
1515         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
1516
1517         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
1518         This parameter is only used by SingleProcessPerfTest.
1519
1520         (PerfTest.run): Repeat tests using different driver processes.
1521         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
1522         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
1523         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
1524         (PerfTest._ensure_metrics): Added.
1525
1526         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
1527         instances of DumpRenderTree/WebKitTestRunner takes too long.
1528         (SingleProcessPerfTest.__init__):
1529
1530         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
1531
1532         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
1533
1534         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
1535         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
1536         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
1537
1538         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
1539         grouped_iteration_values.
1540
1541         (TestPerfTest._assert_results_are_correct):
1542
1543         (TestSingleProcessPerfTest): Added.
1544         (TestSingleProcessPerfTest.test_use_only_one_process):
1545         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
1546
1547         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1548         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1549
1550         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
1551         sample standard deviations since we're now running tests 4 times.
1552         (MainTest._test_run_with_json_output.mock_upload_json):
1553         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1554
1555 2013-03-03  Alexandre Elias  <aelias@chromium.org>
1556
1557         [chromium] Remove WebLayerTreeView::setViewportSize call
1558         https://bugs.webkit.org/show_bug.cgi?id=110727
1559
1560         Reviewed by James Robinson.
1561
1562         After https://codereview.chromium.org/12328080 lands,
1563         setViewportSize is called from the Chromium side. The multiplication
1564         by deviceScaleFactor here was prone to off-by-one errors.
1565         The layoutSize() function was only used here so delete it as well.
1566
1567         DumpRenderTree WebViewHost must now call this method as well.
1568
1569         * DumpRenderTree/chromium/WebViewHost.cpp:
1570         (WebViewHost::initializeLayerTreeView):
1571         (WebViewHost::setWindowRect):
1572         (WebViewHost::setDeviceScaleFactor):
1573         (WebViewHost::updateViewportSize):
1574         * DumpRenderTree/chromium/WebViewHost.h:
1575         (WebViewHost):
1576
1577 2013-02-27  Darin Adler  <darin@apple.com>
1578
1579         StringHasher functions require alignment that call sites do not all guarantee
1580         https://bugs.webkit.org/show_bug.cgi?id=110171
1581
1582         Reviewed by Benjamin Poulain.
1583
1584         * TestWebKitAPI/CMakeLists.txt:
1585         * TestWebKitAPI/GNUmakefile.am:
1586         * TestWebKitAPI/TestWebKitAPI.gypi:
1587         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1588         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1590         * TestWebKitAPI/Tests/WTF/WTF.pro:
1591         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1592         Added the StringHasher.cpp file.
1593
1594         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
1595         for the functions in the StringHasher class.
1596
1597 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
1598
1599         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
1600         https://bugs.webkit.org/show_bug.cgi?id=109772
1601
1602         Reviewed by Andreas Kling.
1603
1604         * DumpRenderTree/TestRunner.cpp:
1605         (TestRunner::staticFunctions):
1606         * DumpRenderTree/TestRunner.h:
1607         (TestRunner):
1608         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1609         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1610         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1611         * DumpRenderTree/mac/TestRunnerMac.mm:
1612         * DumpRenderTree/qt/TestRunnerQt.cpp:
1613         * DumpRenderTree/qt/TestRunnerQt.h:
1614         (TestRunner):
1615         * DumpRenderTree/win/TestRunnerWin.cpp:
1616         * DumpRenderTree/wx/TestRunnerWx.cpp:
1617         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1618         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1619         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1620         (TestRunner):
1621
1622 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
1623
1624         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
1625         https://bugs.webkit.org/show_bug.cgi?id=110943
1626
1627         Reviewed by Yury Semikhatsky.
1628
1629         Unfortunately in many cases raw pointer may point to an object that has been deleted.
1630         There is no working solution to solve this problem in general.
1631         It could be solved only on case by case basis.
1632
1633         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1634         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
1635         (TestWebKitAPI::TEST):
1636
1637 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
1638
1639         Move markerTextForListItem from TestRunner to Internals
1640         https://bugs.webkit.org/show_bug.cgi?id=110939
1641
1642         Reviewed by Benjamin Poulain.
1643
1644         * DumpRenderTree/TestRunner.cpp:
1645         (TestRunner::staticFunctions):
1646         * DumpRenderTree/TestRunner.h:
1647         (TestRunner):
1648         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1649         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1650         (WebTestRunner::TestRunner::TestRunner):
1651         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1652         (TestRunner):
1653         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1654         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1655         * DumpRenderTree/mac/TestRunnerMac.mm:
1656         * DumpRenderTree/qt/TestRunnerQt.cpp:
1657         * DumpRenderTree/qt/TestRunnerQt.h:
1658         (TestRunnerQt):
1659         * DumpRenderTree/win/TestRunnerWin.cpp:
1660         * DumpRenderTree/wx/TestRunnerWx.cpp:
1661         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1662         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1663         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1664         (TestRunner):
1665
1666 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1667
1668         Don't use legacy test names when returning results from PerfTest.run
1669         https://bugs.webkit.org/show_bug.cgi?id=111148
1670
1671         Reviewed by Dirk Pranke.
1672
1673         * Scripts/webkitpy/performance_tests/perftest.py:
1674         (PerfTestMetric.name): Renamed from metric.
1675         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
1676         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
1677         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
1678
1679         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1680         (TestPerfTestMetric.test_init_set_time_metric):
1681         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
1682         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1683         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1684
1685         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1686         (PerfTestsRunner.__init__):
1687         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
1688         to obtain the trac URL instead of hard coding it.
1689         (PerfTestsRunner._run_tests_set):
1690
1691 2013-03-01  Roger Fong  <roger_fong@apple.com>
1692
1693         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
1694         https://bugs.webkit.org/show_bug.cgi?id=111202
1695
1696         This is useful for running VCExpress builds from command line because there is
1697         no unified solution output, only per project build logs.
1698         The project will be run as the last project in the solution.
1699
1700         * win/AssembleBuildLogs: Added.
1701         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
1702         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
1703         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
1704         * win/AssembleBuildLogs/README: Added.
1705
1706 2013-03-01  Roger Fong  <roger_fong@apple.com>
1707
1708         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
1709
1710         * EWSTools/start-queue-win.sh:
1711
1712 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1713
1714         Don't return statistics in PerfTest.run
1715         https://bugs.webkit.org/show_bug.cgi?id=111145
1716
1717         Reviewed by Dirk Pranke.
1718
1719         Simply return a list of values obtained in each iteration from PerfTest.run.
1720         Also simplify various methods as needed.
1721
1722         * Scripts/webkitpy/performance_tests/perftest.py:
1723         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
1724         as needed from PerfTestsRunner._generate_results_dict.
1725
1726         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
1727         that we don't have to worry about the backward compatibility here.
1728
1729         (PerfTestMetric.iteration_values): Added.
1730         (PerfTestMetric.unit): Added.
1731         (PerfTestMetric.metric_to_unit):
1732         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
1733
1734         (PerfTest.run):
1735         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
1736
1737         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1738         (TestPerfTestMetric.test_init_set_missing_unit):
1739         (TestPerfTestMetric.test_init_set_time_metric): Added.
1740         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
1741         (TestPerfTestMetric.test_append):
1742         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
1743         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
1744         (TestPerfTest._assert_results_are_correct):
1745         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1746         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1747
1748         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1749         (PerfTestsRunner._generate_results_dict):
1750
1751         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1752         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
1753         (SomeParserTestData): Ditto.
1754         (MemoryTestData): Ditto.
1755
1756 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1757
1758         [Qt] Enable LINK_PREFETCH
1759         https://bugs.webkit.org/show_bug.cgi?id=111158
1760
1761         Reviewed by Simon Hausmann.
1762
1763         * qmake/mkspecs/features/features.pri:
1764
1765 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1766
1767         [Qt] Update features.pri with new features
1768         https://bugs.webkit.org/show_bug.cgi?id=111157
1769
1770         Reviewed by Jocelyn Turcotte.
1771
1772         * qmake/mkspecs/features/features.pri:
1773
1774 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
1775
1776         [chromium] put WebTestProxy::scheduleComposite back in place
1777         https://bugs.webkit.org/show_bug.cgi?id=111146
1778
1779         Reviewed by Nico Weber.
1780
1781         The call was removed in http://trac.webkit.org/changeset/144398 because
1782         DRT doesn't need it. However, content shell depends on this call.
1783
1784         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1785         (WebTestRunner::WebTestProxy::scheduleComposite):
1786
1787 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1788
1789         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
1790         https://bugs.webkit.org/show_bug.cgi?id=111142
1791
1792         Reviewed by Adam Barth.
1793
1794         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
1795
1796         Also removed _print_status since it's never used anywhere.
1797
1798         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1799         (PerfTestsRunner.run):
1800         (PerfTestsRunner._run_tests_set):
1801         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1802         (MainTest.run_test):
1803         (MainTest.test_run_test_set):
1804         (MainTest.test_run_test_set_kills_drt_per_run):
1805         (MainTest.test_run_test_set_for_parser_tests):
1806
1807 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
1808
1809         Disable window occlusion detection for WebKitTestRunner Web View on Mac
1810         https://bugs.webkit.org/show_bug.cgi?id=111116
1811
1812         Reviewed by Simon Fraser.
1813
1814         Window occlusion notifications were causing WebKitTestRunner's Web View
1815         to be detected as occluded and causing a few JavaScript timer layout
1816         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
1817         by initializing the page visibility to "visible" after creating the view.
1818         But a better solution is to disable window occlusion detection, so that
1819         not only the page but also the view is treated as visible.
1820
1821         * WebKitTestRunner/TestController.cpp:
1822         (WTR::TestController::createWebViewWithOptions): Remove call to
1823         setVisibilityState, since it is no longer necessary.
1824         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1825         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
1826         detection for the created WKView.
1827
1828 2013-02-28  Li Yin  <li.yin@intel.com>
1829
1830         [chromium] Events can't be triggered on MediaStreamTrack
1831         https://bugs.webkit.org/show_bug.cgi?id=110930
1832
1833         Reviewed by Kentaro Hara.
1834
1835         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
1836
1837         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
1838         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
1839
1840 2013-02-27  James Robinson  <jamesr@chromium.org>
1841
1842         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
1843         https://bugs.webkit.org/show_bug.cgi?id=111017
1844
1845         Reviewed by Adam Barth.
1846
1847         This decouples DumpRenderTree from WebLayerTreeViewClient.
1848
1849         * DumpRenderTree/chromium/WebViewHost.cpp:
1850         (WebViewHostDRTLayerTreeViewClient):
1851         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
1852         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
1853         (WebViewHostDRTLayerTreeViewClient::Layout):
1854         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
1855         (WebViewHost::initializeLayerTreeView):
1856         * DumpRenderTree/chromium/WebViewHost.h:
1857         (webkit_support):
1858         (WebViewHost):
1859
1860 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
1861
1862         Unreviewed, add my secondary email address to the list.
1863
1864         * Scripts/webkitpy/common/config/committers.py:
1865
1866 2013-02-28  Philip Rogers  <pdr@google.com>
1867
1868         Add Philip Rogers as a reviewer.
1869
1870         Unreviewed update of committers.py.
1871
1872         * Scripts/webkitpy/common/config/committers.py:
1873
1874 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1875
1876         Merge more methods on PerfTest
1877         https://bugs.webkit.org/show_bug.cgi?id=111030
1878
1879         Reviewed by Dirk Pranke.
1880
1881         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
1882         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
1883
1884         This makes the control flow a lot more comprehensible.
1885
1886         * Scripts/webkitpy/performance_tests/perftest.py:
1887         (PerfTest._run_with_driver):
1888         (PerfTest._should_ignore_line):
1889         (PerfTest._filter_output):
1890
1891         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1892         (TestPerfTest._assert_results_are_correct):
1893         (test_ignored_stderr_lines):
1894
1895 2013-02-28  Robert Hogan  <robert@webkit.org>
1896
1897         Update my IRC nick
1898
1899         Unreviewed.
1900
1901         * Scripts/webkitpy/common/config/committers.py:
1902
1903 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1904
1905         [Qt] Enable thin archives before parsing the project files
1906
1907         Rubber-stamped by Simon Hausmann.
1908
1909         The targetSubDir() function can be called before default_post.prf has been
1910         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
1911         which is parsed before the main project file.
1912         This issue was revealed by r144299 and fixes the clean build.
1913
1914         * qmake/mkspecs/features/default_post.prf:
1915         * qmake/mkspecs/features/default_pre.prf:
1916
1917 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1918
1919         [Qt] Enable CANVAS_PATH flag
1920         https://bugs.webkit.org/show_bug.cgi?id=108508
1921
1922         Reviewed by Simon Hausmann.
1923
1924         Also enable CANVAS_PATH flag for Qt.
1925
1926         * qmake/mkspecs/features/features.pri:
1927
1928 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1929
1930         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
1931
1932         Rubber-stamped by Csaba Osztrogonác.
1933
1934         Besides suppressing a warning about the non-existing function this
1935         fixes the build if there is a subdirectory (eg. debug-and-release).
1936
1937         * TestWebKitAPI/InjectedBundle.pri:
1938         * TestWebKitAPI/TestWebKitAPI.pri:
1939
1940 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1941
1942         [EFL][WTR] WTR cannot load injected bundle
1943         https://bugs.webkit.org/show_bug.cgi?id=111063
1944
1945         Reviewed by Csaba Osztrogonác.
1946
1947         WTR was not able to load injected bundle because of undefined 
1948         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
1949         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
1950         solves the problem.
1951
1952         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1953         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1954
1955 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
1956
1957         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
1958         https://bugs.webkit.org/show_bug.cgi?id=110464
1959
1960         Reviewed by Rob Buis.
1961
1962         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1963
1964 2013-02-28  Xan Lopez  <xlopez@rim.com>
1965
1966         [BlackBerry] DumpRenderTreeSupport: update the set position methods
1967         https://bugs.webkit.org/show_bug.cgi?id=110578
1968
1969         Reviewed by Rob Buis.
1970
1971         TestRunner::setMockGeolocationPosition() changed in r130416:
1972         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
1973
1974         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
1975         setMockGeolocationPositionUnavailableError() in r129444:
1976         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
1977
1978         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1979         (TestRunner::setMockGeolocationPosition):
1980         (TestRunner::setMockGeolocationPositionUnavailableError):
1981
1982 2013-02-28  Xan Lopez  <xlopez@rim.com>
1983
1984         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
1985         https://bugs.webkit.org/show_bug.cgi?id=110465
1986
1987         Reviewed by Rob Buis.
1988
1989         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1990         (LoadItem::invoke):
1991
1992 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1993
1994         PerfTestRunner doesn't need _needs_http and _has_http_lock
1995         https://bugs.webkit.org/show_bug.cgi?id=111037
1996
1997         Reviewed by Adam Barth.
1998
1999         Delete these variables in favor of using a local variable.
2000
2001         Member variables are like global variables. They introduce implicit dependencies
2002         between member functions.
2003
2004         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2005         (PerfTestsRunner.__init__):
2006         (PerfTestsRunner._start_http_servers):
2007         (PerfTestsRunner):
2008         (PerfTestsRunner._stop_http_servers):
2009         (PerfTestsRunner.run):
2010
2011 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2012
2013         Unreviewed, rolling out r144224.
2014         http://trac.webkit.org/changeset/144224
2015         https://bugs.webkit.org/show_bug.cgi?id=111045
2016
2017         Caused plugins/pass-different-npp-struct.html to time out
2018         (Requested by abarth on #webkit).
2019
2020         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2021         (PassDifferentNPPStruct::NPP_SetWindow):
2022         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2023         (NPP_SetWindow):
2024
2025 2013-02-27  Adam Barth  <abarth@webkit.org>
2026
2027         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
2028         https://bugs.webkit.org/show_bug.cgi?id=110907
2029
2030         Reviewed by Eric Seidel.
2031
2032         This patch changes --enable-threaded-html-parser into
2033         --disable-threaded-html-parser and thereby enables the threaded HTML
2034         parser by default for the Chromium port.
2035
2036         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2037         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2038         (WebTestRunner::WebPreferences::reset):
2039         * DumpRenderTree/chromium/TestShell.cpp:
2040         (TestShell::TestShell):
2041
2042 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
2043
2044         Initialize page visibility after creating WebKitTestRunner WebView on Mac
2045         https://bugs.webkit.org/show_bug.cgi?id=111025
2046
2047         Reviewed by Simon Fraser.
2048
2049         Set page visibility to "visible" after creating WebView to override
2050         visibility state inferred from window occlusion notifications on Mac.
2051
2052         * WebKitTestRunner/TestController.cpp:
2053         (WTR::TestController::createWebViewWithOptions): Add call to
2054         setVisibilityState.
2055
2056 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2057
2058         Merge PageLoadingPerfTest into ReplayPerfTest
2059         https://bugs.webkit.org/show_bug.cgi?id=111027
2060
2061         Reviewed by Dirk Pranke.
2062
2063         Merged two classes.
2064
2065         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
2066         part of ReplayPerfTest.
2067
2068         * Scripts/webkitpy/performance_tests/perftest.py:
2069         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
2070         (ReplayPerfTest.__init__):
2071         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
2072         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
2073         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2074         (TestReplayPerfTest):
2075         (TestReplayPerfTest.test_run_single.run_test):
2076         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
2077         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
2078         TestPageLoadingPerfTest.test_run.
2079         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
2080         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
2081         TestPageLoadingPerfTest.test_run_with_memory_output
2082         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
2083         (TestReplayPerfTest.test_prepare_calls_run_single):
2084
2085 2013-02-27  Eric Seidel  <eric@webkit.org>
2086
2087         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
2088         https://bugs.webkit.org/show_bug.cgi?id=111021
2089
2090         Reviewed by Dirk Pranke.
2091
2092         The underlying code (which is shared with run-webkit-tests)
2093         already knew how to support this option, it just wasn't exposed
2094         via the run-perf-tests front-end.  This patch fixes that.
2095
2096         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2097         (PerfTestsRunner._parse_args):
2098
2099 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2100
2101         Stop uploading results to webkit-perf.appspot.com
2102         https://bugs.webkit.org/show_bug.cgi?id=110954
2103
2104         Reviewed by Benjamin Poulain.
2105
2106         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
2107
2108         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2109         (RunAndUploadPerfTests):
2110
2111 2013-02-27  James Simonsen  <simonjam@chromium.org>
2112
2113         [chromium] Lower priority of preloaded images
2114         https://bugs.webkit.org/show_bug.cgi?id=110527
2115
2116         Plumb the didChangePriority signal into DRT so it can be tested.
2117
2118         Reviewed by Nate Chapin.
2119
2120         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2121         (WebKit):
2122         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
2123         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2124         (WebTestRunner::TestRunner::TestRunner):
2125         (WebTestRunner::TestRunner::reset):
2126         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
2127         (WebTestRunner):
2128         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
2129         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2130         (TestRunner):
2131         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2132         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2133         (WebTestRunner::WebTestProxyBase::willSendRequest):
2134         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
2135         (WebTestRunner):
2136
2137 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
2138
2139         AX: Mac platform should support ability to scroll an element into visible
2140         https://bugs.webkit.org/show_bug.cgi?id=109860
2141
2142         Reviewed by Beth Dakin.
2143
2144         * DumpRenderTree/AccessibilityUIElement.cpp:
2145         (scrollToMakeVisibleCallback):
2146         (AccessibilityUIElement::getJSClass):
2147         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2148         (AccessibilityUIElement::scrollToMakeVisible):
2149         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2150         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2151         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2152         (AccessibilityUIElement):
2153         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2154         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2155         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2156         (WTR):
2157
2158 2013-02-27  John Bauman  <jbauman@chromium.org>
2159
2160         Plugin in iframe may not display
2161         https://bugs.webkit.org/show_bug.cgi?id=109879
2162
2163         Reviewed by Simon Fraser.
2164
2165         LogNPPSetWindow will be used with other ports as well.
2166
2167         * DumpRenderTree/DumpRenderTree.gypi:
2168         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2169
2170 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
2171
2172         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2173         https://bugs.webkit.org/show_bug.cgi?id=110973
2174
2175         Reviewed by Adam Barth.
2176
2177         There is nothing that ensures that the log messages from the plugin
2178         come in before the layout test finished loading.
2179
2180         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2181         (PassDifferentNPPStruct::NPP_SetWindow):
2182         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2183         (NPP_SetWindow):
2184
2185 2013-02-27  Glenn Adams  <glenn@skynav.com>
2186
2187         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
2188         https://bugs.webkit.org/show_bug.cgi?id=110944
2189
2190         Reviewed by Dean Jackson.
2191
2192         * Scripts/webkitperl/FeatureList.pm:
2193         * qmake/mkspecs/features/features.pri:
2194
2195 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
2196
2197         Unreviewed. Remove myself from watchlist.
2198
2199         * Scripts/webkitpy/common/config/watchlist:
2200
2201 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2202
2203         Switch QtWebKit to GStreamer 1.0.
2204         https://bugs.webkit.org/show_bug.cgi?id=106669.
2205
2206         Original patch by Sebastian Dröge.
2207         Reviewed by Csaba Osztrogonác.
2208
2209         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
2210         temporarily to make upgrading easy and the patch suitable for Qt5.
2211
2212         * qmake/mkspecs/features/features.prf:
2213
2214 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
2215
2216         Unreviewed. Added myself to committers.py
2217
2218         * Scripts/webkitpy/common/config/committers.py:
2219
2220 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2221
2222         Unreviewed, rolling out r144192.
2223         http://trac.webkit.org/changeset/144192
2224         https://bugs.webkit.org/show_bug.cgi?id=110984
2225
2226         Stored svn password on wrong computer (Requested by kkristof
2227         on #webkit).
2228
2229         * Scripts/webkitpy/common/config/committers.py:
2230
2231 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
2232
2233         Unreviewed. Added myself to committers.py
2234
2235         * Scripts/webkitpy/common/config/committers.py:
2236
2237 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2238
2239         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
2240
2241         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2242         (PerfTestsRunner._upload_json):
2243
2244 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2245
2246         Stop uploading results to webkit-perf.appspot.com
2247         https://bugs.webkit.org/show_bug.cgi?id=110954
2248
2249         Reviewed by Benjamin Poulain.
2250
2251         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
2252         Also, always use the new JSON format. Removed the code to generate the old format.
2253
2254         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2255         (PerfTestsRunner._generate_and_show_results):
2256         (PerfTestsRunner._generate_results_dict):
2257         (PerfTestsRunner._merge_slave_config_json):
2258         (PerfTestsRunner._generate_output_files):
2259
2260 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2261
2262         Unreviewed, rolling out r144136, r144143, and r144147.
2263         http://trac.webkit.org/changeset/144136
2264         http://trac.webkit.org/changeset/144143
2265         http://trac.webkit.org/changeset/144147
2266         https://bugs.webkit.org/show_bug.cgi?id=110950
2267
2268         Caused some timeouts and flaky crashes (Requested by abarth on
2269         #webkit).
2270
2271         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2272         (main):
2273         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2274         (WebTestRunner::WebPreferences::reset):
2275         * DumpRenderTree/chromium/TestShell.cpp:
2276         (TestShell::TestShell):
2277
2278 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2279
2280         Use perf.webkit.org JSON format in results page
2281         https://bugs.webkit.org/show_bug.cgi?id=110842
2282
2283         Reviewed by Benjamin Poulain.
2284
2285         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
2286
2287         A whole bunch of integration tests have been updated to use the new JSON format.
2288
2289         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2290         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
2291         and legacy_output_json_path respectively.
2292         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
2293         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
2294         JSON file and the results page out of perf_webkit_output instead of legacy_output.
2295
2296         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2297         (MainTest.test_run_memory_test):
2298         (MainTest._test_run_with_json_output.mock_upload_json):
2299         (MainTest):
2300         (MainTest.test_run_with_json_output):
2301         (MainTest.test_run_with_description):
2302         (MainTest.test_run_generates_json_by_default):
2303         (MainTest.test_run_merges_output_by_default):
2304         (MainTest.test_run_respects_reset_results):
2305         (MainTest.test_run_generates_and_show_results_page):
2306         (MainTest.test_run_with_slave_config_json):
2307         (MainTest.test_run_with_multiple_repositories):
2308         (MainTest.test_run_with_upload_json):
2309         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
2310
2311 2013-02-26  Adam Barth  <abarth@webkit.org>
2312
2313         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
2314         https://bugs.webkit.org/show_bug.cgi?id=110907
2315
2316         Reviewed by Eric Seidel.
2317
2318         This patch changes --enable-threaded-html-parser into
2319         --disable-threaded-html-parser and thereby enables the threaded HTML
2320         parser by default for the Chromium port.
2321
2322         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2323         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2324         (WebTestRunner::WebPreferences::reset):
2325         * DumpRenderTree/chromium/TestShell.cpp:
2326         (TestShell::TestShell):
2327
2328 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
2329
2330         [chromium] Re-enable the fixed version of freetype on linux
2331         https://bugs.webkit.org/show_bug.cgi?id=110542
2332
2333         Reviewed by Tony Chang.
2334
2335         Re-land the change in r143794 to switch to building with a fixed
2336         version of FreeType for just DumpRenderTree. This allows us to share
2337         one version of pixel baselines for both Lucid and Precise, and run the
2338         layout tests in a stock Precise install (instead of a Lucid chroot).
2339         Going forward, this approach isolates us from os-level changes to the
2340         version of FreeType. Note that Chromium itself still uses the system
2341         FreeType and is unaffected by this change.
2342         
2343         This setting can still be turned off (at compile/gyp-time) by
2344         manually setting use_custom_freetype=0.
2345
2346         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2347
2348 2013-02-26  Nico Weber  <thakis@chromium.org>
2349
2350         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
2351         https://bugs.webkit.org/show_bug.cgi?id=110890
2352
2353         Reviewed by Jochen Eisinger.
2354
2355         Several functions in webkit check that bit to change rendering
2356         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
2357         disables font smoothing in this mode. TestShell and DRT both set
2358         this flag, so content shell drt should set it too.
2359
2360         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2361         (WebTestRunner::TestInterfaces::TestInterfaces):
2362
2363 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
2364
2365         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
2366         https://bugs.webkit.org/show_bug.cgi?id=110884
2367
2368         Reviewed by Csaba Osztrogonác.
2369
2370         Adding the missing spaces before ':' in the unit test.
2371
2372         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2373
2374 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
2375
2376         new-commit-bot: Some IRC clients doesn't linkify rollout messages
2377         https://bugs.webkit.org/show_bug.cgi?id=110861
2378
2379         Reviewed by Ryosuke Niwa.
2380
2381         Adding the space before ':' in order to fix the links shown for the rollout message.
2382
2383         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2384         (NewCommitBot._summarize_commit_log):
2385
2386 2013-02-26  Joone Hur  <joone.hur@intel.com>
2387
2388         [GTK] Add Clutter to jhbuild
2389         https://bugs.webkit.org/show_bug.cgi?id=110245
2390
2391         Reviewed by Martin Robinson.
2392
2393         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
2394         This allows to build WebKitGtk+ with clutter as an acceleration backend
2395         within the jhbuild environment. 
2396
2397         * gtk/jhbuild-optional.modules:
2398
2399 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2400
2401         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
2402
2403         * Scripts/webkitpy/common/checkout/scm/svn.py:
2404         (SVN.value_from_svn_info):
2405
2406 2013-02-25  Alan Cutter  <alancutter@chromium.org>
2407
2408         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
2409         https://bugs.webkit.org/show_bug.cgi?id=110845
2410
2411         Unreviewed EWS bot fix.
2412
2413         Switch the Queue Status Server address the EWS bots use to a more direct URL that
2414         doesn't seem to be having problems from GCE like queues.webkit.org.
2415
2416         * Scripts/webkitpy/common/net/statusserver.py:
2417         (StatusServer):
2418
2419 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2420
2421         Forgot to delete a no-longer-needed unit test after r143980.
2422
2423         Unreviewed, build fix.
2424
2425         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2426         (ChromiumWinTest.test_path_to_image_diff):
2427
2428 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2429
2430         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
2431         Don't include \r at the end of svn info lines on Windows.
2432
2433         This is similar to r143839.
2434
2435         * Scripts/webkitpy/common/checkout/scm/svn.py:
2436         (SVN.value_from_svn_info):
2437
2438 2013-02-25  James Simonsen  <simonjam@chromium.org>
2439
2440         [Resource Timing] Update test suite so it can be exported to the W3C
2441         https://bugs.webkit.org/show_bug.cgi?id=107343
2442
2443         Reviewed by Tony Gentilcore.
2444
2445         * Scripts/export-w3c-performance-wg-tests: Clean up output.
2446         * Scripts/import-w3c-performance-wg-tests:
2447
2448 2013-02-25  Anders Carlsson  <andersca@apple.com>
2449
2450         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
2451         https://bugs.webkit.org/show_bug.cgi?id=110821
2452         <rdar://problem/13265303>
2453
2454         Reviewed by Beth Dakin.
2455
2456         Update for WebKit2 changes.
2457
2458         * MiniBrowser/mac/WK2BrowserWindowController.m:
2459         (-[WK2BrowserWindowController awakeFromNib]):
2460         * WebKitTestRunner/TestController.cpp:
2461         (WTR::TestController::createOtherPage):
2462         (WTR::TestController::createWebViewWithOptions):
2463         (WTR::TestController::unavailablePluginButtonClicked):
2464         * WebKitTestRunner/TestController.h:
2465         (TestController):
2466
2467 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
2468
2469         Optionally partition cache to prevent using cache for tracking
2470         https://bugs.webkit.org/show_bug.cgi?id=110269
2471
2472         Reviewed by Maciej Stachowiak.
2473
2474         Add test suite for public suffix functions on Mac.
2475
2476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2477         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
2478         (TestWebKitAPI):
2479         (TestWebKitAPI::TEST_F):
2480
2481 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2482
2483         nrwt: reenable multiple http shards on chromium win
2484         https://bugs.webkit.org/show_bug.cgi?id=110814
2485
2486         Reviewed by Tony Chang.
2487
2488         The underlying bug in DumpRenderTree that was causing us to look for a
2489         pac file and timeout under load was fixed a while ago.
2490
2491         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2492         (ChromiumWinPort.relative_test_filename):
2493
2494 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2495
2496         Make ninja the default w/ build-webkit --chromium on windows.
2497         https://bugs.webkit.org/show_bug.cgi?id=110731
2498
2499         Unreviewed - TBR'ing thakis :).
2500
2501         * Scripts/update-webkit-chromium:
2502
2503 2013-02-25  Anders Carlsson  <andersca@apple.com>
2504
2505         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
2506         https://bugs.webkit.org/show_bug.cgi?id=110793
2507         <rdar://problem/13265303>
2508
2509         Reviewed by Sam Weinig.
2510
2511         Update for WebKit2 API changes.
2512
2513         * MiniBrowser/mac/WK2BrowserWindowController.m:
2514         (-[WK2BrowserWindowController awakeFromNib]):
2515         * WebKitTestRunner/TestController.cpp:
2516         (WTR::TestController::createWebViewWithOptions):
2517
2518 2013-02-25  Nico Weber  <thakis@chromium.org>
2519
2520         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
2521         https://bugs.webkit.org/show_bug.cgi?id=110775
2522
2523         Unreviewed, basically a rebaseline.
2524
2525         * Scripts/webkitpy/common/config/watchlist:
2526
2527 2013-02-25  Nico Weber  <thakis@chromium.org>
2528
2529         [chromium] Try to get the webkit builder to use msvs again
2530         https://bugs.webkit.org/show_bug.cgi?id=110771
2531
2532         Reviewed by Eric Seidel.
2533
2534         The msvs gyp generator apparently doesn't write the sln file on every
2535         run, so check the vcxproj file instead.
2536
2537         * Scripts/webkitdirs.pm:
2538         (determineIsChromiumNinja):
2539
2540 2013-02-25  Nico Weber  <thakis@chromium.org>
2541
2542         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
2543         https://bugs.webkit.org/show_bug.cgi?id=110767
2544
2545         Reviewed by Eric Seidel.
2546
2547         The tester runs gyp, which generates out/Release/build.ninja. The bot
2548         scripts use existence (and timestamp) of that file to decide if the
2549         current build is supposed to be ninja or xcodebuild. The file exists,
2550         so the snapshot is extracted to out/Release. The snapshot doesn't
2551         contain build.ninja however due to
2552         http://trac.webkit.org/changeset/140375 , so after extracting the
2553         snapshot the scripts think that this is an xcodebuild build. So remove
2554         the part of that revision that removed ninja files from the archive,
2555         and the bots should be happy again.
2556
2557         * BuildSlaveSupport/built-product-archive:
2558         (archiveBuiltProduct):
2559
2560 2013-02-25  Nico Weber  <thakis@chromium.org>
2561
2562         Fix tests after r143910
2563         https://bugs.webkit.org/show_bug.cgi?id=110757
2564
2565         Reviewed by Andreas Kling.
2566
2567         While here, also add a test for the bug r143910 fixed.
2568
2569         * Scripts/webkitpy/common/system/executive_unittest.py:
2570         (ScriptErrorTest.test_message_with_output):
2571         (ScriptErrorTest):
2572         (ScriptErrorTest.test_message_with_tuple):
2573
2574 2013-02-25  Nico Weber  <thakis@chromium.org>
2575
2576         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
2577         https://bugs.webkit.org/show_bug.cgi?id=110755
2578
2579         Reviewed by Jochen Eisinger.
2580
2581         * BuildSlaveSupport/built-product-archive:
2582         (archiveBuiltProduct):
2583         (extractBuiltProduct):
2584
2585 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2586
2587         Unreviewed, rolling out r143895.
2588         http://trac.webkit.org/changeset/143895
2589         https://bugs.webkit.org/show_bug.cgi?id=110758
2590
2591         broke a bunch of tests (Requested by thakis__ on #webkit).
2592
2593         * Scripts/update-webkit-chromium:
2594
2595 2013-02-25  Andreas Kling  <akling@apple.com>
2596
2597         Unreviewed, fix simple mistake in r143903.
2598         <http://webkit.org/b/110746>
2599
2600         Reviewed by Andreas Kling.
2601
2602         Pass git revision, not svn revision, to git shell command.
2603
2604         * Scripts/webkitpy/common/checkout/scm/git.py:
2605         (Git.timestamp_of_latest_commit):
2606
2607 2013-02-25  Nico Weber  <thakis@chromium.org>
2608
2609         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
2610         https://bugs.webkit.org/show_bug.cgi?id=110748
2611
2612         Reviewed by Jochen Eisinger.
2613
2614         One of the mac testers runs DRT from out/ but WebKitUnitTests from
2615         xcodebuild. I'm trying to understand what's going on.
2616
2617         * BuildSlaveSupport/built-product-archive:
2618         (archiveBuiltProduct):
2619         (extractBuiltProduct):
2620
2621 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
2622
2623         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
2624         https://bugs.webkit.org/show_bug.cgi?id=110599
2625
2626         Reviewed by Yury Semikhatsky.
2627
2628         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
2629         that were given us via MemoryInstrumentation calls.
2630         So I extended client api with registerString method that pushes the strings
2631         down to the serializer.
2632
2633         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2634         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2635         (TestWebKitAPI::Helper::Helper):
2636         (Helper):
2637         (TestWebKitAPI::Helper::addNode):
2638         (TestWebKitAPI::TEST):
2639
2640 2013-02-25  Nico Weber  <thakis@chromium.org>
2641
2642         Make ScriptError not crash when args is a tuple
2643         https://bugs.webkit.org/show_bug.cgi?id=110747
2644
2645         Reviewed by Jochen Eisinger.
2646
2647         I'm trying to understand the error on
2648         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
2649         better. I'll likely have to revert the ninja switch on windows, but
2650         having error reporting code that doesn't itself crash sounds like a
2651         good thing to have anyways.
2652
2653         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
2654         tuple not a list.
2655
2656         * Scripts/run-chromium-webkit-unit-tests:
2657         * Scripts/webkitpy/common/system/executive.py:
2658         (ScriptError.__init__):
2659
2660 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
2661
2662         [EFL] Align feature defaults
2663         https://bugs.webkit.org/show_bug.cgi?id=110715
2664
2665         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
2666         OptionsEfl.cmake.
2667
2668         Reviewed by Gyuyoung Kim.
2669
2670         * Scripts/webkitperl/FeatureList.pm:
2671
2672 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2673
2674         run-perf-tests reports wrong commit time
2675         https://bugs.webkit.org/show_bug.cgi?id=110746
2676
2677         Reviewed by Andreas Kling.
2678
2679         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
2680         of when the subdirectory was last modified.
2681
2682         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
2683         insufficient since running "svn log -r <revision>" on a partial checkout only returns
2684         an empty result if the revision didn't modify the subdirectory.
2685
2686         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
2687         the interface compatible with svn.
2688
2689         * Scripts/webkitpy/common/checkout/scm/git.py:
2690         (Git.timestamp_of_latest_commit):
2691         * Scripts/webkitpy/common/checkout/scm/scm.py:
2692         (SCM.timestamp_of_latest_commit):
2693         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2694         (MockSCM.timestamp_of_latest_commit):
2695         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2696         (test_timestamp_of_latest_commit):
2697         * Scripts/webkitpy/common/checkout/scm/svn.py:
2698         (SVN.timestamp_of_latest_commit):
2699         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2700         (PerfTestsRunner._generate_results_dict):
2701
2702 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
2703
2704         [chromium] move WebRuntimeFeatures configuration to TestRunner library
2705         https://bugs.webkit.org/show_bug.cgi?id=110712
2706
2707         Reviewed by Nico Weber.
2708
2709         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2710         (WebTestRunner::TestInterfaces::TestInterfaces):
2711         * DumpRenderTree/chromium/TestShell.cpp:
2712         (TestShell::TestShell):
2713
2714 2013-02-25  Nico Weber  <thakis@chromium.org>
2715
2716         Make ninja the default build system for build-webkit --chromium on windows
2717         https://bugs.webkit.org/show_bug.cgi?id=110731
2718
2719         Reviewed by Jochen Eisinger.
2720
2721         With http://crbug.com/169945 fixed, this should now work.
2722
2723         * Scripts/update-webkit-chromium:
2724
2725 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
2726
2727         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
2728         https://bugs.webkit.org/show_bug.cgi?id=110702
2729
2730         Reviewed by Martin Robinson.
2731
2732         * GtkLauncher/main.c: include autotoolsconfig.h.
2733         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
2734         the include ordering check, since it uses autotoolsconfig.h which needs to
2735         come first.
2736
2737 2013-02-24  Hajime Morrita  <morrita@google.com>
2738
2739         [Custom Elements] Implement bare-bone document.register()
2740         https://bugs.webkit.org/show_bug.cgi?id=100229
2741
2742         Reviewed by Adam Barth.
2743
2744         Added enableCustomDOMElements flag.
2745
2746         * DumpRenderTree/chromium/TestShell.cpp:
2747         (TestShell::TestShell):
2748
2749 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
2750
2751         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
2752         https://bugs.webkit.org/show_bug.cgi?id=110606
2753
2754         Reviewed by Adam Barth.
2755
2756         Part of a larger refactoring series; see tracking bug 82948.
2757
2758         * DumpRenderTree/DumpRenderTree.gypi:
2759         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2760         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
2761         (WebKitSupportTestEnvironment::mockPlatform):
2762         (WebKitSupportTestEnvironment):
2763         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
2764         (MockPlatform::create):
2765         (MockPlatform::MockPlatform):
2766         (MockPlatform::~MockPlatform):
2767         (MockPlatform::setInterfaces):
2768         (MockPlatform::cryptographicallyRandomValues):
2769         (MockPlatform::createMediaStreamCenter):
2770         (MockPlatform::createRTCPeerConnectionHandler):
2771         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
2772         (MockPlatform):
2773         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
2774         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
2775         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2776         (WebTestDelegate):
2777         * DumpRenderTree/chromium/TestShell.cpp:
2778         (TestShell::initialize):
2779         * DumpRenderTree/chromium/TestShell.h:
2780         (TestShell):
2781
2782 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2783
2784         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
2785
2786         * Scripts/webkitpy/common/checkout/scm/svn.py:
2787         (SVN.timestamp_of_latest_commit):
2788
2789 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
2790
2791         Move setAutofilled from TestRunner to WebCore
2792         https://bugs.webkit.org/show_bug.cgi?id=110521
2793
2794         Reviewed by Benjamin Poulain.
2795
2796         * DumpRenderTree/TestRunner.cpp:
2797         (TestRunner::staticFunctions):
2798         * DumpRenderTree/TestRunner.h:
2799         (TestRunner):
2800         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2801         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2802         (WebTestRunner::TestRunner::TestRunner):
2803         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2804         (TestRunner):
2805         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2806         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2807         * DumpRenderTree/mac/TestRunnerMac.mm:
2808         * DumpRenderTree/qt/TestRunnerQt.cpp:
2809         * DumpRenderTree/qt/TestRunnerQt.h:
2810         (TestRunnerQt):
2811         * DumpRenderTree/win/TestRunnerWin.cpp:
2812         * DumpRenderTree/wx/TestRunnerWx.cpp:
2813
2814 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
2815
2816         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
2817         https://bugs.webkit.org/show_bug.cgi?id=108577
2818
2819         Reviewed by Dirk Pranke.
2820
2821         Upload results to perf.webkit.org using new JSON format as well as the host specified by
2822         --test-results-server. The new format is needed to provide extra information perf.webkit.org
2823         need such as the subversion commit time and test URLs. This is a temporarily measure until
2824         we complete the transition and the old JSON format and the code to upload results to
2825         webkit-perf.appspot.com can be deleted.
2826
2827         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
2828         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
2829         so that the app can sort performance test results based on the timestamp of the last commit.
2830
2831         It also changes the repository names returned by port objects to be properly capitalized
2832         human readable names such as WebKit instead of lowercased names such as webkit since these names
2833         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
2834         to explicitly lowercase the names.
2835
2836
2837         * Scripts/webkitpy/common/checkout/scm/git.py:
2838         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
2839         git's timestamp granularity is seconds so we're losing some information compared to using a regular
2840         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
2841         UTC so we're going to manually fiddle with timezone.
2842
2843         * Scripts/webkitpy/common/checkout/scm/scm.py:
2844         (SCM.timestamp_of_latest_commit): Added.
2845
2846         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2847         (MockSCM.timestamp_of_latest_commit): Added.
2848
2849         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2850         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
2851
2852         * Scripts/webkitpy/common/checkout/scm/svn.py:
2853         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
2854         the timestamp which is always in UTC.
2855
2856         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2857         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
2858         'chromium' needs to be substituted by 'chrome' for historical reasons.
2859
2860         * Scripts/webkitpy/layout_tests/port/base.py:
2861         (Port.repository_paths): Return WebKit instead of webkit as noted above.
2862
2863         * Scripts/webkitpy/layout_tests/port/chromium.py:
2864         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
2865
2866         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2867         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
2868         (PerfTestsRunner._collect_tests):
2869
2870         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
2871         and upload them appropriately.
2872
2873         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
2874         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
2875
2876         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
2877
2878         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
2879         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
2880         e.g. "processor" would be renamed to "builderProcessor".
2881
2882         (PerfTestsRunner._generate_output_files):
2883
2884         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
2885         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
2886         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
2887         webkit-perf.appspot.com which spits out a plaintext response.
2888
2889         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2890         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
2891         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
2892         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
2893
2894         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2895         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
2896         cases to parse JSON responses.
2897         (MainTest.test_upload_json.MockFileUploader): Refactored.
2898         (MainTest.test_upload_json.MockFileUploader.reset): Added.
2899         (MainTest.test_upload_json.MockFileUploader.__init__):
2900         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
2901
2902 2013-02-22  Roger Fong  <roger_fong@apple.com>
2903
2904         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
2905
2906         * BuildSlaveSupport/build.webkit.org-config/config.json:
2907
2908 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2909
2910         Unreviewed, rolling out r143794.
2911         http://trac.webkit.org/changeset/143794
2912         https://bugs.webkit.org/show_bug.cgi?id=110542
2913
2914         debug linux builds broken?
2915
2916         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2917
2918 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2919
2920         [chromium] enable the fixed version of freetype on linux
2921         https://bugs.webkit.org/show_bug.cgi?id=110542
2922
2923         Reviewed by Tony Chang.
2924
2925         Switch to building with a fixed version of FreeType for
2926         just DumpRenderTree. This allows us to share one version
2927         of pixel baselines for both Lucid and Precise, and run
2928         the layout tests in a stock Precise install (instead of a Lucid
2929         chroot). Going forward, this approach isolates us from os-level
2930         changes to the version of FreeType. Note that Chromium itself
2931         still uses the system FreeType and is unaffected by this change.
2932         
2933         This setting can still be turned off (at compile/gyp-time) by
2934         manually setting use_custom_freetype=0.
2935
2936         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2937
2938 2013-02-22  Anders Carlsson  <andersca@apple.com>
2939
2940         Move pluginLoadPolicy to the page loader client
2941         https://bugs.webkit.org/show_bug.cgi?id=110635
2942
2943         Reviewed by Sam Weinig.
2944
2945         * MiniBrowser/mac/WK2BrowserWindowController.m:
2946         (-[WK2BrowserWindowController awakeFromNib]):
2947         * WebKitTestRunner/TestController.cpp:
2948         (WTR::TestController::createOtherPage):
2949         (WTR::TestController::createWebViewWithOptions):
2950
2951 2013-02-22  Kenneth Russell  <kbr@google.com>
2952
2953         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
2954
2955         * Scripts/webkitpy/common/config/committers.py:
2956
2957 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2958
2959         [WTR] Do not dump information about empty subframes.
2960         https://bugs.webkit.org/show_bug.cgi?id=110585
2961
2962         Reviewed by Simon Fraser.
2963
2964         Follow DumpRenderTree more closely by skipping empty frames
2965         (frames which have no document). We are not really interested in
2966         showing anything about them.
2967
2968         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2969         (WTR::dumpDescendantFramesText): Do not print subframe names when they
2970         have no associated Document.
2971
2972 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2973
2974         [EFL][DRT] Do not dump empty frames.
2975         https://bugs.webkit.org/show_bug.cgi?id=110474
2976
2977         Reviewed by Kenneth Rohde Christiansen.
2978
2979         Follow the original Mac implementation more closely by skipping
2980         empty frames (frames which have no document). We are not really
2981         interested in showing anything about them.
2982
2983         * DumpRenderTree/efl/DumpRenderTree.cpp:
2984         (dumpFramesAsText):
2985
2986 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
2987
2988         [chromium] support the lucid version of freetype on precise in DRT
2989         https://bugs.webkit.org/show_bug.cgi?id=107338
2990
2991         Reviewed by Tony Chang.
2992
2993         Modify the DRT build so that we can optionally link against
2994         a fixed version of Freetype2. This allows us to share pixel test
2995         results across multiple versions of Ubuntu without having to
2996         worry about differences in font rendering.
2997
2998         At the moment this feature is off by default. Eventually it will
2999         be on by default on linux.
3000
3001         Note that this only affects DRT; the regular Chromium binary
3002         (and, for now, content_shell) will still use the system version
3003         of Freetype.
3004
3005         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3006
3007 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
3008
3009         [Chromium] Remove the word "cheher" from the list of misspelled words
3010         https://bugs.webkit.org/show_bug.cgi?id=110447
3011
3012         Reviewed by Tony Chang.
3013
3014         Other platforms do not mark "cheher" as a misspelled word in layout tests.
3015         This change is to bring Chromium platform in line with the rest of the
3016         platforms.
3017
3018         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
3019         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
3020         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
3021         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
3022
3023 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
3024
3025         [chromium] document WebTestDelegate and WebTestRunner interfaces
3026         https://bugs.webkit.org/show_bug.cgi?id=110472
3027
3028         Reviewed by Adam Barth.
3029
3030         Also remove the default implementation of the remaining WebTestDelegate
3031         methods now that all embedders provide this interface.
3032
3033         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3034         (WebTestDelegate):
3035         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3036         (WebTestRunner):
3037
3038 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
3039
3040         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
3041         https://bugs.webkit.org/show_bug.cgi?id=106059
3042
3043         Reviewed by Geoffrey Garen.
3044
3045         Added new tests for the WebKit API portion of the JSC Objective-C API.
3046
3047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3048         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
3049         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
3050         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
3051         (-[MyConsole log:]):
3052         (-[MyConsole printHelloWorld]):
3053         (-[MyConsole add:to:]):
3054         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
3055         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3056         (TestWebKitAPI):
3057         (TestWebKitAPI::TEST):
3058
3059 2013-02-21  Stephen Chenney  <schenney@chromium.org>
3060
3061         Unreviewed, add myself as a reviewer
3062
3063         * Scripts/webkitpy/common/config/committers.py:
3064
3065 2013-02-21  Jer Noble  <jer.noble@apple.com>
3066
3067         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
3068
3069         * Scripts/webkitpy/common/config/committers.py:
3070         * Scripts/webkitpy/common/config/watchlist:
3071
3072 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
3073
3074         gtk/DumpRenderTree.cpp is missing <locale.h> include
3075         https://bugs.webkit.org/show_bug.cgi?id=109386
3076
3077         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
3078         by include locale.h when we use setlocale.
3079
3080 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
3081
3082         [GTK] Move feature overriding to the configure phase
3083         https://bugs.webkit.org/show_bug.cgi?id=110293
3084
3085         Reviewed by Gustavo Noronha Silva.
3086
3087         * Scripts/webkitdirs.pm:
3088         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
3089         WebKitFeatureOverrides.txt to better match the other filenames used in
3090         the new feature processing.
3091         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
3092         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
3093         and writes WebKitFeatures.txt and WebKitFeatures.h.
3094         * gtk/override-feature-defines: Removed.
3095
3096 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3097
3098         [Qt] Remove obsolete DEPENDPATH assignment
3099
3100         Reviewed by Simon Hausmann
3101
3102         qmake now adds CONFIG+=depend_includepath by default, making manual
3103         DEPENDPATH setup unnecessary.
3104
3105         * qmake/mkspecs/features/default_post.prf:
3106
3107 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
3108
3109         Unreviewed. Changing primary email id.
3110
3111         * Scripts/webkitpy/common/config/committers.py:
3112
3113 2013-02-14  James Robinson  <jamesr@chromium.org>
3114
3115         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
3116         https://bugs.webkit.org/show_bug.cgi?id=109634
3117
3118         Reviewed by Adrienne Walker.
3119
3120         * DumpRenderTree/chromium/WebViewHost.cpp:
3121         (WebViewHost::createOutputSurface):
3122         (WebViewHost::initializeLayerTreeView):
3123
3124 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
3125
3126         [GTK] Re-enable 3D CSS transforms when using build-webkit
3127         https://bugs.webkit.org/show_bug.cgi?id=110402
3128
3129         Reviewed by Xan Lopez.
3130
3131         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
3132         when building WebKitGTK+.
3133
3134 2013-02-20  Roger Fong  <roger_fong@apple.com>
3135
3136         Get VS2010 Solution B&I ready.
3137         <rdar://problem/1322988>
3138
3139         Rubberstamped by Timothy Horton.        
3140         
3141         Add Production configurations.
3142         
3143         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3144         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3145         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
3146         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3147         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
3148         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3149         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3150         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3151         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
3152         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3153         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
3154         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3155         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3156         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
3157         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3158         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3159         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
3160         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3161         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3162         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3163         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
3164         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3165         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
3166         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3167         * win/record-memory/record-memory.vcxproj:
3168         * win/record-memory/record-memoryProduction.props: Added.
3169         * win/record-memory/record-memoryRelease.props:
3170
3171 2013-02-20  Dirk Schulze  <krit@webkit.org>
3172
3173         Enable CANVAS_PATH flag
3174         https://bugs.webkit.org/show_bug.cgi?id=108508
3175
3176         Reviewed by Simon Fraser.
3177
3178         Enable CANVAS_PATH flag on trunk.
3179
3180         * Scripts/webkitperl/FeatureList.pm:
3181
3182 2013-02-20  Tony Chang  <tony@chromium.org>
3183
3184         Parse author names with commas in ChangeLogs
3185         https://bugs.webkit.org/show_bug.cgi?id=110356
3186
3187         Reviewed by Dirk Pranke.
3188
3189         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
3190
3191         * Scripts/webkitpy/common/checkout/changelog.py:
3192         (ChangeLogEntry): Move name splitting regexp into a constant.
3193         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
3194         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
3195         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
3196         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
3197         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3198         (test_parse_authors): Test case with Paweł's name.
3199
3200 2013-02-15  Dirk Schulze  <krit@webkit.org>
3201
3202         [Chromium] Add runtime flag for CanvasPath
3203         https://bugs.webkit.org/show_bug.cgi?id=109997
3204
3205         Reviewed by Adam Barth.
3206
3207         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
3208         the constructor for Path on DOMWindow would never be activatable, since the script
3209         is running after creating the DOMWindow object.
3210
3211         * DumpRenderTree/chromium/TestShell.cpp:
3212         (TestShell::TestShell):
3213
3214 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
3215
3216         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
3217         https://bugs.webkit.org/show_bug.cgi?id=110346
3218
3219         Reviewed by Adam Barth.
3220
3221         Using an index is very brittle, as the TestRunner API does not define
3222         any ordering of windows.
3223
3224         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
3225         trigger the capturing in the browser process before generating the
3226         text dump.
3227
3228         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3229         (WebTestRunner):
3230         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
3231         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3232         (WebTestRunner):
3233         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3234         (TestRunner):
3235         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3236         (WebTestRunner::WebTestProxyBase::captureTree):
3237         * DumpRenderTree/chromium/WebViewHost.cpp:
3238         (WebViewHost::captureHistoryForWindow):
3239         * DumpRenderTree/chromium/WebViewHost.h:
3240         (WebViewHost):
3241
3242 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
3243
3244         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
3245         https://bugs.webkit.org/show_bug.cgi?id=109220
3246
3247         Reviewed by Tony Chang.
3248
3249         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
3250         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
3251         (WebTestRunner):
3252         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
3253         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
3254         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
3255         (MockSpellCheck):
3256         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
3257         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
3258
3259 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3260
3261         [Gtk] HTML5 Media controls require a design refresh
3262         https://bugs.webkit.org/show_bug.cgi?id=83869
3263
3264         Reviewed by Philippe Normand.
3265
3266         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3267         (initializeGtkFontSettings): Added gnome as default icon theme for
3268         the DRT.
3269         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3270         (WTR::initializeGtkSettings): Added gnome as default icon theme for
3271         the WTR.
3272         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
3273         dependency.
3274
3275 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
3276
3277         [chromium] move most of the remaining mocks to TestRunner library
3278         https://bugs.webkit.org/show_bug.cgi?id=110217
3279
3280         Reviewed by Nico Weber.
3281
3282         While most of the functionality provided by these mocks is also
3283         available in the content module, there is no straight forward way to
3284         inject the mock results required for layout tests.
3285
3286         * DumpRenderTree/DumpRenderTree.gypi:
3287         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3288         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3289         (WebKit):
3290         (WebTestRunner):
3291         (WebTestRunner::WebTestProxy::geolocationClient):
3292         (WebTestRunner::WebTestProxy::speechInputController):
3293         (WebTestRunner::WebTestProxy::speechRecognizer):
3294         (WebTestRunner::WebTestProxy::deviceOrientationClient):
3295         (WebTestRunner::WebTestProxy::requestPointerLock):
3296         (WebTestRunner::WebTestProxy::requestPointerUnlock):
3297         (WebTestRunner::WebTestProxy::isPointerLocked):
3298         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
3299         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
3300         (WebTestRunner):
3301         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
3302         (WebTestRunner::MockWebSpeechInputController::setDelegate):
3303         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
3304         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
3305         (WebTestRunner::MockWebSpeechInputController::clearResults):
3306         (WebTestRunner::MockWebSpeechInputController::startRecognition):
3307         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
3308         (WebTestRunner::MockWebSpeechInputController::stopRecording):
3309         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
3310         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
3311         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
3312         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
3313         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
3314         (WebKit):
3315         (WebTestRunner):
3316         (MockWebSpeechInputController):
3317         (WebTestRunner::MockWebSpeechInputController::taskList):
3318         (SpeechTask):
3319         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
3320         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
3321         (WebTestRunner):
3322         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
3323         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
3324         (WebTestRunner::MockWebSpeechRecognizer::start):
3325         (WebTestRunner::MockWebSpeechRecognizer::stop):
3326         (WebTestRunner::MockWebSpeechRecognizer::abort):
3327         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
3328         (WebTestRunner::MockWebSpeechRecognizer::setError):
3329         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
3330         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
3331         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
3332         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
3333         (WebKit):
3334         (WebTestRunner):
3335         (MockWebSpeechRecognizer):
3336         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
3337         (WebTestRunner::MockWebSpeechRecognizer::client):
3338         (WebTestRunner::MockWebSpeechRecognizer::handle):
3339         (WebTestRunner::MockWebSpeechRecognizer::taskList):
3340         (Task):
3341         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
3342         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
3343         (StepTask):
3344         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
3345         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3346         (WebTestRunner::TestInterfaces::TestInterfaces):
3347         (WebTestRunner::TestInterfaces::windowOpened):
3348         (WebTestRunner):
3349         (WebTestRunner::TestInterfaces::windowClosed):
3350         (WebTestRunner::TestInterfaces::windowList):
3351         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3352         (TestInterfaces):
3353         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3354         (WebTestRunner::TestRunner::TestRunner):
3355         (WebTestRunner::TestRunner::reset):
3356         (WebTestRunner::TestRunner::requestPointerLock):
3357         (WebTestRunner):
3358         (WebTestRunner::TestRunner::requestPointerUnlock):
3359         (WebTestRunner::TestRunner::isPointerLocked):
3360         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
3361         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
3362         (WebTestRunner::TestRunner::didLosePointerLockInternal):
3363         (WebTestRunner::TestRunner::windowCount):
3364         (WebTestRunner::TestRunner::setMockDeviceOrientation):
3365         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
3366         (WebTestRunner::TestRunner::setGeolocationPermission):
3367         (WebTestRunner::TestRunner::setMockGeolocationPosition):
3368         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
3369         (WebTestRunner::TestRunner::addMockSpeechInputResult):
3370         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
3371         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
3372         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
3373         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
3374         (WebTestRunner::TestRunner::didAcquirePointerLock):
3375         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
3376         (WebTestRunner::TestRunner::didLosePointerLock):
3377         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
3378         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
3379         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3380         (WebTestRunner):
3381         (TestRunner):
3382         (HostMethodTask):
3383         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
3384         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
3385         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3386         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
3387         (WebTestRunner::WebTestProxyBase::setInterfaces):
3388         (WebTestRunner::WebTestProxyBase::setDelegate):
3389         (WebTestRunner::WebTestProxyBase::reset):
3390         (WebTestRunner::WebTestProxyBase::captureTree):
3391         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
3392         (WebTestRunner):
3393         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
3394         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
3395         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
3396         (WebTestRunner::WebTestProxyBase::geolocationClient):
3397         (WebTestRunner::WebTestProxyBase::speechInputController):
3398         (WebTestRunner::WebTestProxyBase::speechRecognizer):
3399         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
3400         (WebTestRunner::WebTestProxyBase::requestPointerLock):
3401         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
3402         (WebTestRunner::WebTestProxyBase::isPointerLocked):
3403         * DumpRenderTree/chromium/WebViewHost.cpp:
3404         (WebViewHost::reset):
3405         * DumpRenderTree/chromium/WebViewHost.h:
3406         (WebKit):
3407         (WebViewHost):
3408
3409 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
3410
3411         [Qt] Make debug builds possible on 32bit Linux
3412         https://bugs.webkit.org/show_bug.cgi?id=110231
3413
3414         Reviewed by Tor Arne Vestbø.
3415
3416         Use the stabs format for debug builds to make the object files
3417         a bit smaller so that they can be linked on a 32bit system.
3418
3419         * qmake/mkspecs/features/unix/default_post.prf:
3420
3421 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
3422
3423         Unreviewed. Add myself to watch lists.
3424
3425         * Scripts/webkitpy/common/config/committers.py:
3426         * Scripts/webkitpy/common/config/watchlist:
3427
3428 2013-02-19  Joshua Bell  <jsbell@chromium.org>
3429
3430         Remove warning from run-bindings-tests
3431         https://bugs.webkit.org/show_bug.cgi?id=110285
3432
3433         Reviewed by Kentaro Hara.
3434
3435         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
3436         "Unknown option: idlattributesfile". That option was removed from
3437         bindings/scripts/preprocess-idls.pl but was still being passed by
3438         the test script. Remove it.
3439
3440         * Scripts/webkitpy/bindings/main.py:
3441         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
3442
3443 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
3444
3445         Unreviewed. Add myself to watch lists.
3446
3447         * Scripts/webkitpy/common/config/committers.py:
3448         * Scripts/webkitpy/common/config/watchlist:
3449
3450 2013-02-19  Hans Muller  <hmuller@adobe.com>
3451
3452         Unreviewed, corrected primary email.
3453
3454         * Scripts/webkitpy/common/config/committers.py:
3455
3456 2013-02-19  Hans Muller  <hmuller@adobe.com>
3457
3458         Unreviewed. Adding myself as a committer.
3459
3460         * Scripts/webkitpy/common/config/committers.py:
3461
3462 2013-02-19  Pravin D  <pravind@webkit.org>
3463
3464         Unreviewed, changing primary email.
3465
3466         * Scripts/webkitpy/common/config/committers.py:
3467
3468 2013-02-19  Alan Cutter  <alancutter@chromium.org>
3469
3470         REGRESSION: Sheriffbot is failing to process rollout requests
3471         https://bugs.webkit.org/show_bug.cgi?id=106945
3472
3473         Reviewed by Adam Barth.
3474
3475         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
3476         This resolves problems when Sheriffbot attempts to perform a rollout request.
3477
3478         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3479         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
3480         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
3481
3482 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
3483
3484         Unreviewed build fix.
3485
3486         * efl/jhbuild.modules:
3487         * gtk/jhbuild.modules:
3488
3489         Bump harfbuzz module to 0.9.7. See related bug 110145.
3490
3491 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
3492
3493         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
3494         https://bugs.webkit.org/show_bug.cgi?id=110215
3495
3496         Reviewed by Tor Arne Vestbø.
3497
3498         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
3499         continuing the build. Otherwise skip with an error message explaining which
3500         programs are missing from the build.
3501
3502         * qmake/mkspecs/features/configure.prf:
3503         * qmake/mkspecs/features/functions.prf:
3504
3505 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3506
3507         Unreviewed, rolling out r143319.
3508         http://trac.webkit.org/changeset/143319
3509         https://bugs.webkit.org/show_bug.cgi?id=110214
3510
3511         Causes build issues on win32 (Requested by carewolf on
3512         #webkit).
3513
3514         * qmake/mkspecs/features/features.pri:
3515
3516 2013-02-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3517
3518         [Qt] Enable MathML
3519         https://bugs.webkit.org/show_bug.cgi?id=110205
3520
3521         Reviewed by Simon Hausmann.
3522
3523         * qmake/mkspecs/features/features.pri:
3524
3525 2013-02-17  Andrei Bucur  <abucur@adobe.com>
3526
3527         Unreviewed. Adding myself as a committer.
3528
3529         * Scripts/webkitpy/common/config/committers.py:
3530
3531 2013-02-19  Hajime Morrita  <morrita@google.com>
3532
3533         Unreviewed, updated spelling of my name.
3534
3535         * Scripts/webkitpy/common/config/committers.py:
3536
3537 2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
3538
3539         Unreviewed. Adjust expectations.
3540
3541         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3542         (TestWebKitAPI::TEST):
3543
3544 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
3545
3546         Unreviewed GTK gardening.
3547
3548         * Scripts/run-gtk-tests:
3549         (TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
3550
3551 2013-02-18  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3552
3553         [Qt][WK2] Remove duped test name and append new test in project file
3554         https://bugs.webkit.org/show_bug.cgi?id=110117
3555
3556         A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
3557         add this test into the runnable test suite and remove a duped test in project file.
3558
3559         Reviewed by Jocelyn Turcotte.
3560
3561         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
3562
3563 2013-02-18  Jochen Eisinger  <jochen@chromium.org>
3564
3565         [chromium] remove log spew from dumpAllBackForwardLists
3566         https://bugs.webkit.org/show_bug.cgi?id=110108
3567
3568         Reviewed by Nico Weber.
3569
3570         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3571
3572 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3573
3574         [EFL][WK2] Disable failing API tests
3575         https://bugs.webkit.org/show_bug.cgi?id=110081
3576
3577         Reviewed by Kenneth Rohde Christiansen.
3578
3579         Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
3580
3581         * TestWebKitAPI/PlatformEfl.cmake:
3582
3583 2013-02-18  Simon Hausmann  <simon.hausmann@digia.com>
3584
3585         [Qt] Disable the build if certain configure checks fail
3586         https://bugs.webkit.org/show_bug.cgi?id=110094
3587
3588         Reviewed by Tor Arne Vestbø.
3589
3590         Allow for the build to be skipped (clear out SUBDIRS) if certain
3591         configure conditions aren't met.
3592
3593         * qmake/mkspecs/features/configure.prf:
3594
3595 2013-02-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3596
3597         [Qt][WK2] Support WK2 API tests
3598         https://bugs.webkit.org/show_bug.cgi?id=109843
3599
3600         Reviewed by Jocelyn Turcotte.
3601
3602         * TestWebKitAPI/DerivedSources.pri: Added.
3603         * TestWebKitAPI/InjectedBundle.pri: Added.
3604         * TestWebKitAPI/PlatformWebView.h:
3605         * TestWebKitAPI/TestWebKitAPI.pri:
3606         * TestWebKitAPI/TestWebKitAPI.pro:
3607         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
3608         * TestWebKitAPI/Tests/WTF/WTF.pro:
3609         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
3610         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
3611         (TestWebKitAPI::Util::sleep):
3612         (TestWebKitAPI::Util::createInjectedBundlePath):
3613         (TestWebKitAPI::Util::createURLForResource):
3614         (TestWebKitAPI::Util::isKeyDown):
3615         (Util):
3616         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
3617         (TestWebKitAPI):
3618         (WrapperWindow):
3619         (TestWebKitAPI::WrapperWindow::WrapperWindow):
3620         (TestWebKitAPI::WrapperWindow::handleStatusChanged):
3621         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3622         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3623         (TestWebKitAPI::PlatformWebView::resizeTo):
3624         (TestWebKitAPI::PlatformWebView::page):
3625         (TestWebKitAPI::PlatformWebView::focus):
3626         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3627         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3628         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3629         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3630         * TestWebKitAPI/qt/main.cpp:
3631         (addQtWebProcessToPath):
3632         (main):
3633
3634 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3635
3636         [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
3637         https://bugs.webkit.org/show_bug.cgi?id=108598
3638
3639         Reviewed by Kenneth Rohde Christiansen.
3640
3641         Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
3642
3643         * MiniBrowser/efl/main.c:
3644         (update_view_favicon):
3645         (on_view_favicon_changed):
3646         (window_create):
3647
3648 2013-02-18  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3649
3650         Unreviewed. Add myself as a committer.
3651
3652         * Scripts/webkitpy/common/config/committers.py:
3653
3654 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
3655
3656         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3657         https://bugs.webkit.org/show_bug.cgi?id=109554
3658
3659         In some cases leaves have no pointer so with the&