[EFL] Remove E_Dbus dependency
[WebKit-https.git] / Tools / ChangeLog
1 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
2
3         [EFL] Remove E_Dbus dependency
4         https://bugs.webkit.org/show_bug.cgi?id=136355
5
6         Reviewed by Gyuyoung Kim.
7
8         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
9
10 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
11
12         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
13         https://bugs.webkit.org/show_bug.cgi?id=139047
14
15         Reviewed by Carlos Garcia Campos.
16
17         * efl/jhbuild.modules:
18         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
19         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
20         * gtk/jhbuild-optional.modules:
21         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
22         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
23
24 2014-11-25  Tanay C  <tanay.c@samsung.com>
25
26         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
27         https://bugs.webkit.org/show_bug.cgi?id=138090
28
29         Reviewed by Carlos Garcia Campos.
30
31         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
32         (browserWindowZoomIn): Added.
33         (browserWindowZoomOut): Added.
34         (scrollEventCallback): Added.
35         (zoomInCallback): Modified.
36         (zoomOutCallback): Modified.
37         (browserWindowConstructed): Modified.
38
39 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
40
41         [EFL] REGRESSION(r176514): It made performance tests fail
42         https://bugs.webkit.org/show_bug.cgi?id=139037
43
44         Reviewed by Gyuyoung Kim.
45
46         * Scripts/webkitpy/port/efl.py:
47         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
48         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
49         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
50
51 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
52
53         [GTK] update-webkitgtk-libs fails to build fontconfig
54         https://bugs.webkit.org/show_bug.cgi?id=139032
55
56         Reviewed by Martin Robinson.
57
58         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
59         fontconfig will try to generate documentation and fail.
60
61         * gtk/install-dependencies:
62
63 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
64
65         Unreviewed. Fix GTK+ make distcheck.
66
67         * gtk/manifest.txt: Remove deleted files.
68
69 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
70
71         [EFL] Utilize Eail library to support accessibility in EFL
72         https://bugs.webkit.org/show_bug.cgi?id=137742
73
74         Reviewed by Gyuyoung Kim.
75
76         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
77
78         * efl/jhbuild-optional.modules: Added.
79         * efl/jhbuild.modules:
80
81 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
82
83         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
84         https://bugs.webkit.org/show_bug.cgi?id=139023
85
86         Reviewed by Sergio Villar Senin.
87
88         Rename WebKitWebView/default-context as WebKitWebView/web-context
89         and check we are always using the right context for new web views.
90
91         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
92         (testWebViewWebContext):
93         (beforeAll):
94         (testWebViewDefaultContext): Deleted.
95
96 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
97
98         [GTK] Add API to override the default local storage directory
99         https://bugs.webkit.org/show_bug.cgi?id=138828
100
101         Reviewed by Gustavo Noronha Silva.
102
103         Add test to check that the local storage directory is created at
104         the path given on construction.
105
106         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
107         (testWebContextConfiguration):
108         (beforeAll):
109         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
110         (Test::Test):
111         (Test::~Test): Deleted.
112
113 2014-11-21  Zalan Bujtas  <zalan@apple.com>
114
115         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
116         https://bugs.webkit.org/show_bug.cgi?id=138981
117
118         Reviewed by Simon Fraser.
119
120         * MiniBrowser/mac/SettingsController.h:
121         * MiniBrowser/mac/SettingsController.m:
122         (-[SettingsController _populateMenu]):
123         (-[SettingsController validateMenuItem:]):
124         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
125         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
126         * MiniBrowser/mac/WK1BrowserWindowController.m:
127         (-[WK1BrowserWindowController didChangeSettings]):
128         * MiniBrowser/mac/WK2BrowserWindowController.m:
129         (-[WK2BrowserWindowController didChangeSettings]):
130
131 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
132
133         Remove http lock code from webkitperl
134         https://bugs.webkit.org/show_bug.cgi?id=138959
135
136         Reviewed by Alexey Proskuryakov.
137
138         * Scripts/webkitperl/httpd.pm:
139         (cleanUp):
140         (extractLockNumber): Deleted.
141         (getLockFiles): Deleted.
142         (getNextAvailableLockNumber): Deleted.
143         (getLockNumberForCurrentRunning): Deleted.
144         (waitForHTTPDLock): Deleted.
145         (scheduleHttpTesting): Deleted.
146         (getWaitTime): Deleted.
147
148 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
149
150         [EFL] The option value of fixed layout is false in MiniBrowser
151         https://bugs.webkit.org/show_bug.cgi?id=138830
152
153         Reviewed by Gyuyoung Kim.
154
155         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
156
157         * MiniBrowser/efl/main.c:
158
159 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
160
161         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
162         https://bugs.webkit.org/show_bug.cgi?id=138871
163
164         Reviewed by Carlos Garcia Campos.
165
166         Add a test case for the convenience API for posting user messages
167         added to the DOM bindings.
168
169         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
170         (testUserContentManagerMessageFromConvenienceDOMBindings):
171         (beforeAll):
172         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
173         (documentLoadedCallback):
174
175 2014-11-19  Dana Burkart  <dburkart@apple.com>
176
177         Work around the fact that different masters may have different names for their codebases.
178         https://bugs.webkit.org/show_bug.cgi?id=138878
179
180         Reviewed by Mark Rowe.
181
182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
183         (parseRevisionProperty): Changed.
184         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
185         opensource / internal codebase naming convention.
186
187 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
188
189         AX: Screen braille input doesn't work on forms.
190         https://bugs.webkit.org/show_bug.cgi?id=138804
191
192         Unreviewed build fix.
193
194         * DumpRenderTree/AccessibilityUIElement.cpp:
195         (AccessibilityUIElement::setValue):
196
197 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
198
199         AX: Screen braille input doesn't work on forms.
200         https://bugs.webkit.org/show_bug.cgi?id=138804
201
202         Reviewed by Mario Sanchez Prada.
203
204         Add a method to setValue through the AX API in DRT.
205
206         * DumpRenderTree/AccessibilityUIElement.cpp:
207         (setValueCallback):
208         (AccessibilityUIElement::getJSClass):
209         * DumpRenderTree/AccessibilityUIElement.h:
210         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
211         (AccessibilityUIElement::setValue):
212         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
213         (AccessibilityUIElement::setValue):
214
215 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
216
217         Remove the WinCairo buildbot
218         https://bugs.webkit.org/show_bug.cgi?id=138805
219
220         Reviewed by Alex Christensen.
221
222         * BuildSlaveSupport/build.webkit.org-config/config.json:
223         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
224         (appendCustomBuildFlags):
225         * BuildSlaveSupport/test-result-archive:
226         (archiveTestResults):
227
228 2014-11-18  Daniel Bates  <dabates@apple.com>
229
230         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
231         SPI are not available in public SDK
232         https://bugs.webkit.org/show_bug.cgi?id=138802
233
234         Reviewed by David Kilzer.
235
236         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
237
238         * DumpRenderTree/mac/CheckedMalloc.cpp:
239
240 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
241
242         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
243
244         Forgot to fix this test before landing.
245
246         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
247         (testWebViewDefaultContext):
248
249 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
250
251         [GTK] Add API to create a WebKitWebContext
252         https://bugs.webkit.org/show_bug.cgi?id=138826
253
254         Reviewed by Gustavo Noronha Silva.
255
256         Use a different WebKitWebContext for every test to ensure test
257         cases are independent to each other. Tests using DBus to
258         communicate with the injected bundle extension now use a unique
259         name for the well known DBus name.
260
261         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
262         (beforeAll): Remove comment about the order of the tests and
263         move the success test before the failed one now that tests don't
264         depend on each others.
265         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
266         (beforeAll): Remove call to set the web extensions directory,
267         since this is now done for all test in the Test constructor.
268         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
269         (beforeAll): Do not create a temporary directory, a temporary data
270         directory is now created for all tests.
271         (afterAll):
272         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
273         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
274         to the web process test runner.
275         (testWebKitDOMNodeInsertion): Ditto.
276         (testWebKitDOMNodeTagNames): Ditto.
277         (beforeAll): Remove call to set the web extensions directory.
278         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
279         (runTest): Pass the web extension ID to the web process test runner.
280         (beforeAll): Remove call to set the web extensions directory.
281         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
282         (runTest): Pass the web extension ID to the web process test runner.
283         (beforeAll): Remove call to set the web extensions directory.
284         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
285         (createFileAtDestination): Use Test::dataDirectory() as base dir
286         for temporary files.
287         (beforeAll): Do not create a temporary directory.
288         (afterAll):
289         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
290         (webkitFrameTestRun): Pass the web extension ID to the web process
291         test runner.
292         (beforeAll): Remove call to set the web extensions directory.
293         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
294         (beforeAll): Remove call to set the web extensions directory.
295         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
296         (testProcessPerWebView): Use local member instead of global variable.
297         (testMultiprocessWebViewCreateReadyClose): Ditto.
298         (beforeAll): Do not connect to initialize-web-extensions, Test now
299         connects to the signal for all tests and calls a virtual method
300         that test can override.
301         (afterAll):
302         (initializeWebExtensions): Deleted.
303         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
304         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
305         for temporary files.
306         (beforeAll): Do not create a temporary directory.
307         (afterAll):
308         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
309         (beforeAll): Remove call to set the web extensions directory.
310         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
311         (beforeAll): Remove comment about the tests order.
312         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
313         (testWebExtensionGetTitle): Build the DBus service name using the
314         web extension ID.
315         (testDocumentLoadedSignal): Ditto.
316         (testWebKitWebViewProcessCrashed): Ditto.
317         (testWebExtensionIsolatedWorld): Ditto.
318         (beforeAll): Remove initialization-user-data test, since now all
319         tests are passing user data to the web extension.
320         (testWebExtensionInitializationUserData): Deleted.
321         (initializeWebExtensions): Deleted.
322         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
323         (testSetDirectory): Use the web context member inherited from Test.
324         (testClearDatabase): Ditto.
325         (testGetFaviconURI): Ditto.
326         (beforeAll): Do not create a temporary directory.
327         (afterAll):
328         (webkitFaviconDatabaseFinalizedCallback): Deleted.
329         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
330         (UserContentManagerTest::UserContentManagerTest):
331         (beforeAll): Remove call to set the web extensions directory.
332         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
333         (testWebContextDefault): Check also that a newly create web
334         context is not the default web context.
335         (testWebContextSpellChecker): Use the web context member inherited
336         from Test.
337         (testWebContextLanguages): Ditto.
338         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
339         (methodCallCallback): Remove GetInitializationUserData method.
340         (webkit_web_extension_initialize_with_user_data): Always create
341         the DBus name using the user data provided.
342         (makeBusName): Deleted.
343         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
344         (webkit_web_extension_initialize_with_user_data): Create the DBus
345         name using the user data provided.
346         (webkit_web_extension_initialize): Deleted.
347         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
348         (Test::dataDirectory): Return the temporary data directory.
349         (removeNonEmptyDirectory): Also remove directories recursively.
350         (main): Remove the disk cache directory initialization, since this
351         is now done in the Test constructor.
352         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
353         (Test::initializeWebExtensionsCallback): Call the virtual method
354         initializeWebExtensions()
355         (Test::Test): Create a new WebKitWebContext and initialize it.
356         (Test::~Test): Disconnect initialize-web-extensions signal.
357         (Test::initializeWebExtensions): Set the web extensions directory
358         and user data.
359         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
360         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
361         (WebProcessTestRunner::runTest): Build the DBus proxy using a
362         unique name created with the Test web extension ID.
363         (WebProcessTestRunner::proxy): Deleted.
364         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
365         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
366         (WebViewTest::WebViewTest): Create the web view with the Test web
367         context.
368         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
369         content manager parameter to the constructor.
370
371 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
372
373         [GTK] Mesa build fails over llvm-3.5
374         https://bugs.webkit.org/show_bug.cgi?id=138825
375
376         Reviewed by Gustavo Noronha Silva.
377
378         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
379
380         * gtk/jhbuild.modules:
381         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
382
383 2014-11-17  Daniel Bates  <dabates@apple.com>
384
385         Unreviewed, rolling out r176232.
386
387         Broke the Mac build. Will investigate offline.
388
389         Reverted changeset:
390
391         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
392         MobileGestalt"
393         https://bugs.webkit.org/show_bug.cgi?id=138802
394         http://trac.webkit.org/changeset/176232
395
396 2014-11-17  Daniel Bates  <dabates@apple.com>
397
398         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
399         SPI are not available in public SDK
400         https://bugs.webkit.org/show_bug.cgi?id=138802
401
402         Reviewed by David Kilzer.
403
404         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
405
406         * DumpRenderTree/mac/CheckedMalloc.cpp:
407
408 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
409
410         Having 30+ flaky failures breaks EWS
411         https://bugs.webkit.org/show_bug.cgi?id=138743
412
413         Reviewed by Alexey Proskuryakov.
414
415         Adds tests to ensure that the problem has been solved.
416         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
417         (test_first_failure_limit):
418         (test_first_failure_limit_with_some_tree_redness):
419         (test_second_failure_limit):
420         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
421         (test_first_and_second_failure_limit):
422         (test_first_and_clean_failure_limit):
423         (test_first_second_and_clean_failure_limit):
424         (test_very_red_tree_retry): Deleted.
425         Really this was renamed to test_first_second_and_clean_failure_limit.
426         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
427         Makes the appropriate changes to PatchAnalysisTask to make sure that
428         even when the first test run hits the failure limit, it will still try
429         a second run.
430         (PatchAnalysisTask._results_failed_different_tests):
431         (PatchAnalysisTask._test_patch):
432         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
433
434 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
435
436         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
437         https://bugs.webkit.org/show_bug.cgi?id=136018
438
439         Reviewed by Carlos Garcia Campos.
440
441         It is possible that the order of -L arguments in the output of
442         pkg-config is wrong, which causes the linker to find the wrong
443         version (usually older version) of libraries when running
444         gtkdoc-scangobj.
445
446         * gtk/gtkdoc.py:
447         (GTKDoc._run_gtkdoc_scangobj):
448
449 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
450
451         Bump EFL version to 1.12.0
452         https://bugs.webkit.org/show_bug.cgi?id=138733
453
454         Reviewed by Gyuyoung Kim.
455
456         * efl/jhbuild.modules:
457
458 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
459
460         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
461         https://bugs.webkit.org/show_bug.cgi?id=138771
462
463         Reviewed by Chris Fleizach.
464
465         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
466
467         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
468
469 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
470
471         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
472         https://bugs.webkit.org/show_bug.cgi?id=138767
473
474         Reviewed by Chris Fleizach.
475
476         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
477
478         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
479
480 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
481
482         Add shortcut macros to Mac TestExpectations
483         https://bugs.webkit.org/show_bug.cgi?id=138729
484
485         Reviewed by Simon Fraser.
486
487         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
488         Add version macros for current OS versions.
489
490 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
491
492         https://bugs.webkit.org/show_bug.cgi?id=138628
493         A patch that doesn't apply is stuck in commit queue
494
495         Rubber-stamped by David Kilzer.
496
497         This also hopefully fixes other issues:
498         - a patch that has cq+ flag set by a non-committer kills commit queue;
499         - EWS never reports failing tests, and keeps spinning instead.
500
501         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
502         (Bugzilla.set_flag_on_attachment):
503         (Bugzilla.obsolete_attachment):
504         Apply the fix from r174797 to more places.
505
506 2014-11-13  Dan Bernstein  <mitz@apple.com>
507
508         Policy client not called for navigations through the page cache
509         https://bugs.webkit.org/show_bug.cgi?id=138703
510
511         Reviewed by Alexey Proskuryakov.
512
513         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
514         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
515         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
516
517 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
518
519         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
520         https://bugs.webkit.org/show_bug.cgi?id=137867
521
522         Reviewed by Chris Fleizach.
523
524         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
525         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
526         able to test for the presence of ATK_ROLE_INVALID.
527
528         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
529         (WTR::AccessibilityUIElement::role):
530
531 2014-11-13  Juergen Ributzka  <juergen@apple.com>
532
533         Update the "combineModules" script to handel more LLVM metadata.
534         https://bugs.webkit.org/show_bug.cgi?id=138514
535
536         Reviewed by Filip Pizlo.
537
538         * ReducedFTL/combineModules.rb:
539
540 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
541
542         Allow constructing a base PassRef with a derived Ref
543         https://bugs.webkit.org/show_bug.cgi?id=138701
544
545         Reviewed by Andreas Kling
546
547         * TestWebKitAPI/Tests/WTF/Ref.cpp:
548         (TestWebKitAPI::passWithPassRef):
549         (TestWebKitAPI::passWithPassRefPtr):
550         (TestWebKitAPI::TEST):
551
552 2014-11-05  Ada Chan  <adachan@apple.com>
553
554         Implement new plug-in API for muting plug-ins
555         https://bugs.webkit.org/show_bug.cgi?id=138105
556
557         Reviewed by Anders Carlsson.
558
559         Add a new plug-in test for the mute API.
560
561         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
562         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
563         (SetMuted::SetMuted):
564         (SetMuted::isMuted):
565         (SetMuted::cachedIsMuted):
566         (SetMuted::ScriptableObject::hasProperty):
567         (SetMuted::ScriptableObject::getProperty):
568         (SetMuted::ScriptableObject::pluginTest):
569         (SetMuted::NPP_New):
570         (SetMuted::NPP_GetValue):
571         (SetMuted::NPP_SetValue):
572
573 2014-11-12  Philippe Normand  <pnormand@igalia.com>
574
575         Unreviewed, GTK gardening.
576
577         * Scripts/run-gtk-tests:
578         (TestRunner): Skip the UserMediaBasic test because it depends on
579         constraints validation which is going to be fixed in bug #136449.
580
581 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
582
583         [GTK] Expose user script messages to GObject DOM bindings
584         https://bugs.webkit.org/show_bug.cgi?id=138411
585
586         Reviewed by Philippe Normand.
587
588         Add a test case to check that user script messages sent using the
589         DOM bindings API are also received in the UI process.
590
591         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
592         (UserScriptMessageTest::waitUntilMessageReceived):
593         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
594         (testUserContentManagerScriptMessageFromDOMBindings):
595         (beforeAll):
596         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
597         (documentLoadedCallback):
598
599 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
600
601         Unreviewed. Fix GTK+ clean build after r175930.
602
603         Partial rollout of r175930 to not build the new unit test that
604         broke clean builds in GTK+ port.
605
606         * TestWebKitAPI/PlatformGTK.cmake:
607
608 2014-09-01  Philippe Normand  <pnormand@igalia.com>
609
610         [WK2] UserMediaClient support
611         https://bugs.webkit.org/show_bug.cgi?id=123158
612
613         Reviewed by Benjamin Poulain.
614
615         Simple API test for the UserMedia permission request API. The
616         required test infrastructure is also added, inspired by the
617         Geolocation infrastructure.
618
619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
620         Permission request.
621         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
622         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
623         (TestWebKitAPI::TEST):
624         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
625         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
626         helper method to set the permission request result without user interaction.
627         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
628         (WTR::InjectedBundle::setUserMediaPermission):
629         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
630         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
631         (WTR::TestRunner::setUserMediaPermission):
632         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
633         * WebKitTestRunner/TestController.cpp:
634         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
635         request handler.
636         (WTR::TestController::createOtherPage): Enable the new UserMedia
637         permission request handler.
638         (WTR::TestController::createWebViewWithOptions): Ditto.
639         (WTR::TestController::resetPreferencesToConsistentValues): Enable
640         MediaStream support, this is needed for getUserMedia.
641         (WTR::TestController::resetStateToConsistentValues): clear
642         UserMedia permissions list and flags.
643         (WTR::TestController::setUserMediaPermission): Set permission
644         request result and distpatch it.
645         (WTR::TestController::handleUserMediaPermissionRequest): Save
646         request and dispatch it.
647         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
648         Dispatch cached permission requests.
649         * WebKitTestRunner/TestController.h:
650         * WebKitTestRunner/TestInvocation.cpp:
651         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
652
653 2014-11-11  David Kilzer  <ddkilzer@apple.com>
654
655         webkit-patch --suggest-reviewers is broken with newer versions of git
656         <http://webkit.org/b/138627>
657
658         Reviewed by Michael Saboff with feedback from Daniel Bates.
659
660         * Scripts/webkitpy/common/checkout/scm/git.py:
661         (Git._changes_files_for_commit): Strip blank lines instead of
662         assuming there is always a blank line at the beginning of the
663         list.
664
665 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
666
667         DRT and WKTR touch disk cache
668         https://bugs.webkit.org/show_bug.cgi?id=138622
669
670         Reviewed by Geoffrey Garen.
671
672         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
673         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
674         because this function uses the shared cache.
675
676         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
677         Create an empty shared cache to prevent a default one from being created on disk.
678
679 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
680
681         [CSS Grid Layout] Limit the size of explicit/implicit grid
682         https://bugs.webkit.org/show_bug.cgi?id=136217
683
684         Reviewed by Andreas Kling.
685
686         Added a new unit test for the CSS parser. Right now it only checks
687         that we properly clamp the maximum number of tracks on a grid to a
688         maximum of 1 million.
689
690         * TestWebKitAPI/CMakeLists.txt:
691         * TestWebKitAPI/PlatformEfl.cmake:
692         * TestWebKitAPI/PlatformGTK.cmake:
693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
694         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
695         (TestWebKitAPI::computeNumberOfTracks): Helper function.
696         (TestWebKitAPI::TEST): Added a
697         CSSPropertyParserTest.GridTrackLimits test case.
698
699 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
700
701         webkitpy test fix after r175867
702         https://bugs.webkit.org/show_bug.cgi?id=138607
703
704         Reviewed by Philippe Normand.
705
706         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
707         (GDBCrashLogGeneratorTest.test_generate_crash_log):
708
709 2014-11-10  Philippe Normand  <pnormand@igalia.com>
710
711         webkitpy: demangle C++ symbols from crash log stderr
712         https://bugs.webkit.org/show_bug.cgi?id=138565
713
714         Reviewed by Alexey Proskuryakov.
715
716         * Scripts/webkitpy/port/linux_get_crash_log.py:
717         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
718         with c++filt.
719
720 2014-11-10  Philippe Normand  <pnormand@igalia.com>
721
722         [GTK] fix up the GDB backtrace report tool
723         https://bugs.webkit.org/show_bug.cgi?id=138564
724
725         Reviewed by Carlos Garcia Campos.
726
727         * Scripts/webkitpy/port/gtk.py:
728         (GtkPort._get_crash_log): Match the process name reported by the
729         driver with the GTK port WebProcess executable filename.
730         * Scripts/webkitpy/port/linux_get_crash_log.py:
731         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
732         program.
733         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
734         pattern to workaround the 16 characters size limit of %e.
735
736 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
737
738         Unreviewed, moved myself to the list of committers.
739
740         * Scripts/webkitpy/common/config/contributors.json:
741
742 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
743
744         [EFL] Fix the test font path after r175555.
745
746         Reviewed by Csaba Osztrogonác.
747
748         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
749
750 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
751
752         Fix the exception fuzz helper to generate targets in the correct range
753         https://bugs.webkit.org/show_bug.cgi?id=138544
754
755         Reviewed by Filip Pizlo.
756
757         Currently, the script generates exception fuzz targets in the range of
758         0..($checkCount-1). However, target 0 is never hit, while target 1 is
759         always outside of the outermost try block of the tests, which therefore
760         prints unexpected output and results in false failures when fired at.
761         Additionally, target $checkCount is never generated.
762
763         This patch fixes the script to generate targets in the range of
764         2..$checkCount.
765
766         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
767
768 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
769
770         make-passwords-json.py should generarate everything needed for testing
771         https://bugs.webkit.org/show_bug.cgi?id=138503
772
773         Reviewed by Ryosuke Niwa.
774
775         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
776         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
777         Additionally generate auth.json, credentials.cfg and committers.cfg too.
778         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
779         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
780         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
781         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
782
783 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
784
785         [GTK] generate-gtkdoc should ignore invalid files
786         https://bugs.webkit.org/show_bug.cgi?id=138542
787
788         Reviewed by Darin Adler.
789
790         * gtk/generate-gtkdoc:
791         (files_to_ignore.file_should_be_ignored): Return True to ignore
792         invalid files.
793
794 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
795
796         Delete cookies between tests
797         https://bugs.webkit.org/show_bug.cgi?id=138528
798
799         Reviewed by Sam Weinig.
800
801         * DumpRenderTree/mac/DumpRenderTree.mm:
802         (resetWebPreferencesToConsistentValues):
803         * WebKitTestRunner/TestController.cpp:
804         (WTR::TestController::resetPreferencesToConsistentValues):
805         Do it.
806
807         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
808         (WTR::InjectedBundle::beginTesting):
809         Added a FIXME.
810
811 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
812
813         [GTK] Run layout tests using the network process
814         https://bugs.webkit.org/show_bug.cgi?id=138428
815
816         Reviewed by Martin Robinson.
817
818         Shared secondary process is the default in the GTK+ port, but we
819         should run the tests using the network process to ensure
820         everything works with the network process. In the future, the
821         shared secondary process model might be a special case of multiple
822         processes with 1 as maximum number of processes, but always using
823         the network process.
824
825         * WebKitTestRunner/TestController.cpp:
826         (WTR::TestController::initialize):
827
828 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
829
830         [GTK] Allow to create a view with a related page in WTR
831         https://bugs.webkit.org/show_bug.cgi?id=138501
832
833         Reviewed by Martin Robinson.
834
835         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
836         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
837         related page to WKViewCreate.
838         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
839         (WTR::PlatformWebView::PlatformWebView): Pass the given related
840         page to WKViewCreate.
841
842 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
843
844         WTR crashes after running a test when NetworkProcess enabled
845         https://bugs.webkit.org/show_bug.cgi?id=138500
846
847         Reviewed by Alexey Proskuryakov.
848
849         WebNotificationProvider destructor is calling
850         WKNotificationManagerSetProvider, but m_notificationManager is
851         null because removeNotificationManager was already called.
852
853         * WebKitTestRunner/WebNotificationProvider.cpp:
854         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
855         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
856
857 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
858
859         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
860         regarding incorrect call to PatchAnalysisTask.report_failure
861         https://bugs.webkit.org/show_bug.cgi?id=138229
862
863         Reviewed by Daniel Bates.
864
865         * Scripts/webkitpy/common/net/layouttestresults.py:
866         Makes sure test_results returns a list.
867         (LayoutTestResults.test_results):
868         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
869         Makes unit tests also check to make sure
870         task.results_from_patch_test_run() and
871         task.results_from_test_run_without_patch return instances of
872         LayoutTestResults.
873         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
874         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
875         Condenses duplicate code into _should_defer_patch_or_throw, and
876         removes the now-unused _clean_tree_results member.
877         (PatchAnalysisTask.__init__):
878         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
879         (PatchAnalysisTask._should_defer_patch_or_throw):
880         (PatchAnalysisTask._test_patch):
881         (PatchAnalysisTask.results_from_patch_test_run):
882         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
883         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
884         Removes needless call to results_from_test_run_without_patch
885         (AbstractEarlyWarningSystem._failing_tests_message):
886         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
887         Changes order of test failure messages to be in the order that they
888         appear.
889         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
890         * Scripts/webkitpy/tool/commands/queues.py:
891         Removes needless call to results_from_test_run_without_patch.
892         (CommitQueue._failing_tests_message):
893         * Scripts/webkitpy/tool/commands/queues_unittest.py:
894         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
895
896 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
897
898         Unreviewed. Reorder my e-mail addresses in contributors.json
899
900         * Scripts/webkitpy/common/config/contributors.json:
901
902 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
903
904         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
905         https://bugs.webkit.org/show_bug.cgi?id=138475
906
907         Reviewed by Ryosuke Niwa.
908
909         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
910         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
911         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
912         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
913
914         * Scripts/webkitpy/common/checkout/scm/git.py:
915         (Git._run_git_svn_find_rev):
916         Add comment mentioning that svn_revisions need to begin with 'r'.
917         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
918         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
919         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
920
921 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
922
923         [GTK] Add context menu API to Web Process Extensions
924         https://bugs.webkit.org/show_bug.cgi?id=138311
925
926         Reviewed by Gustavo Noronha Silva.
927
928         Add tests cases for WebKitWebPage::context-menu signal.
929
930         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
931         (testContextMenuWebExtensionMenu):
932         (testContextMenuWebExtensionNode):
933         (beforeAll):
934         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
935         (serializeContextMenu):
936         (serializeNode):
937         (contextMenuCallback):
938         (pageCreatedCallback):
939
940 2014-11-06  Commit Queue  <commit-queue@webkit.org>
941
942         Unreviewed, rolling out r175690.
943         https://bugs.webkit.org/show_bug.cgi?id=138460
944
945         We are not ready to run layout tests using the network process
946         yet (Requested by KaL on #webkit).
947
948         Reverted changeset:
949
950         "[GTK] Run layout tests using the network process"
951         https://bugs.webkit.org/show_bug.cgi?id=138428
952         http://trac.webkit.org/changeset/175690
953
954 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
955
956         [GTK] Run layout tests using the network process
957         https://bugs.webkit.org/show_bug.cgi?id=138428
958
959         Reviewed by Martin Robinson.
960
961         Shared secondary process is the default in the GTK+ port, but we
962         should run the tests using the network process to ensure
963         everything works with the network process. In the future, the
964         shared secondary process model might be a special case of multiple
965         processes with 1 as maximum number of processes, but always using
966         the network process.
967
968         * WebKitTestRunner/TestController.cpp:
969         (WTR::TestController::initialize):
970
971 2014-11-05  Dan Bernstein  <mitz@apple.com>
972
973         Remove the unused deletion UI feature
974         https://bugs.webkit.org/show_bug.cgi?id=138442
975
976         Rubber-stamped by Alexey Proskuryakov.
977
978         * DumpRenderTree/mac/EditingDelegate.mm:
979         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
980         delegate method that’s been removed.
981
982 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
983
984         fast/dom/remove-body-during-body-replacement2.html fails on WK2
985         https://bugs.webkit.org/show_bug.cgi?id=138334
986
987         Reviewed by Anders Carlsson.
988
989         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
990         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
991         -makeFirstResponder calls, which may or may not be needed for other reasons, but
992         it also needs to reset internal focus explicitly.
993
994         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
995         WebKit behavior appears wrong, but it matches Firefox.
996
997         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
998         (WTR::InjectedBundlePage::resetAfterTest):
999
1000 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1001
1002         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1003         https://bugs.webkit.org/show_bug.cgi?id=137862
1004
1005         Reviewed by Gustavo Noronha Silva.
1006
1007         Add a test case to check that WebKitWebResource::failed-with-tls-errors
1008         is emitted when a subresource load fails due to TLS errors.
1009
1010         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1011         (TLSSubresourceTest::resourceLoadStartedCallback):
1012         (TLSSubresourceTest::TLSSubresourceTest):
1013         (TLSSubresourceTest::subresourceFailedCallback):
1014         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1015         (TLSSubresourceTest::subresourceLoadStarted):
1016         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1017         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1018         (testSubresourceLoadFailedWithTLSErrors):
1019         (httpsServerCallback):
1020         (httpServerCallback):
1021         (beforeAll):
1022
1023 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1024
1025         Build fix for some compiler versions.
1026
1027         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1028         unhappy because this is a getter, and these shouldn't have side effects.
1029
1030 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1031
1032         Add a method for performing cherrypick-merges.
1033         https://bugs.webkit.org/show_bug.cgi?id=138375
1034
1035         Reviewed by Ryosuke Niwa.
1036
1037         Adds support for cherrypick-merges.
1038
1039         * Scripts/webkitpy/common/checkout/scm/git.py:
1040         (Git.cherrypick_merge): Added.
1041
1042 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1043
1044         Add a way to ascertain the SVN URL associated with a Git branch.
1045         https://bugs.webkit.org/show_bug.cgi?id=138374
1046
1047         Reviewed by Ryosuke Niwa.
1048
1049         The svn_url method returns the SVN URL associated with the current Git branch.
1050
1051         * Scripts/webkitpy/common/checkout/scm/git.py:
1052         (Git.svn_url): Added.
1053
1054 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1055
1056         Add the ability to search for modifications that are staged for commit.
1057         https://bugs.webkit.org/show_bug.cgi?id=138373
1058
1059         Reviewed by Ryosuke Niwa and Daniel Bates.
1060
1061         This makes is easy to do identify files that require merge post-processing,
1062         in addition to stand-alone utility.
1063
1064         * Scripts/webkitpy/common/checkout/scm/git.py:
1065         (Git.modifications_staged_for_commit): Added.
1066
1067 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1068
1069         Add a branch keyword argument to _run_git_svn_find_rev.
1070         https://bugs.webkit.org/show_bug.cgi?id=138372
1071
1072         Reviewed by Ryosuke Niwa.
1073
1074         The addition of this keyword argument allows clients to determine the Git hash
1075         of commits made on an SVN branch, provided that branch has been fetched locally.
1076
1077         * Scripts/webkitpy/common/checkout/scm/git.py:
1078         (Git._run_git_svn_find_rev):
1079         Add a branch keyword argument that is added to the end of the command, if present.
1080
1081 2014-11-04  Chris Dumez  <cdumez@apple.com>
1082
1083         Add ptr() method to Ref class
1084         https://bugs.webkit.org/show_bug.cgi?id=138361
1085
1086         Reviewed by Darin Adler.
1087
1088         Use the new Ref::ptr() method.
1089
1090         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1091         (TestWebKitAPI::TEST):
1092
1093 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1094
1095         [jhbuild] Make it possible to build GTK/EFL in same repository
1096         https://bugs.webkit.org/show_bug.cgi?id=137448
1097
1098         Reviewed by Martin Robinson.
1099
1100         * Scripts/webkitdirs.pm:
1101         (getJhbuildPath):
1102         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
1103         (getPlatformFontsPath):
1104         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1105         (WTR::getFontsPath):
1106         * jhbuild/jhbuild-wrapper:
1107         (determine_platform):
1108         (install_jhbuild):
1109         * jhbuild/jhbuildrc_common.py:
1110         (init):
1111
1112 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1113
1114         [EFL] Bump LLVM to version 3.5.0
1115         https://bugs.webkit.org/show_bug.cgi?id=138312
1116
1117         Reviewed by Csaba Osztrogonác.
1118
1119         * efl/jhbuild.modules:
1120         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
1121         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
1122
1123 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
1124
1125         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
1126         https://bugs.webkit.org/show_bug.cgi?id=138257
1127
1128         Reviewed by Tim Horton.
1129         
1130         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
1131         the user to toggle region page overlays on and off. Two overlays are available,
1132         for the non-fast scrollable region, and the region of element with wheel
1133         event handlers.
1134
1135         * MiniBrowser/mac/SettingsController.h:
1136         * MiniBrowser/mac/SettingsController.m:
1137         (-[SettingsController _populateMenu]):
1138         (-[SettingsController validateMenuItem:]):
1139         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
1140         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
1141         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
1142         (-[SettingsController toggleDebugOverlay:]):
1143         (-[SettingsController debugOverlayVisible:]):
1144         * MiniBrowser/mac/WK2BrowserWindowController.m:
1145         (-[WK2BrowserWindowController didChangeSettings]):
1146
1147 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
1148
1149         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
1150         https://bugs.webkit.org/show_bug.cgi?id=138323
1151
1152         Reviewed by Zalan Bujtas.
1153
1154         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
1155
1156 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1157
1158         [ninja] Don't remove response files for verbose builds
1159         https://bugs.webkit.org/show_bug.cgi?id=137816
1160
1161         Reviewed by Csaba Osztrogonác.
1162
1163         * Scripts/webkitdirs.pm:
1164         (determineNinjaVersion):
1165         (buildCMakeGeneratedProject):
1166
1167 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
1168
1169         [GTK] Fix the build of FTL JIT
1170         https://bugs.webkit.org/show_bug.cgi?id=138298
1171
1172         Reviewed by Carlos Garcia Campos.
1173
1174         * gtk/jhbuild-optional.modules:
1175         Bump up LLVM version to 3.5.0 release and apply patches.
1176         * gtk/patches/llvm-elf-add-stackmaps.patch:
1177         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
1178         trunk.
1179         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
1180         Added. Ensures that PC-relative relocations in EH frames are not
1181         truncated to 32 bits on x86_64.
1182
1183 2014-10-31  Michael Saboff  <msaboff@apple.com>
1184
1185         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
1186         https://bugs.webkit.org/show_bug.cgi?id=138268
1187
1188         Reviewed by Andreas Kling.
1189
1190         Added a --arch and --os option to set or override the values that are
1191         normally computed based on examining the JavaScriptCore we want to test.
1192
1193         * Scripts/run-jsc-stress-tests:
1194
1195 2014-10-31  Dan Bernstein  <mitz@apple.com>
1196
1197         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
1198         https://bugs.webkit.org/show_bug.cgi?id=138259
1199
1200         Reviewed by Geoff Garen.
1201
1202         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
1203         going to be empty to silence the warning.
1204
1205 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
1206
1207         [GTK] Support script message handlers WebKitUserContentManager
1208         https://bugs.webkit.org/show_bug.cgi?id=133730
1209
1210         Reviewed by Carlos Garcia Campos.
1211
1212         Support user script message handlers in WebKitUserContentManager.
1213         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
1214         an option is added to the CMake build files. The option is disabled
1215         globally by default, and the WebKitGTK port enables it. On the API
1216         level, two new methods to register and unregister names are provided
1217         in the "window.webkit" namespace, and on message reception the
1218         "WebKitUserContentManager::script-message-received" signal is
1219         emitted, using the registered names as signal detail.
1220
1221         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1222         Add test case for user script message handlers.
1223         (scriptMessageReceived):
1224         (testUserContentManagerScriptMessageReceived):
1225         (beforeAll):
1226
1227 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1228
1229         bisect-builds should support WebKit clients other than Safari
1230         https://bugs.webkit.org/show_bug.cgi?id=138225
1231
1232         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
1233
1234         The -a / --application optional argument allows the user to specify which application (or application bundle)
1235         should be run against the WebKit nightly builds.
1236
1237         Reviewed by David Kilzer.
1238
1239         * Scripts/bisect-builds:
1240         Swap out $safariPath for the more general $applicationPath
1241         Leave --safari-path as a commandline option for backwards compatibility
1242         (mountAndRunNightly):
1243         Use File::Spec->cat correctly (one directory per argument)
1244         Use open --wait-apps instead of running the target application directly
1245
1246 2014-10-30  Dana Burkart  <dburkart@apple.com>
1247
1248         <rdar://problem/18821260> Perpare for the mysterious future
1249
1250         Reviewed by Lucas Forschler.
1251
1252         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1253         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1254         * LayoutTestRelay/Configurations/Base.xcconfig:
1255         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1256         * MiniBrowser/Configurations/Base.xcconfig:
1257         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1258         * TestWebKitAPI/Configurations/Base.xcconfig:
1259         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1260         * WebKitLauncher/Configurations/Base.xcconfig:
1261         * WebKitTestRunner/Configurations/Base.xcconfig:
1262         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1263
1264 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1265
1266         Update safariVersion to safariVersionString
1267         https://bugs.webkit.org/show_bug.cgi?id=138193
1268
1269         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
1270         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
1271
1272         Rubber-stamped by David Kilzer.
1273
1274         * Scripts/bisect-builds:
1275         (makeNightlyList):
1276         Compare safariVersionString to a string literal, instead of safariVersion.
1277
1278 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
1279
1280         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
1281         https://bugs.webkit.org/show_bug.cgi?id=137775
1282
1283         Reviewed by Carlos Garcia Campos.
1284
1285         * MiniBrowser/gtk/BrowserWindow.c:
1286         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
1287         (browser_window_init):
1288
1289 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
1290
1291         CommitQueue and EWS should reject any patches that result in consistent test
1292         failures that aren't present on the tree.
1293         https://bugs.webkit.org/show_bug.cgi?id=138184
1294
1295         Reviewed by Alexey Proskuryakov.
1296
1297         * Scripts/webkitpy/layout_tests/models/test_results.py:
1298         Adds a simple hashing function to allow for set operations to handle
1299         TestResult objects properly.
1300         (TestResult.__hash__):
1301         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1302         Adds one unit test, and modifies others to agree with the notion that
1303         patches that introduce new test failures (but also have flakyness)
1304         should be rejected rather than spin.
1305         (MockCommitQueue.report_flaky_tests):
1306         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1307         (test_double_flaky_test_failure):
1308         (test_two_flaky_tests):
1309         (test_very_flaky_patch):
1310         (test_very_flaky_patch_with_some_tree_redness):
1311         (test_different_test_failures):
1312         (test_different_test_failures_with_some_tree_redness):
1313         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
1314         (test_mildly_flaky_patch):
1315         (test_mildly_flaky_patch_with_some_tree_redness):
1316         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1317         Makes PatchAnalysisTask reject said patches.
1318         (PatchAnalysisTask._test_patch):
1319
1320 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1321
1322         WinCairoRequirements.zip cannot be downloaded from dropbox
1323         https://bugs.webkit.org/show_bug.cgi?id=138113
1324
1325         Reviewed by Alexey Proskuryakov.
1326
1327         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
1328
1329 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
1330
1331         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
1332         https://bugs.webkit.org/show_bug.cgi?id=138193
1333
1334         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
1335         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
1336
1337         It also does a bit of refactoring, including distinguishing between versions and version strings and
1338         saving versions to local variables instead of using eval in each conditional.
1339
1340         Reviewed by David Kilzer.
1341
1342         * Scripts/bisect-builds:
1343         (makeNightlyList):
1344         Restrict the set of nightlies to r174650 and above when running Yosemite.
1345         Restrict the set of nightlies to r157846 and above when running Mavericks.
1346         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
1347
1348 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1349
1350         [EFL] build-webkit should try harder to avoid re-running cmake
1351         https://bugs.webkit.org/show_bug.cgi?id=137949
1352
1353         Reviewed by Martin Robinson.
1354
1355         * Scripts/webkitdirs.pm:
1356         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
1357         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
1358
1359 2014-10-28  Daniel Bates  <dabates@apple.com>
1360
1361         Unify logic in RunTests.run() to run the Python unit tests
1362         https://bugs.webkit.org/show_bug.cgi?id=138160
1363
1364         Reviewed by Martin Robinson.
1365
1366         Unify the interactive and non-interactive code path for running the Python unit tests
1367         in step RunTests so as to remove duplicate code to compute the the path to the script
1368         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
1369
1370         No new tests since no functionality was changed.
1371
1372         * Scripts/webkitpy/port/base.py:
1373         (Port.python_unittest_results_directory):
1374         * Scripts/webkitpy/tool/steps/runtests.py:
1375         (RunTests.run):
1376
1377 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
1378
1379         Make runtest.py call test-webkitpy with the --json flag when in
1380         non-interactive mode.
1381         https://bugs.webkit.org/show_bug.cgi?id=137667
1382
1383         Reviewed by Daniel Bates.
1384
1385         * Scripts/webkitpy/port/base.py:
1386         Adds the python_unittest_results_directory method.
1387         (Port.python_unittest_results_directory):
1388         * Scripts/webkitpy/tool/steps/runtests.py:
1389         Changes RunTests to call test-webkitpy with the --json flag if the
1390         --non-interactive flag is set.
1391         (RunTests):
1392         (RunTests.run):
1393
1394 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
1395
1396         import-w3c-tests should use re.escape() wherever it's handling file paths
1397         https://bugs.webkit.org/show_bug.cgi?id=137934
1398
1399         This patch adds re.escape() to a few places where we're doing string
1400         conversions. This prevents errors when attribute values coincidentally
1401         have character sequences that can be interpreted as regular expressions.
1402
1403         Reviewed by Bem Jones-Bey.
1404
1405         * Scripts/webkitpy/w3c/test_converter.py:
1406         (_W3CTestConverter.convert_attributes_if_needed):
1407
1408 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1409
1410         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
1411         https://bugs.webkit.org/show_bug.cgi?id=138130
1412
1413         Reviewed by Csaba Osztrogonác.
1414
1415         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1416
1417 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
1418
1419         Fix link to Arch Linux Wiki
1420         https://bugs.webkit.org/show_bug.cgi?id=138010
1421
1422         Reviewed by Benjamin Poulain.
1423
1424         * gtk/install-dependencies:
1425
1426 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
1427
1428         Test regressions are not detected when image result is missing
1429         https://bugs.webkit.org/show_bug.cgi?id=138070
1430
1431         Reviewed by Simon Fraser.
1432
1433         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1434         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1435         Count these as regressions, not as flaky tests.
1436
1437         * Scripts/webkitpy/port/test.py:
1438         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1439         Test it.
1440
1441 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
1442
1443         Add Conrad Shultz to the contributors list.
1444
1445         * Scripts/webkitpy/common/config/contributors.json:
1446
1447 2014-10-24  Dan Bernstein  <mitz@apple.com>
1448
1449         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
1450         https://bugs.webkit.org/show_bug.cgi?id=138046
1451
1452         Reviewed by Alexey Proskuryakov.
1453
1454         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1455         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
1456         401. Otherwise, we’ll retry normally in 45 seconds.
1457
1458 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1459
1460         [GTK] Implement is_selected method on WebKitHitTestResult
1461         https://bugs.webkit.org/show_bug.cgi?id=137110
1462
1463         Reviewed by Tim Horton.
1464
1465         Add tests for new context SELECTION on WebKitHitTestResult.
1466
1467         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1468         (testContextMenuDefaultMenu):
1469         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1470         (testWebViewMouseTarget):
1471
1472 2014-10-23  Roger Fong  <roger_fong@apple.com>
1473
1474         [Win] Skip failing JSC tests following r175078
1475         https://bugs.webkit.org/show_bug.cgi?id=130967.
1476
1477         * Scripts/run-javascriptcore-tests:
1478
1479 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1480
1481         commitqueuetask_unittest.py should be made more concise.
1482         https://bugs.webkit.org/show_bug.cgi?id=137985
1483
1484         Reviewed by Alexey Proskuryakov.
1485
1486         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1487         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
1488         (MockCommitQueue.__init__):
1489         (MockCommitQueue.report_flaky_tests):
1490         (MockCommitQueue):
1491         (MockCommitQueue.get_reported_flaky_tests):
1492         (MockSimpleTestPlanCommitQueue.__init__):
1493         (MockSimpleTestPlanCommitQueue.run_command):
1494         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
1495         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1496         (test_land_failure):
1497         (test_failed_archive):
1498         (test_double_flaky_test_failure):
1499         (test_test_failure):
1500         (test_red_test_failure):
1501         (test_very_red_tree_retry):
1502         (test_red_tree_patch_rejection):
1503         (test_one_flaky_test):
1504         (test_tree_more_red_than_patch):
1505         (MockCommitQueue.test_results): Deleted.
1506         (test_simple_flaky_test_failure): Deleted.
1507         (_expect_validate): Deleted.
1508         (_expect_validate.MockDelegate): Deleted.
1509         (_expect_validate.MockDelegate.refetch_patch): Deleted.
1510         (_expect_validate.MockDelegate.expected_failures): Deleted.
1511         (_mock_patch): Deleted.
1512         (test_validate): Deleted.
1513         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1514         Fixes a bug that slipped through the cracks prior to this change.
1515         (PatchAnalysisTask._test_patch):
1516
1517 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
1518
1519         Flakiness dashboard should support OS X Yosemite
1520         https://bugs.webkit.org/show_bug.cgi?id=137986
1521
1522         Reviewed by Ryosuke Niwa.
1523
1524         * TestResultServer/app.yaml:
1525         * TestResultServer/static-dashboards/builders.jsonp:
1526         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1527
1528 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1529
1530         commitqueuetask should include more tests to ensure that the behavior
1531         of PatchAnalysisTask._test_patch() is well defined
1532         https://bugs.webkit.org/show_bug.cgi?id=137977
1533
1534         Reviewed by Alexey Proskuryakov.
1535
1536         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1537         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
1538         and more readable to define tests that are meant to test the behaviour
1539         of PatchAnalysisTask._test_patch(), and adds several unit tests.
1540         (FailingTestCommitQueue.test_results):
1541         (PatchAnalysisResult):
1542         (MockSimpleTestPlanCommitQueue):
1543         (MockSimpleTestPlanCommitQueue.__init__):
1544         (MockSimpleTestPlanCommitQueue.run_command):
1545         (MockSimpleTestPlanCommitQueue._mock_test_result):
1546         (MockSimpleTestPlanCommitQueue.test_results):
1547         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1548         (test_flaky_test_failure):
1549         (test_failed_archive):
1550         (test_two_flaky_tests):
1551         (test_one_flaky_test):
1552         (test_very_flaky_patch):
1553         (test_very_flaky_patch_with_some_tree_redness):
1554         (test_different_test_failures):
1555         (test_different_test_failures_with_some_tree_redness):
1556         (test_mildly_flaky_patch):
1557         (test_mildly_flaky_patch_with_some_tree_redness):
1558         (test_tree_more_red_than_patch):
1559
1560 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1561
1562         PatchAnalysisTask._test_patch() needs refactoring
1563         https://bugs.webkit.org/show_bug.cgi?id=137904
1564
1565         Reviewed by Alexey Proskuryakov.
1566
1567         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1568         Fixes several small bugs, and makes minor changes to accomodate the
1569         changes in PatchAnalysisTask.
1570         (MockCommitQueue.refetch_patch):
1571         (MockCommitQueue.test_results):
1572         (test_flaky_test_failure):
1573         (test_failed_archive):
1574         (test_very_red_tree_retry):
1575         (_expect_validate.MockDelegate.refetch_patch):
1576         (MockCommitQueue.expected_failures): Deleted.
1577         (_expect_validate.MockDelegate.expected_failures): Deleted.
1578         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
1579         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
1580         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1581         Removes the unexpected_failures member, adds the _clean_tree_results
1582         member, adds a helper function for _test_patch, and refactors
1583         _test_patch to be more readable.
1584         (PatchAnalysisTask.__init__):
1585         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1586         (PatchAnalysisTask._test_patch):
1587         (PatchAnalysisTask.results_from_test_run_without_patch):
1588         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1589         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
1590         (AbstractEarlyWarningSystem.begin_work_queue):
1591         (AbstractEarlyWarningSystem._failing_tests_message):
1592         (AbstractEarlyWarningSystem.command_failed):
1593         (AbstractEarlyWarningSystem.expected_failures): Deleted.
1594         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1595         Makes changes to accomodate the changes made to PatchAnalysisTask.
1596         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1597         * Scripts/webkitpy/tool/commands/perfalizer.py:
1598         Removes Perfalizer's dependancy on ExpectedFailures. 
1599         (PerfalizerTask.refetch_patch):
1600         (PerfalizerTask.expected_failures): Deleted.
1601         * Scripts/webkitpy/tool/commands/queues.py:
1602         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
1603         initializer to allow for mock injection.
1604         (CommitQueue.__init__):
1605         (CommitQueue.begin_work_queue):
1606         (CommitQueue.process_work_item):
1607         (CommitQueue._failing_tests_message):
1608         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1609         Removes dependancy on ExpectedFailures, and instead uses mock
1610         injection.
1611         (MockCommitQueueTask):
1612         (MockCommitQueueTask.results_from_patch_test_run):
1613         (MockCommitQueueTask.results_from_test_run_without_patch):
1614         (mock_run_webkit_patch):
1615
1616 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
1617
1618         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
1619         https://bugs.webkit.org/show_bug.cgi?id=136736
1620
1621         Reviewed by Gyuyoung Kim.
1622
1623         * MiniBrowser/efl/main.c:
1624         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
1625         (window_create):
1626
1627 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1628
1629         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
1630         https://bugs.webkit.org/show_bug.cgi?id=137884
1631
1632         Reviewed by Gustavo Noronha Silva.
1633
1634         Move InputMethodFilter test from WebCore tests to WebKit2 tests
1635         and adapt it to use the new InputMethodFilter WebKit class. Instead
1636         of having virtual methods just for testing, it has a testing mode
1637         that logs the events.
1638
1639         * TestWebKitAPI/PlatformGTK.cmake:
1640         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
1641         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
1642         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
1643         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
1644         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
1645         (TestWebKitAPI::TEST):
1646         (TestWebKitAPI::temporaryGetPreeditStringOverride):
1647         (TestWebKitAPI::temporaryResetOverride):
1648         (TestWebKitAPI::verifyCanceledComposition):
1649
1650 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
1651
1652         build.webkit.org/dashboard: Cannot click on green tester bubbles
1653         https://bugs.webkit.org/show_bug.cgi?id=137909
1654
1655         Reviewed by Darin Adler.
1656
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1658         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1659
1660 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
1661
1662         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
1663         https://bugs.webkit.org/show_bug.cgi?id=137932
1664
1665         Reviewed by Simon Fraser.
1666
1667         This is the first step in moving over to native Windows rendering for our layout tests.
1668         Once this change lands, approximately 300 tests will start failing on Windows. I will
1669         rebaseline these changes against our test hardware and update this bug with the
1670         commits related to that work.
1671
1672         * DumpRenderTree/win/DumpRenderTree.cpp:
1673         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
1674         we use native Windows drawing style.
1675
1676 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1677
1678         Fix FTL Native Inlining for EFL
1679         https://bugs.webkit.org/show_bug.cgi?id=137774
1680
1681         Reviewed by Michael Saboff.
1682
1683         Added Clang as an optional module to jhbuild.
1684
1685         * efl/jhbuild.modules:
1686
1687 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1688
1689         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
1690         https://bugs.webkit.org/show_bug.cgi?id=137832
1691
1692         Reviewed by Carlos Garcia Campos.
1693
1694         Ensure each test sets the TLS errors policy that it really needs.
1695         Have each test except testTLSErrorsPolicy stash and restore the original
1696         TLS errors policy. Update testTLSErrorsPolicy to account for the new
1697         default policy.
1698
1699         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1700         (testSSL):
1701         (testInsecureContent):
1702         (testTLSErrorsPolicy):
1703         (testTLSErrorsRedirect):
1704         (testTLSErrorsHTTPAuth):
1705         (testLoadFailedWithTLSErrors):
1706         (beforeAll):
1707
1708 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1709
1710         Unreviewed. Unskip inspector server unit tests.
1711
1712         They should pass now.
1713
1714         * Scripts/run-gtk-tests:
1715         (TestRunner):
1716
1717 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1718
1719         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
1720         https://bugs.webkit.org/show_bug.cgi?id=132044
1721
1722         Reviewed by Brian Burg.
1723
1724         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1725         (openRemoteDebuggingSession): Remove trailing slash when
1726         concatenating base inspector URL with the page, because the
1727         inspector returns the relative paths with a leading slash.
1728
1729 2014-10-20  Tanay C  <tanay.c@samsung.com>
1730
1731         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
1732         https://bugs.webkit.org/show_bug.cgi?id=137023
1733
1734         Reviewed by Gyuyoung Kim.
1735
1736         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
1737         (search_box_show): Modified.
1738         (search_box_hide): Modified.
1739         (on_search_field_activated): Modified.
1740         (on_search_backward_button_clicked): Modified.
1741         (on_search_forward_button_clicked): Modified.
1742         (on_search_case_option_changed): Added.
1743         (on_search_word_start_option_changed): Added.
1744         (window_create): Modified.
1745
1746 2014-10-20  Tanay C  <tanay.c@samsung.com>
1747
1748         [GTK][Minibrowser] Escape key does not hide the search box
1749         https://bugs.webkit.org/show_bug.cgi?id=137734
1750
1751         Reviewed by Philippe Normand.
1752
1753         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
1754         (stopPageLoad): Modified.
1755
1756 2014-10-18  Antti Koivisto  <antti@apple.com>
1757
1758         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
1759         https://bugs.webkit.org/show_bug.cgi?id=137855
1760
1761         Reviewed by Dan Bernstein.
1762
1763         Test and warn if the dumped response mime type differs from the platform response mime type.
1764
1765         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1766         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1767         (WTR::InjectedBundlePage::platformResponseMimeType):
1768         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1769         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1770         (WTR::InjectedBundlePage::platformResponseMimeType):
1771
1772 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
1773
1774         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
1775         https://bugs.webkit.org/show_bug.cgi?id=137835
1776
1777         Reviewed by Andreas Kling.
1778
1779         * Scripts/run-inspector-perf-tests.py: Removed.
1780         This script is stale, as PerformanceTests/inspector no longer exists.
1781
1782 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1783
1784         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
1785
1786         * Scripts/webkitpy/port/ios.py:
1787         (IOSSimulatorPort.default_baseline_search_path):
1788
1789 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1790
1791         [iOS] Simplify test fallback paths for iOS Simulator testing
1792         https://bugs.webkit.org/show_bug.cgi?id=137830
1793
1794         Reviewed by Zalan Bujtas.
1795         
1796         Make the fallback paths be:
1797             ios-simulator -> generic
1798             ios-simulator-wk2->ios-simulator -> generic
1799         
1800         so don't include mac in the fallback path. Also remove the
1801         version handling for simplicity.
1802
1803         * Scripts/webkitpy/port/ios.py:
1804         (IOSSimulatorPort):
1805         (IOSSimulatorPort.default_baseline_search_path):
1806
1807 2014-10-17  Dana Burkart  <dburkart@apple.com>
1808
1809         Fix typos in the dashboard config file.
1810
1811         Unreviewed.
1812
1813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1814         (WebKitBuildbot):
1815
1816 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
1817
1818         [Win] Allow WinLauncher to specify Custom User Agent strings
1819         https://bugs.webkit.org/show_bug.cgi?id=137828
1820
1821         Reviewed by Dean Jackson.
1822
1823         * WinLauncher/Common.cpp: Add support for custom user agent strings.
1824         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
1825         and set the user agent strings.
1826         * WinLauncher/WinLauncher.h:
1827         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
1828         resources and dialog for setting custom User Agent strings.
1829         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1830
1831 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
1832
1833         [iOS] Turn off font autosizing for iOS WebKitTestRunner
1834         https://bugs.webkit.org/show_bug.cgi?id=137806
1835
1836         Reviewed by Sam Weinig.
1837
1838         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
1839         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
1840         to disable font autosizing.
1841         
1842         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
1843         test controller to set platform-specific prefs.
1844
1845         * WebKitTestRunner/TestController.cpp:
1846         (WTR::TestController::resetPreferencesToConsistentValues):
1847         (WTR::TestController::platformResetPreferencesToConsistentValues):
1848         * WebKitTestRunner/TestController.h:
1849         * WebKitTestRunner/ios/TestControllerIOS.mm:
1850         (WTR::TestController::platformResetPreferencesToConsistentValues):
1851         * WebKitTestRunner/mac/TestControllerMac.mm:
1852         (WTR::TestController::platformResetPreferencesToConsistentValues):
1853
1854 2014-10-16  Dan Bernstein  <mitz@apple.com>
1855
1856         OSObjectPtr is missing leakRef()
1857         https://bugs.webkit.org/show_bug.cgi?id=137798
1858
1859         Reviewed by Sam Weinig.
1860
1861         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1862         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
1863
1864 2014-10-16  Lucas Forschler  <lforschler@apple.com>
1865
1866         Update target platform to remove Leopard, Snow Leopard, Lion.
1867         Add Yosemite. 
1868         
1869         Unreviewed.
1870
1871         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1872         (_should_file_trigger_build):
1873
1874 2014-10-16  David Kilzer  <ddkilzer@apple.com>
1875
1876         commit-queue: fails to replace OO-PS! with reviewer name
1877         <http://webkit.org/b/137795>
1878
1879         Reviewed by Alexey Proskuryakov.
1880
1881         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1882         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
1883         email addresses to unauthenticated page loads, so we must always
1884         authenticate before getting bug data so we get full email
1885         addresses.
1886
1887 2014-10-16  David Kilzer  <ddkilzer@apple.com>
1888
1889         commit-queue: fails to close bugs after successfully landing patches
1890         <http://webkit.org/b/137794>
1891
1892         Reviewed by Alexey Proskuryakov.
1893
1894         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1895         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
1896         tell Mechanize to use the second <textarea> on the page with
1897         name="comment".
1898
1899 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
1900
1901         [Win] Update DRT to match Mac Logic
1902         https://bugs.webkit.org/show_bug.cgi?id=137787
1903
1904         Reviewed by Dean Jackson.
1905
1906         * DumpRenderTree/win/DumpRenderTree.cpp:
1907         (initialize): 0 -> nullptr
1908         (runTest): Initialize MSG structure before using.
1909         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
1910         Also, cleanly shut down COM when exiting.
1911         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1912         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
1913         header and add printf to match Mac.
1914         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
1915         * DumpRenderTree/win/FrameLoadDelegate.h:
1916         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
1917         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
1918         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1919         (isLocalhost): Added.
1920         (hostIsUsedBySomeTestsToGenerateError): Added.
1921         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
1922         of certain error and redirect host names.
1923         * DumpRenderTree/win/UIDelegate.cpp:
1924         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
1925         anything should be output to the console. This modifies behavior to match the Mac.
1926         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1927         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1928         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1929         (UIDelegate::webViewAddMessageToConsole): Ditto.
1930         * WinLauncher/PageLoadTestClient.cpp:
1931         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
1932         added last week.
1933
1934 2014-10-16  Commit Queue  <commit-queue@webkit.org>
1935
1936         Unreviewed, rolling out r174754.
1937         https://bugs.webkit.org/show_bug.cgi?id=137789
1938
1939         Speculative fix for Windows test was ineffective. (Requested
1940         by rfong on #webkit).
1941
1942         Reverted changeset:
1943
1944         "[Windows] Add some more logging to debug Windows test
1945         issues."
1946         http://trac.webkit.org/changeset/174754
1947
1948 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1949
1950         Unreviewed, add myself to CoordinatedGraphics watchers.
1951
1952         * Scripts/webkitpy/common/config/watchlist:
1953
1954 2014-10-15  Roger Fong  <roger_fong@apple.com>
1955
1956         [Windows] Speculative Windows test fix.
1957
1958         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
1959
1960 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
1961
1962         import-w3c-test rewrites relative src paths in ref files incorrectly
1963         https://bugs.webkit.org/show_bug.cgi?id=137586
1964
1965         This patch fixes a bug in test_converter.py where src paths were getting 
1966         rewritten as ../../some-path instead of <script src="../../some-path>". 
1967         It also adds support for rewriting src paths in style  elements, which was 
1968         missing before and it adds tests for this case.
1969
1970         Reviewed by Bem Jones-Bey.
1971
1972         * Scripts/webkitpy/w3c/test_converter.py:
1973         (_W3CTestConverter.convert_attributes_if_needed):
1974         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1975         (test_convert_attributes_if_needed):
1976         (verify_reference_relative_paths):
1977
1978 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
1979
1980         Add --json flag to test-webkitpy to emit JSON formatted test results
1981         to stdout
1982         https://bugs.webkit.org/show_bug.cgi?id=137353
1983
1984         Reviewed by Daniel Bates.
1985
1986         * Scripts/webkitpy/port/server_process_unittest.py:
1987         Adds the read method to MockFile to allow the stdout of test_webkitpy
1988         to be redirected without causing erroneous test failures.
1989         In particular,
1990         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
1991         and
1992         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
1993         because when redirecting to a file, the
1994         _wait_for_data_and_update_buffers_using_select method in 
1995         server_process.py will find that there is a read file descriptor in
1996         its call to select.select, which eventually leads to it calling read()
1997         on the MockFile object.
1998         (MockFile.read):
1999         * Scripts/webkitpy/test/main.py:
2000         Adds the _print_results_as_json method and the --json flag which
2001         determines whether _print_results_as_json will get called.
2002         (Tester._parse_args):
2003         (Tester._print_results_as_json):
2004         (Tester._print_results_as_json.result_dict_from_tuple):
2005         (Tester._run_tests):
2006
2007 2014-10-13  David Farler  <dfarler@apple.com>
2008
2009         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2010         https://bugs.webkit.org/show_bug.cgi?id=137662
2011
2012         Reviewed by Darin Adler.
2013
2014         The layout test harness can close LayoutTestRelay's subprocess
2015         stdout and stderr in the case of a timeout or if a run is
2016         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2017         finds that no one is listening to its stdout/stderr (broken
2018         pipe), then just exit(1), there is nothing to report.
2019
2020         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2021         (-[LTRelayController didReceiveStdoutData:]):
2022         Add @try/@catch for NSFileHandleOperationException.
2023         (-[LTRelayController didReceiveStderrData:]):
2024         Add @try/@catch for NSFileHandleOperationException.
2025
2026 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
2027
2028         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2029         https://bugs.webkit.org/show_bug.cgi?id=137060
2030
2031         Reviewed by Philippe Normand.
2032
2033         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2034
2035         * MiniBrowser/gtk/BrowserWindow.c:
2036         (zoomInCallback):
2037         (zoomOutCallback):
2038         (defaultZoomCallback): Callback for default zoom keyboard support.
2039         (browser_window_init):
2040
2041 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
2042
2043         [Mac] DRT stderr logging after the test completes gets attributed to the next test
2044
2045         Reviewed by Alexey Proskuryakov.
2046         
2047         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
2048         logging to stderr to get associated with the next test.
2049         
2050         Fix by logging #EOF to stderr later, after we've completely finished with this test.
2051
2052         * DumpRenderTree/mac/DumpRenderTree.mm:
2053         (dumpTestResults):
2054         (runTest):
2055
2056 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
2057
2058         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
2059
2060         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
2061
2062 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2063
2064         [cmake] Fix the make build after r174683
2065         https://bugs.webkit.org/show_bug.cgi?id=137703
2066
2067         Reviewed by Martin Robinson.
2068
2069         * Scripts/webkitdirs.pm:
2070         (buildCMakeGeneratedProject):
2071
2072 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2073
2074         Adding myself to the watchlist to CachedFont
2075
2076         Unreviewed.
2077
2078         * Scripts/webkitpy/common/config/watchlist:
2079
2080 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2081
2082         [EFL][GTK] Make it possible to get verbose output with ninja
2083         https://bugs.webkit.org/show_bug.cgi?id=137606
2084
2085         Reviewed by Csaba Osztrogonác.
2086
2087         * Scripts/webkitdirs.pm:
2088         (buildCMakeGeneratedProject):
2089
2090 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2091
2092         [EFL] Make it possible to use ninja for EFL build too
2093         https://bugs.webkit.org/show_bug.cgi?id=137605
2094
2095         Reviewed by Csaba Osztrogonác.
2096
2097         * Scripts/webkitdirs.pm:
2098         (generateBuildSystemFromCMakeProject):
2099         * efl/install-dependencies:
2100
2101 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
2102
2103         [GTK] Minibrowser : Add home buton and keyboard support for home page load
2104         https://bugs.webkit.org/show_bug.cgi?id=137486
2105
2106         Reviewed by Philippe Normand.
2107
2108         * MiniBrowser/gtk/BrowserWindow.c:
2109         (loadHomePage): Callback for home page load.
2110         (browser_window_init):
2111         * MiniBrowser/gtk/BrowserWindow.h:
2112         * MiniBrowser/gtk/main.c:
2113         (main):
2114
2115 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
2116
2117         import-w3c-tests doesn't prefix property values
2118         https://bugs.webkit.org/show_bug.cgi?id=137600
2119
2120         Reviewed by Bem Jones-Bey.
2121
2122         Some property values are prefixed in WebKit. Modified the W3C import
2123         script in order to prefix property values and not only properties.
2124         The patch re-uses most of the already existent logic to prefix
2125         properties.
2126
2127         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
2128         from CSSValueKeywords.in and adapt converter to modify both properties
2129         and property values.
2130         (convert_for_webkit):
2131         (_W3CTestConverter.__init__):
2132         (_W3CTestConverter.output):
2133         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2134         (_W3CTestConverter):
2135         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
2136         (_W3CTestConverter.add_webkit_prefix_following_regex):
2137         (_W3CTestConverter.convert_reference_relpaths):
2138         (_W3CTestConverter.convert_style_data):
2139         (_W3CTestConverter.convert_attributes_if_needed):
2140         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
2141         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
2142         include checks for property values too.
2143         (W3CTestConverterTest.test_read_prefixed_property_list):
2144         (verify_no_conversion_happened):
2145         (verify_prefixed_properties):
2146         (verify_prefixed_property_values):
2147         (generate_test_content_properties_and_values):
2148         (generate_test_content):
2149         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
2150         prefixed property values and inform about them.
2151         (TestImporter.import_tests):
2152         (TestImporter.write_import_log):
2153
2154 2014-10-13  Jer Noble  <jer.noble@apple.com>
2155
2156         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2157         https://bugs.webkit.org/show_bug.cgi?id=137533
2158
2159         Reviewed by Andy Estes.
2160
2161         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
2162
2163         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2164         (TestWebKitAPI::isMSEEnabledCallback):
2165         (TestWebKitAPI::TEST):
2166
2167 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
2168
2169         [Win] Implement a page load profiling tool
2170         https://bugs.webkit.org/show_bug.cgi?id=137673
2171
2172         Reviewed by Dean Jackson.
2173
2174         Add a tool to capture and summarize page load statistics.
2175
2176         * WinLauncher/Common.cpp:
2177         (parseCommandLine): Move from WinMain.cpp so that it can
2178         be shared with internal tools.
2179         * WinLauncher/PageLoadTestClient.cpp: Added.
2180         (PageLoadTestClient::PageLoadTestClient):
2181         (PageLoadTestClient::pageLoadStartedAtTime):
2182         (PageLoadTestClient::didStartProvisionalLoad):
2183         (PageLoadTestClient::didCommitLoad):
2184         (PageLoadTestClient::didFirstLayoutForMainFrame):
2185         (PageLoadTestClient::didHandleOnLoadEvents):
2186         (PageLoadTestClient::didFinishLoad):
2187         (PageLoadTestClient::didFailLoad):
2188         (PageLoadTestClient::didInitiateResourceLoad):
2189         (PageLoadTestClient::didEndResourceLoad):
2190         (PageLoadTestClient::pageLoadEndedAtTime):
2191         (PageLoadTestClient::endPageLoad):
2192         (PageLoadTestClient::clearPageLoadState):
2193         (PageLoadTestClient::shouldConsiderPageLoadEnded):
2194         (PageLoadTestClient::maybeEndPageLoadSoon):
2195         (PageLoadTestClient::setPageURL):
2196         (PageLoadTestClient::dumpRunStatistics):
2197         * WinLauncher/PrintWebUIDelegate.cpp:
2198         (PrintWebUIDelegate::createWebViewWithRequest): Handle
2199         nullptr URL properly.
2200         * WinLauncher/ResourceLoadDelegate.cpp: Added.
2201         (ResourceLoadDelegate::QueryInterface):
2202         (ResourceLoadDelegate::AddRef):
2203         (ResourceLoadDelegate::Release):
2204         (ResourceLoadDelegate::identifierForInitialRequest):
2205         (ResourceLoadDelegate::willSendRequest):
2206         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2207         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
2208         (ResourceLoadDelegate::didReceiveResponse):
2209         (ResourceLoadDelegate::didReceiveContentLength):
2210         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2211         (ResourceLoadDelegate::didFailLoadingWithError):
2212         (ResourceLoadDelegate::plugInFailedWithError):
2213         * WinLauncher/ResourceLoadDelegate.h: Added.
2214         (ResourceLoadDelegate::ResourceLoadDelegate):
2215         * WinLauncher/WinLauncher.cpp:
2216         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
2217         page loading statistics.
2218         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
2219         and set private load delegate state.
2220         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
2221         that sets the view's resource load delegate.
2222         (WinLauncher::loadURL): If no URL is passed, load the test document.
2223         * WinLauncher/WinLauncher.h:
2224         (WinLauncher::pageLoadTestClient):
2225         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
2226         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
2227         * WinLauncher/WinLauncherWebHost.cpp:
2228         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
2229         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
2230         it could be used from other source files.
2231         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
2232         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
2233         (WinLauncherWebHost::didFailLoadWithError): Ditto.
2234         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
2235         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
2236         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
2237         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2238         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2239         * WinLauncher/WinLauncherWebHost.h:
2240         * WinLauncher/WinMain.cpp:
2241         (wWinMain): Create and use new delegates for gathering page load data.
2242         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
2243
2244 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2245
2246         Improve the test image diffs page
2247         https://bugs.webkit.org/show_bug.cgi?id=137674
2248
2249         Reviewed by Alexey Proskuryakov.
2250         
2251         Don't treat the input file as a format string, otherwise we have to escape special
2252         characters. Just do a couple of replaces.
2253
2254         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2255         (TestResultWriter.write_image_diff_files):
2256
2257 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2258
2259         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
2260         https://bugs.webkit.org/show_bug.cgi?id=137659
2261
2262         Reviewed by Martin Robinson.
2263
2264         * Scripts/webkitpy/port/xvfbdriver.py:
2265         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
2266
2267 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
2268
2269         Add more detailed wait time information to EWS metrics
2270         https://bugs.webkit.org/show_bug.cgi?id=137649
2271
2272         Reviewed by Daniel Bates.
2273
2274         Added average and worst time (we used to only have median), and also a percentage
2275         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
2276
2277         There is always some wait due to the polling nature of the queues, which is well understood
2278         and doesn't need to be measured. What needs to be measured is whether there is enough
2279         bot machines to process patches as soon as they are submitted.
2280
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2282         (Analyzer.prototype._analyzeBubblePerformance):
2283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2284         (MetricsBubbleView.prototype._update):
2285
2286 2014-10-11  Jer Noble  <jer.noble@apple.com>
2287
2288         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2289         https://bugs.webkit.org/show_bug.cgi?id=137533
2290
2291         Reviewed by Darin Adler.
2292
2293         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2294         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2295         (TestWebKitAPI::TEST):
2296         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
2297         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
2298
2299 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2300
2301         iOS DRT snapshots are limited to the page visible area
2302         https://bugs.webkit.org/show_bug.cgi?id=137650
2303
2304         Reviewed by Daniel Bates.
2305         
2306         LegacyTileCache drawing was limited to the window's visible area, found by
2307         crawling up the layer hierarchy to the root layer. This caused test snapshots to
2308         be missing non-composited content outside the iPhone visible area, which hinders
2309         testing.
2310         
2311         Fix by adding a test-only mode where the window visible area is the entire window.
2312         
2313         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2314         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
2315         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2316         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
2317         for the DRT window.
2318         
2319
2320 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
2321
2322         Page not fully rendered in iOS DRT snapshots
2323         https://bugs.webkit.org/show_bug.cgi?id=137638
2324
2325         Reviewed by Tim Horton.
2326         
2327         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
2328         to ensure that the page has laid out and is rendered by the time we take
2329         the snapshot.
2330
2331         * DumpRenderTree/mac/DumpRenderTree.mm:
2332         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
2333         (-[DumpRenderTree _webThreadInvoked]): Moved.
2334         (-[DumpRenderTree _waitForWebThreadThenDump]):
2335         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
2336         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
2337         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
2338         relies on dispatch_async too, and the inner block won't complete until the outer block
2339         has completed.
2340         (dumpTestResults): Move the guts of dump() here.
2341         (runTest): Whitespace.
2342
2343 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
2344
2345         Adding svn:ignore so that .pyc files don't show up as new.
2346
2347         * Scripts/webkitpy/xcode: Added property svn:ignore.
2348
2349 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
2350
2351         [EFL] Introduce EWebKit_Extension
2352         https://bugs.webkit.org/show_bug.cgi?id=134921
2353
2354         Reviewed by Gyuyoung Kim.
2355
2356         * MiniBrowser/efl/main.c: Added x option to test extension path.
2357         (window_create):
2358         (elm_main):
2359         * Scripts/webkitpy/common/config/watchlist:
2360         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2361         * Scripts/webkitpy/style/checker.py:
2362         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2363
2364 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
2365
2366         After r174628 we send the test process a SIGTERM before the SIGKILL.
2367
2368         * Scripts/webkitpy/common/system/executive_unittest.py:
2369         (ExecutiveTest.serial_test_kill_process):
2370
2371 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
2372
2373         [EFL] Enable WebP support.
2374         https://bugs.webkit.org/show_bug.cgi?id=136156
2375
2376         Reviewed by Gyuyoung Kim.
2377
2378         Include libwebp-dev package to support WebP for WK2 Efl.
2379
2380         * efl/install-dependencies:
2381
2382 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2383
2384         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
2385         https://bugs.webkit.org/show_bug.cgi?id=137485
2386
2387         Reviewed by Sergio Villar Senin.
2388
2389         Update GMainLoopSource tests. Most of the tests are now run twice,
2390         first with a GMainLoopSource and then with a
2391         GThreadSafeMainLoopSource, since both should have the same
2392         behaviour. The threading test uses GThreadSafeMainLoopSource and
2393         the delete on destroy test uses GMainLoopSource. The tests
2394         themselves haven't changed, since there's no change in behaviour.
2395
2396         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2397         (TestWebKitAPI::GMainLoopSourceTest::source):
2398         (TestWebKitAPI::basicRescheduling):
2399         (TestWebKitAPI::TEST):
2400         (TestWebKitAPI::reentrantRescheduling):
2401         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
2402         (TestWebKitAPI::basicDestroyCallbacks):
2403         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
2404         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
2405
2406 2014-10-10  Dana Burkart  <dburkart@apple.com>
2407
2408         Fix fat-fingered function name in git-add-reviewer.
2409
2410         Unreviewed.
2411
2412         * Scripts/git-add-reviewer:
2413         (getConfigValue):
2414
2415 2014-10-10  David Farler  <dfarler@apple.com>
2416
2417         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
2418         https://bugs.webkit.org/show_bug.cgi?id=137528
2419
2420         Reviewed by Simon Fraser.
2421
2422         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
2423         and SIGKILL the paired simulator app before exiting cleanly.
2424
2425         webkitpy only uses SIGKILL to kill processes which you cannot
2426         catch. Send SIGTERM to the process and give it chance to do
2427         its thing before sending SIGKILL. Sending a SIGKILL to an already
2428         dead PID is safe.
2429
2430         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2431         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2432         (-[LTRelayController finish]):
2433         * LayoutTestRelay/LayoutTestRelay/main.m:
2434         (receivedSignal):
2435         (main):
2436
2437 2014-10-10  David Farler  <dfarler@apple.com>
2438
2439         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
2440         https://bugs.webkit.org/show_bug.cgi?id=137527
2441
2442         Reviewed by Simon Fraser.
2443
2444         NSFileHandle doesn't notify of EOF in its readability handler.
2445         Use a dispatch_source_t and an event handler that is called when reading is possible.
2446         In the handler block, do a run-of-the-mill read(2) from standard input and
2447         detect EOF in the usual way by checking that zero bytes were read.
2448
2449         Once an EOF is received, the FIFOs are disconnected, the simulator app
2450         is killed, and the relay exits with status 0.
2451
2452         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2453         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
2454         (-[LTRelayController didDisconnect]):
2455         (-[LTRelayController didConnect]):
2456         (-[LTRelayController launchApp]):
2457         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
2458         confusion with this new dispatch source, called "standardInputDispatchSource".
2459         (-[LTRelayController finish]): Added.
2460         (-[LTRelayController readFileHandle:]): Deleted.
2461
2462 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
2463
2464         [EFL] Crash on facebook.com
2465         https://bugs.webkit.org/show_bug.cgi?id=137562
2466
2467         Reviewed by Chris Dumez.
2468
2469         Crash occurs on the facebook.com when the webview is resized
2470         after the <select> item is clicked but no item is chosen.
2471         This crash is just caused by the reference of invalidated variable.
2472         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
2473         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
2474         on MiniBrowser is called.
2475         As a result, just set ewk_menu to NULL in order to prevent crash condition.
2476
2477         * MiniBrowser/efl/main.c:
2478         (on_popup_menu_hide):
2479
2480 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2481
2482         A small wording change for clarity.
2483
2484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2485         (MetricsBubbleView.prototype._update):
2486
2487 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2488
2489         Dashboard metrics page should have EWS statistics
2490         https://bugs.webkit.org/show_bug.cgi?id=137626
2491
2492         Reviewed by Ryosuke Niwa.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2495         (BubbleQueue): Put shortName in the object, so that it's actually useful.
2496
2497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2498         (BubbleQueueServer): Re-ordered queues to match bubble order.
2499         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
2500         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
2501
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2503         Added analysis for bubble queues.
2504
2505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
2506
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2508         (buildBubbleQueuesTable): Build the UI.
2509
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
2511         Added JS sources to load.
2512
2513         * QueueStatusServer/app.yaml: To update app version.
2514
2515         * QueueStatusServer/handlers/processingtimesjson.py: Added.
2516
2517         * QueueStatusServer/main.py: Added a handler for processing-times-json.
2518
2519 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2520
2521         REGRESSION: Commit queue doesn't process rollouts
2522         https://bugs.webkit.org/show_bug.cgi?id=137623
2523
2524         Reviewed by Tim Horton.
2525
2526         * QueueStatusServer/app.yaml:
2527         * QueueStatusServer/handlers/updateworkitems.py:
2528         (UpdateWorkItems._work_items_from_request):
2529
2530 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
2531
2532         Fix syntax error after r174601.
2533
2534         * Scripts/run-javascriptcore-tests:
2535
2536 2014-10-10  Michael Saboff  <msaboff@apple.com>
2537
2538         Add ability to select tarfile name in run-jsc-stress-tests
2539         https://bugs.webkit.org/show_bug.cgi?id=137614
2540
2541         Reviewed by Mark Hahnenberg.
2542
2543         Added optional file name argument to the --tarball option.  
2544
2545         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
2546         extra test given after the options wont be used for the optional tarball file name.
2547         * Scripts/run-jsc-stress-tests:
2548
2549 2014-10-10  Chris Dumez  <cdumez@apple.com>
2550
2551         Unreviewed, update my information in contributors.json
2552
2553         Use my preferred first name and update my expertise areas.
2554
2555         * Scripts/webkitpy/common/config/contributors.json:
2556
2557 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
2558
2559         Fix perl scripts to run with env on Linux
2560         https://bugs.webkit.org/show_bug.cgi?id=137601
2561
2562         Reviewed by Csaba Osztrogonác.
2563
2564         Use of arguments in #! is nonstandard and does not behave the same on
2565         different systems. Linux would look for an executable named "perl -w" 
2566         "use warnings;" does the same things in a more portable way.
2567
2568         * Scripts/commit-log-editor:
2569         * Scripts/num-cpus:
2570         * Scripts/prepare-ChangeLog:
2571         * Scripts/run-launcher:
2572         * Scripts/svn-create-patch:
2573
2574 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2575
2576         [jhbuild] We should be able to disable wiping on configuration change
2577         https://bugs.webkit.org/show_bug.cgi?id=137446
2578
2579         Reviewed by Csaba Osztrogonác.
2580
2581         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
2582         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
2583         or passing --no-wipe-on-change command line option.
2584
2585         * Scripts/update-webkit-libs-jhbuild:
2586
2587 2014-10-09  Andy Estes  <aestes@apple.com>
2588
2589         Teach webkitpy about OS X Yosemite
2590         https://bugs.webkit.org/show_bug.cgi?id=137585
2591
2592         Reviewed by Simon Fraser.
2593
2594         * Scripts/webkitpy/common/system/platforminfo.py:
2595         (PlatformInfo._determine_mac_version):
2596         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2597         (TestPlatformInfo.test_os_version):
2598         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2599         (TestExpectationParser):
2600         * Scripts/webkitpy/port/builders.py:
2601         * Scripts/webkitpy/port/mac.py:
2602         (MacPort):
2603         * Scripts/webkitpy/port/mac_unittest.py:
2604         (test_versions):
2605         (test_baseline_search_path):
2606         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2607         (TestRebaselineTest.test_baseline_directory):
2608         (TestRebaselineExpectations.test_rebaseline_expectations):
2609
2610 2014-10-09  Dana Burkart  <dburkart@apple.com>
2611
2612         Add Mac OS Yosemite dashboard support.
2613
2614         Rubber-stamped by Lucas Forschler.
2615
2616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
2617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
2618         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2621
2622 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
2623
2624         Add Babak to contributors.json and add historical email addresses for some contributors
2625         https://bugs.webkit.org/show_bug.cgi?id=137546
2626
2627         Reviewed by Christophe Dumez.
2628
2629         contributors.json is used to analyze historical commit data and change logs.
2630
2631         Add back historical email addresses for some contributors and also add Babak (Shafiei).
2632
2633         * Scripts/webkitpy/common/config/contributors.json:
2634
2635 2014-10-09  Lucas Forschler  <lforschler@apple.com>
2636
2637         Add Mac OS Yosemite webkit build infrastructure.
2638         
2639         This patch adds 15 bots to our build.webkit.org configuration.
2640         We are matching the current Mavericks machines 1:1.
2641         
2642         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
2643         
2644         Reviewed by Matt Hanson.
2645
2646         * BuildSlaveSupport/build.webkit.org-config/config.json:
2647
2648 2014-10-09  Dana Burkart  <dburkart@apple.com>
2649
2650         Don't use backticks when running commands, as we run into sh-related
2651         interpolation issues. Also, fix our usage of system() to properly
2652         retrieve the status code.
2653         https://bugs.webkit.org/show_bug.cgi?id=137541
2654
2655         Reviewed by Darin Adler.
2656
2657         * Scripts/git-add-reviewer:
2658         (interactive):
2659         (nonInteractive):
2660         (requireCleanWorkTree):
2661         (cherryPick):
2662         (commit):
2663         (addReviewerToFile):
2664         (head):
2665         (isAncestor):
2666         (toCommit):
2667         (changeLogsForCommit):
2668         (resetToCommit):
2669         (getConfigValue):
2670         (runCommandWithOutput):
2671
2672 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2673
2674         Add a WebKit1 preference for selection services
2675         https://bugs.webkit.org/show_bug.cgi?id=137498
2676         <rdar://problem/18572699>
2677
2678         Reviewed by Simon Fraser.
2679
2680         * MiniBrowser/mac/WK1BrowserWindowController.m:
2681         (-[WK1BrowserWindowController awakeFromNib]):
2682         Turn on image and selection services in the Legacy WebKit MiniBrowser.
2683
2684 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
2685
2686         Get the patch scripts running on Haiku
2687         https://bugs.webkit.org/show_bug.cgi?id=137559
2688
2689         Reviewed by Benjamin Poulain.
2690
2691         Use /usr/bin/env instead of hardcoding path to perl.
2692         Declare haiku platform in platforminfo.py to avoid check-webkit-style
2693         failure.
2694
2695         * Scripts/commit-log-editor:
2696         * Scripts/num-cpus:
2697         * Scripts/prepare-ChangeLog:
2698         * Scripts/run-launcher:
2699         * Scripts/svn-create-patch:
2700         * Scripts/webkitpy/common/system/platforminfo.py:
2701         (PlatformInfo._determine_os_name):
2702
2703 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
2704
2705         StyleQueue should throw a PatchIsNotValid exception to achieve
2706         consistency with CommitQueue and EWS
2707         https://bugs.webkit.org/show_bug.cgi?id=137500
2708
2709         Reviewed by Alexey Proskuryakov.
2710
2711         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2712         Adds a call to validate() in run().
2713         (StyleQueueTask.run):
2714         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2715         Adds a return False in the patch is not valid exception statement.
2716         (AbstractEarlyWarningSystem.review_patch):
2717         * Scripts/webkitpy/tool/commands/queues.py:
2718         Adds a return False in the patch is not valid exception statement in
2719         commit queue, and adds an except statement to catch PatchIsNotValid
2720         exceptions in style queue.
2721         (CommitQueue.process_work_item):
2722         (StyleQueue.review_patch):
2723
2724 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2725
2726         Race condition with WebKitWebView:is-loading after starting page load
2727         https://bugs.webkit.org/show_bug.cgi?id=136692
2728
2729         Reviewed by Gustavo Noronha Silva.
2730
2731         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2732         (loadChangedCallback): Only check is-loading is false when load
2733         has finished if the load didn't fail due to a cancellation.
2734         (loadFailedCallback): Only check is-loading is false if the load
2735         didn't fail due to a cancellation.
2736         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2737         (WebViewTest::loadURI): Check is-loading is true and active URI is
2738         the requested one rigth after requesting the load.
2739         (WebViewTest::loadHtml): Ditto.
2740         (WebViewTest::loadPlainText): Ditto.
2741         (WebViewTest::loadBytes): Ditto.
2742         (WebViewTest::loadRequest): Ditto.
2743         (WebViewTest::loadAlternateHTML): Ditto.
2744         (WebViewTest::goBack): Ditto.
2745         (WebViewTest::goForward): Ditto.
2746         (WebViewTest::goToBackForwardListItem): Ditto.
2747
2748 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
2749
2750         [Win] Resolve various static analyzer warnings in Tools.
2751         https://bugs.webkit.org/show_bug.cgi?id=137534
2752
2753         Reviewed by Dean Jackson.
2754
2755         * DumpRenderTree/cg/ImageDiffCG.cpp:
2756         (main): User proper printf specifiers.
2757         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2758         (AccessibilityUIElement::childrenCount): Handle possibility that
2759         gcc_accChildCount returns with an error.
2760         (accessibilityState): Ditto for gcc_accState.
2761         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2762         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
2763         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
2764         be treated as such.
2765         * DumpRenderTree/win/DumpRenderTree.cpp:
2766         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
2767         by comparing an unsigned value as being greater-than zero.
2768         * DumpRenderTree/win/EditingDelegate.cpp:
2769         (dump): Pass proper character pointer type to printf.
2770         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
2771         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2772         (EditingDelegate::shouldInsertNode): Ditto.
2773         (EditingDelegate::shouldInsertText): Ditto.
2774         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2775         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2776         (EditingDelegate::shouldApplyStyle): Ditto.
2777         * DumpRenderTree/win/EventSender.cpp:
2778         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
2779         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
2780         system headers.
2781         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
2782         from CreateDIBSection.
2783         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
2784         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
2785         older versions of MSVC we no longer support.
2786         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
2787         for 64-bit builds.
2788         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
2789         * TestWebKitAPI/TestsController.h: Ditto.
2790         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
2791         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
2792         performing bitwise | before the comparison is done.
2793
2794 2014-10-08  Ada Chan  <adachan@apple.com>
2795
2796         Add a test for WKPageIsPlayingAudio().
2797         https://bugs.webkit.org/show_bug.cgi?id=137048
2798
2799         Reviewed by Darin Adler.
2800
2801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2802         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
2803         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
2804         (TestWebKitAPI::nullJavaScriptCallback):
2805         (TestWebKitAPI::didFinishLoadForFrame):
2806         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
2807         (TestWebKitAPI::setUpClients):
2808         (TestWebKitAPI::TEST):
2809         This test loads a page with a video in it. When the page is loaded, we first check that
2810         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
2811         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
2812         now returns true for the page.
2813         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
2814         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
2815         This is a video copied from LayoutTests/media/content.
2816
2817 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
2818
2819         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
2820         https://bugs.webkit.org/show_bug.cgi?id=137516
2821
2822         Reviewed by Alexey Proskuryakov.
2823
2824         * Scripts/webkitpy/thirdparty/__init__.py:
2825         (AutoinstallImportHook._install_irc):
2826
2827 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2828
2829         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
2830         https://bugs.webkit.org/show_bug.cgi?id=137520
2831
2832         Reviewed by Philippe Normand.
2833
2834         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
2835         For other distributions, we are already installing libjpeg-turbo.
2836         So, do the same for Debian and derivatives.
2837
2838         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
2839
2840 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2841
2842         [webkitpy] Add back the workaround to replace ZipFile.extractall()
2843         https://bugs.webkit.org/show_bug.cgi?id=137519
2844
2845         Reviewed by Csaba Osztrogonác.
2846
2847         It was removed by <http://trac.webkit.org/changeset/174266>,
2848         because the comment stated it is a workaround for buggy python
2849         2.6.1 which shipped on Snow Leopard. But it turned out the bug
2850         is still valid with python 2.7 shipped on the latest Ubuntu
2851         (12.04 and 14.04) and OS X 10.9.
2852
2853         * Scripts/webkitpy/common/system/autoinstall.py:
2854         (AutoInstaller):
2855         (AutoInstaller._extract_all):
2856         (AutoInstaller._unzip):
2857
2858 2014-10-08  Commit Queue  <commit-queue@webkit.org>
2859
2860         Unreviewed, rolling out r174335.
2861         https://bugs.webkit.org/show_bug.cgi?id=137515
2862
2863         It broke EFL layout test totally (Requested by gyuyoung on
2864         #webkit).
2865
2866         Reverted changeset:
2867
2868         "[EFL] Introduce EWebKit_Extension"
2869         https://bugs.webkit.org/show_bug.cgi?id=134921
2870         http://trac.webkit.org/changeset/174335
2871
2872 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2873
2874         [GTK] Make forwarding headers generation depend on source code
2875         https://bugs.webkit.org/show_bug.cgi?id=137394
2876
2877         Reviewed by Philippe Normand.
2878
2879         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
2880         * TestWebKitAPI/PlatformGTK.cmake: Only run
2881         generate-forwarding-headers.pl when source code changes.
2882         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
2883
2884 2014-10-07  Tanay C  <tanay.c@samsung.com>
2885
2886         Remove build warnings in Hashmap API tests
2887         https://bugs.webkit.org/show_bug.cgi?id=137484
2888
2889         Reviewed by Darin Adler.
2890
2891         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2892         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
2893
2894 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
2895
2896         Commit queue doesn't drop obsolete patches sometimes
2897         https://bugs.webkit.org/show_bug.cgi?id=137460
2898
2899         Reviewed by Alexey Proskuryakov.
2900
2901         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2902         Adds another test patch for use in queues_unittest.py.
2903         courtesy of Csaba Osztrogonác <ossy@webkit.org>
2904         (MockBugzilla):
2905         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2906         Raises a PatchIsNotValid exception in the case of validate() returning
2907         false.
2908         (CommitQueueTask.run):
2909         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2910         Raises a PatchIsNotValid exception in the case of validate() returning
2911         false.
2912         (EarlyWarningSystemTask.run):
2913         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2914         Defines PatchIsNotValid exception. 
2915         (PatchIsNotValid):
2916         (PatchIsNotValid.__init__):
2917         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2918         Remove call to validate() and instead catches the PatchIsNotValid
2919         exception.
2920         (AbstractEarlyWarningSystem.review_patch):
2921         * Scripts/webkitpy/tool/commands/queues.py:
2922         Adds logic to catch the PatchIsNotValid exception.
2923         (CommitQueue.process_work_item):
2924         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2925         Adds the test_non_valid_patch test to ensure that invalid patches are
2926         handled properly, and don't just result in indefinite spinning.
2927         courtesy of Csaba Osztrogonác <ossy@webkit.org>
2928         (test_non_valid_patch):
2929
2930 2014-10-07  Daniel Bates  <dabates@apple.com>
2931
2932         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
2933         https://bugs.webkit.org/show_bug.cgi?id=137499
2934
2935         Reviewed by Simon Fraser.
2936
2937         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
2938         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
2939         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
2940         bit simulator builds of iOS WebKit.
2941
2942         * Scripts/webkitpy/port/ios.py:
2943         (IOSSimulatorPort._generate_all_test_configurations):
2944
2945 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2946
2947         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
2948         https://bugs.webkit.org/show_bug.cgi?id=137482
2949
2950         Reviewed by Martin Robinson.
2951
2952         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
2953
2954 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2955
2956         [SOUP] TLS errors should take precedence over HTTP authentication
2957         https://bugs.webkit.org/show_bug.cgi?id=137300
2958
2959         Reviewed by Sergio Villar Senin.
2960
2961         Add a test case to check that authenticate signal is not emitted
2962         in case of TLS errors, and the load fails instead.
2963
2964         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2965         (webViewAuthenticationCallback):
2966         (testTLSErrorsHTTPAuth):
2967         (httpsServerCallback):
2968         (beforeAll):
2969
2970 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
2971
2972         Make webkit-patch find-users useful
2973         https://bugs.webkit.org/show_bug.cgi?id=137475
2974
2975         Reviewed by Alexey Proskuryakov.
2976
2977         Make find-users use the CommitterList instead of accessing Bugzilla.
2978
2979         This essentially exposes the same functionality as webkitbot's whois command.
2980
2981         * Scripts/webkitpy/tool/commands/findusers.py:
2982         (FindUsers.execute):
2983
2984 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
2985
2986         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
2987         https://bugs.webkit.org/show_bug.cgi?id=137289
2988
2989         Unreviewed build fix.
2990
2991         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2992         (AccessibilityUIElement::getChildrenWithRange):
2993
2994 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
2995
2996         build.webkit.org/dashboard: Add commit queue
2997         https://bugs.webkit.org/show_bug.cgi?id=137462
2998
2999         Reviewed by Tim Horton.
3000
3001         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
3002         Style queue is still invisible, as it doesn't have an associated platform, and also
3003         we never have problems with it anyway, so it's not worth watching.
3004
3005         The UI now allows for adding more bots to the Other column (such as leaks bot).
3006         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
3007         sources of data in a cell.
3008
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
3010         (BubbleQueue):
3011         (BubbleQueue.prototype.get statusPageURL):
3012         (BubbleQueue.prototype.update):
3013         (BubbleQueue.prototype.loadDetailedStatus):
3014         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
3015         (BubbleQueueServer):
3016         (BubbleQueueServer.prototype.jsonQueueLengthURL):
3017         (BubbleQueueServer.prototype.jsonQueueStatusURL):
3018         (BubbleQueueServer.prototype.queueStatusURL):
3019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
3020         (BubbleQueueView):
3021         (BubbleQueueView.prototype.update.appendQueue):
3022         (BubbleQueueView.prototype.update):
3023         (BubbleQueueView.prototype._addQueueHeadingToPopover):
3024         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
3025         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
3026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
3027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
3028         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
3029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3030         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3032         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
3033         (.bubble-server-popover .latest-status-no-link):
3034         (.bubble-server-popover .bot-status-description):
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3036
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3038         (buildAggregateTable):
3039         (buildQueuesTable):
3040         Removed dysfunctional support for EWS for now. It will be different.
3041
3042 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3043
3044         One more case of incorrect comparison in recordpatchevent.py
3045         https://bugs.webkit.org/show_bug.cgi?id=137459
3046
3047         Reviewed by Tim Horton.
3048
3049         * QueueStatusServer/app.yaml:
3050         * QueueStatusServer/loggers/recordpatchevent.py:
3051         (RecordPatchEvent.started):
3052
3053 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3054
3055         webkit-queues PatchLog is incorrect for patches that took less than a second
3056         https://bugs.webkit.org/show_bug.cgi?id=137453
3057
3058         Reviewed by Tim Horton.
3059
3060         * QueueStatusServer/app.yaml: Updated app version.
3061
3062         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
3063         Don't bail out for patches that took 0 seconds to process (as frequently happens
3064         when a patch is obsolete).
3065
3066 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
3067
3068         EWS bubble hover shows wrong timestamps
3069         https://bugs.webkit.org/show_bug.cgi?id=137252
3070
3071         Reviewed by Alexey Proskuryakov.
3072
3073         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
3074
3075         * QueueStatusServer/handlers/queuestatusjson.py:
3076         (QueueStatusJSON.get):
3077         * QueueStatusServer/handlers/statusbubble.py:
3078         (StatusBubble._iso_time):
3079
3080 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
3081
3082         Unreviewed, updated list of email addresses in contributors.json
3083
3084         * Scripts/webkitpy/common/config/contributors.json: Added my former
3085         email address in Igalia, for the sake of completeness.
3086
3087 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3088
3089         Unreviewed, moved myself to the list of committers.
3090
3091         * Scripts/webkitpy/common/config/contributors.json:
3092
3093 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
3094
3095         [EFL] Introduce EWebKit_Extension
3096         https://bugs.webkit.org/show_bug.cgi?id=134921
3097
3098         Reviewed by Gyuyoung Kim.
3099
3100         * MiniBrowser/efl/main.c: Added x option to test extension path.
3101         (window_create):
3102         (elm_main):
3103         * Scripts/webkitpy/common/config/watchlist:
3104         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3105         * Scripts/webkitpy/style/checker.py:
3106         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3107
3108 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
3109
3110         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
3111         https://bugs.webkit.org/show_bug.cgi?id=137390
3112
3113         Reviewed by Carlos Garcia Campos.
3114
3115         * Scripts/update-webkit-libs-jhbuild:
3116
3117 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3118
3119         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
3120         https://bugs.webkit.org/show_bug.cgi?id=137391
3121
3122         Reviewed by Martin Robinson.
3123
3124         Add a custom command to only re-generate
3125         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
3126
3127         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3128
3129 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3130
3131         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
3132         https://bugs.webkit.org/show_bug.cgi?id=135502
3133
3134         Reviewed by Martin Robinson.
3135
3136         When writing to stdout/stderr fails due to a UnicodeDecodeError
3137         exception, try again without encoding the output.
3138
3139         * gtk/gtkdoc.py:
3140         (GTKDoc._run_command):
3141
3142 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3143
3144         Bugzilla status bubble displays an exception showing attachment 175738
3145         https://bugs.webkit.org/show_bug.cgi?id=137410
3146
3147         Reviewed by Tim Horton.
3148
3149         * QueueStatusServer/app.yaml: Update version.
3150
3151         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
3152         Don't fail even if expected status message is missing.
3153
3154         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
3155         the field in the same way it's defined in QueueStatus table.
3156
3157 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3158
3159         Record latest message in PatchLog for quick access
3160         https://bugs.webkit.org/show_bug.cgi?id=137405
3161
3162         Fixing a typo.
3163
3164         * QueueStatusServer/app.yaml:
3165         * QueueStatusServer/handlers/releasepatch.py:
3166
3167 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3168
3169         Record latest message in PatchLog for quick access
3170         https://bugs.webkit.org/show_bug.cgi?id=137405
3171
3172         Reviewed by Ryosuke Niwa.
3173
3174         It's no SQL...
3175
3176         * QueueStatusServer/handlers/releasepatch.py:
3177         * QueueStatusServer/handlers/updatestatus.py:
3178         * QueueStatusServer/loggers/recordpatchevent.py:
3179         * QueueStatusServer/model/patchlog.py:
3180
3181 2014-10-02  David Farler  <dfarler@apple.com>
3182
3183         -asan-blacklist option also renamed to generic -fsanitize-blacklist
3184         https://bugs.webkit.org/show_bug.cgi?id=137377
3185
3186         Reviewed by Daniel Bates.
3187
3188         * asan/asan.xcconfig:
3189         -asan-blacklist -> -fsanitize-blacklist
3190
3191         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3192
3193 2014-10-03  Roger Fong  <roger_fong@apple.com>
3194
3195         [Windows] Include batch size argument to layout tests on Windows.
3196
3197         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3198         (RunWebKitTests.start): 
3199         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
3200         These crashes seem to happen on random tests though generally in a spread out fashion.
3201         It seems possible that the DRT instance is being clobbered somehow after running too many
3202         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
3203
3204 2014-10-03  Roger Fong  <roger_fong@apple.com>
3205
3206         [Windows] Settle for 2 chid processes running NRWT on Windows.
3207
3208         * Scripts/webkitpy/port/win.py:
3209         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
3210
3211 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
3212
3213         [GTK] Bump up and patch dependencies to allow building for aarch64
3214         https://bugs.webkit.org/show_bug.cgi?id=137147
3215
3216         Reviewed by Martin Robinson.
3217
3218         The currently used versions of pixman, libffi, librsvg, glib,
3219         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
3220         and/or build for aarch64, so they are bumped up and patched where
3221         necessary. Wherever possible, the same versions and patches were used as
3222         for the EFL port bump-up
3223         (https://bugs.webkit.org/show_bug.cgi?id=135885).
3224
3225         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
3226         regression by crashing http/tests/media/video-redirect.html . A patch
3227         already in upstream fixes that bug.
3228
3229         This change does not touch xserver, which also needs bumping up, but 
3230         will be dealt with later.
3231
3232         * gtk/jhbuild.modules:
3233         Specified versions and patches necessary to correctly build for aarch64.
3234         * gtk/patches/gst-events-arent-gstobjects.patch:
3235         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
3236         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
3237         Added. Patches gst-plugins-base to configure correctly for aarch64.
3238         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
3239         Added. Bumps up config.guess and config.sub in librsvg to recognize
3240         aarch64.
3241         * gtk/patches/libxml2-2.9.0-dtd.patch:
3242         Removed. Not necessary for libxml2 v2.9.1 anymore.
3243
3244 2014-09-28  Sam Weinig  <sam@webkit.org>
3245
3246         Remove RefPtrHashMap
3247         https://bugs.webkit.org/show_bug.cgi?id=137200
3248
3249         Reviewed by Darin Adler.
3250
3251         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3252         (TestWebKitAPI::TEST):
3253         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
3254         a minimum of refcount churn occurs.
3255
3256 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3257
3258         Remove workarounds for versions of Python before 2.7
3259         https://bugs.webkit.org/show_bug.cgi?id=137338
3260
3261         Reviewed by Csaba Osztrogonác.
3262
3263         * Scripts/webkitpy/common/system/autoinstall.py:
3264         (AutoInstaller._extract_targz):
3265         (AutoInstaller._unzip):
3266         (AutoInstaller): Deleted.
3267         (AutoInstaller._extract_all): Deleted.
3268         * Scripts/webkitpy/common/webkitunittest.py:
3269         (TestCase.setUp): Deleted.
3270         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3271         (TestConfigurationConverter.collapse_macros):
3272         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3273         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3274         (TestConfigurationConverter):
3275         (TestConfigurationConverter.combinations): Deleted.
3276         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3277         * Scripts/webkitpy/port/base.py:
3278
3279 2014-10-03  Commit Queue  <commit-queue@webkit.org>
3280
3281         Unreviewed, rolling out r174264.
3282         https://bugs.webkit.org/show_bug.cgi?id=137392
3283
3284         It broke run-webkit-tests (Requested by ebalazsfalvi on
3285         #webkit).
3286
3287         Reverted changeset:
3288
3289         "Remove workarounds for versions of Python before 2.7"
3290         https://bugs.webkit.org/show_bug.cgi?id=137338
3291         http://trac.webkit.org/changeset/174264
3292
3293 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3294
3295         Remove workarounds for versions of Python before 2.7
3296         https://bugs.webkit.org/show_bug.cgi?id=137338
3297
3298         Reviewed by Csaba Osztrogonác.
3299
3300         * Scripts/webkitpy/common/system/autoinstall.py:
3301         (AutoInstaller._extract_targz):
3302         (AutoInstaller._unzip):
3303         (AutoInstaller): Deleted.
3304         (AutoInstaller._extract_all): Deleted.
3305         * Scripts/webkitpy/common/webkitunittest.py:
3306         (TestCase.setUp): Deleted.
3307         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3308         (TestConfigurationConverter.collapse_macros):
3309         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3310         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3311         (TestConfigurationConverter):
3312         (TestConfigurationConverter.combinations): Deleted.
3313         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3314         * Scripts/webkitpy/port/base.py:
3315         * Scripts/webkitpy/port/driver.py:
3316         (ContentBlock.__init__):
3317         * Scripts/webkitpy/port/server_process.py:
3318         (ServerProcess._reset):
3319
3320 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3321
3322         Remove autoinstaller workaround for python 2.6
3323         https://bugs.webkit.org/show_bug.cgi?id=137343
3324
3325         Reviewed by Daniel Bates.
3326
3327         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
3328         2.6, nor Snow Leopard is supported anymore, so the workaround is not
3329         needed anymore.
3330
3331         * Scripts/webkitpy/common/system/autoinstall.py:
3332         (AutoInstaller.install):
3333         * Scripts/webkitpy/test/main.py:
3334         (Tester._run_tests):
3335         * Scripts/webkitpy/thirdparty/__init__.py:
3336         (AutoinstallImportHook._install_mechanize):
3337         (AutoinstallImportHook._install_pep8):
3338         (AutoinstallImportHook._install_pylint):
3339         (AutoinstallImportHook._install_buildbot):
3340         (AutoinstallImportHook._install_coverage):
3341         (AutoinstallImportHook._install_eliza):
3342         (AutoinstallImportHook._install_irc):
3343         (AutoinstallImportHook._install):
3344         (autoinstall_everything):
3345
3346 2014-10-02  Daniel Bates  <dabates@apple.com>
3347
3348         Use version number 101000 instead of 10100 for OS X Yosemite
3349         https://bugs.webkit.org/show_bug.cgi?id=137372
3350
3351         Reviewed by Mark Rowe.
3352
3353         The version number for OS X Yosemite is 101000.
3354
3355         * DumpRenderTree/mac/TextInputController.m:
3356
3357 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
3358
3359         update-work-items should never delete items
3360         https://bugs.webkit.org/show_bug.cgi?id=137366
3361
3362         Reviewed by Ryosuke Niwa.
3363
3364         As we don't just replace the whole list any more, indicate which items are high
3365         priority, and which are not. Hight priority ones will be prepended to the queue,
3366         others will be appended.
3367
3368         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
3369         But hopefully we will never have many rollouts competing like that.
3370
3371         * QueueStatusServer/app.yaml: Update version.
3372
3373         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
3374         priority and regular items separately. Removed some error handling that used to
3375         end up in returning status 500 - an uncaught exception does that automatically.
3376
3377         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
3378
3379         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
3380
3381         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
3382         priority items.
3383
3384         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3385         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
3386         line that complicated testing.
3387
3388         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
3389
3390         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
3391         priority items into separate lists.
3392
3393         * Scripts/webkitpy/common/net/statusserver_mock.py:
3394         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3395         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3396         Updated tests.
3397
3398 2014-10-02  Brendan Long  <b.long@cablelabs.com>
3399
3400         Annoying build warnings in WTFString API tests
3401         https://bugs.webkit.org/show_bug.cgi?id=137360
3402
3403         Reviewed by Darin Adler.
3404
3405         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3406         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
3407
3408 2014-10-02  Roger Fong  <roger_fong@apple.com>
3409
3410         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
3411
3412         * Scripts/webkitpy/port/win.py:
3413         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
3414
3415 2014-10-02  David Farler  <dfarler@apple.com>
3416
3417         Move ASan arguments from LLVM (-mllvm) to the frontend
3418         https://bugs.webkit.org/show_bug.cgi?id=137365
3419
3420         Reviewed by David Kilzer.
3421
3422         * asan/asan.xcconfig:
3423         Remove the -mllvm prefix to the asan-blacklist argument, moving it
3424         to the clang frontend.
3425
3426         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3427
3428 2014-10-02  Commit Queue  <commit-queue@webkit.org>
3429
3430         Unreviewed, rolling out r174120.
3431         https://bugs.webkit.org/show_bug.cgi?id=137350
3432
3433         While number of failures is reasonable with 2 processes, test
3434         results seem to be inconsistent between runs (Requested by
3435         rfong on #webkit).
3436
3437         Reverted changeset:
3438
3439         "[Windows] Back to 2 child processes for NRWT on Windows."
3440         http://trac.webkit.org/changeset/174120
3441
3442 2014-10-02  Jeff Miller  <jeffm@apple.com>
3443
3444         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
3445         https://bugs.webkit.org/show_bug.cgi?id=137347
3446
3447         Reviewed by Dan Bernstein.
3448
3449         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3450         Use WebKitSystemInterfaceYosemite on OS X 10.10.
3451
3452         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3453         Ditto.
3454
3455 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3456
3457         [GTK] [JHBuild] Switch sourceware.org mirror to http.
3458
3459         Unreviewed.
3460
3461         The ftp access is recently failing to work as expected, and the
3462         bots fail to download the file.
3463         The same mirror is available via http and seems to work better.
3464
3465         * gtk/jhbuild.modules:
3466
3467 2014-10-01  Commit Queue  <commit-queue@webkit.org>
3468
3469         Unreviewed, rolling out r174185.
3470         https://bugs.webkit.org/show_bug.cgi?id=137334
3471
3472         Patch that adds logging causes webkitpy failures (Requested by
3473         rfong on #webkit).
3474
3475         Reverted changeset:
3476
3477         "commitqueuetasks_unittest references a non-existent member
3478         variable"
3479         https://bugs.webkit.org/show_bug.cgi?id=137303
3480         http://trac.webkit.org/changeset/174185
3481
3482 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3483
3484         EWS and Commit Queue should know better than to spew 500 failed
3485         results in the case of extremely red patches.
3486         https://bugs.webkit.org/show_bug.cgi?id=137324
3487
3488         Reviewed by Alexey Proskuryakov.
3489
3490         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3491         Adds a check for did_exceed_test_failure_limit.
3492         (AbstractEarlyWarningSystem._failing_tests_message):
3493         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3494         Alters the task mock to respond properly to
3495         results_from_patch_test_run(patch)
3496         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3497         * Scripts/webkitpy/tool/commands/queues.py:
3498         Adds a check for did_exceed_test_failure_limit.
3499         (CommitQueue._failing_tests_message):
3500
3501 2014-10-01  Daniel Bates  <dabates@apple.com>
3502
3503         Unreviewed, rolling out r174192.
3504
3505         Revert the unit test fix in r174192 since we reverted r174187
3506         in r174194 due to correctness issues. See
3507         <http://webkit.org/b/137329> for more details.
3508
3509         Reverted changeset:
3510
3511         "Test fix after r174187"
3512         http://trac.webkit.org/changeset/174192
3513
3514 2014-10-01  Mark Rowe  <mrowe@apple.com>
3515
3516         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3517
3518         Reviewed by Dan Bernstein.
3519
3520         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
3521         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
3522         for the LLVM components when on Yosemite.
3523
3524 2014-10-01  Commit Queue  <commit-queue@webkit.org>
3525
3526         Unreviewed, rolling out r174187.
3527         https://bugs.webkit.org/show_bug.cgi?id=137329
3528
3529         webkitpy failures, and thorton says the patch is wrong
3530         (Requested by dethbakin on #webkit).
3531
3532         Reverted changeset:
3533
3534         "[Windows] Increase layout test timeout for Windows following
3535         r174162."
3536         http://trac.webkit.org/changeset/174187
3537
3538 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
3539
3540         Test fix after r174187
3541
3542         * Scripts/webkitpy/port/win_unittest.py:
3543         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
3544
3545 2014-10-01  Roger Fong  <roger_fong@apple.com>
3546
3547         [Windows] Increase layout test timeout for Windows following r174162.
3548
3549         * Scripts/webkitpy/port/win.py:
3550         (WinPort.default_timeout_ms):
3551
3552 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3553
3554         commitqueuetasks_unittest references a non-existent member variable
3555         when mock-reporting flaky tests.
3556         https://bugs.webkit.org/show_bug.cgi?id=137303
3557
3558         Reviewed by Daniel Bates.
3559
3560         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3561         (MockCommitQueue.report_flaky_tests):
3562         Makes the appropriate name change.
3563         (test_simple_flaky_test_failure):
3564         Adds a unit test to make sure that the code is excercised.
3565
3566 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3567
3568         EWS is inconclusively spinning forever on a patch that breaks 500+
3569         tests
3570         https://bugs.webkit.org/show_bug.cgi?id=137223
3571
3572         Reviewed by Tim Horton.
3573
3574         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3575         Checks to see whether the tests have exceeded the failure limit, and
3576         only spins off another test if they have not exceeded the limit.
3577         (PatchAnalysisTask._test_patch):
3578
3579 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
3580
3581         Unreviewed, add Katie Madonna as a contributor.
3582
3583         * Scripts/webkitpy/common/config/contributors.json:
3584
3585 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3586
3587         commitqueuetasks_unittest does not construct FailingTestCommitQueue
3588         objects properly in its test cases.
3589         https://bugs.webkit.org/show_bug.cgi?id=137281
3590
3591         Reviewed by Daniel Bates.
3592
3593         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3594         (FailingTestCommitQueue.test_results):
3595         Adds an assert to make FailingTestCommitQueue harder to mis-use.
3596         (test_double_flaky_test_failure):
3597         Nests the intended test failure strings into one-length lists.
3598         (test_red_test_failure):
3599         Nests the intended test failure strings into one-length lists.
3600
3601 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
3602
3603         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
3604         https://bugs.webkit.org/show_bug.cgi?id=136987
3605
3606         Reviewed by Daniel Bates.
3607
3608         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
3609         Specify the default encoding for all WebKit developers to get consistent results.
3610
3611 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
3612
3613         EWS is too eager to say that a patch does not apply to trunk of repository
3614         https://bugs.webkit.org/show_bug.cgi?id=137290
3615
3616         Reviewed by Ryosuke Niwa.
3617
3618         * QueueStatusServer/app.yaml: Updated app version.
3619
3620         * QueueStatusServer/handlers/statusbubble.py:
3621         (StatusBubble._build_bubble):
3622         (StatusBubble._build_bubbles_for_attachment):
3623         Rewrote to make more sense.
3624
3625 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3626
3627         Remove thirdparty/unittest2 from webkitpy
3628         https://bugs.webkit.org/show_bug.cgi?id=137251
3629
3630         Reviewed by Brent Fulgham.
3631
3632         Additionally ordered imports in related webkitpy files and
3633         removed unnecessary shebangs from unittest files.
3634
3635         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
3636         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3637         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3638         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3639         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3640         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3641         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3642         * Scripts/webkitpy/common/config/committers_unittest.py:
3643         * Scripts/webkitpy/common/config/committervalidator_unittest.py: