Tools/ChangeLog

   1 2015-03-17  Philippe Normand  <pnormand@igalia.com>
   2
   3         [GTK] basic OpenWebRTC build support
   4         https://bugs.webkit.org/show_bug.cgi?id=142393
   5
   6         Reviewed by Carlos Garcia Campos.
   7
   8         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
   9         is not the upstream OpenWebRTC repository. This temporary fork
  10         contains a few patches needed by WebKit for audio/video rendering.
  11
  12 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
  13
  14         [CMake][EFL] Build test tools only for developer mode
  15         https://bugs.webkit.org/show_bug.cgi?id=142761
  16
  17         Reviewed by Csaba Osztrogonác.
  18
  19         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
  20
  21         * CMakeLists.txt:
  22
  23 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
  24
  25         Remove never used "useLayerOnTop" bindings generator argument
  26         https://bugs.webkit.org/show_bug.cgi?id=142773
  27
  28         Reviewed by Darin Adler.
  29
  30         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
  31         (new):
  32
  33 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
  34
  35         Enable ES6 classes by default
  36         https://bugs.webkit.org/show_bug.cgi?id=142774
  37
  38         Reviewed by Gavin Barraclough.
  39
  40         * Scripts/webkitperl/FeatureList.pm:
  41
  42 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
  43
  44         Fix webkitpy tests after r181585.
  45
  46         Looks like "me" cannot be anyone's email, it's a special case.
  47
  48         * Scripts/webkitpy/common/config/contributors.json:
  49
  50 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
  51
  52         Add tolerance to WebAudio tests
  53         https://bugs.webkit.org/show_bug.cgi?id=142676
  54
  55         Reviewed by Tim Horton.
  56
  57         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
  58
  59         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  60         (TestResultWriter.create_audio_diff_and_write_result):
  61         * Scripts/webkitpy/layout_tests/models/test_failures.py:
  62         (FailureAudio.write_failure):
  63         * Scripts/webkitpy/port/base.py:
  64         (Port.do_audio_results_differ):
  65         Diff audio failures.
  66
  67         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
  68         tests to use real parseable WAV data, and got rid of base64, which there didn't
  69         seem to have been any reason for.
  70
  71 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
  72
  73         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
  74         https://bugs.webkit.org/show_bug.cgi?id=142720
  75
  76         Reviewed by Myles C. Maxfield.
  77
  78         Activate system copies of Microsoft fonts for the current process, thus overriding
  79         any other ones that could be preferred by the system otherwise.
  80
  81         * DumpRenderTree/mac/DumpRenderTree.mm:
  82         (activateSystemCoreWebFonts):
  83         (adjustFonts):
  84         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
  85         (WTR::activateSystemCoreWebFonts):
  86         (WTR::activateFonts):
  87
  88 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
  89
  90         Created Streams API watchlist
  91         https://bugs.webkit.org/show_bug.cgi?id=142684
  92
  93         Reviewed by Benjamin Poulain.
  94
  95         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
  96         watchlist and added Benjamin, Youenn and me to it.
  97
  98 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
  99
 100         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
 101         https://bugs.webkit.org/show_bug.cgi?id=142715
 102
 103         Reviewed by Brent Fulgham.
 104
 105         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
 106         (TestWebKitAPI::TEST):
 107
 108 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
 109
 110         Change the exact attribute matching to be ASCII case-insensitive
 111         https://bugs.webkit.org/show_bug.cgi?id=142609
 112
 113         Reviewed by Darin Adler.
 114
 115         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
 116         * TestWebKitAPI/Tests/WTF/StringView.cpp:
 117
 118 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 119
 120         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
 121         https://bugs.webkit.org/show_bug.cgi?id=134764
 122
 123         Reviewed by Ryosuke Niwa.
 124
 125         TestDownloader is introduced to download W3C tests from the official
 126         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
 127         and https://github.com/w3c/csswg-test.git).
 128         TestDownloader clones the repositories and checkouts revisions of the tests
 129         defined in LayoutTests/imported/w3c/resources/TestRepositories.
 130
 131         Similarly to https://codereview.chromium.org/148173016,
 132         TestDownloader copies part of the files based on the rules
 133         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
 134
 135         TestDownloader is used by TestImporter when no source directory is provided.
 136
 137         * Scripts/webkitpy/w3c/test_downloader.py: Added.
 138         (TestDownloader):
 139         (TestDownloader.default_options):
 140         (TestDownloader.load_test_repositories):
 141         (TestDownloader.__init__):
 142         (TestDownloader.checkout_test_repository):
 143         (TestDownloader._init_paths_from_expectations):
 144         (TestDownloader._add_test_suite_paths):
 145         (TestDownloader._empty_directory):
 146         (TestDownloader.copy_tests):
 147         (TestDownloader.download_tests):
 148         * Scripts/webkitpy/w3c/test_importer.py:
 149         (main):
 150         (parse_args):
 151         (TestImporter.__init__):
 152         (TestImporter.do_import):
 153         (TestImporter.test_downloader):
 154         (TestImporter.find_importable_tests.should_keep_subdir):
 155         (TestImporter.should_convert_test_harness_links):
 156         (TestImporter.import_tests):
 157         (TestImporter.write_import_log):
 158
 159 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
 160
 161         [Mavericks] Test snapshots are 1600x1200 on Retina devices
 162         https://bugs.webkit.org/show_bug.cgi?id=142630
 163
 164         Reviewed by Tim Horton.
 165
 166         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
 167         Removed an ifdef that disabled the fix on Mavericks.
 168
 169 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
 170
 171         Remove isWK2 cruft from webkitdirs.pm after r170426
 172         https://bugs.webkit.org/show_bug.cgi?id=142618
 173
 174         Reviewed by Daniel Bates.
 175
 176         * Scripts/webkitdirs.pm:
 177         (isWK2): Deleted.
 178
 179 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
 180
 181         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
 182         https://bugs.webkit.org/show_bug.cgi?id=138687
 183
 184         Reviewed by Carlos Garcia Campos.
 185
 186         Always change cookie policy from UI process, as changing it from WebProcess doesn't
 187         affect other processes.
 188
 189         The implementation is imperfect, because the change happens asynchronously, but I
 190         don't expect it to be a problem in practice.
 191
 192         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 193         (WTR::InjectedBundle::beginTesting):
 194         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 195         (WTR::TestRunner::setAlwaysAcceptCookies):
 196         * WebKitTestRunner/TestInvocation.cpp:
 197         (WTR::TestInvocation::invoke):
 198         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
 199
 200 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
 201
 202         [EFL] Enable building EFL 1.13 with NEON support
 203         https://bugs.webkit.org/show_bug.cgi?id=142619
 204
 205         Reviewed by Gyuyoung Kim.
 206
 207         * efl/jhbuild.modules:
 208
 209 2015-03-11  Alex Christensen  <achristensen@webkit.org>
 210
 211         [Content Extensions] Add resource type and load type triggers.
 212         https://bugs.webkit.org/show_bug.cgi?id=142422
 213
 214         Reviewed by Benjamin Poulain.
 215
 216         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 217         (TestWebKitAPI::testRequest):
 218         (TestWebKitAPI::mainDocumentRequest):
 219         (TestWebKitAPI::TEST_F):
 220         (TestWebKitAPI::testURL): Deleted.
 221
 222 2015-03-10  Sam Weinig  <sam@webkit.org>
 223
 224         Allow adding a button in input elements for auto fill related functionality
 225         <rdar://problem/19782066>
 226         https://bugs.webkit.org/show_bug.cgi?id=142564
 227
 228         Reviewed by Anders Carlsson.
 229
 230         * WebKitTestRunner/TestController.cpp:
 231         (WTR::TestController::createOtherPage):
 232         (WTR::TestController::createWebViewWithOptions):
 233         Update for new callback.
 234
 235 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
 236
 237         Add basic support for BOL and EOL assertions to the URL Filter parser
 238         https://bugs.webkit.org/show_bug.cgi?id=142568
 239
 240         Reviewed by Alex Christensen.
 241
 242         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 243         (TestWebKitAPI::TEST_F):
 244
 245 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
 246
 247         [GTK] Add support for handling TLS errors to MiniBrowser
 248         https://bugs.webkit.org/show_bug.cgi?id=142576
 249
 250         Reviewed by Sergio Villar Senin.
 251
 252         It's useful for testing TLS errors handling itself, but also to
 253         allow ignoring TLS errors when testing.
 254
 255         * MiniBrowser/gtk/BrowserWindow.c:
 256         (webViewLoadFailedWithTLSerrors):
 257         (browserWindowConstructed):
 258
 259 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
 260
 261         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
 262         https://bugs.webkit.org/show_bug.cgi?id=142569
 263
 264         Reviewed by David Hyatt.
 265
 266         Test Optional::valueOrCompute().
 267
 268         * TestWebKitAPI/Tests/WTF/Optional.cpp:
 269         (TestWebKitAPI::TEST):
 270
 271 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
 272
 273         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
 274         https://bugs.webkit.org/show_bug.cgi?id=126688
 275
 276         Reviewed by Gustavo Noronha Silva.
 277
 278         * CMakeLists.txt: Build testing tools only for developer builds,
 279         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
 280         * MiniBrowser/gtk/CMakeLists.txt: Only add
 281         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
 282         and add a rule to install the MiniBrowser.
 283         * MiniBrowser/gtk/main.c:
 284         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
 285         builds.
 286
 287 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
 288
 289         Add some DateMath tests to TestWebKitAPI
 290         https://bugs.webkit.org/show_bug.cgi?id=142565
 291
 292         Reviewed by Alexey Proskuryakov.
 293
 294         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
 295         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
 296         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
 297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
 298         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
 299
 300 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
 301
 302         Regression(r181257): WTF_WorkQueue.Simple is flaky
 303         https://bugs.webkit.org/show_bug.cgi?id=142560
 304
 305         Unreviewed attempt to improve test stability.
 306
 307         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
 308         the WorkQueue a little later to redue flakiness.
 309
 310 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
 311
 312         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
 313         https://bugs.webkit.org/show_bug.cgi?id=142555
 314
 315         Reviewed by Simon Fraser.
 316
 317         * DumpRenderTree/mac/DumpRenderTree.mm:
 318         (setDefaultsToConsistentValuesForTesting):
 319         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
 320         (WTR::InjectedBundle::platformInitialize):
 321
 322 2015-03-10  Alex Christensen  <achristensen@webkit.org>
 323
 324         Use unsigned for HashSet size.
 325         https://bugs.webkit.org/show_bug.cgi?id=142518
 326
 327         Reviewed by Benjamin Poulain.
 328
 329         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
 330         (TestWebKitAPI::TEST):
 331         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
 332         (TestWebKitAPI::testInitialCapacity):
 333         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
 334         (TestWebKitAPI::TEST):
 335
 336 2015-03-10  Daniel Bates  <dabates@apple.com>
 337
 338         [iOS] Add WebKitSystemInterface for iOS 8.2
 339         https://bugs.webkit.org/show_bug.cgi?id=142505
 340
 341         Rubber-stamped by Anders Carlsson.
 342
 343         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
 344         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
 345         copy-webkitlibraries-to-product-directory in r181286.
 346
 347         * Scripts/copy-webkitlibraries-to-product-directory:
 348
 349 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
 350
 351         Extend URL filter's Term definition to support groups/subpatterns
 352         https://bugs.webkit.org/show_bug.cgi?id=142519
 353
 354         Reviewed by Alex Christensen.
 355
 356         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 357         (TestWebKitAPI::testURL):
 358
 359 2015-03-06  Jer Noble  <jer.noble@apple.com>
 360
 361         Add an option to run-webkit-tests to override the LayoutTests/ directory
 362         https://bugs.webkit.org/show_bug.cgi?id=142418
 363
 364         Reviewed by David Kilzer.
 365
 366         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
 367         directory. The base port will parse the options during initialization and store the override
 368         location if present. layout_tests_dir() will return this overridden location if set.
 369
 370         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 371         (parse_args):
 372         * Scripts/webkitpy/port/base.py:
 373         (Port.__init__):
 374         (Port.layout_tests_dir):
 375
 376 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
 377
 378         [CMake] Enable WorkQueue tests for CMake ports
 379         https://bugs.webkit.org/show_bug.cgi?id=142473
 380
 381         Reviewed by Darin Adler.
 382
 383         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
 384         the list of source files.
 385         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
 386         to the list of include directories for EFL.
 387
 388 2015-03-09  David Kilzer  <ddkilzer@apple.com>
 389
 390         Attempt to fix timeouts on iOS Simulator layout tests
 391
 392         * Scripts/webkitpy/port/ios.py:
 393         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
 394         Simulator end after the first 50 tests time out.  Some analysis
 395         this past weekend shows that the 'Booted' status in the output
 396         of `xcrun simctl list` is not sufficient (and watching the test
 397         run shows that SpringBoard hasn't fully started to the point
 398         where it's displaying icons on the home screen).  The workaround
 399         until we have a better fix is to add an arbitrary timeout to let
 400         SpringBoard finish launching.  In practice, 15 seconds is
 401         probably enough, but 30 seconds should nearly always work.
 402
 403 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
 404
 405         Unreviewed. Add myself as a committer.
 406
 407         * Scripts/webkitpy/common/config/contributors.json:
 408
 409 2015-03-09  David Kilzer  <ddkilzer@apple.com>
 410
 411         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
 412
 413         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
 414         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
 415         an expectation that will fail if we hit the race condition.
 416         This test is inherently racy and will deadlock if the first job
 417         for queue2 takes the mutex lock before the second job for
 418         queue1.
 419
 420 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
 421
 422         [Win] WTF::WorkQueue does not balance ref/deref properly
 423         https://bugs.webkit.org/show_bug.cgi?id=142471
 424
 425         Reviewed by Antti Koivisto.
 426
 427         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
 428         (TestWebKitAPI::TEST): Check that the refcount is correct.
 429
 430 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 431
 432         Do not show passing test result on output of EFL layout test
 433         https://bugs.webkit.org/show_bug.cgi?id=142380
 434
 435         Reviewed by Darin Adler.
 436
 437         To show passing tests has caused inconvenience when we detect problem tests
 438         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
 439         in order not to show passing tests in the output of EFL layout test.
 440
 441         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 442         (RunWebKitTests.start):
 443
 444 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
 445
 446         Unreviewed build fix.
 447
 448         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
 449         (TestWebKitAPI::TEST): Remove two unused variables.
 450
 451 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
 452
 453         Add some WorkQueue tests to TestWebKitAPI
 454         https://bugs.webkit.org/show_bug.cgi?id=142447
 455
 456         Reviewed by Sam Weinig.
 457
 458         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
 459         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
 460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 461         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
 462         (TestWebKitAPI::simpleTest):
 463         (TestWebKitAPI::longTest):
 464         (TestWebKitAPI::thirdTest):
 465         (TestWebKitAPI::finishedTests):
 466         (TestWebKitAPI::TEST):
 467         (TestWebKitAPI::longTest2):
 468
 469 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
 470
 471         Remove willDestroyFrame in WKBundlePageLoaderClient
 472         https://bugs.webkit.org/show_bug.cgi?id=142389
 473
 474         Reviewed by Anders Carlsson.
 475
 476         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 477         (WTR::InjectedBundlePage::InjectedBundlePage):
 478
 479 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
 480
 481         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
 482         https://bugs.webkit.org/show_bug.cgi?id=142433
 483
 484         Reviewed by Darin Adler.
 485
 486         Include more TestWebKitAPI tests when building for Windows. Also
 487         fix a build error in MetaAllocator.cpp caused by one of the
 488         Microsoft headers #defining 'small'.
 489
 490         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
 491         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
 492         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
 493
 494 2015-03-06  Sam Weinig  <sam@webkit.org>
 495
 496         [Content Extensions] Move compiling of content extensions to the UIProcess
 497         https://bugs.webkit.org/show_bug.cgi?id=142402
 498
 499         Reviewed by Benjamin Poulain.
 500
 501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 502         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
 503         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
 504         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
 505         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
 506         (TestWebKitAPI::TEST_F):
 507         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
 508         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
 509         is now abstract).
 510
 511 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
 512
 513         [Win] Correct Windows build.
 514
 515         Rubberstamped by Michael Saboff
 516
 517         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
 518         in the GOTO labels.
 519
 520 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
 521
 522         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
 523         https://bugs.webkit.org/show_bug.cgi?id=142385
 524
 525         Reviewed by Sergio Villar Senin.
 526
 527         Use stack allocated GMainLoopSources to make sure they are
 528         cancelled automatically if the test finishes before they have
 529         been processed.
 530
 531         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
 532         (testWebViewSyncRequestOnMaxConns):
 533
 534 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
 535
 536         Remove Mountain Lion libraries since ML isn't supported
 537         https://bugs.webkit.org/show_bug.cgi?id=142332
 538
 539         Reviewed by Darin Adler.
 540
 541         * Scripts/copy-webkitlibraries-to-product-directory:
 542
 543 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
 544
 545         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
 546         https://bugs.webkit.org/show_bug.cgi?id=142083
 547
 548         Reviewed by Simon Fraser.
 549
 550         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
 551
 552         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
 553         (WebPlatformTestServer._copy_webkit_test_files):
 554
 555 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
 556
 557         setup-git-clone fails due to the failure to download python-irclib-0.4.8
 558         https://bugs.webkit.org/show_bug.cgi?id=141946
 559
 560         Reviewed by Ryosuke Niwa.
 561
 562         Check in ircbot.py and irclib.py to avoid network problems in the future.
 563
 564         * Scripts/webkitpy/common/net/irc/ircbot.py:
 565         * Scripts/webkitpy/thirdparty/__init__.py:
 566         (AutoinstallImportHook.find_module):
 567         (AutoinstallImportHook._install_irc): Deleted.
 568         * Scripts/webkitpy/thirdparty/__init___unittest.py:
 569         (ThirdpartyTest.test_imports):
 570         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
 571         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
 572         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
 573
 574 2015-03-06  David Kilzer  <ddkilzer@apple.com>
 575
 576         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
 577
 578         See also fix to config.json in r181097.
 579
 580         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 581         (WebKitBuildbot): Add missing "WK2" to the names of the perf
 582         bots.
 583
 584 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
 585
 586         run-jsc-stress-tests should determine the architecture from ELF binaries
 587         https://bugs.webkit.org/show_bug.cgi?id=142335
 588
 589         Reviewed by Darin Adler.
 590
 591         * Scripts/run-jsc-stress-tests:
 592
 593 2015-03-05  David Kilzer  <ddkilzer@apple.com>
 594
 595         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
 596         <http://webkit.org/b/142226>
 597
 598         Reviewed by Darin Adler.
 599
 600         * Scripts/webkitpy/port/ios.py:
 601         (IOSSimulatorPort.default_baseline_search_path): Switch the
 602         TestExpectations order of ios-simulator-wk2 from this:
 603           ios-simulator-wk2, wk2, ios-simulator
 604         To this:
 605           ios-simulator-wk2, ios-simualtor, wk2
 606
 607 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
 608
 609         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
 610         https://bugs.webkit.org/show_bug.cgi?id=142370
 611
 612         Reviewed by Dean Jackson.
 613
 614         * Scripts/webkitdirs.pm:
 615         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
 616         logs, one for warnings, the other for errors.
 617         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
 618         into the standard BuildOutput.htm document.
 619
 620 2015-03-05  David Kilzer  <ddkilzer@apple.com>
 621
 622         Dashboard has trouble parsing iOS test output
 623         <http://webkit.org/b/142364>
 624
 625         Reviewed by Alex Christensen.
 626
 627         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
 628         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
 629         Add fallback path to build a regex using 'matchString' so that
 630         it matches anywhere in the line.  In practice, 'matchString' is
 631         a prefix for the label following the number.
 632
 633 2015-03-05  Alex Christensen  <achristensen@webkit.org>
 634
 635         Fix linker warnings in TestWebKitAPI.
 636         https://bugs.webkit.org/show_bug.cgi?id=141912
 637
 638         Reviewed by David Kilzer.
 639
 640         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
 641         Do not export TearDownTestCase or SetUpTestCase symbols.
 642
 643 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
 644
 645         [Win] Unreviewed EWS fix.
 646
 647         * Scripts/webkitdirs.pm:
 648         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
 649         the EWS output more usable.
 650
 651 2015-03-05  Chris Dumez  <cdumez@apple.com>
 652
 653         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
 654         https://bugs.webkit.org/show_bug.cgi?id=142350
 655
 656         Reviewed by Michael Saboff and Benjamin Poulain.
 657
 658         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
 659         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
 660
 661         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
 662         (TestWebKitAPI::TEST):
 663
 664 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
 665
 666         [Win] Ensure build target directory exists when launching MSBuild
 667         https://bugs.webkit.org/show_bug.cgi?id=142360
 668
 669         Reviewed by Dean Jackson.
 670
 671         Create the build output directory (if it doesn't exist) before
 672         launching MSBuild so that it can immediately begin writing logs.
 673
 674         * Scripts/webkitdirs.pm:
 675         (buildVisualStudioProject):
 676
 677 2015-03-05  Chris Dumez  <cdumez@apple.com>
 678
 679         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
 680         https://bugs.webkit.org/show_bug.cgi?id=142325
 681
 682         Reviewed by Csaba Osztrogonác.
 683
 684         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
 685         As a result, "--webkit-test-runner / -2" parameters are replaced by
 686         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
 687         than WebKitTestRunner.
 688
 689         * BuildSlaveSupport/build.webkit.org-config/config.json:
 690         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 691         (RunWebKit1Tests):
 692         (RunWebKit1Tests.start):
 693         (RunWebKit1LeakTests):
 694         (RunWebKit1LeakTests.start):
 695         (RunAndUploadPerfTestsWebKit1):
 696         (RunAndUploadPerfTestsWebKit1.start):
 697         (TestFactory):
 698         (TestWebKit1LeaksFactory):
 699         (TestWebKit1LeaksFactory.__init__):
 700         (TestWebKit1Factory):
 701         (TestWebKit1AllButJSCFactory):
 702         (TestAllButJSCFactory):
 703         (BuildAndPerfTestWebKit1Factory):
 704         (BuildAndPerfTestWebKit1Factory.__init__):
 705         (BuildAndPerfTestFactory):
 706         (BuildAndPerfTestFactory.__init__):
 707         (DownloadAndPerfTestWebKit1Factory):
 708         (DownloadAndPerfTestWebKit1Factory.__init__):
 709         (DownloadAndPerfTestFactory):
 710         (DownloadAndPerfTestFactory.__init__):
 711         (RunWebKitLeakTests): Deleted.
 712         (RunWebKitLeakTests.start): Deleted.
 713         (RunWebKit2Tests): Deleted.
 714         (RunWebKit2Tests.start): Deleted.
 715         (RunAndUploadPerfTestsWebKit2): Deleted.
 716         (RunAndUploadPerfTestsWebKit2.start): Deleted.
 717         (TestLeaksFactory): Deleted.
 718         (TestLeaksFactory.__init__): Deleted.
 719         (TestWebKit2Factory): Deleted.
 720         (TestWebKit2AndJSCFactory): Deleted.
 721         (BuildAndPerfTestWebKit2Factory): Deleted.
 722         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
 723         (DownloadAndPerfTestWebKit2Factory): Deleted.
 724         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
 725         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 726         (parse_args):
 727         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 728         (PerfTestsRunner._parse_args):
 729         * Scripts/webkitpy/port/port_testcase.py:
 730         (PortTestCase.test_build_driver):
 731
 732 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
 733
 734         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
 735         https://bugs.webkit.org/show_bug.cgi?id=140845
 736
 737         Reviewed by David Kilzer.
 738
 739         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
 740         and generate suitable build commands to drive a full build from our
 741         existing solution files.
 742
 743         * Scripts/webkitdirs.pm:
 744         (msBuildInstallDir): Added.
 745         (determineConfigurationForVisualStudio): Revise to use MSBuild command
 746         line arguments to drive the build.
 747         (setupCygwinEnv): Warn user if MSBuild cannot be located.
 748         (buildVisualStudioProject): Revise to use MSBuild command line arguments
 749         to specify build architecture.
 750         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
 751         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
 752         bother looking for CoreUI or SafariTheme build logs.
 753
 754 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
 755
 756         [buildbot] mastercfg_unittest.py should be runnable easily
 757         https://bugs.webkit.org/show_bug.cgi?id=142219
 758
 759         Reviewed by Chris Dumez.
 760
 761         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
 762         the last Twisted version works together with this buildbot version.
 763
 764         * Scripts/webkitpy/common/system/autoinstall.py:
 765         (AutoInstaller): Added prepend_to_search_path argument to be able
 766         to prefer autoinstalled package to system package.
 767         (AutoInstaller.__init__):
 768         (AutoInstaller._set_up_target_dir):
 769         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
 770         (AutoInstaller._prepare_package):
 771         (AutoInstaller._extract_targz): Renamed to _extract_tar.
 772         * Scripts/webkitpy/thirdparty/__init__.py:
 773         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
 774
 775 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
 776
 777         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
 778         https://bugs.webkit.org/show_bug.cgi?id=131162
 779
 780         Reviewed by Gyuyoung Kim.
 781
 782         * MiniBrowser/efl/main.c:
 783         (on_download_request):
 784         (on_download_finished):
 785         (on_download_failed):
 786         (window_create):
 787         Adapt download callbacks to new callback mechanism
 788
 789 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
 790
 791         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
 792
 793         In r180927 we updated the libsoup version used by the jhbuild. In
 794         this new version the sniffer uses image/x-icon instead of
 795         image/vnd.microsoft.icon for blank.ico resource.
 796
 797         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
 798         (testWebResourceMimeType):
 799
 800 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
 801
 802         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
 803         https://bugs.webkit.org/show_bug.cgi?id=142244
 804
 805         Reviewed by Sergio Villar Senin.
 806
 807         Check that the SSL server doesn't process any request in case of
 808         TLS errors when the policy is set to FAIL.
 809
 810         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
 811         (testTLSErrorsPolicy):
 812         (testTLSErrorsRedirect):
 813         (testTLSErrorsHTTPAuth):
 814         (testLoadFailedWithTLSErrors):
 815         (testSubresourceLoadFailedWithTLSErrors):
 816         (httpsServerCallback):
 817
 818 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
 819
 820         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
 821         https://bugs.webkit.org/show_bug.cgi?id=141154
 822
 823         Reviewed by Jer Noble.
 824
 825         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
 826
 827         For the sake of completeness WebKitTestRunner should specify temporary
 828         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
 829
 830         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
 831         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
 832         to get data storage paths. Only Mac port has an actual implementation of it.
 833         However, WebKitTestRunner overrides them in favour of unique temporary dir
 834         which is taken from libraryPathForTesting().
 835
 836         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
 837         is not implemented for EFL and GTK ports it returns an empty string.
 838         All default data folders besides MediaKeys are overridden in TestRunner
 839         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
 840         env variable.
 841
 842         GTK port does not enable encrypted keys by default so
 843         WebMediaKeyStorageManager::initialize() code path is never triggered.
 844
 845         * WebKitTestRunner/TestController.cpp:
 846         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
 847         WebKit ports.
 848
 849 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
 850
 851         [buildbot] Add regression test to check which builder runs which tests
 852         https://bugs.webkit.org/show_bug.cgi?id=142166
 853
 854         Reviewed by Alexey Proskuryakov.
 855
 856         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 857         (BuildStepsConstructorTest.createTest):
 858         (BuildStepsTest):
 859         (BuildStepsTest.generateTests):
 860         (BuildStepsTest.createTest):
 861         (BuildStepsTest.createTest.doTest):
 862         (BuildStepsTest.test_unnecessary_expected_results):
 863
 864 2015-03-04  Commit Queue  <commit-queue@webkit.org>
 865
 866         Unreviewed, rolling out r181054.
 867         https://bugs.webkit.org/show_bug.cgi?id=142320
 868
 869         Broke the api tests (Requested by sundiamonde on #webkit).
 870
 871         Reverted changeset:
 872
 873         "Fix linker warnings in TestWebKitAPI."
 874         https://bugs.webkit.org/show_bug.cgi?id=141912
 875         http://trac.webkit.org/changeset/181054
 876
 877 2015-03-04  Alex Christensen  <achristensen@webkit.org>
 878
 879         Fix linker warnings in TestWebKitAPI.
 880         https://bugs.webkit.org/show_bug.cgi?id=141912
 881
 882         Reviewed by David Kilzer.
 883
 884         * TestWebKitAPI/Configurations/Base.xcconfig:
 885         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
 886
 887 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
 888
 889         [Mac] Set SystemUIFontSelect in DRT and WKTR
 890         https://bugs.webkit.org/show_bug.cgi?id=142303
 891
 892         Reviewed by Myles C. Maxfield.
 893
 894         * DumpRenderTree/mac/DumpRenderTree.mm:
 895         (setDefaultsToConsistentValuesForTesting):
 896         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
 897         (WTR::InjectedBundle::platformInitialize):
 898
 899 2015-03-04  Chris Dumez  <cdumez@apple.com>
 900
 901         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
 902         https://bugs.webkit.org/show_bug.cgi?id=142314
 903         <rdar://problem/20046835>
 904
 905         Reviewed by Ryosuke Niwa.
 906
 907         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
 908         to get WK2 code coverage.
 909
 910         * BuildSlaveSupport/build.webkit.org-config/config.json:
 911
 912 2015-03-04  Alex Christensen  <achristensen@webkit.org>
 913
 914         Move content extensions test to properly named directory.
 915         https://bugs.webkit.org/show_bug.cgi?id=142299
 916
 917         Reviewed by Tim Horton.
 918
 919         * WebKitTestRunner/mac/TestControllerMac.mm:
 920         (WTR::TestController::platformConfigureViewForTest):
 921
 922 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 923
 924         W3C test importer should use filesystem instead of os.walk
 925         https://bugs.webkit.org/show_bug.cgi?id=142085
 926
 927         Reviewed by Bem Jones-Bey.
 928
 929         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
 930         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
 931         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
 932
 933         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
 934         Added a unit test to check that test importer is now black-box testable using a Mock system.
 935
 936         * Scripts/webkitpy/common/system/filesystem.py:
 937         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
 938         (FileSystem.dirs_under.filter_all):
 939         * Scripts/webkitpy/common/system/filesystem_mock.py:
 940         (MockFileSystem.dirs_under):
 941         (MockFileSystem.dirs_under.filter_all):
 942         (MockFileSystem.getsize):
 943         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
 944         (MockFileSystemTest.test_dirs_under):
 945         (MockFileSystemTest.test_dirs_under.filter_dir):
 946         * Scripts/webkitpy/common/system/filesystem_unittest.py:
 947         (RealFileSystemTest.test_sep):
 948         (RealFileSystemTest):
 949         (RealFileSystemTest.test_dirs_under):
 950         (RealFileSystemTest.test_dirs_under.filter_this_dir):
 951         * Scripts/webkitpy/w3c/test_importer.py:
 952         (TestImporter.do_import):
 953         (TestImporter.find_importable_tests.should_keep_subdir):
 954         (TestImporter.find_importable_tests):
 955         (TestImporter.should_keep_subdir): Deleted.
 956         (TestImporter.should_skip_file): Deleted.
 957         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 958         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
 959
 960 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
 961
 962         [WebEditingTester] Add support for the find and replace bar
 963         https://bugs.webkit.org/show_bug.cgi?id=142247
 964
 965         Reviewed by Enrica Casucci.
 966
 967         While it's not hooked up yet in WKWebView, adding support for the
 968         find bar to WebEditingTester will help us implement that functionality.
 969
 970         * WebEditingTester/AppDelegate.h:
 971         * WebEditingTester/AppDelegate.m:
 972         (-[WebEditingAppDelegate performTextFinderAction:]):
 973         * WebEditingTester/MainMenu.xib:
 974         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
 975
 976         * WebEditingTester/WK2WebDocumentController.m:
 977         (-[WK2WebDocumentController awakeFromNib]):
 978         (-[WK2WebDocumentController performTextFinderAction:]):
 979         (-[WK2WebDocumentController findBarView]):
 980         (-[WK2WebDocumentController setFindBarView:]):
 981         (-[WK2WebDocumentController isFindBarVisible]):
 982         (-[WK2WebDocumentController setFindBarVisible:]):
 983         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
 984         (-[WK2WebDocumentController layout]):
 985         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
 986         pointing at the WKWebView (currently nothing will work, but the bar will
 987         show up). Install and uninstall the bar as needed.
 988
 989         * WebEditingTester/WebDocument.xib:
 990         Don't use a full-size content view. There's no need, and it makes find
 991         bar layout harder.
 992
 993         * WebEditingTester/WebDocumentController.h:
 994         * WebEditingTester/WebDocumentController.m:
 995         (-[WebDocumentController performTextFinderAction:]):
 996
 997 2015-03-03  Sam Weinig  <sam@webkit.org>
 998
 999         [Content Extensions] Split parsing and compiling of content extensions into their own files
1000         https://bugs.webkit.org/show_bug.cgi?id=142259
1001
1002         Reviewed by Anders Carlsson.
1003
1004         Add basic unit test for the content filter compiler.
1005
1006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1007         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
1008         (WebCore::ContentExtensions::operator<<):
1009         (TestWebKitAPI::ContentFilterTest::SetUp):
1010         (TestWebKitAPI::TEST_F):
1011
1012 2015-03-04  Matthew Mirman  <mmirman@apple.com>
1013
1014         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
1015         https://bugs.webkit.org/show_bug.cgi?id=142230
1016
1017         Reviewed by Csaba Osztrogonác.
1018
1019         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1020         (TestFactory):
1021         (TestFactory.getProduct): Added
1022         (TestFactory.__init__): moved downloader to getProduct
1023         (BuildAndTestFactory):
1024         (BuildAndTestFactory.getProduct): Added
1025         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
1026         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
1027
1028 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
1029
1030         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
1031         https://bugs.webkit.org/show_bug.cgi?id=142225
1032
1033         Reviewed by Carlos Garcia Campos.
1034
1035         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1036         (testWebViewWebContextLifetime):
1037         (beforeAll):
1038
1039 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1040
1041         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
1042         <http://webkit.org/b/142243>
1043
1044         Reviewed by Alexey Proskuryakov.
1045
1046         * WebKitTestRunner/TestController.cpp:
1047         (WTR::TestController::webProcessName):
1048         (WTR::TestController::networkProcessName):
1049         - Return the same process name on iOS and Mac because they both
1050           use the same process name for local engineering builds.
1051
1052 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1053
1054         check-webkit-style: Add exception for FrameworkSoftLink.h header order
1055         <http://webkit.org/b/141872>
1056
1057         Reviewed by Alex Christensen.
1058
1059         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
1060         semi-colons in various places and fix whitespace.
1061         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
1062         constants.
1063         (_IncludeState.__init__): Add self._visited_soft_link_section
1064         boolean state variable.
1065         (_IncludeState.visited_soft_link_section): Getter for
1066         self._visited_soft_link_section.
1067         (_IncludeState.check_next_include_order): Update state machine
1068         for soft-link headers.  Add check that soft-link headers always
1069         appear last.
1070         (_classify_include): Add check for soft-link header type.
1071         (check_include_line): Return early if there is a soft-link
1072         header error.
1073
1074         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1075         (OrderOfIncludesTest.test_public_primary_header): Add tests for
1076         including soft-link headers.
1077         (OrderOfIncludesTest.test_classify_include): Add test for
1078         _SOFT_LINK_HEADER type.
1079
1080 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
1081
1082         build.webkit.org/dashboard: Don't repeatedly handle each test type
1083         https://bugs.webkit.org/show_bug.cgi?id=142211
1084
1085         Reviewed by Tim Horton and Matt Hanson.
1086
1087         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1088         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
1089         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
1090         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
1091         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
1092         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
1093         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
1094         Removed functions that build a link to test step results. The buildbot provides
1095         these links in JSON.
1096
1097         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1098         (BuildbotIteration): Put failing tests into an array, instead of named variables.
1099         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
1100         We can easily add them to the map as needed.
1101         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
1102         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
1103         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
1104         and then build a BuildbotTestResults object, which was strange.
1105         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
1106
1107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1108         Corrected an unrelated assertion that was buggy, and kept firing.
1109
1110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1111         (BuildbotTestResults):
1112         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1113         (BuildbotTestResults.prototype._parseResults):
1114         (BuildbotTestResults.prototype.addFullLayoutTestResults):
1115         Moved the code for parsing JSON results for a single step here.
1116
1117         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1118         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
1119         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
1120         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1121         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
1122         (BuildbotTesterQueueView.prototype.update): Deleted.
1123         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
1124         Updated for the new data structures. One behavior change is that we now display individual
1125         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
1126         test failures, 3 platform api test failures".
1127
1128 2015-03-03  Matthew Mirman  <mmirman@apple.com>
1129
1130         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
1131         https://bugs.webkit.org/show_bug.cgi?id=142094
1132
1133         Reviewed by Csaba Osztrogonác.
1134
1135         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
1136         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1137         (TestFactory):
1138         (TestFactory.__init__): Made running of JSC tests conditional.
1139         (TestAllButJSCFactory):
1140         (TestJSCFactory): Added.
1141         (TestJSCFactory.__init__):
1142         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
1143
1144 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1145
1146         `build-webkit --help` is wrong about how to build for the iOS simulator
1147         <http://webkit.org/b/142223>
1148
1149         Reviewed by Csaba Osztrogonác.
1150
1151         * Scripts/build-webkit: Fix help.
1152
1153 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1154
1155         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
1156
1157         * gtk/jhbuild.modules:
1158
1159 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1160
1161         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
1162         https://bugs.webkit.org/show_bug.cgi?id=141508
1163
1164         Reviewed by Sergio Villar Senin.
1165
1166         Add a unit test to check that synchronous XHRs load even if the
1167         maximum connection limits are reached.
1168
1169         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1170         (testWebViewSyncRequestOnMaxConns):
1171         (serverCallback):
1172         (beforeAll):
1173         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
1174
1175 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
1176
1177         Update the name of ASan build step.
1178
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1180
1181 2015-03-02  Jer Noble  <jer.noble@apple.com>
1182
1183         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1184         https://bugs.webkit.org/show_bug.cgi?id=142121
1185
1186         Reviewed by Simon Fraser.
1187
1188         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
1189         that the initial and final screen rects for the web content are as expected.
1190
1191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1192         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
1193         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
1194         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1195         (runJavaScriptAlert):
1196         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1197         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
1198         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
1199         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
1200         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
1201         (TestWebKitAPI::TEST_F):
1202
1203 2015-03-01  David Kilzer  <ddkilzer@apple.com>
1204
1205         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
1206
1207         Follow-up fix for:
1208
1209         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1210         <http://webkit.org/b/142145>
1211
1212         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1213         (-[LTRelayController _environmentVariables]): Fix think-o.
1214
1215 2015-03-01  David Kilzer  <ddkilzer@apple.com>
1216
1217         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1218         <http://webkit.org/b/142145>
1219
1220         Reviewed by Simon Fraser.
1221
1222         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1223         (-[LTRelayController _environmentVariables]): Add.
1224         (-[LTRelayController launchApp]): Use -_environmentVariables.
1225
1226 2015-02-28  David Kilzer  <ddkilzer@apple.com>
1227
1228         [iOS] Stop running webkit-build-directory on every layout test
1229
1230         This was originally fixed by David Farler for Bug 135409 in
1231         r172602.
1232
1233         * Scripts/webkitpy/port/ios.py:
1234         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
1235         run webkit-build-directory every time it's called.
1236
1237 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1238
1239         W3C importer should use filesystem instead of shutil/host
1240         https://bugs.webkit.org/show_bug.cgi?id=142012
1241
1242         Reviewed by Bem Jones-Bey.
1243
1244         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
1245
1246         * Scripts/webkitpy/w3c/test_importer.py:
1247         (main):
1248         (TestImporter.do_import):
1249         (TestImporter.find_importable_tests):
1250         (TestImporter.import_tests):
1251         (TestImporter.remove_deleted_files):
1252         (TestImporter.write_import_log):
1253
1254 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1255
1256         W3C test importer should use filesystem to read and write files
1257         https://bugs.webkit.org/show_bug.cgi?id=142084
1258
1259         Reviewed by Bem Jones-Bey.
1260
1261         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
1262
1263         * Scripts/webkitpy/w3c/test_importer.py:
1264         (TestImporter.import_tests):
1265         (TestImporter.remove_deleted_files):
1266         (TestImporter.write_import_log):
1267
1268 2015-02-27  Sam Weinig  <sam@webkit.org>
1269
1270         Add WebKit2 SPI to create a DOM File object
1271         https://bugs.webkit.org/show_bug.cgi?id=142109
1272
1273         Reviewed by Tim Horton.
1274
1275         Add a test for WKBundleFileHandleRef.
1276
1277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1278         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
1279         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1280         (TestWebKitAPI::didFinishLoadForFrame):
1281         (TestWebKitAPI::TEST):
1282         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
1283         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
1284         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
1285
1286 2015-02-27  Michael Saboff  <msaboff@apple.com>
1287
1288         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
1289         https://bugs.webkit.org/show_bug.cgi?id=142112
1290
1291         Reviewed by Filip Pizlo.
1292
1293         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
1294         <someDir> as the library path.
1295
1296         * Scripts/run-jsc-benchmarks:
1297
1298 2015-02-27  Alex Christensen  <achristensen@webkit.org>
1299
1300         [WinCairo] Unreviewed build fix.
1301
1302         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1303         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
1304
1305 2015-02-27  Anders Carlsson  <andersca@apple.com>
1306
1307         Add infrastructure for handling website data in the network process
1308         https://bugs.webkit.org/show_bug.cgi?id=142092
1309
1310         Reviewed by Andreas Kling.
1311
1312         Add a menu item that will fetch all website data, delete the returned data records, and
1313         fetch all website data again so we can confirm that it's all empty.
1314
1315         * MiniBrowser/mac/WK2BrowserWindowController.m:
1316         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1317
1318 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1319
1320         [Win] Remove remaining SafariTheme cruft
1321         https://bugs.webkit.org/show_bug.cgi?id=142075
1322
1323         Reviewed by Anders Carlsson.
1324
1325         Remove reference to SafariTheme-switching preference.
1326
1327         * DumpRenderTree/win/DumpRenderTree.cpp:
1328         (resetWebPreferencesToConsistentValues):
1329         (prepareConsistentTestingEnvironment):
1330
1331 2015-02-26  Doug Russell  <d_russell@apple.com>
1332
1333         AX: Expose caret browsing preference to accessibility API
1334         https://bugs.webkit.org/show_bug.cgi?id=141862
1335
1336         Reviewed by Chris Fleizach.
1337
1338         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
1339         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
1340
1341         * DumpRenderTree/AccessibilityUIElement.cpp:
1342         (setBoolAttributeValueCallback):
1343         (selectedTextMarkerRangeCallback):
1344         (resetSelectedTextMarkerRangeCallback):
1345         (AccessibilityUIElement::setBoolAttributeValue):
1346         (AccessibilityUIElement::selectedTextMarkerRange):
1347         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1348         (AccessibilityUIElement::getJSClass):
1349         * DumpRenderTree/AccessibilityUIElement.h:
1350         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1351         (AccessibilityUIElement::setBoolAttributeValue):
1352         (AccessibilityUIElement::selectedTextMarkerRange):
1353         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1354         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1355         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1356         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1357         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1358         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1359         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1360         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1361         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1362         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1363         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1364
1365 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1366
1367         [Win] Remove WebKitExportGenerator project (and related)
1368         https://bugs.webkit.org/show_bug.cgi?id=142035
1369
1370         Reviewed by Dean Jackson.
1371
1372         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
1373         build log from WebKitExportGenerator.
1374
1375 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
1376
1377         [EFL] Bump EFL version to 1.13.0
1378         https://bugs.webkit.org/show_bug.cgi?id=141708
1379
1380         Reviewed by Gyuyoung Kim.
1381
1382         * efl/jhbuild.modules:
1383
1384 2015-02-26  Sam Weinig  <sam@webkit.org>
1385
1386         Check in missing WebEditingTester.xcconfig file.
1387
1388         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
1389
1390 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
1391
1392         [webkitpy] Remove skipped file related crufts
1393         https://bugs.webkit.org/show_bug.cgi?id=142046
1394
1395         Reviewed by Ryosuke Niwa.
1396
1397         * Scripts/webkitpy/port/base.py:
1398         (Port.skipped_layout_tests):
1399         (Port._tests_from_skipped_file_contents): Deleted.
1400         (Port): Deleted.
1401         (Port._expectations_from_skipped_files): Deleted.
1402         * Scripts/webkitpy/port/mac_unittest.py:
1403         (MacTest.test_default_timeout_ms):
1404         (MacTest): Deleted.
1405         (test_tests_from_skipped_file_contents): Deleted.
1406
1407 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1408
1409         [Win] Unreviewed WinCairo build fix after r180653.
1410
1411         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
1412
1413         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1414         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1415         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1416         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
1417         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
1418
1419 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
1420
1421         [Win] Use WEBCORE_EXPORT instead of Definition file
1422         https://bugs.webkit.org/show_bug.cgi?id=141734
1423
1424         Reviewed by Alex Christensen.
1425
1426         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1427         Use a precompiled header so we can define our export macros properly.
1428         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1429         Visual studio automatic update stuff.
1430         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1431         Set up Precompiled Header use for project..
1432         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
1433         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
1434         declarations for building DumpRenderTree as a client of
1435         WebCore/WebKit.
1436
1437 2015-02-25  Mark Lam  <mark.lam@apple.com>
1438
1439         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
1440         <https://webkit.org/b/141672>
1441
1442         Reviewed by Alexey Proskuryakov.
1443
1444         ASan does not like the fact that we memcpy the stack for GC scans.  So,
1445         we're working around this by using our own memcpy (asanUnsafeMemcpy)
1446         implementation that we can tell ASan to ignore.
1447
1448         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
1449         which isn't effective for working around this issue.
1450
1451         * asan/webkit-asan-ignore.txt:
1452
1453 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
1454
1455         CodeBlock crashes when dumping op_push_name_scope
1456         https://bugs.webkit.org/show_bug.cgi?id=141953
1457
1458         Reviewed by Filip Pizlo.
1459
1460         * Scripts/run-jsc-stress-tests:
1461
1462 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1463
1464         W3C test importer should use argparse instead of optparse
1465         https://bugs.webkit.org/show_bug.cgi?id=142013
1466
1467         Reviewed by Bem Jones-Bey.
1468
1469         * Scripts/webkitpy/w3c/test_importer.py:
1470         (main): Updating according argparse.
1471         (parse_args): Moving from optparse to argparse.
1472
1473 2015-02-25  Brady Eidson  <beidson@apple.com>
1474
1475         Get rid of TestInvocation::pathOrURL
1476         https://bugs.webkit.org/show_bug.cgi?id=142021
1477
1478         Reviewed by Tim Horton.
1479
1480         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
1481         but most code that uses it expected an absolute path.
1482
1483         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
1484
1485         * WebKitTestRunner/TestController.cpp:
1486         (WTR::TestController::updateWebViewSizeForTest):
1487         (WTR::TestController::updateWindowScaleForTest):
1488         (WTR::shouldUseFixedLayout):
1489         (WTR::TestController::updateLayoutTypeForTest):
1490
1491         * WebKitTestRunner/TestInvocation.cpp:
1492         (WTR::TestInvocation::TestInvocation):
1493         (WTR::TestInvocation::urlContains):
1494         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1495         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1496         (WTR::TestInvocation::invoke):
1497         (WTR::shouldLogFrameLoadDelegates): Deleted.
1498         (WTR::shouldLogHistoryClientCallbacks): Deleted.
1499         * WebKitTestRunner/TestInvocation.h:
1500         (WTR::TestInvocation::pathOrURL): Deleted.
1501
1502         * WebKitTestRunner/ios/TestControllerIOS.mm:
1503         (WTR::shouldMakeViewportFlexible):
1504         (WTR::TestController::platformConfigureViewForTest):
1505
1506         * WebKitTestRunner/mac/TestControllerMac.mm:
1507         (WTR::shouldUseThreadedScrolling):
1508         (WTR::TestController::platformConfigureViewForTest):
1509
1510 2015-02-25  Brady Eidson  <beidson@apple.com>
1511
1512         Layout test support for user content filters
1513         https://bugs.webkit.org/show_bug.cgi?id=142018
1514
1515         Reviewed by Tim Horton.
1516
1517         * WebKitTestRunner/TestController.cpp:
1518         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
1519
1520         * WebKitTestRunner/mac/TestControllerMac.mm:
1521         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
1522           file before loading the test itself.
1523
1524 2015-02-24  Sam Weinig  <sam@webkit.org>
1525
1526         Convert WebEditingTester to use xcconfig files
1527         https://bugs.webkit.org/show_bug.cgi?id=141879
1528
1529         Reviewed by Darin Adler.
1530
1531         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
1532
1533         * WebEditingTester/Configurations: Added.
1534         * WebEditingTester/Configurations/Base.xcconfig: Added.
1535         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
1536         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1537
1538 2015-02-24  Andy Estes  <aestes@apple.com>
1539
1540         Teach MiniBrowser how to disable per-window web processes
1541         https://bugs.webkit.org/show_bug.cgi?id=141988
1542
1543         Reviewed by Darin Adler.
1544
1545         * MiniBrowser/mac/AppDelegate.m:
1546         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
1547         * MiniBrowser/mac/SettingsController.h:
1548         * MiniBrowser/mac/SettingsController.m:
1549         (-[SettingsController _populateMenu]): Added a new Settings menu item.
1550         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
1551         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
1552         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
1553
1554 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
1555
1556         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
1557         https://bugs.webkit.org/show_bug.cgi?id=141889
1558
1559         Reviewed by Darin Adler.
1560
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1562
1563 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1564
1565         REGRESSION(r179429): Can't type comments in Facebook
1566         https://bugs.webkit.org/show_bug.cgi?id=141859
1567
1568         Reviewed by Brent Fulgham.
1569
1570         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1571
1572         * DumpRenderTree/mac/DumpRenderTree.mm:
1573         (resetWebPreferencesToConsistentValues):
1574         * DumpRenderTree/win/DumpRenderTree.cpp:
1575         (resetWebPreferencesToConsistentValues):
1576         * WebKitTestRunner/TestController.cpp:
1577         (WTR::TestController::resetPreferencesToConsistentValues):
1578
1579 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1580
1581         Crash loading local file with WebPageProxy::loadAlternateHTMLString
1582         https://bugs.webkit.org/show_bug.cgi?id=141867
1583
1584         Reviewed by Anders Carlsson.
1585
1586         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1587         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
1588         be shared with the new test.
1589         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
1590         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
1591         (testLoadAlternateHTMLForLocalPage):
1592         (beforeAll):
1593
1594 2015-02-24  David Kilzer  <ddkilzer@apple.com>
1595
1596         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
1597         <http://webkit.org/b/141900>
1598
1599         Reviewed by Myles C. Maxfield.
1600
1601         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1602         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
1603         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
1604         - Rename to share code with iOS.
1605         - Add USE(APPKIT) around AppKit-specific headers and code.
1606         - Fix a check-webkit-style warning.
1607         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
1608         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1609         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
1610         - Remove ios/ActivateFontsIOS.mm.
1611         - Fix InjectedBundle/cocoa group to represent the directory on
1612           disk.  Includes a change to InjectedBundlePageCocoa.mm.
1613
1614 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1615
1616         Unreviewed, rolling out r180547 and r180550.
1617         https://bugs.webkit.org/show_bug.cgi?id=141957
1618
1619         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1620
1621         Reverted changesets:
1622
1623         "REGRESSION(r179429): Can't type comments in Facebook"
1624         https://bugs.webkit.org/show_bug.cgi?id=141859
1625         http://trac.webkit.org/changeset/180547
1626
1627         "Constructor returning null should construct an object instead
1628         of null"
1629         https://bugs.webkit.org/show_bug.cgi?id=141640
1630         http://trac.webkit.org/changeset/180550
1631
1632 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1633
1634         REGRESSION(r179429): Can't type comments in Facebook
1635         https://bugs.webkit.org/show_bug.cgi?id=141859
1636
1637         Reviewed by Geoffrey Garen.
1638
1639         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1640
1641         * DumpRenderTree/mac/DumpRenderTree.mm:
1642         (resetWebPreferencesToConsistentValues):
1643         * WebKitTestRunner/TestController.cpp:
1644         (WTR::TestController::resetPreferencesToConsistentValues):
1645
1646 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
1647
1648         [EFL] fix eo errors
1649         https://bugs.webkit.org/show_bug.cgi?id=141909
1650
1651         Reviewed by Gyuyoung Kim.
1652
1653         Fix eo errors that occur whenever minibrowser is launched.
1654         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
1655         - elm_obj_win_resize_object_add's first parameter should be elm_win
1656
1657         * MiniBrowser/efl/main.c:
1658         (window_create):
1659
1660 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1661
1662         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
1663
1664         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1665         (TestWebKitAPI::TEST):
1666
1667 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
1668
1669         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
1670         https://bugs.webkit.org/show_bug.cgi?id=141935
1671
1672         Reviewed by Myles C. Maxfield.
1673
1674         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1675         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
1676         tests for assigning from nullptr.
1677
1678 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
1679
1680         WTF::WeakPtr should have a 'forget' method.
1681         https://bugs.webkit.org/show_bug.cgi?id=141923
1682
1683         Reviewed by Myles C. Maxfield.
1684
1685         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1686         (TestWebKitAPI::TEST): Added 'Forget' tests case.
1687
1688 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1689
1690         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
1691         https://bugs.webkit.org/show_bug.cgi?id=141920
1692
1693         Reviewed by Tim Horton.
1694
1695         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1696         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1697         Do the same thing as we do for regular green bubbles.
1698
1699 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1700
1701         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
1702         https://bugs.webkit.org/show_bug.cgi?id=141925
1703
1704         Reviewed by Tim Horton.
1705
1706         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1707         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1708
1709 2015-02-23  Anders Carlsson  <andersca@apple.com>
1710
1711         Add API for fetching website data records to _WKWebsiteDataStore
1712         https://bugs.webkit.org/show_bug.cgi?id=141926
1713
1714         Reviewed by Beth Dakin.
1715
1716         * MiniBrowser/mac/MainMenu.xib:
1717         * MiniBrowser/mac/WK2BrowserWindowController.m:
1718         (-[WK2BrowserWindowController fetchWebsiteData:]):
1719         Add menu item to fetch and dump website data.
1720
1721 2015-02-23  David Kilzer  <ddkilzer@apple.com>
1722
1723         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
1724         <http://webkit.org/b/141884>
1725
1726         Reviewed by Alexey Proskuryakov.
1727
1728         * Scripts/webkitpy/port/leakdetector.py:
1729         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
1730         snowleopard, lion and older leaks.  Add known leak for
1731         mavericks, but check Port.operating_system before calling
1732         Port.is_mavericks.
1733         * Scripts/webkitpy/port/mac.py:
1734         (MacPort.is_snowleopard): Delete.
1735         (MacPort.is_lion): Delete.
1736         (MacPort.is_mavericks): Add.
1737
1738 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1739
1740         build.webkit.org/dashboard should filter out commits to other branches
1741         https://bugs.webkit.org/show_bug.cgi?id=140362
1742
1743         Reviewed by Tim Horton.
1744
1745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1746         (BuildbotQueue):
1747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1748         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
1749         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1750         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
1751         (BuildbotQueueView.prototype.revisionContentForIteration):
1752         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
1753         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
1754         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
1755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1756         (Trac.prototype.get oldestRecordedRevisionNumber):
1757         (Trac.prototype.commitsOnBranch):
1758         (Trac.prototype._xmlTimelineURL):
1759         (Trac.prototype._convertCommitInfoElementToObject):
1760         (Trac.prototype._update):
1761         (Trac.prototype.startPeriodicUpdates):
1762         (Trac.prototype.loadMoreHistoricalData):
1763         (Trac.prototype.update): Deleted.
1764
1765 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1766
1767         Tests don't work on some bots: Failed to stop wptwk
1768         https://bugs.webkit.org/show_bug.cgi?id=141235
1769
1770         Reviewed by Ryosuke Niwa.
1771
1772         Logging of server subprocesses in launcher script.
1773         Killing of server subprocesses when stopping/before starting.
1774         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
1775
1776         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1777         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
1778         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1779         (WebPlatformTestServer.__init__):
1780         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
1781         (WebPlatformTestServer):
1782         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
1783         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
1784         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1785         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
1786         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
1787         (TestWebPlatformTestServer):
1788         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
1789
1790 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1791
1792         [WebEditingTester] Allow dropping HTML files on the app
1793         https://bugs.webkit.org/show_bug.cgi?id=141834
1794
1795         Reviewed by Simon Fraser.
1796
1797         * WebEditingTester/AppDelegate.m:
1798         (-[WebEditingAppDelegate openDocument:]):
1799         (-[WebEditingAppDelegate application:openFile:]):
1800         Implement application:openFile:, factoring file loading code out of openDocument.
1801
1802         * WebEditingTester/Info.plist:
1803         Register as an editor for HTML files.
1804
1805         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1806         Enrica is not an organization.
1807
1808 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1809
1810         [WebEditingTester] Expand "WK" to "WebKit" in a few places
1811         https://bugs.webkit.org/show_bug.cgi?id=141833
1812
1813         Reviewed by Anders Carlsson.
1814
1815         * WebEditingTester/AppDelegate.h:
1816         * WebEditingTester/AppDelegate.m:
1817         (-[WebEditingAppDelegate newEditor:]):
1818         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
1819         (-[WebEditingAppDelegate validateMenuItem:]):
1820         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1821         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
1822         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
1823         (-[WebEditingAppDelegate showOperations:]): Deleted.
1824         * WebEditingTester/MainMenu.xib:
1825         The WK abbreviation is unnaturally grating in menu items for some reason.
1826
1827 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1828
1829         [WebEditingTester] Add a custom protocol for loading canned content
1830         https://bugs.webkit.org/show_bug.cgi?id=141830
1831
1832         Reviewed by Enrica Casucci.
1833
1834         Add a canned:// protocol handler, which can be used to emulate behaviors
1835         in WebKit client apps (like Mail) that use custom protocol handlers,
1836         which can have important effects on editing (mostly, the URLs are only
1837         valid inside of the client application, but not when copied/dragged out).
1838
1839         For now, we only support two canned files:
1840
1841             canned://dice is a PNG of dice (stolen from LayoutTests/)
1842             canned://text is the string "canned text" served as text/html
1843
1844         In the future we could support things like very large (generated) files,
1845         progressive loading, etc. to further simulate conditions in other apps.
1846
1847         * WebEditingTester/AppDelegate.m:
1848         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1849         Register the protocol with CFNetwork, and the scheme with WebKit2.
1850
1851         * WebEditingTester/Canned Content/dice.png: Added.
1852         * WebEditingTester/CannedContent.h: Added.
1853         * WebEditingTester/CannedContent.m: Added.
1854         (-[CannedContent initWithRequest:cachedResponse:client:]):
1855         (+[CannedContent canonicalRequestForRequest:]):
1856         (+[CannedContent canInitWithRequest:]):
1857         We only want to handle canned:// URLs.
1858
1859         (-[CannedContent startLoading]):
1860         For now, immediately load the two files we know about.
1861         Otherwise, immediately fail the load.
1862
1863         (-[CannedContent stopLoading]):
1864         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1865
1866 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1867
1868         [WebEditingTester] Implement an open panel
1869         https://bugs.webkit.org/show_bug.cgi?id=141829
1870
1871         Reviewed by Simon Fraser.
1872
1873         * WebEditingTester/AppDelegate.m:
1874         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
1875         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
1876         (-[WebEditingAppDelegate openDocument:]):
1877         Add an open panel (with radio buttons to pick which WebKit to open with).
1878         Loads the file as an HTML string.
1879
1880 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
1881
1882         [WebEditingTester] @properties, dot syntax, and remember the window position
1883         https://bugs.webkit.org/show_bug.cgi?id=141843
1884
1885         Reviewed by Tim Horton.
1886
1887         Modernize a bit with more dot syntax, use @property for the web views,
1888         and give the main window an Autosave name so it remembers the widow position.
1889
1890         * WebEditingTester/WK1WebDocumentController.m:
1891         (-[WK1WebDocumentController awakeFromNib]):
1892         (-[WK1WebDocumentController loadHTMLString:]):
1893         * WebEditingTester/WK2WebDocumentController.m:
1894         (-[WK2WebDocumentController awakeFromNib]):
1895         * WebEditingTester/WebDocument.xib:
1896
1897 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1898
1899         [WebEditingTester] Hook up key equivalents for new window action
1900         https://bugs.webkit.org/show_bug.cgi?id=141828
1901
1902         Reviewed by Enrica Casucci.
1903
1904         * WebEditingTester/AppDelegate.h:
1905         * WebEditingTester/AppDelegate.m:
1906         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1907         (-[WebEditingAppDelegate newEditor:]):
1908         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
1909         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
1910         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1911         (defaultConfiguration): Deleted.
1912         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
1913         Move WKWebViewConfiguration setup into WK2WebDocumentController.
1914         Remove unused application termination code.
1915         Update new-window menu item key equivalents when launching and when
1916         changing the use-WebKit2-by-default setting.
1917         Make WebDocumentController subclasses all initialized the same way,
1918         and use that to factor out alloc/init.
1919         Rename loadContent to loadHTMLString for future use.
1920
1921         * WebEditingTester/MainMenu.xib:
1922         Add default key equivalents.
1923         Cmd-N will always make the default kind of window (controlled by the pref).
1924         Cmd-Opt-N will always make the other kind.
1925         The menu items are configured as alternates so they only show up if you
1926         press alt (just like in MiniBrowser).
1927
1928         * WebEditingTester/WK1WebDocumentController.m:
1929         (-[WK1WebDocumentController loadHTMLString:]):
1930         (-[WK1WebDocumentController loadContent]): Deleted.
1931         * WebEditingTester/WK2WebDocumentController.h:
1932         * WebEditingTester/WK2WebDocumentController.m:
1933         (defaultConfiguration):
1934         (-[WK2WebDocumentController awakeFromNib]):
1935         (-[WK2WebDocumentController loadHTMLString:]):
1936         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
1937         (-[WK2WebDocumentController dealloc]): Deleted.
1938         * WebEditingTester/WebDocumentController.h:
1939         * WebEditingTester/WebDocumentController.m:
1940         (-[WebDocumentController init]):
1941         (-[WebDocumentController initWithWindow:]):
1942         (+[WebDocumentController defaultEditingSource]):
1943         (-[WebDocumentController loadHTMLString:]):
1944         (-[WebDocumentController windowDidLoad]): Deleted.
1945         (-[WebDocumentController defaultEditingSource]): Deleted.
1946         (-[WebDocumentController applicationTerminating]): Deleted.
1947         (-[WebDocumentController loadContent]): Deleted.
1948
1949 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1950
1951         [WebEditingTester] ARC-ify WebEditingTester
1952         https://bugs.webkit.org/show_bug.cgi?id=141827
1953
1954         Reviewed by Sam Weinig.
1955
1956         * WebEditingTester/AppDelegate.m:
1957         (-[WebEditingAppDelegate showOperations:]):
1958         * WebEditingTester/EditingOperations.m:
1959         (editingOperations):
1960         * WebEditingTester/WK1WebDocumentController.m:
1961         (-[WK1WebDocumentController dealloc]): Deleted.
1962         * WebEditingTester/WK2WebDocumentController.m:
1963         (-[WK2WebDocumentController dealloc]): Deleted.
1964         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1965         Turn on ARC and remove a few retain/release/autorelease calls.
1966         We don't need to implement dealloc in either document controller
1967         because WebView and WKWebView's UIDelegate property does not hold a
1968         strong reference.
1969
1970 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1971
1972         [WebEditingTester] Factor out list of editing operations
1973         https://bugs.webkit.org/show_bug.cgi?id=141826
1974
1975         Reviewed by Sam Weinig.
1976
1977         * WebEditingTester/AppDelegate.m:
1978         (-[WebEditingAppDelegate showOperations:]):
1979         * WebEditingTester/EditingOperations.h: Added.
1980         * WebEditingTester/EditingOperations.m: Added.
1981         (editingOperations):
1982         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1983         Move EditingOperations array to its own file, and make it an NSArray
1984         instead of a C array. Adjust accordingly in showOperations:.
1985
1986 2015-02-20  Michael Saboff  <msaboff@apple.com>
1987
1988         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
1989         https://bugs.webkit.org/show_bug.cgi?id=141676
1990
1991         Reviewed by Filip Pizlo.
1992
1993         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
1994         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
1995         large string expression that we want to eval.
1996
1997         * Scripts/run-jsc-stress-tests:
1998
1999 2015-02-19  Daniel Bates  <dabates@apple.com>
2000
2001         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
2002         https://bugs.webkit.org/show_bug.cgi?id=141815
2003         <rdar://problem/19893933>
2004
2005         Reviewed by Simon Fraser.
2006
2007         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
2008         was booted by iOS Simulator in a previous run of run-webkit-test.
2009
2010         * Scripts/webkitpy/port/ios.py:
2011         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
2012         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
2013         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
2014
2015 2015-02-19  David Kilzer  <ddkilzer@apple.com>
2016
2017         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
2018         <http://webkit.org/b/141799>
2019
2020         Reviewed by Alex Christensen.
2021
2022         * Scripts/webkitpy/style/checkers/cpp.py:
2023         (_IncludeState.check_next_include_order): Don't emit a warning
2024         if the primary header exists and the source file name ends with
2025         "SoftLink.cpp".  Add 'filename' argument to method.
2026         (check_include_line): Pass in 'filename'.
2027
2028         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2029         (OrderOfIncludesTest.test_check_next_include_order__no_config):
2030         (OrderOfIncludesTest.test_check_next_include_order__no_self):
2031         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
2032         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
2033         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
2034         - Add test filename arguments for calls to
2035           check_next_include_order().
2036         (OrderOfIncludesTest.test_primary_header): Add test for a file
2037         name ending in "SoftLink.cpp".
2038
2039 2015-02-18  Enrica Casucci  <enrica@apple.com>
2040
2041         Add new tool to test editable Webviews.
2042         https://bugs.webkit.org/show_bug.cgi?id=141772
2043
2044         Reviewed by Tim Horton.
2045
2046         Adding WebEditingTester, a Cocoa application to
2047         test WK1 and Wk2 views in editable mode.
2048
2049         * WebEditingTester: Added.
2050         * WebEditingTester/AppDelegate.h: Added.
2051         * WebEditingTester/AppDelegate.m: Added.
2052         (-[WebEditingAppDelegate init]):
2053         (defaultConfiguration):
2054         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2055         (-[WebEditingAppDelegate applicationWillTerminate:]):
2056         (-[WebEditingAppDelegate newEditor:]):
2057         (-[WebEditingAppDelegate showOperations:]):
2058         (-[WebEditingAppDelegate useWebKit2ByDefault]):
2059         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2060         (-[WebEditingAppDelegate validateMenuItem:]):
2061         * WebEditingTester/Info.plist: Added.
2062         * WebEditingTester/MainMenu.xib: Added.
2063         * WebEditingTester/WK1WebDocumentController.h: Added.
2064         * WebEditingTester/WK1WebDocumentController.m: Added.
2065         (-[WK1WebDocumentController awakeFromNib]):
2066         (-[WK1WebDocumentController loadContent]):
2067         (-[WK1WebDocumentController dealloc]):
2068         (-[WK1WebDocumentController pasteAsMarkup:]):
2069         * WebEditingTester/WK2WebDocumentController.h: Added.
2070         * WebEditingTester/WK2WebDocumentController.m: Added.
2071         (-[WK2WebDocumentController initWithConfiguration:]):
2072         (-[WK2WebDocumentController pasteAsMarkup:]):
2073         (-[WK2WebDocumentController awakeFromNib]):
2074         (-[WK2WebDocumentController dealloc]):
2075         (-[WK2WebDocumentController loadContent]):
2076         * WebEditingTester/WebDocument.xib: Added.
2077         * WebEditingTester/WebDocumentController.h: Added.
2078         * WebEditingTester/WebDocumentController.m: Added.
2079         (-[WebDocumentController initWithWindow:]):
2080         (-[WebDocumentController windowDidLoad]):
2081         (-[WebDocumentController defaultEditingSource]):
2082         (-[WebDocumentController applicationTerminating]):
2083         (-[WebDocumentController loadContent]):
2084         * WebEditingTester/WebEditingTester.xcodeproj: Added.
2085         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
2086         * WebEditingTester/main.m: Added.
2087         (main):
2088
2089 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
2090
2091         Run JSC tests on ARM EFL bots
2092         https://bugs.webkit.org/show_bug.cgi?id=141165
2093
2094         Reviewed by Alexey Proskuryakov.
2095
2096         * BuildSlaveSupport/build.webkit.org-config/config.json:
2097         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2098         (RunJavaScriptCoreTests.countFailures):
2099         (RunRemoteJavaScriptCoreTests):
2100         (RunRemoteJavaScriptCoreTests.start):
2101         (BuildAndRemoteJSCTestsFactory):
2102         (BuildAndRemoteJSCTestsFactory.__init__):
2103
2104 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
2105
2106         Streamline unexported function build fixes
2107         https://bugs.webkit.org/show_bug.cgi?id=141761
2108
2109         Reviewed by Alex Christensen.
2110
2111         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
2112         We don't need to ignore symbols that are not exported due to the .unexp file.
2113
2114 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
2115
2116         Remove more references to WebCore.exp.in
2117         https://bugs.webkit.org/show_bug.cgi?id=141747
2118
2119         Reviewed by Alexey Proskuryakov.
2120
2121         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2122         (ShouldBuildTest):
2123
2124 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
2125
2126         Windows test results should not fall back to mac-mountainlion after r180176
2127         https://bugs.webkit.org/show_bug.cgi?id=141719
2128
2129         Reviewed by Brent Fulgham.
2130
2131         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2132         (_should_file_trigger_build):
2133         * Scripts/webkitpy/port/win.py:
2134         (WinPort.default_baseline_search_path):
2135         * Scripts/webkitpy/port/win_unittest.py:
2136         (WinPortTest.test_baseline_search_path):
2137
2138 2015-02-17  Daniel Bates  <dabates@apple.com>
2139
2140         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
2141         https://bugs.webkit.org/show_bug.cgi?id=141718
2142
2143         Reviewed by Alex Christensen.
2144
2145         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
2146
2147         * Scripts/webkitpy/port/ios.py:
2148         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
2149         Log a error and return False if we are unable to boot the simulator device so that the caller can take
2150         appropriate action, say exit(3) before running any layout tests.
2151         * Scripts/webkitpy/xcode/simulator.py:
2152         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
2153         with the specified UDID.
2154         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
2155         with the specified UDID can successfully boot and shut down. We make at most two attempts to
2156         boot and shut down the device, erasing the device between tries so as to restore the device
2157         to a known good state.
2158
2159 2015-02-17  Daniel Bates  <dabates@apple.com>
2160
2161         run_webkit_tests.py should not know about iOS Simulator details
2162         https://bugs.webkit.org/show_bug.cgi?id=141711
2163
2164         Reviewed by Alex Christensen.
2165
2166         Run_webkit_tests.py should only parse the iOS-specific command
2167         line options --runtime and --device-type. Let the port-specific
2168         logic in ios.py validate the parsed options and instantiate
2169         internal data structures.
2170
2171         Currently run_webkit_tests.py parses the iOS-specific command
2172         line options --runtime and --device-type, validates them, and
2173         instantiates internal data structures from the parsed strings.
2174         Instead the validation logic and instantiation of internal
2175         data structures should be handled by the iOS port object.
2176
2177         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2178         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
2179         and instantiate internal data structures for them.
2180         * Scripts/webkitpy/port/driver.py:
2181         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
2182         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
2183         respectively.
2184         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
2185         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
2186         object from --runtime, if specified. Otherwise, instantiates a Runtime
2187         object for the latest installed iphonesimulator SDK version.
2188         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
2189         object from --device-type, if specified. Otherwise, instantiates
2190         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
2191         machine, respectively.
2192         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
2193         runtime is available to use.
2194         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
2195         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
2196         * Scripts/webkitpy/xcode/simulator.py:
2197         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
2198         with a runtime identifier for the specified iOS version.
2199
2200 2015-02-17  Dana Burkart  <dburkart@apple.com>
2201
2202         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
2203         https://bugs.webkit.org/show_bug.cgi?id=141672
2204
2205         Reviewed by David Kilzer.
2206
2207         * asan/webkit-asan-ignore.txt:
2208
2209 2015-02-17  Alex Christensen  <achristensen@webkit.org>
2210
2211         Remove WebCore.exp.in and clean up.
2212         https://bugs.webkit.org/show_bug.cgi?id=141491
2213
2214         Reviewed by Andreas Kling.
2215
2216         * Scripts/sort-export-file: Removed.
2217         * Scripts/webkitpy/style/checker.py:
2218         (_all_categories):
2219         (FileType):
2220         (CheckerDispatcher._file_type):
2221         (CheckerDispatcher._create_checker):
2222         Don't check if the export files are sorted.
2223         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
2224         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
2225
2226 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2227
2228         Unreviewed. Fix GTK+ make distcheck.
2229
2230         Do not exclude bmalloc directory from the tarball.
2231
2232         * gtk/manifest.txt.in:
2233
2234 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2235
2236         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
2237
2238         I forgot to add the return of a bool function.
2239
2240         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2241         (WebKitDOMNodeTest::testDOMCache):
2242
2243 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2244
2245         [GTK] GObject DOM bindings object are cached forever
2246         https://bugs.webkit.org/show_bug.cgi?id=141558
2247
2248         Reviewed by Sergio Villar Senin.
2249
2250         Add checks for all DOM objects to ensure they are not leaked. Also
2251         add a dedicated test for the DOM Object Cache.
2252
2253         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2254         (WebKitDOMNodeFilterTest::testTreeWalker):
2255         (WebKitDOMNodeFilterTest::testNodeIterator):
2256         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2257         (WebKitDOMNodeTest::testHierarchyNavigation):
2258         (WebKitDOMNodeTest::testInsertion):
2259         (WebKitDOMNodeTest::testTagNames):
2260         (WebKitDOMNodeTest::testDOMCache):
2261         (registerTests):
2262         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2263         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2264         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2265         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2266         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2267         (testWebKitDOMObjectCache):
2268         (beforeAll):
2269         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2270         (documentLoadedCallback):
2271
2272 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2273
2274         [GTK] WebKitFrame objects are never released
2275         https://bugs.webkit.org/show_bug.cgi?id=141641
2276
2277         Reviewed by Martin Robinson.
2278
2279         Add a way to check GObjects leaks for WebProcess tests and check
2280         WebKitFrame objects are not leaked.
2281
2282         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
2283         (WebKitFrameTest::testMainFrame):
2284         (WebKitFrameTest::testURI):
2285         (WebKitFrameTest::testJavaScriptContext):
2286         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2287         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
2288         (runTest):
2289         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2290
2291 2015-02-16  Tim Horton  <timothy_horton@apple.com>
2292
2293         Fix the MiniBrowser build with newer clang
2294
2295         * MiniBrowser/mac/SettingsController.m:
2296         (-[SettingsController _toggleBooleanDefault:]):
2297         * MiniBrowser/mac/WK1BrowserWindowController.m:
2298         (-[WK1BrowserWindowController windowWillClose:]):
2299         * MiniBrowser/mac/WK2BrowserWindowController.m:
2300         (-[WK2BrowserWindowController windowWillClose:]):
2301         NSApp is id and clang gets confused about which -delegate we're talking about.
2302
2303 2015-02-16  Antti Koivisto  <antti@apple.com>
2304
2305         Develop/Disable Caches does not properly disable disk cache
2306         https://bugs.webkit.org/show_bug.cgi?id=141636
2307
2308         Reviewed by Anders Carlsson.
2309
2310         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
2311         the network process too.
2312
2313         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
2314
2315         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2316         (WTR::InjectedBundle::beginTesting):
2317         (WTR::InjectedBundle::setCacheModel):
2318         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2320
2321             Forward to TestController.
2322
2323         (WTR::TestRunner::setCacheModel):
2324         * WebKitTestRunner/TestInvocation.cpp:
2325         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2326
2327 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
2328
2329         Unreviewed. Add myself as a committer.
2330
2331         * Scripts/webkitpy/common/config/contributors.json:
2332
2333 2015-02-15  David Kilzer  <ddkilzer@apple.com>
2334
2335         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
2336         <http://webkit.org/b/141607>
2337
2338         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
2339         externals in Source/WebCore/Configurations/WebCore.unexp when
2340         building with Xcode 5.x.
2341         (readXcode5SymbolsToIgnore): Add.
2342
2343 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
2344
2345         [EFL] fix Evas GL engine error.
2346         https://bugs.webkit.org/show_bug.cgi?id=141621
2347
2348         Reviewed by Gyuyoung Kim.
2349
2350         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
2351
2352         * MiniBrowser/efl/main.c:
2353         (elm_main):
2354
2355 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
2356
2357         [buildbot] Enable run-api-tests on release Mac bots
2358         https://bugs.webkit.org/show_bug.cgi?id=141518
2359
2360         Reviewed by Darin Adler.
2361
2362         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2363         (RunUnitTests):
2364         (BuildFactory.__init__):
2365         (TestFactory.__init__):
2366         (BuildAndTestFactory.__init__):
2367         (RunUnitTests.start): Deleted.
2368         (unitTestsSupported): Deleted.
2369
2370 2015-02-13  Anders Carlsson  <andersca@apple.com>
2371
2372         Add a move constructor and move assignment operator to Deque
2373         https://bugs.webkit.org/show_bug.cgi?id=141571
2374
2375         Reviewed by Andreas Kling.
2376
2377         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2378         (TestWebKitAPI::TEST):
2379
2380 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2381
2382         run-jsc-stress-tests --remote should skip profiler tests
2383         https://bugs.webkit.org/show_bug.cgi?id=141470
2384
2385         Reviewed by Filip Pizlo.
2386
2387         * Scripts/run-jsc-stress-tests:
2388
2389 2015-02-13  Anders Carlsson  <andersca@apple.com>
2390
2391         Add an initializer list constructor to Deque
2392         https://bugs.webkit.org/show_bug.cgi?id=141565
2393
2394         Reviewed by Andreas Kling.
2395
2396         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2397         (TestWebKitAPI::TEST):
2398
2399 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2400
2401         [buildbot] Remove buildJSCTool cruft from master.cfg
2402         https://bugs.webkit.org/show_bug.cgi?id=141513
2403
2404         Reviewed by Alexey Proskuryakov.
2405
2406         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2407         (RunJavaScriptCoreTests):
2408         (RunJavaScriptCoreTests.start):
2409         (RunWebKitTests):
2410         (RunWebKitTests.start):
2411         (TestFactory.__init__):
2412         (TestLeaksFactory.__init__):
2413         (RunJavaScriptCoreTests.__init__): Deleted.
2414         (RunWebKitTests.__init__): Deleted.
2415
2416 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2417
2418         Unreviewed, remove empty directories.
2419
2420         * DumpRenderTree/gtk: Removed.
2421         * DumpRenderTree/gtk/fonts: Removed.
2422         * DumpRenderTree/unix: Removed.
2423         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
2424         * GtkLauncher: Removed.
2425         * TestWebKitAPI/Tests/WebKitGtk: Removed.
2426         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
2427         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
2428         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
2429
2430 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2431
2432         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
2433         https://bugs.webkit.org/show_bug.cgi?id=141519
2434
2435         Reviewed by Alexey Proskuryakov.
2436
2437         * Scripts/build-webkittestrunner:
2438
2439 2015-02-12  Alex Christensen  <achristensen@webkit.org>
2440
2441         Removed empty directory.
2442
2443         * WinCELauncher: Removed.
2444
2445 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
2446
2447         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
2448         https://bugs.webkit.org/show_bug.cgi?id=141202
2449
2450         Reviewed by Darin Adler.
2451
2452         * Scripts/run-jsc-stress-tests:
2453
2454 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
2455
2456         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
2457         https://bugs.webkit.org/show_bug.cgi?id=141517
2458
2459         Reviewed by Anders Carlsson.
2460
2461         We do not need to locate or use the DLL's that came with Safari, so stop
2462         failing when we cannot find them. Also remove some old Qt cruft from this
2463         script.
2464
2465         * BuildSlaveSupport/built-product-archive:
2466         (archiveBuiltProduct):
2467         (extractBuiltProduct):
2468
2469 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
2470
2471         [Win] [64-bit] Work around MSVC2013 Runtime Bug
2472         https://bugs.webkit.org/show_bug.cgi?id=141498
2473         <rdar://problem/19803642>
2474
2475         Reviewed by Anders Carlsson.
2476
2477         Disable FMA3 instruction use in the MSVC math library to
2478         work around a VS2013 runtime crash. We can remove this
2479         workaround when we switch to VS2015.
2480
2481         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
2482         disable FMA3 support.
2483         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
2484         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
2485         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2486         * Scripts/webkitperl/httpd.pm: Ditto.
2487         * TestWebKitAPI/win/main.cpp: Ditto.
2488         * WinLauncher/Common.cpp: Ditto.
2489         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
2490
2491 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
2492
2493         run-jsc-stress-tests should accept remote host config from JSON file
2494         https://bugs.webkit.org/show_bug.cgi?id=141509
2495
2496         Reviewed by Michael Saboff.
2497
2498         * Scripts/run-javascriptcore-tests:
2499         (runJSCStressTests):
2500         * Scripts/run-jsc-stress-tests:
2501
2502 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2503
2504         [GTK] Add API to allow overriding the default color chooser implementation
2505         https://bugs.webkit.org/show_bug.cgi?id=98935
2506
2507         Reviewed by Gustavo Noronha Silva.
2508
2509         Add a color chooser implementation for MiniBrowser using
2510         GtkPopover when the GTK+ version is recent enough.
2511         And a test case to check the new color chooser API.
2512
2513         * MiniBrowser/gtk/BrowserWindow.c:
2514         (colorChooserRGBAChanged):
2515         (popoverColorClosed):
2516         (colorChooserRequestFinished):
2517         (runColorChooserCallback):
2518         (browserWindowConstructed):
2519         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2520         (testWebViewColorChooserRequest):
2521         (beforeAll):
2522
2523 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2524
2525         Make run-jsc-stress-tests --remote work with make-based runner
2526         https://bugs.webkit.org/show_bug.cgi?id=141079
2527
2528         Reviewed by Darin Adler.
2529
2530         * Scripts/run-javascriptcore-tests:
2531         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
2532         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
2533         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
2534         to avoid code duplication.
2535
2536 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2537
2538         run-jsc-stress tests should detect the number of processors on the remote machine too
2539         https://bugs.webkit.org/show_bug.cgi?id=141196
2540
2541         Reviewed by Darin Adler.
2542
2543         * Scripts/run-javascriptcore-tests:
2544         (runJSCStressTests): Pass through the --child-processes argument.
2545         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
2546         to detect the number of local and remote processors with the same algorithm.
2547         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
2548         same as $numProcessors.
2549
2550 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2551
2552         run-jsc-stress-tests should pass JSC_timeout to remote hosts
2553         https://bugs.webkit.org/show_bug.cgi?id=141164
2554
2555         Reviewed by Darin Adler.
2556
2557         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
2558
2559         * Scripts/run-jsc-stress-tests:
2560
2561 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2562
2563         [GTK] Add default color chooser implementation using GtkColorChooserDialog
2564         https://bugs.webkit.org/show_bug.cgi?id=141392
2565
2566         Reviewed by Gustavo Noronha Silva.
2567
2568         Enable INPUT_TYPE_COLOR by default for GTK+ port.
2569
2570         * Scripts/webkitperl/FeatureList.pm:
2571
2572 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
2573
2574         run-jsc-stress-tests shell test runner should run tests in fixed order
2575         https://bugs.webkit.org/show_bug.cgi?id=141383
2576
2577         Reviewed by Darin Adler.
2578
2579         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2580
2581 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
2582
2583         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
2584         https://bugs.webkit.org/show_bug.cgi?id=140485
2585
2586         Reviewed by Anders Carlsson.
2587
2588         Implement takeFocus() as a way to set focus through accessibility wrappers.
2589
2590         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2591         (AccessibilityUIElement::takeFocus):
2592         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2593         (WTR::AccessibilityUIElement::takeFocus):
2594
2595 2015-02-08  Darin Adler  <darin@apple.com>
2596
2597         Remove the SVG instance tree
2598         https://bugs.webkit.org/show_bug.cgi?id=140602
2599
2600         Reviewed by Dean Jackson.
2601
2602         * Scripts/check-for-global-initializers: Removed special case for
2603         SVGElementInstance.o.
2604
2605 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2606
2607         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
2608         <http://webkit.org/b/141365>
2609
2610         Reviewed by Daniel Bates.
2611
2612         * Scripts/webkitpy/xcode/simulator.py:
2613         (Simulator): Add unavailable_version_re precompiled regex.
2614         (Simulator._parse_devices): Check for unavailable versions and
2615         ignore them if found when parsing the output of
2616         `xcrun simctl list`.
2617         * Scripts/webkitpy/xcode/simulator_unittest.py:
2618         (test_unavailable_devices): Add test with output from
2619         `xcrun simctl list` with unavailable runtimes that fails before
2620         the fix.
2621
2622 2015-02-07  Chris Dumez  <cdumez@apple.com>
2623
2624         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
2625         https://bugs.webkit.org/show_bug.cgi?id=141321
2626
2627         Reviewed by Darin Adler.
2628
2629         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
2630
2631 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2632
2633         [iOS] Make Simulator class testable
2634         <http://webkit.org/b/141358>
2635
2636         Rubber-stamped by Darin Adler.
2637
2638         * Scripts/webkitpy/common/system/platforminfo.py:
2639         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
2640         command to here from Simulator.refresh() in xcode/simulator.py
2641         so that the output of the command can be mocked.
2642
2643         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2644         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
2645         to None.
2646         (MockPlatformInfo.xcode_simctl_list): Add method that returns
2647         self.expected_xcode_simctl_list expectation.
2648
2649         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
2650         and license header.
2651         (Simulator.__init__): Add optional 'host' parameter to make it
2652         possible to pass in a mock object for testing.  Set self._host
2653         to 'host' parameter or create Host() object.
2654         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
2655         method.
2656
2657         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
2658         for current code.
2659         (SimulatorTest):
2660         (SimulatorTest.setUp):
2661         (SimulatorTest._set_expected_xcrun_simctl_list):
2662         (SimulatorTest.test_simulator_device_types):
2663         (test_invalid_device_types_header):
2664         (test_invalid_runtimes_header):
2665         (test_invalid_devices_header):
2666
2667 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
2668
2669         run-jsc-stress-tests --remote should use the default ssh port
2670         https://bugs.webkit.org/show_bug.cgi?id=141287
2671
2672         Reviewed by Darin Adler.
2673
2674         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
2675
2676 2015-02-06  Dana Burkart  <dburkart@apple.com>
2677
2678         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
2679         https://bugs.webkit.org/show_bug.cgi?id=141349
2680
2681         Reviewed by Alexey Proskuryakov.
2682
2683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2684         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2685         (BuildbotTesterQueueView.prototype.update):
2686
2687 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
2688
2689         Report network process crashes during layout tests
2690         https://bugs.webkit.org/show_bug.cgi?id=139646
2691
2692         Reviewed by Anders Carlsson.
2693
2694         * WebKitTestRunner/TestController.cpp:
2695         (WTR::TestController::initialize):
2696         (WTR::TestController::networkProcessName):
2697         (WTR::TestController::networkProcessDidCrash):
2698         * WebKitTestRunner/TestController.h:
2699
2700 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
2701
2702         run-jsc-stress-tests --remote should create remote directory before copying the bundle
2703         https://bugs.webkit.org/show_bug.cgi?id=141329
2704
2705         Reviewed by Michael Saboff.
2706
2707         * Scripts/run-jsc-stress-tests:
2708
2709 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2710
2711         [GTK] Remove WebKitWebView::close-notification signal
2712         https://bugs.webkit.org/show_bug.cgi?id=141330
2713
2714         Reviewed by Gustavo Noronha Silva.
2715
2716         Update notifications unit tests according to the API changes, and
2717         add a test case to check that onclose event is fired when a
2718         notification is closed by the user.
2719
2720         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2721         (testWebViewNotification):
2722
2723 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
2724
2725         Dashboard doesn't consider building ASan a productive step
2726         https://bugs.webkit.org/show_bug.cgi?id=141312
2727
2728         Reviewed by Simon Fraser.
2729
2730         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2731
2732 2015-02-05  Daniel Bates  <dabates@apple.com>
2733
2734         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
2735         https://bugs.webkit.org/show_bug.cgi?id=141306
2736
2737         Reviewed by Alexey Proskuryakov.
2738
2739         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
2740         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
2741         existent runtime.
2742
2743         * Scripts/webkitpy/xcode/simulator.py:
2744         (Runtime.from_identifier):
2745
2746 2015-02-05  Daniel Bates  <dabates@apple.com>
2747
2748         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
2749         https://bugs.webkit.org/show_bug.cgi?id=139746
2750         <rdar://problem/19283658>
2751
2752         Reviewed by Alexey Proskuryakov.
2753
2754         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
2755         if the simulator device is not in state Booted.
2756
2757         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
2758         launching/relaunching the iOS Simulator app and a simulator app can only be installed
2759         on a device that is in the Booted state. LayoutTestRelay may run before the
2760         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
2761         We should defer executing LayoutTestRelay until the simulator device booted by
2762         iOS Simulator is in the Booted state.
2763
2764         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
2765         Simulator methods with the module name, simulator.
2766         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
2767         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
2768         before launching iOS Simulator to boot it.
2769         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
2770         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
2771         * Scripts/webkitpy/xcode/simulator.py:
2772         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
2773         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
2774         interested in the state of the device are more likely interested in the current state of the device as
2775         opposed to the state of the device when the Device object was created.
2776         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
2777         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
2778         from both this function and Simulator.device_state().
2779         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
2780         (Simulator.DeviceState): Added; class of constants.
2781         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
2782         device is in the specified state.
2783         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
2784         (Simulator.device_directory): Added.
2785         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
2786
2787 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
2788
2789         Disable retries on Mac debug testers
2790         https://bugs.webkit.org/show_bug.cgi?id=141296
2791
2792         Reviewed by Simon Fraser.
2793
2794         * BuildSlaveSupport/build.webkit.org-config/config.json:
2795
2796 2015-02-05  Dan Bernstein  <mitz@apple.com>
2797
2798         Need a way to force $xcodeSDK in webkitdirs.pm
2799         https://bugs.webkit.org/show_bug.cgi?id=141291
2800
2801         Reviewed by Anders Carlsson.
2802
2803         * Scripts/webkitdirs.pm:
2804         (setXcodeSDK): Added.
2805
2806 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
2807
2808         [Streams API] Implement a barebone ReadableStream interface
2809         https://bugs.webkit.org/show_bug.cgi?id=141045
2810
2811         Reviewed by Benjamin Poulain.
2812
2813         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
2814
2815 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
2816
2817         filter-build-webkit: reduce more unfiltered output
2818         https://bugs.webkit.org/show_bug.cgi?id=141282
2819
2820         Reviewed by Daniel Bates.
2821
2822         * Scripts/filter-build-webkit:
2823         Report CompileDTraceScript and Preprocess lines as successful.
2824
2825 2015-02-04  Dana Burkart  <dburkart@apple.com>
2826
2827         Botwatcher's Dashboard is cramped
2828         https://bugs.webkit.org/show_bug.cgi?id=140273
2829
2830         Reviewed by Alexey Proskuryakov.
2831
2832         Add a heading key which will allow for arbitrary headings in builder queues.
2833
2834         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2835         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2836         (BuildbotBuilderQueueView.prototype.update):
2837         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
2838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2839         (BuildbotIteration.prototype._parseData):
2840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2841         (BuildbotLeaksQueueView.prototype.update):
2842         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
2843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2844         (BuildbotPerformanceQueueView.prototype.update):
2845         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
2846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2847         (BuildbotQueue):
2848         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2849         (BuildbotQueueView.prototype._unauthorizedAccess):
2850         (BuildbotQueueView.prototype._appendBuild):
2851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2852         (BuildbotTestResults):
2853         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2854         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2855         (BuildbotTesterQueueView.prototype.update):
2856         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
2857
2858 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
2859
2860         WKTR should not use -mainScreen to pick a color profile
2861         https://bugs.webkit.org/show_bug.cgi?id=141265
2862
2863         Reviewed by Tim Horton.
2864
2865         -[NSScreen mainScreen] depends on the active window, so use the first screen
2866         (which is the one we put the window on anyway).
2867
2868         Do some cleanup in DRT that makes the code look similar.
2869
2870         * DumpRenderTree/mac/DumpRenderTree.mm:
2871         (createWebViewAndOffscreenWindow):
2872         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2873         (WTR::PlatformWebView::PlatformWebView):
2874
2875 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
2876
2877         LayoutTestHelper should set the color profile of all displays
2878         https://bugs.webkit.org/show_bug.cgi?id=141260
2879
2880         Reviewed by Tim Horton.
2881
2882         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
2883         which is the screen with the active window. Make things more robust by changing
2884         the colorspace of all displays, not just the main screen, when running layout tests.
2885
2886         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
2887         * DumpRenderTree/mac/LayoutTestHelper.m:
2888         (originalColorProfileURLs):
2889         (colorProfileURLForDisplay):
2890         (displayUUIDStrings):
2891         (saveDisplayColorProfiles):
2892         (setDisplayColorProfile):
2893         (restoreDisplayColorProfiles):
2894         (installLayoutTestColorProfile):
2895         (restoreUserColorProfile):
2896         (main):
2897         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
2898         toll-free bridged, sadly). Use the map to restore all profiles on exit.
2899         Convert to use more Obj-C types.
2900
2901 2015-02-04  Daniel Bates  <dabates@apple.com>
2902
2903         test-webkitpy fails on Mac without iphoneos SDK
2904         https://bugs.webkit.org/show_bug.cgi?id=141255
2905         <rdar://problem/19619691>
2906
2907         I inadvertently committed the wrong exception message. Fix up the exception message
2908         to instruct a person to install the iOS SDK when it cannot be found.
2909
2910         * Scripts/webkitpy/port/ios.py:
2911         (IOSPort.determine_full_port_name):
2912
2913 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2914
2915         W3C test importer should sort the list of files when generating the w3c-import.log
2916         https://bugs.webkit.org/show_bug.cgi?id=141156
2917
2918         Reviewed by Bem Jones-Bey.
2919
2920         Sort explicitly the list of imported files written in the w3c-import.log.
2921         Removed logging of the import date.
2922
2923         * Scripts/webkitpy/w3c/test_importer.py:
2924         (TestImporter.write_import_log):
2925
2926 2015-02-04  Daniel Bates  <dabates@apple.com>
2927
2928         test-webkitpy fails on Mac without iphoneos SDK
2929         https://bugs.webkit.org/show_bug.cgi?id=141255
2930         <rdar://problem/19619691>
2931
2932         Reviewed by David Kilzer and Alexey Proskuryakov.
2933
2934         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
2935         should not require the iphoneos SDK to be installed to run the webkitpy tests.
2936
2937         * Scripts/webkitpy/common/system/platforminfo.py:
2938         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
2939         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
2940         to standard output if the SDK is installed to return the empty string if the SDK is
2941         not installed.
2942         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2943         (MockPlatformInfo.xcode_sdk_version): Added.
2944         * Scripts/webkitpy/port/ios.py:
2945         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
2946         to get the version of the iphoneos SDK, if installed.
2947
2948 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
2949
2950         run-webkit-tests doesn't always capture ASan violation reports
2951         https://bugs.webkit.org/show_bug.cgi?id=141231
2952
2953         Reviewed by Darin Adler.
2954
2955         * Scripts/webkitpy/port/driver.py:
2956         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
2957         by the driver already (as is the case with ASan violations, which are printed to
2958         stderr).
2959         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
2960         report.
2961         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
2962         a separate variable for reporting.
2963
2964 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2965
2966         [webkitpy] Add platform specific Skipped file mechanism for performance tests
2967         https://bugs.webkit.org/show_bug.cgi?id=141152
2968
2969         Reviewed by Csaba Osztrogonác.
2970
2971         Support a test-expectation-like syntax in performance tests' skipped files.
2972         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
2973
2974         * Scripts/webkitpy/port/base.py:
2975         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
2976
2977         * Scripts/webkitpy/port/base_unittest.py:
2978         (PortTest.test_skipped_perf_tests): Test the new syntax.
2979
2980 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
2981
2982         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
2983         https://bugs.webkit.org/show_bug.cgi?id=141236
2984
2985         Reviewed by Sam Weinig.
2986
2987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2988         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
2989
2990 2015-02-04  Chris Dumez  <cdumez@apple.com>
2991
2992         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
2993         https://bugs.webkit.org/show_bug.cgi?id=141192
2994
2995         Reviewed by Benjamin Poulain.
2996
2997         Add API tests for Vector::removeFirst(value) and
2998         Vector::removeAll(value).
2999
3000         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3001         (TestWebKitAPI::TEST):
3002
3003 2015-02-03  Tim Horton  <timothy_horton@apple.com>
3004
3005         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
3006         https://bugs.webkit.org/show_bug.cgi?id=141217
3007
3008         Reviewed by Sam Weinig.
3009
3010         * WebKitTestRunner/TestController.cpp:
3011         (WTR::copyWebCryptoMasterKey):
3012         (WTR::TestController::createOtherPage):
3013         (WTR::TestController::createWebViewWithOptions):
3014         (WTR::TestController::ensureViewSupportsOptions):
3015         (WTR::TestController::didCommitNavigation):
3016         (WTR::TestController::didFinishNavigation):
3017         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3018         (WTR::TestController::didReceiveAuthenticationChallenge):
3019         (WTR::TestController::decidePolicyForPluginLoad):
3020         (WTR::TestController::decidePolicyForNavigationAction):
3021         (WTR::TestController::decidePolicyForNavigationResponse):
3022         (WTR::TestController::didCommitLoadForFrame): Deleted.
3023         (WTR::TestController::didFinishLoadForFrame): Deleted.
3024         * WebKitTestRunner/TestController.h:
3025         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
3026
3027 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
3028
3029         Unreviewed. Add myself as a committer.
3030
3031         * Scripts/webkitpy/common/config/contributors.json:
3032
3033 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3034
3035         [Win] Unreviewed test fix.
3036
3037         * DumpRenderTree/win/PolicyDelegate.cpp:
3038         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
3039         so was not matching expected output.
3040
3041 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3042
3043         Unreviewed. Moving myself to the committer section at last.
3044
3045         * Scripts/webkitpy/common/config/contributors.json:
3046
3047 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3048
3049         [Win] Tests fail because DRT reports '(null)' instead of an empty string
3050         https://bugs.webkit.org/show_bug.cgi?id=141205
3051
3052         Reviewed by Anders Carlsson.
3053
3054         * DumpRenderTree/win/HistoryDelegate.cpp:
3055         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
3056         properly so that we match expected DumpRenderTree output.
3057
3058 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3059
3060         [GTK] TestWebKitAccessibility is not skipped
3061         https://bugs.webkit.org/show_bug.cgi?id=141179
3062
3063         Reviewed by Carlos Garcia Campos.
3064
3065         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
3066         skipped, and it apparently works reliably on the bots.
3067
3068         * Scripts/run-gtk-tests:
3069         (TestRunner):
3070
3071 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3072
3073         run-perf-tests: allow to specify a wrapper command.
3074         https://bugs.webkit.org/show_bug.cgi?id=141172
3075
3076         Reviewed by Ryosuke Niwa.
3077
3078         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3079         (parse_args): Update text to indicate is also valid for WTR.
3080         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3081         (PerfTestsRunner._parse_args): Add wrapper command.
3082
3083 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3084
3085         [Win] Correct version parsing warning in update-webkit
3086         https://bugs.webkit.org/show_bug.cgi?id=141200
3087
3088         Reviewed by Anders Carlsson.
3089
3090         * Scripts/webkitdirs.pm:
3091         (setupAppleWinEnv): Strip out any specific version build level
3092         from the Cygwin version information.
3093
3094
3095 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3096
3097         [Win] Attempt to improve the reliability of HTTP service
3098         https://bugs.webkit.org/show_bug.cgi?id=141191
3099
3100         Reviewed by Darin Adler.
3101
3102         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3103         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
3104         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
3105         when stopping the service doesn't do so on its own (for Windows runs).
3106
3107 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3108
3109         Web platform test server should not need to create __init__.py files
3110         https://bugs.webkit.org/show_bug.cgi?id=141030
3111
3112         Reviewed by Ryosuke Niwa.
3113
3114         W3C TestImporter ensures that copied __init__.py files are not empty.
3115         If needed, a comment is inserted in __init__.py files.
3116         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
3117
3118         * Scripts/webkitpy/common/system/filesystem.py:
3119         (FileSystem.getsize):
3120         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3121         (TestWebPlatformTestServer.test_start_cmd):
3122         (TestWebPlatformTestServer):
3123         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
3124         * Scripts/webkitpy/w3c/test_importer.py:
3125         (TestImporter.import_tests):
3126
3127 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3128
3129         Unreviewed. Moving myself to the committer section.
3130
3131         * Scripts/webkitpy/common/config/contributors.json:
3132
3133 2015-02-02  Saam Barati  <saambarati1@gmail.com>
3134
3135         Create tests for JSC's Control Flow Profiler
3136         https://bugs.webkit.org/show_bug.cgi?id=141123
3137
3138         Reviewed by Filip Pizlo.
3139
3140         * Scripts/run-javascriptcore-tests:
3141         (runJSCStressTests):
3142         * Scripts/run-jsc-stress-tests:
3143
3144 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
3145
3146         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
3147         https://bugs.webkit.org/show_bug.cgi?id=141158
3148
3149         Reviewed by Darin Adler.
3150
3151         * Scripts/run-jsc-stress-tests:
3152
3153 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3154
3155         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
3156         https://bugs.webkit.org/show_bug.cgi?id=141142
3157
3158         Reviewed by Carlos Garcia Campos.
3159
3160         * MiniBrowser/gtk/BrowserWindow.c:
3161         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
3162
3163 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3164
3165         Web platform test server is not always launching properly on Mac EWS bots
3166         https://bugs.webkit.org/show_bug.cgi?id=141141
3167
3168         Unreviewed.
3169
3170         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3171         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
3172
3173 2015-01-31  Sam Weinig  <sam@webkit.org>
3174
3175         Remove even more Mountain Lion support
3176         https://bugs.webkit.org/show_bug.cgi?id=141124
3177
3178         Reviewed by Alexey Proskuryakov.
3179
3180         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3181         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3182         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3183         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3184         * DumpRenderTree/mac/DumpRenderTree.mm:
3185         (activateTestingFonts):
3186         (prepareConsistentTestingEnvironment):
3187         * DumpRenderTree/mac/EventSendingController.mm:
3188         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3189         (-[EventSendingController contextClick]):
3190         * DumpRenderTree/mac/TextInputController.m:
3191         * LayoutTestRelay/Configurations/Base.xcconfig:
3192         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3193         * MiniBrowser/Configurations/Base.xcconfig:
3194         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3195         * MiniBrowser/mac/WK2BrowserWindowController.m:
3196         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3197         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3198         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3199         * TestWebKitAPI/Configurations/Base.xcconfig:
3200         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3201         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3202         (-[DownloadDelegate _downloadDidFinish:]):
3203         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3204         (TestWebKitAPI::TEST):
3205         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3206         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3207         * WebKitLauncher/Configurations/Base.xcconfig:
3208         * WebKitTestRunner/Configurations/Base.xcconfig:
3209         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3210         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3211         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3212         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3213         (WTR::activateFonts):
3214         * WebKitTestRunner/TestController.cpp:
3215         (WTR::TestController::initialize):
3216         (WTR::TestController::webProcessName):
3217         * WebKitTestRunner/mac/EventSenderProxy.mm:
3218         * asan/asan.xcconfig:
3219
3220 2015-01-31  Commit Queue  <commit-queue@webkit.org>
3221
3222         Unreviewed, rolling out r179408.
3223         https://bugs.webkit.org/show_bug.cgi?id=141117
3224
3225         This didn't fully fix the issue (Requested by anttik on
3226         #webkit).
3227
3228         Reverted changeset:
3229
3230         "OSObjectPtr does not work with dispatch_data_t on Maverics"
3231         https://bugs.webkit.org/show_bug.cgi?id=141081
3232         http://trac.webkit.org/changeset/179408
3233
3234 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3235
3236         https://trac.webkit.org/changeset/179439 breaks a python test
3237         https://bugs.webkit.org/show_bug.cgi?id=141114
3238
3239         Unreviewed.
3240
3241         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3242         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.
3243
3244 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3245
3246         Import W3C web platform tests infrastructure
3247         https://bugs.webkit.org/show_bug.cgi?id=140934
3248
3249         Reviewed by Ryosuke Niwa.
3250
3251         Loading necessary web platform tests modules before launching server.
3252         Ensuring that some empty __init__.py files are present and create them if necessary.
3253
3254         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3255         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3256
3257 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3258
3259         [Win] Another unreviewed test fix.
3260
3261         Correct copy/paste error in buildbot handling.
3262
3263         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3264         (LayoutTestApacheHttpd.__init__):
3265         (LayoutTestApacheHttpd._get_apache_config_file_path):
3266
3267 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3268
3269         [Win] Unreviewed test fix.
3270
3271         Correct path handling based on failures on test bots to get things running again.
3272
3273         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3274         (LayoutTestApacheHttpd.__init__):
3275         (LayoutTestApacheHttpd._get_apache_config_file_path):
3276
3277 2015-01-30  Chris Dumez  <cdumez@apple.com>
3278
3279         Unreviewed. Fix Windows build after r179409.
3280
3281         * DumpRenderTree/win/TestRunnerWin.cpp:
3282         (TestRunner::notifyDone):
3283         (TestRunner::queueLoad):
3284
3285 2015-01-30  Chris Dumez  <cdumez@apple.com>
3286
3287         Rename shared() static member functions to singleton() for singleton classes.
3288         https://bugs.webkit.org/show_bug.cgi?id=141088
3289
3290         Reviewed by Ryosuke Niwa and Benjamin Poulain.
3291
3292         Rename shared() static member functions to singleton() for singleton
3293         classes as per the recent coding style change.
3294
3295 2015-01-30  Antti Koivisto  <antti@apple.com>
3296
3297         OSObjectPtr does not work with dispatch_data_t on Maverics
3298         https://bugs.webkit.org/show_bug.cgi?id=141081
3299
3300         Reviewed by Pratik Solanki.
3301
3302         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
3303         (TestWebKitAPI::TEST):
3304
3305 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3306
3307         [Win] Switch to Apache on Windows
3308         https://bugs.webkit.org/show_bug.cgi?id=141060
3309
3310         Reviewed by Alexey Proskuryakov.
3311
3312         Update our scripts under Windows (and Cygwin) to locate and use
3313         the XAMPP installation of Apache for running tests.
3314
3315         * Scripts/run-webkit-httpd:
3316         * Scripts/webkitperl/httpd.pm:
3317         (getHTTPDPath):
3318         (getDefaultConfigForTestDirectory):
3319         (getHTTPDConfigPathForTestDirectory):
3320         * Scripts/webkitpy/common/system/executive_unittest.py:
3321         (ExecutiveTest.serial_test_kill_process):
3322         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3323         (LayoutTestApacheHttpd.__init__):
3324         (LayoutTestApacheHttpd._get_apache_config_file_path):
3325         (LayoutTestApacheHttpd._stop_running_server):
3326         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3327         (HttpServerBase._is_server_running_on_all_ports):
3328         * Scripts/webkitpy/port/base.py:
3329         (Port._apache_config_file_name_for_platform):
3330         * Scripts/webkitpy/port/port_testcase.py:
3331         (test_apache_config_file_name_for_platform):
3332         * Scripts/webkitpy/port/win.py:
3333         (WinPort.show_results_html_file):
3334         (WinPort._uses_apache):
3335         (WinPort):
3336         (WinPort._path_to_apache):
3337
3338 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
3339
3340         Built result takes too long to be compressed on bots
3341         https://bugs.webkit.org/show_bug.cgi?id=141056
3342
3343         Reviewed by Daniel Bates.
3344
3345         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
3346
3347         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
3348
3349 2015-01-29  Sam Weinig  <sam@webkit.org>
3350
3351         Remove support for screen font substitution
3352         https://bugs.webkit.org/show_bug.cgi?id=141038
3353
3354         Reviewed by Tim Horton.
3355
3356         * DumpRenderTree/win/DumpRenderTree.cpp:
3357         (resetWebPreferencesToConsistentValues):
3358         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
3359
3360 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3361
3362         Make run-jsc-stress-tests --remote work on Linux too
3363         https://bugs.webkit.org/show_bug.cgi?id=141000
3364
3365         Reviewed by Darin Adler.
3366
3367         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
3368         use bash/dash compatible signal names, use Linux/Mac compatible find options,
3369         use bash/dash compatible functions.
3370         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
3371
3372 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3373
3374         [buildbot] Simplify jscore-test buildstep
3375         https://bugs.webkit.org/show_bug.cgi?id=140821
3376
3377         Reviewed by Alexey Proskuryakov.
3378
3379         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3380         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
3381         (RunJavaScriptCoreTests.countFailures): Added.
3382         (RunJavaScriptCoreTests.commandComplete): Deleted.
3383         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
3384         (RunJavaScriptCoreTests.getText): Deleted.
3385         (RunJavaScriptCoreTests.getText2): Deleted.
3386         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
3387         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3388         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
3389         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
3390         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
3391
3392 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3393
3394         Unreviewed, revert r179337, we don't need this dependency.
3395
3396         * efl/install-dependencies:
3397         * gtk/install-dependencies:
3398
3399 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
3400
3401         Unreviewed. Moving myself to the committer section.
3402
3403         * Scripts/webkitpy/common/config/contributors.json:
3404
3405 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
3406
3407         URTBF after r179326, added uuid-dev package as new dependency.
3408
3409         * efl/install-dependencies:
3410         * gtk/install-dependencies:
3411
3412 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
3413
3414         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
3415         https://bugs.webkit.org/show_bug.cgi?id=140673
3416
3417         Reviewed by Sam Weinig.
3418
3419         * Scripts/dtrace/trace-webkit2-messages.d: Added.
3420         Add a DTrace script that outputs a small blob of JSON per message.
3421
3422 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
3423
3424         Removed fastMallocForbid / fastMallocAllow
3425         https://bugs.webkit.org/show_bug.cgi?id=141012
3426
3427         Reviewed by Mark Hahnenberg.
3428
3429         Fixed a test bug I noticed while testing.
3430
3431         * DumpRenderTree/JavaScriptThreading.cpp:
3432         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
3433         accessing javaScriptThreads -- otherwise, you'll ASSERT.
3434
3435 2015-01-28  Dana Burkart  <dburkart@apple.com>
3436
3437         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
3438         https://bugs.webkit.org/show_bug.cgi?id=141015
3439
3440         Reviewed by Alexey Proskuryakov.
3441
3442         * asan/asan.xcconfig:
3443
3444 2015-01-28  Sam Weinig  <sam@webkit.org>
3445
3446         Fix the build.
3447
3448         * Scripts/copy-webkitlibraries-to-product-directory:
3449
3450 2015-01-28  Lucas Forschler  <lforschler@apple.com>
3451
3452         Increase the FileUpload block size in an attempt to improve network performance.
3453
3454         Reviewed by Alexey Proskuryakov.
3455
3456         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3457         (UploadBuiltProduct.__init__):
3458
3459 2015-01-28  Dana Burkart  <dburkart@apple.com>
3460
3461         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
3462         https://bugs.webkit.org/show_bug.cgi?id=136765
3463
3464         Reviewed by Alexey Proskuryakov.
3465
3466         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3467         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3468         * LayoutTestRelay/Configurations/Base.xcconfig:
3469         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3470         * MiniBrowser/Configurations/Base.xcconfig:
3471         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3472         * TestWebKitAPI/Configurations/Base.xcconfig:
3473         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3474         * WebKitLauncher/Configurations/Base.xcconfig:
3475         * WebKitTestRunner/Configurations/Base.xcconfig:
3476         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3477
3478 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
3479
3480         AX: [ATK] Implement support for new AtkRole types for MathML
3481         https://bugs.webkit.org/show_bug.cgi?id=140916
3482
3483         Reviewed by Chris Fleizach.
3484
3485         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
3486         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
3487
3488 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3489
3490         [GTK] Stop removing color marks from unit tests output
3491         https://bugs.webkit.org/show_bug.cgi?id=140996
3492
3493         Reviewed by Philippe Normand.
3494
3495         Since r178236 google tests use a custom simplified output without
3496         any colors, so we don't need to handle the case of non ttys to
3497         remove the color marks.
3498
3499         * Scripts/run-gtk-tests:
3500         (TestRunner.__init__):
3501         (TestRunner._run_test_command.parse_line):
3502
3503 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3504
3505         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
3506         https://bugs.webkit.org/show_bug.cgi?id=131731
3507
3508         Reviewed by Žan Doberšek.
3509
3510         A web page loaded offscreen is in prerender state not hidden.
3511
3512         * Scripts/run-gtk-tests:
3513         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
3514         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3515         (testWebViewPageVisibility):
3516
3517 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3518
3519         Partially revert r178802.
3520
3521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
3523
3524 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3525
3526         build.webkit.org/dashboard asserts on some commits
3527         https://bugs.webkit.org/show_bug.cgi?id=140926
3528
3529         Reviewed by Tim Horton.
3530
3531         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3532         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
3533
3534 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3535
3536         Make flakiness dashboard OS list actually match test_expectations.py
3537         https://bugs.webkit.org/show_bug.cgi?id=140969
3538
3539         Reviewed by Ryosuke Niwa.
3540
3541         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3542
3543 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
3544
3545         [Win] WinLauncher crashes on eleventh site visited
3546         https://bugs.webkit.org/show_bug.cgi?id=140960
3547
3548         Reviewed by Anders Carlsson.
3549
3550         * WinLauncher/WinLauncher.cpp:
3551         (WinLauncher::showLastVisitedSites): Don't access off the end of
3552         the history array.
3553
3554 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3555
3556         [Mac] Disable building Java applets by default
3557         https://bugs.webkit.org/show_bug.cgi?id=140957
3558         rdar://problem/19619529
3559
3560         Reviewed by Anders Carlsson.
3561
3562         It was actually already disabled unconditionally, by accident.
3563
3564         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
3565         * Scripts/webkitpy/port/mac.py:
3566         (MacPort._check_port_build):
3567         (MacPort._build_java_test_support):
3568
3569 2015-01-27  Daniel Bates  <dabates@apple.com>
3570
3571         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
3572         https://bugs.webkit.org/show_bug.cgi?id=140949
3573
3574         Reviewed by Alexey Proskuryakov.
3575
3576         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
3577         builders so that run-webkit-tests can lint the appropriate TestExpectation
3578         files.
3579
3580         * Scripts/webkitpy/port/builders.py:
3581         * Scripts/webkitpy/port/ios.py:
3582         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
3583         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
3584         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
3585         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
3586         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
3587         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
3588         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
3589
3590
3591 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3592
3593         Update bots on the flakiness dashboard
3594         https://bugs.webkit.org/show_bug.cgi?id=140956
3595
3596         Reviewed by Ryosuke Niwa.
3597
3598         * TestResultServer/static-dashboards/builders.jsonp:
3599         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3600
3601 2015-01-27  Daniel Bates  <dabates@apple.com>
3602
3603         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
3604         https://bugs.webkit.org/show_bug.cgi?id=140942
3605
3606         Reviewed by Alexey Proskuryakov.
3607
3608         The directory LayoutTests/platform/wk2 contains test expectations and test results that
3609         are applicable to all WebKit2 ports. We should make use of this information when
3610         running layout tests using iOS WebKit2.
3611
3612         Additionally, make use of the convenience function Port._wk2_port_name() for the name
3613         of the WebKit2 port instead of directly using string concatenation.
3614
3615         * Scripts/webkitpy/port/ios.py:
3616         (IOSSimulatorPort.default_baseline_search_path):
3617
3618 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
3619
3620         [Win] Disable FTL stress tests
3621         https://bugs.webkit.org/show_bug.cgi?id=140932
3622
3623         Reviewed by Brent Fulgham.
3624
3625         * Scripts/run-javascriptcore-tests:
3626
3627 2015-01-27  Daniel Bates  <dabates@apple.com>
3628
3629         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
3630         https://bugs.webkit.org/show_bug.cgi?id=140939
3631
3632         Reviewed by Eric Carlson.
3633
3634         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
3635
3636         * Scripts/webkitdirs.pm:
3637         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
3638         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
3639         and define a function called wanted.
3640
3641 2015-01-27  Daniel Bates  <dabates@apple.com>
3642
3643         Teach run-webkit-app --simulator how to install custom built app
3644         https://bugs.webkit.org/show_bug.cgi?id=140691
3645
3646         Fix inadvertent omission of directory test flag in expression to check for the
3647         existence of the iOS simulator device-specific directory for user installed apps.
3648
3649         * Scripts/webkitdirs.pm:
3650         (hasUserInstalledAppInSimulatorDevice):
3651
3652 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
3653
3654         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
3655         https://bugs.webkit.org/show_bug.cgi?id=87426
3656         <rdar://problem/11527899>
3657
3658         Reviewed by Darin Adler.
3659
3660         Revise COMPtr to work better with our HashMap implementation. Use
3661         modern loop syntax.