2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
2
3         Reviewed by Laszlo Gombos.
4
5         [Qt] Build MiniBrowser for Symbian
6         https://bugs.webkit.org/show_bug.cgi?id=56319
7
8         Have MiniBrowser reference it's own copy of useragentlist.txt instead
9         of copying QtTestBrowser's.
10         Remove Tools/MiniBrowser/DerivedSources.pro
11         This reduces complexity in the Tools scripts due to Symbian limitations.
12
13         * DerivedSources.pro:
14         * MiniBrowser/DerivedSources.pro: Removed.
15         * MiniBrowser/MiniBrowser.qrc:
16         * MiniBrowser/qt/MiniBrowser.pro:
17         * Scripts/webkitdirs.pm:
18
19 2011-03-31  Chang Shu  <cshu@webkit.org>
20
21         Reviewed by Darin Adler.
22
23         WebKitTestRunner needs layoutTestController.clearAllDatabases
24         https://bugs.webkit.org/show_bug.cgi?id=42540
25
26         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
27         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
28         (WTR::InjectedBundle::beginTesting):
29         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
30         (WTR::LayoutTestController::clearAllDatabases):
31         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
32
33 2011-03-31  Chang Shu  <cshu@webkit.org>
34
35         Reviewed by Darin Adler.
36
37         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
38         https://bugs.webkit.org/show_bug.cgi?id=42692
39
40         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
41
42 2011-03-31  Darin Adler  <darin@apple.com>
43
44         Reviewed by Sam Weinig.
45
46         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
47         https://bugs.webkit.org/show_bug.cgi?id=57573
48
49         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
50         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
51         Removed fake definitions of keyDown and contextClick.
52
53         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
54         (WTR::operator==): Added. So we can compare two WKPoint structs.
55         (WTR::parseModifier): Added.
56         (WTR::parseModifierArray): Added.
57         (WTR::EventSendingController::EventSendingController): Initialize the
58         new data members.
59         (WTR::EventSendingController::mouseDown): Added. Calls
60         WKBundlePageSimulateMouseDown.
61         (WTR::EventSendingController::mouseUp): Added. Calls
62         WKBundlePageSimulateMouseUp.
63         (WTR::EventSendingController::mouseMoveTo): Added. Calls
64         WKBundlePageSimulateMouseMotion.
65         (WTR::EventSendingController::leapForward): Added.
66         (WTR::EventSendingController::updateClickCount): Added. Used by the
67         mouseDown/Up functions to create a click count.
68
69         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
70         for the changes above.
71
72 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
73
74         Reviewed by Martin Robinson.
75
76         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
77         https://bugs.webkit.org/show_bug.cgi?id=57362
78
79         Do not generate DRT output if willSendRequestReturnsNull is set.
80
81         * DumpRenderTree/gtk/DumpRenderTree.cpp:
82         (willSendRequestCallback):
83
84 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
85
86         Reviewed by Martin Robinson.
87
88         Implement MiniBrowser for Gtk port.
89         https://bugs.webkit.org/show_bug.cgi?id=48512
90
91         Initial implementation of the Gtk MiniBrowser.
92
93         * MiniBrowser/gtk/GNUmakefile.am: Added.
94         * MiniBrowser/gtk/main.c: Added.
95         (activateUriEntryCallback):
96         (destroyCallback):
97         (goBackCallback):
98         (goForwardCallback):
99         (createToolbar):
100         (createWebView):
101         (createWindow):
102         (argumentToURL):
103         (main):
104
105 2011-03-30  Dominic Cooney  <dominicc@google.com>
106
107         Reviewed by Dimitri Glazkov.
108
109         Adds layoutTestController.shadowRoot accessor to Mac DRT.
110         https://bugs.webkit.org/show_bug.cgi?id=57415
111
112         * DumpRenderTree/LayoutTestController.cpp:
113         (shadowRootCallback):
114         (LayoutTestController::staticFunctions):
115         * DumpRenderTree/LayoutTestController.h:
116         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
117         (LayoutTestController::shadowRoot):
118         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
119         (LayoutTestController::shadowRoot):
120
121 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
122
123         Reviewed by Chris Marrin.
124
125         Update fast/canvas tests to avoid dumping the render tree when possible
126         https://bugs.webkit.org/show_bug.cgi?id=57493
127
128         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
129           accelerated drawing and accelerated drawing for canvas
130
131 2011-03-30  Adam Roben  <aroben@apple.com>
132
133         Stop ignoring leaks in CGGradientCreateWithColorStops
134
135         Fixes <rdar://problem/7888547>.
136
137         Rubber-stamped by John Sullivan.
138
139         * Scripts/old-run-webkit-tests:
140         (countAndPrintLeaks): Removed some code to ignore those leaks.
141
142 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
143
144         Reviewed by Alexey Proskuryakov.
145
146         Add some dynamic annotations to JavaScriptCore/wtf
147         https://bugs.webkit.org/show_bug.cgi?id=53747
148
149         By using these annotations we can improve the precision of finding
150         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
151         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
152
153         These files don't add new functionality, so don't need extra tests.
154
155         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
156
157 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
158
159         Reviewed by Adam Roben.
160
161         Share most vsprops between Release and Production builds in releaseproduction.vsprops
162         https://bugs.webkit.org/show_bug.cgi?id=57508
163
164         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
165         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
166         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
167         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
168         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
169         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
170         * DumpRenderTree/win/ImageDiffProduction.vsprops:
171         * DumpRenderTree/win/ImageDiffRelease.vsprops:
172         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
173         * FindSafari/FindSafariProduction.vsprops:
174         * FindSafari/FindSafariRelease.vsprops:
175         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
176         * FindSafari/FindSafariReleasePGO.vsprops:
177         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
178         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
179         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
180         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
181         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
182         * WebKitAPITest/WebKitAPITestProduction.vsprops:
183         * WebKitAPITest/WebKitAPITestRelease.vsprops:
184         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
185         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
186         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
187         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
188         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
189         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
190         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
191         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
192         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
193         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
194         * WinLauncher/WinLauncherProduction.vsprops:
195         * WinLauncher/WinLauncherRelease.vsprops:
196         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
197         * record-memory-win/record-memory-winProduction.vsprops:
198         * record-memory-win/record-memory-winRelease.vsprops:
199         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
200
201 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
202
203         Reviewed by Adam Roben.
204
205         Update Windows production build logic for new production configurations
206         https://bugs.webkit.org/show_bug.cgi?id=57494
207
208         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
209         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
210         * DumpRenderTree/win/ImageDiffProduction.vsprops:
211         * FindSafari/FindSafariProduction.vsprops:
212         * FindSafari/FindSafariReleasePGO.vsprops:
213         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
214         * WebKitAPITest/WebKitAPITestProduction.vsprops:
215         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
216         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
217         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
218         * WinLauncher/WinLauncherProduction.vsprops:
219         * record-memory-win/record-memory-winProduction.vsprops:
220
221 2011-03-30  Robert Hogan  <robert@webkit.org>
222
223         Reviewed by Antonio Gomes.
224
225         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
226         Unskip http/tests/navigation/go-back-to-error-page.html
227
228         Also add the location of DumpRenderTreeSupportQt.h
229         to DRT's include paths.
230
231         https://bugs.webkit.org/show_bug.cgi?id=52614
232
233         * DumpRenderTree/qt/DumpRenderTree.pro:
234         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
235         * DumpRenderTree/qt/DumpRenderTreeQt.h:
236         * DumpRenderTree/qt/GCControllerQt.cpp:
237         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
238         (LayoutTestController::queueLoadHTMLString):
239         * DumpRenderTree/qt/LayoutTestControllerQt.h:
240         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
241         * DumpRenderTree/qt/TextInputControllerQt.cpp:
242         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
243         (LoadAlternateHTMLStringItem::invoke):
244         * DumpRenderTree/qt/WorkQueueItemQt.h:
245         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
246         * QtTestBrowser/QtTestBrowser.pro:
247         * QtTestBrowser/launcherwindow.h:
248
249 2011-03-30  Adam Barth  <abarth@webkit.org>
250
251         Reviewed by Adam Roben.
252
253         SheriffBot rollouts take too long
254         https://bugs.webkit.org/show_bug.cgi?id=57498
255
256         We used to build before landing rollouts via the commit-queue to
257         prevent further breakage, but now that our individual commit-queue
258         machines are slower, building takes too long.  I can't remember the
259         last time a rollout broke compile.  It seems like just landing the
260         patch is the better trade-off.
261
262         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
263         * Scripts/webkitpy/tool/commands/queues_unittest.py:
264
265 2011-03-30  Adam Barth  <abarth@webkit.org>
266
267         Remove platform/chromium-mac-snowleopard
268         https://bugs.webkit.org/show_bug.cgi?id=57486
269
270         This directory no longer exists, so we can remove it from the fallback
271         chain.
272
273         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
274
275 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
276
277         Reviewed by Adam Roben.
278
279         Rename Windows configuration Release_LTCG to Production for clarity
280         https://bugs.webkit.org/show_bug.cgi?id=57465
281
282         * DumpRenderTree/DumpRenderTree.sln:
283         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
284         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
285         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
286         * DumpRenderTree/win/DumpRenderTree.vcproj:
287         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
288         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
289         * DumpRenderTree/win/ImageDiff.vcproj:
290         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
291         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
292         * FindSafari/FindSafari.vcproj:
293         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
294         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
295         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
296         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
297         * MiniBrowser/MiniBrowser.vcproj:
298         * Scripts/webkitdirs.pm:
299         * TestWebKitAPI/win/TestWebKitAPI.sln:
300         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
301         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
302         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
303         * WebKitAPITest/WebKitAPITest.vcproj:
304         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
305         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
306         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
307         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
308         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
309         * WebKitTestRunner/WebKitTestRunner.sln:
310         * WebKitTestRunner/win/InjectedBundle.vcproj:
311         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
312         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
313         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
314         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
315         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
316         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
317         * WinLauncher/WinLauncher.vcproj:
318         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
319         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
320         * record-memory-win/record-memory-win.vcproj:
321         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
322         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
323
324 2011-03-30  MORITA Hajime  <morrita@google.com>
325
326         Reviewed by Dimitri Glazkov.
327
328         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
329         https://bugs.webkit.org/show_bug.cgi?id=56573
330
331         Added LayoutTestController.shadowRoot() to Chromium DRT.
332
333         * DumpRenderTree/chromium/LayoutTestController.cpp:
334         (LayoutTestController::LayoutTestController):
335         (LayoutTestController::shadowRoot):
336         * DumpRenderTree/chromium/LayoutTestController.h:
337
338 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
339
340         Reviewed by Kent Tamura.
341
342         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
343         https://bugs.webkit.org/show_bug.cgi?id=57430
344
345         * DumpRenderTree/chromium/LayoutTestController.cpp:
346         (LayoutTestController::LayoutTestController):
347         (LayoutTestController::setPluginsEnabled):
348         * DumpRenderTree/chromium/LayoutTestController.h:
349
350 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
351
352         Reviewed by Adam Barth.
353
354         make webkit-patch upload respect -d
355         https://bugs.webkit.org/show_bug.cgi?id=57425
356
357         * Scripts/webkitpy/common/checkout/scm.py:
358         * Scripts/webkitpy/tool/steps/commit.py:
359
360 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
361
362         Reviewed by Adam Barth.
363
364         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
365         https://bugs.webkit.org/show_bug.cgi?id=57429
366
367         * Scripts/webkitpy/common/checkout/scm.py:
368
369 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
370
371         Unreviewed, rolling out r82383.
372         http://trac.webkit.org/changeset/82383
373         https://bugs.webkit.org/show_bug.cgi?id=57417
374
375         "nrwt isn't shutting down cleanly" (Requested by dpranke on
376         #webkit).
377
378         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
379         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
380         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
381
382 2011-03-29  Kent Tamura  <tkent@chromium.org>
383
384         Reviewed by Dimitri Glazkov.
385
386         Make validation message bubble testable
387         https://bugs.webkit.org/show_bug.cgi?id=57290
388
389         * DumpRenderTree/mac/DumpRenderTree.mm:
390         (createWebViewAndOffscreenWindow): Change a setting so that validation
391           bubbles isn't hidden automatically.
392
393 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
394
395         Reviewed by Ojan Vafai.
396
397         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
398
399         It's a bit unclear whether multiple threads or multiple
400         processes will be a better model on windows. This change will
401         test threads for now while we're still working out the bugs in
402         multiple-processes.
403
404         https://bugs.webkit.org/show_bug.cgi?id=57410
405
406         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
407         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
408         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
409
410 2011-03-29  David Levin  <levin@chromium.org>
411
412         Reviewed by Shinichiro Hamaji.
413
414         check-webkit-style confused by two ChangeLog entries in a row from same user
415         https://bugs.webkit.org/show_bug.cgi?id=57250
416
417         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
418         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
419         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
420           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
421           checking more than that would be very messey.
422         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
423         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
424
425 2011-03-29  Kent Tamura  <tkent@chromium.org>
426
427         Reviewed by Dimitri Glazkov.
428
429         [Mac] Enable interactive-validation tests on Mac DRT
430         https://bugs.webkit.org/show_bug.cgi?id=57308
431
432         * DumpRenderTree/mac/DumpRenderTree.mm:
433         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
434
435 2011-03-29  Chang Shu  <cshu@webkit.org>
436
437         Reviewed by Kenneth Rohde Christiansen.
438
439         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
440         https://bugs.webkit.org/show_bug.cgi?id=42692
441
442         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
443         (WTR::InjectedBundle::beginTesting):
444         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
445         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
446         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
447
448 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
449
450         Reviewed by Xan Lopez.
451
452         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
453         https://bugs.webkit.org/show_bug.cgi?id=57067
454
455         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
456         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
457         update DRT and pixel results as hundreds of results will need to be updated.
458
459         * DumpRenderTree/gtk/DumpRenderTree.cpp:
460         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
461         by overriding the theme RC/CSS files.
462
463 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
464
465         Reviewed by Adam Roben.
466
467         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
468         https://bugs.webkit.org/show_bug.cgi?id=57394
469
470         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
471         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
472         the IDE. To avoid this, add a separate vsprops file for each project configuration that
473         contains the required inherited property sheets.
474
475         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
476         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
477         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
478         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
479         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
480         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
481         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
482         * DumpRenderTree/win/DumpRenderTree.vcproj:
483         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
484         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
485         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
486         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
487         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
488         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
489         * DumpRenderTree/win/ImageDiff.vcproj:
490         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
491         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
492         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
493         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
494         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
495         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
496         * FindSafari/FindSafari.vcproj:
497         * FindSafari/FindSafariDebug.vsprops: Added.
498         * FindSafari/FindSafariDebugAll.vsprops: Added.
499         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
500         * FindSafari/FindSafariRelease.vsprops: Added.
501         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
502         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
503         * FindSafari/FindSafariReleasePGO.vsprops: Added.
504         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
505         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
506         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
507         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
508         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
509         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
510         * MiniBrowser/MiniBrowser.vcproj:
511         * WebKitAPITest/WebKitAPITest.vcproj:
512         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
513         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
514         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
515         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
516         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
517         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
518         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
519         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
520         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
521         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
522         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
523         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
524         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
525         * WebKitTestRunner/win/InjectedBundle.vcproj:
526         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
527         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
528         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
529         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
530         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
531         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
532         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
533         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
534         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
535         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
536         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
537         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
538         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
539         * WinLauncher/WinLauncher.vcproj:
540         * WinLauncher/WinLauncherDebug.vsprops: Added.
541         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
542         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
543         * WinLauncher/WinLauncherRelease.vsprops: Added.
544         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
545         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
546         * record-memory-win/record-memory-win.vcproj:
547         * record-memory-win/record-memory-winDebug.vsprops: Added.
548         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
549         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
550         * record-memory-win/record-memory-winRelease.vsprops: Added.
551         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
552         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
553
554 2011-03-29  Adam Barth  <abarth@webkit.org>
555
556         Reviewed by Darin Adler.
557
558         test_runner2.py can crash due to undefined variable
559         https://bugs.webkit.org/show_bug.cgi?id=57356
560
561         Replace reference to undefined variable with a variable that's actually
562         defined.  AFAICT, there's no way to test this code.
563
564         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
565
566 2011-03-29  Tony Chang  <tony@chromium.org>
567
568         Reviewed by Eric Seidel.
569
570         cleanup rebaseline-chromium-webkit-tests
571         https://bugs.webkit.org/show_bug.cgi?id=57375
572
573         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
574             - Split _extract_and_add_new_baselines into 3 functions
575             - Reduce the amount of line wrapping (the file already has lines
576               over 80 col, so may as well try to make the file consistent)
577             - Remove unnecessary ()s
578
579 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
580
581         Reviewed by Adam Roben.
582
583         Make WinCairo a core builder.
584         https://bugs.webkit.org/show_bug.cgi?id=57373
585
586         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
587         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
588
589 2011-03-29  Timothy Hatcher  <timothy@apple.com>
590
591         Update update-webkit-localizable-strings to understand that WebKit and
592         WebKit2 strings go in WebCore.
593
594         Also make extract-localizable-strings optionally use an exclude file. No individual
595         warnings are produced about unlocalized strings when there is no exclude file. This
596         is needed for WebCore, since there are too many bare strings.
597
598         https://webkit.org/b/57354
599
600         Reviewed by Sam Weinig.
601
602         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
603         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
604
605 2011-03-29  Darin Adler  <darin@apple.com>
606
607         Reviewed by Adam Roben.
608
609         WebKit2 bundle page needs to offer generated file hooks
610         https://bugs.webkit.org/show_bug.cgi?id=57279
611
612         (Land missing part of the original patch after r82289.)
613
614         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
615         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
616
617 2011-03-29  Tony Chang  <tony@chromium.org>
618
619         Reviewed by Ojan Vafai.
620
621         [chromium] NRWT should be able to read checksums from png comments
622         https://bugs.webkit.org/show_bug.cgi?id=57280
623
624         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
625             from a file.
626         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
627         * Scripts/webkitpy/common/system/filesystem_mock.py:
628         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
629             if the -checksum.txt file doesn't exist, try looking in the png.
630         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
631         * Scripts/webkitpy/layout_tests/port/test.py:
632         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
633             2k for a png comment with the checksum
634         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
635
636 2011-03-29  Philippe Normand  <pnormand@igalia.com>
637
638         Rubber-stamped by Gustavo Noronha Silva.
639
640         [GTK] http/tests/uri/username-with-no-hostname.html fails
641         https://bugs.webkit.org/show_bug.cgi?id=57325
642
643         * DumpRenderTree/gtk/DumpRenderTree.cpp:
644         (willSendRequestCallback): URI host value check done case-insensitively.
645
646 2011-03-29  Philippe Normand  <pnormand@igalia.com>
647
648         Reviewed by Martin Robinson.
649
650         [GTK] http/tests/uri/username-with-no-hostname.html fails
651         https://bugs.webkit.org/show_bug.cgi?id=57325
652
653         * DumpRenderTree/gtk/DumpRenderTree.cpp:
654         (willSendRequestCallback): Check URI before submitting the request
655         to WebCore.
656
657 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
658
659         Reviewed by Ojan Vafai.
660
661         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
662         https://bugs.webkit.org/show_bug.cgi?id=57303
663
664         * DumpRenderTree/chromium/EventSender.cpp:
665         (EventSender::doDragDrop):
666         (EventSender::beginDragWithFiles):
667
668 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
669
670         Reviewed by Andreas Kling.
671
672         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
673         https://bugs.webkit.org/show_bug.cgi?id=57314
674
675         Provide possibility to print loaded urls to the standard output.
676
677         * MiniBrowser/qt/BrowserWindow.cpp:
678         (BrowserWindow::BrowserWindow):
679         (BrowserWindow::printURL):
680         * MiniBrowser/qt/BrowserWindow.h:
681         * MiniBrowser/qt/MiniBrowserApplication.cpp:
682         (MiniBrowserApplication::handleUserOptions):
683         * MiniBrowser/qt/MiniBrowserApplication.h:
684         (WindowOptions::WindowOptions):
685         * QtTestBrowser/launcherwindow.cpp:
686         (LauncherWindow::initializeView):
687         (LauncherWindow::printURL):
688         (LauncherWindow::cloneWindow):
689         * QtTestBrowser/launcherwindow.h:
690         (WindowOptions::WindowOptions):
691         * QtTestBrowser/main.cpp:
692         (LauncherApplication::handleUserOptions):
693
694 2011-03-29  Gabor Loki  <loki@webkit.org>
695
696         Rubber-stamped by Csaba Osztrogonác.
697
698         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
699         https://bugs.webkit.org/show_bug.cgi?id=56918
700
701         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
702
703 2011-03-28  Gabor Loki  <loki@webkit.org>
704
705         Reviewed by Csaba Osztrogonác.
706
707         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
708         https://bugs.webkit.org/show_bug.cgi?id=56918
709
710         * Scripts/build-jsc:
711         * Scripts/webkitdirs.pm:
712
713 2011-03-28  Andrew Foster  <andrewf@chromium.org>
714
715         Reviewed by Ojan Vafai.
716
717         webkit-patch should be more intelligent about whether a bug applies to a patch
718         Create a new function, parse_bug_id_from_changelog() which determines
719         that a bug is related to a patch by parsing the output generated from
720         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
721         the description of a patch.
722         https://bugs.webkit.org/show_bug.cgi?id=56989
723
724         * Scripts/webkitpy/common/checkout/api.py:
725         * Scripts/webkitpy/common/checkout/changelog.py:
726         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
727         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
728         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
729         * Scripts/webkitpy/style/checkers/changelog.py:
730         * Scripts/webkitpy/tool/commands/upload.py:
731
732 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
733
734         Revert accidentally commited change.
735
736         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
737         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
738
739 2011-03-28  Tony Chang  <tony@chromium.org>
740
741         Reviewed by Adam Barth.
742
743         [chromium] have DRT write the png checksum into a png comment
744         https://bugs.webkit.org/show_bug.cgi?id=57255
745
746         * DumpRenderTree/chromium/TestShell.cpp:
747         (TestShell::dumpImage):
748
749 2011-03-28  Adele Peterson  <adele@apple.com>
750
751         Removing Qt stub, since it doesn't use the same header as the others.
752
753         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
754
755 2011-03-28  Adele Peterson  <adele@apple.com>
756
757         Added a few more stubs.
758
759         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
760         (LayoutTestController::hasGrammarMarker):
761         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
762         (LayoutTestController::hasGrammarMarker):
763         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
764         (LayoutTestController::hasGrammarMarker):
765
766 2011-03-28  Adele Peterson  <adele@apple.com>
767
768         Build fix.
769
770         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
771         (LayoutTestController::hasGrammarMarker):
772
773 2011-03-28  Adele Peterson  <adele@apple.com>
774
775         Reviewed by Eric Seidel.
776
777         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
778         https://bugs.webkit.org/show_bug.cgi?id=57173
779
780         * DumpRenderTree/LayoutTestController.cpp:
781         (hasGrammarMarkerCallback): Added.
782         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
783         * DumpRenderTree/LayoutTestController.h:
784         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
785         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
786
787 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
788
789         Reviewed by Benjamin Poulain.
790
791         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
792         https://bugs.webkit.org/show_bug.cgi?id=57087
793
794         Trivial typo fix after r82082.
795
796         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
797         (WTR::activateFonts):
798
799 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
800
801         Reviewed by Andreas Kling.
802
803         Add myself to the committers list.
804
805         * Scripts/webkitpy/common/config/committers.py:
806
807 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
808
809         Reviewed by Sam Weinig.
810
811         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
812         to link against WebKit.framework for now.
813
814         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
815
816 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
817
818         Reviewed by Andreas Kling.
819
820         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
821         https://bugs.webkit.org/show_bug.cgi?id=57087
822
823         Disable QT_ASCII_CAST_WARNINGS for applications.
824
825         * DumpRenderTree/qt/DumpRenderTree.pro:
826         * DumpRenderTree/qt/ImageDiff.pro:
827         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
828         * MiniBrowser/qt/MiniBrowser.pro:
829         * QtTestBrowser/QtTestBrowser.pro:
830         * WebKitTestRunner/qt/WebKitTestRunner.pro:
831
832 2011-03-28  Andreas Kling  <kling@webkit.org>
833
834         Reviewed by Kenneth Rohde Christiansen.
835
836         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
837         https://bugs.webkit.org/show_bug.cgi?id=57224
838
839         * QtTestBrowser/mainwindow.cpp:
840         (MainWindow::buildUI):
841         (MainWindow::onTitleChanged):
842         * QtTestBrowser/mainwindow.h:
843
844 2011-03-27  Jer Noble  <jer.noble@apple.com>
845
846         Reviewed by Maciej Stachowiak.
847
848         Full Screen: disable keyboard access by default
849         https://bugs.webkit.org/show_bug.cgi?id=56684
850
851         Accept the withKeyboard parameter to supportsFullScreenForElement.
852
853         * DumpRenderTree/mac/UIDelegate.mm:
854         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
855
856 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
857
858         Reviewed by David Levin.
859
860         check-webkit-style should check ChangeLog for a valid bug number
861         https://bugs.webkit.org/show_bug.cgi?id=57184
862
863         * Scripts/webkitpy/style/checker.py:
864         * Scripts/webkitpy/style/checker_unittest.py:
865         * Scripts/webkitpy/style/checkers/changelog.py: Added.
866         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
867
868 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
869
870         Reviewed by Andreas Kling.
871
872         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
873         https://bugs.webkit.org/show_bug.cgi?id=57087
874
875         Use explicit conversion for string to avoid depending on the default codec
876         installed by the user code.
877
878         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
879         (WTR::activateFonts):
880
881 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
882
883         Revert inadvertantly committed changes.
884
885         * Scripts/old-run-webkit-tests:
886         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
887
888 2011-03-26  Andreas Kling  <kling@webkit.org>
889
890         Reviewed by Kenneth Rohde Christiansen.
891
892         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
893         https://bugs.webkit.org/show_bug.cgi?id=57162
894
895         * QtTestBrowser/QtTestBrowser.qrc:
896         * QtTestBrowser/favicon.png: Added.
897         * QtTestBrowser/locationedit.cpp:
898         (defaultPageIcon):
899         (LocationEdit::LocationEdit):
900         (LocationEdit::setPageIcon):
901         (LocationEdit::resizeEvent):
902         (LocationEdit::updateInternalGeometry):
903         * QtTestBrowser/locationedit.h:
904         * QtTestBrowser/mainwindow.cpp:
905         (MainWindow::buildUI):
906         (MainWindow::onIconChanged):
907         (MainWindow::onLoadStarted):
908         * QtTestBrowser/mainwindow.h:
909
910 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
911
912         Reviewed by Xan Lopez.
913
914         [GTK] Force DumpRenderTree to use 96 DPI
915         https://bugs.webkit.org/show_bug.cgi?id=56866
916
917         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
918         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
919
920         * DumpRenderTree/gtk/DumpRenderTree.cpp:
921         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
922         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
923         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
924
925 2011-03-25  Andy Estes  <aestes@apple.com>
926
927         Reviewed by Adele Peterson.
928
929         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
930         https://bugs.webkit.org/show_bug.cgi?id=49016
931
932         TestNetscapePlugIn needs to register support for an image MIME type so
933         we can test that the embed tag prefers plug-ins to render image MIME
934         types.
935
936         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
937         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
938         (NP_GetMIMEDescription): Ditto.
939         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
940
941 2011-03-25  Jessie Berlin  <jberlin@apple.com>
942
943         Reviewed by Sam Weinig.
944
945         WebKit2: Need to be able to set and get the Cookie Storage Policy.
946         https://bugs.webkit.org/show_bug.cgi?id=50780
947
948         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
949
950         The test is named "CookieManager" so that we can eventually exercise more of the
951         CookieManager functionality in the test.
952
953         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
954         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
955         Assert that the policy returned is equal to the policy set in
956         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
957         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
958         Set the policy to something different than the user's policy and get the policy again.
959         (TestWebKitAPI::didFinishLoadForFrame):
960         Get the user's policy so that it can be restored at the end of the test.
961         (TestWebKitAPI::TEST):
962         Load about:blank so that the Web Process gets instatiated (needed to get the
963         CookieManager).
964
965         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
966         Add CookieManager.cpp.
967
968 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
969
970         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
971
972         * wx/build/settings.py:
973
974 2011-03-24  Ilya Sherman  <isherman@chromium.org>
975
976         Reviewed by Adam Roben.
977
978         Implement layoutTestController.setAutoFilled in DRT on Windows
979         https://bugs.webkit.org/show_bug.cgi?id=56828
980
981         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
982         (LayoutTestController::setAutofilled): Implemented.
983
984 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
985
986         Unreviewed build correction.
987
988         Correct vsprops file for Debug variant of the CFLite build.
989         Disable a CFNETWORK-specific test when building for CFLite.
990
991         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
992         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
993
994 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
995
996         Reviewed by Adam Barth.
997
998         fix regressions introduced in 81908 - there were a couple of
999         code paths that only fired under python 2.5 that I missed.
1000
1001         Also change a couple of 'python' references to sys.executable
1002         in order to handle runing test-webkitpy with a binary other than
1003         something called 'python'.
1004
1005         https://bugs.webkit.org/show_bug.cgi?id=57063
1006
1007         * Scripts/webkitpy/layout_tests/port/mac.py:
1008         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1009         * Scripts/webkitpy/test/cat.py:
1010         * Scripts/webkitpy/test/echo.py:
1011
1012 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1013
1014         Unreviewed build correction.
1015
1016         Add a stub implementation of the TestInvocation dumping logic.
1017         Update project files to reflect new file.
1018
1019         * WebKitTestRunner/cairo: Added.
1020         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1021         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1022         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1023
1024 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1025
1026         Reviewed by Tony Chang.
1027
1028         new-run-webkit-tests: clean up worker model defaults. This
1029         changes the default behavior to 'threads' instead of
1030         'old-threads', and clarifies that chromium-win-* and
1031         chromium-mac-leopard are exceptions.
1032
1033         https://bugs.webkit.org/show_bug.cgi?id=56971
1034
1035         * Scripts/webkitpy/layout_tests/port/base.py:
1036         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1037         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1038         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1039         * Scripts/webkitpy/layout_tests/port/test.py:
1040         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1041
1042 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1043
1044         Reviewed by Darin Adler.
1045
1046         Media Stream API: fix the order of the options in build-webkit.
1047         https://bugs.webkit.org/show_bug.cgi?id=56949
1048
1049         Fix the order of the options in build-webkit.
1050
1051         * Scripts/build-webkit:
1052
1053 2011-03-23  Adam Klein  <adamk@chromium.org>
1054
1055         Reviewed by Mihai Parparita.
1056
1057         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1058         https://bugs.webkit.org/show_bug.cgi?id=56884
1059
1060         This option will be utilized by Chromium's ui_tests to allow
1061         referencing js-test-resources from a layout test over HTTP.
1062
1063         * Scripts/new-run-webkit-httpd:
1064         Added --layout_tests_dir option.
1065         * Scripts/webkitpy/layout_tests/port/http_server.py:
1066         Plumbed through as layout_tests_dir param.
1067
1068 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1069
1070         Reviewed by Mihai Parparita.
1071
1072         new-run-webkit-tests: run tests in ascending alphabetical order per
1073         dir. This is a second attempt at the fix; the first attempt, in 
1074         r81597, broke the behavior on the old-inline and old-threads
1075         worker models.
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=56760
1078
1079         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1080         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1081         * Scripts/webkitpy/layout_tests/port/test.py:
1082         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1083
1084 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1085
1086         Reviewed by Martin Robinson.
1087
1088         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1089         https://bugs.webkit.org/show_bug.cgi?id=56953
1090
1091         Print the string for the detail of 'property-change' signal.
1092
1093         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1094         (axObjectEventListener): Print the detail string.
1095
1096 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1097
1098         Reviewed by Pavel Feldman.
1099
1100         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1101         https://bugs.webkit.org/show_bug.cgi?id=56843
1102
1103         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1104         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1105
1106 2011-03-22  Eric Seidel  <eric@webkit.org>
1107
1108         Reviewed by Adam Barth.
1109
1110         Teach update-webkit about gyp
1111         https://bugs.webkit.org/show_bug.cgi?id=56881
1112
1113         This makes it possible for someone who builds from Xcode
1114         to just run update-webkit --gyp and have the project files
1115         generated after update automatically.
1116
1117         I also added a stand-alone "generate-project-files" script
1118         wrapping Source/gyp/configure.  This makes running gyp simpler
1119         since most people will not have gyp or Source/gyp in their path.
1120
1121         * Scripts/build-webkit:
1122         * Scripts/generate-project-files: Added.
1123         * Scripts/update-webkit:
1124
1125 2011-03-22  Anton D'Auria  <adauria@apple.com>
1126
1127         Reviewed by Alexey Proskuryakov.
1128
1129         Add +[WebApplicationCache getOriginsWithCache]
1130         https://bugs.webkit.org/show_bug.cgi?id=56722
1131
1132         * DumpRenderTree/LayoutTestController.cpp:
1133         (originsWithApplicationCacheCallback):
1134         (LayoutTestController::staticFunctions):
1135         * DumpRenderTree/LayoutTestController.h:
1136         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1137         (LayoutTestController::originsWithApplicationCache):
1138         * DumpRenderTree/chromium/LayoutTestController.h:
1139         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1140         (LayoutTestController::originsWithApplicationCache):
1141         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
1142         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
1143         (LayoutTestController::originsWithApplicationCache):
1144         (LayoutTestController::originsWithLocalStorage):
1145         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1146         (LayoutTestController::originsWithApplicationCache):
1147         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1148         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1149         (LayoutTestController::originsWithApplicationCache):
1150         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
1151         (LayoutTestController::originsWithApplicationCache):
1152
1153 2011-03-22  Eric Seidel  <eric@webkit.org>
1154
1155         Reviewed by Adam Barth.
1156
1157         Add support to build-webkit for building with gyp-generated project files
1158         https://bugs.webkit.org/show_bug.cgi?id=56877
1159
1160         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
1161         Eventually we'll want to support gyp-generated projects in a more general manner.
1162
1163         * Scripts/build-webkit:
1164
1165 2011-03-22  David Kilzer  <ddkilzer@apple.com>
1166
1167         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
1168
1169         Reviewed by Joseph Pecoraro.
1170
1171         * Scripts/build-webkit: Updated usage statement to include
1172         --dsym.
1173         * Scripts/webkitdirs.pm: Added $generateDsym variable.
1174         (generateDsym): Added. Call determineGenerateDsym() and
1175         return $generateDsym.
1176         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
1177         $generateDsym.
1178         (argumentsForXcode): Added.  Returns additional arguments for
1179         xcodebuild based on command-line switches.
1180         (XcodeOptions): Updated to include argumentsForXcode() in the
1181         array returned.
1182
1183 2011-03-22  Adam Roben  <aroben@apple.com>
1184
1185         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
1186
1187         These bots are consistently green again.
1188
1189         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
1190         core builders
1191
1192         Rubber-stamped by Antti Koivisto.
1193
1194         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1195         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
1196
1197         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1198         (BuildBotTest.test_builder_name_regexps): Updated expectations.
1199
1200 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1201
1202         Unreviewed, rolling out r81597.
1203         http://trac.webkit.org/changeset/81597
1204         https://bugs.webkit.org/show_bug.cgi?id=56801
1205
1206         Change results in lots of unexpected flaky on the dashboard.
1207         (Requested by pfeldman on #webkit).
1208
1209         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1210         * Scripts/webkitpy/layout_tests/port/test.py:
1211         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1212
1213 2011-03-21  Sam Weinig  <sam@webkit.org>
1214
1215         Fix failing tests on the WebKit2 bots.
1216
1217         * WebKitTestRunner/TestController.cpp:
1218         (WTR::TestController::resetStateToConsistentValues):
1219
1220 2011-03-21  Daniel Sievers  <sievers@google.com>
1221
1222         Reviewed by Simon Fraser.
1223
1224         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1225         https://bugs.webkit.org/show_bug.cgi?id=56139
1226
1227         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1228         (main):
1229         * DumpRenderTree/chromium/LayoutTestController.cpp:
1230         (LayoutTestController::LayoutTestController):
1231         (LayoutTestController::layerTreeAsText):
1232         * DumpRenderTree/chromium/LayoutTestController.h:
1233         (LayoutTestController::setShowDebugLayerTree):
1234         * DumpRenderTree/chromium/TestShell.cpp:
1235         (TestShell::runFileTest):
1236         (TestShell::dump):
1237         * DumpRenderTree/chromium/TestShell.h:
1238         (TestParams::TestParams):
1239
1240 2011-03-21  Adam Roben  <aroben@apple.com>
1241
1242         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
1243
1244         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1245         output as plain text
1246
1247         Reviewed by David Kilzer.
1248
1249         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1250         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
1251         to the master.
1252         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
1253         since we're running on the build master, not the slave. Instead, turn the raw source of
1254         actual.html which the build slave uploaded into an HTML log.
1255
1256 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
1257
1258         Reviewed by Mihai Parparita.
1259
1260         new-run-webkit-tests: run tests in ascending alphabetical order per dir
1261         https://bugs.webkit.org/show_bug.cgi?id=56760
1262
1263         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1264         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1265         * Scripts/webkitpy/layout_tests/port/test.py:
1266
1267 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
1268
1269         Reviewed by Steve Block.
1270
1271         Media Stream API patch 0: adding compilation guards.
1272         https://bugs.webkit.org/show_bug.cgi?id=56458
1273
1274         Adding options to enable the media stream API feature in Chromium.
1275
1276         * Scripts/build-webkit:
1277
1278 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
1279
1280         Reviewed by Laszlo Gombos.
1281
1282         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
1283         https://bugs.webkit.org/show_bug.cgi?id=56323
1284
1285         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
1286         "--stdout" or "--stderr" option.
1287
1288         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1289         (WebCore::DumpRenderTree::~DumpRenderTree):
1290         (WebCore::DumpRenderTree::processArgsLine):
1291         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1292         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1293         (WebCore::DumpRenderTree::setRedirectOutputFileName):
1294         (WebCore::DumpRenderTree::setRedirectErrorFileName):
1295         * DumpRenderTree/qt/main.cpp:
1296         (isOption):
1297         (takeOptionValue):
1298         (printUsage):
1299         (main):
1300
1301 2011-03-21  Adam Roben  <aroben@apple.com>
1302
1303         Fix exceptions on the buildbot due to my last change
1304
1305         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1306         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
1307
1308 2011-03-21  Adam Roben  <aroben@apple.com>
1309
1310         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
1311
1312         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1313         output as plain text
1314
1315         Reviewed by Darin Adler.
1316
1317         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1318         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
1319         logs.
1320         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
1321         the build master. This will correctly treat it as HTML.
1322
1323 2011-03-20  Bill Budge  <bbudge@chromium.org>
1324
1325         Reviewed by Adam Barth.
1326
1327         Rename ThreadSafeShared to ThreadSafeRefCounted
1328         https://bugs.webkit.org/show_bug.cgi?id=56714
1329
1330         No new tests. Exposes no new functionality.
1331
1332         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
1333         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
1334         * Scripts/do-webcore-rename:
1335
1336 2011-03-19  Anton D'Auria  <adauria@apple.com>
1337
1338         Reviewed by Dan Bernstein.
1339
1340         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
1341         https://bugs.webkit.org/show_bug.cgi?id=56719
1342
1343         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
1344         (LayoutTestController::clearApplicationCacheForOrigin):
1345
1346 2011-03-19  Anton D'Auria  <adauria@apple.com>
1347
1348         Reviewed by Alexey Proskuryakov.
1349
1350         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1351         https://bugs.webkit.org/show_bug.cgi?id=56415
1352
1353         * DumpRenderTree/LayoutTestController.cpp:
1354         (clearApplicationCacheForOriginCallback):
1355         (LayoutTestController::staticFunctions):
1356         * DumpRenderTree/LayoutTestController.h:
1357         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
1358         (LayoutTestController::LayoutTestController):
1359         (LayoutTestController::clearAllApplicationCaches):
1360         (LayoutTestController::clearApplicationCacheForOrigin): 
1361         * DumpRenderTree/chromium/LayoutTestController.h:
1362         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1363         (LayoutTestController::clearApplicationCacheForOrigin):
1364         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1365         (LayoutTestController::clearApplicationCacheForOrigin):
1366         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1367         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1368         (LayoutTestController::clearApplicationCacheForOrigin):
1369         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1370         (LayoutTestController::clearApplicationCacheForOrigin):
1371
1372 2011-03-18  Dan Bernstein  <mitz@apple.com>
1373
1374         Revised build fix for r81135.
1375
1376         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1377         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1378
1379 2011-03-18  Adam Roben  <aroben@apple.com>
1380
1381         Windows build fix
1382
1383         * WebKitTestRunner/config.h: Add a missing #endif.
1384
1385 2011-03-18  Andreas Kling  <kling@webkit.org>
1386
1387         Unbreak Qt build after r81494.
1388
1389         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1390         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1391
1392 2011-03-18  Sam Weinig  <sam@webkit.org>
1393
1394         Fix windows build. This was really Adam Roben's fault. I swear!
1395
1396         * WebKitTestRunner/config.h:
1397
1398 2011-03-18  Sam Weinig  <sam@webkit.org>
1399
1400         Reviewed by Adam Roben.
1401
1402         Pixel tests don't work in WebKitTestRunner on Windows
1403         https://bugs.webkit.org/show_bug.cgi?id=56630
1404
1405         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1406         built-in snapshotting instead of using the window server on the Mac.
1407
1408         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1409         (WTR::InjectedBundle::InjectedBundle):
1410         (WTR::InjectedBundle::didReceiveMessage):
1411         (WTR::InjectedBundle::beginTesting):
1412         (WTR::InjectedBundle::done):
1413         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1414         (WTR::InjectedBundle::setPixelResult):
1415         (WTR::InjectedBundle::shouldDumpPixels):
1416         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1417         (WTR::InjectedBundlePage::dump):
1418         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1419
1420         * WebKitTestRunner/TestInvocation.cpp:
1421         (WTR::TestInvocation::invoke):
1422         (WTR::TestInvocation::dump):
1423         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1424         * WebKitTestRunner/TestInvocation.h:
1425         * WebKitTestRunner/cg: Added.
1426         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1427         (WTR::createCGContextFromImage):
1428         (WTR::computeMD5HashStringForContext):
1429         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1430         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1431         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1432
1433         * WebKitTestRunner/win/TestInvocationWin.cpp:
1434         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1435         Keep stub for Cairo build.
1436
1437         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1438         Add CG configuration.
1439
1440         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1441         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1442         Add new files.
1443
1444 2011-03-18  Adam Roben  <aroben@apple.com>
1445
1446         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1447
1448         Rubber-stamped by Simon Fraser.
1449
1450         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1451         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1452         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1453
1454 2011-03-18  Adam Roben  <aroben@apple.com>
1455
1456         Don't ellipsize long or indented function names in Leaks Viewer
1457
1458         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1459         scrollbar
1460
1461         Reviewed by Simon Fraser.
1462
1463         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1464         (.data-grid .data-container):
1465         (.data-grid td > div, .data-grid th > div):
1466         Allow the contents to extend to the right.
1467
1468 2011-03-18  Adam Roben  <aroben@apple.com>
1469
1470         Fix some leaks in DRT seen on the leaks bot
1471
1472         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1473         setWillSendRequestClearHeaderCallback in DRT are leaky
1474
1475         Reviewed by Alexey Proskuryakov.
1476
1477         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1478
1479         * DumpRenderTree/LayoutTestController.cpp:
1480         (addURLToRedirectCallback):
1481         (setWillSendRequestClearHeaderCallback):
1482         Use OwnArrayPtr to cause the strings to be deleted.
1483
1484 2011-03-18  Adam Roben  <aroben@apple.com>
1485
1486         Fix a NSURLCredential leak seen on the leaks bot
1487
1488         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1489         connection:didReceiveAuthenticationChallenge:] is leaky
1490
1491         Reviewed by John Sullivan.
1492
1493         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1494         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1495         cause the NSURLCredential to be released.
1496
1497 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1498
1499         Unreviewed.
1500
1501         Remove unnecessary brackets around my email address.
1502
1503         * Scripts/webkitpy/common/config/committers.py:
1504
1505 2011-03-18  Adam Roben  <aroben@apple.com>
1506         
1507         Remove some files I accidentally added in r81454
1508
1509         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1510         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1511
1512 2011-03-18  Adam Roben  <aroben@apple.com>
1513
1514         Ignore an NSNumberFormatter leak on SnowLeopard
1515
1516         * Scripts/old-run-webkit-tests:
1517         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1518         getObjectValue:forString:errorDescription:].
1519
1520 2011-03-18  Adam Roben  <aroben@apple.com>
1521
1522         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1523
1524         Rubber-stamped by Mark Rowe.
1525
1526         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1527         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1528         released.
1529
1530 2011-03-17  Adam Roben  <aroben@apple.com>
1531
1532         Address a review comment I missed in r81445
1533
1534         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1535         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1536         leaked bytes to speed up searching on long lines.
1537
1538 2011-03-17  Adam Roben  <aroben@apple.com>
1539
1540         Mark leaky builds orange, even if all regression tests passed
1541
1542         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1543         build.webkit.org when all tests pass even though there are still leaks
1544
1545         Reviewed by Dan Bernstein.
1546
1547         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1548         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1549         be marked orange if this build step generates warnings.
1550
1551 2011-03-17  Adam Roben  <aroben@apple.com>
1552
1553         Allow values in Leaks Viewer to be shown as percentages
1554
1555         Double-clicking on a column will toggle between showing percentages and showing real values.
1556
1557         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1558         number of leaked bytes in Leaks Viewer
1559
1560         Reviewed by Joe Pecoraro.
1561
1562         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1563         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
1564         node's totalTime, which is used in calculating percentages.
1565
1566         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1567         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
1568         showing them as percentages.
1569
1570 2011-03-17  Adam Roben  <aroben@apple.com>
1571
1572         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
1573
1574         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
1575         the number of leaked allocations. And the new Average column shows the average number of
1576         leaked bytes per call.
1577
1578         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
1579         just how many allocations
1580
1581         Reviewed by Joe Pecoraro.
1582
1583         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1584         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
1585         line and store it with the leak stack.
1586         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
1587         properties.
1588         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
1589         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
1590         .numberOfCalls now holds the number of leaked allocations.
1591
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1593         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
1594         appear.
1595         (monkeyPatchInspectorObjects): Format the values as bytes.
1596
1597 2011-03-17  Adam Roben  <aroben@apple.com>
1598
1599         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
1600
1601         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
1602         regression tests
1603
1604         Reviewed by James Robinson.
1605
1606         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1607         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
1608         is always populated, even when all regression tests pass.
1609
1610 2011-03-10  Hayato Ito  <hayato@chromium.org>
1611
1612         Reviewed by Tony Chang.
1613
1614         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
1615
1616         https://bugs.webkit.org/show_bug.cgi?id=56076
1617
1618         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1619
1620 2011-03-17  Adam Roben  <aroben@apple.com>
1621
1622         Skip a compositing-sensitive test when accelerated compositing is disabled
1623
1624         Reviewed by Sam Weinig.
1625
1626         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
1627         accelerated compositing is disabled.
1628
1629 2011-03-17  Adam Roben  <aroben@apple.com>
1630
1631         Start using PlatformSpecificScheduler for the Mac builders
1632
1633         The current set of file/directory patterns should work for Mac builders. We may discover
1634         that there are more files and directories we can exclude from the Mac builds, but they can
1635         be added later.
1636
1637         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
1638
1639         Reviewed by Mark Rowe.
1640
1641         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
1642         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
1643
1644         * Scripts/webkitpy/common/config/build.py:
1645         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
1646         cleaned up patterns a little bit.
1647
1648         * Scripts/webkitpy/common/config/build_unittest.py:
1649         (ShouldBuildTest): Fixed some expected results.
1650         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
1651         platforms.
1652
1653 2011-03-17  Jeff Miller  <jeffm@apple.com>
1654
1655         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
1656         
1657         *.mode*
1658         *.pbxuser
1659         *.perspective*
1660         project.xcworkspace
1661         xcuserdata
1662
1663         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1664         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1665         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1666         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1667         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1668
1669 2011-03-17  Adam Roben  <aroben@apple.com>
1670
1671         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
1672
1673         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
1674         mac-wk2
1675
1676         Reviewed by Anders Carlsson.
1677
1678         * Scripts/old-run-webkit-tests:
1679         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
1680         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
1681         we're running in WebKit2 mode.
1682
1683 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
1684
1685         Reviewed by Yury Semikhatsky.
1686
1687         Web Inspector: Clean up Inspector strings.
1688         https://bugs.webkit.org/show_bug.cgi?id=56557
1689
1690         Modify the script to deal correctly with "\xNN" escapes, and to
1691         check strings in Chromium's DevTools.js.
1692
1693         * Scripts/check-inspector-strings:
1694
1695 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
1696
1697         Reviewed by Benjamin Poulain.
1698
1699         Update autoinstall to install mechanize 0.2.4
1700         https://bugs.webkit.org/show_bug.cgi?id=56499
1701
1702         Newer versions of mechanize support HTTPS proxies, which is necessary
1703         for people using webkit-patch behind firewalls.
1704
1705         * Scripts/webkitpy/common/system/autoinstall.py:
1706         * Scripts/webkitpy/thirdparty/__init__.py:
1707
1708 2011-03-16  Sam Weinig  <sam@webkit.org>
1709
1710         Reviewed by Adam Roben.
1711
1712         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
1713         https://bugs.webkit.org/show_bug.cgi?id=56541
1714
1715         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1716         (WTR::InjectedBundlePage::willSendRequestForFrame):
1717         Check for an empty host in addition to a null host.  This bug was introduced
1718         when porting off of the KURL code and onto the WKURLRef version.
1719
1720 2011-03-16  Sam Weinig  <sam@webkit.org>
1721
1722         Reviewed by Adam Roben.
1723
1724         Add Lucas Forschler to the list of WebKit committers.
1725
1726         * Scripts/webkitpy/common/config/committers.py:
1727
1728 2011-03-16  Sam Weinig  <sam@webkit.org>
1729
1730         Reviewed upon and dictated through Adam Roben.
1731
1732         Escape crashing function names in results.html. This fixes an issue
1733         when a crash involves a type with templates.
1734
1735         * Scripts/old-run-webkit-tests:
1736
1737 2011-03-16  Daniel Sievers  <sievers@google.com>
1738
1739         Reviewed by James Robinson.
1740
1741         Add setting to always force compositing mode
1742         https://bugs.webkit.org/show_bug.cgi?id=56156
1743
1744         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1745         (main):
1746         * DumpRenderTree/chromium/TestShell.cpp:
1747         (TestShell::TestShell):
1748         (TestShell::resetWebSettings):
1749         * DumpRenderTree/chromium/TestShell.h:
1750         (TestShell::setForceCompositingMode):
1751         * DumpRenderTree/chromium/WebPreferences.cpp:
1752         (WebPreferences::reset):
1753         (WebPreferences::applyTo):
1754         * DumpRenderTree/chromium/WebPreferences.h:
1755
1756 2011-03-15  Hayato Ito  <hayato@chromium.org>
1757
1758         Reviewed by Ojan Vafai.
1759
1760         Ignore files that will be used by reftests in old-run-webkit-tests.
1761
1762         https://bugs.webkit.org/show_bug.cgi?id=55936
1763
1764         * Scripts/old-run-webkit-tests:
1765
1766 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1767
1768         Reviewed by Adam Roben.
1769
1770         Function relativeScriptsDir doesn't return the correct relative
1771         Scripts directory.
1772
1773         * Scripts/webkitdirs.pm:
1774         (relativeScriptsDir): Ensure we use the directory that contains
1775         webkitdirs.pm, not the one that contains the original script that
1776         was invoked.
1777
1778 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1779
1780         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1781         fix to link against the Security framework after recent WebKitSystemInterface changes.
1782
1783         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1784         (LayoutTestController::originsWithLocalStorage):
1785         * wx/build/settings.py:
1786         * wx/build/waf_extensions.py:
1787
1788 2011-03-15  Sam Weinig  <sam@webkit.org>
1789
1790         Reviewed by Darin Adler.
1791
1792         Add script to convert a patch to a prettypatch and show in the default browser
1793         https://bugs.webkit.org/show_bug.cgi?id=56416
1794
1795         This can be used either like
1796             $ svn-create-patch | show-pretty-diff
1797         or
1798             $ show-pretty-diff patch.diff
1799
1800         * Scripts/show-pretty-diff: Added.
1801
1802 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
1803
1804         Rubber-stamped by Adam Roben.
1805
1806         Adding myself as a reviewer.
1807
1808         * Scripts/webkitpy/common/config/committers.py:
1809
1810 2011-03-15  Anders Carlsson  <andersca@apple.com>
1811
1812         Try to fix the Windows build.
1813
1814         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1815         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1816
1817 2011-03-15  Anders Carlsson  <andersca@apple.com>
1818
1819         Reviewed by Sam Weinig.
1820
1821         Make sure that NP_Shutdown is always the last NPP function called
1822         https://bugs.webkit.org/show_bug.cgi?id=56391
1823
1824         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
1825
1826         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1827         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1828         (PluginTest::PluginTest):
1829         (PluginTest::NP_Shutdown):
1830         (PluginTest::registerNPShutdownFunction):
1831         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1832         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
1833         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
1834         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1835         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
1836         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
1837         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
1838         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
1839         (NPDeallocateCalledBeforeNPShutdown::shutdown):
1840         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1841         (NP_Shutdown):
1842         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1843         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1844         * GNUmakefile.am:
1845
1846 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1847
1848         Reviewed by Tony Chang.
1849
1850         Autofilled form elements are assigned fixed background color but not text color
1851         https://bugs.webkit.org/show_bug.cgi?id=48382
1852
1853         * DumpRenderTree/LayoutTestController.cpp:
1854         (setAutofilledCallback): Added.
1855         (LayoutTestController::staticFunctions):
1856         * DumpRenderTree/LayoutTestController.h:
1857         * DumpRenderTree/chromium/LayoutTestController.cpp:
1858         (LayoutTestController::LayoutTestController):
1859         (LayoutTestController::setAutofilled): Added.
1860         * DumpRenderTree/chromium/LayoutTestController.h:
1861         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1862         (LayoutTestController::setAutofilled): Added.
1863         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1864         (LayoutTestController::setAutofilled): Added.
1865         (LayoutTestController::setValueForUser): Style tweak.
1866         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1867         (LayoutTestController::setAutofilled): Added (stub).
1868         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1869         (LayoutTestController::setAutofilled): Added (stub).
1870
1871 2011-03-15  Dan Bernstein  <mitz@apple.com>
1872
1873         Build fix after r81135.
1874
1875         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1876
1877 2011-03-15  Dan Bernstein  <mitz@apple.com>
1878
1879         Build fix after r81135.
1880
1881         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1882         * WebKitTestRunner/mac/TestControllerMac.mm:
1883         * WebKitTestRunner/mac/TestInvocationMac.mm:
1884         * WebKitTestRunner/mac/main.mm:
1885
1886 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
1887
1888         Reviewed by Adam Barth.
1889
1890         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
1891         https://bugs.webkit.org/show_bug.cgi?id=56349
1892
1893         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
1894         on platforms where we use it. Copied from DumpRenderTree.pro.
1895
1896 2011-03-15  Dan Bernstein  <mitz@apple.com>
1897
1898         Build fix after r81135.
1899
1900         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1901         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1902
1903 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1904
1905         Reviewed by Darin Adler.
1906
1907         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1908         info into the headers rather than in export symbol definition files, but disable it on 
1909         all platforms initially so we can deal with port build issues one port at a time.
1910         
1911         https://bugs.webkit.org/show_bug.cgi?id=27551
1912
1913         * DumpRenderTree/cg/ImageDiffCG.cpp:
1914         * DumpRenderTree/chromium/config.h:
1915         * DumpRenderTree/config.h:
1916         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1917         * TestWebKitAPI/TestWebKitAPIPrefix.h:
1918         * WebKitAPITest/HostWindow.cpp:
1919         * WebKitAPITest/TestsController.cpp:
1920         * WebKitAPITest/config.h: Added.
1921         * WebKitAPITest/main.cpp:
1922         * WebKitAPITest/tests/WebViewDestruction.cpp:
1923         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1924         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1925         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1926         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1927         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1928         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1929         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1930         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1931         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1932         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1933         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1934         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
1935         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1936         * WebKitTestRunner/TestController.cpp:
1937         * WebKitTestRunner/TestInvocation.cpp:
1938         * WebKitTestRunner/config.h: Added.
1939         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1940         * WebKitTestRunner/qt/TestControllerQt.cpp:
1941         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1942         * WebKitTestRunner/qt/main.cpp:
1943         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1944         * WebKitTestRunner/win/TestControllerWin.cpp:
1945         * WebKitTestRunner/win/TestInvocationWin.cpp:
1946         * WebKitTestRunner/win/main.cpp:
1947         * wx/build/settings.py:
1948
1949 2011-03-15  Hayato Ito  <hayato@chromium.org>
1950
1951         Reviewed by Shinichiro Hamaji.
1952
1953         [NRWT] Add support for reftests to new-run-webkit-tests.
1954
1955         https://bugs.webkit.org/show_bug.cgi?id=55457
1956
1957         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1958         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1959         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1960         * Scripts/webkitpy/layout_tests/port/base.py:
1961         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1962         * Scripts/webkitpy/layout_tests/port/test.py:
1963         * Scripts/webkitpy/layout_tests/port/test_files.py:
1964         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1965
1966 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
1967
1968         Reviewed by Martin Robinson.
1969
1970         [GTK] Fix compilation warning after r80892
1971         https://bugs.webkit.org/show_bug.cgi?id=56302
1972
1973         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1974         (LayoutTestController::originsWithLocalStorage):
1975
1976 2011-03-15  Robert Hogan  <robert@webkit.org>
1977
1978         Reviewed by Adam Barth.
1979
1980         Document the qmakearg argument, and hint how to build webkit2 on Qt
1981         https://bugs.webkit.org/show_bug.cgi?id=56326
1982
1983         * Scripts/build-webkit: add --qmakearg to build-webkit --help
1984
1985 2011-03-15  Adam Roben  <aroben@apple.com>
1986
1987         Make Windows 7 Release (Tests) a core builder
1988
1989         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1990         give it a few more days of greenness first.
1991
1992         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1993
1994         Reviewed by Sam Weinig.
1995
1996         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1997         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1998
1999         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2000         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2001         Updated the core regexps to match the buildbot module. Updated the expected results to match
2002         the current set of core builders.
2003
2004 2011-03-14  Adam Roben  <aroben@apple.com>
2005
2006         Add forgotten file from r81116
2007
2008         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
2009
2010 2011-03-14  Sam Weinig  <sam@webkit.org>
2011
2012         Reviewed by Adam Roben.
2013
2014         about:blank fake responses don't get serialized when sent the UIProcess
2015         <rdar://problem/9108119>
2016         https://bugs.webkit.org/show_bug.cgi?id=56357
2017
2018         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2019         (TestWebKitAPI::decidePolicyForResponse):
2020         (TestWebKitAPI::TEST):
2021         Add test that loads of about:blank have a response with a MIMEType of text/html.
2022
2023         * TestWebKitAPI/PlatformUtilities.h:
2024         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2025         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2026         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2027         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2028         Add helper to get the MIMEType from a WKURLResponse.
2029
2030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2031         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2032         Add new files.
2033
2034 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2035
2036         Reviewed by Kenneth Rohde Christiansen.
2037
2038         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2039         https://bugs.webkit.org/show_bug.cgi?id=56006
2040
2041         * QtTestBrowser/launcherwindow.cpp:
2042         (LauncherWindow::initializeView):
2043         * QtTestBrowser/main.cpp:
2044         (LauncherApplication::handleUserOptions):
2045
2046 2011-03-14  James Kozianski  <koz@chromium.org>
2047
2048         Reviewed by Ojan Vafai.
2049
2050         Add method to make BuildBot return test outputs
2051         https://bugs.webkit.org/show_bug.cgi?id=54374
2052
2053         The Builder.latest_cached_build will be used by the new rebaseline
2054         script to determine the build to use baselines from.
2055
2056         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2057         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2058
2059 2011-03-14  Adam Roben  <aroben@apple.com>
2060
2061         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2062
2063         Reviewed by Sam Weinig.
2064
2065         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2066         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2067         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2068         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2069         ensure the web process is initialized, then ask the bundle to run the test and assert that
2070         it succeeded.
2071
2072         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2073         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2074         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2075         handle a given URL.
2076         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2077         URL type cannot be handled).
2078         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2079         result.
2080
2081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2082         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2083         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2084         Added new files to the project.
2085
2086 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2087
2088         Unreviewed, rolling out r81094.
2089         http://trac.webkit.org/changeset/81094
2090         https://bugs.webkit.org/show_bug.cgi?id=56355
2091
2092         Broke the chromium DRT related build. (Requested by dave_levin
2093         on #webkit).
2094
2095         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2096         (main):
2097         * DumpRenderTree/chromium/LayoutTestController.cpp:
2098         (LayoutTestController::LayoutTestController):
2099         (LayoutTestController::layerTreeAsText):
2100         * DumpRenderTree/chromium/LayoutTestController.h:
2101         * DumpRenderTree/chromium/TestShell.cpp:
2102         (TestShell::runFileTest):
2103         (TestShell::dump):
2104         * DumpRenderTree/chromium/TestShell.h:
2105         (TestParams::TestParams):
2106
2107 2011-03-14  Daniel Sievers  <sievers@google.com>
2108
2109         Reviewed by Simon Fraser.
2110
2111         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2112         https://bugs.webkit.org/show_bug.cgi?id=56139
2113
2114         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2115         (main):
2116         * DumpRenderTree/chromium/LayoutTestController.cpp:
2117         (LayoutTestController::LayoutTestController):
2118         (LayoutTestController::layerTreeAsText):
2119         * DumpRenderTree/chromium/LayoutTestController.h:
2120         (LayoutTestController::setShowDebugLayerTree):
2121         * DumpRenderTree/chromium/TestShell.cpp:
2122         (TestShell::runFileTest):
2123         (TestShell::dump):
2124         * DumpRenderTree/chromium/TestShell.h:
2125         (TestParams::TestParams):
2126
2127 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2128
2129         Reviewed by Adam Roben.
2130
2131         [Qt][WK2]Unbreak InjectedBundle on Qt
2132         https://bugs.webkit.org/show_bug.cgi?id=54109
2133
2134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2135         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
2136         API's instead of KURL to analyze the URL.
2137         * WebKitTestRunner/StringFunctions.h:
2138         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
2139         in the WebKitTestRunner project.
2140         (WTR::toWK): Use adoptWK.
2141         (WTR::operator<<): Added helper for printing a WKURL.
2142         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
2143         against WebCore.
2144
2145 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2146
2147         Reviewed by Kenneth Rohde Christiansen.
2148
2149         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
2150         https://bugs.webkit.org/show_bug.cgi?id=56321
2151
2152         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
2153         to the list of exceptions for WebKit2 C API headers.
2154
2155 2011-03-14  Adam Roben  <aroben@apple.com>
2156
2157         Show the list of recent leaky builds in reverse chronological order
2158
2159         Previously they were being shown in a deterministic but surprising order based on
2160         lexicographically sorting the build offsets (-1, -10, -2, -3...).
2161
2162         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
2163
2164         Reviewed by Darin Adler.
2165
2166         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2167         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
2168         callback.
2169
2170 2011-03-14  Adam Roben  <aroben@apple.com>
2171
2172         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
2173
2174         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
2175         analyze
2176
2177         Reviewed by David Kilzer and Joe Pecoraro.
2178
2179         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2180         (#url-prompt): Made this a bit taller to make room for the list of builds.
2181
2182         (#recent-builds-loading-indicator):
2183         (#recent-builds-list):
2184         Added styles for the build list and loading indicator.
2185
2186         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2187         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
2188         it. This will unescape it.
2189         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
2190         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
2191         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
2192         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
2193         prompt UI.
2194         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
2195         now also used when a recent build is clicked.
2196
2197         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
2198         (RecentBuildsLoader): Store the callback.
2199         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
2200         builder. Find the revision number, leak count, and results URL for each one. Pass the
2201         resulting info to our callback.
2202
2203         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2204         (range): Added this helper function to return an array containing the integers [0, n).
2205
2206         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
2207         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
2208
2209 2011-03-14  Mark Rowe  <mrowe@apple.com>
2210
2211         Reviewed by Adam Roben.
2212
2213         Fix two memory leaks within LayoutTestController's storage support.
2214
2215         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2216         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
2217         by JSStringCreateWithCFString.
2218         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
2219         allocate.
2220
2221 2011-03-14  Mark Rowe  <mrowe@apple.com>
2222
2223         Reviewed by Oliver Hunt.
2224
2225         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
2226
2227         * DumpRenderTree/LayoutTestController.cpp:
2228         (LayoutTestController::staticFunctions): Remove duplicate entries.
2229
2230 2011-03-14  Alice Liu  <alice.liu@apple.com>
2231
2232         Reviewed by Dan Bernstein.
2233
2234         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
2235
2236         * DumpRenderTree/mac/PerlSupport/Makefile:
2237         Add whitespace when joining "-arch" with the architectures passed in as arguments.
2238
2239 2011-03-14  Daniel Bates  <dbates@rim.com>
2240
2241         https://bugs.webkit.org/show_bug.cgi?id=55438
2242         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
2243         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
2244
2245         * Scripts/build-webkit:
2246
2247 2011-03-14  Daniel Bates  <dbates@rim.com>
2248
2249         Reviewed by David Kilzer.
2250
2251         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
2252         https://bugs.webkit.org/show_bug.cgi?id=55438
2253
2254         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
2255         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
2256         CMake arguments for feature defines.
2257
2258         * Scripts/build-webkit:
2259           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
2260           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
2261           - Sorted forward declarations.
2262           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
2263             Modified call sites as needed.
2264         * Scripts/webkitdirs.pm:
2265           - Added cleanCMakeGeneratedProject() to clean a CMake build.
2266           - Added buildCMakeGeneratedProject() to build using generated build system.
2267           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
2268           - Added generateBuildSystemFromCMakeProject() to generate the build system from
2269             a CMake project.
2270           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
2271
2272 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
2273
2274         Reviewed by Steve Block.
2275
2276         Detach Geolocation from Frame when Page destroyed.
2277         https://bugs.webkit.org/show_bug.cgi?id=52877
2278
2279         Extend the layout test controller to expose the number of pending
2280         geolocation requests, so that we can test that the requests have
2281         been cancelled on page close.
2282
2283         * DumpRenderTree/LayoutTestController.cpp:
2284         (numberOfPendingGeolocationPermissionRequestsCallback):
2285         (LayoutTestController::staticFunctions):
2286         * DumpRenderTree/LayoutTestController.h:
2287         * DumpRenderTree/chromium/LayoutTestController.cpp:
2288         (LayoutTestController::LayoutTestController):
2289         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2290         * DumpRenderTree/chromium/LayoutTestController.h:
2291         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2292         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2293         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2294         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2295         * DumpRenderTree/mac/UIDelegate.h:
2296         * DumpRenderTree/mac/UIDelegate.mm:
2297         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2298         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2299         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2300         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2301         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2302         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2303         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2304         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2305
2306
2307 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2308
2309         Unreviewed. Modify my email address in committers.py.
2310
2311         * Scripts/webkitpy/common/config/committers.py:
2312
2313 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
2314
2315         Reviewed by Kenneth Rohde Christiansen.
2316
2317         [Qt] QtLauncher does not load the same set of fonts as the DRT
2318         https://bugs.webkit.org/show_bug.cgi?id=34959
2319
2320         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
2321         When this option is used the webkit fonts are loaded the same
2322         as they are in DumpRenderTree.  This option can be used on
2323         QtTestBrowser and run-launcher.  It can only be used
2324         on Linux systems with FcInit and is configured as such.
2325
2326         * QtTestBrowser/launcherwindow.h:
2327         (WindowOptions::WindowOptions):
2328         * QtTestBrowser/main.cpp:
2329         (initWebKitTestFonts):
2330         (launcherMain):
2331         (LauncherApplication::handleUserOptions):
2332
2333 2011-03-12  Dan Bernstein  <mitz@apple.com>
2334
2335         Reviewed by Mark Rowe.
2336
2337         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
2338         DumpRenderTree is being built for.
2339
2340         * DumpRenderTree/mac/PerlSupport/Makefile:
2341
2342 2011-03-12  Dan Bernstein  <mitz@apple.com>
2343
2344         Suggested by Mark Rowe.
2345
2346         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
2347         as they were before r80915.
2348
2349 2011-03-12  Anders Carlsson  <andersca@apple.com>
2350
2351         Reviewed by Sam Weinig.
2352
2353         Should be able to download a PDF to the Downloads folder
2354         https://bugs.webkit.org/show_bug.cgi?id=56256
2355
2356         * MiniBrowser/mac/BrowserWindowController.m:
2357         (-[BrowserWindowController awakeFromNib]):
2358         * WebKitTestRunner/TestController.cpp:
2359         (WTR::TestController::createOtherPage):
2360         (WTR::TestController::initialize):
2361         Update for API changes.
2362
2363 2011-03-11  Anton D'Auria  <adauria@apple.com>
2364
2365         Reviewed and landed by Brady Eidson.
2366
2367         https://bugs.webkit.org/show_bug.cgi?id=51878
2368         Add WebKit1 API to view and delete local storage
2369
2370         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2371
2372         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2373         * DumpRenderTree/LayoutTestController.cpp:
2374         (syncLocalStorageCallback):
2375         (observeStorageTrackerNotificationsCallback):
2376         (deleteAllLocalStorageCallback):
2377         (deleteLocalStorageForOriginCallback):
2378         (originsWithLocalStorageCallback):
2379         (LayoutTestController::staticFunctions):
2380         * DumpRenderTree/LayoutTestController.h:
2381         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2382         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2383         (-[StorageTrackerDelegate init]):
2384         (-[StorageTrackerDelegate logNotifications:controller:]):
2385         (-[StorageTrackerDelegate originModified:]):
2386         (-[StorageTrackerDelegate dealloc]):
2387         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2388         * DumpRenderTree/chromium/LayoutTestController.cpp:
2389         (LayoutTestController::LayoutTestController):
2390         (LayoutTestController::deleteAllLocalStorage):
2391         (LayoutTestController::originsWithLocalStorage):
2392         (LayoutTestController::deleteLocalStorageForOrigin):
2393         (observeStorageTrackerNotifications):
2394         (syncLocalStorage):
2395         * DumpRenderTree/chromium/LayoutTestController.h:
2396         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2397         (LayoutTestController::originsWithLocalStorage):
2398         (LayoutTestController::deleteAllLocalStorage):
2399         (LayoutTestController::deleteLocalStorageForOrigin):
2400         (LayoutTestController::observeStorageTrackerNotifications):
2401         (LayoutTestController::syncLocalStorage):
2402         * DumpRenderTree/mac/DumpRenderTree.mm:
2403         (resetDefaultsToConsistentValues):
2404         (allocateGlobalControllers):
2405         (releaseGlobalControllers):
2406         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2407         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2408         (LayoutTestController::syncLocalStorage):
2409         (LayoutTestController::observeStorageTrackerNotifications):
2410         (LayoutTestController::deleteAllLocalStorage):
2411         (LayoutTestController::originsWithLocalStorage):
2412         (LayoutTestController::deleteLocalStorageForOrigin):
2413         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2414         (LayoutTestController::originsWithLocalStorage):
2415         (LayoutTestController::deleteAllLocalStorage):
2416         (LayoutTestController::deleteLocalStorageForOrigin):
2417         (LayoutTestController::observeStorageTrackerNotifications):
2418         (LayoutTestController::syncLocalStorage):
2419         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2420         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2421         (LayoutTestController::clearAllApplicationCaches):
2422         (LayoutTestController::syncLocalStorage):
2423         (LayoutTestController::observeStorageTrackerNotifications):
2424         (LayoutTestController::clearAllDatabases):
2425         (LayoutTestController::deleteAllLocalStorage):
2426         (LayoutTestController::originsWithLocalStorage):
2427         (LayoutTestController::deleteLocalStorageForOrigin):
2428         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2429         (LayoutTestController::syncLocalStorage):
2430         (LayoutTestController::observeStorageTrackerNotifications):
2431         (LayoutTestController::clearAllDatabases):
2432         (LayoutTestController::deleteAllLocalStorage):
2433         (LayoutTestController::originsWithLocalStorage):
2434         (LayoutTestController::deleteLocalStorageForOrigin):
2435
2436 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2437
2438         Reviewed by Adam Roben.
2439
2440         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2441         Process has finished launching.
2442         https://bugs.webkit.org/show_bug.cgi?id=56208
2443
2444         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2445         (TestWebKitAPI::TEST):
2446         Test that calling WKContextClearResourceCaches works with both options when called before
2447         the Web Process is valid.
2448
2449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2450         Add the new test.
2451         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2452         Ditto.
2453
2454 2011-03-11  Adam Roben  <aroben@apple.com>
2455
2456         Make it possible to view all leaks from a build at once in Leaks Viewer
2457
2458         You can now give Leaks Viewer the URL of a build results page (e.g.,
2459         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2460         will load all the leaks files from that build.
2461
2462         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2463         files from a particular build at once, rather than one at a time
2464
2465         Reviewed by David Kilzer.
2466
2467         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2468         (LeaksLoader): Initialize our properties.
2469         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2470         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2471         from that page.
2472         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2473         so it can provide feedback. Then load each one and pass it to the client.
2474         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2475         it into a DOM, pull out all the links to leaks files, and load each one.
2476
2477         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2478         (LeaksParser): Initialize our worker.
2479         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2480
2481         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2482         This code mostly came from Worker.js.
2483         (LeaksParserWorker): Initialize our profile.
2484         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2485         profile.
2486         (LeaksParserWorker.prototype._parseLeaks):
2487         (LeaksParserWorker.prototype._createNode):
2488         (LeaksParserWorker.prototype._incorporateLeaks):
2489         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2490         version of createProfile which adds to this.profile instead of making a new profile each
2491         time.
2492         (onmessage): Parse the file and send back the new profile.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2495         (#loading-indicator):
2496         (#spinner):
2497         (#loading-indicator-label):
2498         Tweaked styles to accomodate a longer label.
2499
2500         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2501         (LeaksViewer.loaded): Set up a loader and parser.
2502
2503         (LeaksViewer.get filesLeftToParse):
2504         (LeaksViewer.set filesLeftToParse):
2505         Added these simple accessors.
2506
2507         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2508         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2509         the parser.
2510         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2511         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2512         _loadLeaksFromURL function).
2513         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2514         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2515         loading indicator, including the number of files being loaded.
2516         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2517         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2518         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2519         _loadingIndicatorText.
2520
2521         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2522         (getResource): Moved here from LeaksViewer.js.
2523
2524         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2525         LeaksParserWorker.js.
2526
2527         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2528         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2529
2530 2011-03-11  Adam Roben  <aroben@apple.com>
2531
2532         Don't trigger a build when build.webkit.org's HTML files are modified
2533
2534         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2535
2536         Reviewed by Dan Bernstein.
2537
2538         * Scripts/webkitpy/common/config/build.py:
2539         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2540         directories that shouldn't trigger builds. Re-sorted the list.
2541
2542         * Scripts/webkitpy/common/config/build_unittest.py:
2543         (ShouldBuildTest): Added a test to cover the above change.
2544
2545 2011-03-11  Adam Roben  <aroben@apple.com>
2546
2547         Roll out r80848
2548
2549         It was accidentally committed.
2550
2551         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2552         (LeaksViewer._loadLeaksFromURL):
2553
2554 2011-03-11  Tony Chang  <tony@chromium.org>
2555
2556         Reviewed by Ojan Vafai.
2557
2558         kill hung lighttpd processes on the chromium win bot
2559         https://bugs.webkit.org/show_bug.cgi?id=56152
2560
2561         Sometimes this process doesn't exit and it holds on to
2562         a log file that we can't delete or copy, causing the tests
2563         to go red.
2564
2565         * BuildSlaveSupport/win/kill-old-processes:
2566
2567 2011-03-11  Ilya Sherman  <isherman@chromium.org>
2568
2569         Reviewed by Kent Tamura.
2570
2571         [Chromium] missing HTMLInputElement::setValueForUser() to tests
2572         https://bugs.webkit.org/show_bug.cgi?id=55854
2573
2574         * DumpRenderTree/chromium/LayoutTestController.cpp:
2575         (LayoutTestController::LayoutTestController):
2576         (LayoutTestController::setValueForUser): Added.
2577         * DumpRenderTree/chromium/LayoutTestController.h:
2578
2579 2011-03-10  Peter Kasting  <pkasting@google.com>
2580
2581         Reviewed by Dimitri Glazkov.
2582
2583         Clean up some gross code in TestShellWin.cpp.  No functional change.
2584         https://bugs.webkit.org/show_bug.cgi?id=56048
2585
2586         * DumpRenderTree/chromium/TestShellWin.cpp:
2587         (checkLayoutTestSystemDependencies):
2588
2589 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
2590
2591         Reviewed by Laszlo Gombos.
2592
2593         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
2594
2595         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2596         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
2597
2598 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2599
2600         Reviewed by Kenneth Rohde Christiansen.
2601
2602         [EFL] Make single backing store the default for EWebLauncher
2603         https://bugs.webkit.org/show_bug.cgi?id=55753
2604
2605         Set single backing store the default for EWebLauncher.
2606
2607         * EWebLauncher/main.c:
2608         (main):
2609
2610 2011-03-10  Adam Roben  <aroben@apple.com>
2611
2612         Ignore errors from files being held open when creating a test result archive
2613
2614         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
2615         fails to delete the results directory
2616
2617         Reviewed by Mark Rowe.
2618
2619         * BuildSlaveSupport/test-result-archive:
2620         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
2621         thrown when a process is holding a file open.
2622
2623 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2624
2625         Unreviewed, rolling out r80701.
2626         http://trac.webkit.org/changeset/80701
2627         https://bugs.webkit.org/show_bug.cgi?id=56126
2628
2629         fast/dom/Geolocation/window-close-crash.html fails on Snow
2630         Leopard release builds (Requested by mihaip on #webkit).
2631
2632         * DumpRenderTree/LayoutTestController.cpp:
2633         (LayoutTestController::staticFunctions):
2634         * DumpRenderTree/LayoutTestController.h:
2635         * DumpRenderTree/chromium/LayoutTestController.cpp:
2636         (LayoutTestController::LayoutTestController):
2637         * DumpRenderTree/chromium/LayoutTestController.h:
2638         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2639         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2640         * DumpRenderTree/mac/UIDelegate.h:
2641         * DumpRenderTree/mac/UIDelegate.mm:
2642         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2643         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2644         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2645         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2646
2647 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2648
2649         Reviewed by Gustavo Noronha Silva.
2650
2651         [GTK] run-gtk-tests doesn't fail if a test crashes
2652         https://bugs.webkit.org/show_bug.cgi?id=56089
2653
2654         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
2655         even if a test crashes. So run the tests individually and if a
2656         test fails remember its exit code so run-gtk-test fails too, if
2657         required.
2658
2659 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2660
2661         Reviewed by Dmitry Titov.
2662
2663         Detach Geolocation from Frame when Page destroyed.
2664         https://bugs.webkit.org/show_bug.cgi?id=52877
2665
2666         Extend the layout test controller to expose the number of pending
2667         geolocation requests, so that we can test that the requests have
2668         been cancelled on page close.
2669
2670         * DumpRenderTree/LayoutTestController.cpp:
2671         (numberOfPendingGeolocationPermissionRequestsCallback):
2672         (LayoutTestController::staticFunctions):
2673         * DumpRenderTree/LayoutTestController.h:
2674         * DumpRenderTree/chromium/LayoutTestController.cpp:
2675         (LayoutTestController::LayoutTestController):
2676         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2677         * DumpRenderTree/chromium/LayoutTestController.h:
2678         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2679         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2680         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2681         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2682         * DumpRenderTree/mac/UIDelegate.h:
2683         * DumpRenderTree/mac/UIDelegate.mm:
2684         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2685         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2686         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2687         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2688         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2689         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2690         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2691         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2692
2693
2694 2011-03-09  Adam Roben  <aroben@apple.com>
2695
2696         Hide Leaks Viewer's URL prompt by default
2697
2698         We will show it as needed. I think I left it visible by default by accident after doing some
2699         testing.
2700
2701         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
2702         URL is passed as a query parameter, but does
2703
2704         Reviewed by Simon Fraser.
2705
2706         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2707
2708 2011-03-09  Adam Roben  <aroben@apple.com>
2709
2710         Don't use Element.classList or box-shadow in Leaks Viewer
2711
2712         They aren't supported by Safari 5. Luckily we have substitutes for them!
2713
2714         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
2715
2716         Reviewed by Simon Fraser.
2717
2718         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2719         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
2720
2721         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2722         (LeaksViewer.urlPromptButtonClicked):
2723         (LeaksViewer._displayURLPrompt):
2724         (LeaksViewer._setLoadingIndicatorHidden):
2725         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
2726
2727 2011-03-09  Adam Roben  <aroben@apple.com>
2728
2729         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
2730
2731         Rubber-stamped by David Kilzer.
2732
2733         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2734
2735 2011-03-09  Adam Roben  <aroben@apple.com>
2736
2737         Add a Leaks Viewer tool to build.webkit.org
2738
2739         This tool parses leaks from the files generated by the leaks bot and displays them in a
2740         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2741         code).
2742
2743         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2744         be passed to the tool via the "url" query parameter.
2745
2746         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2747         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2748         Inspector's Heavy profile view. But it's still pretty useful as-is.
2749
2750         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2751
2752         Reviewed by Darin Adler.
2753
2754         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2755         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2756         (#url-prompt): This is the prompt itself.
2757
2758         (#loading-indicator):
2759         (#loading-indicator > img):
2760         These show a spinner in the bottom-right when we're loading a leaks file.
2761
2762         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2763         as percentages.
2764
2765         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2766         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2767         URL if one wasn't given to us as a query parameter).
2768
2769         (LeaksViewer.get loading):
2770         (LeaksViewer.set loading):
2771         (LeaksViewer.get url):
2772         (LeaksViewer.set url):
2773         Pretty simple accessors.
2774
2775         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2776         prompt.
2777         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2778         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2779         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2780         the profile to the Web Inspector code once it's been created.
2781         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2782         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2783         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2784         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2785
2786         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
2787         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
2788         (ProfilerAgent.getProfile): Store the callback.
2789         (ProfilerAgent.profileReady): Call the callback.
2790         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
2791         count and total leak counts as real values, not percentages or milliseconds.
2792
2793         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
2794         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
2795         (parseLeaks): Extract call stacks out of a leaks file.
2796         (createNode): Helper function to create a new empty profile node.
2797         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
2798         WebInspector.ProfileView.
2799
2800         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
2801
2802 2011-03-09  Dan Bernstein  <mitz@apple.com>
2803
2804         Reviewed by Adam Roben.
2805
2806         Combine multiple --ignore-tests values
2807         https://bugs.webkit.org/show_bug.cgi?id=56016
2808
2809         * Scripts/old-run-webkit-tests:
2810
2811 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
2812
2813         Reviewed by David Levin.
2814
2815         Adding myself to the committer file.
2816
2817         * Scripts/webkitpy/common/config/committers.py:
2818
2819 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2820
2821         Rubber-stamped by Adam Roben.
2822
2823         Fix two leaks I introduced into the API tests.
2824
2825         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2826         (TestWebKitAPI::TEST):
2827
2828 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2829
2830         Reviewed by Anders Carlsson.
2831
2832         Crash in CFNetwork visiting google.com
2833         https://bugs.webkit.org/show_bug.cgi?id=55958
2834
2835         Add a test for not trying to copy a null CFURLResponse.
2836
2837         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
2838         (TestWebKitAPI::TEST):
2839         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2840
2841 2011-03-08  Hayato Ito  <hayato@chromium.org>
2842
2843         Reviewed by Ojan Vafai.
2844
2845         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
2846
2847         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
2848
2849         https://bugs.webkit.org/show_bug.cgi?id=55450
2850
2851         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2852
2853 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2854
2855         Reviewed by Martin Robinson.
2856
2857         [GTK] Add layoutTestController.setValueForUser() after r80412
2858         https://bugs.webkit.org/show_bug.cgi?id=55862
2859
2860         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2861         (LayoutTestController::setValueForUser): Implement setValueForUser()
2862
2863 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
2864
2865         Reviewed by Adam Barth.
2866
2867         Add script_shell_command to WebKitPort
2868         https://bugs.webkit.org/show_bug.cgi?id=55925
2869
2870         Add a central place where we generate the shell command from the script name.
2871         This function will be used later to detect the correct script interpreter on Win32.
2872
2873         * Scripts/webkitpy/common/config/ports.py:
2874         * Scripts/webkitpy/layout_tests/port/base.py:
2875         * Scripts/webkitpy/tool/steps/abstractstep.py:
2876         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2877
2878 2011-03-07  Ojan Vafai  <ojan@chromium.org>
2879
2880         Reviewed by Adam Barth.
2881
2882         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
2883         https://bugs.webkit.org/show_bug.cgi?id=55749
2884
2885         * Scripts/webkitpy/tool/commands/upload.py:
2886         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2887         * Scripts/webkitpy/tool/steps/__init__.py:
2888         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
2889         * Scripts/webkitpy/tool/steps/options.py:
2890
2891 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
2892
2893         Reviewed by David Levin.
2894
2895         Add support for DataTransferItems
2896         https://bugs.webkit.org/show_bug.cgi?id=55115
2897
2898         Enable data transfer items in DRT.
2899
2900         * DumpRenderTree/chromium/TestShell.cpp:
2901         (TestShell::TestShell):
2902
2903 2011-03-06  Ojan Vafai  <ojan@chromium.org>
2904
2905         Reviewed by Tony Chang.
2906
2907         [test dashboard] pull treemap files
2908         https://bugs.webkit.org/show_bug.cgi?id=55852
2909
2910         * TestResultServer/handlers/dashboardhandler.py:
2911
2912 2011-03-03  Hayato Ito  <hayato@chromium.org>
2913
2914         Reviewed by Mihai Parparita.
2915
2916         [NRWT] Clear output image file used by DumpRenderTree to make sure the
2917         previous image should not be used in the ChromiumDriver.
2918
2919         Also make sure that output image from the ChromiumDriver should be ''
2920         (empty string) if a test crashes for consistency with the WebKitDriver
2921         implementation.
2922
2923         https://bugs.webkit.org/show_bug.cgi?id=55746
2924
2925         * Scripts/webkitpy/layout_tests/port/chromium.py:
2926
2927 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
2928
2929         Reviewed by Martin Robinson.
2930
2931         [Gtk] fast/js/navigator-language.html fails locally
2932         https://bugs.webkit.org/show_bug.cgi?id=55880
2933
2934         Add LANG variable to the clean environment when running
2935         old-run-webkit-tests script.
2936
2937         * Scripts/old-run-webkit-tests:
2938
2939 2011-03-07  Tony Chang  <tony@chromium.org>
2940
2941         Reviewed by Mihai Parparita.
2942
2943         [Chromium] Find .checksum files without .pngs and vice-versa
2944         https://bugs.webkit.org/show_bug.cgi?id=55236
2945
2946         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
2947             mismatched results.
2948
2949 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2950
2951         Reviewed by Beth Dakin.
2952
2953         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
2954         https://bugs.webkit.org/show_bug.cgi?id=55706
2955
2956         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
2957
2958         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2959         (AccessibilityController::focusedElement):
2960            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
2961            because it could change at any time.
2962         (AccessibilityController::rootElement):
2963
2964 2011-03-07  Sam Weinig  <sam@webkit.org>
2965
2966         Reviewed by Anders Carlsson.
2967
2968         Add unableToImplementPolicy callback for WebKit2 policy client
2969         <rdar://problem/9071902>
2970         https://bugs.webkit.org/show_bug.cgi?id=55884
2971
2972         * MiniBrowser/mac/BrowserWindowController.m:
2973         (-[BrowserWindowController awakeFromNib]):
2974         Update policy client initialization struct for new member.
2975
2976 2011-03-07  Sam Weinig  <sam@webkit.org>
2977
2978         Reviewed by Anders Carlsson.
2979
2980         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2981         https://bugs.webkit.org/show_bug.cgi?id=55827
2982
2983         * MiniBrowser/mac/BrowserWindowController.m:
2984         (decidePolicyForResponse):
2985         (-[BrowserWindowController awakeFromNib]):
2986         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2987         (TestWebKitAPI::decidePolicyForResponse):
2988         (TestWebKitAPI::TEST):
2989         Update tools for new name.
2990
2991 2011-03-06  Daniel Bates  <dbates@rim.com>
2992
2993         Reviewed by Eric Seidel and David Kilzer.
2994
2995         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
2996         https://bugs.webkit.org/show_bug.cgi?id=55503
2997
2998         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
2999         in checkForJavaSDK().
3000
3001         Also, remove extraneous space in function prototype for unlinkZeroFiles.
3002
3003         * Scripts/build-webkit:
3004
3005 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
3006
3007         Reviewed by Sam Weinig.
3008
3009         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
3010
3011         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3012         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
3013             by willSendRequestForFrame. The API expects a retained reference to the URL request.
3014
3015 2011-03-05  Ilya Sherman  <isherman@chromium.org>
3016
3017         Reviewed by Darin Adler.
3018
3019         HTMLInputElement::setValue() should schedule change event when the element is focused
3020         In service of https://code.google.com/p/chromium/issues/detail?id=42716
3021         https://bugs.webkit.org/show_bug.cgi?id=53160
3022
3023         * DumpRenderTree/LayoutTestController.cpp:
3024         (setValueForUserCallback):
3025         (LayoutTestController::staticFunctions):
3026         * DumpRenderTree/LayoutTestController.h:
3027         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3028         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3029         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3030         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
3031         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3032         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3033         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3034         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3035         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3036         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3037
3038 2011-03-04  Mark Rowe  <mrowe@apple.com>
3039
3040         Reviewed by Alexey Proskuryakov.
3041
3042         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
3043
3044         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
3045         
3046         * DumpRenderTree/mac/CheckedMalloc.cpp:
3047         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
3048         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
3049         and then restore the initial protection flags when we're done.
3050
3051 2011-03-04  Evan Martin  <evan@chromium.org>
3052
3053         Reviewed by Tony Chang.
3054
3055         [gdb] pretty-print KURL in gdb
3056         https://bugs.webkit.org/show_bug.cgi?id=55788
3057
3058         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
3059         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
3060         pretty-printing.
3061
3062 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3063
3064         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
3065
3066         Reviewed by Darin Adler.
3067
3068         * TestWebKitAPI/JavaScriptTest.cpp:
3069         (TestWebKitAPI::javaScriptCallback):
3070         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3071         (TestWebKitAPI::didRunJavaScript):
3072         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3073         (TestWebKitAPI::nullJavaScriptCallback):
3074         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3075         (TestWebKitAPI::didRunJavaScript):
3076
3077 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3078
3079         Make run-api-tests show failed if a test fails.
3080
3081         https://webkit.org/b/55725
3082
3083         Reviewed by Sam Weinig.
3084
3085         * Scripts/run-api-tests:
3086         (runTest): Remove "my" from the nested $result assignment so the
3087         check outside the condition sees the real result.
3088
3089 2011-03-02  MORITA Hajime  <morrita@google.com>
3090
3091         Reviewed by Kent Tamura.
3092
3093         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
3094         https://bugs.webkit.org/show_bug.cgi?id=55434
3095
3096         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
3097         and passed the object webkit_support::PostDelayedTask directly.
3098
3099         Note that the change keeps postTask() as is because it has a
3100         semantics taht webkit_support::PostDelayedTask() has; It jumps to
3101         the main thread.
3102
3103         * DumpRenderTree/chromium/Task.cpp:
3104         (postDelayedTask):
3105         * DumpRenderTree/chromium/Task.h:
3106         (WebTask::Run):
3107
3108 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3109
3110         Reviewed by Kenneth Rohde Christiansen.
3111
3112         [QT] Implement mock client-based geolocation for layout testing
3113         https://bugs.webkit.org/show_bug.cgi?id=54334
3114
3115         Implement testing for Client-Based geolocation for QtWebkit.
3116
3117         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3118         (WebCore::DumpRenderTree::DumpRenderTree):
3119         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3120         (LayoutTestController::reset):
3121         (LayoutTestController::setGeolocationPermission):
3122         (LayoutTestController::setMockGeolocationError):
3123         (LayoutTestController::setMockGeolocationPosition):
3124
3125 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3126
3127         Unreviewed, rolling out r80237.
3128         http://trac.webkit.org/changeset/80237
3129         https://bugs.webkit.org/show_bug.cgi?id=55714
3130
3131         Windows bots aren't ready to be core (Requested by aroben on
3132         #webkit).
3133
3134         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3135         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3136
3137 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3138
3139         Reviewed by Tony Chang.
3140
3141         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
3142         https://bugs.webkit.org/show_bug.cgi?id=55694
3143         
3144         Fixes for interruptions in NRWT:
3145         - Make TestRunInterruptedException be pickleable correctly (the base
3146           Exception class defines a __reduce__ that does not include the reason)
3147         - Fix ordering of returned arguments from TestRunner2._run_tests
3148           (interrupted and keyboard_interrupted were reversed)
3149         - Fix cancel_workers callsites (was using old name).
3150         - In handle_exception re-raise actual exception instance that was thrown
3151
3152         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3153         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3154         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3155         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3156
3157 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
3158
3159         Unreviewed.
3160
3161         Adding myself as a committer.
3162
3163         * Scripts/webkitpy/common/config/committers.py:
3164
3165 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
3166
3167         Reviewed by Mihai Parparita.
3168
3169         Teach sheriffbot to answer whois commands
3170         https://bugs.webkit.org/show_bug.cgi?id=55687
3171
3172         * Scripts/webkitpy/tool/bot/irc_command.py:
3173         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3174         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3175
3176 2011-03-03  Victoria Kirst  <vrk@google.com>
3177
3178         Reviewed by Eric Carlson.
3179
3180         Enable media tests in chromium-gpu/test_expectations
3181         https://bugs.webkit.org/show_bug.cgi?id=53608
3182
3183         Add media folder to the list of GPU test paths.
3184
3185         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3186
3187 2011-03-03  Adam Roben  <aroben@apple.com>
3188
3189         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
3190
3191         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
3192         incorrect parsing of absolute Windows-style file: URLs
3193
3194         Reviewed by Tim Hatcher.
3195
3196         * WebKitTestRunner/TestInvocation.cpp:
3197         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
3198         <http://webkit.org/b/55683>.
3199
3200 2011-03-03  Tony Chang  <tony@chromium.org>
3201
3202         Reviewed by Dimitri Glazkov.
3203
3204         [chromium] Run kill-old-processes on the chromium-win bot too
3205         https://bugs.webkit.org/show_bug.cgi?id=55630
3206
3207         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3208         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
3209
3210 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3211
3212         Reviewed by Martin Robinson.
3213
3214         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
3215         https://bugs.webkit.org/show_bug.cgi?id=53960
3216
3217         * DumpRenderTree/gtk/EventSender.cpp:
3218         (sendClick):
3219         (scheduleAsynchronousClickCallback):
3220
3221 2011-03-03  Adam Roben  <aroben@apple.com>
3222
3223         Look for Windows-style paths when checking whether a test is an Inspector test
3224
3225         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
3226         out or crash on Windows 7 Release (WebKit2 Tests)
3227
3228         Reviewed by Darin Adler.
3229
3230         * WebKitTestRunner/TestInvocation.cpp:
3231         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
3232         Windows.
3233
3234 2011-03-03  Adam Roben  <aroben@apple.com>
3235
3236         Make Windows 7 Release (Tests) a core builder
3237
3238         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3239         give it a few more days of greenness first.
3240
3241         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3242
3243         Reviewed by Andreas Kling.
3244
3245         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3246         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3247
3248         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3249         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3250         Updated the core regexps to match the buildbot module. Updated the expected results to match
3251         the current set of core builders.
3252
3253 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
3254
3255         Reviewed by Andreas Kling.
3256
3257         Adding myself as a reviewer.
3258
3259         * Scripts/webkitpy/common/config/committers.py:
3260
3261 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
3262
3263         Reviewed by Xan Lopez.
3264
3265         [GTK] Extended application cache database API and added unit tests file.
3266         https://bugs.webkit.org/show_bug.cgi?id=55335
3267
3268         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
3269         of webkit_application_cache_set_maximum_size due to API exposal.
3270
3271 2011-03-02  Ojan Vafai  <ojan@chromium.org>
3272
3273         Reviewed by Adam Barth.
3274
3275         make webkit-patch upload work for security bugs
3276         https://bugs.webkit.org/show_bug.cgi?id=55655
3277
3278         The problem is that we shell out to prepare-ChangeLog,
3279         which does not authenticate with bugzilla. All it needs from
3280         bugzilla is the bug title though. We just pass it through from
3281         webkit-patch instead.
3282
3283         * Scripts/prepare-ChangeLog:
3284         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3285         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3286
3287 2011-03-01  Ojan Vafai  <ojan@chromium.org>
3288
3289         Reviewed by Tony Chang.
3290
3291         [test-dashboard] make gtest JSON match layout-tests JSON
3292         https://bugs.webkit.org/show_bug.cgi?id=55556
3293
3294         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
3295         Make this code match.
3296
3297         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3298
3299 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
3300
3301         Reviewed by Tony Chang.
3302
3303         NRWT - implement Linux Hardy 64-bit port support. This involves
3304         adding support for non-'x86' architectures and updating the
3305         "deduplicate_tests" script to correctly understand that
3306         port.name() is not always equal to basename(port.baseline_path()).
3307
3308         This change introduces two new port names: 'chromium-linux-x86'
3309         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
3310         flag will cause the code to determine which one to use at
3311         runtime, just like we currently do with 'chromium-win'.
3312
3313         https://bugs.webkit.org/show_bug.cgi?id=55535
3314
3315         * Scripts/webkitpy/common/system/executive_mock.py:
3316           Handle 'return_stderr' keyword arg to run_command()
3317         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3318         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3319         * Scripts/webkitpy/layout_tests/port/base.py:
3320         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3321         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3322         * Scripts/webkitpy/layout_tests/port/factory.py:
3323         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3324
3325 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
3326
3327         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
3328         update symlinks accordingly.
3329
3330         * wx/packaging/build-mac-installer.py:
3331
3332 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3333
3334         Unreviewed, rolling out r80139.
3335         http://trac.webkit.org/changeset/80139
3336         https://bugs.webkit.org/show_bug.cgi?id=55620
3337
3338         failing and crashing tests on Snow Leopard bot (Requested by
3339         mihaip1 on #webkit).
3340
3341         * DumpRenderTree/LayoutTestController.cpp:
3342         (LayoutTestController::staticFunctions):
3343         * DumpRenderTree/LayoutTestController.h:
3344         * DumpRenderTree/chromium/LayoutTestController.cpp:
3345         (LayoutTestController::LayoutTestController):
3346         * DumpRenderTree/chromium/LayoutTestController.h:
3347         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3348         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3349         * DumpRenderTree/mac/UIDelegate.h:
3350         * DumpRenderTree/mac/UIDelegate.mm:
3351         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3352         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3353         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3354         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3355
3356 2011-03-02  Adam Roben  <aroben@apple.com>
3357
3358         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
3359
3360         This matches DumpRenderTree on Windows.
3361
3362         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
3363         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
3364         in WebKit2
3365
3366         Reviewed by Beth Dakin.
3367
3368         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3369         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
3370         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
3371
3372 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3373
3374         Reviewed by David Levin.
3375
3376         Add feature define for data transfer items
3377         https://bugs.webkit.org/show_bug.cgi?id=55510
3378
3379         * Scripts/build-webkit:
3380
3381 2011-03-02  Adam Roben  <aroben@apple.com>
3382
3383         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
3384
3385         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
3386         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
3387         the former location, but was getting lucky on some SnowLeopard machines because symlinks
3388         were being created there pointing into DiagnosticReports. For machines without these
3389         symlinks, crash logs were not getting captured.
3390
3391         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
3392         SnowLeopard machines
3393
3394         Reviewed by Eric Seidel.
3395
3396         * Scripts/old-run-webkit-tests:
3397         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
3398
3399 2011-03-02  Adam Roben  <aroben@apple.com>
3400
3401         Don't try to capture crash logs on platforms that haven't implemented that feature
3402
3403         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
3404         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
3405
3406         Reviewed by Joseph Pecoraro.
3407
3408         * Scripts/old-run-webkit-tests:
3409         (captureSavedCrashLog): Bail if we don't have a crash log glob.
3410         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
3411         strictly required to fix bug 55504, but seems worthwhile.
3412
3413 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3414
3415         Reviewed by Dmitry Titov.
3416
3417         Detach Geolocation from Frame when Page destroyed.
3418         https://bugs.webkit.org/show_bug.cgi?id=52877
3419
3420         Extend the layout test controller to expose the number of pending
3421         geolocation requests, so that we can test that the requests have
3422         been cancelled on page close.
3423
3424         * DumpRenderTree/LayoutTestController.cpp:
3425         (numberOfPendingGeolocationPermissionRequestsCallback):
3426         (LayoutTestController::staticFunctions):
3427         * DumpRenderTree/LayoutTestController.h:
3428         * DumpRenderTree/chromium/LayoutTestController.cpp:
3429         (LayoutTestController::LayoutTestController):
3430         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3431         * DumpRenderTree/chromium/LayoutTestController.h:
3432         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3433         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3434         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3435         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3436         * DumpRenderTree/mac/UIDelegate.h:
3437         * DumpRenderTree/mac/UIDelegate.mm:
3438         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3439         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3440         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3441         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3442         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3443         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3444         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3445         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3446
3447
3448 2011-03-01  Kent Tamura  <tkent@chromium.org>
3449
3450         Reviewed by Dimitri Glazkov.
3451
3452         Assertion fails when a form validation bubble appears
3453         https://bugs.webkit.org/show_bug.cgi?id=55550
3454
3455         Test: fast/forms/interactive-validation-attach-assertion.html
3456
3457         * DumpRenderTree/chromium/WebPreferences.cpp:
3458         (WebPreferences::applyTo): Enable the interactive validation feature by
3459           default. This matches to Chromium browser.
3460
3461 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3462
3463         Reviewed by Kent Tamura.
3464
3465         Remove efl port style exception of Webcore/JavaScriptCore
3466         https://bugs.webkit.org/show_bug.cgi?id=55549
3467
3468         WebCore and JavaScriptCore need to adhere WebKit coding style.
3469
3470         * Scripts/webkitpy/style/checker.py:
3471
3472 2011-03-01  Tony Chang  <tony@chromium.org>
3473
3474         Reviewed by Ojan Vafai.
3475
3476         [chromium] clean up temp files on chromium-mac builder too
3477         https://bugs.webkit.org/show_bug.cgi?id=55525
3478
3479         * BuildSlaveSupport/chromium/remove-crash-logs:
3480
3481 2011-02-28  Ojan Vafai  <ojan@chromium.org>
3482
3483         Reviewed by Tony Chang.
3484
3485         wrap json in a function call to afford cross-domain loading
3486         https://bugs.webkit.org/show_bug.cgi?id=55353
3487
3488         Also delete the code that compacts the JSON. It turns out this
3489         breaks the rebaseline tool and is probably a premature optimization anyways.
3490
3491         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3492         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3493         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3494         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3495
3496 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3497
3498         Unreviewed, rolling out r80079.
3499         http://trac.webkit.org/changeset/80079
3500         https://bugs.webkit.org/show_bug.cgi?id=55547
3501
3502         "Broke the Win debug build?" (Requested by dcheng on #webkit).
3503
3504         * Scripts/build-webkit:
3505
3506 2011-03-01  Mark Rowe  <mrowe@apple.com>
3507
3508         Reviewed by Sam Weinig.
3509
3510         Update verification scripts to handle WebKit2.
3511
3512         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
3513         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
3514         WebKit2.
3515
3516 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
3517
3518         Reviewed by David Levin.
3519
3520         Add feature define for data transfer items
3521         https://bugs.webkit.org/show_bug.cgi?id=55510
3522
3523         * Scripts/build-webkit:
3524
3525 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3526
3527         Reviewed by Timothy Hatcher.
3528
3529         All Console Messages should be passed to ChromeClients.
3530         https://bugs.webkit.org/show_bug.cgi?id=54926
3531
3532         Update DumpRenderTree's UIDelegate to use the new console message delegate.
3533
3534         * DumpRenderTree/mac/UIDelegate.mm:
3535         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3536
3537 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3538
3539         Reviewed by Adam Barth.
3540
3541         Tragically, we stopped running the python unit tests
3542         on Chromium Win just as I was getting them to be green.
3543         This patch turns them back on.
3544
3545         https://bugs.webkit.org/show_bug.cgi?id=55521
3546
3547         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3548
3549 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3550
3551         Reviewed by Adam Roben.
3552
3553         Disable
3554         webkitpy.common.system.executive_unittest.ExecutiveTest.\
3555            test_kill_all fails on win until it can be properly triaged.
3556
3557         https://bugs.webkit.org/show_bug.cgi?id=54790
3558
3559         * Scripts/webkitpy/common/system/executive_unittest.py:
3560
3561     2011-03-01  Helder Correia  <helder@sencha.com>
3562
3563             Unreviewed. Add myself to committers.py.
3564
3565             * Scripts/webkitpy/common/config/committers.py:
3566
3567 2011-03-01  Adam Roben  <aroben@apple.com>
3568
3569         Give up if a crash log for the web process is taking too long to be saved on Windows
3570
3571         This should keep the bots from getting stuck while waiting for a crash log, if writing a
3572         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
3573
3574         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
3575         to be saved for the web process
3576
3577         Reviewed by Steve Falkenburg.
3578
3579         * WebKitTestRunner/win/TestControllerWin.cpp:
3580         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
3581         Generalized the code slightly to handle the optional object to wait on.
3582         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
3583         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
3584         prevent us from waiting forever.
3585
3586 2011-03-01  Adam Roben  <aroben@apple.com>
3587
3588         Give WebKitLauncherWin's PDB file a name different from WebKit's
3589
3590         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
3591         fighting over the same PDB file, meaning that one of them was going to lose and not have
3592         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
3593
3594         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
3595         runs (due to missing symbols)
3596
3597         Reviewed by David Kilzer.
3598
3599         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
3600         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
3601
3602 2011-03-01  Adam Roben  <aroben@apple.com>
3603
3604         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
3605
3606         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
3607         --exit-after-n-crashes-or-timeouts limit
3608
3609         Reviewed by David Kilzer.
3610
3611         * Scripts/old-run-webkit-tests:
3612         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
3613         the number of tests that caused the web process to crash when exiting early.
3614
3615 2011-03-01  Adam Roben  <aroben@apple.com>
3616
3617         Save a crash log when the web process crashes
3618
3619         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
3620         until it has finished crashing, which guarantees that the crash log will have had time to be
3621         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
3622         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
3623
3624         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
3625         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
3626
3627         Reviewed by Sam Weinig.
3628
3629         * Scripts/old-run-webkit-tests:
3630         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
3631         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
3632         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
3633         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
3634         WebProces_*.crash files when the web process crashes.
3635
3636         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3637         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
3638         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
3639         along to platformInitialize.
3640
3641         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
3642
3643         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3644         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
3645
3