076692c915a34305d2ed6793e62dc0994b0b9e50
[WebKit-https.git] / Tools / ChangeLog
1 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
4         https://bugs.webkit.org/show_bug.cgi?id=149252
5
6         Reviewed by Darin Adler.
7
8         In case of glib tests the test runner notifies about tests
9         crashing, but for google tests we don't get any feedback, which
10         means that in case of a test crashing we get a list of **PASS**
11         messages and at the summary we are notified that the test suite
12         has failed, but it's impossible to know which test cases have failed.
13
14         * Scripts/run-gtk-tests:
15         (TestRunner._run_google_test): Add a **CRASH** message if test
16         case crashed.
17
18 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
19
20         WebKitTestRunner can leak user content script results between tests
21         https://bugs.webkit.org/show_bug.cgi?id=149391
22
23         Reviewed by Sam Weinig.
24
25         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
26         about:blank, and thus about:blank doesn't have unintended side effects.
27
28         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
29         (WTR::InjectedBundle::beginTesting):
30         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
31         (WTR::InjectedBundlePage::resetAfterTest):
32
33 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
34
35         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
36         https://bugs.webkit.org/show_bug.cgi?id=149384
37
38         Reviewed by Chris Fleizach.
39
40         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
41         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
42         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
43         regardless of whether someone else holds a reference (we also call -stopListening in
44         -dealloc).
45
46         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
47         (AccessibilityController::platformResetToConsistentState):
48         (AccessibilityController::addNotificationListener):
49         Ditto.
50
51 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
52
53         Remove XHR_TIMEOUT compilation guard
54         https://bugs.webkit.org/show_bug.cgi?id=149260
55
56         Reviewed by Benjamin Poulain.
57
58         * Scripts/webkitperl/FeatureList.pm:
59
60 2015-09-19  Dan Bernstein  <mitz@apple.com>
61
62         Attempted build fix.
63
64         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
65
66 2015-09-18  Commit Queue  <commit-queue@webkit.org>
67
68         Unreviewed, rolling out r189908.
69         https://bugs.webkit.org/show_bug.cgi?id=149368
70
71         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
72
73         Reverted changeset:
74
75         "printing does not use minimum page zoom factor"
76         https://bugs.webkit.org/show_bug.cgi?id=108507
77         http://trac.webkit.org/changeset/189908
78
79 2015-09-18  Andy Estes  <aestes@apple.com>
80
81         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
82         https://bugs.webkit.org/show_bug.cgi?id=149360
83
84         Reviewed by Tim Horton.
85
86         Added an API test.
87
88         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
89         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
90         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
91         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
92         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
93         (TEST):
94         * TestWebKitAPI/ios/pages.pages: Added.
95
96 2015-09-18  Nan Wang  <n_wang@apple.com>
97
98         AX: Implement ARIA 1.1 @aria-current on iOS
99         https://bugs.webkit.org/show_bug.cgi?id=149297
100
101         Reviewed by Chris Fleizach.
102
103         Added support to test aria-current on iOS.
104
105         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
106         (AccessibilityUIElement::stringAttributeValue):
107         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
108         (WTR::AccessibilityUIElement::stringAttributeValue):
109
110 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
111
112         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
113         https://bugs.webkit.org/show_bug.cgi?id=149352
114
115         Reviewed by Simon Fraser.
116
117         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
118         m_context can be null. This may indicate a bug in webkitpy too, but
119         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
120         wrong with opening and immediately closing it.
121
122 2015-09-18  Daniel Bates  <dabates@apple.com>
123
124         isGitSVNDirectory() returns true when Git is not installed
125         https://bugs.webkit.org/show_bug.cgi?id=149351
126
127         Reviewed by Alexey Proskuryakov.
128
129         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
130         Git is not installed on the machine.
131
132         * Scripts/VCSUtils.pm:
133         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
134         status code 0 (success).
135
136 2015-09-18  Alex Christensen  <achristensen@webkit.org>
137
138         Prevent build-webkit from building four times on Windows 
139         https://bugs.webkit.org/show_bug.cgi?id=149336
140
141         Reviewed by Brent Fulgham.
142
143         * Scripts/build-webkit:
144         Move the Windows code out of the for loop iterating over each subdirectory to be build.
145         They're built all at once.
146         * Scripts/webkitdirs.pm:
147         (buildVisualStudioProject):
148         (cmakeGeneratedBuildfile):
149         Don't generate the Visual Studio solution if it already exists.
150         It will run CMake again if necessary.
151
152 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
153
154         [iOS WK2] WTR fails to set the key window in the UIKit sense
155         https://bugs.webkit.org/show_bug.cgi?id=149325
156
157         Reviewed by Tim Horton.
158
159         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
160         This causes UIKit to bypass code that actually sets the key window, resulting in
161         [UIAppliation sharedApplication].keyWindow always being nil.
162
163         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
164         -[WebKitTestRunnerWindow isKeyWindow] call super.
165
166         * WebKitTestRunner/PlatformWebView.h:
167         (WTR::PlatformWebView::setWindowIsKey): Deleted.
168         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
169         (WTR::PlatformWebView::setWindowIsKey):
170         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
171         (WTR::PlatformWebView::setWindowIsKey):
172         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
173         (-[WebKitTestRunnerWindow isKeyWindow]):
174         (WTR::PlatformWebView::PlatformWebView):
175         (WTR::PlatformWebView::~PlatformWebView):
176         (WTR::PlatformWebView::setWindowIsKey):
177         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
178         (WTR::PlatformWebView::setWindowIsKey):
179
180 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
181
182         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
183         https://bugs.webkit.org/show_bug.cgi?id=149321
184
185         Reviewed by Tim Horton.
186         
187         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
188         enabled the "testing" viewport configuration, which disables page scaling.
189         
190         If we're running viewport tests, we want the normal web page configuration.
191         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
192         based on whether the test is in a "viewport" directory.
193
194         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
195         (WTR::InjectedBundle::beginTesting):
196         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
197         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
198         * WebKitTestRunner/TestInvocation.cpp:
199         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
200         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
201         (WTR::TestInvocation::shouldMakeViewportFlexible):
202         (WTR::TestInvocation::invoke):
203         * WebKitTestRunner/TestInvocation.h:
204         * WebKitTestRunner/ios/TestControllerIOS.mm:
205         (WTR::TestController::platformConfigureViewForTest):
206         (WTR::shouldMakeViewportFlexible): Deleted.
207
208 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
209
210         Give iOS WebKitTestRunner a launch storyboard
211         https://bugs.webkit.org/show_bug.cgi?id=149314
212
213         Reviewed by Dan Bates.
214         
215         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
216         that it's been built for specific device configurations, and puts the window
217         at the top of the screen. This simplifies coordinate conversions in a future patch.
218
219         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
220         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
221         * WebKitTestRunner/ios/Launch.storyboard: Added.
222
223 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
224
225         Update licence in r189890
226         https://bugs.webkit.org/show_bug.cgi?id=149306
227
228         Reviewed by Dean Jackson.
229
230         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
231         * FontWithFeatures/FontWithFeatures/FontCreator.h:
232         * FontWithFeatures/FontWithFeatures/main.cpp:
233
234 2015-09-17  Mark Lam  <mark.lam@apple.com>
235
236         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
237         https://bugs.webkit.org/show_bug.cgi?id=149285
238
239         Reviewed by Saam Barati.
240
241         Just need to add an option to pass --no-jit to run-jsc-stress-test.
242
243         * Scripts/run-javascriptcore-tests:
244         (runJSCStressTests):
245
246 2015-09-17  Alex Christensen  <achristensen@webkit.org>
247
248         Switch AppleWin build to use CMake
249         https://bugs.webkit.org/show_bug.cgi?id=149163
250
251         Reviewed by Brent Fulgham.
252
253         * Scripts/build-webkit:
254         * Scripts/run-api-tests:
255         (runTest):
256         (listAllTests):
257         (prepareEnvironmentForRunningTestTool):
258         (testToolPaths):
259         (testToolPath): Deleted.
260         Run the API tests as separate executables on Windows.
261         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
262         * Scripts/webkitdirs.pm:
263         (checkRequiredSystemConfig):
264         (jhbuildWrapperPrefixIfNeeded):
265         (generateBuildSystemFromCMakeProject):
266         Fix configuration quirks.
267
268 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
269
270         Added toggle options for hiding and showing certain platform families on the dashboard.
271         https://bugs.webkit.org/show_bug.cgi?id=148403
272
273         Reviewed by David Kilzer.
274
275         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
276         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
277         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
278         in lieu of an "all" button in the toggle menu.
279
280         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
281         (parsePlatformFamily): Helper function to parse out a platform family.
282         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
283         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
284         (updateToggleButtons): Updates the status of the toggle buttons.
285         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
286         (documentReady): Added creation of toggle buttons.
287         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
288         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
289         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
290         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
291         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
293         (QueueView): Updated to use hiddenPlatformFamilies.
294         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
295         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
296         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
297         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
298         (Settings.prototype.toggleHiddenPlatform): Deleted.
299         (Settings.prototype.clearHiddenPlatforms): Deleted.
300         (Settings.prototype.toggleShowPlatformFamily): Deleted.
301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
302         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
303         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
304         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
305         (table.queue-grid tr.headers th):
306         (div.settingsWrapper.hide):
307         (div.settingsWrapper):
308         (div.familyToggleWrapper):
309         (div.platformFamilyToggleButton):
310         (div.platformFamilyShowToggleButton:not(:last-child)):
311         (div.familyShown):
312         (div.accessibilityButton):
313         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
314         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
315         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
316         platformFamilyToggleButton and settingsWrapper class.
317         (.accessibilityButton): Deleted.
318
319 2015-09-17  Tim Horton  <timothy_horton@apple.com>
320
321         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
322         https://bugs.webkit.org/show_bug.cgi?id=148904
323
324         Reviewed by Myles Maxfield.
325
326         * WebKitTestRunner/TestController.cpp:
327         (WTR::parseBooleanTestHeaderValue):
328         (WTR::updateViewOptionsFromTestHeader):
329         Check for the key "useThreadedScrolling".
330         Add some code to check for "true" and "false" for boolean options.
331
332         (WTR::TestController::viewOptionsForTest):
333         Apply the test's overrides last, even after the platform's.
334
335 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
336
337         printing does not use minimum page zoom factor
338         https://bugs.webkit.org/show_bug.cgi?id=108507
339
340         Reviewed by Darin Adler.
341
342         WebKitTestRunner always takes the snapshots from the UI process
343         (expect for IOS), so in the case of printing, the layout in the
344         web view is not the expected one. When printing, we need to take
345         the snapshot in the web process and ensure it's rendered with a
346         PrintContext.
347
348         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
349         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
350         kWKSnapshotOptionsPrinting option to
351         WKBundlePageCreateSnapshotWithOptions() when printing. When not
352         printing, don't even create the snapshot, since it will be ignored
353         by the UI process that always creates its own from the WebView (expect for IOS platform)
354         * WebKitTestRunner/TestInvocation.cpp:
355         (WTR::TestInvocation::dumpResults): Use always the snapshot image
356         received from the web process if any when comparing pixel
357         results. Now we only receive a snapshot from the web process in
358         case of printing, or when platform is IOS. Otherwhise, generate
359         the snapshot from the WebView as usual.
360         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
361         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
362         is created by the caller now, but the CG implementation needs to
363         know if it's a Web or UI process snapshot.
364         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
365         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
366         cairo surface for the given image.
367         * WebKitTestRunner/cg/TestInvocationCG.cpp:
368         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
369         CGContext for the given image.
370
371 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
372
373         Create a font which can be used for testing font features
374         https://bugs.webkit.org/show_bug.cgi?id=149237
375
376         Reviewed by Simon Fraser.
377
378         This patch adds a new project in the Tools/ directory which generates a font which can
379         be used for testing font features. This is a standalone project consisting of two files:
380         1. A file which actually generates the byte vector representing the font. This file has
381         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
382         specific, and only relies on the C++ STL.
383         2. A file with a main() which calls generateFont() and writes out the font, as well as
384         uses the font to render some demonstration text into a .png file. This file is platform
385         specific.
386
387         The font itself only supports the following characters:
388         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
389         However, the shape of these letters are either an X or a check mark.
390
391         The letter "A" always is a check mark.
392         The letter "B" always is an X.
393         Without any font features turned on, the rest of the letters are shown as X.
394
395         Each font feature has an letter associated with it. When the font feature is enabled,
396         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
397         as a check mark.
398
399         Here are the mappings of font features to letters:
400         liga: C
401         clig: D
402         dlig: E
403         hlig: F
404         calt: G
405         subs: H
406         sups: I
407         smcp: J
408         c2sc: K
409         pcap: L
410         c2pc: M
411         unic: N
412         titl: O
413         onum: P
414         pnum: Q
415         tnum: R
416         frac: S
417         afrc: T
418         ordn: U
419         zero: V
420         hist: W
421         jp78: X
422         jp83: Y
423         jp90: Z
424         jp04: a
425         smpl: b
426         trad: c
427         fwid: d
428         pwid: e
429         ruby: f
430
431         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
432         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
433         (integralLog2):
434         (roundDownToPowerOfTwo):
435         (isFourByteAligned):
436         (clampTo):
437         (append32):
438         (writeCFFEncodedNumber):
439         (CFFBuilder::CFFBuilder):
440         (CFFBuilder::takeResult):
441         (CFFBuilder::moveTo):
442         (CFFBuilder::lineTo):
443         (CFFBuilder::curveToCubic):
444         (CFFBuilder::closePath):
445         (CFFBuilder::writePoint):
446         (generateBoxCharString):
447         (generateCheckCharString):
448         (generateXCharString):
449         (charStringForGlyph):
450         (Generator::generate):
451         (Generator::Placeholder::Placeholder):
452         (Generator::Placeholder::populate):
453         (Generator::Placeholder::~Placeholder):
454         (Generator::placeholder):
455         (Generator::append16):
456         (Generator::append32):
457         (Generator::append32BitCode):
458         (Generator::overwrite16):
459         (Generator::overwrite32):
460         (Generator::appendCFFTable):
461         (Generator::appendSubstitutionSubtable):
462         (Generator::appendScriptSubtable):
463         (Generator::appendGSUBTable):
464         (Generator::appendOS2Table):
465         (Generator::appendFormat12CMAPTable):
466         (Generator::appendFormat4CMAPTable):
467         (Generator::appendCMAPTable):
468         (Generator::appendHEADTable):
469         (Generator::appendHHEATable):
470         (Generator::appendHMTXTable):
471         (Generator::appendMAXPTable):
472         (Generator::appendNAMETable):
473         (Generator::appendPOSTTable):
474         (Generator::calculateChecksum):
475         (Generator::appendTable):
476         (generateFont):
477         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
478         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
479         (drawTextWithFeature):
480         (main):
481
482 2015-09-16  Commit Queue  <commit-queue@webkit.org>
483
484         Unreviewed, rolling out r189875 and r189878.
485         https://bugs.webkit.org/show_bug.cgi?id=149235
486
487         cygwin cmake build not ready yet (Requested by alexchristensen
488         on #webkit).
489
490         Reverted changesets:
491
492         "Switch AppleWin build to use CMake"
493         https://bugs.webkit.org/show_bug.cgi?id=149163
494         http://trac.webkit.org/changeset/189875
495
496         "Cygwin build fix after r189875"
497         http://trac.webkit.org/changeset/189878
498
499 2015-09-16  Alex Christensen  <achristensen@webkit.org>
500
501         Cygwin build fix after r189875
502
503         * Scripts/build-webkit:
504         * Scripts/webkitdirs.pm:
505         (jhbuildWrapperPrefixIfNeeded):
506         (generateBuildSystemFromCMakeProject):
507         Make things work with cygwin and cmake.
508
509 2015-09-16  Alex Christensen  <achristensen@webkit.org>
510
511         Switch AppleWin build to use CMake
512         https://bugs.webkit.org/show_bug.cgi?id=149163
513
514         Reviewed by Brent Fulgham.
515
516         * Scripts/build-webkit:
517         Build with CMake.
518         * Scripts/run-api-tests:
519         (runTest):
520         (listAllTests):
521         (prepareEnvironmentForRunningTestTool):
522         (testToolPaths):
523         (testToolPath): Deleted.
524         Run the API tests as separate executables on Windows.
525         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
526
527 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
528
529         Add newer build.webkit.org pages to robots.txt
530         https://bugs.webkit.org/show_bug.cgi?id=149219
531
532         Reviewed by Darin Adler.
533
534         Indexing bot watcher's dashboard can't be good.
535
536         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
537
538 2015-09-16  Alex Christensen  <achristensen@webkit.org>
539
540         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
541
542         * BuildSlaveSupport/built-product-archive:
543         (unzipArchive):
544
545 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
546
547         [EFL] Fix the help message of separated web process option of MiniBrowser
548         https://bugs.webkit.org/show_bug.cgi?id=149212
549
550         Reviewed by Gyuyoung Kim.
551
552         * MiniBrowser/efl/main.c:
553
554 2015-09-16  Alex Christensen  <achristensen@webkit.org>
555
556         Fix python syntax after r189851.
557
558         * BuildSlaveSupport/built-product-archive:
559         (unzipArchive):
560         For loops need a colon.
561
562 2015-09-15  Alex Christensen  <achristensen@webkit.org>
563
564         Fix Windows test bots after changing to non-cygwin build
565         https://bugs.webkit.org/show_bug.cgi?id=149196
566
567         Reviewed by Daniel Bates.
568
569         * BuildSlaveSupport/built-product-archive:
570         (unzipArchive):
571         Using different versions of python makes what I think is https://bugs.python.org/issue15795
572         prevent us from executing files from the archive on the test bots.
573
574 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
575
576         Add ShadowRoot interface and Element.prototype.attachShadow
577         https://bugs.webkit.org/show_bug.cgi?id=149187
578
579         Reviewed by Antti Koivisto.
580
581         * Scripts/webkitperl/FeatureList.pm:
582
583 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
584
585         Appscale queue status json output lacks bots
586         https://bugs.webkit.org/show_bug.cgi?id=149194
587         <rdar://problem/22171089>
588
589         Reviewed by Alexey Proskuryakov.
590
591         * QueueStatusServer/handlers/queuestatusjson.py:
592         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
593         * QueueStatusServer/index.yaml: Index according to appscale requirements.
594
595 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
596
597         [Win] Provide a means for viewing the layer tree
598         https://bugs.webkit.org/show_bug.cgi?id=149165
599
600         Reviewed by Simon Fraser.
601
602         Update MiniBrowser with a new Debug menu option that will
603         dump the current layer tree to the debug console.
604         
605         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
606         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
607         * MiniBrowser/win/Common.cpp:
608         (WndProc): Add handler for 'Print Layer Tree' menu option.
609         * MiniBrowser/win/MiniBrowser.cpp:
610         (MiniBrowser::printLayerTree): Added Handler.
611         * MiniBrowser/win/MiniBrowser.h:
612
613 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
614
615         WebKitTestRunner declarative language setting is broken for iOS
616         https://bugs.webkit.org/show_bug.cgi?id=149119
617
618         Unreviewed.
619
620         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
621         lost in the final version which got committed. This simply implements the existing
622         OS X behavior on iOS.
623
624         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
625         (WTR::InjectedBundle::platformInitialize):
626
627 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
628
629         Unreviewed, add myself to committers list.
630
631         * Scripts/webkitpy/common/config/contributors.json:
632
633 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
634
635         [Cocoa] Allow testing with the system language
636         https://bugs.webkit.org/show_bug.cgi?id=148671
637
638         Reviewed by Anders Carlsson and Alexey Proskuryakov.
639
640         React to tests marked with language=lang1,lang2,etc in their header.
641         Once this information is parsed, pass it to
642         WKContextConfigurationSetOverrideLanguages().
643
644         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
645         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
646         list.
647         * WebKitTestRunner/TestController.cpp:
648         (WTR::TestController::createWebViewWithOptions): Call
649         WKContextConfigurationSetOverrideLanguages().
650         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
651         * WebKitTestRunner/TestOptions.h:
652         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
653         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
654         option to restart the web process.
655         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
656         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
657
658 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
659
660         [WKTR] Allow changing the WKContextConfiguration between successive tests
661         https://bugs.webkit.org/show_bug.cgi?id=148833
662
663         Reviewed by Tim Horton.
664
665         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
666         However, there are certain tests which require specifying options in this object. This patch makes
667         our existing code for recreating the test runner web view also recreate the WKContext.
668
669         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
670         class.
671
672         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
673         * WebKitTestRunner/PlatformWebView.h:
674         (WTR::PlatformWebView::options):
675         * WebKitTestRunner/TestController.cpp:
676         (WTR::TestController::initialize):
677         (WTR::TestController::generateContextConfiguration):
678         (WTR::TestController::generatePageConfiguration):
679         (WTR::TestController::createWebViewWithOptions):
680         (WTR::TestController::ensureViewSupportsOptionsForTest):
681         (WTR::updateContextConfigurationOptionsFromTestHeader):
682         (WTR::TestController::contextConfigurationOptionsForTest):
683         (WTR::TestController::platformCreateWebView):
684         (WTR::TestController::platformCreateOtherPage):
685         (WTR::updateViewOptionsFromTestHeader): Deleted.
686         (WTR::TestController::viewOptionsForTest): Deleted.
687         * WebKitTestRunner/TestController.h:
688         (WTR::TestController::injectedBundlePath):
689         (WTR::TestController::testPluginDirectory):
690         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
691         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
692         (WTR::TestController::platformCreateWebView):
693         (WTR::TestController::platformCreateOtherPage):
694         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
695         (WTR::PlatformWebView::PlatformWebView):
696         (WTR::PlatformWebView::viewSupportsOptions):
697         * WebKitTestRunner/efl/TestControllerEfl.cpp:
698         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
699         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
700         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
701         (WTR::PlatformWebView::PlatformWebView):
702         (WTR::PlatformWebView::viewSupportsOptions):
703         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
704         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
705         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
706         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
707         (WTR::PlatformWebView::PlatformWebView):
708         (WTR::PlatformWebView::viewSupportsOptions):
709         * WebKitTestRunner/ios/TestControllerIOS.mm:
710         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
711         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
712         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
713         (WTR::PlatformWebView::PlatformWebView):
714         (WTR::PlatformWebView::viewSupportsOptions):
715         * WebKitTestRunner/mac/TestControllerMac.mm:
716         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
717         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
718
719 2015-09-11  Michael Saboff  <msaboff@apple.com>
720
721         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
722         https://bugs.webkit.org/show_bug.cgi?id=149083
723
724         Reviewed by Alexey Proskuryakov.
725
726         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
727
728         * DumpRenderTree/mac/LayoutTestHelper.m:
729         (colorProfileURLForDisplay):
730
731 2015-09-11  Saam barati  <sbarati@apple.com>
732
733         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
734         https://bugs.webkit.org/show_bug.cgi?id=149058
735
736         Reviewed by Geoffrey Garen.
737
738         * Scripts/run-jsc-stress-tests:
739
740 2015-09-10  Commit Queue  <commit-queue@webkit.org>
741
742         Unreviewed, rolling out r189595.
743         https://bugs.webkit.org/show_bug.cgi?id=149052
744
745         The tests still fail (Requested by ap on #webkit).
746
747         Reverted changeset:
748
749         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
750         error -1"
751         https://bugs.webkit.org/show_bug.cgi?id=142929
752         http://trac.webkit.org/changeset/189595
753
754 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
755
756         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
757         https://bugs.webkit.org/show_bug.cgi?id=142929
758
759         Reviewed by Brent Fulgham.
760
761         Silence the logging. We'll track fixing the root cause in Radar.
762
763         * Scripts/webkitpy/port/mac.py:
764         (MacPort.stderr_patterns_to_strip): Added a FIXME.
765
766         * Scripts/webkitpy/port/win.py:
767         (WinPort.logging_patterns_to_strip): Added.
768
769 2015-09-09  Andy Estes  <aestes@apple.com>
770
771         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
772         https://bugs.webkit.org/show_bug.cgi?id=149022
773
774         Reviewed by Daniel Bates.
775
776         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
777         did not account for this.
778
779         * Scripts/webkitpy/xcode/simulator.py:
780         (Simulator): Optionally matched a revision at the end of a runtime version number.
781         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
782
783 2015-09-09  Andy Estes  <aestes@apple.com>
784
785         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
786         https://bugs.webkit.org/show_bug.cgi?id=149029
787         <rdar://problem/22432624>
788
789         Reviewed by Daniel Bates.
790
791         * Scripts/webkitpy/xcode/simulator.py:
792         (Simulator): Taught to parse tvOS runtimes.
793         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
794
795 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
796
797         Fix bit rot on bot watcher's dashboard page
798         https://bugs.webkit.org/show_bug.cgi?id=149012
799
800         Reviewed by Tim Horton.
801
802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
803         The code path used by the metrics page was trying to add properties to an undefined.
804
805         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
806         Silence an expection that would occur when the step has no logs. This should never
807         happen, but it did (perhaps buildbot was misconfigured for a while).
808
809 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
810
811         Update LayoutTestRelay xcconfig file.
812
813         Rubber-stamped by Dan Bernstein.
814
815         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
816
817 2015-09-09  Saam barati  <sbarati@apple.com>
818
819         DFG should have a debugging option that runs a phase that flushes all locals
820         https://bugs.webkit.org/show_bug.cgi?id=148916
821
822         Reviewed by Filip Pizlo.
823
824         * Scripts/run-jsc-stress-tests:
825
826 2015-09-09  Commit Queue  <commit-queue@webkit.org>
827
828         Unreviewed, rolling out r189530 and r189534.
829         https://bugs.webkit.org/show_bug.cgi?id=148996
830
831         Caused assertion failures on Yosemite (Requested by litherum
832         on #webkit).
833
834         Reverted changesets:
835
836         "[WKTR] Allow changing the WKContextConfiguration between
837         successive tests"
838         https://bugs.webkit.org/show_bug.cgi?id=148833
839         http://trac.webkit.org/changeset/189530
840
841         "[Cocoa] Fix the tests after r189530"
842         http://trac.webkit.org/changeset/189534
843
844 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
845
846         [Cocoa] Fix the tests after r189530
847
848         Unreviewed.
849
850         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
851         (WTR::initializeWebViewConfiguration):
852
853 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
854
855         [WKTR] Allow changing the WKContextConfiguration between successive tests
856         https://bugs.webkit.org/show_bug.cgi?id=148833
857
858         Reviewed by Tim Horton.
859
860         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
861         However, there are certain tests which require specifying options in this object. This patch makes
862         our existing code for recreating the test runner web view also recreate the WKContext.
863
864         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
865         class.
866
867         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
868         * WebKitTestRunner/PlatformWebView.h:
869         (WTR::PlatformWebView::options):
870         * WebKitTestRunner/TestController.cpp:
871         (WTR::TestController::initialize):
872         (WTR::TestController::generateContextConfiguration):
873         (WTR::TestController::generatePageConfiguration):
874         (WTR::TestController::createWebViewWithOptions):
875         (WTR::TestController::ensureViewSupportsOptionsForTest):
876         (WTR::updateContextConfigurationOptionsFromTestHeader):
877         (WTR::TestController::contextConfigurationOptionsForTest):
878         (WTR::TestController::platformCreateWebView):
879         (WTR::TestController::platformCreateOtherPage):
880         (WTR::updateViewOptionsFromTestHeader): Deleted.
881         (WTR::TestController::viewOptionsForTest): Deleted.
882         * WebKitTestRunner/TestController.h:
883         (WTR::TestController::injectedBundlePath):
884         (WTR::TestController::testPluginDirectory):
885         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
886         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
887         (WTR::TestController::platformCreateWebView):
888         (WTR::TestController::platformCreateOtherPage):
889         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
890         (WTR::PlatformWebView::PlatformWebView):
891         (WTR::PlatformWebView::viewSupportsOptions):
892         * WebKitTestRunner/efl/TestControllerEfl.cpp:
893         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
894         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
895         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
896         (WTR::PlatformWebView::PlatformWebView):
897         (WTR::PlatformWebView::viewSupportsOptions):
898         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
899         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
900         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
901         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
902         (WTR::PlatformWebView::PlatformWebView):
903         (WTR::PlatformWebView::viewSupportsOptions):
904         * WebKitTestRunner/ios/TestControllerIOS.mm:
905         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
906         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
907         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
908         (WTR::PlatformWebView::PlatformWebView):
909         (WTR::PlatformWebView::viewSupportsOptions):
910         * WebKitTestRunner/mac/TestControllerMac.mm:
911         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
912         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
913
914 2015-09-08  Daniel Bates  <dabates@apple.com>
915
916         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
917         https://bugs.webkit.org/show_bug.cgi?id=148980
918
919         Reviewed by Alexey Proskuryakov.
920
921         Add setting to enable/disable accelerated drawing so as to support testing
922         this feature in MiniBrowser on Mac.
923
924         * MiniBrowser/mac/SettingsController.h:
925         * MiniBrowser/mac/SettingsController.m:
926         (-[SettingsController _populateMenu]): Add menu item.
927         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
928         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
929         (-[SettingsController acceleratedDrawingEnabled]): Added.
930         * MiniBrowser/mac/WK1BrowserWindowController.m:
931         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
932         * MiniBrowser/mac/WK2BrowserWindowController.m:
933         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
934
935 2015-09-08  Jason Marcell  <jmarcell@apple.com>
936
937         Unreviewed. Added myself as a commiter in contributors.json.
938
939         * Scripts/webkitpy/common/config/contributors.json:
940
941 2015-09-08  Keith Miller  <keith_miller@apple.com>
942
943         Unreviewed, added myself to the list of contributors.
944
945         * Scripts/webkitpy/common/config/contributors.json:
946
947 2015-09-08  Daniel Bates  <dabates@apple.com>
948
949         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
950         https://bugs.webkit.org/show_bug.cgi?id=148921
951
952         Reviewed by Alexey Proskuryakov.
953
954         The ring image is positioned above the platform icon in markup and we specify the CSS
955         property z-index for the ring image so that it is painted on top of the platform icon
956         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
957         of the ring image, switch the order of these DOM elements and remove the use of the CSS
958         property z-index to achieve a similar effect.
959
960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
961         (documentReady): Create the platform icon image element before the ring image such that
962         the ring image is painted on top of the platform icon.
963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
964         (table.queue-grid td.logo img.ring): Removed property z-index.
965
966 2015-09-08  Daniel Bates  <dabates@apple.com>
967
968         Dashboard: Remove duplicate gear icon data URLs
969         https://bugs.webkit.org/show_bug.cgi?id=148920
970
971         Reviewed by Alexey Proskuryakov.
972
973         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
974         background-image associated with each of the three gear icon states: collapsed (.settings), hover
975         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
976         as a mask and make use of the CSS background-color to define the fill color for each of these three
977         states.
978
979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
980         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
981         (.settings:hover): Override CSS background-color for hover state.
982         (.settings-visible .settings): Override CSS background-color for expanded state.
983
984 2015-09-07  Andy Estes  <aestes@apple.com>
985
986         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
987         https://bugs.webkit.org/show_bug.cgi?id=148946
988         <rdar://problem/22603981>
989
990         Reviewed by Dan Bernstein.
991
992         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
993         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
994
995 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
996
997         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
998         https://bugs.webkit.org/show_bug.cgi?id=148927
999
1000         Reviewed by Csaba Osztrogonác.
1001
1002         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1003         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
1004
1005         * WebKitTestRunner/TestController.cpp:
1006         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
1007         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1008         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
1009
1010 2015-09-07  Andy Estes  <aestes@apple.com>
1011
1012         Fix the Production build after r189455.
1013
1014         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
1015         In-App Purchase template instead of the Aggregate template. Whoops.
1016
1017 2015-09-06  Andy Estes  <aestes@apple.com>
1018
1019         WebKit.xcworkspace should be be able to build iOS platforms
1020         https://bugs.webkit.org/show_bug.cgi?id=148881
1021
1022         Reviewed by Daniel Bates.
1023
1024         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
1025         for all supported platforms.
1026
1027         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
1028         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
1029         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
1030         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
1031
1032 2015-09-06  Andy Estes  <aestes@apple.com>
1033
1034         WebKitTestRunner should build for iOS using the default target
1035         https://bugs.webkit.org/show_bug.cgi?id=148918
1036
1037         Reviewed by Daniel Bates.
1038
1039         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
1040         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
1041         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
1042
1043         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
1044         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
1045         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
1046         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
1047         WebKitTestRunner is skipped when installing on iOS.
1048
1049         The target dependency graph now looks like this:
1050
1051             All
1052                 WebKitTestRunnerApp
1053                     WebKitTestRunner (Library)
1054                         WebKitTestRunnerInjectedBundle
1055                             Derived Sources
1056                 WebKitTestRunner
1057                     WebKitTestRunner (Library)
1058                         WebKitTestRunnerInjectedBundle
1059                             Derived Sources
1060
1061         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
1062         * Scripts/build-webkittestrunner: Ditto.
1063         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
1064         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
1065         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
1066         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
1067         excluded iOS-only files, and skipped installing on iOS.
1068         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
1069         excluded Mac-only files, and skipped installing on Mac.
1070         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
1071         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
1072         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
1073         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
1074         new configuration files.
1075
1076 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
1077
1078         Web Inspector: Improve prepare-ChangeLog for multiple cases
1079         https://bugs.webkit.org/show_bug.cgi?id=148875
1080
1081         Reviewed by Timothy Hatcher.
1082
1083         * Scripts/prepare-ChangeLog:
1084         (get_function_line_ranges_for_javascript):
1085         - We were ignoring everything inside of an anonymous function expression,
1086           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
1087           Better handle this by inserting a few tweaks.
1088         - Allow method syntax outside of classes as long as they are at the global level.
1089         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
1090
1091         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1092         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1093         (Foo.prototype.method1):
1094         (Foo.prototype.method2):
1095         (Foo.prototype.method3.innerFunction):
1096         (Foo.prototype.method3):
1097         (insideGlobalAnonymousFunctionExpression):
1098         (foo.insideGlobalFunctionExpression):
1099         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
1100         (IssueWithMapGetAndSet.prototype.method1):
1101         (IssueWithMapGetAndSet.prototype.method2):
1102         (IssueWithMapGetAndSet.prototype.method3):
1103         (IssueWithMapGetAndSet):
1104
1105 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1106
1107         [ES6] Enable ES6 Module in JSC shell by default
1108         https://bugs.webkit.org/show_bug.cgi?id=148689
1109
1110         Reviewed by Geoffrey Garen.
1111
1112         * Scripts/run-javascriptcore-tests:
1113         (runJSCStressTests):
1114         * Scripts/run-jsc-stress-tests:
1115
1116 2015-09-04  Basile Clement  <basile_clement@apple.com>
1117
1118         Unreviewed, change my email address.
1119
1120         * Scripts/webkitpy/common/config/contributors.json:
1121
1122 2015-09-04  Beth Dakin  <bdakin@apple.com>
1123
1124         Should have a test to make sure links don't navigate after a cancelled force 
1125         click
1126         https://bugs.webkit.org/show_bug.cgi?id=148846
1127
1128         Reviewed by Tim Horton.
1129
1130         New EventSender function for a started then cancelled force click.
1131         * WebKitTestRunner/EventSenderProxy.h:
1132         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1133         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1134         (WTR::EventSendingController::mouseForceClick):
1135         (WTR::EventSendingController::startAndCancelMouseForceClick):
1136         (WTR::EventSendingController::mouseForceDown):
1137         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1138         * WebKitTestRunner/TestController.cpp:
1139         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1140         * WebKitTestRunner/mac/EventSenderProxy.mm:
1141         (WTR::EventSenderProxy::mouseForceClick):
1142         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
1143         (WTR::EventSenderProxy::mouseForceDown):
1144         (WTR::EventSenderProxy::mouseMoveTo):
1145
1146 2015-09-04  Tim Horton  <timothy_horton@apple.com>
1147
1148         Add a test for r179736 (programmatic navigation during swipe causing a crash)
1149         https://bugs.webkit.org/show_bug.cgi?id=148830
1150
1151         Reviewed by Beth Dakin.
1152
1153         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1154         (WTR::InjectedBundle::beginTesting):
1155         Make sure that TestRunner callbacks don't leak between tests!
1156
1157 2015-09-04  Anders Carlsson  <andersca@apple.com>
1158
1159         It should be possible to pass relative HTTP test paths to DumpRenderTree
1160         https://bugs.webkit.org/show_bug.cgi?id=148825
1161         <rdar://problem/22583866>
1162
1163         Reviewed by Tim Horton.
1164
1165         Convert the path to an absolute path if needed.
1166
1167         * DumpRenderTree/mac/DumpRenderTree.mm:
1168         (computeTestURL):
1169
1170 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1171
1172         Fix Swift unit tests for prepare-ChangeLog.
1173         https://bugs.webkit.org/show_bug.cgi?id=148817
1174
1175         Reviewed by Alexey Proskuryakov.
1176
1177         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
1178         Swift unit tests for prepare-ChangeLog.
1179
1180 2015-09-04  Lucas Forschler  <lforschler@apple.com>
1181
1182         Modifications to the webkit-nightly logic.
1183         
1184         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
1185         (updateAlertPanel):
1186         * WebKitLauncher/main.m:
1187         (displayErrorAndQuit):
1188
1189 2015-09-04  Beth Dakin  <bdakin@apple.com>
1190
1191         Speculative build fix.
1192
1193         * WebKitTestRunner/mac/EventSenderProxy.mm:
1194
1195 2015-09-04  Brian Burg  <bburg@apple.com>
1196
1197         Web Inspector: InspectorController should support multiple frontend channels
1198         https://bugs.webkit.org/show_bug.cgi?id=148538
1199
1200         Reviewed by Joseph Pecoraro.
1201
1202         InspectorClients must explicitly disconnect their frontend channel(s) from the
1203         inspected page's InspectorController.
1204
1205         To make this possible, DumpRenderTree should not destroy non-primary views until
1206         it has tried to close any abandoned Web Inspector instances. Performing teardown
1207         in the reverse order prevents disconnection of the frontend channel because that
1208         prematurely destroys the inspector frontend client.
1209
1210         * DumpRenderTree/mac/DumpRenderTree.mm:
1211         (runTest):
1212         * DumpRenderTree/win/DumpRenderTree.cpp:
1213         (runTest):
1214
1215 2015-09-04  Beth Dakin  <bdakin@apple.com>
1216
1217         Need to be able to test default behaviors on force click
1218         https://bugs.webkit.org/show_bug.cgi?id=148758
1219
1220         Reviewed by Tim Horton.
1221
1222         This patch adds a new eventSender method to do a full, completed force click, 
1223         and it re-works all of the existing force methods to dispatch their events in 
1224         such a way that they will trigger the NSImmediateAction gesture recognizer. 
1225         To do this, first we need to send the events to the app rather than straight 
1226         to the view, and also needed to tweak some state and send the events in a 
1227         delayed fashion.
1228
1229         New public function mouseForceClick() and private helper functions to make 
1230         NSEvents.
1231         * WebKitTestRunner/EventSenderProxy.h:
1232
1233         New public function mouseForceClick().
1234         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1235         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1236         (WTR::EventSendingController::mouseMoveTo):
1237         (WTR::EventSendingController::mouseForceClick):
1238         (WTR::EventSendingController::mouseForceDown):
1239         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1240         * WebKitTestRunner/TestController.cpp:
1241         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1242
1243         initPressureEventAtLocation needs to take a stageTransition and a window.
1244         * WebKitTestRunner/mac/EventSenderProxy.mm:
1245         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1246         (-[EventSenderSyntheticEvent stageTransition]):
1247         (-[EventSenderSyntheticEvent timestamp]):
1248         (-[EventSenderSyntheticEvent _cgsEventRecord]):
1249         (-[EventSenderSyntheticEvent window]):
1250
1251         In order to enter the gesture recognizer, we need to start with a mouse down 
1252         that has a NSEventMaskPressure modifier.
1253         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
1254
1255         This ensures that the events queue properly for the force monitor in AppKit.
1256         (WTR::spinRunLoopForForce):
1257
1258          We need to start the pressure change events with a began.
1259         (WTR::EventSenderProxy::beginPressureEvent):
1260
1261         These functions can be used to create the NSEvent for a pressure change every 
1262         time we need one.
1263         (WTR::EventSenderProxy::pressureChangeEvent):
1264
1265         Send the right series of events to emulate a full, completed force click.
1266         (WTR::EventSenderProxy::mouseForceClick):
1267
1268         Use all of the new things for these existing functions.
1269         (WTR::EventSenderProxy::mouseForceDown):
1270         (WTR::EventSenderProxy::mouseForceUp):
1271         (WTR::EventSenderProxy::mouseForceChanged):
1272
1273         Set NSFakeForceTouchDevice to YES.
1274         * WebKitTestRunner/mac/main.mm:
1275         (setDefaultsToConsistentValuesForTesting):
1276
1277 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1278
1279         prepare-ChangeLog needs to know how to parse Swift files.
1280         https://bugs.webkit.org/show_bug.cgi?id=148784
1281         <rdar://problem/22510062>
1282
1283         Reviewed by Darin Adler.
1284
1285         * Scripts/prepare-ChangeLog:
1286         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
1287         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
1288         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
1289         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
1290         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
1291         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
1292         (freeFunction): Ditto.
1293         (MyClass.function): Ditto.
1294         (MyClass.functionWithArgument(_:)): Ditto.
1295         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
1296         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
1297         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
1298         (MyClass.classFunction): Ditto.
1299         (MyClass.readWriteComputedVariable): Ditto.
1300         (MyClass.readOnlyComputedVariable): Ditto.
1301
1302 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
1303
1304         Import css/css-color-3
1305         https://bugs.webkit.org/show_bug.cgi?id=148803
1306
1307         Reviewed by Chris Dumez.
1308
1309         Fixed a bug that the imported reference files used the same extention as tests.
1310         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
1311
1312         * Scripts/webkitpy/w3c/test_importer.py:
1313         (TestImporter.find_importable_tests):
1314
1315 2015-09-03  Commit Queue  <commit-queue@webkit.org>
1316
1317         Unreviewed, rolling out r189338.
1318         https://bugs.webkit.org/show_bug.cgi?id=148785
1319
1320         Caused tons of crashes (Requested by cdumez on #webkit).
1321
1322         Reverted changeset:
1323
1324         "Web Inspector: InspectorController should support multiple
1325         frontend channels"
1326         https://bugs.webkit.org/show_bug.cgi?id=148538
1327         http://trac.webkit.org/changeset/189338
1328
1329 2015-09-03  Brian Burg  <bburg@apple.com>
1330
1331         Web Inspector: InspectorController should support multiple frontend channels
1332         https://bugs.webkit.org/show_bug.cgi?id=148538
1333
1334         Reviewed by Joseph Pecoraro.
1335
1336         InspectorClients must explicitly disconnect their frontend channel(s) from the
1337         inspected page's InspectorController.
1338
1339         To make this possible, DumpRenderTree should not destroy non-primary views until
1340         it has tried to close any abandoned Web Inspector instances. Performing teardown
1341         in the reverse order prevents disconnection of the frontend channel because that
1342         prematurely destroys the inspector frontend client.
1343
1344         * DumpRenderTree/mac/DumpRenderTree.mm:
1345         (runTest):
1346         * DumpRenderTree/win/DumpRenderTree.cpp:
1347         (runTest):
1348
1349 2015-09-03  Timothy Hatcher  <timothy@apple.com>
1350
1351         Update WebKit nightly icon to be more like Safari
1352         https://bugs.webkit.org/show_bug.cgi?id=148768
1353
1354         Reviewed by Joseph Pecoraro.
1355
1356         * WebKitLauncher/webkit.icns:
1357
1358 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
1359
1360         JavaScriptCore should have some ES6 conformance tests
1361         https://bugs.webkit.org/show_bug.cgi?id=148771
1362
1363         Reviewed by Chris Dumez.
1364
1365         * Scripts/run-javascriptcore-tests:
1366         (runJSCStressTests): Added es6 as a test suite.
1367
1368         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
1369
1370         Some of these tests currently fail, so I also added a way to expect
1371         failure for now. We'll migrate failing tests to expected passes as we
1372         fix them.
1373
1374 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1375
1376         Add a test for swipe-start hysteresis
1377         https://bugs.webkit.org/show_bug.cgi?id=148756
1378
1379         Reviewed by Anders Carlsson.
1380
1381         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1382         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1383         (WTR::cacheTestRunnerCallback):
1384         (WTR::TestRunner::clearTestRunnerCallbacks):
1385         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1386         Make sure that we log if a client tries to install a callback twice
1387         (since we use .add, the second call would not work).
1388
1389         Also, add clearTestRunnerCallbacks so tests can swap out installed
1390         callbacks.
1391
1392 2015-09-03  Anders Carlsson  <andersca@apple.com>
1393
1394         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
1395         https://bugs.webkit.org/show_bug.cgi?id=148746
1396         rdar://problem/22568073
1397
1398         Reviewed by Tim Horton.
1399
1400         * DumpRenderTree/mac/DumpRenderTree.mm:
1401         (computeTestURL):
1402         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
1403
1404         (runTest):
1405         Call computeTestURL.
1406
1407         (testPathFromURL):
1408         Get rid of this; computeTestURL does this for us now.
1409
1410         * Scripts/webkitpy/port/driver.py:
1411         (Driver._command_from_driver_input):
1412         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
1413
1414 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1415
1416         Swipe tests fail on Mavericks
1417         https://bugs.webkit.org/show_bug.cgi?id=148752
1418
1419         Reviewed by Beth Dakin.
1420
1421         * WebKitTestRunner/mac/EventSenderProxy.mm:
1422
1423 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1424
1425         Fix the 32-bit build
1426
1427         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1428         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1429
1430 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1431
1432         Remove some logging that wasn't meant to be in the tree
1433
1434         * WebKitTestRunner/mac/EventSenderProxy.mm:
1435         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1436
1437 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1438
1439         [Mac] Add support for testing swipes
1440         https://bugs.webkit.org/show_bug.cgi?id=148700
1441
1442         Reviewed by Beth Dakin.
1443
1444         * WebKitTestRunner/EventSenderProxy.h:
1445         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1446         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1447         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1448         (WTR::cgEventPhaseFromString):
1449         (WTR::cgEventMomentumPhaseFromString):
1450         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1451         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
1452         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1453         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1454         (WTR::InjectedBundle::didReceiveMessageToPage):
1455         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1456         (WTR::TestRunner::installDidBeginSwipeCallback):
1457         (WTR::TestRunner::installWillEndSwipeCallback):
1458         (WTR::TestRunner::installDidEndSwipeCallback):
1459         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
1460         (WTR::TestRunner::callDidBeginSwipeCallback):
1461         (WTR::TestRunner::callWillEndSwipeCallback):
1462         (WTR::TestRunner::callDidEndSwipeCallback):
1463         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
1464         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1465         * WebKitTestRunner/TestController.cpp:
1466         (WTR::TestController::createOtherPage):
1467         (WTR::TestController::createWebViewWithOptions):
1468         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1469         (WTR::TestController::didBeginNavigationGesture):
1470         (WTR::TestController::willEndNavigationGesture):
1471         (WTR::TestController::didEndNavigationGesture):
1472         (WTR::TestController::didRemoveNavigationGestureSnapshot):
1473         * WebKitTestRunner/TestController.h:
1474         * WebKitTestRunner/TestInvocation.cpp:
1475         (WTR::TestInvocation::didBeginSwipe):
1476         (WTR::TestInvocation::willEndSwipe):
1477         (WTR::TestInvocation::didEndSwipe):
1478         (WTR::TestInvocation::didRemoveSwipeSnapshot):
1479         * WebKitTestRunner/TestInvocation.h:
1480         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
1481         when the snapshot is removed.
1482
1483         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
1484         mouseScrollBy function.
1485
1486         * WebKitTestRunner/mac/EventSenderProxy.mm:
1487         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1488         (-[EventSenderSyntheticEvent type]):
1489         (-[EventSenderSyntheticEvent subtype]):
1490         (-[EventSenderSyntheticEvent locationInWindow]):
1491         (-[EventSenderSyntheticEvent location]):
1492         (-[EventSenderSyntheticEvent momentumPhase]):
1493         (-[EventSenderSyntheticEvent _isTouchesEnded]):
1494         (-[EventSenderSyntheticEvent _cgsEventRecord]):
1495         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
1496         more adjustable values.
1497
1498         (WTR::EventSenderProxy::mouseForceDown):
1499         (WTR::EventSenderProxy::mouseForceUp):
1500         (WTR::EventSenderProxy::mouseForceChanged):
1501         Adopt EventSenderSyntheticEvent.
1502
1503         (WTR::nsEventPhaseFromCGEventPhase):
1504         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1505         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
1506
1507         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1508         (WTR::PlatformWebView::PlatformWebView):
1509         Enable swipe.
1510
1511 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
1512
1513         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
1514         https://bugs.webkit.org/show_bug.cgi?id=148723
1515
1516         Reviewed by Anders Carlsson.
1517
1518         * WebKitTestRunner/TestController.cpp:
1519         (WTR::testPath):
1520         (WTR::updateViewOptionsFromTestHeader):
1521         (WTR::TestController::viewOptionsForTest):
1522
1523 2015-09-03  Lucas Forschler  <lforschler@apple.com>
1524
1525         Test commit.
1526
1527 2015-09-02  Tim Horton  <timothy_horton@apple.com>
1528
1529         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
1530         https://bugs.webkit.org/show_bug.cgi?id=148693
1531
1532         Reviewed by Anders Carlsson.
1533
1534         * WebKitTestRunner/TestController.cpp:
1535         (WTR::TestController::createOtherPage):
1536         (WTR::TestController::createWebViewWithOptions):
1537
1538 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1539
1540         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
1541         https://bugs.webkit.org/show_bug.cgi?id=148529
1542
1543         Reviewed by Darin Adler.
1544
1545         When there are pending EventSender messages after a test finishes,
1546         they could be processed in the main loop started by the
1547         resetStateToConsistentValues(), but the old EventSender has been
1548         replaced by a new one at that point. The new Eventsender can crash
1549         when processing messages that were sent to the old one. To avoid
1550         this, we return early when receiving an EventSender message and
1551         the TestController state is not RunningTest.
1552
1553         * WebKitTestRunner/TestController.cpp:
1554         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
1555         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1556
1557 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1558
1559         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
1560         https://bugs.webkit.org/show_bug.cgi?id=148528
1561
1562         Reviewed by Darin Adler.
1563
1564         Before r188548 resetStateToConsistentValues() was called in
1565         TestController::run(), before tests are run, but now it's called
1566         for every test in TestInvocation::invoke(), after m_status has
1567         changed to RunningTest.
1568
1569         * WebKitTestRunner/TestController.cpp:
1570         (WTR::TestController::resetStateToConsistentValues): Use
1571         TemporaryChange to reset m_state ot its previous value after reset
1572         is done.
1573
1574 2015-08-31  Jason Marcell  <jmarcell@apple.com>
1575
1576         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
1577         that are marked as requiring corresponding tests.
1578         https://bugs.webkit.org/show_bug.cgi?id=148498
1579         <rdar://problem/21555314>
1580
1581         Reviewed by Dan Bernstein and David Kilzer.
1582
1583         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
1584         simulate Git's attribute behevaior.
1585         (main): Added "requiresTests" array to contain files that require tests.
1586         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
1587         section in ChangeLog.
1588         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
1589         however, we check if the file or any containing folder has the given property set to "1" and
1590         return 1 if so; return 0 otherwise.
1591         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
1592         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
1593
1594 2015-08-26  Andy Estes  <aestes@apple.com>
1595
1596         [Content Filtering] Determine navigation and content policy before continuing to filter a load
1597         https://bugs.webkit.org/show_bug.cgi?id=148506
1598
1599         Reviewed by Brady Eidson.
1600
1601         Added download API tests covering every decision and decision point.
1602         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
1603
1604         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
1605         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
1606         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1607         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
1608         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
1609         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
1610         decision and decision point as a bundle parameter.
1611         (+[MockContentFilterEnabler supportsSecureCoding]):
1612         (-[MockContentFilterEnabler copyWithZone:]):
1613         (-[MockContentFilterEnabler initWithCoder:]):
1614         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
1615         (-[MockContentFilterEnabler encodeWithCoder:]):
1616         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
1617         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
1618         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
1619         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
1620         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
1621         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
1622         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
1623         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
1624         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
1625         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
1626         (+[MockContentFilterEnabler supportsSecureCoding]):
1627         (-[MockContentFilterEnabler copyWithZone:]):
1628         (-[MockContentFilterEnabler initWithCoder:]):
1629         (-[MockContentFilterEnabler dealloc]):
1630         (-[MockContentFilterEnabler encodeWithCoder:]):
1631         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
1632         (-[ContentFilteringPlugIn dealloc]): Stop observing.
1633         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
1634         (+[ServerRedirectPlugIn initialize]): Deleted.
1635         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1636         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1637         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
1638         (TEST): Deleted.
1639
1640 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
1641
1642         Skip slow lock tests on Windows/debug
1643         https://bugs.webkit.org/show_bug.cgi?id=148643
1644
1645         Reviewed by Alexey Proskuryakov.
1646
1647         The lock tests simulate a critical section by doing some floating point math, and then either
1648         make those critical sections very long or invoke them many times. This appears to be
1649         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
1650         that kind of computation slow.
1651
1652         These tests are almost as useful in release as they are in debug, so it's probably better to
1653         just skip the in debug on platforms where this causes timeouts.
1654
1655         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1656         (TestWebKitAPI::runLockTest):
1657         (TestWebKitAPI::skipSlow):
1658         (TestWebKitAPI::TEST):
1659
1660 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
1661
1662         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
1663         https://bugs.webkit.org/show_bug.cgi?id=125720
1664
1665         Reviewed by Daniel Bates.
1666
1667         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
1668
1669         * DumpRenderTree/AccessibilityUIElement.cpp:
1670         (pressCallback):
1671         (scrollToMakeVisibleWithSubFocusCallback):
1672         (scrollToGlobalPointCallback):
1673         (scrollToMakeVisibleCallback):
1674         (AccessibilityUIElement::getJSClass):
1675         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1676         (AccessibilityUIElement::scrollToMakeVisible):
1677         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1678         (AccessibilityUIElement::scrollToGlobalPoint):
1679         (AccessibilityUIElement::selectedTextRange):
1680         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1681         (AccessibilityUIElement::AccessibilityUIElement):
1682         (AccessibilityUIElement::mathPrescriptsDescription):
1683         (AccessibilityUIElement::scrollToMakeVisible):
1684         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1685         (AccessibilityUIElement::scrollToGlobalPoint):
1686         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1687         (WTR::AccessibilityUIElement::isTextMarkerValid):
1688         (WTR::AccessibilityUIElement::textMarkerForIndex):
1689         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1690         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1691         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1692         (WTR::AccessibilityUIElement::supportedActions):
1693         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1694         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1695         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1696         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1697         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1698         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1699         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1700         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1701         (WTR::AccessibilityUIElement::selectedTextRange):
1702         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1703         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1704         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1705         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1706         (WTR::AccessibilityUIElement::selectedTextRange):
1707
1708 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
1709
1710         Add a mysteriously nonproblematic missing comma.
1711
1712         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1713         (TestExpectationParser._collect_matching_tests):
1714         (TestExpectationParser):
1715
1716 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
1717
1718         Remove an old temporary script that has served its purpose
1719
1720         * Scripts/convert-test-expectations: Removed.
1721
1722 2015-08-28  Jer Noble  <jer.noble@apple.com>
1723
1724         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
1725         https://bugs.webkit.org/show_bug.cgi?id=148579
1726
1727         Reviewed by Anders Carlsson.
1728
1729         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
1730
1731         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
1732         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
1733
1734         * DumpRenderTree/mac/DumpRenderTree.mm:
1735         (resetWebPreferencesToConsistentValues):
1736         (resetWebViewToConsistentStateBeforeTesting): 
1737         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1738         (WTR::initializeWebViewConfiguration):
1739
1740 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
1741
1742         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
1743         https://bugs.webkit.org/show_bug.cgi?id=148592
1744
1745         Reviewed by Tim Horton.
1746
1747         * Scripts/webkitpy/port/base.py:
1748         (Port.to.setup_environ_for_server):
1749         (Port.to):
1750         (Port.to._append_value_colon_separated):
1751         (Port.to.show_results_html_file):
1752         * Scripts/webkitpy/port/ios.py:
1753         (IOSSimulatorPort.setup_environ_for_server):
1754         * Scripts/webkitpy/port/mac.py:
1755         (MacPort.setup_environ_for_server):
1756
1757 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
1758
1759         LICM should be sound even if the CFG has changed
1760         https://bugs.webkit.org/show_bug.cgi?id=148259
1761
1762         Reviewed by Benjamin Poulain.
1763
1764         Add a utility for creating tests that set some uncommon option.
1765
1766         * Scripts/run-jsc-stress-tests:
1767
1768 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
1769
1770         [Win] Unreviewed EWS correction.
1771
1772         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
1773
1774 2015-08-28  Jer Noble  <jer.noble@apple.com>
1775
1776         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
1777         https://bugs.webkit.org/show_bug.cgi?id=147512
1778
1779         Reviewed by Anders Carlsson.
1780
1781         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
1782         to a consistent (true) value.
1783
1784         * DumpRenderTree/mac/DumpRenderTree.mm:
1785         (setDefaultsToConsistentValuesForTesting):
1786         * WebKitTestRunner/TestController.cpp:
1787         (WTR::TestController::resetPreferencesToConsistentValues):
1788
1789 2015-08-28  Tim Horton  <timothy_horton@apple.com>
1790
1791         Add navigation gesture callbacks to WKPageNavigationClient
1792         https://bugs.webkit.org/show_bug.cgi?id=148568
1793         <rdar://problem/22371346>
1794
1795         Reviewed by Anders Carlsson.
1796
1797         * WebKitTestRunner/TestController.cpp:
1798         (WTR::TestController::createOtherPage):
1799         (WTR::TestController::createWebViewWithOptions):
1800         Add some zeroes.
1801
1802 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
1803
1804         [Mac] kill-old-processes should kill more processes
1805         https://bugs.webkit.org/show_bug.cgi?id=148577
1806
1807         Reviewed by Tim Horton.
1808
1809         * BuildSlaveSupport/kill-old-processes:
1810
1811 2015-08-28  Jason Marcell  <jmarcell@apple.com>
1812
1813         The status message for combined builder queues should say "all builds succeeded" if everything
1814         built correctly.
1815         https://bugs.webkit.org/show_bug.cgi?id=148535
1816
1817         Reviewed by David Kilzer and Alexey Proskuryakov.
1818
1819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1820         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
1821         say "all builds succeeded" if everything built correctly.
1822
1823 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1824
1825         [GTK] Simplify the internal API to create a WebView
1826         https://bugs.webkit.org/show_bug.cgi?id=148570
1827
1828         Reviewed by Žan Doberšek.
1829
1830         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
1831         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1832         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
1833         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
1834         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
1835         passing the received PageConfiguration.
1836         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1837         (WTR::PlatformWebView::PlatformWebView): Create the WebView
1838         passing the received PageConfiguration.
1839
1840 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
1841
1842         iOS Simulator API tests fails as Simulator is not running
1843         https://bugs.webkit.org/show_bug.cgi?id=148501
1844         rdar://problem/22447525
1845
1846         Reviewed by Daniel Bates.
1847
1848         This change is a workaround for <rdar://problem/22388812>.
1849
1850          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
1851          and quit it on program termination when running tests on the iOS port.
1852          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
1853          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
1854
1855 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1856
1857         Make DLLLauncherMain executables dependent on dll
1858         https://bugs.webkit.org/show_bug.cgi?id=148548
1859
1860         Reviewed by Brent Fulgham.
1861
1862         * DumpRenderTree/CMakeLists.txt:
1863         * DumpRenderTree/PlatformWin.cmake:
1864         * MiniBrowser/win/CMakeLists.txt:
1865         * TestWebKitAPI/CMakeLists.txt:
1866         * TestWebKitAPI/PlatformWin.cmake:
1867
1868 2015-08-27  Lucas Forschler  <lforschler@apple.com>
1869
1870         Remove Mac slaves 188/189 after being replaced with 400/401.
1871         
1872         Unreviewed.
1873         
1874         * BuildSlaveSupport/build.webkit.org-config/config.json:
1875
1876 2015-08-27  Lucas Forschler  <lforschler@apple.com>
1877
1878         Add two bots to the Mac Yosemite queue.
1879         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
1880         
1881         Unreviewed.
1882         
1883         * BuildSlaveSupport/build.webkit.org-config/config.json:
1884
1885 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1886
1887         [Win CMake] Fix incremental build after r188673
1888         https://bugs.webkit.org/show_bug.cgi?id=148539
1889
1890         Reviewed by Brent Fulgham.
1891
1892         * TestWebKitAPI/PlatformWin.cmake:
1893         Copy forwarding headers from WebCore before building in case that was not yet done.
1894         It used to be done when running CMake, but now it's a build step.
1895
1896 2015-08-27  Nan Wang  <n_wang@apple.com>
1897
1898         AX: Fix accessibility/select-element-at-index.html test
1899         https://bugs.webkit.org/show_bug.cgi?id=148516
1900
1901         Reviewed by Chris Fleizach.
1902
1903         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
1904
1905         * DumpRenderTree/AccessibilityUIElement.cpp:
1906         (setSelectedChildCallback):
1907         (setSelectedChildAtIndexCallback):
1908         (removeSelectionAtIndexCallback):
1909         (elementAtPointCallback):
1910         (sentenceAtOffsetCallback):
1911         (stringForSelectionCallback):
1912         (AccessibilityUIElement::getJSClass):
1913         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1914         (AccessibilityUIElement::setSelectedChild):
1915         (AccessibilityUIElement::setSelectedChildAtIndex):
1916         (AccessibilityUIElement::removeSelectionAtIndex):
1917         (AccessibilityUIElement::accessibilityValue):
1918         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1919         (WTR::AccessibilityUIElement::wordAtOffset):
1920         (WTR::AccessibilityUIElement::lineAtOffset):
1921         (WTR::AccessibilityUIElement::sentenceAtOffset):
1922         (WTR::AccessibilityUIElement::isSelectable):
1923         (WTR::AccessibilityUIElement::isMultiSelectable):
1924         (WTR::AccessibilityUIElement::setSelectedChild):
1925         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1926         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1927         (WTR::AccessibilityUIElement::selectedChildrenCount):
1928         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1929         (WTR::AccessibilityUIElement::isExpanded):
1930         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1931         (WTR::AccessibilityUIElement::setSelectedChild):
1932         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1933         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1934         (WTR::AccessibilityUIElement::accessibilityValue):
1935
1936 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1937
1938         Build fix after r188982
1939
1940         * MiniBrowser/win/CMakeLists.txt:
1941         The directory structure changed in the move.
1942
1943 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
1944
1945         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
1946
1947         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
1948
1949         * gtk/install-dependencies:
1950
1951 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1952
1953         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
1954
1955         * Scripts/run-gtk-tests:
1956         (TestRunner):
1957
1958 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1959
1960         Fix GTK+ WTR crashes in initializeMainRunLoop()
1961
1962         Rubber-stamped by Žan Doberšek.
1963
1964         Initialize threading and main thread before
1965         RunLoop::initializeMainRunLoop(), since the GLib implementation of
1966         the RunLoop uses isMainThread() to decide whether to create a new
1967         GMainContext or use the default one. Also use RunLoop::run() and
1968         ::stop() instead of gtk_main/quit.
1969
1970         * WebKitTestRunner/TestController.cpp:
1971         (WTR::TestController::initialize):
1972         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1973         (WTR::TestController::notifyDone):
1974         (WTR::TestController::platformRunUntil):
1975
1976 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
1977
1978         Unreviewed, further shorten a test that times out because it's very long
1979         running.
1980
1981         I've locally run these tests on repeat for 24 hours and found no genuine
1982         failures, like deadlocks. So, the timeouts are probably because the test
1983         machine is slow and debug is slow. We should just run this test for fewer
1984         iterations.
1985
1986         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1987         (TestWebKitAPI::TEST):
1988
1989 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
1990
1991         Unreviewed build fix attempt on EFL
1992
1993         * WebKitTestRunner/PlatformEfl.cmake:
1994
1995 2015-08-26  Alex Christensen  <achristensen@webkit.org>
1996
1997         Build fix after r188982
1998
1999         * MiniBrowser/win/CMakeLists.txt:
2000         Find .rc files in correct directory.
2001
2002 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
2003
2004         [EFL] Bump cairo version to 1.14.2
2005         https://bugs.webkit.org/show_bug.cgi?id=148474
2006
2007         Reviewed by Csaba Osztrogonác.
2008
2009         * efl/jhbuild.modules:
2010
2011 2015-08-26  Andy Estes  <aestes@apple.com>
2012
2013         Crash when following a Google search link to Twitter with Limit Adult Content enabled
2014         https://bugs.webkit.org/show_bug.cgi?id=147651
2015
2016         Rubber-stamped by Brady Eidson.
2017
2018         Taught TestRunner how to decide the navigation policy after a delay.
2019
2020         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2021         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2022         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2023         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2024         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2025         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2026         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2027         * WebKitTestRunner/TestController.cpp:
2028         (WTR::TestController::initialize):
2029         (WTR::TestController::resetStateToConsistentValues):
2030         (WTR::TestController::decidePolicyForNavigationAction):
2031         * WebKitTestRunner/TestController.h:
2032         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2033         * WebKitTestRunner/TestInvocation.cpp:
2034         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2035
2036 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2037
2038         [Win] Rename 'WinLauncher' to 'MiniBrowser'
2039         https://bugs.webkit.org/show_bug.cgi?id=148485
2040
2041         Reviewed by Alex Christensen
2042
2043         Move the WinLauncher project and source files to a subdirectory
2044         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
2045         source code and project files.
2046         
2047         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
2048         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
2049         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
2050         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
2051         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
2052         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
2053         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
2054         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
2055         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
2056         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
2057         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
2058         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
2059         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
2060         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
2061         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
2062         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
2063         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
2064         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
2065         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
2066         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
2067         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
2068         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
2069         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
2070         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
2071         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
2072         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
2073         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
2074         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
2075         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
2076         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
2077         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
2078         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
2079         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
2080         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
2081         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2082         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
2083         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
2084         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2085         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2086         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
2087         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
2088         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
2089         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
2090         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
2091         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
2092         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
2093         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
2094         * MiniBrowser/win: Copied from WinLauncher.
2095         * MiniBrowser/win/Common.cpp:
2096         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
2097         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
2098         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
2099         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
2100         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
2101         * MiniBrowser/win/PageLoadTestClient.cpp:
2102         * MiniBrowser/win/PageLoadTestClient.h:
2103         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2104         * MiniBrowser/win/ResourceLoadDelegate.h:
2105         * MiniBrowser/win/WinLauncher.cpp: Removed.
2106         * MiniBrowser/win/WinLauncher.h: Removed.
2107         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
2108         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2109         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2110         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2111         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2112         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2113         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2114         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2115         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2116         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2117         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2118         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2119         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2120         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2121         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2122         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2123         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2124         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2125         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2126         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2127         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2128         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2129         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2130         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2131         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
2132         * MiniBrowser/win/WinLauncherReplace.h: Removed.
2133         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
2134         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
2135         * MiniBrowser/win/WinMain.cpp:
2136         * WinLauncher: Removed.
2137         * WinLauncher/AccessibilityDelegate.cpp: Removed.
2138         * WinLauncher/AccessibilityDelegate.h: Removed.
2139         * WinLauncher/CMakeLists.txt: Removed.
2140         * WinLauncher/Common.cpp: Removed.
2141         * WinLauncher/DOMDefaultImpl.cpp: Removed.
2142         * WinLauncher/DOMDefaultImpl.h: Removed.
2143         * WinLauncher/PageLoadTestClient.cpp: Removed.
2144         * WinLauncher/PageLoadTestClient.h: Removed.
2145         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
2146         * WinLauncher/PrintWebUIDelegate.h: Removed.
2147         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
2148         * WinLauncher/ResourceLoadDelegate.h: Removed.
2149         * WinLauncher/WebDownloadDelegate.cpp: Removed.
2150         * WinLauncher/WebDownloadDelegate.h: Removed.
2151         * WinLauncher/WinLauncher.cpp: Removed.
2152         * WinLauncher/WinLauncher.h: Removed.
2153         * WinLauncher/WinLauncher.vcxproj: Removed.
2154         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2155         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2156         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2157         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2158         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2159         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2160         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2161         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2162         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2163         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2164         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2165         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2166         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2167         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2168         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2169         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2170         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2171         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2172         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2173         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2174         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2175         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2176         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2177         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
2178         * WinLauncher/WinLauncherReplace.h: Removed.
2179         * WinLauncher/WinLauncherWebHost.cpp: Removed.
2180         * WinLauncher/WinLauncherWebHost.h: Removed.
2181         * WinLauncher/WinMain.cpp: Removed.
2182         * WinLauncher/resource.h: Removed.
2183         * WinLauncher/stdafx.cpp: Removed.
2184         * WinLauncher/stdafx.h: Removed.
2185         * win/AssembleBuildLogs/AssembleLogs.cmd:
2186
2187 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2188
2189         [Win] Simplify menu handling code in WinLauncher
2190         https://bugs.webkit.org/show_bug.cgi?id=148461
2191
2192         Reviewed by Zalan Bujtas.
2193
2194         Revise 'ToggleMenuItem' to return a boolean value indicating if
2195         it handled the message. Revise WndProc to use this to decide if it
2196         should pass the message on to the default handler, rather than
2197         duplicating the logic in both places.
2198         
2199         * WinLauncher/Common.cpp:
2200         (ToggleMenuItem): Return true if the menu item message was handled.
2201         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
2202         the message tothe default handler.
2203
2204 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
2205
2206         Remove unused code after r188948
2207         https://bugs.webkit.org/show_bug.cgi?id=148467
2208
2209         Reviewed by Gyuyoung Kim.
2210
2211         * WebKitTestRunner/TestController.cpp:
2212         (WTR::TestController::platformPreferences): Deleted.
2213
2214 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2215
2216         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
2217         https://bugs.webkit.org/show_bug.cgi?id=148377
2218
2219         Reviewed by Carlos Garcia Campos.
2220
2221         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
2222         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
2223         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
2224         EFL and GTK at the moment.
2225
2226         * WebKitTestRunner/TestController.cpp:
2227         (WTR::TestController::platformWillRunTest):
2228         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2229         (WTR::TestController::platformPreferences):
2230         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2231         (WTR::TestController::platformPreferences):
2232
2233 2015-08-25  Nan Wang  <n_wang@apple.com>
2234
2235         AX: Enable accessibility/aria-controls.html test for mac
2236         https://bugs.webkit.org/show_bug.cgi?id=148458
2237
2238         Reviewed by Chris Fleizach.
2239
2240         Implemented ariaControlsElementAtIndex(unsigned index).
2241
2242         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2243         (AccessibilityUIElement::ariaControlsElementAtIndex):
2244         (AccessibilityUIElement::disclosedRowAtIndex):
2245         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2246         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2247
2248 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2249
2250         Remove python tests for PassRefPtr 
2251         https://bugs.webkit.org/show_bug.cgi?id=148463
2252
2253         Reviewed by Andy Estes.
2254
2255         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
2256
2257         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2258         (PassPtrTest): Deleted.
2259         (PassPtrTest.assert_pass_ptr_check): Deleted.
2260         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
2261         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
2262         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
2263         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
2264         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
2265         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
2266
2267 2015-08-25  Andy Estes  <aestes@apple.com>
2268
2269         [iOS] run-webkit-tests fails if watchOS SDK is installed
2270         https://bugs.webkit.org/show_bug.cgi?id=148453
2271
2272         Reviewed by David Kilzer.
2273
2274         * Scripts/webkitpy/xcode/simulator.py:
2275         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
2276         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2277
2278 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
2279
2280         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
2281         https://bugs.webkit.org/show_bug.cgi?id=148197
2282         rdar://problem/22334382
2283
2284         Reviewed by Daniel Bates.
2285
2286         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
2287         * Scripts/webkitpy/port/ios.py:
2288         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
2289         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
2290         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
2291         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
2292         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
2293
2294 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2295
2296         Remove PassRefPtr style check rule
2297         https://bugs.webkit.org/show_bug.cgi?id=148432
2298
2299         Reviewed by Andreas Kling.
2300
2301         PassRefPtr is being removed. Thus style rule needs to be removed as well.
2302
2303         * Scripts/webkitpy/style/checkers/cpp.py:
2304         (_check_parameter_name_against_text): Deleted.
2305         (check_function_definition_and_pass_ptr): Deleted.
2306         (check_function_definition): Deleted.
2307         (check_pass_ptr_usage): Deleted.
2308         (process_line): Deleted.
2309         (CppChecker): Deleted.
2310
2311 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
2312
2313         [Win] Expose "Inverted Colors" option in WinLauncher
2314         https://bugs.webkit.org/show_bug.cgi?id=148451
2315
2316         Reviewed by Tim Horton.
2317
2318         Add the ability to toggle the "Inverted Colors" preference
2319         in WinLauncher.
2320         
2321         * WinLauncher/Common.cpp:
2322         (ToggleMenuItem): Toggle the feature when the menu item
2323         is selected.
2324         (WndProc): Recognize the new menu option.
2325         * WinLauncher/WinLauncher.cpp:
2326         (WinLauncher::setToDefaultPreferences): Launch with "Invert
2327         Colors" turned off.
2328         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
2329         entry for "Invert Colors".
2330         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2331
2332 2015-08-25  Nan Wang  <n_wang@apple.com>
2333
2334         [Mac] accessibility/document-attributes.html fails
2335         https://bugs.webkit.org/show_bug.cgi?id=116636
2336
2337         Reviewed by Chris Fleizach.
2338
2339         Implemented documentURI() and documentEncoding().
2340
2341         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2342         (AccessibilityUIElement::documentEncoding):
2343         (AccessibilityUIElement::documentURI):
2344         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2345         (WTR::AccessibilityUIElement::documentEncoding):
2346         (WTR::AccessibilityUIElement::documentURI):
2347
2348 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
2349
2350         [Win] Unreviewed test gardening.
2351
2352         Fix another case where the logging string is constructed using the variable 'frame',
2353         but the method argument is not given a name. This causes the global 'frame' value to
2354         be used, producing incorrect output.
2355
2356         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2357         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
2358         argument.
2359
2360 2015-08-24  Tim Horton  <timothy_horton@apple.com>
2361
2362         (Finally...) get rid of WKViewIOS
2363         https://bugs.webkit.org/show_bug.cgi?id=148404
2364
2365         Reviewed by Anders Carlsson.
2366
2367         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2368         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2369         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2370         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2371         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2372         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2373         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
2374         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2375         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2376         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
2377         Mark tests that use WKBrowsingContextController as Mac-only.
2378
2379         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2380         (WTR::AccessibilityController::addNotificationListener):
2381         * WebKitTestRunner/ios/mainIOS.mm:
2382         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
2383         Import UIKit instead of depending on WKView.h to do so.
2384
2385 2015-08-24  Jason Marcell  <jmarcell@apple.com>
2386
2387         Add support to dashboard for displaying Git SHA's as revisions.
2388         https://bugs.webkit.org/show_bug.cgi?id=148387
2389
2390         Reviewed by Daniel Bates.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2393         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2395         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
2397         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
2398
2399 2015-08-24  Andy Estes  <aestes@apple.com>
2400
2401         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
2402
2403         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
2404
2405 2015-08-23  Andy Estes  <aestes@apple.com>
2406
2407         Addressed a missed piece of review feedback from r188851.
2408
2409         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2410
2411 2015-08-23  Andy Estes  <aestes@apple.com>
2412
2413         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
2414         https://bugs.webkit.org/show_bug.cgi?id=147872
2415         rdar://problem/22044000
2416
2417         Reviewed by Dan Bernstein.
2418         
2419         Added an API test.
2420
2421         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
2422         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2423         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
2424         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
2425         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
2426         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
2427         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
2428         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
2429         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
2430         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
2431         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
2432
2433 2015-08-23  Andy Estes  <aestes@apple.com>
2434
2435         Fixed the 32-bit Mac build after r188844.
2436
2437         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
2438         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2439
2440 2015-08-22  Andy Estes  <aestes@apple.com>
2441
2442         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
2443         https://bugs.webkit.org/show_bug.cgi?id=148317
2444
2445         Reviewed by Dan Bernstein.
2446
2447         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
2448         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
2449         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
2450         when creating WKWebViews.
2451
2452         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
2453         added a new API test for bundle parameters.
2454
2455         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
2456         named its executable TestWebKitAPI.bundle.
2457         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
2458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
2459         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
2460         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
2461         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
2462         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
2463         bundle parameter and asked for an initial notification.
2464         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
2465         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
2466         mirror its value in the main frame's JSContext.
2467         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
2468         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
2469         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
2470         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
2471         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
2472         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
2473         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
2474         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
2475         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
2476         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
2477
2478 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
2479
2480         URTBF after r188828.
2481
2482         * WebKitTestRunner/PlatformWebView.h:
2483
2484 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
2485
2486         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
2487         https://bugs.webkit.org/show_bug.cgi?id=148356
2488
2489         Reviewed by Darin Adler.
2490
2491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2492         (BuildbotCombinedQueueView.prototype.update):
2493
2494 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
2495
2496         build.webkit.org/dashboard: Respect step's hidden flag
2497         https://bugs.webkit.org/show_bug.cgi?id=148357
2498
2499         Reviewed by Darin Adler.
2500
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2502         (BuildbotIteration.prototype._parseData):
2503
2504 2015-08-23  Nan Wang  <n_wang@apple.com>
2505
2506         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
2507         https://bugs.webkit.org/show_bug.cgi?id=148328
2508
2509         Reviewed by Darin Adler.
2510
2511         We should only expose stringValue() when value attribute is set.
2512
2513         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2514         (AccessibilityUIElement::stringValue):
2515         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2516         (WTR::AccessibilityUIElement::stringValue):
2517
2518 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2519
2520         Remove style checking rule regarding OwnPtr and PassOwnPtr
2521         https://bugs.webkit.org/show_bug.cgi?id=148360
2522
2523         Reviewed by Darin Adler.
2524
2525         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
2526         Removed it.
2527
2528         * Scripts/do-webcore-rename:
2529         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2530         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
2531         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
2532         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
2533         (WebKitStyleTest.test_names): Deleted.
2534
2535 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
2536
2537         WebKitTestRunner should use WKWebView on OS X and iOS
2538         https://bugs.webkit.org/show_bug.cgi?id=143743
2539         <rdar://problem/16947123>
2540
2541         Reviewed by Anders Carlsson.
2542         Patch by Enrica Casucci and myself.
2543
2544         * WebKitTestRunner/PlatformWebView.h:
2545         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
2546         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
2547         instead of WKContext and WKPageGroup.
2548
2549         Remove the unused, always-true windowSnapshotEnabled().
2550         While technically some platforms don't have window snapshotting,
2551         they just return null instead of implementing windowSnapshotEnabled().
2552
2553         * WebKitTestRunner/TestController.h:
2554         * WebKitTestRunner/TestController.cpp:
2555         (WTR::TestController::createOtherPage):
2556         (WTR::TestController::initialize):
2557         (WTR::TestController::createWebViewWithOptions):
2558         Delegate to the various platforms for creating PlatformWebView instances,
2559         for creating WKContexts, and for accessing WKPreferences,
2560         so that they can do special things (like, use WKWebView instead!).
2561
2562         (WTR::TestController::resetPreferencesToConsistentValues):
2563         Make explicit WebKitTestRunner's desired default for two preferences
2564         which have differing defaults between the antique and modern API,
2565         for consistency's sake.
2566
2567         (WTR::TestController::resetStateToConsistentValues):
2568         Add platformResetStateToConsistentValues.
2569
2570         * WebKitTestRunner/TestInvocation.cpp:
2571         (WTR::TestInvocation::dumpResults):
2572         Adjust to the aforementioned removal of windowSnapshotEnabled().
2573
2574         * WebKitTestRunner/ios/TestControllerCocoa.mm:
2575         (WTR::TestController::platformResetStateToConsistentValues):
2576         (WTR::TestController::platformPreferences):
2577         (WTR::TestController::platformCreateWebView):
2578         (WTR::TestController::platformCreateOtherPage):
2579         (WTR::TestController::platformInitializeConfiguration):
2580         Implement the new platform functions for the Modern WebKit2 API,
2581         in a new TestControllerCocoa file that is shared between iOS and Mac.
2582         
2583         For platformMaybeCreateContext, use the trick that we know we can cast
2584         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
2585         WKWebView's configuration.
2586
2587         Ditto for WKPreferencesRef and WKPreferences.
2588
2589         Remove user content filters on the WKWebView's userContentController.
2590
2591         * WebKitTestRunner/mac/TestControllerMac.mm:
2592         * WebKitTestRunner/ios/TestControllerIOS.mm:
2593         Move code into TestControllerCocoa.
2594
2595         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2596         (WTR::InjectedBundle::beginTesting):
2597         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2598         (WTR::TestRunner::addUserScript):
2599         (WTR::TestRunner::addUserStyleSheet):
2600         Adopt WKBundlePage API for user scripts/sheets.
2601
2602         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2603         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2604         Make and keep a WKWebView instead of a WKView.
2605         
2606         * WebKitTestRunner/mac/EventSenderProxy.mm:
2607         (WTR::EventSenderProxy::mouseUp):
2608         (WTR::EventSenderProxy::mouseMoveTo):
2609         Reach inside the WKWebView to the WKView when dispatching events.
2610         This is fairly ugly and we should come up with a better solution.
2611         Also, fix some flipping and style errors.
2612
2613 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2614
2615         Unreviewed, attempt to fix GTK build after r188718
2616
2617         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2618         (WTR::PlatformWebView::PlatformWebView):
2619
2620 2015-08-21  Commit Queue  <commit-queue@webkit.org>
2621
2622         Unreviewed, rolling out r188807, r188813, and r188815.
2623         https://bugs.webkit.org/show_bug.cgi?id=148349
2624
2625         lots of 32-bit build problems, better to resolve separately
2626         and try again (Requested by thorton on #webkit).
2627
2628         Reverted changesets:
2629
2630         "WebKitTestRunner should use WKWebView on OS X and iOS"
2631         https://bugs.webkit.org/show_bug.cgi?id=143743
2632         http://trac.webkit.org/changeset/188807
2633
2634         "Stop building WebKitTestRunner for 32-bit platforms"
2635         https://bugs.webkit.org/show_bug.cgi?id=143743
2636         http://trac.webkit.org/changeset/188813
2637
2638         "Stop building WebKitTestRunner for 32-bit platforms"
2639         https://bugs.webkit.org/show_bug.cgi?id=143743
2640         http://trac.webkit.org/changeset/188815
2641
2642 2015-08-21  Tim Horton  <timothy_horton@apple.com>
2643
2644         Stop building WebKitTestRunner for 32-bit platforms
2645         https://bugs.webkit.org/show_bug.cgi?id=143743
2646         <rdar://problem/16947123>
2647
2648         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2649         This is a restriction on the valid set, not the desired set.
2650
2651 2015-08-21  Jason Marcell  <jmarcell@apple.com>
2652
2653         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
2654         to work with these new objects.
2655         https://bugs.webkit.org/show_bug.cgi?id=148188
2656
2657         Reviewed by Daniel Bates.
2658
2659         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2660         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2661         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2662         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
2663         (repository, "branch name")-pair.
2664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
2665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2666         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2667         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2668         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
2669         objects which represent a (repository, "branch name")-pair.
2670         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2671         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2672         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
2673         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
2674         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
2675         BuildbotQueue.branch to BuildbotQueue.branches.
2676         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2677         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
2678
2679 2015-08-21  Tim Horton  <timothy_horton@apple.com>
2680
2681         Stop building WebKitTestRunner for 32-bit platforms
2682         https://bugs.webkit.org/show_bug.cgi?id=143743
2683         <rdar://problem/16947123>
2684
2685         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2686         WKWebView is not available on 32-bit OS X.
2687
2688 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
2689
2690         [Win] Unreviewed test correction after r188709.
2691
2692         I removed a function argument that happened to be mirrored by a global
2693         value with the same name. This prevented a compile error, but testing
2694         showed that the wrong value was being used in the function.
2695
2696         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2697         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
2698         back
2699
2700 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
2701
2702         WebKitTestRunner should use WKWebView on OS X and iOS
2703         https://bugs.webkit.org/show_bug.cgi?id=143743
2704         <rdar://problem/16947123>
2705
2706         Reviewed by Anders Carlsson.
2707         Patch by Enrica Casucci and myself.
2708
2709         * WebKitTestRunner/PlatformWebView.h:
2710         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
2711         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
2712         instead of WKContext and WKPageGroup.
2713
2714         Remove the unused, always-true windowSnapshotEnabled().
2715         While technically some platforms don't have window snapshotting,
2716         they just return null instead of implementing windowSnapshotEnabled().
2717
2718         * WebKitTestRunner/TestController.h:
2719         * WebKitTestRunner/TestController.cpp:
2720         (WTR::TestController::createOtherPage):
2721         (WTR::TestController::initialize):
2722         (WTR::TestController::createWebViewWithOptions):
2723         Delegate to the various platforms for creating PlatformWebView instances,
2724         for creating WKContexts, and for accessing WKPreferences,
2725         so that they can do special things (like, use WKWebView instead!).
2726
2727         (WTR::TestController::resetPreferencesToConsistentValues):
2728         Make explicit WebKitTestRunner's desired default for two preferences
2729         which have differing defaults between the antique and modern API,
2730         for consistency's sake.
2731
2732         (WTR::TestController::resetStateToConsistentValues):
2733         Add platformResetStateToConsistentValues.
2734
2735         * WebKitTestRunner/TestInvocation.cpp:
2736         (WTR::TestInvocation::dumpResults):
2737         Adjust to the aforementioned removal of windowSnapshotEnabled().
2738
2739         * WebKitTestRunner/ios/TestControllerCocoa.mm:
2740         (WTR::TestController::platformResetStateToConsistentValues):
2741         (WTR::TestController::platformPreferences):
2742         (WTR::TestController::platformCreateWebView):
2743         (WTR::TestController::platformCreateOtherPage):
2744         (WTR::TestController::platformInitializeConfiguration):
2745         Implement the new platform functions for the Modern WebKit2 API,
2746         in a new TestControllerCocoa file that is shared between iOS and Mac.
2747         
2748         For platformMaybeCreateContext, use the trick that we know we can cast
2749         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
2750         WKWebView's configuration.
2751
2752         Ditto for WKPreferencesRef and WKPreferences.
2753
2754         Remove user content filters on the WKWebView's userContentController.
2755
2756         * WebKitTestRunner/mac/TestControllerMac.mm:
2757         * WebKitTestRunner/ios/TestControllerIOS.mm:
2758         Move code into TestControllerCocoa.
2759
2760         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2761         (WTR::InjectedBundle::beginTesting):
2762         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2763         (WTR::TestRunner::addUserScript):
2764         (WTR::TestRunner::addUserStyleSheet):
2765         Adopt WKBundlePage API for user scripts/sheets.
2766
2767         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2768         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2769         Make and keep a WKWebView instead of a WKView.
2770         
2771         * WebKitTestRunner/mac/EventSenderProxy.mm:
2772         (WTR::EventSenderProxy::mouseUp):
2773         (WTR::EventSenderProxy::mouseMoveTo):
2774         Reach inside the WKWebView to the WKView when dispatching events.
2775         This is fairly ugly and we should come up with a better solution.
2776         Also, fix some flipping and style errors.
2777
2778 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
2779
2780         Improve how UI events are dispatched by WebKitTestRunner
2781         https://bugs.webkit.org/show_bug.cgi?id=148326
2782
2783         Reviewed by Anders Carlsson.
2784
2785         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2786         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2787         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
2788         asynchronous (and really, it has always been for the most part).
2789
2790         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2791         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
2792         (WTR::EventSendingController::mouseUp): Ditto.
2793         (WTR::EventSendingController::mouseMoveTo): Ditto.
2794         (WTR::EventSendingController::mouseForceDown): Ditto.
2795         (WTR::EventSendingController::mouseForceUp): Ditto.
2796         (WTR::EventSendingController::mouseForceChanged): Ditto.
2797         (WTR::EventSendingController::leapForward): Ditto.
2798         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
2799         (WTR::EventSendingController::keyDown): Ditto.
2800         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
2801         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
2802         to be done in custom WebKit2 code for test wheel event handling.
2803         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
2804         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
2805         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
2806         (WTR::EventSendingController::addTouchPoint): Ditto.
2807         (WTR::EventSendingController::updateTouchPoint): Ditto.
2808         (WTR::EventSendingController::setTouchModifier): Ditto.
2809         (WTR::EventSendingController::setTouchPointRadius): Ditto.
2810         (WTR::EventSendingController::touchStart): Ditto.
2811         (WTR::EventSendingController::touchMove): Ditto.
2812         (WTR::EventSendingController::touchEnd): Ditto.
2813         (WTR::EventSendingController::touchCancel): Ditto.
2814         (WTR::EventSendingController::clearTouchPoints): Ditto.
2815         (WTR::EventSendingController::releaseTouchPoint): Ditto.
2816         (WTR::EventSendingController::cancelTouchPoint): Ditto.
2817
2818         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2819         (WTR::InjectedBundle::postSetWindowIsKey):
2820         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2821         (WTR::InjectedBundle::isGeolocationProviderActive):
2822         (WTR::InjectedBundle::shouldProcessWorkQueue):
2823         Updated for WKBundlePagePostSynchronousMessage renaming.
2824
2825         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2826         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
2827
2828         * WebKitTestRunner/TestController.cpp:
2829         (WTR::TestController::initialize): Allow handling the new test style messages.
2830         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
2831         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
2832         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2833         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
2834         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
2835
2836         * WebKitTestRunner/mac/EventSenderProxy.mm:
2837         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
2838         (WTR::EventSenderProxy::keyDown): Ditto.
2839         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
2840         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2841
2842 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2843
2844         Skip no-llint tests that fail due to running out of executable memory after r188969
2845         https://bugs.webkit.org/show_bug.cgi?id=148273
2846
2847         Reviewed by Michael Saboff.
2848
2849         * Scripts/run-jsc-stress-tests:
2850
2851 2015-08-21  Nan Wang  <n_wang@apple.com>
2852
2853         [Mac] accessibility/selection-states.html fails
2854         https://bugs.webkit.org/show_bug.cgi?id=116637
2855
2856         Reviewed by Chris Fleizach.
2857
2858         Implemented isSelectable() and isMultiSelectable().
2859
2860         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2861         (AccessibilityUIElement::isSelectable):
2862         (AccessibilityUIElement::isMultiSelectable):
2863         (AccessibilityUIElement::isSelectedOptionActive):
2864         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2865         (WTR::AccessibilityUIElement::isSelectable):
2866         (WTR::AccessibilityUIElement::isMultiSelectable):
2867         (WTR::AccessibilityUIElement::isVisible):
2868
2869 2015-08-21  Jason Marcell  <jmarcell@apple.com>
2870
2871         Fix iteration over repositories on bot watcher's dashboard.
2872
2873         Reviewed by Alexey Proskuryakov.
2874
2875         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2876         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
2877
2878 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
2879
2880         [EFL] Revise PlatformWebView ctor according to r188718
2881         https://bugs.webkit.org/show_bug.cgi?id=148282
2882
2883         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
2884         instead of WKContextRef and WKPageGroupRef respectively.
2885
2886         Reviewed by Gyuyoung Kim.
2887
2888         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2889         (WTR::PlatformWebView::PlatformWebView):
2890
2891 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
2892
2893         Unreviewed, changed Devin Rousso's email.
2894
2895         * Scripts/webkitpy/common/config/contributors.json:
2896
2897 2015-08-20  Anders Carlsson  <andersca@apple.com>
2898
2899         Use WKPageConfigurationRef in WebKitTestRunner
2900         https://bugs.webkit.org/show_bug.cgi?id=147996
2901
2902         Reviewed by Tim Horton.
2903
2904         * WebKitTestRunner/TestController.cpp:
2905         (WTR::TestController::createOtherPage):
2906         (WTR::TestController::initialize):
2907         (WTR::TestController::createWebViewWithOptions):
2908         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2909         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
2910         (WTR::PlatformWebView::PlatformWebView):
2911         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
2912
2913 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
2914
2915         [Win] Update Windows tools for revised MIDL interfaces
2916         https://bugs.webkit.org/show_bug.cgi?id=148249
2917
2918         Reviewed by Dean Jackson.
2919
2920         This is a follow-up to Bug 148001.
2921
2922         Revise the testing software to use compatible signatures and
2923         implementations to match the requirements of the IDL generated
2924         with the SAL annotations.
2925
2926         * DumpRenderTree/win/DRTDataObject.cpp:
2927         * DumpRenderTree/win/DRTDataObject.h:
2928         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2929         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2930         * DumpRenderTree/win/DRTDropSource.cpp:
2931         * DumpRenderTree/win/DRTDropSource.h:
2932         * DumpRenderTree/win/DumpRenderTree.cpp:
2933         * DumpRenderTree/win/EditingDelegate.cpp:
2934         * DumpRenderTree/win/EditingDelegate.h:
2935         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2936         * DumpRenderTree/win/FrameLoadDelegate.h:
2937         * DumpRenderTree/win/HistoryDelegate.cpp:
2938         * DumpRenderTree/win/HistoryDelegate.h:
2939         * DumpRenderTree/win/PolicyDelegate.cpp:
2940         * DumpRenderTree/win/PolicyDelegate.h:
2941         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2942         * DumpRenderTree/win/ResourceLoadDelegate.h:
2943         * DumpRenderTree/win/TestRunnerWin.cpp:
2944         * DumpRenderTree/win/UIDelegate.cpp:
2945         * DumpRenderTree/win/UIDelegate.h:
2946         * WinLauncher/AccessibilityDelegate.cpp:
2947         * WinLauncher/AccessibilityDelegate.h:
2948         * WinLauncher/Common.cpp:
2949         * WinLauncher/DOMDefaultImpl.cpp:
2950         * WinLauncher/DOMDefaultImpl.h:
2951         * WinLauncher/PageLoadTestClient.cpp:
2952         * WinLauncher/PageLoadTestClient.h:
2953         * WinLauncher/PrintWebUIDelegate.cpp:
2954         * WinLauncher/PrintWebUIDelegate.h:
2955         * WinLauncher/ResourceLoadDelegate.cpp:
2956         * WinLauncher/ResourceLoadDelegate.h:
2957         * WinLauncher/WebDownloadDelegate.cpp:
2958         * WinLauncher/WebDownloadDelegate.h:
2959         * WinLauncher/WinLauncherWebHost.cpp:
2960         * WinLauncher/WinLauncherWebHost.h:
2961         * WinLauncher/WinMain.cpp:
2962         * win/DLLLauncher/DLLLauncherMain.cpp:
2963
2964 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
2965
2966         Unreviewed, shorten a test that runs too long and times out.
2967
2968         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2969         (TestWebKitAPI::TEST):
2970
2971 2015-08-20  Alex Christensen  <achristensen@webkit.org>
2972
2973         Clean up CMake build after r188673
2974         https://bugs.webkit.org/show_bug.cgi?id=148234
2975
2976         Reviewed by Tim Horton.
2977
2978         * DumpRenderTree/PlatformWin.cmake:
2979         * TestWebKitAPI/CMakeLists.txt:
2980         * TestWebKitAPI/PlatformWin.cmake:
2981         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
2982         gtest needs to be a static library on Windows to not crash.
2983
2984 2015-08-19  Alex Christensen  <achristensen@webkit.org>
2985
2986         CMake Windows build should not include files directly from other Source directories
2987         https://bugs.webkit.org/show_bug.cgi?id=148198
2988
2989         Reviewed by Brent Fulgham.
2990
2991         * DumpRenderTree/DumpRenderTreePrefix.h:
2992         Include cmakeconfig.h to properly define all enabled features.
2993         * DumpRenderTree/PlatformWin.cmake:
2994         * TestWebKitAPI/PlatformWin.cmake:
2995
2996 2015-08-19  Alex Christensen  <achristensen@webkit.org>
2997
2998         Build TestWTF on Mac with CMake.
2999         https://bugs.webkit.org/show_bug.cgi?id=147972
3000
3001         Reviewed by Tim Horton.
3002
3003         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
3004         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
3005
3006         * TestWebKitAPI/CMakeLists.txt:
3007         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
3008         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
3009         * TestWebKitAPI/PlatformMac.cmake: Added.
3010         * TestWebKitAPI/config.h:
3011         Postpone some build fixes until WebKit builds completely on Mac with CMake.
3012
3013 2015-08-19  Brian Burg  <bburg@apple.com>
3014
3015         Unreviewed, add Aleksandr Skachkov to the list of contributors.
3016
3017         * Scripts/webkitpy/common/config/contributors.json:
3018
3019 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3020
3021         REGRESSION(r188548): [GTK] Build broken.
3022         https://bugs.webkit.org/show_bug.cgi?id=148154
3023
3024         Reviewed by Martin Robinson.
3025
3026         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3027         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3028         Even if we don't need to add/override any settings in ViewOptions,
3029         we need to define this as an empty function to make it build.
3030
3031 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3032
3033         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
3034         https://bugs.webkit.org/show_bug.cgi?id=148073
3035
3036         Reviewed by Alexey Proskuryakov.
3037
3038         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
3039         (TestWebKitAPI::TEST):
3040
3041 2015-08-18  Anders Carlsson  <andersca@apple.com>
3042
3043         Fix test failure fallout from r188602 by using a V5 page ui client struct.
3044
3045         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3046         (TestWebKitAPI::setUpClients):
3047
3048 2015-08-18  Brian Burg  <bburg@apple.com>
3049
3050         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
3051         https://bugs.webkit.org/show_bug.cgi?id=147955
3052
3053         Reviewed by Timothy Hatcher.
3054
3055         To enable sharing of common test code between protocol and model tests,
3056         start loading the protocol TestStub.js through the WebInspectorUI bundle.
3057
3058         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
3059         protocol-test.js uses to load the inspector frontend stub into its iframe
3060         from an arbitrary local file URL.
3061
3062         * DumpRenderTree/TestRunner.cpp:
3063         (getInspectorTestStubURLCallback):
3064         (TestRunner::staticValues):
3065         * DumpRenderTree/TestRunner.h:
3066         * DumpRenderTree/mac/TestRunnerMac.mm:
3067         (SOFT_LINK_STAGED_FRAMEWORK):
3068         (TestRunner::inspectorTestStubURL):
3069         * DumpRenderTree/win/TestRunnerWin.cpp:
3070         (TestRunner::inspectorTestStubURL):
3071         * WebKitTestRunner/Configurations/Base.xcconfig:
3072         Since WebKitTestRunner now includes WebCore private headers, also search
3073         for the WebCore framework inside the WebKit umbrella framework.
3074
3075         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3076         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3077         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3078         (WTR::TestRunner::inspectorTestStubURL):
3079         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3080         (WTR::TestRunner::inspectorTestStubURL):
3081         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3082         (WTR::TestRunner::inspectorTestStubURL):
3083
3084 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
3085
3086         Unreviewed, fix GTK build.
3087
3088         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3089         (TestWebKitAPI::TEST):
3090
3091 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
3092
3093         Replace all remaining uses of WTF::Mutex with WTF::Lock
3094         https://bugs.webkit.org/show_bug.cgi?id=148089
3095
3096         Reviewed by Geoffrey Garen.
3097
3098         * DumpRenderTree/JavaScriptThreading.cpp:
3099         (javaScriptThreadsMutex):
3100         (runJavaScriptThread):
3101         (startJavaScriptThreads):
3102         (stopJavaScriptThreads):
3103         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
3104         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3105         (TestWebKitAPI::TEST):
3106         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3107         (TestWebKitAPI::TEST):
3108
3109 2015-08-17  Commit Queue  <commit-queue@webkit.org>
3110
3111         Unreviewed, rolling out r188539, r188544, r188552, and
3112         r188564.
3113         https://bugs.webkit.org/show_bug.cgi?id=148122
3114
3115         Broke tests and some build styles (Requested by ap on
3116         #webkit).
3117
3118         Reverted changesets:
3119
3120         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
3121         bundle"
3122         https://bugs.webkit.org/show_bug.cgi?id=147955
3123         http://trac.webkit.org/changeset/188539
3124
3125         "Web Inspector: split TestStub.js into multiple files and
3126         modernize it"
3127         https://bugs.webkit.org/show_bug.cgi?id=148077
3128         http://trac.webkit.org/changeset/188544
3129
3130         "Web Inspector: InspectorTest should be a subclass of
3131         TestHarness"
3132         https://bugs.webkit.org/show_bug.cgi?id=148079
3133         http://trac.webkit.org/changeset/188552
3134
3135         "Unreviewed internal build fix attempt after r188539."
3136         http://trac.webkit.org/changeset/188564
3137
3138 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
3139
3140         [OS X] Remove support for composite fonts
3141         https://bugs.webkit.org/show_bug.cgi?id=147920
3142
3143         Reviewed by Dan Bernstein.
3144
3145         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3146         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
3147         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3148         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3149         * DumpRenderTree/mac/DumpRenderTree.mm:
3150         (allowedFontFamilySet): Deleted.
3151         (activateTestingFonts): Deleted.
3152         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3153         (WTR::allowedFontFamilySet): Deleted.
3154         (WTR::activateFonts): Deleted.
3155         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3156         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
3157         * WebKitTestRunner/mac/TestControllerMac.mm:
3158         (WTR::allowedFontFamilySet): Deleted.
3159
3160 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
3161
3162         Unreviewed internal build fix attempt after r188539.
3163
3164         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3165
3166 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
3167
3168         Fix the build
3169
3170         Unreviewed.
3171
3172         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3173
3174 2015-08-17  Alex Christensen  <achristensen@webkit.org>
3175
3176         Build Debug Suffix on Windows with CMake
3177         https://bugs.webkit.org/show_bug.cgi?id=148083
3178
3179         Reviewed by Brent Fulgham.
3180
3181         * TestWebKitAPI/CMakeLists.txt:
3182         * TestWebKitAPI/PlatformWin.cmake:
3183         Add DEBUG_SUFFIX
3184
3185 2015-08-17  Anders Carlsson  <andersca@apple.com>
3186
3187         Simplify how PlatformWebViews are created when view options change
3188         https://bugs.webkit.org/show_bug.cgi?id=148093
3189
3190         Reviewed by Sam Weinig.
3191
3192         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
3193
3194         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
3195         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
3196         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
3197
3198         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
3199
3200         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
3201         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
3202
3203         * WebKitTestRunner/TestController.cpp:
3204         (WTR::TestController::ensureViewSupportsOptionsForTest):
3205         (WTR::shouldUseFixedLayout):
3206         (WTR::TestController::viewOptionsForTest):
3207         (WTR::TestController::updateWebViewSizeForTest):
3208         (WTR::TestController::updateWindowScaleForTest):
3209         (WTR::TestController::configureViewForTest):
3210         (WTR::TestController::initialize): Deleted.
3211         (WTR::TestController::ensureViewSupportsOptions): Deleted.
3212         (WTR::TestController::updateLayoutTypeForTest): Deleted.
3213         (WTR::TestController::platformConfigureViewForTest): Deleted.
3214         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
3215         (WTR::TestController::run): Deleted.
3216         * WebKitTestRunner/TestController.h:
3217         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3218         (WTR::shouldUseFixedLayout):
3219         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3220         (WTR::TestController::platformConfigureViewForTest):
3221         (WTR::TestController::platformResetPreferencesToConsistentValues):
3222         * WebKitTestRunner/ios/TestControllerIOS.mm:
3223         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3224         * WebKitTestRunner/mac/TestControllerMac.mm:
3225         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3226         (WTR::TestController::platformConfigureViewForTest):
3227
3228 2015-08-17  Sam Weinig  <sam@webkit.org>
3229
3230         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
3231         https://bugs.webkit.org/show_bug.cgi?id=148097
3232
3233         Reviewed by Anders Carlsson.
3234
3235         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
3236         Add tests for WebsiteDataStores in the WKPageConfiguration.
3237
3238 2015-08-17  Brian Burg  <bburg@apple.com>
3239
3240         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
3241         https://bugs.webkit.org/show_bug.cgi?id=147955
3242
3243         Reviewed by Timothy Hatcher.
3244
3245         To enable sharing of common test code between protocol and model tests,
3246         start loading the protocol TestStub.js through the WebInspectorUI bundle.
3247
3248         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
3249         protocol-test.js uses to load the inspector frontend stub into its iframe
3250         from an arbitrary local file URL.
3251
3252         * DumpRenderTree/TestRunner.cpp:
3253         (getInspectorTestStubURLCallback):
3254         (TestRunner::staticValues):
3255         * DumpRenderTree/TestRunner.h:
3256         * DumpRenderTree/mac/TestRunnerMac.mm:
3257         (SOFT_LINK_STAGED_FRAMEWORK):
3258         (TestRunner::inspectorTestStubURL):
3259         * DumpRenderTree/win/TestRunnerWin.cpp:
3260         (TestRunner::inspectorTestStubURL):
3261         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3262         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3263         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3264         (WTR::TestRunner::inspectorTestStubURL):
3265         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3266         (WTR::TestRunner::inspectorTestStubURL):
3267         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3268         (WTR::TestRunner::inspectorTestStubURL):
3269
3270 2015-08-17  Saam barati  <sbarati@apple.com>
3271
3272         Change email address from saambarati1@gmail.com to sbarati@apple.com
3273
3274         * Scripts/webkitpy/common/config/contributors.json:
3275
3276 2015-08-17  Jason Marcell  <jmarcell@apple.com>
3277
3278         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
3279         repositories other than "openSource" and "internal".
3280         https://bugs.webkit.org/show_bug.cgi?id=147961
3281
3282         Reviewed by Daniel Bates.
3283
3284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3285         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
3286         generically with repositories other than "openSource" and "internal".
3287
3288 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
3289
3290         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
3291         https://bugs.webkit.org/show_bug.cgi?id=148081
3292
3293         Reviewed by Tim Horton.
3294
3295         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3296         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3297
3298 2015-08-11  Andy Estes  <aestes@apple.com>
3299
3300         [Cocoa] Add redirect support to CustomProtocolManager
3301         https://bugs.webkit.org/show_bug.cgi?id=147871
3302
3303         Reviewed by Dan Bernstein.
3304
3305         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
3306
3307         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3308         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
3309         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
3310         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3311         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
3312         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
3313         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
3314         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
3315         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
3316         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3317         (TestWebKitAPI::TEST): Unregistered TestProtocol.
3318         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
3319         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
3320         (-[TestProtocol startLoading]): Taught to handle redirect responses.
3321
3322 2015-08-13  Andy Estes  <aestes@apple.com>
3323
3324         [Cocoa] Downloads do not start if policy decision is made asynchronously
3325         https://bugs.webkit.org/show_bug.cgi?id=147985
3326
3327         Reviewed by Brady Eidson.
3328
3329         Added a new API test.
3330
3331         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3332         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3333         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
3334         (TEST):
3335
3336 2015-08-14  Commit Queue  <commit-queue@webkit.org>
3337
3338         Unreviewed, rolling out r187357.
3339         https://bugs.webkit.org/show_bug.cgi?id=148032
3340
3341         webkit-patch generates incorrect patches that cannot be
3342         applied (Requested by dydz on #webkit).
3343
3344         Reverted changeset:
3345
3346         "Call fixChangeLogPatch when generating patches from webkit-
3347         patch"
3348         https://bugs.webkit.org/show_bug.cgi?id=147248
3349         http://trac.webkit.org/changeset/187357
3350
3351 2015-08-14  Jason Marcell  <jmarcell@apple.com>
3352
3353         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
3354         other than "openSource" and "internal".
3355         https://bugs.webkit.org/show_bug.cgi?id=147938
3356
3357         Reviewed by Daniel Bates.
3358
3359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3360         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
3361         repositories other than "openSource" and "internal".
3362
3363 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
3364
3365         Unreviewed, shorten another test that is timing out.
3366
3367         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3368         (TestWebKitAPI::TEST):
3369
3370 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
3371
3372         AppScale: Assertion hit when hovering a webkit-queue bubble
3373         https://bugs.webkit.org/show_bug.cgi?id=147997
3374
3375         Reviewed by Alexey Proskuryakov.
3376
3377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
3378         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
3379
3380 2015-08-13  Lucas Forschler  <lforschler@apple.com>
3381
3382         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
3383         
3384         Unreviewed.
3385         
3386         * Scripts/copy-webkitlibraries-to-product-directory:
3387
3388 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
3389
3390         Run benchmark customized Dromaeo should not assume there is an internet connection.
3391         https://bugs.webkit.org/show_bug.cgi?id=147995
3392
3393         Reviewed by Ryosuke Niwa.
3394
3395         Add several dependency js libs to local.
3396
3397         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
3398
3399 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
3400
3401         WTF should have a compact Condition object to use with Lock
3402         https://bugs.webkit.org/show_bug.cgi?id=147986
3403
3404         Reviewed by Geoffrey Garen.
3405
3406         Add a test for WTF::Condition.
3407
3408         * TestWebKitAPI/CMakeLists.txt:
3409         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3411         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
3412         (TestWebKitAPI::TEST):
3413         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3414         (TestWebKitAPI::runLockTest): Change the name of the thread.
3415
3416 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
3417
3418         Unreviewed, shorten another test. It's timing out in debug on some bot.
3419
3420         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3421         (TestWebKitAPI::TEST):
3422
3423 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
3424
3425         WTF::Lock should not suffer from the thundering herd
3426         https://bugs.webkit.org/show_bug.cgi?id=147947
3427
3428         Reviewed by Geoffrey Garen.
3429
3430         Add testing that checks that locks return to a pristine state after contention is over.
3431
3432         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3433         (TestWebKitAPI::LockInspector::isFullyReset):
3434         (TestWebKitAPI::runLockTest):
3435         (TestWebKitAPI::TEST):
3436
3437 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
3438
3439         Benchmarks supported by run_benchmark script should not assume we have internet access.
3440         https://bugs.webkit.org/show_bug.cgi?id=147959
3441
3442         Reviewed by Ryosuke Niwa.
3443
3444         For JSBench we should not request jquery.min.js from google through the internet.
3445
3446         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
3447
3448 2015-08-12  Jason Marcell  <jmarcell@apple.com>
3449
3450         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
3451         other than "openSource" and "internal".
3452         https://bugs.webkit.org/show_bug.cgi?id=147796
3453
3454         Reviewed by Daniel Bates.
3455
3456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3457         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
3458         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
3459         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
3460         and another assertion that, if the previousIteration is non-null, the given repository is in
3461         previousIteration.revision.
3462         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
3463         with repositories other than "openSource" and "internal". Also added an assertion that the returned
3464         fragment has at least one child node.
3465
3466 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
3467
3468         Add a tool that dumps class and struct member layout, showing padding
3469         https://bugs.webkit.org/show_bug.cgi?id=147898
3470
3471         Reviewed by Zalan Bujtas.
3472         
3473         This 'dump-class-layout' script uses the lldb Python bindings to collect data
3474         about data member layout, and displays it.
3475         
3476         Sample output:
3477
3478               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
3479               +0 < 56>     WebCore::URL m_value;
3480               +0 <  8>         WTF::String m_string;
3481               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
3482               +0 <  8>                 WTF::StringImpl * m_ptr;
3483               +8 <  1>         bool:1 m_isValid;
3484               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
3485               +9 <  3>         <PADDING>
3486              +12 <  4>         int m_schemeEnd;
3487              +16 <  4>         int m_userStart;
3488              +20 <  4>         int m_userEnd;
3489              +24 <  4>         int m_passwordEnd;
3490              +28 <  4>         int m_hostEnd;
3491              +32 <  4>         int m_portEnd;
3492              +36 <  4>         int m_pathAfterLastSlash;
3493              +40 <  4>         int m_pathEnd;
3494              +44 <  4>         int m_queryEnd;
3495              +48 <  4>         int m_fragmentEnd;
3496              +52 <  4>         <PADDING>
3497              +52 <  4>     <PADDING>
3498              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
3499              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
3500             Total byte size: 72
3501             Total pad bytes: 11
3502             Padding percentage: 15.28 %
3503
3504         * Scripts/dump-class-layout: Added.
3505         (webkit_build_dir):
3506         (developer_dir):
3507         (import_lldb):
3508         (find_build_directory):
3509         (verify_type):
3510         (verify_type_recursive):
3511         (dump_class):
3512         (main):
3513         (main.or):
3514
3515 2015-08-12  Alex Christensen  <achristensen@webkit.org>
3516
3517         Fix Debug CMake builds on Windows
3518         https://bugs.webkit.org/show_bug.cgi?id=147940
3519
3520         Reviewed by Chris Dumez.
3521
3522         * DumpRenderTree/PlatformWin.cmake:
3523         * TestWebKitAPI/PlatformWin.cmake:
3524         The BitmapImage test is not enabled on the AppleWin port.
3525         * WinLauncher/CMakeLists.txt:
3526         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
3527
3528 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3529
3530         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
3531
3532         In r188125 I added a way to mark tests as slow to use a longer
3533         timeout. But it seems it was not enough for
3534         WTF_Lock.ContendedShortSection, so let's try again with a longer
3535         timeout now.
3536
3537         * Scripts/run-gtk-tests:
3538         (TestRunner._run_google_test):
3539
3540 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
3541
3542         Allow --debug option in run-jsc
3543         https://bugs.webkit.org/show_bug.cgi?id=147923
3544
3545         Reviewed by Csaba Osztrogonác.
3546
3547         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
3548
3549         * Scripts/run-jsc:
3550
3551 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3552
3553         Fix test after build fix in r188286.
3554         https://bugs.webkit.org/show_bug.cgi?id=147907
3555
3556         Reviewed by Anders Carlsson.
3557
3558         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3559         sleep_for can now be used, but we need to include <thread>
3560
3561 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3562
3563         Always use a byte-sized lock implementation
3564         https://bugs.webkit.org/show_bug.cgi?id=147908
3565
3566         Reviewed by Geoffrey Garen.
3567
3568         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
3569         now tests of Lock.
3570
3571         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3572         (TestWebKitAPI::runLockTest):
3573         (TestWebKitAPI::TEST):
3574
3575 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
3576
3577         Make ASan build not depend on asan.xcconfig
3578         https://bugs.webkit.org/show_bug.cgi?id=147840
3579         rdar://problem/21093702
3580
3581         Reviewed by Daniel Bates.
3582
3583         * asan/asan.xcconfig:
3584         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
3585         are now marked in source code.
3586
3587 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3588
3589         Unreviewed, shorten another test since it timed out.
3590
3591         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3592         (TestWebKitAPI::TEST):
3593
3594 2015-08-11  Mark Lam  <mark.lam@apple.com>
3595
3596         Fix names of Lock tests: should be "Contended", not "Contented".
3597         https://bugs.webkit.org/show_bug.cgi?id=147905
3598
3599         Reviewed by Saam Barati.
3600
3601         We're testing the behavior of lock contention (i.e. when threads contend), not
3602         whether the locks are happy (contented).
3603
3604         * Scripts/run-gtk-tests:
3605         (TestRunner):
3606         (TestRunner.__init__): Deleted.
3607         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3608         (TestWebKitAPI::runLockTest):
3609         (TestWebKitAPI::TEST):
3610
3611 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3612
3613         Update WinCairoRequirements to VS2015.
3614
3615         * Scripts/update-webkit-wincairo-libs:
3616         Update WinCairoRequirements location.
3617
3618 2015-08-11  Jason Marcell  <jmarcell@apple.com>
3619
3620         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
3621         for internalTrac.
3622         https://bugs.webkit.org/show_bug.cgi?id=147805
3623
3624         Reviewed by Daniel Bates.
3625
3626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3627         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
3628         Dashboard.Repository.Internal.trac for internalTrac.
3629         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
3630         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
3631         respectively.
3632         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3633         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
3634         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
3635         internalTrac.
3636         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
3637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
3638         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3639         (Analyzer): Ditto.
3640         (Analyzer.prototype.analyze): Ditto.
3641
3642 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3643
3644         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
3645
3646         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3647         (TestWebKitAPI::TEST):
3648
3649 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
3650
3651         [Win] Switch Windows build to Visual Studio 2015
3652         https://bugs.webkit.org/show_bug.cgi?id=147887
3653         <rdar://problem/22235098>
3654
3655         Reviewed by Alex Christensen.
3656
3657         Update Visual Studio project file settings to use the current Visual
3658         Studio and compiler. Continue targeting binaries to run on our minimum
3659         supported configuration of Windows 7.
3660
3661         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3662         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3663         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3664         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3665         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3666         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
3667         prefer the newer MSBuild included in Visual Studio 2015.
3668         (visualStudioInstallDir):
3669         (msBuildInstallDir):
3670         (visualStudioVersion):
3671         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3672         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3673         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3674         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3675         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3676         * win/record-memory/record-memory.vcxproj:
3677
3678 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3679
3680         Another speculative build fix after r188280.
3681
3682         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3683         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
3684         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
3685
3686 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3687
3688         Unreviewed build fix after r188280.
3689
3690         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3691         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
3692
3693 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
3694
3695         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
3696         https://bugs.webkit.org/show_bug.cgi?id=147665
3697
3698         Reviewed by Mark Lam.
3699
3700         * TestWebKitAPI/CMakeLists.txt:
3701         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3703         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3704         (TestWebKitAPI::TEST):
3705         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
3706         (TestWebKitAPI::TEST):
3707
3708 2015-08-11  Brian Burg  <bburg@apple.com>
3709
3710         webkit-patch should not explode when $EDITOR is set incorrectly
3711         https://bugs.webkit.org/show_bug.cgi?id=147884
3712
3713         Reviewed by Darin Adler.
3714
3715         If $EDITOR doesn't exist, log a warning and continue.
3716
3717         * Scripts/webkitpy/common/system/user.py: 
3718         (User.edit):
3719         (User.edit_changelog):
3720
3721 2015-08-11  Dan Bernstein  <mitz@apple.com>
3722
3723         Reverted r188255, because it turned out that delegates do nonot need this information.
3724
3725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3726         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
3727
3728 2015-08-11  Dan Bernstein  <mitz@apple.com>
3729
3730         [Cocoa] The UI delegate can't tell if printing was user-initiated
3731         https://bugs.webkit.org/show_bug.cgi?id=147869
3732
3733         Reviewed by Sam Weinig.
3734
3735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3736         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
3737         (-[PrintFrameController webView:didFinishNavigation:]):
3738         (-[PrintFrameController _webView:printFrame:userInitiated:]):
3739         (TEST):
3740
3741 2015-08-10  Alex Christensen  <achristensen@webkit.org>
3742
3743         Another build fix after r188239.
3744
3745         * TestWebKitAPI/PlatformWin.cmake:
3746         Link with more libraries.
3747         * WinLauncher/CMakeLists.txt:
3748         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
3749
3750 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
3751
3752         Build fix after r188237.
3753
3754         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3755         (BenchmarkBuilder.__enter__):
3756
3757 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
3758
3759         Update ReadMe and correct the way to use abstract abstract class.
3760         https://bugs.webkit.org/show_bug.cgi?id=147860
3761
3762         Reviewed by Ryosuke Niwa.
3763
3764         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
3765         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
3766
3767         * Scripts/webkitpy/benchmark_runner/README.md:
3768         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3769         (BrowserDriver):
3770         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3771         (OSXBrowserDriver.restore_env):
3772         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3773         (HTTPServerDriver):
3774         (HTTPServerDriver.set_device_id):
3775         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3776         (SimpleHTTPServerDriver.get_return_code):
3777         (SimpleHTTPServerDriver):
3778         (SimpleHTTPServerDriver.set_device_id):
3779
3780 2015-08-10  Alex Christensen  <achristensen@webkit.org>
3781
3782         Build TestWebKitAPI with CMake on Windows
3783         https://bugs.webkit.org/show_bug.cgi?id=147851
3784
3785         Reviewed by Chris Dumez.
3786
3787         * CMakeLists.txt:
3788         * TestWebKitAPI/CMakeLists.txt:
3789         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
3790         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
3791         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
3792         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
3793         * TestWebKitAPI/PlatformEfl.cmake:
3794         * TestWebKitAPI/PlatformGTK.cmake:
3795         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
3796         I did this without changing the directory structure of the existing EFL and GTK builds.
3797         * TestWebKitAPI/PlatformWin.cmake: Added.
3798         * TestWebKitAPI/win/main.cpp:
3799         (main):
3800         (dllLauncherEntryPoint):
3801         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
3802         * WinLauncher/CMakeLists.txt:
3803         AppleWin port needs /NODEFAULTLIB:MSVCRT.
3804
3805 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
3806
3807         Make cleanup more robust and minor code cleaning in run benchmark script.
3808         https://bugs.webkit.org/show_bug.cgi?id=147800
3809
3810         Reviewed by Ryosuke Niwa.
3811
3812         Use 'finnaly' block to make sure cleanup code is always executed.
3813
3814         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3815         (built_benchmark):
3816         (built_benchmark.__init__):
3817         (built_benchmark.__enter__):
3818         (built_benchmark.__exit__):
3819         (test_environment):
3820         (test_environment.__init__):
3821         (test_environment.__enter__):
3822         (test_environment.__exit__):
3823         (BenchmarkRunner.__init__):
3824         (BenchmarkRunner.execute):
3825         (BenchmarkRunner._dump):
3826         (BenchmarkRunner._wrap):
3827         (BenchmarkRunner): Deleted.
3828         (BenchmarkRunner._cleanup): Deleted.
3829         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3830         (BrowserDriver.close_browsers):
3831         (BrowserDriver):
3832         (BrowserDriver.restore_env):
3833         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3834         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
3835
3836 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3837
3838         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
3839         https://bugs.webkit.org/show_bug.cgi?id=146414
3840
3841         Reviewed by Darin Adler.
3842
3843         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3844         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
3845
3846 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3847
3848         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
3849         https://bugs.webkit.org/show_bug.cgi?id=147727
3850
3851         Reviewed by Sergio Villar Senin.
3852
3853         I think it was not this test in particular, but
3854         /webkit2/WebKitWebView/custom-charset that is affecting the
3855         others. This is because changing the encoding reloads the page,
3856         but we don't wait for the page to be reloaded, so when the test
3857         finishes and other test starts the web process is still reloading
3858         the page.
3859
3860         * Scripts/run-gtk-tests:
3861         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
3862         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3863         (testWebViewCustomCharset): Wait until page is reloaded after
3864         changing the charset.
3865
3866 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3867
3868         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
3869
3870         It's timing out in the bots. My guess is that there's no installer
3871         installed in the bots and gst_install_plugins_supported() returns
3872         false, so we don't even get a permission request because no
3873         installer will be launched.
3874
3875         * Scripts/run-gtk-tests:
3876         (TestRunner):
3877
3878 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3879
3880         [GTK] Another build fix after r188157.
3881
3882         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3883         (WTR::PlatformWebView::viewSupportsOptions):
3884         Name all the things correctly!
3885
3886 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3887
3888         [EFL, GTK] Build fix after r188176.
3889
3890         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3891         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
3892
3893 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3894
3895         [GTK] Speculative build fix after r188157.
3896
3897         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3898         (WTR::PlatformWebView::PlatformWebView):
3899         Update parameter list.
3900
3901 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3902
3903         Build more testing binaries with CMake on Windows
3904         https://bugs.webkit.org/show_bug.cgi?id=147799
3905
3906         Reviewed by Brent Fulgham.
3907
3908         * DumpRenderTree/CMakeLists.txt:
3909         Build TestNetscapePlugin.
3910         * DumpRenderTree/PlatformWin.cmake:
3911         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
3912         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
3913         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
3914         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
3915         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
3916         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
3917         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
3918         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
3919         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
3920
3921 2015-08-07  Jason Marcell  <jmarcell@apple.com>
3922
3923         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
3924         https://bugs.webkit.org/show_bug.cgi?id=147667
3925
3926         Reviewed by Daniel Bates.
3927
3928         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3929         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
3930         other than "openSource" and "internal".
3931         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
3932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3933         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
3934         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
3935         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3936         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
3937         (sortedPlatforms): Deleted.
3938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3939         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
3940         (sortedPlatforms): Deleted.
3941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3942         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
3943         and sorts them by this property returning the new sorted array.
3944
3945 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
3946
3947         Lightweight locks should be adaptive
3948         https://bugs.webkit.org/show_bug.cgi?id=147545
3949
3950         Reviewed by Geoffrey Garen.
3951
3952         * TestWebKitAPI/CMakeLists.txt:
3953         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3955         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
3956         (TestWebKitAPI::runLockTest):
3957         (TestWebKitAPI::TEST):
3958
3959 2015-08-07  Anders Carlsson  <andersca@apple.com>
3960
3961         Fix a tyop.
3962
3963         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3964         (WTR::PlatformWebView::viewSupportsOptions):
3965
3966 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
3967
3968         Update AppEngine app version numbers to the latest commit.
3969
3970         * QueueStatusServer/app.yaml:
3971         * TestResultServer/app.yaml:
3972
3973 2015-08-07  Anders Carlsson  <andersca@apple.com>
3974
3975         Simplify WKTR's view options
3976         https://bugs.webkit.org/show_bug.cgi?id=147791
3977
3978         Reviewed by Sam Weinig.
3979
3980         Instead of using a WKDictionaryRef, just use a struct for the options.
3981
3982         * WebKitTestRunner/PlatformWebView.h:
3983         (WTR::PlatformWebView::options):
3984         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3985         * WebKitTestRunner/TestController.cpp:
3986         (WTR::TestController::initialize):
3987         (WTR::TestController::createWebViewWithOptions):
3988         (WTR::TestController::ensureViewSupportsOptions):
3989         (WTR::TestController::updateLayoutTypeForTest):
3990         * WebKitTestRunner/TestController.h:
3991         * WebKitTestRunner/ViewOptions.h: Added.
3992         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3993         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3994         (WTR::PlatformWebView::PlatformWebView):
3995         (WTR::PlatformWebView::viewSupportsOptions):
3996         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3997         (WTR::PlatformWebView::viewSupportsOptions):
3998         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3999         (WTR::PlatformWebView::viewSupportsOptions):
4000         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4001         (WTR::PlatformWebView::PlatformWebView):
4002         (WTR::PlatformWebView::viewSupportsOptions):
4003         * WebKitTestRunner/mac/TestControllerMac.mm:
4004         (WTR::TestController::platformConfigureViewForTest):
4005
4006 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
4007
4008         Running tests for a long time results in some tests running very slowly (throttling)
4009         https://bugs.webkit.org/show_bug.cgi?id=147718
4010
4011         Reviewed by Chris Dumez.
4012
4013         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
4014         Although COCOA ports default this setting to be disabled in WebKit1,
4015         we should make both test harnesses disable the setting for consistency.
4016
4017         * DumpRenderTree/mac/DumpRenderTree.mm:
4018         (resetWebPreferencesToConsistentValues):
4019
4020 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
4021
4022         Use a specific version of Speedometer in run-benchmark
4023         https://bugs.webkit.org/show_bug.cgi?id=147769
4024
4025         Reviewed by Chris Dumez.
4026
4027         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
4028
4029         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
4030
4031 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
4032
4033         twisted_http_server.py should support --port
4034         https://bugs.webkit.org/show_bug.cgi?id=147771
4035
4036         Reviewed by Chris Dumez.
4037
4038         Added the option. This makes the script more useful on its own.
4039
4040         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
4041
4042 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
4043
4044         [GTK] WTF unit tests are timing out in the bots
4045         https://bugs.webkit.org/show_bug.cgi?id=147777
4046
4047         Reviewed by Filip Pizlo.
4048
4049         Add a way to mark google unit tests as slow and add
4050         WTF_Lock.ContentedShortSection to the list. In case of slow test
4051         we use the double of the given timeout for that particular test.
4052
4053         * Scripts/run-gtk-tests:
4054         (TestRunner):
4055         (TestRunner._run_google_test):
4056
4057 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
4058
4059         [GTK] run-gtk-tests should not stop when a google test case fails
4060         https://bugs.webkit.org/show_bug.cgi?id=147778
4061
4062         Reviewed by Philippe Normand.
4063
4064         For glib based tests we run the test runner with the -k option,
4065         but for google tests we are aborting as soon as we find a failure.
4066
4067         * Scripts/run-gtk-tests:
4068         (TestRunner._run_google_test_suite): Use a global return code that
4069         is set to 1 when any test has failed.
4070
4071 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
4072
4073         [GStreamer] Do not automatically show PackageKit codec installation notifications
4074         https://bugs.webkit.org/show_bug.cgi?id=135973
4075
4076         Reviewed by Philippe Normand.
4077
4078         Handle the missing media plugins installation permission request
4079         in MiniBrowser and add a test case for the new API.
4080
4081         * MiniBrowser/gtk/BrowserWindow.c:
4082         (webViewDecidePermissionRequest):
4083         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4084         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
4085         (permissionRequestCallback):
4086         (testInstallMissingPluginsPermissionRequest):
4087         (beforeAll):
4088         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
4089         (methodCallCallback):
4090
4091 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
4092
4093         Running tests for a long time results in some tests running very slowly (throttling)
4094         https://bugs.webkit.org/show_bug.cgi?id=147718
4095
4096         Reviewed by Alexey Proskuryakov.
4097
4098         * WebKitTestRunner/TestController.cpp:
4099         (WTR::TestController::resetPreferencesToConsistentValues):
4100         Ensure throttling settings are disabled for tests for all ports, as
4101         COCOA ports default to having these setting enabled. Note, there is
4102         still other timer throttling not covered by these setting.
4103
4104 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
4105
4106         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
4107         https://bugs.webkit.org/show_bug.cgi?id=147752
4108
4109         Reviewed by Chris Dumez.
4110
4111         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
4112
4113         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
4114         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
4115
4116         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
4117         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
4118         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
4119         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
4120         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
4121         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
4122         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
4123         HTTPServerDriverFactory taking the platform name as an argument.
4124         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
4125         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
4126         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
4127         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
4128         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
4129         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
4130         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
4131         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
4132         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
4133         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
4134         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
4135         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
4136         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
4137         (HTTPServerDriver): Replaced name by platforms.
4138         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
4139         (SimpleHTTPServerDriver): Ditto.
4140         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
4141         (parse_args): Removed --http-server-driver option.
4142         (start): Ditto.
4143
4144 2015-08-06  Chris Dumez  <cdumez@apple.com>
4145
4146         Toggle GPS state based on page visibility to save battery
4147         https://bugs.webkit.org/show_bug.cgi?id=147685
4148
4149         Reviewed by Benjamin Poulain.
4150
4151         Add testRunner.isGeolocationProviderActive() test support function.
4152
4153         * DumpRenderTree/TestRunner.cpp:
4154         (isGeolocationProviderActiveCallback):
4155         (TestRunner::staticFunctions):
4156         * DumpRenderTree/TestRunner.h:
4157         * DumpRenderTree/mac/MockGeolocationProvider.h:
4158         * DumpRenderTree/mac/MockGeolocationProvider.mm:
4159         (-[MockGeolocationProvider isActive]):
4160         * DumpRenderTree/mac/TestRunnerMac.mm:
4161         (TestRunner::isGeolocationProviderActive):
4162         * DumpRenderTree/win/TestRunnerWin.cpp:
4163         (TestRunner::isGeolocationProviderActive):
4164         * WebKitTestRunner/GeolocationProviderMock.h:
4165         (WTR::GeolocationProviderMock::isActive):
4166         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4167         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4168         (WTR::InjectedBundle::isGeolocationProviderActive):
4169         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4170         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4171         (WTR::TestRunner::isGeolocationProviderActive):
4172         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4173         * WebKitTestRunner/TestController.cpp:
4174         (WTR::TestController::isGeolocationProviderActive):
4175         * WebKitTestRunner/TestController.h:
4176         * WebKitTestRunner/TestInvocation.cpp:
4177         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4178
4179 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
4180
4181         Automate JSBench with run-benchmark
4182         https://bugs.webkit.org/show_bug.cgi?id=147716
4183
4184         Reviewed by Chris Dumez.
4185
4186         Added JSBench plan to run-benchmark.
4187
4188         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
4189         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
4190         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
4191         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
4192         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
4193         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
4194         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
4195         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
4196         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
4197         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
4198         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
4199         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
4200         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
4201         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
4202         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
4203         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
4204
4205 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
4206