065c83a1fd3fb574e02261402d660be3dfc2bca8
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2
3         Unreviewed, build fix after r241480
4
5         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
6         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
7         (-[DragAndDropSimulator initWithWebView:]):
8
9 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
10
11         AX: ARIA Reflection was disabled in error
12         https://bugs.webkit.org/show_bug.cgi?id=194647
13         <rdar://problem/48068336>
14
15         Reviewed by Ryosuke Niwa.
16
17         Remove test override now that this feature should be enabled by default.
18
19         * WebKitTestRunner/TestController.cpp:
20         (WTR::TestController::resetPreferencesToConsistentValues):
21
22 2019-02-14  Commit Queue  <commit-queue@webkit.org>
23
24         Unreviewed, rolling out r241486.
25         https://bugs.webkit.org/show_bug.cgi?id=194655
26
27         causing API failures in builds (Requested by ShawnRoberts on
28         #webkit).
29
30         Reverted changeset:
31
32         "[Cocoa] Media elements will restart network buffering just
33         before suspending"
34         https://bugs.webkit.org/show_bug.cgi?id=193691
35         https://trac.webkit.org/changeset/241486
36
37 2019-02-14  Zalan Bujtas  <zalan@apple.com>
38
39         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
40         https://bugs.webkit.org/show_bug.cgi?id=194622
41
42         Reviewed by Antti Koivisto.
43
44         * LayoutReloaded/misc/LFC-passing-tests.txt:
45
46 2019-02-14  Zalan Bujtas  <zalan@apple.com>
47
48         [LFC] Shrink-to-fit-width should be constrained by min/max width
49         https://bugs.webkit.org/show_bug.cgi?id=194653
50
51         Reviewed by Antti Koivisto.
52
53         * LayoutReloaded/misc/LFC-passing-tests.txt:
54
55 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
56
57         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
58         https://bugs.webkit.org/show_bug.cgi?id=194641
59
60         Reviewed by Geoffrey Garen.
61
62         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
63         so that the test would fail without this fix.
64
65         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
66         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
67
68 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
69
70         [ews-app] Change log level for a log statement
71
72         Unreviewed minor fix.
73
74         * BuildSlaveSupport/ews-app/ews/models/patch.py:
75         (Patch.save_patch):
76
77 2019-02-13  Jer Noble  <jer.noble@apple.com>
78
79         [Cocoa] Media elements will restart network buffering just before suspending
80         https://bugs.webkit.org/show_bug.cgi?id=193691
81
82         Reviewed by Eric Carlson.
83
84         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
85         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
86         (TEST):
87
88 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
89
90         [ews-app] Fetch builder id to name mapping
91         https://bugs.webkit.org/show_bug.cgi?id=194355
92
93         Reviewed by Lucas Forschler.
94
95         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
96         (Buildbot.get_builder_id_to_name_mapping):
97         (Buildbot._get_display_name_from_builder_name):
98
99 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
100
101         Further restricting webarchive loads
102         https://bugs.webkit.org/show_bug.cgi?id=194567
103         <rdar://problem/47610130>
104
105         Reviewed by Youenn Fablet.
106
107         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
108         navigations on drop.
109
110         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
111         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
112         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
113         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
114         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
115         (TestWebKitAPI::TEST):
116         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
117         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
118         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
119         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
120         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
121         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
122         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
123
124 2019-02-13  John Wilander  <wilander@apple.com>
125
126         Store Ad Click Attribution requests in the network process
127         https://bugs.webkit.org/show_bug.cgi?id=194510
128         <rdar://problem/47650118>
129
130         Reviewed by Alex Christensen and Daniel Bates.
131
132         This patch adds two TestRunner functions:
133         - dumpAdClickAttribution()
134         - clearAdClickAttribution()
135
136         They call into the network process to dump and clear Ad Click
137         Attribution state, respectively.
138
139         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
140         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
141         (WTR::TestRunner::dumpAdClickAttribution):
142         (WTR::TestRunner::clearAdClickAttribution):
143         * WebKitTestRunner/InjectedBundle/TestRunner.h:
144         * WebKitTestRunner/TestController.cpp:
145         (WTR::TestController::resetStateToConsistentValues):
146         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
147         (WTR::adClickAttributionStringResultCallback):
148         (WTR::TestController::dumpAdClickAttribution):
149         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
150         (WTR::adClickAttributionVoidCallback):
151         (WTR::TestController::clearAdClickAttribution):
152         * WebKitTestRunner/TestController.h:
153         * WebKitTestRunner/TestInvocation.cpp:
154         (WTR::TestInvocation::dumpResults):
155         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
156         (WTR::TestInvocation::dumpAdClickAttribution):
157         * WebKitTestRunner/TestInvocation.h:
158
159 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
160
161         [ews-app] Generate status-bubble
162         https://bugs.webkit.org/show_bug.cgi?id=194572
163
164         Reviewed by Lucas Forschler.
165
166         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
167         (StatusBubble._build_bubble):
168         (StatusBubble._should_show_bubble_for):
169         (StatusBubble._build_bubbles_for_patch):
170
171 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
172
173         [ews-app] Add status bubble html template
174         https://bugs.webkit.org/show_bug.cgi?id=194571
175
176         Reviewed by Lucas Forschler.
177
178         * BuildSlaveSupport/ews-app/ews/templates: Added.
179         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
180
181 2019-02-12  Chris Dumez  <cdumez@apple.com>
182
183         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
184         https://bugs.webkit.org/show_bug.cgi?id=194568
185         <rdar://problem/47944490>
186
187         Reviewed by Ryosuke Niwa.
188
189         Add API test coverage.
190
191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
192         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
193
194 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
195
196         webkitpy: Remove bug_dummy from parsed test expectations
197         https://bugs.webkit.org/show_bug.cgi?id=194562
198         <rdar://problem/47853999>
199
200         Reviewed by Lucas Forschler.
201
202         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
203         (TestExpectationParser):
204         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
205         skipped tests.
206         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
207
208 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
209
210         [ews-app] Add method to fetch patch
211         https://bugs.webkit.org/show_bug.cgi?id=194518
212
213         Reviewed by Lucas Forschler.
214
215         * BuildSlaveSupport/ews-app/ews/models/patch.py:
216         (Patch.get_patch):
217
218 2019-02-12  Zalan Bujtas  <zalan@apple.com>
219
220         [LFC] Expand tests coverage (60 new tests -> 860)
221
222         Unreviewed test gardening (run-singly, --child-processes=1).
223
224         * LayoutReloaded/misc/LFC-passing-tests.txt:
225
226 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
227
228         Allow pages to trigger programmatic paste from script on iOS
229         https://bugs.webkit.org/show_bug.cgi?id=194271
230         <rdar://problem/47808810>
231
232         Reviewed by Tim Horton.
233
234         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
235
236         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
237         (WTR::UIScriptController::platformSetDidShowMenuCallback):
238         (WTR::UIScriptController::platformSetDidHideMenuCallback):
239         (WTR::UIScriptController::rectForMenuAction const):
240
241         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
242         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
243         for when the menu is shown or hidden.
244
245         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
246         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
247         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
248         (WTR::UIScriptController::setDidShowMenuCallback):
249         (WTR::UIScriptController::didShowMenuCallback const):
250         (WTR::UIScriptController::setDidHideMenuCallback):
251         (WTR::UIScriptController::didHideMenuCallback const):
252         (WTR::UIScriptController::platformSetDidShowMenuCallback):
253         (WTR::UIScriptController::platformSetDidHideMenuCallback):
254         (WTR::UIScriptController::rectForMenuAction const):
255         * TestRunnerShared/UIScriptContext/UIScriptController.h:
256         * WebKitTestRunner/TestController.cpp:
257         (WTR::TestController::resetPreferencesToConsistentValues):
258         (WTR::updateTestOptionsFromTestHeader):
259         * WebKitTestRunner/TestOptions.h:
260
261         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
262         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
263
264         (WTR::TestOptions::hasSameInitializationOptions const):
265         * WebKitTestRunner/UIScriptControllerCocoa.mm:
266         (WTR::UIScriptController::calendarType const):
267         (WTR::UIScriptController::platformUndoManager const):
268         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
269         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
270         (-[TestRunnerWKWebView initWithFrame:configuration:]):
271         (-[TestRunnerWKWebView dealloc]):
272         (-[TestRunnerWKWebView _didShowMenu]):
273         (-[TestRunnerWKWebView _didHideMenu]):
274
275         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
276
277         * WebKitTestRunner/ios/TestControllerIOS.mm:
278         (WTR::handleMenuWillHideNotification):
279         (WTR::handleMenuDidHideNotification):
280         (WTR::TestController::platformInitialize):
281         (WTR::TestController::platformDestroy):
282         (WTR::TestController::platformResetStateToConsistentValues):
283
284         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
285         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
286
287         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
288         (WTR::forEachViewInHierarchy):
289         (WTR::findViewInHierarchyOfType):
290
291         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
292         functions that dig through a given view's hierarchy in search of a view of a given class.
293
294         (WTR::UIScriptController::selectionStartGrabberViewRect const):
295         (WTR::UIScriptController::selectionEndGrabberViewRect const):
296         (WTR::UIScriptController::selectionCaretViewRect const):
297         (WTR::UIScriptController::selectionRangeViewRects const):
298         (WTR::UIScriptController::platformSetDidShowMenuCallback):
299         (WTR::UIScriptController::platformSetDidHideMenuCallback):
300
301         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
302
303         (WTR::UIScriptController::rectForMenuAction const):
304
305         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
306         callout bar) whose label matches the given string.
307
308         (WTR::UIScriptController::platformContentView const):
309
310         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
311         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
312         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
313
314         (WTR::UIScriptController::platformUndoManager const): Deleted.
315         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
316         (WTR::UIScriptController::platformContentView const):
317         (WTR::UIScriptController::platformUndoManager const): Deleted.
318
319 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
320
321         webkitpy: No option to only show unexpected failures in results.html for iPad
322         https://bugs.webkit.org/show_bug.cgi?id=194554
323         <rdar://problem/47922442>
324
325         Rubber-stamped by Aakash Jain.
326
327         Just because a TestExpecations file does not exist for a specific platform does not mean that
328         TestExpecations are not being used, given that platforms inherit test expectations.
329
330         * Scripts/webkitpy/port/base.py:
331         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
332         * Scripts/webkitpy/port/base_unittest.py:
333         (PortTest.test_uses_test_expectations_file):
334
335 2019-02-12  Alex Christensen  <achristensen@webkit.org>
336
337         Remove setDefersLoading infrastructure from WebKit2
338         https://bugs.webkit.org/show_bug.cgi?id=194506
339
340         Reviewed by Brady Eidson.
341
342         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
343         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
344         (WTR::TestRunner::setDefersLoading): Deleted.
345         * WebKitTestRunner/InjectedBundle/TestRunner.h:
346
347 2019-02-12  Alex Christensen  <achristensen@webkit.org>
348
349         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
350         https://bugs.webkit.org/show_bug.cgi?id=194522
351         <rdar://problem/47789393>
352
353         Reviewed by Chris Dumez.
354
355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
356         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
357         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
359
360 2019-02-12  Andy Estes  <aestes@apple.com>
361
362         [iOSMac] Enable Parental Controls Content Filtering
363         https://bugs.webkit.org/show_bug.cgi?id=194521
364         <rdar://39732376>
365
366         Reviewed by Tim Horton.
367
368         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
369
370 2019-02-12  Zalan Bujtas  <zalan@apple.com>
371
372         [LFC][IFC] Add intrinsic width support for float boxes.
373         https://bugs.webkit.org/show_bug.cgi?id=194528
374
375         Reviewed by Antti Koivisto.
376
377         Expand tests coverage (2 new tests -> 800).
378         (This is the correct test ordering --runs-singly --child-processes=1)
379
380         * LayoutReloaded/misc/LFC-passing-tests.txt:
381
382 2019-02-12  Rob Buis  <rbuis@igalia.com>
383
384         Implement serializing in MIME type parser
385         https://bugs.webkit.org/show_bug.cgi?id=193909
386
387         Reviewed by Darin Adler.
388
389         Add various tests involving upper case, non-ASCII, control/null characters,
390         various HTTP whitespace, single quotes and an unpaired surrogate.
391
392         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
393         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
394         (TestWebKitAPI::serializeIfValid):
395         (TestWebKitAPI::TEST):
396
397 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
398
399         [Cocoa] Ask platform for generic font family mappings
400         https://bugs.webkit.org/show_bug.cgi?id=187723
401         <rdar://problem/41892438>
402
403         Reviewed by Brent Fulgham.
404
405         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
406
407         * DumpRenderTree/mac/DumpRenderTree.mm:
408         (allowedFontFamilySet):
409         * WebKitTestRunner/mac/TestControllerMac.mm:
410         (WTR::allowedFontFamilySet):
411
412 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
413
414         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
415         https://bugs.webkit.org/show_bug.cgi?id=193622
416
417         Reviewed by Michael Catanzaro.
418
419         This adds support for loading content extension rule sets from the JSON files which
420         accompany the corresponding layout test, using the C API. The Cocoa specific parts
421         of WKTR for this could be removed, but that is left for a follow-up patch with
422         cleanups.
423
424         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
425         * WebKitTestRunner/TestController.cpp:
426         (WTR::testPath): Subtract one from the length when constructing the result std::string to
427         avoid having the null-terminator copied into the result.
428         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
429         part of the preparations to run a test.
430         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
431         (WTR::contentExtensionStoreCallback): Added.
432         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
433         used for content extensions test.
434         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
435         extensions and compiling the JSON rule set for tests involving content extensions.
436         (WTR::TestController::resetContentExtensions): Removes the content extension built for
437         testing and disables content extensions.
438         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
439         resetContentExtensions().
440         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
441         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
442         configureContentExtensionForTest(), and userContentController().
443
444 2019-02-11  Daniel Bates  <dabates@apple.com>
445
446         [iOS] Mouse/Touch/Pointer events are missing modifier keys
447         https://bugs.webkit.org/show_bug.cgi?id=191446
448         <rdar://problem/45929460>
449
450         Reviewed by Tim Horton.
451
452         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
453
454         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
455         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
456         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
457         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
458         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
459         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
460         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
461         * TestRunnerShared/UIScriptContext/UIScriptController.h:
462         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
463         (WTR::arrayLength):
464         (WTR::parseModifierArray):
465         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
466         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
467         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
468         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
469
470 2019-02-11  Commit Queue  <commit-queue@webkit.org>
471
472         Unreviewed, rolling out r241272 and r241276.
473         https://bugs.webkit.org/show_bug.cgi?id=194514
474
475         Broke the Apple Internal build and the fix requires human
476         intervention :( (Requested by dydz on #webkit).
477
478         Reverted changesets:
479
480         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
481         https://bugs.webkit.org/show_bug.cgi?id=191446
482         https://trac.webkit.org/changeset/241272
483
484         "Fix internal iOS build after r241272"
485         https://bugs.webkit.org/show_bug.cgi?id=191446
486         https://trac.webkit.org/changeset/241276
487
488 2019-02-11  Truitt Savell  <tsavell@apple.com>
489
490         Unreviewed, rolling out r241269.
491
492         Caused 5 layout tests crashes on Mac WK1
493
494         Reverted changeset:
495
496         "DumpRenderTree should report unknown options"
497         https://bugs.webkit.org/show_bug.cgi?id=191303
498         https://trac.webkit.org/changeset/241269
499
500 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
501
502         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
503         https://bugs.webkit.org/show_bug.cgi?id=194313
504
505         Reviewed by Tim Horton.
506
507         Add a helper to determine whether the web view is presenting modal UI.
508
509         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
510         (WTR::UIScriptController::isPresentingModally const):
511         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
512         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
513         (WTR::UIScriptController::isPresentingModally const):
514         * TestRunnerShared/UIScriptContext/UIScriptController.h:
515         * WebKitTestRunner/UIScriptControllerCocoa.mm:
516         (WTR::UIScriptController::calendarType const): Deleted.
517         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
518         (WTR::UIScriptController::isPresentingModally const):
519         (WTR::UIScriptController::calendarType const):
520         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
521         (WTR::UIScriptController::calendarType const):
522
523 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
524
525         GCHeapInspector: Show the retained sizes in more places
526         https://bugs.webkit.org/show_bug.cgi?id=194464
527
528         Reviewed by Simon Fraser.
529
530         * GCHeapInspector/gc-heap-inspector.html:
531         * GCHeapInspector/script/interface.js:
532         (HeapInspectorUtils.humanReadableSize):
533         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
534         (HeapInspectorUtils.spanForNode.span.span):
535         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
536         (HeapSnapshotInspector.prototype.buildRoots):
537
538 2019-02-11  Daniel Bates  <dabates@apple.com>
539
540         [iOS] Mouse/Touch/Pointer events are missing modifier keys
541         https://bugs.webkit.org/show_bug.cgi?id=191446
542         <rdar://problem/45929460>
543
544         Reviewed by Tim Horton.
545
546         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
547
548         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
549         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
550         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
551         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
552         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
553         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
554         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
555         * TestRunnerShared/UIScriptContext/UIScriptController.h:
556         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
557         (WTR::arrayLength):
558         (WTR::parseModifierArray):
559         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
560         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
561         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
562         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
563
564 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
565
566         DumpRenderTree should report unknown options
567         https://bugs.webkit.org/show_bug.cgi?id=191303
568
569         Reviewed by Frédéric Wang.
570
571         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
572         to report unknown options.
573         Added and assigned test options which are currently used in tests.
574
575         * DumpRenderTree/TestOptions.cpp:
576         (TestOptions::TestOptions):
577
578 2019-02-11  Truitt Savell  <tsavell@apple.com>
579
580         Unreviewed, rolling out r241229.
581
582         Revision broke internal builds for watchOS.
583
584         Reverted changeset:
585
586         "[Cocoa] Ask platform for generic font family mappings"
587         https://bugs.webkit.org/show_bug.cgi?id=187723
588         https://trac.webkit.org/changeset/241229
589
590 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
591
592         [WinCairo][MiniBrowser] Basic authentication always fails.
593         https://bugs.webkit.org/show_bug.cgi?id=194496
594
595         Reviewed by Don Olmstead.
596
597         * MiniBrowser/win/DialogHelper.h:
598         (Dialog::getText):
599
600 2019-02-11  Philippe Normand  <pnormand@igalia.com>
601
602         [GStreamer] GstMappedBuffer testsuite build fails
603         https://bugs.webkit.org/show_bug.cgi?id=194495
604
605         Reviewed by Carlos Garcia Campos.
606
607         Fix the build by explicitely adding the gstreamer1.0-audio include
608         directories to the include path.
609
610         * TestWebKitAPI/PlatformGTK.cmake:
611         * TestWebKitAPI/PlatformWPE.cmake:
612
613 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
614
615         [GTK][WPE] Add enable-javascript-markup setting
616         https://bugs.webkit.org/show_bug.cgi?id=193439
617
618         Reviewed by Michael Catanzaro.
619
620         Add test cases to check the new setting.
621
622         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
623         (testWebKitSettings):
624         (testWebKitSettingsJavaScriptMarkup):
625         (beforeAll):
626
627 2019-02-10  Darin Adler  <darin@apple.com>
628
629         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
630         https://bugs.webkit.org/show_bug.cgi?id=194485
631
632         Reviewed by Daniel Bates.
633
634         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
635
636 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
637
638         Add more tests for clampTo<>()
639         https://bugs.webkit.org/show_bug.cgi?id=194462
640
641         Reviewed by Geoffrey Garen.
642
643         Darin suggested to test the very last floating point number
644         at the boundaries when truncating to integer.
645         I added test for max/min and max-1/min-1.
646
647         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
648         (TestWebKitAPI::TEST):
649
650 2019-02-09  Darin Adler  <darin@apple.com>
651
652         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
653         https://bugs.webkit.org/show_bug.cgi?id=194021
654
655         Reviewed by Geoffrey Garen.
656
657         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
658         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
659         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
660
661 2019-02-09  Zalan Bujtas  <zalan@apple.com>
662
663         [LFC][IFC] Add intrinsic width support for basic inline containers
664         https://bugs.webkit.org/show_bug.cgi?id=194473
665
666         Reviewed by Antti Koivisto.
667
668         Expand tests coverage (11 new tests -> 798)
669
670         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
671
672 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
673
674         Fix MiniBrowser's entitlements
675         https://bugs.webkit.org/show_bug.cgi?id=192431
676
677         Reviewed by Joseph Pecoraro.
678
679         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
680         files, making it impossible to load any extension.
681
682         * MiniBrowser/MiniBrowser.entitlements:
683
684 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
685
686         [Cocoa] Ask platform for generic font family mappings
687         https://bugs.webkit.org/show_bug.cgi?id=187723
688         <rdar://problem/41892438>
689
690         Reviewed by Brent Fulgham.
691
692         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
693
694         * DumpRenderTree/mac/DumpRenderTree.mm:
695         (allowedFontFamilySet):
696         * WebKitTestRunner/mac/TestControllerMac.mm:
697         (WTR::allowedFontFamilySet):
698
699 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
700
701         [GTK] Implement back/forward touchpad gesture
702         https://bugs.webkit.org/show_bug.cgi?id=193919
703
704         Reviewed by Michael Catanzaro.
705
706         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
707         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
708
709 2019-02-08  Alex Christensen  <achristensen@webkit.org>
710
711         Add SPI to use networking daemon instead of XPC service
712         https://bugs.webkit.org/show_bug.cgi?id=194427
713
714         Reviewed by Geoffrey Garen
715
716         * MiniBrowser/MiniBrowser.entitlements:
717
718 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
719
720         [ews-build] Ensure that every builder in config.json has short name
721         https://bugs.webkit.org/show_bug.cgi?id=194461
722
723         Reviewed by Lucas Forschler.
724
725         * BuildSlaveSupport/ews-build/loadConfig.py:
726         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
727
728 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
729
730         [ews-build] Add short name to config.json
731         https://bugs.webkit.org/show_bug.cgi?id=194456
732
733         Reviewed by Lucas Forschler.
734
735         * BuildSlaveSupport/ews-build/config.json: Added short name.
736         * BuildSlaveSupport/ews-build/loadConfig.py:
737         (loadBuilderConfig): Set the short name as the builder description.
738
739 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
740
741         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
742         https://bugs.webkit.org/show_bug.cgi?id=194418
743
744         Reviewed by Lucas Forschler.
745
746         Do not include errors trying when finding crashlogs at the end of
747         a run-webkit-tests run since we don't process those errors.
748
749         * Scripts/webkitpy/port/darwin.py:
750         (DarwinPort._look_for_all_crash_logs_in_log_dir):
751         * Scripts/webkitpy/port/ios_device.py:
752         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
753         * Scripts/webkitpy/port/watch_device.py:
754         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
755
756 2019-02-08  Beth Dakin  <bdakin@apple.com>
757
758         Add afterScreenUpdates to WKSnapshotConfiguration
759         https://bugs.webkit.org/show_bug.cgi?id=194362
760         -and corresponding-
761         <rdar://problem/40655528> Please add an "after screen updates" property to 
762         WKSnapshotConfiguration (to solve blank snapshots)
763
764         Reviewed by Tim Horton.
765
766         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
767         (TEST):
768
769 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
770
771         clampTo(): do not convert the input to double when dealing with integers
772         https://bugs.webkit.org/show_bug.cgi?id=194263
773         <rdar://problem/47692312>
774
775         Reviewed by Darin Adler.
776
777         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
778         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
779         (TestWebKitAPI::testClampFloatingPointToInteger):
780         (TestWebKitAPI::testClampSameSignIntegers):
781         (TestWebKitAPI::testClampUnsignedToSigned):
782         (TestWebKitAPI::testClampSignedToUnsigned):
783
784 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
785
786         webkitpy: Respect --dedicated-simulators flag
787         https://bugs.webkit.org/show_bug.cgi?id=194416
788         <rdar://problem/47894722>
789
790         Reviewed by Lucas Forschler.
791
792         * Scripts/webkitpy/port/device_port.py:
793         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
794         available devices can be safely ignored.
795
796 2019-02-07  Keith Rollin  <krollin@apple.com>
797
798         Remove extra copy of 100x100-red.tga
799         https://bugs.webkit.org/show_bug.cgi?id=194371
800         <rdar://problem/47873465>
801
802         Reviewed by Said Abou-Hallawa.
803
804         In order to help it pass its tests, Bug 194190 added a second copy of
805         the file 100x100-red.tga. However, it turns out that this additional
806         file wasn't actually needed, and that that sole previous copy was
807         sufficient. At the same time, this second copy -- which was copied to
808         the same location in the build output as the first copy -- now caused
809         XCBuild to complain because there were two production rules for the
810         same output file. Address this by removing the newly-added extra copy.
811
812         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
813         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
814
815 2019-02-07  Alex Christensen  <achristensen@webkit.org>
816
817         Deprecate WKBundlePageSetDefersLoading
818         https://bugs.webkit.org/show_bug.cgi?id=191394
819
820         Reviewed by Dean Jackson.
821
822         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
823         (WTR::TestRunner::setDefersLoading):
824
825 2019-02-07  Zalan Bujtas  <zalan@apple.com>
826
827         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
828         https://bugs.webkit.org/show_bug.cgi?id=194391
829
830         Reviewed by Antti Koivisto.
831
832         * LayoutReloaded/misc/LFC-passing-tests.txt:
833
834 2019-02-06  Keith Rollin  <krollin@apple.com>
835
836         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
837         https://bugs.webkit.org/show_bug.cgi?id=193975
838         <rdar://problem/47643306>
839
840         Reviewed by Tim Horton.
841
842         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
843         the Info.plist file into the bundle. This step is not necessary as the
844         implicit "bundle up all the build products into a framework" build
845         phase does this already. Having the Copy Bundle Resources phase do
846         this causes a conflict under XCBuild, which objects to two build
847         phases producing the same file (Info.plist). Address this by removing
848         Info.plist from the Copy Bundle Resources phase.
849
850         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
851
852 2019-02-06  Keith Rollin  <krollin@apple.com>
853
854         Really enable the automatic checking and regenerations of .xcfilelists during builds
855         https://bugs.webkit.org/show_bug.cgi?id=194357
856         <rdar://problem/47861231>
857
858         Reviewed by Chris Dumez.
859
860         Bug 194124 was supposed to enable the automatic checking and
861         regenerating of .xcfilelist files during the build. While related
862         changes were included in that patch, the change to actually enable the
863         operation somehow was omitted. This patch actually enables the
864         operation. The check-xcfilelist.sh scripts now check
865         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
866         from the checking.
867
868         * DumpRenderTree/Scripts/check-xcfilelists.sh:
869         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
870
871 2019-02-06  David Kilzer  <ddkilzer@apple.com>
872
873         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
874         <https://webkit.org/b/194286>
875         <rdar://problem/47815558>
876
877         Reviewed by Alexey Proskuryakov.
878
879         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
880         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
881         WKRetainPtr<> to avoid leaking the WKDataRef.
882
883 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
884
885         Unreviewed, fix a typo
886
887         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
888
889 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
890
891         [GTK][WPE] force libpsl build to use ICU in jhbuild
892         https://bugs.webkit.org/show_bug.cgi?id=194288
893
894         Reviewed by Carlos Garcia Campos.
895
896         * gtk/jhbuild.modules:
897         Require ICU for libpsl build in jhbuild, like done in WPE.
898
899 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
900
901         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
902         https://bugs.webkit.org/show_bug.cgi?id=194209
903
904         Reviewed by Carlos Garcia Campos.
905
906         Enhance TestCookieManager to ensure this doesn't happen again.
907
908         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
909         (testCookieManagerPersistentStorage):
910         (beforeAll):
911
912 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
913
914         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
915         https://bugs.webkit.org/show_bug.cgi?id=194324
916
917         Reviewed by Andy Estes.
918
919         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
920         part of the name is already implicit, since this is in testing code in TestOptions.
921
922         * WebKitTestRunner/TestController.cpp:
923         (WTR::TestController::generateContextConfiguration const):
924         (WTR::updateTestOptionsFromTestHeader):
925         * WebKitTestRunner/TestOptions.h:
926         (WTR::TestOptions::hasSameInitializationOptions const):
927
928 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
929
930         [ews-build] Allow * as platform for builders and workers
931         https://bugs.webkit.org/show_bug.cgi?id=188533
932
933         Reviewed by Lucas Forschler.
934
935         * BuildSlaveSupport/ews-build/loadConfig.py:
936         (checkWorkersAndBuildersForConsistency):
937
938 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
939
940         [ews-build] Add few bots to config.json
941         https://bugs.webkit.org/show_bug.cgi?id=194304
942
943         Reviewed by Lucas Forschler.
944
945         * BuildSlaveSupport/ews-build/config.json:
946
947 2019-02-05  Keith Rollin  <krollin@apple.com>
948
949         Enable the automatic checking and regenerations of .xcfilelists during builds
950         https://bugs.webkit.org/show_bug.cgi?id=194124
951         <rdar://problem/47721277>
952
953         Reviewed by Tim Horton.
954
955         Bug 193790 add a facility for checking -- during build time -- that
956         any needed .xcfilelist files are up-to-date and for updating them if
957         they are not. This facility was initially opt-in by setting
958         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
959         the process seemed robust. Its now time to enable this facility and
960         make it opt-out. If there is a need to disable this facility, set and
961         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
962         running `make` or `build-webkit`, or before running Xcode from the
963         command line.
964
965         Additionally, remove the step that generates a list of source files
966         going into the UnifiedSources build step. It's only necessarily to
967         specify Sources.txt and SourcesCocoa.txt as inputs.
968
969         * Scripts/generate-xcfilelists:
970
971 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
972
973         [GTK][WPE] force libpsl build to use ICU in jhbuild
974         https://bugs.webkit.org/show_bug.cgi?id=194288
975
976         Reviewed by Philippe Normand.
977
978         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
979         This can cause build failures if libidn is detected but libunistring is not available.
980
981         Make sure that ICU is used for runtime and builtin PSL data.
982
983         * gtk/jhbuild.modules:
984         * wpe/jhbuild.modules:
985
986 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
987
988         [ews-app] Modified timestamp should be updated on updating data
989         https://bugs.webkit.org/show_bug.cgi?id=194295
990
991         Reviewed by Lucas Forschler.
992
993         * BuildSlaveSupport/ews-app/ews/models/build.py:
994         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
995         * BuildSlaveSupport/ews-app/ews/models/step.py:
996
997 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
998
999         Unreviewed, rolling out r240742.
1000
1001         Causes crashes on iOS simulator.
1002
1003         Reverted changeset:
1004
1005         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1006         not focused in a content-editable element"
1007         https://bugs.webkit.org/show_bug.cgi?id=192824
1008         https://trac.webkit.org/changeset/240742
1009
1010 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1011
1012         run-webkit-tests emits message "...running None" when running tests
1013         https://bugs.webkit.org/show_bug.cgi?id=194133
1014         <rdar://problem/47724738>
1015
1016         Reviewed by Lucas Forschler.
1017
1018         * Scripts/webkitpy/xcode/device_type.py:
1019         (DeviceType.__str__): Use both version mapping tables and use just the variant
1020         name if no version name is available.
1021         * Scripts/webkitpy/xcode/device_type_unittest.py:
1022         (DeviceTypeTest):
1023         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1024         an associated named.
1025
1026 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1027
1028         [WPE] require python3-setuptools for meson build in jhbuild
1029         https://bugs.webkit.org/show_bug.cgi?id=194287
1030
1031         Reviewed by Philippe Normand.
1032
1033         python3-setuptools is needed to build meson in jhbuild.
1034         It is already required by the GTK port.
1035
1036         * wpe/install-dependencies:
1037
1038 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1039
1040         [ews-app] Add method to save BuilderMapping to database
1041         https://bugs.webkit.org/show_bug.cgi?id=194264
1042
1043         Reviewed by Lucas Forschler.
1044
1045         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1046         (BuilderMapping.__str__):
1047         (BuilderMapping):
1048         (BuilderMapping.save_mapping):
1049         (BuilderMapping.update_mapping):
1050         (BuilderMapping.get_existing_mapping):
1051         (BuilderMapping.is_valid_mapping):
1052
1053 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1054
1055         [ews-app] Add timestamp fields for BuilderMappings
1056         https://bugs.webkit.org/show_bug.cgi?id=194266
1057
1058         Reviewed by Lucas Forschler.
1059
1060         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1061         (BuilderMapping):
1062
1063 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1064
1065         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1066         https://bugs.webkit.org/show_bug.cgi?id=174816
1067
1068         Reviewed by Michael Catanzaro.
1069
1070         Add tests for webkit_uri_for_display().
1071
1072         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1073         (testURIForDisplayUnaffected):
1074         (testURIForDisplayAffected):
1075         (beforeAll):
1076         (afterAll):
1077         * TestWebKitAPI/glib/CMakeLists.txt:
1078
1079 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1080
1081         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1082         https://bugs.webkit.org/show_bug.cgi?id=194158
1083         <rdar://problem/47737268>
1084
1085         Rubber-stamped by Aakash Jain.
1086
1087         * Scripts/webkitpy/port/device_port.py:
1088         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1089
1090 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1091
1092         [CG] Enable setAdditionalSupportedImageTypes for WK1
1093         https://bugs.webkit.org/show_bug.cgi?id=194190
1094
1095         Reviewed by Tim Horton.
1096
1097         Add a test similar to the one under WebKit Cocoa but make it create a
1098         WebView instead of a WKWebView.
1099
1100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1101         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1102         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1103         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1104         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1105         (TestWebKitAPI::runTest):
1106         (TestWebKitAPI::TEST):
1107
1108 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1109
1110         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1111         https://bugs.webkit.org/show_bug.cgi?id=194168
1112
1113         Reviewed by Simon Fraser.
1114
1115         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1116
1117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1118         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1119         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1120         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1121         (TEST):
1122         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1123         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1124
1125 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1126
1127         REGRESSION (r237269): webkit-patch what-broke is broken 
1128         https://bugs.webkit.org/show_bug.cgi?id=193025
1129
1130         Reviewed by Aakash Jain.
1131
1132         * Scripts/webkitpy/common/host.py:
1133         (Host.buildbot):
1134         (Host.bugzilla): Renamed to 'buildbot'.
1135
1136 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1137
1138         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1139         https://bugs.webkit.org/show_bug.cgi?id=194207
1140
1141         Reviewed by Tim Horton.
1142
1143         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1144         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1145         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1146         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1147         start and delete forwards to remove the original attachment.
1148
1149         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1150         (TestWebKitAPI::TEST):
1151
1152 2019-02-04  Youenn Fablet  <youenn@apple.com>
1153
1154         Capture state should be managed consistently when doing process swapping
1155         https://bugs.webkit.org/show_bug.cgi?id=194122
1156         <rdar://problem/47609293>
1157
1158         Reviewed by Eric Carlson.
1159
1160         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1161         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1162         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1163         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1164         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1165         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1166         (WTR::TestRunner::isDoingMediaCapture const):
1167         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1168         * WebKitTestRunner/TestController.cpp:
1169         (WTR::TestController::isDoingMediaCapture const):
1170         * WebKitTestRunner/TestController.h:
1171         * WebKitTestRunner/TestInvocation.cpp:
1172         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1173         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1174         (WTR::TestController::isDoingMediaCapture const):
1175
1176 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1177
1178         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1179         https://bugs.webkit.org/show_bug.cgi?id=194142
1180
1181         Reviewed by Ross Kirsling.
1182
1183         There three 'separator' variables in TestController.cpp. Renamed
1184         it 'pathSeparator', and unified them.
1185
1186         * WebKitTestRunner/TestController.cpp:
1187         (WTR::TestController::generateContextConfiguration const):
1188         (WTR::createTestURL):
1189         (WTR::TestController::platformAdjustContext):
1190
1191 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1192
1193         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1194         https://bugs.webkit.org/show_bug.cgi?id=194198
1195
1196         Reviewed by Antti Koivisto.
1197
1198         No need to set the banner heights on navigation now, since Page stores them.
1199
1200         * MiniBrowser/mac/WK2BrowserWindowController.m:
1201         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1202
1203 2019-02-03  John Wilander  <wilander@apple.com>
1204
1205         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1206         https://bugs.webkit.org/show_bug.cgi?id=194104
1207         <rdar://problem/47649991>
1208
1209         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1210
1211         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1212         (TestWebKitAPI::TEST):
1213             Changed numeric types from unsigned short to uint32_t.
1214
1215 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1216
1217         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1218         <https://webkit.org/b/194178>
1219         <rdar://problem/47753473>
1220
1221         Reviewed by Alexey Proskuryakov.
1222
1223         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1224         (WTR::uninstallFakeHelvetica): Pass nullptr into
1225         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1226
1227 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1228
1229         [LFC] Initialize ICB's style with fixed width/height.
1230         https://bugs.webkit.org/show_bug.cgi?id=194188
1231
1232         Reviewed by Antti Koivisto.
1233
1234         * LayoutReloaded/misc/LFC-passing-tests.txt:
1235
1236 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1237
1238         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1239         https://bugs.webkit.org/show_bug.cgi?id=194185
1240
1241         Reviewed by Antti Koivisto.
1242
1243         * LayoutReloaded/misc/LFC-passing-tests.txt:
1244
1245 2018-12-16  Darin Adler  <darin@apple.com>
1246
1247         Convert additional String::format clients to alternative approaches
1248         https://bugs.webkit.org/show_bug.cgi?id=192746
1249
1250         Reviewed by Alexey Proskuryakov.
1251
1252         * WebKitTestRunner/TestController.cpp:
1253         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1254         as an intermediate in code that ultimately constructs a WTF::String.
1255         (WTR::userMediaOriginHash): Use makeString.
1256         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1257         (WTR::TestController::didPerformClientRedirect): Ditto.
1258         (WTR::TestController::didPerformServerRedirect): Ditto.
1259         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1260
1261 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [ews-build] Add unit test to verify builder keys
1264         https://bugs.webkit.org/show_bug.cgi?id=194152
1265
1266         Reviewed by Lucas Forschler.
1267
1268         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1269         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1270
1271 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1272
1273         [LFC] Expand tests coverage (12 new tests -> 787)
1274
1275         Unreviewed test gardening.
1276
1277         * LayoutReloaded/misc/LFC-passing-tests.txt:
1278
1279 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1280
1281         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1282         https://bugs.webkit.org/show_bug.cgi?id=194163
1283
1284         Reviewed by Simon Fraser.
1285
1286         775
1287
1288         * LayoutReloaded/misc/LFC-passing-tests.txt:
1289
1290 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1291
1292         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1293         https://bugs.webkit.org/show_bug.cgi?id=194140
1294         <rdar://problem/47728098>
1295
1296         Reviewed by Tim Horton.
1297
1298         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1299         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1300         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1301
1302         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1303         test to induce an IPC deadlock when presenting a modal alert during touch start.
1304
1305         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1306         * WebKitTestRunner/TestController.cpp:
1307         (WTR::runJavaScriptAlert):
1308
1309         Add a client callback function for running JavaScript alerts.
1310
1311         (WTR::TestController::createOtherPage):
1312         (WTR::TestController::generateContextConfiguration const):
1313
1314         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1315         the fix in this patch.
1316
1317         (WTR::TestController::createWebViewWithOptions):
1318
1319         Plumb TestOptions to generateContextConfiguration.
1320
1321         (WTR::TestController::resetPreferencesToConsistentValues):
1322         (WTR::TestController::resetStateToConsistentValues):
1323         (WTR::updateTestOptionsFromTestHeader):
1324         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1325         (WTR::TestController::handleJavaScriptAlert):
1326         * WebKitTestRunner/TestController.h:
1327         * WebKitTestRunner/TestInvocation.cpp:
1328         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1329         * WebKitTestRunner/TestOptions.h:
1330         (WTR::TestOptions::hasSameInitializationOptions const):
1331
1332 2019-02-01  Chris Dumez  <cdumez@apple.com>
1333
1334         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1335         https://bugs.webkit.org/show_bug.cgi?id=193740
1336         <rdar://problem/47527267>
1337
1338         Reviewed by Alex Christensen.
1339
1340         Add API test coverage.
1341
1342         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1343
1344 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1345
1346         [ews-app] Add display name field to BuilderMapping model
1347         https://bugs.webkit.org/show_bug.cgi?id=194153
1348
1349         Reviewed by Lucas Forschler.
1350
1351         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1352         (BuilderMapping):
1353
1354 2019-02-01  Youenn Fablet  <youenn@apple.com>
1355
1356         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1357         https://bugs.webkit.org/show_bug.cgi?id=194155
1358
1359         Reviewed by Eric Carlson.
1360
1361         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1362         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1363         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1364
1365 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1366
1367         [LFC] Adjust replaced element's intrinsic ratio
1368         https://bugs.webkit.org/show_bug.cgi?id=194154
1369
1370         Reviewed by Antti Koivisto.
1371
1372         761
1373
1374         * LayoutReloaded/misc/LFC-passing-tests.txt:
1375
1376 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1377
1378         [WPE] Show test results in minibrowser
1379         https://bugs.webkit.org/show_bug.cgi?id=194150
1380
1381         Reviewed by Žan Doberšek.
1382
1383         * Scripts/webkitpy/port/wpe.py:
1384         (WPEPort.show_results_html_file):
1385
1386 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1387
1388         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1389         https://bugs.webkit.org/show_bug.cgi?id=194151
1390
1391         Reviewed by Žan Doberšek.
1392
1393         ALT + <- go back
1394         ALT + -> go forward
1395
1396         * MiniBrowser/wpe/main.cpp:
1397         (main):
1398
1399 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1400
1401         [LFC] Set intrinsic size on Layout::Replaced
1402         https://bugs.webkit.org/show_bug.cgi?id=194139
1403
1404         Reviewed by Antti Koivisto.
1405
1406         744
1407
1408         * LayoutReloaded/misc/LFC-passing-tests.txt:
1409
1410 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1411
1412         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1413         https://bugs.webkit.org/show_bug.cgi?id=194146
1414
1415         Reviewed by Xabier Rodriguez-Calvar.
1416
1417         It allows to open relative paths.
1418
1419         * MiniBrowser/wpe/main.cpp:
1420         (main):
1421
1422 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1423
1424         Update flakiness dashboard configuration after recent queue changes
1425         https://bugs.webkit.org/show_bug.cgi?id=194127
1426
1427         Rubber-stamped by Aakash Jain.
1428
1429         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1430
1431         * TestResultServer/static-dashboards/builders.jsonp:
1432
1433 2019-01-31  Youenn Fablet  <youenn@apple.com>
1434
1435         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1436         https://bugs.webkit.org/show_bug.cgi?id=194106
1437         <rdar://problem/47676333>
1438
1439         Reviewed by Ryosuke Niwa.
1440
1441         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1442         (TestWebKitAPI::didFinishNavigation):
1443         (TestWebKitAPI::TEST):
1444         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1445
1446 2019-01-31  Chris Dumez  <cdumez@apple.com>
1447
1448         Page zoom level is lost after a process swap or a crash
1449         https://bugs.webkit.org/show_bug.cgi?id=194105
1450         <rdar://problem/47610781>
1451
1452         Reviewed by Alex Christensen.
1453
1454         Add API test coverage.
1455
1456         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1457         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1458
1459 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1460
1461         Revert r238819 which is unneeded and caused a performance regression.
1462         https://bugs.webkit.org/show_bug.cgi?id=192272
1463         <rdar://problem/46664625>
1464
1465         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1466         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1467         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1468
1469 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1470
1471         Formalize WebKitAdditions mechanism of LoadOptimizer
1472         https://bugs.webkit.org/show_bug.cgi?id=193886
1473         <rdar://problem/47696809>
1474
1475         Reviewed by Brent Fulgham.
1476
1477         * MiniBrowser/MiniBrowser.entitlements:
1478         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1479
1480 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1481
1482         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1483         https://bugs.webkit.org/show_bug.cgi?id=194090
1484
1485         Reviewed by Antti Koivisto.
1486
1487         * LayoutReloaded/misc/LFC-passing-tests.txt:
1488
1489 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1490
1491         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1492         https://bugs.webkit.org/show_bug.cgi?id=194074
1493
1494         Reviewed by Antti Koivisto.
1495
1496         * LayoutReloaded/misc/LFC-passing-tests.txt:
1497
1498 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1499
1500         [LFC][BFC] Add support for block level replaced box.
1501         https://bugs.webkit.org/show_bug.cgi?id=194071
1502
1503         Reviewed by Antti Koivisto.
1504
1505         * LayoutReloaded/misc/LFC-passing-tests.txt:
1506
1507 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1508
1509         Fix WebKitTestRunner's testPath with Windows full paths
1510         https://bugs.webkit.org/show_bug.cgi?id=194012
1511
1512         Reviewed by Alex Christensen.
1513
1514         updateTestOptionsFromTestHeader failed to open test files because
1515         testPath returned wrong file paths. It returned a path "/C:/..."
1516         if a URL "file:///C:/..." was given.
1517
1518         * WebKitTestRunner/TestController.cpp:
1519         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1520
1521 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1522
1523         [WPE] Bump font related dependencies to match the GTK+ port
1524         https://bugs.webkit.org/show_bug.cgi?id=194017
1525
1526         Reviewed by Žan Doberšek.
1527
1528         * wpe/jhbuild.modules:
1529         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1530         * wpe/patches/icudata-stdlibs.patch: Added.
1531
1532 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1533
1534         Enable swipe tests on iOS
1535         https://bugs.webkit.org/show_bug.cgi?id=194076
1536
1537         Reviewed by Geoffrey Garen.
1538
1539         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1540         it causes a debug assertion failure in runUIScript.
1541
1542         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1543         (WTR::UIScriptController::beginBackSwipe):
1544         (WTR::UIScriptController::completeBackSwipe):
1545
1546 2019-01-30  Keith Rollin  <krollin@apple.com>
1547
1548         Use correct printf format specifier
1549         https://bugs.webkit.org/show_bug.cgi?id=194062
1550         <rdar://problem/47686167>
1551
1552         Reviewed by Alexey Proskuryakov.
1553
1554         LayoutTestSpellChecker.mm is trying to format a variable of type
1555         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1556         actually an unsigned long long. Fix this by formatting with %llu.
1557
1558         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1559         (-[LayoutTestTextCheckingResult description]):
1560
1561 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1562
1563         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1564         https://bugs.webkit.org/show_bug.cgi?id=193979
1565
1566         Reviewed by Wenson Hsieh.
1567
1568         Fix the test for iOS. Make the test work with iOS UA string.
1569
1570         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1571
1572 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1573
1574         Replace High Sierra LLINT CLoop bot due to hardware failure
1575         https://bugs.webkit.org/show_bug.cgi?id=194066
1576
1577         Reviewed by Aakash Jain.
1578
1579         * BuildSlaveSupport/build.webkit.org-config/config.json:
1580
1581 2019-01-30  Keith Rollin  <krollin@apple.com>
1582
1583         [NSDragItem init] is unavailable
1584         https://bugs.webkit.org/show_bug.cgi?id=194059
1585         <rdar://problem/47685715>
1586
1587         Reviewed by Wenson Hsieh.
1588
1589         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1590         DumpRenderTree and TestWebKitAPI, which both try to create an
1591         NSDragItem in a manner that invokes this method. Address this by using
1592         -initWithPasteboardWriter instead.
1593
1594         Note that the parameter passed to initWithPasteboardWriter is likely
1595         incorrect. In both cases, the object passed does not conform to
1596         NSPasteboardWriting. However, with this fix, we're no worse off than
1597         before, and can now perform builds with newer compilers and SDKs until
1598         a real fix can be crafted. That work is tracked in
1599         https://bugs.webkit.org/show_bug.cgi?id=194060
1600
1601         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1602         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1603         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1604         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1605
1606 2019-01-30  Daniel Bates  <dabates@apple.com>
1607
1608         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1609         https://bugs.webkit.org/show_bug.cgi?id=192824
1610         <rdar://problem/47100332>
1611
1612         Reviewed by Wenson Hsieh.
1613
1614         Fix a bug where the wrong usage code was used for F13 thru F24.
1615
1616         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1617         (keyCodeForDOMFunctionKey):
1618
1619 2019-01-30  Chris Dumez  <cdumez@apple.com>
1620
1621         Regression(PSON) Load hang can occur on history navigation
1622         https://bugs.webkit.org/show_bug.cgi?id=194030
1623         <rdar://problem/47656939>
1624
1625         Reviewed by Antti Koivisto.
1626
1627         Add API test coverage.
1628
1629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1630
1631 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1632
1633         [LFC] Expand tests coverage.
1634
1635         Unreviewed test gardening.
1636
1637         * LayoutReloaded/misc/LFC-passing-tests.txt:
1638
1639 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1640
1641         [Flatpak] Add openjpeg support
1642         https://bugs.webkit.org/show_bug.cgi?id=194019
1643
1644         Reviewed by Michael Catanzaro.
1645
1646         * flatpak/org.webkit.CommonModules.yaml:
1647
1648 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1649
1650         Unreviewed, rolling out r240708.
1651         https://bugs.webkit.org/show_bug.cgi?id=194022
1652
1653         It broke WPE build (Requested by KaL on #webkit).
1654
1655         Reverted changeset:
1656
1657         "[WPE] Bump font related dependencies to match the GTK+ port"
1658         https://bugs.webkit.org/show_bug.cgi?id=194017
1659         https://trac.webkit.org/changeset/240708
1660
1661 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1662
1663         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1664         https://bugs.webkit.org/show_bug.cgi?id=194001
1665
1666         Reviewed by Antti Koivisto.
1667
1668         * LayoutReloaded/misc/LFC-passing-tests.txt:
1669
1670 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1671
1672         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1673         https://bugs.webkit.org/show_bug.cgi?id=194020
1674
1675         Reviewed by Antti Koivisto.
1676
1677         * LayoutReloaded/misc/LFC-passing-tests.txt:
1678
1679 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1680
1681         AX: Support color well on iOS
1682         https://bugs.webkit.org/show_bug.cgi?id=194010
1683
1684         Reviewed by Joanmarie Diggs.
1685
1686         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1687         (WTR::AccessibilityUIElement::stringAttributeValue):
1688
1689 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1690
1691         [WPE] Bump font related dependencies to match the GTK+ port
1692         https://bugs.webkit.org/show_bug.cgi?id=194017
1693
1694         Reviewed by Žan Doberšek.
1695
1696         * wpe/jhbuild.modules:
1697         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1698         * wpe/patches/icudata-stdlibs.patch: Added.
1699
1700 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1701
1702         [Mac] Update window scale API usage
1703         https://bugs.webkit.org/show_bug.cgi?id=193991
1704         rdar://problem/47614795
1705
1706         Reviewed by Tim Horton.
1707
1708         * DumpRenderTree/mac/DumpRenderTree.mm:
1709         (changeWindowScaleIfNeeded):
1710         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1711         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1712         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1713
1714 2019-01-29  Chris Dumez  <cdumez@apple.com>
1715
1716         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1717         https://bugs.webkit.org/show_bug.cgi?id=193977
1718         <rdar://problem/47643716>
1719
1720         Reviewed by Geoff Garen.
1721
1722         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1723         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1724         to the previous provisional committing *before* we make the last load. 
1725
1726         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1727
1728 2019-01-29  Youenn Fablet  <youenn@apple.com>
1729
1730         Adopt new SPI to evaluate server certificate trust
1731         https://bugs.webkit.org/show_bug.cgi?id=193355
1732
1733         Reviewed by Alex Christensen.
1734
1735         Add infrastructure to handle HTTPS server trust evaluation testing.
1736
1737         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1738         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1739         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1740         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1741         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1742         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1743         * WebKitTestRunner/TestController.cpp:
1744         (WTR::TestController::resetPreferencesToConsistentValues):
1745         (WTR::TestController::didReceiveAuthenticationChallenge):
1746         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1747         * WebKitTestRunner/TestController.h:
1748         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1749         * WebKitTestRunner/TestInvocation.cpp:
1750         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1751         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1752         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1753
1754 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1755
1756         [ews-build] Add build step to print bot Configuration
1757         https://bugs.webkit.org/show_bug.cgi?id=193887
1758
1759         Reviewed by Lucas Forschler.
1760
1761         * BuildSlaveSupport/ews-build/steps.py:
1762         (PrintConfiguration): Build step to print configuration.
1763         * BuildSlaveSupport/ews-build/factories.py:
1764
1765 2019-01-29  Chris Dumez  <cdumez@apple.com>
1766
1767         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1768         https://bugs.webkit.org/show_bug.cgi?id=193967
1769         <rdar://problem/47635348>
1770
1771         Reviewed by Alex Christensen.
1772
1773         Add API test coverage.
1774
1775         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1776         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1777
1778 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1779
1780         [ews-app] Handle incoming results data
1781         https://bugs.webkit.org/show_bug.cgi?id=193973
1782
1783         Reviewed by Lucas Forschler.
1784
1785         * BuildSlaveSupport/ews-app/ews/views/results.py:
1786
1787 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1788
1789         [ews-app] Make the results url generic
1790         https://bugs.webkit.org/show_bug.cgi?id=193928
1791
1792         Reviewed by Lucas Forschler.
1793
1794         * BuildSlaveSupport/ews-app/ews/urls.py:
1795
1796 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1797
1798         [ews-build] Configure buildbot to send events to ews-app
1799         https://bugs.webkit.org/show_bug.cgi?id=193968
1800
1801         Reviewed by Lucas Forschler.
1802
1803         * BuildSlaveSupport/ews-build/events.py: Added.
1804         * BuildSlaveSupport/ews-build/master.cfg:
1805
1806 2019-01-29  Keith Rollin  <krollin@apple.com>
1807
1808         Add .xcfilelists to Run Script build phases
1809         https://bugs.webkit.org/show_bug.cgi?id=193792
1810         <rdar://problem/47201785>
1811
1812         Reviewed by Alex Christensen.
1813
1814         As part of supporting XCBuild, update the necessary Run Script build
1815         phases in their Xcode projects to refer to their associated
1816         .xcfilelist files.
1817
1818         Note that the addition of these files bumps the Xcode project version
1819         number to something that's Xcode 10 compatible. This change means that
1820         older versions of the Xcode IDE can't read these projects. Nor can it
1821         fully load workspaces that refer to these projects (the updated
1822         projects are shown as non-expandable placeholders). `xcodebuild` can
1823         still build these projects; it's just that the IDE can't open them.
1824
1825         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1826         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1827
1828 2019-01-29  John Wilander  <wilander@apple.com>
1829
1830         Add data abstraction and validation for Ad Click Attribution
1831         https://bugs.webkit.org/show_bug.cgi?id=193916
1832         <rdar://problem/47603481>
1833
1834         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1835
1836         Ad click attribution has two steps. First, the storage of an ad
1837         campaign ID for a click that takes the user to a destination
1838         site. Second, a conversion on the destination site that can be
1839         attributed to the ad click.
1840
1841         This patch adds a class that represents a request for ad click
1842         attribution. Validation makes sure that the bits of entropy
1843         reported through this mechanism is limited.
1844
1845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1846         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1847         (TestWebKitAPI::TEST):
1848
1849 2019-01-29  Chris Dumez  <cdumez@apple.com>
1850
1851         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1852         https://bugs.webkit.org/show_bug.cgi?id=193932
1853         <rdar://problem/47598947>
1854
1855         Reviewed by Brady Eidson.
1856
1857         Add API test coverage.
1858
1859         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1860
1861 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1862
1863         Adding new passing LFC tests.
1864
1865         Unreviewed test gardening.
1866
1867         * LayoutReloaded/misc/LFC-passing-tests.txt:
1868
1869 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1870
1871         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1872         https://bugs.webkit.org/show_bug.cgi?id=193964
1873
1874         Reviewed by Antti Koivisto.
1875
1876         * LayoutReloaded/misc/LFC-passing-tests.txt:
1877
1878 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1879
1880         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1881         https://bugs.webkit.org/show_bug.cgi?id=193954
1882
1883         Reviewed by Antti Koivisto.
1884
1885         * LayoutReloaded/misc/LFC-passing-tests.txt:
1886
1887 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1888
1889         WebDriver: add support for running subtests
1890         https://bugs.webkit.org/show_bug.cgi?id=193904
1891
1892         Reviewed by Michael Catanzaro.
1893
1894         pytest already supports it by passing test.py::subtest, so we can do the same.
1895
1896         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1897         (get_item_name): Made this global.
1898         (CollectRecorder.__init__): Receive the parameter to ignore.
1899         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1900         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1901         (collect): Add parameter to ignore.
1902         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1903         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1904         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1905         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1906         (WebDriverTestRunnerSelenium.run): Ditto.
1907         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1908         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1909         (WebDriverTestRunnerW3C.run): Ditto.
1910
1911 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1912
1913         User agent string override for navigator.userAgent should be site specific quirks
1914         https://bugs.webkit.org/show_bug.cgi?id=193950
1915
1916         Reviewed by Brent Fulgham.
1917
1918         Updated per the _WKWebsitePolicies rename.
1919
1920         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1921         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1922
1923 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1924
1925         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1926         https://bugs.webkit.org/show_bug.cgi?id=193941
1927
1928         Reviewed by Alex Christensen.
1929
1930         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1931         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1932         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1933         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1934         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1935         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1936         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1937         * TestWebKitAPI/Tests/WTF/Time.cpp:
1938         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1939         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1940         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1941         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1942
1943 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1944
1945         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1946
1947         * Scripts/webkitpy/common/config/contributors.json:
1948
1949 2019-01-28  Andy Estes  <aestes@apple.com>
1950
1951         [watchOS] Enable Parental Controls content filtering
1952         https://bugs.webkit.org/show_bug.cgi?id=193939
1953         <rdar://problem/46641912>
1954
1955         Reviewed by Ryosuke Niwa.
1956
1957         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1958
1959 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1960
1961         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1962         <https://webkit.org/b/193884>
1963
1964         Reviewed by Jiewen Tan.
1965
1966         * Scripts/webkitpy/style/checkers/cpp.py:
1967         (check_language): Add LocalAuthentication to
1968         `frameworks_with_soft_links`.
1969
1970 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1971
1972         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1973         https://bugs.webkit.org/show_bug.cgi?id=193891
1974
1975         Reviewed by Ross Kirsling.
1976
1977         There were three problems in window sizes of WebView and the host window.
1978         1. The sizes of pixel image output were incorrect.
1979         2. The host window is going to appear after window.resize was invoked.
1980         3. window.resize resized only the host window, not WebView.
1981
1982         This change solves them with a following approach.
1983         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1984         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1985            as well as DumpRenderTree in order to match the client area and the window area.
1986         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1987         d. PlatformWebView::setWindowFrame changes both window sizes.
1988         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1989
1990         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1991         (WTR::PlatformWebView::PlatformWebView): Create the host window
1992         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1993         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1994         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1995
1996 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1997
1998         [ews-app] Add method to save Step data to database
1999         https://bugs.webkit.org/show_bug.cgi?id=193890
2000
2001         Reviewed by Lucas Forschler.
2002
2003         * BuildSlaveSupport/ews-app/ews/models/step.py:
2004         (Step.save_step): Method to save step data.
2005         (Step.update_step): Method to update step data.
2006         (Step.get_existing_step): Method to fetch existing step from database.
2007         (Step.is_valid_result): Method to validate valid step result.
2008
2009 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2010
2011         [ews-app] Add method to save Build data to database
2012         https://bugs.webkit.org/show_bug.cgi?id=193735
2013
2014         Reviewed by Lucas Forschler.
2015
2016         * BuildSlaveSupport/ews-app/ews/models/build.py:
2017         (Build.save_build): Method to save build information to database.
2018         (Build.get_existing_build): Method to fetch existing build from database.
2019         (Build.is_valid_result): Method to validate build result.
2020         * BuildSlaveSupport/ews-app/ews/common/util.py:
2021         (is_valid_int_id): Method to validate valid id.
2022
2023 2019-01-28  Chris Dumez  <cdumez@apple.com>
2024
2025         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2026         https://bugs.webkit.org/show_bug.cgi?id=193915
2027         <rdar://problem/47560907>
2028
2029         Reviewed by Alex Christensen.
2030
2031         Add API test coverage.
2032
2033         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2034
2035 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2036
2037         [ews-app] Rename id variables
2038         https://bugs.webkit.org/show_bug.cgi?id=193883
2039
2040         Reviewed by Lucas Forschler.
2041
2042         * BuildSlaveSupport/ews-app/ews/models/build.py:
2043         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2044         * BuildSlaveSupport/ews-app/ews/models/step.py:
2045         * BuildSlaveSupport/ews-app/ews/urls.py:
2046         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2047         * BuildSlaveSupport/ews-app/ews/views/results.py:
2048         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2049
2050 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2051
2052         [ews-app] Allow certain fields to be empty
2053         https://bugs.webkit.org/show_bug.cgi?id=193892
2054
2055         Reviewed by Lucas Forschler.
2056
2057         * BuildSlaveSupport/ews-app/ews/models/build.py:
2058         * BuildSlaveSupport/ews-app/ews/models/step.py:
2059
2060 2019-01-28  Rob Buis  <rbuis@igalia.com>
2061
2062         Update MIME type parser
2063         https://bugs.webkit.org/show_bug.cgi?id=180526
2064
2065         Reviewed by Frédéric Wang.
2066
2067         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2068         (TestWebKitAPI::TEST):
2069
2070 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2071
2072         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2073         https://bugs.webkit.org/show_bug.cgi?id=193896
2074
2075         Reviewed by Antti Koivisto.
2076
2077         * LayoutReloaded/misc/LFC-passing-tests.txt:
2078
2079 2018-12-15  Darin Adler  <darin@apple.com>
2080
2081         Replace many uses of String::format with more type-safe alternatives
2082         https://bugs.webkit.org/show_bug.cgi?id=192742
2083
2084         Reviewed by Mark Lam.
2085
2086         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2087         (WTR::cacheTestRunnerCallback): Use makeString.
2088         * WebKitTestRunner/TestController.cpp:
2089         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2090         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2091
2092 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2093
2094         Use a load optimizer for some sites
2095         https://bugs.webkit.org/show_bug.cgi?id=193881
2096         <rdar://problem/46325455>
2097
2098         Reviewed by Brent Fulgham.
2099
2100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2101         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2102
2103 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2104
2105         AX: Introduce a static accessibility tree
2106         https://bugs.webkit.org/show_bug.cgi?id=193348
2107         <rdar://problem/47203295>
2108
2109         Reviewed by Ryosuke Niwa.
2110
2111         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2112
2113 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2114
2115         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2116         https://bugs.webkit.org/show_bug.cgi?id=193867
2117
2118         Reviewed by Antti Koivisto.
2119
2120         * LayoutReloaded/misc/LFC-passing-tests.txt:
2121
2122 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2123
2124         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2125         https://bugs.webkit.org/show_bug.cgi?id=193865
2126
2127         Reviewed by Antti Koivisto.
2128
2129         * LayoutReloaded/misc/LFC-passing-tests.txt:
2130
2131 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2132
2133         Need a mechanism to override navigator.userAgent
2134         https://bugs.webkit.org/show_bug.cgi?id=193762
2135         <rdar://problem/47504939>
2136
2137         Reviewed by Brent Fulgham.
2138
2139         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2140
2141         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2142         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2143         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2144
2145 2019-01-25  Dean Jackson  <dino@apple.com>
2146
2147         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2148         https://bugs.webkit.org/show_bug.cgi?id=193831
2149         <rdar://problem/47399263>
2150
2151         Reviewed by Chris Dumez.
2152
2153         Two new tests that exercise cross-origin and same-origin System
2154         Previews.
2155
2156         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2157
2158 2019-01-25  Keith Rollin  <krollin@apple.com>
2159
2160         Update Xcode projects with "Check .xcfilelists" build phase
2161         https://bugs.webkit.org/show_bug.cgi?id=193790
2162         <rdar://problem/47201374>
2163
2164         Reviewed by Alex Christensen.
2165
2166         Support for XCBuild includes specifying inputs and outputs to various
2167         Run Script build phases. These inputs and outputs are specified as
2168         .xcfilelist files. Once created, these .xcfilelist files need to be
2169         kept up-to-date. In order to check that they are up-to-date or not,
2170         add an Xcode build step that invokes an external script that performs
2171         the checking. If the .xcfilelists are found to be out-of-date, update
2172         them, halt the build, and instruct the developer to restart the build
2173         with up-to-date files.
2174
2175         At this time, the checking and regenerating is performed only if the
2176         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2177         who want to use this facility can set this variable and test out the
2178         checking/regenerating. Once it seems like there are no egregious
2179         issues that upset a developer's workflow, we'll unconditionally enable
2180         this facility.
2181
2182         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2183         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2184         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2185         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2186
2187 2019-01-25  Keith Rollin  <krollin@apple.com>
2188
2189         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2190         https://bugs.webkit.org/show_bug.cgi?id=193781
2191         <rdar://problem/47201153>
2192
2193         Reviewed by Alex Christensen.
2194
2195         Part of generating the .xcfilelists used as part of adopting XCBuild
2196         includes running `make DerivedSources.make` from a standalone script.
2197         It’s important for this invocation to have the same environment as
2198         when the actual build invokes `make DerivedSources.make`. If the
2199         environments are different, then the two invocations will provide
2200         different results. In order to get the same environment in the
2201         standalone script, have the script launch xcodebuild targeting the
2202         "Apply Configuration to XCFileLists" build target, which will then
2203         re-invoke our standalone script. The script is now running again, this
2204         time in an environment with all workspace, project, target, xcconfig
2205         and other environment variables established.
2206
2207         The "Apply Configuration to XCFileLists" build target accomplishes
2208         this task via a small embedded shell script that consists only of:
2209
2210             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2211
2212         The process that invokes "Apply Configuration to XCFileLists" first
2213         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2214         evaluated and exports it into the shell environment. When xcodebuild
2215         is invoked, it inherits the value of this variable and can `eval` the
2216         contents of that variable. Our external standalone script can then set
2217         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2218         of command-line parameters needed to restart itself in the appropriate
2219         state.
2220
2221         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2222         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2223
2224 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2225
2226         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2227         https://bugs.webkit.org/show_bug.cgi?id=193802
2228         <rdar://problem/46010580>
2229
2230         Reviewed by Andy Estes.
2231
2232         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2233         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2234         (TEST):
2235
2236 2019-01-25  Daniel Bates  <dabates@apple.com>
2237
2238         [iOS] uiController.keyDown() does not translate Control modified key
2239         https://bugs.webkit.org/show_bug.cgi?id=192898
2240
2241         Reviewed by Wenson Hsieh.
2242
2243         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2244         key translation, as applicable. Among other cases, key translation occurs when performing
2245         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2246         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2247         human pressing down and releasing key(s) using a hardware keyboard.
2248
2249         * WebKitTestRunner/ios/HIDEventGenerator.h:
2250         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2251         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2252
2253         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2254         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2255         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2256         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2257         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2258         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2259         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2260         (-[HIDEventGenerator longPress:completionBlock:]):
2261         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2262         Update code for above renaming.
2263
2264         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2265         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2266
2267         (-[HIDEventGenerator keyDown:]): Added.
2268         (-[HIDEventGenerator keyUp:]): Added.
2269         (-[HIDEventGenerator keyPress:completionBlock:]):
2270         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2271         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2272         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2273         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2274         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2275         (WTR::parseModifier): Deleted.
2276
2277 2019-01-25  Keith Rollin  <krollin@apple.com>
2278
2279         Complete the implementation of generate-xcfilelists
2280         https://bugs.webkit.org/show_bug.cgi?id=193782
2281
2282         Reviewed by Alex Christensen.
2283
2284         A preliminary version of generate-xcfilelists was added in r238008.
2285         This patch updates that script in order to:
2286
2287         - Support checking of .xcfilelists
2288         - Perform better execution of `make DerivedSources.make` by
2289           relaunching generate-xcfilelists under xcodebuild
2290         - Support incremental generation and checking of .xcfilelists
2291         - Support supplementary .xcfilelists files from WebKitAdditions
2292         - Support being wrapped by parallel version of generate-xcfilelists in
2293           Internal that adds support for (re)generating WebKit projects in
2294           that repo.
2295         - Support builds that have been performed in WebKitBuild as well as
2296           ~/Library/Developer/code/DerivedData
2297         - Increase robustness and debugging facilities.
2298
2299         * Scripts/generate-xcfilelists:
2300
2301 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2302
2303         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2304         https://bugs.webkit.org/show_bug.cgi?id=193297
2305         <rdar://problem/47158841>
2306
2307         Unreviewed test case fix.
2308
2309         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2310         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2311
2312         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2313         (TEST):
2314
2315 2019-01-25  Keith Rollin  <krollin@apple.com>
2316
2317         Update existing .xcfilelists
2318         https://bugs.webkit.org/show_bug.cgi?id=193791
2319         <rdar://problem/47201706>
2320
2321         Reviewed by Alex Christensen.
2322
2323         Many .xcfilelist files were added in r238824 in order to support
2324         XCBuild. Update these with recent changes to the set of build files
2325         and with the current generate-xcfilelist script.
2326
2327         * DumpRenderTree/DerivedSources-input.xcfilelist:
2328         * DumpRenderTree/DerivedSources-output.xcfilelist:
2329         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2330         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2331
2332 2019-01-25  Keith Rollin  <krollin@apple.com>
2333
2334         Fix missing dependencies in extract-dependencies-from-makefile
2335         https://bugs.webkit.org/show_bug.cgi?id=193783
2336         <rdar://problem/47201571>
2337
2338         Reviewed by Alex Christensen.
2339
2340         The extract-dependencies-from-makefile script generates .xcfilelists
2341         for XCBuild by invoking a makefile in --debug mode, parsing the
2342         dependency information in the output, and extracting information
2343         regarding targets and dependents. However, the way `make` emits this
2344         dependency information is not rigorous, and so we need to determine
2345         what lines to look for and parse by trial and error. This approach
2346         didn't coriginally atch all the information we needed to collect, so
2347         update the script to look for the additional lines we now know to look
2348         for.
2349
2350         * Scripts/extract-dependencies-from-makefile:
2351         (Parser):
2352         (Parser.addTarget):
2353         (Parser.addPrereq):
2354         (Parser.doParse):
2355
2356 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2357
2358         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2359         https://bugs.webkit.org/show_bug.cgi?id=193297
2360         <rdar://problem/47158841>
2361
2362         Reviewed by Alex Christensen.
2363
2364         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2365             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2366         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2367         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2368         activating the message used to trigger the callback when it is set.
2369
2370 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2371
2372         WKWebView.goBack should reload if there is a safe browsing warning
2373         https://bugs.webkit.org/show_bug.cgi?id=193805
2374         <rdar://problem/46908216>
2375
2376         Reviewed by Geoff Garen.
2377
2378         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2379         (+[Simple3LookupContext sharedLookupContext]):
2380         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2381         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2382         (TEST):
2383
2384 2019-01-25  Chris Dumez  <cdumez@apple.com>
2385
2386         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2387         https://bugs.webkit.org/show_bug.cgi?id=193788
2388         <rdar://problem/47531231>
2389
2390         Reviewed by Alex Christensen.
2391
2392         Add API test coverage.
2393
2394         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2395         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2396
2397 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2398
2399         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2400         https://bugs.webkit.org/show_bug.cgi?id=193771
2401
2402         Unreviewed infrastructure fix.
2403
2404         * Scripts/webkitpy/port/darwin.py:
2405         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2406
2407 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2408
2409         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2410
2411 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2412
2413         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2414
2415         * Scripts/webkitpy/common/config/contributors.json:
2416
2417 2019-01-25  Chris Dumez  <cdumez@apple.com>
2418
2419         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2420         https://bugs.webkit.org/show_bug.cgi?id=193779
2421         <rdar://problem/46170903>
2422
2423         Reviewed by Antti Koivisto.
2424
2425         Add API test that quickly navigates forward to a previous process without waiting for it to
2426         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2427         the process' previous page when reconnecting the it for the forward navigation.
2428
2429         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2430
2431 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2432
2433         Need a way for JavaScript (or bundle) code to participate in undo
2434         https://bugs.webkit.org/show_bug.cgi?id=190009
2435         <rdar://problem/44807048>
2436
2437         Reviewed by Ryosuke Niwa.
2438
2439         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2440         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2441
2442         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2443         (WTR::UIScriptController::lastUndoLabel const):
2444         (WTR::UIScriptController::firstRedoLabel const):
2445         (WTR::UIScriptController::platformUndoManager const):
2446         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2447         (WTR::UIScriptController::lastUndoLabel const):
2448         (WTR::UIScriptController::firstRedoLabel const):
2449         (WTR::UIScriptController::platformUndoManager const):
2450         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2451         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2452         (WTR::UIScriptController::lastUndoLabel const):
2453         (WTR::UIScriptController::firstRedoLabel const):
2454         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2455         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2456         (WTR::UIScriptController::lastUndoLabel const):
2457         (WTR::UIScriptController::firstRedoLabel const):
2458         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2459         (WTR::UIScriptController::platformUndoManager const):
2460         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2461         (WTR::UIScriptController::platformUndoManager const):
2462
2463 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2464
2465         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2466         https://bugs.webkit.org/show_bug.cgi?id=193824
2467
2468         Reviewed by Antti Koivisto.
2469
2470         * LayoutReloaded/misc/LFC-passing-tests.txt:
2471
2472 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2473
2474         Update macOS JSC bot configurations
2475         https://bugs.webkit.org/show_bug.cgi?id=193739
2476
2477         Reviewed by Alexey Proskuryakov.
2478
2479         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2481         (BubbleQueueServer): Move JSC EWS to Mojave section.
2482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2483         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2484         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2485
2486 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2487
2488         [Win][WebKitTestRunner] Implement EventSenderProxy
2489         https://bugs.webkit.org/show_bug.cgi?id=193755
2490
2491         Reviewed by Don Olmstead.
2492
2493         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2494         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2495         (WTR::EventSenderProxy::dispatchMessage):
2496         (WTR::EventSenderProxy::EventSenderProxy):
2497         (WTR::EventSenderProxy::mouseDown):
2498         (WTR::EventSenderProxy::mouseUp):
2499         (WTR::EventSenderProxy::mouseMoveTo):
2500         (WTR::EventSenderProxy::mouseScrollBy):
2501         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2502
2503 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2504
2505         Unreviewed fix for API test failure after r240437.
2506
2507         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2508
2509         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2510
2511 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2512
2513         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2514         https://bugs.webkit.org/show_bug.cgi?id=193787
2515         <rdar://problem/47497634>
2516
2517         Reviewed by Alexey Proskuryakov.
2518
2519         * Scripts/webkitdirs.pm:
2520         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2521
2522 2019-01-24  Truitt Savell  <tsavell@apple.com>
2523
2524         Unreviewed, rolling out r240446.
2525
2526         Casued 5 API failures
2527
2528         Reverted changeset:
2529
2530         "Activate the WebResourceLoadStatisticsStore in the
2531         NetworkProcess and deactivate it in the UIProcess."
2532         https://bugs.webkit.org/show_bug.cgi?id=193297
2533         https://trac.webkit.org/changeset/240446
2534
2535 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2536
2537         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2538         https://bugs.webkit.org/show_bug.cgi?id=193741
2539         <rdar://problem/47135030>
2540
2541         Reviewed by Antti Koivisto and Simon Fraser.
2542
2543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2544         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2545         (TestWebKitAPI::TEST):
2546
2547 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2548
2549         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2550         https://bugs.webkit.org/show_bug.cgi?id=193297
2551         <rdar://problem/47158841>
2552
2553         Reviewed by Alex Christensen.
2554
2555         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2556         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2557         activating the message used to trigger the callback when it is set.
2558
2559 2019-01-24  John Wilander  <wilander@apple.com>
2560
2561         Add Ad Click Attribution as an internal/experimental feature
2562         https://bugs.webkit.org/show_bug.cgi?id=193685
2563         <rdar://problem/47450399>
2564
2565         Reviewed by Brent Fulgham.
2566
2567         Added test option adClickAttributionEnabled.
2568
2569         * DumpRenderTree/TestOptions.cpp:
2570         (TestOptions::TestOptions):
2571         * DumpRenderTree/TestOptions.h:
2572         * DumpRenderTree/mac/DumpRenderTree.mm:
2573         (setWebPreferencesForTestOptions):
2574
2575 2019-01-24  Antti Koivisto  <antti@apple.com>
2576
2577         [PSON] Flash on back navigation on Mac
2578         https://bugs.webkit.org/show_bug.cgi?id=193716
2579         <rdar://problem/47148458>
2580
2581         Reviewed by Chris Dumez.
2582
2583         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2584
2585         Closing of the previous page is delayed so waiting for didFinishNavigation is
2586         not sufficient to guarantee we have received all the messages. Wait for them.
2587
2588 2019-01-24  Chris Dumez  <cdumez@apple.com>
2589
2590         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2591         https://bugs.webkit.org/show_bug.cgi?id=193761
2592         <rdar://problem/47456405>
2593
2594         Reviewed by Alex Christensen.
2595
2596         Add API test coverage.
2597
2598         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2599
2600 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2601
2602         webkitpy: Missing PID in crashlog name should not be fatal
2603         https://bugs.webkit.org/show_bug.cgi?id=193771
2604
2605         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2606         of raising an exception.
2607
2608         Reviewed by Lucas Forschler.
2609
2610         * Scripts/webkitpy/port/darwin.py:
2611         (DarwinPort._merge_crash_logs):
2612
2613 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2614
2615         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2616         https://bugs.webkit.org/show_bug.cgi?id=193746
2617
2618         Reviewed by Youenn Fablet.
2619
2620         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2621         so we'd best just not call it.
2622
2623         * Scripts/webkitpy/w3c/test_exporter.py:
2624         (WebPlatformTestExporter.create_branch_with_patch):
2625
2626 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2627
2628         Move FileSystem to WTF
2629         https://bugs.webkit.org/show_bug.cgi?id=193602
2630
2631         Reviewed by Yusuke Suzuki.
2632
2633         * DumpRenderTree/win/DumpRenderTree.cpp:
2634         * TestWebKitAPI/CMakeLists.txt:
2635         * TestWebKitAPI/PlatformGTK.cmake:
2636         * TestWebKitAPI/PlatformJSCOnly.cmake:
2637         * TestWebKitAPI/PlatformPlayStation.cmake:
2638         * TestWebKitAPI/PlatformWPE.cmake:
2639         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2640         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2641         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2642         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2643         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2644         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2645         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2646         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2647         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2648         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2649
2650 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2651
2652         [WPE] Remove hard dependency on subprocess32 for the API tests
2653
2654         Rubber-stamped by Carlos Garcia Campos.
2655
2656         * glib/api_test_runner.py:
2657         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2658         its presence only when running WPEQt tests.
2659
2660 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2661
2662         [GLIB] Expose JavaScriptCore options in GLib public API
2663         https://bugs.webkit.org/show_bug.cgi?id=188742
2664
2665         Reviewed by Michael Catanzaro.
2666
2667         Add a test for the new API.
2668
2669         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2670         (testsJSCOptions):
2671         (main):
2672
2673 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2674
2675         [GTK][WPE] Support JPEG 2000 images
2676         https://bugs.webkit.org/show_bug.cgi?id=186272
2677
2678         Reviewed by Žan Doberšek.
2679
2680         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2681
2682         * gtk/jhbuild.modules:
2683         * wpe/jhbuild.modules:
2684
2685 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2686
2687         check-webkit-style should warn when using soft-linking macros in a header
2688         <https://webkit.org/b/193750>
2689
2690         Reviewed by Darin Adler.
2691
2692         * Scripts/webkitpy/style/checkers/cpp.py:
2693         (check_language): Add softlink/header check by refactoring the
2694         softlink/framework check.
2695         (CppChecker): Enable softlink/header check by default.
2696         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2697         (CppStyleTest.test_softlink_framework): Rename from
2698         CppStyleTest.test_softlink() and change test framework name in
2699         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2700         files. Set file_name for macros that only appear in headers.
2701         (CppStyleTest.test_softlink_header): Add tests for using
2702         soft-link macros in headers.
2703
2704 2019-01-23  Chris Dumez  <cdumez@apple.com>
2705
2706         Deprecate API to limit the maximum number of WebProcesses
2707         https://bugs.webkit.org/show_bug.cgi?id=193725
2708         <rdar://problem/47464879>
2709
2710         Reviewed by Geoff Garen.
2711
2712         Update existing API tests to stop using deprecated API.
2713
2714         * MiniBrowser/mac/AppDelegate.m:
2715         (defaultConfiguration):
2716         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2717         (TestWebKitAPI::TEST):
2718         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2719         (TestWebKitAPI::TEST):
2720         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2721         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2722         (TEST):
2723         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2724         (TEST):
2725
2726 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2727
2728         [ews-app] Rename ews model buildermappings to buildermapping
2729         https://bugs.webkit.org/show_bug.cgi?id=193729
2730
2731         Reviewed by Lucas Forschler.
2732
2733         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2734         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2735         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2736
2737 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2738
2739         [ews-app] Rename ews model steps to step
2740         https://bugs.webkit.org/show_bug.cgi?id=193697
2741
2742         Reviewed by Lucas Forschler.
2743
2744         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2745         (Step): Renamed Steps to Step.
2746
2747 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2748
2749         Clean up IndexedDB files between tests
2750         https://bugs.webkit.org/show_bug.cgi?id=192796
2751         <rdar://problem/46824999>
2752
2753         Reviewed by Geoffrey Garen.
2754
2755         * DumpRenderTree/mac/DumpRenderTree.mm:
2756         (runTest):
2757         * WebKitTestRunner/TestController.cpp:
2758         (WTR::TestController::resetStateToConsistentValues):
2759         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2760         (WTR::RemoveAllIndexedDatabasesCallback):
2761         (WTR::TestController::ClearIndexedDatabases):
2762         * WebKitTestRunner/TestController.h:
2763         * WebKitTestRunner/TestInvocation.cpp:
2764         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2765
2766 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2767
2768         [ews-app] Rename ews model Builds to Build
2769         https://bugs.webkit.org/show_bug.cgi?id=193695
2770
2771         Reviewed by Lucas Forschler.
2772
2773         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2774         (Build): Renamed Builds to Build.
2775
2776 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2777
2778         webkitpy: Wait longer when launching WebKitTestRunner
2779         https://bugs.webkit.org/show_bug.cgi?id=193734
2780
2781         Reviewed by Aakash Jain.
2782
2783         * Scripts/webkitpy/port/simulator_process.py:
2784         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2785
2786 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2787
2788         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2789         https://bugs.webkit.org/show_bug.cgi?id=193182
2790         <rdar://problem/47452154>
2791
2792         Reviewed by Tim Horton.
2793
2794         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2795         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2796         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2797
2798         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2799         preventing later tests from recognizing gestures.
2800
2801         * WebKitTestRunner/ios/TestControllerIOS.mm:
2802         (WTR::TestController::platformResetStateToConsistentValues):
2803
2804         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2805
2806 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2807
2808         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2809         https://bugs.webkit.org/show_bug.cgi?id=193722
2810         <rdar://problem/47481475>
2811
2812         Reviewed by Lucas Forschler.
2813
2814         iPhone and iPad ports should both use the iOS config.
2815
2816         * Scripts/webkitpy/port/ios_simulator.py:
2817         (IPhoneSimulatorPort.__init__):
2818         (IPadSimulatorPort.__init__):
2819
2820 2019-01-23  Rob Buis  <rbuis@igalia.com>
2821
2822         Update MIME type parser
2823         https://bugs.webkit.org/show_bug.cgi?id=180526
2824
2825         Reviewed by Frédéric Wang.
2826
2827         Add unit tests for both parse modes of ParsedContentType.
2828
2829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2830         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2831         (TestWebKitAPI::TEST):
2832
2833 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2834
2835         [ews-app] fetch loop should not stop on network issues
2836         https://bugs.webkit.org/show_bug.cgi?id=193666
2837
2838         Reviewed by Lucas Forschler.
2839
2840         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2841         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2842
2843 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2844
2845         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2846         https://bugs.webkit.org/show_bug.cgi?id=189165
2847         <rdar://problem/47433765>
2848
2849         Reviewed by Tim Horton.
2850
2851         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2852         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2853         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2854         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2855         would make its way to the UI process by the time the layer tree commit is finished.
2856
2857         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2858         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2859         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2860         will fail because it asks for -_autofillContext too early.
2861
2862         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2863         is handled in the UI process.
2864
2865         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2866
2867         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2868         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2869         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2870         input session.
2871
2872         (-[AutofillTestView textInputHasAutofillContext]):
2873
2874         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2875
2876         * TestWebKitAPI/cocoa/TestWKWebView.h:
2877         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2878         (nextInputSessionChangeCount):
2879
2880         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2881         This includes changing the focused element from one to another.
2882
2883         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2884         (-[TestWKWebView didStartFormControlInteraction]):
2885         (-[TestWKWebView didEndFormControlInteraction]):
2886         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2887
2888         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2889         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2890         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2891         that doesn't require an input session to one that doesn't.
2892
2893 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2894
2895         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2896         <https://webkit.org/b/193676>
2897
2898         Reviewed by Alexey Proskuryakov.
2899
2900         * Scripts/webkitpy/style/checkers/cpp.py:
2901         (check_member_initialization_list):
2902         - Don't report missing whitespace around colon if the colon at
2903           the start of the line is formatted correctly.
2904         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2905         (WebKitStyleTest.test_member_initialization_list):
2906         - Add a test for a missing permutation of existing tests.
2907         - Add a test this false-positive.
2908         - Add blank lines between subtests to make them easier to read.
2909
2910 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2911
2912         [build.webkit.org] Unit-test failure after r237113
2913         https://bugs.webkit.org/show_bug.cgi?id=193669
2914
2915         Reviewed by Michael Catanzaro.
2916
2917         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2918         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2919         multiple or zero flags.
2920
2921 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2922
2923         Cache bytecode to disk
2924         https://bugs.webkit.org/show_bug.cgi?id=192782
2925         <rdar://problem/46084932>
2926
2927         Reviewed by Keith Miller.
2928
2929         Add test helper to execute bytecode-cache tests: it executes each test
2930         twice, the first with JSC_diskCachePath set to a temporary directory
2931         and second with JSC_forceDiskCache=true (in addition to the cache path)
2932         to guarantee that only the disk cache is being used and no new
2933         UnlinkedCodeBlocks are being created.
2934
2935         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2936         * Scripts/run-jsc-stress-tests:
2937
2938 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2939
2940         [css-logical] Implement flow-relative margin, padding and border shorthands
2941         https://bugs.webkit.org/show_bug.cgi?id=188697
2942
2943         Reviewed by Simon Fraser and Antti Koivisto.
2944
2945         * DumpRenderTree/TestOptions.cpp:
2946         (TestOptions::TestOptions):
2947         * DumpRenderTree/TestOptions.h:
2948         * DumpRenderTree/mac/DumpRenderTree.mm:
2949         (setWebPreferencesForTestOptions):
2950         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2951
2952         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2953         (JSONCSSPropertiesChecker.check_codegen_properties):
2954         Allow CSS property definitions to have a 'runtime-flag' parameter which
2955         disables the property when the specified runtime flag is disabled.
2956
2957 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2958
2959         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2960         https://bugs.webkit.org/show_bug.cgi?id=193643
2961
2962         Reviewed by Michael Catanzaro.
2963
2964         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2965         * wpe/jhbuild.modules: Ditto.
2966
2967 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2968
2969         [LFC][Floats] Take float top position into account when computing containing block height.
2970         https://bugs.webkit.org/show_bug.cgi?id=193655
2971
2972         Reviewed by Antti Koivisto.
2973
2974         * LayoutReloaded/misc/LFC-passing-tests.txt:
2975
2976 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2977
2978         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2979         <https://webkit.org/b/193645>
2980         <rdar://problem/47421574>
2981
2982         Reviewed by Alex Christensen.
2983
2984         - Now checks for local soft-linking of all frameworks that have
2985           their own *SoftLinking.{cpp,h,mm} files.
2986         - Changes softlink/uikit warning to softlink/framework.
2987
2988         * Scripts/webkitpy/style/checkers/cpp.py:
2989         (check_language):
2990         (CppChecker):
2991         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2992         (CppStyleTest):
2993
2994 2019-01-20  Saam Barati  <sbarati@apple.com>
2995
2996         Rollout r240210: It broke tests on iOS
2997         https://bugs.webkit.org/show_bug.cgi?id=193640
2998
2999         Unreviewed.
3000
3001         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3002         * Scripts/run-jsc-stress-tests:
3003
3004 2019-01-20  chris fleizach  <cfleizach@apple.com>
3005
3006         AX: Support returning relative frames for accessibility
3007         https://bugs.webkit.org/show_bug.cgi?id=193414
3008         <rdar://problem/47268501>
3009
3010         Reviewed by Zalan Bujtas.
3011
3012         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3013         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3014         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3015         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3016         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3017         (WTR::attributesOfElement):
3018         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3019
3020 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3021
3022         Unreviewed, add my new email address
3023
3024         * Scripts/webkitpy/common/config/contributors.json:
3025
3026 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3027
3028         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3029         https://bugs.webkit.org/show_bug.cgi?id=193617
3030
3031         Reviewed by Antti Koivisto.
3032
3033         * LayoutReloaded/misc/LFC-passing-tests.txt:
3034
3035 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3036
3037         Unreviewed, rolling out r240209.
3038
3039         Broke GTK/WPE injected bundle
3040
3041         Reverted changeset:
3042
3043         "AX: Support returning relative frames for accessibility"
3044         https://bugs.webkit.org/show_bug.cgi?id=193414
3045         https://trac.webkit.org/changeset/240209
3046
3047 2019-01-12  Dan Bernstein  <mitz@apple.com>
3048
3049         [Cocoa] Avoid importing directly from subumbrella frameworks
3050         https://bugs.webkit.org/show_bug.cgi?id=186016
3051         <rdar://problem/40591038>
3052
3053         Reviewed by Sam Weinig.
3054
3055         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3056           LaunchServices header.
3057         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3058           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3059         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3060           when using SDKs earlier than 10.13.
3061         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3062           and OTHER_CPLUSPLUSFLAGS.
3063         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3064           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3065         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3066           LaunchServices header.
3067
3068 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3069
3070         Cache bytecode to disk
3071         https://bugs.webkit.org/show_bug.cgi?id=192782
3072         <rdar://problem/46084932>
3073
3074         Reviewed by Keith Miller.
3075
3076         Add test helper to execute bytecode-cache tests: it executes each test
3077         twice, the first with JSC_diskCachePath set to a temporary directory
3078         and second with JSC_forceDiskCache=true (in addition to the cache path)
3079         to guarantee that only the disk cache is being used and no new
3080         UnlinkedCodeBlocks are being created.
3081
3082         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3083         * Scripts/run-jsc-stress-tests:
3084
3085 2019-01-20  chris fleizach  <cfleizach@apple.com>
3086
3087         AX: Support returning relative frames for accessibility
3088         https://bugs.webkit.org/show_bug.cgi?id=193414
3089         <rdar://problem/47268501>
3090
3091         Reviewed by Zalan Bujtas.
3092
3093         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3094         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3095         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3096         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3097         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3098         (WTR::attributesOfElement):
3099         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3100
3101 2019-01-20  Antoine Quint  <graouts@apple.com>
3102
3103         Add a POINTER_EVENTS feature flag
3104         https://bugs.webkit.org/show_bug.cgi?id=193577
3105         <rdar://problem/47408511>
3106
3107         Unreviewed. Also enable Pointer Events for iosmac.
3108
3109         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3110
3111 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3112
3113         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3114         https://bugs.webkit.org/show_bug.cgi?id=193613
3115
3116         Reviewed by Antti Koivisto.
3117
3118         * LayoutReloaded/misc/LFC-passing-tests.txt:
3119
3120 2019-01-19  Antoine Quint  <graouts@apple.com>
3121
3122         Add a POINTER_EVENTS feature flag
3123         https://bugs.webkit.org/show_bug.cgi?id=193577
3124
3125         Reviewed by Dean Jackson.
3126
3127         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3128
3129 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3130
3131         Disable the run-jsc-stress-test remote host key check [second round].
3132         https://bugs.webkit.org/show_bug.cgi?id=192988
3133
3134         Reviewed by Dewei Zhu.
3135
3136         * Scripts/run-jsc-stress-tests:
3137
3138 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3139
3140         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3141         https://bugs.webkit.org/show_bug.cgi?id=193597
3142
3143         Reviewed by Lucas Forschler.
3144
3145         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3146
3147 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3148
3149         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3150         https://bugs.webkit.org/show_bug.cgi?id=193595
3151
3152         Reviewed by Lucas Forschler.
3153
3154         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3155         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3156         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3157
3158 2019-01-18  Chris Dumez  <cdumez@apple.com>
3159
3160         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3161         https://bugs.webkit.org/show_bug.cgi?id=193588
3162         <rdar://problem/47131566>
3163
3164         Reviewed by Alex Christensen.
3165
3166         Add layout test coverage.
3167
3168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3169
3170 2019-01-18  Jer Noble  <jer.noble@apple.com>
3171
3172         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3173         https://bugs.webkit.org/show_bug.cgi?id=189553
3174
3175         Reviewed by Tim Horton.
3176
3177         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3178
3179         * ContentExtensionTester/Configurations/Base.xcconfig:
3180         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3181         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3182         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3183         * ImageDiff/cg/Configurations/Base.xcconfig:
3184         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3185         * MiniBrowser/Configurations/Base.xcconfig:
3186         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3187         * MobileMiniBrowser/Configurations/Base.xcconfig:
3188         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3189         * Scripts/webkitpy/style/checker.py:
3190         (_all_categories):
3191         (FileType):
3192         (CheckerDispatcher._file_type):
3193         (CheckerDispatcher._create_checker):
3194         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3195         (SDKVariantChecker):
3196         (SDKVariantChecker.__init__):
3197         (SDKVariantChecker.check):
3198         * TestWebKitAPI/Configurations/Base.xcconfig:
3199         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3200         * WebEditingTester/Configurations/Base.xcconfig:
3201         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3202         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3203         * WebKitTestRunner/Configurations/Base.xcconfig:
3204         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3205         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3206         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3207
3208 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3209
3210         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3211         <https://webkit.org/b/193568>
3212         <rdar://problem/47381130>
3213
3214         Reviewed by Alex Christensen.
3215
3216         Make sure no one re-introduces UIKit soft-linking by adding a
3217         style rule.
3218
3219         * Scripts/webkitpy/style/checkers/cpp.py:
3220         (check_language): Add softlink/uikit check.
3221         (CppChecker): Enable softlink/uikit check.
3222         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3223         (CppStyleTest): Add test for softlink/uikit.
3224
3225 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3226
3227         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3228         https://bugs.webkit.org/show_bug.cgi?id=193584
3229
3230         Change "-dev" to "-devel".
3231
3232         Reviewed by Michael Catanzaro.
3233
3234         * gtk/install-dependencies:
3235
3236 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3237
3238         webkitpy: Add iPhone and iPad ports
3239         https://bugs.webkit.org/show_bug.cgi?id=193537
3240         <rdar://problem/47353390>
3241
3242         Reviewed by Lucas Forschler.
3243
3244         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3245         ports. Note that this separation is optional, the --ios-simulator command remains.
3246
3247         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3248         (RunTest.test_device_type_test_division): Drive-by fix.
3249         (RunTest.test_device_type_specific_listing): Ditto.
3250         (RunTest.test_ipad_test_division):
3251         (RunTest):
3252         (RunTest.test_ipad_listing):
3253         * Scripts/webkitpy/port/factory.py:
3254         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3255         (PortFactory):
3256         * Scripts/webkitpy/port/ios_simulator.py:
3257         (IPhoneSimulatorPort):
3258         (IPadSimulatorPort):
3259
3260 2019-01-18  Chris Dumez  <cdumez@apple.com>
3261
3262         Regression(PSON) Scroll position is not always restored properly when navigating back
3263         https://bugs.webkit.org/show_bug.cgi?id=193578
3264         <rdar://problem/47386331>
3265
3266         Reviewed by Tim Horton.
3267
3268         Add API test coverage.
3269
3270         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3271
3272 2019-01-18  Youenn Fablet  <youenn@apple.com>
3273
3274         Add a new SPI to request for cache storage quota increase
3275         https://bugs.webkit.org/show_bug.cgi?id=193323
3276
3277         Reviewed by Alex Christensen.
3278
3279         Implement WebsiteDataStore quota delegate to handle quota requests.
3280         By default, do not update quota.
3281         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3282
3283         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3284         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3285         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3286         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3287         * WebKitTestRunner/TestController.cpp:
3288         (WTR::TestController::allowCacheStorageQuotaIncrease):
3289         * WebKitTestRunner/TestController.h:
3290         * WebKitTestRunner/TestInvocation.cpp:
3291         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3292         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3293         (-[CacheStorageQuotaManager init]):
3294         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3295         (WTR::initializeWebViewConfiguration):
3296         (WTR::TestController::cocoaResetStateToConsistentValues):
3297         (WTR::TestController::allowCacheStorageQuotaIncrease):
3298
3299 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3300
3301         [ews-build] Pass owner to the triggered builds
3302         https://bugs.webkit.org/show_bug.cgi?id=193574
3303
3304         Reviewed by Lucas Forschler.
3305
3306         * BuildSlaveSupport/ews-build/factories.py:
3307         (BuildFactory.propertiesToPassToTriggers):
3308
3309 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3310
3311         [ews-app] Send patch author as a build property
3312         https://bugs.webkit.org/show_bug.cgi?id=193560
3313
3314         Reviewed by Lucas Forschler.
3315
3316         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3317         (BugzillaPatchFetcher.fetch):
3318
3319 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3320
3321         webkitpy: Implement device type specific expected results (Follow-up fix)
3322         https://bugs.webkit.org/show_bug.cgi?id=192162
3323         <rdar://problem/46345449>
3324
3325         Unreviewed infrastructure fix.
3326
3327         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3328         (Manager.run): Don't boot a device if no tests are available to run on it.
3329
3330 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3331
3332         webkitpy: Implement device type specific expected results (Follow-up fix)
3333         https://bugs.webkit.org/show_bug.cgi?id=192162
3334         <rdar://problem/46345449>
3335
3336         Unreviewed infrastructure fix.
3337
3338         * Scripts/webkitpy/api_tests/manager.py:
3339         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3340
3341 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3342
3343         webkitpy: Implement device type specific expected results (Part 2)
3344         https://bugs.webkit.org/show_bug.cgi?id=192162
3345         <rdar://problem/46345449>
3346
3347         Rubber-stamped by Aakash Jain.
3348
3349         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3350         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3351         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3352
3353         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3354         (LayoutTestFinder.find_tests): Pass device_type through.
3355         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3356         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3357         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3358         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3359         (Manager._collect_tests): Pass device type to test finder.
3360         (Manager._needs_web_platform_test):
3361         (Manager._prepare_lists): Index _expectations by device type.
3362         (Manager._test_input_for_file):
3363         (Manager._test_is_slow): Ditto.
3364         (Manager._test_should_dump_jsconsolelog_in_stderr):
3365         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3366         (Manager._get_test_inputs):
3367         (Manager._update_worker_count):
3368         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3369         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3370         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3371         the one which runs the test.
3372         (Manager._run_test_subset):
3373         (Manager._run_tests): Index _expectations by current_device_type.
3374         (Manager._print_expectation_line_for_test): Ditto.
3375         (Manager._print_expectations_for_subset): Ditto.
3376         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3377         Unlike run, this function will behave the same regardless of what devices are available.
3378         (Manager._custom_device_for_test): Deleted.
3379         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3380         (ManagerTest.test_uses_custom_device): Deleted.
3381         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3382         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3383         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3384         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3385         all of the expectations.
3386         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3387         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3388         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3389         (TestExpectations.__init__): Allow device_type to be passed through.
3390         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3391         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3392         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3393         (summarize_results):
3394         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3395         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3396         a test ran with, one must check all expectations to find the first non-skip expectation.
3397         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3398         (RunTest.test_device_type_test_division):
3399         (RunTest):
3400         (RunTest.test_device_type_specific_listing):
3401         * Scripts/webkitpy/port/base.py:
3402         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3403         (Port.supported_device_types): The result of this function will change based on what devices are available.
3404         * Scripts/webkitpy/port/device_port.py:
3405         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3406         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3407         can be used.
3408         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3409         any, or the DEFAULT_DEVICE_TYPES of the port.
3410         * Scripts/webkitpy/port/ios.py:
3411         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3412         * Scripts/webkitpy/port/ios_simulator.py:
3413         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3414         * Scripts/webkitpy/port/watch.py:
3415         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3416         * Scripts/webkitpy/port/watch_simulator.py:
3417         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3418         * Scripts/webkitpy/xcode/device_type.py:
3419         (DeviceType):
3420         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3421
3422 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3423
3424         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3425         https://bugs.webkit.org/show_bug.cgi?id=193575
3426
3427         Reviewed by Michael Catanzaro.
3428
3429         Allow the script to run without explicit port argument because
3430         it's specific to the WPE port anyway.
3431
3432         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3433         and simplify the rest of the code accordingly.
3434
3435 2019-01-18  Charlie Turner  <cturner@igalia.com>
3436
3437         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3438         https://bugs.webkit.org/show_bug.cgi?id=192229
3439
3440         Reviewed by Xabier Rodriguez-Calvar.
3441
3442         * MiniBrowser/wpe/main.cpp:
3443         (main): Enable encrypted-media by default.
3444
3445 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3446
3447         [Flatpak] Missing KeyboardInterrupt exception handler
3448         https://bugs.webkit.org/show_bug.cgi?id=193570
3449
3450         Reviewed by Michael Catanzaro.
3451
3452         * flatpak/flatpakutils.py:
3453         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3454
3455 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3456
3457         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3458         https://bugs.webkit.org/show_bug.cgi?id=193564
3459
3460         Reviewed by Antti Koivisto.
3461
3462         * LayoutReloaded/misc/LFC-passing-tests.txt:
3463
3464 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3465
3466         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3467         https://bugs.webkit.org/show_bug.cgi?id=193562
3468
3469         Reviewed by Antti Koivisto.
3470
3471         * LayoutReloaded/misc/LFC-passing-tests.txt:
3472
3473 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3474
3475         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3476         https://bugs.webkit.org/show_bug.cgi?id=193555
3477
3478         Reviewed by Antti Koivisto.
3479
3480         * LayoutReloaded/misc/LFC-passing-tests.txt:
3481
3482 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3483
3484         [WPE] Add Qt extension
3485         https://bugs.webkit.org/show_bug.cgi?id=191464
3486
3487         Reviewed by Carlos Garcia Campos.
3488
3489         MiniBrowser and API tests for the WPE Qt API. To run the
3490         MiniBrowser a new script is introduced. Example invocation:
3491
3492         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3493
3494         Also note-worthy is the introduction of the python2-subprocess32
3495         dependency to run the GLib API tests.
3496
3497         * MiniBrowser/wpe/CMakeLists.txt:
3498         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3499         * MiniBrowser/wpe/qt/main.cpp: Added.
3500         (main):
3501         * MiniBrowser/wpe/qt/main.qml: Added.
3502         * MiniBrowser/wpe/qt/qml.qrc: Added.
3503         * Scripts/run-gtk-tests:
3504         (GtkTestRunner.is_google_test):
3505         (GtkTestRunner):
3506         (GtkTestRunner.is_qt_test):
3507         * Scripts/run-qt-wpe-minibrowser: Added.
3508         * Scripts/run-wpe-tests:
3509         (WPETestRunner):
3510         (WPETestRunner.is_google_test):
3511         (WPETestRunner.is_qt_test):
3512         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3513         (TestLoad::main):
3514         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3515         (TestLoadHtml::main):
3516         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3517         (TestLoadRequest::main):
3518         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3519         (TestRunJavaScript::main):
3520         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3521         (waitForSignal):
3522         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3523         (LoadSpy::LoadSpy):
3524         (LoadSpy::~LoadSpy):
3525         (LoadSpy::onLoadingChanged):
3526         (LoadStartedCatcher::LoadStartedCatcher):
3527         (LoadStartedCatcher::~LoadStartedCatcher):
3528         (LoadStartedCatcher::onLoadingChanged):
3529         (waitForLoadSucceeded):
3530         (waitForLoadFailed):
3531         * TestWebKitAPI/glib/CMakeLists.txt:
3532         * flatpak/flatpakutils.py:
3533         (WebkitFlatpak.load_from_args):
3534         (WebkitFlatpak.__init__):
3535         (WebkitFlatpak.clean_args):
3536         (WebkitFlatpak.run_in_sandbox):
3537         * flatpak/org.webkit.CommonModules.yaml:
3538         * flatpak/org.webkit.WPE.yaml:
3539         * flatpak/org.webkit.WPEModules.yaml:
3540         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3541         * flatpak/org.webkit.WebKit.yaml:
3542         * glib/api_test_runner.py:
3543         (TestRunner._run_test_qt):
3544         (TestRunner.is_qt_test):
3545         (TestRunner._run_test):
3546
3547 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3548
3549         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3550         https://bugs.webkit.org/show_bug.cgi?id=193494
3551         <rdar://problem/46859627>
3552
3553         Reviewed by Simon Fraser and Tim Horton.
3554
3555         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3556         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3557
3558         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3559         (WTR::UIScriptController::contentOffsetX const):
3560         (WTR::UIScriptController::contentOffsetY const):
3561         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3562         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3563         (WTR::UIScriptController::contentOffsetX const):
3564         (WTR::UIScriptController::contentOffsetY const):
3565         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3566
3567         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3568
3569         * WebKitTestRunner/TestController.cpp:
3570         (WTR::updateTestOptionsFromTestHeader):
3571         * WebKitTestRunner/TestOptions.h:
3572         (WTR::TestOptions::hasSameInitializationOptions const):
3573         * WebKitTestRunner/ios/TestControllerIOS.mm:
3574         (WTR::TestController::platformResetStateToConsistentValues):
3575         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3576         (WTR::UIScriptController::contentOffsetX const):
3577         (WTR::UIScriptController::contentOffsetY const):
3578
3579 2019-01-17  Truitt Savell  <tsavell@apple.com>
3580
3581         Unreviewed, rolling out r240124.
3582
3583         This commit broke an internal build.
3584
3585         Reverted changeset:
3586
3587         "SDK_VARIANT build destinations should be separate from non-
3588         SDK_VARIANT builds"
3589         https://bugs.webkit.org/show_bug.cgi?id=189553
3590         https://trac.webkit.org/changeset/240124
3591
3592 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3593
3594         Fix string concatenation API test after r239920
3595         https://bugs.webkit.org/show_bug.cgi?id=193551
3596         <rdar://problem/47359304>
3597
3598         Reviewed by Youenn Fablet.
3599
3600         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3601         (TestWebKitAPI::TEST):
3602         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3603         in WebKit's build configuration like it apparently is on Linux.
3604
3605 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3606
3607         [ews-build] validate-patch should handle the case when bug_id is None
3608         https://bugs.webkit.org/show_bug.cgi?id=193547
3609
3610         Reviewed by Lucas Forschler.
3611
3612         * BuildSlaveSupport/ews-build/steps.py:
3613         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3614         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3615
3616 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3617
3618         [ews-build] Add patch author information in build
3619         https://bugs.webkit.org/show_bug.cgi?id=193465
3620
3621         Reviewed by Lucas Forschler.
3622
3623         * BuildSlaveSupport/ews-build/steps.py:
3624         (ValidatePatch._is_patch_obsolete):
3625
3626 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3627
3628         [ews-build] Pass bug_id to the triggered builds
3629         https://bugs.webkit.org/show_bug.cgi?id=193548
3630
3631         Reviewed by Lucas Forschler.
3632
3633         * BuildSlaveSupport/ews-build/factories.py:
3634         (BuildFactory.propertiesToPassToTriggers):
3635
3636 2019-01-17  Jer Noble  <jer.noble@apple.com>
3637
3638         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3639         https://bugs.webkit.org/show_bug.cgi?id=189553
3640
3641         Reviewed by Tim Horton.
3642
3643         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3644
3645         * ContentExtensionTester/Configurations/Base.xcconfig:
3646         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3647         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3648         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3649         * ImageDiff/cg/Configurations/Base.xcconfig:
3650         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3651         * MiniBrowser/Configurations/Base.xcconfig:
3652         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3653         * MobileMiniBrowser/Configurations/Base.xcconfig:
3654         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3655         * Scripts/webkitpy/style/checker.py:
3656         (_all_categories):
3657         (FileType):
3658         (CheckerDispatcher._file_type):
3659         (CheckerDispatcher._create_checker):
3660         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3661         (SDKVariantChecker):
3662         (SDKVariantChecker.__init__):
3663         (SDKVariantChecker.check):
3664         * TestWebKitAPI/Configurations/Base.xcconfig:
3665         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3666         * WebEditingTester/Configurations/Base.xcconfig:
3667         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3668         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3669         * WebKitTestRunner/Configurations/Base.xcconfig:
3670         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3671         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3672         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3673
3674 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3675
3676         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3677         https://bugs.webkit.org/show_bug.cgi?id=193534
3678
3679         Reviewed by Antti Koivisto.
3680
3681         * LayoutReloaded/misc/LFC-passing-tests.txt:
3682
3683 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3684
3685         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3686         https://bugs.webkit.org/show_bug.cgi?id=193528
3687
3688         Reviewed by Antti Koivisto.
3689
3690         * LayoutReloaded/misc/LFC-passing-tests.txt:
3691
3692 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3693
3694         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3695         https://bugs.webkit.org/show_bug.cgi?id=193520
3696
3697         Reviewed by Antti Koivisto.
3698
3699         * LayoutReloaded/misc/LFC-passing-tests.txt:
3700
3701 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3702
3703         [ews-build] unapply-patch step should not update source
3704         https://bugs.webkit.org/show_bug.cgi?id=193234
3705
3706         Reviewed by Lucas Forschler.
3707
3708         * BuildSlaveSupport/ews-build/steps.py:
3709         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3710         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3711
3712 2019-01-16  Youenn Fablet  <youenn@apple.com>
3713
3714         Add a new SPI for controlling getUserMedia
3715         https://bugs.webkit.org/show_bug.cgi?id=192793
3716
3717         Reviewed by Eric Carlson.
3718
3719         * MiniBrowser/mac/WK2BrowserWindowController.m:
3720         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3721         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3722         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3723         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3724         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3725         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3726         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3727         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3728         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3729         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3730         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3731         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3732         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3733         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3734
3735 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3736
3737         [LFC][BFC] Inflow non-replaced used width should not be negative.
3738         https://bugs.webkit.org/show_bug.cgi?id=193495
3739
3740         Reviewed by Antti Koivisto.
3741
3742         * LayoutReloaded/misc/LFC-passing-tests.txt:
3743
3744 2019-01-16  Chris Dumez  <cdumez@apple.com>
3745
3746         Regression(PSON) View becomes blank after click a cross-site download link
3747         https://bugs.webkit.org/show_bug.cgi?id=193361
3748         <rdar://problem/47099573>
3749
3750         Reviewed by Geoffrey Garen.
3751
3752         Add API test coverage.
3753
3754         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3755         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3756
3757 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3758
3759         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3760         https://bugs.webkit.org/show_bug.cgi?id=193470
3761
3762         Reviewed by Antti Koivisto.
3763
3764         * LayoutReloaded/misc/LFC-passing-tests.txt:
3765
3766 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3767
3768         [LFC] Adjust margin box verification.
3769         https://bugs.webkit.org/show_bug.cgi?id=193482
3770
3771         Reviewed by Antti Koivisto.
3772
3773         * LayoutReloaded/misc/LFC-passing-tests.txt:
3774
3775 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3776
3777         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3778         https://bugs.webkit.org/show_bug.cgi?id=193451
3779
3780         Reviewed by Geoffrey Garen.
3781
3782         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3783         (TEST):
3784         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3785         (runWebsiteDataStoreCustomPaths):
3786
3787 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3788
3789         webkitpy: Support boolean simctl isAvailable
3790         https://bugs.webkit.org/show_bug.cgi?id=193472
3791         <rdar://problem/47296150>
3792
3793         Reviewed by Ryosuke Niwa.
3794
3795         * Scripts/webkitpy/xcode/simulated_device.py:
3796         (SimulatedDeviceManager._create_runtimes):
3797         (SimulatedDeviceManager._create_device_with_runtime):
3798
3799 2019-01-15  Chris Dumez  <cdumez@apple.com>
3800
3801         Unreviewed, rolling out r239993, r239995, r239997, and
3802         r239999.
3803
3804         Caused assertions under
3805         ViewGestureController::disconnectFromProcess()
3806
3807         Reverted changesets:
3808
3809         "Regression(PSON) View becomes blank after click a cross-site
3810         download link"
3811         https://bugs.webkit.org/show_bug.cgi?id=193361
3812         https://trac.webkit.org/changeset/239993
3813
3814         "Unreviewed iOS build fix after r239993."
3815         https://trac.webkit.org/changeset/239995
3816
3817         "Fix iOS build after r239993"
3818         https://bugs.webkit.org/show_bug.cgi?id=193361
3819         https://trac.webkit.org/changeset/239997
3820
3821         "Unreviewed, revert part of r239997 as it is not needed to fix
3822         the build."
3823         https://trac.webkit.org/changeset/239999
3824
3825 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3826
3827         Cannot tab out of WKWebView on macOS
3828         https://bugs.webkit.org/show_bug.cgi?id=161448
3829         <rdar://problem/28100085>
3830
3831         Reviewed by Dean Jackson.
3832
3833         Add a test that tabbing into and out of WKWebView works correctly.
3834
3835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3836         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3837         (WebKit2_CommandBackForwardTest::SetUp):
3838         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3839         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3840         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3841         (-[FocusableView canBecomeKeyView]):
3842         (TEST):
3843         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3844         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3845         (-[OffscreenWindow initWithSize:]):
3846         (-[OffscreenWindow isKeyWindow]):
3847         (-[OffscreenWindow isVisible]):
3848         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3849         (TestWebKitAPI::PlatformWebView::initialize):
3850         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3851         (-[ActiveOffscreenWindow isVisible]): Deleted.
3852         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3853
3854 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3855
3856         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3857         https://bugs.webkit.org/show_bug.cgi?id=193459
3858
3859         Reviewed by Mark Lam.
3860
3861         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3862         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3863
3864 2019-01-15  Chris Dumez  <cdumez@apple.com>
3865
3866         Regression(PSON) View becomes blank after click a cross-site download link
3867         https://bugs.webkit.org/show_bug.cgi?id=193361
3868         <rdar://problem/47099573>
3869
3870         Reviewed by Geoff Garen.
3871
3872         Add API test coverage.
3873
3874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3875         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3876
3877 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3878
3879         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3880         https://bugs.webkit.org/show_bug.cgi?id=193448
3881
3882         Reviewed by Antti Koivisto.
3883
3884         * LayoutReloaded/misc/LFC-passing-tests.txt:
3885
3886 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3887
3888         webkitpy: Implement device type specific expected results (Part 1)
3889         https://bugs.webkit.org/show_bug.cgi?id=192162
3890
3891         Reviewed by Lucas Forschler.
3892
3893         Device type specific expected results covers two related ideas. The first (covered by this change)
3894         is where to search for -expected.* files. The second is which tests to run based on the
3895         TestExpectations.txt file.
3896
3897         After this change, the baseline search path will be determined by the type of device running a
3898         test. Device type will be passed into any function which picks a file based on the baseline search
3899         path.
3900
3901         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3902         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3903         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3904         (Manager.run): Print baseline search path for each round of devices.
3905         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3906         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3907         (SingleTestRunner._expected_driver_output): Ditto.
3908         (SingleTestRunner._driver_input): Ditto.
3909         * Scripts/webkitpy/layout_tests/views/printing.py:
3910         (Printer.print_config): Move printing of baseline search path to a separate function.
3911         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3912         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3913         (Testprinter.test_print_config):
3914         (Testprinter.test_print_baseline_search_path):
3915         * Scripts/webkitpy/port/base.py:
3916         (Port.baseline_search_path): Pass device_type through.
3917         (Port._expected_baselines_for_suffixes): Ditto.
3918         (Port.expected_baselines): Ditto.
3919         (Port.expected_filename): Ditto.
3920         (Port.expected_checksum): Ditto.
3921         (Port.expected_image): Ditto.
3922         (Port.expected_audio): Ditto.
3923         (Port.expected_text): Ditto.
3924         (Port.reference_files): Ditto.
3925         (Port.tests): Ditto.
3926         (Port._expanded_paths): Ditto.
3927         (Port.skipped_layout_tests): Ditto.
3928         (Port.expectations_dict): Ditto.
3929         (Port._port_specific_expectations_files): Ditto.
3930         (Port.expectations_files): Ditto.
3931         (Port.test_search_path): Ditto.
3932         (Port._tests_for_other_platforms): Ditto.
3933         * Scripts/webkitpy/port/base_unittest.py:
3934         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3935         (PortTest.test_nonexistant_expectations): Ditto.
3936         (test_ref_tests_platform_directory): Ditto.
3937         * Scripts/webkitpy/port/darwin.py:
3938         (DarwinPort._port_specific_expectations_files): Accept device_type.
3939         * Scripts/webkitpy/port/driver.py:
3940         (DriverProxy):
3941         (DriverProxy.host): Expose _target_host for device_type information.
3942         * Scripts/webkitpy/port/gtk.py:
3943         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3944         * Scripts/webkitpy/port/ios.py:
3945         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3946         * Scripts/webkitpy/port/mac.py:
3947         (MacPort. default_baseline_search_path): Ditto.
3948         * Scripts/webkitpy/port/port_testcase.py:
3949         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3950         * Scripts/webkitpy/port/test.py:
3951         * Scripts/webkitpy/port/watch.py:
3952         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3953         * Scripts/webkitpy/port/win.py:
3954         (WinPort.test_search_path): Accept, but do not use, device_type.
3955         * Scripts/webkitpy/port/wpe.py:
3956         (WPEPort._port_specific_expectations_files): Ditto.
3957         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3958         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3959
3960 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3961
3962         [LFC] Use the containing block's padding box to position out-of-flow elements.
3963         https://bugs.webkit.org/show_bug.cgi?id=193431
3964
3965         Reviewed by Antti Koivisto.
3966
3967         * LayoutReloaded/misc/LFC-passing-tests.txt:
3968
3969 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3970
3971         Move a test implementation file that got misplaced in the Xcode project
3972
3973         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3974
3975 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3976
3977         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3978         r239913, and r239914.
3979         https://bugs.webkit.org/show_bug.cgi?id=193407
3980
3981         These revisions caused an internal failure (Requested by
3982         Truitt on #webkit).
3983
3984         Reverted changesets:
3985
3986         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3987         https://bugs.webkit.org/show_bug.cgi?id=186016
3988         https://trac.webkit.org/changeset/239901
3989
3990         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3991         https://trac.webkit.org/changeset/239909
3992
3993         "Tried to fix the build."
3994         https://trac.webkit.org/changeset/239910
3995
3996         "Fixed iOS builds after r239910."
3997         https://trac.webkit.org/changeset/239912
3998
3999         "More build fixing."
4000         https://trac.webkit.org/changeset/239913
4001
4002         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
4003         https://trac.webkit.org/changeset/239914
4004
4005 2019-01-14  Mark Lam  <mark.lam@apple.com>
4006
4007         Re-enable ability to build --cloop builds.
4008         https://bugs.webkit.org/show_bug.cgi?id=192955
4009         <rdar://problem/46882363>
4010
4011         Reviewed by Saam barati and Keith Miller.
4012
4013         The --cloop build option was being ignored this whole time since r236381.
4014         This patch makes it possible to build CLoop builds again.
4015
4016         * Scripts/build-jsc:
4017         * Scripts/webkitperl/FeatureList.pm:
4018         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4019
4020 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4021
4022         webkitpy: Expose device_type from host-like objects
4023         https://bugs.webkit.org/show_bug.cgi?id=193406
4024         <rdar://problem/47262305>
4025
4026         Reviewed by Lucas Forschler.
4027
4028         Devices should expose device_type. As a result, all host objects should
4029         provide a device_type property, even if they do not yet define a device_type.
4030
4031         * Scripts/webkitpy/common/system/systemhost.py:
4032         (SystemHost):
4033         (SystemHost.device_type):
4034         * Scripts/webkitpy/common/system/systemhost_mock.py:
4035         (MockSystemHost):
4036         (MockSystemHost.device_type):
4037         * Scripts/webkitpy/port/device.py:
4038         (Device):
4039         (Device.device_type):
4040         * Scripts/webkitpy/xcode/simulated_device.py:
4041         (SimulatedDeviceManager._find_exisiting_device_for_request):
4042         (SimulatedDeviceManager._disambiguate_device_type):
4043         (SimulatedDeviceManager._does_fulfill_request):
4044         (SimulatedDeviceManager.device_count_for_type):
4045         (SimulatedDeviceManager.initialize_devices):
4046         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4047         (test_available_devices):
4048         (test_swapping_devices):
4049
4050 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4051
4052         webkitpy: Support alternate simctl device list output (Follow-up fix)
4053         https://bugs.webkit.org/show_bug.cgi?id=193362
4054         <rdar://problem/47122965>
4055
4056         Rubber-stamped by Lucas Forschler.
4057
4058         * Scripts/webkitpy/xcode/simulated_device.py:
4059         (SimulatedDeviceManager.populate_available_devices):
4060
4061 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
4062
4063         [iOS] Expose SPI to access the current sentence boundary and selection state
4064         https://bugs.webkit.org/show_bug.cgi?id=193398
4065         <rdar://problem/45893108>
4066
4067         Reviewed by Dean Jackson.
4068
4069         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
4070         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
4071         expected.
4072
4073         * TestWebKitAPI/EditingTestHarness.h:
4074         * TestWebKitAPI/EditingTestHarness.mm:
4075         (-[EditingTestHarness moveBackward]):
4076         (-[EditingTestHarness moveForward]):
4077         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
4078
4079         Add a couple of new helper methods on EditingTestHarness.
4080
4081         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
4082         (-[SelectionChangeObserver initWithWebView:]):
4083         (-[SelectionChangeObserver webView]):
4084         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
4085         (-[SelectionChangeObserver currentSelectionAttributes]):
4086
4087 2019-01-14  Zalan Bujtas  <zalan@apple.com>
4088
4089         [LFC][BFC] Add basic box-sizing support.
4090         https://bugs.webkit.org/show_bug.cgi?id=193392
4091
4092         Reviewed by Antti Koivisto.
4093
4094         * LayoutReloaded/misc/LFC-passing-tests.txt:
4095
4096 2019-01-14  Charlie Turner  <cturner@igalia.com>
4097
4098         [WPE] API test gardening
4099         https://bugs.webkit.org/show_bug.cgi?id=193319
4100
4101         Reviewed by Michael Catanzaro.
4102
4103         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
4104         passing tests.
4105
4106 2019-01-14  Charlie Turner  <cturner@igalia.com>
4107
4108         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
4109         https://bugs.webkit.org/show_bug.cgi?id=192977
4110
4111         Reviewed by Carlos Garcia Campos.
4112
4113         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
4114         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4115         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
4116         (TestWebKitAPI::GStreamerTest::SetUp):
4117         (TestWebKitAPI::GStreamerTest::TearDown):
4118         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
4119         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
4120         (TestWebKitAPI::TEST_F):
4121
4122 2019-01-14  Charlie Turner  <cturner@igalia.com>
4123
4124         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
4125         https://bugs.webkit.org/show_bug.cgi?id=193332
4126
4127         Reviewed by Michael Catanzaro.
4128
4129         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
4130         defined as a char16_t, which changed in ICU 59, the
4131         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
4132         unsigned short. This test is relying on the behaviour that
4133         UChar=unsigned short, which doesn't hold across platforms and ICU
4134         library versions. The full fix would be a special syntax for
4135         literal characters so that these ambiguities do not arise. That
4136         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
4137         (TestWebKitAPI::TEST):
4138
4139 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4140
4141         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
4142
4143         * Scripts/make-dist:
4144         (Distcheck.configure):
4145
4146 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
4147
4148         [ews-build] Update macOS queue configurations
4149         https://bugs.webkit.org/show_bug.cgi?id=193365
4150         <rdar://problem/47221073>
4151
4152         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
4153
4154         * BuildSlaveSupport/ews-build/config.json:
4155
4156 2019-01-13  Zalan Bujtas  <zalan@apple.com>
4157
4158         [LFC] Adjust assert for statically positioned fixed elements
4159         https://bugs.webkit.org/show_bug.cgi?id=193385
4160
4161         Reviewed by Antti Koivisto.
4162
4163         * LayoutReloaded/misc/LFC-passing-tests.txt:
4164
4165 2019-01-13  Philippe Normand  <pnormand@igalia.com>
4166
4167         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
4168         https://bugs.webkit.org/show_bug.cgi?id=193387
4169
4170         Reviewed by Carlos Garcia Campos.
4171
4172         * MiniBrowser/wpe/main.cpp:
4173         (main):
4174
4175 2019-01-12  Timothy Hatcher  <timothy@apple.com>
4176
4177         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4178         https://bugs.webkit.org/show_bug.cgi?id=191655
4179         rdar://problem/46074680
4180
4181         Reviewed by Megan Gardner.
4182
4183         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
4184         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4185
4186 2019-01-12  Dan Bernstein  <mitz@apple.com>
4187
4188         [Cocoa] Avoid importing directly from subumbrella frameworks
4189         https://bugs.webkit.org/show_bug.cgi?id=186016
4190         <rdar://problem/40591038>
4191
4192         Reviewed by Sam Weinig.
4193
4194         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4195           LaunchServices header.
4196         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4197           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4198         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4199           when using SDKs earlier than 10.13.
4200         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4201           and OTHER_CPLUSPLUSFLAGS.
4202         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4203           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4204         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4205           LaunchServices header.
4206
4207 2019-01-11  John Wilander  <wilander@apple.com>
4208
4209         Compile out Web API Statistics Collection
4210         https://bugs.webkit.org/show_bug.cgi?id=193370
4211         <rdar://problem/45388584>
4212
4213         Reviewed by Brent Fulgham.
4214
4215         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4216             Defined ENABLE_WEB_API_STATISTICS, off by default.
4217
4218 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4219
4220         [WPE] Add gtk-doc
4221         https://bugs.webkit.org/show_bug.cgi?id=178900
4222
4223         Reviewed by Michael Catanzaro.
4224
4225         Add Tools/gtkdoc to manifest.txt.in files.
4226         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4227
4228         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4229         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4230
4231 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4232
4233         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
4234         https://bugs.webkit.org/show_bug.cgi?id=193364
4235         <rdar://problem/47214117>
4236
4237         Reviewed by Tim Horton.
4238
4239         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
4240         precise, whereas dragging near the middle of the textarea does.
4241
4242         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4243         (TestWebKitAPI::TEST):
4244
4245 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4246
4247         webkitpy: Support alternate simctl device list output
4248         https://bugs.webkit.org/show_bug.cgi?id=193362
4249         <rdar://problem/47122965>
4250
4251         Reviewed by Lucas Forschler.
4252
4253         * Scripts/webkitpy/xcode/simulated_device.py:
4254         (SimulatedDeviceManager.populate_available_devices):
4255
4256 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
4257
4258         [ews-build] Update macOS queue configurations
4259         https://bugs.webkit.org/show_bug.cgi?id=193365
4260
4261         Reviewed by Lucas Forschler.
4262
4263         * BuildSlaveSupport/ews-build/config.json:
4264
4265 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4266
4267         webkitpy: Incorporate device type into baseline search path
4268         https://bugs.webkit.org/show_bug.cgi?id=193356
4269         <rdar://problem/47215515>
4270
4271         Reviewed by Lucas Forschler.
4272
4273         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
4274
4275         * Scripts/webkitpy/port/base.py:
4276         (Port.default_baseline_search_path): Allow device type to be passed in.
4277         * Scripts/webkitpy/port/gtk.py:
4278         (GtkPort.default_baseline_search_path): Ignore device type.
4279         * Scripts/webkitpy/port/ios.py:
4280         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
4281         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
4282         * Scripts/webkitpy/port/ios_device_unittest.py:
4283         (IOSDeviceTest):
4284         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4285         (IOSSimulatorTest):
4286         * Scripts/webkitpy/port/mac.py:
4287         (MacPort.default_baseline_search_path): Ignore device type.
4288         * Scripts/webkitpy/port/watch.py:
4289         (WatchPort.default_baseline_search_path): Ditto.
4290         * Scripts/webkitpy/port/win.py:
4291         (WinPort.default_baseline_search_path): Ditto.
4292         (WinCairoPort.default_baseline_search_path): Ditto.
4293         * Scripts/webkitpy/port/wpe.py:
4294         (WPEPort.default_baseline_search_path): Ditto.
4295
4296 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4297
4298         webkitpy: Print abbreviated baseline search path that includes only folders that exist
4299         https://bugs.webkit.org/show_bug.cgi?id=193352
4300         <rdar://problem/47210736>
4301
4302         Reviewed by Lucas Forschler.
4303
4304         * Scripts/webkitpy/layout_tests/views/printing.py:
4305         (Printer.print_config): Print list on only baseline search paths which exist. 
4306         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4307         (Testprinter.test_print_config):
4308
4309 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
4310
4311         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
4312         https://bugs.webkit.org/show_bug.cgi?id=193340
4313
4314         Reviewed by David Kilzer.
4315
4316         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4317         (WTR::InjectedBundle::didReceiveMessageToPage):
4318         Pull the strings out into a WKRetainPtr.
4319
4320         * WebKitTestRunner/WebNotificationProvider.cpp:
4321         (WTR::WebNotificationProvider::closeWebNotification):
4322         Adopt the created value into the WKRetainPtr.
4323
4324         * WebKitTestRunner/mac/TestControllerMac.mm:
4325         (WTR::generateWhitelist):
4326         Immediately adopt a created value to avoid potential mistakes.
4327
4328 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
4329
4330         Enable DFG on ARM/Linux again
4331         https://bugs.webkit.org/show_bug.cgi?id=192496
4332
4333         Reviewed by Yusuke Suzuki.
4334
4335         After changing the bytecode format DFG was disabled on all 32-bit
4336         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4337         on ARM by default.
4338
4339         * Scripts/run-jsc-stress-tests:
4340
4341 2019-01-11  Timothy Hatcher  <timothy@apple.com>
4342
4343         Unreviewed, fix #ifdef in API test added in r239851.
4344         https://bugs.webkit.org/show_bug.cgi?id=193327
4345         rdar://problem/47093222
4346
4347         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
4348
4349 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4350
4351         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
4352         https://bugs.webkit.org/show_bug.cgi?id=193109
4353