0649f22d05552f171ad89c5898ff35141a82107e
[WebKit-https.git] / Tools / ChangeLog
1 2016-06-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2
3         [GTK] Update YouCompleteMe script to make all include paths absolute
4         https://bugs.webkit.org/show_bug.cgi?id=158301
5
6         Reviewed by Michael Catanzaro.
7
8         Before this patch, some include paths were not made absolute.
9         This could make YouCompleteMe plugin to fail extracting information or validating cpp files.
10
11         * gtk/ycm_extra_conf.py:
12
13 2016-06-03  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
14
15         Unreviewed: add myself to the committers list.
16
17         * Scripts/webkitpy/common/config/contributors.json:
18
19 2016-06-02  Per Arne Vollan  <pvollan@apple.com>
20
21         [Win] Fetch API tests are failing.
22         https://bugs.webkit.org/show_bug.cgi?id=158296
23
24         Reviewed by Alex Christensen.
25
26         Enable Fetch API when running tests.
27
28         * DumpRenderTree/win/DumpRenderTree.cpp:
29         (resetWebPreferencesToConsistentValues):
30
31 2016-06-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
32
33         Really display failing JSC stress tests in buildbot dashboard
34         https://bugs.webkit.org/show_bug.cgi?id=158324
35
36         Reviewed by Alexey Proskuryakov.
37
38         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
39         (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
40         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
41         (BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
42         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
43         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
44         membership in array.
45         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
46         generated after the first time.
47         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
48         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
49
50 2016-06-02  Michael Saboff  <msaboff@apple.com>
51
52         [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
53         https://bugs.webkit.org/show_bug.cgi?id=158317
54
55         Reviewed by Saam Barati.
56
57         Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
58         variant.
59
60         * Scripts/run-jsc-stress-tests:
61
62 2016-06-02  Aakash Jain  <aakash_jain@apple.com>
63
64         LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
65         https://bugs.webkit.org/show_bug.cgi?id=158305
66
67         Reviewed by Alexey Proskuryakov.
68
69         * Scripts/webkitpy/port/ios.py:
70         (IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
71
72 2016-06-01  Brian Burg  <bburg@apple.com>
73
74         REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields
75         https://bugs.webkit.org/show_bug.cgi?id=158227
76         <rdar://problem/26232464>
77
78         Reviewed by Alexey Proskuryakov.
79
80         Add a regression test that runs on Mac only.
81
82         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
83         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added.
84         (-[DummyNavigationDelegate webView:didFinishNavigation:]):
85         (TEST):
86         * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added.
87
88 2016-06-01  Chris Fleizach  <cfleizach@apple.com>
89
90         AX: iOS: VoiceOver can't access attachments in mail messages
91         https://bugs.webkit.org/show_bug.cgi?id=158198
92
93         Reviewed by Joanmarie Diggs.
94
95         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
96         (AccessibilityUIElement::stringForRange):
97         (AccessibilityUIElement::attributedStringForRange):
98         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
99         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
100         (WTR::AccessibilityUIElement::attributedStringForRange):
101         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
102
103 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
104
105         Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow.
106
107         It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the
108         timeout is applied per tester program not per test case, so we need to mark the whole test
109         WebKit2Gtk/TestInspectorServer as slow.
110
111         * Scripts/run-gtk-tests:
112         (TestRunner):
113         (TestRunner._run_test_glib):
114
115 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
116
117         Unreviewed. Skip media permission request GTK+ unit tests.
118
119         They are timing out in the bots.
120
121         * Scripts/run-gtk-tests:
122         (TestRunner):
123
124 2016-05-31  Jer Noble  <jer.noble@apple.com>
125
126         Yet another unreviewed build fix; move the closing brace of the namespace declaration inside
127         the #if check.
128
129         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
130
131 2016-05-31  Jer Noble  <jer.noble@apple.com>
132
133         Further unreviewed build fix; only run FullscreenTopContentInset test on Mac.
134
135         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
136
137 2016-05-31  Jer Noble  <jer.noble@apple.com>
138
139         Unreviewed build fix; only run FullscreetTopContentInset test on platforms
140         where WK_API_ENABLED is set.
141
142         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
143
144 2016-05-31  Jer Noble  <jer.noble@apple.com>
145
146         REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
147         https://bugs.webkit.org/show_bug.cgi?id=158156
148         <rdar://problem/26519589>
149
150         Reviewed by Darin Adler.
151
152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
153         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
154         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
155         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
156         (TestWebKitAPI::TEST):
157
158 2016-05-31  Jon Lee  <jonlee@apple.com>
159
160         Unreviewed: add myself to the reviewers list.
161
162         * Scripts/webkitpy/common/config/contributors.json:
163
164 2016-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
165
166         [GTK] Provide alternative mirror for the ICU tarball.
167         https://bugs.webkit.org/show_bug.cgi?id=154530
168
169         Unreviewed.
170
171         * gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having
172         a hard time trying to download the ICU tarball from download.icu-project.org
173         (which redirects to sourceforge and gives problems with something related to
174         SSL). Provide this alternative mirror to make things working back.
175
176 2016-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
177
178         [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
179         https://bugs.webkit.org/show_bug.cgi?id=158200
180
181         Reviewed by Philippe Normand.
182
183         This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case
184         POSITION_UNAVAILABLE is returned without asking the API layer.
185
186         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
187         (testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns
188         POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the
189         document title, and use user script messages that are more reliable instead.
190
191 2016-05-28  Aakash Jain  <aakash_jain@apple.com>
192
193         tests fail if display sleeps while run-webkit-tests is running
194         https://bugs.webkit.org/show_bug.cgi?id=153919
195
196         Reviewed by Darin Adler.
197
198         * DumpRenderTree/mac/LayoutTestHelper.m:
199         (addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
200
201 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
202
203         Display failing JSC stress tests in buildbot dashboard
204         https://bugs.webkit.org/show_bug.cgi?id=156595
205
206         Reviewed by Alexey Proskuryakov.
207
208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
209         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
210         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
212         (BuildbotCombinedQueueView.prototype.update):
213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
214         (BuildbotIteration):
215         (BuildbotIteration.prototype._parseData):
216         (BuildbotIteration.prototype.loadLayoutTestResults):
217         (BuildbotIteration.prototype.):
218         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults):
219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
220         (BuildbotQueueView.prototype._createLoadingIndicator):
221         (BuildbotQueueView.prototype.):
222         (BuildbotQueueView.prototype._onPopoverCopy):
223         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions):
224         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions):
225         (BuildbotQueueView.prototype._addIterationHeadingToPopover):
226         (BuildbotQueueView.prototype._testStepFailureDescription):
227         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount):
228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
229         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
231         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
232         (BuildbotTesterQueueView.prototype.update):
233         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
234         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions):
235         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted.
236         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted.
237         (BuildbotTesterQueueView.prototype.): Deleted.
238         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted.
239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:
240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
241         (MockBuildbot):
242         (MockBuildbot.prototype.buildPageURLForIteration):
243         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
244         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
246         (MockBuildbotQueue):
247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
248         (MockBuildbotTestResults):
249         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
252
253 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
254
255         Display failing JSC stress tests in buildbot dashboard
256         https://bugs.webkit.org/show_bug.cgi?id=156595
257
258         Reviewed by Alexey Proskuryakov.
259
260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
261         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Generate the URL for raw JSON output of
262         JSC tests.
263         (Buildbot.prototype.javaScriptCoreTestStdioURLForIteration): Generate the URL for human-readable stdio output
264         of JSC tests.
265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
266         (BuildbotCombinedQueueView.prototype.update): Display JSC test results in popover.
267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
268         (BuildbotIteration): Add javaScriptCoreTestResults variable.
269         (BuildbotIteration.prototype.): Check for javascriptcore tests step.
270         (BuildbotIteration.prototype.loadLayoutTestResults): Add comma at closing brace.
271         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): Fetch JSON from Buildbot server.
272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
273         (BuildbotQueueView.prototype._createLoadingIndicator): Reusable function.
274         (BuildbotQueueView.prototype._onPopoverCopy): Reusable copy event handler to allow accurate copying of text
275         from popovers.
276         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Generates the popover bubble's
277         inner HTML from the JSC failure data.
278         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Generate the popover bubble
279         for JSC results and handle request failures.
280         (BuildbotQueueView.prototype._testStepFailureDescription): Moved from subclass.
281         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): Moved from subclass.
282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
283         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Parse JSON into a list of failing tests.
284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
285         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Instantiate PopoverTrackers for builds whose 
286         only failures are JSC tests.
287         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Use _onPopoverCopy.
288         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Use _createLoadingIndicator.
289         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. Moved to superclass.
290         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. Moved to superclass.
291         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. Using superclass's reusable function as copy handler instead.
292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Add new script files.
293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Added.
294         (MockBuildbot): Mocked version of Buildbot, only containing URL methods.
295         (MockBuildbot.prototype.buildPageURLForIteration): Same as real Buildbot.js
296         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Points to local file containing JSON for test.
297         (MockBuildbot.prototype.javaScriptCoreTestStdioURLForIteration): Same as real Buildbot.js
298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
299         (MockBuildbotQueue): Use a MockBuildbot() instead of a string.
300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Added.
301         (MockBuildbotTestResults): Mocked version of BuildbotTestResults.
302         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Sets the 'regressions' variable.
303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Add four groups of tests.
305
306 2016-05-27  Chris Dumez  <cdumez@apple.com>
307
308         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables
309         https://bugs.webkit.org/show_bug.cgi?id=158111
310
311         Reviewed by Darin Adler.
312
313         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables.
314         These are often used cross-thread and copying the captured lambda variables can be
315         dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon
316         capture).
317
318         * WebKitTestRunner/TestController.cpp:
319         (WTR::TestController::decidePolicyForNavigationAction):
320
321 2016-05-27  Brady Eidson  <beidson@apple.com>
322
323         Modern IDB: After closing a Netflix video, trying to watch it again fails.
324         <rdar://problem/25092473> and https://bugs.webkit.org/show_bug.cgi?id=158160
325
326         Reviewed by Alex Christensen.
327
328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
329         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added.
330         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added.
331         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added.
332
333 2016-05-27  Joanmarie Diggs  <jdiggs@igalia.com>
334
335         AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
336         https://bugs.webkit.org/show_bug.cgi?id=158152
337
338         Reviewed by Chris Fleizach.
339
340         The failure is actually a bug fix because only one child is being added, but two
341         notifications were being emitted. Now there is only one notification. To verify
342         this was the case, we really should examine the child reportedly being added. That
343         child is the ATK event's any_data, so pass along that child to the listener.
344
345         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
346
347 2016-05-26  Alex Christensen  <achristensen@webkit.org>
348
349         Expose content extension failure error codes in SPI
350         https://bugs.webkit.org/show_bug.cgi?id=158095
351         rdar://problem/26475651
352
353         Reviewed by Anders Carlsson.
354
355         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
356         (checkDomain):
357         (TEST_F):
358         Add tests that use the new enum.
359
360 2016-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
361
362         New intl-numberformat.js test fails on many Linux platforms
363         https://bugs.webkit.org/show_bug.cgi?id=154530
364
365         Reviewed by Darin Adler.
366
367         The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of
368         icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal
369         jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is.
370
371         * gtk/jhbuild.modules:
372
373 2016-05-26  Yusuke Suzuki  <utatane.tea@gmail.com>
374
375         [JSC] Allow JSBench to use precise time
376         https://bugs.webkit.org/show_bug.cgi?id=158050
377
378         Reviewed by Geoffrey Garen.
379
380         JSBench use `new Date().getTime()` without options and there is no way to use precise time.
381         This patch modifies the JSBench code to inject the code taking the precise time.
382         `currentTimeInMS` is given by the benchmerk harness and JSBench uses it.
383         run-jsc-benchmark switches this function's implementation between `Date.now()` and
384         testRunner's precise time one.
385
386         While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and
387         the contents are not changed for a long time. As described in the original paper[1], the
388         tests can be generated by using JSBench's record & replay system, but in that case, we can
389         adopt this modification by changing the tool side.
390
391         We also add currentTimeInMS implementation in harness.js and u?rem.js directly.
392         u?rem.js implementation is required when it is executed in u?rem.html without harness.
393         And harness.js implementation is required when it is executed in the JSBench's harness.
394         In these implementation, we follow the JetStream's time measuring function: performance.now(),
395         preciseTime(), or Date.now().
396
397         [1]: http://dl.acm.org/citation.cfm?id=2048119
398
399         * Scripts/run-jsc-benchmarks:
400
401 2016-05-26  Brent Fulgham  <bfulgham@apple.com>
402
403         Unreviewed test fix after r201427.
404         https://bugs.webkit.org/show_bug.cgi?id=157423
405         <rdar://problem/23751632>
406
407         A debug assertion was firing during some test runs due to the Geolocation permission
408         being turned off during the test. The timer logic was originally written to assert
409         if the timer fired when permissions were disabled. But this is no longer valid,
410         because we expect the Geolocation system to be active and become deactivated if the
411         browsing context violates one of the security criteria.
412
413         * DumpRenderTree/mac/UIDelegate.mm:
414         (-[UIDelegate timerFired]): Remove invalid assertion.
415
416 2016-05-26  Filip Pizlo  <fpizlo@apple.com>
417
418         ScopedLambda should have a lifetime story that makes sense to the compiler
419         https://bugs.webkit.org/show_bug.cgi?id=158118
420
421         Reviewed by Mark Lam.
422         
423         Added a test case. This test crashes before the fix and now it passes.
424
425         * TestWebKitAPI/CMakeLists.txt:
426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
427         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added.
428         (TestWebKitAPI::TEST):
429
430 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
431
432         Build fix
433
434         Rubber stamped by Lucas Forschler.
435
436         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
437         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
438
439 2016-05-25  Anders Carlsson  <andersca@apple.com>
440
441         Get rid of WTF/Functional.h
442         https://bugs.webkit.org/show_bug.cgi?id=158081
443
444         Reviewed by Chris Dumez.
445
446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
447         * TestWebKitAPI/Tests/WTF/Functional.cpp: Removed.
448         (TestWebKitAPI::returnFortyTwo): Deleted.
449         (TestWebKitAPI::TEST): Deleted.
450         (TestWebKitAPI::multiplyByTwo): Deleted.
451         (TestWebKitAPI::multiplyByOneAndAHalf): Deleted.
452         (TestWebKitAPI::multiply): Deleted.
453         (TestWebKitAPI::subtract): Deleted.
454         (TestWebKitAPI::A::A): Deleted.
455         (TestWebKitAPI::A::f): Deleted.
456         (TestWebKitAPI::A::addF): Deleted.
457         (TestWebKitAPI::B::B): Deleted.
458         (TestWebKitAPI::B::~B): Deleted.
459         (TestWebKitAPI::B::ref): Deleted.
460         (TestWebKitAPI::B::deref): Deleted.
461         (TestWebKitAPI::B::f): Deleted.
462         (TestWebKitAPI::B::g): Deleted.
463         (TestWebKitAPI::Number::create): Deleted.
464         (TestWebKitAPI::Number::~Number): Deleted.
465         (TestWebKitAPI::Number::value): Deleted.
466         (TestWebKitAPI::Number::Number): Deleted.
467         (TestWebKitAPI::multiplyNumberByTwo): Deleted.
468
469 2016-05-25  Daniel Bates  <dabates@apple.com> and Brent Fulgham  <bfulgham@apple.com>
470
471         [WebSockets] No infrastructure for testing secure web sockets (wss)
472         https://bugs.webkit.org/show_bug.cgi?id=157884
473         <rdar://problem/26477197>
474
475         Reviewed by Andy Estes.
476
477         Add support to webkitpy to start and stop a secure Web Socket server running on port 9323
478         using the certificate, private-key from file LayoutTests/http/conf/webkit-httpd.pem. Also
479         teaches run-webkit-httpd to start and stop the Web Socket servers.
480
481         Modify DumpRenderTree and WebKitTestRunner to understand a new testRunner method,
482         'setAllowsAnySSLCertificate', which allows us to use the same self-signed test certificate
483         we do for our HTTPS tests.
484         
485         * DumpRenderTree/TestRunner.cpp:
486         (setAllowsAnySSLCertificateCallback):
487         (TestRunner::setAllowsAnySSLCertificate):
488         * DumpRenderTree/TestRunner.h:
489         * DumpRenderTree/mac/DumpRenderTree.mm:
490         (resetWebViewToConsistentStateBeforeTesting): Make sure we turn off the new flag between tests.
491         * Scripts/run-webkit-httpd:
492         (main): Start the websocket server at launch.
493         * Scripts/webkitpy/layout_tests/controllers/manager.py:
494         (Manager.__init__): Remove dead code.
495         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
496         (PyWebSocket.__init__): Cleanup code.
497         (PyWebSocket): Pass '--tls-client-ca' to start command.
498         (PyWebSocket._prepare_config): Cleanups.
499         * Scripts/webkitpy/port/base.py:
500         (Port.to.start_http_server):
501         (Port.to):
502         (Port.to._extract_certificate_from_pem): Added.
503         (Port.to._extract_private_key_from_pem): Added.
504         (Port.to.start_websocket_server): Start secure socket server.
505         (Port.to.stop_websocket_server): Stop secure socket server.
506         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add new API.
507         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
508         (WTR::InjectedBundle::setAllowsAnySSLCertificate): Added.
509         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
510         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
511         (WTR::TestRunner::setAllowsAnySSLCertificate): Added.
512         * WebKitTestRunner/InjectedBundle/TestRunner.h:
513
514 2016-05-25  Keith Miller  <keith_miller@apple.com>
515
516         run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
517         https://bugs.webkit.org/show_bug.cgi?id=158077
518
519         Reviewed by Mark Lam.
520
521         Since we didn't have JSBench in the tree before we needed to lookup the path to it from
522         benchmark config file. That's no longer the case so we should just fix it in the script.
523
524         * Scripts/run-jsc-benchmarks:
525
526 2016-05-24  Aakash Jain  <aakash_jain@apple.com>
527
528         Reorganize dashboard code: move code from _timeIntervalString to base class
529         https://bugs.webkit.org/show_bug.cgi?id=158047
530         rdar://problem/26457274
531
532         Reviewed by Alexey Proskuryakov and Dean Johnson.
533
534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
535         (BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
536         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
537         (QueueView.prototype._readableTimeString): Same.
538
539 2016-05-24  Yusuke Suzuki  <utatane.tea@gmail.com>
540
541         [JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports
542         https://bugs.webkit.org/show_bug.cgi?id=158016
543
544         Reviewed by Darin Adler.
545
546         This patch easily allows run-jsc-benchmark to run WebKitTestRunner-based tests in GTK / EFL ports.
547         This change encourages us to run tests with the browser-heap in nix environments.
548         Two things are modified.
549
550         1. Add a fall-back to look up the library path in GTK / EFL / JSCOnly environment.
551
552             In GTK / EFL / JSCOnly ports, the hierarchy of the build directory is slightly different from Apple port.
553             For example, the jsc bin locate at "WebKitBuild/XXX/Release/bin/jsc" and the lib path is "WebKitBuild/XXX/Release/lib"
554             while the one of Apple port is "WebKitBuild/XXX/Release/jsc" and "WebKitBuild/XXX/Release/lib".
555             And based on this library path, we configure the required environment variables to run WebKitTestRunner in GTK / EFL ports.
556
557         2. Add --dependencies option to add dependent library paths.
558
559             While Apple ports does not require any additional dependent library path, GTK and EFL ports require this path,
560             typically WebKitBuild/DependenciesGTK and WebKitBuild/DependenciesEFL respectively. So we need to add such paths to LD_LIBRARY_PATH.
561             Instead of adding platform options like --gtk / --efl, we add --dependencies option to add the additional dependent library paths.
562             The platform options still require the build path to look up the dependent library directory. So we pass it directly through --dependencies.
563             Multiple additional dependent library paths can be added by using --dependencies multiple times.
564
565         By using these change, we can run benchmarks that require WebKitTestRunner in GTK / EFL ports (If you would like to run them in a headless manner, you can use xvbuf.).
566         Example:
567             `Tools/Scripts/run-jsc-benchmarks baseline:WebKitBuild/baseline/Release/bin/WebKitTestRunner patched:WebKitBuild/patched/Release/bin/WebKitTestRunner --dependencies WebKitBuild/DependenciesGTK/Root/lib --js-bench`
568
569         * Scripts/run-jsc-benchmarks:
570
571 2016-05-20  Keith Miller  <keith_miller@apple.com>
572         We should have JSBench in PerformanceTests
573         https://bugs.webkit.org/show_bug.cgi?id=157952
574
575         Rubber-stamped by Saam Barati.
576
577         This changes the runner to use the layout of the newest version of JSBench.
578
579         * Scripts/run-jsc-benchmarks:
580
581 2016-05-24  Chris Dumez  <cdumez@apple.com>
582
583         Use auto for some of our lambda function parameters
584         https://bugs.webkit.org/show_bug.cgi?id=158001
585
586         Reviewed by Darin Adler.
587
588         Use auto for some of our lambda function parameters now that we build with c++14.
589
590         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
591         (WTR::InjectedBundle::willDestroyPage):
592
593 2016-05-23  Brady Eidson  <beidson@apple.com>
594
595         check-webkit-style gets flags std::literals::chrono_literals as bad naming.
596         https://bugs.webkit.org/show_bug.cgi?id=157969
597
598         Reviewed by Alex Christensen.
599
600         * Scripts/webkitpy/style/checkers/cpp.py:
601         (check_identifier_name_in_declaration):
602         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
603         (WebKitStyleTest.test_names):
604
605 2016-05-22  Alexey Proskuryakov  <ap@apple.com>
606
607         RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
608         https://bugs.webkit.org/show_bug.cgi?id=157977
609         rdar://problem/20874156
610
611         Reviewed by David Kilzer.
612
613         * WebKitTestRunner/TestInvocation.cpp:
614         (WTR::TestInvocation::invoke): Be more certain to launch a new process when there was
615         a timeout detected. If we don't, there is a chance that the process is not quite frozen,
616         and will still send a response that we no longer expect.
617         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr
618         too, as stdout is not available, at least not in the case that I was observing.
619
620 2016-05-22  Brady Eidson  <beidson@apple.com>
621
622         Move to C++14.
623         https://bugs.webkit.org/show_bug.cgi?id=157948
624
625         Reviewed by Michael Catanzaro.
626
627         * DumpRenderTree/mac/Configurations/Base.xcconfig:
628         * MiniBrowser/Configurations/Base.xcconfig:
629         * TestWebKitAPI/Configurations/Base.xcconfig:
630         * WebKitTestRunner/Configurations/Base.xcconfig:
631
632 2016-05-21  Aakash Jain  <aakash_jain@apple.com>
633
634         Simulator launch fails intermittently due to failure in checking simulator boot status
635         https://bugs.webkit.org/show_bug.cgi?id=157965
636         rdar://problem/26402404
637
638         Reviewed by Alexey Proskuryakov.
639
640         * Scripts/webkitpy/xcode/simulator.py:
641         (Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
642         whether simulator has finished booting.
643
644 2016-05-21  Dan Bernstein  <mitz@apple.com>
645
646         Silence warnings from svn propget when using newer versions of Subversion.
647         https://bugs.webkit.org/show_bug.cgi?id=157879
648
649         Reviewed by Daniel Bates.
650
651         * Scripts/prepare-ChangeLog:
652         (attributeCommand): Redirect svn propget stderr to /dev/null.
653         * Scripts/svn-create-patch:
654         (findMimeType): Ditto.
655
656 2016-05-20  Ryosuke Niwa  <rniwa@webkit.org>
657
658         run-benchmark's results should contain Animometer's debug output
659         https://bugs.webkit.org/show_bug.cgi?id=157941
660
661         Reviewed by Stephanie Lewis.
662
663         Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
664         The result can be dragged and dropped into Animometer's developer.html page.
665
666         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
667         (BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
668         (BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.
669         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
670         Modified the patch to store the debug output.
671         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
672         (ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
673         when the request body is larger than a certain size on twisted.
674
675 2016-05-20  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
676
677         Use clearer names for JSON output of javascriptcore test results
678         https://bugs.webkit.org/show_bug.cgi?id=157921
679
680         Reviewed by Alexey Proskuryakov.
681
682         "failures" and "apiTestResult" were somewhat ambiguous names. 
683         
684         * Scripts/run-javascriptcore-tests:
685         (runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".
686
687 2016-05-20  Chris Dumez  <cdumez@apple.com>
688
689         Unreviewed, fix API test introduced in r201213.
690
691         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
692         (TestWebKitAPI::TEST):
693
694 2016-05-20  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
695
696         Implement operator== for WeakPtr
697         https://bugs.webkit.org/show_bug.cgi?id=157883
698
699         Reviewed by Chris Dumez.
700
701         Implement operator== and operator!= for WeakPtr and update code to use the operators.
702
703         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
704         (TestWebKitAPI::TEST):
705
706 2016-05-19  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
707
708         Add JSON results to 32-bit and CLoop JSC tests
709         https://bugs.webkit.org/show_bug.cgi?id=157929
710
711         Reviewed by Alexey Proskuryakov.
712
713         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
714         (RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
715         (Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
716
717 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
718
719         Typo fix in import-test262-tests
720         https://bugs.webkit.org/show_bug.cgi?id=157902
721
722         Reviewed by Keith Miller.
723
724         * Scripts/import-test262-tests:
725
726 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
727
728         [EFL] Fix the gst-libav build on ARM Thumb2 after r199649
729         https://bugs.webkit.org/show_bug.cgi?id=157893
730
731         Reviewed by Antonio Gomes.
732
733         * efl/patches/gst-libav.patch:
734
735 2016-05-19  Jer Noble  <jer.noble@apple.com>
736
737         REGRESSION(r200951): VideoControlsManager API tests time out
738         https://bugs.webkit.org/show_bug.cgi?id=157896
739         <rdar://problem/26326293>
740
741         Reviewed by Eric Carlson.
742
743         Explicitly disable user gesture requirements for playback.
744
745         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
746         (TestWebKitAPI::TEST):
747
748 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
749
750         Slow JSC stress tests times out in 32 bit debug mode
751         https://bugs.webkit.org/show_bug.cgi?id=154964
752
753         Reviewed by Michael Catanzaro.
754
755         * Scripts/run-javascriptcore-tests:
756         (runJSCStressTests): Pass through the --debug option.
757         * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
758
759 2016-05-18  Aakash Jain  <aakash_jain@apple.com>
760
761         Remove underline from Status Bubbles on dashboard
762         https://bugs.webkit.org/show_bug.cgi?id=157870
763         rdar://problem/26332321
764
765         Reviewed by Alexey Proskuryakov.
766
767         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style 
768         change made in http://trac.webkit.org/r200880
769
770 2016-05-18  Michael Saboff  <msaboff@apple.com>
771
772         r199812 broke test262
773         https://bugs.webkit.org/show_bug.cgi?id=157595
774
775         Reviewed by Filip Pizlo.
776
777         Added a new run type, runOneLargeHeap, for tests that use a large amount of memory.
778         This run type will not run with the --memory-limited option.  Without that option,
779         we'll only the default test variant.
780
781         * Scripts/run-jsc-stress-tests:
782
783 2016-05-18  Simon Fraser  <simon.fraser@apple.com>
784
785         REGRESSION (r200534) Command-+ no longer zooms pages 
786         https://bugs.webkit.org/show_bug.cgi?id=157826
787         rdar://problem/26334636
788
789         Reviewed by Dean Jackson.
790
791         * DumpRenderTree/mac/DumpRenderTree.mm:
792         (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).
793
794 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
795
796         [GTK] accessibility/meter-element.html is failing
797         https://bugs.webkit.org/show_bug.cgi?id=115633
798
799         Reviewed by Chris Fleizach.
800
801         Implement AccessibilityUIElement::valueDescription() and add mapping
802         from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
803
804         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
805         (WTR::AccessibilityUIElement::valueDescription):
806
807 2016-05-18  Brady Eidson  <beidson@apple.com>
808
809         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
810         https://bugs.webkit.org/show_bug.cgi?id=157823
811
812         Reviewed by Alex Christensen.
813
814         * DumpRenderTree/mac/TestRunnerMac.mm:
815         (TestRunner::clearAllDatabases):
816         
817         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
818         (WTR::TestRunner::clearAllDatabases):
819         
820         * WebKitTestRunner/TestInvocation.cpp:
821         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
822
823 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
824
825         AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
826         https://bugs.webkit.org/show_bug.cgi?id=157822
827
828         Reviewed by Chris Fleizach.
829
830         Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
831         nullptr upon failure.
832
833         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
834         (WTR::AccessibilityUIElement::helpText):
835
836 2016-05-17  Beth Dakin  <bdakin@apple.com>
837
838         Make handleAcceptedCandidate a public function
839         https://bugs.webkit.org/show_bug.cgi?id=157763
840         -and corresponding-
841         rdar://problem/26206397
842
843         Reviewed by Tim Horton.
844
845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
846         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added.
847         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added.
848         (-[DoNotLeakWebView dealloc]):
849         (-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
850         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
851         (TestWebKitAPI::TEST):
852
853 2016-05-17  Keith Miller  <keith_miller@apple.com>
854
855         Add test262 harness support code
856         https://bugs.webkit.org/show_bug.cgi?id=157797
857
858         Reviewed by Filip Pizlo.
859
860         The import-test262-tests script is used to generate the yaml file used to run test262. It
861         takes a path to the local copy of the Test262 repository as well as an optional path to file
862         containing a list of failures. This script currently just creates the yaml file used to run
863         the script. It does not relocate the test files into our tests directory. In the future I
864         plan to add that feature but it didn't seem essential for the first iteration. Since many
865         test262 tests need to be run in both strict and non-strict mode, import-test262-tests
866         creates two separate runs for those tests. This enables us to distinguish between failures
867         in only one of the two modes.
868
869         This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order
870         to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262
871         takes an actual test file along with the metadata associated with it. prepareTest262Fixture
872         takes a fixture file (used by module tests for importing) and makes sure that file is
873         properly relocated to the test runner directory.
874
875         The proccess I used to import the tests was to first run import-test262-tests to create a
876         yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is
877         passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the
878         output to a file and collected all the lines with "FAIL" in it. Finally, I reran
879         import-test262-tests with the new failure file to create the final yaml.
880
881         * Scripts/import-test262-tests: Added.
882         * Scripts/run-jsc-stress-tests:
883
884 2016-05-16  Enrica Casucci  <enrica@apple.com>
885
886         build fix after r200968 and r200969
887
888         Unreviewed.
889
890         * DumpRenderTree/mac/EventSendingController.mm:
891         (-[EventSendingController keyDown:withModifiers:withLocation:]):
892
893 2016-05-16  Jer Noble  <jer.noble@apple.com>
894
895         API test WebKit2.MSEIsPlayingAudio timing out after r200951
896         https://bugs.webkit.org/show_bug.cgi?id=157748
897
898         Reviewed by Eric Carlson.
899
900         The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the
901         "user gesture" check fails at that point.  Call play() up front; playback will begin as soon
902         as enough data is loaded.
903
904         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html:
905
906 2016-05-16  Enrica Casucci  <enrica@apple.com>
907
908         Remove unused initializer for WebEvent on iOS.
909         https://bugs.webkit.org/show_bug.cgi?id=157689
910
911         Reviewed by Anders Carlsson.
912
913         Adopting different initializer for WebEvent to fix the build.
914
915         * DumpRenderTree/mac/EventSendingController.mm:
916         (-[EventSendingController keyDown:withModifiers:withLocation:]):
917
918 2016-05-16  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
919
920         Add machine-readable results for JSC API tests to the Buildbot json log
921         https://bugs.webkit.org/show_bug.cgi?id=157642
922
923         Reviewed by Geoffrey Garen.
924
925         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
926         (RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests
927         * Scripts/run-javascriptcore-tests:
928         (runJSCStressTests): Abstracted out writing JSON to file (new function below)
929         (writeJsonDataIfApplicable): Added
930
931 2016-04-06  Jer Noble  <jer.noble@apple.com>
932
933         [WK2] Add API to WKWebViewConfiguration to control autoplay policy.
934         https://bugs.webkit.org/show_bug.cgi?id=156312
935
936         Reviewed by Dan Bernstein.
937
938         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
939         (WTR::initializeWebViewConfiguration):
940         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
941         (TEST_F):
942
943 2016-05-16  Brent Fulgham  <bfulgham@apple.com>
944
945         REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays
946         https://bugs.webkit.org/show_bug.cgi?id=157630
947         <rdar://problem/25277577>
948
949         Reviewed by Simon Fraser.
950
951         Update test infrastructure to support checking the number of images in the pasteboard.
952
953         * DumpRenderTree/TestRunner.cpp:
954         (imageCountInGeneralPasteboardCallback): Added.
955         (TestRunner::staticFunctions):
956         * DumpRenderTree/TestRunner.h:
957         * DumpRenderTree/mac/TestRunnerMac.mm:
958         (TestRunner::imageCountInGeneralPasteboard): Added.
959         * DumpRenderTree/win/TestRunnerWin.cpp:
960         (TestRunner::imageCountInGeneralPasteboard): Added stub method.
961         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
962         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
963         (WTR::InjectedBundle::imageCountInGeneralPasteboard): Added.
964         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
965         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
966         (WTR::TestRunner::imageCountInGeneralPasteboard): Added.
967         * WebKitTestRunner/InjectedBundle/TestRunner.h:
968         * WebKitTestRunner/TestController.cpp:
969         (WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation.
970         * WebKitTestRunner/TestController.h:
971         * WebKitTestRunner/TestInvocation.cpp:
972         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message.
973         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
974         (WTR::TestController::imageCountInGeneralPasteboard): Added.
975
976 2016-05-13  Dewei Zhu  <dewei_zhu@apple.com>
977
978         Fix JSBench which causes math domain error in run-benchmark script.
979         https://bugs.webkit.org/show_bug.cgi?id=157697
980         <rdar://problem/26279292>
981
982         Reviewed by Ryosuke Niwa.
983
984         Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
985         Also fix a round-off error while calculating stdev.
986
987         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
988         (BenchmarkResults._format_values):
989         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
990
991 2016-05-13  Brady Eidson  <beidson@apple.com>
992
993         Extend protector naming code style guideline to cover operator= assignment.
994         https://bugs.webkit.org/show_bug.cgi?id=157693
995
996         Reviewed by Darin Adler.
997
998         * Scripts/webkitpy/style/checkers/cpp.py:
999         (check_identifier_name_in_declaration):
1000         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1001         (WebKitStyleTest.test_names):
1002
1003 2016-05-13  Aakash Jain  <aakash_jain@apple.com>
1004
1005         Dashboard code restructuring
1006         https://bugs.webkit.org/show_bug.cgi?id=157680
1007         <rdar://problem/14736888>
1008
1009         Reviewed by Alexey Proskuryakov.
1010
1011         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1012         (BubbleQueueView.prototype.addLinkToRow): Moved to base class.
1013         (BubbleQueueView.prototype.addTextToRow): Moved to base class.
1014         (BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
1015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1016         (BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1018         (BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1020         (BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1021         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1022         (BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
1023         additional argument.
1024         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
1025         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
1026         (BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
1027         (BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
1028         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1029         (documentReady): Display any customView if available.
1030         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1031         (QueueView.prototype.addLinkToRow): Moved from child class, no changes.
1032         (QueueView.prototype.addTextToRow): Moved from child class, no changes.
1033         (QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
1034         (QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
1035         by taking latestIterationGetter method as an argument.
1036         (QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
1037         (QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
1038         (QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
1039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1040         (a:hover:link): Underline only when there is a link.
1041
1042 2016-05-13  Yoav Weiss  <yoav@yoav.ws>
1043
1044         Turn on WEB_TIMING for all ports
1045         https://bugs.webkit.org/show_bug.cgi?id=157673
1046
1047         Reviewed by Alex Christensen.
1048
1049         * Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.
1050
1051 2016-05-13  Brady Eidson  <beidson@apple.com>
1052
1053         Protector Ref/RefPtrs should have a specified naming style.
1054         https://bugs.webkit.org/show_bug.cgi?id=157591
1055
1056         Reviewed by Darin Adler.
1057
1058         * Scripts/webkitpy/style/checkers/cpp.py:
1059         (check_identifier_name_in_declaration):
1060         (CppChecker):
1061         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1062         (WebKitStyleTest.test_names):
1063
1064 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
1065
1066         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
1067         https://bugs.webkit.org/show_bug.cgi?id=157564
1068
1069         Reviewed by Darin Adler.
1070
1071         * Scripts/webkitperl/FeatureList.pm:
1072         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1073
1074 2016-05-11  Joanmarie Diggs  <jdiggs@igalia.com>
1075
1076         [GTK] accessibility/aria-readonly.html is failing
1077         https://bugs.webkit.org/show_bug.cgi?id=98357
1078
1079         Reviewed by Chris Fleizach.
1080
1081         Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
1082         AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
1083         ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
1084         with range verification for inputs which implement AtkValue. The latter two
1085         additions are admittedly a heuristic workaround for platform accessibility
1086         API differences. But they should be sufficient to facilitate cross-platform
1087         testing of isAttributeSettable() for form elements which lack ARIA attributes.
1088
1089         Bump the minimum version of at-spi2-core and at-spi2-atk
1090         to 2.15.4 (earliest version that supports STATE_READ_ONLY).
1091
1092         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1093         (WTR::AccessibilityUIElement::isAttributeSettable):
1094         * gtk/jhbuild.modules:
1095
1096 2016-05-10  Ryan Haddad  <ryanhaddad@apple.com>
1097
1098         Another attempt to fix the build after r200668.
1099
1100         Unreviewed build fix.
1101
1102         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
1103         (TEST):
1104
1105 2016-05-10  Dan Bernstein  <mitz@apple.com>
1106
1107         Tried to fix the Mac build after r200668.
1108
1109         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1110         (WTR::TestController::platformCreateWebView):
1111
1112 2016-05-10  Sam Weinig  <sam@webkit.org>
1113
1114         Tweak underline style for data detected links
1115         https://bugs.webkit.org/show_bug.cgi?id=157546
1116
1117         Reviewed by Tim Horton.
1118
1119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/Tests/WebCore/Color.cpp: Added.
1121         (TestWebKitAPI::TEST):
1122         Add tests for the new Color::getHSV() function.
1123
1124 2016-05-10  Filip Pizlo  <fpizlo@apple.com>
1125
1126         Internal JSC profiler should have a timestamped log of events for each code block
1127         https://bugs.webkit.org/show_bug.cgi?id=157538
1128
1129         Reviewed by Benjamin Poulain.
1130
1131         * Scripts/display-profiler-output:
1132
1133 2016-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1134
1135         [Linux] Remove seccomp filters support
1136         https://bugs.webkit.org/show_bug.cgi?id=157380
1137
1138         Reviewed by Darin Adler.
1139
1140         * Scripts/webkitperl/FeatureList.pm:
1141         * TestWebKitAPI/PlatformEfl.cmake:
1142         * TestWebKitAPI/PlatformGTK.cmake:
1143         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed.
1144         * efl/jhbuild.modules:
1145         * gtk/jhbuild.modules:
1146
1147 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
1148
1149         [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling
1150         https://bugs.webkit.org/show_bug.cgi?id=157496
1151         rdar://problem/22963278
1152
1153         Reviewed by Tim Horton.
1154
1155         Enhance UIScriptController to generate a drag, which is useful for scrolling.
1156
1157         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1158         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1159         (WTR::UIScriptController::dragFromPointToPoint):
1160         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1161         * WebKitTestRunner/ios/HIDEventGenerator.h:
1162         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1163         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1164         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1165         (WTR::UIScriptController::dragFromPointToPoint):
1166
1167 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
1168
1169         Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
1170         https://bugs.webkit.org/show_bug.cgi?id=157480
1171
1172         Reviewed by Zalan Bujtas.
1173
1174         Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
1175         and move it next to the other iOS text autosizing tests.
1176         
1177         Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
1178
1179         * DumpRenderTree/TestRunner.cpp:
1180         (setTextAutosizingEnabledCallback): Deleted.
1181         (TestRunner::staticFunctions): Deleted.
1182         * DumpRenderTree/mac/TestRunnerMac.mm:
1183         (TestRunner::setTextAutosizingEnabled): Deleted.
1184
1185 2016-05-07  Darin Adler  <darin@apple.com>
1186
1187         Next step on dictionary bindings, along with other bindings refinements
1188         https://bugs.webkit.org/show_bug.cgi?id=157451
1189
1190         Reviewed by Chris Dumez.
1191
1192         * Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.
1193         Also skip test expectations in a directory that this was modifying unnecessarily.
1194
1195 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
1196
1197         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
1198         https://bugs.webkit.org/show_bug.cgi?id=157432
1199         rdar://problem/16406720
1200
1201         Reviewed by Dean Jackson.
1202
1203         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
1204
1205         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
1206         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
1207         These two settings are shared with TEXT_AUTOSIZING.
1208
1209         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
1210
1211         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
1212         without changes.
1213
1214         An implication of this set of changes is that the way clients enable text autosizing
1215         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
1216         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
1217         on iPhone only, not iPad.
1218
1219         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
1220         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
1221
1222         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
1223         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
1224         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
1225
1226         * DumpRenderTree/mac/DumpRenderTree.mm:
1227         (resetWebPreferencesToConsistentValues):
1228         * DumpRenderTree/mac/TestRunnerMac.mm:
1229         (TestRunner::setTextAutosizingEnabled):
1230         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1231         * WebKitTestRunner/ios/TestControllerIOS.mm:
1232         (WTR::TestController::platformResetPreferencesToConsistentValues):
1233
1234 2016-05-06  Dean Jackson  <dino@apple.com>
1235
1236         Regions, Shapes and Tracks don't need runtime features
1237         https://bugs.webkit.org/show_bug.cgi?id=157426
1238         <rdar://problem/26146262>
1239
1240         Reviewed by Simon Fraser.
1241
1242         The following RuntimeEnabledFeatures can be removed since
1243         we have no need to disable them (they are stable and have
1244         shipped for a while):
1245         - CSS Regions
1246         - CSS Shapes
1247         - Media tracks
1248
1249         * DumpRenderTree/mac/DumpRenderTree.mm:
1250         (resetWebPreferencesToConsistentValues): Deleted.
1251
1252 2016-05-06  Ryan Haddad  <ryanhaddad@apple.com>
1253
1254         Increase delay when launching multiple ios-simulators in parallel
1255         https://bugs.webkit.org/show_bug.cgi?id=157422
1256
1257         Reviewed by Alexey Proskuryakov.
1258
1259         Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening
1260         this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue.
1261
1262         * Scripts/webkitpy/port/ios.py:
1263         (IOSSimulatorPort.setup_test_run):
1264
1265 2016-05-06  Per Arne Vollan  <peavo@outlook.com>
1266
1267         [Win] Remove WinXP support.
1268         https://bugs.webkit.org/show_bug.cgi?id=157416
1269
1270         Reviewed by Brent Fulgham.
1271
1272         * win/DLLLauncher/DLLLauncherMain.cpp:
1273         (enableTerminationOnHeapCorruption):
1274
1275 2016-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
1276
1277         [css-grid] Unprefix CSS Grid Layout properties
1278         https://bugs.webkit.org/show_bug.cgi?id=157137
1279
1280         Reviewed by Simon Fraser.
1281
1282         Remove "-webkit" prefix from all the grid layout properties,
1283         including the display value.
1284         Update the source code to remove the prefix where it was used too.
1285
1286         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1287         (TestWebKitAPI::TEST):
1288
1289 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
1290
1291         Partially revert http://trac.webkit.org/r200504
1292         Improve HTTP test names in WebKitTestRunner's crash report information
1293         https://bugs.webkit.org/show_bug.cgi?id=157389
1294
1295         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs
1296         in crash reporter information.
1297
1298 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
1299
1300         Improve HTTP test names in WebKitTestRunner's crash report information
1301         https://bugs.webkit.org/show_bug.cgi?id=157389
1302
1303         Reviewed by Alex Christensen.
1304
1305         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1306         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
1307
1308         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1309         (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
1310         use other port numbers too. For http tests, return the complete URL string, not
1311         just the path.
1312
1313 2016-05-04  Alex Christensen  <achristensen@webkit.org>
1314
1315         Blocked redirected main resource requests need descriptive errors
1316         https://bugs.webkit.org/show_bug.cgi?id=156828
1317         rdar://problem/25711316
1318
1319         Reviewed by Daniel Bates.
1320
1321         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1322         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1323         Print out the error type to make sure we have the most descriptive error type.
1324
1325 2016-05-05  Enrique Ocaña González  <eocanha@igalia.com>
1326
1327         [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
1328         https://bugs.webkit.org/show_bug.cgi?id=157341
1329
1330         Reviewed by Xabier Rodriguez-Calvar.
1331
1332         * gtk/jhbuild.modules:
1333         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
1334         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
1335
1336 2016-05-04  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1337
1338         Add JSC test results in JSON format to a Buildbot log
1339         https://bugs.webkit.org/show_bug.cgi?id=156920
1340
1341         Reviewed by Daniel Bates.
1342
1343         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1344         (RunJavaScriptCoreTests): Move command-line option for output file out
1345         of WithProperties.
1346
1347 2016-05-04  Dean Jackson  <dino@apple.com>
1348
1349         TestRunner should always enable all the experimental features
1350         https://bugs.webkit.org/show_bug.cgi?id=157360
1351         <rdar://problem/26099748>
1352
1353         Reviewed by Anders Carlsson.
1354
1355         Call the new SPI that enables all the experimental features.
1356
1357         * WebKitTestRunner/TestController.cpp:
1358         (WTR::TestController::resetPreferencesToConsistentValues):
1359
1360 2016-05-04  Mark Lam  <mark.lam@apple.com>
1361
1362         ES6 Function.name inferred from property names of literal objects can break some websites.
1363         https://bugs.webkit.org/show_bug.cgi?id=157246
1364
1365         Reviewed by Geoffrey Garen.
1366
1367         * WebKitTestRunner/TestController.cpp:
1368         (WTR::TestController::resetPreferencesToConsistentValues):
1369         (WTR::updateTestOptionsFromTestHeader):
1370         * WebKitTestRunner/TestOptions.h:
1371
1372         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1373         (WTR::PlatformWebView::viewSupportsOptions):
1374         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1375         (WTR::PlatformWebView::viewSupportsOptions):
1376         - Add needsSiteSpecificQuirks to WKTR options that can be set. 
1377
1378 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
1379
1380         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
1381         https://bugs.webkit.org/show_bug.cgi?id=157331
1382
1383         Reviewed by Chris Fleizach.
1384
1385         Add AXLandmarkRegion to the landmark strings handled by roleToString
1386         for objects with ATK_ROLE_LANDMARK.
1387
1388         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1389
1390 2016-05-03  Beth Dakin  <bdakin@apple.com>
1391
1392         Add VideoControlsManager tests
1393         https://bugs.webkit.org/show_bug.cgi?id=157332
1394         -and corresponding-
1395         rdar://problem/24358431
1396
1397         Reviewed by Sam Weinig.
1398
1399         This patch adds three VideoControlsManager tests.
1400
1401         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1402         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
1403         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
1404         (-[DidPlayMessageHandler initWithWKWebView:]):
1405         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
1406         (TestWebKitAPI::TEST):
1407         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
1408         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
1409         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
1410
1411 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
1412
1413         [ATK] accessibility/document-attributes.html is failing
1414         https://bugs.webkit.org/show_bug.cgi?id=125348
1415
1416         Reviewed by Chris Fleizach.
1417
1418         The test was failing because the WebArea is now being exposed with the role of
1419         ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
1420         change was made, documentEncoding() and documentURI() were not updated accordingly.
1421
1422         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1423         (WTR::AccessibilityUIElement::documentEncoding):
1424         (WTR::AccessibilityUIElement::documentURI):
1425
1426 2016-05-03  Brent Fulgham  <bfulgham@apple.com>
1427
1428         [Win] Unreviewed build fix.
1429
1430         * EWSTools/start-queue-win.sh: Establish proper VS2015 build
1431         environment at start of queue run.
1432
1433 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
1434
1435         [ATK] accessibility/content-editable-as-textarea.html fails
1436         https://bugs.webkit.org/show_bug.cgi?id=155353
1437
1438         Reviewed by Darin Adler.
1439
1440         The test was timing out because it expected an AXValueChanged notification.
1441         In ATK, AXValueChanged notifications are made for widgets which implement
1442         the AtkValue interface (sliders, progress bars, etc.). We should be listening
1443         for AXTextChanged instead. AtkText's text-insert and text-remove have been
1444         added to the AccessibilityNotificationHandler.
1445
1446         Also, ATK's AccessibilityUIElement support had a number of unimplemented
1447         methods that are being used as part of the previously-failing test. Those
1448         methods are now implemented so that the ATK results are much more similar
1449         to those on the Mac.
1450
1451         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1452         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
1453         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1454         (WTR::AccessibilityUIElement::stringAttributeValue):
1455         (WTR::AccessibilityUIElement::rangeForLine):
1456         (WTR::AccessibilityUIElement::boundsForRange):
1457         (WTR::AccessibilityUIElement::attributedStringForRange):
1458
1459 2016-05-02  Brady Eidson  <beidson@apple.com>
1460
1461         Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
1462         https://bugs.webkit.org/show_bug.cgi?id=157274
1463
1464         Reviewed by Alex Christensen.
1465
1466         Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
1467         and reset them in between tests:
1468         * DumpRenderTree/TestRunner.cpp:
1469         (accummulateLogsForChannel):
1470         (TestRunner::staticFunctions):
1471         (TestRunner::waitToDumpWatchdogTimerFired):
1472         (TestRunner::setAccummulateLogsForChannel):
1473         * DumpRenderTree/TestRunner.h:
1474         * DumpRenderTree/mac/DumpRenderTree.mm:
1475         (resetWebViewToConsistentStateBeforeTesting):
1476
1477         Also add the new method to WKTR's TestRunner, but just stubbed for now:
1478         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1479         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1480         (WTR::TestRunner::accummulateLogsForChannel):
1481         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1482
1483 2016-05-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1484
1485         Add fail-fast option to run-javascriptcore-tests
1486         https://bugs.webkit.org/show_bug.cgi?id=157270
1487
1488         Reviewed by Geoffrey Garen.
1489
1490         * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
1491         Defaults to yes, which is the current behavior.
1492
1493 2016-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1494
1495         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
1496         https://bugs.webkit.org/show_bug.cgi?id=157268
1497
1498         Reviewed by Michael Catanzaro.
1499
1500         * MiniBrowser/gtk/CMakeLists.txt:
1501
1502 2016-04-30  Darin Adler  <darin@apple.com>
1503
1504         Streamline and remove unused bindings generation code
1505         https://bugs.webkit.org/show_bug.cgi?id=157237
1506
1507         Reviewed by Chris Dumez.
1508
1509         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1510         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1511         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1512         Replace non-standard "int" with standard "long", which means the same thing.
1513
1514 2016-04-30  Darin Adler  <darin@apple.com>
1515
1516         Next batch of conversions to use C++ enum class instead of strings for enumerations
1517         https://bugs.webkit.org/show_bug.cgi?id=157232
1518
1519         Reviewed by Chris Dumez.
1520
1521         * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
1522         checking. We don't want to waste time trying to make our generated code match our style.
1523
1524 2016-04-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1525
1526         Add JSC test results in JSON format to a Buildbot log.
1527         https://bugs.webkit.org/show_bug.cgi?id=156920
1528
1529         Reviewed by Daniel Bates.
1530
1531         Generate JSON results for JSC tests and upload them to the master
1532         using Buildbot's logfiles machinery.
1533
1534         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1535         (RunJavaScriptCoreTests): Use --json-output option when invoking the
1536         run-javascriptcore-tests Perl script, and expose this JSON output as a 
1537         Buildbot log.
1538         * Scripts/run-javascriptcore-tests:
1539         (runJSCStressTests): Change key names and remove redundant count key.
1540
1541 2016-04-29  Joanmarie Diggs  <jdiggs@igalia.com>
1542
1543         [ATK] Expose the value of aria-roledescription via an AtkObject attribute
1544         https://bugs.webkit.org/show_bug.cgi?id=146719
1545
1546         Reviewed by Chris Fleizach.
1547
1548         Implement roleDescription() so that the implementation can be tested.
1549
1550         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1551         (WTR::AccessibilityUIElement::roleDescription):
1552
1553 2016-04-27  Alexey Proskuryakov  <ap@apple.com>
1554
1555         Don't throttle GuardMalloc on 8-core Macs
1556         https://bugs.webkit.org/show_bug.cgi?id=157108
1557
1558         Reviewed by Alex Christensen.
1559
1560         This was making them slower unnecessarily.
1561
1562         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
1563
1564 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
1565
1566         Unreviewed: add myself to the committers list.
1567
1568         * Scripts/webkitpy/common/config/contributors.json:
1569
1570 2016-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1571
1572         Fix text in log files autogenerated by import-w3c-tests
1573         https://bugs.webkit.org/show_bug.cgi?id=157021
1574
1575         Unreviewed. Fixing the second typo.
1576
1577         * Scripts/webkitpy/w3c/test_importer.py:
1578         (TestImporter.write_import_log):
1579
1580 2016-04-26  Filip Pizlo  <fpizlo@apple.com>
1581
1582         WebCore on Mac ignores the user's preferred region (country) while getting the language
1583         https://bugs.webkit.org/show_bug.cgi?id=156993
1584
1585         Reviewed by Geoffrey Garen.
1586
1587         Change the test expectations for this test. If the variant is not explicitly specified in
1588         the AppleLanguage, then we use the locale's country code, which this test assumes is US.
1589
1590         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
1591         (TestWebKitAPI::languageForSystemLanguage):
1592         (TestWebKitAPI::TEST):
1593
1594 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1595
1596         Remove the build flag for template elements
1597         https://bugs.webkit.org/show_bug.cgi?id=157022
1598
1599         Reviewed by Daniel Bates.
1600
1601         Removed the build option.
1602
1603         * Scripts/webkitperl/FeatureList.pm:
1604
1605 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1606
1607         Fix text in log files autogenerated by import-w3c-tests
1608         https://bugs.webkit.org/show_bug.cgi?id=157021
1609
1610         Reviewed by Chris Dumez.
1611
1612         s/Webkit/WebKit/ and end each sentence with a period.
1613
1614         * Scripts/webkitpy/w3c/test_importer.py:
1615         (TestImporter.write_import_log):
1616
1617 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
1618
1619         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
1620         https://bugs.webkit.org/show_bug.cgi?id=156929
1621
1622         Reviewed by Darin Adler.
1623
1624         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1625         (TestWebKitAPI::TEST):
1626
1627 2016-04-25  Caitlin Potter  <caitp@igalia.com>
1628
1629         [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
1630         https://bugs.webkit.org/show_bug.cgi?id=156976
1631
1632         Reviewed by Darin Adler.
1633
1634         Mitigate style-checker spam on bugs which introduce new JavaScript
1635         token types.
1636
1637         * Scripts/webkitpy/style/checkers/cpp.py:
1638         (_EnumState.__init__):
1639         (_EnumState.process_clean_line):
1640         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1641         (NoNonVirtualDestructorsTest.test_enum_casing):
1642
1643 2016-04-25  Simon Fraser  <simon.fraser@apple.com>
1644
1645         Fix issues with content-animation performance tests
1646         https://bugs.webkit.org/show_bug.cgi?id=157001
1647
1648         Reviewed by Sam Weinig.
1649
1650         Add patch content for svg-animation.html, and fix the paths in the patch so
1651         it applies correctly.
1652
1653         Add the patch file to the .plan file.
1654
1655         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
1656         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1657
1658 2016-04-25  Brady Eidson  <beidson@apple.com>
1659
1660         Tweaking IndexedDB watchlist and adding myself to it.
1661
1662         * Scripts/webkitpy/common/config/watchlist:
1663
1664 2016-04-25  Commit Queue  <commit-queue@webkit.org>
1665
1666         Unreviewed, rolling out r199916.
1667         https://bugs.webkit.org/show_bug.cgi?id=156989
1668
1669         Might break buildbot when master is restarted (Requested by
1670         Srinivasan Vijayaraghava, Guest100, on #webkit).
1671
1672         Reverted changeset:
1673
1674         "Add JSC test results in json format to a buildbot log"
1675         https://bugs.webkit.org/show_bug.cgi?id=156920
1676         http://trac.webkit.org/changeset/199916
1677
1678 2016-04-23  Chris Dumez  <cdumez@apple.com>
1679
1680         [WebIDL] Drop [Default] WebKit-IDL extended attribute
1681         https://bugs.webkit.org/show_bug.cgi?id=156955
1682
1683         Reviewed by Darin Adler.
1684
1685         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1686
1687 2016-04-23  Csaba Osztrogonác  <ossy@webkit.org>
1688
1689         Really enable INDEXED_DATABASE on Apple Mac cmake build
1690         https://bugs.webkit.org/show_bug.cgi?id=156902
1691
1692         Reviewed by Michael Catanzaro.
1693
1694         * Scripts/webkitperl/FeatureList.pm:
1695
1696 2016-04-23  Andy Estes  <aestes@apple.com>
1697
1698         check-webkit-style: fix false-positive warnings about @synchronized
1699         https://bugs.webkit.org/show_bug.cgi?id=156957
1700
1701         Reviewed by Dan Bernstein.
1702
1703         * Scripts/webkitpy/style/checkers/cpp.py:
1704         (check_spacing_for_function_call): Ignore @synchronized lines.
1705         (check_braces): Ditto.
1706         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1707         (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
1708
1709 2016-04-22  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1710
1711         Add JSC test results in json format to a buildbot log
1712         https://bugs.webkit.org/show_bug.cgi?id=156920
1713
1714         Reviewed by Alexey Proskuryakov.
1715
1716         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1717         (RunJavaScriptCoreTests):
1718         Add runtime flag to output json into buildbot
1719         * Scripts/run-javascriptcore-tests:
1720         (runJSCStressTests):
1721         Change key names and remove redundant count key
1722
1723 2016-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1724
1725         Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
1726
1727         Unreviewed test gardening.
1728
1729         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1730         (TestWebKitAPI::TEST):
1731
1732 2016-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1733
1734         [GTK] Enable the download attribute support
1735         https://bugs.webkit.org/show_bug.cgi?id=99025
1736
1737         Reviewed by Žan Doberšek.
1738
1739         * Scripts/webkitperl/FeatureList.pm:
1740
1741 2016-04-21  Keith Miller  <keith_miller@apple.com>
1742
1743         WebScriptObject description swizzler should work in a multi-threaded world
1744         https://bugs.webkit.org/show_bug.cgi?id=156808
1745
1746         Add a test for our NSObject swizzling TLS implementation. The test runs on
1747         two threads. One in JS and another in Objective-C. We expect the JS thread
1748         to use our NSObject description override and the Objective-C thread to act
1749         as though it was using the original NSObject description method.
1750
1751         Reviewed by Geoffrey Garen.
1752
1753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1754         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
1755         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
1756         (nsObjectDescriptionTest):
1757         (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
1758         (TestWebKitAPI::TEST):
1759
1760 2016-04-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1761
1762         [GTK] WebKitWebView should claim the contents size as its natural size
1763         https://bugs.webkit.org/show_bug.cgi?id=156835
1764
1765         Reviewed by Žan Doberšek.
1766
1767         Add test case to check the WebKitWebView preferred size.
1768
1769         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1770         (testWebViewPreferredSize):
1771         (beforeAll):
1772
1773 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
1774
1775         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
1776         https://bugs.webkit.org/show_bug.cgi?id=156827
1777         
1778         Update the .plan file now that the files are present in SVN.
1779
1780         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1781
1782 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
1783
1784         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
1785         https://bugs.webkit.org/show_bug.cgi?id=156827
1786         rdar://problem/24358135
1787
1788         Reviewed by Stephanie Lewis.
1789
1790         Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
1791         and collate results across them. Also add the ability for the browser_driver to supply
1792         additional results, allowing for tests that collect results data in native code, rather
1793         than generating it in the web page.
1794
1795         Add a set of "content animation" tests that use this new functionality, which test
1796         CSS animation and requestAnimationFrame performance.
1797
1798         'plan' files have two new optional keys:
1799             'test_files': a list of files to run as a suite
1800             'options': optional parameters. Currently supports one new option,
1801                 'animation_command', which affects the way that iOS tests are run,
1802                 and is passed to MobileSafari as a parameter on launch.
1803
1804         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1805         (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
1806         (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
1807         (BenchmarkRunner):
1808         (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
1809         running a single test. It starts and stops the http_server_driver.
1810         (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
1811         key, otherwise look for the new 'test_files' and load each in a loop.
1812         (BenchmarkRunner._dump):
1813         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1814         (BrowserDriver.launch_url): Pass options.
1815         (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
1816         (BrowserDriver):
1817         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
1818         (GTKMiniBrowserDriver.launch_url):
1819         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1820         (OSXBrowserDriver.close_browsers):
1821         (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
1822         (OSXBrowserDriver._terminiate_processes): Deleted.
1823         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1824         (OSXChromeDriver.launch_url):
1825         (OSXChromeCanaryDriver.launch_url):
1826         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1827         (OSXFirefoxDriver.launch_url):
1828         (OSXFirefoxNightlyDriver.launch_url):
1829         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1830         (OSXSafariDriver.launch_url):
1831         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
1832         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
1833
1834 2016-04-20  Dustin Falgout  <dustin@falgout.us>
1835
1836         [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
1837         https://bugs.webkit.org/show_bug.cgi?id=156651
1838
1839         Reviewed by Michael Catanzaro.
1840
1841         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1842         (testWebKitSettings):
1843
1844 2016-04-20  Brady Eidson  <beidson@apple.com>
1845
1846         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
1847         https://bugs.webkit.org/show_bug.cgi?id=156782
1848
1849         Reviewed by Alex Christensen.
1850
1851         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1852
1853 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
1854
1855         Unreviewed build fix after r199752.
1856
1857         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1858         (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
1859
1860 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
1861
1862         Remove remaining bits of dynamic <link> rel='icon' loading
1863         https://bugs.webkit.org/show_bug.cgi?id=156727
1864
1865         Reviewed by Darin Adler.
1866
1867         Remove unused test infrastructure. This code never existed in WebKit2
1868         testing since was only used on Windows.
1869
1870         * DumpRenderTree/TestRunner.cpp:
1871         (dumpIconChangesCallback): Deleted.
1872         * DumpRenderTree/TestRunner.h:
1873         (TestRunner::dumpIconChanges): Deleted.
1874         (TestRunner::setDumpIconChanges): Deleted.
1875
1876 2016-04-19  Keith Miller  <keith_miller@apple.com>
1877
1878         ObjcInstance::stringValue should not call NSObject's description method
1879         https://bugs.webkit.org/show_bug.cgi?id=156758
1880
1881         Reviewed by Geoffrey Garen.
1882
1883         Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
1884         an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
1885         call the NSObjects description method without first swizzling it.
1886
1887         * DumpRenderTree/mac/ObjCController.m:
1888         (+[ObjCController isSelectorExcludedFromWebScript:]):
1889         (+[ObjCController webScriptNameForSelector:]):
1890         (-[ObjCController testArrayOfObjects]):
1891         (-[ObjCController testObject]):
1892
1893 2016-04-18  Dan Bernstein  <mitz@apple.com>
1894
1895         Fixed building with old Xcode.
1896
1897         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1898         (TEST):
1899
1900 2016-04-18  Dean Jackson  <dino@apple.com>
1901
1902         New SPI to export a dictionary of runtime features
1903         https://bugs.webkit.org/show_bug.cgi?id=156645
1904         <rdar://problem/23621666>
1905
1906         Reviewed by Darin Adler.
1907
1908         Test the experimental features SPI on WKPreferences.
1909
1910         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1911
1912 2016-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
1913
1914         [JSCOnly] Implement RunLoop and remove glib dependency
1915         https://bugs.webkit.org/show_bug.cgi?id=155706
1916
1917         Reviewed by Michael Catanzaro.
1918
1919         Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
1920         Platform specific ones locate under jsconly directory since
1921         it is not `generic` (Since it includes the GLIB event loop case).
1922
1923         * CMakeLists.txt:
1924         * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
1925         * TestWebKitAPI/PlatformUtilities.h:
1926         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1927         (TestWebKitAPI::TEST):
1928         * TestWebKitAPI/config.h:
1929         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
1930         (TestWebKitAPI::Util::run):
1931         (TestWebKitAPI::Util::sleep):
1932         * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
1933         (main):
1934
1935 2016-04-18  Jon Lee  <jonlee@apple.com>
1936
1937         Update Animometer plan.
1938         https://bugs.webkit.org/show_bug.cgi?id=156652
1939
1940         Reviewed by Darin Adler.
1941
1942         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
1943
1944 2016-04-18  Dana Burkart  <dburkart@apple.com>
1945
1946         svn-apply: add option for ignoring changes to ChangeLog files
1947         https://bugs.webkit.org/show_bug.cgi?id=156618
1948
1949         Reviewed by Darin Adler.
1950
1951         This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
1952         patch() if the file in question is a ChangeLog.
1953
1954         * Scripts/svn-apply:
1955         (patch):
1956
1957 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1958
1959         Pending API Request URL is wrong after reloading
1960         https://bugs.webkit.org/show_bug.cgi?id=139342
1961
1962         Reviewed by Darin Adler.
1963
1964         Update test case to check that the active URL should remain the
1965         same after a reload.
1966
1967         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
1968         (TestWebKitAPI::TEST):
1969
1970 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1971
1972         Pending API request URL no set when loading Data, Alternate HTML or plain text
1973         https://bugs.webkit.org/show_bug.cgi?id=136916
1974
1975         Reviewed by Darin Adler.
1976
1977         Add new test to check that active URL is the requested one right
1978         after calling WKPage load methods.
1979
1980         * TestWebKitAPI/PlatformEfl.cmake:
1981         * TestWebKitAPI/PlatformGTK.cmake:
1982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1983         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
1984         (TestWebKitAPI::TEST):
1985         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1986         (WebViewTest::loadPlainText): Remove FIXME.
1987         (WebViewTest::loadBytes): Ditto.
1988         (WebViewTest::loadAlternateHTML): Ditto.
1989
1990 2016-04-18  Commit Queue  <commit-queue@webkit.org>
1991
1992         Unreviewed, rolling out r199660.
1993         https://bugs.webkit.org/show_bug.cgi?id=156691
1994
1995         It broke the iOS build (Requested by KaL on #webkit).
1996
1997         Reverted changeset:
1998
1999         "Pending API request URL no set when loading Data, Alternate
2000         HTML or plain text"
2001         https://bugs.webkit.org/show_bug.cgi?id=136916
2002         http://trac.webkit.org/changeset/199660
2003
2004 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2005
2006         Pending API request URL no set when loading Data, Alternate HTML or plain text
2007         https://bugs.webkit.org/show_bug.cgi?id=136916
2008
2009         Reviewed by Darin Adler.
2010
2011         Add new test to check that active URL is the requested one right
2012         after calling WKPage load methods.
2013
2014         * TestWebKitAPI/PlatformEfl.cmake:
2015         * TestWebKitAPI/PlatformGTK.cmake:
2016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2017         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
2018         (TestWebKitAPI::TEST):
2019         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2020         (WebViewTest::loadPlainText): Remove FIXME.
2021         (WebViewTest::loadBytes): Ditto.
2022         (WebViewTest::loadAlternateHTML): Ditto.
2023
2024 2016-04-18  Jeremy Huddleston Sequoia  <jeremyhu@apple.com>
2025
2026         Fix incorrect assumption that APPLE implies Mac.
2027         https://bugs.webkit.org/show_bug.cgi?id=156679
2028
2029         Addresses build failure introduced in r198947
2030
2031         Reviewed by Alex Christensen.
2032
2033         * CMakeLists.txt:
2034
2035 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2036
2037         [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
2038         https://bugs.webkit.org/show_bug.cgi?id=156621
2039
2040         Reviewed by Martin Robinson.
2041
2042         This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
2043         scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
2044         simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
2045
2046         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2047         (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
2048
2049 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2050
2051         [EFL] Bump gstreamer from 1.4.4 to 1.6.3
2052         https://bugs.webkit.org/show_bug.cgi?id=156655
2053
2054         Reviewed by Antonio Gomes.
2055
2056         To support html5 video feature, we should bump gstreamer version.
2057
2058         * efl/jhbuild.modules:
2059         * efl/patches/gst-libav.patch: Update against newer version.
2060         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
2061
2062 2016-04-16  Sam Weinig  <sam@webkit.org>
2063
2064         More build fixing.
2065
2066         * MiniBrowser/mac/BrowserWindowController.m:
2067         (-[BrowserWindowController share:]):
2068
2069 2016-04-16  Sam Weinig  <sam@webkit.org>
2070
2071         Another build fix.
2072
2073         * MiniBrowser/mac/BrowserWindowController.m:
2074         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
2075
2076 2016-04-16  Sam Weinig  <sam@webkit.org>
2077
2078         Fix 32-bit build.
2079
2080         * MiniBrowser/mac/BrowserWindowController.m:
2081         (-[BrowserWindowController share:]):
2082         (-[BrowserWindowController fetch:]):
2083         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
2084
2085 2016-04-15  Sam Weinig  <sam@webkit.org>
2086
2087         Add support for NSSharingService to MiniBrowser, for no great reasons
2088         https://bugs.webkit.org/show_bug.cgi?id=156658
2089
2090         Reviewed by Darin Adler.
2091
2092         * MiniBrowser/mac/BrowserWindow.xib:
2093         * MiniBrowser/mac/BrowserWindowController.h:
2094         Add the share button.
2095
2096         * MiniBrowser/mac/BrowserWindowController.m:
2097         (-[BrowserWindowController windowDidLoad]):
2098         Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
2099
2100         (-[BrowserWindowController share:]):
2101         Show the picker when the button is pressed.
2102         (-[BrowserWindowController mainContentView]):
2103         Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
2104
2105         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
2106         (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
2107         (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
2108         (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
2109         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
2110         (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2111         Add delegate methods.
2112
2113         * MiniBrowser/mac/WK1BrowserWindowController.m:
2114         (-[WK1BrowserWindowController mainContentView]):
2115         * MiniBrowser/mac/WK2BrowserWindowController.m:
2116         (-[WK2BrowserWindowController mainContentView]):
2117         Implement to return the web view.
2118
2119 2016-04-16  Alexey Proskuryakov  <ap@apple.com>
2120
2121         Build fix.
2122
2123         Temporary workaround for rdar://problem/25754945.
2124
2125         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2126
2127 2016-04-15  Commit Queue  <commit-queue@webkit.org>
2128
2129         Unreviewed, rolling out r199600.
2130         https://bugs.webkit.org/show_bug.cgi?id=156642
2131
2132         It didn't help (Requested by ap_ on #webkit).
2133
2134         Reverted changeset:
2135
2136         "Build fix."
2137         http://trac.webkit.org/changeset/199600
2138
2139 2016-04-15  Alexey Proskuryakov  <ap@apple.com>
2140
2141         Build fix.
2142
2143         * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
2144
2145 2016-04-14  Alexey Proskuryakov  <ap@apple.com>
2146
2147         Some GuardMalloc bots are not happy when running many parallel processes
2148         https://bugs.webkit.org/show_bug.cgi?id=156614
2149         rdar://problem/24711525
2150
2151         Reviewed by David Kilzer.
2152
2153         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
2154
2155 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
2156
2157         Make <a download> a runtime enabled option
2158         https://bugs.webkit.org/show_bug.cgi?id=156583
2159         <rdar://problem/25733449>
2160
2161         Reviewed by Alex Christensen.
2162
2163         * DumpRenderTree/mac/DumpRenderTree.mm:
2164         (resetWebPreferencesToConsistentValues):
2165         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2166         (WTR::InjectedBundle::beginTesting):
2167         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2168         (WTR::TestRunner::setDownloadAttributeEnabled):
2169         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2170
2171 2016-04-14  Anders Carlsson  <andersca@apple.com>
2172
2173         Another build fix attempt.
2174
2175         * MiniBrowser/mac/WK2BrowserWindowController.m:
2176
2177 2016-04-14  Anders Carlsson  <andersca@apple.com>
2178
2179         Fix build.
2180
2181         * MiniBrowser/mac/WK2BrowserWindowController.m:
2182         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2183
2184 2016-04-14  Anders Carlsson  <andersca@apple.com>
2185
2186         [Mac] Add API for open panel handling to WKWebView
2187         https://bugs.webkit.org/show_bug.cgi?id=137759
2188         rdar://problem/23278623
2189
2190         Reviewed by Tim Horton.
2191
2192         Have MiniBrowser implement the new delegate method.
2193
2194         * MiniBrowser/mac/WK2BrowserWindowController.m:
2195         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2196
2197 2016-04-14  Jiewen Tan  <jiewen_tan@apple.com>
2198
2199         Unreviewed, rolling out r199554.
2200
2201         The change breaks Yosemite Release/Debug build
2202
2203         Reverted changeset:
2204
2205         "[Mac] Add API for open panel handling to WKWebView"
2206         https://bugs.webkit.org/show_bug.cgi?id=137759
2207         http://trac.webkit.org/changeset/199554
2208
2209 2016-04-14  Anders Carlsson  <andersca@apple.com>
2210
2211         [Mac] Add API for open panel handling to WKWebView
2212         https://bugs.webkit.org/show_bug.cgi?id=137759
2213         rdar://problem/23278623
2214
2215         Reviewed by Tim Horton.
2216
2217         Have MiniBrowser implement the new delegate method.
2218
2219         * MiniBrowser/mac/WK2BrowserWindowController.m:
2220         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2221
2222 2016-04-14  Jon Lee  <jonlee@apple.com>
2223
2224         Update Animometer plan
2225         https://bugs.webkit.org/show_bug.cgi?id=156569
2226
2227         Reviewed by Alex Christensen.
2228
2229         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
2230         resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
2231
2232 2016-04-13  Alex Christensen  <achristensen@webkit.org>
2233
2234         CMake MiniBrowser should be an app bundle
2235         https://bugs.webkit.org/show_bug.cgi?id=156521
2236
2237         Reviewed by Brent Fulgham.
2238
2239         * MiniBrowser/mac/CMakeLists.txt:
2240         Make an app bundle and compile nibs.
2241         * MiniBrowser/mac/Info.plist:
2242         CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.
2243
2244 2016-04-13  Chris Dumez  <cdumez@apple.com>
2245
2246         We should not speculatively revalidate cached redirects
2247         https://bugs.webkit.org/show_bug.cgi?id=156548
2248         <rdar://problem/25583886>
2249
2250         Reviewed by Darin Adler.
2251
2252         Re-enable speculative loading in the context of layout tests. This was
2253         turned off by mistake when speculative loading was turned into a
2254         setting recently.
2255
2256         * WebKitTestRunner/TestController.cpp:
2257         (WTR::TestController::generatePageConfiguration):
2258
2259 2016-04-12  Alexey Proskuryakov  <ap@apple.com>
2260
2261         Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
2262         https://bugs.webkit.org/show_bug.cgi?id=155367
2263
2264         Reviewed by Darin Adler.
2265
2266         * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
2267         Don't flakily consume the return code with waitpid, callers need to do waitpid on
2268         their own. Not sure if this line of code was even intentional.
2269
2270 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
2271
2272         [OS X] Flakey crash after ScrollAnimatorMac destruction
2273         https://bugs.webkit.org/show_bug.cgi?id=156372
2274
2275         Reviewed by Darin Adler.
2276
2277         Implement the new <!-- webkit-test-runner --> flag.
2278
2279         * WebKitTestRunner/TestController.cpp:
2280         (WTR::TestController::createWebViewWithOptions):
2281         (WTR::TestController::ensureViewSupportsOptionsForTest):
2282         (WTR::TestController::resetPreferencesToConsistentValues):
2283         (WTR::TestController::resetStateToConsistentValues):
2284         (WTR::updateTestOptionsFromTestHeader):
2285         * WebKitTestRunner/TestController.h:
2286         * WebKitTestRunner/TestInvocation.cpp:
2287         (WTR::TestInvocation::invoke):
2288         * WebKitTestRunner/TestOptions.h:
2289         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2290         (WKR::PlatformWebView::viewSupportsOptions):
2291
2292 2016-04-12  Tomas Popela  <tpopela@redhat.com>
2293
2294         Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported
2295         https://bugs.webkit.org/show_bug.cgi?id=156338
2296
2297         Reviewed by Michael Catanzaro.
2298
2299         Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just
2300         for the i686 where it is supported and not for other architectures
2301         (such as s390(x) and ppc(64)) where the build will fail with these
2302         CXXFLAGS.
2303
2304         * Scripts/webkitdirs.pm:
2305         (generateBuildSystemFromCMakeProject):
2306
2307 2016-04-11  Alex Christensen  <achristensen@webkit.org>
2308
2309         Build MiniBrowser with CMake on Mac
2310         https://bugs.webkit.org/show_bug.cgi?id=156471
2311
2312         Reviewed by Daniel Bates.
2313
2314         * CMakeLists.txt:
2315         * DumpRenderTree/CMakeLists.txt:
2316         * DumpRenderTree/PlatformWin.cmake:
2317         * MiniBrowser/mac/CMakeLists.txt: Added.
2318
2319 2016-04-11  Ryuan Choi  <ryuan.choi@navercorp.com>
2320
2321         [EFL] Do not pass context to EwkViewCreate
2322         https://bugs.webkit.org/show_bug.cgi?id=156461
2323
2324         Reviewed by Darin Adler.
2325
2326         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2327         (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls.
2328         * TestWebKitAPI/efl/PlatformWebView.cpp:
2329         (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto.
2330         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2331         (WTR::PlatformWebView::PlatformWebView): Ditto.
2332
2333 2016-04-11  Fujii Hironori  <Hironori.Fujii@jp.sony.com>
2334
2335         [CMake] Make FOLDER property INHERITED
2336         https://bugs.webkit.org/show_bug.cgi?id=156460
2337
2338         Reviewed by Brent Fulgham.
2339
2340         * CMakeLists.txt:
2341         * DumpRenderTree/CMakeLists.txt:
2342         * DumpRenderTree/PlatformWin.cmake:
2343         * ImageDiff/CMakeLists.txt:
2344         * MiniBrowser/efl/CMakeLists.txt:
2345         * MiniBrowser/gtk/CMakeLists.txt:
2346         * MiniBrowser/win/CMakeLists.txt:
2347         Set FOLDER property as a directory property not a target property
2348
2349 2016-04-10  Caitlin Potter  <caitp@igalia.com>
2350
2351         [Tools] correctly check for braces in multiline branches in macro definition
2352         https://bugs.webkit.org/show_bug.cgi?id=156441
2353
2354         Reviewed by Darin Adler.
2355
2356         Prevents emitting whitespace/braces warning for code like the
2357         following:
2358
2359         ```
2360         #define MACRO(x) \
2361             if (x) { \
2362                 doTheThing(); \
2363                 continue; \
2364             }
2365         ```
2366
2367         * Scripts/webkitpy/style/checkers/cpp.py:
2368         (check_braces):
2369         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2370         (WebKitStyleTest.test_line_breaking):
2371
2372 2016-04-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2373
2374         Testharness-based tests that time out should be able to produce a detailed output
2375         https://bugs.webkit.org/show_bug.cgi?id=145313
2376
2377         Reviewed by Xabier Rodriguez-Calvar.
2378
2379         Adding timeout readonly accessor to TestRunner for both WK1 and WK2.
2380
2381         * DumpRenderTree/TestRunner.cpp:
2382         (getTimeoutCallback): The js "timeout" property getter.
2383         (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value.
2384         * DumpRenderTree/TestRunner.h:
2385         (TestRunner::timeout): Adding access to DRT m_timeout private value.
2386         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS.
2387         * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition.
2388         (WTR::TestRunner::timeout):
2389
2390 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
2391
2392         stylebot should know about TestWebKitAPI FeatureDefines.xcconfig
2393         https://bugs.webkit.org/show_bug.cgi?id=156387
2394
2395         Rubber-stamped by Dan Bernstein.
2396
2397         * Scripts/webkitpy/style/checkers/featuredefines.py:
2398         (FeatureDefinesChecker.check):
2399
2400 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
2401
2402         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
2403         https://bugs.webkit.org/show_bug.cgi?id=156384
2404
2405         Reviewed by Ryosuke Niwa.
2406
2407         * Scripts/webkitperl/FeatureList.pm:
2408         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2409
2410 2016-04-06  Dean Jackson  <dino@apple.com>
2411
2412         Watchlist modifications:
2413         - remove roger_fong
2414         - add myself to a few areas
2415         - remove graouts from WebInspectorAPI
2416
2417         * Scripts/webkitpy/common/config/watchlist:
2418
2419 2016-04-07  Simon Fraser  <simon.fraser@apple.com>
2420
2421         Make it possible to test effect of view exposed rect on tiled backing
2422         https://bugs.webkit.org/show_bug.cgi?id=156365
2423
2424         Reviewed by Tim Horton.
2425
2426         Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable
2427         testing of tile coverage when setViewExposedRect() is passed a non-null rectangle.
2428
2429         testRunner.setViewSize() is used instead of using window.resizeTo(), since we
2430         can't easily resize a window to larger than the screen being tested on.
2431
2432         * DumpRenderTree/TestRunner.cpp:
2433         (setViewSizeCallback):
2434         (TestRunner::staticFunctions):
2435         * DumpRenderTree/TestRunner.h:
2436         * DumpRenderTree/mac/TestRunnerMac.mm:
2437         (TestRunner::setViewSize):
2438         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2439         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2440         (WTR::InjectedBundle::postSetViewSize):
2441         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2442         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2443         (WTR::TestRunner::setViewSize):
2444         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2445         * WebKitTestRunner/TestInvocation.cpp:
2446         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2447
2448 2016-04-07  Jason Marcell  <jmarcell@apple.com>
2449
2450         Adding layout tests for the bot watcher's dashboard QUnit tests.
2451         https://bugs.webkit.org/show_bug.cgi?id=155272
2452
2453         Reviewed by Daniel Bates.
2454
2455         Moved supporting resources into a resources folder and updated index.html accordingly
2456         to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done.
2457
2458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added.
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory.
2460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from
2461         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js.
2462         (MockBuildbotQueue):
2463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from
2464         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js.
2465         (MockBuildbotQueueView):
2466         (MockBuildbotQueueView.prototype._latestProductiveIteration):
2467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from
2468         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js.
2469         (MockTrac):
2470         (MockTrac.prototype.get oldestRecordedRevisionNumber):
2471         (MockTrac.prototype.get latestRecordedRevisionNumber):
2472         (MockTrac.prototype.loadMoreHistoricalData):
2473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from
2474         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml.
2475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from
2476         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml.
2477         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from
2478         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js.
2479         Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory.
2480         (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done.
2481         * Scripts/run-dashboard-tests: Added.
2482
2483 2016-04-06  ChangSeok Oh  <changseok@webkit.org>
2484
2485         Unreviewed, Update my primary email address and expertise.
2486
2487         * Scripts/webkitpy/common/config/contributors.json:
2488
2489 2016-04-06  Jon Lee  <jonlee@apple.com>
2490
2491         Update the Animometer patch and plan files
2492         https://bugs.webkit.org/show_bug.cgi?id=156263
2493
2494         Reviewed by Ryosuke Niwa.
2495
2496         Measure the latest set of tests by updating the plan revision to r199134.
2497
2498         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only.
2499         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead
2500         of the developer page.
2501
2502 2016-04-06  Saam barati  <sbarati@apple.com>
2503
2504         jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989
2505         https://bugs.webkit.org/show_bug.cgi?id=156187
2506
2507         Reviewed by Keith Miller.
2508
2509         * Scripts/run-jsc-stress-tests:
2510
2511 2016-04-06  Alex Christensen  <achristensen@webkit.org>
2512
2513         Compile WebKitTestRunner with CMake on Mac
2514         https://bugs.webkit.org/show_bug.cgi?id=156310
2515
2516         Reviewed by Daniel Bates.
2517
2518         * CMakeLists.txt:
2519         * WebKitTestRunner/CMakeLists.txt:
2520         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2521         * WebKitTestRunner/PlatformEfl.cmake:
2522         * WebKitTestRunner/PlatformGTK.cmake:
2523         * WebKitTestRunner/PlatformMac.cmake: Added.
2524
2525 2016-04-05  Simon Fraser  <simon.fraser@apple.com>
2526
2527         Implement operator== and operator!= for Optional<>
2528         https://bugs.webkit.org/show_bug.cgi?id=156266
2529
2530         Reviewed by Anders Carlsson.
2531
2532         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2533         (TestWebKitAPI::TEST):
2534
2535 2016-04-05  Alex Christensen  <achristensen@webkit.org>
2536
2537         Make CMake-generated binaries on Mac able to run
2538         https://bugs.webkit.org/show_bug.cgi?id=156268
2539
2540         Reviewed by Daniel Bates.
2541
2542         * DumpRenderTree/CMakeLists.txt:
2543         * DumpRenderTree/PlatformMac.cmake:
2544         * DumpRenderTree/PlatformWin.cmake:
2545         * TestWebKitAPI/PlatformMac.cmake:
2546
2547 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2548
2549         [Fetch API] Add a runtime flag to fetch API and related constructs
2550         https://bugs.webkit.org/show_bug.cgi?id=156113
2551  
2552         Reviewed by Alex Christensen.
2553
2554         * DumpRenderTree/TestRunner.h:
2555         * DumpRenderTree/mac/DumpRenderTree.mm:
2556         (resetWebPreferencesToConsistentValues):
2557         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2558         (WTR::InjectedBundle::beginTesting):
2559         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2560         (WTR::TestRunner::setWebGL2Enabled):
2561         (WTR::TestRunner::setFetchAPIEnabled):
2562         (WTR::TestRunner::setAllowUniversalAccessFromFileURLs):
2563         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2564
2565 2016-04-05  Keith Miller  <keith_miller@apple.com>
2566
2567         Make Keith a reviewer!
2568         https://bugs.webkit.org/show_bug.cgi?id=156246
2569
2570         Reviewed by Mark Lam.
2571
2572         * Scripts/webkitpy/common/config/contributors.json:
2573
2574 2016-04-05  Antoine Quint  <graouts@apple.com>
2575
2576         [WebGL2] Allow enabling WebGL2 with a runtime flag
2577         https://bugs.webkit.org/show_bug.cgi?id=156166
2578         <rdar://problem/25526929>
2579
2580         Always enable WebGL2 during testing.
2581
2582         Reviewed by Dean Jackson.
2583
2584         * DumpRenderTree/mac/DumpRenderTree.mm:
2585         (resetWebPreferencesToConsistentValues):
2586         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2587         (WTR::InjectedBundle::beginTesting):
2588         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2589         (WTR::TestRunner::setWebGL2Enabled):
2590         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2591
2592 2016-04-04  Bill Ming  <mbbill@gmail.com>
2593
2594         [win] run-webkit-tests failed to launch DumpRenderTree
2595         https://bugs.webkit.org/show_bug.cgi?id=156150
2596
2597         Reviewed by Alex Christensen.
2598
2599         * Tools/Scripts/webkitpy/port/base.py:
2600
2601 2016-04-04  Bill Ming  <mbbill@gmail.com>
2602
2603         prepare-ChangeLog set endl incorrectly.
2604         https://bugs.webkit.org/show_bug.cgi?id=156151
2605
2606         Reviewed by Alex Christensen.
2607
2608         * Tools/Scripts/prepare-ChangeLog:
2609
2610 2016-04-03  Sam Weinig  <sam@webkit.org>
2611
2612         Add SPI to allow install script message handlers in isolated worlds
2613         https://bugs.webkit.org/show_bug.cgi?id=156153
2614
2615         Reviewed by Anders Carlsson.
2616
2617         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2618         Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
2619
2620 2016-04-04  Jiewen Tan  <jiewen_tan@apple.com>
2621
2622         Build fix for r198956.
2623
2624         Unreviewed.
2625
2626         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
2627         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2628         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2629         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2630
2631 2016-04-04  Bill Ming  <mbbill@gmail.com>
2632
2633         [win] prepare-ChangeLog should treat windows path differently.
2634         https://bugs.webkit.org/show_bug.cgi?id=156120
2635
2636         Reviewed by Brent Fulgham.
2637
2638         * Scripts/prepare-ChangeLog:
2639
2640 2016-04-04  Alejandro G. Castro  <alex@igalia.com>
2641
2642         REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations
2643         https://bugs.webkit.org/show_bug.cgi?id=156164
2644
2645         Reviewed by Philippe Normand.
2646
2647         Enable the new WEB_RTC option by default for Gtk+.
2648
2649         * Scripts/webkitperl/FeatureList.pm:
2650
2651 2016-04-03  Dan Bernstein  <mitz@apple.com>
2652
2653         Use the correct value for the first nightly build with frameworks built for OS X 10.11.
2654
2655         * Scripts/bisect-builds:
2656         (makeNightlyList):
2657
2658 2016-04-03  Dan Bernstein  <mitz@apple.com>
2659
2660         Made bisect-builds work again.
2661
2662         Rubber-stamped by Sam Weinig.
2663
2664         * Scripts/bisect-builds:
2665         Changed to use HTTPS to access nightly.webkit.org, and added a minimum revision for OS X 10.11.
2666
2667 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
2668
2669         Build fix for r198956.
2670
2671         Unreviewed.
2672
2673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2674         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm.
2675         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]):
2676         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]):
2677         (TEST):
2678         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2679         (-[LoadInvalidSchemeDelegate browsingContextController:didFailProvisionalLoadWithError:]):
2680         (TestWebKitAPI::TEST):
2681
2682 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
2683
2684         WebKit should dispatchDidFailProvisionalLoad while loading invalid URLs
2685         https://bugs.webkit.org/show_bug.cgi?id=155995
2686         <rdar://problem/14967004>
2687
2688         Reviewed by Andy Estes.
2689
2690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2691         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm:
2692         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
2693         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didStartProvisionalNavigation:]):
2694         (TEST):
2695         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Added.
2696         (literalURL):
2697         (-[LoadInvalidURLNavigationActionDelegate webView:didCommitNavigation:]):
2698         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2699         (TestWebKitAPI::TEST):
2700         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html: Added.
2701         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: Added.
2702         (-[LoadInvalidURLWebFrameLoadDelegate webView:didCommitLoadForFrame:]):
2703         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2704         (TestWebKitAPI::TEST):
2705
2706 2016-04-01  Brent Fulgham  <bfulgham@apple.com>
2707
2708         Confirm <a download> satisfies specification criteria
2709         https://bugs.webkit.org/show_bug.cgi?id=156057
2710
2711         Reviewed by Andy Estes.
2712
2713         Revise WebKitTestRunner:
2714         (1) Provide a download client delegate.
2715         (2) Teach WKTR to wait to finish a test until a download finishes.
2716         (3) Allow WKTR to notify the current TestRunner that it can finish.
2717
2718         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2719         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2720         (WTR::InjectedBundle::didReceiveMessageToPage): Update to recognize a new
2721         message "NotifyDownloadDone".
2722         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2723         (WTR::InjectedBundlePage::decidePolicyForNavigationAction): Handle 'download'
2724         attribute case.
2725         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2726         (WTR::TestRunner::waitUntilDownload): Added.
2727         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2728         (WTR::TestRunner::shouldFinishAfterDownload): Added.
2729         * WebKitTestRunner/TestController.cpp:
2730         (WTR::TestController::createWebViewWithOptions): Set up the download client.
2731         (WTR::TestController::downloadDidStart): Added.
2732         (WTR::TestController::decideDestinationWithSuggestedFilename): Added.
2733         (WTR::TestController::downloadDidFinish): Added.
2734         (WTR::TestController::downloadDidFail): Added.
2735         (WTR::TestController::downloadDidCancel): Added.
2736         * WebKitTestRunner/TestController.h:
2737         * WebKitTestRunner/TestInvocation.cpp:
2738         (WTR::TestInvocation::notifyDownloadDone): Added.
2739         * WebKitTestRunner/TestInvocation.h:
2740
2741 2016-04-01  Alex Christensen  <achristensen@webkit.org>
2742
2743         Compile DumpRenderTree with CMake on Mac
2744         https://bugs.webkit.org/show_bug.cgi?id=156088
2745
2746         Reviewed by Brent Fulgham.
2747
2748         * CMakeLists.txt:
2749         * DumpRenderTree/CMakeLists.txt:
2750         * DumpRenderTree/DefaultPolicyDelegate.m:
2751         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2752         * DumpRenderTree/DumpRenderTreeFileDraggingSource.m:
2753         * DumpRenderTree/PlatformMac.cmake: Added.
2754         * DumpRenderTree/PlatformWin.cmake:
2755         * DumpRenderTree/mac/AppleScriptController.m:
2756         (convertAEDescToObject):
2757         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
2758         * DumpRenderTree/mac/LayoutTestHelper.m:
2759
2760 2016-03-31  Bill Ming  <mbbill@gmail.com>
2761
2762         https://bugs.webkit.org/show_bug.cgi?id=156094
2763         [Win] TestWebCore target build sometimes fail.
2764
2765         Reviewed by Alex Christensen.
2766
2767         * Tools/TestWebKitAPI/PlatformWin.cmake:
2768
2769 2016-03-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2770
2771         [EFL] Bump EFL version to 1.17.0
2772         https://bugs.webkit.org/show_bug.cgi?id=153008
2773
2774         Reviewed by Michael Catanzaro.
2775
2776         Original author is Csaba Osztrogonác  <ossy@webkit.org>
2777
2778         * efl/jhbuild.modules:
2779
2780 2016-03-31  Daniel Bates  <dabates@apple.com>
2781
2782         run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled
2783         https://bugs.webkit.org/show_bug.cgi?id=156071
2784         <rdar://problem/25467827>
2785
2786         Reviewed by Brent Fulgham.
2787
2788         Fixes an issue where run-webkit-tests will fail to create the suffixed user's cache directory
2789         on non-Apple Internal machines with System Integrity Protection enabled because the OS only
2790         honors the suffix, specified by the environment variable DIRHELPER_USER_DIR_SUFFIX, in
2791         privileged processes. And python(1) does not have sufficient privileges. As a workaround for
2792         systems that have System Integrity Protection enabled we compute the path to the suffixed
2793         user's cache directory by hand.
2794
2795         Additionally, fix an issue where the user's cache directory created by run-webkit-test was
2796         never deleted on cessation of the test run.
2797
2798         * Scripts/webkitpy/port/driver.py:
2799         (Driver._start): Actually store the path to the user's cache directory in self._driver_user_cache_directory
2800         so that we can delete this directory on cessation of the test run.
2801         * Scripts/webkitpy/port/mac.py:
2802         (MacPort):
2803         (MacPort._path_to_user_cache_directory): Unset the environment variable DIRHELPER_USER_DIR_SUFFIX (if set),
2804         query the OS for the path to the user's cache directory and concatenate this path with the
2805         specified suffix.
2806
2807 2016-03-31  Jiewen Tan  <jiewen_tan@apple.com>
2808
2809         WebKit should set Original URL of a download request correctly
2810         https://bugs.webkit.org/show_bug.cgi?id=155914
2811         <rdar://problem/10473811>
2812
2813         Reviewed by Anders Carlsson.
2814
2815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2816         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2817         (-[DownloadRequestOriginalURLDelegate initWithExpectOriginalURL:]):
2818         (-[DownloadRequestOriginalURLDelegate _downloadDidStart:]):
2819         (-[DownloadRequestOriginalURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2820         (TEST):
2821         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Added.
2822         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Added.
2823         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Added.
2824
2825 2016-03-30  Dewei Zhu  <dewei_zhu@apple.com>
2826
2827         Extend animometer timeout for slow CPUs.
2828         https://bugs.webkit.org/show_bug.cgi?id=156047
2829
2830         Reviewed by Ryosuke Niwa.
2831
2832         Extend animometer timeout to 30 minutes for slow device.
2833
2834         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
2835
2836 2016-03-30  Daniel Bates  <dabates@apple.com>
2837
2838         run-webkit-tests must create parent directory of user's cache directory before running tests
2839         https://bugs.webkit.org/show_bug.cgi?id=156009
2840         <rdar://problem/25442682>
2841
2842         Reviewed by Alexey Proskuryakov.
2843
2844         The script run-webkit-tests must create the parent directory of the user's cache directory
2845         before running tests because a WebKit2 child process expects that this directory exists
2846         when it starts.
2847
2848         The script run-webkit-tests influences the path chosen by a WebKit2 child process for the
2849         user's temporary directory and user's cache directory via the environment variable
2850         DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it
2851         as part of setting up the test environment. But run-webkit-tests does not create the user's
2852         cache directory. Therefore there is race between the time AppKit creates it and when the
2853         launched WebContent and Network processes query for the path to the user's cache directory
2854         such that the OS may return the empty string to the WebContent and Network processes if
2855         queried for this directory before AppKit creates it.
2856
2857         * Scripts/webkitpy/port/base.py:
2858         (Port._path_to_user_cache_directory): Added. Base class implementation that returns the
2859         empty string. We will override this method for the OS X port to return the path to the
2860         user's cache directory with the specified suffix.
2861         (Port.remove_cache_directory): Deleted.
2862         * Scripts/webkitpy/port/driver.py:
2863         (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory
2864         to the suffix to use for the user's temporary and cache directories and the path to the
2865         user's cache directory, respectively.
2866         (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX
2867         to self._driver_user_directory_suffix.
2868         (Driver._start): Compute the user directory suffix and the path to the user's cache
2869         directory. Create the user's cache directory (if applicable).
2870         (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable).
2871         * Scripts/webkitpy/port/mac.py:
2872         (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory().
2873         (MacPort.remove_cache_directory): Deleted.
2874
2875 2016-03-29  Benjamin Poulain  <bpoulain@apple.com>
2876
2877         [WTF] Removing a smart pointer from HashTable issues two stores to the same location
2878         https://bugs.webkit.org/show_bug.cgi?id=155676
2879
2880         Reviewed by Darin Adler.
2881
2882         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2883         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2884
2885 2016-03-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2886
2887         Add machine-readable results for JSC stress tests
2888         https://bugs.webkit.org/show_bug.cgi?id=155771
2889
2890         Reviewed by Darin Adler and Dean Johnson
2891
2892         Add an option to output JSC stress test results to a user-specified file in JSON format.
2893
2894         * Scripts/run-javascriptcore-tests:
2895         (runJSCStressTests): Add JSON output support
2896         (readAllLines): Remove trailing newline from the end of each item
2897
2898 2016-03-29  Alex Christensen  <achristensen@webkit.org>
2899
2900         Fix Windows build.
2901
2902         * TestWebKitAPI/PlatformWin.cmake:
2903
2904 2016-03-29  Timothy Hatcher  <timothy@apple.com>
2905
2906         Update WebKit nightly to have a red needle to better match Safari
2907
2908         https://bugs.webkit.org/show_bug.cgi?id=155983
2909
2910         Reviewed by Joseph Pecoraro.
2911
2912         * WebKitLauncher/webkit.icns:
2913
2914 2016-03-28  Joanmarie Diggs  <jdiggs@igalia.com>
2915
2916         Adding myself as a reviewer.
2917
2918         Unreviewed.
2919
2920         * Scripts/webkitpy/common/config/contributors.json:
2921
2922 2016-03-25  Dewei Zhu  <dewei_zhu@apple.com>
2923
2924         Dromaeo patch used by run-benchmark should not include an invalid address.
2925         https://bugs.webkit.org/show_bug.cgi?id=155910
2926
2927         Reviewed by Ryosuke Niwa.
2928
2929         Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.
2930         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
2931
2932 2016-03-25  Daniel Bates  <dabates@apple.com>
2933
2934         Add WebKitSystemInterface for iOS 9.3
2935         https://bugs.webkit.org/show_bug.cgi?id=155893
2936
2937         Rubber-stamped by Alexey Proskuryakov.
2938
2939         * Scripts/copy-webkitlibraries-to-product-directory:
2940
2941 2016-03-25  Daniel Bates  <dabates@apple.com>
2942
2943         Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
2944         in copy-webkitlibraries-to-product-directory
2945         https://bugs.webkit.org/show_bug.cgi?id=155869
2946
2947         Reviewed by Alexey Proskuryakov.
2948
2949         It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
2950         webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
2951         line argument.
2952
2953         * Scripts/copy-webkitlibraries-to-product-directory:
2954
2955 2016-03-25  Konstantin Tokarev  <annulen@yandex.ru>
2956
2957         Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
2958         https://bugs.webkit.org/show_bug.cgi?id=155882
2959
2960         Reviewed by Michael Catanzaro.
2961
2962         It was already enabled in all trunk ports, and is required for
2963         WebInspectorUI to work.
2964
2965         * Scripts/webkitperl/FeatureList.pm:
2966
2967 2016-03-24  Jeremy Zerfas  <WebKit@JeremyZerfas.com>
2968
2969         Improve update-webkit-dependency script.
2970         https://bugs.webkit.org/show_bug.cgi?id=155576
2971
2972         Reviewed by Brent Fulgham.
2973
2974         * Scripts/update-webkit-dependency:
2975         -Updated script to also use ETags for helping to determine whether dependency is up to date.
2976         -Updated script so it usually won't need to download the entire dependency each time it is
2977          ran.
2978         -Updated script to ensure zip file contains expected directories before trying to install.
2979         -Added some more error checking and improved error messages.
2980         (lastModifiedToUnixTime): Deleted.
2981
2982         * Scripts/update-webkit-wincairo-libs:
2983         -Corrected comment about what script does.
2984
2985 2016-03-24 Bill Ming <mbbill@gmail.com>
2986
2987         Fix webkitpy tests after r198617
2988         https://bugs.webkit.org/show_bug.cgi?id=155827
2989
2990         Reviewed by Alex Christensen.
2991
2992         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2993         (ConfirmDiff._show_pretty_diff):
2994
2995 2016-03-23  Bill Ming  <mbbill@gmail.com>
2996
2997         webkit-patch failed to open pretty diff on Windows
2998         https://bugs.webkit.org/show_bug.cgi?id=155827
2999
3000         Reviewed by Alex Christensen.
3001
3002         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3003         (ConfirmDiff._show_pretty_diff):
3004
3005 2016-03-23  Jer Noble  <jer.noble@apple.com>
3006
3007         [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
3008         https://bugs.webkit.org/show_bug.cgi?id=155764
3009
3010         Reviewed by Eric Carlson.
3011
3012         Remove the requirement for media elements to have webkit-playsinline attributes on iOS.
3013
3014         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3015         (RequiresUserActionForPlaybackTest::SetUp):
3016
3017 2016-03-23  Anders Carlsson  <andersca@apple.com>
3018
3019         Crash when using KVO from within -[WebView initWithCoder:]
3020         https://bugs.webkit.org/show_bug.cgi?id=155816
3021         rdar://problem/17073265
3022
3023         Reviewed by Dan Bernstein.
3024
3025         Add test.
3026
3027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3028         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added.
3029         (-[EarlyKVOCrashResponder initWithWebView:]):
3030         (-[EarlyKVOCrashResponder initWithCoder:]):
3031         (-[EarlyKVOCrashResponder dealloc]):
3032         (-[EarlyKVOCrashResponder encodeWithCoder:]):
3033         (TestWebKitAPI::TEST):
3034
3035 2016-03-23  Lucas Forschler  <lforschler@apple.com>
3036
3037         Teach kill-old-processes about perl 5.18.
3038         
3039         Reviewed by Alexey Proskuryakov
3040
3041         * BuildSlaveSupport/kill-old-processes:
3042         (main):
3043
3044 2016-03-22  Keith Rollin  <krollin@apple.com>
3045
3046         Unreviewed: add Keith Rollin to the committers list.
3047
3048         * Scripts/webkitpy/common/config/contributors.json:
3049
3050 2016-03-22  Per Arne Vollan  <peavo@outlook.com>
3051
3052         [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
3053         https://bugs.webkit.org/show_bug.cgi?id=141499
3054
3055         Reviewed by Brent Fulgham.
3056
3057         As we have moved on to VS2015, this workaround is no longer needed.
3058
3059         * DumpRenderTree/cg/ImageDiffCG.cpp:
3060         (main):
3061         * DumpRenderTree/win/DumpRenderTree.cpp:
3062         (main):
3063         * DumpRenderTree/win/ImageDiffCairo.cpp:
3064         (main):
3065         * MiniBrowser/win/Common.cpp:
3066         (DllMain):
3067         * TestWebKitAPI/win/main.cpp:
3068         (main):
3069         * win/DLLLauncher/DLLLauncherMain.cpp:
3070         (wWinMain):
3071
3072 2016-03-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3073
3074         [JSC] ASMBench cannot be run without JSBENCH_PATH
3075         https://bugs.webkit.org/show_bug.cgi?id=155751
3076
3077         Reviewed by Saam Barati.
3078
3079         Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files.
3080
3081         * Scripts/run-jsc-benchmarks:
3082
3083 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
3084
3085         [Win] SharedBuffer::copy() can cause a segmentation fault.
3086         https://bugs.webkit.org/show_bug.cgi?id=155739
3087
3088         Reviewed by Ryosuke Niwa.
3089
3090         * TestWebKitAPI/PlatformWin.cmake: Build and run the
3091         SharedBuffer tests.
3092
3093 2016-03-22  Csaba Osztrogonác  <ossy@webkit.org>
3094
3095         [buildbot] Move ARM Linux bots to JSCOnly port
3096         https://bugs.webkit.org/show_bug.cgi?id=155655
3097
3098         Reviewed by Lucas Forschler.
3099
3100         * BuildSlaveSupport/build.webkit.org-config/config.json:
3101         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3102         (ConfigureBuild.__init__):
3103         (appendCustomBuildFlags):
3104         (CompileJSCOnly):
3105         (Factory.__init__):
3106         (BuildAndRemoteJSCTestsFactory):
3107         (BuildAndRemoteJSCTestsFactory.__init__):
3108         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3109         * BuildSlaveSupport/clean-build:
3110         (main):
3111
3112 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
3113
3114         Improve SharedBuffer testing
3115         https://bugs.webkit.org/show_bug.cgi?id=93078
3116         <rdar://problem/25277829>
3117
3118         Reviewed by Ryosuke Niwa.
3119
3120         Based on a Blink patch by Huang Dongsung <luxtella@company100.net>.
3121         <https://src.chromium.org/viewvc/blink?revision=153850&view=revision,
3122         and a Blink patch by <tyoshino@chromium.org>
3123         <https://src.chromium.org/viewvc/blink?view=rev&revision=151617>
3124
3125         Add three test cases from the Blink project that cover various append,
3126         copy, and createArrayBuffer calls.
3127
3128         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3129         (TestWebKitAPI::TEST_F):
3130
3131 2016-03-21  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3132
3133         [Win] Connect layoutTestController.findString() to support testing
3134         https://bugs.webkit.org/show_bug.cgi?id=50234
3135
3136         Reviewed by Alex Christensen.
3137
3138         Implement TestRunner::findString().
3139
3140         * DumpRenderTree/win/TestRunnerWin.cpp:
3141         (TestRunner::findString):
3142
3143 2016-03-20  Dan Bernstein  <mitz@apple.com>
3144
3145         [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
3146         https://bugs.webkit.org/show_bug.cgi?id=155707
3147         <rdar://problem/24980691>
3148
3149         Reviewed by Darin Adler.
3150
3151         * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR
3152           based on the last component of MACOSX_DEPLOYMENT_TARGET.
3153         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds,
3154           preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
3155
3156         Similarly for these projects:
3157
3158         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3159         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3160         * LayoutTestRelay/Configurations/Base.xcconfig:
3161         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3162         * MiniBrowser/Configurations/Base.xcconfig:
3163         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3164         * TestWebKitAPI/Configurations/Base.xcconfig:
3165         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3166         * WebEditingTester/Configurations/Base.xcconfig:
3167         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3168         * WebKitTestRunner/Configurations/Base.xcconfig:
3169         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3170
3171 2016-03-20  Dan Bernstein  <mitz@apple.com>
3172
3173         Update build settings
3174
3175         Rubber-stamped by Andy Estes.
3176
3177         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3178         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3179         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3180         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3181         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3182         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source.
3183         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3184         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3185         * asan/asan.xcconfig:
3186
3187 2016-03-18  Sam Weinig  <sam@webkit.org>
3188
3189         Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost
3190         https://bugs.webkit.org/show_bug.cgi?id=155621
3191
3192         Reviewed by Alex Christensen.
3193
3194         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3195         (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger):
3196         (TestWebKitAPI::testMovingUsingEnsure):
3197         (TestWebKitAPI::testMovingUsingAdd):
3198         Add tests ensuring that objects moved into a map using ensure don't
3199         have extra ref-churn.
3200
3201 2016-03-17  Tim Horton  <timothy_horton@apple.com>
3202
3203         Fix some deprecation warnings in WebEditingTester
3204         https://bugs.webkit.org/show_bug.cgi?id=155601
3205
3206         Reviewed by Simon Fraser.
3207
3208         * WebEditingTester/AppDelegate.m:
3209         (-[WebEditingAppDelegate showOperations:]):
3210         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3211
3212 2016-03-17  Tim Horton  <timothy_horton@apple.com>
3213
3214         Find-in-page indicator in Mail viewer is the wrong scale and cut off
3215         https://bugs.webkit.org/show_bug.cgi?id=155605
3216         <rdar://problem/23948165>
3217
3218         Reviewed by Simon Fraser.
3219
3220         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
3221         (TEST):
3222         Add a test that ensures that the find result image is correctly @2x.
3223         The NSImage size should be in points.
3224
3225 2016-03-16  Commit Queue  <commit-queue@webkit.org>
3226
3227         Unreviewed, rolling out r198187.
3228         https://bugs.webkit.org/show_bug.cgi?id=155564
3229
3230         Potentially break testing on iOS (Requested by Guest23 on
3231         #webkit).
3232
3233         Reverted changeset:
3234
3235         "Add twisted-15.5.0 module to
3236         webkitpy.thirdparty.autoinstalled."
3237         https://bugs.webkit.org/show_bug.cgi?id=154667
3238         http://trac.webkit.org/changeset/198187
3239
3240 2016-03-16  David Kilzer  <ddkilzer@apple.com>
3241
3242         check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
3243         <http://webkit.org/b/155445>
3244
3245         Reviewed by Darin Adler.
3246
3247         * Scripts/webkitpy/style/checker.py:
3248         (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
3249         on TestWebKitAPI since this project uses a config.h header as of
3250         r95188.  Also remove references to WebKitAPITest, which ceased
3251         to exist in r95944.
3252
3253         * Scripts/webkitpy/style/checker_unittest.py:
3254         (GlobalVariablesTest.test_path_rules_specifier): Add tests.
3255         Remove reference to WebKitAPITest project.
3256
3257 2016-03-16  Tim Horton  <timothy_horton@apple.com>
3258
3259         [mac] Printing test snapshots are upside-down after r198242
3260         https://bugs.webkit.org/show_bug.cgi?id=155543
3261
3262         Reviewed by Simon Fraser.
3263
3264         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3265         (createPagedBitmapContext):
3266         Flip printing snapshots in DRT so that everything is right-side-up.
3267
3268 2016-03-16  Alexey Proskuryakov  <ap@apple.com>
3269
3270         Update unit test for iOS debug queues.
3271
3272         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3273
3274 2016-03-16  Jiewen Tan  <jiewen_tan@apple.com>
3275
3276         URL Parsing should signal failure for illegal IDN
3277         https://bugs.webkit.org/show_bug.cgi?id=154945
3278         <rdar://problem/8014795>
3279
3280         Reviewed by Brent Fulgham.
3281
3282         * MiniBrowser/mac/WK2BrowserWindowController.m:
3283         (-[WK2BrowserWindowController fetch:]):
3284         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
3285         (TestWebKitAPI::TEST):
3286
3287 2016-03-15  Tim Horton  <timothy_horton@apple.com>
3288
3289         [iOS Simulator] Test result snapshots are upside down
3290         https://bugs.webkit.org/show_bug.cgi?id=154761
3291
3292         Reviewed by Simon Fraser.
3293
3294         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3295         (WTR::createCGContextFromImage):
3296         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3297         In r97104, Simon added code to take WindowServer snapshots, which came
3298         in flipped, and added code to flip them back. At this point, WindowServer
3299         snapshots got flipped, and software snapshots did not.
3300
3301         In r140067, Simon noticed that WindowServer ref test images were upside-down
3302         on Mac (not sure why this changed), so turned off the flipping code (but
3303         didn't delete it!). Now, WindowServer snapshots and software snapshots both
3304         are not flipped.
3305
3306         In r190304, Carlos added an enum for the source of the snapshot ("WebView"
3307         for window server snapshots, and "WebContent" for software snapshots),
3308         and - critically - changed the flipping logic to flip software snapshots!
3309
3310         We didn't notice this on Mac because at this point we've made it so that
3311         we *always* have WindowServer snapshots, but on iOS we still don't have
3312         WindowServer snapshots, so now they're flipped.
3313
3314         And that's how we got here.
3315
3316         To restore the behavior from r140067, and correctly unflip snapshots on
3317         iOS, just delete this code.
3318
3319 2016-03-15  Alexey Proskuryakov  <ap@apple.com>
3320
3321         run-api-tests doesn't print test name when the test crashes
3322         https://bugs.webkit.org/show_bug.cgi?id=155476
3323
3324         Reviewed by Daniel Bates.
3325
3326         * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
3327         doesn't contain the test name yet. Changed test name output to always be before raw
3328         stdout for clarity.
3329
3330 2016-03-15  Chris Dumez  <cdumez@apple.com>
3331
3332         Unreviewed, rolling out r198203.
3333
3334         Favorites view is no longer loading on iOS
3335
3336         Reverted changeset:
3337
3338         "URL Parsing should signal failure for illegal IDN"
3339         https://bugs.webkit.org/show_bug.cgi?id=154945
3340         http://trac.webkit.org/changeset/198203
3341
3342 2016-03-15  Jiewen Tan  <jiewen_tan@apple.com>
3343
3344         URL Parsing should signal failure for illegal IDN
3345         https://bugs.webkit.org/show_bug.cgi?id=154945
3346         <rdar://problem/8014795>
3347
3348         Reviewed by Brent Fulgham.
3349
3350         * MiniBrowser/mac/WK2BrowserWindowController.m:
3351         (-[WK2BrowserWindowController fetch:]):
3352         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
3353         (TestWebKitAPI::TEST):
3354
3355 2016-03-14  Chris Dumez  <cdumez@apple.com>
3356
3357         Unreviewed, rolling out r197981.
3358
3359         Caused a massive PLT regression on Mac.
3360
3361         Reverted changeset:
3362
3363         "Font antialiasing (smoothing) changes when elements are
3364         rendered into compositing layers"
3365         https://bugs.webkit.org/show_bug.cgi?id=23364
3366         http://trac.webkit.org/changeset/197981
3367
3368 2016-03-14  Dewei Zhu  <dewei_zhu@apple.com>
3369
3370         Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
3371         https://bugs.webkit.org/show_bug.cgi?id=154667
3372
3373         Reviewed by Ryosuke Niwa and Simon Fraser.
3374
3375         Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
3376         Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.
3377
3378         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3379         (ServerControl.render_POST): Deleted.
3380         * Scripts/webkitpy/thirdparty/__init__.py:
3381         (AutoinstallImportHook.find_module):
3382         (AutoinstallImportHook._install_twisted_15_5_0):
3383         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3384         (ThirdpartyTest.test_imports):
3385
3386 2016-03-14  Mark Lam  <mark.lam@apple.com>
3387
3388         Need to distinguish between Symbol() and Symbol("").
3389         https://bugs.webkit.org/show_bug.cgi?id=155438
3390
3391         Reviewed by Saam Barati.
3392
3393         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3394         (TestWebKitAPI::TEST):
3395         - Test that the a symbol with an empty string is not equivalent to a null symbol. 
3396
3397 2016-03-14  David Kilzer  <ddkilzer@apple.com>
3398
3399         Remove blank lines after #include "config.h"
3400
3401         Follow-up fix from review comments on Bug 155394.
3402
3403         * TestWebKitAPI/PlatformUtilities.cpp:
3404         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
3405
3406 2016-03-14  Frederic Wang  <fred.wang@free.fr>
3407
3408         Unreviewed: Add my professional email address.
3409
3410         * Scripts/webkitpy/common/config/contributors.json:
3411
3412 2016-03-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3413
3414         Web platform test server should not try to launch servers on already bound sockets
3415         https://bugs.webkit.org/show_bug.cgi?id=141157
3416
3417         Reviewed by Darin Adler.
3418
3419         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3420         (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json.
3421         (base_url): Refactored to use wpt_config_json routine.
3422         (WebPlatformTestServer.__init__): Fill port mappings according WPT config.
3423
3424 2016-03-13  Joseph Pecoraro  <pecoraro@apple.com>
3425
3426         Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
3427         https://bugs.webkit.org/show_bug.cgi?id=155417
3428
3429         Reviewed by Yusuke Suzuki.
3430
3431         * Scripts/webkitperl/FeatureList.pm:
3432         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3433
3434 2016-03-13  Dean Jackson  <dino@apple.com>
3435
3436         DRT should enable WebGL by default on Mac
3437         https://bugs.webkit.org/show_bug.cgi?id=155419
3438         <rdar://problem/25136981>
3439
3440         Reviewed by Sam Weinig.
3441
3442         For some reason, lost in time, WebGL was enabled
3443         by default on trunk, but disabled by default
3444         in DumpRenderTree when using WebKit 1. This
3445         was very annoying, because each test had
3446         an explicit command to enable it.
3447
3448         * DumpRenderTree/mac/DumpRenderTree.mm:
3449         (resetWebPreferencesToConsistentValues): Deleted WebGL line.
3450
3451 2016-03-13  Konstantin Tokarev  <annulen@yandex.ru>
3452
3453         Added new port JSCOnly.
3454         https://bugs.webkit.org/show_bug.cgi?id=154512
3455
3456         Reviewed by Michael Catanzaro.
3457
3458         This port allows to build JavaScriptCore engine with minimal
3459         dependencies.
3460
3461         * Scripts/build-jsc:
3462         * Scripts/webkitdirs.pm:
3463         (argumentsForConfiguration):
3464         (executableProductDir):
3465         (determinePortName):
3466         (isJSCOnly):
3467         (wrapperPrefixIfNeeded):
3468         (generateBuildSystemFromCMakeProject):
3469         (buildCMakeGeneratedProject):
3470
3471 2016-03-13  David Kilzer  <ddkilzer@apple.com>
3472
3473         TestWebKitAPI: fix linker warnings
3474         <http://webkit.org/b/155394>
3475
3476         Reviewed by Darin Adler.
3477
3478         * TestWebKitAPI/CMakeLists.txt:
3479         - Add RefLogger.cpp source file.
3480         - Add other missing cross-platform source files.
3481         - Add FIXMEs about RunLoop.cpp and about missing
3482           platform-specific source files.
3483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3484         - Add RefLogger.cpp source file.
3485
3486         * TestWebKitAPI/Counters.cpp:
3487         (DeleterCounter<ConstructorDestructorCounter>::deleterCount):
3488         Move specific declaration here to fix linker warning.
3489         * TestWebKitAPI/Counters.h:
3490         (DeleterCounter<T>::deleterCount): Remove declaration of global
3491         template variable.
3492
3493         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added.
3494         (TestWebKitAPI::log): Added.  Move inline definition in
3495         RefLogger.h to here to fix linker warning.
3496
3497         * TestWebKitAPI/Tests/WTF/RefLogger.h:
3498         (TestWebKitAPI::log): Replace inline function with declaration.
3499
3500 2016-03-12  David Kilzer  <ddkilzer@apple.com>
3501
3502         REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp
3503
3504         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to
3505         "Test.h" to fix incorrect case.  This was discovered when adding
3506         WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394.
3507
3508 2016-03-12  David Kilzer  <ddkilzer@apple.com>
3509
3510         run-webkit-tests: handle Darwin framework/library environment variables more consistently
3511         <http://webkit.org/b/155392>
3512
3513         Reviewed by Daniel Bates.
3514
3515         These changes will make it possible to pass through environment
3516         variables from the run-webkit-tests command-line.
3517
3518         * Scripts/webkitpy/port/base.py:
3519         (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH,
3520         __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the
3521         list of variables to keep from the run-webkit-test environment.
3522
3523         * Scripts/webkitpy/port/driver.py:
3524         (Driver._append_environment_variable_path): Add method to append
3525         a path to an environment variable, or set the path if the
3526         variable doesn't exist.
3527         (Driver._setup_environ_for_driver): Extract build_root_path into
3528         a local variable.  Use Driver._append_environment_variable_path
3529         to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH,
3530         DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of
3531         overwriting them.
3532
3533         * Scripts/webkitpy/port/driver_unittest.py:
3534         (DriverTest.test__append_environment_variable_path): Add test
3535         method to test Driver._append_environment_variable_path.
3536
3537 2016-03-11  Alexey Proskuryakov  <ap@apple.com>
3538
3539         [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out
3540         https://bugs.webkit.org/show_bug.cgi?id=155276
3541
3542         [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out
3543         https://bugs.webkit.org/show_bug.cgi?id=155345
3544
3545         [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
3546         https://bugs.webkit.org/show_bug.cgi?id=153997
3547         <rdar://problem/23580034>
3548
3549         <rdar://problem/23580018> TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty
3550
3551         Rubber-stamped by Filip Pizlo.
3552
3553         * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout.
3554
3555         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
3556         on iOS again.
3557
3558 2016-03-11  Jer Noble  <jer.noble@apple.com>
3559
3560         [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting
3561         https://bugs.webkit.org/show_bug.cgi?id=155365
3562
3563         Reviewed by Darin Adler.
3564
3565         Allow tests running on iOS simulator to play video inline, avoiding this assert.
3566
3567         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3568         (RequiresUserActionForPlaybackTest::SetUp):
3569
3570 2016-03-11  Frederic Wang  <fwang@igalia.com>
3571
3572         [jhbuild] Disable LLVM OCaml bindings.
3573         https://bugs.webkit.org/show_bug.cgi?id=153274
3574
3575         Reviewed by Michael Catanzaro.
3576
3577         * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM.
3578
3579 2016-03-11  Commit Queue  <commit-queue@webkit.org>
3580
3581         Unreviewed, rolling out r197495.
3582         https://bugs.webkit.org/show_bug.cgi?id=155369
3583
3584         LLVM is needed to run update-webkitgtk-libs reliably
3585         (Requested by mcatanzaro on #webkit).
3586
3587         Reverted changeset:
3588
3589         "[jhbuild] Remove LLVM dependency."
3590         https://bugs.webkit.org/show_bug.cgi?id=153274
3591         http://trac.webkit.org/changeset/197495
3592
3593 2016-03-11  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3594
3595         WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
3596         https://bugs.webkit.org/show_bug.cgi?id=153419
3597
3598         Reviewed by Darin Adler.
3599
3600         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3601         (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase.
3602
3603
3604 2016-03-10  Simon Fraser  <simon.fraser@apple.com>
3605
3606         Font antialiasing (smoothing) changes when elements are rendered into compositing layers
3607         https://bugs.webkit.org/show_bug.cgi?id=23364
3608
3609         Reviewed by Tim Horton.
3610
3611         Turn off smoothed layer text because it affects many layout test results.
3612
3613         * DumpRenderTree/mac/DumpRenderTree.mm:
3614         (resetWebViewToConsistentStateBeforeTesting):
3615         * WebKitTestRunner/TestController.cpp:
3616         (WTR::TestController::resetStateToConsistentValues):
3617
3618 2016-03-10  Jer Noble  <jer.noble@apple.com>
3619
3620         Partial roll-out of r197953; test fails because encode/decode support of those properties were never added.
3621
3622         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3623         (TEST): Deleted.
3624
3625 2016-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3626
3627         [OS X] Main frame scrollbars should appear on the left on RTL systems
3628         https://bugs.webkit.org/show_bug.cgi?id=155149
3629
3630         Reviewed by Simon Fraser.
3631
3632         Setting the volatile default needs to be done early, so it is
3633         plumbed through the injected bundle's initialization routine.
3634
3635         Control of RTL scrollbars is handled by putting the string
3636         <!-- webkit-test-runner [ rtlScrollbars=true ] -->
3637         on the first line of a test.
3638
3639         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3640         (WTR::shouldUseRTLScrollbars):
3641         (WTR::InjectedBundle::platformInitialize):
3642         * WebKitTestRunner/TestController.cpp:
3643         (WTR::TestController::generatePageConfiguration):
3644         (WTR::updateTestOptionsFromTestHeader):
3645         (WTR::TestController::getInjectedBundleInitializationUserData):
3646         * WebKitTestRunner/TestController.h:
3647         * WebKitTestRunner/TestOptions.h:
3648         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3649         (WTR::PlatformWebView::viewSupportsOptions):
3650
3651 2016-03-08  Jer Noble  <jer.noble@apple.com>
3652
3653         Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
3654         https://bugs.webkit.org/show_bug.cgi?id=155141
3655
3656         Reviewed by Beth Dakin.
3657
3658         Set the default values for media preferences unconditionally, not just on PLATFORM(IOS). Set "video requires user gesture"
3659         to sane defaults in addition to "audio requires user gesture" and (in the case of DumpREnderTree) instead of "media requires user gesture".
3660
3661         Add a new test of WK2 user gesture requirement preferences.
3662
3663         * DumpRenderTree/mac/DumpRenderTree.mm:
3664         (resetWebPreferencesToConsistentValues):
3665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3666         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
3667         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
3668         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Added.
3669         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]):
3670         (-[RequiresUserActionForPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
3671         (RequiresUserActionForPlaybackTest::SetUp):
3672         (RequiresUserActionForPlaybackTest::createWebView):
3673         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
3674         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
3675         (RequiresUserActionForPlaybackTest::testAudioOnly):
3676         (TEST_F):
3677         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3678         (TEST):
3679
3680 2016-03-10  Brian Burg  <bburg@apple.com>
3681
3682         Web Inspector: should be able to run protocol and input generator scripts from any directory
3683         https://bugs.webkit.org/show_bug.cgi?id=155307
3684
3685         Reviewed by Joseph Pecoraro.
3686
3687         * Scripts/webkitpy/inspector/main.py:
3688         (InspectorGeneratorTests.main):
3689         * Scripts/webkitpy/replay/main.py:
3690         (InputGeneratorTests.main):
3691         Compute the current SCM based on the location of the script being executed, not
3692         the $CWD which could be anything. There's rarely a good reason to use $CWD.
3693
3694 2016-03-10  David Kilzer  <ddkilzer@apple.com>
3695
3696         [iOS] DumpRenderTree crashes when accessing window.testRunner.inspectorTestStubURL
3697         <http://webkit.org/b/155295>
3698
3699         Reviewed by Brent Fulgham.
3700
3701         * DumpRenderTree/mac/TestRunnerMac.mm:
3702         (TestRunner::inspectorTestStubURL): Always return nullptr for
3703         PLATFORM(IOS).  This matches what we did in r192604 for
3704         WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm.
3705
3706 2016-03-10  Frederic Wang  <fwang@igalia.com>
3707
3708         [GTK] Add support for WOFF2
3709         https://bugs.webkit.org/show_bug.cgi?id=152616
3710
3711         Reviewed by Carlos Garcia Campos.
3712
3713         * Scripts/webkitpy/style/checker.py: Only verify basic style for third party modules brotli and woff2.
3714
3715 2016-03-09  Ryosuke Niwa  <rniwa@webkit.org>
3716
3717         Add runtime flags for shadow DOM and custom elements
3718         https://bugs.webkit.org/show_bug.cgi?id=155213
3719
3720         Reviewed by Dean Jackson.
3721
3722         Always enable shadow DOM and custom elements during testing.
3723
3724         * DumpRenderTree/mac/DumpRenderTree.mm:
3725         (resetWebPreferencesToConsistentValues):
3726         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3727         (WTR::InjectedBundle::beginTesting):
3728         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3729         (WTR::TestRunner::setShadowDOMEnabled): Added.
3730         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3731
3732 2016-03-09  Brent Fulgham  <bfulgham@apple.com>
3733
3734         Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
3735         https://bugs.webkit.org/show_bug.cgi?id=155265
3736         <rdar://problem/11101440>
3737
3738         Reviewed by Andy Estes.
3739
3740         WK2 localStorage tests need the 'AllowUniversalAccessFromFileURLs' preference set by default.
3741         Tests that confirm blocking localStorage manually set the flag to "False" in the test.
3742
3743         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3744         (WTR::initializeWebViewConfiguration): Set the default state to the correct value.
3745
3746 2016-03-09  David Kilzer  <ddkilzer@apple.com>
3747
3748         check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files
3749         <http://webkit.org/b/155273>
3750
3751         Reviewed by Andy Estes.
3752
3753         * Scripts/webkitpy/style/checkers/cpp.py:
3754         (check_spacing_for_function_call): Ignore @catch lines.
3755         (check_braces): Ditto.
3756         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3757         (CppStyleTest.test_brace_at_begin_of_line): Add test case.
3758
3759 2016-03-09  Jason Marcell  <jmarcell@apple.com>
3760
3761         Removing reference to Dashboard.Repository.Internal.trac from open source unit tests.
3762         https://bugs.webkit.org/show_bug.cgi?id=155274
3763
3764         Reviewed by Alexey Proskuryakov.
3765
3766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:
3767         (setup): Deleted. In bug 154180 we removed Dashboard.Repository.Internal which was causing an
3768         error in the unit tests.
3769
3770 2016-03-09  Aakash Jain  <aakash_jain@apple.com>
3771
3772         use ulimit command to check process limit in webkitpy
3773         https://bugs.webkit.org/show_bug.cgi?id=155260
3774
3775         Reviewed by Alexey Proskuryakov.
3776
3777         * Scripts/webkitpy/port/ios.py:
3778         (IOSSimulatorPort.default_child_processes): Use ulimit command output instead of 
3779         launchctl limit maxproc command.
3780
3781 2016-03-09  Alexey Proskuryakov  <ap@apple.com>
3782
3783         Stop building armv7 on iOS device builders
3784         https://bugs.webkit.org/show_bug.cgi?id=155246
3785
3786         Reviewed by David Kilzer.
3787
3788         * BuildSlaveSupport/build.webkit.org-config/config.json: Building both armv7 and
3789         armv7s makes the bots unnecessarily slow. We can catch super rare v7-only regressions
3790         elsewhere.
3791
3792         * Scripts/webkitpy/common/config/ews.json: Changed EWS to match, as we always want
3793         EWS configuration to be verified by buildbot queues.
3794
3795         * Scripts/webkitdirs.pm:
3796         * Scripts/webkitpy/port/ios.py:
3797         Changed default to arm64. I think that the default is probably not used in any
3798         practical scenarios, but it's nice to make it more sensible.
3799
3800 2016-03-09  Alexey Proskuryakov  <ap@apple.com>
3801
3802         Add iOS Simulator EWS to bot watcher's dashboard
3803         https://bugs.webkit.org/show_bug.cgi?id=155220
3804
3805         Reviewed by Lucas Forschler.
3806
3807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3808
3809 2016-03-09  Brent Fulgham  <bfulgham@apple.com>
3810
3811         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
3812         https://bugs.webkit.org/show_bug.cgi?id=155185
3813         <rdar://problem/11101440>
3814
3815         Reviewed by Anders Carlsson.
3816
3817         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
3818         (TestWebKitAPI::TEST): Allow local file accesss to run test.
3819         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3820         (TEST): Ditto.
3821         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
3822         (TEST): Ditto.
3823
3824 2016-03-09  Tim Horton  <timothy_horton@apple.com>
3825
3826         Removing and re-adding a script message handler with the same name results in an unusable message handler
3827         https://bugs.webkit.org/show_bug.cgi?id=155223
3828
3829         Reviewed by Sam Weinig.
3830
3831         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3832         (TEST):
3833         Add a test ensuring that it is possible to remove and re-add a script message handler
3834         with the same name and still dispatch messages to it.
3835
3836 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
3837
3838         Fix iOS Simulator EWS.
3839
3840         Unreviewed build fix.
3841
3842         * Scripts/webkitpy/common/config/ports.py:
3843
3844 2016-03-08  Aakash Jain  <aakash_jain@apple.com>
3845
3846         Booting multiple iOS simulator parallely fails sometimes
3847         https://bugs.webkit.org/show_bug.cgi?id=155208
3848         <rdar://problem/25019651>
3849
3850         Reviewed by Darin Adler.
3851
3852         * Scripts/webkitpy/port/ios.py:
3853         (IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent
3854         simulator boot.
3855
3856 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
3857
3858         Add iOS debug testers to flakiness dashboard
3859         https://bugs.webkit.org/show_bug.cgi?id=155206
3860
3861         Reviewed by Darin Adler.
3862
3863         * TestResultServer/static-dashboards/builders.jsonp:
3864
3865 2016-03-08  Oliver Hunt  <oliver@apple.com>
3866
3867         Start moving to separated writable and executable mappings in the JIT
3868         https://bugs.webkit.org/show_bug.cgi?id=155178
3869
3870         Reviewed by Fil Pizlo.
3871
3872         Making run-jsc-benchmarks slightly happier on my machine.
3873
3874         * Scripts/run-jsc-benchmarks:
3875
3876 2016-03-08  Anders Carlsson  <andersca@apple.com>
3877
3878         Use NSUInteger instead of NSWindowStyleMask.
3879
3880         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3881
3882 2016-03-08  Anders Carlsson  <andersca@apple.com>
3883
3884         Fix build.
3885
3886         We intentionally don't use AppKitCompatibilityDeclarations.h here, since we want
3887         MiniBrowser to build without WTF.
3888
3889         * MiniBrowser/mac/AppDelegate.m:
3890         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3891         * MiniBrowser/mac/BrowserWindowController.m:
3892         (-[BrowserWindowController windowDidLoad]):
3893         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3894
3895 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
3896
3897         Add iOS simulator EWS that runs tests
3898         https://bugs.webkit.org/show_bug.cgi?id=155175
3899
3900         Reviewed by Lucas Forschler.
3901
3902         * QueueStatusServer/config/queues.py:
3903         * Scripts/webkitpy/common/config/ews.json:
3904         * Scripts/webkitpy/common/config/ports.py:
3905
3906 2016-03-08  Commit Queue  <commit-queue@webkit.org>
3907
3908         Unreviewed, rolling out r197793 and r197799.
3909         https://bugs.webkit.org/show_bug.cgi?id=155195
3910
3911         something weird happened while landing this and everything
3912         broke (Requested by olliej on #webkit).
3913
3914         Reverted changesets:
3915
3916         "Start moving to separated writable and executable mappings in
3917         the JIT"
3918         https://bugs.webkit.org/show_bug.cgi?id=155178
3919         http://trac.webkit.org/changeset/197793
3920
3921         "arm64 build fix after r197793."
3922         http://trac.webkit.org/changeset/197799
3923
3924 2016-03-08  Oliver Hunt  <oliver@apple.com>
3925
3926         Start moving to separated writable and executable mappings in the JIT
3927         https://bugs.webkit.org/show_bug.cgi?id=155178
3928
3929         Reviewed by Filip Pizlo.
3930
3931         Making run-jsc-benchmarks slightly happier on my machine.
3932
3933         * Scripts/run-jsc-benchmarks:
3934
3935 2016-03-08  Daniel Bates  <dabates@apple.com>
3936
3937         Support iterating over an OptionSet and checking if it is empty
3938         https://bugs.webkit.org/show_bug.cgi?id=154941
3939         <rdar://problem/24964187>
3940
3941         Reviewed by Darin Adler.
3942
3943         Add tests to ensure that we do not regression both iteration of an OptionSet and
3944         determining whether an OptionSet is empty.
3945
3946         * TestWebKitAPI/Test.h:
3947         (TestWebKitAPI::Util::assertStrongEnum): Helper function to assert two strong enum type for equality.
3948         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
3949         (TestWebKitAPI::TEST):
3950
3951 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
3952
3953         Add debug iOS Simulator bots to the dashboard
3954         https://bugs.webkit.org/show_bug.cgi?id=155157
3955
3956         Reviewed by Darin Adler.
3957
3958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3959
3960 2016-03-08  Alejandro G. Castro  <alex@igalia.com>
3961
3962         Unreviewed EFL build fix after r197752.
3963
3964         * Scripts/webkitperl/FeatureList.pm: Avoid MEDIA_STREAM
3965         compilation by default until EFL bumps gstreamer to 1.6.
3966
3967 2016-03-08  Alejandro G. Castro  <alex@igalia.com>
3968
3969         [GTK] [EFL] Avoid running mediastream tests by default until we compile by default
3970         https://bugs.webkit.org/show_bug.cgi?id=153540
3971
3972         Reviewed by Philippe Normand.
3973
3974         After bumping gstreamer to 1.6.3 in r196804 we can enable again
3975         compilation of mediastream and running the tests.
3976
3977         * Scripts/run-gtk-tests:
3978         (TestRunner): Enable again the UserMedia API test.
3979         * Scripts/webkitperl/FeatureList.pm: Enable the compilation of the
3980         mediastream by default.
3981         * gtk/jhbuild-webrtc.modules: Removed the specific jhbuild modules
3982         file.
3983         * gtk/jhbuild.modules: Bumped the openwebrtc version to the one we
3984         are currently using.
3985
3986 2016-03-07  Jon Lee  <jonlee@apple.com>
3987
3988         Update perf bot configuration for Animometer
3989         https://bugs.webkit.org/show_bug.cgi?id=155134
3990
3991         Reviewed by Ryosuke Niwa.
3992
3993         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Refactor the patch
3994         to work with the latest version of the harness.
3995         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Bump up the timeout,
3996         and use the latest version of the harness.
3997
3998 2016-03-07  Joanmarie Diggs  <jdiggs@igalia.com>
3999
4000         [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0
4001         https://bugs.webkit.org/show_bug.cgi?id=154839
4002
4003         Reviewed by Michael Catanzaro.
4004
4005         Add '-Wno-error' to jhbuildrc; remove it from the module sets for macos.
4006
4007         * gtk/jhbuild-webrtc.modules:
4008         * gtk/jhbuild.modules:
4009         * gtk/jhbuildrc:
4010
4011 2016-03-07  Aakash Jain  <aakash_jain@apple.com>
4012
4013         webkitpy should verify timestamp from CrashLogs while collecting all crash logs
4014         https://bugs.webkit.org/show_bug.cgi?id=155000
4015         <rdar://problem/24860219>
4016
4017         Reviewed by Alexey Proskuryakov.
4018
4019         * Scripts/webkitpy/common/system/crashlogs.py:
4020         (CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected 
4021         time range, because file modification time is not always accurate.
4022         (CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs.
4023         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4024         (CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function.
4025
4026 2016-03-06  Alexey Proskuryakov  <ap@apple.com>
4027
4028         build-webkit prints an error on iOS simulator bots
4029         https://bugs.webkit.org/show_bug.cgi?id=155078
4030
4031         Reviewed by Dan Bernstein.
4032
4033         This happens when build-layouttestrelay sets $xcodeSDK to undefined, to use host SDK.
4034
4035         * Scripts/webkitdirs.pm: (buildXCodeProject): There is no need to pass -sdk, because
4036         XcodeOptions() already passes SDKROOT as appropriate.
4037
4038         * Scripts/build-layouttestrelay: Added a FIXME. Resetting $xcodeSDK doesn't reset
4039         any other configuration variables that were derived from its initial value, like $portName.
4040
4041 2016-03-05  Tim Horton  <timothy_horton@apple.com>
4042
4043         Create a DOMHTMLVideoElement when wrapping <video> elements
4044         https://bugs.webkit.org/show_bug.cgi?id=155084
4045         <rdar://problem/24997193>
4046
4047         Reviewed by Dan Bernstein.
4048
4049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4050         * TestWebKitAPI/Tests/mac/DOMHTMLVideoElementWrapper.mm: Added.
4051         (-[VideoWrapperFrameLoadDelegate webView:didFinishLoadForFrame:]):
4052         (TestWebKitAPI::TEST):
4053         Add an API test for this behavior.
4054
4055 2016-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4056
4057         [GTK] Fix logging details after r197505 (Run the run-benchmark script on the performance bot.)
4058         https://bugs.webkit.org/show_bug.cgi?id=154595
4059
4060         Unreviewed.
4061
4062         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
4063         (start): Use logging.exception when a test fails in order to get the details about the error.
4064
4065 2016-03-04  Alexey Proskuryakov  <ap@apple.com>
4066
4067         Add iOS simulator debug bots
4068         https://bugs.webkit.org/show_bug.cgi?id=155053
4069
4070         Reviewed by Lucas Forschler.
4071
4072         * BuildSlaveSupport/build.webkit.org-config/config.json:
4073
4074 2016-03-04  Brent Fulgham  <bfulgham@apple.com>
4075
4076         [WK2] Gather resource load statistics
4077         https://bugs.webkit.org/show_bug.cgi?id=154278
4078         <rdar://problem/24702892>
4079
4080         Reviewed by Andy Estes.
4081
4082         * MiniBrowser/mac/AppDelegate.m:
4083         (defaultConfiguration): Retrieve state of the ResourceLoadStatisticsEnabled setting.
4084         * MiniBrowser/mac/SettingsController.m:
4085         (-[SettingsController _populateMenu]): Move setting from WK1-only to be
4086         universally applicable.
4087         * MiniBrowser/mac/WK2BrowserWindowController.m:
4088         (-[WK2BrowserWindowController didChangeSettings]): Recognize when the
4089         Resource Load Statistics flag has changed.
4090
4091 2016-03-04  Alex Christensen  <achristensen@webkit.org>
4092
4093         Remove vcxproj build system
4094         https://bugs.webkit.org/show_bug.cgi?id=154388
4095
4096         Rubber-stamped by Brent Fulgham.
4097
4098         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Removed.
4099         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Removed.
4100         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Removed.
4101         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Removed.
4102         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Removed.
4103         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Removed.
4104         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Removed.
4105         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Removed.
4106         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Removed.
4107         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Removed.
4108         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Removed.
4109         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Removed.
4110         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Removed.
4111         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Removed.
4112         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Removed.
4113         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Removed.
4114         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Removed.
4115         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Removed.
4116         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Removed.
4117         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Removed.
4118         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Removed.
4119         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Removed.
4120         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Removed.
4121         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Removed.
4122         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Removed.
4123         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Removed.
4124         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Removed.
4125         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Removed.
4126         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Removed.
4127         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Removed.
4128         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Removed.
4129         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Removed.
4130         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Removed.
4131         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Removed.
4132         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Removed.
4133         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Removed.
4134         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Removed.
4135         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Removed.
4136         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Removed.
4137         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Removed.
4138         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Removed.
4139         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Removed.
4140         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Removed.
4141         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Removed.
4142         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Removed.
4143         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Removed.
4144         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Removed.
4145         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Removed.
4146         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Removed.
4147         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Removed.
4148         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Removed.
4149         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Removed.
4150         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Removed.
4151         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Removed.
4152         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Removed.
4153         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Removed.
4154         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Removed.
4155         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Removed.
4156         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Removed.
4157         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Removed.
4158         * TestWebKitAPI/TestWebKitAPI.vcxproj: Removed.
4159         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Removed.
4160         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Removed.
4161         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Removed.
4162         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Removed.
4163         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Removed.
4164         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Removed.
4165         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Removed.
4166         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Removed.
4167         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Removed.
4168         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Removed.
4169         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Removed.
4170         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Removed.
4171         * win/AssembleBuildLogs: Removed.
4172         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Removed.
4173         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Removed.
4174         * win/AssembleBuildLogs/AssembleLogs.cmd: Removed.
4175         * win/AssembleBuildLogs/README: Removed.
4176
4177 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
4178
4179         Whitespace causes font-variant: all-small-caps to synthesize
4180         https://bugs.webkit.org/show_bug.cgi?id=155004
4181         <rdar://problem/24630796>
4182
4183         Reviewed by Darin Adler.
4184
4185         * DumpRenderTree/mac/DumpRenderTree.mm:
4186         (allowedFontFamilySet):
4187         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4188         (WTR::allowedFontFamilySet):
4189         * WebKitTestRunner/mac/TestControllerMac.mm:
4190         (WTR::allowedFontFamilySet):
4191
4192 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
4193
4194         [iOS] Crash during font loading when injected bundle cancels load
4195         https://bugs.webkit.org/show_bug.cgi?id=155001
4196
4197         Reviewed by Tim Horton.
4198
4199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4200         * TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Added.
4201         * TestWebKitAPI/Tests/WebKit2/webfont.html: Added.
4202         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Added.
4203         (-[Myles webView:didFinishNavigation:]):
4204         (TEST):
4205         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Added.
4206         (-[CancelFontSubresourcePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4207         (-[CancelFontSubresourcePlugIn webProcessPlugInBrowserContextController:frame:willSendRequestForResource:request:redirectResponse:]):
4208
4209 2016-03-04  Konstantin Tokarev  <annulen@yandex.ru>
4210
4211         [check-webkit-style] Added checks for redundant virtual specifiers.
4212         https://bugs.webkit.org/show_bug.cgi?id=155017
4213
4214         Reviewed by Darin Adler.
4215
4216         Added 3 new checks related to virtual, override, and final specifiers:
4217
4218         1. When "override" is present, "virtual" is redundant.
4219         2. When "final" is present, "virtual" is redundant.
4220         3. When "final" is present, "override" is redundant.
4221
4222         * Scripts/webkitpy/style/checkers/cpp.py:
4223         (_FunctionState.begin):
4224         (_FunctionState.is_virtual):
4225         (_check_parameter_name_against_text):
4226         (_error_redundant_specifier):
4227         (check_function_definition):
4228         (CppChecker):
4229         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4230         (FunctionDetectionTest.perform_function_detection):
4231         (FunctionDetectionTest.test_basic_function_detection):
4232         (FunctionDetectionTest.test_function_declaration_detection):
4233         (FunctionDetectionTest.test_pure_function_detection):
4234         (FunctionDetectionTest.test_override_and_final_function_detection):
4235         (FunctionDetectionTest.test_non_functions):
4236         (FunctionDetectionTest.test_parameter_list):
4237
4238 2016-03-03  Darin Adler  <darin@apple.com>
4239
4240         Followup to:
4241         Remove "virtual" from all lines that have both "virtual" and "override".
4242         https://bugs.webkit.org/show_bug.cgi?id=155005
4243
4244         Reviewed by Geoffrey Garen.
4245
4246         * Scripts/do-webcore-rename: Added more regular expressions to make sure we always
4247         use either override or final, not both, and to remove virtual from all lines that
4248         have both virtual and final.
4249
4250 2016-03-03  Darin Adler  <darin@apple.com>
4251
4252         Remove "virtual" from all lines that have both "virtual" and "override".
4253         https://bugs.webkit.org/show_bug.cgi?id=155005
4254
4255         Reviewed by Geoffrey Garen.
4256
4257         * Scripts/do-webcore-rename: Added a regular expression to this script to do the job.
4258
4259 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4260
4261         [GTK] Unreviewed fix after r197505 (Run the run-benchmark script on the performance bot.)
4262         https://bugs.webkit.org/show_bug.cgi?id=154595
4263
4264         Unreviewed fix after r197505.
4265
4266         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4267         (RunBenchmarkTests.start):
4268
4269 2016-03-03  Daniel Bates  <dabates@apple.com>
4270
4271         Add unit tests for WTF::OptionSet
4272         https://bugs.webkit.org/show_bug.cgi?id=154925
4273         <rdar://problem/24964211>
4274
4275         Reviewed by Darin Adler.
4276
4277         Add tests to ensure that we do not regress the behavior of WTF::OptionSet.
4278
4279         * TestWebKitAPI/CMakeLists.txt: Add file TestWebKitAPI/Tests/WTF/OptionSet.cpp.
4280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
4281         * TestWebKitAPI/Tests/WTF/OptionSet.cpp: Added.
4282         (TestWebKitAPI::TEST):
4283
4284 2016-03-03  Commit Queue  <commit-queue@webkit.org>
4285
4286         Unreviewed, rolling out r197442.
4287         https://bugs.webkit.org/show_bug.cgi?id=154967
4288
4289         Broke tests, and also uses a wrong approach (Requested by ap
4290         on #webkit).
4291
4292         Reverted changeset:
4293
4294         "Disable FTL JIT testing on 32-bit JSC tester bots"
4295         https://bugs.webkit.org/show_bug.cgi?id=154858
4296         http://trac.webkit.org/changeset/197442
4297
4298 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4299
4300         [GTK] Run the run-benchmark script on the performance bot.
4301         https://bugs.webkit.org/show_bug.cgi?id=154595
4302
4303         Reviewed by Carlos Garcia Campos.
4304
4305         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add new RunBenchmarkTests step on the perf bots (only for the GTK+ port at this moment).
4306         (RunBenchmarkTests):
4307         (RunBenchmarkTests.start):
4308         (RunBenchmarkTests.getText):
4309         (RunBenchmarkTests.getText2):