[GStreamer][MiniBrowser] Honor GStreamer command line parameters in MiniBrowser
[WebKit-https.git] / Tools / ChangeLog
1 2018-02-20  Philippe Normand  <pnormand@igalia.com>
2
3         [GStreamer][MiniBrowser] Honor GStreamer command line parameters in MiniBrowser
4         https://bugs.webkit.org/show_bug.cgi?id=173655
5
6         Reviewed by Xabier Rodriguez-Calvar.
7
8         The FIXME in GStreamerUtilities.cpp asks to pass the command line
9         parameters to the GStreamer initialization function.
10
11         Based on initial patch by: Vanessa Chipirrás Navalón  <vchipirras@igalia.com>
12
13         * MiniBrowser/gtk/main.c:
14         (main): Add the group containing the Gstreamer options that the console displays.
15 2018-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
16
17         [WTR][GTK] crash log backtrace doesn't show symbol names for DatabaseProcess and NetworkProcess
18         https://bugs.webkit.org/show_bug.cgi?id=182953
19
20         Reviewed by Carlos Garcia Campos.
21
22         * Scripts/webkitpy/port/gtk.py:
23         (GtkPort._get_crash_log): Removed the code to convert WebProcess name.
24         * WebKitTestRunner/TestController.cpp:
25         (WTR::TestController::webProcessName): Return the correct program name for GTK+ port.
26         (WTR::TestController::networkProcessName): Ditto.
27         (WTR::TestController::databaseProcessName): Ditto.
28
29 2018-02-19  Ryan Haddad  <ryanhaddad@apple.com>
30
31         Unreviewed, rolling out r228696.
32
33         The API test added with this change is timing out on macOS.
34
35         Reverted changeset:
36
37         "Null pointer dereference in
38         WebPageProxy::urlSchemeHandlerForScheme()"
39         https://bugs.webkit.org/show_bug.cgi?id=182905
40         https://trac.webkit.org/changeset/228696
41
42 2018-02-16  Ryosuke Niwa  <rniwa@webkit.org>
43
44         Add an entitlement check for service worker on iOS
45         https://bugs.webkit.org/show_bug.cgi?id=182865
46         <rdar://problem/37505903>
47
48         Reviewed by Brady Eidson.
49
50         Added the service worker entitlements to WebKitTestRunner and TestWebKitAPI on iOS.
51
52         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
53         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
54         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
55         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
56
57 2018-02-16  Youenn Fablet  <youenn@apple.com>
58
59         Allow specifying which plug-ins are supported
60         https://bugs.webkit.org/show_bug.cgi?id=182748
61
62         Reviewed by Chris Dumez.
63
64         Add support for a test runner API to specificy supported plug-ins.
65
66         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
67         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
68         (WTR::TestRunner::setPluginsAsUnsupported):
69         * WebKitTestRunner/InjectedBundle/TestRunner.h:
70         * WebKitTestRunner/TestController.cpp:
71         (WTR::TestController::resetStateToConsistentValues):
72         (WTR::TestController::setPluginsAsUnsupported):
73         * WebKitTestRunner/TestController.h:
74         * WebKitTestRunner/TestInvocation.cpp:
75         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
76
77 2018-02-16  Per Arne Vollan  <pvollan@apple.com>
78
79         Implement stopping of run loop in the WebContent process when using NSRunLoop.
80         https://bugs.webkit.org/show_bug.cgi?id=182499
81         <rdar://problem/37247424>
82
83         Reviewed by Brent Fulgham.
84
85         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
86         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessTerminate.mm: Added.
87         (TEST):
88
89 2018-02-15  Alexey Proskuryakov  <ap@apple.com>
90
91         Speed up dSYM generation on build.webkit.org with -gline-tables-only
92         https://bugs.webkit.org/show_bug.cgi?id=182841
93         rdar://problem/34579649
94
95         Reviewed by Aakash Jain.
96
97         Build speed and binary size improvements are so substantial that I'm willing to make
98         CI builds less suitable for debugging, which is not a common scenario anyway.
99         Crash logs will still have line numbers in them.
100
101         * BuildSlaveSupport/build.webkit.org-config/steps.py: (CompileWebKit.start):
102
103 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
104
105         WebCore headers should not be included relatively within dependent projects
106         https://bugs.webkit.org/show_bug.cgi?id=182805
107
108         Reviewed by Chris Dumez.
109
110         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
111         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
112         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
113         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
114         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
115         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
116
117 2018-02-15  Tomas Popela  <tpopela@redhat.com>
118
119         run-jsc-stress-tests - skip a test if any of the run commands evals to skip
120         https://bugs.webkit.org/show_bug.cgi?id=182729
121
122         If multiple run commands are specified and one of them evals to skip,
123         then the test is not skipped, because the run is scheduled while
124         evaluating other commands.
125
126         Remember if the test is going to be skipped - if yes, just stop
127         evaluating the other run commands.
128
129         Reviewed by Saam Barati.
130
131         * Scripts/run-jsc-stress-tests:
132
133 2018-02-14  Charlie Turner  <cturner@igalia.com>
134
135         Get Garden-O-Matic running again.
136         https://bugs.webkit.org/show_bug.cgi?id=179089
137
138         Reviewed by Carlos Alberto Lopez Perez.
139
140         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
141         (parseCommitData): Author field is not always spelled 'author' these days.
142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
143         No longer have a 32-bit builder.
144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
145         (ui.perf.View.base.init): createElement has a required parameter these days.
146         * Scripts/webkitpy/tool/commands/gardenomatic.py:
147         (GardenOMatic): Override use_globs so that platform lookup in config.js works.
148
149 2018-02-14  Don Olmstead  <don.olmstead@sony.com>
150
151         Remove unused ForwardingHeaders directories from Tools
152         https://bugs.webkit.org/show_bug.cgi?id=182813
153
154         Reviewed by Konstantin Tokarev.
155
156         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Removed.
157         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Removed.
158         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed.
159         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Removed.
160         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Removed.
161
162 2018-02-14  Daniel Bates  <dabates@apple.com>
163
164         Disallow cross-origin subresources from asking for credentials
165         https://bugs.webkit.org/show_bug.cgi?id=182579
166         <rdar://problem/36162271>
167
168         Reviewed by Andy Estes.
169
170         Add test option allowCrossOriginSubresourcesToAskForCredential (defaults to false)
171         so that tests can toggle between the old behavior and new behavior.
172
173         * DumpRenderTree/TestOptions.h:
174         * DumpRenderTree/TestOptions.mm:
175         (TestOptions::TestOptions):
176         * DumpRenderTree/mac/DumpRenderTree.mm:
177         (setWebPreferencesForTestOptions):
178         * WebKitTestRunner/TestController.cpp:
179         (WTR::TestController::resetPreferencesToConsistentValues):
180         (WTR::updateTestOptionsFromTestHeader):
181         * WebKitTestRunner/TestOptions.h:
182         (WTR::TestOptions::hasSameInitializationOptions const):
183
184 2018-02-12  Ryosuke Niwa  <rniwa@webkit.org>
185
186         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
187         https://bugs.webkit.org/show_bug.cgi?id=182564
188
189         Reviewed by Wenson Hsieh.
190
191         Updated assertions to make sure the trailing "}" of @list rules is includd in the style, the "style" element
192         is wrapped by "head" element (not present in the pasted markup since the fragment parsing algorithm strips away),
193         and the style content is enclosed in "<!--" and "-->".
194
195         Also use execCommand('insertHTML', ~) to insert the HTML obtained via dataTransfer.getData instead of innerHTML
196         to make sure our pasting code preserves the special style element for MSO list quirks.
197
198         Finally, added two more test cases for pasting content from Microsoft Word's compatibility mode.
199
200         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
201         (TEST):
202         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
203         (TEST):
204
205 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
206
207         [Tools] --wincairo should imply --64-bit by default.
208         https://bugs.webkit.org/show_bug.cgi?id=182753
209
210         Reviewed by Daniel Bates.
211
212         WinCairo does not currently support 32-bit and `--wincairo` itself should refer to a working platform.
213         This patch ensures x64 is determined correctly for `build-webkit --no-ninja` and `run-webkit-tests`.
214
215         * Scripts/webkitdirs.pm:
216         (determinePassedArchitecture):
217         (shouldBuild32Bit):
218         (determineShouldBuild32Bit):
219         (determineIsWin64):
220         * Scripts/webkitpy/common/config/ports.py:
221         (WinCairoPort.build_webkit_command):
222         * Scripts/webkitpy/common/config/ports_unittest.py:
223         (DeprecatedPortTest.test_wincairo_port):
224         * Scripts/webkitpy/port/win.py:
225         (WinCairoPort):
226
227 2018-02-13  Commit Queue  <commit-queue@webkit.org>
228
229         Unreviewed, rolling out r228431.
230         https://bugs.webkit.org/show_bug.cgi?id=182766
231
232         Regressed CMake build stability (Requested by dolmstead on
233         #webkit).
234
235         Reverted changeset:
236
237         "[CMake] Make WebCore headers copies"
238         https://bugs.webkit.org/show_bug.cgi?id=182512
239         https://trac.webkit.org/changeset/228431
240
241 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
242
243         [CMake] Make WebCore headers copies
244         https://bugs.webkit.org/show_bug.cgi?id=182512
245
246         Reviewed by Keith Miller.
247
248         * DumpRenderTree/CMakeLists.txt:
249         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
250         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
251         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
252         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
253         * TestWebKitAPI/PlatformGTK.cmake:
254         * TestWebKitAPI/PlatformWPE.cmake:
255         * TestWebKitAPI/PlatformWin.cmake:
256         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
257         (loadResourceIntoBuffer):
258         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
259         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
260         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
261         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
262         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
263
264 2018-02-13  Chris Dumez  <cdumez@apple.com>
265
266         REGRESSION (r228299): Broke reader mode in Safari
267         https://bugs.webkit.org/show_bug.cgi?id=182697
268         <rdar://problem/37399012>
269
270         Reviewed by Ryosuke Niwa.
271
272         Add API test coverage for responding asynchronously to the decidePolicyForNavigationResponse
273         delegate.
274
275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
276         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm: Added.
277         (-[TestAsyncNavigationDelegate webView:didFinishNavigation:]):
278         (-[TestAsyncNavigationDelegate webView:didFailNavigation:withError:]):
279         (-[TestAsyncNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
280         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
281         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
282         (TestWebKitAPI::TEST):
283
284 2018-02-12  John Wilander  <wilander@apple.com>
285
286         Resource Load Statistics: Classify resources as prevalent based on redirects to other prevalent resources
287         https://bugs.webkit.org/show_bug.cgi?id=182664
288         <rdar://problem/37372572>
289
290         Reviewed by Brent Fulgham.
291
292         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
293         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
294         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
295         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
296         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
297         * WebKitTestRunner/InjectedBundle/TestRunner.h:
298         * WebKitTestRunner/TestController.cpp:
299         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
300         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
301         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
302         * WebKitTestRunner/TestController.h:
303         * WebKitTestRunner/TestInvocation.cpp:
304         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
305
306 2018-02-12  Ross Kirsling  <ross.kirsling@sony.com>
307
308         download-latest-github-release .py should not use "browser download URL".
309         https://bugs.webkit.org/show_bug.cgi?id=182646
310
311         Reviewed by Per Arne Vollan.
312
313         * Scripts/download-latest-github-release.py:
314         Download request should be a proper GitHub API call and should actually include the token when applicable.
315         (Also clean up usage of args and print while we're in here.)
316
317 2018-02-12  Per Arne Vollan  <pvollan@apple.com>
318
319         EWS should run Windows tests.
320         https://bugs.webkit.org/show_bug.cgi?id=177967
321
322         Reviewed by Lucas Forschler.
323
324         This will help catch regressions at an early stage.
325
326         * Scripts/webkitpy/common/config/ews.json:
327
328 2018-02-08  Ryosuke Niwa  <rniwa@webkit.org>
329
330         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
331         https://bugs.webkit.org/show_bug.cgi?id=182564
332
333         Reviewed by Wenson Hsieh.
334
335         Added tests for pasting HTML with list items generated by Microsoft Word as well as HTML which looks like
336         the one generated by Microsoft Word but missing a proper "html" element at the beginning.
337
338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
339         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added test cases.
340         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm: Added test cases.
341         (msoListMarkupWithoutProperHTMLElement): Added.
342         * TestWebKitAPI/Tests/WebKitCocoa/mso-list.html: Added.
343
344 2018-02-09  Don Olmstead  <don.olmstead@sony.com>
345
346         [CMake] Make PAL headers copies
347         https://bugs.webkit.org/show_bug.cgi?id=182645
348
349         Reviewed by Alex Christensen.
350
351         * TestWebKitAPI/CMakeLists.txt:
352
353 2018-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
354
355         Pasting from Excel no longer provides text/html data
356         https://bugs.webkit.org/show_bug.cgi?id=182636
357         <rdar://problem/37087060>
358
359         Reviewed by Ryosuke Niwa.
360
361         Add new API tests to exercise pasting images with various other content types on macOS, and when dropping images
362         and HTML markup on iOS. See the WebCore ChangeLog for more detail.
363
364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
365         * TestWebKitAPI/Tests/WebKitCocoa/DataTransfer.html: Added.
366
367         Add a new API test harness that dumps various bits of information about a DataTransfer upon paste and drop.
368         While somewhat similar to some existing harnesses, this makes a distinction between the raw HTML data on the
369         pasteboard and the actual result of inserting said HTML into the DOM. This allows us to check that the HTML has
370         been sanitized, while making checks for the actual content of the HTML robust against inline style changes.
371
372         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
373         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm: Added.
374
375         Add a new test suite to exercise pasting mixed content types. In these test cases, the pasteboard contains a
376         file, with some combination of plain text, rich text, and URLs.
377
378         (imagePath):
379         (writeTypesAndDataToPasteboard):
380
381         Add a helper to write a var-arg list of content types and data to the general NSPasteboard.
382
383         (setUpWebView):
384         (markupString):
385         (TestWebKitAPI::TEST):
386         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
387         (TestWebKitAPI::testIconImageData):
388         (TestWebKitAPI::TEST):
389         * TestWebKitAPI/cocoa/TestWKWebView.h:
390
391         Move a private declaration of -[WKWebView paste:] out to TestWKWebView.h, so that it can be shared across
392         multiple tests. Currently, it only resides in PasteImage.mm, but I need it in PasteMixedContent.mm as well.
393
394 2018-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
395
396         Add a way to check if a host is an IP address
397         https://bugs.webkit.org/show_bug.cgi?id=182427
398
399         Reviewed by Alex Christensen.
400
401         Add unit test for URL::hostIsIPAddress().
402
403         * TestWebKitAPI/Tests/WebCore/URL.cpp:
404         (TestWebKitAPI::TEST_F):
405
406 2018-02-09  Philippe Normand  <pnormand@igalia.com>
407
408         [GStreamer] Layout test fast/replaced/border-radius-clip.html crashes with GStreamer-CRITICAL **: gst_segment_to_stream_time: assertion 'segment->format == format' failed in gst_segment_to_stream_time()
409         https://bugs.webkit.org/show_bug.cgi?id=176802
410
411         Reviewed by Xabier Rodriguez-Calvar.
412
413         * gstreamer/jhbuild.modules:
414         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Added.
415
416 2018-02-09  Philippe Normand  <pnormand@igalia.com>
417
418         [JHBuild] Update Mesa to version 17
419         https://bugs.webkit.org/show_bug.cgi?id=182599
420
421         Reviewed by Carlos Alberto Lopez Perez.
422
423         * gtk/jhbuild.modules: Update Mesa (and its dependencies, hopefully) to version 17.3.3.
424
425 2018-02-08  Chris Dumez  <cdumez@apple.com>
426
427         There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld
428         https://bugs.webkit.org/show_bug.cgi?id=182524
429         <rdar://problem/9057327>
430
431         Reviewed by Ryosuke Niwa.
432
433         Add API test coverage.
434
435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
436         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp: Added.
437         (TestWebKitAPI::runJavaScriptAlert):
438         (TestWebKitAPI::TEST):
439         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp: Added.
440         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::InjectedBundleDisableOverrideBuiltinsBehaviorTest):
441         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
442         * TestWebKitAPI/Tests/WebKit/override-builtins-test.html: Added.
443
444 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
445
446         TestController should not exercise cocoa-specific resource load statistics APIs
447         https://bugs.webkit.org/show_bug.cgi?id=182355
448
449         Reviewed by Alex Christensen.
450
451         Remove unnecessary use of platform-specific APIs in the TestController, since there are
452         cross-platform APIs to do the same thing.
453
454         Also, ensure callbacks execute before returning from TestController's functions, since
455         otherwise the tests are guaranteed to be flaky at best, and also since there's nothing to
456         prevent the TestController from being destroyed before the callbacks execute.
457
458         * WebKitTestRunner/TestController.cpp:
459         (WTR::resourceStatisticsVoidResultCallback):
460         (WTR::resourceStatisticsBooleanResultCallback):
461         (WTR::TestController::isStatisticsPrevalentResource):
462         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
463         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
464         (WTR::TestController::isStatisticsHasHadUserInteraction):
465         (WTR::TestController::isStatisticsGrandfathered):
466         (WTR::TestController::statisticsUpdateCookiePartitioning):
467         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
468         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
469         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
470         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
471         (WTR::resourceStatisticsCallback): Deleted.
472         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback): Deleted.
473         * WebKitTestRunner/TestController.h:
474         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
475         (WTR::toNSString): Deleted.
476         (WTR::TestController::setStatisticsLastSeen): Deleted.
477         (WTR::TestController::setStatisticsPrevalentResource): Deleted.
478         (WTR::TestController::isStatisticsPrevalentResource): Deleted.
479         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder): Deleted.
480         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo): Deleted.
481         (WTR::TestController::setStatisticsHasHadUserInteraction): Deleted.
482         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
483         (WTR::TestController::isStatisticsHasHadUserInteraction): Deleted.
484         (WTR::TestController::setStatisticsGrandfathered): Deleted.
485         (WTR::TestController::isStatisticsGrandfathered): Deleted.
486         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin): Deleted.
487         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin): Deleted.
488         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo): Deleted.
489         (WTR::TestController::setStatisticsTimeToLiveUserInteraction): Deleted.
490         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
491         (WTR::TestController::statisticsProcessStatisticsAndDataRecords): Deleted.
492         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
493         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
494         (WTR::TestController::statisticsSubmitTelemetry): Deleted.
495         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned): Deleted.
496         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval): Deleted.
497         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured): Deleted.
498         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval): Deleted.
499         (WTR::TestController::setStatisticsGrandfatheringTime): Deleted.
500         (WTR::TestController::setStatisticsMaxStatisticsEntries): Deleted.
501         (WTR::TestController::setStatisticsPruneEntriesDownTo): Deleted.
502         (WTR::TestController::statisticsClearInMemoryAndPersistentStore): Deleted.
503         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): Deleted.
504         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): Deleted.
505         (WTR::TestController::statisticsResetToConsistentState): Deleted.
506
507 2018-02-08  Jonathan Bedard  <jbedard@apple.com>
508
509         webkit-patch suggest-reviewers dies with AttributeError: 'NoneType' object has no attribute 'revision'
510         https://bugs.webkit.org/show_bug.cgi?id=182584
511
512         Reviewed by Daniel Bates.
513
514         It is possible that a specific revision has an empty ChangeLog. In this case, Checkout.commit_info_for_revision
515         will return 'None'. Checkout.recent_commit_infos_for_files should never return a set with 'None' in it.
516
517         * Scripts/webkitpy/common/checkout/checkout.py:
518         (Checkout.recent_commit_infos_for_files): Remove any empty commit information from the set.
519         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Add a file which references an empty ChangeLog.
520
521 2018-02-08  Matt Lewis  <jlewis3@apple.com>
522
523         Unreviewed, rolling out r228261.
524
525         This broke an internal build
526
527         Reverted changeset:
528
529         "Add a way to check if a host is an IP address"
530         https://bugs.webkit.org/show_bug.cgi?id=182427
531         https://trac.webkit.org/changeset/228261
532
533 2018-02-08  Commit Queue  <commit-queue@webkit.org>
534
535         Unreviewed, rolling out r228267, r228268, and r228269.
536         https://bugs.webkit.org/show_bug.cgi?id=182601
537
538         jhbuild socks (Requested by philn on #webkit).
539
540         Reverted changesets:
541
542         "[JHBuild] Update Mesa to version 17"
543         https://bugs.webkit.org/show_bug.cgi?id=182599
544         https://trac.webkit.org/changeset/228267
545
546         "Unreviewed, GTK build fix attempt after r228267."
547         https://trac.webkit.org/changeset/228268
548
549         "Unreviewed, final GTK build fix attempt after r228267."
550         https://trac.webkit.org/changeset/228269
551
552 2018-02-08  Philippe Normand  <pnormand@igalia.com>
553
554         Unreviewed, final GTK build fix attempt after r228267.
555
556         * gtk/jhbuild.modules: sha256sum for libdrm was for the tar.gz archive. Oops.
557
558 2018-02-08  Philippe Normand  <pnormand@igalia.com>
559
560         Unreviewed, GTK build fix attempt after r228267.
561
562         * gtk/jhbuild.modules: Update to libdrm version 2.4.89, Mesa 17 requires at least version 2.4.75.
563
564 2018-02-08  Philippe Normand  <pnormand@igalia.com>
565
566         [JHBuild] Update Mesa to version 17
567         https://bugs.webkit.org/show_bug.cgi?id=182599
568
569         Reviewed by Carlos Alberto Lopez Perez.
570
571         * gtk/jhbuild.modules: Update Mesa to version 17.3.3.
572
573 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
574
575         Add a way to check if a host is an IP address
576         https://bugs.webkit.org/show_bug.cgi?id=182427
577
578         Reviewed by Alex Christensen.
579
580         Add unit test for URL::hostIsIPAddress().
581
582         * TestWebKitAPI/Tests/WebCore/URL.cpp:
583         (TestWebKitAPI::TEST_F):
584
585 2018-02-07  Tim Horton  <timothy_horton@apple.com>
586
587         Evernote device management web view sometimes displays at the wrong scale
588         https://bugs.webkit.org/show_bug.cgi?id=182590
589         <rdar://problem/36633687>
590
591         Reviewed by Simon Fraser.
592
593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
594         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm.
595         (-[TestDelegateForScrollView dealloc]):
596         (TestWebKitAPI::TEST):
597         (-[WKScrollViewDelegateWithViewForZoomingOverridden viewForZoomingInScrollView:]):
598         Add a test that failed before the change that ensures that we don't
599         consult the external delegate for viewForZoomingInScrollView:, and that
600         we succesfully update the scale even if it matches that of the view
601         the external delegate returns for viewForZoomingInScrollView:.
602
603 2018-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
604
605         REGRESSION(r226396): File paths are inserted when dropping image files
606         https://bugs.webkit.org/show_bug.cgi?id=182557
607         <rdar://problem/37294120>
608
609         Reviewed by Ryosuke Niwa.
610
611         Tweak some image pasting API tests to ensure that file paths are not inserted when pasting images backed by
612         file paths on disk.
613
614         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
615         (TEST):
616
617 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
618
619         [GTK] Enable WebKit.GeolocationTransitionTo{High,Low}Accuracy tests
620         https://bugs.webkit.org/show_bug.cgi?id=125068
621
622         Unreviewed test gardening.
623
624         They do not appear to have failed since we started running them again in r226944.
625
626         * TestWebKitAPI/glib/TestExpectations.json:
627
628 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
629
630         [GTK] Enable WebKit.InjectedBundleFrameHitTest test
631         https://bugs.webkit.org/show_bug.cgi?id=120303
632
633         Unreviewed test gardening.
634
635         It does not appear to have failed since we started running it again in r226944.
636
637         * TestWebKitAPI/glib/TestExpectations.json:
638
639 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
640
641         [GTK] Enable WebKit.ForceRepaint test
642         https://bugs.webkit.org/show_bug.cgi?id=105532
643
644         Unreviewed test gardening.
645
646         It does not appear to have failed since we started running it again in r226944.
647
648         * TestWebKitAPI/glib/TestExpectations.json:
649
650 2018-02-07  Philippe Normand  <pnormand@igalia.com>
651
652         [JHBuild] Add libva in moduleset
653         https://bugs.webkit.org/show_bug.cgi?id=182384
654
655         Reviewed by Xabier Rodriguez-Calvar.
656
657         * gstreamer/jhbuild.modules: Add libva and disable spurious message output.
658         * gtk/install-dependencies: Remove libva from dependencies.
659         * wpe/install-dependencies: Ditto.
660
661 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
662
663         [GTK] Enable WebKit.NewFirstVisuallyNonEmptyLayoutFrames test
664         https://bugs.webkit.org/show_bug.cgi?id=85037
665
666         Unreviewed test gardening.
667
668         It does not appear to have failed since we started running it again in r226944.
669
670         * TestWebKitAPI/glib/TestExpectations.json:
671
672 2018-02-06  Leo Balter  <leonardo.balter@gmail.com>
673
674         Nit fix for ruby script called through Perl
675         https://bugs.webkit.org/show_bug.cgi?id=182552
676
677         Reviewed by Yusuke Suzuki.
678
679         * BuildSlaveSupport/build.webkit.org-config/steps.py:
680         (RunTest262Tests):
681
682 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
683
684         Remove WebCore/ForwardingHeaders directory
685         https://bugs.webkit.org/show_bug.cgi?id=182347
686
687         Reviewed by Keith Miller.
688
689         * WebKitTestRunner/TestController.cpp:
690
691 2018-02-06  Ross Kirsling  <ross.kirsling@sony.com>
692
693         webkit-patch upload should ask for confirmation before creating a new bug
694         https://bugs.webkit.org/show_bug.cgi?id=182551
695
696         Reviewed by Daniel Bates.
697
698         It is quite easy to paste unintended text into the bug number prompt. This creates a junk bug with an uneditable
699         first comment, which could result in embarrassment or potentially even a proprietary information leak.
700
701         * Scripts/webkitpy/tool/commands/upload_unittest.py:
702         (test_prepare):
703         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
704         (PromptForBugOrTitle):
705         (PromptForBugOrTitle.options):
706         (PromptForBugOrTitle.run):
707
708 2018-02-06  Youenn Fablet  <youenn@apple.com>
709
710         HasServiceWorkerRegistration bit should be sent when creating a new page
711         https://bugs.webkit.org/show_bug.cgi?id=182410
712
713         Reviewed by Chris Dumez.
714
715         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
716
717 2018-02-06  Andres Gomez  <agomez@igalia.com>
718
719         [GTK][WPE] Add dependencies watching lists for WKGTK+ and WPE
720         https://bugs.webkit.org/show_bug.cgi?id=182346
721
722         Reviewed by Michael Catanzaro.
723
724         Loren, Carlos and Andres are interested on the WKGTK+ dependencies
725         watchlist since they are running WKGTK+ EWS.
726
727         Similarly, Adrian and Carlos are running a WPE EWS.
728
729         * Scripts/webkitpy/common/config/watchlist: Added WPEDependencies
730           and WebKitGTKDependencies watchlists with the proper people.
731
732 2018-02-06  Andres Gomez  <agomez@igalia.com>
733
734         Unreviewed, canonicalize contributors.json
735
736         After Thibault's addition, automatic checks complain about
737         contributors.json with:
738
739         "[...] Use "validate-committer-lists --canonicalize" to reformat
740         it. [...]"
741
742         * Scripts/webkitpy/common/config/contributors.json: Canonicalize.
743
744 2018-02-06  Andres Gomez  <agomez@igalia.com>
745
746         Unreviewed, add Lorenzo Tilve to contributors.json
747
748         We need to add Loren to the contributors list in order to CC him
749         in Bugzilla.
750
751         * Scripts/webkitpy/common/config/contributors.json: Added Lorenzo
752           Tilve.
753
754 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
755
756         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
757         https://bugs.webkit.org/show_bug.cgi?id=182478
758
759         Reviewed by Alex Christensen.
760
761         For TestWebKitAPI, sources related to WebKitLegacy are built
762         at WebKit build. Those files should be reffered for WebKitLegacy build.
763
764         * TestWebKitAPI/PlatformWin.cmake:
765
766 2018-02-05  Daniel Bates  <dabates@apple.com>
767
768         REGRESSION (r217572): run-webkit-tests exits without emitting newline character
769         https://bugs.webkit.org/show_bug.cgi?id=182360
770
771         Rubber-stamped by Aakash Jain.
772
773         Fixes an annoyance where run-webkit-tests always exits without printing a newline character.
774         In the terminal this looks like:
775
776             $ Tools/Scripts/run-webkit-tests
777             Expected to fail, but passed: (7)
778             ...
779             Stopping WebSocket server ...$
780
781         This bug was caused by code added in r217572 to stop all run-webkit-tests started servers (e.g. an HTTP
782         server) from an at-exit handler. When run-webkit-tests runs successfully (i.e. without error or
783         control-C interruption) we would stop all such servers twice: once as part of ending the test
784         run and once from the at-exit handler. The latter never prints a trailing newline character hence
785         the state of the terminal (as depicted above). Instead LayoutTestRunner.stop_servers() should only
786         stop servers that it started in LayoutTestRunner.start_servers().
787
788         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
789         (LayoutTestRunner.__init__):
790         (LayoutTestRunner.start_servers):
791         (LayoutTestRunner.stop_servers):
792         Only start servers that run-webkit-tests has not already started and only stop servers that
793         run-webkit-tests started.
794
795         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
796         (LayoutTestRunnerTests.test_servers_started.is_websocket_server_running):
797         (LayoutTestRunnerTests.test_servers_started):
798         (LayoutTestRunnerTests.test_servers_started.is_websocket_servers_running): Deleted.
799         Update due to rename below.
800
801         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
802         (is_web_socket_server_running): Added.
803         (PyWebSocket.is_running): Deleted.
804
805         * Scripts/webkitpy/port/base.py:
806         (Port.is_http_server_running): Check if we already started the server ourself.
807         (Port.is_websocket_server_running): Formerly named is_websocket_servers_running. Modified
808         to check if we already started the server ourself. Take a similar approach as the other
809         Port.is_*_running methods and only check if an existing WebSocket server is running on the
810         non-secure server port. This is a simple heuristic and should be sufficient in practice.
811         (Port.is_wpt_server_running): Check if we already started the server ourself.
812         (Port.is_websocket_servers_running): Deleted; renamed to is_websocket_server_running().
813
814 2018-02-05  Daniel Bates  <dabates@apple.com>
815
816         prepare-ChangeLog gets confused about Python docstrings that contain the word "class" or "def"
817         https://bugs.webkit.org/show_bug.cgi?id=182405
818
819         Reviewed by David Kilzer.
820
821         String literal statements, including docstrings, do not demarcate a new scope in Python.
822         So, do not treat them like they do when building up the list of modified functions.
823
824         * Scripts/prepare-ChangeLog:
825         (get_function_line_ranges_for_python):
826         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
827         The expected ending line number for the last "pass" statement inside the scope of Class5 changed
828         from 97 to 98 because empty lines do not effect scope. This is consistent with the parsing
829         of the second "pass" statement in the scope of class Class5. A "pass" is a null operation that
830         is used as a syntactic placeholder when a statement is required. Ideally we would make
831         the parsing code smarter so as to avoid emitting ranges for "pass" statements that serve
832         not syntactic purpose.
833         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
834         (Class5):
835         (Class6):
836         (Class6.__init__):
837         (Class7):
838         (Class7.__init__):
839         (Class8):
840         (Class8.__init__):
841         Add some more tests.
842
843 2018-02-05  Matt Lewis  <jlewis3@apple.com>
844
845         Unreviewed, rolling out r228086.
846
847         This introduced a failure with API test
848         URLTest.HostIsIPAddress.
849
850         Reverted changeset:
851
852         "Add a way to check if a host is an IP address"
853         https://bugs.webkit.org/show_bug.cgi?id=182427
854         https://trac.webkit.org/changeset/228086
855
856 2018-02-05  John Wilander  <wilander@apple.com>
857
858         Storage Access API: Add testRunner.getAllStorageAccessEntries() to make testing easier and more explicit
859         https://bugs.webkit.org/show_bug.cgi?id=181601
860         <rdar://problem/36475837>
861
862         Reviewed by Alex Christensen.
863
864         http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html
865         was found to be flaky. With the testRunner.hasStorageAccessEntry() getter
866         it's possible to check access even if a frame doesn't respond timely to
867         postMessage after detach and attach.
868
869         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
870         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
871         (WTR::InjectedBundle::didReceiveMessageToPage):
872         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
873         (WTR::TestRunner::setStorageAccessAPIEnabled):
874             Just moved for source file grouping.
875         (WTR::TestRunner::getAllStorageAccessEntries):
876         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback):
877         * WebKitTestRunner/InjectedBundle/TestRunner.h:
878         * WebKitTestRunner/TestController.cpp:
879         (WTR::TestController::getAllStorageAccessEntries):
880             Note that this is just stubbed out, i.e. not implemented.
881         * WebKitTestRunner/TestController.h:
882         * WebKitTestRunner/TestInvocation.cpp:
883         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
884         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
885         * WebKitTestRunner/TestInvocation.h:
886         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
887         (WTR::TestController::getAllStorageAccessEntries):
888             This is the Cocoa-specific version of this test infrastructure.
889
890 2018-02-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
891
892         [Win] Enable multi CPU building on MSBuild.
893         https://bugs.webkit.org/show_bug.cgi?id=182446
894
895         Compiling itself already uses multi cores, but other stuff is still on single core.
896         This patch enables that by passing an argument to MSBuild.exe.
897
898         Reviewed by Alex Christensen.
899
900         * Scripts/webkitdirs.pm:
901         (determineNumberOfCPUs):
902         (buildVisualStudioProject):
903
904 2018-02-05  Alicia Boya García  <aboya@igalia.com>
905
906         Fix bug in MediaTime comparison for negative values with different scale.
907         https://bugs.webkit.org/show_bug.cgi?id=182433
908
909         Improved test coverage for MediaTime::compare().
910
911         Reviewed by Xabier Rodriguez-Calvar.
912
913         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
914         (TestWebKitAPI::TEST):
915
916 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
917
918         [SOUP] WebSockets must use system proxy settings
919         https://bugs.webkit.org/show_bug.cgi?id=126384
920
921         Reviewed by Michael Catanzaro.
922
923         Check also WebSockets in /webkit2/WebKitWebContext/proxy.
924
925         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
926         (ProxyTest::webSocketProxyServerCallback):
927         (ProxyTest::ProxyTest):
928         (ProxyTest::webSocketConnected):
929         (ProxyTest::createWebSocketAndWaitUntilConnected):
930         (webSocketServerCallback):
931         (testWebContextProxySettings):
932         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
933         (WebKitTestServer::~WebKitTestServer):
934         (WebKitTestServer::addWebSocketHandler):
935         (WebKitTestServer::removeWebSocketHandler):
936         (WebKitTestServer::getWebSocketURIForPath const):
937         (WebKitTestServer::getURIForPath const):
938         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
939         (WebKitTestServer::baseURI const):
940         (WebKitTestServer::baseWebSocketURI const):
941
942 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
943
944         Add a way to check if a host is an IP address
945         https://bugs.webkit.org/show_bug.cgi?id=182427
946
947         Reviewed by Alex Christensen.
948
949         Add unit test for URL::hostIsIPAddress().
950
951         * TestWebKitAPI/Tests/WebCore/URL.cpp:
952         (TestWebKitAPI::TEST_F):
953
954 2018-02-03  Charlie Turner  <cturner@igalia.com>
955
956         Add libmount to WPE dependencies
957         https://bugs.webkit.org/show_bug.cgi?id=182345
958
959         Reviewed by Michael Catanzaro.
960
961         * wpe/install-dependencies:
962
963 2018-02-02  Youenn Fablet  <youenn@apple.com>
964
965         W3C test exporter should allow exporting newly added files
966         https://bugs.webkit.org/show_bug.cgi?id=182369
967
968         Reviewed by Ryosuke Niwa.
969
970         * Scripts/webkitpy/common/checkout/scm/git.py:
971         (Git.apply_mail_patch):
972
973 2018-02-02  David Quesada  <david_quesada@apple.com>
974
975         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
976         https://bugs.webkit.org/show_bug.cgi?id=182363
977         rdar://problem/37093498
978
979         Reviewed by Ryosuke Niwa.
980
981         Updated ApplicationManifestParserTests to account for the new default scope behavior.
982
983         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
984         (assertManifestHasDefaultValues):
985         (TEST_F):
986
987 2018-02-02  Youenn Fablet  <youenn@apple.com>
988
989         Clearing all service worker registrations should wait for importing service worker registration to finish
990         https://bugs.webkit.org/show_bug.cgi?id=182407
991
992         Reviewed by Chris Dumez.
993
994         Make sure we finish clearing service worker registrations before running tests.
995
996         * WebKitTestRunner/TestController.cpp:
997         (WTR::TestController::resetStateToConsistentValues):
998         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
999         (WTR::clearServiceWorkerRegistrationsCallback):
1000         (WTR::TestController::clearServiceWorkerRegistrations):
1001         * WebKitTestRunner/TestController.h:
1002
1003 2018-02-02  Youenn Fablet  <youenn@apple.com>
1004
1005         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
1006         https://bugs.webkit.org/show_bug.cgi?id=182403
1007
1008         Reviewed by Alex Christensen.
1009
1010         * WebKitTestRunner/TestController.cpp:
1011         (WTR::TestController::generateContextConfiguration const):
1012         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1013         (WTR::initializeWebViewConfiguration):
1014
1015 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1016
1017         [GTK] WebDriver: tests step always times out in the bot
1018         https://bugs.webkit.org/show_bug.cgi?id=182437
1019
1020         Reviewed by Carlos Alberto Lopez Perez.
1021
1022         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
1023         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
1024
1025         * Scripts/run-webdriver-tests: Call teardown() after run().
1026         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1027         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
1028         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1029         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
1030         the display driver once and pass it to the test runners.
1031         (WebDriverTestRunner.teardown): Stop the display server.
1032         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1033         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
1034         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
1035         (WebDriverTestRunnerSelenium.run): Ditto.
1036         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1037         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
1038         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
1039         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1040         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
1041
1042 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1043
1044         Unreviewed, rolling out r227999.
1045
1046         It didn't fix the problem
1047
1048         Reverted changeset:
1049
1050         "Unreviewed. Try to avoid webdriver tests step timing out in
1051         the bots."
1052         https://trac.webkit.org/changeset/227999
1053
1054 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1055
1056         Start timeout for the run-buildbot-test script is too aggressive
1057         https://bugs.webkit.org/show_bug.cgi?id=182429
1058
1059         Reviewed by Carlos Garcia Campos.
1060
1061         15 seconds is not enough waiting for the update database process
1062         to complete on a system backed with rotational HDDs. Raise it to 60.
1063
1064         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
1065         (wait_for_master_ready):
1066
1067 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1068
1069         re-add ARM JSCOnly bots on buildbot waterfall
1070         https://bugs.webkit.org/show_bug.cgi?id=182428
1071
1072         Reviewed by Csaba Osztrogonác.
1073
1074         * BuildSlaveSupport/build.webkit.org-config/config.json:
1075         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1076
1077 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
1078
1079         Remove ARM JSCOnly bots from buildbot waterfall
1080         https://bugs.webkit.org/show_bug.cgi?id=182398
1081
1082         Reviewed by Alexey Proskuryakov.
1083
1084         * BuildSlaveSupport/build.webkit.org-config/config.json:
1085         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1086
1087 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1088
1089         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
1090
1091         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
1092         workaround for a bug in python2.7 when using multiprocess module.
1093
1094         * Scripts/run-webdriver-tests:
1095
1096 2018-02-01  Youenn Fablet  <youenn@apple.com>
1097
1098         Delay service worker process creation until actually needed by SWServer
1099         https://bugs.webkit.org/show_bug.cgi?id=182301
1100
1101         Reviewed by Chris Dumez.
1102
1103         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1104         (function):
1105
1106 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
1107
1108         Bubbles intermittently disappear from bot watchers dashboard
1109         https://bugs.webkit.org/show_bug.cgi?id=182085
1110
1111         Reviewed by Alexey Proskuryakov.
1112
1113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1114         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
1115         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
1116         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
1117
1118 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1119
1120         [GTK] Problem with Washington Post images
1121         https://bugs.webkit.org/show_bug.cgi?id=181421
1122
1123         Reviewed by Carlos Alberto Lopez Perez.
1124
1125         Add test case for the new user agent quirk.
1126
1127         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1128         (TestWebKitAPI::TEST):
1129
1130 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1131
1132         [GTK] MiniBrowser settings are just a list of names
1133         https://bugs.webkit.org/show_bug.cgi?id=182005
1134
1135         Reviewed by Sergio Villar Senin.
1136
1137         The default size we are using is too small to show the values column, and the window is not resizable because
1138         GObjectClass::constructed() is not called in the parent class.
1139
1140         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1141         (browser_settings_dialog_init): Use 600x400 as default size.
1142         (browserSettingsDialogConstructed): Chain up to parent constructed.
1143
1144 2018-01-31  Andres Gomez  <agomez@igalia.com>
1145
1146         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
1147
1148         * Scripts/webkitpy/common/config/watchlist:
1149
1150 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
1151
1152         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
1153         https://bugs.webkit.org/show_bug.cgi?id=181204
1154         <rdar://problem/36256274>
1155
1156         Reviewed by Ryosuke Niwa.
1157
1158         Implement 'testRunner.forceImmediateCompletion()' for WK1.
1159
1160         * DumpRenderTree/TestRunner.cpp:
1161         (forceImmediateCompletionCallback):
1162         (TestRunner::staticFunctions):
1163
1164 2018-01-31  Alex Christensen  <achristensen@webkit.org>
1165
1166         Unreviewed, rolling out r227942.
1167
1168         r227875 should not have been rolled out.
1169
1170         Reverted changeset:
1171
1172         "Unreviewed, rolling out r227875."
1173         https://bugs.webkit.org/show_bug.cgi?id=182357
1174         https://trac.webkit.org/changeset/227942
1175
1176 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1177
1178         Unreviewed, rolling out r227875.
1179         https://bugs.webkit.org/show_bug.cgi?id=182357
1180
1181         Missing cross-platform TestController implementation
1182
1183         Reverted changeset:
1184
1185         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
1186         https://bugs.webkit.org/show_bug.cgi?id=181958
1187         https://trac.webkit.org/changeset/227875
1188
1189         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1190         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1191         (WTR::InjectedBundle::didReceiveMessageToPage):
1192         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1193         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1194         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1195         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
1196         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1197         * WebKitTestRunner/TestInvocation.cpp:
1198         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
1199         * WebKitTestRunner/TestInvocation.h:
1200         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1201         (WTR::TestController::statisticsUpdateCookiePartitioning):
1202         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1203
1204 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1205
1206         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
1207         https://bugs.webkit.org/show_bug.cgi?id=182222
1208
1209         Reviewed by Alex Christensen.
1210
1211         Use the new API to notify when resource load statistics deletion is complete.
1212
1213         * WebKitTestRunner/TestController.cpp:
1214         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
1215         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1216         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1217
1218 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
1219
1220         Add the support for running StyleBench to run-benchmark
1221         https://bugs.webkit.org/show_bug.cgi?id=182323
1222
1223         Reviewed by Antti Koivisto.
1224
1225         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
1226
1227         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
1228         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
1229
1230 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1231
1232         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
1233         https://bugs.webkit.org/show_bug.cgi?id=182339
1234         <rdar://problem/36041396>
1235
1236         Reviewed by Andy Estes.
1237
1238         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
1239         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
1240         check against the length of the data written.
1241
1242         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1243         (testIconImageData):
1244         (runTestWithTemporaryFolder):
1245         (TestWebKitAPI::TEST):
1246
1247 2018-01-31  Dan Bernstein  <mitz@apple.com>
1248
1249         [macOS] MiniBrowser isn’t app-sandboxed
1250         https://bugs.webkit.org/show_bug.cgi?id=182147
1251
1252         Reviewed by Sam Weinig.
1253
1254         Enable App Sandbox and add a temporary exception allowing read access to all files.
1255
1256         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
1257         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
1258         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
1259           and read access from /.
1260         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
1261
1262 2018-01-31  Philippe Normand  <pnormand@igalia.com>
1263
1264         [JHBuild] Add gstreamer-vaapi in moduleset
1265         https://bugs.webkit.org/show_bug.cgi?id=182283
1266
1267         Reviewed by Carlos Alberto Lopez Perez.
1268
1269         GStreamer-VAAPI is required for hardware-accelerated video
1270         playback support on Intel and AMD (using radeosi driver)
1271         platforms.
1272
1273         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
1274         * gtk/install-dependencies: Install libva.
1275         * wpe/install-dependencies: Ditto.
1276         * Scripts/webkitpy/port/gtk.py:
1277         (GtkPort.setup_environ_for_server): Disable va-api support when
1278         testing because it's incompatible with Mesa's softGL driver.
1279
1280 2018-01-31  Charlie Turner  <cturner@igalia.com>
1281
1282         [WPE] Update jhbuild dependencies
1283         https://bugs.webkit.org/show_bug.cgi?id=182286
1284
1285         This upgrades the following packages,
1286         glib 2.44.1 -> 2.54.3
1287         glib-networking 2.42.0 -> 2.54.1
1288         libsoup 2.48.0 -> 2.60.3
1289
1290         The initial reason for performing these upgrades was that when
1291         visiting https://youtube.com, WPE was getting TLS certificate
1292         errors. After upgrading glib-networking, these were fixed, but the
1293         upgrade introduced dependencies on newer versions of the other
1294         packages upgraded in this commit.
1295
1296         The upgrade to glib caused a linking error in gstreamer, the
1297         following errors were being logged during linking,
1298
1299         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
1300         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
1301         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
1302
1303         This was fixed by adding the glib package built in the jhbuild to
1304         harfbuzz.
1305
1306         Finally, the upgrade of glib caused the glib-warning-fix.patch to
1307         no longer apply, so this patch was removed.
1308
1309         Reviewed by Michael Catanzaro.
1310
1311         * wpe/jhbuild.modules: Added dependecies.
1312         * wpe/patches/glib-warning-fix.patch: Removed.
1313
1314 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1315
1316         Unreviewed, rolling out r227782.
1317
1318         It didn't fix the problem
1319
1320         Reverted changeset:
1321
1322         "Unreviewed. Try to avoid webdriver tests step timing out in
1323         the bots."
1324         https://trac.webkit.org/changeset/227782
1325
1326 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1327
1328         WebDriver: add domains to server config in w3c tests
1329         https://bugs.webkit.org/show_bug.cgi?id=182294
1330
1331         Reviewed by Carlos Alberto Lopez Perez.
1332
1333         Several cookie tests expect server_config to have a domains key.
1334
1335         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
1336                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
1337
1338         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1339         (WebDriverW3CExecutor.__init__):
1340
1341 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1342
1343         Unreviewed. Update W3C WebDriver imported tests.
1344
1345         Show full pytest failure logs.
1346
1347         pytest truncates long lists when printing a failed assertion.
1348         This is not great for debugging and arguably it should be the
1349         default to show the full diff when comparing lists.
1350
1351         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1352         (run):
1353
1354 2018-01-30  John Wilander  <wilander@apple.com>
1355
1356         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
1357         https://bugs.webkit.org/show_bug.cgi?id=181958
1358         https://bugs.webkit.org/show_bug.cgi?id=182072
1359         <rdar://problem/36801804>
1360         <rdar://problem/36845795>
1361
1362         Reviewed by Brent Fulgham.
1363
1364         Because of the asynchronous nature of XPC and cookies,
1365         we need callbacks in these TestRunner functions so that
1366         the layout tests can wait for state changes to finish
1367         before checking test conditions.
1368
1369         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1370         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1371         (WTR::InjectedBundle::didReceiveMessageToPage):
1372         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1373         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1374         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1375         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
1376         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1377         * WebKitTestRunner/TestInvocation.cpp:
1378         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
1379         * WebKitTestRunner/TestInvocation.h:
1380         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1381         (WTR::TestController::statisticsUpdateCookiePartitioning):
1382         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1383
1384 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1385
1386         [webkitpy] Config file for apache is copied twice.
1387         https://bugs.webkit.org/show_bug.cgi?id=182131
1388
1389         Reviewed by Daniel Bates.
1390
1391         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1392         (LayoutTestApacheHttpd.__init__):
1393         (LayoutTestApacheHttpd._copy_apache_config_file):
1394         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
1395
1396 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1397
1398         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1399         https://bugs.webkit.org/show_bug.cgi?id=182312
1400
1401         Reviewed by Michael Catanzaro.
1402
1403         * DumpRenderTree/config.h:
1404         * TestWebKitAPI/config.h:
1405         * WebKitTestRunner/config.h:
1406
1407 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1408
1409         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
1410         https://bugs.webkit.org/show_bug.cgi?id=182307
1411         <rdar://problem/36041485>
1412
1413         Reviewed by Ryosuke Niwa.
1414
1415         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
1416         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
1417         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
1418         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
1419
1420         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
1421         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1422         (TestWebKitAPI::TEST):
1423
1424 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
1425
1426         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
1427         https://bugs.webkit.org/show_bug.cgi?id=182284
1428
1429         Reviewed by Michael Catanzaro.
1430
1431         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
1432         * wpe/manifest.txt.in: Ditto.
1433
1434 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1435
1436         Unreviewed, try to fix JSCOnly build
1437         https://bugs.webkit.org/show_bug.cgi?id=177202
1438
1439         * CMakeLists.txt:
1440
1441 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1442
1443         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
1444
1445         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
1446         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
1447         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
1448         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
1449
1450         * Scripts/run-webdriver-tests:
1451         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1452         (WebDriverTestRunner.dump_results_to_json_file):
1453
1454 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1455
1456         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
1457         https://bugs.webkit.org/show_bug.cgi?id=177202
1458
1459         Reviewed by Alex Christensen.
1460
1461         * CMakeLists.txt:
1462
1463 2018-01-29  Alex Christensen  <achristensen@webkit.org>
1464
1465         Clean up API after bugs 178240 and 176474
1466         https://bugs.webkit.org/show_bug.cgi?id=182259
1467
1468         Reviewed by Dan Bernstein.
1469
1470         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1471         (TEST):
1472         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
1473
1474 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1475
1476         [WebAuthN] Add a compile-time feature flag
1477         https://bugs.webkit.org/show_bug.cgi?id=182211
1478         <rdar://problem/36936365>
1479
1480         Reviewed by Brent Fulgham.
1481
1482         * Scripts/webkitperl/FeatureList.pm:
1483         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1484
1485 2018-01-29  Brady Eidson  <beidson@apple.com>
1486
1487         Make the API test added in r227737 be Mac-only.
1488
1489         Unreviewed gardening.
1490
1491         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
1492
1493 2018-01-29  Matt Lewis  <jlewis3@apple.com>
1494
1495         Unreviewed, rolling out r227731.
1496
1497         This caused and assertion failure in API tests.
1498
1499         Reverted changeset:
1500
1501         "Layout Test fast/events/beforeunload-dom-manipulation-
1502         crash.html is crashing"
1503         https://bugs.webkit.org/show_bug.cgi?id=181204
1504         https://trac.webkit.org/changeset/227731
1505
1506 2018-01-29  Youenn Fablet  <youenn@apple.com>
1507
1508         WPT test exporter should add WebKit export in its PR description
1509         https://bugs.webkit.org/show_bug.cgi?id=182246
1510
1511         Reviewed by Chris Dumez.
1512
1513         Updating PR description body to contain the words 'WebKit export'.
1514         That way, WPT PR bot will mark the PR as reviewed downstream.
1515
1516         * Scripts/webkitpy/w3c/test_exporter.py:
1517         (TestExporter.__init__):
1518         (TestExporter.make_pull_request):
1519         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1520         (TestExporterTest.test_export):
1521
1522 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
1523
1524         Add the support for running Speedometer 2.0 to run-benchmark
1525         https://bugs.webkit.org/show_bug.cgi?id=182231
1526
1527         Reviewed by Antti Koivisto.
1528
1529         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
1530         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
1531         requires aggregating the geometric mean out of total time spent in each suite.
1532
1533         Also added --show-iteration-values to show individual measured values in each iteration.
1534
1535         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1536         (BenchmarkResults.format): Added show_iteration_values as an option.
1537         (BenchmarkResults._format_tests): Ditto.
1538         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
1539         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
1540         is easily parsable as a JSON array.
1541         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
1542         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
1543         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
1544         had exactly one aggregator.
1545         (BenchmarkResults._lint_results):
1546         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
1547         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
1548         parent_aggregator_list.
1549         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
1550         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
1551         (BenchmarkResults._lint_configuration):
1552         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
1553         (test_format_values_with_no_unit_scaling): Added.
1554         (test_format_values_with_iteration_values): Added.
1555         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
1556         (test_aggregate_results_from_another_aggregator): Added.
1557         (test_lint_results): Added a test case.
1558         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1559         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
1560         (BenchmarkRunner._run_benchmark): Ditto.
1561         (BenchmarkRunner.show_results): Ditto.
1562         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
1563         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
1564         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1565         (parse_args): Added --show-iteration-values as a boolean argument.
1566         (run_benchmark_plan): Ditto.
1567         (start): Ditto.
1568         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1569         (WebServerBenchmarkRunner.__init__): Ditto.
1570
1571 2018-01-29  Brady Eidson  <beidson@apple.com>
1572
1573         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
1574         https://bugs.webkit.org/show_bug.cgi?id=182229
1575
1576         Reviewed by Chris Dumez.
1577
1578         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1579         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
1580
1581 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1582
1583         WebDriver: properly recover w3c tests after a webdriver server crash
1584         https://bugs.webkit.org/show_bug.cgi?id=182242
1585
1586         Reviewed by Carlos Alberto Lopez Perez.
1587
1588         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
1589         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
1590         relaunching the server after every test failure, because other failures, even when not crashing the server,
1591         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
1592         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
1593
1594         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1595         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
1596         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1597         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
1598         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
1599         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
1600         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
1601         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
1602
1603 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
1604
1605         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
1606         https://bugs.webkit.org/show_bug.cgi?id=181204
1607         <rdar://problem/36256274>
1608
1609         Reviewed by Ryosuke Niwa.
1610
1611         Implement 'testRunner.forceImmediateCompletion()' for WK1.
1612
1613         * DumpRenderTree/TestRunner.cpp:
1614         (forceImmediateCompletionCallback):
1615         (TestRunner::staticFunctions):
1616
1617 2018-01-29  Frederic Wang  <fwang@igalia.com>
1618
1619         Unreviewed, add myself to some watch lists.
1620
1621         * Scripts/webkitpy/common/config/watchlist:
1622
1623 2018-01-27  Dan Bernstein  <mitz@apple.com>
1624
1625         HaveInternalSDK includes should be "#include?"
1626         https://bugs.webkit.org/show_bug.cgi?id=179670
1627
1628         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1629
1630 2018-01-26  Chris Dumez  <cdumez@apple.com>
1631
1632         Make sure service worker code does not launch a StorageProcess unnecessarily
1633         https://bugs.webkit.org/show_bug.cgi?id=182192
1634         <rdar://problem/36927427>
1635
1636         Reviewed by Geoffrey Garen.
1637
1638         Add API test coverage.
1639
1640         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1641
1642 2018-01-26  Chris Dumez  <cdumez@apple.com>
1643
1644         Offlined content does not work for apps on home screen
1645         https://bugs.webkit.org/show_bug.cgi?id=182070
1646         <rdar://problem/36843906>
1647
1648         Reviewed by Youenn Fablet.
1649
1650         Add API test coverage to make sure an already registered service worker is able to intercept
1651         the very first load.
1652
1653         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1654         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
1655
1656 2018-01-26  Chris Nardi  <cnardi@chromium.org>
1657
1658         Addressing post-review comments after r226614
1659         https://bugs.webkit.org/show_bug.cgi?id=182151
1660
1661         Reviewed by Myles C. Maxfield.
1662
1663         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
1664         (TestWebKitAPI::TEST):
1665
1666 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
1667
1668         Unreviewed, rolling out r224920.
1669
1670         Some Win EWS bots are not coming back up after starting reboot.
1671
1672         * EWSTools/start-queue-win.sh:
1673
1674 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1675
1676         WebDriver: simplify the tests json report
1677         https://bugs.webkit.org/show_bug.cgi?id=182171
1678
1679         Reviewed by Carlos Alberto Lopez Perez.
1680
1681         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
1682         form the subtest name. We should do the same for simplicity and compatibility with WPT.
1683
1684         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1685         (WebDriverTestRunner.dump_results_to_json_file):
1686
1687 2018-01-25  Alex Christensen  <achristensen@webkit.org>
1688
1689         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
1690         https://bugs.webkit.org/show_bug.cgi?id=182152
1691
1692         Reviewed by Joseph Pecoraro.
1693
1694         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1695         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1696         (TEST):
1697
1698 2018-01-25  Youenn Fablet  <youenn@apple.com>
1699
1700         WebPluginInfoProvider should handle null host queries
1701         https://bugs.webkit.org/show_bug.cgi?id=182112
1702
1703         Reviewed by Chris Dumez.
1704
1705         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
1706         (TEST):
1707
1708 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1709
1710         [webkitpy] Stop modifying path information only when running on Cygwin
1711         https://bugs.webkit.org/show_bug.cgi?id=182136
1712
1713         On LayoutTestApacheHttpd, some path configuration is modified when platform
1714         is Windows. This modification is only required for AppleWin running on Cygwin.
1715         WinCairo uses native Windows environment, so the condition should be changed.
1716
1717         Reviewed by Per Arne Vollan.
1718
1719         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1720         (LayoutTestApacheHttpd.__init__):
1721         (LayoutTestApacheHttpd._get_apache_config_file_path):
1722
1723 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
1724
1725         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
1726         https://bugs.webkit.org/show_bug.cgi?id=182038
1727         <rdar://problem/36812083>
1728
1729         Reviewed by Jer Noble.
1730
1731         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1732         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
1733
1734 2018-01-24  Daniel Bates  <dabates@apple.com>
1735
1736         webkit-patch upload emits irrelevant simulator warnings
1737         https://bugs.webkit.org/show_bug.cgi?id=181702
1738         <rdar://problem/36556359>
1739
1740         Reviewed by Aakash Jain.
1741
1742         Remove warning when a person explicitly passes --child-processes with a value greater than
1743         the default number of simulator instances webkitpy would have used had --child-processes
1744         been omitted. Moreover, the placement of the warning logic to support printing such a message
1745         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
1746
1747         By default, webkitpy will parallelize running tests using the maximum number of simulator
1748         instances that can be supported based on available system resources at the time run-webkit-tests
1749         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
1750         by specifying --child-processes knows what they are doing. The effects of picking a large
1751         value be obvious, the system may become sluggish.
1752
1753         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
1754         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
1755
1756         * Scripts/webkitpy/port/ios_simulator.py:
1757         (IOSSimulatorPort.__init__):
1758
1759 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
1760
1761         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
1762         https://bugs.webkit.org/show_bug.cgi?id=182102
1763
1764         Reviewed by Carlos Garcia Campos.
1765
1766         * MiniBrowser/gtk/main.c:
1767         (main): Removed the call to set_enable_webvr().
1768
1769 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1770
1771         WebDriver: add support for slow tests
1772         https://bugs.webkit.org/show_bug.cgi?id=182095
1773
1774         Reviewed by Carlos Alberto Lopez Perez.
1775
1776         Add timeout mark to slow tests.
1777
1778         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1779         (TestExpectationsMarker.__init__): Save the timeout.
1780         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
1781         (run): Pass timeout to TestExpectationsMarker constructor.
1782
1783 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1784
1785         Gracefully recover from NetworkProcess crashes in private browsing
1786         https://bugs.webkit.org/show_bug.cgi?id=182073
1787         <rdar://problem/36572023>
1788
1789         Reviewed by Geoff Garen.
1790
1791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1792         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
1793         (-[CrashDelegate webView:didFinishNavigation:]):
1794         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
1795         (-[CrashDelegate webView:didFailNavigation:withError:]):
1796         (TEST):
1797
1798 2018-01-24  Ali Juma  <ajuma@chromium.org>
1799
1800         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
1801         https://bugs.webkit.org/show_bug.cgi?id=182052
1802
1803         Reviewed by Simon Fraser.
1804
1805         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
1806         immediately.
1807
1808         Test: fast/visual-viewport/viewport-dimensions.html
1809
1810         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1811         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1812
1813 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1814
1815         Remove pre-Sierra-OS-specific code in Tools
1816         https://bugs.webkit.org/show_bug.cgi?id=182034
1817
1818         Reviewed by Tim Horton.
1819
1820         * DumpRenderTree/mac/DumpRenderTree.mm:
1821         (setDefaultsToConsistentValuesForTesting):
1822         * MiniBrowser/mac/BrowserWindowController.m:
1823         (-[BrowserWindowController windowDidLoad]):
1824         (-[BrowserWindowController share:]):
1825         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1826         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
1827         (-[EventStreamPlayer playbackTimerFired:]):
1828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1829         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
1830         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1831         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1832         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1833         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1834         (WTR::InjectedBundle::platformInitialize):
1835         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1836         (WTR::initializeWebViewConfiguration):
1837
1838 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
1839
1840         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
1841         https://bugs.webkit.org/show_bug.cgi?id=181400
1842         <rdar://problem/36358768>
1843
1844         Reviewed by Joseph Pecoraro.
1845
1846         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
1847
1848         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
1849         Always disable poisoning when running with --leaks, as this should work locally,
1850         not just on bots.
1851
1852 2018-01-24  Daniel Bates  <dabates@apple.com>
1853
1854         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
1855         https://bugs.webkit.org/show_bug.cgi?id=181993
1856         <rdar://problem/36421080>
1857
1858         Reviewed by David Hyatt.
1859
1860         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
1861         as we no longer support this strategy.
1862
1863         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
1864
1865 2018-01-24  David Kilzer  <ddkilzer@apple.com>
1866
1867         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
1868         <https://webkit.org/b/182015>
1869         <rdar://problem/36449728>
1870
1871         Reviewed by Tim Horton.
1872
1873         * Scripts/webkitpy/style/checkers/cpp.py:
1874         (regex_for_lambdas_and_blocks): Update regex to include
1875         optional return type for block argument in Objective-C.
1876         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1877         (WebKitStyleTest.test_braces): Add test.
1878
1879 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
1880
1881         WPE-focused test gardening.
1882         https://bugs.webkit.org/show_bug.cgi?id=182051
1883
1884         Unreviewed test gardening.
1885
1886         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
1887
1888 2018-01-23  Mark Lam  <mark.lam@apple.com>
1889
1890         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
1891         https://bugs.webkit.org/show_bug.cgi?id=182017
1892         <rdar://problem/36795513>
1893
1894         Reviewed by Filip Pizlo and JF Bastien.
1895
1896         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1897         (TestWebKitAPI::TEST):
1898         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1899         (TestWebKitAPI::TEST):
1900         (TestWebKitAPI::passWithRef):
1901         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1902         (TestWebKitAPI::TEST):
1903         (TestWebKitAPI::f1):
1904         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1905         (TestWebKitAPI::TEST):
1906         (TestWebKitAPI::poisonedPtrFoo):
1907         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1910         (TestWebKitAPI::TEST):
1911
1912 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
1913
1914         [WebVR] Add OpenVR to the tree and to the build
1915         https://bugs.webkit.org/show_bug.cgi?id=177298
1916
1917         Reviewed by Žan Doberšek.
1918
1919         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
1920         with reduced style checks.
1921
1922 2018-01-24  Chris Nardi  <cnardi@chromium.org>
1923
1924         Add Chris Nardi to contributors list
1925         https://bugs.webkit.org/show_bug.cgi?id=182029
1926
1927         Reviewed by Antti Koivisto.
1928
1929         * Scripts/webkitpy/common/config/contributors.json:
1930
1931 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1932
1933         Mac Sierra perf bots have been failing due to CG errors
1934         https://bugs.webkit.org/show_bug.cgi?id=181955
1935
1936         Reviewed by Antti Koivisto.
1937
1938         Ignore the CoreGraphics error messages on macOS Sierra.
1939
1940         Also added tests for ignoring lines in stdout and stderr.
1941
1942         * Scripts/webkitpy/performance_tests/perftest.py:
1943         (PerfTest.run_failed): Refactored for clarity.
1944         (PerfTest):
1945         (PerfTest.filter_ignored_lines): Added.
1946         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
1947         are now used to ignore lines in other kinds of tests than parser tests.
1948         (PerfTest._errors_to_ignore_in_sierra): Added.
1949         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
1950         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1951         (test_parse_output_with_ignored_stdout): Added.
1952         (test_parse_output_with_ignored_stderr): Added.
1953         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
1954
1955 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
1956
1957         Resign NowPlaying status when no media element is eligible
1958         https://bugs.webkit.org/show_bug.cgi?id=181914
1959         <rdar://problem/35294116>
1960
1961         Reviewed by Jer Noble.
1962
1963         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1964         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1965         (TestWebKitAPI::TEST):
1966         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1967
1968 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1969
1970         [WinCairo] Use 64-bit toolset
1971         https://bugs.webkit.org/show_bug.cgi?id=181979
1972
1973         Reviewed by Alex Christensen.
1974
1975         Use 64-bit toolset for 64-bit build in order to improve build time. 
1976
1977         * Scripts/webkitdirs.pm:
1978         (generateBuildSystemFromCMakeProject):
1979
1980 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
1981
1982         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
1983         https://bugs.webkit.org/show_bug.cgi?id=181741
1984         rdar://problem/36593581
1985
1986         Reviewed by Tim Horton.
1987         
1988         If zoomToScale:animated: is called with the current zoom level, call the callback
1989         rather than doing nothing.
1990
1991         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1992         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1993
1994 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1995
1996         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
1997         https://bugs.webkit.org/show_bug.cgi?id=180820
1998
1999         Reviewed by David Kilzer.
2000
2001         * Scripts/webkitpy/common/checkout/scm/git.py:
2002         (Git.in_working_directory):
2003         (Git.clone):
2004         (Git.read_git_config):
2005         (Git.apply_reverse_diff):
2006         * Scripts/webkitpy/common/checkout/scm/scm.py:
2007         (SCM.run):
2008         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2009         * Scripts/webkitpy/common/checkout/scm/svn.py:
2010         (SVNRepository.has_authorization_for_realm):
2011         * Scripts/webkitpy/common/net/credentials_unittest.py:
2012         * Scripts/webkitpy/common/system/abstractexecutive.py:
2013         (AbstractExecutive.run_command):
2014         * Scripts/webkitpy/common/system/executive.py:
2015         (Executive.kill_process.is):
2016         (Executive.running_pids):
2017         (Executive.kill_all):
2018         (Executive.run_command):
2019         * Scripts/webkitpy/common/system/executive_mock.py:
2020         (MockExecutive.run_command):
2021         (MockExecutive2.run_command):
2022         * Scripts/webkitpy/common/system/executive_unittest.py:
2023         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
2024         * Scripts/webkitpy/common/system/platforminfo.py:
2025         (PlatformInfo.xcode_sdk_version):
2026         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2027         (Lighttpd._check_and_kill):
2028         * Scripts/webkitpy/port/base.py:
2029         (Port._symbols_string):
2030         * Scripts/webkitpy/port/gtk.py:
2031         (GtkPort.setup_environ_for_server):
2032         * Scripts/webkitpy/port/win.py:
2033         (WinPort._runtime_feature_list):
2034         (WinPort.read_registry_value):
2035         * Scripts/webkitpy/port/win_unittest.py:
2036         (WinPortTest.test_runtime_feature_list):
2037         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2038         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
2039
2040 2018-01-23  Commit Queue  <commit-queue@webkit.org>
2041
2042         Unreviewed, rolling out r227279 and r227373.
2043         https://bugs.webkit.org/show_bug.cgi?id=181988
2044
2045         The LayoutTest crash fix introduced an API test failure.
2046         (Requested by ryanhaddad on #webkit).
2047
2048         Reverted changesets:
2049
2050         "Resign NowPlaying status when no media element is eligible"
2051         https://bugs.webkit.org/show_bug.cgi?id=181914
2052         https://trac.webkit.org/changeset/227279
2053
2054         "Resign NowPlaying status when no media element is eligible"
2055         https://bugs.webkit.org/show_bug.cgi?id=181914
2056         https://trac.webkit.org/changeset/227373
2057
2058 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2059
2060         Unreviewed. Add test case for slow in test_expectations.py.
2061
2062         I forgot to also check slow tests in test_expectations.py unit tests.
2063
2064         * Scripts/webkitpy/common/test_expectations_unittest.py:
2065         (assert_slow):
2066         (test_build_type):
2067         (test_slow):
2068
2069 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2070
2071         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
2072
2073         * TestWebKitAPI/glib/TestExpectations.json:
2074
2075 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2076
2077         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
2078         https://bugs.webkit.org/show_bug.cgi?id=181616
2079         <rdar://problem/36484908>
2080
2081         Reviewed by Wenson Hsieh.
2082
2083         Added tests to make sure we sanitize plain HTML, not just web archives,
2084         when and only when custom pasteboard data is enabled.
2085
2086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2087         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
2088         (writeHTMLToPasteboard): Added.
2089         (createWebViewWithCustomPasteboardDataSetting): Added.
2090
2091 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
2092
2093         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
2094         https://bugs.webkit.org/show_bug.cgi?id=181400
2095         rdar://problem/36358768
2096
2097         Reviewed by JF Bastien.
2098
2099         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
2100
2101 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2102
2103         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
2104         https://bugs.webkit.org/show_bug.cgi?id=181929
2105
2106         Reviewed by Michael Catanzaro.
2107
2108         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
2109         the website data completion callback is not called immediately, and a new file is created when the operation
2110         finishes. We need to check that the file was removing after calling clear.
2111
2112         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2113         (fileChangedCallback):
2114         (testWebsiteDataResourceLoadStatistics):
2115
2116 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2117
2118         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
2119
2120         * TestWebKitAPI/glib/TestExpectations.json:
2121
2122 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2123
2124         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
2125
2126         Partially revert r226782, the fix was wrong for the GLib version we currently use.
2127
2128         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2129         (testWebKitConsoleMessageNetworkError):
2130
2131 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2132
2133         Unreviewed. Remove unused verbose mode from GLib API tests runner.
2134
2135         * glib/api_test_runner.py:
2136         (add_options):
2137
2138 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2139
2140         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
2141         https://bugs.webkit.org/show_bug.cgi?id=181918
2142
2143         Reviewed by Tim Horton.
2144
2145         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
2146
2147         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2148
2149 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
2150
2151         Resign NowPlaying status when no media element is eligible
2152         https://bugs.webkit.org/show_bug.cgi?id=181914
2153         <rdar://problem/35294116>
2154
2155         Reviewed by Jer Noble.
2156
2157         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2158         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
2159         (TestWebKitAPI::TEST):
2160         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
2161
2162 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
2163
2164         Fix broken unit-tests after r227192
2165         https://bugs.webkit.org/show_bug.cgi?id=181909
2166
2167         Reviewed by Carlos Garcia Campos.
2168
2169         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2170
2171 2018-01-20  Chris Dumez  <cdumez@apple.com>
2172
2173         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
2174         https://bugs.webkit.org/show_bug.cgi?id=174984
2175         <rdar://problem/33665676>
2176
2177         Reviewed by Alexey Proskuryakov.
2178
2179         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
2180
2181         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2182         (TEST):
2183
2184 2018-01-20  Brian Burg  <bburg@apple.com>
2185
2186         WebDriver: fix some nits that prevent running W3C tests on Mac
2187         https://bugs.webkit.org/show_bug.cgi?id=181864
2188
2189         Reviewed by Carlos Garcia Campos.
2190
2191         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2192         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
2193         as we assume that the property exists later.
2194
2195         (WebDriverW3CWebServer.stop): If the temporary file doesn't
2196         exist for some reason, the remove call will raise and exception.
2197         Gracefully handle the case where the file isn't created due to
2198         a problem/exception that happened elsewhere.
2199
2200 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
2201
2202         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
2203         https://bugs.webkit.org/show_bug.cgi?id=181881
2204
2205         Reviewed by Alexey Proskuryakov.
2206
2207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2208         (BubbleQueueServer):
2209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2211         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
2212
2213 2018-01-19  Youenn Fablet  <youenn@apple.com>
2214
2215         Do not go to the storage process when registering a service worker client if there is no service worker registered
2216         https://bugs.webkit.org/show_bug.cgi?id=181740
2217         <rdar://problem/36650400>
2218
2219         Reviewed by Chris Dumez.
2220
2221         Add support for internals inside API tests.
2222
2223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2224         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
2225         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
2226         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
2227         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
2228         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
2229         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2230         (setConfigurationInjectedBundlePath):
2231         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
2232
2233 2018-01-19  John Wilander  <wilander@apple.com>
2234
2235         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
2236         https://bugs.webkit.org/show_bug.cgi?id=181822
2237         https://bugs.webkit.org/show_bug.cgi?id=175263
2238         https://bugs.webkit.org/show_bug.cgi?id=178536
2239         https://bugs.webkit.org/show_bug.cgi?id=181223
2240         https://bugs.webkit.org/show_bug.cgi?id=181482
2241         <rdar://problem/33491222>
2242         <rdar://problem/33805293>
2243         <rdar://problem/36332683>
2244         <rdar://problem/36549026>
2245
2246         Reviewed by Alex Christensen.
2247
2248         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2249         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2250         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2251         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2252         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2253         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2254         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2255         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2256
2257 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
2258
2259         run-webkit-tests fails when there is a curly brace in Xcode build output
2260         https://bugs.webkit.org/show_bug.cgi?id=181254
2261         <rdar://problem/36453374>
2262
2263         Reviewed by Daniel Bates.
2264
2265         * Scripts/webkitpy/port/base.py:
2266         (Port._run_script): Encode script output before logging it.
2267
2268 2018-01-19  Chris Dumez  <cdumez@apple.com>
2269
2270         Service worker registrations restored from disk may not be reused when the JS calls register() again
2271         https://bugs.webkit.org/show_bug.cgi?id=181810
2272         <rdar://problem/36591711>
2273
2274         Reviewed by Youenn Fablet.
2275
2276         Add API test coverage.
2277
2278         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2279         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
2280         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
2281
2282 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
2283
2284         Remove El Capitan queues from flakiness dashboard
2285         https://bugs.webkit.org/show_bug.cgi?id=181860
2286
2287         Reviewed by Aakash Jain.
2288
2289         * TestResultServer/static-dashboards/builders.jsonp:
2290
2291 2018-01-19  Keith Miller  <keith_miller@apple.com>
2292
2293         HaveInternalSDK includes should be "#include?"
2294         https://bugs.webkit.org/show_bug.cgi?id=179670
2295
2296         Reviewed by Dan Bernstein.
2297
2298         * MiniBrowser/Configurations/Base.xcconfig:
2299         * MobileMiniBrowser/Configurations/Base.xcconfig:
2300         * TestWebKitAPI/Configurations/Base.xcconfig:
2301         * WebKitTestRunner/Configurations/Base.xcconfig:
2302
2303 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2304
2305         WebDriver: driver environment not passed to pytest when running w3c tests
2306         https://bugs.webkit.org/show_bug.cgi?id=181852
2307
2308         Reviewed by Carlos Alberto Lopez Perez.
2309
2310         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
2311
2312         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2313         (WebDriverW3CExecutor.run):
2314
2315 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2316
2317         [GTK] WebDriver: wayland display no used in wayland bot
2318         https://bugs.webkit.org/show_bug.cgi?id=181851
2319
2320         Reviewed by Carlos Alberto Lopez Perez.
2321
2322         We need to handle the additionalArguments property in the WebDriverTests step.
2323
2324         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2325         (RunWebDriverTests.start):
2326
2327 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2328
2329         [GTK] TERM environment variable is not passed to the test driver.
2330         https://bugs.webkit.org/show_bug.cgi?id=181847
2331
2332         Rubber-stamped by by Carlos Garcia Campos.
2333
2334         * Scripts/webkitpy/port/base.py:
2335         (Port.to.setup_environ_for_server):
2336
2337 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2338
2339         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
2340         https://bugs.webkit.org/show_bug.cgi?id=181844
2341
2342         Reviewed by Carlos Alberto Lopez Perez.
2343
2344         We always try to create the directory where to store the json file, but when the filename is given directly,
2345         like in the bots, the current dir is used.
2346
2347         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2348         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
2349         empty string.
2350
2351 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2352
2353         [GTK] WebDriver tests are running outside the jhbuild env
2354         https://bugs.webkit.org/show_bug.cgi?id=181842
2355
2356         Reviewed by Žan Doberšek.
2357
2358         We need to enter jhbuild env in run-webdriver-tests.
2359
2360         * Scripts/run-webdriver-tests:
2361
2362 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2363
2364         [GTK] Run WebDriver tests in the bots
2365         https://bugs.webkit.org/show_bug.cgi?id=181787
2366
2367         Reviewed by Michael Catanzaro.
2368
2369         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
2370         factory for the GTK port for now.
2371
2372         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2373         (TestFactory.__init__):
2374         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2375         (RunWebDriverTests):
2376         (RunWebDriverTests.start):
2377         (RunWebDriverTests.commandComplete):
2378         (RunWebDriverTests.evaluateCommand):
2379         (RunWebDriverTests.getText):
2380         (RunWebDriverTests.getText2):
2381
2382 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2383
2384         [WinCairo] Pass correct url for http test to test driver.
2385         https://bugs.webkit.org/show_bug.cgi?id=181814
2386
2387         Reviewed by Alex Christensen.
2388
2389         * Scripts/webkitpy/port/driver.py:
2390         (Driver):
2391         (Driver.http_test_path_to_uri):
2392         (Driver.is_secure_path):
2393         (Driver.http_base_url):
2394         (Driver.uri_to_test):
2395
2396 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2397
2398         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
2399
2400         * BuildSlaveSupport/build.webkit.org-config/config.json:
2401
2402 2018-01-18  Dan Bernstein  <mitz@apple.com>
2403
2404         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
2405         https://bugs.webkit.org/show_bug.cgi?id=181803
2406
2407         Reviewed by Tim Horton.
2408
2409         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
2410         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
2411         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
2412         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
2413         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
2414         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2415         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2416         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2417         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
2418           helpers.
2419         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
2420           settings useful for defining settings that depend on the target macOS version.
2421         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
2422         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
2423
2424 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
2425
2426         Remove Opensource El Capitan queues from buildbot
2427         https://bugs.webkit.org/show_bug.cgi?id=181712
2428
2429         Reviewed by Aakash Jain.
2430
2431         * BuildSlaveSupport/build.webkit.org-config/config.json:
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2433         (WebKitBuildbot):
2434         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2435
2436 2018-01-18  Chris Dumez  <cdumez@apple.com>
2437
2438         Service Workers restored from persistent storage have 'redundant' state
2439         https://bugs.webkit.org/show_bug.cgi?id=181749
2440         <rdar://problem/36556486>
2441
2442         Reviewed by Youenn Fablet.
2443
2444         Add API test coverage.
2445
2446         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2447         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
2448
2449 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2450
2451         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
2452         https://bugs.webkit.org/show_bug.cgi?id=176796
2453
2454         Reviewed by Chris Fleizach.
2455
2456         Add sanity check that we have a URL before calling g_strstr_len().
2457
2458         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2459         (WTR::AccessibilityUIElement::url):
2460
2461 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2462
2463         Add triggers for Sierra test262 and perf queues
2464         https://bugs.webkit.org/show_bug.cgi?id=181799
2465
2466         Reviewed by Aakash Jain.
2467
2468         * BuildSlaveSupport/build.webkit.org-config/config.json:
2469
2470 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2471
2472         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
2473         https://bugs.webkit.org/show_bug.cgi?id=181783
2474         <rdar://problem/35785445>
2475
2476         Reviewed by Ryosuke Niwa.
2477
2478         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
2479         copying an image contains a relevant title.
2480
2481         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2482         (TestWebKitAPI::TEST):
2483         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2484         * TestWebKitAPI/ios/UIKitSPI.h:
2485
2486 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2487
2488         WebDriver: ignore the driver in selenium test names when getting expectations
2489         https://bugs.webkit.org/show_bug.cgi?id=181738
2490
2491         Reviewed by Carlos Alberto Lopez Perez.
2492
2493         In selenium tests, the driver is added as a parameter to every test which results in tests names like
2494         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
2495         driver name in the test expectations file, so we need to remove it when querying the expectations.
2496
2497         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2498         (TestExpectationsMarker.__init__): Save the param to ignore.
2499         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
2500         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
2501         (run): Pass param to ignore to TestExpectationsMarker().
2502         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2503         (WebDriverSeleniumExecutor.__init__): Save the driver name.
2504         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
2505
2506 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2507
2508         [GTK][WPE] Show unit tests unexpectedly passing in the bots
2509         https://bugs.webkit.org/show_bug.cgi?id=181726
2510
2511         Reviewed by Michael Catanzaro.
2512
2513         Now that we have the info, let's show it also in the bots.
2514
2515         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2516         (RunGLibAPITests.commandComplete):
2517
2518 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
2519
2520         Fix broken unittest after r227048
2521         https://bugs.webkit.org/show_bug.cgi?id=181760
2522
2523         Reviewed by Aakash Jain.
2524
2525
2526 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2527
2528         WEBKIT_FRAMEWORK should not modify file-global include directories
2529         https://bugs.webkit.org/show_bug.cgi?id=181656
2530
2531         Reviewed by Konstantin Tokarev.
2532
2533         * TestWebKitAPI/PlatformWPE.cmake:
2534         * TestWebKitAPI/glib/CMakeLists.txt:
2535
2536 2018-01-17  Alicia Boya García  <aboya@igalia.com>
2537
2538         Unreviewed, mark Alicia as committer in contributors.json
2539
2540         * Scripts/webkitpy/common/config/contributors.json:
2541
2542 2018-01-17  Youenn Fablet  <youenn@apple.com>
2543
2544         Put fetch Request.keepalive behind a runtime flag
2545         https://bugs.webkit.org/show_bug.cgi?id=181592
2546
2547         Reviewed by Chris Dumez.
2548
2549         * DumpRenderTree/mac/DumpRenderTree.mm:
2550         (enableExperimentalFeatures):
2551         * DumpRenderTree/win/DumpRenderTree.cpp:
2552         (enableExperimentalFeatures):
2553         * WebKitTestRunner/TestController.cpp:
2554         (WTR::TestController::resetPreferencesToConsistentValues):
2555
2556 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2557
2558         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2559         https://bugs.webkit.org/show_bug.cgi?id=181637
2560         <rdar://problem/36508471>
2561
2562         Reviewed by Tim Horton.
2563
2564         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
2565         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
2566
2567         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2568         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2569         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
2570
2571         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
2572         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
2573
2574         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2575         (webViewForTestingAttachments):
2576         (-[TestWKWebView tagsInBody]):
2577         (-[TestWKWebView expectElementTagsInOrder:]):
2578         (-[TestWKWebView expectElementTag:toComeBefore:]):
2579
2580         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
2581         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
2582
2583         (TestWebKitAPI::TEST):
2584         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2585         (WTR::InjectedBundlePage::InjectedBundlePage):
2586
2587 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2588
2589         WebDriver: add support for test expectations
2590         https://bugs.webkit.org/show_bug.cgi?id=180420
2591
2592         Reviewed by Carlos Alberto Lopez Perez.
2593
2594         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
2595
2596         * Scripts/run-webdriver-tests: Get the retval from process_results().
2597         * Scripts/webkitpy/thirdparty/__init__.py:
2598         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
2599         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2600         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
2601         (TestExpectationsMarker.__init__): Initialize expectations.
2602         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
2603         (run): Create and use TestExpectationsMarker plugin.
2604         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2605         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
2606         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2607         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
2608         (WebDriverTestRunner.run): Do not count results here.
2609         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
2610         amount of failures. Printing the test summary while processing results will be made optional in a follow up
2611         patch.
2612         (WebDriverTestRunner.process_results.report): Return the amount of failures.
2613         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2614         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
2615         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
2616         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
2617         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2618         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
2619         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
2620         (WebDriverTestRunnerW3C._scan_directory): Ditto.
2621         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
2622         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2623         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
2624
2625 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2626
2627         Unreviewed WPE gardening. Mark some known unit test failures.
2628
2629         * TestWebKitAPI/glib/TestExpectations.json:
2630
2631 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2632
2633         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
2634         https://bugs.webkit.org/show_bug.cgi?id=181724
2635
2636         Reviewed by Philippe Normand.
2637
2638         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
2639         reason to use different names. This way we can refer to the same test names for both and we can share the
2640         expectations in the TestExpectations.json file.
2641
2642         * TestWebKitAPI/glib/TestExpectations.json:
2643         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
2644
2645 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2646
2647         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
2648
2649         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
2650         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
2651
2652         * glib/api_test_runner.py:
2653         (TestRunner._run_test_glib):
2654         (TestRunner._run_google_test):
2655
2656 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2657
2658         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
2659         https://bugs.webkit.org/show_bug.cgi?id=179914
2660
2661         Reviewed by Žan Doberšek.
2662
2663         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
2664         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
2665         all symbols listed in the script are present in the library.
2666
2667         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
2668         (bss_symbols):
2669         * Scripts/check-for-invalid-symbols-in-version-script: Added.
2670         (script_symbols):
2671         * Scripts/make-dist:
2672         (Distcheck.build):
2673         (Distcheck):
2674         (Distcheck.check_symbols):
2675         (Distcheck.check):
2676
2677 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2678
2679         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
2680         https://bugs.webkit.org/show_bug.cgi?id=181722
2681
2682         Reviewed by Žan Doberšek.
2683
2684         I forgot to pass the parameters to run() when restarting.
2685
2686         * glib/glib_test_runner.py:
2687         (GLibTestRunner.run):
2688
2689 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
2690
2691         [CMake] Remove WebCoreDerivedSources library target
2692         https://bugs.webkit.org/show_bug.cgi?id=181664
2693
2694         Reviewed by Carlos Garcia Campos.
2695
2696         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
2697         * TestWebKitAPI/PlatformWin.cmake: Ditto.
2698
2699 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
2700
2701         Move Debug Test262, Release Test262 and Performance queues to Sierra
2702         https://bugs.webkit.org/show_bug.cgi?id=181692
2703
2704         Unreviewed
2705
2706 2018-01-16  Zach Li  <zachli@apple.com>
2707
2708         Add pop-up policy support in website policies.
2709         https://bugs.webkit.org/show_bug.cgi?id=181544.
2710         rdar://problem/30521400.
2711
2712         Reviewed by Alex Christensen.
2713
2714         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2715         Added pop-up-check.html.
2716
2717         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
2718
2719         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2720         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2721         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2722         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2723         (TEST):
2724
2725 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2726
2727         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
2728         https://bugs.webkit.org/show_bug.cgi?id=181638
2729         <rdar://problem/36508702>
2730
2731         Reviewed by Dan Bernstein.
2732
2733         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
2734         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
2735
2736         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2737         (-[AttachmentUpdateObserver init]):
2738         (-[AttachmentUpdateObserver sourceForIdentifier:]):
2739         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
2740         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
2741         (TestWebKitAPI::TEST):
2742         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
2743
2744 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2745
2746         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
2747
2748         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
2749
2750         * glib/api_test_runner.py:
2751         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
2752         * glib/glib_test_runner.py:
2753         (GLibTestRunner.run): Use given env.
2754
2755 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2756
2757         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
2758         https://bugs.webkit.org/show_bug.cgi?id=181676
2759
2760         Reviewed by Carlos Alberto Lopez Perez.
2761
2762         The option was removed in r226967.
2763
2764         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2765         (RunGtkAPITests):
2766         (RunWPEAPITests):
2767
2768 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2769
2770         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
2771
2772         The bots are still passing that option and the step is failing because it was removed in r226967.
2773
2774         * glib/api_test_runner.py:
2775         (add_options):
2776
2777 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2778
2779         [GTK][WPE] Improve the way glib tests are run
2780         https://bugs.webkit.org/show_bug.cgi?id=181674
2781
2782         Reviewed by Žan Doberšek.
2783
2784         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
2785         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
2786         tests failing due to an expected assert in the test and unexpected crashes.
2787         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
2788         not showing the subtest name in stdout in case of timeouts.
2789         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
2790         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
2791         of every test case.
2792
2793         * glib/api_test_runner.py:
2794         (TestRunner._run_test_glib): Use GLibTestRunner.
2795         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
2796         (add_options):
2797         * glib/glib_test_runner.py: Added.
2798         (TestTimeout):
2799         (Message):
2800         (Message.__init__):
2801         (Message.create):
2802         (Message.create.read_unsigned):
2803         (Message.create.read_double):
2804         (Message.create.read_string):
2805         (GLibTestRunner):
2806         (GLibTestRunner.__init__):
2807         (GLibTestRunner._process_data):
2808         (GLibTestRunner._process_message):
2809         (GLibTestRunner._read_from_pipe):
2810         (GLibTestRunner._read_from_stderr):
2811         (GLibTestRunner._start_timeout):
2812         (GLibTestRunner._start_timeout._alarm_handler):
2813         (GLibTestRunner._stop_timeout):
2814         (GLibTestRunner._subtest_start):
2815         (GLibTestRunner._subtest_message):
2816         (GLibTestRunner._subtest_stderr):
2817         (GLibTestRunner._subtest_end):
2818         (GLibTestRunner.run):
2819
2820 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2821
2822         Unreviewed, add Thibault to contributors.json
2823
2824         It's a bit weird to add someone here before their first contribution, but this affects
2825         Bugzilla autocomplete, and that is serious business.
2826
2827         * Scripts/webkitpy/common/config/contributors.json:
2828
2829 2018-01-15  JF Bastien  <jfbastien@apple.com>
2830
2831         Remove makePoisonedUnique
2832         https://bugs.webkit.org/show_bug.cgi?id=181630
2833         <rdar://problem/36498623>
2834
2835         Reviewed by Mark Lam.
2836
2837         Update tests.
2838
2839         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2840         (TestWebKitAPI::TEST):
2841         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2842         (TestWebKitAPI::TEST):
2843
2844 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
2845
2846         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
2847         https://bugs.webkit.org/show_bug.cgi?id=181476
2848
2849         Reviewed by Michael Catanzaro.
2850
2851         Update to xorg-server 1.19.6 which depends on libxfont2, and change
2852         the lists of packages to install libxfont2-devel (or equivalent).
2853
2854         * gtk/install-dependencies:
2855         * gtk/jhbuild.modules:
2856
2857 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2858
2859         [GTK][WPE] Add support for unit test expectations
2860         https://bugs.webkit.org/show_bug.cgi?id=181589
2861
2862         Reviewed by Michael Catanzaro.
2863
2864         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
2865         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
2866         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
2867         script itself is not a good idea either.
2868
2869         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
2870         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
2871         convenient methods to query them.
2872
2873         * Scripts/run-gtk-tests:
2874         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
2875         * Scripts/run-wpe-tests:
2876         (WPETestRunner): Ditto.
2877         * Scripts/webkitpy/common/test_expectations.py: Added.
2878         (TestExpectations):
2879         (TestExpectations.__init__):
2880         (TestExpectations._port_name_for_expected):
2881         (TestExpectations._expected_value):
2882         (TestExpectations.skipped_tests):
2883         (TestExpectations.skipped_subtests):
2884         (TestExpectations._expectation_value):
2885         (TestExpectations.is_slow):
2886         (TestExpectations.get_expectation):
2887         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
2888         (MockTestExpectations):
2889         (MockTestExpectations.__init__):
2890         (MockTestExpectations.is_skip):
2891         (ExpectationsTest):
2892         (assert_exp):
2893         (assert_not_exp):
2894         (assert_bad_exp):
2895         (assert_skip):
2896         (test_basic):
2897         (test_skip):
2898         (test_flaky):
2899         (test_build_type):
2900         * TestWebKitAPI/glib/TestExpectations.json: Added.
2901         * glib/api_test_runner.py:
2902         (TestRunner): Remove SkippedTest implementation.
2903         (TestRunner.__init__): Create a TestExpectations.
2904         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
2905         (TestRunner._should_run_test_program): Ditto.
2906         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
2907         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
2908         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
2909         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
2910         (TestRunner.run_tests.report): Helper to write report to stdout.
2911
2912 2018-01-13  Mark Lam  <mark.lam@apple.com>
2913
2914         Replace all use of ConstExprPoisoned with Poisoned.
2915         https://bugs.webkit.org/show_bug.cgi?id=181542
2916         <rdar://problem/36442138>
2917
2918         Reviewed by JF Bastien.
2919
2920         1. Converted tests to using new uintptr_t& poison type.
2921         2. Added tests for Poisoned comparison operators.
2922
2923         * TestWebKitAPI/CMakeLists.txt:
2924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2925         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
2926         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2927         (TestWebKitAPI::TEST):
2928         (TestWebKitAPI::initializeTestPoison): Deleted.
2929         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2930         (TestWebKitAPI::TEST):
2931         (TestWebKitAPI::passWithRef):
2932         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2933         (TestWebKitAPI::TEST):
2934         (TestWebKitAPI::f1):
2935         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2936         (TestWebKitAPI::TEST):
2937         (TestWebKitAPI::poisonedPtrFoo):
2938         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2939         (TestWebKitAPI::TEST):
2940         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2941         (TestWebKitAPI::TEST):
2942
2943 2018-01-13  David Kilzer  <ddkilzer@apple.com>
2944
2945         check-webkit-style: false positive for [whitespace/braces] with os_log format string
2946         <https://webkit.org/b/181606>
2947
2948         Reviewed by Darin Adler.
2949
2950         * Scripts/webkitpy/style/checkers/cpp.py:
2951         (check_spacing): Modify regular expression to ignore
2952         os_log format strings like '%{public}'.
2953         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2954         (CppStyleTest.test_spacing_before_braces): Add os_log
2955         format string test.
2956
2957 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2958
2959         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
2960         https://bugs.webkit.org/show_bug.cgi?id=181626
2961
2962         Reviewed by Joseph Pecoraro.
2963
2964         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
2965         Additionally, write a new API test covering the change in r226915.
2966
2967         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2968         (webViewForTestingAttachments):
2969         (TestWebKitAPI::TEST):
2970
2971 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2972
2973         History state should be updated during client redirects with asynchronous policy decisions
2974         https://bugs.webkit.org/show_bug.cgi?id=181358
2975         <rdar://problem/35547689>
2976
2977         Reviewed by Andy Estes.
2978
2979         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2980         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
2981         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2982         (TEST):
2983
2984 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
2985
2986         webkitpy: Refactor simulator code (Part 4)
2987         https://bugs.webkit.org/show_bug.cgi?id=180555
2988         <rdar://problem/36131381>
2989
2990         Reviewed by Aakash Jain.
2991
2992         Move new_simulated_device.py to simulated_device.py.
2993
2994         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
2995         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
2996         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
2997         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
2998         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
2999
3000 2018-01-12  Alex Christensen  <achristensen@webkit.org>
3001
3002         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
3003         https://bugs.webkit.org/show_bug.cgi?id=181595
3004
3005         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
3006         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
3007         I change the < and > to $ to make this test pass and continue to test what it used to.
3008
3009         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
3010         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3011         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3012
3013 2018-01-11  Keith Miller  <keith_miller@apple.com>
3014
3015         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
3016         https://bugs.webkit.org/show_bug.cgi?id=181573
3017
3018         Reviewed by Simon Fraser.
3019
3020         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3021
3022 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
3023
3024         [WebAuthN] Import a CBOR coder from Chromium
3025         https://bugs.webkit.org/show_bug.cgi?id=181522
3026         <rdar://problem/36055729>
3027
3028         Reviewed by Brent Fulgham.
3029
3030         This patch also imports all unit tests into our API tests to ensure all
3031         workarounds and modification against the original codebase doesn't change
3032         any original functionalities.
3033
3034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3035         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
3036         (TestWebKitAPI::TEST):
3037         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
3038         (TestWebKitAPI::TEST):
3039         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
3040         (TestWebKitAPI::eq):
3041         Workarounds applied.
3042         (TestWebKitAPI::TEST):
3043
3044 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3045
3046         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
3047         https://bugs.webkit.org/show_bug.cgi?id=181538
3048         <rdar://problem/36440580>
3049
3050         Reviewed by Aakash Jain.
3051
3052         When disambiguating a device type, it is possible that the provided device type is sufficiently
3053         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
3054         will result in a failure to disambiguate the type.
3055
3056         * Scripts/webkitpy/xcode/new_simulated_device.py:
3057         (SimulatedDeviceManager._disambiguate_device_type):
3058
3059 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
3060
3061         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
3062         https://bugs.webkit.org/show_bug.cgi?id=181136
3063         <rdar://problem/36116604>
3064
3065         Reviewed by Chris Dumez.
3066
3067         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
3068         browsing sessions.
3069
3070         * Scripts/run-gtk-tests:
3071         (GtkTestRunner): Unskip test now that it passes.
3072         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3073         (TEST): Add new WebsiteDataStoreEphemeral test.
3074
3075 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3076
3077         Unreviewed, rolling out r226816.
3078
3079         This change broke LayoutTests on the bots.
3080
3081         Reverted changeset:
3082
3083         "run-webkit-tests fails when there is a curly brace in Xcode
3084         build output"
3085         https://bugs.webkit.org/show_bug.cgi?id=181254
3086         https://trac.webkit.org/changeset/226816
3087
3088 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3089
3090         webkitpy: Fix flakey webserver tests
3091         https://bugs.webkit.org/show_bug.cgi?id=181555
3092         <rdar://problem/36448273>
3093
3094         Reviewed by Aakash Jain.
3095
3096         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3097         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
3098         determine if a specific server is running.
3099
3100 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3101
3102         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
3103         https://bugs.webkit.org/show_bug.cgi?id=181561
3104         <rdar://problem/36452652>
3105
3106         Reviewed by Aakash Jain.
3107
3108         BeautifulSoup.find may return None, this case should be gracefully handled.
3109
3110         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3111         (BugzillaQueries._parse_result_count):
3112         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
3113
3114 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
3115
3116         run-webkit-tests fails when there is a curly brace in Xcode build output
3117         https://bugs.webkit.org/show_bug.cgi?id=181254
3118
3119         Reviewed by Daniel Bates.
3120
3121         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3122         (MeteredStream.write):
3123
3124 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3125
3126         webkitpy: Reimplement simulator code (Part 3)
3127         https://bugs.webkit.org/show_bug.cgi?id=180555
3128         <rdar://problem/36131381>
3129
3130         Reviewed by Aakash Jain.
3131
3132         Remove old simulator code.
3133
3134         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
3135         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
3136         * Scripts/webkitpy/xcode/simulator.py: Removed.
3137         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
3138
3139 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3140
3141         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
3142         https://bugs.webkit.org/show_bug.cgi?id=181337
3143         <rdar://problem/36324813>
3144
3145         Reviewed by Tim Horton.
3146
3147         Add 3 new API tests for attachment element dragging.
3148
3149         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3150         (-[TestWKWebView expectElementTag:toComeBefore:]):
3151         (-[NSItemProvider expectType:withData:]):
3152         (TestWebKitAPI::TEST):
3153
3154 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3155
3156         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
3157         https://bugs.webkit.org/show_bug.cgi?id=179621
3158         <rdar://problem/35589585>
3159
3160         Unreviewed infrastructure fix.
3161
3162         * Scripts/webkitpy/port/mac.py:
3163         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
3164         list if we are the VERSION_MAX, which usually corresponds with future.
3165
3166 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
3167
3168         CodeBlocks should be in IsoSubspaces
3169         https://bugs.webkit.org/show_bug.cgi?id=180884
3170
3171         Reviewed by Saam Barati.
3172         
3173         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
3174         shouldn't take a long time due to benchmarks we don't optimize for.
3175         
3176         * Scripts/run-jsc-benchmarks:
3177
3178 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
3179
3180         Test gardening for GTK.
3181         https://bugs.webkit.org/show_bug.cgi?id=181477
3182
3183         Unreviewed test gardening.
3184
3185         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
3186         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
3187
3188 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3189
3190         Add the new JSCOnly bot to the scheduler.
3191         https://bugs.webkit.org/show_bug.cgi?id=181487
3192
3193         Unreviewed follow-up patch after r226729
3194
3195         On r226729 I missed to add the new JSCOnly bot the default scheduler.
3196         This is needed to make the bot automatically pick each commit for testing.
3197
3198         * BuildSlaveSupport/build.webkit.org-config/config.json:
3199
3200 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3201
3202         [Attachment Support] Support dragging attachment elements out as files on iOS
3203         https://bugs.webkit.org/show_bug.cgi?id=181199
3204         <rdar://problem/36299316>
3205
3206         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
3207
3208         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
3209         attachment API tests.
3210
3211         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3212         (-[NSItemProvider expectType:withData:]):
3213         (TestWebKitAPI::TEST):
3214
3215         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
3216         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
3217         -expectType:withData: helper to inspect the item providers created from the drag source.
3218
3219         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3220         (TestWebKitAPI::TEST):
3221         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3222         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3223         (-[MockDragSession localContext]):
3224         (-[MockDragSession setLocalContext:]):
3225         (-[DataInteractionSimulator _resetSimulatedState]):
3226         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
3227         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3228         (-[DataInteractionSimulator _advanceProgress]):
3229         (-[DataInteractionSimulator endDataTransfer]):
3230
3231         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
3232         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
3233         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
3234         MockDragSession to hold on to a localContext.
3235
3236 2018-01-11  Ali Juma  <ajuma@chromium.org>
3237
3238         Unreviewed. Add Ali Juma as contributor
3239
3240         * Scripts/webkitpy/common/config/contributors.json:
3241
3242 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3243
3244         Unreviewed. Update Selenium WebDriver imported tests.
3245
3246         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
3247         environment variables.
3248
3249         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3250         (collect): Reorder the arguments to make pytest happy.
3251         (run): Ditto.
3252         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3253         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
3254
3255 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
3256
3257         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
3258         https://bugs.webkit.org/show_bug.cgi?id=181492
3259         <rdar://problem/36359679>
3260
3261         Reviewed by Alexey Proskuryakov. 
3262
3263 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
3264
3265         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
3266         https://bugs.webkit.org/show_bug.cgi?id=181475
3267
3268         Reviewed by Michael Catanzaro.
3269
3270         * gtk/install-dependencies: Update package list for Arch Linux, extend
3271         message shown at end of installation with additional tips.
3272
3273 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3274
3275         REGRESSION(r222507): Composition highlight doesn't render when using IME
3276         https://bugs.webkit.org/show_bug.cgi?id=181485
3277         <rdar://problem/35896516>
3278
3279         Reviewed by Ryosuke Niwa.
3280
3281         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
3282         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
3283         allow rendering composition backgrounds (see InlineTextBox::paint).
3284
3285         * DumpRenderTree/ios/TextInputControllerIOS.m:
3286         (+[TextInputController isSelectorExcludedFromWebScript:]):
3287         (+[TextInputController webScriptNameForSelector:]):
3288         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
3289         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
3290         * DumpRenderTree/mac/TextInputControllerMac.m:
3291         (+[TextInputController isSelectorExcludedFromWebScript:]):
3292         (+[TextInputController webScriptNameForSelector:]):
3293         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
3294         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
3295         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
3296         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
3297         (WTR::TextInputController::setMarkedText):
3298         * WebKitTestRunner/InjectedBundle/TextInputController.h:
3299
3300 2018-01-10  JF Bastien  <jfbastien@apple.com>
3301
3302         Poison small JSObject derivatives which only contain pointers
3303         https://bugs.webkit.org/show_bug.cgi?id=181483
3304         <rdar://problem/36407127>
3305
3306         Reviewed by Mark Lam.
3307
3308         Test the new move-assign and move-copy from unique_ptr, as well as
3309         nullptr_t ctors.
3310
3311         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3312         (TestWebKitAPI::TEST):
3313         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
3314         (TestWebKitAPI::TEST):
3315         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
3316         (TestWebKitAPI::TEST):
3317
3318 2018-01-10  Chris Dumez  <cdumez@apple.com>
3319
3320         Multiple http/wpt/beacon/contentextensions/ test are flaky.
3321         https://bugs.webkit.org/show_bug.cgi?id=179256
3322         <rdar://problem/35401978>
3323
3324         Reviewed by Alex Christensen.
3325
3326         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
3327         instance gets its own folder to avoid conflicts and flakiness.
3328
3329         * WebKitTestRunner/mac/TestControllerMac.mm:
3330         (WTR::TestController::platformConfigureViewForTest):
3331
3332 2018-01-10  Tim Horton  <timothy_horton@apple.com>
3333
3334         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
3335         https://bugs.webkit.org/show_bug.cgi?id=181269
3336         <rdar://problem/35110344>
3337
3338         Reviewed by Simon Fraser.
3339
3340         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3341         (WTR::UIScriptController::beginBackSwipe):
3342         (WTR::UIScriptController::completeBackSwipe):
3343         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3344         (WTR::UIScriptController::beginBackSwipe):
3345         (WTR::UIScriptController::completeBackSwipe):
3346         (WTR::UIScriptController::overridePreference):
3347         (WTR::UIScriptController::replaceTextAtRange):
3348         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3349         (WTR::PlatformWebView::setNavigationGesturesEnabled):
3350         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3351         (WTR::UIScriptController::beginBackSwipe):
3352         (WTR::UIScriptController::completeBackSwipe):
3353         Implement beginBackSwipe and completeBackSwipe on iOS (they already
3354         exist on Mac) in terms of the new WKWebView testing SPI.
3355
3356 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3357
3358         REGRESSION (r226715): ignore WARNING output in linter tests
3359         https://bugs.webkit.org/show_bug.cgi?id=181486
3360         <rdar://problem/36408847>
3361
3362         Reviewed by Aakash Jain.
3363
3364         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
3365
3366         * Scripts/webkitpy/common/system/outputcapture.py:
3367         (OutputCapture.__init__): Pass logging level to be captured.
3368         * Scripts/webkitpy/style/main_unittest.py:
3369         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
3370         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
3371         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
3372         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
3373         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
3374         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
3375         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
3376         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
3377
3378 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3379
3380         Add a JSCOnly MIPS buildbot
3381         https://bugs.webkit.org/show_bug.cgi?id=181487
3382
3383         Reviewed by Michael Catanzaro.
3384
3385         Add the new bot configs definitions for the master and update the unit tests.
3386
3387         * BuildSlaveSupport/build.webkit.org-config/config.json:
3388         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3389
3390 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3391
3392         REGRESSION (r226715): don't re-check number of simulators in child processes
3393         https://bugs.webkit.org/show_bug.cgi?id=181484
3394         <rdar://problem/36407151>
3395
3396         Reviewed by Aakash Jain.
3397
3398         * Scripts/webkitpy/port/ios_simulator.py:
3399         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
3400         are already initialized.
3401
3402 2018-01-10  Commit Queue  <commit-queue@webkit.org>
3403
3404         Unreviewed, rolling out r226667 and r226673.
3405         https://bugs.webkit.org/show_bug.cgi?id=181488
3406
3407         This caused a flaky crash. (Requested by mlewis13 on #webkit).
3408
3409         Reverted changesets:
3410
3411         "CodeBlocks should be in IsoSubspaces"
3412         https://bugs.webkit.org/show_bug.cgi?id=180884
3413         https://trac.webkit.org/changeset/226667
3414
3415         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
3416         https://bugs.webkit.org/show_bug.cgi?id=180884
3417         https://trac.webkit.org/changeset/226673
3418
3419 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3420
3421         Follow-up fix to r226715
3422         https://bugs.webkit.org/show_bug.cgi?id=180555
3423         <rdar://problem/36131381>
3424
3425         Unreviewed infrastructure fix.
3426
3427         * Scripts/webkitpy/xcode/new_simulated_device.py:
3428         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
3429         of delete.
3430
3431 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3432
3433         webkitpy: Refactor simulator code (Part 2)
3434         https://bugs.webkit.org/show_bug.cgi?id=180555
3435         <rdar://problem/36131381>
3436
3437         Reviewed by Aakash Jain.
3438
3439         The patch leverages the SimulatedDeviceManager when running layout tests.
3440         This patch is primarily code removal, since much of the IOSSimulatorPort
3441         was dedicated to managing simulators. The removed code is either now owned by the
3442         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
3443         boot multiple simulators which was made obsolete in Xcode 9.
3444
3445         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3446         (Manager._custom_device_for_test.in): Device names now have spaces in them,
3447         strip those spaces.
3448         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3449         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
3450         * Scripts/webkitpy/port/ios.py:
3451         (IOSPort.__init__): The _current_device idiom is no longer required since the
3452         SimulatedDeviceManager keeps track of any previously booted devices.
3453         (IOSPort.target_host): Even when only a single device is used, it will be accessed
3454         through the array of managed devices.
3455         (IOSPort.using_multiple_devices): Deleted.
3456         * Scripts/webkitpy/port/ios_device.py:
3457         (IOSDevicePort.using_multiple_devices): Deleted.
3458         * Scripts/webkitpy/port/ios_simulator.py:
3459         (IOSSimulatorPort): Remove constants required to manage simulators, change device
3460         class strings so they can be parsed by the DeviceType class.
3461         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
3462         the number of simulators currently booted, the number of child processes specified
3463         and the maximum number of simulators supported by this system.
3464         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
3465         devices owned by the SimulatedDeviceManager.
3466         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
3467         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
3468         the maximum number of supported simulators on this system.
3469         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
3470         request for each child process and send this list to the SimulatedDeviceManager to
3471         initialize the devices.
3472         (IOSSimulatorPort.clean_up_test_run):
3473         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
3474         specified version of iOS.
3475         (IOSSimulatorPort.reset_preferences):
3476         (IOSSimulatorPort.simulator_runtime): Deleted.
3477         (IOSSimulatorPort.simulator_device_type): Deleted.
3478         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
3479         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
3480         (IOSSimulatorPort._create_simulators): Deleted.
3481         (IOSSimulatorPort._quit_ios_simulator): Deleted.
3482         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
3483         (IOSSimulatorPort.using_multiple_devices): Deleted.
3484         (IOSSimulatorPort._create_device): Deleted.
3485         (IOSSimulatorPort.get_simulator_path): Deleted.
3486         (IOSSimulatorPort._createSimulatorApps): Deleted.
3487         (IOSSimulatorPort._createSimulatorApp): Deleted.
3488         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3489         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
3490         maximum number of simulators run on this system.
3491         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
3492         * Scripts/webkitpy/xcode/new_simulated_device.py:
3493         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
3494
3495 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3496
3497         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
3498         https://bugs.webkit.org/show_bug.cgi?id=181474
3499
3500         Reviewed by Carlos Alberto Lopez Perez.
3501
3502         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
3503         name as the name.
3504
3505         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3506         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
3507         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
3508
3509 2018-01-09  Andy Estes  <aestes@apple.com>
3510
3511         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
3512         https://bugs.webkit.org/show_bug.cgi?id=181459
3513
3514         Reviewed by Dan Bernstein.
3515
3516         * ImageDiff/cg/Configurations/Base.xcconfig:
3517
3518 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
3519
3520         font-display:fallback can cause a visual flash (which is supposed to be impossible)
3521         https://bugs.webkit.org/show_bug.cgi?id=181374
3522
3523         Reviewed by Simon Fraser.
3524
3525         The test requires Palatino.
3526
3527         * DumpRenderTree/mac/DumpRenderTree.mm:
3528         (allowedFontFamilySet):
3529         * WebKitTestRunner/mac/TestControllerMac.mm:
3530         (WTR::allowedFontFamilySet):
3531
3532 2018-01-09  Saam Barati  <sbarati@apple.com>
3533
3534         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
3535         https://bugs.webkit.org/show_bug.cgi?id=181449
3536
3537         Reviewed by JF Bastien.
3538
3539         This allows me to Cmd+f in my terminal to search for things without
3540         having the results become misaligned.
3541
3542         * Scripts/display-profiler-output:
3543
3544 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3545
3546         [webkitpy] PlatformInfo should have default argument for casual use
3547         https://bugs.webkit.org/show_bug.cgi?id=180827
3548
3549         Reviewed by David Kilzer.
3550
3551         PlatformInfo should be the only way to check platform specific thing instead
3552         of sys.platform or other various checks. If there is something you want to check,
3553         it should be placed in PlatformInfo.
3554
3555         Currently to instantiate PlatformInfo, it requires arguments, which is usually
3556         sys, platform and Executive(). They are straight forward and should be handled
3557         by default arguments. Then we can instantiate PlatformInfo more casual.
3558
3559         * Scripts/webkitpy/common/system/platforminfo.py:
3560         (PlatformInfo): Use relative module path import
3561         (PlatformInfo.__init__):
3562         (PlatformInfo.executive): Lazy instantiation of Executive()
3563         (PlatformInfo.total_bytes_memory): Accessing via above property
3564         (PlatformInfo.xcode_sdk_version): Ditto
3565         (PlatformInfo.xcode_simctl_list): Ditto
3566         (PlatformInfo.xcode_version): Ditto
3567         (PlatformInfo._win_version_str): Ditto
3568         * Scripts/webkitpy/common/system/systemhost.py:
3569         (SystemHost.__init__):
3570         * Scripts/webkitpy/common/system/user.py:
3571         (User.__init__):
3572
3573 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3574
3575         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
3576         https://bugs.webkit.org/show_bug.cgi?id=176443
3577
3578         Reviewed by Darin Adler.
3579
3580         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
3581         (TEST):
3582
3583 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
3584
3585         check-webkit-style: Verify syntax for WK_API_AVAILABLE
3586         https://bugs.webkit.org/show_bug.cgi?id=181394
3587
3588         Reviewed by Darin Adler.
3589
3590         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
3591         as the second parameter instead of ios(WK_IOS_TBA). This generally
3592         builds for iOS on EWS but not when using the public SDK. See r224057,
3593         r223207 and r226211 for example. This patch adds a basic style check
3594         for that macro to prevent this kind of mistake.
3595
3596         * Scripts/webkitpy/style/checkers/cpp.py:
3597         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
3598         (check_style): Run new style check.
3599         (CppChecker): Add build type for the new style check.
3600         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3601         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
3602
3603 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3604
3605         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
3606         https://bugs.webkit.org/show_bug.cgi?id=181420
3607         <rdar://problem/36365827>
3608
3609         Reviewed by Alex Christensen.
3610
3611         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
3612         of corresponding _WKAttachments.
3613
3614         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3615         (TestWebKitAPI::TEST):
3616
3617 2018-01-08  Alex Christensen  <achristensen@webkit.org>
3618
3619         Add WKNavigationDelegate SPI exposing WebProcess crash reason
3620         https://bugs.webkit.org/show_bug.cgi?id=181410
3621         <rdar://problem/36167199>
3622
3623         Reviewed by Wenson Hsieh.
3624
3625         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3626         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
3627         (TEST):
3628
3629 2018-01-08  Alex Christensen  <achristensen@webkit.org>
3630
3631         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
3632         https://bugs.webkit.org/show_bug.cgi?id=181408
3633         <rdar://problem/35884960>
3634