059914fe89fe51e5abf180a70b75167a287c945c
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-01  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Adam Roben.
4
5         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
6
7         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
8         (WTR::LayoutTestController::shadowRoot):
9         Make judicious use of adoptWK().
10
11 2011-04-01  Sam Weinig  <sam@webkit.org>
12
13         Reviewed by Timothy Hatcher.
14
15         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
16
17         * Scripts/extract-localizable-strings:
18
19 2011-04-01  Anders Carlsson  <andersca@apple.com>
20
21         Reviewed by Sam Weinig.
22
23         Shockwave plug-in doesn't accept mouse events
24         https://bugs.webkit.org/show_bug.cgi?id=57653
25         <rdar://problem/8483273>
26
27         Add a plug-in test.
28
29         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
30         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
31         (PluginTest::indicateTestFailure):
32         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
33
34         (PluginTest::NPN_ConvertPoint):
35         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
36         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
37         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
38         Call indicateTestFailure.
39
40         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
41         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
42         (ConvertPoint::ConvertPoint):
43         (ConvertPoint::testConvert):
44         (ConvertPoint::NPP_New):
45
46 2011-04-01  Dominic Cooney  <dominicc@google.com>
47
48         Reviewed by Martin Robinson.
49
50         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
51         https://bugs.webkit.org/show_bug.cgi?id=57551
52
53         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
54         (LayoutTestController::shadowRoot):
55
56 2011-04-01  Sam Weinig  <sam@webkit.org>
57
58         Reviewed by Anders Carlsson.
59
60         WebKitTestRunner needs layoutTestController.shadowRoot
61         https://bugs.webkit.org/show_bug.cgi?id=57661
62
63         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
64         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
65         (WTR::LayoutTestController::shadowRoot):
66         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
67         Implement layoutTestController.shadowRoot for WebKit2.
68
69 2011-04-01  Chang Shu  <cshu@webkit.org>
70
71         Reviewed by Darin Adler.
72
73         WebKitTestRunner needs layoutTestController.setDatabaseQuota
74         https://bugs.webkit.org/show_bug.cgi?id=57568
75
76         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
77         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
78         (WTR::LayoutTestController::setDatabaseQuota):
79         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
80
81 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
82
83         Reviewed by Tony Chang.
84
85         This patch completes the cleanup of
86         rebaseline-chromium-webkit-tests to work with all of the
87         variants of a platform (we can now rebaseline gpu- and non-gpu
88         files at the same time).
89
90         When the rebaselining is complete, any lines declared as
91         REBASELINE in the expectations file that matches a test that was
92         actually rebaselined will be deleted, even if only one of the
93         variants was actually rebaselined. This may cause odd problems,
94         but is better than where we're at today.
95
96         This change removes the -g flag and deprecates -w. The -g flag is gone
97         because GPU baselines are handled just like any other variant.
98         The -w flag is deprecated because this tool now only works
99         against the canaries, since that's the only place we have a full
100         set of bots. It will be trivial to change this to
101         build.webkit.org if we decide that's where we want them to be.
102
103         Also, this patch deletes a lot of cruft that is no longer needed
104         in the test_expectations code and the port-specific code.
105
106         https://bugs.webkit.org/show_bug.cgi?id=55191
107
108         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
109         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
110         * Scripts/webkitpy/layout_tests/port/base.py:
111         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
112         * Scripts/webkitpy/layout_tests/port/chromium.py:
113         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
114         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
115         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
116         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
117         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
118         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
119         * Scripts/webkitpy/layout_tests/port/mac.py:
120         * Scripts/webkitpy/layout_tests/port/test.py:
121         * Scripts/webkitpy/layout_tests/port/webkit.py:
122         * Scripts/webkitpy/layout_tests/port/win.py:
123         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
124         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
125
126 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
127
128         Reviewed by Adam Barth.
129
130         rebaseline-chromium-webkit-tests does not work correctly with
131         version-specific baselines. This patch updates the tool to use
132         all of the version-specific bots on the canaries, and will now
133         attempt to rebaseline all of the versions by default, although
134         it will not update both GPU and CPU versions.
135         
136         Also, it will no longer modify the test_expectations.txt file
137         *at all*. You will have to manually delete the REBASELINE lines
138         after running the tool and determining that it did what you
139         wanted it to do. This should be fixed in a separate bug - see
140         webkit bug #55191.
141
142         https://bugs.webkit.org/show_bug.cgi?id=55608
143
144         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
145         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
146         * Scripts/webkitpy/layout_tests/port/chromium.py:
147         * Scripts/webkitpy/layout_tests/port/test.py:
148         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
149         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
150
151 2011-03-31  Tony Chang  <tony@chromium.org>
152
153         Reviewed by Ojan Vafai.
154
155         [chromium] update the rebaseline tool to know about pngs with checksums
156         https://bugs.webkit.org/show_bug.cgi?id=57481
157
158         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
159         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
160
161 2011-04-01  Adam Roben  <aroben@apple.com>
162
163         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
164
165         Previously, we were getting the revision of the first revision that triggered a build.
166         Choosing the last revision would have been more accurate. But got_revision is what is used
167         everywhere else on build.webkit.org, and should work even when there were no changes that
168         triggered a build (e.g., if someone clicked the Force Build button).
169
170         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
171         recent builds list
172
173         Reviewed by Anders Carlsson.
174
175         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
176         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
177         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
178
179         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
180         (Array.prototype.first): Added this helper function to return the first element in an array
181         that matches the given predicate, or null if no such element exists.
182
183 2011-03-31  Adam Roben  <aroben@apple.com>
184
185         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
186
187         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
188
189         Reviewed by Darin Adler.
190
191         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
192         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
193         URL on its own line.
194
195         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
196         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
197         progression, and added a new test that uses a short bug URL while I was at it.
198
199 2011-04-01  Adam Roben  <aroben@apple.com>
200
201         Mark .vcproj/.vsprops/.sln files as being Windows-only
202
203         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
204
205         Reviewed by Anders Carlsson.
206
207         * Scripts/webkitpy/common/config/build.py:
208         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
209         directories as Windows-only.
210
211         * Scripts/webkitpy/common/config/build_unittest.py:
212         (ShoulBuildTest): Added test cases for the above.
213
214 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
215
216         Reviewed by Laszlo Gombos.
217
218         [Qt] Build MiniBrowser for Symbian
219         https://bugs.webkit.org/show_bug.cgi?id=56319
220
221         Have MiniBrowser reference it's own copy of useragentlist.txt instead
222         of copying QtTestBrowser's.
223         Remove Tools/MiniBrowser/DerivedSources.pro
224         This reduces complexity in the Tools scripts due to Symbian limitations.
225
226         * DerivedSources.pro:
227         * MiniBrowser/DerivedSources.pro: Removed.
228         * MiniBrowser/MiniBrowser.qrc:
229         * MiniBrowser/qt/MiniBrowser.pro:
230         * Scripts/webkitdirs.pm:
231
232 2011-03-31  Chang Shu  <cshu@webkit.org>
233
234         Reviewed by Darin Adler.
235
236         WebKitTestRunner needs layoutTestController.clearAllDatabases
237         https://bugs.webkit.org/show_bug.cgi?id=42540
238
239         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
240         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
241         (WTR::InjectedBundle::beginTesting):
242         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
243         (WTR::LayoutTestController::clearAllDatabases):
244         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
245
246 2011-03-31  Chang Shu  <cshu@webkit.org>
247
248         Reviewed by Darin Adler.
249
250         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
251         https://bugs.webkit.org/show_bug.cgi?id=42692
252
253         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
254
255 2011-03-31  Darin Adler  <darin@apple.com>
256
257         Reviewed by Sam Weinig.
258
259         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
260         https://bugs.webkit.org/show_bug.cgi?id=57573
261
262         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
263         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
264         Removed fake definitions of keyDown and contextClick.
265
266         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
267         (WTR::operator==): Added. So we can compare two WKPoint structs.
268         (WTR::parseModifier): Added.
269         (WTR::parseModifierArray): Added.
270         (WTR::EventSendingController::EventSendingController): Initialize the
271         new data members.
272         (WTR::EventSendingController::mouseDown): Added. Calls
273         WKBundlePageSimulateMouseDown.
274         (WTR::EventSendingController::mouseUp): Added. Calls
275         WKBundlePageSimulateMouseUp.
276         (WTR::EventSendingController::mouseMoveTo): Added. Calls
277         WKBundlePageSimulateMouseMotion.
278         (WTR::EventSendingController::leapForward): Added.
279         (WTR::EventSendingController::updateClickCount): Added. Used by the
280         mouseDown/Up functions to create a click count.
281
282         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
283         for the changes above.
284
285 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
286
287         Reviewed by Martin Robinson.
288
289         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
290         https://bugs.webkit.org/show_bug.cgi?id=57362
291
292         Do not generate DRT output if willSendRequestReturnsNull is set.
293
294         * DumpRenderTree/gtk/DumpRenderTree.cpp:
295         (willSendRequestCallback):
296
297 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
298
299         Reviewed by Martin Robinson.
300
301         Implement MiniBrowser for Gtk port.
302         https://bugs.webkit.org/show_bug.cgi?id=48512
303
304         Initial implementation of the Gtk MiniBrowser.
305
306         * MiniBrowser/gtk/GNUmakefile.am: Added.
307         * MiniBrowser/gtk/main.c: Added.
308         (activateUriEntryCallback):
309         (destroyCallback):
310         (goBackCallback):
311         (goForwardCallback):
312         (createToolbar):
313         (createWebView):
314         (createWindow):
315         (argumentToURL):
316         (main):
317
318 2011-03-30  Dominic Cooney  <dominicc@google.com>
319
320         Reviewed by Dimitri Glazkov.
321
322         Adds layoutTestController.shadowRoot accessor to Mac DRT.
323         https://bugs.webkit.org/show_bug.cgi?id=57415
324
325         * DumpRenderTree/LayoutTestController.cpp:
326         (shadowRootCallback):
327         (LayoutTestController::staticFunctions):
328         * DumpRenderTree/LayoutTestController.h:
329         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
330         (LayoutTestController::shadowRoot):
331         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
332         (LayoutTestController::shadowRoot):
333
334 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
335
336         Reviewed by Chris Marrin.
337
338         Update fast/canvas tests to avoid dumping the render tree when possible
339         https://bugs.webkit.org/show_bug.cgi?id=57493
340
341         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
342           accelerated drawing and accelerated drawing for canvas
343
344 2011-03-30  Adam Roben  <aroben@apple.com>
345
346         Stop ignoring leaks in CGGradientCreateWithColorStops
347
348         Fixes <rdar://problem/7888547>.
349
350         Rubber-stamped by John Sullivan.
351
352         * Scripts/old-run-webkit-tests:
353         (countAndPrintLeaks): Removed some code to ignore those leaks.
354
355 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
356
357         Reviewed by Alexey Proskuryakov.
358
359         Add some dynamic annotations to JavaScriptCore/wtf
360         https://bugs.webkit.org/show_bug.cgi?id=53747
361
362         By using these annotations we can improve the precision of finding
363         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
364         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
365
366         These files don't add new functionality, so don't need extra tests.
367
368         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
369
370 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
371
372         Reviewed by Adam Roben.
373
374         Share most vsprops between Release and Production builds in releaseproduction.vsprops
375         https://bugs.webkit.org/show_bug.cgi?id=57508
376
377         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
378         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
379         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
380         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
381         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
382         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
383         * DumpRenderTree/win/ImageDiffProduction.vsprops:
384         * DumpRenderTree/win/ImageDiffRelease.vsprops:
385         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
386         * FindSafari/FindSafariProduction.vsprops:
387         * FindSafari/FindSafariRelease.vsprops:
388         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
389         * FindSafari/FindSafariReleasePGO.vsprops:
390         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
391         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
392         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
393         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
394         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
395         * WebKitAPITest/WebKitAPITestProduction.vsprops:
396         * WebKitAPITest/WebKitAPITestRelease.vsprops:
397         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
398         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
399         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
400         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
401         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
402         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
403         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
404         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
405         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
406         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
407         * WinLauncher/WinLauncherProduction.vsprops:
408         * WinLauncher/WinLauncherRelease.vsprops:
409         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
410         * record-memory-win/record-memory-winProduction.vsprops:
411         * record-memory-win/record-memory-winRelease.vsprops:
412         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
413
414 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
415
416         Reviewed by Adam Roben.
417
418         Update Windows production build logic for new production configurations
419         https://bugs.webkit.org/show_bug.cgi?id=57494
420
421         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
422         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
423         * DumpRenderTree/win/ImageDiffProduction.vsprops:
424         * FindSafari/FindSafariProduction.vsprops:
425         * FindSafari/FindSafariReleasePGO.vsprops:
426         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
427         * WebKitAPITest/WebKitAPITestProduction.vsprops:
428         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
429         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
430         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
431         * WinLauncher/WinLauncherProduction.vsprops:
432         * record-memory-win/record-memory-winProduction.vsprops:
433
434 2011-03-30  Robert Hogan  <robert@webkit.org>
435
436         Reviewed by Antonio Gomes.
437
438         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
439         Unskip http/tests/navigation/go-back-to-error-page.html
440
441         Also add the location of DumpRenderTreeSupportQt.h
442         to DRT's include paths.
443
444         https://bugs.webkit.org/show_bug.cgi?id=52614
445
446         * DumpRenderTree/qt/DumpRenderTree.pro:
447         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
448         * DumpRenderTree/qt/DumpRenderTreeQt.h:
449         * DumpRenderTree/qt/GCControllerQt.cpp:
450         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
451         (LayoutTestController::queueLoadHTMLString):
452         * DumpRenderTree/qt/LayoutTestControllerQt.h:
453         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
454         * DumpRenderTree/qt/TextInputControllerQt.cpp:
455         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
456         (LoadAlternateHTMLStringItem::invoke):
457         * DumpRenderTree/qt/WorkQueueItemQt.h:
458         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
459         * QtTestBrowser/QtTestBrowser.pro:
460         * QtTestBrowser/launcherwindow.h:
461
462 2011-03-30  Adam Barth  <abarth@webkit.org>
463
464         Reviewed by Adam Roben.
465
466         SheriffBot rollouts take too long
467         https://bugs.webkit.org/show_bug.cgi?id=57498
468
469         We used to build before landing rollouts via the commit-queue to
470         prevent further breakage, but now that our individual commit-queue
471         machines are slower, building takes too long.  I can't remember the
472         last time a rollout broke compile.  It seems like just landing the
473         patch is the better trade-off.
474
475         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
476         * Scripts/webkitpy/tool/commands/queues_unittest.py:
477
478 2011-03-30  Adam Barth  <abarth@webkit.org>
479
480         Remove platform/chromium-mac-snowleopard
481         https://bugs.webkit.org/show_bug.cgi?id=57486
482
483         This directory no longer exists, so we can remove it from the fallback
484         chain.
485
486         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
487
488 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
489
490         Reviewed by Adam Roben.
491
492         Rename Windows configuration Release_LTCG to Production for clarity
493         https://bugs.webkit.org/show_bug.cgi?id=57465
494
495         * DumpRenderTree/DumpRenderTree.sln:
496         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
497         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
498         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
499         * DumpRenderTree/win/DumpRenderTree.vcproj:
500         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
501         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
502         * DumpRenderTree/win/ImageDiff.vcproj:
503         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
504         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
505         * FindSafari/FindSafari.vcproj:
506         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
507         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
508         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
509         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
510         * MiniBrowser/MiniBrowser.vcproj:
511         * Scripts/webkitdirs.pm:
512         * TestWebKitAPI/win/TestWebKitAPI.sln:
513         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
514         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
515         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
516         * WebKitAPITest/WebKitAPITest.vcproj:
517         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
518         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
519         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
520         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
521         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
522         * WebKitTestRunner/WebKitTestRunner.sln:
523         * WebKitTestRunner/win/InjectedBundle.vcproj:
524         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
525         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
526         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
527         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
528         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
529         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
530         * WinLauncher/WinLauncher.vcproj:
531         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
532         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
533         * record-memory-win/record-memory-win.vcproj:
534         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
535         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
536
537 2011-03-30  MORITA Hajime  <morrita@google.com>
538
539         Reviewed by Dimitri Glazkov.
540
541         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
542         https://bugs.webkit.org/show_bug.cgi?id=56573
543
544         Added LayoutTestController.shadowRoot() to Chromium DRT.
545
546         * DumpRenderTree/chromium/LayoutTestController.cpp:
547         (LayoutTestController::LayoutTestController):
548         (LayoutTestController::shadowRoot):
549         * DumpRenderTree/chromium/LayoutTestController.h:
550
551 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
552
553         Reviewed by Kent Tamura.
554
555         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
556         https://bugs.webkit.org/show_bug.cgi?id=57430
557
558         * DumpRenderTree/chromium/LayoutTestController.cpp:
559         (LayoutTestController::LayoutTestController):
560         (LayoutTestController::setPluginsEnabled):
561         * DumpRenderTree/chromium/LayoutTestController.h:
562
563 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
564
565         Reviewed by Adam Barth.
566
567         make webkit-patch upload respect -d
568         https://bugs.webkit.org/show_bug.cgi?id=57425
569
570         * Scripts/webkitpy/common/checkout/scm.py:
571         * Scripts/webkitpy/tool/steps/commit.py:
572
573 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
574
575         Reviewed by Adam Barth.
576
577         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
578         https://bugs.webkit.org/show_bug.cgi?id=57429
579
580         * Scripts/webkitpy/common/checkout/scm.py:
581
582 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
583
584         Unreviewed, rolling out r82383.
585         http://trac.webkit.org/changeset/82383
586         https://bugs.webkit.org/show_bug.cgi?id=57417
587
588         "nrwt isn't shutting down cleanly" (Requested by dpranke on
589         #webkit).
590
591         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
592         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
593         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
594
595 2011-03-29  Kent Tamura  <tkent@chromium.org>
596
597         Reviewed by Dimitri Glazkov.
598
599         Make validation message bubble testable
600         https://bugs.webkit.org/show_bug.cgi?id=57290
601
602         * DumpRenderTree/mac/DumpRenderTree.mm:
603         (createWebViewAndOffscreenWindow): Change a setting so that validation
604           bubbles isn't hidden automatically.
605
606 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
607
608         Reviewed by Ojan Vafai.
609
610         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
611
612         It's a bit unclear whether multiple threads or multiple
613         processes will be a better model on windows. This change will
614         test threads for now while we're still working out the bugs in
615         multiple-processes.
616
617         https://bugs.webkit.org/show_bug.cgi?id=57410
618
619         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
620         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
621         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
622
623 2011-03-29  David Levin  <levin@chromium.org>
624
625         Reviewed by Shinichiro Hamaji.
626
627         check-webkit-style confused by two ChangeLog entries in a row from same user
628         https://bugs.webkit.org/show_bug.cgi?id=57250
629
630         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
631         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
632         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
633           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
634           checking more than that would be very messey.
635         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
636         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
637
638 2011-03-29  Kent Tamura  <tkent@chromium.org>
639
640         Reviewed by Dimitri Glazkov.
641
642         [Mac] Enable interactive-validation tests on Mac DRT
643         https://bugs.webkit.org/show_bug.cgi?id=57308
644
645         * DumpRenderTree/mac/DumpRenderTree.mm:
646         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
647
648 2011-03-29  Chang Shu  <cshu@webkit.org>
649
650         Reviewed by Kenneth Rohde Christiansen.
651
652         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
653         https://bugs.webkit.org/show_bug.cgi?id=42692
654
655         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
656         (WTR::InjectedBundle::beginTesting):
657         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
658         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
659         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
660
661 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
662
663         Reviewed by Xan Lopez.
664
665         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
666         https://bugs.webkit.org/show_bug.cgi?id=57067
667
668         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
669         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
670         update DRT and pixel results as hundreds of results will need to be updated.
671
672         * DumpRenderTree/gtk/DumpRenderTree.cpp:
673         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
674         by overriding the theme RC/CSS files.
675
676 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
677
678         Reviewed by Adam Roben.
679
680         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
681         https://bugs.webkit.org/show_bug.cgi?id=57394
682
683         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
684         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
685         the IDE. To avoid this, add a separate vsprops file for each project configuration that
686         contains the required inherited property sheets.
687
688         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
689         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
690         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
691         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
692         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
693         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
694         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
695         * DumpRenderTree/win/DumpRenderTree.vcproj:
696         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
697         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
698         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
699         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
700         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
701         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
702         * DumpRenderTree/win/ImageDiff.vcproj:
703         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
704         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
705         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
706         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
707         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
708         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
709         * FindSafari/FindSafari.vcproj:
710         * FindSafari/FindSafariDebug.vsprops: Added.
711         * FindSafari/FindSafariDebugAll.vsprops: Added.
712         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
713         * FindSafari/FindSafariRelease.vsprops: Added.
714         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
715         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
716         * FindSafari/FindSafariReleasePGO.vsprops: Added.
717         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
718         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
719         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
720         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
721         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
722         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
723         * MiniBrowser/MiniBrowser.vcproj:
724         * WebKitAPITest/WebKitAPITest.vcproj:
725         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
726         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
727         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
728         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
729         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
730         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
731         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
732         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
733         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
734         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
735         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
736         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
737         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
738         * WebKitTestRunner/win/InjectedBundle.vcproj:
739         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
740         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
741         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
742         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
743         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
744         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
745         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
746         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
747         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
748         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
749         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
750         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
751         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
752         * WinLauncher/WinLauncher.vcproj:
753         * WinLauncher/WinLauncherDebug.vsprops: Added.
754         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
755         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
756         * WinLauncher/WinLauncherRelease.vsprops: Added.
757         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
758         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
759         * record-memory-win/record-memory-win.vcproj:
760         * record-memory-win/record-memory-winDebug.vsprops: Added.
761         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
762         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
763         * record-memory-win/record-memory-winRelease.vsprops: Added.
764         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
765         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
766
767 2011-03-29  Adam Barth  <abarth@webkit.org>
768
769         Reviewed by Darin Adler.
770
771         test_runner2.py can crash due to undefined variable
772         https://bugs.webkit.org/show_bug.cgi?id=57356
773
774         Replace reference to undefined variable with a variable that's actually
775         defined.  AFAICT, there's no way to test this code.
776
777         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
778
779 2011-03-29  Tony Chang  <tony@chromium.org>
780
781         Reviewed by Eric Seidel.
782
783         cleanup rebaseline-chromium-webkit-tests
784         https://bugs.webkit.org/show_bug.cgi?id=57375
785
786         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
787             - Split _extract_and_add_new_baselines into 3 functions
788             - Reduce the amount of line wrapping (the file already has lines
789               over 80 col, so may as well try to make the file consistent)
790             - Remove unnecessary ()s
791
792 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
793
794         Reviewed by Adam Roben.
795
796         Make WinCairo a core builder.
797         https://bugs.webkit.org/show_bug.cgi?id=57373
798
799         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
800         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
801
802 2011-03-29  Timothy Hatcher  <timothy@apple.com>
803
804         Update update-webkit-localizable-strings to understand that WebKit and
805         WebKit2 strings go in WebCore.
806
807         Also make extract-localizable-strings optionally use an exclude file. No individual
808         warnings are produced about unlocalized strings when there is no exclude file. This
809         is needed for WebCore, since there are too many bare strings.
810
811         https://webkit.org/b/57354
812
813         Reviewed by Sam Weinig.
814
815         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
816         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
817
818 2011-03-29  Darin Adler  <darin@apple.com>
819
820         Reviewed by Adam Roben.
821
822         WebKit2 bundle page needs to offer generated file hooks
823         https://bugs.webkit.org/show_bug.cgi?id=57279
824
825         (Land missing part of the original patch after r82289.)
826
827         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
828         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
829
830 2011-03-29  Tony Chang  <tony@chromium.org>
831
832         Reviewed by Ojan Vafai.
833
834         [chromium] NRWT should be able to read checksums from png comments
835         https://bugs.webkit.org/show_bug.cgi?id=57280
836
837         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
838             from a file.
839         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
840         * Scripts/webkitpy/common/system/filesystem_mock.py:
841         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
842             if the -checksum.txt file doesn't exist, try looking in the png.
843         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
844         * Scripts/webkitpy/layout_tests/port/test.py:
845         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
846             2k for a png comment with the checksum
847         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
848
849 2011-03-29  Philippe Normand  <pnormand@igalia.com>
850
851         Rubber-stamped by Gustavo Noronha Silva.
852
853         [GTK] http/tests/uri/username-with-no-hostname.html fails
854         https://bugs.webkit.org/show_bug.cgi?id=57325
855
856         * DumpRenderTree/gtk/DumpRenderTree.cpp:
857         (willSendRequestCallback): URI host value check done case-insensitively.
858
859 2011-03-29  Philippe Normand  <pnormand@igalia.com>
860
861         Reviewed by Martin Robinson.
862
863         [GTK] http/tests/uri/username-with-no-hostname.html fails
864         https://bugs.webkit.org/show_bug.cgi?id=57325
865
866         * DumpRenderTree/gtk/DumpRenderTree.cpp:
867         (willSendRequestCallback): Check URI before submitting the request
868         to WebCore.
869
870 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
871
872         Reviewed by Ojan Vafai.
873
874         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
875         https://bugs.webkit.org/show_bug.cgi?id=57303
876
877         * DumpRenderTree/chromium/EventSender.cpp:
878         (EventSender::doDragDrop):
879         (EventSender::beginDragWithFiles):
880
881 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
882
883         Reviewed by Andreas Kling.
884
885         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
886         https://bugs.webkit.org/show_bug.cgi?id=57314
887
888         Provide possibility to print loaded urls to the standard output.
889
890         * MiniBrowser/qt/BrowserWindow.cpp:
891         (BrowserWindow::BrowserWindow):
892         (BrowserWindow::printURL):
893         * MiniBrowser/qt/BrowserWindow.h:
894         * MiniBrowser/qt/MiniBrowserApplication.cpp:
895         (MiniBrowserApplication::handleUserOptions):
896         * MiniBrowser/qt/MiniBrowserApplication.h:
897         (WindowOptions::WindowOptions):
898         * QtTestBrowser/launcherwindow.cpp:
899         (LauncherWindow::initializeView):
900         (LauncherWindow::printURL):
901         (LauncherWindow::cloneWindow):
902         * QtTestBrowser/launcherwindow.h:
903         (WindowOptions::WindowOptions):
904         * QtTestBrowser/main.cpp:
905         (LauncherApplication::handleUserOptions):
906
907 2011-03-29  Gabor Loki  <loki@webkit.org>
908
909         Rubber-stamped by Csaba Osztrogonác.
910
911         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
912         https://bugs.webkit.org/show_bug.cgi?id=56918
913
914         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
915
916 2011-03-28  Gabor Loki  <loki@webkit.org>
917
918         Reviewed by Csaba Osztrogonác.
919
920         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
921         https://bugs.webkit.org/show_bug.cgi?id=56918
922
923         * Scripts/build-jsc:
924         * Scripts/webkitdirs.pm:
925
926 2011-03-28  Andrew Foster  <andrewf@chromium.org>
927
928         Reviewed by Ojan Vafai.
929
930         webkit-patch should be more intelligent about whether a bug applies to a patch
931         Create a new function, parse_bug_id_from_changelog() which determines
932         that a bug is related to a patch by parsing the output generated from
933         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
934         the description of a patch.
935         https://bugs.webkit.org/show_bug.cgi?id=56989
936
937         * Scripts/webkitpy/common/checkout/api.py:
938         * Scripts/webkitpy/common/checkout/changelog.py:
939         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
940         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
941         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
942         * Scripts/webkitpy/style/checkers/changelog.py:
943         * Scripts/webkitpy/tool/commands/upload.py:
944
945 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
946
947         Revert accidentally commited change.
948
949         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
950         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
951
952 2011-03-28  Tony Chang  <tony@chromium.org>
953
954         Reviewed by Adam Barth.
955
956         [chromium] have DRT write the png checksum into a png comment
957         https://bugs.webkit.org/show_bug.cgi?id=57255
958
959         * DumpRenderTree/chromium/TestShell.cpp:
960         (TestShell::dumpImage):
961
962 2011-03-28  Adele Peterson  <adele@apple.com>
963
964         Removing Qt stub, since it doesn't use the same header as the others.
965
966         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
967
968 2011-03-28  Adele Peterson  <adele@apple.com>
969
970         Added a few more stubs.
971
972         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
973         (LayoutTestController::hasGrammarMarker):
974         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
975         (LayoutTestController::hasGrammarMarker):
976         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
977         (LayoutTestController::hasGrammarMarker):
978
979 2011-03-28  Adele Peterson  <adele@apple.com>
980
981         Build fix.
982
983         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
984         (LayoutTestController::hasGrammarMarker):
985
986 2011-03-28  Adele Peterson  <adele@apple.com>
987
988         Reviewed by Eric Seidel.
989
990         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
991         https://bugs.webkit.org/show_bug.cgi?id=57173
992
993         * DumpRenderTree/LayoutTestController.cpp:
994         (hasGrammarMarkerCallback): Added.
995         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
996         * DumpRenderTree/LayoutTestController.h:
997         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
998         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
999
1000 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1001
1002         Reviewed by Benjamin Poulain.
1003
1004         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1005         https://bugs.webkit.org/show_bug.cgi?id=57087
1006
1007         Trivial typo fix after r82082.
1008
1009         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1010         (WTR::activateFonts):
1011
1012 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
1013
1014         Reviewed by Andreas Kling.
1015
1016         Add myself to the committers list.
1017
1018         * Scripts/webkitpy/common/config/committers.py:
1019
1020 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
1021
1022         Reviewed by Sam Weinig.
1023
1024         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
1025         to link against WebKit.framework for now.
1026
1027         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1028
1029 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1030
1031         Reviewed by Andreas Kling.
1032
1033         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1034         https://bugs.webkit.org/show_bug.cgi?id=57087
1035
1036         Disable QT_ASCII_CAST_WARNINGS for applications.
1037
1038         * DumpRenderTree/qt/DumpRenderTree.pro:
1039         * DumpRenderTree/qt/ImageDiff.pro:
1040         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1041         * MiniBrowser/qt/MiniBrowser.pro:
1042         * QtTestBrowser/QtTestBrowser.pro:
1043         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1044
1045 2011-03-28  Andreas Kling  <kling@webkit.org>
1046
1047         Reviewed by Kenneth Rohde Christiansen.
1048
1049         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
1050         https://bugs.webkit.org/show_bug.cgi?id=57224
1051
1052         * QtTestBrowser/mainwindow.cpp:
1053         (MainWindow::buildUI):
1054         (MainWindow::onTitleChanged):
1055         * QtTestBrowser/mainwindow.h:
1056
1057 2011-03-27  Jer Noble  <jer.noble@apple.com>
1058
1059         Reviewed by Maciej Stachowiak.
1060
1061         Full Screen: disable keyboard access by default
1062         https://bugs.webkit.org/show_bug.cgi?id=56684
1063
1064         Accept the withKeyboard parameter to supportsFullScreenForElement.
1065
1066         * DumpRenderTree/mac/UIDelegate.mm:
1067         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1068
1069 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
1070
1071         Reviewed by David Levin.
1072
1073         check-webkit-style should check ChangeLog for a valid bug number
1074         https://bugs.webkit.org/show_bug.cgi?id=57184
1075
1076         * Scripts/webkitpy/style/checker.py:
1077         * Scripts/webkitpy/style/checker_unittest.py:
1078         * Scripts/webkitpy/style/checkers/changelog.py: Added.
1079         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
1080
1081 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1082
1083         Reviewed by Andreas Kling.
1084
1085         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1086         https://bugs.webkit.org/show_bug.cgi?id=57087
1087
1088         Use explicit conversion for string to avoid depending on the default codec
1089         installed by the user code.
1090
1091         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1092         (WTR::activateFonts):
1093
1094 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
1095
1096         Revert inadvertantly committed changes.
1097
1098         * Scripts/old-run-webkit-tests:
1099         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1100
1101 2011-03-26  Andreas Kling  <kling@webkit.org>
1102
1103         Reviewed by Kenneth Rohde Christiansen.
1104
1105         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
1106         https://bugs.webkit.org/show_bug.cgi?id=57162
1107
1108         * QtTestBrowser/QtTestBrowser.qrc:
1109         * QtTestBrowser/favicon.png: Added.
1110         * QtTestBrowser/locationedit.cpp:
1111         (defaultPageIcon):
1112         (LocationEdit::LocationEdit):
1113         (LocationEdit::setPageIcon):
1114         (LocationEdit::resizeEvent):
1115         (LocationEdit::updateInternalGeometry):
1116         * QtTestBrowser/locationedit.h:
1117         * QtTestBrowser/mainwindow.cpp:
1118         (MainWindow::buildUI):
1119         (MainWindow::onIconChanged):
1120         (MainWindow::onLoadStarted):
1121         * QtTestBrowser/mainwindow.h:
1122
1123 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
1124
1125         Reviewed by Xan Lopez.
1126
1127         [GTK] Force DumpRenderTree to use 96 DPI
1128         https://bugs.webkit.org/show_bug.cgi?id=56866
1129
1130         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
1131         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
1132
1133         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1134         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
1135         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
1136         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
1137
1138 2011-03-25  Andy Estes  <aestes@apple.com>
1139
1140         Reviewed by Adele Peterson.
1141
1142         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1143         https://bugs.webkit.org/show_bug.cgi?id=49016
1144
1145         TestNetscapePlugIn needs to register support for an image MIME type so
1146         we can test that the embed tag prefers plug-ins to render image MIME
1147         types.
1148
1149         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
1150         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1151         (NP_GetMIMEDescription): Ditto.
1152         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
1153
1154 2011-03-25  Jessie Berlin  <jberlin@apple.com>
1155
1156         Reviewed by Sam Weinig.
1157
1158         WebKit2: Need to be able to set and get the Cookie Storage Policy.
1159         https://bugs.webkit.org/show_bug.cgi?id=50780
1160
1161         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
1162
1163         The test is named "CookieManager" so that we can eventually exercise more of the
1164         CookieManager functionality in the test.
1165
1166         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
1167         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1168         Assert that the policy returned is equal to the policy set in
1169         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
1170         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1171         Set the policy to something different than the user's policy and get the policy again.
1172         (TestWebKitAPI::didFinishLoadForFrame):
1173         Get the user's policy so that it can be restored at the end of the test.
1174         (TestWebKitAPI::TEST):
1175         Load about:blank so that the Web Process gets instatiated (needed to get the
1176         CookieManager).
1177
1178         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1179         Add CookieManager.cpp.
1180
1181 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1182
1183         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
1184
1185         * wx/build/settings.py:
1186
1187 2011-03-24  Ilya Sherman  <isherman@chromium.org>
1188
1189         Reviewed by Adam Roben.
1190
1191         Implement layoutTestController.setAutoFilled in DRT on Windows
1192         https://bugs.webkit.org/show_bug.cgi?id=56828
1193
1194         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1195         (LayoutTestController::setAutofilled): Implemented.
1196
1197 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1198
1199         Unreviewed build correction.
1200
1201         Correct vsprops file for Debug variant of the CFLite build.
1202         Disable a CFNETWORK-specific test when building for CFLite.
1203
1204         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
1205         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1206
1207 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1208
1209         Reviewed by Adam Barth.
1210
1211         fix regressions introduced in 81908 - there were a couple of
1212         code paths that only fired under python 2.5 that I missed.
1213
1214         Also change a couple of 'python' references to sys.executable
1215         in order to handle runing test-webkitpy with a binary other than
1216         something called 'python'.
1217
1218         https://bugs.webkit.org/show_bug.cgi?id=57063
1219
1220         * Scripts/webkitpy/layout_tests/port/mac.py:
1221         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1222         * Scripts/webkitpy/test/cat.py:
1223         * Scripts/webkitpy/test/echo.py:
1224
1225 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1226
1227         Unreviewed build correction.
1228
1229         Add a stub implementation of the TestInvocation dumping logic.
1230         Update project files to reflect new file.
1231
1232         * WebKitTestRunner/cairo: Added.
1233         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1234         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1235         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1236
1237 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1238
1239         Reviewed by Tony Chang.
1240
1241         new-run-webkit-tests: clean up worker model defaults. This
1242         changes the default behavior to 'threads' instead of
1243         'old-threads', and clarifies that chromium-win-* and
1244         chromium-mac-leopard are exceptions.
1245
1246         https://bugs.webkit.org/show_bug.cgi?id=56971
1247
1248         * Scripts/webkitpy/layout_tests/port/base.py:
1249         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1250         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1251         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1252         * Scripts/webkitpy/layout_tests/port/test.py:
1253         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1254
1255 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1256
1257         Reviewed by Darin Adler.
1258
1259         Media Stream API: fix the order of the options in build-webkit.
1260         https://bugs.webkit.org/show_bug.cgi?id=56949
1261
1262         Fix the order of the options in build-webkit.
1263
1264         * Scripts/build-webkit:
1265
1266 2011-03-23  Adam Klein  <adamk@chromium.org>
1267
1268         Reviewed by Mihai Parparita.
1269
1270         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1271         https://bugs.webkit.org/show_bug.cgi?id=56884
1272
1273         This option will be utilized by Chromium's ui_tests to allow
1274         referencing js-test-resources from a layout test over HTTP.
1275
1276         * Scripts/new-run-webkit-httpd:
1277         Added --layout_tests_dir option.
1278         * Scripts/webkitpy/layout_tests/port/http_server.py:
1279         Plumbed through as layout_tests_dir param.
1280
1281 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1282
1283         Reviewed by Mihai Parparita.
1284
1285         new-run-webkit-tests: run tests in ascending alphabetical order per
1286         dir. This is a second attempt at the fix; the first attempt, in 
1287         r81597, broke the behavior on the old-inline and old-threads
1288         worker models.
1289
1290         https://bugs.webkit.org/show_bug.cgi?id=56760
1291
1292         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1293         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1294         * Scripts/webkitpy/layout_tests/port/test.py:
1295         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1296
1297 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1298
1299         Reviewed by Martin Robinson.
1300
1301         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1302         https://bugs.webkit.org/show_bug.cgi?id=56953
1303
1304         Print the string for the detail of 'property-change' signal.
1305
1306         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1307         (axObjectEventListener): Print the detail string.
1308
1309 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1310
1311         Reviewed by Pavel Feldman.
1312
1313         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1314         https://bugs.webkit.org/show_bug.cgi?id=56843
1315
1316         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1317         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1318
1319 2011-03-22  Eric Seidel  <eric@webkit.org>
1320
1321         Reviewed by Adam Barth.
1322
1323         Teach update-webkit about gyp
1324         https://bugs.webkit.org/show_bug.cgi?id=56881
1325
1326         This makes it possible for someone who builds from Xcode
1327         to just run update-webkit --gyp and have the project files
1328         generated after update automatically.
1329
1330         I also added a stand-alone "generate-project-files" script
1331         wrapping Source/gyp/configure.  This makes running gyp simpler
1332         since most people will not have gyp or Source/gyp in their path.
1333
1334         * Scripts/build-webkit:
1335         * Scripts/generate-project-files: Added.
1336         * Scripts/update-webkit:
1337
1338 2011-03-22  Anton D'Auria  <adauria@apple.com>
1339
1340         Reviewed by Alexey Proskuryakov.
1341
1342         Add +[WebApplicationCache getOriginsWithCache]
1343         https://bugs.webkit.org/show_bug.cgi?id=56722
1344
1345         * DumpRenderTree/LayoutTestController.cpp:
1346         (originsWithApplicationCacheCallback):
1347         (LayoutTestController::staticFunctions):
1348         * DumpRenderTree/LayoutTestController.h:
1349         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1350         (LayoutTestController::originsWithApplicationCache):
1351         * DumpRenderTree/chromium/LayoutTestController.h:
1352         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1353         (LayoutTestController::originsWithApplicationCache):
1354         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
1355         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
1356         (LayoutTestController::originsWithApplicationCache):
1357         (LayoutTestController::originsWithLocalStorage):
1358         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1359         (LayoutTestController::originsWithApplicationCache):
1360         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1361         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1362         (LayoutTestController::originsWithApplicationCache):
1363         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
1364         (LayoutTestController::originsWithApplicationCache):
1365
1366 2011-03-22  Eric Seidel  <eric@webkit.org>
1367
1368         Reviewed by Adam Barth.
1369
1370         Add support to build-webkit for building with gyp-generated project files
1371         https://bugs.webkit.org/show_bug.cgi?id=56877
1372
1373         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
1374         Eventually we'll want to support gyp-generated projects in a more general manner.
1375
1376         * Scripts/build-webkit:
1377
1378 2011-03-22  David Kilzer  <ddkilzer@apple.com>
1379
1380         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
1381
1382         Reviewed by Joseph Pecoraro.
1383
1384         * Scripts/build-webkit: Updated usage statement to include
1385         --dsym.
1386         * Scripts/webkitdirs.pm: Added $generateDsym variable.
1387         (generateDsym): Added. Call determineGenerateDsym() and
1388         return $generateDsym.
1389         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
1390         $generateDsym.
1391         (argumentsForXcode): Added.  Returns additional arguments for
1392         xcodebuild based on command-line switches.
1393         (XcodeOptions): Updated to include argumentsForXcode() in the
1394         array returned.
1395
1396 2011-03-22  Adam Roben  <aroben@apple.com>
1397
1398         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
1399
1400         These bots are consistently green again.
1401
1402         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
1403         core builders
1404
1405         Rubber-stamped by Antti Koivisto.
1406
1407         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1408         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
1409
1410         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1411         (BuildBotTest.test_builder_name_regexps): Updated expectations.
1412
1413 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1414
1415         Unreviewed, rolling out r81597.
1416         http://trac.webkit.org/changeset/81597
1417         https://bugs.webkit.org/show_bug.cgi?id=56801
1418
1419         Change results in lots of unexpected flaky on the dashboard.
1420         (Requested by pfeldman on #webkit).
1421
1422         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1423         * Scripts/webkitpy/layout_tests/port/test.py:
1424         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1425
1426 2011-03-21  Sam Weinig  <sam@webkit.org>
1427
1428         Fix failing tests on the WebKit2 bots.
1429
1430         * WebKitTestRunner/TestController.cpp:
1431         (WTR::TestController::resetStateToConsistentValues):
1432
1433 2011-03-21  Daniel Sievers  <sievers@google.com>
1434
1435         Reviewed by Simon Fraser.
1436
1437         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1438         https://bugs.webkit.org/show_bug.cgi?id=56139
1439
1440         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1441         (main):
1442         * DumpRenderTree/chromium/LayoutTestController.cpp:
1443         (LayoutTestController::LayoutTestController):
1444         (LayoutTestController::layerTreeAsText):
1445         * DumpRenderTree/chromium/LayoutTestController.h:
1446         (LayoutTestController::setShowDebugLayerTree):
1447         * DumpRenderTree/chromium/TestShell.cpp:
1448         (TestShell::runFileTest):
1449         (TestShell::dump):
1450         * DumpRenderTree/chromium/TestShell.h:
1451         (TestParams::TestParams):
1452
1453 2011-03-21  Adam Roben  <aroben@apple.com>
1454
1455         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
1456
1457         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1458         output as plain text
1459
1460         Reviewed by David Kilzer.
1461
1462         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1463         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
1464         to the master.
1465         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
1466         since we're running on the build master, not the slave. Instead, turn the raw source of
1467         actual.html which the build slave uploaded into an HTML log.
1468
1469 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
1470
1471         Reviewed by Mihai Parparita.
1472
1473         new-run-webkit-tests: run tests in ascending alphabetical order per dir
1474         https://bugs.webkit.org/show_bug.cgi?id=56760
1475
1476         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1477         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1478         * Scripts/webkitpy/layout_tests/port/test.py:
1479
1480 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
1481
1482         Reviewed by Steve Block.
1483
1484         Media Stream API patch 0: adding compilation guards.
1485         https://bugs.webkit.org/show_bug.cgi?id=56458
1486
1487         Adding options to enable the media stream API feature in Chromium.
1488
1489         * Scripts/build-webkit:
1490
1491 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
1492
1493         Reviewed by Laszlo Gombos.
1494
1495         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
1496         https://bugs.webkit.org/show_bug.cgi?id=56323
1497
1498         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
1499         "--stdout" or "--stderr" option.
1500
1501         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1502         (WebCore::DumpRenderTree::~DumpRenderTree):
1503         (WebCore::DumpRenderTree::processArgsLine):
1504         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1505         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1506         (WebCore::DumpRenderTree::setRedirectOutputFileName):
1507         (WebCore::DumpRenderTree::setRedirectErrorFileName):
1508         * DumpRenderTree/qt/main.cpp:
1509         (isOption):
1510         (takeOptionValue):
1511         (printUsage):
1512         (main):
1513
1514 2011-03-21  Adam Roben  <aroben@apple.com>
1515
1516         Fix exceptions on the buildbot due to my last change
1517
1518         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1519         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
1520
1521 2011-03-21  Adam Roben  <aroben@apple.com>
1522
1523         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
1524
1525         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1526         output as plain text
1527
1528         Reviewed by Darin Adler.
1529
1530         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1531         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
1532         logs.
1533         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
1534         the build master. This will correctly treat it as HTML.
1535
1536 2011-03-20  Bill Budge  <bbudge@chromium.org>
1537
1538         Reviewed by Adam Barth.
1539
1540         Rename ThreadSafeShared to ThreadSafeRefCounted
1541         https://bugs.webkit.org/show_bug.cgi?id=56714
1542
1543         No new tests. Exposes no new functionality.
1544
1545         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
1546         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
1547         * Scripts/do-webcore-rename:
1548
1549 2011-03-19  Anton D'Auria  <adauria@apple.com>
1550
1551         Reviewed by Dan Bernstein.
1552
1553         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
1554         https://bugs.webkit.org/show_bug.cgi?id=56719
1555
1556         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
1557         (LayoutTestController::clearApplicationCacheForOrigin):
1558
1559 2011-03-19  Anton D'Auria  <adauria@apple.com>
1560
1561         Reviewed by Alexey Proskuryakov.
1562
1563         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1564         https://bugs.webkit.org/show_bug.cgi?id=56415
1565
1566         * DumpRenderTree/LayoutTestController.cpp:
1567         (clearApplicationCacheForOriginCallback):
1568         (LayoutTestController::staticFunctions):
1569         * DumpRenderTree/LayoutTestController.h:
1570         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
1571         (LayoutTestController::LayoutTestController):
1572         (LayoutTestController::clearAllApplicationCaches):
1573         (LayoutTestController::clearApplicationCacheForOrigin): 
1574         * DumpRenderTree/chromium/LayoutTestController.h:
1575         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1576         (LayoutTestController::clearApplicationCacheForOrigin):
1577         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1578         (LayoutTestController::clearApplicationCacheForOrigin):
1579         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1580         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1581         (LayoutTestController::clearApplicationCacheForOrigin):
1582         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1583         (LayoutTestController::clearApplicationCacheForOrigin):
1584
1585 2011-03-18  Dan Bernstein  <mitz@apple.com>
1586
1587         Revised build fix for r81135.
1588
1589         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1590         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1591
1592 2011-03-18  Adam Roben  <aroben@apple.com>
1593
1594         Windows build fix
1595
1596         * WebKitTestRunner/config.h: Add a missing #endif.
1597
1598 2011-03-18  Andreas Kling  <kling@webkit.org>
1599
1600         Unbreak Qt build after r81494.
1601
1602         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1603         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1604
1605 2011-03-18  Sam Weinig  <sam@webkit.org>
1606
1607         Fix windows build. This was really Adam Roben's fault. I swear!
1608
1609         * WebKitTestRunner/config.h:
1610
1611 2011-03-18  Sam Weinig  <sam@webkit.org>
1612
1613         Reviewed by Adam Roben.
1614
1615         Pixel tests don't work in WebKitTestRunner on Windows
1616         https://bugs.webkit.org/show_bug.cgi?id=56630
1617
1618         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1619         built-in snapshotting instead of using the window server on the Mac.
1620
1621         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1622         (WTR::InjectedBundle::InjectedBundle):
1623         (WTR::InjectedBundle::didReceiveMessage):
1624         (WTR::InjectedBundle::beginTesting):
1625         (WTR::InjectedBundle::done):
1626         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1627         (WTR::InjectedBundle::setPixelResult):
1628         (WTR::InjectedBundle::shouldDumpPixels):
1629         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1630         (WTR::InjectedBundlePage::dump):
1631         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1632
1633         * WebKitTestRunner/TestInvocation.cpp:
1634         (WTR::TestInvocation::invoke):
1635         (WTR::TestInvocation::dump):
1636         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1637         * WebKitTestRunner/TestInvocation.h:
1638         * WebKitTestRunner/cg: Added.
1639         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1640         (WTR::createCGContextFromImage):
1641         (WTR::computeMD5HashStringForContext):
1642         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1643         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1644         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1645
1646         * WebKitTestRunner/win/TestInvocationWin.cpp:
1647         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1648         Keep stub for Cairo build.
1649
1650         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1651         Add CG configuration.
1652
1653         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1654         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1655         Add new files.
1656
1657 2011-03-18  Adam Roben  <aroben@apple.com>
1658
1659         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1660
1661         Rubber-stamped by Simon Fraser.
1662
1663         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1664         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1665         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1666
1667 2011-03-18  Adam Roben  <aroben@apple.com>
1668
1669         Don't ellipsize long or indented function names in Leaks Viewer
1670
1671         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1672         scrollbar
1673
1674         Reviewed by Simon Fraser.
1675
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1677         (.data-grid .data-container):
1678         (.data-grid td > div, .data-grid th > div):
1679         Allow the contents to extend to the right.
1680
1681 2011-03-18  Adam Roben  <aroben@apple.com>
1682
1683         Fix some leaks in DRT seen on the leaks bot
1684
1685         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1686         setWillSendRequestClearHeaderCallback in DRT are leaky
1687
1688         Reviewed by Alexey Proskuryakov.
1689
1690         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1691
1692         * DumpRenderTree/LayoutTestController.cpp:
1693         (addURLToRedirectCallback):
1694         (setWillSendRequestClearHeaderCallback):
1695         Use OwnArrayPtr to cause the strings to be deleted.
1696
1697 2011-03-18  Adam Roben  <aroben@apple.com>
1698
1699         Fix a NSURLCredential leak seen on the leaks bot
1700
1701         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1702         connection:didReceiveAuthenticationChallenge:] is leaky
1703
1704         Reviewed by John Sullivan.
1705
1706         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1707         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1708         cause the NSURLCredential to be released.
1709
1710 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1711
1712         Unreviewed.
1713
1714         Remove unnecessary brackets around my email address.
1715
1716         * Scripts/webkitpy/common/config/committers.py:
1717
1718 2011-03-18  Adam Roben  <aroben@apple.com>
1719         
1720         Remove some files I accidentally added in r81454
1721
1722         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1723         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1724
1725 2011-03-18  Adam Roben  <aroben@apple.com>
1726
1727         Ignore an NSNumberFormatter leak on SnowLeopard
1728
1729         * Scripts/old-run-webkit-tests:
1730         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1731         getObjectValue:forString:errorDescription:].
1732
1733 2011-03-18  Adam Roben  <aroben@apple.com>
1734
1735         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1736
1737         Rubber-stamped by Mark Rowe.
1738
1739         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1740         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1741         released.
1742
1743 2011-03-17  Adam Roben  <aroben@apple.com>
1744
1745         Address a review comment I missed in r81445
1746
1747         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1748         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1749         leaked bytes to speed up searching on long lines.
1750
1751 2011-03-17  Adam Roben  <aroben@apple.com>
1752
1753         Mark leaky builds orange, even if all regression tests passed
1754
1755         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1756         build.webkit.org when all tests pass even though there are still leaks
1757
1758         Reviewed by Dan Bernstein.
1759
1760         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1761         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1762         be marked orange if this build step generates warnings.
1763
1764 2011-03-17  Adam Roben  <aroben@apple.com>
1765
1766         Allow values in Leaks Viewer to be shown as percentages
1767
1768         Double-clicking on a column will toggle between showing percentages and showing real values.
1769
1770         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1771         number of leaked bytes in Leaks Viewer
1772
1773         Reviewed by Joe Pecoraro.
1774
1775         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1776         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
1777         node's totalTime, which is used in calculating percentages.
1778
1779         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1780         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
1781         showing them as percentages.
1782
1783 2011-03-17  Adam Roben  <aroben@apple.com>
1784
1785         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
1786
1787         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
1788         the number of leaked allocations. And the new Average column shows the average number of
1789         leaked bytes per call.
1790
1791         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
1792         just how many allocations
1793
1794         Reviewed by Joe Pecoraro.
1795
1796         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1797         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
1798         line and store it with the leak stack.
1799         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
1800         properties.
1801         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
1802         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
1803         .numberOfCalls now holds the number of leaked allocations.
1804
1805         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1806         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
1807         appear.
1808         (monkeyPatchInspectorObjects): Format the values as bytes.
1809
1810 2011-03-17  Adam Roben  <aroben@apple.com>
1811
1812         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
1813
1814         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
1815         regression tests
1816
1817         Reviewed by James Robinson.
1818
1819         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1820         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
1821         is always populated, even when all regression tests pass.
1822
1823 2011-03-10  Hayato Ito  <hayato@chromium.org>
1824
1825         Reviewed by Tony Chang.
1826
1827         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
1828
1829         https://bugs.webkit.org/show_bug.cgi?id=56076
1830
1831         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1832
1833 2011-03-17  Adam Roben  <aroben@apple.com>
1834
1835         Skip a compositing-sensitive test when accelerated compositing is disabled
1836
1837         Reviewed by Sam Weinig.
1838
1839         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
1840         accelerated compositing is disabled.
1841
1842 2011-03-17  Adam Roben  <aroben@apple.com>
1843
1844         Start using PlatformSpecificScheduler for the Mac builders
1845
1846         The current set of file/directory patterns should work for Mac builders. We may discover
1847         that there are more files and directories we can exclude from the Mac builds, but they can
1848         be added later.
1849
1850         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
1851
1852         Reviewed by Mark Rowe.
1853
1854         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
1855         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
1856
1857         * Scripts/webkitpy/common/config/build.py:
1858         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
1859         cleaned up patterns a little bit.
1860
1861         * Scripts/webkitpy/common/config/build_unittest.py:
1862         (ShouldBuildTest): Fixed some expected results.
1863         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
1864         platforms.
1865
1866 2011-03-17  Jeff Miller  <jeffm@apple.com>
1867
1868         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
1869         
1870         *.mode*
1871         *.pbxuser
1872         *.perspective*
1873         project.xcworkspace
1874         xcuserdata
1875
1876         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1877         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1878         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1879         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1880         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1881
1882 2011-03-17  Adam Roben  <aroben@apple.com>
1883
1884         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
1885
1886         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
1887         mac-wk2
1888
1889         Reviewed by Anders Carlsson.
1890
1891         * Scripts/old-run-webkit-tests:
1892         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
1893         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
1894         we're running in WebKit2 mode.
1895
1896 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
1897
1898         Reviewed by Yury Semikhatsky.
1899
1900         Web Inspector: Clean up Inspector strings.
1901         https://bugs.webkit.org/show_bug.cgi?id=56557
1902
1903         Modify the script to deal correctly with "\xNN" escapes, and to
1904         check strings in Chromium's DevTools.js.
1905
1906         * Scripts/check-inspector-strings:
1907
1908 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
1909
1910         Reviewed by Benjamin Poulain.
1911
1912         Update autoinstall to install mechanize 0.2.4
1913         https://bugs.webkit.org/show_bug.cgi?id=56499
1914
1915         Newer versions of mechanize support HTTPS proxies, which is necessary
1916         for people using webkit-patch behind firewalls.
1917
1918         * Scripts/webkitpy/common/system/autoinstall.py:
1919         * Scripts/webkitpy/thirdparty/__init__.py:
1920
1921 2011-03-16  Sam Weinig  <sam@webkit.org>
1922
1923         Reviewed by Adam Roben.
1924
1925         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
1926         https://bugs.webkit.org/show_bug.cgi?id=56541
1927
1928         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1929         (WTR::InjectedBundlePage::willSendRequestForFrame):
1930         Check for an empty host in addition to a null host.  This bug was introduced
1931         when porting off of the KURL code and onto the WKURLRef version.
1932
1933 2011-03-16  Sam Weinig  <sam@webkit.org>
1934
1935         Reviewed by Adam Roben.
1936
1937         Add Lucas Forschler to the list of WebKit committers.
1938
1939         * Scripts/webkitpy/common/config/committers.py:
1940
1941 2011-03-16  Sam Weinig  <sam@webkit.org>
1942
1943         Reviewed upon and dictated through Adam Roben.
1944
1945         Escape crashing function names in results.html. This fixes an issue
1946         when a crash involves a type with templates.
1947
1948         * Scripts/old-run-webkit-tests:
1949
1950 2011-03-16  Daniel Sievers  <sievers@google.com>
1951
1952         Reviewed by James Robinson.
1953
1954         Add setting to always force compositing mode
1955         https://bugs.webkit.org/show_bug.cgi?id=56156
1956
1957         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1958         (main):
1959         * DumpRenderTree/chromium/TestShell.cpp:
1960         (TestShell::TestShell):
1961         (TestShell::resetWebSettings):
1962         * DumpRenderTree/chromium/TestShell.h:
1963         (TestShell::setForceCompositingMode):
1964         * DumpRenderTree/chromium/WebPreferences.cpp:
1965         (WebPreferences::reset):
1966         (WebPreferences::applyTo):
1967         * DumpRenderTree/chromium/WebPreferences.h:
1968
1969 2011-03-15  Hayato Ito  <hayato@chromium.org>
1970
1971         Reviewed by Ojan Vafai.
1972
1973         Ignore files that will be used by reftests in old-run-webkit-tests.
1974
1975         https://bugs.webkit.org/show_bug.cgi?id=55936
1976
1977         * Scripts/old-run-webkit-tests:
1978
1979 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1980
1981         Reviewed by Adam Roben.
1982
1983         Function relativeScriptsDir doesn't return the correct relative
1984         Scripts directory.
1985
1986         * Scripts/webkitdirs.pm:
1987         (relativeScriptsDir): Ensure we use the directory that contains
1988         webkitdirs.pm, not the one that contains the original script that
1989         was invoked.
1990
1991 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1992
1993         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1994         fix to link against the Security framework after recent WebKitSystemInterface changes.
1995
1996         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1997         (LayoutTestController::originsWithLocalStorage):
1998         * wx/build/settings.py:
1999         * wx/build/waf_extensions.py:
2000
2001 2011-03-15  Sam Weinig  <sam@webkit.org>
2002
2003         Reviewed by Darin Adler.
2004
2005         Add script to convert a patch to a prettypatch and show in the default browser
2006         https://bugs.webkit.org/show_bug.cgi?id=56416
2007
2008         This can be used either like
2009             $ svn-create-patch | show-pretty-diff
2010         or
2011             $ show-pretty-diff patch.diff
2012
2013         * Scripts/show-pretty-diff: Added.
2014
2015 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
2016
2017         Rubber-stamped by Adam Roben.
2018
2019         Adding myself as a reviewer.
2020
2021         * Scripts/webkitpy/common/config/committers.py:
2022
2023 2011-03-15  Anders Carlsson  <andersca@apple.com>
2024
2025         Try to fix the Windows build.
2026
2027         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2028         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2029
2030 2011-03-15  Anders Carlsson  <andersca@apple.com>
2031
2032         Reviewed by Sam Weinig.
2033
2034         Make sure that NP_Shutdown is always the last NPP function called
2035         https://bugs.webkit.org/show_bug.cgi?id=56391
2036
2037         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
2038
2039         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2040         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2041         (PluginTest::PluginTest):
2042         (PluginTest::NP_Shutdown):
2043         (PluginTest::registerNPShutdownFunction):
2044         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2045         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
2046         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
2047         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2048         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
2049         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
2050         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
2051         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
2052         (NPDeallocateCalledBeforeNPShutdown::shutdown):
2053         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2054         (NP_Shutdown):
2055         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2056         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2057         * GNUmakefile.am:
2058
2059 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2060
2061         Reviewed by Tony Chang.
2062
2063         Autofilled form elements are assigned fixed background color but not text color
2064         https://bugs.webkit.org/show_bug.cgi?id=48382
2065
2066         * DumpRenderTree/LayoutTestController.cpp:
2067         (setAutofilledCallback): Added.
2068         (LayoutTestController::staticFunctions):
2069         * DumpRenderTree/LayoutTestController.h:
2070         * DumpRenderTree/chromium/LayoutTestController.cpp:
2071         (LayoutTestController::LayoutTestController):
2072         (LayoutTestController::setAutofilled): Added.
2073         * DumpRenderTree/chromium/LayoutTestController.h:
2074         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2075         (LayoutTestController::setAutofilled): Added.
2076         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2077         (LayoutTestController::setAutofilled): Added.
2078         (LayoutTestController::setValueForUser): Style tweak.
2079         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2080         (LayoutTestController::setAutofilled): Added (stub).
2081         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2082         (LayoutTestController::setAutofilled): Added (stub).
2083
2084 2011-03-15  Dan Bernstein  <mitz@apple.com>
2085
2086         Build fix after r81135.
2087
2088         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2089
2090 2011-03-15  Dan Bernstein  <mitz@apple.com>
2091
2092         Build fix after r81135.
2093
2094         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2095         * WebKitTestRunner/mac/TestControllerMac.mm:
2096         * WebKitTestRunner/mac/TestInvocationMac.mm:
2097         * WebKitTestRunner/mac/main.mm:
2098
2099 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
2100
2101         Reviewed by Adam Barth.
2102
2103         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
2104         https://bugs.webkit.org/show_bug.cgi?id=56349
2105
2106         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
2107         on platforms where we use it. Copied from DumpRenderTree.pro.
2108
2109 2011-03-15  Dan Bernstein  <mitz@apple.com>
2110
2111         Build fix after r81135.
2112
2113         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2114         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2115
2116 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2117
2118         Reviewed by Darin Adler.
2119
2120         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2121         info into the headers rather than in export symbol definition files, but disable it on 
2122         all platforms initially so we can deal with port build issues one port at a time.
2123         
2124         https://bugs.webkit.org/show_bug.cgi?id=27551
2125
2126         * DumpRenderTree/cg/ImageDiffCG.cpp:
2127         * DumpRenderTree/chromium/config.h:
2128         * DumpRenderTree/config.h:
2129         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2130         * TestWebKitAPI/TestWebKitAPIPrefix.h:
2131         * WebKitAPITest/HostWindow.cpp:
2132         * WebKitAPITest/TestsController.cpp:
2133         * WebKitAPITest/config.h: Added.
2134         * WebKitAPITest/main.cpp:
2135         * WebKitAPITest/tests/WebViewDestruction.cpp:
2136         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2137         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2138         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2139         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2140         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2141         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2142         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2143         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2144         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2145         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2146         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2147         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2148         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2149         * WebKitTestRunner/TestController.cpp:
2150         * WebKitTestRunner/TestInvocation.cpp:
2151         * WebKitTestRunner/config.h: Added.
2152         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2153         * WebKitTestRunner/qt/TestControllerQt.cpp:
2154         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2155         * WebKitTestRunner/qt/main.cpp:
2156         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2157         * WebKitTestRunner/win/TestControllerWin.cpp:
2158         * WebKitTestRunner/win/TestInvocationWin.cpp:
2159         * WebKitTestRunner/win/main.cpp:
2160         * wx/build/settings.py:
2161
2162 2011-03-15  Hayato Ito  <hayato@chromium.org>
2163
2164         Reviewed by Shinichiro Hamaji.
2165
2166         [NRWT] Add support for reftests to new-run-webkit-tests.
2167
2168         https://bugs.webkit.org/show_bug.cgi?id=55457
2169
2170         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2171         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2172         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2173         * Scripts/webkitpy/layout_tests/port/base.py:
2174         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2175         * Scripts/webkitpy/layout_tests/port/test.py:
2176         * Scripts/webkitpy/layout_tests/port/test_files.py:
2177         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2178
2179 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
2180
2181         Reviewed by Martin Robinson.
2182
2183         [GTK] Fix compilation warning after r80892
2184         https://bugs.webkit.org/show_bug.cgi?id=56302
2185
2186         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2187         (LayoutTestController::originsWithLocalStorage):
2188
2189 2011-03-15  Robert Hogan  <robert@webkit.org>
2190
2191         Reviewed by Adam Barth.
2192
2193         Document the qmakearg argument, and hint how to build webkit2 on Qt
2194         https://bugs.webkit.org/show_bug.cgi?id=56326
2195
2196         * Scripts/build-webkit: add --qmakearg to build-webkit --help
2197
2198 2011-03-15  Adam Roben  <aroben@apple.com>
2199
2200         Make Windows 7 Release (Tests) a core builder
2201
2202         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2203         give it a few more days of greenness first.
2204
2205         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2206
2207         Reviewed by Sam Weinig.
2208
2209         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2210         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2211
2212         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2213         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2214         Updated the core regexps to match the buildbot module. Updated the expected results to match
2215         the current set of core builders.
2216
2217 2011-03-14  Adam Roben  <aroben@apple.com>
2218
2219         Add forgotten file from r81116
2220
2221         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
2222
2223 2011-03-14  Sam Weinig  <sam@webkit.org>
2224
2225         Reviewed by Adam Roben.
2226
2227         about:blank fake responses don't get serialized when sent the UIProcess
2228         <rdar://problem/9108119>
2229         https://bugs.webkit.org/show_bug.cgi?id=56357
2230
2231         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2232         (TestWebKitAPI::decidePolicyForResponse):
2233         (TestWebKitAPI::TEST):
2234         Add test that loads of about:blank have a response with a MIMEType of text/html.
2235
2236         * TestWebKitAPI/PlatformUtilities.h:
2237         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2238         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2239         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2240         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2241         Add helper to get the MIMEType from a WKURLResponse.
2242
2243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2244         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2245         Add new files.
2246
2247 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2248
2249         Reviewed by Kenneth Rohde Christiansen.
2250
2251         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2252         https://bugs.webkit.org/show_bug.cgi?id=56006
2253
2254         * QtTestBrowser/launcherwindow.cpp:
2255         (LauncherWindow::initializeView):
2256         * QtTestBrowser/main.cpp:
2257         (LauncherApplication::handleUserOptions):
2258
2259 2011-03-14  James Kozianski  <koz@chromium.org>
2260
2261         Reviewed by Ojan Vafai.
2262
2263         Add method to make BuildBot return test outputs
2264         https://bugs.webkit.org/show_bug.cgi?id=54374
2265
2266         The Builder.latest_cached_build will be used by the new rebaseline
2267         script to determine the build to use baselines from.
2268
2269         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2270         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2271
2272 2011-03-14  Adam Roben  <aroben@apple.com>
2273
2274         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2275
2276         Reviewed by Sam Weinig.
2277
2278         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2279         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2280         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2281         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2282         ensure the web process is initialized, then ask the bundle to run the test and assert that
2283         it succeeded.
2284
2285         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2286         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2287         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2288         handle a given URL.
2289         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2290         URL type cannot be handled).
2291         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2292         result.
2293
2294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2295         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2296         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2297         Added new files to the project.
2298
2299 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2300
2301         Unreviewed, rolling out r81094.
2302         http://trac.webkit.org/changeset/81094
2303         https://bugs.webkit.org/show_bug.cgi?id=56355
2304
2305         Broke the chromium DRT related build. (Requested by dave_levin
2306         on #webkit).
2307
2308         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2309         (main):
2310         * DumpRenderTree/chromium/LayoutTestController.cpp:
2311         (LayoutTestController::LayoutTestController):
2312         (LayoutTestController::layerTreeAsText):
2313         * DumpRenderTree/chromium/LayoutTestController.h:
2314         * DumpRenderTree/chromium/TestShell.cpp:
2315         (TestShell::runFileTest):
2316         (TestShell::dump):
2317         * DumpRenderTree/chromium/TestShell.h:
2318         (TestParams::TestParams):
2319
2320 2011-03-14  Daniel Sievers  <sievers@google.com>
2321
2322         Reviewed by Simon Fraser.
2323
2324         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2325         https://bugs.webkit.org/show_bug.cgi?id=56139
2326
2327         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2328         (main):
2329         * DumpRenderTree/chromium/LayoutTestController.cpp:
2330         (LayoutTestController::LayoutTestController):
2331         (LayoutTestController::layerTreeAsText):
2332         * DumpRenderTree/chromium/LayoutTestController.h:
2333         (LayoutTestController::setShowDebugLayerTree):
2334         * DumpRenderTree/chromium/TestShell.cpp:
2335         (TestShell::runFileTest):
2336         (TestShell::dump):
2337         * DumpRenderTree/chromium/TestShell.h:
2338         (TestParams::TestParams):
2339
2340 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2341
2342         Reviewed by Adam Roben.
2343
2344         [Qt][WK2]Unbreak InjectedBundle on Qt
2345         https://bugs.webkit.org/show_bug.cgi?id=54109
2346
2347         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2348         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
2349         API's instead of KURL to analyze the URL.
2350         * WebKitTestRunner/StringFunctions.h:
2351         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
2352         in the WebKitTestRunner project.
2353         (WTR::toWK): Use adoptWK.
2354         (WTR::operator<<): Added helper for printing a WKURL.
2355         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
2356         against WebCore.
2357
2358 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2359
2360         Reviewed by Kenneth Rohde Christiansen.
2361
2362         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
2363         https://bugs.webkit.org/show_bug.cgi?id=56321
2364
2365         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
2366         to the list of exceptions for WebKit2 C API headers.
2367
2368 2011-03-14  Adam Roben  <aroben@apple.com>
2369
2370         Show the list of recent leaky builds in reverse chronological order
2371
2372         Previously they were being shown in a deterministic but surprising order based on
2373         lexicographically sorting the build offsets (-1, -10, -2, -3...).
2374
2375         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
2376
2377         Reviewed by Darin Adler.
2378
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2380         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
2381         callback.
2382
2383 2011-03-14  Adam Roben  <aroben@apple.com>
2384
2385         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
2386
2387         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
2388         analyze
2389
2390         Reviewed by David Kilzer and Joe Pecoraro.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2393         (#url-prompt): Made this a bit taller to make room for the list of builds.
2394
2395         (#recent-builds-loading-indicator):
2396         (#recent-builds-list):
2397         Added styles for the build list and loading indicator.
2398
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2400         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
2401         it. This will unescape it.
2402         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
2403         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
2404         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
2405         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
2406         prompt UI.
2407         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
2408         now also used when a recent build is clicked.
2409
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
2411         (RecentBuildsLoader): Store the callback.
2412         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
2413         builder. Find the revision number, leak count, and results URL for each one. Pass the
2414         resulting info to our callback.
2415
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2417         (range): Added this helper function to return an array containing the integers [0, n).
2418
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
2420         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
2421
2422 2011-03-14  Mark Rowe  <mrowe@apple.com>
2423
2424         Reviewed by Adam Roben.
2425
2426         Fix two memory leaks within LayoutTestController's storage support.
2427
2428         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2429         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
2430         by JSStringCreateWithCFString.
2431         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
2432         allocate.
2433
2434 2011-03-14  Mark Rowe  <mrowe@apple.com>
2435
2436         Reviewed by Oliver Hunt.
2437
2438         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
2439
2440         * DumpRenderTree/LayoutTestController.cpp:
2441         (LayoutTestController::staticFunctions): Remove duplicate entries.
2442
2443 2011-03-14  Alice Liu  <alice.liu@apple.com>
2444
2445         Reviewed by Dan Bernstein.
2446
2447         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
2448
2449         * DumpRenderTree/mac/PerlSupport/Makefile:
2450         Add whitespace when joining "-arch" with the architectures passed in as arguments.
2451
2452 2011-03-14  Daniel Bates  <dbates@rim.com>
2453
2454         https://bugs.webkit.org/show_bug.cgi?id=55438
2455         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
2456         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
2457
2458         * Scripts/build-webkit:
2459
2460 2011-03-14  Daniel Bates  <dbates@rim.com>
2461
2462         Reviewed by David Kilzer.
2463
2464         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
2465         https://bugs.webkit.org/show_bug.cgi?id=55438
2466
2467         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
2468         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
2469         CMake arguments for feature defines.
2470
2471         * Scripts/build-webkit:
2472           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
2473           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
2474           - Sorted forward declarations.
2475           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
2476             Modified call sites as needed.
2477         * Scripts/webkitdirs.pm:
2478           - Added cleanCMakeGeneratedProject() to clean a CMake build.
2479           - Added buildCMakeGeneratedProject() to build using generated build system.
2480           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
2481           - Added generateBuildSystemFromCMakeProject() to generate the build system from
2482             a CMake project.
2483           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
2484
2485 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
2486
2487         Reviewed by Steve Block.
2488
2489         Detach Geolocation from Frame when Page destroyed.
2490         https://bugs.webkit.org/show_bug.cgi?id=52877
2491
2492         Extend the layout test controller to expose the number of pending
2493         geolocation requests, so that we can test that the requests have
2494         been cancelled on page close.
2495
2496         * DumpRenderTree/LayoutTestController.cpp:
2497         (numberOfPendingGeolocationPermissionRequestsCallback):
2498         (LayoutTestController::staticFunctions):
2499         * DumpRenderTree/LayoutTestController.h:
2500         * DumpRenderTree/chromium/LayoutTestController.cpp:
2501         (LayoutTestController::LayoutTestController):
2502         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2503         * DumpRenderTree/chromium/LayoutTestController.h:
2504         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2505         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2506         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2507         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2508         * DumpRenderTree/mac/UIDelegate.h:
2509         * DumpRenderTree/mac/UIDelegate.mm:
2510         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2511         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2512         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2513         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2514         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2515         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2516         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2517         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2518
2519
2520 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2521
2522         Unreviewed. Modify my email address in committers.py.
2523
2524         * Scripts/webkitpy/common/config/committers.py:
2525
2526 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
2527
2528         Reviewed by Kenneth Rohde Christiansen.
2529
2530         [Qt] QtLauncher does not load the same set of fonts as the DRT
2531         https://bugs.webkit.org/show_bug.cgi?id=34959
2532
2533         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
2534         When this option is used the webkit fonts are loaded the same
2535         as they are in DumpRenderTree.  This option can be used on
2536         QtTestBrowser and run-launcher.  It can only be used
2537         on Linux systems with FcInit and is configured as such.
2538
2539         * QtTestBrowser/launcherwindow.h:
2540         (WindowOptions::WindowOptions):
2541         * QtTestBrowser/main.cpp:
2542         (initWebKitTestFonts):
2543         (launcherMain):
2544         (LauncherApplication::handleUserOptions):
2545
2546 2011-03-12  Dan Bernstein  <mitz@apple.com>
2547
2548         Reviewed by Mark Rowe.
2549
2550         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
2551         DumpRenderTree is being built for.
2552
2553         * DumpRenderTree/mac/PerlSupport/Makefile:
2554
2555 2011-03-12  Dan Bernstein  <mitz@apple.com>
2556
2557         Suggested by Mark Rowe.
2558
2559         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
2560         as they were before r80915.
2561
2562 2011-03-12  Anders Carlsson  <andersca@apple.com>
2563
2564         Reviewed by Sam Weinig.
2565
2566         Should be able to download a PDF to the Downloads folder
2567         https://bugs.webkit.org/show_bug.cgi?id=56256
2568
2569         * MiniBrowser/mac/BrowserWindowController.m:
2570         (-[BrowserWindowController awakeFromNib]):
2571         * WebKitTestRunner/TestController.cpp:
2572         (WTR::TestController::createOtherPage):
2573         (WTR::TestController::initialize):
2574         Update for API changes.
2575
2576 2011-03-11  Anton D'Auria  <adauria@apple.com>
2577
2578         Reviewed and landed by Brady Eidson.
2579
2580         https://bugs.webkit.org/show_bug.cgi?id=51878
2581         Add WebKit1 API to view and delete local storage
2582
2583         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2584
2585         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2586         * DumpRenderTree/LayoutTestController.cpp:
2587         (syncLocalStorageCallback):
2588         (observeStorageTrackerNotificationsCallback):
2589         (deleteAllLocalStorageCallback):
2590         (deleteLocalStorageForOriginCallback):
2591         (originsWithLocalStorageCallback):
2592         (LayoutTestController::staticFunctions):
2593         * DumpRenderTree/LayoutTestController.h:
2594         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2595         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2596         (-[StorageTrackerDelegate init]):
2597         (-[StorageTrackerDelegate logNotifications:controller:]):
2598         (-[StorageTrackerDelegate originModified:]):
2599         (-[StorageTrackerDelegate dealloc]):
2600         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2601         * DumpRenderTree/chromium/LayoutTestController.cpp:
2602         (LayoutTestController::LayoutTestController):
2603         (LayoutTestController::deleteAllLocalStorage):
2604         (LayoutTestController::originsWithLocalStorage):
2605         (LayoutTestController::deleteLocalStorageForOrigin):
2606         (observeStorageTrackerNotifications):
2607         (syncLocalStorage):
2608         * DumpRenderTree/chromium/LayoutTestController.h:
2609         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2610         (LayoutTestController::originsWithLocalStorage):
2611         (LayoutTestController::deleteAllLocalStorage):
2612         (LayoutTestController::deleteLocalStorageForOrigin):
2613         (LayoutTestController::observeStorageTrackerNotifications):
2614         (LayoutTestController::syncLocalStorage):
2615         * DumpRenderTree/mac/DumpRenderTree.mm:
2616         (resetDefaultsToConsistentValues):
2617         (allocateGlobalControllers):
2618         (releaseGlobalControllers):
2619         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2620         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2621         (LayoutTestController::syncLocalStorage):
2622         (LayoutTestController::observeStorageTrackerNotifications):
2623         (LayoutTestController::deleteAllLocalStorage):
2624         (LayoutTestController::originsWithLocalStorage):
2625         (LayoutTestController::deleteLocalStorageForOrigin):
2626         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2627         (LayoutTestController::originsWithLocalStorage):
2628         (LayoutTestController::deleteAllLocalStorage):
2629         (LayoutTestController::deleteLocalStorageForOrigin):
2630         (LayoutTestController::observeStorageTrackerNotifications):
2631         (LayoutTestController::syncLocalStorage):
2632         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2633         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2634         (LayoutTestController::clearAllApplicationCaches):
2635         (LayoutTestController::syncLocalStorage):
2636         (LayoutTestController::observeStorageTrackerNotifications):
2637         (LayoutTestController::clearAllDatabases):
2638         (LayoutTestController::deleteAllLocalStorage):
2639         (LayoutTestController::originsWithLocalStorage):
2640         (LayoutTestController::deleteLocalStorageForOrigin):
2641         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2642         (LayoutTestController::syncLocalStorage):
2643         (LayoutTestController::observeStorageTrackerNotifications):
2644         (LayoutTestController::clearAllDatabases):
2645         (LayoutTestController::deleteAllLocalStorage):
2646         (LayoutTestController::originsWithLocalStorage):
2647         (LayoutTestController::deleteLocalStorageForOrigin):
2648
2649 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2650
2651         Reviewed by Adam Roben.
2652
2653         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2654         Process has finished launching.
2655         https://bugs.webkit.org/show_bug.cgi?id=56208
2656
2657         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2658         (TestWebKitAPI::TEST):
2659         Test that calling WKContextClearResourceCaches works with both options when called before
2660         the Web Process is valid.
2661
2662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2663         Add the new test.
2664         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2665         Ditto.
2666
2667 2011-03-11  Adam Roben  <aroben@apple.com>
2668
2669         Make it possible to view all leaks from a build at once in Leaks Viewer
2670
2671         You can now give Leaks Viewer the URL of a build results page (e.g.,
2672         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2673         will load all the leaks files from that build.
2674
2675         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2676         files from a particular build at once, rather than one at a time
2677
2678         Reviewed by David Kilzer.
2679
2680         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2681         (LeaksLoader): Initialize our properties.
2682         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2683         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2684         from that page.
2685         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2686         so it can provide feedback. Then load each one and pass it to the client.
2687         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2688         it into a DOM, pull out all the links to leaks files, and load each one.
2689
2690         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2691         (LeaksParser): Initialize our worker.
2692         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2693
2694         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2695         This code mostly came from Worker.js.
2696         (LeaksParserWorker): Initialize our profile.
2697         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2698         profile.
2699         (LeaksParserWorker.prototype._parseLeaks):
2700         (LeaksParserWorker.prototype._createNode):
2701         (LeaksParserWorker.prototype._incorporateLeaks):
2702         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2703         version of createProfile which adds to this.profile instead of making a new profile each
2704         time.
2705         (onmessage): Parse the file and send back the new profile.
2706
2707         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2708         (#loading-indicator):
2709         (#spinner):
2710         (#loading-indicator-label):
2711         Tweaked styles to accomodate a longer label.
2712
2713         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2714         (LeaksViewer.loaded): Set up a loader and parser.
2715
2716         (LeaksViewer.get filesLeftToParse):
2717         (LeaksViewer.set filesLeftToParse):
2718         Added these simple accessors.
2719
2720         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2721         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2722         the parser.
2723         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2724         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2725         _loadLeaksFromURL function).
2726         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2727         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2728         loading indicator, including the number of files being loaded.
2729         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2730         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2731         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2732         _loadingIndicatorText.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2735         (getResource): Moved here from LeaksViewer.js.
2736
2737         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2738         LeaksParserWorker.js.
2739
2740         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2741         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2742
2743 2011-03-11  Adam Roben  <aroben@apple.com>
2744
2745         Don't trigger a build when build.webkit.org's HTML files are modified
2746
2747         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2748
2749         Reviewed by Dan Bernstein.
2750
2751         * Scripts/webkitpy/common/config/build.py:
2752         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2753         directories that shouldn't trigger builds. Re-sorted the list.
2754
2755         * Scripts/webkitpy/common/config/build_unittest.py:
2756         (ShouldBuildTest): Added a test to cover the above change.
2757
2758 2011-03-11  Adam Roben  <aroben@apple.com>
2759
2760         Roll out r80848
2761
2762         It was accidentally committed.
2763
2764         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2765         (LeaksViewer._loadLeaksFromURL):
2766
2767 2011-03-11  Tony Chang  <tony@chromium.org>
2768
2769         Reviewed by Ojan Vafai.
2770
2771         kill hung lighttpd processes on the chromium win bot
2772         https://bugs.webkit.org/show_bug.cgi?id=56152
2773
2774         Sometimes this process doesn't exit and it holds on to
2775         a log file that we can't delete or copy, causing the tests
2776         to go red.
2777
2778         * BuildSlaveSupport/win/kill-old-processes:
2779
2780 2011-03-11  Ilya Sherman  <isherman@chromium.org>
2781
2782         Reviewed by Kent Tamura.
2783
2784         [Chromium] missing HTMLInputElement::setValueForUser() to tests
2785         https://bugs.webkit.org/show_bug.cgi?id=55854
2786
2787         * DumpRenderTree/chromium/LayoutTestController.cpp:
2788         (LayoutTestController::LayoutTestController):
2789         (LayoutTestController::setValueForUser): Added.
2790         * DumpRenderTree/chromium/LayoutTestController.h:
2791
2792 2011-03-10  Peter Kasting  <pkasting@google.com>
2793
2794         Reviewed by Dimitri Glazkov.
2795
2796         Clean up some gross code in TestShellWin.cpp.  No functional change.
2797         https://bugs.webkit.org/show_bug.cgi?id=56048
2798
2799         * DumpRenderTree/chromium/TestShellWin.cpp:
2800         (checkLayoutTestSystemDependencies):
2801
2802 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
2803
2804         Reviewed by Laszlo Gombos.
2805
2806         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
2807
2808         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2809         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
2810
2811 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2812
2813         Reviewed by Kenneth Rohde Christiansen.
2814
2815         [EFL] Make single backing store the default for EWebLauncher
2816         https://bugs.webkit.org/show_bug.cgi?id=55753
2817
2818         Set single backing store the default for EWebLauncher.
2819
2820         * EWebLauncher/main.c:
2821         (main):
2822
2823 2011-03-10  Adam Roben  <aroben@apple.com>
2824
2825         Ignore errors from files being held open when creating a test result archive
2826
2827         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
2828         fails to delete the results directory
2829
2830         Reviewed by Mark Rowe.
2831
2832         * BuildSlaveSupport/test-result-archive:
2833         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
2834         thrown when a process is holding a file open.
2835
2836 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2837
2838         Unreviewed, rolling out r80701.
2839         http://trac.webkit.org/changeset/80701
2840         https://bugs.webkit.org/show_bug.cgi?id=56126
2841
2842         fast/dom/Geolocation/window-close-crash.html fails on Snow
2843         Leopard release builds (Requested by mihaip on #webkit).
2844
2845         * DumpRenderTree/LayoutTestController.cpp:
2846         (LayoutTestController::staticFunctions):
2847         * DumpRenderTree/LayoutTestController.h:
2848         * DumpRenderTree/chromium/LayoutTestController.cpp:
2849         (LayoutTestController::LayoutTestController):
2850         * DumpRenderTree/chromium/LayoutTestController.h:
2851         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2852         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2853         * DumpRenderTree/mac/UIDelegate.h:
2854         * DumpRenderTree/mac/UIDelegate.mm:
2855         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2856         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2857         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2858         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2859
2860 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2861
2862         Reviewed by Gustavo Noronha Silva.
2863
2864         [GTK] run-gtk-tests doesn't fail if a test crashes
2865         https://bugs.webkit.org/show_bug.cgi?id=56089
2866
2867         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
2868         even if a test crashes. So run the tests individually and if a
2869         test fails remember its exit code so run-gtk-test fails too, if
2870         required.
2871
2872 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2873
2874         Reviewed by Dmitry Titov.
2875
2876         Detach Geolocation from Frame when Page destroyed.
2877         https://bugs.webkit.org/show_bug.cgi?id=52877
2878
2879         Extend the layout test controller to expose the number of pending
2880         geolocation requests, so that we can test that the requests have
2881         been cancelled on page close.
2882
2883         * DumpRenderTree/LayoutTestController.cpp:
2884         (numberOfPendingGeolocationPermissionRequestsCallback):
2885         (LayoutTestController::staticFunctions):
2886         * DumpRenderTree/LayoutTestController.h:
2887         * DumpRenderTree/chromium/LayoutTestController.cpp:
2888         (LayoutTestController::LayoutTestController):
2889         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2890         * DumpRenderTree/chromium/LayoutTestController.h:
2891         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2892         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2893         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2894         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2895         * DumpRenderTree/mac/UIDelegate.h:
2896         * DumpRenderTree/mac/UIDelegate.mm:
2897         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2898         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2899         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2900         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2901         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2902         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2903         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2904         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2905
2906
2907 2011-03-09  Adam Roben  <aroben@apple.com>
2908
2909         Hide Leaks Viewer's URL prompt by default
2910
2911         We will show it as needed. I think I left it visible by default by accident after doing some
2912         testing.
2913
2914         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
2915         URL is passed as a query parameter, but does
2916
2917         Reviewed by Simon Fraser.
2918
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2920
2921 2011-03-09  Adam Roben  <aroben@apple.com>
2922
2923         Don't use Element.classList or box-shadow in Leaks Viewer
2924
2925         They aren't supported by Safari 5. Luckily we have substitutes for them!
2926
2927         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
2928
2929         Reviewed by Simon Fraser.
2930
2931         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2932         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
2933
2934         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2935         (LeaksViewer.urlPromptButtonClicked):
2936         (LeaksViewer._displayURLPrompt):
2937         (LeaksViewer._setLoadingIndicatorHidden):
2938         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
2939
2940 2011-03-09  Adam Roben  <aroben@apple.com>
2941
2942         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
2943
2944         Rubber-stamped by David Kilzer.
2945
2946         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2947
2948 2011-03-09  Adam Roben  <aroben@apple.com>
2949
2950         Add a Leaks Viewer tool to build.webkit.org
2951
2952         This tool parses leaks from the files generated by the leaks bot and displays them in a
2953         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2954         code).
2955
2956         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2957         be passed to the tool via the "url" query parameter.
2958
2959         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2960         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2961         Inspector's Heavy profile view. But it's still pretty useful as-is.
2962
2963         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2964
2965         Reviewed by Darin Adler.
2966
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2968         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2969         (#url-prompt): This is the prompt itself.
2970
2971         (#loading-indicator):
2972         (#loading-indicator > img):
2973         These show a spinner in the bottom-right when we're loading a leaks file.
2974
2975         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2976         as percentages.
2977
2978         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2979         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2980         URL if one wasn't given to us as a query parameter).
2981
2982         (LeaksViewer.get loading):
2983         (LeaksViewer.set loading):
2984         (LeaksViewer.get url):
2985         (LeaksViewer.set url):
2986         Pretty simple accessors.
2987
2988         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2989         prompt.
2990         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2991         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2992         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2993         the profile to the Web Inspector code once it's been created.
2994         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2995         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2996         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2997         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2998
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
3000         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
3001         (ProfilerAgent.getProfile): Store the callback.
3002         (ProfilerAgent.profileReady): Call the callback.
3003         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
3004         count and total leak counts as real values, not percentages or milliseconds.
3005
3006         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
3007         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
3008         (parseLeaks): Extract call stacks out of a leaks file.
3009         (createNode): Helper function to create a new empty profile node.
3010         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
3011         WebInspector.ProfileView.
3012
3013         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
3014
3015 2011-03-09  Dan Bernstein  <mitz@apple.com>
3016
3017         Reviewed by Adam Roben.
3018
3019         Combine multiple --ignore-tests values
3020         https://bugs.webkit.org/show_bug.cgi?id=56016
3021
3022         * Scripts/old-run-webkit-tests:
3023
3024 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
3025
3026         Reviewed by David Levin.
3027
3028         Adding myself to the committer file.
3029
3030         * Scripts/webkitpy/common/config/committers.py:
3031
3032 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3033
3034         Rubber-stamped by Adam Roben.
3035
3036         Fix two leaks I introduced into the API tests.
3037
3038         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3039         (TestWebKitAPI::TEST):
3040
3041 2011-03-08  Jessie Berlin  <jberlin@apple.com>
3042
3043         Reviewed by Anders Carlsson.
3044
3045         Crash in CFNetwork visiting google.com
3046         https://bugs.webkit.org/show_bug.cgi?id=55958
3047
3048         Add a test for not trying to copy a null CFURLResponse.
3049
3050         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
3051         (TestWebKitAPI::TEST):
3052         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3053
3054 2011-03-08  Hayato Ito  <hayato@chromium.org>
3055
3056         Reviewed by Ojan Vafai.
3057
3058         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
3059
3060         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
3061
3062         https://bugs.webkit.org/show_bug.cgi?id=55450
3063
3064         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3065
3066 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3067
3068         Reviewed by Martin Robinson.
3069
3070         [GTK] Add layoutTestController.setValueForUser() after r80412
3071         https://bugs.webkit.org/show_bug.cgi?id=55862
3072
3073         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3074         (LayoutTestController::setValueForUser): Implement setValueForUser()
3075
3076 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
3077
3078         Reviewed by Adam Barth.
3079
3080         Add script_shell_command to WebKitPort
3081         https://bugs.webkit.org/show_bug.cgi?id=55925
3082
3083         Add a central place where we generate the shell command from the script name.
3084         This function will be used later to detect the correct script interpreter on Win32.
3085
3086         * Scripts/webkitpy/common/config/ports.py:
3087         * Scripts/webkitpy/layout_tests/port/base.py:
3088         * Scripts/webkitpy/tool/steps/abstractstep.py:
3089         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3090
3091 2011-03-07  Ojan Vafai  <ojan@chromium.org>
3092
3093         Reviewed by Adam Barth.
3094
3095         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
3096         https://bugs.webkit.org/show_bug.cgi?id=55749
3097
3098         * Scripts/webkitpy/tool/commands/upload.py:
3099         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3100         * Scripts/webkitpy/tool/steps/__init__.py:
3101         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
3102         * Scripts/webkitpy/tool/steps/options.py:
3103
3104 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
3105
3106         Reviewed by David Levin.
3107
3108         Add support for DataTransferItems
3109         https://bugs.webkit.org/show_bug.cgi?id=55115
3110
3111         Enable data transfer items in DRT.
3112
3113         * DumpRenderTree/chromium/TestShell.cpp:
3114         (TestShell::TestShell):
3115
3116 2011-03-06  Ojan Vafai  <ojan@chromium.org>
3117
3118         Reviewed by Tony Chang.
3119
3120         [test dashboard] pull treemap files
3121         https://bugs.webkit.org/show_bug.cgi?id=55852
3122
3123         * TestResultServer/handlers/dashboardhandler.py:
3124
3125 2011-03-03  Hayato Ito  <hayato@chromium.org>
3126
3127         Reviewed by Mihai Parparita.
3128
3129         [NRWT] Clear output image file used by DumpRenderTree to make sure the
3130         previous image should not be used in the ChromiumDriver.
3131
3132         Also make sure that output image from the ChromiumDriver should be ''
3133         (empty string) if a test crashes for consistency with the WebKitDriver
3134         implementation.
3135
3136         https://bugs.webkit.org/show_bug.cgi?id=55746
3137
3138         * Scripts/webkitpy/layout_tests/port/chromium.py:
3139
3140 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
3141
3142         Reviewed by Martin Robinson.
3143
3144         [Gtk] fast/js/navigator-language.html fails locally
3145         https://bugs.webkit.org/show_bug.cgi?id=55880
3146
3147         Add LANG variable to the clean environment when running
3148         old-run-webkit-tests script.
3149
3150         * Scripts/old-run-webkit-tests:
3151
3152 2011-03-07  Tony Chang  <tony@chromium.org>
3153
3154         Reviewed by Mihai Parparita.
3155
3156         [Chromium] Find .checksum files without .pngs and vice-versa
3157         https://bugs.webkit.org/show_bug.cgi?id=55236
3158
3159         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
3160             mismatched results.
3161
3162 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
3163
3164         Reviewed by Beth Dakin.
3165
3166         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
3167         https://bugs.webkit.org/show_bug.cgi?id=55706
3168
3169         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
3170
3171         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3172         (AccessibilityController::focusedElement):
3173            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
3174            because it could change at any time.
3175         (AccessibilityController::rootElement):
3176
3177 2011-03-07  Sam Weinig  <sam@webkit.org>
3178
3179         Reviewed by Anders Carlsson.
3180
3181         Add unableToImplementPolicy callback for WebKit2 policy client
3182         <rdar://problem/9071902>
3183         https://bugs.webkit.org/show_bug.cgi?id=55884
3184
3185         * MiniBrowser/mac/BrowserWindowController.m:
3186         (-[BrowserWindowController awakeFromNib]):
3187         Update policy client initialization struct for new member.
3188
3189 2011-03-07  Sam Weinig  <sam@webkit.org>
3190
3191         Reviewed by Anders Carlsson.
3192
3193         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
3194         https://bugs.webkit.org/show_bug.cgi?id=55827
3195
3196         * MiniBrowser/mac/BrowserWindowController.m:
3197         (decidePolicyForResponse):
3198         (-[BrowserWindowController awakeFromNib]):
3199         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3200         (TestWebKitAPI::decidePolicyForResponse):
3201         (TestWebKitAPI::TEST):
3202         Update tools for new name.
3203
3204 2011-03-06  Daniel Bates  <dbates@rim.com>
3205
3206         Reviewed by Eric Seidel and David Kilzer.
3207
3208         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
3209         https://bugs.webkit.org/show_bug.cgi?id=55503
3210
3211         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
3212         in checkForJavaSDK().
3213
3214         Also, remove extraneous space in function prototype for unlinkZeroFiles.
3215
3216         * Scripts/build-webkit:
3217
3218 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
3219
3220         Reviewed by Sam Weinig.
3221
3222         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
3223
3224         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3225         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
3226             by willSendRequestForFrame. The API expects a retained reference to the URL request.
3227
3228 2011-03-05  Ilya Sherman  <isherman@chromium.org>
3229
3230         Reviewed by Darin Adler.
3231
3232         HTMLInputElement::setValue() should schedule change event when the element is focused
3233         In service of https://code.google.com/p/chromium/issues/detail?id=42716
3234         https://bugs.webkit.org/show_bug.cgi?id=53160
3235
3236         * DumpRenderTree/LayoutTestController.cpp:
3237         (setValueForUserCallback):
3238         (LayoutTestController::staticFunctions):
3239         * DumpRenderTree/LayoutTestController.h:
3240         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3241         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3242         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3243         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
3244         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3245         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3246         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3247         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3248         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3249         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3250
3251 2011-03-04  Mark Rowe  <mrowe@apple.com>
3252
3253         Reviewed by Alexey Proskuryakov.
3254
3255         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
3256
3257         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
3258         
3259         * DumpRenderTree/mac/CheckedMalloc.cpp:
3260         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
3261         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
3262         and then restore the initial protection flags when we're done.
3263
3264 2011-03-04  Evan Martin  <evan@chromium.org>
3265
3266         Reviewed by Tony Chang.
3267
3268         [gdb] pretty-print KURL in gdb
3269         https://bugs.webkit.org/show_bug.cgi?id=55788
3270
3271         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
3272         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
3273         pretty-printing.
3274
3275 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3276
3277         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
3278
3279         Reviewed by Darin Adler.
3280
3281         * TestWebKitAPI/JavaScriptTest.cpp:
3282         (TestWebKitAPI::javaScriptCallback):
3283         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3284         (TestWebKitAPI::didRunJavaScript):
3285         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3286         (TestWebKitAPI::nullJavaScriptCallback):
3287         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3288         (TestWebKitAPI::didRunJavaScript):
3289
3290 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3291
3292         Make run-api-tests show failed if a test fails.
3293
3294         https://webkit.org/b/55725
3295
3296         Reviewed by Sam Weinig.
3297
3298         * Scripts/run-api-tests:
3299         (runTest): Remove "my" from the nested $result assignment so the
3300         check outside the condition sees the real result.
3301
3302 2011-03-02  MORITA Hajime  <morrita@google.com>
3303
3304         Reviewed by Kent Tamura.
3305
3306         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
3307         https://bugs.webkit.org/show_bug.cgi?id=55434
3308
3309         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
3310         and passed the object webkit_support::PostDelayedTask directly.
3311
3312         Note that the change keeps postTask() as is because it has a
3313         semantics taht webkit_support::PostDelayedTask() has; It jumps to
3314         the main thread.
3315
3316         * DumpRenderTree/chromium/Task.cpp:
3317         (postDelayedTask):
3318         * DumpRenderTree/chromium/Task.h:
3319         (WebTask::Run):
3320
3321 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3322
3323         Reviewed by Kenneth Rohde Christiansen.
3324
3325         [QT] Implement mock client-based geolocation for layout testing
3326         https://bugs.webkit.org/show_bug.cgi?id=54334
3327
3328         Implement testing for Client-Based geolocation for QtWebkit.
3329
3330         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3331         (WebCore::DumpRenderTree::DumpRenderTree):
3332         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3333         (LayoutTestController::reset):
3334         (LayoutTestController::setGeolocationPermission):
3335         (LayoutTestController::setMockGeolocationError):
3336         (LayoutTestController::setMockGeolocationPosition):
3337
3338 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3339
3340         Unreviewed, rolling out r80237.
3341         http://trac.webkit.org/changeset/80237
3342         https://bugs.webkit.org/show_bug.cgi?id=55714
3343
3344         Windows bots aren't ready to be core (Requested by aroben on
3345         #webkit).
3346
3347         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3348         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3349
3350 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3351
3352         Reviewed by Tony Chang.
3353
3354         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
3355         https://bugs.webkit.org/show_bug.cgi?id=55694
3356         
3357         Fixes for interruptions in NRWT:
3358         - Make TestRunInterruptedException be pickleable correctly (the base
3359           Exception class defines a __reduce__ that does not include the reason)
3360         - Fix ordering of returned arguments from TestRunner2._run_tests
3361           (interrupted and keyboard_interrupted were reversed)
3362         - Fix cancel_workers callsites (was using old name).
3363         - In handle_exception re-raise actual exception instance that was thrown
3364
3365         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3366         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3367         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3368         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3369
3370 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
3371
3372         Unreviewed.
3373
3374         Adding myself as a committer.
3375
3376         * Scripts/webkitpy/common/config/committers.py:
3377
3378 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
3379
3380         Reviewed by Mihai Parparita.
3381
3382         Teach sheriffbot to answer whois commands
3383         https://bugs.webkit.org/show_bug.cgi?id=55687
3384
3385         * Scripts/webkitpy/tool/bot/irc_command.py:
3386         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3387         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3388
3389 2011-03-03  Victoria Kirst  <vrk@google.com>
3390
3391         Reviewed by Eric Carlson.
3392
3393         Enable media tests in chromium-gpu/test_expectations
3394         https://bugs.webkit.org/show_bug.cgi?id=53608
3395
3396         Add media folder to the list of GPU test paths.
3397
3398         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3399
3400 2011-03-03  Adam Roben  <aroben@apple.com>
3401
3402         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
3403
3404         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
3405         incorrect parsing of absolute Windows-style file: URLs
3406
3407         Reviewed by Tim Hatcher.
3408
3409         * WebKitTestRunner/TestInvocation.cpp:
3410         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
3411         <http://webkit.org/b/55683>.
3412
3413 2011-03-03  Tony Chang  <tony@chromium.org>
3414
3415         Reviewed by Dimitri Glazkov.
3416
3417         [chromium] Run kill-old-processes on the chromium-win bot too
3418         https://bugs.webkit.org/show_bug.cgi?id=55630
3419
3420         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3421         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
3422
3423 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3424
3425         Reviewed by Martin Robinson.
3426
3427         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
3428         https://bugs.webkit.org/show_bug.cgi?id=53960
3429
3430         * DumpRenderTree/gtk/EventSender.cpp:
3431         (sendClick):
3432         (scheduleAsynchronousClickCallback):
3433
3434 2011-03-03  Adam Roben  <aroben@apple.com>
3435
3436         Look for Windows-style paths when checking whether a test is an Inspector test
3437
3438         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
3439         out or crash on Windows 7 Release (WebKit2 Tests)
3440
3441         Reviewed by Darin Adler.
3442
3443         * WebKitTestRunner/TestInvocation.cpp:
3444         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
3445         Windows.
3446
3447 2011-03-03  Adam Roben  <aroben@apple.com>
3448
3449         Make Windows 7 Release (Tests) a core builder
3450
3451         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3452         give it a few more days of greenness first.
3453
3454         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3455
3456         Reviewed by Andreas Kling.
3457
3458         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3459         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3460
3461         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3462         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3463         Updated the core regexps to match the buildbot module. Updated the expected results to match
3464         the current set of core builders.
3465
3466 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
3467
3468         Reviewed by Andreas Kling.
3469
3470         Adding myself as a reviewer.
3471
3472         * Scripts/webkitpy/common/config/committers.py:
3473
3474 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
3475
3476         Reviewed by Xan Lopez.
3477
3478         [GTK] Extended application cache database API and added unit tests file.
3479         https://bugs.webkit.org/show_bug.cgi?id=55335
3480
3481         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
3482         of webkit_application_cache_set_maximum_size due to API exposal.
3483
3484 2011-03-02  Ojan Vafai  <ojan@chromium.org>
3485
3486         Reviewed by Adam Barth.
3487
3488         make webkit-patch upload work for security bugs
3489         https://bugs.webkit.org/show_bug.cgi?id=55655
3490
3491         The problem is that we shell out to prepare-ChangeLog,
3492         which does not authenticate with bugzilla. All it needs from
3493         bugzilla is the bug title though. We just pass it through from
3494         webkit-patch instead.
3495
3496         * Scripts/prepare-ChangeLog:
3497         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3498         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3499
3500 2011-03-01  Ojan Vafai  <ojan@chromium.org>
3501
3502         Reviewed by Tony Chang.
3503
3504         [test-dashboard] make gtest JSON match layout-tests JSON
3505         https://bugs.webkit.org/show_bug.cgi?id=55556
3506
3507         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
3508         Make this code match.
3509
3510         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3511
3512 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
3513
3514         Reviewed by Tony Chang.
3515
3516         NRWT - implement Linux Hardy 64-bit port support. This involves
3517         adding support for non-'x86' architectures and updating the
3518         "deduplicate_tests" script to correctly understand that
3519         port.name() is not always equal to basename(port.baseline_path()).
3520
3521         This change introduces two new port names: 'chromium-linux-x86'
3522         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
3523         flag will cause the code to determine which one to use at
3524         runtime, just like we currently do with 'chromium-win'.
3525
3526         https://bugs.webkit.org/show_bug.cgi?id=55535
3527
3528         * Scripts/webkitpy/common/system/executive_mock.py:
3529           Handle 'return_stderr' keyword arg to run_command()
3530         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3531         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3532         * Scripts/webkitpy/layout_tests/port/base.py:
3533         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3534         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3535         * Scripts/webkitpy/layout_tests/port/factory.py:
3536         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3537
3538 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
3539
3540         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
3541         update symlinks accordingly.
3542
3543         * wx/packaging/build-mac-installer.py:
3544
3545 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3546
3547         Unreviewed, rolling out r80139.
3548         http://trac.webkit.org/changeset/80139
3549         https://bugs.webkit.org/show_bug.cgi?id=55620
3550
3551         failing and crashing tests on Snow Leopard bot (Requested by
3552         mihaip1 on #webkit).
3553
3554         * DumpRenderTree/LayoutTestController.cpp:
3555         (LayoutTestController::staticFunctions):
3556         * DumpRenderTree/LayoutTestController.h:
3557         * DumpRenderTree/chromium/LayoutTestController.cpp:
3558         (LayoutTestController::LayoutTestController):
3559         * DumpRenderTree/chromium/LayoutTestController.h:
3560         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3561         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3562         * DumpRenderTree/mac/UIDelegate.h:
3563         * DumpRenderTree/mac/UIDelegate.mm:
3564         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3565         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3566         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3567         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3568
3569 2011-03-02  Adam Roben  <aroben@apple.com>
3570
3571         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
3572
3573         This matches DumpRenderTree on Windows.
3574
3575         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
3576         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
3577         in WebKit2
3578
3579         Reviewed by Beth Dakin.
3580
3581         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3582         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
3583         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
3584
3585 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3586
3587         Reviewed by David Levin.
3588
3589         Add feature define for data transfer items
3590         https://bugs.webkit.org/show_bug.cgi?id=55510
3591
3592         * Scripts/build-webkit:
3593
3594 2011-03-02  Adam Roben  <aroben@apple.com>
3595
3596         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
3597
3598         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
3599         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
3600         the former location, but was getting lucky on some SnowLeopard machines because symlinks
3601         were being created there pointing into DiagnosticReports. For machines without these
3602         symlinks, crash logs were not getting captured.
3603
3604         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
3605         SnowLeopard machines
3606
3607         Reviewed by Eric Seidel.
3608
3609         * Scripts/old-run-webkit-tests:
3610         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
3611
3612 2011-03-02  Adam Roben  <aroben@apple.com>
3613
3614         Don't try to capture crash logs on platforms that haven't implemented that feature
3615
3616         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
3617         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
3618
3619         Reviewed by Joseph Pecoraro.
3620
3621         * Scripts/old-run-webkit-tests:
3622         (captureSavedCrashLog): Bail if we don't have a crash log glob.
3623         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
3624         strictly required to fix bug 55504, but seems worthwhile.
3625
3626 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3627
3628         Reviewed by Dmitry Titov.
3629
3630         Detach Geolocation from Frame when Page destroyed.
3631         https://bugs.webkit.org/show_bug.cgi?id=52877
3632
3633         Extend the layout test controller to expose the number of pending
3634         geolocation requests, so that we can test that the requests have
3635         been cancelled on page close.
3636
3637         * DumpRenderTree/LayoutTestController.cpp:
3638         (numberOfPendingGeolocationPermissionRequestsCallback):
3639         (LayoutTestController::staticFunctions):
3640         * DumpRenderTree/LayoutTestController.h:
3641         * DumpRenderTree/chromium/LayoutTestController.cpp:
3642         (LayoutTestController::LayoutTestController):
3643         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3644         * DumpRenderTree/chromium/LayoutTestController.h:
3645         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3646         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3647         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3648         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3649         * DumpRenderTree/mac/UIDelegate.h:
3650         * DumpRenderTree/mac/UIDelegate.mm:
3651         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3652         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3653         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3654         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3655         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3656         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3657         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3658         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3659
3660
3661 2011-03-01  Kent Tamura  <tkent@chromium.org>
3662
3663         Reviewed by Dimitri Glazkov.
3664
3665         Assertion fails when a form validation bubble appears
3666         https://bugs.webkit.org/show_bug.cgi?id=55550
3667
3668         Test: fast/forms/interactive-validation-attach-assertion.html
3669
3670         * DumpRenderTree/chromium/WebPreferences.cpp:
3671         (WebPreferences::applyTo): Enable the interactive validation feature by
3672           default. This matches to Chromium browser.
3673
3674 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3675
3676         Reviewed by Kent Tamura.
3677
3678         Remove efl port style exception of Webcore/JavaScriptCore
3679         https://bugs.webkit.org/show_bug.cgi?id=55549
3680
3681         WebCore and JavaScriptCore need to adhere WebKit coding style.
3682
3683         * Scripts/webkitpy/style/checker.py:
3684
3685 2011-03-01  Tony Chang  <tony@chromium.org>
3686
3687         Reviewed by Ojan Vafai.
3688
3689         [chromium] clean up temp files on chromium-mac builder too
3690         https://bugs.webkit.org/show_bug.cgi?id=55525
3691
3692         * BuildSlaveSupport/chromium/remove-crash-logs:
3693
3694 2011-02-28  Ojan Vafai  <ojan@chromium.org>
3695
3696         Reviewed by Tony Chang.
3697
3698         wrap json in a function call to afford cross-domain loading
3699         https://bugs.webkit.org/show_bug.cgi?id=55353
3700
3701         Also delete the code that compacts the JSON. It turns out this
3702         breaks the rebaseline tool and is probably a premature optimization anyways.
3703
3704         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3705         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3706         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3707         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3708
3709 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3710
3711         Unreviewed, rolling out r80079.
3712         http://trac.webkit.org/changeset/80079
3713         https://bugs.webkit.org/show_bug.cgi?id=55547
3714
3715         "Broke the Win debug build?" (Requested by dcheng on #webkit).
3716
3717         * Scripts/build-webkit:
3718
3719 2011-03-01  Mark Rowe  <mrowe@apple.com>
3720
3721         Reviewed by Sam Weinig.
3722
3723         Update verification scripts to handle WebKit2.
3724
3725         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
3726         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
3727         WebKit2.
3728
3729 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
3730
3731         Reviewed by David Levin.
3732
3733         Add feature define for data transfer items
3734         https://bugs.webkit.org/show_bug.cgi?id=55510
3735
3736         * Scripts/build-webkit:
3737
3738 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3739
3740         Reviewed by Timothy Hatcher.
3741
3742         All Console Messages should be passed to ChromeClients.
3743         https://bugs.webkit.org/show_bug.cgi?id=54926
3744
3745         Update DumpRenderTree's UIDelegate to use the new console message delegate.
3746
3747         * DumpRenderTree/mac/UIDelegate.mm:
3748         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3749
3750 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3751
3752         Reviewed by Adam Barth.
3753
3754         Tragically, we stopped running the python unit tests
3755         on Chromium Win just as I was getting them to be green.
3756         This patch turns them back on.
3757
3758         https://bugs.webkit.org/show_bug.cgi?id=55521
3759
3760         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3761
3762 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3763
3764         Reviewed by Adam Roben.
3765
3766         Disable
3767         webkitpy.common.system.executive_unittest.ExecutiveTest.\
3768            test_kill_all fails on win until it can be properly triaged.
3769
3770         https://bugs.webkit.org/show_bug.cgi?id=54790
3771
3772         * Scripts/webkitpy/common/system/executive_unittest.py:
3773
3774     2011-03-01  Helder Correia  <helder@sencha.com>
3775
3776             Unreviewed. Add myself to committers.py.
3777
3778             * Scripts/webkitpy/common/config/committers.py:
3779
3780 2011-03-01  Adam Roben  <aroben@apple.com>
3781
3782         Give up if a crash log for the web process is taking too long to be saved on Windows
3783
3784         This should keep the bots from getting stuck while waiting for a crash log, if writing a
3785         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
3786
3787         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
3788         to be saved for the web process
3789
3790         Reviewed by Steve Falkenburg.
3791
3792         * WebKitTestRunner/win/TestControllerWin.cpp:
3793         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
3794         Generalized the code slightly to handle the optional object to wait on.
3795         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
3796         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
3797         prevent us from waiting forever.
3798
3799 2011-03-01  Adam Roben  <aroben@apple.com>
3800
3801         Give WebKitLauncherWin's PDB file a name different from WebKit's
3802
3803         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
3804         fighting over the same PDB file, meaning that one of them was going to lose and not have
3805         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
3806
3807         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
3808         runs (due to missing symbols)
3809
3810         Reviewed by David Kilzer.
3811
3812         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
3813         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
3814
3815 2011-03-01  Adam Roben  <aroben@apple.com>
3816
3817         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
3818
3819         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
3820         --exit-after-n-crashes-or-timeouts limit
3821
3822         Reviewed by David Kilzer.
3823
3824         * Scripts/old-run-webkit-tests:
3825         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
3826         the number of tests that caused the web process to crash when exiting early.
3827
3828 2011-03-01  Adam Roben  <aroben@apple.com>
3829
3830         Save a crash log when the web process crashes
3831
3832         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
3833         until it has finished crashing, which guarantees that the crash log will have had time to be
3834         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
3835         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
3836
3837         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
3838         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
3839
3840         Reviewed by Sam Weinig.
3841
3842         * Scripts/old-run-webkit-tests:
3843         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
3844         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
3845         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
3846         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
3847         WebProces_*.crash files when the web process crashes.
3848
3849         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3850         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
3851         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
3852         along to platformInitialize.
3853
3854         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
3855
3856         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3857         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
3858
3859         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3860         (WTR::InjectedBundle::platformInitialize):
3861         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3862         (WTR::InjectedBundle::platformInitialize):
3863         Updated function signature.
3864
3865         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3866         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
3867         webProcessCrashingEvent, then lets the crash continue as normal.
3868
3869         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
3870         event we should use to tell the UI process we're crashing from the initializationUserData,
3871         and get a handle to that event.
3872
3873         * WebKitTestRunner/TestController.cpp:
3874         (WTR::TestController::TestController): Initialize new members.
3875         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
3876         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
3877         when a crash log is being saved on Windows. Exit right away if specified. (This is the
3878         default.)
3879
3880         * WebKitTestRunner/TestController.h: Added new members.
3881
3882         * WebKitTestRunner/win/TestControllerWin.cpp:
3883         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
3884         us it's crashing.
3885         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
3886         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
3887         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
3888         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
3889         so the test harness will know the web process has crashed and not try to kill us, then wait
3890         for the web process to finish crashing so a crash log will have time to be saved.
3891         (WTR::toWK): Simple hepler function.
3892         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
3893         process should use to tell us it is crashing in the context's initialization user data.
3894
3895 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
3896
3897         Reviewed by Tony Gentilcore.
3898
3899         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
3900         https://bugs.webkit.org/show_bug.cgi?id=55476
3901
3902         Chromium Win uses BuildAndTestFactory, not TestFactory.
3903
3904         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
3905
3906 2011-03-01  Adam Roben  <aroben@apple.com>
3907
3908         Test that the WebKit2 responsiveness timer doesn't fire too early
3909
3910         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
3911         early on Windows
3912
3913         Reviewed by Anders Carlsson.
3914
3915         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
3916
3917         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
3918         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3919         (TestWebKitAPI::didFinishLoadForFrame):
3920         (TestWebKitAPI::processDidBecomeUnresponsive):
3921         (TestWebKitAPI::setInjectedBundleClient):
3922         (TestWebKitAPI::setPageLoaderClient):
3923         Simple helper functions.
3924
3925         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
3926         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
3927         the responsiveness timer to start, but the web process should unpause before it has a chance
3928         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
3929
3930         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
3931         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
3932         Call up to the base class.
3933         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
3934         pause, sleep for 0.5 seconds, then send back a message saying we paused.
3935
3936         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3937         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
3938         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3939         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
3940
3941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3942         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3943         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3944         Added new files.
3945
3946 2011-03-01  Andras Becsi  <abecsi@webkit.org>
3947
3948         Reviewed by Csaba Osztrogonác.
3949
3950         [Qt] Clean up the project files and move common options to WebKit.pri.
3951
3952         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
3953
3954
3955 2011-03-01  Adam Roben  <aroben@apple.com>
3956
3957         Skip another multiprocessing test on Windows
3958
3959         It is sometimes failing (and may be leaving child Python processes around).
3960         <http://webkit.org/b/55087> tracks the failure.
3961
3962         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3963         (FuncitonTests.test_get__processes): Skip this test on Windows.
3964
3965 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
3966
3967         Reviewed by Pavel Feldman.
3968
3969         Web Inspector: reduce inspector tests flakiness.
3970         https://bugs.webkit.org/show_bug.cgi?id=55401
3971
3972         * DumpRenderTree/chromium/TestShell.cpp:
3973         (TestShell::runFileTest):
3974         * DumpRenderTree/chromium/WebPreferences.cpp:
3975         (WebPreferences::reset):
3976
3977 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
3978
3979         Reviewed by James Robinson.
3980
3981         NRWT should still upload results when it exits early due to too many failures
3982         https://bugs.webkit.org/show_bug.cgi?id=55432
3983         
3984         Only keyboard interrupts should prevent results from being uploaded.
3985
3986         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3987         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3988
3989 2011-02-28  Alice Liu  <alice.liu@apple.com>
3990
3991         Reviewed by Adam Roben and Gavin Barraclough.
3992
3993         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
3994         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
3995
3996         * TestWebKitAPI/InjectedBundleController.h:
3997         (TestWebKitAPI::InjectedBundleController::bundle):
3998         * TestWebKitAPI/PlatformWebView.h:
3999         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
4000         (TestWebKitAPI::didFinishLoadForFrame):
4001         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4002         (TestWebKitAPI::setPageLoaderClient):
4003         (TestWebKitAPI::TEST):
4004         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
4005         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
4006         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
4007         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
4008         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4009         (TestWebKitAPI::PlatformWebView::simulateRightClick):
4010         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4011         (TestWebKitAPI::PlatformWebView::simulateRightClick):
4012         
4013         Added files to:
4014         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4015         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4016         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
4017
4018 2011-02-28  Adam Roben  <aroben@apple.com>
4019
4020         Start running InjectedBundle API tests on Windows
4021
4022         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
4023
4024         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
4025
4026         Reviewed by Darin Adler.
4027
4028         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
4029         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
4030         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
4031         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
4032         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
4033         These are just extracted from TestWebKitAPI.vcproj.
4034
4035         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
4036         up the DLL's filename.
4037
4038         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
4039         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
4040         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
4041
4042         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
4043         "all" configuration.
4044
4045         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
4046         injected bundle tests. Let VS resort things.
4047
4048         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
4049
4050 2011-02-28  Adam Roben  <aroben@apple.com>
4051
4052         Add a test for the paint rect passed via WM_PAINT to windowless plugins
4053
4054         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
4055         Large portions of pages with plugins paint black
4056
4057         Reviewed by Anders Carlsson.
4058
4059         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4060         (PluginTest::NPP_HandleEvent):
4061         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
4062         Added NPP_HandleEvent. Just returns 0 at this level.
4063
4064         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
4065         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
4066         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
4067         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
4068         WM_PAINT has the expected coordinates.
4069
4070         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4071         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
4072         else.
4073
4074         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
4075         resort things.
4076
4077         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4078         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
4079         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
4080         webView:didFinishLoadForFrame:] in DumpRenderTree.
4081
4082         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4083         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
4084         can start running.
4085
4086 2011-02-28  Adam Roben  <aroben@apple.com>
4087
4088         Tell MiniBrowser's WKViews that they're in a window
4089
4090         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
4091
4092         Reviewed by Anders Carlsson.
4093
4094         * MiniBrowser/win/BrowserView.cpp:
4095         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
4096
4097 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
4098
4099         Reviewed by Csaba Osztrogonác.
4100
4101         The new QML tests require QML_IMPORT_PATH variable to be set in order to
4102         load the proper plugin.
4103
4104         * Scripts/run-qtwebkit-tests:
4105
4106 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
4107
4108         Unreviewed, fix spelling mistake.
4109
4110         hardware-accelated => hardware-accelerated.
4111
4112         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4113
4114 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
4115
4116         Reviewed by Andreas Kling.
4117
4118         Made sure that the build-webkit --qmake argument is always respected.
4119
4120         Previously, it would be respected during the build, but not during
4121         the early feature detection. The build would also fail if qmake was
4122         not in your path, even if you specified --qmake with a valid qmake
4123         binary.
4124
4125         [Qt] WebKit patches required to work with a modularized version of Qt
4126         https://bugs.webkit.org/show_bug.cgi?id=53916
4127
4128         * Scripts/build-webkit:
4129         * Scripts/webkitdirs.pm:
4130
4131 2011-02-27  Ojan Vafai  <ojan@chromium.org>
4132
4133         Fix failing tests from http://trac.webkit.org/changeset/79837.
4134
4135         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4136         This was just a mistake that would break if someone tried printing with this configuration.
4137         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4138         Method signature changed. Didn't notice that this method was being calling in a unittest.
4139
4140 2011-02-24  Hayato Ito  <hayato@chromium.org>
4141
4142         Reviewed by Eric Seidel.
4143
4144         [NRWT] Remove test_types/* classes.
4145
4146         This is the last patch in the series of efforts which tried to remove test_types classes.
4147         A single_test_runner module will take over responsibilities of test_type classes.
4148
4149         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
4150
4151         https://bugs.webkit.org/show_bug.cgi?id=55123
4152
4153         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
4154         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
4155         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
4156         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
4157         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
4158         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
4159         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
4160         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
4161         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
4162         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
4163
4164 2011-02-25  Ojan Vafai  <ojan@chromium.org>
4165
4166         Reviewed by Tony Chang.
4167
4168         Change results.json format to the one used by unexpected_results.json
4169         https://bugs.webkit.org/show_bug.cgi?id=52267
4170
4171         Also add runtimes in milliseconds to the JSON and make the output format more compact.
4172         Named the file full_results.json to avoid conflicting with the results.json
4173         file the test-results server currently serves up.
4174
4175         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
4176         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4177         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4178         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4179         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
4180         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
4181
4182 2011-02-27  Adam Roben  <aroben@apple.com>
4183
4184         Followup fix to r79827
4185
4186         * DumpRenderTree/win/UIDelegate.cpp:
4187         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
4188         lastPathComponent. This matches what we did here before r79827, and matches Mac.
4189
4190 2011-02-27  Dan Bernstein  <mitz@apple.com>
4191
4192         Reviewed by Adam Roben.
4193
4194         Make bisect-builds print a trac link for the regression range
4195         https://bugs.webkit.org/show_bug.cgi?id=55331
4196
4197         * Scripts/bisect-builds:
4198
4199 2011-02-27  Adam Roben  <aroben@apple.com>
4200
4201         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
4202
4203         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
4204         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
4205         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
4206
4207         Reviewed by Anders Carlsson.
4208
4209         * DumpRenderTree/win/EditingDelegate.cpp:
4210         (indexOfFirstWordCharacter):
4211         (wordLength):
4212         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
4213
4214 2011-02-27  Adam Roben  <aroben@apple.com>
4215
4216         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
4217
4218         This matches Mac. (In fact, the code was ported from Mac!)
4219
4220         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
4221         match Mac
4222
4223         Reviewed by Anders Carlsson.
4224
4225         * DumpRenderTree/win/DumpRenderTree.cpp:
4226         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
4227         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
4228         _drt_descriptionSuitableForTestResult].
4229         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
4230
4231         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
4232
4233         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
4234         DumpRenderTree.cpp.
4235
4236 2011-02-27  Adam Roben  <aroben@apple.com>
4237
4238         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
4239
4240         This makes Bugzilla autocompletion work correctly.
4241
4242         * Scripts/webkitpy/common/config/committers.py:
4243
4244 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
4245
4246         Reviewed by Andreas Kling.
4247
4248         [Qt] fast/loader/user-stylesheet-fast-path.html fails
4249         https://bugs.webkit.org/show_bug.cgi?id=50911
4250
4251         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4252         (LayoutTestController::setUserStyleSheetLocation):
4253         Use QUrl::fromEncoded since the passed string is already encoded.
4254
4255 2011-02-27  Adam Roben  <aroben@apple.com>
4256
4257         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
4258
4259         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
4260         is different from old-run-webkit-test's. Because of this, the path to the crash log file
4261         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
4262         details.
4263
4264         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
4265         --results-directory path is used (like on the test slaves)
4266
4267         Reviewed by Dan Bernstein.
4268
4269         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
4270         made $testResultsDirectory an absolute path.
4271
4272 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
4273
4274         Reviewed by Adam Barth.
4275
4276         m_dumpAccessibilityNotifications should be initialized.
4277         https://bugs.webkit.org/show_bug.cgi?id=54874
4278
4279         * DumpRenderTree/chromium/AccessibilityController.cpp:
4280         (AccessibilityController::AccessibilityController):
4281
4282 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
4283
4284         Reviewed by Pavel Feldman.
4285
4286         DumpRenderTree should reset frame opener between tests.
4287         https://bugs.webkit.org/show_bug.cgi?id=54874
4288
4289         Added clearOpener() calls between tests.
4290         Some tests are using window.open() to change current window location.
4291         This changes window.opener property whose nullity is checked before
4292         showing xml viewer.
4293
4294         * DumpRenderTree/chromium/TestShell.cpp:
4295         (TestShell::resetTestController):
4296         * DumpRenderTree/gtk/DumpRenderTree.cpp: