Rename WebKitTools to Tools
[WebKit-https.git] / Tools / ChangeLog
1 2010-12-17  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Simon Fraser.
4
5         Rename WebKitTools to Tools
6         https://bugs.webkit.org/show_bug.cgi?id=49861
7
8         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9         * CodeCoverage/README:
10         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
11         (WebCore::DumpRenderTree::initializeFonts):
12         * EWSTools/start-commit-queue.sh:
13         * EWSTools/start-queue.sh:
14         * GNUmakefile.am:
15         * MIDLWrapper/MIDLWrapper.cpp:
16         (wmain):
17         * MiniBrowser/qt/MiniBrowser.pro:
18         * Scripts/build-api-tests:
19         * Scripts/build-dumprendertree:
20         * Scripts/build-webkit:
21         * Scripts/build-webkittestrunner:
22         * Scripts/generate-coverage-data:
23         * Scripts/old-run-webkit-tests:
24         * Scripts/run-api-tests:
25         * Scripts/run-iexploder-tests:
26         * Scripts/run-javascriptcore-tests:
27         * Scripts/run-mangleme-tests:
28         * Scripts/run-sunspider:
29         * Scripts/run-webkit-websocketserver:
30         * Scripts/sunspider-compare-results:
31         * Scripts/test-webkitperl:
32         * Scripts/test-webkitpy:
33         * Scripts/update-iexploder-cssproperties:
34         * Scripts/update-webkit:
35         * Scripts/update-webkit-localizable-strings:
36         * Scripts/webkitdirs.pm:
37         * Scripts/webkitpy/common/checkout/scm.py:
38         * Scripts/webkitpy/common/checkout/scm_unittest.py:
39         * Scripts/webkitpy/common/config/committervalidator.py:
40         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
41         * Scripts/webkitpy/common/config/ports.py:
42         * Scripts/webkitpy/common/config/ports_unittest.py:
43         * Scripts/webkitpy/common/system/logutils_unittest.py:
44         * Scripts/webkitpy/common/system/ospath_unittest.py:
45         * Scripts/webkitpy/layout_tests/port/chromium.py:
46         * Scripts/webkitpy/layout_tests/port/config.py:
47         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
48         * Scripts/webkitpy/layout_tests/port/http_server.py:
49         * Scripts/webkitpy/layout_tests/port/test.py:
50         * Scripts/webkitpy/style/checker.py:
51         * Scripts/webkitpy/style/checker_unittest.py:
52         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
53         * Scripts/webkitpy/tool/commands/queues_unittest.py:
54         * Scripts/webkitpy/tool/steps/steps_unittest.py:
55         * WebKitTestRunner/DerivedSources.pro:
56         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
57         (WTR::activateFonts):
58         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
59         * wx/build/build_utils.py:
60
61 2010-12-16  Antonio Gomes  <agomes@rim.com>
62
63         Reviewed by Martin Robinson.
64
65         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
66         https://bugs.webkit.org/show_bug.cgi?id=51163
67
68         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
69         GTK+'s DRT should also reset to UNIX after each test execution.
70
71         * DumpRenderTree/gtk/DumpRenderTree.cpp:
72         (resetDefaultsToConsistentValues):
73
74 2010-12-17  David Levin  <levin@chromium.org>
75
76         Reviewed by Eric Seidel.
77
78         check-webkit-style should understand WTF #include guards
79         https://bugs.webkit.org/show_bug.cgi?id=44911
80
81         * Scripts/webkitpy/style/checkers/cpp.py:
82         (get_header_guard_cpp_variable): modify to suggest the WTF style
83         of header guard when appropriate.
84         (check_for_header_guard): handle multiple return values from
85         get_header_guard_cpp_variable
86         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
87         (CppStyleTest.test_build_header_guard): Added tests for the WTF
88         header style.
89
90 2010-12-16  David Levin  <levin@chromium.org>
91
92         Reviewed by Eric Seidel.
93
94         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
95         https://bugs.webkit.org/show_bug.cgi?id=51210
96
97         The error only shows up when using python 2.6 or later.
98
99         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
100         the decprecated field error,message with something equivalent.
101
102 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
103
104         Reviewed by Eric Seidel.
105
106         Add --exit-after-n-failures/crashes to NRWT
107         https://bugs.webkit.org/show_bug.cgi?id=51160
108         
109         Abort test run (in a similar way to how control-C is handled) when
110         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
111         that number of unexpected failures/crashes/timeouts.
112
113         * Scripts/webkitpy/layout_tests/port/test.py:
114         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
115         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
116
117 2010-12-16  David Levin  <levin@chromium.org>
118
119         Reviewed by Shinichiro Hamaji.
120
121         check-webkit-style unit tests has some duplicate boilerplate code.
122         https://bugs.webkit.org/show_bug.cgi?id=49519
123
124         * Scripts/webkitpy/style/checkers/cpp.py:
125         (update_include_state): Replaced the "io" parameter with the global
126         configuration _unit_test_config. This allowed not calling into
127         functions at a low level and also not plumbing through the injection
128         information through many levels of code.
129         (check_for_include_what_you_use): Ditto.
130         (process_file_data): Added the ability to set up the unit test config
131         to allow for injection.
132         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
133         (ErrorCollector.__init__): Added support for having a filter for errors.
134         (ErrorCollector.__call__): Ditto.
135         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
136         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
137         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
138         functions in the cpp.py with generic processing and a filter that
139         indicates what errors should be kept.
140         (CppStyleTestBase.perform_multi_line_lint): Ditto.
141         (CppStyleTestBase.perform_language_rules_check): Ditto.
142         (CppStyleTestBase.perform_function_lengths_check): Ditto.
143         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
144         (CppStyleTestBase.perform_include_what_you_use): Ditto.
145         (CppStyleTest.test_multi_line_comments): Added another
146         error message which applies to the test case.
147         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
148         to not have config.h, since it is processed as a header file.
149         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
150         style and indentation in checked code.
151         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
152         Fixed line number.
153         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
154         Ditto.
155
156 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
157
158         Unreviewed, rolling out r74136.
159         http://trac.webkit.org/changeset/74136
160         https://bugs.webkit.org/show_bug.cgi?id=51135
161
162         r74136 breaks chromium canary bots because some tests are not
163         rebaselined correctly to resolve EOL differences (Requested by
164         jianli on #webkit).
165
166         * Scripts/webkitpy/layout_tests/port/base.py:
167         * Scripts/webkitpy/layout_tests/port/test.py:
168         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
169
170 2010-12-15  Adam Roben  <aroben@apple.com>
171
172         Teach check-webkit-style to check .vcproj and .vsprops files for XML
173         syntax errors
174
175         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
176         XML syntax errors in .vcproj/.vsprops files
177
178         Reviewed by Dave Levin.
179
180         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
181         that should be treated as XML and that should be allowed to contain
182         carriage returns. (These lists happen to be identical currently.)
183         (FileType): Added a new XML type.
184         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
185         Just does a simple file extension check.
186         (CheckerDispatcher._file_type): Added a case for XML files.
187         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
188         files (surprise!).
189         (StyleProcessor.process): Ask the dispatcher whether we should pass the
190         lines through the carriage checker.
191
192         * Scripts/webkitpy/style/checker_unittest.py:
193         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
194         Added. Checks a few file names to see if carriage returns are allowed
195         or not.
196         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
197         other assert_checker_* functions.
198         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
199         test_*_paths functions.
200         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
201         test_*_paths functions.
202         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
203         file from this test case, as vcproj files now have a type.
204         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
205         Added. Similar to the other should_* functions.
206         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
207         Added. Checks that carriage returns aren't checked for or stripped for
208         allowed files.
209
210         * Scripts/webkitpy/style/checkers/xml.py: Added.
211         (XMLChecker.__init__): Simple init method.
212         (XMLChecker.check): Pass each line through the expat parser, and record
213         a style error for any errors thrown by the parser.
214
215         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
216         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
217         produce a style error.
218         (XMLCheckerTest.assert_error): Checks that the given XML produces an
219         error of the given category on the given line.
220         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
221         checking that the XMLChecker constructor works properly.
222         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
223         cause a style error (see, e.g., r73887).
224         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
225         cause a style error (see, e.g., r73773).
226         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
227         properly.
228         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
229         tags cause a style error (see, e.g., r72795).
230         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
231         style error.
232
233 2010-12-15  Lucas Forschler  <lforschler@apple.com>
234
235         Reviewed by Stephanie Lewis.
236
237         https://bugs.webkit.org/show_bug.cgi?id=51117
238         Add a new leopard test bot
239         really really commit to trunk this time.
240
241         * BuildSlaveSupport/build.webkit.org-config/config.json:
242
243 2010-12-15  Sam Weinig  <sam@webkit.org>
244
245         Reviewed by Anders Carlsson.
246
247         WebKit2: Can't add files to an <input type=file>
248         https://bugs.webkit.org/show_bug.cgi?id=51087
249
250         * MiniBrowser/mac/BrowserWindowController.m:
251         (runOpenPanel):
252         (-[BrowserWindowController awakeFromNib]):
253         Add simple implementation of runOpenPanel callback.
254
255         * MiniBrowser/win/BrowserView.cpp:
256         (BrowserView::create):
257         * WebKitTestRunner/TestController.cpp:
258         (WTR::createOtherPage):
259         (WTR::TestController::initialize):
260         Stub out runOpenPanel callback. 
261
262 2010-12-14  Eric Seidel  <eric@webkit.org>
263
264         Reviewed by Adam Barth.
265
266         commit-queue should upload failure diffs when tests flake
267         https://bugs.webkit.org/show_bug.cgi?id=51051
268
269         To make this testable I needed to pipe FileSystem down onto tool.
270         We've wanted it there for a long time anyway.
271
272         This patch is kinda a big hack.  But we don't have a nice
273         way to read results.html files.  I think this will need further
274         revision before this code actually feels clean.
275
276         As part of testing this change, I had to make MockBugzilla.create_bug
277         actually return an id (like it should) which required updating
278         a few other unit test results (for the better).
279
280         The results_matching_keys change in layouttestresults/rebasline
281         was an alternate path which I decided not to use in the end, but
282         I left the change as it seemed an improvement.
283
284         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
285         * Scripts/webkitpy/common/net/layouttestresults.py:
286         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
287         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
288         * Scripts/webkitpy/tool/commands/queues.py:
289         * Scripts/webkitpy/tool/commands/rebaseline.py:
290         * Scripts/webkitpy/tool/main.py:
291         * Scripts/webkitpy/tool/mocktool.py:
292
293 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
294
295         Reviewed by James Robinson.
296
297         new-run-webkit-tests ignores trailing EOL differences in text tests
298         https://bugs.webkit.org/show_bug.cgi?id=36983
299
300         Changed the handling of new-line characters within new-run-webkit-tests
301         to match old-run-webkit-tests.  Differences in leading and trailing empty
302         lines in text expectation files are no longer ignored.
303
304         * Scripts/webkitpy/layout_tests/port/base.py:
305         * Scripts/webkitpy/layout_tests/port/test.py:
306         Added unit tests.  Removed old duplicate unit test entries.
307         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
308
309 2010-12-15  Ojan Vafai  <ojan@chromium.org>
310
311         Reviewed by Adam Barth.
312
313         make status-bubble white-space:nowrap so we can measure it's width without wrapping
314         https://bugs.webkit.org/show_bug.cgi?id=51149
315
316         * QueueStatusServer/templates/statusbubble.html:
317
318 2010-12-15  Ojan Vafai  <ojan@chromium.org>
319
320         Reviewed by Adam Barth.
321
322         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
323         https://bugs.webkit.org/show_bug.cgi?id=51125
324
325         * QueueStatusServer/templates/statusbubble.html:
326
327 2010-12-15  Darin Adler  <darin@apple.com>
328
329         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
330
331 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
332
333         Unreviewed, rolling out r74117.
334         http://trac.webkit.org/changeset/74117
335         https://bugs.webkit.org/show_bug.cgi?id=51113
336
337         This broke the GTK1 build. (Requested by mrobinson on
338         #webkit).
339
340         * Scripts/webkitdirs.pm:
341
342 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
343
344         Reviewed by Martin Robinson.
345
346         Change generate-forwarding-headers.pl for GTK port usage 
347         (https://bugs.webkit.org/show_bug.cgi?id=37369)
348
349         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
350
351 2010-12-14  Kent Tamura  <tkent@chromium.org>
352
353         Reviewed by Jian Li.
354
355         [DRT/Chromium] Remove another unnecessary error message
356         https://bugs.webkit.org/show_bug.cgi?id=51083
357
358         * DumpRenderTree/chromium/WebViewHost.cpp:
359         (WebViewHost::didInvalidateRect):
360
361 2010-12-14  Lucas Forschler  <lforschler@apple.com>
362
363         Reviewed by Stephanie Lewis.
364
365         Add a new Leopard Debug Test WK2 Bot
366
367         * BuildSlaveSupport/build.webkit.org-config/config.json:
368
369 2010-12-14  Ojan Vafai  <ojan@chromium.org>
370
371         Fix python unittests after http://trac.webkit.org/changeset/74070.
372
373         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
374
375 2010-12-14  Kent Tamura  <tkent@chromium.org>
376
377         Reviewed by Jian Li.
378
379         [DRT/Chromium] Remove a unnecessary error message
380         https://bugs.webkit.org/show_bug.cgi?id=51069
381
382         * DumpRenderTree/chromium/WebViewHost.cpp:
383         (WebViewHost::paintInvalidatedRegion):
384
385 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
386
387         Reviewed by Ojan Vafai.
388
389         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
390         https://bugs.webkit.org/show_bug.cgi?id=48926
391
392         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
393         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
394
395 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
396
397         Reviewed by Eric Seidel.
398
399         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
400         https://bugs.webkit.org/show_bug.cgi?id=50231
401
402         Guard CONFIG+=link_pkgconfig with !symbian.
403
404         * DumpRenderTree/qt/DumpRenderTree.pro:
405         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
406         * WebKitTestRunner/qt/WebKitTestRunner.pro:
407
408 2010-12-14  Philippe Normand  <pnormand@igalia.com>
409
410         Reviewed by Ojan Vafai.
411
412         [new-run-webkit-tests] expectations parsing is slow
413         https://bugs.webkit.org/show_bug.cgi?id=50635
414
415         Avoid expensive iteration of all the tests when checking if a test
416         file is to be skipped or not.
417
418         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
419         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
420         * Scripts/webkitpy/layout_tests/port/test.py:
421
422 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
423
424         Reviewed by Xan Lopez.
425
426         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
427         https://bugs.webkit.org/show_bug.cgi?id=27048
428
429         Add support in DRT for checking whether an accessibility UI
430         element is focusable and/or focused. Implemented for GTK.
431
432         * DumpRenderTree/AccessibilityUIElement.cpp:
433         (getIsFocusedCallback): New.
434         (getIsFocusableCallback): New.
435         (AccessibilityUIElement::getJSClass): Add the new available
436         callbacks for isFocused and isFocusable.
437         * DumpRenderTree/AccessibilityUIElement.h:
438         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
439         (AccessibilityUIElement::isFocused): New, implemented by checking
440         whether the related AtkState value is in the object's state set.
441         (AccessibilityUIElement::isFocusable): Ditto.
442         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
443         (AccessibilityUIElement::isFocused): New, dummy implementation.
444         (AccessibilityUIElement::isFocusable): Ditto.
445         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
446         (AccessibilityUIElement::isFocused): Ditto.
447         (AccessibilityUIElement::isFocusable): Ditto.
448
449 2010-12-14  Eric Seidel  <eric@webkit.org>
450
451         Reviewed by Ojan Vafai.
452
453         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
454         https://bugs.webkit.org/show_bug.cgi?id=50715
455
456         This patch makes webkit-patch print the following:
457
458         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
459         Install a 64-bit git for better performance, see:
460         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
461
462         I wrote this mostly because I have approximately 8 machines that I use
463         and making sure each one is using a good Git install seemed folly.
464         webkit-patch makes a lot of git calls, so using a fast git can shave
465         several seconds in every invocation.  See the webkit-dev thread for more info.
466
467         This message will print twice during 'webkit-patch upload',
468         once from webkit-patch and once from check-webkit-style.
469
470         Unfortunately there is no good way to test this due to how machine-dependent
471         the code is.  I considered writing a test for the log message, but it seemed not worth it.
472
473         * Scripts/webkitpy/common/checkout/scm.py:
474
475 2010-12-13  Eric Seidel  <eric@webkit.org>
476
477         Reviewed by Adam Barth.
478
479         FlakyTestReporter doesn't understand bots running from multiple email addresses
480         https://bugs.webkit.org/show_bug.cgi?id=50960
481
482         This explains at least one of the dupes of:
483         https://bugs.webkit.org/show_bug.cgi?id=50863
484         that we saw filed by the commit-queue this morning.
485         I think the other one was explained by my previous fix to result counting code.
486
487         Since this is really hard to test with a unit test, instead I
488         create a new (possibly useful in the future) command
489         which given a layout test path will return you
490         the one bug which our tools would assume it the flaky test bug.
491         If some other script wants to use bug-for-test we'll
492         need to extend it with some options like --create-if-missing or similar.
493
494         * Scripts/webkitpy/common/net/bugzilla/bug.py:
495         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
496         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
497         * Scripts/webkitpy/tool/commands/__init__.py:
498         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
499
500 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
501
502         Reviewed by James Robinson.
503
504         Add option to build-webkit to not build WebKit2
505         https://bugs.webkit.org/show_bug.cgi?id=50988
506         
507         Add support for a --no-webkit2 option to build-webkit. It seems to save
508         ~1 minute from clean builds and ~10 seconds from no-op builds.
509
510         * Scripts/build-webkit:
511
512 2010-12-13  Lucas Forschler  <lforschler@apple.com>
513
514         Reviewed by Dave Kilzer.
515
516         Update iexploder from 1.3.2 to 1.7.2
517         Move 1.3.2 into its own subdir
518         Add 1.7.2 into its own subdir
519         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
520
521         * Scripts/run-iexploder-tests:
522         * Scripts/update-iexploder-cssproperties:
523         * iExploder/CHANGELOG.txt: Removed.
524         * iExploder/LICENSE.txt: Removed.
525         * iExploder/README.txt: Removed.
526         * iExploder/htdocs: Removed.
527         * iExploder/iexploder-1.3.2: Added.
528         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
529         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
530         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
531         * iExploder/iexploder-1.3.2/htdocs: Added.
532         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
533         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
534         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
535         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
536         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
537         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
538         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
539         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
540         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
541         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
542         * iExploder/iexploder-1.3.2/tools: Added.
543         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
544         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
545         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
546         * iExploder/iexploder-1.7.2: Added.
547         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
548         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
549         * iExploder/iexploder-1.7.2/README.txt: Added.
550         * iExploder/iexploder-1.7.2/output: Added.
551         * iExploder/iexploder-1.7.2/src: Added.
552         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
553         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
554         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
555         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
556         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
557         * iExploder/iexploder-1.7.2/src/css-properties: Added.
558         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
559         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
560         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
561         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
562         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
563         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
564         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
565         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
566         * iExploder/iexploder-1.7.2/src/css-values: Added.
567         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
568         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
569         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
570         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
571         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
572         * iExploder/iexploder-1.7.2/src/headers: Added.
573         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
574         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
575         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
576         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
577         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
578         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
579         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
580         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
581         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
582         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
583         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
584         * iExploder/iexploder-1.7.2/src/html-tags: Added.
585         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
586         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
587         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
588         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
589         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
590         * iExploder/iexploder-1.7.2/src/html-values: Added.
591         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
592         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
593         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
594         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
595         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
596         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
597         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
598         * iExploder/iexploder-1.7.2/src/index.html: Added.
599         * iExploder/iexploder-1.7.2/src/media: Added.
600         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
601         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
602         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
603         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
604         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
605         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
606         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
607         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
608         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
609         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
610         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
611         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
612         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
613         * iExploder/iexploder-1.7.2/src/mime-types: Added.
614         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
615         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
616         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
617         * iExploder/iexploder-1.7.2/src/protocols: Added.
618         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
619         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
620         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
621         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
622         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
623         * iExploder/iexploder-1.7.2/src/version.rb: Added.
624         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
625         * iExploder/iexploder-1.7.2/testcases: Added.
626         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
627         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
628         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
629         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
630         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
631         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
632         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
633         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
634         * iExploder/iexploder-1.7.2/tools: Added.
635         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
636         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
637         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
638         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
639         * iExploder/tools: Removed.
640
641 2010-12-13  Sam Weinig  <sam@webkit.org>
642
643         Reviewed by Anders Carlsson.
644
645         Remove associated page concept from WKView constructor
646         https://bugs.webkit.org/show_bug.cgi?id=50983
647
648         Step 1: Remove associate page constructors from WKView and make
649         all views use the shared namespace for the context.
650
651         * TestWebKitAPI/PlatformWebView.h:
652         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
653         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
654         * WebKitTestRunner/PlatformWebView.h:
655         * WebKitTestRunner/TestController.cpp:
656         (WTR::createOtherPage):
657         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
658         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
659         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
660
661 2010-12-13  Sam Weinig  <sam@webkit.org>
662
663         Reviewed by Anders Carlsson.
664
665         Change the WebKit2 public API so there is no explicit WKPageNamespace object
666         https://bugs.webkit.org/show_bug.cgi?id=50898
667
668         * MiniBrowser/mac/AppDelegate.h:
669         * MiniBrowser/mac/AppDelegate.m:
670         * MiniBrowser/mac/BrowserWindowController.h:
671         * MiniBrowser/mac/BrowserWindowController.m:
672         * MiniBrowser/win/BrowserView.cpp:
673         Convert MiniBrowser to not use PageNamespaces.
674
675         * TestWebKitAPI/PlatformWebView.h:
676         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
677         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
678         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
679         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
680         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
681         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
682         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
683         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
684         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
685         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
686         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
687         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
688         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
689         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
690         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
691         Convert TestWebKitAPI to not use PageNamespaces.
692
693         * WebKitTestRunner/PlatformWebView.h:
694         * WebKitTestRunner/TestController.cpp:
695         * WebKitTestRunner/TestController.h:
696         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
697         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
698         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
699         Convert WebKitTestRunner to not use PageNamespaces.
700
701 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
702
703         Reviewed by Eric Seidel.
704
705         webkit-patch rollout should be able to do multi-revision rollouts
706         https://bugs.webkit.org/show_bug.cgi?id=33336
707
708         Make it possible to pass more than one revision to webkit-patch.
709
710         * Scripts/webkitpy/common/checkout/api.py:
711         * Scripts/webkitpy/common/checkout/changelog.py:
712         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
713         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
714         * Scripts/webkitpy/tool/commands/download.py:
715         * Scripts/webkitpy/tool/commands/download_unittest.py:
716         * Scripts/webkitpy/tool/mocktool.py:
717         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
718         * Scripts/webkitpy/tool/steps/revertrevision.py:
719
720 2010-12-13  Eric Seidel  <eric@webkit.org>
721
722         Unreviewed.
723
724         Teach webkit-patch how to search bugzilla
725         https://bugs.webkit.org/show_bug.cgi?id=50500
726
727         webkit-patch bug-search fails when there is only one result.
728         Turns out we needed a bit more logic in our result count parsing code.
729
730         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
731         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
732
733 2010-12-13  Antti Koivisto  <antti@apple.com>
734
735         Reviewed by Alexey Proskuryakov.
736
737         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
738         https://bugs.webkit.org/show_bug.cgi?id=50758
739
740         * DumpRenderTree/LayoutTestController.cpp:
741         (setSerializeHTTPLoadsCallback):
742         (LayoutTestController::staticFunctions):
743         * DumpRenderTree/LayoutTestController.h:
744         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
745         (LayoutTestController::setSerializeHTTPLoads):
746         * DumpRenderTree/mac/DumpRenderTree.mm:
747         (resetDefaultsToConsistentValues):
748         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
749         (LayoutTestController::setSerializeHTTPLoads):
750         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
751         (LayoutTestController::setSerializeHTTPLoads):
752
753 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
754
755         Reviewed by Ojan Vafai.
756
757         Remove "use-drt" option from test step command line, since the option was removed in r73748.
758         https://bugs.webkit.org/show_bug.cgi?id=50936
759
760         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
761
762 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
763
764         Reviewed by Csaba Osztrogonác.
765
766         Add revlink to BuildBot status
767         https://bugs.webkit.org/show_bug.cgi?id=50914
768
769         This adds a hyperlink to trac changeset on the revision numbers. 
770
771         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
772
773 2010-12-13  Andras Becsi  <abecsi@webkit.org>
774
775         Reviewed by Csaba Osztrogonác.
776
777         [Qt][WK2] Fix build if WebKitTools are not available
778         https://bugs.webkit.org/show_bug.cgi?id=50242
779
780         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
781         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
782         * MiniBrowser/DerivedSources.pro: Added.
783
784 2010-12-13  Eric Seidel  <eric@webkit.org>
785
786         Reviewed by Adam Barth.
787
788         EWS Queues should remove orpahned pyc files before starting
789         https://bugs.webkit.org/show_bug.cgi?id=50904
790
791         A previous check added a platform.py which caused
792         EWS bots on some platforms to hit an import exception.
793         The platform.py file was removed in a subsequent commit, but
794         the EWS bots in question stayed stuck.  This change will
795         fix those bots once restarted (and prevent this in the future).
796
797         I also went ahead and unified start-queue and start-commit-queue
798         since they were nearly identical.  I also added bot_id support
799         to both force all EWSes to have bot ids as well as get rid of the one
800         remaining reason why I had my own copies of these scripts.
801         Hopefully this will be enough to get all the other bot admins
802         (ahem, Adam, ahem) to move to using these checked in copies as well.
803
804         * EWSTools/start-commit-queue.sh: Removed.
805         * EWSTools/start-queue.sh:
806
807 2010-10-28  MORITA Hajime  <morrita@google.com>
808
809         Reviewed by Ojan Vafai.
810
811         spellcheck does not check pasted text
812         https://bugs.webkit.org/show_bug.cgi?id=40092
813
814         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
815         to control the setting.
816
817         * DumpRenderTree/LayoutTestController.cpp:
818         (setAsynchronousSpellCheckingEnabledCallback):
819         (LayoutTestController::staticFunctions):
820         * DumpRenderTree/LayoutTestController.h:
821         * DumpRenderTree/chromium/LayoutTestController.h:
822         * DumpRenderTree/chromium/LayoutTestController.cpp:
823         (LayoutTestController::LayoutTestController):
824         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
825         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
826         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
827         * DumpRenderTree/mac/DumpRenderTree.mm:
828         (resetDefaultsToConsistentValues):
829         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
830         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
831         * DumpRenderTree/qt/LayoutTestControllerQt.h:
832         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
833         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
834         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
835         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
836         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
837         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
838
839 2010-12-12  Sam Weinig  <sam@webkit.org>
840
841         Reviewed by Anders Carlsson.
842
843         Fix failing API test. It turns out that a pop-state event
844         is sent before every fragment navigation, so we have to test
845         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
846
847         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
848         (TestWebKitAPI::didSameDocumentNavigationForFrame):
849
850 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
851
852         Reviewed by Eric Seidel.
853
854         [GTK] Add new-run-webkit-tests support to gtk
855         https://bugs.webkit.org/show_bug.cgi?id=50681
856
857         Adding the basic support to run the new-run-webkit-tests.
858
859         * Scripts/webkitpy/layout_tests/port/gtk.py:
860
861 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
862
863         Reviewed by Kenneth Rohde Christiansen.
864
865         [Qt] Mock DeviceOrientation client for DRT
866         https://bugs.webkit.org/show_bug.cgi?id=47490
867
868         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
869         (WebCore::DumpRenderTree::DumpRenderTree):
870         (WebCore::DumpRenderTree::~DumpRenderTree):
871         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
872         (LayoutTestController::setMockDeviceOrientation):
873
874 2010-12-11  Philippe Normand  <pnormand@igalia.com>
875
876         Reviewed by Gustavo Noronha Silva.
877
878         [GTK] launcher: disable the Mozilla-style fullscreen API
879         https://bugs.webkit.org/show_bug.cgi?id=50874
880
881         Disabling the fullscreen API until its implementation for GTK is
882         mature enough. The webview setting for it is already FALSE by
883         default.
884
885         * GtkLauncher/main.c:
886         (createWindow):
887
888 2010-12-10  Eric Seidel  <eric@webkit.org>
889
890         Reviewed by Adam Barth.
891
892         commit-queue flaky test messages show cryptic version information for mac os x
893         https://bugs.webkit.org/show_bug.cgi?id=50864
894
895         Turns out platform.platform() returns kernel version information
896         which isn't helpful, and just plain confusing on Mac
897         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
898
899         So I've updated PlatformInfo.display_name() to special case
900         mac.  I also found a bad use of sys.platform in the process
901         and fixed that.  (sys.platform always returns 'darwin' on mac).
902
903         * Scripts/webkitpy/common/system/platforminfo.py:
904         * Scripts/webkitpy/common/system/user.py:
905         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
906         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
907         * Scripts/webkitpy/tool/commands/queues_unittest.py:
908
909 2010-12-10  Eric Seidel  <eric@webkit.org>
910
911         Unreviewed.
912
913         Exception seen while reporting flaky test with commit-queue.
914         Just a missing include.
915
916         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
917         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
918
919 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
920
921         Reviewed by Eric Seidel.
922
923         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
924         https://bugs.webkit.org/show_bug.cgi?id=50796
925
926         Also updating the test code to use JSONResultsGeneratorBase and
927         to improve test coverage for incremental cases.
928
929         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
930         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
931
932 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
933
934         Reviewed by Darin Adler.
935
936         prepare-ChangeLog --help doesn't mention --bug shorthand -b
937         https://bugs.webkit.org/show_bug.cgi?id=50835
938
939         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
940
941 2010-12-10  Eric Seidel  <eric@webkit.org>
942
943         Reviewed by Adam Barth.
944
945         Bugs created by the commit-queue should all block on a master bug
946         https://bugs.webkit.org/show_bug.cgi?id=50857
947
948         This makes all bugs created by the commit-queue block on:
949         https://bugs.webkit.org/show_bug.cgi?id=50856
950
951         In the process of testing this, I found that the existing
952         create_bug code was wrong.  I also found that existing
953         unit tests for create-rollout used invalid values
954         for options.blocks.  I fixed both issues and tested.
955
956         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
957         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
958         * Scripts/webkitpy/tool/commands/commandtest.py:
959         * Scripts/webkitpy/tool/commands/download_unittest.py:
960         * Scripts/webkitpy/tool/commands/upload_unittest.py:
961         * Scripts/webkitpy/tool/mocktool.py:
962         * Scripts/webkitpy/tool/steps/options.py:
963
964 2010-12-10  Eric Seidel  <eric@webkit.org>
965
966         Reviewed by Adam Barth.
967
968         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
969         https://bugs.webkit.org/show_bug.cgi?id=50853
970
971         I also discovered when doing this that the code was posting
972         the comment on the wrong bug, but that's fixed here too.
973
974         * Scripts/webkitpy/common/net/bugzilla/bug.py:
975         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
976         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
977         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
978         * Scripts/webkitpy/tool/commands/queues_unittest.py:
979         * Scripts/webkitpy/tool/mocktool.py:
980
981 2010-12-10  Anders Carlsson  <andersca@apple.com>
982
983         Reviewed by John Sullivan.
984
985         Make WKContextGetStatistics gather global statistics
986         https://bugs.webkit.org/show_bug.cgi?id=50850
987
988         Remove the code that gets the statistics and fills in the per context
989         statistics information for now.
990
991         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
992         (-[BrowserStatisticsWindowController refreshStatistics:]):
993
994 2010-12-10  Eric Seidel  <eric@webkit.org>
995
996         Unreviewed.
997
998         commit-queue should report port/platform information when commenting on flaky test bugs
999         https://bugs.webkit.org/show_bug.cgi?id=50839
1000
1001         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1002         which was only used by new run webkit tests (and clearly not unit tested).
1003
1004         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1005         * Scripts/webkitpy/tool/main.py:
1006         * Scripts/webkitpy/tool/mocktool.py:
1007
1008 2010-12-10  Eric Seidel  <eric@webkit.org>
1009
1010         Reviewed by Tony Chang.
1011
1012         commit-queue should report port/platform information when commenting on flaky test bugs
1013         https://bugs.webkit.org/show_bug.cgi?id=50839
1014
1015         This was a suggestion from Tony Chang this morning.
1016         I added a platform.py class so I could easily mock the platform call,
1017         but that may not be the final solution for this mocking.
1018         We'll try it and see.
1019
1020         * Scripts/webkitpy/common/system/platform.py: Added.
1021         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1022         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1023         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1024         * Scripts/webkitpy/tool/main.py:
1025         * Scripts/webkitpy/tool/mocktool.py:
1026
1027 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1028
1029         Reviewed by Joseph Pecoraro.
1030
1031         Bug 43455 - [Qt]: Implement Application Cache Quotas
1032         https://bugs.webkit.org/show_bug.cgi?id=43455
1033
1034         Introduce functions to allow new appcache layout test origin-quota.html
1035         to work correctly under Qt.
1036
1037         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1038         (WebCore::DumpRenderTree::DumpRenderTree):
1039         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1040         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1041
1042         Introduce functions to allow new appcache layout test origin-quota.html
1043         to be successful under qt. Changes required because LayoutTestControllerQt
1044         does not inherit from LayoutController.
1045
1046         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1047         (LayoutTestController::reset):
1048         (LayoutTestController::clearAllApplicationCaches):
1049         (LayoutTestController::setApplicationCacheOriginQuota):
1050         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1051         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1052         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1053
1054 2010-12-10  Eric Seidel  <eric@webkit.org>
1055
1056         Reviewed by Adam Barth.
1057
1058         Move buildbot.py into its own module so we can split it out into one-file-per-class
1059         https://bugs.webkit.org/show_bug.cgi?id=50806
1060
1061         We're adding more buildbot logic these days, so it makes sense
1062         to give buildbot its own module.
1063
1064         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1065         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1066         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1067         * Scripts/webkitpy/common/net/failuremap.py:
1068         * Scripts/webkitpy/common/net/regressionwindow.py:
1069         * Scripts/webkitpy/tool/commands/rebaseline.py:
1070
1071 2010-12-10  Tony Chang  <tony@chromium.org>
1072
1073         Reviewed by Eric Seidel.
1074
1075         Use FileSystem::remove when cleaning up http lock files
1076         https://bugs.webkit.org/show_bug.cgi?id=50830
1077
1078         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1079
1080 2010-12-10  Joone Hur  <joone@kldp.org>
1081
1082         Reviewed by Martin Robinson.
1083
1084         [GTK] DRT needs layoutTestController.setCacheModel
1085         https://bugs.webkit.org/show_bug.cgi?id=50705
1086         
1087         webkit_set_cache_mode() is called to set the cache model.
1088         
1089         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1090         (LayoutTestController::setCacheModel): Set the cache model. 
1091
1092 2010-12-10  Tony Chang  <tony@chromium.org>
1093
1094         Reviewed by Ojan Vafai.
1095
1096         [chromium] remove --use-drt and add --use-test-shell
1097         https://bugs.webkit.org/show_bug.cgi?id=50701
1098
1099         * Scripts/webkitpy/common/config/ports.py:
1100         * Scripts/webkitpy/common/config/ports_unittest.py:
1101         * Scripts/webkitpy/layout_tests/port/chromium.py:
1102         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1103         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1104         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1105         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1106         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1107         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1108         * Scripts/webkitpy/layout_tests/port/webkit.py:
1109         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1110         * Scripts/webkitpy/style/checkers/test_expectations.py:
1111         * Scripts/webkitpy/tool/commands/queries.py:
1112
1113 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1114
1115         Reviewed by Steve Block.
1116
1117         [Chromium] Implement mocks for client-based geolocation
1118         https://bugs.webkit.org/show_bug.cgi?id=46895
1119
1120         * DumpRenderTree/chromium/LayoutTestController.cpp:
1121         (LayoutTestController::setGeolocationPermission):
1122         (LayoutTestController::setMockGeolocationPosition):
1123         (LayoutTestController::setMockGeolocationError):
1124         * DumpRenderTree/chromium/LayoutTestController.h:
1125         * DumpRenderTree/chromium/WebViewHost.cpp:
1126         (WebViewHost::geolocationClient):
1127         (WebViewHost::geolocationClientMock):
1128         (WebViewHost::reset):
1129         * DumpRenderTree/chromium/WebViewHost.h:
1130
1131 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1132
1133         Reviewed by Martin Robinson.
1134
1135         [GTK] Add hasSpellingMarker support to the DRT
1136         https://bugs.webkit.org/show_bug.cgi?id=50739
1137
1138         Implemented the hasSpellingMarker to support spelling tests.
1139
1140         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1141         (LayoutTestController::hasSpellingMarker):
1142
1143 2010-12-10  Eric Seidel  <eric@webkit.org>
1144
1145         Reviewed by Ojan Vafai.
1146
1147         webkit-patch: not possible to use build-and-test with local commits
1148         https://bugs.webkit.org/show_bug.cgi?id=33378
1149
1150         Make --no-clean not even check if we have local commits.
1151         It's unclear to me why the code was originally written this way.
1152         I was unable to dig up a reason from svn history.
1153
1154         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1155         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1156
1157 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1158
1159         Reviewed by Martin Robinson.
1160
1161         [GTK] AX: implement isEnabled in DRT
1162         https://bugs.webkit.org/show_bug.cgi?id=50814
1163
1164         Implement AccessibilityUIElement::isEnabled() for GTK.
1165
1166         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1167         (checkElementState): New function to refactor common code.
1168         (AccessibilityUIElement::isEnabled): Implement this by checking
1169         the current state of the AtkObject.
1170         (AccessibilityUIElement::isSelected): Use the new
1171         checkElementState function.
1172
1173 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1174
1175         Reviewed by Kenneth Rohde Christiansen.
1176
1177         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1178         https://bugs.webkit.org/show_bug.cgi?id=50750
1179
1180         * MiniBrowser/qt/BrowserView.cpp:
1181         (BrowserView::BrowserView):
1182         * MiniBrowser/qt/BrowserView.h:
1183         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1184         (WTR::WebView::WebView):
1185
1186 2010-12-10  Joone Hur  <joone@kldp.org>
1187
1188         Reviewed by Xan Lopez.
1189
1190         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1191         https://bugs.webkit.org/show_bug.cgi?id=50808
1192
1193         Unskipping the following test cases:
1194         userscripts/mixed-case-stylesheet.html
1195         userscripts/simple-stylesheet.html
1196         userscripts/user-style-all-frames.html
1197
1198         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1199         (LayoutTestController::addUserStyleSheet):
1200
1201 2010-12-10  Joone Hur  <joone@kldp.org>
1202
1203         Reviewed by Eric Seidel.
1204
1205         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1206         https://bugs.webkit.org/show_bug.cgi?id=50783
1207
1208         This patch allows to unskip the following test cases:
1209         printing/page-rule-selection.html
1210         printing/page-format-data.html
1211
1212         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1213         (LayoutTestController::pageProperty): Added.
1214         (LayoutTestController::isPageBoxVisible): Ditto.
1215         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1216         (LayoutTestController::addUserStyleSheet): Ditto.
1217
1218 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1219
1220         Reviewed by Kenneth Rohde Christiansen.
1221
1222         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1223
1224         A menu allows to switch QNAM back to the same thread.
1225
1226         * QtTestBrowser/launcherwindow.cpp:
1227         (LauncherWindow::initializeView):
1228         (LauncherWindow::createChrome):
1229         (LauncherWindow::toggleThreadedQnam):
1230         * QtTestBrowser/launcherwindow.h:
1231         (WindowOptions::WindowOptions):
1232         * QtTestBrowser/webpage.cpp:
1233         (WebPage::WebPage):
1234         (WebPage::setQnamThreaded):
1235         * QtTestBrowser/webpage.h:
1236         (QnamThread::QnamThread):
1237         (QnamThread::~QnamThread):
1238         (QnamThread::networkAccessManager):
1239         (QnamThread::run):
1240
1241 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1242
1243         Reviewed by Xan Lopez.
1244
1245         [Gtk] style="font-family: courier" makes text disappear
1246         https://bugs.webkit.org/show_bug.cgi?id=47452
1247
1248         Add a test that verifies that fonts without valid charmaps are
1249         never selected.
1250
1251         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1252         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1253         that has no valid charmap.
1254         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1255         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1256         settings which may disable selection of bitmap fonts.
1257
1258 2010-12-10  Eric Seidel  <eric@webkit.org>
1259
1260         Unreviewed.
1261
1262         The commit-queue should file bugs about flaky tests it encounters
1263         https://bugs.webkit.org/show_bug.cgi?id=50803
1264
1265         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1266         Now it's tested.
1267
1268         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1269         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1270
1271 2010-12-10  Eric Seidel  <eric@webkit.org>
1272
1273         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1274
1275         The commit-queue should file bugs about flaky tests it encounters
1276         https://bugs.webkit.org/show_bug.cgi?id=50803
1277
1278         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1279
1280 2010-12-09  Eric Seidel  <eric@webkit.org>
1281
1282         Reviewed by Adam Barth.
1283
1284         The commit-queue should file bugs about flaky tests it encounters
1285         https://bugs.webkit.org/show_bug.cgi?id=50803
1286
1287         This change got a bit big.  I also added a new config.urls file
1288         because I needed to share the view_source_url code with committervalidator.py.
1289
1290         This adds a new class FlakyTestReporter which holds all the logic about
1291         reporting flaky tests to bugzilla.
1292
1293         Right now this code knows how to look up bugs for flaky tests.
1294         If it can't find a bug filed from the commit-queue, it will open a new
1295         one, ccing the relevant people and adding information about the failure.
1296
1297         It is not yet smart enough to chase down duplicate chains, or to include
1298         the actual failure diff.  But those can be added in later iterations.
1299
1300         * Scripts/webkitpy/common/checkout/api.py:
1301         * Scripts/webkitpy/common/checkout/changelog.py:
1302         * Scripts/webkitpy/common/checkout/commitinfo.py:
1303         * Scripts/webkitpy/common/config/committervalidator.py:
1304         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1305         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1306         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1307         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1308         * Scripts/webkitpy/tool/bot/irc_command.py:
1309         * Scripts/webkitpy/tool/bot/sheriff.py:
1310         * Scripts/webkitpy/tool/commands/download.py:
1311         * Scripts/webkitpy/tool/commands/queues.py:
1312         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1313         * Scripts/webkitpy/tool/comments.py:
1314         * Scripts/webkitpy/tool/mocktool.py:
1315         * Scripts/webkitpy/tool/steps/commit.py:
1316
1317 2010-12-09  Eric Seidel  <eric@webkit.org>
1318
1319         Reviewed by Adam Barth.
1320
1321         Teach webkit-patch how to search bugzilla
1322         https://bugs.webkit.org/show_bug.cgi?id=50500
1323
1324         This is a step towards teaching webkitpy how to file
1325         new bugs for flaky tests and update them when new flakes occur.
1326
1327         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1328         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1329         * Scripts/webkitpy/tool/commands/__init__.py:
1330         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1331
1332 2010-12-09  Adam Barth  <abarth@webkit.org>
1333
1334         Reviewed by Ojan Vafai.
1335
1336         commit-queue errors out due to local commits
1337         https://bugs.webkit.org/show_bug.cgi?id=50766
1338
1339         We seem to be tripping over having local commits in the working copy a
1340         lot recently.  I don't quite fully understand what the issue is, but
1341         this patch attempts to solve the problem by adding an explicit clean
1342         step before processing a patch.  Previously, we did the cleaning as
1343         part of the apply-attachment step, so this might not actually fix the
1344         problem.
1345
1346         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1347         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1348         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1349
1350 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1351
1352         Reviewed by Ojan Vafai.
1353
1354         Make new-run-webkit-tests --lint-test-files log slightly better
1355         messages and return -1 if lint fails. Remove the
1356         'suppress_errors' keyword param to the TestExpectationsFile
1357         class, and clean up logging and exception raising for error
1358         handling. Also add more unit tests and clean up the unit test code a bit.
1359
1360         https://bugs.webkit.org/show_bug.cgi?id=50205
1361
1362         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1363         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1364         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1365         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1366         * Scripts/webkitpy/layout_tests/port/chromium.py:
1367         * Scripts/webkitpy/style/checkers/test_expectations.py:
1368         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1369
1370 2010-12-09  Tony Chang  <tony@chromium.org>
1371
1372         Unreviewed, fix for windows code.  We were catching the wrong
1373         exception in Windows.
1374
1375         * Scripts/webkitpy/common/system/filesystem.py:
1376
1377 2010-12-09  Antonio Gomes  <agomes@rim.com>
1378
1379         Reviewed by Martin Robinson.
1380
1381         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1382         https://bugs.webkit.org/show_bug.cgi?id=48429
1383
1384         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1385
1386         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1387         (LayoutTestController::workerThreadCount):
1388
1389 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1390
1391         Reviewed by Martin Robinson.
1392
1393         [GTK] Support the Mozilla-style Fullscreen Javascript API
1394         https://bugs.webkit.org/show_bug.cgi?id=50572
1395
1396         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1397         make DRT update the Chrome when the WebView settings have been
1398         reset to consistent values.
1399
1400         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1401         (resetDefaultsToConsistentValues):
1402         * GtkLauncher/main.c:
1403         (create_window):
1404         * Scripts/build-webkit:
1405
1406 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1407
1408         Reviewed by Tor Arne Vestbø
1409
1410         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1411         https://bugs.webkit.org/show_bug.cgi?id=50742
1412
1413         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1414
1415         * Scripts/webkitdirs.pm:
1416
1417 2010-12-09  Joone Hur  <joone@kldp.org>
1418
1419          Reviewed by Martin Robinson.
1420
1421          [GTK] Support for viewport meta tag
1422          https://bugs.webkit.org/show_bug.cgi?id=45443
1423
1424          Add support for testing the viewport properties for WebKitGtk.
1425
1426          * DumpRenderTree/LayoutTestController.cpp:
1427          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1428          (LayoutTestController::staticFunctions):
1429          * DumpRenderTree/LayoutTestController.h:
1430          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1431          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1432          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1433          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1434          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1435          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1436          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1437          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1438          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1439          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1440
1441 2010-12-08  William Siegrist <wsiegrist@apple.com>
1442
1443         Reviewed by Eric Seidel.
1444
1445         Migrate buildbot.py from xmlrpc to json.
1446         https://bugs.webkit.org/show_bug.cgi?id=50647
1447
1448         * Scripts/webkitpy/common/net/buildbot.py:
1449
1450 2010-12-08  Tony Chang  <tony@chromium.org>
1451
1452         Reviewed by Eric Seidel.
1453
1454         make starting the websocket server more reliable on windows
1455         https://bugs.webkit.org/show_bug.cgi?id=50712
1456
1457         * Scripts/webkitpy/common/system/filesystem.py:
1458         (remove): Substitute method for os.remove to retry on error on Windows
1459         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1460         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1461
1462 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1463
1464         Reviewed by Adam Roben.
1465
1466         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1467         https://bugs.webkit.org/show_bug.cgi?id=50656
1468
1469         * MiniBrowser/mac/BrowserWindowController.m:
1470         (-[BrowserWindowController awakeFromNib]):
1471         Indicate that exceededDatabaseQuota is not implemented.
1472         * MiniBrowser/win/BrowserView.cpp:
1473         (BrowserView::create):
1474         Ditto.
1475         * WebKitTestRunner/TestController.cpp:
1476         (WTR::createOtherPage):
1477         Ditto.
1478         (WTR::TestController::initialize):
1479         Ditto.
1480
1481 2010-12-08  Antonio Gomes  <agomes@rim.com>
1482
1483         Reviewed by Martin Robinson.
1484
1485         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1486         https://bugs.webkit.org/show_bug.cgi?id=48429
1487
1488         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1489         * webkit_gc_collect_javascript_objects;
1490         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1491         * webkit_gc_count_javascript_objects;
1492         * webkit_web_frame_layout.
1493
1494         These were all only used by GTK+ DRT.
1495
1496         * DumpRenderTree/gtk/EventSender.cpp:
1497         (dispatchEvent):
1498         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1499         (GCController::collect):
1500         (GCController::collectOnAlternateThread):
1501         (GCController::getJSObjectCount):
1502
1503 2010-12-07  Tony Chang  <tony@chromium.org>
1504
1505         Reviewed by Ojan Vafai.
1506
1507         [chromium] force NRWT to use DRT
1508         https://bugs.webkit.org/show_bug.cgi?id=50359
1509
1510         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1511
1512 2010-12-06  Sam Weinig  <sam@webkit.org>
1513
1514         Reviewed by Anders Carlsson.
1515
1516         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1517         https://bugs.webkit.org/show_bug.cgi?id=50584
1518
1519         * MiniBrowser/mac/BrowserWindowController.m:
1520         (didSameDocumentNavigationForFrame):
1521         (-[BrowserWindowController awakeFromNib]):
1522         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1523         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1524         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1525         (TestWebKitAPI::TEST):
1526         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1527         (WTR::InjectedBundlePage::InjectedBundlePage):
1528         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1529         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1530         * WebKitTestRunner/TestController.cpp:
1531         (WTR::TestController::initialize):
1532
1533 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1534
1535         Reviewed by Ojan Vafai.
1536
1537         Make TestResultsServer return 404 for non-existing results files.
1538         https://bugs.webkit.org/show_bug.cgi?id=50581
1539
1540         * TestResultServer/handlers/testfilehandler.py:
1541
1542 2010-12-06  Tony Chang  <tony@chromium.org>
1543
1544         Reviewed by Ojan Vafai.
1545
1546         [chromium] fix an assert hit in DRT
1547         https://bugs.webkit.org/show_bug.cgi?id=50575
1548
1549         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1550         semantics.
1551
1552         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1553         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1554         WTF::RefCountedBase::ref()).
1555
1556         * DumpRenderTree/chromium/TestWebWorker.h:
1557         (TestWebWorker::TestWebWorker):
1558
1559 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1560
1561         Reviewed by Eric Seidel.
1562
1563         make webkit-patch command work when the git branch is not synced to the remote svn branch
1564         https://bugs.webkit.org/show_bug.cgi?id=50424
1565
1566         * Scripts/webkitpy/common/checkout/scm.py:
1567         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1568
1569 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1570
1571         Reviewed by Andreas Kling.
1572
1573         [WINCE] Add build system
1574         https://bugs.webkit.org/show_bug.cgi?id=50522
1575
1576         * CMakeListsWinCE.txt: Added.
1577
1578 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1579
1580         Reviewed by Tony Chang.
1581
1582         Allow the Chromium port to have Leopard-specific baselines
1583         https://bugs.webkit.org/show_bug.cgi?id=50506
1584
1585         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1586
1587 2010-12-03  Tony Chang  <tony@chromium.org>
1588
1589         Reviewed by Kent Tamura.
1590
1591         [chromium] fix 2 bugs with inspector tests in DRT
1592         https://bugs.webkit.org/show_bug.cgi?id=50492
1593
1594         Tasks can outlive the tasklist (even when canceled) so this was
1595         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1596         when a task is canceled.
1597
1598         Also fix an assert when closing devtool windows by copying some
1599         logic from test_shell.
1600
1601         * DumpRenderTree/chromium/Task.cpp:
1602         (WebTask::~WebTask):
1603         (TaskList::revokeAll):
1604         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1605             the tasklist (since the task can outlive the tasklist).
1606         * DumpRenderTree/chromium/TestShell.h:
1607         (TestShell::devToolsWebView):
1608         * DumpRenderTree/chromium/WebViewHost.cpp:
1609         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1610             a window if the window has devtools loaded.  This avoids an
1611             ASSERT and matches test_shell.
1612
1613 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1614
1615         Reviewed by Martin Robinson.
1616
1617         [GTK] Fix GtkLauncher.c style, use webkit style
1618         https://bugs.webkit.org/show_bug.cgi?id=50542
1619
1620         * GtkLauncher/main.c:
1621         (activateUriEntryCb):
1622         (updateTitle):
1623         (linkHoverCb):
1624         (notifyTitleCb):
1625         (notifyLoadStatusCb):
1626         (notifyProgressCb):
1627         (destroyCb):
1628         (goBackCb):
1629         (goForwardCb):
1630         (create_webViewCb):
1631         (webViewReadyCb):
1632         (closeWebViewCb):
1633         (createBrowser):
1634         (createStatusbar):
1635         (createToolbar):
1636         (createWindow):
1637         (main):
1638
1639 2010-12-04  Antonio Gomes  <agomes@rim.com>
1640
1641         Reviewed by Martin Robinson.
1642
1643         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1644         https://bugs.webkit.org/show_bug.cgi?id=48429
1645
1646         Moved more private method declared with WEBKIT_API to
1647         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1648
1649         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1650         (resetDefaultsToConsistentValues):
1651         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1652         (LayoutTestController::addOriginAccessWhitelistEntry):
1653         (LayoutTestController::execCommand):
1654         (LayoutTestController::isCommandEnabled):
1655
1656 2010-12-04  Antonio Gomes  <agomes@rim.com>
1657
1658         Reviewed by Andreas Kling.
1659
1660         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1661
1662         Method was removed by http://trac.webkit.org/changeset/71604
1663
1664         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1665
1666 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1667
1668         Reviewed by Xan Lopez.
1669
1670         [GTK] Fix compilation warnings reported by clang
1671         https://bugs.webkit.org/show_bug.cgi?id=50252
1672
1673         * GtkLauncher/main.c:
1674         (create_window): The create_statusbar function does not have
1675         parameters.
1676
1677 2010-12-05  Robert Hogan  <robert@webkit.org>
1678
1679         Reviewed by Andreas Kling.
1680
1681         [Qt] Zero-sized font does not yet work
1682
1683         Fix fast/text/font-size-zero.html
1684
1685         Copy other ports by setting minimumFontSize to 0 for DRT runs.
1686
1687         https://bugs.webkit.org/show_bug.cgi?id=49759
1688
1689         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1690         (WebCore::WebPage::WebPage):
1691
1692 2010-12-04  Sam Weinig  <sam@webkit.org>
1693
1694         Reviewed by Jon Honeycutt.
1695
1696         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
1697         https://bugs.webkit.org/show_bug.cgi?id=50511
1698
1699         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
1700         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
1701
1702         * MiniBrowser/mac/BrowserWindowController.m:
1703         (didChangeLocationWithinPageForFrame):
1704         (-[BrowserWindowController awakeFromNib]):
1705         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
1706         * TestWebKitAPI/PlatformUtilities.cpp:
1707         (TestWebKitAPI::Util::toWK):
1708         * TestWebKitAPI/PlatformUtilities.h:
1709         (TestWebKitAPI::Util::adoptWK):
1710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1711         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
1712         (TestWebKitAPI::nullJavaScriptCallback):
1713         (TestWebKitAPI::didFinishLoadForFrame):
1714         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
1715         (TestWebKitAPI::TEST):
1716         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
1717         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1718         * TestWebKitAPI/win/copy-resources.cmd:
1719         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1720         (WTR::InjectedBundlePage::InjectedBundlePage):
1721         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1722         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1723         * WebKitTestRunner/TestController.cpp:
1724         (WTR::TestController::initialize):
1725
1726 2010-11-08  Antonio Gomes  <agomes@rim.com>
1727
1728         Reviewed by Martin Robinson.
1729
1730         [Gtk] Populate DumpRenderTreeSupportGtk
1731         https://bugs.webkit.org/show_bug.cgi?id=48429
1732
1733         Made the previous calls to webkit_web_frame* functions defined as private
1734         APIs in webkitprivate.h go through DRTSupportGtk.
1735
1736         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1737         (AccessibilityController::focusedElement):
1738         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1739         (dumpFramesAsText):
1740         (resetDefaultsToConsistentValues):
1741         (dump):
1742         (webViewDocumentLoadFinished):
1743         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1744         (LayoutTestController::counterValueForElementById):
1745         (LayoutTestController::pageNumberForElementById):
1746         (LayoutTestController::numberOfPages):
1747         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1748         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1749         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1750         (LayoutTestController::numberOfActiveAnimations):
1751         (LayoutTestController::suspendAnimations):
1752         (LayoutTestController::resumeAnimations):
1753         (LayoutTestController::markerTextForListItem):
1754
1755 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1756
1757         Reviewed by Tony Chang.
1758
1759         Rebaseline server: use pretty text diff output
1760         https://bugs.webkit.org/show_bug.cgi?id=50484
1761         
1762         Serve *-pretty-diff.html for text diff output.
1763
1764         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1765         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1766         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1767         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1768
1769 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1770
1771         Unreviewed, rolling out r73302.
1772         http://trac.webkit.org/changeset/73302
1773         https://bugs.webkit.org/show_bug.cgi?id=50499
1774
1775         Causes crashes in debug LayoutTests (Requested by xan_ on
1776         #webkit).
1777
1778         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1779         (AccessibilityUIElement::AccessibilityUIElement):
1780         (AccessibilityUIElement::parentElementCallback):
1781         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1782         * DumpRenderTree/chromium/CppBoundClass.cpp:
1783         * DumpRenderTree/chromium/CppBoundClass.h:
1784
1785 2010-12-03  Sam Weinig  <sam@webkit.org>
1786
1787         Reviewed by Maciej Stachowiak.
1788
1789         Enable <a ping> for Mac/Windows/WebKit2 builds
1790         <rdar://problem/8504473>
1791         https://bugs.webkit.org/show_bug.cgi?id=50488
1792
1793         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1794         (TestWebKitAPI::TEST): Test that the default value of
1795         WKPreferencesGetHyperlinkAuditingEnabled is true.
1796
1797 2010-12-03  Chris Guillory  <chris.guillory@google.com>
1798
1799         Reviewed by Chris Fleizach.
1800
1801         Include the FrameView widget of a RenderWidget in the accessibility tree.
1802         https://bugs.webkit.org/show_bug.cgi?id=49106
1803
1804         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1805         (AccessibilityUIElement::AccessibilityUIElement):
1806         (AccessibilityUIElement::parentElementCallback):
1807         (AccessibilityUIElement::isEqualCallback):
1808         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1809         * DumpRenderTree/chromium/CppBoundClass.cpp:
1810         (CppBoundClass::getFromCppVariant):
1811         * DumpRenderTree/chromium/CppBoundClass.h:
1812
1813 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1814
1815         Reviewed by Tony Chang.
1816
1817         Rebaseline server: organize tests by state, add dry run mode
1818         https://bugs.webkit.org/show_bug.cgi?id=50473
1819         
1820         Group tests in the menu by state, so that it's easier to see after
1821         processing the queue which failed.
1822         
1823         Add support for the --dry-run flag so that it's easier to test changes
1824         such as this (stubs out filesystem and SCM operations).
1825
1826         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1827         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1828         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1829
1830 2010-12-03  Brady Eidson  <beidson@apple.com>
1831
1832         Reviewed by Anders Carlsson.
1833
1834         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
1835         WebKit2 Authentication Support
1836
1837         Keep these builds working:
1838         * MiniBrowser/mac/BrowserWindowController.m:
1839         (-[BrowserWindowController awakeFromNib]):
1840
1841         * WebKitTestRunner/TestController.cpp:
1842         (WTR::TestController::initialize):
1843
1844 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
1845
1846         Reviewed by Tony Chang.
1847
1848         Rebaseline server: move existing baselines
1849         https://bugs.webkit.org/show_bug.cgi?id=50421
1850         
1851         Implement moving of existing baselines: move all files that are about
1852         to be overwriten by update baselines.
1853         
1854         Also fix a typo in the UI JS.
1855
1856         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1857         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1858         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1859
1860 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1861
1862         Unreviewed, rolling out r73211.
1863         http://trac.webkit.org/changeset/73211
1864         https://bugs.webkit.org/show_bug.cgi?id=50450
1865
1866         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
1867         yutak on #webkit).
1868
1869         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1870
1871 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1872
1873         Unreviewed, rolling out r73222.
1874         http://trac.webkit.org/changeset/73222
1875         https://bugs.webkit.org/show_bug.cgi?id=50449
1876
1877         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1878         (Requested by yutak on #webkit).
1879
1880         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1881         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1882         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1883         * Scripts/webkitpy/layout_tests/port/base.py:
1884         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1885         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1886
1887 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1888
1889         Unreviewed, rolling out r73228.
1890         http://trac.webkit.org/changeset/73228
1891         https://bugs.webkit.org/show_bug.cgi?id=50448
1892
1893         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1894         (Requested by yutak on #webkit).
1895
1896         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1897         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1898         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1899         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1900         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1901
1902 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1903
1904         Unreviewed, rolling out r73231.
1905         http://trac.webkit.org/changeset/73231
1906         https://bugs.webkit.org/show_bug.cgi?id=50443
1907
1908         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
1909         (Requested by yutak on #webkit).
1910
1911         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1912         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1913         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1914         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1915
1916 2010-12-03  David Levin  <levin@chromium.org>
1917
1918         Reviewed by Shinichiro Hamaji.
1919
1920         check-webkit-style: false positive reported for #if macro
1921         https://bugs.webkit.org/show_bug.cgi?id=48242
1922
1923         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
1924           all preprocessor commands.
1925         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
1926
1927 2010-12-02  Eric Seidel  <eric@webkit.org>
1928
1929         Reviewed by Adam Barth.
1930
1931         Update the EWSTools scripts to use modern-style git repos
1932         https://bugs.webkit.org/show_bug.cgi?id=50402
1933
1934         * EWSTools/create-webkit-git:
1935         * EWSTools/start-commit-queue.sh:
1936         * EWSTools/start-queue.sh:
1937
1938 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
1939
1940         Fix Chromium Linux plugin tests by not logging
1941         unconditionally from the event handling code.
1942
1943         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1944         (handleEventX11):
1945
1946 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
1947
1948         Reviewed by Tony Chang.
1949
1950         nrwt multiprocessing - move logic back into run_webkit_tests
1951
1952         This change moves a bunch of logic that I had put into
1953         message_broker back into run_webkit_tests, in a slightly
1954         different format. WorkerMessageBroker needed to become less aware of
1955         the logic the TestRunner class uses, and more generic.
1956         Eventually the MessageBroker will only do generic messaging and
1957         thread/process-pooling, and (almost) all of the
1958         run-webkit-tests-specific logic will be moved to
1959         run_webkit_tests.py and dump_render_tree_thread.py.
1960         
1961         The biggest changes are that the Broker can now start a single
1962         worker, but the responsibility for starting all of them is pushed
1963         back to the TestRunner (Manager), and the logic for checking if
1964         the threads are done or wedged is moved back to TestRunner. We
1965         also remove WorkerMessageBroker.cleanup (not needed) and
1966         cancel_workers (they have to be cancelled individually).
1967         
1968         The  message_broker is now encapsulated inside
1969         TestRunner._run_tests(); it only needs to exist while actually
1970         running the tests.
1971
1972         Also, delete a bunch of tests in message_broker_unittest that no
1973         longer make much sense.
1974
1975         This patch depends on bug 50372.
1976
1977         https://bugs.webkit.org/show_bug.cgi?id=50374
1978
1979         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1980         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1981         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1982         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1983         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1984
1985 2010-12-02  Hayato Ito  <hayato@chromium.org>
1986
1987         Reviewed by Eric Seidel.
1988
1989         Refactor test_types's compare_output() method so that it takes a
1990         TestInput object.
1991
1992         compare_output() will need additional information included in a TestInput
1993         object to support reftests. This change is a pre-requirement of that.
1994
1995         https://bugs.webkit.org/show_bug.cgi?id=50362
1996
1997         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1998         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1999         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2000         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2001         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2002
2003 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2004
2005         Reviewed by Anders Carlsson.
2006
2007         Add the ability to run script on 'new' and 'paint' in the test plugin
2008         https://bugs.webkit.org/show_bug.cgi?id=50425
2009         
2010         Add "onnew" and "onpaintevent" attributes to the test plugin,
2011         so that tests can run JS at these times.
2012
2013         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2014         (pluginAllocate):
2015         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2016         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2017         (NPP_New):
2018         (NPP_Destroy):
2019         (handleEventCarbon):
2020         (handleEventCocoa):
2021         (NPP_HandleEvent):
2022
2023 2010-12-02  Sam Weinig  <sam@webkit.org>
2024
2025         Fix Qt build.
2026
2027         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2028         (WTR::PlatformWebView::PlatformWebView):
2029
2030 2010-12-02  Sam Weinig  <sam@webkit.org>
2031
2032         Reviewed by Anders Carlsson.
2033
2034         WebKit2 Preferences should be held off the PageGroup, not the Context
2035         https://bugs.webkit.org/show_bug.cgi?id=50414
2036
2037         Update for API changes.
2038
2039         * WebKitTestRunner/PlatformWebView.h:
2040         * WebKitTestRunner/TestController.cpp:
2041         (WTR::createOtherPage):
2042         (WTR::TestController::initialize):
2043         (WTR::TestController::resetStateToConsistentValues):
2044         * WebKitTestRunner/TestController.h:
2045         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2046         (WTR::PlatformWebView::PlatformWebView):
2047         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2048         (WTR::PlatformWebView::PlatformWebView):
2049
2050 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2051
2052         Reviewed by Tony Chang.
2053
2054         new-run-webkit-tests: minor cleanup for multiprocessing work
2055
2056         This change:
2057         * moves worker naming into TestShellThread, eliminating a
2058           parameter to the constructor and putting the responsibility in
2059           the correct place.
2060         * eliminates the _WorkerState() class in message_broker, because
2061           it turns out that state really needs to be in run_webkit_tests
2062         * renames the Broker classes to be module-private.
2063         * fixes a bunch of minor commenting and whitespace issues to
2064           make subsequent patches a bit clearer.
2065         * Adds a Port hook for default_worker_model() so that we can
2066           accomodate the potential for different worker models on
2067           different ports.
2068         * merge in the fix from 50420 for the brokenness introduced in
2069           bug 50367.
2070
2071         This patch depends on bug 50367.
2072
2073         https://bugs.webkit.org/show_bug.cgi?id=50372
2074
2075         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2076         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2077         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2078         * Scripts/webkitpy/layout_tests/port/base.py:
2079         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2080         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2081
2082 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2083
2084         Reviewed by Tony Chang.
2085
2086         This change is a bunch of cleanup / refactoring of the file
2087         below. It moves a bunch of free functions to methods on the
2088         TestShellThread class, and restructures other methods to be
2089         closer to the structure we'll need for the multiprocessing
2090         rewrite.
2091
2092         It also makes the logic of --run-singly a *lot* easier to follow
2093         by nestling all of the separate-thread logic into a single
2094         routine.
2095
2096         There should be no semantic changes in this patch, just cleanup.
2097
2098         https://bugs.webkit.org/show_bug.cgi?id=50367
2099
2100         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2101
2102 2010-12-02  Tony Chang  <tony@chromium.org>
2103
2104         Unreviewed, rolling out r73164.
2105         http://trac.webkit.org/changeset/73164
2106         https://bugs.webkit.org/show_bug.cgi?id=50359
2107
2108         broke debugger tests on win
2109
2110         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2111
2112 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2113
2114         Reviewed by Tony Chang.
2115
2116         Rebaseline server: add updating of baselines
2117         https://bugs.webkit.org/show_bug.cgi?id=50305
2118         
2119         Implements updating of baselines, where we copy -actual.* files over
2120         the current -expected.* files. To do this, we need a
2121         _get_actual_result_files method to get test results files and a
2122         _rebaseline_test method to actually do the file copy and SCM operation.
2123         _rebaseline_test logs output into a buffer, this is useful for both
2124         showing result in the UI and for unit tests.
2125         
2126         To make passing around of the various test environment properties
2127         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2128         class for them.
2129         
2130         Moving of existing baselines is not implemented yet, this patch is big
2131         enough as it is.
2132
2133         * Scripts/webkitpy/common/system/filesystem.py:
2134         * Scripts/webkitpy/common/system/filesystem_mock.py:
2135         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2136         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2137         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2138         * Scripts/webkitpy/tool/mocktool.py:
2139
2140 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2141
2142         Unreviewed build fix after vcproj updates.
2143
2144         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2145         that WIN_CAIRO is defined for this build.
2146         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2147         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2148         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2149
2150 2010-12-02  Sam Weinig  <sam@webkit.org>
2151
2152         Reviewed by Anders Carlsson.
2153
2154         WebKit2 needs API to turn on popup blocking
2155         https://bugs.webkit.org/show_bug.cgi?id=50407
2156
2157         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2158         (TestWebKitAPI::TEST):
2159         * WebKitTestRunner/TestController.cpp:
2160         (WTR::TestController::resetStateToConsistentValues):
2161
2162 2010-12-01  Tony Chang  <tony@chromium.org>
2163
2164         Reviewed by Ojan Vafai.
2165
2166         [chromium] force NRWT to use DRT
2167         https://bugs.webkit.org/show_bug.cgi?id=50359
2168
2169         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2170
2171 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2172
2173         Reviewed by Xan Lopez.
2174
2175         [GTK] DumpRenderTree has two copies of JavaScriptCore
2176         https://bugs.webkit.org/show_bug.cgi?id=49877
2177
2178         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2179         LDADD list for DumpRenderTree.
2180
2181 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2182
2183         Unreviewed: Added myself to list of Committers.
2184
2185         * Scripts/webkitpy/common/config/committers.py:
2186
2187 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2188
2189         Reviewed by Adam Barth.
2190
2191         build-webkit --chromium always updates DEPS and re-generates project files
2192         https://bugs.webkit.org/show_bug.cgi?id=50340
2193         
2194         Make build-webkit --chromium invoke update-webkit-chromium only when
2195         --update-chromium is passed in, so that we don't add 20 seconds to all
2196         builds.
2197         
2198         Making all invocations update was added with r61883, with the goal of
2199         making EWS bots always update. The bots will switch to using this flag
2200         (as will all other webkit-patch build steps) so nothing should change
2201         for them.
2202
2203         * Scripts/webkitdirs.pm:
2204         * Scripts/webkitpy/common/config/ports.py:
2205         * Scripts/webkitpy/common/config/ports_unittest.py:
2206
2207 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2208
2209         Reviewed by Tony Chang.
2210
2211         new-run-webkit-tests: add a --dry-run / -n flag
2212         https://bugs.webkit.org/show_bug.cgi?id=50045
2213
2214         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2215         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2216
2217 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2218
2219         Reviewed by Adam Roben.
2220
2221         WinCairo build should not use link-time code generation (LTCG)
2222         https://bugs.webkit.org/show_bug.cgi?id=50353
2223
2224         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2225         * DumpRenderTree/win/DumpRenderTree.vcproj:
2226         * DumpRenderTree/win/ImageDiff.vcproj:
2227         * FindSafari/FindSafari.vcproj:
2228         * MiniBrowser/MiniBrowser.vcproj:
2229         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2230         * WebKitAPITest/WebKitAPITest.vcproj:
2231         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2232         * WebKitTestRunner/win/InjectedBundle.vcproj:
2233         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2234         * WinLauncher/WinLauncher.vcproj:
2235         * record-memory-win/record-memory-win.vcproj:
2236
2237 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2238
2239         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2240         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2241         adding the file to the sources list was not enough to force the rebuild.
2242
2243         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2244         Remove an empty line at the end of this file to force a rebuild.
2245
2246 2010-12-01  Sam Weinig  <sam@webkit.org>
2247
2248         Fix windows build.
2249
2250         * MiniBrowser/win/BrowserView.cpp:
2251         (BrowserView::create):
2252
2253 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2254
2255         Add missing file to the TestNetscapePlugin sources list after r73057.
2256
2257         * GNUmakefile.am: Add missing file.
2258
2259 2010-12-01  Sam Weinig  <sam@webkit.org>
2260
2261         Reviewed by Anders Carlsson.
2262
2263         Add PageGrouping to WebKit2 API
2264         https://bugs.webkit.org/show_bug.cgi?id=50332
2265
2266         - Update testing harnesses to deal with new PageGroup API.
2267
2268         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2269         (WKBundleInitialize):
2270         * TestWebKitAPI/InjectedBundleController.cpp:
2271         (TestWebKitAPI::InjectedBundleController::initialize):
2272         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2273         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2274         * TestWebKitAPI/InjectedBundleController.h:
2275         * TestWebKitAPI/InjectedBundleTest.h:
2276         (TestWebKitAPI::InjectedBundleTest::initialize):
2277         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2278         * TestWebKitAPI/PlatformUtilities.cpp:
2279         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2280         * TestWebKitAPI/PlatformUtilities.h:
2281         * TestWebKitAPI/PlatformWebView.h:
2282         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2283         (TestWebKitAPI::TEST):
2284         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2285         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2286         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2287         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2288         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2289         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2290         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2291         (WTR::InjectedBundle::didInitializePageGroup):
2292         (WTR::InjectedBundle::initialize):
2293         (WTR::InjectedBundle::beginTesting):
2294         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2295         (WTR::InjectedBundle::pageGroup):
2296         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2297         (WTR::LayoutTestController::addUserScript):
2298         (WTR::LayoutTestController::addUserStyleSheet):
2299         (WTR::LayoutTestController::setXSSAuditorEnabled):
2300         * WebKitTestRunner/TestController.cpp:
2301         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2302         (WTR::PlatformWebView::PlatformWebView):
2303
2304 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2305
2306         Reviewed by Adam Roben.
2307
2308         vcproj changes can't be applied cleanly by the Windows EWS bot
2309         https://bugs.webkit.org/show_bug.cgi?id=50328
2310
2311         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2312         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2313         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2314         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2315         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2316         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2317         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2318         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2319         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2320         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2321         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2322         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2323         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2324         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2325         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2326         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2327         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2328         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2329         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2330         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2331         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2332         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2333         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2334         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2335         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2336         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2337         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2338         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2339         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2340         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2341         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2342         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2343         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2344         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2345         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2346         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2347         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2348         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2349         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2350         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2351         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2352         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2353         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2354         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2355         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2356
2357 2010-12-01  Anders Carlsson  <andersca@apple.com>
2358
2359         Reviewed by Darin Adler.
2360
2361         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2362         https://bugs.webkit.org/show_bug.cgi?id=50336
2363
2364         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2365         Add new test.
2366
2367         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2368         (PluginTest::NPP_New):
2369         Add default implementation/
2370
2371         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2372         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2373         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2374         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2375         Get the user agent.
2376
2377         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2378         (NPP_New):
2379         Call PluginTest::NPP_New.
2380
2381         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2382         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2383         Add new files.
2384
2385         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2386         (webkit_test_plugin_new_instance):
2387         Call PluginTest::NPP_New.
2388
2389 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2390
2391         [wx] Build fixes after recent trunk changes.
2392
2393         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2394         (LayoutTestController::findString):
2395         * wx/build/settings.py:
2396
2397 2010-12-01  Dan Bernstein  <mitz@apple.com>
2398
2399         Reviewed by Darin Adler.
2400
2401         WebKitTestRunner needs layoutTestController.findString
2402         https://bugs.webkit.org/show_bug.cgi?id=50238
2403
2404         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2405         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2406         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2407         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2408
2409 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2410
2411         Try using svn:eol-style native on a vcproj file.
2412
2413         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2414
2415 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2416
2417         Reviewed by Adam Roben.
2418
2419         [WINCE] Add WinCELauncher
2420         https://bugs.webkit.org/show_bug.cgi?id=50217
2421
2422         * WinCELauncher/main.cpp: Added.
2423
2424 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2425
2426         Reviewed by Kenneth Rohde Christiansen.
2427
2428         [Qt] Implement layoutTestController.findString
2429         https://bugs.webkit.org/show_bug.cgi?id=50236
2430
2431         Add the missing function to the LayoutTestController.
2432
2433         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2434         (LayoutTestController::findString):
2435         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2436
2437 2010-11-30  Tony Chang  <tony@chromium.org>
2438
2439         Reviewed by Adam Barth.
2440
2441         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2442         https://bugs.webkit.org/show_bug.cgi?id=49036
2443
2444         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2445             for CppVariants.
2446         (LayoutTestController::cppVariantToBool):
2447         (LayoutTestController::cppVariantToInt32):
2448         (LayoutTestController::setDatabaseQuota):
2449         (LayoutTestController::evaluateInWebInspector):
2450         (LayoutTestController::setMockGeolocationError):
2451
2452 2010-11-30  Eric Seidel  <eric@webkit.org>
2453
2454         Reviewed by Tony Chang.
2455
2456         update-webkit should call git fetch before git svn rebase
2457         https://bugs.webkit.org/show_bug.cgi?id=50273
2458
2459         After discussion on webkit-dev, we've decided to move the "default"
2460         git setup to pulling updates from git.webkit.org in preference
2461         to rebuilding the local svn index using git svn fetch every time.
2462
2463         This change should have no effect on people using the "old" git setup
2464         and should dramatically increase the speed of updates for those using
2465         the "new" git setup along with update-webkit.  I'm about to move the
2466         EWS and other queues over to this setup once this lands.
2467
2468         * Scripts/update-webkit:
2469
2470 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2471
2472         Reviewed by Xan Lopez.
2473
2474         GTK: AX: implement press in DRT
2475         https://bugs.webkit.org/show_bug.cgi?id=36146
2476
2477         Implement AccessibilityUIElement::press() for GTK.
2478
2479         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2480         (AccessibilityUIElement::press): Implemented.
2481
2482 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2483
2484         Reviewed by Tony Chang.
2485
2486         config.webkit_base_dir returns a path with a trailing slash
2487         https://bugs.webkit.org/show_bug.cgi?id=50197
2488         
2489         config.webkit_base_dir() should return a path without a trailing slash,
2490         like all the other methods that return paths.
2491         
2492         Undoes MockFileSytem changes by r72640, since they're no longer
2493         necessary for GetBaselinesTest to pass.
2494
2495         * Scripts/webkitpy/common/system/filesystem_mock.py:
2496         * Scripts/webkitpy/layout_tests/port/base.py:
2497         * Scripts/webkitpy/layout_tests/port/config.py:
2498         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2499
2500 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2501
2502         Reviewed by Tony Chang.
2503
2504         Rebaseline server: baseline display tweaks
2505         https://bugs.webkit.org/show_bug.cgi?id=50207
2506         
2507         Determine which baselines were used when running the tests and highlight
2508         them in the UI. Sort platform names alphabetically.
2509         
2510         Also makes the server URL be launched in the user's browser
2511         automatically.
2512
2513         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2514         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2515         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2516         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2517         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2518
2519 2010-11-30  Dan Bernstein  <mitz@apple.com>
2520
2521         Reviewed by Anders Carlsson.
2522
2523         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2524         https://bugs.webkit.org/show_bug.cgi?id=50238
2525
2526         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2527         (WTR::LayoutTestController::findString): Added.
2528         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2529
2530 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2531
2532         Reviewed by Adam Roben.
2533
2534         All projects on Windows should use cmd files for build events
2535         https://bugs.webkit.org/show_bug.cgi?id=50213
2536
2537         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2538         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2539         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2540         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2541         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2542         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2543         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2544         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2545         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2546         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2547         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2548         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2549         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2550         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2551         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2552         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2553         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2554         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2555         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2556         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2557         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2558         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2559         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2560         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2561         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2562         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2563         * WinLauncher/WinLauncherCommon.vsprops:
2564         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2565         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2566
2567 2010-11-29  Dan Bernstein  <mitz@apple.com>
2568
2569         GTK DumpRenderTree build fix after r72887.
2570
2571         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2572         (LayoutTestController::findString):
2573
2574 2010-11-29  Dan Bernstein  <mitz@apple.com>
2575
2576         Windows DumpRenderTree build fix after r72887.
2577
2578         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2579         (LayoutTestController::findString): Added empty implementation.
2580
2581 2010-11-29  Dan Bernstein  <mitz@apple.com>
2582
2583         Reviewed by Darin Adler.
2584
2585         DumpRenderTree changes for testing the text search API.
2586         https://bugs.webkit.org/show_bug.cgi?id=50038
2587
2588         * DumpRenderTree/LayoutTestController.cpp:
2589         (findStringCallback):
2590         (LayoutTestController::staticFunctions):
2591         * DumpRenderTree/LayoutTestController.h:
2592         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2593         (LayoutTestController::findString):
2594         * MiniBrowser/mac/BrowserWindowController.m:
2595         (-[BrowserWindowController find:]):
2596
2597 2010-11-29  Johnny Ding  <jnd@chromium.org>
2598
2599         Unreviewed: Add myself to the list of Committers.
2600
2601         * Scripts/webkitpy/common/config/committers.py:
2602
2603 2010-11-29  Mark Rowe  <mrowe@apple.com>
2604
2605         Reviewed by Adele Peterson.
2606
2607         <rdar://problem/8694997> DumpRenderTree fails to build.
2608
2609         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2610
2611 2010-11-29  Mark Rowe  <mrowe@apple.com>
2612
2613         Reviewed by Adele Peterson.
2614
2615         <rdar://problem/8694997> DumpRenderTree fails to build.
2616
2617         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2618         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2619         * DumpRenderTree/mac/PerlSupport/Makefile:
2620
2621 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2622
2623         Reviewed by Martin Robinson.
2624
2625         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2626         https://bugs.webkit.org/show_bug.cgi?id=50154
2627
2628         Added missing checks to allAttributes().
2629
2630         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2631         (AccessibilityUIElement::allAttributes): Added missing checks.
2632
2633 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2634
2635         Reviewed by Kenneth Rohde Christiansen.
2636
2637         [Qt] Allow pre-generation for package builds for WebKit2
2638         https://bugs.webkit.org/show_bug.cgi?id=50139
2639
2640         Use a build variable for the generated directory path and set the
2641         value based on CONFIG just like for WebKit1.
2642
2643         For non-package builds use a relative base path for the
2644         genrated directory just like for WebKit1.
2645
2646         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2647         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2648
2649 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2650
2651         Reviewed by Kenneth Rohde Christiansen.
2652
2653         [Qt] Move some build logic from Qt to platform independent code
2654         https://bugs.webkit.org/show_bug.cgi?id=50134
2655
2656         Create target directories inside generate-forwarding-headers.pl.
2657
2658         * Scripts/generate-forwarding-headers.pl:
2659
2660 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2661
2662         Reviewed by Martin Robinson.
2663
2664         [GTK] Windowless plugins gets broken key input
2665         https://bugs.webkit.org/show_bug.cgi?id=49927
2666
2667         Convert the XEvent::keycode to ASCII before printing it. Not
2668         doing this was causing false positive in 
2669         plugins/keyboard-events.html.
2670
2671         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2672         (keycode_to_char):
2673         (webkit_test_plugin_handle_event):
2674
2675 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2676
2677         Reviewed by Antonio Gomes.
2678
2679         [Qt] Html autofocus not working with QGraphicsWebView
2680         https://bugs.webkit.org/show_bug.cgi?id=43169
2681
2682         Tell the scene to set the webview item as the currently
2683         focused item. This makes the input field with autofocus get
2684         focus as it should.
2685
2686         * QtTestBrowser/webview.cpp:
2687         (WebViewGraphicsBased::WebViewGraphicsBased):
2688
2689 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2690
2691         Reviewed by Tony Chang.
2692
2693         nrwt - clean up create_driver interface and print out the
2694         command line used for DumpRenderTree/TestShell.
2695
2696         This patch adds a driver_cmd_line() call to the Port class in
2697         order to retrive the command line to print it out (as part of
2698         --print config).
2699
2700         In addition, this patch cleans up the Port.create_driver()
2701         signature and the Driver constructor interface to take a worker
2702         number and no longer require the image_path argument (Chromium's
2703         drivers now synthesize the image_path from the worker number
2704         internally).
2705
2706         https://bugs.webkit.org/show_bug.cgi?id=49934
2707
2708         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2709         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2710         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2711         * Scripts/webkitpy/layout_tests/port/base.py:
2712         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2713         * Scripts/webkitpy/layout_tests/port/chromium.py:
2714         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2715         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2716         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2717         * Scripts/webkitpy/layout_tests/port/test.py:
2718         * Scripts/webkitpy/layout_tests/port/webkit.py:
2719         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2720         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2721
2722 2010-11-24  Ojan Vafai  <ojan@chromium.org>
2723
2724         Reviewed by Tony Chang.
2725
2726         [chromium] improve memory usage for test results server and store fewer runs
2727         https://bugs.webkit.org/show_bug.cgi?id=50035
2728
2729         Store fewer runs and don't pass full files around when we only need bools.
2730         Greatly improves error rates on test-results.appspot.com.
2731
2732         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2733         * TestResultServer/handlers/testfilehandler.py:
2734         * TestResultServer/model/dashboardfile.py:
2735         * TestResultServer/model/jsonresults.py:
2736
2737 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2738
2739         Reviewed by Tony Chang.
2740
2741         This patch implements the first part of the manager side of the
2742         Broker objects - it handles creating threads, waiting for them
2743         to complete, and running a single-threaded loop as well.
2744
2745         https://bugs.webkit.org/show_bug.cgi?id=49779
2746
2747         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2748         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2749         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2750         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2751
2752 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
2753
2754         Reviewed by David Levin.
2755
2756         DRT should not generate pixel output for text/plain tests
2757         https://bugs.webkit.org/show_bug.cgi?id=50002
2758         
2759         Modify Mac, Windows and GTK DRT implementations to disable pixel output
2760         when encountering a text/plain response (the Chromium one already does
2761         this, and none of the other ports special-case text/plain output in
2762         the first place).
2763
2764         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2765         (dump):
2766         * DumpRenderTree/mac/DumpRenderTree.mm:
2767         (dump):
2768         * DumpRenderTree/win/DumpRenderTree.cpp:
2769         (dump):
2770
2771 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2772
2773         Unreviewed.
2774
2775         Add my other email address to committers.py.
2776
2777         * Scripts/webkitpy/common/config/committers.py:
2778
2779 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2780
2781         Reviewed by Csaba Osztrogonác.
2782
2783         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
2784         https://bugs.webkit.org/show_bug.cgi?id=49975
2785
2786         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
2787         to enable the script to define it 0 in case of a minimal build.
2788
2789 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
2790
2791         Reviewed by Xan Lopez.
2792
2793         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
2794         https://bugs.webkit.org/show_bug.cgi?id=49143
2795
2796         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2797         (createWebView): Call the new connectEditingCallbacks function.
2798         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
2799         (dumpNodePath):
2800         (dumpRange):
2801         (insertActionString):
2802         (selectionAffinityString):
2803         (shouldBeginEditing):
2804         (shouldEndEditing):
2805         (shouldInsertNode):
2806         (shouldInsertText):
2807         (shouldDeleteRange):
2808         (shouldShowDeleteInterfaceForElement):
2809         (shouldChangeSelectedRange):
2810         (shouldApplyStyle):
2811         (editingBegan):
2812         (userChangedContents):
2813         (editingEnded):
2814         (selectionChanged):
2815         (connectEditingCallbacks):
2816         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
2817         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
2818
2819 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
2820
2821         Reviewed by Andreas Kling.
2822
2823         [Qt] Make QtTestBrowser remember the selected user agent
2824         https://bugs.webkit.org/show_bug.cgi?id=50021
2825
2826         Set user agent for a new page by using the old page's
2827
2828         * QtTestBrowser/mainwindow.cpp:
2829         (MainWindow::setPage):
2830
2831 2010-11-24 Patrick Gansterer <paroga@webkit.org>
2832
2833         Reviewed by Csaba Osztrogonác.
2834
2835         Remove Bakefile build system files
2836         https://bugs.webkit.org/show_bug.cgi?id=49983
2837
2838         r53757 only removed the content, but not the files.
2839         This patch removes that empty files.
2840
2841         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
2842         * wx/browser/browser.bkl: Removed.
2843         * wx/build-wxwebkit: Removed.
2844
2845 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
2846
2847         Reviewed by Tony Chang.
2848
2849         This patch cleans up the logic used to shard tests into groups a
2850         bit and adds the --worker-model flag to NRWT. The flag is only
2851         used at the moment to control whether to run single-threaded or
2852         not, but eventually will also allow toggling between threads and
2853         processes.
2854
2855         Also add a minor cleanup with _test_is_slow(), which just
2856         eliminates some repetition and gives slightly better encapsulation.
2857
2858         https://bugs.webkit.org/show_bug.cgi?id=49773
2859
2860         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2861         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2862
2863 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
2864
2865         Reviewed by Tony Chang.
2866
2867         Rebaseline server: list current baselines and platforms
2868         https://bugs.webkit.org/show_bug.cgi?id=49991
2869         
2870         List existing baselines (with Trac links) for tests.
2871         
2872         Add dropdowns for choosing with platform baselines to target (and what
2873         to do with existing ones).
2874
2875         Also fix MockFileSystem.join to behave more like os.path.join (unit
2876         test was ending up with two consecutive slashes in a layout test
2877         path).        
2878
2879         * Scripts/webkitpy/common/system/filesystem_mock.py:
2880         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2881         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2882         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2883         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2884         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2885         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2886         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
2887
2888 2010-11-23  Ojan Vafai  <ojan@chromium.org>
2889
2890         Reviewed by Tony Chang.
2891
2892         remove timeout argument to urlopen
2893         https://bugs.webkit.org/show_bug.cgi?id=49995
2894
2895         Apparently the version of python we have on the bots doesn't accept a timeout argument.
2896
2897         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2898
2899 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2900
2901         Unreviewed, rolling out r72628.
2902         http://trac.webkit.org/changeset/72628
2903         https://bugs.webkit.org/show_bug.cgi?id=49994
2904
2905         This patch is causing layout-test failtures on GTK Linux
2906         64-bit Debug (Requested by ctguil on #webkit).
2907
2908         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2909         (AccessibilityUIElement::AccessibilityUIElement):
2910         (AccessibilityUIElement::parentElementCallback):
2911         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2912         * DumpRenderTree/chromium/CppBoundClass.cpp:
2913         * DumpRenderTree/chromium/CppBoundClass.h:
2914
2915 2010-11-22  Ojan Vafai  <ojan@chromium.org>
2916
2917         Reviewed by Tony Chang.
2918
2919         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
2920         https://bugs.webkit.org/show_bug.cgi?id=49944
2921
2922         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2923
2924 2010-11-23  Chris Guillory  <chris.guillory@google.com>
2925
2926         Reviewed by Dimitri Glazkov.
2927
2928         Include the FrameView widget of a RenderWidget in the accessibility tree.
2929         https://bugs.webkit.org/show_bug.cgi?id=49106
2930
2931         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2932         (AccessibilityUIElement::AccessibilityUIElement):
2933         (AccessibilityUIElement::parentElementCallback):
2934         (AccessibilityUIElement::isEqualCallback):
2935         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2936         * DumpRenderTree/chromium/CppBoundClass.cpp:
2937         (CppBoundClass::getFromCppVariant):
2938         * DumpRenderTree/chromium/CppBoundClass.h:
2939
2940 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
2941
2942         Reviewed by Kenneth Rohde Christiansen.
2943
2944         [EFL] Add tiled backing store to EWebLauncher
2945         https://bugs.webkit.org/show_bug.cgi?id=45777
2946
2947         Allow EWebLauncher to choose between single and tiled backing store
2948
2949         * EWebLauncher/main.c:
2950         (on_key_down):
2951         (browserCreate):
2952         (main):
2953
2954 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2955
2956         Reviewed by Tor Arne Vestbø.
2957
2958         [Qt] Review the setUserPermission & friends API
2959         https://bugs.webkit.org/show_bug.cgi?id=46810
2960
2961         Renamed requestPermissionFromUser to featurePermissionRequested
2962         and cancelRequestsForPermission to featurePermissionRequestCanceled.
2963
2964         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2965         (WebCore::WebPage::WebPage):
2966         * QtTestBrowser/webpage.cpp:
2967         (WebPage::WebPage):
2968         (WebPage::featurePermissionRequestCanceled):
2969         * QtTestBrowser/webpage.h:
2970
2971 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2972
2973         Reviewed by Tor Arne Vestbø.
2974
2975         [Qt] Review the setUserPermission & friends API
2976         https://bugs.webkit.org/show_bug.cgi?id=46810
2977
2978         Rename setUserPermission to setFeaturePermission
2979
2980         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2981         (WebCore::WebPage::requestPermission):
2982         (WebCore::WebPage::permissionSet):
2983         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2984         (LayoutTestController::grantDesktopNotificationPermission):
2985         * QtTestBrowser/webpage.cpp:
2986         (WebPage::requestPermission):
2987
2988 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2989
2990         Reviewed by Tor Arne Vestbø.
2991
2992         [Qt] Review the setUserPermission & friends API
2993         https://bugs.webkit.org/show_bug.cgi?id=46810
2994
2995         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
2996         and GeolocationPermissionDomain to Geolocation.
2997
2998         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2999         (WebCore::WebPage::WebPage):
3000         (WebCore::WebPage::requestPermission):
3001         (WebCore::WebPage::cancelPermission):
3002         (WebCore::WebPage::permissionSet):
3003         (WebCore::DumpRenderTree::geolocationPermissionSet):
3004         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3005         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3006         (LayoutTestController::grantDesktopNotificationPermission):
3007         * QtTestBrowser/webpage.cpp:
3008         (WebPage::WebPage):
3009         (WebPage::requestPermission):
3010         (WebPage::cancelRequestsForPermission):
3011         * QtTestBrowser/webpage.h:
3012
3013 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3014
3015         Reviewed by Tor Arne Vestbø.
3016
3017         [Qt] Review the setUserPermission & friends API
3018         https://bugs.webkit.org/show_bug.cgi?id=46810
3019
3020         Add a ByUser suffix to PermissionGranted/Denied. In the future
3021         we can add PermissionGrantedByDefault.
3022
3023
3024         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3025         (WebCore::WebPage::requestPermission):
3026         (WebCore::WebPage::permissionSet):
3027         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3028         (LayoutTestController::grantDesktopNotificationPermission):
3029         * QtTestBrowser/webpage.cpp:
3030         (WebPage::requestPermission):
3031
3032 2010-11-18  Satish Sampath  <satish@chromium.org>
3033
3034         Reviewed by Jeremy Orlow.
3035
3036         For speech input event, send an event object containing all the recognition results and metadata.
3037         https://bugs.webkit.org/show_bug.cgi?id=49736
3038
3039         Updated DRT by renaming the mock result method on all platforms to the new signature.
3040
3041         * DumpRenderTree/LayoutTestController.cpp:
3042         (addMockSpeechInputResultCallback):
3043         (LayoutTestController::staticFunctions):
3044         * DumpRenderTree/LayoutTestController.h:
3045         * DumpRenderTree/chromium/LayoutTestController.cpp:
3046         (LayoutTestController::LayoutTestController):
3047         (LayoutTestController::addMockSpeechInputResult):
3048         * DumpRenderTree/chromium/LayoutTestController.h:
3049         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3050         (LayoutTestController::addMockSpeechInputResult):
3051         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3052         (LayoutTestController::addMockSpeechInputResult):
3053         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3054         (LayoutTestController::addMockSpeechInputResult):
3055         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3056         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3057         (LayoutTestController::addMockSpeechInputResult):
3058         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3059         (LayoutTestController::addMockSpeechInputResult):
3060
3061 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3062
3063         Reviewed by Tony Chang.
3064
3065         Fix some spacing issues with log messages with
3066         new-run-webkit-tests --verbose.
3067
3068         https://bugs.webkit.org/show_bug.cgi?id=49936
3069
3070         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3071
3072 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3073
3074         Reviewed by Adam Barth.
3075
3076         update scm to work with different remote branches
3077         https://bugs.webkit.org/show_bug.cgi?id=49949
3078
3079         This works if there are multiple svn tracking branches
3080         and/or if the tracking branch is refs/remots/origin/master
3081         instead of refs/remotes/trunk which is the direction we're trying
3082         to head since that makes fetches faster.
3083
3084         * Scripts/webkitpy/common/checkout/scm.py:
3085         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3086
3087 2010-11-22  Hayato Ito  <hayato@chromium.org>
3088
3089         Reviewed by Shinichiro Hamaji.
3090
3091         Ignore reference files which will be used by reftests when collecting
3092         test cases.
3093         https://bugs.webkit.org/show_bug.cgi?id=49835
3094
3095         * Scripts/webkitpy/layout_tests/port/test_files.py:
3096         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3097
3098 2010-11-22  Adam Roben  <aroben@apple.com>
3099
3100         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3101
3102         Apple's Windows build allows placing header files and import libraries for WebKit's
3103         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3104         $WebKitLibrariesDir environment variable. This is both required for production builds and
3105         convenient for Apple-internal developer builds. Apple's production builds also require that
3106         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3107         builds, the files are copied into that directory tree by the
3108         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3109         copying is done by
3110         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3111
3112         This .vsprops copying is problematic in one very important case: when a developer updates
3113         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3114         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3115         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3116         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3117         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3118         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3119
3120         To fix this, we now use normal relative paths to access the .vsprops files in the source
3121         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3122         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3123         unset, so the normal relative paths are used to read the .vsprops files out of the source
3124         tree directly. In production builds, this environment variable is set to a fake directory
3125         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3126         is resolved.
3127         
3128         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3129
3130         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3131
3132         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3133         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3134         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3135         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3136         FeatureDefines.vsprops becomes:
3137
3138         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3139
3140         which resolves to:
3141
3142         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3143
3144         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3145         actually exist since they are matched by an equal number of ".." path components.)
3146
3147         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3148         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3149
3150         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3151         updated
3152
3153         Reviewed by Dave Hyatt.
3154
3155         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3156         * DumpRenderTree/win/DumpRenderTree.vcproj:
3157         * DumpRenderTree/win/ImageDiff.vcproj:
3158         * FindSafari/FindSafari.vcproj:
3159         * MiniBrowser/MiniBrowser.vcproj:
3160         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3161         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3162         * WebKitAPITest/WebKitAPITest.vcproj:
3163         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3164         * WebKitTestRunner/win/InjectedBundle.vcproj:
3165         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3166         * WinLauncher/WinLauncher.vcproj:
3167         * record-memory-win/record-memory-win.vcproj:
3168         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3169         files.
3170
3171 2010-11-22  Adam Roben  <aroben@apple.com>
3172
3173         Make it possible to run tests on Windows without Visual Studio or VC++
3174         Express installed
3175
3176         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3177         are not installed. But this function doesn't need to be called when we
3178         already have a build available and are just trying to run the tests.
3179
3180         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3181         because Visual Studio/VC++ Express aren't installed
3182
3183         Reviewed by Dave Hyatt.
3184
3185         * Scripts/webkitdirs.pm:
3186         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3187         it is not needed by this function. Also added a FIXME.
3188
3189         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3190         relying on determineConfigurationForVisualStudio doing it.
3191
3192 2010-11-19  Hayato Ito  <hayato@chromium.org>
3193
3194         Reviewed by Shinichiro Hamaji.
3195
3196         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3197
3198         https://bugs.webkit.org/show_bug.cgi?id=49812
3199
3200         * Scripts/webkitpy/layout_tests/driver_test.py:
3201         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3202         * Scripts/webkitpy/layout_tests/port/base.py:
3203         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3204         * Scripts/webkitpy/layout_tests/port/chromium.py:
3205         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3206         * Scripts/webkitpy/layout_tests/port/test.py:
3207         * Scripts/webkitpy/layout_tests/port/webkit.py:
3208         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3209         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3210
3211 2010-11-22  Hayato Ito  <hayato@chromium.org>
3212
3213         Reviewed by Tony Chang.
3214
3215         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3216
3217         https://bugs.webkit.org/show_bug.cgi?id=49924
3218
3219         * Scripts/webkitpy/layout_tests/port/chromium.py:
3220
3221 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3222
3223         Reviewed by Kenneth Rohde Christiansen.
3224
3225         Fix EWebLauncher zoom discretization
3226         https://bugs.webkit.org/show_bug.cgi?id=49810
3227
3228         * EWebLauncher/main.c:
3229         (nearest_zoom_level_get):
3230         (zoom_level_set):
3231         (on_load_finished):
3232         (on_key_down):
3233
3234 2010-11-21  Sam Weinig  <sam@webkit.org>
3235
3236         Rubber-stamped by Dan Bernstein.
3237
3238         Fix ~300 WebKit2 tests by enabling developer extras preference.
3239
3240         * WebKitTestRunner/TestController.cpp:
3241         (WTR::TestController::resetStateToConsistentValues):
3242
3243 2010-11-21  Sam Weinig  <sam@webkit.org>
3244
3245         Reviewed by Dan Bernstein.
3246
3247         Textareas should be resizable by default
3248         https://bugs.webkit.org/show_bug.cgi?id=49892
3249
3250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3251         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3252         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3253         Add preferences test.
3254
3255 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3256
3257         Reviewed by Tony Chang.
3258
3259         Rebaseline server: checksum-only differences and prefetching
3260         https://bugs.webkit.org/show_bug.cgi?id=49841
3261         
3262         Add support for image test results where the only difference is in the
3263         checksum.
3264         
3265         Add prefetching of the image results from the next test.
3266         
3267         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3268         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3269         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3270
3271 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3272
3273         Reviewed by Tony Chang.
3274
3275         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3276
3277         Add the 'worker number' and 'worker name' concepts to the 
3278         TestShellThread objects, and move test_types and test_args from
3279         the TestRunner to the TestShellThread.
3280
3281         https://bugs.webkit.org/show_bug.cgi?id=49768
3282
3283         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3284         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3285
3286 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3287
3288         Reviewed by Ojan Vafai.
3289
3290         Do some minor cleanup and bug fixing.
3291
3292         https://bugs.webkit.org/show_bug.cgi?id=49777
3293
3294         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3295         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3296
3297 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3298
3299         Reviewed by Ojan Vafai.
3300
3301         nrwt - config.build_directory() is busted
3302
3303         Fixes a typo that was causing us to usually return the top level
3304         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3305         bug was hidden by test stubs that were too simplistic :(.
3306
3307         https://bugs.webkit.org/show_bug.cgi?id=49815
3308
3309         * Scripts/webkitpy/common/system/executive_mock.py:
3310         * Scripts/webkitpy/layout_tests/port/config.py:
3311         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3312
3313 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3314
3315         Reviewed by Adam Roben.
3316
3317         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3318         https://bugs.webkit.org/show_bug.cgi?id=49819
3319
3320         * DumpRenderTree/DumpRenderTree.sln:
3321         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3322         * DumpRenderTree/win/DumpRenderTree.vcproj:
3323         * DumpRenderTree/win/ImageDiff.vcproj:
3324         * FindSafari/FindSafari.vcproj:
3325         * MiniBrowser/MiniBrowser.vcproj:
3326         * TestWebKitAPI/win/TestWebKitAPI.sln:
3327         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3328         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3329         * WebKitAPITest/WebKitAPITest.vcproj:
3330         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3331         * WebKitTestRunner/win/InjectedBundle.vcproj:
3332         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3333         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3334         * WinLauncher/WinLauncher.vcproj:
3335         * record-memory-win/record-memory-win.vcproj:
3336
3337 2010-11-19  Adam Roben  <aroben@apple.com>
3338
3339         Add some more Windows slaves
3340
3341         This is probably more than we will be using in the immediate future,
3342         but having some extra slave names makes experimenting with different
3343         configurations easier.
3344
3345         Reviewed by Jon Honeycutt.
3346
3347         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3348         Windows slaves and distributed them among the three different Test
3349         builders.
3350
3351 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3352
3353         Reviewed by Ojan Vafai.
3354
3355         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3356         https://bugs.webkit.org/show_bug.cgi?id=49702
3357
3358         Re-landing r72357 with a test fix.
3359
3360         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3361         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3362         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3363
3364 2010-11-19  Avi Drissman  <avi@google.com>
3365
3366         Reviewed by Antonio Gomes.
3367
3368         Complete support for Unix editing mode
3369         https://bugs.webkit.org/show_bug.cgi?id=49757
3370
3371         * DumpRenderTree/LayoutTestController.cpp:
3372         (setEditingBehaviorCallback):
3373         * DumpRenderTree/chromium/LayoutTestController.cpp:
3374         (LayoutTestController::setEditingBehavior):
3375
3376 2010-11-19  Adam Roben  <aroben@apple.com>
3377
3378         Fix run-javascriptcore-tests when there's a space in the path to
3379         testapi
3380
3381         Reviewed by Sam Weinig.
3382
3383         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
3384         system() to force it to interpret spaces in the path correctly.
3385
3386 2010-11-19  Adam Roben  <aroben@apple.com>
3387
3388         Update scripts for .exe name changes after r72327
3389
3390         As of r72327, the "_debug" suffix is only used in Debug_All builds.
3391
3392         Reviewed by Sam Weinig.
3393
3394         * Scripts/run-javascriptcore-tests:
3395         (testapiPath):
3396
3397         * Scripts/sunspider-compare-results:
3398         (pathToBuiltJSC):
3399
3400         * Scripts/webkitdirs.pm:
3401         (jscPath):
3402         (safariPath):
3403
3404 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3405
3406         Reviewed by Darin Adler.
3407
3408         Normalize Cairo/CFLite project/solution configuration names
3409         https://bugs.webkit.org/show_bug.cgi?id=49818
3410
3411         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3412         * DumpRenderTree/win/DumpRenderTree.vcproj:
3413         * DumpRenderTree/win/ImageDiff.vcproj:
3414         * MiniBrowser/MiniBrowser.vcproj:
3415         * TestWebKitAPI/win/TestWebKitAPI.sln:
3416         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3417         * WebKitAPITest/WebKitAPITest.vcproj:
3418         * WebKitTestRunner/win/InjectedBundle.vcproj:
3419         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3420         * WinLauncher/WinLauncher.vcproj:
3421         * Scripts/webkitdirs.pm: Updated cairo build configs.
3422
3423 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3424
3425         Reviewed by Adam Roben.
3426
3427         Windows vcproj configuration names should be normalized across projects
3428         https://bugs.webkit.org/show_bug.cgi?id=49776
3429
3430         * DumpRenderTree/DumpRenderTree.sln:
3431         * FindSafari/FindSafari.vcproj:
3432         * TestWebKitAPI/win/TestWebKitAPI.sln:
3433         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3434         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
3435         * WebKitAPITest/WebKitAPITest.vcproj:
3436         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3437         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3438         * WebKitTestRunner/WebKitTestRunner.sln:
3439         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3440         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
3441         * record-memory-win/record-memory-win.vcproj:
3442
3443 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3444
3445         Build fix - as per DRT-mac, always enabled developer extras,
3446         in win/qt/gtk DRT.
3447
3448         This is necessary to enable rich exception messages to be generated
3449         following https://bugs.webkit.org/show_bug.cgi?id=49708.
3450
3451         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3452         (shouldEnableDeveloperExtras):
3453         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3454         (WebCore::shouldEnableDeveloperExtras):
3455         * DumpRenderTree/win/DumpRenderTree.cpp:
3456         (shouldEnableDeveloperExtras):
3457
3458 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3459
3460         Unreviewed, rolling out r72357.
3461         http://trac.webkit.org/changeset/72357
3462         https://bugs.webkit.org/show_bug.cgi?id=49784
3463
3464         It broke test-webkitpy tests since the patch didn't have the
3465         corresponding test update (Requested by kinuko on #webkit).
3466
3467         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3468         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3469
3470 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
3471
3472         Reviewed by Tony Chang.
3473
3474         Rebaseline server: add rebaseline queue
3475         https://bugs.webkit.org/show_bug.cgi?id=49763
3476         
3477         Add a UI queue (a multi-item <select>) where tests to be baselined
3478         can be enqueued (also supports basic removal). A queue is used instead
3479         of immediately doing rebaselines since SCM operations can take a while.
3480         It's better to go through lots of tests quickly to mark them as
3481         needing rebaselining and then batch the SCM operations.
3482         
3483         Also adds a simple log where results can be displayed.
3484
3485         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3486         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3487         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3488         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
3489         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3490         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3491
3492 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3493
3494         Reviewed by Oliver Hunt.
3495
3496         Bug 49708 - Stop recompiling functions to regenerate exception info.
3497
3498         Instead only hold info as necessary – keep divot info is the inspector
3499         is enabled, line number info is debugging or profiling, and handler
3500         info for functions with try/catch.
3501
3502         * DumpRenderTree/mac/DumpRenderTree.mm:
3503         (shouldEnableDeveloperExtras):
3504             - always enable the developer tools from DRT, to ensure we
3505               produce rich error messages on JavaScript exceptions.
3506
3507 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
3508
3509         Reviewed by Ojan Vafai.
3510
3511         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3512         https://bugs.webkit.org/show_bug.cgi?id=49702
3513
3514         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3515         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3516
3517 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
3518
3519         Reviewed by Tony Chang.
3520
3521         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
3522
3523         Create the first version of the 'message_broker' package. This
3524         class will encapsulate all of the threading/multiprocessing and
3525         message-sending details for the communication between the
3526         'manager' object and the 'worker' objects. For the moment, it
3527         just holds some routines and tests for logging thread stacks.
3528
3529         There should be no functional changes in this patch, just moving stuff
3530         around.
3531
3532         https://bugs.webkit.org/show_bug.cgi?id=49707
3533
3534         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3535         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
3536         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
3537         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
3538         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3539         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3540
3541 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3542
3543         Reviewed by Adam Roben.
3544
3545         Remove leftover Windows Debug_Internal configurations
3546         https://bugs.webkit.org/show_bug.cgi?id=49758
3547
3548         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3549         * DumpRenderTree/win/DumpRenderTree.vcproj:
3550         * DumpRenderTree/win/ImageDiff.vcproj:
3551         * MiniBrowser/MiniBrowser.vcproj:
3552         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3553         * WebKitAPITest/WebKitAPITest.vcproj:
3554         * WebKitTestRunner/win/InjectedBundle.vcproj:
3555         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3556         * WinLauncher/WinLauncher.vcproj:
3557
3558 2010-11-18  Adam Roben  <aroben@apple.com>
3559
3560         Add three new Windows XP build slaves
3561
3562         Reviewed by Steve Falkenburg.
3563
3564         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
3565         new slaves, and added them to the Windows XP Debug (Tests) builder.
3566
3567 2010-11-18  Daniel Bates  <dbates@rim.com>
3568
3569         Reviewed by Adam Roben.
3570
3571         update-webkit-support-libs should fall back to existing
3572         WebKitSupportLibrary version if there is no internet connectivity
3573         https://bugs.webkit.org/show_bug.cgi?id=49503
3574
3575         Fall back to existing support libraries (if present) when there is
3576         no internet connection.
3577
3578         Currently, update-webkit-support-libs dies with an "out-of-date"
3579         error when there is no internet connection because it cannot
3580         retrieve versioning information from developer.apple.com. Because
3581         update-webkit-support-libs fails, build-webkit fails. Instead,
3582         if there is no internet connection and the support libraries are
3583         present then we should warn the user and exit() with success so
3584         that build-webkit can work without an internet connection.
3585
3586         * Scripts/update-webkit-support-libs:
3587
3588 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3589
3590         Reviewed by Adam Roben.
3591
3592         Debug_Internal Windows configuration is unnecessary, should be removed
3593         https://bugs.webkit.org/show_bug.cgi?id=49753
3594
3595         * DumpRenderTree/win/DumpRenderTree.cpp:
3596         * MiniBrowser/win/stdafx.h:
3597         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3598         * WebKitTestRunner/win/TestControllerWin.cpp:
3599
3600 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3601
3602         Reviewed by Adam Roben.
3603
3604         Clean up vcproj errors
3605         https://bugs.webkit.org/show_bug.cgi?id=49741
3606
3607         * MiniBrowser/MiniBrowser.vcproj:
3608         * WebKitAPITest/WebKitAPITest.vcproj:
3609         * WebKitTestRunner/win/InjectedBundle.vcproj:
3610         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3611
3612 2010-11-18  Hayato Ito  <hayato@chromium.org>
3613
3614         Reviewed by Shinichiro Hamaji.
3615
3616         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
3617         which is caused by r72249.
3618
3619         https://bugs.webkit.org/show_bug.cgi?id=49751
3620
3621         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3622
3623 2010-11-18  Adam Roben  <aroben@apple.com>
3624
3625         Implement layoutTestController.waitForPolicyDelegate on Windows
3626
3627         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
3628
3629         Reviewed by Simon Fraser.
3630
3631         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3632         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
3633         code from LayoutTestControllerMac.mm.
3634
3635 2010-11-18  Hayato Ito  <hayato@chromium.org>
3636
3637         Reviewed by Shinichiro Hamaji.
3638
3639         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
3640
3641         https://bugs.webkit.org/show_bug.cgi?id=49740
3642 </