2011-06-13 Chris Rogers <crogers@google.com>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-13  Chris Rogers  <crogers@google.com>
2
3         Unreviewed build fix.
4
5         Build fix to chromium DRT until we can rebaseline some tests
6         https://bugs.webkit.org/show_bug.cgi?id=62608
7
8         * DumpRenderTree/chromium/TestShell.cpp:
9         (TestShell::TestShell):
10
11 2011-06-13  Chris Rogers  <crogers@google.com>
12
13         Reviewed by Dirk Pranke.
14
15         Add Web Audio support to chromium DRT
16         https://bugs.webkit.org/show_bug.cgi?id=62306
17
18         * DumpRenderTree/chromium/LayoutTestController.cpp:
19         (LayoutTestController::LayoutTestController):
20         (LayoutTestController::reset):
21         (LayoutTestController::setEncodedAudioData):
22         * DumpRenderTree/chromium/LayoutTestController.h:
23         (LayoutTestController::encodedAudioData):
24         (LayoutTestController::shouldDumpAsAudio):
25         (LayoutTestController::setShouldDumpAsAudio):
26         * DumpRenderTree/chromium/TestEventPrinter.cpp:
27         (DRTPrinter::handleAudioHeader):
28         (TestShellPrinter::handleAudioHeader):
29         * DumpRenderTree/chromium/TestEventPrinter.h:
30         * DumpRenderTree/chromium/TestShell.cpp:
31         (TestShell::TestShell):
32         (TestShell::dump):
33
34 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
35
36         Reviewed by Eric Seidel.
37
38         [EFL] Add load error handler to EWebLauncher
39         https://bugs.webkit.org/show_bug.cgi?id=62347
40
41         Add a handler function of "load,error" to EWebLauncher.
42         EWebLauncher now displays a simple error page on load errors.
43
44         * EWebLauncher/main.c:
45         (on_load_error):
46         (browserCreate):
47
48 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
49
50         Reviewed by Eric Seidel.
51
52         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
53         https://bugs.webkit.org/show_bug.cgi?id=62385
54
55         Remove duplicate TestNetscapePlugIn implementation. Having two copies
56         of this code makes keeping it in sync much more difficult. The files are
57         almost identical and this change ports the X11 changes to main.cpp.
58
59         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
60         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
61         some results on Qt and this seems to be unnecessary for the moment.
62         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
63         (handleEventX11): Use the handler to properly convert the keycode. Do not print
64         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
65         it should not be in the results.
66         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
67         XP_UNIX block is first by guarding against using a null instance.
68         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
69         the XP_UNIX define for Linux.
70         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
71         * GNUmakefile.am: Update source list.
72
73 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
74
75         Unreviewed, rolling out r88671.
76         http://trac.webkit.org/changeset/88671
77         https://bugs.webkit.org/show_bug.cgi?id=62591
78
79         "didn't work" (Requested by dpranke on #webkit).
80
81         * Scripts/new-run-webkit-httpd:
82         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
83         * Scripts/webkitpy/layout_tests/port/http_server.py:
84         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
85         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
86         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
87         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
88
89 2011-06-13  Nate Chapin  <japhet@chromium.org>
90
91         Reviewed by Darin Fisher.
92
93         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
94
95         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
96
97 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
98
99         Reviewed by Tony Chang.
100
101         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
102         https://bugs.webkit.org/show_bug.cgi?id=62251
103
104         shut_down_http_server() was a total hack that was only used by
105         new-run-webkit-httpd, so I've moved the code there and switched
106         to using executive.kill_process() for the common case. The
107         method itself will be removed in the patch on bug 59993.
108
109         * Scripts/new-run-webkit-httpd:
110         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
111         * Scripts/webkitpy/layout_tests/port/http_server.py:
112         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
113         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
114
115 2011-06-13  Tony Chang  <tony@chromium.org>
116
117         Reviewed by Dimitri Glazkov.
118
119         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
120         https://bugs.webkit.org/show_bug.cgi?id=62578
121
122         * Scripts/build-webkit:
123
124 2011-06-13  Tony Chang  <tony@chromium.org>
125
126         Reviewed by Adam Barth.
127
128         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
129         https://bugs.webkit.org/show_bug.cgi?id=62545
130
131         * Scripts/build-webkit:
132
133 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
134
135         Reviewed by Martin Robinson.
136
137         [GTK] Export an API similar to WebKit1
138         https://bugs.webkit.org/show_bug.cgi?id=57820
139
140         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
141         code, but linking to libwebkit2gtk.
142
143         * GNUmakefile.am:
144         * GtkLauncher/main.c:
145         (createBrowser):
146         (main):
147
148 2011-06-12  MORITA Hajime  <morrita@google.com>
149
150         Unreviewed, rolling out r88625.
151         http://trac.webkit.org/changeset/88625
152         https://bugs.webkit.org/show_bug.cgi?id=61073
153
154         Breaks SL Webkit2 Tests
155
156         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
157         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
158         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
159         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
160         (WTR::InjectedBundlePage::didClearWindowForFrame):
161         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
162
163 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
164
165         Reviewed by Antonio Gomes.
166
167         [Qt] LayoutTestController needs setTextDirection implementation
168         https://bugs.webkit.org/show_bug.cgi?id=62442
169
170         Implements LayoutController.setTextDirection.
171
172         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
173         (LayoutTestController::setTextDirection):
174         * DumpRenderTree/qt/LayoutTestControllerQt.h:
175
176 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
177
178         Reviewed by Hajime Morita.
179
180         Add window.internals to WebKit2's WebKitTestRunner.
181         https://bugs.webkit.org/show_bug.cgi?id=61073
182
183         Test: fast/harness/internals-object.html
184
185         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
186         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
187         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
188         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
189         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
190         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
191
192 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
193
194         Unreviewed, rolling out r88616.
195         http://trac.webkit.org/changeset/88616
196         https://bugs.webkit.org/show_bug.cgi?id=62517
197
198         It broke editing/text-iterator/findString.html (Requested by
199         tonikitoo on #webkit).
200
201         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
202         * DumpRenderTree/qt/LayoutTestControllerQt.h:
203
204 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
205
206         Reviewed by Antonio Gomes.
207
208         [Qt] LayoutTestController needs setTextDirection implementation
209         https://bugs.webkit.org/show_bug.cgi?id=62442
210
211         Implements LayoutController.setTextDirection.
212
213         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
214         (LayoutTestController::setTextDirection):
215         * DumpRenderTree/qt/LayoutTestControllerQt.h:
216
217 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
218
219         Reviewed by Ojan Vafai.
220
221         new-run-webkit-tests: 'images' links on results.html don't work
222         https://bugs.webkit.org/show_bug.cgi?id=62194
223
224         Use relative path when generating images-diffs.html
225
226         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
227         Added _output_testname.
228
229 2011-06-10  Lucas Forschler  <lforschler@apple.com>
230
231         Reviewed by Stephanie Lewis.
232
233         Script to kill old processes on Mac.
234         This matches the windows version.
235         https://bugs.webkit.org/show_bug.cgi?id=62479  
236         
237         * BuildSlaveSupport/mac: Added.
238         * BuildSlaveSupport/mac/kill-old-processes: Added.
239
240 2011-06-10  Adam Barth  <abarth@webkit.org>
241
242         Reviewed by James Robinson.
243
244         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
245         https://bugs.webkit.org/show_bug.cgi?id=62489
246
247         * Scripts/webkitpy/tool/bot/sheriff.py:
248         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
249
250 2011-06-10  Tony Chang  <tony@chromium.org>
251
252         Reviewed by Ojan Vafai.
253
254         add a compile guard ENABLE(FLEXBOX)
255         https://bugs.webkit.org/show_bug.cgi?id=62049
256
257         * Scripts/build-webkit:
258
259 2011-06-10  Mark Rowe  <mrowe@apple.com>
260
261         Reviewed by Dimitri Glazkov.
262
263         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
264
265         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
266         header file.
267
268         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
269         * DumpRenderTree/mac/Configurations/Base.xcconfig:
270
271 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
272
273         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
274
275         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
276         (handleEventX11):
277         (NPP_GetValue):
278         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
279         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
280         (webkit_test_plugin_new_instance):
281         (webkit_test_plugin_destroy_instance):
282         (webkit_test_plugin_set_window):
283         (executeScript):
284         (webkit_test_plugin_new_stream):
285         (webkit_test_plugin_destroy_stream):
286         (webkit_test_plugin_stream_as_file):
287         (webkit_test_plugin_write_ready):
288         (webkit_test_plugin_write):
289         (webkit_test_plugin_print):
290         (keyEventToChar):
291         (webkit_test_plugin_handle_event):
292         (webkit_test_plugin_url_notify):
293         (webkit_test_plugin_get_value):
294         (webkit_test_plugin_set_value):
295         (NP_GetMIMEDescription):
296         (NP_Initialize):
297         (NP_Shutdown):
298         (NP_GetValue):
299         * GNUmakefile.am:
300
301 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
302
303         Reviewed by Eric Seidel.
304
305         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
306         https://bugs.webkit.org/show_bug.cgi?id=55603
307
308         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
309         TextInputController support.
310
311         * DumpRenderTree/gtk/TextInputController.cpp:
312         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
313         of start and end. This matches the other ports. Do not use GLib style early returns.
314         (hasMarkedTextCallback): Added.
315         (markedRangeCallback): Added.
316         (insertTextCallback): Cleanup as described above.
317         (unmarkTextCallback): Cleanup as described above.
318         (firstRectForCharacterRangeCallback): Cleanup as described above.
319         (selectedRangeCallback): Cleanup as described above.
320
321 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
322
323         Reviewed by Tony Chang.
324
325         nrwt: support webaudio in chromium driver
326         https://bugs.webkit.org/show_bug.cgi?id=62226
327
328         * Scripts/webkitpy/layout_tests/port/chromium.py:
329
330 2011-06-09  Dan Bernstein  <mitz@apple.com>
331
332         Reviewed by Anders Carlsson.
333
334         Added a test for Vector::reverse()
335         https://bugs.webkit.org/show_bug.cgi?id=62393
336
337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
338         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
339         (TestWebKitAPI::TEST):
340         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
341
342 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
343
344         Reviewed by Andreas Kling.
345
346         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
347         https://bugs.webkit.org/show_bug.cgi?id=62385
348
349         Remove duplicate TestNetscapePlugIn implementation. Having two copies
350         of this code makes keeping it in sync much more difficult. The files are
351         almost identical and this change ports the X11 changes to main.cpp.
352
353         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
354         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
355         (handleEventX11): Use the handler to properly convert the keycode. Do not print
356         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
357         it should not be in the results.
358         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
359         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
360         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
361         * GNUmakefile.am: Update source list.
362
363 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
364
365         Reviewed by Tony Chang.
366
367         Test plugin should support event logging on the windows port.
368         https://bugs.webkit.org/show_bug.cgi?id=61721
369
370         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
371         calls to mean the plugin handled the event.
372
373         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
374         (handleEventWin): Return 0 for each event on windows.
375
376 2011-06-09  Chang Shu  <cshu@webkit.org>
377
378         Reviewed by Andreas Kling.
379
380         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
381         https://bugs.webkit.org/show_bug.cgi?id=62381
382
383         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
384         QWKPagePrivate::isViewFocused() will check it later.
385
386         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
387         (WTR::PlatformWebView::PlatformWebView):
388
389 2011-06-09  Robert Hogan  <robert@webkit.org>
390
391         Reviewed by Andreas Kling.
392
393         Teach Qt about window.internals
394         https://bugs.webkit.org/show_bug.cgi?id=61074
395
396         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
397         (WebCore::DumpRenderTree::initJSObjects):
398
399 2011-06-09  Eric Seidel  <eric@webkit.org>
400
401         Reviewed by Adam Barth.
402
403         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
404         https://bugs.webkit.org/show_bug.cgi?id=62362
405
406         The mac bots are failing inspector tests.  We don't know why yet.
407         So for now, turning run-webkit-tests off for the mac-ews.
408
409         Also noticed that due to the wrong variable name the cr-linux
410         bots weren't running tests!
411
412         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
413
414 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
415
416         Reviewed by Csaba Osztrogonac.
417
418         [Qt][WK2] Canvas tests make css2.1 ones failing
419         https://bugs.webkit.org/show_bug.cgi?id=53427
420
421         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
422         Since the Qt port should eventually go to QRawFont, this issue will be resolved
423         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
424         needed for the workaround.
425
426         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
427         (WTR::LayoutTestController::platformInitialize):
428
429 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
430
431         Reviewed by Chris Fleizach.
432
433         [GTK] Provide a way in DRT to check the platform name
434         https://bugs.webkit.org/show_bug.cgi?id=56855
435
436         Patch for adding 'platformName' static property to DRT's
437         LayoutController and provide platform specific implementations.
438
439         In principle, this feature will be only of interest for writing
440         accessibility tests, so that's why it's only implemented in the
441         Mac, Gtk and Win platforms.
442
443         * DumpRenderTree/LayoutTestController.h: New method platformName().
444         * DumpRenderTree/LayoutTestController.cpp:
445         (getPlatformNameCallback): New callback for 'platformName'.
446         (LayoutTestController::staticValues): New static property.
447
448         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
449         (LayoutTestController::platformName): Implemented.
450
451         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
452         (LayoutTestController::platformName): Implemented.
453
454         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
455         (LayoutTestController::platformName): Implemented.
456
457 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
458
459         Reviewed by James Robinson.
460
461         Add mikelawther to committers.py
462         https://bugs.webkit.org/show_bug.cgi?id=62354
463
464         * Scripts/webkitpy/common/config/committers.py:
465
466 2011-06-08  Kent Tamura  <tkent@chromium.org>
467
468         [Chromium] Fix a typo.
469
470         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
471         (WebThemeControlDRTWin::draw):
472
473 2011-06-08  Kent Tamura  <tkent@chromium.org>
474
475         Reviewed by Hajime Morita.
476
477         [Chromium] Support vertical sliders in Windows DRT
478         https://bugs.webkit.org/show_bug.cgi?id=62352
479
480         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
481         (WebThemeControlDRTWin::draw):
482           Paint VerticalSliderThumbType and VerticalSliderTrackType.
483         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
484           Add VerticalSliderTrackType and VerticalSliderThumbType.
485         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
486         (WebThemeEngineDRTWin::paintTrackbar):
487           Convert Windows identifiers to the internal identifiers for vertical sliders.
488
489 2011-06-08  Ojan Vafai  <ojan@chromium.org>
490
491         Reviewed by Tony Chang.
492
493         add a short-flag for --experimental-fully-parallel
494         https://bugs.webkit.org/show_bug.cgi?id=62321
495
496         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
497
498 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
499
500         Reviewed by Tony Chang.
501
502         new-run-webkit-tests: don't turn the tree red when there are new passes
503         https://bugs.webkit.org/show_bug.cgi?id=62311
504
505         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
506         to match commandComplete.
507
508         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
509
510 2011-06-08  Tom Hudson  <tomhudson@google.com>
511
512         Reviewed by Mihai Parparita.
513
514         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
515         https://bugs.webkit.org/show_bug.cgi?id=60964
516
517         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
518         Add 'Sort tests by metric' link.
519         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
520         (disableSorting): Activate 'Sort tests by metric' link.
521         (enableSorting): Deactivate 'Sort tests by metric' link.
522         (selectDirectory): Call enableSorting()/disableSorting() depending
523         on currently selected failure type, and sort tests if requested.
524         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
525         New .disabled-control class for deactivated links.
526
527 2011-06-08  Tom Sepez  <tsepez@chromium.org>
528
529         Reviewed by Adam Barth.
530
531         Add web permissions callbacks for mixed content blocking.
532         https://bugs.webkit.org/show_bug.cgi?id=61946
533
534         * DumpRenderTree/chromium/LayoutTestController.cpp:
535         (LayoutTestController::setAllowDisplayOfInsecureContent):
536         (LayoutTestController::setAllowRunningOfInsecureContent):
537         (LayoutTestController::overridePreference):
538         * DumpRenderTree/chromium/WebPermissions.cpp:
539         (WebPermissions::allowDisplayingInsecureContent):
540         (WebPermissions::allowRunningInsecureContent):
541         (WebPermissions::setDisplayingInsecureContentAllowed):
542         (WebPermissions::setRunningInsecureContentAllowed):
543         (WebPermissions::reset):
544         * DumpRenderTree/chromium/WebPermissions.h:
545
546 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
547
548         Reviewed by Tony Chang.
549
550         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
551         https://bugs.webkit.org/show_bug.cgi?id=62259
552
553         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
554
555 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
556
557         Reviewed by Tony Chang.
558
559         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
560         https://bugs.webkit.org/show_bug.cgi?id=62303
561
562         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
563
564         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
565
566 2011-06-08  Greg Simon  <gregsimon@chromium.org>
567
568         Reviewed by Dimitri Glazkov.
569
570         Control Indexeddb backends from LayoutTestController
571         https://bugs.webkit.org/show_bug.cgi?id=61000
572
573         * DumpRenderTree/chromium/LayoutTestController.cpp:
574         (LayoutTestController::LayoutTestController):
575         (LayoutTestController::setOverrideIndexedDBBackingStore):
576         (LayoutTestController::clearAllDatabases):
577         * DumpRenderTree/chromium/LayoutTestController.h:
578
579 2011-06-08  Andreas Kling  <kling@webkit.org>
580
581         Add Pierre Rossi to contributors list for EZ-CC.
582
583         * Scripts/webkitpy/common/config/committers.py:
584
585 2011-06-08  Ilya Sherman  <isherman@chromium.org>
586
587         Reviewed by Andreas Kling.
588
589         Add Ilya Sherman to list of committers
590         https://bugs.webkit.org/show_bug.cgi?id=62270
591
592         * Scripts/webkitpy/common/config/committers.py:
593
594 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
595
596         Reviewed by Tony Chang.
597
598         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
599         https://bugs.webkit.org/show_bug.cgi?id=62178
600
601         Added commandComplete and evaluateCommand for NewRunWebKitTests class
602         to parse new-run-webkit-tests' results.
603
604         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
605
606 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
607
608         Reviewed by Eric Seidel.
609
610         webkitpy: add a popen() call to executive
611         https://bugs.webkit.org/show_bug.cgi?id=62179
612
613         This change adds a popen() wrapper call to the Executive object.
614         This will allow other webkitpy scripts that currently call
615         subprocess directly to use Executive, instead.
616
617         No additional tests are necessary (the existing tests cover the code).
618
619         * Scripts/webkitpy/common/system/executive.py:
620
621 2011-06-07  Sam Weinig  <sam@webkit.org>
622
623         Reviewed by Anders Carlsson.
624
625         Remove repeated IPC traffic from SetRenderTreeSize message
626         https://bugs.webkit.org/show_bug.cgi?id=62244
627
628         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
629         (WTR::InjectedBundlePage::InjectedBundlePage):
630         Add stub for didLayoutForFrame.
631
632 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
633
634         Reviewed by Tony Chang.
635
636         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
637         https://bugs.webkit.org/show_bug.cgi?id=62241
638
639         * Scripts/webkitpy/layout_tests/port/chromium.py:
640
641 2011-06-07  Adam Barth  <abarth@webkit.org>
642
643         Rubber-stamped by Eric Seidel.
644
645         Enable tests on the mac-ews
646
647         When we bring the mac-ews back up, we're going to try running tests!
648
649         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
650
651 2011-06-07  Dmitry Lomov  <dslomov@google.com>
652
653         Reviewed by David Levin.
654
655         https://bugs.webkit.org/show_bug.cgi?id=62215
656         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
657
658         * Scripts/webkitpy/style/checkers/cpp.py:
659         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
660
661 2011-06-07  Nico Weber  <thakis@chromium.org>
662
663         Reviewed by Dimitri Glazkov.
664
665         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
666         https://bugs.webkit.org/show_bug.cgi?id=62210
667
668         The change to TestEventPrinter fixes a latent bug, because
669         objects are deleted through the TestEventPrinter type, but none
670         of the subclasses have destructors or non-POD members.
671
672         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
673         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
674         discussed at http://codereview.chromium.org/7094005/, we prefer making
675         leaf class destructors virtual over making the leaf classes final.
676
677         * DumpRenderTree/chromium/NotificationPresenter.cpp:
678         (NotificationPresenter::~NotificationPresenter):
679         * DumpRenderTree/chromium/NotificationPresenter.h:
680         * DumpRenderTree/chromium/TestEventPrinter.cpp:
681         (TestEventPrinter::~TestEventPrinter):
682         * DumpRenderTree/chromium/TestEventPrinter.h:
683         * DumpRenderTree/chromium/WebViewHost.h:
684
685 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
686
687         Reviewed by Dirk Pranke.
688
689         [chromium] Chromium bots on build.webkit.org don't upload results.html
690         https://bugs.webkit.org/show_bug.cgi?id=61961
691
692         Don't fix the path on chromium port erroneously.
693
694         * BuildSlaveSupport/test-result-archive:
695
696 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
697
698         Fix the GTK+ build by ensuring that the autogenerated sources
699         necessary for libWebCoreInternals are recorded in a predeclared
700         variable before assigning to BUILT_SOURCES.
701
702         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
703
704 2011-06-06  Yong Li  <yoli@rim.com>
705
706         Reviewed by Eric Seidel.
707
708         https://bugs.webkit.org/show_bug.cgi?id=62097
709         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
710
711         * Scripts/webkitpy/style/checkers/cpp.py:
712         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
713
714 2011-06-06  Xan Lopez  <xlopez@igalia.com>
715
716         Reviewed by Martin Robinson.
717
718         [GTK] Enable feature/symbol detection in NWRT/GTK
719         https://bugs.webkit.org/show_bug.cgi?id=62136
720
721         Disable feature detection through DRT, since we don't support it,
722         and set the libwebcore patch correctly so that symbol detection
723         through 'nm' works.
724
725         * Scripts/webkitpy/layout_tests/port/gtk.py:
726
727 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
728
729         Reviewed by Tony Gentilcore.
730
731         Add a "prerender" state for page visibility.
732         https://bugs.webkit.org/show_bug.cgi?id=62062
733
734         * DumpRenderTree/chromium/LayoutTestController.cpp:
735         (LayoutTestController::setPageVisibility):
736
737 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
738
739         [Qt] Implement download feature for QtTestBrowser
740         https://bugs.webkit.org/show_bug.cgi?id=61865
741
742         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
743
744         * QtTestBrowser/launcherwindow.cpp:
745         (LauncherWindow::LauncherWindow):
746         * QtTestBrowser/launcherwindow.h:
747
748 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
749
750         Reviewed by Csaba Osztrogonác.
751
752         [Qt] Implement download feature for QtTestBrowser
753         https://bugs.webkit.org/show_bug.cgi?id=61865
754
755         * QtTestBrowser/launcherwindow.cpp:
756         (LauncherWindow::LauncherWindow):
757         (LauncherWindow::downloadRequest):
758         (LauncherWindow::fileDownloadFinished):
759         * QtTestBrowser/launcherwindow.h:
760
761 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
762
763         Reviewed by Dimitri Glazkov.
764
765         Make DumpRenderTree initialize window.internals.
766         https://bugs.webkit.org/show_bug.cgi?id=61076
767
768         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
769         * DumpRenderTree/win/FrameLoadDelegate.cpp:
770         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
771
772 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
773
774         Reviewed by Kent Tamura.
775
776         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
777         https://bugs.webkit.org/show_bug.cgi?id=61628
778
779         * Scripts/build-webkit:
780
781 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
782
783         Reviewed by Kent Tamura.
784
785         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
786         https://bugs.webkit.org/show_bug.cgi?id=61631
787
788         * Scripts/build-webkit:
789
790 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
791
792         Unreviewed. Fix the GTK+ build.
793
794         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
795
796 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
797
798         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
799         works properly).
800
801         * Scripts/webkitpy/common/config/committers.py:
802
803 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
804
805         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
806         WebKit scripts expect, so other scripts work properly with wx.
807
808         * waf/build/build_utils.py:
809         * waf/build/settings.py:
810
811 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
812
813         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
814         to build on Mac.
815
816         * waf/build/settings.py:
817         * wx/install-unix-extras:
818
819 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
820
821         [wx] Unreviewed build fixes for recent trunk changes.
822
823         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
824         (LayoutTestController::setTextDirection):
825         * waf/build/settings.py:
826
827 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
828
829         Fix the GTK+ build.
830
831         * GNUmakefile.am: Add some missing newline escape.
832
833 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
834
835         Try to fix the GTK+ bulid.
836
837         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
838         source list.
839
840 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
841
842         Reviewed by Adam Barth.
843
844         nrwt: should skip chromium test expectation overrides on upstream bots
845         https://bugs.webkit.org/show_bug.cgi?id=61888
846
847         * Scripts/webkitpy/layout_tests/port/chromium.py:
848         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
849
850 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
851
852         Reviewed by Ojan Vafai.
853
854         new-run-webkit-tests: minor logging, code cleanup
855         https://bugs.webkit.org/show_bug.cgi?id=62055
856
857         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
858         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
859
860 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
861
862         Try to fix the build failure on the GTK+ 32-bit Release bot.
863
864         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
865
866 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
867
868         Reviewed by Ryosuke Niwa.
869
870         [GTK] Support smart replace for the pasteboard
871         https://bugs.webkit.org/show_bug.cgi?id=61734
872
873         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
874         This is required to produce consistent test results.
875
876         * DumpRenderTree/gtk/DumpRenderTree.cpp:
877         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
878         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
879         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
880         methods which calls into DumpRenderTreeSupportGtk.
881
882 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
883
884         Reviewed by Dimitri Glazkov.
885
886         Teach Gtk build about window.internals
887         https://bugs.webkit.org/show_bug.cgi?id=61071
888
889         * DumpRenderTree/gtk/DumpRenderTree.cpp:
890         (webViewWindowObjectCleared): Inject the new internals object when the
891         window object clears.
892         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
893         Also do a little bit of cleanup.
894
895 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
896
897         Reviewed by Tony Chang.
898
899         Worker may not be stopped after LT.
900         https://bugs.webkit.org/show_bug.cgi?id=61847
901
902         Re-submit a variant of the first fix for this bug. It's possible
903         that actually calling cleanup() in the worker threads was taking
904         too long and we triggered the assertions in the manager thread.
905
906         I've bumped up the timeout in the manager and added better
907         diagnostics. I also cleaned up the cleanup() code a bit because
908         there was some unnecessary if-checks.
909
910         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
911         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
912
913 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
914
915         Reviewed by Tony Chang.
916
917         nrwt: fix duplicate logging regression
918         https://bugs.webkit.org/show_bug.cgi?id=61981
919
920         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
921
922 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
923
924         Reviewed by Adam Barth.
925
926         Modified addTouchPoint to correctly re-use touchPoint id values starting
927         from the lowest not-un-use touchPoint id as is done by the embedder
928         APIs. (Fixes BUGCR36415)
929
930         https://bugs.webkit.org/show_bug.cgi?id=62016
931
932         * DumpRenderTree/chromium/EventSender.cpp:
933         (EventSender::addTouchPoint):
934
935 2011-06-03  Cary Clark  <caryclark@google.com>
936
937         Reviewed by Eric Seidel.
938
939         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
940         https://bugs.webkit.org/show_bug.cgi?id=61534
941
942         Skia on Mac uses Skia to render WebKit, and CG
943         to render UI elements. The CG elements need a
944         transcribed graphics context that preserves the
945         canvas matrix, and the canvas clip.
946
947         The SkiaBitLocker utility class sets up a CGContext
948         from the SkCanvas, locks the bitmap's bits, and
949         releases the lock when the class goes out of scope.
950
951         The SkiaBitLocker implementation is described by
952         this patch:
953         http://codereview.chromium.org/7031006/
954
955         When WebKit uses Skia for rendering, the WebCanvas
956         is an SkCanvas. Create an equivalent CGContext to
957         draw the scrollbar thumb.
958
959         As the Chrome Mac port does not yet use Skia, this
960         patch has no effect and requires no tests.
961
962         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
963         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
964
965 2011-06-03  Andras Becsi  <abecsi@webkit.org>
966
967         Unreviewed build fix.
968
969         Fix typo.
970
971         * Scripts/old-run-webkit-tests:
972
973 2011-06-03  Andras Becsi  <abecsi@webkit.org>
974
975         Reviewed by Csaba Osztrogonác.
976
977         Print error message when there is no httpd present on the system
978         https://bugs.webkit.org/show_bug.cgi?id=61939
979
980         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
981         * Scripts/webkitperl/httpd.pm:
982
983 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
984
985         Reviewed by Yury Semikhatsky.
986
987         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
988         https://bugs.webkit.org/show_bug.cgi?id=61533
989
990         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
991
992         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
993         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
994         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
995         * DumpRenderTree/chromium/LayoutTestController.cpp:
996         (LayoutTestController::LayoutTestController):
997         (LayoutTestController::setJavaScriptProfilingEnabled):
998         * DumpRenderTree/chromium/LayoutTestController.h:
999         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1000         (LayoutTestController::setJavaScriptProfilingEnabled):
1001         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1002         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
1003         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1004
1005 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
1006
1007         Reviewed by Tony Chang.
1008
1009         NRWT needs a way to log to a file without including backspaces without needing --verbose
1010         https://bugs.webkit.org/show_bug.cgi?id=60328
1011
1012         This change modifies NRWT so that if it can tell if it is
1013         writing to a terminal, it will overwrite any messages printed
1014         in the 'one-line-progress' and 'updates' print options, and if
1015         not (or if --verbose was specified) the messages will be printed
1016         without backspaces.
1017
1018         If the overwriting updates are disabled, one-line-progress will
1019         only print every 10 seconds instead of on every update. This
1020         ensures that we still get updates once in a while while the
1021         tests are running, even if we're not in --verbose mode. Note
1022         that one-line-progress will now still be printed in --verbose,
1023         since it's useful as long as you're not flooded with the
1024         updates.
1025
1026         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1027         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1028         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1029
1030 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
1031
1032         Reviewed by Gustavo Noronha Silva.
1033
1034         [GTK] autogen.sh is run twice for each buld on the bots
1035         https://bugs.webkit.org/show_bug.cgi?id=61951
1036
1037         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
1038         for the WebKit project. This prevents build-jsc runs from forcing subsequent
1039         build-webkit runs to re-rerun autogen.sh.
1040
1041 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1042
1043         Unreviewed, rolling out r87946.
1044         http://trac.webkit.org/changeset/87946
1045         https://bugs.webkit.org/show_bug.cgi?id=61965
1046
1047         Cause NRWT to break (Requested by abarth|gardener on #webkit).
1048
1049         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1050
1051 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1052
1053         Reviewed by Darin Adler.
1054
1055         Add build logistics and plumbing for window.internals object.
1056         https://bugs.webkit.org/show_bug.cgi?id=60313
1057
1058         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1059         * DumpRenderTree/chromium/TestShell.cpp:
1060         (TestShell::bindJSObjectsToWindow): Added injection code.
1061         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1062         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1063
1064 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
1065
1066         Reviewed by Dirk Pranke.
1067
1068         Call cleanup() explicitly at the end of worker.run().
1069         https://bugs.webkit.org/show_bug.cgi?id=61847
1070
1071         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1072
1073 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1074
1075         Unreviewed, rolling out r87926.
1076         http://trac.webkit.org/changeset/87926
1077         https://bugs.webkit.org/show_bug.cgi?id=60313
1078
1079         Fails to find WebCoreTestSupport.dylib on bots.
1080
1081         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1082         * DumpRenderTree/chromium/TestShell.cpp:
1083         (TestShell::bindJSObjectsToWindow):
1084         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1085         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1086
1087 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
1088
1089         Reviewed by Darin Adler.
1090
1091         Add build logistics and plumbing for window.internals object.
1092         https://bugs.webkit.org/show_bug.cgi?id=60313
1093
1094         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1095         * DumpRenderTree/chromium/TestShell.cpp:
1096         (TestShell::bindJSObjectsToWindow): Added injection code.
1097         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1098         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1099
1100 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1101
1102         Reviewed by Eric Seidel.
1103
1104         Adjust efl coding style to more efl directories
1105         https://bugs.webkit.org/show_bug.cgi?id=61903
1106
1107         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
1108
1109 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
1110
1111         Reviewed by Tony Chang.
1112
1113         old-run-webkit-tests: add support for audio files
1114         https://bugs.webkit.org/show_bug.cgi?id=57992
1115
1116         * Scripts/old-run-webkit-tests:
1117
1118 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
1119
1120         Reviewed by Adam Barth.
1121
1122         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
1123         https://bugs.webkit.org/show_bug.cgi?id=34314
1124
1125         * DumpRenderTree/DumpRenderTree.gypi:
1126         * DumpRenderTree/chromium/LayoutTestController.cpp:
1127         (LayoutTestController::LayoutTestController):
1128         (LayoutTestController::setImagesAllowed):
1129         (LayoutTestController::setStorageAllowed):
1130         * DumpRenderTree/chromium/LayoutTestController.h:
1131         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
1132         (WebPermissions::WebPermissions):
1133         (WebPermissions::~WebPermissions):
1134         (WebPermissions::allowImages):
1135         (WebPermissions::allowStorage):
1136         (WebPermissions::setImagesAllowed):
1137         (WebPermissions::setStorageAllowed):
1138         (WebPermissions::reset):
1139         * DumpRenderTree/chromium/WebPermissions.h:
1140
1141 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
1142
1143         Reviewed by Tony Chang.
1144
1145         Test plugin should support event logging on the windows port.
1146         https://bugs.webkit.org/show_bug.cgi?id=61721
1147
1148         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1149         (handleEventWin): Well, handle them.
1150
1151 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
1152
1153         Reviewed by Tony Chang.
1154
1155         [chromium] Use correct file name for dragging out images.
1156         https://bugs.webkit.org/show_bug.cgi?id=24887
1157
1158         * DumpRenderTree/chromium/EventSender.cpp:
1159         (EventSender::EventSender):
1160         (EventSender::dumpFilenameBeingDragged):
1161         * DumpRenderTree/chromium/EventSender.h:
1162
1163 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
1164
1165         Reviewed by Tony Chang.
1166
1167         nrwt: make webaudio work w/o content-length header
1168         https://bugs.webkit.org/show_bug.cgi?id=61819
1169
1170         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1171         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1172         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1173         * Scripts/webkitpy/layout_tests/port/webkit.py:
1174
1175 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1176
1177         Reviewed by Andreas Kling.
1178
1179         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
1180         https://bugs.webkit.org/show_bug.cgi?id=61802
1181
1182         Add command line parameter and menu item to MiniBrowser application 
1183         enabling use of QGLWidget for browser viewport.
1184
1185         * MiniBrowser/qt/BrowserWindow.cpp:
1186         (BrowserWindow::BrowserWindow):
1187         (BrowserWindow::toggleGLViewport):
1188         * MiniBrowser/qt/BrowserWindow.h:
1189         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1190         (MiniBrowserApplication::handleUserOptions):
1191         * MiniBrowser/qt/MiniBrowserApplication.h:
1192         (WindowOptions::WindowOptions):
1193
1194 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
1195
1196         Reviewed by Xan Lopez.
1197
1198         Print out autogen arguments when they differ from the last set, to help
1199         with debugging build issues.
1200
1201         * Scripts/webkitdirs.pm: Print out previous and current build arguments
1202         when they differ.
1203
1204 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1205
1206         Reviewed by Martin Robinson.
1207
1208         [GTK] run-launcher should run MiniBrowser in WebKit2
1209         https://bugs.webkit.org/show_bug.cgi?id=61858
1210
1211         * Scripts/run-launcher: Check whether -2 command line option has
1212         been passed and run MiniBrowser instead of GtkLauncher.
1213
1214 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
1215
1216         Reviewed by Dirk Pranke.
1217
1218         Fix exception in verbose printing mode.
1219         https://bugs.webkit.org/show_bug.cgi?id=61723
1220
1221         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1222
1223 2011-05-31  Yong Li  <yoli@rim.com>
1224
1225         Reviewed by Eric Seidel.
1226
1227         https://bugs.webkit.org/show_bug.cgi?id=54807
1228         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
1229         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
1230         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
1231         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
1232         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
1233         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
1234         rule we should have in order to make our code independent from compilers and compiler flags.
1235
1236         * Scripts/webkitpy/style/checkers/cpp.py:
1237
1238 2011-05-31  Hironori Bono  <hbono@chromium.org>
1239
1240         Reviewed by Eric Seidel.
1241
1242         Add a JavaScript function layoutTestController.setTextDirection().
1243         https://bugs.webkit.org/show_bug.cgi?id=50952
1244
1245         This change adds a new JavaScript function setTextDirection() to the
1246         LayoutTestController class of Safari and Chrome to write layout tests
1247         that changes the text direction of an editable element.
1248
1249         * DumpRenderTree/LayoutTestController.cpp:
1250         (setTextDirectionCallback):
1251         (LayoutTestController::staticFunctions):
1252         * DumpRenderTree/LayoutTestController.h:
1253         * DumpRenderTree/chromium/LayoutTestController.cpp:
1254         (LayoutTestController::LayoutTestController):
1255         (LayoutTestController::setTextDirection):
1256         * DumpRenderTree/chromium/LayoutTestController.h:
1257         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1258         (LayoutTestController::setTextDirection):
1259         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1260         (LayoutTestController::setTextDirection):
1261         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1262         (LayoutTestController::setTextDirection):
1263
1264 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1265
1266         Reviewed by Simon Hausmann.
1267
1268         [Qt] User-agent list of Qt test browsers is very outdated
1269         https://bugs.webkit.org/show_bug.cgi?id=61531
1270
1271         The user can edit the user-agent manually, so there's no need to have
1272         a super complete and up to date list, but it's nice to have it
1273         minimally updated.
1274
1275         * MiniBrowser/qt/useragentlist.txt:
1276         * QtTestBrowser/useragentlist.txt:
1277
1278 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
1279
1280         Reviewed by Adam Roben.
1281
1282         [GTK] [WebKit2] Implement a basic WebKitTestRunner
1283         https://bugs.webkit.org/show_bug.cgi?id=57068
1284
1285         Add an implementation of WebKitTestRunner for GTK+.
1286
1287         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
1288         * Scripts/old-run-webkit-tests: Ditto.
1289         * Scripts/run-launcher: Ditto.
1290         * Scripts/webkitdirs.pm: Ditto.
1291         * WebKitTestRunner/GNUmakefile.am: Added.
1292         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1293         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
1294         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1295         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1296         * WebKitTestRunner/PlatformWebView.h:
1297         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
1298         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
1299         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1300         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1301         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1302         (main): Added.
1303
1304 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
1305
1306         Reviewed by Tony Chang.
1307
1308         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
1309         https://bugs.webkit.org/show_bug.cgi?id=60241
1310
1311         * Scripts/new-run-webkit-tests:
1312
1313 2011-05-31  Eric Seidel  <eric@webkit.org>
1314
1315         Reviewed by David Kilzer.
1316
1317         webkitpy should create zips with zip -9
1318         https://bugs.webkit.org/show_bug.cgi?id=61789
1319
1320         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
1321
1322         * Scripts/webkitpy/common/system/workspace.py:
1323         * Scripts/webkitpy/common/system/workspace_unittest.py:
1324
1325 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1326
1327         Reviewed by Csaba Osztrogonác.
1328
1329         [Qt] Implement find feature for QtTestBrowser
1330         https://bugs.webkit.org/show_bug.cgi?id=61425
1331
1332         Buildfix for --minimal and CONFIG+=qt_minimal build.
1333
1334         * QtTestBrowser/launcherwindow.cpp:
1335         (LauncherWindow::LauncherWindow):
1336         (LauncherWindow::createChrome):
1337         * QtTestBrowser/launcherwindow.h:
1338
1339 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1340
1341         Reviewed by Csaba Osztrogonác.
1342
1343         [Qt] Implement find feature for QtTestBrowser
1344         https://bugs.webkit.org/show_bug.cgi?id=61425
1345
1346         * QtTestBrowser/launcherwindow.cpp:
1347         (LauncherWindow::LauncherWindow):
1348         (LauncherWindow::createChrome):
1349         (LauncherWindow::showFindBar):
1350         (LauncherWindow::find):
1351         * QtTestBrowser/launcherwindow.h:
1352
1353 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1354
1355         Reviewed by Martin Robinson.
1356
1357         [GTK] Implement JavaScript dialogs in MiniBrowser
1358         https://bugs.webkit.org/show_bug.cgi?id=61725
1359
1360         * MiniBrowser/gtk/BrowserWindow.c:
1361         (WKStringGetCString): Helper function to get a UTF-8 c string from
1362         a WKStringRef.
1363         (WKURLGetCString): Helper function to get a UTF-8 c string from a
1364         WKURLRef.
1365         (browserWindowUpdateURL): Update to use WKURLGetCString.
1366         (didReceiveTitleForFrame): Update to use WKStringGetCString.
1367         (createMessageDialog): Create a GtkMessageDialog.
1368         (runJavaScriptAlert):
1369         (runJavaScriptConfirm):
1370         (runJavaScriptPrompt):
1371         (browserWindowUIClientInit):
1372
1373 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
1374
1375         Reviewed by Kent Tamura.
1376
1377         WebSocket closing handshake
1378         https://bugs.webkit.org/show_bug.cgi?id=35721
1379
1380         * Scripts/webkitpy/thirdparty/__init__.py:
1381         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1382         to get the right behavior of closing handshake.
1383
1384 2011-05-29  Daniel Bates  <dbates@rim.com>
1385
1386         Reviewed by David Kilzer.
1387
1388         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
1389         https://bugs.webkit.org/show_bug.cgi?id=61162
1390
1391         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
1392         that omits a line count. In particular, the chunk range regular expression does
1393         not match a chunk range line that omits a line count. GNU diff(1) will omit the
1394         line count in the chunk range if the line count is exactly 1. For example, appending
1395         a new line to the end of an existing file F that contains exactly one line of text will
1396         be represented in a diff with a chunk range line that omits the line count for F.
1397
1398         * Scripts/VCSUtils.pm:
1399           (parseChunkRange): Added.
1400         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
1401         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1402           - Added unit test "Git: Append new line to the end of an existing file".
1403
1404 2011-05-28  Adam Barth  <abarth@webkit.org>
1405
1406         Reviewed by Eric Seidel.
1407
1408         EWS builds patches that fail to build twice, which seems useless and slows down the bots
1409         https://bugs.webkit.org/show_bug.cgi?id=55585
1410
1411         This patch switches all the early warning system bots over to the new
1412         PatchAnalysisTask-based infrastructure.  This patch makes these bots
1413         more efficient (in the case where patches fail to build) and paves the
1414         way for running tests on these bots!
1415
1416         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1417         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1418         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1419         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1420         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1421         * Scripts/webkitpy/tool/commands/queues.py:
1422
1423 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
1424
1425         Reviewed by Kent Tamura.
1426
1427         Add bashi as a committer.
1428
1429         https://bugs.webkit.org/show_bug.cgi?id=61685
1430
1431         * Scripts/webkitpy/common/config/committers.py:
1432
1433 2011-05-27  Adam Barth  <abarth@webkit.org>
1434
1435         Reviewed by Eric Seidel.
1436
1437         When checking whether the tree is red, the EWS posts a link to the wrong log
1438         https://bugs.webkit.org/show_bug.cgi?id=61072
1439
1440         We need to cache the original script error because that contains the
1441         failure log we want to upload.  If we don't cache that script error,
1442         self._script_error will get overwritten when we sanity check the clean
1443         tree (and it also has test failures).
1444
1445         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1446             - This testing approach is slightly goofy.  We'd like to use
1447               assertRaisesRegexp, but that's not available until Python 2.7.
1448         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1449
1450 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
1451
1452         Reviewed by Adam Barth.
1453
1454         Add layoutTestController.setStorageAllowed() to control whether access
1455         to the localStorage API is enabled via the WebPermissionClient
1456         https://bugs.webkit.org/show_bug.cgi?id=61581
1457
1458         * DumpRenderTree/chromium/LayoutTestController.cpp:
1459         (LayoutTestController::LayoutTestController):
1460         (LayoutTestController::setStorageAllowed):
1461         * DumpRenderTree/chromium/LayoutTestController.h:
1462         * DumpRenderTree/chromium/TestShell.cpp:
1463         (TestShell::TestShell):
1464         (TestShell::createNewWindow):
1465         * DumpRenderTree/chromium/TestShell.h:
1466         * DumpRenderTree/chromium/WebPermissions.h: Added.
1467         (WebPermissions::WebPermissions):
1468         (WebPermissions::allowStorage):
1469         (WebPermissions::setStorageAllowed):
1470         (WebPermissions::reset):
1471
1472 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1473
1474         Reviewed by Eric Seidel.
1475
1476         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
1477         https://bugs.webkit.org/show_bug.cgi?id=60326
1478
1479         This patch removes a lot of the complexity from the
1480         metered_stream implementation that was unnecessary since there
1481         was only one caller and the logic could be coordinated better.
1482
1483         There should be no functional changes in this patch, just code
1484         getting deleted and cleaned up.
1485
1486         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1487         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
1488         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1489         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1490
1491 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1492
1493         Reviewed by Eric Seidel.
1494
1495         NRWT: minor cleanup in printing module
1496         https://bugs.webkit.org/show_bug.cgi?id=60329
1497
1498         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1499
1500 2011-05-27  Steve Lacey  <sjl@chromium.org>
1501
1502         Reviewed by David Levin.
1503
1504         Add sjl@chromium.org as a committer.
1505
1506         https://bugs.webkit.org/show_bug.cgi?id=61672
1507
1508         * Scripts/webkitpy/common/config/committers.py:
1509
1510 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1511
1512         Reviewed by Adam Barth.
1513
1514         NRWT: remove --print detailed-progress
1515         https://bugs.webkit.org/show_bug.cgi?id=60324
1516
1517         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1518         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1519         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1520         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1521
1522 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1523
1524         Reviewed by Ojan Vafai.
1525
1526         NRWT: debug messages from the workers are being logged twice
1527         https://bugs.webkit.org/show_bug.cgi?id=60428
1528
1529         It looks like when the workers are run in separate processes
1530         we end up getting two copies of every log message they print.
1531         This has to do with the multiprocessing module on UNIX cloning
1532         the log configuration in a way I wasn't expecting, and so two
1533         log handlers end up getting registered.
1534
1535         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1536         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1537         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1538         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1539
1540 2011-05-27  Adam Roben  <aroben@apple.com>
1541
1542         Always decode tester names from location.hash
1543
1544         When navigating directly to a tester-specific URL (e.g.,
1545         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
1546         with a URL-encoded tester name in the page, and then the encoded name could make its way
1547         into Bugzilla bugs. Bad!
1548
1549         Reviewed by David Kilzer.
1550
1551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1552         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
1553         decodeURIComponent before trying to use it.
1554
1555 2011-05-27  Adam Roben  <aroben@apple.com>
1556
1557         Remove testing code that snuck into r87528
1558
1559         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1560         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
1561
1562 2011-05-27  Adam Roben  <aroben@apple.com>
1563
1564         Add links to TestFailures to easily file bugs about failing tests
1565
1566         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
1567         links to file bugs for failing tests
1568
1569         Reviewed by David Kilzer.
1570
1571         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1572         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
1573         for a particular build.
1574         (Builder.prototype._getFailingTests): Use resultsPageURL.
1575
1576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1577         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
1578         failures.
1579         (ViewController.prototype._domForBuildName): Use resultsPageURL.
1580         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
1581         new bug link. The bug has a title, description, and URL already filled in for you!
1582
1583 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1584
1585         Unreviewed, rolling out r87464.
1586         http://trac.webkit.org/changeset/87464
1587         https://bugs.webkit.org/show_bug.cgi?id=61643
1588
1589         client-close/server-close tests are flaky on Chromium Mac and
1590         Windows (Requested by aklein on #webkit).
1591
1592         * Scripts/webkitpy/thirdparty/__init__.py:
1593
1594 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
1595
1596         Added Douglas Davidson to contributors list for easier CC'ing.
1597
1598         * Scripts/webkitpy/common/config/committers.py:
1599
1600 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1601
1602         Reviewed by Adam Barth.
1603
1604         Fix worldID and destinationDomain argument names
1605         https://bugs.webkit.org/show_bug.cgi?id=61571
1606
1607         As part of working on r87423, I noticed a couple of inconsistencies in
1608         argument names:
1609         - We would use worldId in .h files but worldID in .cpp files.
1610           Standardize on the latter
1611         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
1612           destinationDomains argument, even though the actual parameter was for
1613           a single domain (renamed to be singular).
1614
1615         * DumpRenderTree/LayoutTestController.h:
1616         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1617         (LayoutTestController::evaluateScriptInIsolatedWorld):
1618
1619 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
1620
1621         Reviewed by Kent Tamura.
1622
1623         WebSocket closing handshake
1624         https://bugs.webkit.org/show_bug.cgi?id=35721
1625
1626         * Scripts/webkitpy/thirdparty/__init__.py:
1627         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1628         to get the right behavior of closing handshake.
1629
1630 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
1631
1632         Reviewed by Andreas Kling.
1633
1634         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
1635         https://bugs.webkit.org/show_bug.cgi?id=42676
1636
1637         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
1638
1639         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1640         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1641         (WTR::InjectedBundle::beginTesting):
1642         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1643         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
1644         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1645
1646 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1647
1648         Reviewed by Andreas Kling.
1649
1650         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
1651         https://bugs.webkit.org/show_bug.cgi?id=61527
1652
1653         The setMaximumHeight() call is unecessary and breaks the dialog at
1654         least on my setup.
1655
1656         * QtTestBrowser/launcherwindow.cpp:
1657         (LauncherWindow::showUserAgentDialog):
1658
1659 2011-05-02  Robert Hogan  <robert@webkit.org>
1660
1661         Reviewed by Adam Roben.
1662
1663         [Qt] Allow popup windows from plugins when initiated by a user gesture
1664
1665         https://bugs.webkit.org/show_bug.cgi?id=41292
1666
1667         Support parameters introduced in plugin-initiate-popup-window.html
1668
1669         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1670         (webkit_test_plugin_new_instance):
1671         (webkit_test_plugin_handle_event):
1672
1673 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1674
1675         Reviewed by Adam Barth.
1676
1677         Support cross-origin XMLHttpRequest in isolated worlds
1678         https://bugs.webkit.org/show_bug.cgi?id=59843
1679
1680         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
1681
1682         * DumpRenderTree/chromium/LayoutTestController.cpp:
1683         (LayoutTestController::LayoutTestController):
1684         (LayoutTestController::setIsolatedWorldSecurityOrigin):
1685         * DumpRenderTree/chromium/LayoutTestController.h:
1686
1687 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
1688
1689         Reviewed by Adam Roben.
1690
1691         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
1692         https://bugs.webkit.org/show_bug.cgi?id=61474
1693         <rdar://problem/9468337>
1694
1695         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1696         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
1697
1698 2011-05-26  Andreas Kling  <kling@webkit.org>
1699
1700         Unreviewed, correct address to webkit-committers mailing list.
1701
1702         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1703
1704 2011-05-25  Adam Roben  <aroben@apple.com>
1705
1706         Don't assume that builds finish in the order they were started
1707
1708         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
1709         build when one slave is taking a long time to finish a build
1710
1711         Reviewed by Antti Koivisto.
1712
1713         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1714         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
1715         newer than the oldest in-progress build are also themselves in progress. Just check whether
1716         each build is actually in progress (as signified by its presence in the currentBuilds set).
1717
1718 2011-05-25  Adam Roben  <aroben@apple.com>
1719
1720         Correctly detect cases where only a single test failed/crashed/timed out
1721
1722         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
1723         failing test
1724
1725         Reviewed by Darin Adler.
1726
1727         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1728         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
1729         will be singular when only a single test fails/crashes/times out.
1730
1731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1732         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
1733         failed/crashed/timed out.
1734
1735 2011-05-26  Tom Hudson  <tomhudson@google.com>
1736
1737         Reviewed by Tony Chang.
1738
1739         Add flags to Chromium ImageDiff to write image comparison metrics on
1740         stdout.
1741         https://bugs.webkit.org/show_bug.cgi?id=60569
1742
1743         * DumpRenderTree/chromium/ImageDiff.cpp:
1744         (Image::createFromStdin): Fix spelling.
1745         (maxOf3): New function to do 3-way maximum.
1746         (getRedComponent): Extract red component from ABGR packed encoding.
1747         (getGreenComponent): Extract green component from ABGR packed encoding.
1748         (getBlueComponent): Extract blue component from ABGR packed encoding.
1749         (weightedPercentageDifferent): Determine % of pixels different in two
1750         images multiplied by intensity difference of each pixel.
1751         (printHelp): Document new arguments.
1752         (compareImages): Parameterize.
1753         (untestedCompareImages): Parameterize.
1754         (diffImages): Parameterize; write results on stdout if requested.
1755         (main): Parse new arguments.
1756
1757 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1758
1759         Reviewed by Simon Hausmann.
1760
1761         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
1762         https://bugs.webkit.org/show_bug.cgi?id=42697
1763
1764         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
1765
1766         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1767         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1768         (WTR::InjectedBundle::beginTesting):
1769         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1770         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
1771         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1772
1773 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
1774
1775         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
1776         https://bugs.webkit.org/show_bug.cgi?id=61428
1777         <rdar://problem/9457006>
1778
1779         Reviewed by Adam Roben.
1780
1781         The crash occurs when Flash posts a message to a window that it
1782         creates, and in processing the message, it calls NPN_Evaluate to
1783         evaluate JavaScript that removes the plug-in from the page. Flash then
1784         crashes when we return to Flash code.
1785
1786         This test emulates that behavior.
1787
1788         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
1789         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
1790         Initialize member vars.
1791         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
1792         Remove our custom property from the message window, and destroy it.
1793         (CallJSThatDestroysPlugin::NPP_Destroy):
1794         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
1795         layout test controller that we're done.
1796         (wndProc):
1797         Get the PluginTest object, and call its runTest() function.
1798         (CallJSThatDestroysPlugin::NPP_New):
1799         Setup the test: register a class for the message-only window, create
1800         it, and post a message to it to run the test.
1801         (CallJSThatDestroysPlugin::runTest):
1802         Execute JS that removes the plug-in from the page, and if we're not
1803         destroyed, log a success message.
1804
1805         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1806         Add new test to project.
1807
1808 2011-05-25  Tony Chang  <tony@chromium.org>
1809
1810         Reviewed by Adam Barth.
1811
1812         webkitpy's NetworkTransaction shouldn't use mechanize
1813         https://bugs.webkit.org/show_bug.cgi?id=61450
1814
1815         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1816         use urllib2 directly.  Re-add NetworkTransaction to
1817         test_results_uploader.py (reverting r87124).
1818
1819         * Scripts/webkitpy/common/net/networktransaction.py:
1820         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1821
1822 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1823
1824         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1825         until the port begins using those export macros.
1826
1827         * DumpRenderTree/chromium/config.h:
1828
1829 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1830
1831         Unreviewed, rolling out r87257.
1832         http://trac.webkit.org/changeset/87257
1833         https://bugs.webkit.org/show_bug.cgi?id=61457
1834
1835         This broke layout tests, see bug 61431. (Requested by
1836         hwennborg on #webkit).
1837
1838         * DumpRenderTree/chromium/LayoutTestController.cpp:
1839         (LayoutTestController::LayoutTestController):
1840         (LayoutTestController::clearAllDatabases):
1841         * DumpRenderTree/chromium/LayoutTestController.h:
1842
1843 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1844
1845         Reviewed by Andreas Kling.
1846
1847         [Qt] fast/css/disabled-author-styles.html failed
1848         https://bugs.webkit.org/show_bug.cgi?id=61438
1849
1850         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1851
1852         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1853         (WebCore::WebPage::resetSettings):
1854         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1855         (LayoutTestController::setAuthorAndUserStylesEnabled):
1856         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1857
1858 2011-05-25  Adam Roben  <aroben@apple.com>
1859
1860         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1861
1862         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1863         started exiting early due to too many crashes, timeouts, or failures
1864
1865         Reviewed by David Kilzer.
1866
1867         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1868         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1869         run-webkit-tests exits early due to too many failures, pass that information in another
1870         argument to the callback.
1871         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1872         the new structure of the object passed to the callback.
1873         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1874         getNumberOfFailingTests and to pass that along to our own callbacks.
1875         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1876         from _getFailingTests and to store that value in the history object.
1877
1878         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1879         (.info): Added.
1880
1881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1882         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1883         object and to add a note when run-webkit-tests exited early due to too many failures.
1884         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1885         latestBuildInfos since each entry now contains more than just the tester and failure count.
1886         Now displays a message for testers where the latest build exited early due to too many
1887         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1888         store that value in latestBuildInfos.
1889
1890 2011-05-24  Keishi Hattori  <keishi@webkit.org>
1891
1892         Reviewed by Kent Tamura.
1893
1894         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1895         https://bugs.webkit.org/show_bug.cgi?id=61273
1896
1897         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
1898
1899 2011-05-24  Greg Simon  <gregsimon@chromium.org>
1900
1901         Reviewed by Dimitri Glazkov.
1902
1903         Control Indexeddb backends from LayoutTestController
1904         https://bugs.webkit.org/show_bug.cgi?id=61000
1905
1906         * DumpRenderTree/chromium/LayoutTestController.cpp:
1907         (LayoutTestController::LayoutTestController):
1908         (LayoutTestController::setOverrideIndexedDBBackingStore):
1909         (LayoutTestController::clearAllDatabases):
1910         * DumpRenderTree/chromium/LayoutTestController.h:
1911
1912 2011-05-24  Robert Hogan  <robert@webkit.org>
1913
1914         Reviewed by Ryosuke Niwa.
1915
1916         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
1917         https://bugs.webkit.org/show_bug.cgi?id=61393
1918
1919         * DumpRenderTree/qt/EventSenderQt.h:
1920         * DumpRenderTree/qt/EventSenderQt.cpp:
1921         (getModifiers): static function for interpreting modifiers
1922         (EventSender::mouseDown): Respect keyboard modifiers
1923         (EventSender::keyDown): use new static function
1924         (EventSender::sendOrQueueEvent): whitespace fix
1925
1926 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
1927
1928         Reviewed by Adam Barth.
1929
1930         Adding MHTML reading support.
1931         https://bugs.webkit.org/show_bug.cgi?id=7168
1932
1933         * Scripts/build-webkit:
1934         * Scripts/old-run-webkit-tests:
1935         * Scripts/webkitperl/features.pm:
1936         * Scripts/webkitpy/layout_tests/port/test_files.py:
1937         * Scripts/webkitpy/layout_tests/port/webkit.py:
1938
1939 2011-05-24  Stephen White  <senorblanco@chromium.org>
1940
1941         Reviewed by Kenneth Russell.
1942
1943         Remove most style checks on Source/ThirdParty/glu, since it doesn't
1944         follow WebKit style.
1945         https://bugs.webkit.org/show_bug.cgi?id=61365
1946
1947         * Scripts/webkitpy/style/checker.py:
1948
1949 2011-05-24  Adam Roben  <aroben@apple.com>
1950
1951         Don't allow forcing builds through the build.webkit.org web interface
1952
1953         Someone has been forcing bogus builds.
1954
1955         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1956
1957 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
1958
1959         Reviewed by Adam Roben.
1960
1961         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1962         https://bugs.webkit.org/show_bug.cgi?id=42669
1963
1964         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
1965         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
1966         Because that case changed the setting.
1967
1968         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1969         (WTR::InjectedBundle::beginTesting):
1970
1971 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1972
1973         Reviewed by Kenneth Rohde Christiansen.
1974
1975         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
1976         https://bugs.webkit.org/show_bug.cgi?id=61052
1977
1978         * Scripts/old-run-webkit-tests:
1979
1980 2011-05-24  Adam Roben  <aroben@apple.com>
1981
1982         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
1983
1984         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
1985         that don't have any failing tests, which isn't useful
1986
1987         Reviewed by David Kilzer.
1988
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
1990         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
1991         instead of name strings.
1992         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
1993         builder names into an array of builders.
1994
1995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1996         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
1997         the most recently completed build, or -1 if there is no such build.
1998         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
1999         in the given build, or -1 if the number could not be determined. Some of this code came from
2000         _getFailingTests.
2001         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
2002         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
2003         getNumberOfFailingTests functions.
2004
2005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2006         (ViewController.prototype._displayTesters): Get the current number of test failures for each
2007         tester and show it in the list. Omit testers that have no failures at all. We keep the
2008         testers and failure counts in an array and sort it before displaying the current data, as
2009         the order in which data will be fetched is unpredictable.
2010
2011 2011-05-23  Tony Chang  <tony@chromium.org>
2012
2013         Reviewed by Ojan Vafai.
2014
2015         [nrwt] don't use NetworkTranslation when uploading results
2016         https://bugs.webkit.org/show_bug.cgi?id=61315
2017
2018         This avoids autoinstalling mechanize.  It didn't matter anyway
2019         because test_results_uploader.py wasn't using mechanize to make the
2020         request so NetworkTransaction::run wasn't doing anything extra
2021         (it only matters if it catches mechanize.HTTPError).
2022
2023         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2024
2025 2011-05-23  Tony Chang  <tony@chromium.org>
2026
2027         Reviewed by Dirk Pranke.
2028
2029         [chromium] fix the rebaseline tool to work with Linux GPU failures
2030         https://bugs.webkit.org/show_bug.cgi?id=61312
2031
2032         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2033
2034 2011-05-23  Darin Adler  <darin@apple.com>
2035
2036         Ignore generated .pyc files in a directory full of python code.
2037
2038         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
2039
2040 2011-05-23  Adam Barth  <abarth@webkit.org>
2041
2042         Reviewed by Eric Seidel.
2043
2044         sheriffbot should give more details about the failures in IRC
2045         https://bugs.webkit.org/show_bug.cgi?id=61233
2046
2047         With this patch, sheriffbot will annonce the set of failing tests,
2048         which might help folks triage the problem.
2049
2050         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2051         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2052
2053 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2054
2055         Unreviewed, rolling out r87078.
2056         http://trac.webkit.org/changeset/87078
2057         https://bugs.webkit.org/show_bug.cgi?id=61294
2058
2059         Patch contains errors and seems likely to break a bunch of
2060         bots (Requested by abarth on #webkit).
2061
2062         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2063         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2064         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2065
2066 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
2067
2068         Reviewed by Ojan Vafai.
2069
2070         Convert json_results_generator.py to output version 4 JSON.
2071         https://bugs.webkit.org/show_bug.cgi?id=60869
2072
2073         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2074         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2075         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2076
2077 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
2078
2079         Reviewed by Adam Barth.
2080
2081         Move generation of shell_command from port to executive
2082         https://bugs.webkit.org/show_bug.cgi?id=61251
2083
2084         After move it's possible to use the code in other places too.
2085
2086         * Scripts/webkitpy/common/config/ports.py:
2087         * Scripts/webkitpy/common/system/executive.py:
2088
2089 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
2090
2091         Reviewed by Darin Adler.
2092
2093         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2094         https://bugs.webkit.org/show_bug.cgi?id=42669
2095
2096         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
2097
2098         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2099         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2100         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
2101         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2102
2103 2011-05-22  Robert Hogan  <robert@webkit.org>
2104
2105         Reviewed by Kenneth Rohde Christiansen.
2106
2107         Fix policyDelegate in Qt DRT
2108         https://bugs.webkit.org/show_bug.cgi?id=61247
2109
2110         Use the 'policy delegate' implemented in FrameLoaderClient
2111         for layout tests. The partial implementation in DumpRenderTreeQt
2112         is redundant, so remove it.
2113
2114         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2115         (WebCore::WebPage::acceptNavigationRequest):
2116         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2117         (LayoutTestController::waitForPolicyDelegate):
2118
2119 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
2120
2121         Reviewed by Darin Adler.
2122
2123         Use double quotes for filename arguments
2124         https://bugs.webkit.org/show_bug.cgi?id=61250
2125
2126         Windows does not support single quotes on the command line,
2127         so replace them with double quotes.
2128
2129         * Scripts/prepare-ChangeLog:
2130
2131 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
2132
2133         Reviewed by Sam Weinig.
2134
2135         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
2136         https://bugs.webkit.org/show_bug.cgi?id=42550
2137         
2138         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
2139
2140         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2141         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2142         Copy the code for pausing animations, FIXME comments and all.
2143         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2144         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2145
2146 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
2147
2148         Reviewed by Stephen White.
2149
2150         Adding myself to the committers list.
2151
2152         * Scripts/webkitpy/common/config/committers.py:
2153
2154 2011-05-19  Adam Roben  <aroben@apple.com>
2155
2156         Test that the WebKit2 UI process doesn't crash when starting a download
2157
2158         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
2159         (preceded by assertion) in fastMalloc when downloading a file
2160
2161         Reviewed by Darin Adler.
2162
2163         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
2164
2165         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
2166         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
2167         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
2168         started, cancel the download, and return a bogus string.
2169
2170         (TestWebKitAPI::setContextDownloadClient):
2171         (TestWebKitAPI::setPagePolicyClient):
2172         Simple helper functions.
2173
2174         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
2175         our policy client, and run until we know that the download was started. If we haven't
2176         crashed, we win!
2177
2178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2179         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2180         * TestWebKitAPI/win/copy-resources.cmd:
2181         Added new files.
2182
2183 2011-05-20  Kent Tamura  <tkent@chromium.org>
2184
2185         Reviewed by Ryosuke Niwa.
2186
2187         Fix style errors in DumpRenderTree/chromium/.
2188         https://bugs.webkit.org/show_bug.cgi?id=61172
2189
2190         * DumpRenderTree/chromium/CppBoundClass.cpp:
2191         (CppBoundClass::getAsCppVariant):
2192         (CppBoundClass::bindToJavascript):
2193         * DumpRenderTree/chromium/CppBoundClass.h:
2194         (CppBoundClass::GetterCallback::~GetterCallback):
2195         (CppBoundClass::CppBoundClass):
2196         (CppBoundClass::Callback::~Callback):
2197         (CppBoundClass::MemberCallback::MemberCallback):
2198         (CppBoundClass::MemberCallback::~MemberCallback):
2199         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
2200         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
2201         * DumpRenderTree/chromium/CppVariant.h:
2202         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2203         (DRTDevToolsAgent::~DRTDevToolsAgent):
2204         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2205         (DRTDevToolsClient::sendFrontendLoaded):
2206         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2207         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2208         (main):
2209         * DumpRenderTree/chromium/EventSender.cpp:
2210         (SavedEvent::SavedEvent):
2211         (EventSender::EventSender):
2212         (EventSender::keyDown):
2213         * DumpRenderTree/chromium/EventSender.h:
2214         * DumpRenderTree/chromium/ImageDiff.cpp:
2215         (Image::Image):
2216         * DumpRenderTree/chromium/LayoutTestController.cpp:
2217         (LayoutTestController::LayoutTestController):
2218         (LayoutTestController::WorkQueue::reset):
2219         (WorkItemBackForward::WorkItemBackForward):
2220         (WorkItemLoadingScript::WorkItemLoadingScript):
2221         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
2222         (WorkItemLoad::WorkItemLoad):
2223         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2224         (LayoutTestController::pathToLocalResource):
2225         * DumpRenderTree/chromium/LayoutTestController.h:
2226         (LayoutTestController::WorkItem::~WorkItem):
2227         (LayoutTestController::WorkQueue::WorkQueue):
2228         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2229         (MockSpellCheck::MockSpellCheck):
2230         (MockSpellCheck::~MockSpellCheck):
2231         * DumpRenderTree/chromium/MockSpellCheck.h:
2232         * DumpRenderTree/chromium/NotificationPresenter.h:
2233         (NotificationPresenter::NotificationPresenter):
2234         * DumpRenderTree/chromium/Task.cpp:
2235         (WebTask::WebTask):
2236         * DumpRenderTree/chromium/Task.h:
2237         (TaskList::TaskList):
2238         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2239         (DRTPrinter::DRTPrinter):
2240         (TestShellPrinter::TestShellPrinter):
2241         * DumpRenderTree/chromium/TestNavigationController.cpp:
2242         (TestNavigationEntry::TestNavigationEntry):
2243         (TestNavigationEntry::~TestNavigationEntry):
2244         (TestNavigationController::TestNavigationController):
2245         (TestNavigationController::reload):
2246         (TestNavigationController::loadEntry):
2247         (TestNavigationController::didNavigateToEntry):
2248         * DumpRenderTree/chromium/TestNavigationController.h:
2249         (TestShellExtraData::TestShellExtraData):
2250         * DumpRenderTree/chromium/TestShell.cpp:
2251         (dumpHistoryItem):
2252         * DumpRenderTree/chromium/TestShell.h:
2253         (TestParams::TestParams):
2254         * DumpRenderTree/chromium/TestShellWin.cpp:
2255         (TestShell::waitTestFinished):
2256         * DumpRenderTree/chromium/TestWebWorker.h:
2257         (TestWebWorker::startWorkerContext):
2258         (TestWebWorker::terminateWorkerContext):
2259         (TestWebWorker::postMessageToWorkerContext):
2260         (TestWebWorker::clientDestroyed):
2261         (TestWebWorker::postMessageToWorkerObject):
2262         (TestWebWorker::postExceptionToWorkerObject):
2263         (TestWebWorker::postConsoleMessageToWorkerObject):
2264         (TestWebWorker::confirmMessageFromWorkerObject):
2265         (TestWebWorker::reportPendingActivity):
2266         (TestWebWorker::workerContextClosed):
2267         (TestWebWorker::~TestWebWorker):
2268         * DumpRenderTree/chromium/TextInputController.cpp:
2269         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2270         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2271         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2272         (WebThemeEngineDRTWin::paintButton):
2273         (WebThemeEngineDRTWin::paintMenuList):
2274         (WebThemeEngineDRTWin::paintTrackbar):
2275         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2276         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2277         * DumpRenderTree/chromium/WebViewHost.cpp:
2278         (WebViewHost::navigate):
2279         (WebViewHost::updateSessionHistory):
2280         (WebViewHost::paintInvalidatedRegion):
2281         * DumpRenderTree/chromium/WebViewHost.h:
2282
2283 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2284
2285         Reviewed by Adam Roben.
2286
2287         Detect hangs in run-api-tests
2288         https://bugs.webkit.org/show_bug.cgi?id=48043
2289
2290         * Scripts/run-api-tests: Added test timeouts
2291
2292 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2293
2294         Reviewed by Adam Roben.
2295
2296         run-api-tests should run one test per process
2297         https://bugs.webkit.org/show_bug.cgi?id=61088
2298
2299         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
2300         return code, and parsing GTest output format.
2301
2302 2011-05-15  Robert Hogan  <robert@webkit.org>
2303
2304         Reviewed by Antonio Gomes.
2305
2306         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
2307         https://bugs.webkit.org/show_bug.cgi?id=60834
2308         Fix unix test plugin for plugins/get-url-with-javascript-url.html
2309
2310         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2311         (webkit_test_plugin_new_stream):
2312         (webkit_test_plugin_write_ready):
2313         (webkit_test_plugin_write):
2314
2315 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2316
2317         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
2318         http://trac.webkit.org/changeset/86869
2319         http://trac.webkit.org/changeset/86873
2320         http://trac.webkit.org/changeset/86875
2321         http://trac.webkit.org/changeset/86877
2322         https://bugs.webkit.org/show_bug.cgi?id=61139
2323
2324         broke builds and debug DRT (Requested by rniwa on #webkit).
2325
2326         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2327         * DumpRenderTree/chromium/TestShell.cpp:
2328         (TestShell::bindJSObjectsToWindow):
2329         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2330         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2331
2332 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
2333
2334         Reviewed by Darin Adler.
2335
2336         Add build logistics and plumbing for window.internals object.
2337         https://bugs.webkit.org/show_bug.cgi?id=60313
2338
2339         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2340         * DumpRenderTree/chromium/TestShell.cpp:
2341         (TestShell::bindJSObjectsToWindow): Added injection code.
2342         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2343         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2344
2345 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2346
2347         Reviewed by Csaba Osztrogonác.
2348
2349         [Qt] Implement eventSender.scalePageBy
2350         https://bugs.webkit.org/show_bug.cgi?id=60015
2351
2352         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2353         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2354         * DumpRenderTree/qt/EventSenderQt.cpp:
2355         (EventSender::scalePageBy):
2356         * DumpRenderTree/qt/EventSenderQt.h:
2357
2358 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
2359
2360         Reviewed by Kent Tamura.
2361
2362         [Chromium] IME candidate window appears wrong position in an iframe
2363         https://bugs.webkit.org/show_bug.cgi?id=61023
2364
2365         Call the focused frame's firstRectForCharacterRange() instead of the
2366         main frame so that DRT behaves as the same as Chromium.
2367
2368         * DumpRenderTree/chromium/TextInputController.cpp:
2369         (TextInputController::firstRectForCharacterRange):
2370
2371 2011-05-18  Adam Roben  <aroben@apple.com>
2372
2373         Add a new page to build.webkit.org to help find when tests started failing
2374
2375         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
2376         right now, but already shows some useful information. It's somewhat similar to webkit-patch
2377         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
2378         little more convenient than either of them, though, because it's all done in the browser
2379         (and thus it's easy to go directly to the relevant test results).
2380
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
2382         (Buildbot): This class represents a Buildbot server.
2383         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
2384         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
2385         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
2386         callback.
2387         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
2388         be implemented by a derived class that understands this server's build naming scheme.
2389         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2390         particular build.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
2393         (Builder): This class represents one builder on the buildbot.
2394         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
2395         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
2396         information about a particular test failure.
2397         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
2398         information about when tests started failing.
2399         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2400         particular build.
2401         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
2402         callback.
2403         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
2404         extracts all the failing tests listed in it, passing them to the callback.
2405         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
2406         build, merges them into the build history, and calls the callback telling it whether the
2407         next build should be fetched to provide more information.
2408
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2410         Added. Just some simple styles.
2411
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
2413         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
2414         (getResource): Wrapper around XMLHttpRequest.
2415         (Array.prototype.findFirst): Finds the first element matching the given predicate and
2416         returns it.
2417         (Array.prototype.last): Returns the last element of the array.
2418
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
2420         (ViewController): This class contains the main logic for displaying the page.
2421         (ViewController.loaded): Just calls through to parseHash.
2422         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
2423         shows the list of all testers so one can be chosen. This function is called when the page
2424         loads and whenever we get a hashchange event.
2425         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
2426         as it is fetched. The display ends up grouping tests by when they started failing.
2427         (ViewController._displayTesters): Gets the list of testers and displays it.
2428
2429         (ViewController._domForBuildName):
2430         (ViewController._domForFailedTest):
2431         Helper functions to create descriptions and links for a particular build or failed test.
2432
2433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
2434         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
2435         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
2436
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
2438         loads all the files and sets up a ViewController, which does the rest.
2439
2440         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
2441         page.
2442
2443 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2444
2445         Reviewed by Csaba Osztrogonác.
2446
2447         [Qt] Implement layoutTestController.setValueForUser()
2448         https://bugs.webkit.org/show_bug.cgi?id=60956
2449
2450         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2451         (LayoutTestController::setValueForUser):
2452         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2453
2454 2011-05-16  Robert Hogan  <robert@webkit.org>
2455
2456         Reviewed by Kenneth Rohde Christiansen.
2457
2458         plugins/invalidate_rect.html fails on linux ports
2459
2460         - Make the unix test netscape plugin recognize the onPaintEvent
2461           and windowedPlugin parameters.
2462
2463         https://bugs.webkit.org/show_bug.cgi?id=54051
2464
2465         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2466         (handleEventX11):
2467         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2468         (LayoutTestController::displayInvalidatedRegion):
2469         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2470         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2471         (webkit_test_plugin_new_instance):
2472         (webkit_test_plugin_handle_event):
2473
2474 2011-05-17  Tony Chang  <tony@chromium.org>
2475
2476         Reviewed by Ojan Vafai.
2477
2478         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
2479         https://bugs.webkit.org/show_bug.cgi?id=60895
2480
2481         Update the tools to handle the move.  Lucid 32 results now go in
2482         chromium-linux-x86 and the default platform on Linux is now x86_64.
2483
2484         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
2485         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2486         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
2487         * Scripts/webkitpy/layout_tests/port/base.py: ditto
2488         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
2489         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2490         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
2491         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
2492         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
2493
2494 2011-05-17  Adam Roben  <aroben@apple.com>
2495
2496         Make run-api-tests work on Windows when there are spaces in the path
2497
2498         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
2499         spaces in the path to TestWebKitAPI.exe
2500
2501         Reviewed by David Levin.
2502
2503         * Scripts/run-api-tests:
2504         (runTestTool): Use the "direct object" form of system() to avoid having the path to
2505         TestWebKitAPI.exe be split by the shell.
2506
2507 2011-05-16  Ian Henderson  <ianh@apple.com>
2508
2509         Reviewed by Joseph Pecoraro.
2510
2511         Page::goToItem doesn't work while loading is deferred
2512         https://bugs.webkit.org/show_bug.cgi?id=60412
2513
2514         Add setDefersLoading and goBack methods to LayoutTestController.  We
2515         need to use goBack() instead of history.back() because the latter goes
2516         through NavigationScheduler, hence doesn't exhibit the bug.
2517
2518         * DumpRenderTree/LayoutTestController.cpp:
2519         (goBackCallback):
2520         (setDefersLoadingCallback):
2521         (LayoutTestController::staticFunctions):
2522         * DumpRenderTree/LayoutTestController.h:
2523         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2524         (LayoutTestController::goBack):
2525         (LayoutTestController::setDefersLoading):
2526         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2527         (LayoutTestController::goBack):
2528         (LayoutTestController::setDefersLoading):
2529         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2530         (LayoutTestController::goBack):
2531         (LayoutTestController::setDefersLoading):
2532         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2533         (LayoutTestController::goBack):
2534         (LayoutTestController::setDefersLoading):
2535
2536 2011-05-16  Sam Weinig  <sam@webkit.org>
2537
2538         Reviewed by Anders Carlsson.
2539
2540         TestWebKitAPI should build with clang if it can
2541         https://bugs.webkit.org/show_bug.cgi?id=60918
2542
2543         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2544         Update CompilerVersion.xcconfig to match others.
2545
2546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2547         Add CompilerVersion.xcconfig to the project.
2548
2549         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2550         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2551         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2552         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2553         Add some casts to quiet warnings from clang.
2554
2555 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
2556
2557         Reviewed by David Levin.
2558
2559         add dpranke as a reviewer
2560         https://bugs.webkit.org/show_bug.cgi?id=60919
2561
2562         * Scripts/webkitpy/common/config/committers.py:
2563
2564 2011-05-16  Robert Hogan  <robert@webkit.org>
2565
2566         Reviewed by Anders Carlsson.
2567
2568         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
2569
2570         https://bugs.webkit.org/show_bug.cgi?id=60838
2571
2572         The unix test plugin needs to call the test's NPP_URLNotify
2573         rather than the browsers.
2574
2575         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2576         (webkit_test_plugin_url_notify):
2577
2578 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
2579
2580         Rubber-stamped by Adam Roben.
2581
2582         Adding myself as a reviewer.
2583         * Scripts/webkitpy/common/config/committers.py:
2584
2585 2011-05-16  Sam Weinig  <sam@webkit.org>
2586
2587         Fix typo pointed out by Dave Levin.
2588
2589         * TestWebKitAPI/PlatformUtilities.h:
2590         (TestWebKitAPI::Util::assertWKStringEqual):
2591         Strig -> String.
2592
2593 2011-05-16  Sam Weinig  <sam@webkit.org>
2594
2595         Reviewed by David Levin.
2596
2597         Convert api tester over to using gtest expectations directly
2598         https://bugs.webkit.org/show_bug.cgi?id=60862
2599
2600         * TestWebKitAPI/PlatformUtilities.cpp:
2601         (TestWebKitAPI::Util::toSTD):
2602         * TestWebKitAPI/PlatformUtilities.h:
2603         (TestWebKitAPI::Util::assertWKStrigEqual):
2604         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
2605         the implementation of the macro simpler.
2606
2607         * TestWebKitAPI/Test.h:
2608         Remove TEST_ASSERT forwarder.
2609
2610         [Test changes elided]
2611
2612 2011-05-16  David Kilzer  <ddkilzer@apple.com>
2613
2614         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
2615         <rdar://problem/9446430>
2616
2617         Reviewed by Mark Rowe.
2618
2619         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
2620         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2621         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2622
2623 2011-05-16  Jon Lee  <jonlee@apple.com>
2624
2625         Reviewed by Simon Fraser.
2626
2627         Can't horizontally scroll iframes and overflow because wheel events are always accepted
2628         https://bugs.webkit.org/show_bug.cgi?id=60779
2629
2630         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2631         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
2632
2633 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2634
2635         Reviewed by Csaba Osztrogonác.
2636
2637         [Qt] Tools.pro misses include(common.pri)
2638         https://bugs.webkit.org/show_bug.cgi?id=60883
2639
2640         It includes features.pri, which depends on common.pri (the build is
2641         not broken today with the default options, but this is the right
2642         thing to do).
2643
2644         * Tools.pro:
2645
2646 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
2647
2648         Unreviewed: adding myself to committers.py.
2649
2650         * Scripts/webkitpy/common/config/committers.py:
2651
2652 2011-05-15  Daniel Bates  <dbates@webkit.org>
2653
2654         Reviewed by Chris Jerdonek.
2655
2656         svn-apply can't handle Git diff that only changes executable bit
2657         https://bugs.webkit.org/show_bug.cgi?id=60848
2658
2659         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
2660         that only has an executable bit change.
2661
2662         * Scripts/VCSUtils.pm:
2663           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
2664         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
2665         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
2666         * Scripts/svn-apply:
2667         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
2668         * Scripts/svn-unapply:
2669         (patch): Ditto.
2670         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2671           - Updated expected results for test cases to account for numTextChunks.
2672           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
2673           - Added test case "Git: file that only has an executable bit change".
2674         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2675           - Updated expected results for test cases to account for numTextChunks.
2676
2677 2011-05-15  Sam Weinig  <sam@webkit.org>
2678
2679         Fix windows build.
2680
2681         * TestWebKitAPI/win/main.cpp:
2682         (main):
2683
2684 2011-05-15  Sam Weinig  <sam@webkit.org>
2685
2686         Reviewed by David Levin.
2687
2688         Make API tester more gtest friendly
2689         https://bugs.webkit.org/show_bug.cgi?id=60859
2690
2691         * Scripts/run-api-tests:
2692         Numerous changes:
2693         - Remove logic to run tests one at a time.
2694         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
2695           the test runner and allow gtest to print it for us.
2696         - Forward stdout from the test tool to stdout, even in non-verbose runs.
2697         - Run test tool from the current working directory instead of the root webkit
2698           directory.
2699
2700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2701         Move plist to be with other bundle sources.
2702
2703         * TestWebKitAPI/TestsController.cpp:
2704         (TestWebKitAPI::TestsController::TestsController):
2705         (TestWebKitAPI::TestsController::run):
2706         * TestWebKitAPI/TestsController.h:
2707         * TestWebKitAPI/mac/main.mm:
2708         Simplify TestController down to a single run function. We should consider removing the class
2709         entirely at some point.
2710
2711 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2712
2713         Unreviewed, rolling out r86504.
2714         http://trac.webkit.org/changeset/86504
2715         https://bugs.webkit.org/show_bug.cgi?id=60853
2716
2717         "Broke Qt EventSender in editing/selection tests" (Requested
2718         by mwenge on #webkit).
2719
2720         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2721         (WebCore::WebPage::WebPage):
2722         (WebCore::DumpRenderTree::DumpRenderTree):
2723         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2724         (WebCore::DumpRenderTree::initJSObjects):
2725         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2726         (WebCore::DumpRenderTree::eventSender):
2727         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2728         (webkit_test_plugin_new_instance):
2729         (webkit_test_plugin_set_window):
2730         (webkit_test_plugin_handle_event):
2731
2732 2011-05-12  Robert Hogan  <robert@webkit.org>
2733
2734         Reviewed by Benjamin Poulain.
2735
2736         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2737
2738         The support for this test added to the unix test plugin here
2739         may allow other platforms to pass it (nearly everyone
2740         skips it). On Qt it required a bit of trickiness with
2741         the page's EventSender object to get it working fully though,
2742         so only unskipping Qt here.
2743
2744         https://bugs.webkit.org/show_bug.cgi?id=60722
2745
2746         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2747         (WebCore::WebPage::WebPage):
2748         (WebCore::WebPage::eventSender):
2749         (WebCore::DumpRenderTree::DumpRenderTree):
2750         (WebCore::DumpRenderTree::initJSObjects):
2751         (WebCore::DumpRenderTree::createWindow):
2752         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2753         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2754         (webkit_test_plugin_new_instance):
2755         (webkit_test_plugin_set_window):
2756         (webkit_test_plugin_handle_event):
2757
2758 2011-05-14  Arno Renevier  <arno@renevier.net>
2759
2760         Reviewed by Martin Robinson.
2761
2762         make run-gtk-tests executable
2763         https://bugs.webkit.org/show_bug.cgi?id=59278
2764
2765         * Scripts/run-gtk-tests:
2766
2767 2011-05-14  Anders Carlsson  <andersca@apple.com>
2768
2769         Reviewed by Kevin Decker.
2770
2771         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2772         https://bugs.webkit.org/show_bug.cgi?id=60823
2773         <rdar://problem/9430386>
2774
2775         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2776
2777         * DumpRenderTree/DumpRenderTree.gypi:
2778         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2779         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2780         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2781         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2782         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2783         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2784         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2785         * GNUmakefile.am:
2786
2787 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2788
2789         Unreviewed, rolling out r86476.
2790         http://trac.webkit.org/changeset/86476
2791         https://bugs.webkit.org/show_bug.cgi?id=60832
2792
2793         It made plugins/get-url-notify-with-url-that-fails-to-
2794         load.html crash on GTK (Requested by Ossy on #webkit).
2795
2796         * DumpRenderTree/DumpRenderTree.gypi:
2797         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2798         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
2799         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2800         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2801         * GNUmakefile.am:
2802
2803 2011-05-13  Anders Carlsson  <andersca@apple.com>
2804
2805         Reviewed by Sam Weinig.
2806
2807         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2808         https://bugs.webkit.org/show_bug.cgi?id=60823
2809         <rdar://problem/9430386>
2810
2811         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2812
2813         * DumpRenderTree/DumpRenderTree.gypi:
2814         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2815         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2816         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2817         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2818         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2819         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2820         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2821         * GNUmakefile.am:
2822
2823 2011-05-13  Anders Carlsson  <andersca@apple.com>
2824
2825         Build fix.
2826
2827         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2828
2829 2011-05-13  Anders Carlsson  <andersca@apple.com>
2830
2831         Reviewed by Sam Weinig.
2832
2833         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2834         https://bugs.webkit.org/show_bug.cgi?id=60810
2835
2836         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2837
2838         * DumpRenderTree/DumpRenderTree.gypi:
2839         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2840         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2841         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2842         * GNUmakefile.am:
2843         Add files.
2844
2845         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2846         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2847         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2848
2849         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2850         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2851         (GetURLWithJavaScriptURL::NPP_New):
2852         (GetURLWithJavaScriptURL::NPP_NewStream):
2853         (GetURLWithJavaScriptURL::NPP_DestroyStream):
2854         (GetURLWithJavaScriptURL::NPP_WriteReady):
2855         (GetURLWithJavaScriptURL::NPP_Write):
2856         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2857         (NPP_NewStream):
2858         (NPP_WriteReady):
2859         (NPP_Write):
2860         (NPP_URLNotify):
2861         call the PluginTest NPP wrappers.
2862
2863 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2864
2865         Unreviewed, rolling out r86447.
2866         http://trac.webkit.org/changeset/86447
2867         https://bugs.webkit.org/show_bug.cgi?id=60809
2868
2869         "Broke some uses of EventSender object on Qt" (Requested by
2870         mwenge on #webkit).
2871
2872         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2873         (WebCore::WebPage::WebPage):
2874         (WebCore::DumpRenderTree::DumpRenderTree):
2875         (WebCore::DumpRenderTree::initJSObjects):
2876         (WebCore::DumpRenderTree::createWindow):
2877         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2878         (WebCore::DumpRenderTree::eventSender):
2879         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2880         (webkit_test_plugin_new_instance):
2881         (webkit_test_plugin_set_window):
2882         (webkit_test_plugin_handle_event):
2883
2884 2011-05-13  Robert Hogan  <robert@webkit.org>
2885
2886         Reviewed by Benjamin Poulain.
2887
2888         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2889
2890         The support for this test added to the unix test plugin here
2891         may allow other platforms to pass it (nearly everyone
2892         skips it). On Qt it required a bit of trickiness with
2893         the page's EventSender object to get it working fully though,
2894         so only unskipping Qt here.
2895
2896         https://bugs.webkit.org/show_bug.cgi?id=60722
2897
2898         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2899         (WebCore::WebPage::WebPage):
2900         (WebCore::WebPage::eventSender):
2901         (WebCore::DumpRenderTree::DumpRenderTree):
2902         (WebCore::DumpRenderTree::initJSObjects):
2903         (WebCore::DumpRenderTree::createWindow):
2904         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2905         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2906         (webkit_test_plugin_new_instance):
2907         (webkit_test_plugin_set_window):
2908         (webkit_test_plugin_handle_event):
2909
2910 2011-05-13  Adam Roben  <aroben@apple.com>
2911
2912         Exclude the Leopard NRWT bot from the core builder set
2913
2914         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
2915
2916         Reviewed by Darin Adler.
2917
2918         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2919         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
2920         in the core builder set.
2921
2922         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2923         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
2924         regexps.
2925
2926 2011-05-13  Adam Roben  <aroben@apple.com>
2927
2928         Group all the NRWT bots together
2929
2930         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
2931         bots are experimental, it seems best not to clutter up the non-experimental bots with
2932         experimental ones.
2933
2934         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
2935         on build.webkit.org
2936
2937         Reviewed by Dan Bernstein.
2938
2939         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
2940         Chromium testers, which also use new-run-webkit-tests.
2941
2942 2011-05-13  Adam Roben  <aroben@apple.com>
2943
2944         Add a plugin test that dumps the plugin window's rect
2945
2946         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
2947         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
2948
2949         Reviewed by Dan Bernstein.
2950
2951         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
2952         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
2953         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
2954         harness window and log it.
2955
2956         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
2957
2958 2011-05-13  Adam Roben  <aroben@apple.com>
2959
2960         Move code required for most tests of plugin window geometry into a base class
2961
2962         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
2963         having all the trickiness in a shared base class, writing new window geometry tests will be
2964         much easier.
2965
2966         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
2967
2968         Reviewed by Anders Carlsson.
2969
2970         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2971         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
2972         WindowGeometryTest base class. Most of the code from this class was moved to the new base
2973         class.
2974         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
2975         This is called by the base class when it is safe to check the window's geometry. Note that
2976         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
2977         just vestigial code from an earlier version of this test.
2978
2979         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
2980         WindowGeometryTest class.
2981
2982         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
2983         WindowRegionIsSetToClipRect.
2984         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
2985         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
2986         Subclasses can implement that function to perform their own tests.
2987
2988         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
2989
2990 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
2991
2992         Reviewed by Csaba Osztrogonác.
2993
2994         Missing 2nd #EOF if WebProcess is killed.
2995         https://bugs.webkit.org/show_bug.cgi?id=60761
2996
2997         If the WebProcess is killed, only one #EOF is yielded
2998         by WebKitTestRunner. However, run-webkit-test wait for
2999         a second #EOF, which signals the finishing of pixel dump.
3000         Since this never happens, run-webkit-test waits forever.
3001
3002         * WebKitTestRunner/TestInvocation.cpp:
3003         (WTR::TestInvocation::dump):
3004         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3005         * WebKitTestRunner/TestInvocation.h:
3006
3007 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3008
3009         Reviewed by Csaba Osztrogonác.
3010
3011         [NRWT] chromium-linux tests shouldn't run on other platforms
3012         https://bugs.webkit.org/show_bug.cgi?id=60162
3013
3014         Remove _tests_for_other_platforms defs because r82753
3015         implemented it properly in the baseclass in webkit.py.
3016
3017         * Scripts/webkitpy/layout_tests/port/gtk.py:
3018         * Scripts/webkitpy/layout_tests/port/qt.py:
3019         * Scripts/webkitpy/layout_tests/port/win.py:
3020
3021 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
3022
3023         Reviewed by Antonio Gomes.
3024
3025         [EFL] Remove unused option of EWeblauncher
3026         https://bugs.webkit.org/show_bug.cgi?id=60747
3027
3028         Remove sudo-workaround option.
3029         This option is not used and make other option wrong.
3030
3031         * EWebLauncher/main.c:
3032
3033 2011-05-12  Lucas Forschler  <lforschler@apple.com>
3034
3035         Reviewed by Stephanie Lewis.
3036
3037         Fix config.json to address missing WK2 builder/tester config.
3038         Fix naming of machines (xserve not macpro)
3039
3040         * BuildSlaveSupport/build.webkit.org-config/config.json:
3041
3042 2011-05-12  Lucas Forschler  <lforschler@apple.com>
3043
3044         Reviewed by Stephanie Lewis.
3045
3046         Add SnowLeopard Debug builder and Test bot.
3047         apple-xserve-8 = SL Debug Tester.
3048         apple-xserve-9 = SL Debug Builder.
3049         
3050         * BuildSlaveSupport/build.webkit.org-config/config.json:
3051
3052 2011-05-12  Adam Barth  <abarth@webkit.org>
3053
3054         This patch disables sheriffbot's bug postings.  He's just been way too
3055         spammy recently due to test flakiness.
3056
3057         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3058         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3059
3060 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
3061
3062         Reviewed by Anders Carlsson.
3063
3064         After relaunching an unresponsive web process, web page stops responding to mouse movement
3065         https://bugs.webkit.org/show_bug.cgi?id=60669
3066         <rdar://problem/9409934>
3067         
3068         This test follows the steps needed to reproduce this bug:
3069         1) Hang the web process
3070         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
3071         3) Kill and restart the WebProcess
3072         4) Move the mouse
3073         
3074         We are testing that we receive mouse move events after the WebProcess has restarted.
3075
3076         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
3077         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
3078         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
3079         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
3080         (TestWebKitAPI::setPageLoaderClient):
3081         (TestWebKitAPI::TEST):
3082         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
3083         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
3084         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
3085         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
3086
3087         * TestWebKitAPI/PlatformWebView.h:
3088         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3089         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
3090         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3091         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
3092
3093         Add new files.
3094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3095         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3096         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3097         * TestWebKitAPI/win/copy-resources.cmd:
3098
3099 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
3100
3101         Reviewed by Antonio Gomes.
3102
3103         [EFL] Added initialization/shutdown for ecore_file library
3104         https://bugs.webkit.org/show_bug.cgi?id=60457
3105
3106         Added initialization and shuthown for ecore_file library and replaced
3107         realpath function to ecore_file_realpath.
3108
3109         * EWebLauncher/main.c:
3110         (quit):
3111         (findThemePath):
3112         (main):
3113
3114 2011-05-12  Young Han Lee  <joybro@company100.net>
3115
3116         Reviewed by Kenneth Rohde Christiansen.
3117
3118         [Qt] Implement layoutTestController.layerTreeAsText()
3119         https://bugs.webkit.org/show_bug.cgi?id=60367
3120
3121         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3122         (LayoutTestController::layerTreeAsText):
3123         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3124
3125 2011-05-11  Eric Seidel  <eric@webkit.org>
3126
3127         Reviewed by David Levin.
3128
3129         Teach validate-committer-lists how to validate committers bugzilla_email()
3130         https://bugs.webkit.org/show_bug.cgi?id=60651
3131
3132         It turns out we currently have 9 committers with invalid values for their
3133         bugzilla_email field (meaning we don't know what email is their bugzilla account).
3134         "Alexander Kellett" <lypanov@mac.com>
3135         "Andre Boule" <aboule@apple.com>
3136         "Cameron McCormack" <cam@webkit.org>
3137         "Chris Petersen" <cpetersen@apple.com>
3138         "Eli Fidler" <eli@staikos.net>
3139         "Matt Lilek" <webkit@mattlilek.com>
3140         "Pierre d'Herbemont" <pdherbemont@free.fr>
3141         "Scott Violet" <sky@chromium.org>
3142         "Adam Treat" <treat@kde.org>
3143
3144         Most of those haven't committed in a very long time, so it's not suprising
3145         that we haven't noticed that their bugzilla emails are bogus.
3146
3147         * Scripts/validate-committer-lists:
3148         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3149         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3150
3151 2011-05-11  Dmitry Lomov  <dslomov@google.com>
3152
3153         Reviewed by David Levin.
3154
3155         https://bugs.webkit.org/show_bug.cgi?id=59561
3156         Switch TestWebKitAPI to GTest
3157
3158         Fixes Makefiles and WinCairo build as well
3159
3160         * Makefile:
3161         * Scripts/build-api-tests:
3162         * Scripts/run-api-tests:
3163         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3164         * TestWebKitAPI/Test.h:
3165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3166         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3167         (TestWebKitAPI::TEST):
3168         * TestWebKitAPI/TestsController.cpp:
3169         (TestWebKitAPI::TestsController::TestsController):
3170         (TestWebKitAPI::TestsController::dumpTestNames):
3171         (TestWebKitAPI::TestsController::runTestNamed):
3172         (TestWebKitAPI::TestsController::runAllTests):
3173         * TestWebKitAPI/TestsController.h:
3174         * TestWebKitAPI/mac/main.mm:
3175         (main):
3176
3177 2011-05-11  Eric Seidel  <eric@webkit.org>
3178
3179         Reviewed by Alexey Proskuryakov.
3180
3181         Add Luke Macpherson to committers.py as a Contributor
3182         https://bugs.webkit.org/show_bug.cgi?id=60639
3183
3184         * Scripts/webkitpy/common/config/committers.py:
3185
3186 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
3187
3188         Reviewed by Kenneth Rohde Christiansen.
3189
3190         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
3191         https://bugs.webkit.org/show_bug.cgi?id=60439
3192
3193         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
3194
3195         * Scripts/build-webkit:
3196
3197 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
3198
3199         Reviewed by Adam Roben.
3200
3201         REGRESSION (r86161): WKPreferences API test failing on Windows
3202         https://bugs.webkit.org/show_bug.cgi?id=60658
3203
3204         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3205         (TestWebKitAPI::TEST):
3206
3207 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
3208
3209         Reviewed by Ojan Vafai.
3210
3211         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
3212         https://bugs.webkit.org/show_bug.cgi?id=60521
3213
3214         First steps towards making the results JSON all hierarchical.
3215
3216         * TestResultServer/model/jsonresults.py:
3217         * TestResultServer/model/jsonresults_unittest.py:
3218
3219 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
3220
3221         [wx] Build fix, adding new LayoutTestController method stubs.
3222
3223         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3224         (LayoutTestController::localStorageDiskUsageForOrigin):
3225         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3226
3227 2011-05-11  Jessie Berlin  <jberlin@apple.com>
3228
3229         Reviewed by Darin Adler.
3230
3231         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
3232         about the usage for both the origin overall and the database in question.
3233         https://bugs.webkit.org/show_bug.cgi?id=60573
3234
3235         * WebKitTestRunner/TestController.cpp:
3236         (WTR::exceededDatabaseQuota):
3237
3238 2011-05-10  Stephen White  <senorblanco@chromium.org>
3239
3240         Reviewed by David Levin.
3241
3242         Adding myself as a reviewer.
3243         https://bugs.webkit.org/show_bug.cgi?id=60587
3244
3245         * Scripts/webkitpy/common/config/committers.py:
3246
3247 2011-05-11  Eric Seidel  <eric@webkit.org>
3248
3249         Reviewed by Csaba Osztrogonác.
3250
3251         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
3252         https://bugs.webkit.org/show_bug.cgi?id=60614
3253
3254         AppEngine has a result limit of 1000.  We hit that when trying
3255         to find out how many patches the style-queue (and other queues)
3256         have passed in the last 30 days.  So lets display 1000+ instead
3257         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
3258
3259         I also made the status pages show "never" instead of just "ago" when we
3260         haven't seen a pass or boot message in the last 1000 messages.
3261
3262         * QueueStatusServer/handlers/queuestatus.py:
3263         * QueueStatusServer/templates/queuestatus.html:
3264
3265 2011-05-11  Adam Barth  <abarth@webkit.org>
3266
3267         Reviewed by Eric Seidel.
3268
3269         sheriffbot shouldn't spam bugs when it can't figure out who to blame
3270         https://bugs.webkit.org/show_bug.cgi?id=60613
3271
3272         This patch limits the number of bugs sheriffbot will spam to three.
3273         Ideally, we'd come up with some smarter huerstics, but hopefully this
3274         will cut down on the bugmail spam for slow bots.
3275
3276         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3277
3278 2011-05-10  Eric Seidel  <eric@webkit.org>
3279
3280         Reviewed by Adam Barth.
3281
3282         EWS bots should be robust against test-webkitpy hangs
3283         https://bugs.webkit.org/show_bug.cgi?id=60579
3284
3285         Added a killAfterTimeout subroutine, which takes a child_pid
3286         and timeout, and will setup a watchdog process to kill that child
3287         after the timeout.  killAfterTimeout will waitpid on the child.
3288
3289         * EWSTools/start-queue.sh:
3290
3291 2011-05-10  MORITA Hajime  <morrita@google.com>
3292
3293         Unreviewed, moved myself to the reviewers list.
3294
3295         * Scripts/webkitpy/common/config/committers.py:
3296
3297 2011-05-10  Anton D'Auria  <adauria@apple.com>
3298
3299         Reviewed by David Levin.
3300
3301         StorageTracker should report actual local storage usage on disk
3302         https://bugs.webkit.org/show_bug.cgi?id=60558
3303
3304         * DumpRenderTree/LayoutTestController.cpp:
3305         (localStorageDiskUsageForOriginCallback):
3306         (LayoutTestController::staticFunctions):
3307         * DumpRenderTree/LayoutTestController.h:
3308         * DumpRenderTree/chromium/LayoutTestController.cpp:
3309         (LayoutTestController::LayoutTestController):
3310         (LayoutTestController::localStorageDiskUsageForOrigin):
3311         * DumpRenderTree/chromium/LayoutTestController.h:
3312         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3313         (LayoutTestController::localStorageDiskUsageForOrigin):
3314         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3315         (LayoutTestController::localStorageDiskUsageForOrigin):
3316         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3317         (LayoutTestController::localStorageDiskUsageForOrigin):
3318         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3319         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3320         (LayoutTestController::localStorageDiskUsageForOrigin):
3321
3322 2011-05-10  Anton D'Auria  <adauria@apple.com>
3323
3324         Reviewed by Alexey Proskuryakov.
3325
3326         Add ApplicationCache API to get disk usage per origin
3327         https://bugs.webkit.org/show_bug.cgi?id=57127
3328
3329         Added test that loads two frames with ~15Kb image, checks usage,
3330         deletes app cache, verifies usage is 0.
3331
3332         * DumpRenderTree/LayoutTestController.cpp:
3333         (applicationCacheDiskUsageForOriginCallback):
3334         (LayoutTestController::staticFunctions):
3335         * DumpRenderTree/LayoutTestController.h:
3336         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3337         (LayoutTestController::LayoutTestController):
3338         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3339         * DumpRenderTree/chromium/LayoutTestController.h:
3340         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3341         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3342         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3343         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3344         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3345         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3346         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3347         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3348         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3349
3350 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3351
3352         Unreviewed, adding Rafael Antognolli as a committer.
3353
3354         * Scripts/webkitpy/common/config/committers.py:
3355
3356 2011-05-10  Chris Evans  <cevans@chromium.org>
3357
3358         Reviewed by Adam Barth.
3359
3360         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
3361         https://bugs.webkit.org/show_bug.cgi?id=58378
3362
3363         * DumpRenderTree/chromium/LayoutTestController.cpp:
3364         (LayoutTestController::LayoutTestController):
3365         (LayoutTestController::setAllowDisplayOfInsecureContent):
3366         (LayoutTestController::setAllowRunningOfInsecureContent):
3367         * DumpRenderTree/chromium/LayoutTestController.h:
3368         * DumpRenderTree/chromium/WebPreferences.cpp:
3369         (WebPreferences::reset):
3370         (WebPreferences::applyTo):
3371         * DumpRenderTree/chromium/WebPreferences.h:
3372         Add plumbing for new settings to Chromium DRT.
3373
3374 2011-05-10  Enrica Casucci  <enrica@apple.com>
3375
3376         Reviewed by Beth Dakin.
3377
3378         Added my name to the reviewers list and removed my name from
3379         to committer-only list.
3380
3381         * Scripts/webkitpy/common/config/committers.py:
3382
3383 2011-05-10  David Levin  <levin@chromium.org>
3384
3385         Reviewed by Shinichiro Hamaji.
3386
3387         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
3388         https://bugs.webkit.org/show_bug.cgi?id=60466
3389
3390         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
3391         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
3392           that property was removed.
3393         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
3394           filtering for errors.
3395         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
3396           verify that the line filtering is turned off.
3397         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
3398           and remove the unused file_path parameter.
3399         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
3400           line filtering is turned off (and fix test_no_error).
3401         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
3402           of errors based on the lines changed in the patch.
3403         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
3404           the filtering.
3405
3406 2011-05-10  Adam Roben  <aroben@apple.com>
3407
3408         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
3409
3410         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
3411         platform/win/plugins/window-geometry-initialized-before-set-window.html and
3412         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
3413         (WebKit2 Tests)
3414
3415         Reviewed by Anders Carlsson.
3416
3417         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3418         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
3419         WindowedPluginTest::testHarnessWindow function.
3420
3421         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
3422         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
3423         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
3424         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
3425         created for.
3426
3427         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3428         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
3429         WindowedPluginTest, and initialized new members.
3430         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
3431         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
3432         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
3433         then clean up and tell the test harness we're done.
3434         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
3435         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
3436         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
3437         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
3438         window becomes visible.
3439         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
3440         if it was hidden at the start of the test.
3441         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
3442         This should cause our window to become visible and our window region to get set. When we get
3443         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
3444         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
3445         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
3446         "startTest".
3447         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
3448
3449         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
3450         (WindowedPluginTest::testHarnessWindow):
3451         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
3452         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
3453
3454 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3455
3456         Reviewed by Kenneth Rohde Christiansen.
3457
3458         [Qt] Add new qt-4.8 platform for layout testing
3459         https://bugs.webkit.org/show_bug.cgi?id=60544
3460
3461         * Scripts/old-run-webkit-tests:
3462         * Scripts/webkitdirs.pm:
3463
3464 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3465
3466         Unreviewed, rolling out r86108.
3467         http://trac.webkit.org/changeset/86108
3468         https://bugs.webkit.org/show_bug.cgi?id=60533
3469
3470         Broke makefile based builds and Cairo (Requested by weinig on
3471         #webkit).
3472
3473         * Scripts/build-api-tests:
3474         * Scripts/run-api-tests:
3475         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3476         * TestWebKitAPI/Test.h:
3477         (TestWebKitAPI::Test::~Test):
3478         (TestWebKitAPI::Test::name):
3479         (TestWebKitAPI::Test::Register::Register):
3480         (TestWebKitAPI::Test::Register::create):
3481         (TestWebKitAPI::Test::Test):
3482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3483         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3484         (TestWebKitAPI::TEST):
3485         * TestWebKitAPI/TestsController.cpp:
3486         (TestWebKitAPI::TestsController::TestsController):
3487         (TestWebKitAPI::TestsController::dumpTestNames):
3488         (TestWebKitAPI::TestsController::runTestNamed):
3489         (TestWebKitAPI::TestsController::testFailed):
3490         (TestWebKitAPI::TestsController::registerCreateTestFunction):
3491         * TestWebKitAPI/TestsController.h:
3492         * TestWebKitAPI/mac/main.mm:
3493         (main):
3494
3495 2011-05-09  Hayato Ito  <hayato@chromium.org>
3496
3497         Reviewed by Ojan Vafai.
3498
3499         Skip reftests if pixel tests are disabled.
3500
3501         https://bugs.webkit.org/show_bug.cgi?id=59078
3502
3503         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3504         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3505         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3506         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3507
3508 2011-05-09  Chang Shu  <cshu@webkit.org>
3509
3510         Reviewed by Kenneth Rohde Christiansen.
3511
3512         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
3513         https://bugs.webkit.org/show_bug.cgi?id=60499
3514
3515         The implementation is similar to gtk.
3516
3517         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3518         (TextInputController::unmarkText):
3519         * DumpRenderTree/qt/TextInputControllerQt.h:
3520
3521 2011-05-09  James Robinson  <jamesr@chromium.org>
3522
3523         Reviewed by Eric Seidel.
3524
3525         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
3526         https://bugs.webkit.org/show_bug.cgi?id=60520
3527
3528         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3529
3530 2011-05-09  Dmitry Lomov  <dslomov@google.com>
3531
3532         Reviewed by Sam Weinig.
3533
3534         Switch TestWebKitAPI to GTest
3535         https://bugs.webkit.org/show_bug.cgi?id=59561
3536
3537         * Scripts/build-api-tests:
3538         * Scripts/run-api-tests:
3539         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3540         * TestWebKitAPI/Test.h:
3541         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3542         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3543         (TestWebKitAPI::TEST):
3544         * TestWebKitAPI/TestsController.cpp:
3545         (TestWebKitAPI::TestsController::TestsController):
3546         (TestWebKitAPI::TestsController::dumpTestNames):
3547         (TestWebKitAPI::TestsController::runTestNamed):
3548         (TestWebKitAPI::TestsController::runAllTests):
3549         * TestWebKitAPI/TestsController.h:
3550         * TestWebKitAPI/mac/main.mm:
3551         (main):
3552
3553 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
3554
3555         Reviewed by Andreas Kling.
3556
3557         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
3558         https://bugs.webkit.org/show_bug.cgi?id=60487
3559
3560         When adding a new touch point, the start position of this point needs to be set.
3561
3562         * DumpRenderTree/qt/EventSenderQt.cpp:
3563         (EventSender::addTouchPoint):
3564
3565 2011-05-09  Robert Hogan  <robert@webkit.org>
3566
3567         Reviewed by Adam Roben.
3568
3569         https://bugs.webkit.org/show_bug.cgi?id=57137
3570
3571         Unskip plugins/embed-prefers-plugins-for-images.html
3572
3573         Add image/png mime-type to test netscape plugin on Unix.
3574
3575         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3576         (NP_GetMIMEDescription):
3577
3578 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
3579
3580         Reviewed by Ojan Vafai.
3581
3582         Pull jsonresults_unittest test cases out into separate test methods.
3583         https://bugs.webkit.org/show_bug.cgi?id=60418
3584
3585         * TestResultServer/model/jsonresults_unittest.py:
3586
3587 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3588
3589         Reviewed by Andreas Kling.
3590
3591         [Qt] fix fast/dom/Geolocation/window-close-crash.html
3592         https://bugs.webkit.org/show_bug.cgi?id=60458
3593
3594         Update all pages with Mock position/error/permission.
3595
3596         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3597         (LayoutTestController::setGeolocationPermission):
3598         (LayoutTestController::setMockGeolocationError):
3599         (LayoutTestController::setMockGeolocationPosition):
3600
3601 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
3602
3603         Reviewed by Tony Gentilcore.
3604
3605         Implement Page Visibility API.
3606         https://bugs.webkit.org/show_bug.cgi?id=54181
3607
3608         * DumpRenderTree/LayoutTestController.cpp:
3609         (setPageVisibilityCallback):
3610         (resetPageVisibilityCallback):
3611         (LayoutTestController::staticFunctions):
3612         * DumpRenderTree/LayoutTestController.h:
3613         (LayoutTestController::setPageVisibility):
3614         (LayoutTestController::resetPageVisibility):
3615         * DumpRenderTree/chromium/LayoutTestController.cpp:
3616         (LayoutTestController::LayoutTestController):
3617         (LayoutTestController::resetPageVisibility):
3618         (LayoutTestController::setPageVisibility):
3619         * DumpRenderTree/chromium/LayoutTestController.h:
3620
3621 2011-05-07  Adam Barth  <abarth@webkit.org>
3622
3623         Reviewed by Eric Seidel.
3624
3625         Testing EWS spins on patches with a large number of failures
3626         https://bugs.webkit.org/show_bug.cgi?id=60441
3627
3628         In cases where the tree has a small number of persistent failures but a
3629         patch has a large number of failures, we weren't believing any results.
3630         That lead to us retrying the patch forever while we waited for
3631         trustworthy results that would never come.
3632
3633         This patch loosens the semantics of unexpected_failures to return a
3634         subset (rather than the exact set) of unexpected failures.  In the case
3635         where the tree has a bounded number of failures and the patch has an
3636         unbounded number of failures, we can accurately compute such a subset
3637         and reject the patch.
3638
3639         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3640         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3641         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3642         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3643         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3644
3645 2011-05-07  Joe Mason  <jmason@rim.com>
3646
3647         Reviewed by Daniel Bates.
3648
3649         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
3650         https://bugs.webkit.org/show_bug.cgi?id=52211
3651
3652         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
3653         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
3654
3655         * DumpRenderTree/chromium/WebViewHost.cpp:
3656         (WebViewHost::willPerformClientRedirect):
3657         (WebViewHost::didStartProvisionalLoad):
3658         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3659         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3660
3661 2011-05-07  Daniel Bates  <dbates@webkit.org>
3662
3663         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
3664         <http://trac.webkit.org/changeset/86007> (bug #60438).
3665
3666         * Scripts/old-run-webkit-tests:
3667      &n