API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-01  Youenn Fablet  <youenn@apple.com>
2
3         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
4         https://bugs.webkit.org/show_bug.cgi?id=194155
5
6         Reviewed by Eric Carlson.
7
8         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
9         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
10         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
11
12 2019-02-01  Zalan Bujtas  <zalan@apple.com>
13
14         [LFC] Adjust replaced element's intrinsic ratio
15         https://bugs.webkit.org/show_bug.cgi?id=194154
16
17         Reviewed by Antti Koivisto.
18
19         761
20
21         * LayoutReloaded/misc/LFC-passing-tests.txt:
22
23 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
24
25         [WPE] Show test results in minibrowser
26         https://bugs.webkit.org/show_bug.cgi?id=194150
27
28         Reviewed by Žan Doberšek.
29
30         * Scripts/webkitpy/port/wpe.py:
31         (WPEPort.show_results_html_file):
32
33 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
34
35         [WPE] MiniBrowser: add ky bindings for back/forward navigation
36         https://bugs.webkit.org/show_bug.cgi?id=194151
37
38         Reviewed by Žan Doberšek.
39
40         ALT + <- go back
41         ALT + -> go forward
42
43         * MiniBrowser/wpe/main.cpp:
44         (main):
45
46 2019-02-01  Zalan Bujtas  <zalan@apple.com>
47
48         [LFC] Set intrinsic size on Layout::Replaced
49         https://bugs.webkit.org/show_bug.cgi?id=194139
50
51         Reviewed by Antti Koivisto.
52
53         744
54
55         * LayoutReloaded/misc/LFC-passing-tests.txt:
56
57 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
58
59         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
60         https://bugs.webkit.org/show_bug.cgi?id=194146
61
62         Reviewed by Xabier Rodriguez-Calvar.
63
64         It allows to open relative paths.
65
66         * MiniBrowser/wpe/main.cpp:
67         (main):
68
69 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
70
71         Update flakiness dashboard configuration after recent queue changes
72         https://bugs.webkit.org/show_bug.cgi?id=194127
73
74         Rubber-stamped by Aakash Jain.
75
76         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
77
78         * TestResultServer/static-dashboards/builders.jsonp:
79
80 2019-01-31  Youenn Fablet  <youenn@apple.com>
81
82         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
83         https://bugs.webkit.org/show_bug.cgi?id=194106
84         <rdar://problem/47676333>
85
86         Reviewed by Ryosuke Niwa.
87
88         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
89         (TestWebKitAPI::didFinishNavigation):
90         (TestWebKitAPI::TEST):
91         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
92
93 2019-01-31  Chris Dumez  <cdumez@apple.com>
94
95         Page zoom level is lost after a process swap or a crash
96         https://bugs.webkit.org/show_bug.cgi?id=194105
97         <rdar://problem/47610781>
98
99         Reviewed by Alex Christensen.
100
101         Add API test coverage.
102
103         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
104         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
105
106 2019-01-31  Alex Christensen  <achristensen@webkit.org>
107
108         Revert r238819 which is unneeded and caused a performance regression.
109         https://bugs.webkit.org/show_bug.cgi?id=192272
110         <rdar://problem/46664625>
111
112         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
113         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
114         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
115
116 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
117
118         Formalize WebKitAdditions mechanism of LoadOptimizer
119         https://bugs.webkit.org/show_bug.cgi?id=193886
120         <rdar://problem/47696809>
121
122         Reviewed by Brent Fulgham.
123
124         * MiniBrowser/MiniBrowser.entitlements:
125         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
126
127 2019-01-31  Zalan Bujtas  <zalan@apple.com>
128
129         [LFC] Margin before/after/start/end initial value is 0 and not auto.
130         https://bugs.webkit.org/show_bug.cgi?id=194090
131
132         Reviewed by Antti Koivisto.
133
134         * LayoutReloaded/misc/LFC-passing-tests.txt:
135
136 2019-01-31  Zalan Bujtas  <zalan@apple.com>
137
138         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
139         https://bugs.webkit.org/show_bug.cgi?id=194074
140
141         Reviewed by Antti Koivisto.
142
143         * LayoutReloaded/misc/LFC-passing-tests.txt:
144
145 2019-01-31  Zalan Bujtas  <zalan@apple.com>
146
147         [LFC][BFC] Add support for block level replaced box.
148         https://bugs.webkit.org/show_bug.cgi?id=194071
149
150         Reviewed by Antti Koivisto.
151
152         * LayoutReloaded/misc/LFC-passing-tests.txt:
153
154 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
155
156         Fix WebKitTestRunner's testPath with Windows full paths
157         https://bugs.webkit.org/show_bug.cgi?id=194012
158
159         Reviewed by Alex Christensen.
160
161         updateTestOptionsFromTestHeader failed to open test files because
162         testPath returned wrong file paths. It returned a path "/C:/..."
163         if a URL "file:///C:/..." was given.
164
165         * WebKitTestRunner/TestController.cpp:
166         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
167
168 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
169
170         [WPE] Bump font related dependencies to match the GTK+ port
171         https://bugs.webkit.org/show_bug.cgi?id=194017
172
173         Reviewed by Žan Doberšek.
174
175         * wpe/jhbuild.modules:
176         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
177         * wpe/patches/icudata-stdlibs.patch: Added.
178
179 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
180
181         Enable swipe tests on iOS
182         https://bugs.webkit.org/show_bug.cgi?id=194076
183
184         Reviewed by Geoffrey Garen.
185
186         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
187         it causes a debug assertion failure in runUIScript.
188
189         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
190         (WTR::UIScriptController::beginBackSwipe):
191         (WTR::UIScriptController::completeBackSwipe):
192
193 2019-01-30  Keith Rollin  <krollin@apple.com>
194
195         Use correct printf format specifier
196         https://bugs.webkit.org/show_bug.cgi?id=194062
197         <rdar://problem/47686167>
198
199         Reviewed by Alexey Proskuryakov.
200
201         LayoutTestSpellChecker.mm is trying to format a variable of type
202         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
203         actually an unsigned long long. Fix this by formatting with %llu.
204
205         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
206         (-[LayoutTestTextCheckingResult description]):
207
208 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
209
210         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
211         https://bugs.webkit.org/show_bug.cgi?id=193979
212
213         Reviewed by Wenson Hsieh.
214
215         Fix the test for iOS. Make the test work with iOS UA string.
216
217         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
218
219 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
220
221         Replace High Sierra LLINT CLoop bot due to hardware failure
222         https://bugs.webkit.org/show_bug.cgi?id=194066
223
224         Reviewed by Aakash Jain.
225
226         * BuildSlaveSupport/build.webkit.org-config/config.json:
227
228 2019-01-30  Keith Rollin  <krollin@apple.com>
229
230         [NSDragItem init] is unavailable
231         https://bugs.webkit.org/show_bug.cgi?id=194059
232         <rdar://problem/47685715>
233
234         Reviewed by Wenson Hsieh.
235
236         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
237         DumpRenderTree and TestWebKitAPI, which both try to create an
238         NSDragItem in a manner that invokes this method. Address this by using
239         -initWithPasteboardWriter instead.
240
241         Note that the parameter passed to initWithPasteboardWriter is likely
242         incorrect. In both cases, the object passed does not conform to
243         NSPasteboardWriting. However, with this fix, we're no worse off than
244         before, and can now perform builds with newer compilers and SDKs until
245         a real fix can be crafted. That work is tracked in
246         https://bugs.webkit.org/show_bug.cgi?id=194060
247
248         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
249         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
250         * TestWebKitAPI/mac/TestDraggingInfo.mm:
251         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
252
253 2019-01-30  Daniel Bates  <dabates@apple.com>
254
255         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
256         https://bugs.webkit.org/show_bug.cgi?id=192824
257         <rdar://problem/47100332>
258
259         Reviewed by Wenson Hsieh.
260
261         Fix a bug where the wrong usage code was used for F13 thru F24.
262
263         * WebKitTestRunner/ios/HIDEventGenerator.mm:
264         (keyCodeForDOMFunctionKey):
265
266 2019-01-30  Chris Dumez  <cdumez@apple.com>
267
268         Regression(PSON) Load hang can occur on history navigation
269         https://bugs.webkit.org/show_bug.cgi?id=194030
270         <rdar://problem/47656939>
271
272         Reviewed by Antti Koivisto.
273
274         Add API test coverage.
275
276         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
277
278 2019-01-30  Zalan Bujtas  <zalan@apple.com>
279
280         [LFC] Expand tests coverage.
281
282         Unreviewed test gardening.
283
284         * LayoutReloaded/misc/LFC-passing-tests.txt:
285
286 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
287
288         [Flatpak] Add openjpeg support
289         https://bugs.webkit.org/show_bug.cgi?id=194019
290
291         Reviewed by Michael Catanzaro.
292
293         * flatpak/org.webkit.CommonModules.yaml:
294
295 2019-01-30  Commit Queue  <commit-queue@webkit.org>
296
297         Unreviewed, rolling out r240708.
298         https://bugs.webkit.org/show_bug.cgi?id=194022
299
300         It broke WPE build (Requested by KaL on #webkit).
301
302         Reverted changeset:
303
304         "[WPE] Bump font related dependencies to match the GTK+ port"
305         https://bugs.webkit.org/show_bug.cgi?id=194017
306         https://trac.webkit.org/changeset/240708
307
308 2019-01-30  Zalan Bujtas  <zalan@apple.com>
309
310         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
311         https://bugs.webkit.org/show_bug.cgi?id=194001
312
313         Reviewed by Antti Koivisto.
314
315         * LayoutReloaded/misc/LFC-passing-tests.txt:
316
317 2019-01-30  Zalan Bujtas  <zalan@apple.com>
318
319         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
320         https://bugs.webkit.org/show_bug.cgi?id=194020
321
322         Reviewed by Antti Koivisto.
323
324         * LayoutReloaded/misc/LFC-passing-tests.txt:
325
326 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
327
328         AX: Support color well on iOS
329         https://bugs.webkit.org/show_bug.cgi?id=194010
330
331         Reviewed by Joanmarie Diggs.
332
333         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
334         (WTR::AccessibilityUIElement::stringAttributeValue):
335
336 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
337
338         [WPE] Bump font related dependencies to match the GTK+ port
339         https://bugs.webkit.org/show_bug.cgi?id=194017
340
341         Reviewed by Žan Doberšek.
342
343         * wpe/jhbuild.modules:
344         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
345         * wpe/patches/icudata-stdlibs.patch: Added.
346
347 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
348
349         [Mac] Update window scale API usage
350         https://bugs.webkit.org/show_bug.cgi?id=193991
351         rdar://problem/47614795
352
353         Reviewed by Tim Horton.
354
355         * DumpRenderTree/mac/DumpRenderTree.mm:
356         (changeWindowScaleIfNeeded):
357         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
358         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
359         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
360
361 2019-01-29  Chris Dumez  <cdumez@apple.com>
362
363         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
364         https://bugs.webkit.org/show_bug.cgi?id=193977
365         <rdar://problem/47643716>
366
367         Reviewed by Geoff Garen.
368
369         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
370         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
371         to the previous provisional committing *before* we make the last load. 
372
373         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
374
375 2019-01-29  Youenn Fablet  <youenn@apple.com>
376
377         Adopt new SPI to evaluate server certificate trust
378         https://bugs.webkit.org/show_bug.cgi?id=193355
379
380         Reviewed by Alex Christensen.
381
382         Add infrastructure to handle HTTPS server trust evaluation testing.
383
384         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
385         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
386         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
387         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
388         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
389         * WebKitTestRunner/InjectedBundle/TestRunner.h:
390         * WebKitTestRunner/TestController.cpp:
391         (WTR::TestController::resetPreferencesToConsistentValues):
392         (WTR::TestController::didReceiveAuthenticationChallenge):
393         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
394         * WebKitTestRunner/TestController.h:
395         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
396         * WebKitTestRunner/TestInvocation.cpp:
397         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
398         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
399         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
400
401 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
402
403         [ews-build] Add build step to print bot Configuration
404         https://bugs.webkit.org/show_bug.cgi?id=193887
405
406         Reviewed by Lucas Forschler.
407
408         * BuildSlaveSupport/ews-build/steps.py:
409         (PrintConfiguration): Build step to print configuration.
410         * BuildSlaveSupport/ews-build/factories.py:
411
412 2019-01-29  Chris Dumez  <cdumez@apple.com>
413
414         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
415         https://bugs.webkit.org/show_bug.cgi?id=193967
416         <rdar://problem/47635348>
417
418         Reviewed by Alex Christensen.
419
420         Add API test coverage.
421
422         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
423         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
424
425 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
426
427         [ews-app] Handle incoming results data
428         https://bugs.webkit.org/show_bug.cgi?id=193973
429
430         Reviewed by Lucas Forschler.
431
432         * BuildSlaveSupport/ews-app/ews/views/results.py:
433
434 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
435
436         [ews-app] Make the results url generic
437         https://bugs.webkit.org/show_bug.cgi?id=193928
438
439         Reviewed by Lucas Forschler.
440
441         * BuildSlaveSupport/ews-app/ews/urls.py:
442
443 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
444
445         [ews-build] Configure buildbot to send events to ews-app
446         https://bugs.webkit.org/show_bug.cgi?id=193968
447
448         Reviewed by Lucas Forschler.
449
450         * BuildSlaveSupport/ews-build/events.py: Added.
451         * BuildSlaveSupport/ews-build/master.cfg:
452
453 2019-01-29  Keith Rollin  <krollin@apple.com>
454
455         Add .xcfilelists to Run Script build phases
456         https://bugs.webkit.org/show_bug.cgi?id=193792
457         <rdar://problem/47201785>
458
459         Reviewed by Alex Christensen.
460
461         As part of supporting XCBuild, update the necessary Run Script build
462         phases in their Xcode projects to refer to their associated
463         .xcfilelist files.
464
465         Note that the addition of these files bumps the Xcode project version
466         number to something that's Xcode 10 compatible. This change means that
467         older versions of the Xcode IDE can't read these projects. Nor can it
468         fully load workspaces that refer to these projects (the updated
469         projects are shown as non-expandable placeholders). `xcodebuild` can
470         still build these projects; it's just that the IDE can't open them.
471
472         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
473         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
474
475 2019-01-29  John Wilander  <wilander@apple.com>
476
477         Add data abstraction and validation for Ad Click Attribution
478         https://bugs.webkit.org/show_bug.cgi?id=193916
479         <rdar://problem/47603481>
480
481         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
482
483         Ad click attribution has two steps. First, the storage of an ad
484         campaign ID for a click that takes the user to a destination
485         site. Second, a conversion on the destination site that can be
486         attributed to the ad click.
487
488         This patch adds a class that represents a request for ad click
489         attribution. Validation makes sure that the bits of entropy
490         reported through this mechanism is limited.
491
492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
493         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
494         (TestWebKitAPI::TEST):
495
496 2019-01-29  Chris Dumez  <cdumez@apple.com>
497
498         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
499         https://bugs.webkit.org/show_bug.cgi?id=193932
500         <rdar://problem/47598947>
501
502         Reviewed by Brady Eidson.
503
504         Add API test coverage.
505
506         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
507
508 2019-01-29  Zalan Bujtas  <zalan@apple.com>
509
510         Adding new passing LFC tests.
511
512         Unreviewed test gardening.
513
514         * LayoutReloaded/misc/LFC-passing-tests.txt:
515
516 2019-01-29  Zalan Bujtas  <zalan@apple.com>
517
518         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
519         https://bugs.webkit.org/show_bug.cgi?id=193964
520
521         Reviewed by Antti Koivisto.
522
523         * LayoutReloaded/misc/LFC-passing-tests.txt:
524
525 2019-01-29  Zalan Bujtas  <zalan@apple.com>
526
527         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
528         https://bugs.webkit.org/show_bug.cgi?id=193954
529
530         Reviewed by Antti Koivisto.
531
532         * LayoutReloaded/misc/LFC-passing-tests.txt:
533
534 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
535
536         WebDriver: add support for running subtests
537         https://bugs.webkit.org/show_bug.cgi?id=193904
538
539         Reviewed by Michael Catanzaro.
540
541         pytest already supports it by passing test.py::subtest, so we can do the same.
542
543         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
544         (get_item_name): Made this global.
545         (CollectRecorder.__init__): Receive the parameter to ignore.
546         (CollectRecorder.pytest_collectreport): Collect also the subtests.
547         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
548         (collect): Add parameter to ignore.
549         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
550         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
551         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
552         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
553         (WebDriverTestRunnerSelenium.run): Ditto.
554         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
555         (WebDriverTestRunnerW3C.collect_tests): Ditto.
556         (WebDriverTestRunnerW3C.run): Ditto.
557
558 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
559
560         User agent string override for navigator.userAgent should be site specific quirks
561         https://bugs.webkit.org/show_bug.cgi?id=193950
562
563         Reviewed by Brent Fulgham.
564
565         Updated per the _WKWebsitePolicies rename.
566
567         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
568         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
569
570 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
571
572         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
573         https://bugs.webkit.org/show_bug.cgi?id=193941
574
575         Reviewed by Alex Christensen.
576
577         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
578         * TestWebKitAPI/Tests/WTF/Condition.cpp:
579         * TestWebKitAPI/Tests/WTF/Lock.cpp:
580         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
581         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
582         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
583         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
584         * TestWebKitAPI/Tests/WTF/Time.cpp:
585         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
586         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
587         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
588         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
589
590 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
591
592         Unreviewed, reorder my emails to fix autocomplete in bugzilla
593
594         * Scripts/webkitpy/common/config/contributors.json:
595
596 2019-01-28  Andy Estes  <aestes@apple.com>
597
598         [watchOS] Enable Parental Controls content filtering
599         https://bugs.webkit.org/show_bug.cgi?id=193939
600         <rdar://problem/46641912>
601
602         Reviewed by Ryosuke Niwa.
603
604         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
605
606 2019-01-28  David Kilzer  <ddkilzer@apple.com>
607
608         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
609         <https://webkit.org/b/193884>
610
611         Reviewed by Jiewen Tan.
612
613         * Scripts/webkitpy/style/checkers/cpp.py:
614         (check_language): Add LocalAuthentication to
615         `frameworks_with_soft_links`.
616
617 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
618
619         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
620         https://bugs.webkit.org/show_bug.cgi?id=193891
621
622         Reviewed by Ross Kirsling.
623
624         There were three problems in window sizes of WebView and the host window.
625         1. The sizes of pixel image output were incorrect.
626         2. The host window is going to appear after window.resize was invoked.
627         3. window.resize resized only the host window, not WebView.
628
629         This change solves them with a following approach.
630         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
631         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
632            as well as DumpRenderTree in order to match the client area and the window area.
633         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
634         d. PlatformWebView::setWindowFrame changes both window sizes.
635         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
636
637         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
638         (WTR::PlatformWebView::PlatformWebView): Create the host window
639         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
640         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
641         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
642
643 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
644
645         [ews-app] Add method to save Step data to database
646         https://bugs.webkit.org/show_bug.cgi?id=193890
647
648         Reviewed by Lucas Forschler.
649
650         * BuildSlaveSupport/ews-app/ews/models/step.py:
651         (Step.save_step): Method to save step data.
652         (Step.update_step): Method to update step data.
653         (Step.get_existing_step): Method to fetch existing step from database.
654         (Step.is_valid_result): Method to validate valid step result.
655
656 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
657
658         [ews-app] Add method to save Build data to database
659         https://bugs.webkit.org/show_bug.cgi?id=193735
660
661         Reviewed by Lucas Forschler.
662
663         * BuildSlaveSupport/ews-app/ews/models/build.py:
664         (Build.save_build): Method to save build information to database.
665         (Build.get_existing_build): Method to fetch existing build from database.
666         (Build.is_valid_result): Method to validate build result.
667         * BuildSlaveSupport/ews-app/ews/common/util.py:
668         (is_valid_int_id): Method to validate valid id.
669
670 2019-01-28  Chris Dumez  <cdumez@apple.com>
671
672         Regression(PSON) Crash under WebPageProxy::didStartProgress()
673         https://bugs.webkit.org/show_bug.cgi?id=193915
674         <rdar://problem/47560907>
675
676         Reviewed by Alex Christensen.
677
678         Add API test coverage.
679
680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
681
682 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
683
684         [ews-app] Rename id variables
685         https://bugs.webkit.org/show_bug.cgi?id=193883
686
687         Reviewed by Lucas Forschler.
688
689         * BuildSlaveSupport/ews-app/ews/models/build.py:
690         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
691         * BuildSlaveSupport/ews-app/ews/models/step.py:
692         * BuildSlaveSupport/ews-app/ews/urls.py:
693         * BuildSlaveSupport/ews-app/ews/views/patch.py:
694         * BuildSlaveSupport/ews-app/ews/views/results.py:
695         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
696
697 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
698
699         [ews-app] Allow certain fields to be empty
700         https://bugs.webkit.org/show_bug.cgi?id=193892
701
702         Reviewed by Lucas Forschler.
703
704         * BuildSlaveSupport/ews-app/ews/models/build.py:
705         * BuildSlaveSupport/ews-app/ews/models/step.py:
706
707 2019-01-28  Rob Buis  <rbuis@igalia.com>
708
709         Update MIME type parser
710         https://bugs.webkit.org/show_bug.cgi?id=180526
711
712         Reviewed by Frédéric Wang.
713
714         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
715         (TestWebKitAPI::TEST):
716
717 2019-01-28  Zalan Bujtas  <zalan@apple.com>
718
719         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
720         https://bugs.webkit.org/show_bug.cgi?id=193896
721
722         Reviewed by Antti Koivisto.
723
724         * LayoutReloaded/misc/LFC-passing-tests.txt:
725
726 2018-12-15  Darin Adler  <darin@apple.com>
727
728         Replace many uses of String::format with more type-safe alternatives
729         https://bugs.webkit.org/show_bug.cgi?id=192742
730
731         Reviewed by Mark Lam.
732
733         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
734         (WTR::cacheTestRunnerCallback): Use makeString.
735         * WebKitTestRunner/TestController.cpp:
736         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
737         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
738
739 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
740
741         Use a load optimizer for some sites
742         https://bugs.webkit.org/show_bug.cgi?id=193881
743         <rdar://problem/46325455>
744
745         Reviewed by Brent Fulgham.
746
747         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
748         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
749
750 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
751
752         AX: Introduce a static accessibility tree
753         https://bugs.webkit.org/show_bug.cgi?id=193348
754         <rdar://problem/47203295>
755
756         Reviewed by Ryosuke Niwa.
757
758         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
759
760 2019-01-26  Zalan Bujtas  <zalan@apple.com>
761
762         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
763         https://bugs.webkit.org/show_bug.cgi?id=193867
764
765         Reviewed by Antti Koivisto.
766
767         * LayoutReloaded/misc/LFC-passing-tests.txt:
768
769 2019-01-26  Zalan Bujtas  <zalan@apple.com>
770
771         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
772         https://bugs.webkit.org/show_bug.cgi?id=193865
773
774         Reviewed by Antti Koivisto.
775
776         * LayoutReloaded/misc/LFC-passing-tests.txt:
777
778 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
779
780         Need a mechanism to override navigator.userAgent
781         https://bugs.webkit.org/show_bug.cgi?id=193762
782         <rdar://problem/47504939>
783
784         Reviewed by Brent Fulgham.
785
786         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
787
788         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
789         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
790         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
791
792 2019-01-25  Dean Jackson  <dino@apple.com>
793
794         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
795         https://bugs.webkit.org/show_bug.cgi?id=193831
796         <rdar://problem/47399263>
797
798         Reviewed by Chris Dumez.
799
800         Two new tests that exercise cross-origin and same-origin System
801         Previews.
802
803         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
804
805 2019-01-25  Keith Rollin  <krollin@apple.com>
806
807         Update Xcode projects with "Check .xcfilelists" build phase
808         https://bugs.webkit.org/show_bug.cgi?id=193790
809         <rdar://problem/47201374>
810
811         Reviewed by Alex Christensen.
812
813         Support for XCBuild includes specifying inputs and outputs to various
814         Run Script build phases. These inputs and outputs are specified as
815         .xcfilelist files. Once created, these .xcfilelist files need to be
816         kept up-to-date. In order to check that they are up-to-date or not,
817         add an Xcode build step that invokes an external script that performs
818         the checking. If the .xcfilelists are found to be out-of-date, update
819         them, halt the build, and instruct the developer to restart the build
820         with up-to-date files.
821
822         At this time, the checking and regenerating is performed only if the
823         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
824         who want to use this facility can set this variable and test out the
825         checking/regenerating. Once it seems like there are no egregious
826         issues that upset a developer's workflow, we'll unconditionally enable
827         this facility.
828
829         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
830         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
831         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
832         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
833
834 2019-01-25  Keith Rollin  <krollin@apple.com>
835
836         Update Xcode projects with "Apply Configuration to XCFileLists" build target
837         https://bugs.webkit.org/show_bug.cgi?id=193781
838         <rdar://problem/47201153>
839
840         Reviewed by Alex Christensen.
841
842         Part of generating the .xcfilelists used as part of adopting XCBuild
843         includes running `make DerivedSources.make` from a standalone script.
844         It’s important for this invocation to have the same environment as
845         when the actual build invokes `make DerivedSources.make`. If the
846         environments are different, then the two invocations will provide
847         different results. In order to get the same environment in the
848         standalone script, have the script launch xcodebuild targeting the
849         "Apply Configuration to XCFileLists" build target, which will then
850         re-invoke our standalone script. The script is now running again, this
851         time in an environment with all workspace, project, target, xcconfig
852         and other environment variables established.
853
854         The "Apply Configuration to XCFileLists" build target accomplishes
855         this task via a small embedded shell script that consists only of:
856
857             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
858
859         The process that invokes "Apply Configuration to XCFileLists" first
860         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
861         evaluated and exports it into the shell environment. When xcodebuild
862         is invoked, it inherits the value of this variable and can `eval` the
863         contents of that variable. Our external standalone script can then set
864         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
865         of command-line parameters needed to restart itself in the appropriate
866         state.
867
868         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
869         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
870
871 2019-01-25  Alex Christensen  <achristensen@webkit.org>
872
873         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
874         https://bugs.webkit.org/show_bug.cgi?id=193802
875         <rdar://problem/46010580>
876
877         Reviewed by Andy Estes.
878
879         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
880         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
881         (TEST):
882
883 2019-01-25  Daniel Bates  <dabates@apple.com>
884
885         [iOS] uiController.keyDown() does not translate Control modified key
886         https://bugs.webkit.org/show_bug.cgi?id=192898
887
888         Reviewed by Wenson Hsieh.
889
890         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
891         key translation, as applicable. Among other cases, key translation occurs when performing
892         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
893         also makes the behavior of uiController.keyDown() more closely match the behavior of a
894         human pressing down and releasing key(s) using a hardware keyboard.
895
896         * WebKitTestRunner/ios/HIDEventGenerator.h:
897         * WebKitTestRunner/ios/HIDEventGenerator.mm:
898         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
899
900         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
901         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
902         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
903         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
904         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
905         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
906         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
907         (-[HIDEventGenerator longPress:completionBlock:]):
908         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
909         Update code for above renaming.
910
911         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
912         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
913
914         (-[HIDEventGenerator keyDown:]): Added.
915         (-[HIDEventGenerator keyUp:]): Added.
916         (-[HIDEventGenerator keyPress:completionBlock:]):
917         (-[HIDEventGenerator eventDispatchThreadEntry:]):
918         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
919         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
920         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
921         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
922         (WTR::parseModifier): Deleted.
923
924 2019-01-25  Keith Rollin  <krollin@apple.com>
925
926         Complete the implementation of generate-xcfilelists
927         https://bugs.webkit.org/show_bug.cgi?id=193782
928
929         Reviewed by Alex Christensen.
930
931         A preliminary version of generate-xcfilelists was added in r238008.
932         This patch updates that script in order to:
933
934         - Support checking of .xcfilelists
935         - Perform better execution of `make DerivedSources.make` by
936           relaunching generate-xcfilelists under xcodebuild
937         - Support incremental generation and checking of .xcfilelists
938         - Support supplementary .xcfilelists files from WebKitAdditions
939         - Support being wrapped by parallel version of generate-xcfilelists in
940           Internal that adds support for (re)generating WebKit projects in
941           that repo.
942         - Support builds that have been performed in WebKitBuild as well as
943           ~/Library/Developer/code/DerivedData
944         - Increase robustness and debugging facilities.
945
946         * Scripts/generate-xcfilelists:
947
948 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
949
950         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
951         https://bugs.webkit.org/show_bug.cgi?id=193297
952         <rdar://problem/47158841>
953
954         Unreviewed test case fix.
955
956         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
957         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
958
959         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
960         (TEST):
961
962 2019-01-25  Keith Rollin  <krollin@apple.com>
963
964         Update existing .xcfilelists
965         https://bugs.webkit.org/show_bug.cgi?id=193791
966         <rdar://problem/47201706>
967
968         Reviewed by Alex Christensen.
969
970         Many .xcfilelist files were added in r238824 in order to support
971         XCBuild. Update these with recent changes to the set of build files
972         and with the current generate-xcfilelist script.
973
974         * DumpRenderTree/DerivedSources-input.xcfilelist:
975         * DumpRenderTree/DerivedSources-output.xcfilelist:
976         * WebKitTestRunner/DerivedSources-input.xcfilelist:
977         * WebKitTestRunner/DerivedSources-output.xcfilelist:
978
979 2019-01-25  Keith Rollin  <krollin@apple.com>
980
981         Fix missing dependencies in extract-dependencies-from-makefile
982         https://bugs.webkit.org/show_bug.cgi?id=193783
983         <rdar://problem/47201571>
984
985         Reviewed by Alex Christensen.
986
987         The extract-dependencies-from-makefile script generates .xcfilelists
988         for XCBuild by invoking a makefile in --debug mode, parsing the
989         dependency information in the output, and extracting information
990         regarding targets and dependents. However, the way `make` emits this
991         dependency information is not rigorous, and so we need to determine
992         what lines to look for and parse by trial and error. This approach
993         didn't coriginally atch all the information we needed to collect, so
994         update the script to look for the additional lines we now know to look
995         for.
996
997         * Scripts/extract-dependencies-from-makefile:
998         (Parser):
999         (Parser.addTarget):
1000         (Parser.addPrereq):
1001         (Parser.doParse):
1002
1003 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1004
1005         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1006         https://bugs.webkit.org/show_bug.cgi?id=193297
1007         <rdar://problem/47158841>
1008
1009         Reviewed by Alex Christensen.
1010
1011         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1012             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1013         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1014         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1015         activating the message used to trigger the callback when it is set.
1016
1017 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1018
1019         WKWebView.goBack should reload if there is a safe browsing warning
1020         https://bugs.webkit.org/show_bug.cgi?id=193805
1021         <rdar://problem/46908216>
1022
1023         Reviewed by Geoff Garen.
1024
1025         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1026         (+[Simple3LookupContext sharedLookupContext]):
1027         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1028         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1029         (TEST):
1030
1031 2019-01-25  Chris Dumez  <cdumez@apple.com>
1032
1033         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1034         https://bugs.webkit.org/show_bug.cgi?id=193788
1035         <rdar://problem/47531231>
1036
1037         Reviewed by Alex Christensen.
1038
1039         Add API test coverage.
1040
1041         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1042         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1043
1044 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1045
1046         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1047         https://bugs.webkit.org/show_bug.cgi?id=193771
1048
1049         Unreviewed infrastructure fix.
1050
1051         * Scripts/webkitpy/port/darwin.py:
1052         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1053
1054 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1055
1056         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1057
1058 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1059
1060         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1061
1062         * Scripts/webkitpy/common/config/contributors.json:
1063
1064 2019-01-25  Chris Dumez  <cdumez@apple.com>
1065
1066         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1067         https://bugs.webkit.org/show_bug.cgi?id=193779
1068         <rdar://problem/46170903>
1069
1070         Reviewed by Antti Koivisto.
1071
1072         Add API test that quickly navigates forward to a previous process without waiting for it to
1073         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1074         the process' previous page when reconnecting the it for the forward navigation.
1075
1076         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1077
1078 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1079
1080         Need a way for JavaScript (or bundle) code to participate in undo
1081         https://bugs.webkit.org/show_bug.cgi?id=190009
1082         <rdar://problem/44807048>
1083
1084         Reviewed by Ryosuke Niwa.
1085
1086         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1087         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1088
1089         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1090         (WTR::UIScriptController::lastUndoLabel const):
1091         (WTR::UIScriptController::firstRedoLabel const):
1092         (WTR::UIScriptController::platformUndoManager const):
1093         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1094         (WTR::UIScriptController::lastUndoLabel const):
1095         (WTR::UIScriptController::firstRedoLabel const):
1096         (WTR::UIScriptController::platformUndoManager const):
1097         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1098         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1099         (WTR::UIScriptController::lastUndoLabel const):
1100         (WTR::UIScriptController::firstRedoLabel const):
1101         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1102         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1103         (WTR::UIScriptController::lastUndoLabel const):
1104         (WTR::UIScriptController::firstRedoLabel const):
1105         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1106         (WTR::UIScriptController::platformUndoManager const):
1107         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1108         (WTR::UIScriptController::platformUndoManager const):
1109
1110 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1111
1112         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1113         https://bugs.webkit.org/show_bug.cgi?id=193824
1114
1115         Reviewed by Antti Koivisto.
1116
1117         * LayoutReloaded/misc/LFC-passing-tests.txt:
1118
1119 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1120
1121         Update macOS JSC bot configurations
1122         https://bugs.webkit.org/show_bug.cgi?id=193739
1123
1124         Reviewed by Alexey Proskuryakov.
1125
1126         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1128         (BubbleQueueServer): Move JSC EWS to Mojave section.
1129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1130         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1131         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1132
1133 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1134
1135         [Win][WebKitTestRunner] Implement EventSenderProxy
1136         https://bugs.webkit.org/show_bug.cgi?id=193755
1137
1138         Reviewed by Don Olmstead.
1139
1140         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1141         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1142         (WTR::EventSenderProxy::dispatchMessage):
1143         (WTR::EventSenderProxy::EventSenderProxy):
1144         (WTR::EventSenderProxy::mouseDown):
1145         (WTR::EventSenderProxy::mouseUp):
1146         (WTR::EventSenderProxy::mouseMoveTo):
1147         (WTR::EventSenderProxy::mouseScrollBy):
1148         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1149
1150 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1151
1152         Unreviewed fix for API test failure after r240437.
1153
1154         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1155
1156         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1157
1158 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1159
1160         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1161         https://bugs.webkit.org/show_bug.cgi?id=193787
1162         <rdar://problem/47497634>
1163
1164         Reviewed by Alexey Proskuryakov.
1165
1166         * Scripts/webkitdirs.pm:
1167         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1168
1169 2019-01-24  Truitt Savell  <tsavell@apple.com>
1170
1171         Unreviewed, rolling out r240446.
1172
1173         Casued 5 API failures
1174
1175         Reverted changeset:
1176
1177         "Activate the WebResourceLoadStatisticsStore in the
1178         NetworkProcess and deactivate it in the UIProcess."
1179         https://bugs.webkit.org/show_bug.cgi?id=193297
1180         https://trac.webkit.org/changeset/240446
1181
1182 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1183
1184         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1185         https://bugs.webkit.org/show_bug.cgi?id=193741
1186         <rdar://problem/47135030>
1187
1188         Reviewed by Antti Koivisto and Simon Fraser.
1189
1190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1191         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1192         (TestWebKitAPI::TEST):
1193
1194 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1195
1196         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1197         https://bugs.webkit.org/show_bug.cgi?id=193297
1198         <rdar://problem/47158841>
1199
1200         Reviewed by Alex Christensen.
1201
1202         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1203         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1204         activating the message used to trigger the callback when it is set.
1205
1206 2019-01-24  John Wilander  <wilander@apple.com>
1207
1208         Add Ad Click Attribution as an internal/experimental feature
1209         https://bugs.webkit.org/show_bug.cgi?id=193685
1210         <rdar://problem/47450399>
1211
1212         Reviewed by Brent Fulgham.
1213
1214         Added test option adClickAttributionEnabled.
1215
1216         * DumpRenderTree/TestOptions.cpp:
1217         (TestOptions::TestOptions):
1218         * DumpRenderTree/TestOptions.h:
1219         * DumpRenderTree/mac/DumpRenderTree.mm:
1220         (setWebPreferencesForTestOptions):
1221
1222 2019-01-24  Antti Koivisto  <antti@apple.com>
1223
1224         [PSON] Flash on back navigation on Mac
1225         https://bugs.webkit.org/show_bug.cgi?id=193716
1226         <rdar://problem/47148458>
1227
1228         Reviewed by Chris Dumez.
1229
1230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1231
1232         Closing of the previous page is delayed so waiting for didFinishNavigation is
1233         not sufficient to guarantee we have received all the messages. Wait for them.
1234
1235 2019-01-24  Chris Dumez  <cdumez@apple.com>
1236
1237         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1238         https://bugs.webkit.org/show_bug.cgi?id=193761
1239         <rdar://problem/47456405>
1240
1241         Reviewed by Alex Christensen.
1242
1243         Add API test coverage.
1244
1245         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1246
1247 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1248
1249         webkitpy: Missing PID in crashlog name should not be fatal
1250         https://bugs.webkit.org/show_bug.cgi?id=193771
1251
1252         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1253         of raising an exception.
1254
1255         Reviewed by Lucas Forschler.
1256
1257         * Scripts/webkitpy/port/darwin.py:
1258         (DarwinPort._merge_crash_logs):
1259
1260 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1261
1262         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1263         https://bugs.webkit.org/show_bug.cgi?id=193746
1264
1265         Reviewed by Youenn Fablet.
1266
1267         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1268         so we'd best just not call it.
1269
1270         * Scripts/webkitpy/w3c/test_exporter.py:
1271         (WebPlatformTestExporter.create_branch_with_patch):
1272
1273 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1274
1275         Move FileSystem to WTF
1276         https://bugs.webkit.org/show_bug.cgi?id=193602
1277
1278         Reviewed by Yusuke Suzuki.
1279
1280         * DumpRenderTree/win/DumpRenderTree.cpp:
1281         * TestWebKitAPI/CMakeLists.txt:
1282         * TestWebKitAPI/PlatformGTK.cmake:
1283         * TestWebKitAPI/PlatformJSCOnly.cmake:
1284         * TestWebKitAPI/PlatformPlayStation.cmake:
1285         * TestWebKitAPI/PlatformWPE.cmake:
1286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1287         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1288         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1289         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1290         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1291         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1292         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1293         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1294         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1295         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1296
1297 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1298
1299         [WPE] Remove hard dependency on subprocess32 for the API tests
1300
1301         Rubber-stamped by Carlos Garcia Campos.
1302
1303         * glib/api_test_runner.py:
1304         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1305         its presence only when running WPEQt tests.
1306
1307 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1308
1309         [GLIB] Expose JavaScriptCore options in GLib public API
1310         https://bugs.webkit.org/show_bug.cgi?id=188742
1311
1312         Reviewed by Michael Catanzaro.
1313
1314         Add a test for the new API.
1315
1316         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1317         (testsJSCOptions):
1318         (main):
1319
1320 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1321
1322         [GTK][WPE] Support JPEG 2000 images
1323         https://bugs.webkit.org/show_bug.cgi?id=186272
1324
1325         Reviewed by Žan Doberšek.
1326
1327         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1328
1329         * gtk/jhbuild.modules:
1330         * wpe/jhbuild.modules:
1331
1332 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1333
1334         check-webkit-style should warn when using soft-linking macros in a header
1335         <https://webkit.org/b/193750>
1336
1337         Reviewed by Darin Adler.
1338
1339         * Scripts/webkitpy/style/checkers/cpp.py:
1340         (check_language): Add softlink/header check by refactoring the
1341         softlink/framework check.
1342         (CppChecker): Enable softlink/header check by default.
1343         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1344         (CppStyleTest.test_softlink_framework): Rename from
1345         CppStyleTest.test_softlink() and change test framework name in
1346         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1347         files. Set file_name for macros that only appear in headers.
1348         (CppStyleTest.test_softlink_header): Add tests for using
1349         soft-link macros in headers.
1350
1351 2019-01-23  Chris Dumez  <cdumez@apple.com>
1352
1353         Deprecate API to limit the maximum number of WebProcesses
1354         https://bugs.webkit.org/show_bug.cgi?id=193725
1355         <rdar://problem/47464879>
1356
1357         Reviewed by Geoff Garen.
1358
1359         Update existing API tests to stop using deprecated API.
1360
1361         * MiniBrowser/mac/AppDelegate.m:
1362         (defaultConfiguration):
1363         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1364         (TestWebKitAPI::TEST):
1365         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1366         (TestWebKitAPI::TEST):
1367         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1368         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1369         (TEST):
1370         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1371         (TEST):
1372
1373 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1374
1375         [ews-app] Rename ews model buildermappings to buildermapping
1376         https://bugs.webkit.org/show_bug.cgi?id=193729
1377
1378         Reviewed by Lucas Forschler.
1379
1380         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1381         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1382         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1383
1384 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1385
1386         [ews-app] Rename ews model steps to step
1387         https://bugs.webkit.org/show_bug.cgi?id=193697
1388
1389         Reviewed by Lucas Forschler.
1390
1391         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1392         (Step): Renamed Steps to Step.
1393
1394 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1395
1396         Clean up IndexedDB files between tests
1397         https://bugs.webkit.org/show_bug.cgi?id=192796
1398         <rdar://problem/46824999>
1399
1400         Reviewed by Geoffrey Garen.
1401
1402         * DumpRenderTree/mac/DumpRenderTree.mm:
1403         (runTest):
1404         * WebKitTestRunner/TestController.cpp:
1405         (WTR::TestController::resetStateToConsistentValues):
1406         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1407         (WTR::RemoveAllIndexedDatabasesCallback):
1408         (WTR::TestController::ClearIndexedDatabases):
1409         * WebKitTestRunner/TestController.h:
1410         * WebKitTestRunner/TestInvocation.cpp:
1411         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1412
1413 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1414
1415         [ews-app] Rename ews model Builds to Build
1416         https://bugs.webkit.org/show_bug.cgi?id=193695
1417
1418         Reviewed by Lucas Forschler.
1419
1420         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1421         (Build): Renamed Builds to Build.
1422
1423 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1424
1425         webkitpy: Wait longer when launching WebKitTestRunner
1426         https://bugs.webkit.org/show_bug.cgi?id=193734
1427
1428         Reviewed by Aakash Jain.
1429
1430         * Scripts/webkitpy/port/simulator_process.py:
1431         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
1432
1433 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1434
1435         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
1436         https://bugs.webkit.org/show_bug.cgi?id=193182
1437         <rdar://problem/47452154>
1438
1439         Reviewed by Tim Horton.
1440
1441         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
1442         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
1443         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
1444
1445         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
1446         preventing later tests from recognizing gestures.
1447
1448         * WebKitTestRunner/ios/TestControllerIOS.mm:
1449         (WTR::TestController::platformResetStateToConsistentValues):
1450
1451         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
1452
1453 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1454
1455         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
1456         https://bugs.webkit.org/show_bug.cgi?id=193722
1457         <rdar://problem/47481475>
1458
1459         Reviewed by Lucas Forschler.
1460
1461         iPhone and iPad ports should both use the iOS config.
1462
1463         * Scripts/webkitpy/port/ios_simulator.py:
1464         (IPhoneSimulatorPort.__init__):
1465         (IPadSimulatorPort.__init__):
1466
1467 2019-01-23  Rob Buis  <rbuis@igalia.com>
1468
1469         Update MIME type parser
1470         https://bugs.webkit.org/show_bug.cgi?id=180526
1471
1472         Reviewed by Frédéric Wang.
1473
1474         Add unit tests for both parse modes of ParsedContentType.
1475
1476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1477         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
1478         (TestWebKitAPI::TEST):
1479
1480 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1481
1482         [ews-app] fetch loop should not stop on network issues
1483         https://bugs.webkit.org/show_bug.cgi?id=193666
1484
1485         Reviewed by Lucas Forschler.
1486
1487         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1488         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
1489
1490 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1491
1492         [iOS] Multiple WKWebViewAutofillTests are flaky failures
1493         https://bugs.webkit.org/show_bug.cgi?id=189165
1494         <rdar://problem/47433765>
1495
1496         Reviewed by Tim Horton.
1497
1498         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
1499         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
1500         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
1501         process in sufficient to ensure that any previous action that blurred the focused element in the web process
1502         would make its way to the UI process by the time the layer tree commit is finished.
1503
1504         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
1505         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
1506         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
1507         will fail because it asks for -_autofillContext too early.
1508
1509         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
1510         is handled in the UI process.
1511
1512         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1513
1514         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
1515         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
1516         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
1517         input session.
1518
1519         (-[AutofillTestView textInputHasAutofillContext]):
1520
1521         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
1522
1523         * TestWebKitAPI/cocoa/TestWKWebView.h:
1524         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1525         (nextInputSessionChangeCount):
1526
1527         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
1528         This includes changing the focused element from one to another.
1529
1530         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1531         (-[TestWKWebView didStartFormControlInteraction]):
1532         (-[TestWKWebView didEndFormControlInteraction]):
1533         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1534
1535         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
1536         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
1537         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
1538         that doesn't require an input session to one that doesn't.
1539
1540 2019-01-22  David Kilzer  <ddkilzer@apple.com>
1541
1542         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
1543         <https://webkit.org/b/193676>
1544
1545         Reviewed by Alexey Proskuryakov.
1546
1547         * Scripts/webkitpy/style/checkers/cpp.py:
1548         (check_member_initialization_list):
1549         - Don't report missing whitespace around colon if the colon at
1550           the start of the line is formatted correctly.
1551         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1552         (WebKitStyleTest.test_member_initialization_list):
1553         - Add a test for a missing permutation of existing tests.
1554         - Add a test this false-positive.
1555         - Add blank lines between subtests to make them easier to read.
1556
1557 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1558
1559         [build.webkit.org] Unit-test failure after r237113
1560         https://bugs.webkit.org/show_bug.cgi?id=193669
1561
1562         Reviewed by Michael Catanzaro.
1563
1564         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1565         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
1566         multiple or zero flags.
1567
1568 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
1569
1570         Cache bytecode to disk
1571         https://bugs.webkit.org/show_bug.cgi?id=192782
1572         <rdar://problem/46084932>
1573
1574         Reviewed by Keith Miller.
1575
1576         Add test helper to execute bytecode-cache tests: it executes each test
1577         twice, the first with JSC_diskCachePath set to a temporary directory
1578         and second with JSC_forceDiskCache=true (in addition to the cache path)
1579         to guarantee that only the disk cache is being used and no new
1580         UnlinkedCodeBlocks are being created.
1581
1582         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
1583         * Scripts/run-jsc-stress-tests:
1584
1585 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1586
1587         [css-logical] Implement flow-relative margin, padding and border shorthands
1588         https://bugs.webkit.org/show_bug.cgi?id=188697
1589
1590         Reviewed by Simon Fraser and Antti Koivisto.
1591
1592         * DumpRenderTree/TestOptions.cpp:
1593         (TestOptions::TestOptions):
1594         * DumpRenderTree/TestOptions.h:
1595         * DumpRenderTree/mac/DumpRenderTree.mm:
1596         (setWebPreferencesForTestOptions):
1597         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1598
1599         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1600         (JSONCSSPropertiesChecker.check_codegen_properties):
1601         Allow CSS property definitions to have a 'runtime-flag' parameter which
1602         disables the property when the specified runtime flag is disabled.
1603
1604 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1605
1606         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1607         https://bugs.webkit.org/show_bug.cgi?id=193643
1608
1609         Reviewed by Michael Catanzaro.
1610
1611         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1612         * wpe/jhbuild.modules: Ditto.
1613
1614 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1615
1616         [LFC][Floats] Take float top position into account when computing containing block height.
1617         https://bugs.webkit.org/show_bug.cgi?id=193655
1618
1619         Reviewed by Antti Koivisto.
1620
1621         * LayoutReloaded/misc/LFC-passing-tests.txt:
1622
1623 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1624
1625         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1626         <https://webkit.org/b/193645>
1627         <rdar://problem/47421574>
1628
1629         Reviewed by Alex Christensen.
1630
1631         - Now checks for local soft-linking of all frameworks that have
1632           their own *SoftLinking.{cpp,h,mm} files.
1633         - Changes softlink/uikit warning to softlink/framework.
1634
1635         * Scripts/webkitpy/style/checkers/cpp.py:
1636         (check_language):
1637         (CppChecker):
1638         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1639         (CppStyleTest):
1640
1641 2019-01-20  Saam Barati  <sbarati@apple.com>
1642
1643         Rollout r240210: It broke tests on iOS
1644         https://bugs.webkit.org/show_bug.cgi?id=193640
1645
1646         Unreviewed.
1647
1648         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1649         * Scripts/run-jsc-stress-tests:
1650
1651 2019-01-20  chris fleizach  <cfleizach@apple.com>
1652
1653         AX: Support returning relative frames for accessibility
1654         https://bugs.webkit.org/show_bug.cgi?id=193414
1655         <rdar://problem/47268501>
1656
1657         Reviewed by Zalan Bujtas.
1658
1659         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1660         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1661         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1662         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1663         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1664         (WTR::attributesOfElement):
1665         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1666
1667 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1668
1669         Unreviewed, add my new email address
1670
1671         * Scripts/webkitpy/common/config/contributors.json:
1672
1673 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1674
1675         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1676         https://bugs.webkit.org/show_bug.cgi?id=193617
1677
1678         Reviewed by Antti Koivisto.
1679
1680         * LayoutReloaded/misc/LFC-passing-tests.txt:
1681
1682 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1683
1684         Unreviewed, rolling out r240209.
1685
1686         Broke GTK/WPE injected bundle
1687
1688         Reverted changeset:
1689
1690         "AX: Support returning relative frames for accessibility"
1691         https://bugs.webkit.org/show_bug.cgi?id=193414
1692         https://trac.webkit.org/changeset/240209
1693
1694 2019-01-12  Dan Bernstein  <mitz@apple.com>
1695
1696         [Cocoa] Avoid importing directly from subumbrella frameworks
1697         https://bugs.webkit.org/show_bug.cgi?id=186016
1698         <rdar://problem/40591038>
1699
1700         Reviewed by Sam Weinig.
1701
1702         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1703           LaunchServices header.
1704         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1705           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1706         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1707           when using SDKs earlier than 10.13.
1708         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1709           and OTHER_CPLUSPLUSFLAGS.
1710         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1711           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1712         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1713           LaunchServices header.
1714
1715 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1716
1717         Cache bytecode to disk
1718         https://bugs.webkit.org/show_bug.cgi?id=192782
1719         <rdar://problem/46084932>
1720
1721         Reviewed by Keith Miller.
1722
1723         Add test helper to execute bytecode-cache tests: it executes each test
1724         twice, the first with JSC_diskCachePath set to a temporary directory
1725         and second with JSC_forceDiskCache=true (in addition to the cache path)
1726         to guarantee that only the disk cache is being used and no new
1727         UnlinkedCodeBlocks are being created.
1728
1729         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1730         * Scripts/run-jsc-stress-tests:
1731
1732 2019-01-20  chris fleizach  <cfleizach@apple.com>
1733
1734         AX: Support returning relative frames for accessibility
1735         https://bugs.webkit.org/show_bug.cgi?id=193414
1736         <rdar://problem/47268501>
1737
1738         Reviewed by Zalan Bujtas.
1739
1740         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1741         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1742         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1743         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1744         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1745         (WTR::attributesOfElement):
1746         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1747
1748 2019-01-20  Antoine Quint  <graouts@apple.com>
1749
1750         Add a POINTER_EVENTS feature flag
1751         https://bugs.webkit.org/show_bug.cgi?id=193577
1752         <rdar://problem/47408511>
1753
1754         Unreviewed. Also enable Pointer Events for iosmac.
1755
1756         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1757
1758 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1759
1760         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1761         https://bugs.webkit.org/show_bug.cgi?id=193613
1762
1763         Reviewed by Antti Koivisto.
1764
1765         * LayoutReloaded/misc/LFC-passing-tests.txt:
1766
1767 2019-01-19  Antoine Quint  <graouts@apple.com>
1768
1769         Add a POINTER_EVENTS feature flag
1770         https://bugs.webkit.org/show_bug.cgi?id=193577
1771
1772         Reviewed by Dean Jackson.
1773
1774         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1775
1776 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1777
1778         Disable the run-jsc-stress-test remote host key check [second round].
1779         https://bugs.webkit.org/show_bug.cgi?id=192988
1780
1781         Reviewed by Dewei Zhu.
1782
1783         * Scripts/run-jsc-stress-tests:
1784
1785 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1786
1787         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1788         https://bugs.webkit.org/show_bug.cgi?id=193597
1789
1790         Reviewed by Lucas Forschler.
1791
1792         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1793
1794 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1795
1796         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1797         https://bugs.webkit.org/show_bug.cgi?id=193595
1798
1799         Reviewed by Lucas Forschler.
1800
1801         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1802         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1803         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1804
1805 2019-01-18  Chris Dumez  <cdumez@apple.com>
1806
1807         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1808         https://bugs.webkit.org/show_bug.cgi?id=193588
1809         <rdar://problem/47131566>
1810
1811         Reviewed by Alex Christensen.
1812
1813         Add layout test coverage.
1814
1815         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1816
1817 2019-01-18  Jer Noble  <jer.noble@apple.com>
1818
1819         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1820         https://bugs.webkit.org/show_bug.cgi?id=189553
1821
1822         Reviewed by Tim Horton.
1823
1824         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1825
1826         * ContentExtensionTester/Configurations/Base.xcconfig:
1827         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1828         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1829         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1830         * ImageDiff/cg/Configurations/Base.xcconfig:
1831         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1832         * MiniBrowser/Configurations/Base.xcconfig:
1833         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1834         * MobileMiniBrowser/Configurations/Base.xcconfig:
1835         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1836         * Scripts/webkitpy/style/checker.py:
1837         (_all_categories):
1838         (FileType):
1839         (CheckerDispatcher._file_type):
1840         (CheckerDispatcher._create_checker):
1841         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1842         (SDKVariantChecker):
1843         (SDKVariantChecker.__init__):
1844         (SDKVariantChecker.check):
1845         * TestWebKitAPI/Configurations/Base.xcconfig:
1846         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1847         * WebEditingTester/Configurations/Base.xcconfig:
1848         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1849         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1850         * WebKitTestRunner/Configurations/Base.xcconfig:
1851         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1852         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1853         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1854
1855 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1856
1857         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1858         <https://webkit.org/b/193568>
1859         <rdar://problem/47381130>
1860
1861         Reviewed by Alex Christensen.
1862
1863         Make sure no one re-introduces UIKit soft-linking by adding a
1864         style rule.
1865
1866         * Scripts/webkitpy/style/checkers/cpp.py:
1867         (check_language): Add softlink/uikit check.
1868         (CppChecker): Enable softlink/uikit check.
1869         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1870         (CppStyleTest): Add test for softlink/uikit.
1871
1872 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1873
1874         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1875         https://bugs.webkit.org/show_bug.cgi?id=193584
1876
1877         Change "-dev" to "-devel".
1878
1879         Reviewed by Michael Catanzaro.
1880
1881         * gtk/install-dependencies:
1882
1883 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1884
1885         webkitpy: Add iPhone and iPad ports
1886         https://bugs.webkit.org/show_bug.cgi?id=193537
1887         <rdar://problem/47353390>
1888
1889         Reviewed by Lucas Forschler.
1890
1891         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1892         ports. Note that this separation is optional, the --ios-simulator command remains.
1893
1894         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1895         (RunTest.test_device_type_test_division): Drive-by fix.
1896         (RunTest.test_device_type_specific_listing): Ditto.
1897         (RunTest.test_ipad_test_division):
1898         (RunTest):
1899         (RunTest.test_ipad_listing):
1900         * Scripts/webkitpy/port/factory.py:
1901         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1902         (PortFactory):
1903         * Scripts/webkitpy/port/ios_simulator.py:
1904         (IPhoneSimulatorPort):
1905         (IPadSimulatorPort):
1906
1907 2019-01-18  Chris Dumez  <cdumez@apple.com>
1908
1909         Regression(PSON) Scroll position is not always restored properly when navigating back
1910         https://bugs.webkit.org/show_bug.cgi?id=193578
1911         <rdar://problem/47386331>
1912
1913         Reviewed by Tim Horton.
1914
1915         Add API test coverage.
1916
1917         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1918
1919 2019-01-18  Youenn Fablet  <youenn@apple.com>
1920
1921         Add a new SPI to request for cache storage quota increase
1922         https://bugs.webkit.org/show_bug.cgi?id=193323
1923
1924         Reviewed by Alex Christensen.
1925
1926         Implement WebsiteDataStore quota delegate to handle quota requests.
1927         By default, do not update quota.
1928         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1929
1930         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1931         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1932         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1933         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1934         * WebKitTestRunner/TestController.cpp:
1935         (WTR::TestController::allowCacheStorageQuotaIncrease):
1936         * WebKitTestRunner/TestController.h:
1937         * WebKitTestRunner/TestInvocation.cpp:
1938         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1939         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1940         (-[CacheStorageQuotaManager init]):
1941         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1942         (WTR::initializeWebViewConfiguration):
1943         (WTR::TestController::cocoaResetStateToConsistentValues):
1944         (WTR::TestController::allowCacheStorageQuotaIncrease):
1945
1946 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1947
1948         [ews-build] Pass owner to the triggered builds
1949         https://bugs.webkit.org/show_bug.cgi?id=193574
1950
1951         Reviewed by Lucas Forschler.
1952
1953         * BuildSlaveSupport/ews-build/factories.py:
1954         (BuildFactory.propertiesToPassToTriggers):
1955
1956 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1957
1958         [ews-app] Send patch author as a build property
1959         https://bugs.webkit.org/show_bug.cgi?id=193560
1960
1961         Reviewed by Lucas Forschler.
1962
1963         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1964         (BugzillaPatchFetcher.fetch):
1965
1966 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1967
1968         webkitpy: Implement device type specific expected results (Follow-up fix)
1969         https://bugs.webkit.org/show_bug.cgi?id=192162
1970         <rdar://problem/46345449>
1971
1972         Unreviewed infrastructure fix.
1973
1974         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1975         (Manager.run): Don't boot a device if no tests are available to run on it.
1976
1977 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1978
1979         webkitpy: Implement device type specific expected results (Follow-up fix)
1980         https://bugs.webkit.org/show_bug.cgi?id=192162
1981         <rdar://problem/46345449>
1982
1983         Unreviewed infrastructure fix.
1984
1985         * Scripts/webkitpy/api_tests/manager.py:
1986         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1987
1988 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1989
1990         webkitpy: Implement device type specific expected results (Part 2)
1991         https://bugs.webkit.org/show_bug.cgi?id=192162
1992         <rdar://problem/46345449>
1993
1994         Rubber-stamped by Aakash Jain.
1995
1996         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1997         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1998         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1999
2000         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2001         (LayoutTestFinder.find_tests): Pass device_type through.
2002         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2003         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2004         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2005         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2006         (Manager._collect_tests): Pass device type to test finder.
2007         (Manager._needs_web_platform_test):
2008         (Manager._prepare_lists): Index _expectations by device type.
2009         (Manager._test_input_for_file):
2010         (Manager._test_is_slow): Ditto.
2011         (Manager._test_should_dump_jsconsolelog_in_stderr):
2012         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2013         (Manager._get_test_inputs):
2014         (Manager._update_worker_count):
2015         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2016         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2017         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2018         the one which runs the test.
2019         (Manager._run_test_subset):
2020         (Manager._run_tests): Index _expectations by current_device_type.
2021         (Manager._print_expectation_line_for_test): Ditto.
2022         (Manager._print_expectations_for_subset): Ditto.
2023         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2024         Unlike run, this function will behave the same regardless of what devices are available.
2025         (Manager._custom_device_for_test): Deleted.
2026         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2027         (ManagerTest.test_uses_custom_device): Deleted.
2028         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2029         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2030         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2031         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2032         all of the expectations.
2033         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2034         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2035         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2036         (TestExpectations.__init__): Allow device_type to be passed through.
2037         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2038         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2039         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2040         (summarize_results):
2041         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2042         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2043         a test ran with, one must check all expectations to find the first non-skip expectation.
2044         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2045         (RunTest.test_device_type_test_division):
2046         (RunTest):
2047         (RunTest.test_device_type_specific_listing):
2048         * Scripts/webkitpy/port/base.py:
2049         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2050         (Port.supported_device_types): The result of this function will change based on what devices are available.
2051         * Scripts/webkitpy/port/device_port.py:
2052         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2053         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2054         can be used.
2055         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2056         any, or the DEFAULT_DEVICE_TYPES of the port.
2057         * Scripts/webkitpy/port/ios.py:
2058         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2059         * Scripts/webkitpy/port/ios_simulator.py:
2060         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2061         * Scripts/webkitpy/port/watch.py:
2062         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2063         * Scripts/webkitpy/port/watch_simulator.py:
2064         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2065         * Scripts/webkitpy/xcode/device_type.py:
2066         (DeviceType):
2067         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2068
2069 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2070
2071         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2072         https://bugs.webkit.org/show_bug.cgi?id=193575
2073
2074         Reviewed by Michael Catanzaro.
2075
2076         Allow the script to run without explicit port argument because
2077         it's specific to the WPE port anyway.
2078
2079         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2080         and simplify the rest of the code accordingly.
2081
2082 2019-01-18  Charlie Turner  <cturner@igalia.com>
2083
2084         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2085         https://bugs.webkit.org/show_bug.cgi?id=192229
2086
2087         Reviewed by Xabier Rodriguez-Calvar.
2088
2089         * MiniBrowser/wpe/main.cpp:
2090         (main): Enable encrypted-media by default.
2091
2092 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2093
2094         [Flatpak] Missing KeyboardInterrupt exception handler
2095         https://bugs.webkit.org/show_bug.cgi?id=193570
2096
2097         Reviewed by Michael Catanzaro.
2098
2099         * flatpak/flatpakutils.py:
2100         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2101
2102 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2103
2104         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2105         https://bugs.webkit.org/show_bug.cgi?id=193564
2106
2107         Reviewed by Antti Koivisto.
2108
2109         * LayoutReloaded/misc/LFC-passing-tests.txt:
2110
2111 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2112
2113         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2114         https://bugs.webkit.org/show_bug.cgi?id=193562
2115
2116         Reviewed by Antti Koivisto.
2117
2118         * LayoutReloaded/misc/LFC-passing-tests.txt:
2119
2120 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2121
2122         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2123         https://bugs.webkit.org/show_bug.cgi?id=193555
2124
2125         Reviewed by Antti Koivisto.
2126
2127         * LayoutReloaded/misc/LFC-passing-tests.txt:
2128
2129 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2130
2131         [WPE] Add Qt extension
2132         https://bugs.webkit.org/show_bug.cgi?id=191464
2133
2134         Reviewed by Carlos Garcia Campos.
2135
2136         MiniBrowser and API tests for the WPE Qt API. To run the
2137         MiniBrowser a new script is introduced. Example invocation:
2138
2139         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2140
2141         Also note-worthy is the introduction of the python2-subprocess32
2142         dependency to run the GLib API tests.
2143
2144         * MiniBrowser/wpe/CMakeLists.txt:
2145         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2146         * MiniBrowser/wpe/qt/main.cpp: Added.
2147         (main):
2148         * MiniBrowser/wpe/qt/main.qml: Added.
2149         * MiniBrowser/wpe/qt/qml.qrc: Added.
2150         * Scripts/run-gtk-tests:
2151         (GtkTestRunner.is_google_test):
2152         (GtkTestRunner):
2153         (GtkTestRunner.is_qt_test):
2154         * Scripts/run-qt-wpe-minibrowser: Added.
2155         * Scripts/run-wpe-tests:
2156         (WPETestRunner):
2157         (WPETestRunner.is_google_test):
2158         (WPETestRunner.is_qt_test):
2159         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2160         (TestLoad::main):
2161         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2162         (TestLoadHtml::main):
2163         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2164         (TestLoadRequest::main):
2165         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2166         (TestRunJavaScript::main):
2167         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2168         (waitForSignal):
2169         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2170         (LoadSpy::LoadSpy):
2171         (LoadSpy::~LoadSpy):
2172         (LoadSpy::onLoadingChanged):
2173         (LoadStartedCatcher::LoadStartedCatcher):
2174         (LoadStartedCatcher::~LoadStartedCatcher):
2175         (LoadStartedCatcher::onLoadingChanged):
2176         (waitForLoadSucceeded):
2177         (waitForLoadFailed):
2178         * TestWebKitAPI/glib/CMakeLists.txt:
2179         * flatpak/flatpakutils.py:
2180         (WebkitFlatpak.load_from_args):
2181         (WebkitFlatpak.__init__):
2182         (WebkitFlatpak.clean_args):
2183         (WebkitFlatpak.run_in_sandbox):
2184         * flatpak/org.webkit.CommonModules.yaml:
2185         * flatpak/org.webkit.WPE.yaml:
2186         * flatpak/org.webkit.WPEModules.yaml:
2187         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2188         * flatpak/org.webkit.WebKit.yaml:
2189         * glib/api_test_runner.py:
2190         (TestRunner._run_test_qt):
2191         (TestRunner.is_qt_test):
2192         (TestRunner._run_test):
2193
2194 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2195
2196         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2197         https://bugs.webkit.org/show_bug.cgi?id=193494
2198         <rdar://problem/46859627>
2199
2200         Reviewed by Simon Fraser and Tim Horton.
2201
2202         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2203         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2204
2205         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2206         (WTR::UIScriptController::contentOffsetX const):
2207         (WTR::UIScriptController::contentOffsetY const):
2208         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2209         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2210         (WTR::UIScriptController::contentOffsetX const):
2211         (WTR::UIScriptController::contentOffsetY const):
2212         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2213
2214         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2215
2216         * WebKitTestRunner/TestController.cpp:
2217         (WTR::updateTestOptionsFromTestHeader):
2218         * WebKitTestRunner/TestOptions.h:
2219         (WTR::TestOptions::hasSameInitializationOptions const):
2220         * WebKitTestRunner/ios/TestControllerIOS.mm:
2221         (WTR::TestController::platformResetStateToConsistentValues):
2222         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2223         (WTR::UIScriptController::contentOffsetX const):
2224         (WTR::UIScriptController::contentOffsetY const):
2225
2226 2019-01-17  Truitt Savell  <tsavell@apple.com>
2227
2228         Unreviewed, rolling out r240124.
2229
2230         This commit broke an internal build.
2231
2232         Reverted changeset:
2233
2234         "SDK_VARIANT build destinations should be separate from non-
2235         SDK_VARIANT builds"
2236         https://bugs.webkit.org/show_bug.cgi?id=189553
2237         https://trac.webkit.org/changeset/240124
2238
2239 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2240
2241         Fix string concatenation API test after r239920
2242         https://bugs.webkit.org/show_bug.cgi?id=193551
2243         <rdar://problem/47359304>
2244
2245         Reviewed by Youenn Fablet.
2246
2247         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2248         (TestWebKitAPI::TEST):
2249         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2250         in WebKit's build configuration like it apparently is on Linux.
2251
2252 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2253
2254         [ews-build] validate-patch should handle the case when bug_id is None
2255         https://bugs.webkit.org/show_bug.cgi?id=193547
2256
2257         Reviewed by Lucas Forschler.
2258
2259         * BuildSlaveSupport/ews-build/steps.py:
2260         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2261         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2262
2263 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2264
2265         [ews-build] Add patch author information in build
2266         https://bugs.webkit.org/show_bug.cgi?id=193465
2267
2268         Reviewed by Lucas Forschler.
2269
2270         * BuildSlaveSupport/ews-build/steps.py:
2271         (ValidatePatch._is_patch_obsolete):
2272
2273 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2274
2275         [ews-build] Pass bug_id to the triggered builds
2276         https://bugs.webkit.org/show_bug.cgi?id=193548
2277
2278         Reviewed by Lucas Forschler.
2279
2280         * BuildSlaveSupport/ews-build/factories.py:
2281         (BuildFactory.propertiesToPassToTriggers):
2282
2283 2019-01-17  Jer Noble  <jer.noble@apple.com>
2284
2285         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2286         https://bugs.webkit.org/show_bug.cgi?id=189553
2287
2288         Reviewed by Tim Horton.
2289
2290         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2291
2292         * ContentExtensionTester/Configurations/Base.xcconfig:
2293         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2294         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2295         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2296         * ImageDiff/cg/Configurations/Base.xcconfig:
2297         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2298         * MiniBrowser/Configurations/Base.xcconfig:
2299         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2300         * MobileMiniBrowser/Configurations/Base.xcconfig:
2301         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2302         * Scripts/webkitpy/style/checker.py:
2303         (_all_categories):
2304         (FileType):
2305         (CheckerDispatcher._file_type):
2306         (CheckerDispatcher._create_checker):
2307         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2308         (SDKVariantChecker):
2309         (SDKVariantChecker.__init__):
2310         (SDKVariantChecker.check):
2311         * TestWebKitAPI/Configurations/Base.xcconfig:
2312         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2313         * WebEditingTester/Configurations/Base.xcconfig:
2314         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2315         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2316         * WebKitTestRunner/Configurations/Base.xcconfig:
2317         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2318         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2319         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2320
2321 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2322
2323         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2324         https://bugs.webkit.org/show_bug.cgi?id=193534
2325
2326         Reviewed by Antti Koivisto.
2327
2328         * LayoutReloaded/misc/LFC-passing-tests.txt:
2329
2330 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2331
2332         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2333         https://bugs.webkit.org/show_bug.cgi?id=193528
2334
2335         Reviewed by Antti Koivisto.
2336
2337         * LayoutReloaded/misc/LFC-passing-tests.txt:
2338
2339 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2340
2341         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2342         https://bugs.webkit.org/show_bug.cgi?id=193520
2343
2344         Reviewed by Antti Koivisto.
2345
2346         * LayoutReloaded/misc/LFC-passing-tests.txt:
2347
2348 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2349
2350         [ews-build] unapply-patch step should not update source
2351         https://bugs.webkit.org/show_bug.cgi?id=193234
2352
2353         Reviewed by Lucas Forschler.
2354
2355         * BuildSlaveSupport/ews-build/steps.py:
2356         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2357         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2358
2359 2019-01-16  Youenn Fablet  <youenn@apple.com>
2360
2361         Add a new SPI for controlling getUserMedia
2362         https://bugs.webkit.org/show_bug.cgi?id=192793
2363
2364         Reviewed by Eric Carlson.
2365
2366         * MiniBrowser/mac/WK2BrowserWindowController.m:
2367         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2368         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2369         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2370         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2371         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2372         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2373         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2374         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2375         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2376         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2377         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2378         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2379         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2380         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2381
2382 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2383
2384         [LFC][BFC] Inflow non-replaced used width should not be negative.
2385         https://bugs.webkit.org/show_bug.cgi?id=193495
2386
2387         Reviewed by Antti Koivisto.
2388
2389         * LayoutReloaded/misc/LFC-passing-tests.txt:
2390
2391 2019-01-16  Chris Dumez  <cdumez@apple.com>
2392
2393         Regression(PSON) View becomes blank after click a cross-site download link
2394         https://bugs.webkit.org/show_bug.cgi?id=193361
2395         <rdar://problem/47099573>
2396
2397         Reviewed by Geoffrey Garen.
2398
2399         Add API test coverage.
2400
2401         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2402         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2403
2404 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2405
2406         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2407         https://bugs.webkit.org/show_bug.cgi?id=193470
2408
2409         Reviewed by Antti Koivisto.
2410
2411         * LayoutReloaded/misc/LFC-passing-tests.txt:
2412
2413 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2414
2415         [LFC] Adjust margin box verification.
2416         https://bugs.webkit.org/show_bug.cgi?id=193482
2417
2418         Reviewed by Antti Koivisto.
2419
2420         * LayoutReloaded/misc/LFC-passing-tests.txt:
2421
2422 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2423
2424         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2425         https://bugs.webkit.org/show_bug.cgi?id=193451
2426
2427         Reviewed by Geoffrey Garen.
2428
2429         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
2430         (TEST):
2431         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2432         (runWebsiteDataStoreCustomPaths):
2433
2434 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2435
2436         webkitpy: Support boolean simctl isAvailable
2437         https://bugs.webkit.org/show_bug.cgi?id=193472
2438         <rdar://problem/47296150>
2439
2440         Reviewed by Ryosuke Niwa.
2441
2442         * Scripts/webkitpy/xcode/simulated_device.py:
2443         (SimulatedDeviceManager._create_runtimes):
2444         (SimulatedDeviceManager._create_device_with_runtime):
2445
2446 2019-01-15  Chris Dumez  <cdumez@apple.com>
2447
2448         Unreviewed, rolling out r239993, r239995, r239997, and
2449         r239999.
2450
2451         Caused assertions under
2452         ViewGestureController::disconnectFromProcess()
2453
2454         Reverted changesets:
2455
2456         "Regression(PSON) View becomes blank after click a cross-site
2457         download link"
2458         https://bugs.webkit.org/show_bug.cgi?id=193361
2459         https://trac.webkit.org/changeset/239993
2460
2461         "Unreviewed iOS build fix after r239993."
2462         https://trac.webkit.org/changeset/239995
2463
2464         "Fix iOS build after r239993"
2465         https://bugs.webkit.org/show_bug.cgi?id=193361
2466         https://trac.webkit.org/changeset/239997
2467
2468         "Unreviewed, revert part of r239997 as it is not needed to fix
2469         the build."
2470         https://trac.webkit.org/changeset/239999
2471
2472 2019-01-15  Tim Horton  <timothy_horton@apple.com>
2473
2474         Cannot tab out of WKWebView on macOS
2475         https://bugs.webkit.org/show_bug.cgi?id=161448
2476         <rdar://problem/28100085>
2477
2478         Reviewed by Dean Jackson.
2479
2480         Add a test that tabbing into and out of WKWebView works correctly.
2481
2482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2483         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2484         (WebKit2_CommandBackForwardTest::SetUp):
2485         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
2486         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
2487         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
2488         (-[FocusableView canBecomeKeyView]):
2489         (TEST):
2490         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
2491         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
2492         (-[OffscreenWindow initWithSize:]):
2493         (-[OffscreenWindow isKeyWindow]):
2494         (-[OffscreenWindow isVisible]):
2495         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2496         (TestWebKitAPI::PlatformWebView::initialize):
2497         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
2498         (-[ActiveOffscreenWindow isVisible]): Deleted.
2499         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
2500
2501 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
2502
2503         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
2504         https://bugs.webkit.org/show_bug.cgi?id=193459
2505
2506         Reviewed by Mark Lam.
2507
2508         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2509         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
2510
2511 2019-01-15  Chris Dumez  <cdumez@apple.com>
2512
2513         Regression(PSON) View becomes blank after click a cross-site download link
2514         https://bugs.webkit.org/show_bug.cgi?id=193361
2515         <rdar://problem/47099573>
2516
2517         Reviewed by Geoff Garen.
2518
2519         Add API test coverage.
2520
2521         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2522         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2523
2524 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2525
2526         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
2527         https://bugs.webkit.org/show_bug.cgi?id=193448
2528
2529         Reviewed by Antti Koivisto.
2530
2531         * LayoutReloaded/misc/LFC-passing-tests.txt:
2532
2533 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2534
2535         webkitpy: Implement device type specific expected results (Part 1)
2536         https://bugs.webkit.org/show_bug.cgi?id=192162
2537
2538         Reviewed by Lucas Forschler.
2539
2540         Device type specific expected results covers two related ideas. The first (covered by this change)
2541         is where to search for -expected.* files. The second is which tests to run based on the
2542         TestExpectations.txt file.
2543
2544         After this change, the baseline search path will be determined by the type of device running a
2545         test. Device type will be passed into any function which picks a file based on the baseline search
2546         path.
2547
2548         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2549         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
2550         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2551         (Manager.run): Print baseline search path for each round of devices.
2552         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2553         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
2554         (SingleTestRunner._expected_driver_output): Ditto.
2555         (SingleTestRunner._driver_input): Ditto.
2556         * Scripts/webkitpy/layout_tests/views/printing.py:
2557         (Printer.print_config): Move printing of baseline search path to a separate function.
2558         (Printer.print_baseline_search_path): Moved from Printer.print_config.
2559         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2560         (Testprinter.test_print_config):
2561         (Testprinter.test_print_baseline_search_path):
2562         * Scripts/webkitpy/port/base.py:
2563         (Port.baseline_search_path): Pass device_type through.
2564         (Port._expected_baselines_for_suffixes): Ditto.
2565         (Port.expected_baselines): Ditto.
2566         (Port.expected_filename): Ditto.
2567         (Port.expected_checksum): Ditto.
2568         (Port.expected_image): Ditto.
2569         (Port.expected_audio): Ditto.
2570         (Port.expected_text): Ditto.
2571         (Port.reference_files): Ditto.
2572         (Port.tests): Ditto.
2573         (Port._expanded_paths): Ditto.
2574         (Port.skipped_layout_tests): Ditto.
2575         (Port.expectations_dict): Ditto.
2576         (Port._port_specific_expectations_files): Ditto.
2577         (Port.expectations_files): Ditto.
2578         (Port.test_search_path): Ditto.
2579         (Port._tests_for_other_platforms): Ditto.
2580         * Scripts/webkitpy/port/base_unittest.py:
2581         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
2582         (PortTest.test_nonexistant_expectations): Ditto.
2583         (test_ref_tests_platform_directory): Ditto.
2584         * Scripts/webkitpy/port/darwin.py:
2585         (DarwinPort._port_specific_expectations_files): Accept device_type.
2586         * Scripts/webkitpy/port/driver.py:
2587         (DriverProxy):
2588         (DriverProxy.host): Expose _target_host for device_type information.
2589         * Scripts/webkitpy/port/gtk.py:
2590         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2591         * Scripts/webkitpy/port/ios.py:
2592         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2593         * Scripts/webkitpy/port/mac.py:
2594         (MacPort. default_baseline_search_path): Ditto.
2595         * Scripts/webkitpy/port/port_testcase.py:
2596         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2597         * Scripts/webkitpy/port/test.py:
2598         * Scripts/webkitpy/port/watch.py:
2599         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2600         * Scripts/webkitpy/port/win.py:
2601         (WinPort.test_search_path): Accept, but do not use, device_type.
2602         * Scripts/webkitpy/port/wpe.py:
2603         (WPEPort._port_specific_expectations_files): Ditto.
2604         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2605         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2606
2607 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2608
2609         [LFC] Use the containing block's padding box to position out-of-flow elements.
2610         https://bugs.webkit.org/show_bug.cgi?id=193431
2611
2612         Reviewed by Antti Koivisto.
2613
2614         * LayoutReloaded/misc/LFC-passing-tests.txt:
2615
2616 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2617
2618         Move a test implementation file that got misplaced in the Xcode project
2619
2620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2621
2622 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2623
2624         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2625         r239913, and r239914.
2626         https://bugs.webkit.org/show_bug.cgi?id=193407
2627
2628         These revisions caused an internal failure (Requested by
2629         Truitt on #webkit).
2630
2631         Reverted changesets:
2632
2633         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2634         https://bugs.webkit.org/show_bug.cgi?id=186016
2635         https://trac.webkit.org/changeset/239901
2636
2637         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2638         https://trac.webkit.org/changeset/239909
2639
2640         "Tried to fix the build."
2641         https://trac.webkit.org/changeset/239910
2642
2643         "Fixed iOS builds after r239910."
2644         https://trac.webkit.org/changeset/239912
2645
2646         "More build fixing."
2647         https://trac.webkit.org/changeset/239913
2648
2649         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2650         https://trac.webkit.org/changeset/239914
2651
2652 2019-01-14  Mark Lam  <mark.lam@apple.com>
2653
2654         Re-enable ability to build --cloop builds.
2655         https://bugs.webkit.org/show_bug.cgi?id=192955
2656         <rdar://problem/46882363>
2657
2658         Reviewed by Saam barati and Keith Miller.
2659
2660         The --cloop build option was being ignored this whole time since r236381.
2661         This patch makes it possible to build CLoop builds again.
2662
2663         * Scripts/build-jsc:
2664         * Scripts/webkitperl/FeatureList.pm:
2665         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2666
2667 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2668
2669         webkitpy: Expose device_type from host-like objects
2670         https://bugs.webkit.org/show_bug.cgi?id=193406
2671         <rdar://problem/47262305>
2672
2673         Reviewed by Lucas Forschler.
2674
2675         Devices should expose device_type. As a result, all host objects should
2676         provide a device_type property, even if they do not yet define a device_type.
2677
2678         * Scripts/webkitpy/common/system/systemhost.py:
2679         (SystemHost):
2680         (SystemHost.device_type):
2681         * Scripts/webkitpy/common/system/systemhost_mock.py:
2682         (MockSystemHost):
2683         (MockSystemHost.device_type):
2684         * Scripts/webkitpy/port/device.py:
2685         (Device):
2686         (Device.device_type):
2687         * Scripts/webkitpy/xcode/simulated_device.py:
2688         (SimulatedDeviceManager._find_exisiting_device_for_request):
2689         (SimulatedDeviceManager._disambiguate_device_type):
2690         (SimulatedDeviceManager._does_fulfill_request):
2691         (SimulatedDeviceManager.device_count_for_type):
2692         (SimulatedDeviceManager.initialize_devices):
2693         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2694         (test_available_devices):
2695         (test_swapping_devices):
2696
2697 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2698
2699         webkitpy: Support alternate simctl device list output (Follow-up fix)
2700         https://bugs.webkit.org/show_bug.cgi?id=193362
2701         <rdar://problem/47122965>
2702
2703         Rubber-stamped by Lucas Forschler.
2704
2705         * Scripts/webkitpy/xcode/simulated_device.py:
2706         (SimulatedDeviceManager.populate_available_devices):
2707
2708 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2709
2710         [iOS] Expose SPI to access the current sentence boundary and selection state
2711         https://bugs.webkit.org/show_bug.cgi?id=193398
2712         <rdar://problem/45893108>
2713
2714         Reviewed by Dean Jackson.
2715
2716         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2717         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2718         expected.
2719
2720         * TestWebKitAPI/EditingTestHarness.h:
2721         * TestWebKitAPI/EditingTestHarness.mm:
2722         (-[EditingTestHarness moveBackward]):
2723         (-[EditingTestHarness moveForward]):
2724         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2725
2726         Add a couple of new helper methods on EditingTestHarness.
2727
2728         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2729         (-[SelectionChangeObserver initWithWebView:]):
2730         (-[SelectionChangeObserver webView]):
2731         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2732         (-[SelectionChangeObserver currentSelectionAttributes]):
2733
2734 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2735
2736         [LFC][BFC] Add basic box-sizing support.
2737         https://bugs.webkit.org/show_bug.cgi?id=193392
2738
2739         Reviewed by Antti Koivisto.
2740
2741         * LayoutReloaded/misc/LFC-passing-tests.txt:
2742
2743 2019-01-14  Charlie Turner  <cturner@igalia.com>
2744
2745         [WPE] API test gardening
2746         https://bugs.webkit.org/show_bug.cgi?id=193319
2747
2748         Reviewed by Michael Catanzaro.
2749
2750         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2751         passing tests.
2752
2753 2019-01-14  Charlie Turner  <cturner@igalia.com>
2754
2755         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2756         https://bugs.webkit.org/show_bug.cgi?id=192977
2757
2758         Reviewed by Carlos Garcia Campos.
2759
2760         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2761         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2762         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2763         (TestWebKitAPI::GStreamerTest::SetUp):
2764         (TestWebKitAPI::GStreamerTest::TearDown):
2765         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2766         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2767         (TestWebKitAPI::TEST_F):
2768
2769 2019-01-14  Charlie Turner  <cturner@igalia.com>
2770
2771         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2772         https://bugs.webkit.org/show_bug.cgi?id=193332
2773
2774         Reviewed by Michael Catanzaro.
2775
2776         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2777         defined as a char16_t, which changed in ICU 59, the
2778         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2779         unsigned short. This test is relying on the behaviour that
2780         UChar=unsigned short, which doesn't hold across platforms and ICU
2781         library versions. The full fix would be a special syntax for
2782         literal characters so that these ambiguities do not arise. That
2783         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2784         (TestWebKitAPI::TEST):
2785
2786 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2787
2788         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2789
2790         * Scripts/make-dist:
2791         (Distcheck.configure):
2792
2793 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2794
2795         [ews-build] Update macOS queue configurations
2796         https://bugs.webkit.org/show_bug.cgi?id=193365
2797         <rdar://problem/47221073>
2798
2799         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2800
2801         * BuildSlaveSupport/ews-build/config.json:
2802
2803 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2804
2805         [LFC] Adjust assert for statically positioned fixed elements
2806         https://bugs.webkit.org/show_bug.cgi?id=193385
2807
2808         Reviewed by Antti Koivisto.
2809
2810         * LayoutReloaded/misc/LFC-passing-tests.txt:
2811
2812 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2813
2814         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2815         https://bugs.webkit.org/show_bug.cgi?id=193387
2816
2817         Reviewed by Carlos Garcia Campos.
2818
2819         * MiniBrowser/wpe/main.cpp:
2820         (main):
2821
2822 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2823
2824         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2825         https://bugs.webkit.org/show_bug.cgi?id=191655
2826         rdar://problem/46074680
2827
2828         Reviewed by Megan Gardner.
2829
2830         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2831         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2832
2833 2019-01-12  Dan Bernstein  <mitz@apple.com>
2834
2835         [Cocoa] Avoid importing directly from subumbrella frameworks
2836         https://bugs.webkit.org/show_bug.cgi?id=186016
2837         <rdar://problem/40591038>
2838
2839         Reviewed by Sam Weinig.
2840
2841         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2842           LaunchServices header.
2843         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2844           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2845         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2846           when using SDKs earlier than 10.13.
2847         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2848           and OTHER_CPLUSPLUSFLAGS.
2849         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2850           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2851         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2852           LaunchServices header.
2853
2854 2019-01-11  John Wilander  <wilander@apple.com>
2855
2856         Compile out Web API Statistics Collection
2857         https://bugs.webkit.org/show_bug.cgi?id=193370
2858         <rdar://problem/45388584>
2859
2860         Reviewed by Brent Fulgham.
2861
2862         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2863             Defined ENABLE_WEB_API_STATISTICS, off by default.
2864
2865 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2866
2867         [WPE] Add gtk-doc
2868         https://bugs.webkit.org/show_bug.cgi?id=178900
2869
2870         Reviewed by Michael Catanzaro.
2871
2872         Add Tools/gtkdoc to manifest.txt.in files.
2873         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2874
2875         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2876         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2877
2878 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2879
2880         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2881         https://bugs.webkit.org/show_bug.cgi?id=193364
2882         <rdar://problem/47214117>
2883
2884         Reviewed by Tim Horton.
2885
2886         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2887         precise, whereas dragging near the middle of the textarea does.
2888
2889         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2890         (TestWebKitAPI::TEST):
2891
2892 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2893
2894         webkitpy: Support alternate simctl device list output
2895         https://bugs.webkit.org/show_bug.cgi?id=193362
2896         <rdar://problem/47122965>
2897
2898         Reviewed by Lucas Forschler.
2899
2900         * Scripts/webkitpy/xcode/simulated_device.py:
2901         (SimulatedDeviceManager.populate_available_devices):
2902
2903 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2904
2905         [ews-build] Update macOS queue configurations
2906         https://bugs.webkit.org/show_bug.cgi?id=193365
2907
2908         Reviewed by Lucas Forschler.
2909
2910         * BuildSlaveSupport/ews-build/config.json:
2911
2912 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2913
2914         webkitpy: Incorporate device type into baseline search path
2915         https://bugs.webkit.org/show_bug.cgi?id=193356
2916         <rdar://problem/47215515>
2917
2918         Reviewed by Lucas Forschler.
2919
2920         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2921
2922         * Scripts/webkitpy/port/base.py:
2923         (Port.default_baseline_search_path): Allow device type to be passed in.
2924         * Scripts/webkitpy/port/gtk.py:
2925         (GtkPort.default_baseline_search_path): Ignore device type.
2926         * Scripts/webkitpy/port/ios.py:
2927         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2928         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2929         * Scripts/webkitpy/port/ios_device_unittest.py:
2930         (IOSDeviceTest):
2931         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2932         (IOSSimulatorTest):
2933         * Scripts/webkitpy/port/mac.py:
2934         (MacPort.default_baseline_search_path): Ignore device type.
2935         * Scripts/webkitpy/port/watch.py:
2936         (WatchPort.default_baseline_search_path): Ditto.
2937         * Scripts/webkitpy/port/win.py:
2938         (WinPort.default_baseline_search_path): Ditto.
2939         (WinCairoPort.default_baseline_search_path): Ditto.
2940         * Scripts/webkitpy/port/wpe.py:
2941         (WPEPort.default_baseline_search_path): Ditto.
2942
2943 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2944
2945         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2946         https://bugs.webkit.org/show_bug.cgi?id=193352
2947         <rdar://problem/47210736>
2948
2949         Reviewed by Lucas Forschler.
2950
2951         * Scripts/webkitpy/layout_tests/views/printing.py:
2952         (Printer.print_config): Print list on only baseline search paths which exist. 
2953         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2954         (Testprinter.test_print_config):
2955
2956 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2957
2958         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2959         https://bugs.webkit.org/show_bug.cgi?id=193340
2960
2961         Reviewed by David Kilzer.
2962
2963         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2964         (WTR::InjectedBundle::didReceiveMessageToPage):
2965         Pull the strings out into a WKRetainPtr.
2966
2967         * WebKitTestRunner/WebNotificationProvider.cpp:
2968         (WTR::WebNotificationProvider::closeWebNotification):
2969         Adopt the created value into the WKRetainPtr.
2970
2971         * WebKitTestRunner/mac/TestControllerMac.mm:
2972         (WTR::generateWhitelist):
2973         Immediately adopt a created value to avoid potential mistakes.
2974
2975 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2976
2977         Enable DFG on ARM/Linux again
2978         https://bugs.webkit.org/show_bug.cgi?id=192496
2979
2980         Reviewed by Yusuke Suzuki.
2981
2982         After changing the bytecode format DFG was disabled on all 32-bit
2983         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2984         on ARM by default.
2985
2986         * Scripts/run-jsc-stress-tests:
2987
2988 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2989
2990         Unreviewed, fix #ifdef in API test added in r239851.
2991         https://bugs.webkit.org/show_bug.cgi?id=193327
2992         rdar://problem/47093222
2993
2994         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2995
2996 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2997
2998         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2999         https://bugs.webkit.org/show_bug.cgi?id=193109
3000         <rdar://problem/44807048>
3001
3002         Reviewed by Ryosuke Niwa.
3003
3004         Introduce and respect a test option to enable the UndoManager API.
3005
3006         * WebKitTestRunner/TestController.cpp:
3007         (WTR::updateTestOptionsFromTestHeader):
3008         * WebKitTestRunner/TestOptions.h:
3009         (WTR::TestOptions::hasSameInitializationOptions const):
3010         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3011         (WTR::TestController::platformCreateWebView):
3012
3013 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3014
3015         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3016         https://bugs.webkit.org/show_bug.cgi?id=193346
3017
3018         Reviewed by Antti Koivisto.
3019
3020         * LayoutReloaded/misc/LFC-passing-tests.txt:
3021
3022 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3023
3024         Unreviewed, fix typo that breaks dashboard link.
3025
3026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3027         (WebKitBuildbot):
3028
3029 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3030
3031         Update macOS queue configurations
3032         https://bugs.webkit.org/show_bug.cgi?id=193329
3033
3034         Reviewed by Alexey Proskuryakov.
3035
3036         * BuildSlaveSupport/build.webkit.org-config/config.json:
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3038         (BubbleQueueServer):
3039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3040         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3041         (WebKitBuildbot):
3042         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3043         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3044         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3045
3046 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3047
3048         MiniBrowser should be able to navigate to about:blank
3049         https://bugs.webkit.org/show_bug.cgi?id=193345
3050
3051         Reviewed by Simon Fraser.
3052
3053         * MiniBrowser/mac/BrowserWindowController.m:
3054         (-[BrowserWindowController addProtocolIfNecessary:]):
3055         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3056
3057         * MiniBrowser/mac/WK1BrowserWindowController.m:
3058         (-[WK1BrowserWindowController fetch:]):
3059         * MiniBrowser/mac/WK2BrowserWindowController.m:
3060         (-[WK2BrowserWindowController fetch:]):
3061         Clean up the code that uses this to match style.
3062
3063 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3064
3065         Remove MiniBrowser custom "Process Swap" menu item which does not work
3066         https://bugs.webkit.org/show_bug.cgi?id=193344
3067
3068         Reviewed by Simon Fraser.
3069
3070         There is a menu item under the Experimental menu that does work.
3071
3072         * MiniBrowser/mac/AppDelegate.m:
3073         (defaultConfiguration):
3074         * MiniBrowser/mac/SettingsController.h:
3075         * MiniBrowser/mac/SettingsController.m:
3076         (-[SettingsController _populateMenu]):
3077         (-[SettingsController validateMenuItem:]):
3078         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3079         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3080
3081 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3082
3083         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3084         https://bugs.webkit.org/show_bug.cgi?id=193327
3085         rdar://problem/47093222
3086
3087         Reviewed by Tim Horton.
3088
3089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3090         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3091         (TestWebKitAPI::didFinishNavigation):
3092         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3093         (TestWebKitAPI::TEST):
3094         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3095         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3096         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3097         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3098         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3099
3100 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3101
3102         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3103         https://bugs.webkit.org/show_bug.cgi?id=193338
3104         <rdar://problem/46664774>
3105
3106         Reviewed by David Kilzer.
3107
3108         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3109         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3110
3111 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3112
3113         Unreviewed, rolling out r239825.
3114         https://bugs.webkit.org/show_bug.cgi?id=193330
3115
3116         Broke tests on armv7/linux bots (Requested by guijemont on
3117         #webkit).
3118
3119         Reverted changeset:
3120
3121         "Enable DFG on ARM/Linux again"
3122         https://bugs.webkit.org/show_bug.cgi?id=192496
3123         https://trac.webkit.org/changeset/239825
3124
3125 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3126
3127         Disable the run-jsc-stress-test remote host key check.
3128         https://bugs.webkit.org/show_bug.cgi?id=192988
3129
3130         Reviewed by Alexey Proskuryakov.
3131
3132         * Scripts/run-jsc-stress-tests:
3133
3134 2019-01-10  John Wilander  <wilander@apple.com>
3135
3136         Override the session configuration for cookieAcceptPolicy
3137         https://bugs.webkit.org/show_bug.cgi?id=190925
3138         <rdar://problem/45497382>
3139
3140         Reviewed by Alexey Proskuryakov and Alex Christensen.
3141
3142         Test infrastructure for setting a first-party-only cookie policy.
3143
3144         * DumpRenderTree/TestRunner.cpp:
3145         (setOnlyAcceptFirstPartyCookiesCallback):
3146         (TestRunner::staticFunctions):
3147         * DumpRenderTree/TestRunner.h:
3148         * DumpRenderTree/mac/TestRunnerMac.mm:
3149         (TestRunner::setOnlyAcceptFirstPartyCookies):
3150         * DumpRenderTree/win/TestRunnerWin.cpp:
3151         (TestRunner::setOnlyAcceptFirstPartyCookies):
3152         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3153         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3154         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3155         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3156         * WebKitTestRunner/TestInvocation.cpp:
3157         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3158
3159 2019-01-09  Matt Rajca  <mrajca@apple.com>
3160
3161         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3162         https://bugs.webkit.org/show_bug.cgi?id=193301
3163
3164         Reviewed by Jer Noble.
3165         
3166         Added API tests.
3167
3168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3169         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3170         (TEST):
3171         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3172
3173 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3174
3175         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3176         https://bugs.webkit.org/show_bug.cgi?id=193310
3177
3178         Reviewed by Antti Koivisto.
3179
3180         * LayoutReloaded/misc/LFC-passing-tests.txt:
3181
3182 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3183
3184         Enable DFG on ARM/Linux again
3185         https://bugs.webkit.org/show_bug.cgi?id=192496
3186
3187         Reviewed by Yusuke Suzuki.
3188
3189         After changing the bytecode format DFG was disabled on all 32-bit
3190         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3191         on ARM by default.
3192
3193         * Scripts/run-jsc-stress-tests:
3194
3195 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3196
3197         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3198         https://bugs.webkit.org/show_bug.cgi?id=193271
3199
3200         Reviewed by Brent Fulgham.
3201
3202         BSTR is a special data structure created by SysAllocString, not a
3203         wchar_t null-terminated string.
3204
3205         * DumpRenderTree/win/TestRunnerWin.cpp:
3206         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3207         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3208         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3209         BSTR from wide string literals.
3210
3211 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3212
3213         Tweak wording for build/version_check style checker error
3214         https://bugs.webkit.org/show_bug.cgi?id=193256
3215
3216         Reviewed by Tim Horton.
3217
3218         * Scripts/webkitpy/style/checkers/cpp.py:
3219         (check_os_version_checks):
3220         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3221         (WebKitStyleTest.test_os_version_checks):
3222
3223 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3224
3225         [ews-build] Add link to bug along with bug title
3226         https://bugs.webkit.org/show_bug.cgi?id=193293
3227
3228         Reviewed by Lucas Forschler.
3229
3230         * BuildSlaveSupport/ews-build/steps.py:
3231         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3232         (ConfigureBuild.add_bug_id_url): Deleted.
3233         (ConfigureBuild.getBugURL): Deleted.
3234
3235 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3236
3237         [ews-build] Use https for ews-build server
3238         https://bugs.webkit.org/show_bug.cgi?id=193193
3239
3240         Reviewed by Lucas Forschler.
3241
3242         * BuildSlaveSupport/ews-build/steps.py:
3243
3244 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3245
3246         [ews-build] Parse and display number of style failures
3247         https://bugs.webkit.org/show_bug.cgi?id=193280
3248
3249         Reviewed by Lucas Forschler.
3250
3251         * BuildSlaveSupport/ews-build/steps.py:
3252         (CheckStyle): Use TestWithFailureCount as base class.
3253         (CheckStyle.countFailures): Count the number of style failures.
3254
3255 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3256
3257         [ews-build] use patch_id instead of ewspatchid
3258         https://bugs.webkit.org/show_bug.cgi?id=193235
3259
3260         Reviewed by Lucas Forschler.
3261
3262         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3263         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3264         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3265
3266 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3267
3268         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3269         https://bugs.webkit.org/show_bug.cgi?id=192625
3270
3271         Reviewed by Antti Koivisto.
3272
3273         * LayoutReloaded/misc/LFC-passing-tests.txt:
3274
3275 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3276
3277         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3278         https://bugs.webkit.org/show_bug.cgi?id=192841
3279
3280         Reviewed by Carlos Garcia Campos.
3281
3282         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3283         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3284         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3285
3286         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3287
3288         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3289         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3290         (WebKitWebEditorTest::testSelectionChanged):
3291         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3292         (WebKitFrameTest::testMainFrame):
3293         (WebKitFrameTest::testURI):
3294         (WebKitFrameTest::testJavaScriptContext):
3295         (WebKitFrameTest::testJavaScriptValues):
3296         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3297         (testWebViewAuthenticationRequest):
3298         (testWebViewAuthenticationLoadCancelled):
3299         (testWebViewAuthenticationFailure):
3300         (testWebViewAuthenticationStorage):
3301         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3302         (testWebViewAuthenticationProxy):
3303         (testWebViewAuthenticationProxyHTTPS):
3304         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3305         (testAutomationSessionRequestSession):
3306         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3307         (testBackForwardListNavigation):
3308         (testWebKitWebViewSessionState):
3309         (testWebKitWebViewSessionStateWithFormData):
3310         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3311         (ConsoleMessageTest::consoleMessageReceivedCallback):
3312         (testWebKitConsoleMessageConsoleAPI):
3313         (testWebKitConsoleMessageJavaScriptException):
3314         (testWebKitConsoleMessageNetworkError):
3315         (testWebKitConsoleMessageSecurityError):
3316         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3317         (testCookieManagerAcceptPolicy):
3318         (testCookieManagerCookiesChanged):
3319         (testCookieManagerPersistentStorage):
3320         (testCookieManagerPersistentStorageDeleteAll):
3321         (testCookieManagerEphemeral):
3322         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3323         (testWebKitDOMElementAutoFill):
3324         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3325         (downloadLocalFileSuccessfully):
3326         (createFileAtDestination):
3327         (testDownloadOverwriteDestinationDisallowed):
3328         (testDownloadLocalFileError):
3329         (testDownloadRemoteFile):
3330         (testDownloadRemoteFileError):
3331         (testWebViewDownloadURI):
3332         (testPolicyResponseDownload):
3333         (testPolicyResponseDownloadCancel):
3334         (testDownloadMIMEType):
3335         (contextMenuCallback):
3336         (testContextMenuDownloadActions):
3337         (testBlobDownload):
3338         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3339         (testWebKitWebEditorSelectionChanged):
3340         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3341         (testWebKitFrameMainFrame):
3342         (testWebKitFrameURI):
3343         (testWebKitFrameJavaScriptContext):
3344         (testWebKitFrameJavaScriptValues):
3345         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3346         (LoadStopTrackingTest::loadFailed):
3347         (testWebViewTitle):
3348         (testURIRequestHTTPHeaders):
3349         (testURIRequestHTTPMethod):
3350         (testURIResponseHTTPHeaders):
3351         (testRedirectToDataURI):
3352         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3353         (testProcessPerWebView):
3354         (testWebProcessLimit):
3355         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3356         (testWebViewResources):
3357         (testWebResourceLoading):
3358         (testWebResourceSuggestedFilename):
3359         (testWebResourceGetData):
3360         (testWebResourceGetDataError):
3361         (testWebViewResourcesHistoryCache):
3362         (testWebResourceSendRequest):
3363         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3364         (testSSL):
3365         (testInsecureContent):
3366         (testTLSErrorsPolicy):
3367         (testTLSErrorsRedirect):
3368         (testTLSErrorsHTTPAuth):
3369         (testLoadFailedWithTLSErrors):
3370         (testSubresourceLoadFailedWithTLSErrors):
3371         (httpsServerCallback):
3372         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3373         (testWebViewCreateNavigationData):
3374         (testWebViewJavaScriptDialogs):
3375         (testWebViewWindowProperties):
3376         (testWebViewMouseTarget):
3377         (testWebViewFileChooserRequest):
3378         (testWebViewColorChooserRequest):
3379         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3380         (testWebExtensionGetTitle):
3381         (testDocumentLoadedSignal):
3382         (testWebKitWebViewProcessCrashed):
3383         (testWebExtensionWindowObjectCleared):
3384         (testWebExtensionIsolatedWorld):
3385         (permissionRequestCallback):
3386         (didAssociateFormControlsCallback):
3387         (testWebExtensionFormControlsAssociated):
3388         (FormSubmissionTest::FormSubmissionTest):
3389         (FormSubmissionTest::testFormSubmissionResult):
3390         (testWebExtensionFormSubmissionSteps):
3391         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3392         (testNotInitialized):
3393         (testClearDatabase):
3394         (testPrivateBrowsing):
3395         (testGetFavicon):
3396         (testWebViewFavicon):
3397         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3398         (testFindControllerTextFound):
3399         (testFindControllerTextNotFound):
3400         (testFindControllerMatchCount):
3401         (testFindControllerMaxMatchCount):
3402         (testFindControllerNext):
3403         (testFindControllerPrevious):
3404         (testFindControllerCountedMatches):
3405         (testFindControllerOptions):
3406         (testFindControllerHide):
3407         (testFindControllerInstance):
3408         (testFindControllerGetters):
3409         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3410         (testNavigationPolicy):
3411         (testResponsePolicy):
3412         (testNewWindowPolicy):
3413         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3414         (testSecurityOriginBasicConstructor):
3415         (testSecurityOriginURIConstructor):
3416         (testSecurityOriginDefaultPort):
3417         (testSecurityOriginFileURI):
3418         (testOpaqueSecurityOrigin):
3419         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3420         (testWebKitSettings):
3421         (testWebKitSettingsNewWithSettings):
3422         (testWebKitSettingsUserAgent):
3423         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3424         (testWebViewNewWithUserContentManager):
3425         (isStyleSheetInjectedForURLAtPath):
3426         (isScriptInjectedForURLAtPath):
3427         (testUserContentManagerInjectedStyleSheet):
3428         (testUserContentManagerInjectedScript):
3429         (UserScriptMessageTest::scriptMessageReceived):
3430         (UserScriptMessageTest::waitUntilMessageReceived):
3431         (UserScriptMessageTest::runJavaScriptFinished):
3432         (testUserContentManagerScriptMessageReceived):
3433         (testUserContentManagerScriptMessageInWorldReceived):
3434         (testUserContentManagerScriptMessageFromDOMBindings):
3435         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3436         (testWebContextDefault):
3437         (testWebContextEphemeral):
3438         (testWebContextGetPlugins):
3439         (testWebContextURIScheme):
3440         (testWebContextSpellChecker):
3441         (testWebContextLanguages):
3442         (consoleMessageReceivedCallback):
3443         (testWebContextSecurityFileXHR):
3444         (ProxyTest::ProxyTest):
3445         (testWebContextProxySettings):
3446         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3447         (testWebViewWebContext):
3448         (testWebViewWebBackend):
3449         (testWebViewEphemeral):
3450         (testWebViewCustomCharset):
3451         (testWebViewSettings):
3452         (testWebViewRunJavaScript):
3453         (testWebViewCanShowMIMEType):
3454         (testWebViewSubmitForm):
3455         (testWebViewSave):
3456         (testWebViewPageVisibility):
3457         (testWebViewSnapshot):
3458         (testWebViewNotification):
3459         (testWebViewNotificationInitialPermissionAllowed):
3460         (testWebViewNotificationInitialPermissionDisallowed):
3461         (testWebViewIsPlayingAudio):
3462         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3463         (WebsiteDataTest::WebsiteDataTest):
3464         (WebsiteDataTest::remove):
3465         (WebsiteDataTest::clear):
3466         (testWebsiteDataConfiguration):
3467         (testWebsiteDataEphemeral):
3468         (testWebsiteDataCache):
3469         (testWebsiteDataStorage):
3470         (testWebsiteDataDatabases):
3471         (testWebsiteDataAppcache):
3472         (testWebsiteDataCookies):
3473         (testWebsiteDataDeviceIdHashSalt):
3474         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3475         (emitDocumentLoaded):
3476         (emitURIChanged):
3477         (sendRequestCallback):
3478         (contextMenuCallback):
3479         (consoleMessageSentCallback):
3480         (emitFormControlsAssociated):
3481         (formControlsAssociatedCallback):
3482         (emitFormSubmissionEvent):
3483         (willSubmitFormCallback):
3484         (windowObjectCleared):
3485         (methodCallCallback):
3486         (registerGResource):
3487         (webkit_web_extension_initialize_with_user_data):
3488         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
3489         (checkLeaks):
3490         (WebProcessTest::create):
3491         (runTest):
3492         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
3493         (AutocleanupsTest::testWebProcessAutocleanups):
3494         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
3495         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
3496         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
3497         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
3498         (WebKitDOMDOMWindowTest::testSignals):
3499         (WebKitDOMDOMWindowTest::testDispatchEvent):
3500         (WebKitDOMDOMWindowTest::testGetComputedStyle):
3501         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
3502         (WebKitDOMNodeFilterTest::testTreeWalker):
3503         (WebKitDOMNodeFilterTest::testNodeIterator):
3504         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
3505         (WebKitDOMNodeTest::testHierarchyNavigation):
3506         (WebKitDOMNodeTest::testInsertion):
3507         (WebKitDOMNodeTest::testTagNamesNodeList):
3508         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
3509         (WebKitDOMNodeTest::testDOMCache):
3510         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
3511         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3512         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3513         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3514         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
3515         (testUIProcessAutocleanups):
3516         (testWebProcessAutocleanups):
3517         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3518         (testContextMenuPopulateMenu):
3519         (testContextMenuDismissed):
3520         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
3521         (testWebKitDOMClientRectDivBoundingClientRectPosition):
3522         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
3523         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
3524         (testWebKitDOMDOMWindowSignals):
3525         (testWebKitDOMDOMWindowDispatchEvent):
3526         (testWebKitDOMDOMWindowGetComputedStyle):
3527         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
3528         (testWebKitDOMNodeHierarchyNavigation):
3529         (testWebKitDOMNodeInsertion):
3530         (testWebKitDOMNodeTagNamesNodeList):
3531         (testWebKitDOMNodeTagNamesHTMLCollection):
3532         (testWebKitDOMObjectCache):
3533         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
3534         (testWebKitDOMNodeFilterTreeWalker):
3535         (testWebKitDOMNodeFilterNodeIterator):
3536         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
3537         (testWebKitDOMXPathNSResolverNative):
3538         (testWebKitDOMXPathNSResolverCustom):
3539         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
3540         (testInspectorDefault):
3541         (testInspectorManualAttachDetach):
3542         (testInspectorCustomContainerDestroyed):
3543         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
3544         (startTestServer):
3545         (testInspectorServerPageList):
3546         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
3547         (OptionMenuTest::showOptionMenuCallback):
3548         (OptionMenuTest::menuCloseCallback):
3549         (OptionMenuTest::close):
3550         (OptionMenuTest::activateItem):
3551         (OptionMenuTest::selectItem):
3552         (testOptionMenuSimple):
3553         (testOptionMenuGroups):
3554         (testOptionMenuActivate):
3555         (testOptionMenuSelect):
3556         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
3557         (testPrintOperationPrintSettings):
3558         (webViewPrintCallback):
3559         (testPrintOperationPrint):
3560         (testPrintCustomWidget):
3561         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3562         (checkAtspiAccessible):
3563         (testAtspiBasicHierarchy):
3564         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
3565         (testWebKitCheckVersion):
3566         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
3567         (testWebViewEditorCutCopyPasteNonEditable):
3568         (testWebViewEditorCutCopyPasteEditable):
3569         (testWebViewEditorSelectAllNonEditable):
3570         (testWebViewEditorSelectAllEditable):
3571         (loadContentsAndTryToCutSelection):
3572         (testWebViewEditorNonEditable):
3573         (testWebViewEditorEditable):
3574         (testWebViewEditorEditorStateTypingAttributes):
3575         (testWebViewEditorInsertImage):
3576         (testWebViewEditorCreateLink):
3577         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3578         (loadChangedCallback):
3579         (loadFailedCallback):
3580         (loadFailedWithTLSErrorsCallback):
3581         (LoadTrackingTest::LoadTrackingTest):
3582         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3583         (registerGResource):
3584         (removeNonEmptyDirectory):
3585         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3586         (Test::adoptView):
3587         (Test::~Test):
3588         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3589         (WebKitTestBus::getOrCreateConnection):
3590         (WebKitTestBus::createProxy):
3591         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3592         (WebKitTestServer::getWebSocketURIForPath const):
3593         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3594         (WebViewTest::initializeWebView):
3595         (WebViewTest::loadURI):
3596         (WebViewTest::loadHtml):
3597         (WebViewTest::loadPlainText):
3598         (WebViewTest::loadBytes):
3599         (WebViewTest::loadRequest):
3600         (WebViewTest::loadAlternateHTML):
3601         (WebViewTest::goBack):
3602         (WebViewTest::goForward):
3603         (WebViewTest::goToBackForwardListItem):
3604         (resourceGetDataCallback):
3605         (WebViewTest::mainResourceData):
3606         (WebViewTest::javascriptResultToCString):
3607         (WebViewTest::javascriptResultToNumber):
3608         (WebViewTest::javascriptResultToBoolean):
3609         (WebViewTest::javascriptResultIsNull):
3610         (WebViewTest::javascriptResultIsUndefined):
3611         (onSnapshotReady):
3612         (WebViewTest::runWebProcessTest):
3613         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
3614         (WebViewTest::platformInitializeWebView):
3615         (WebViewTest::showInWindow):
3616         (WebViewTest::showInWindowAndWaitUntilMapped):
3617         (WebViewTest::mouseMoveTo):
3618         (WebViewTest::emitPopupMenuSignal):
3619         (WebViewTest::keyStroke):
3620         (WebViewTest::doMouseButtonEvent):
3621
3622 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3623
3624         [WPE] API tests can't run in flatpak environment
3625         https://bugs.webkit.org/show_bug.cgi?id=193242
3626
3627         Reviewed by Michael Catanzaro.
3628
3629         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3630         flatpakutils so that it knows which port it's dealing with.
3631         * glib/common.py: Remove build_dir globals so that subsequent
3632         calls actually take args into account.
3633         (library_build_path):
3634         (binary_build_path):
3635
3636 2019-01-08  Dean Jackson  <dino@apple.com>
3637
3638         Blob references for System Previews don't get a correct file extension
3639         https://bugs.webkit.org/show_bug.cgi?id=193268
3640         <rdar://problem/47133037>
3641
3642         Reviewed by Tim Horton.
3643
3644         New test that a Blob download of a USDZ file gets named correctly.
3645
3646         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3647         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3648         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3649         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3650         (TEST):
3651         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3652
3653 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3654
3655         [WebAuthN] Support U2F HID Authenticators on macOS
3656         https://bugs.webkit.org/show_bug.cgi?id=191535
3657         <rdar://problem/47102027>
3658
3659         Reviewed by Brent Fulgham.
3660
3661         This patch:
3662         1) adds support for U2F mocking mechanism;
3663         2) updates tests to reflect U2fCommandConstructor changes.
3664
3665         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3666         (TestWebKitAPI::TEST):
3667       &nb