04e198fcfdb93b71a1e75fa8e3a14002614b64a1
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         font-weight in @font-face can cause a font to be downloaded even when it's not used
4         https://bugs.webkit.org/show_bug.cgi?id=168114
5         <rdar://problem/30301317>
6
7         Reviewed by Darin Adler.
8
9         LastResort needs to be usable in tests.
10
11         * DumpRenderTree/mac/DumpRenderTree.mm:
12         (allowedFontFamilySet):
13         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
14         (WTR::allowedFontFamilySet):
15         * WebKitTestRunner/mac/TestControllerMac.mm:
16         (WTR::allowedFontFamilySet):
17
18 2017-02-16  Alex Christensen  <achristensen@webkit.org>
19
20         Remove old URL parser
21         https://bugs.webkit.org/show_bug.cgi?id=168483
22
23         Reviewed by Tim Horton.
24
25         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
26         (TestWebKitAPI::checkURL):
27         (TestWebKitAPI::checkRelativeURL):
28         (TestWebKitAPI::checkURLDifferences):
29         (TestWebKitAPI::checkRelativeURLDifferences):
30
31 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
32
33         [WK2] Add additional test infrastructure and unit tests for data interaction
34         https://bugs.webkit.org/show_bug.cgi?id=168439
35         <rdar://problem/30557942>
36
37         Reviewed by Tim Horton.
38
39         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
40         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
41         support data interaction from  See per-method descriptions below for more details.
42
43         * Configurations/TestWebKitAPI.xcconfig:
44
45         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
46
47         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
48
49         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
50         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
51
52         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
53         (-[TestWKWebView editorContainsImageElement]):
54         (-[TestWKWebView editorValue]):
55
56         New helper methods for querying information from the "editor" element in a test page.
57
58         (TestWebKitAPI::TEST):
59         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
60
61         Moves logic for capturing events during a simulated data interaction run from the test file to
62         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
63
64         * TestWebKitAPI/cocoa/TestWKWebView.h:
65         * TestWebKitAPI/cocoa/TestWKWebView.mm:
66         (-[TestMessageHandler removeMessage:]):
67         (-[TestWKWebView clearMessageHandlers:]):
68
69         Add the ability to clear message handlers from the TestWKWebView.
70
71         * TestWebKitAPI/ios/DataInteractionSimulator.h:
72         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
73         (dataInteractionEventNames):
74         (-[DataInteractionSimulator initWithWebView:]):
75         (-[DataInteractionSimulator _resetSimulatedState]):
76
77         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
78         simulating data interaction.
79
80         (-[DataInteractionSimulator observedEventNames]):
81
82         Returns a list of the names of events relevant to data interaction that were observed over the course of the
83         most recent run.
84
85         (-[DataInteractionSimulator runFrom:to:]):
86
87         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
88         to run the same data interaction for multiple simulated gestures.
89
90         (-[DataInteractionSimulator _advanceProgress]):
91         (-[DataInteractionSimulator _finishDataInteraction]):
92         (-[DataInteractionSimulator externalItemProvider]):
93         (-[DataInteractionSimulator setExternalItemProvider:]):
94
95         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
96         phase of a test run.
97
98         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
99         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
100         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
101         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
102
103         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
104         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
105         wherein the the web process might take longer than usual to process the request to start data interaction, and
106         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
107         the web process is received, which then causes no simulated delegate methods to be fired.
108
109         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
110         (-[DataInteractionSimulator run]): Deleted.
111
112 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
113
114         Remove unused test pages in TestWebKitAPI
115         https://bugs.webkit.org/show_bug.cgi?id=168462
116
117         Reviewed by Anders Carlsson.
118
119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
120         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
121         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
122         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
123         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
124         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
125
126 2017-02-16  Alex Christensen  <achristensen@webkit.org>
127
128         Special URLs without a host are invalid
129         https://bugs.webkit.org/show_bug.cgi?id=168461
130
131         Reviewed by Tim Horton.
132
133         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
134         (TestWebKitAPI::TEST_F):
135
136 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
137
138         The collector thread should only start when the mutator doesn't have heap access
139         https://bugs.webkit.org/show_bug.cgi?id=167737
140
141         Reviewed by Keith Miller.
142         
143         Make more tests collect continuously.
144
145         * Scripts/run-jsc-stress-tests:
146
147 2017-02-16  Tim Horton  <timothy_horton@apple.com>
148
149         WKWebView inside a UICollectionView flashes when items are inserted above it
150         https://bugs.webkit.org/show_bug.cgi?id=168376
151         <rdar://problem/29322051>
152
153         Reviewed by Simon Fraser.
154
155         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
156         (-[TestRunnerWKWebView _setStableStateOverride:]):
157         Update the one external caller of this internal method...
158
159         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
160         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
161         * DumpRenderTree/mac/UIScriptControllerMac.mm:
162         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
163         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
164         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
165         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
166         * TestRunnerShared/UIScriptContext/UIScriptController.h:
167         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
168         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
169         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
170         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
171         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
172         back after we dispatch a visible content rect update from the UI process
173         to the Web Content process, so any messages sent from the block will arrive
174         after the visible content rect update.
175
176 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
177
178         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
179         https://bugs.webkit.org/show_bug.cgi?id=168321
180
181         This bots should be added to the trunk build scheduler.
182         Unreviewed fix after r212429.
183
184         * BuildSlaveSupport/build.webkit.org-config/config.json:
185
186 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
187
188         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
189         https://bugs.webkit.org/show_bug.cgi?id=168321
190
191         Reviewed by Michael Catanzaro.
192
193         The additionalArgument --default-cmake-features is used both to
194         skip the JHBuild (InstallGtkDependencies) build step and to build
195         with the default features from the CMake config.
196
197         * BuildSlaveSupport/build.webkit.org-config/config.json:
198         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
199         (Factory.__init__):
200         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
201
202 2017-02-15  Lucas Forschler  <lforschler@apple.com>
203
204         https://bugs.webkit.org/show_bug.cgi?id=168386
205         Remove EFL from build.webkit.org
206
207         Reviewed by Alex Christensen
208
209         * BuildSlaveSupport/build.webkit.org-config/config.json:
210         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
211         (DeleteStaleBuildFiles.start):
212         (appendCustomBuildFlags):
213         (RunWebKitTests.start):
214         (RunBuiltinsTests):
215         (Factory.__init__):
216         (TestFactory.__init__):
217         (loadBuilderConfig):
218         (InstallEflDependencies): Deleted.
219         (RunEflAPITests): Deleted.
220         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
223         (BubbleQueueServer):
224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
226         (Analyzer.prototype._triggeringQueue):
227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
228         (WebKitBuildbot):
229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
230         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
231         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
232         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
233         (_should_file_trigger_build):
234
235 2017-02-15  Alex Christensen  <achristensen@webkit.org>
236
237         Unreviewed, rolling out r212169.
238
239         Broke iOS WebInspector
240
241         Reverted changeset:
242
243         "WebInspector: refactor RemoteInspector to move cocoa specific
244         code to their own files"
245         https://bugs.webkit.org/show_bug.cgi?id=166681
246         http://trac.webkit.org/changeset/212169
247
248 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
249
250         webkitpy: Fix DarwinPort._get_crash_log()
251         https://bugs.webkit.org/show_bug.cgi?id=168372
252         <rdar://problem/30535156>
253
254         Reviewed by Daniel Bates.
255
256         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
257         DarwinPort should return the expected return value for _get_crash_log.
258
259         * Scripts/webkitpy/port/darwin.py:
260         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
261
262 2017-02-15  Chris Dumez  <cdumez@apple.com>
263
264         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
265         https://bugs.webkit.org/show_bug.cgi?id=168291
266         <rdar://problem/30508593>
267
268         Reviewed by Tim Horton.
269
270         Drop overridePreference() implementation in iOS's UIScriptController
271         as it was only used for the minimum font size setting and this setting
272         is not exposed on iOS.
273
274         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
275         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
276         (WTR::UIScriptController::overridePreference):
277         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
278
279 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
280
281         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
282         https://bugs.webkit.org/show_bug.cgi?id=168329
283         <rdar://problem/30518832>
284
285         Reviewed by Daniel Bates.
286
287         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
288         never change given the same input arguments.  Memoize function for efficiency.
289
290         * Scripts/webkitpy/port/darwin.py: Add memoized import.
291         (DarwinPort):
292         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
293         
294
295 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
296
297         webkitpy: Remove unused import from darwin.py
298         https://bugs.webkit.org/show_bug.cgi?id=168371
299
300         Reviewed by Alex Christensen.
301
302         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
303
304 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
305
306         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
307         https://bugs.webkit.org/show_bug.cgi?id=168364
308
309         Reviewed by Michael Catanzaro.
310
311         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
312         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
313         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
314
315         Fixes: http/tests/security/credentials-from-different-domains.html
316                http/tests/xmlhttprequest/cross-origin-no-authorization.html
317
318         * gtk/jhbuild.modules:
319         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
320         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
321
322 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
323
324         [GTK] Update cookie manager API to properly work with ephemeral sessions
325         https://bugs.webkit.org/show_bug.cgi?id=168230
326
327         Reviewed by Michael Catanzaro.
328
329         Update unit tests and add new cases for the new API.
330
331         * MiniBrowser/gtk/main.c:
332         (gotWebsiteDataCallback):
333         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
334         (testCookieManagerEphemeral):
335         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
336         (testWebContextEphemeral):
337         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
338         (testWebViewEphemeral):
339         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
340         (serverCallback):
341         (testWebsiteDataEphemeral):
342         (testWebsiteDataCookies):
343         (beforeAll):
344
345 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
346
347         [WK2] Support data interaction on links
348         https://bugs.webkit.org/show_bug.cgi?id=168331
349         <rdar://problem/30200837>
350
351         Reviewed by Tim Horton.
352
353         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
354         editable area results in the link URL being inserted.
355
356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
357         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
358         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
359         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
360         (TestWebKitAPI::TEST):
361
362 2017-02-14  Jason Rinn  <jrinn@apple.com>
363
364         Add a test for new WebKit Cocoa API, _getContentsAsString.
365         https://bugs.webkit.org/show_bug.cgi?id=168147
366         <rdar://problem/30502539>
367
368         Reviewed by Tim Horton.
369
370         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
371         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
372         (TEST):
373
374 2017-02-14  Matt Rajca  <mrajca@apple.com>
375
376         Website policies: iframes should respect the autoplay policy of the top-level document
377         https://bugs.webkit.org/show_bug.cgi?id=168333
378
379         Reviewed by Alex Christensen.
380
381         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
382         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
383         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
384         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
385         (TEST):
386
387 2017-02-14  Chris Dumez  <cdumez@apple.com>
388
389         HTML Form Validation bubble should take minimum font size setting into consideration
390         https://bugs.webkit.org/show_bug.cgi?id=168271
391         <rdar://problem/29869869>
392
393         Reviewed by Simon Fraser.
394
395         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
396         font size of the validation bubble.
397
398         Add an overridePreference() method to UIScriptController. This is currently
399         used to override the value of the minimumFontSize setting. testRunner's
400         overridePreference() is not usable on WK2 because it does not update the
401         value of the preference on the UIProcess side.
402
403         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
404         (WTR::UIScriptController::overridePreference):
405         * DumpRenderTree/mac/UIScriptControllerMac.mm:
406         (WTR::UIScriptController::overridePreference):
407         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
408         * TestRunnerShared/UIScriptContext/UIScriptController.h:
409         * WebKitTestRunner/TestController.cpp:
410         (WTR::TestController::resetPreferencesToConsistentValues):
411         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
412         (WTR::UIScriptController::overridePreference):
413         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
414         (WTR::UIScriptController::contentsOfUserInterfaceItem):
415         (WTR::UIScriptController::overridePreference):
416
417 2017-02-14  Florian Bruhin  <git@the-compiler.org>
418
419         Use a set instead of a list for tests when parsing expectations
420         https://bugs.webkit.org/show_bug.cgi?id=168304
421
422         In _collect_matching_tests, a lot of membership tests are done on a giant list
423         of strings. By making it a set instead, we can make those much faster, and
424         there's no reason for it to be a list.
425
426         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
427         to 3s on my machine.
428
429         Reviewed by Ryosuke Niwa.
430
431         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
432         (TestExpectationParser.__init__):
433         (TestExpectationParser._collect_matching_tests):
434
435 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
436
437         Unreviewed build-fix after r212297.
438
439         * Scripts/webkitpy/port/simulator_process.py:
440         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
441
442 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
443
444         [CMake] build-webkit should allow building with the default cmake configuration
445         https://bugs.webkit.org/show_bug.cgi?id=168323
446
447         Reviewed by Michael Catanzaro.
448
449         Add a --default-cmake-features switch that makes the script pass
450         no value for any of the features defined by build-webkit, that
451         way the default values from the port cmake config will be used.
452
453         * Scripts/build-webkit:
454         (cMakeArgsFromFeatures):
455
456 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
457
458         Unreviewed build-fix after r212297.
459
460         * Scripts/webkitpy/port/simulator_process.py:
461         (SimulatorProcess.stop): Handle case where there is no process to kill.
462
463 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
464
465         [CMake] build-webkit should print the cmake command executed
466         https://bugs.webkit.org/show_bug.cgi?id=168318
467
468         Reviewed by Michael Catanzaro.
469
470         Run the cmake commands to configure or start the build through
471         a wrapper that prints the command before executing it.
472
473         * Scripts/webkitdirs.pm:
474         (systemVerbose):
475         (generateBuildSystemFromCMakeProject):
476         (buildCMakeGeneratedProject):
477         (cleanCMakeGeneratedProject):
478
479 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
480
481         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
482         https://bugs.webkit.org/show_bug.cgi?id=168150
483
484         Reviewed by Alexey Proskuryakov.
485
486         * Scripts/webkitpy/port/simulator_process.py:
487         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
488         (SimulatorProcess._kill): Move closing of app into stop().
489         * Scripts/webkitpy/xcode/simulator.py:
490         (Device.launch_app):
491         (Device.terminate_app): Deleted.
492
493 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
494
495         REGRESSION(r212192): [GTK] Broke downloads API tests
496         https://bugs.webkit.org/show_bug.cgi?id=168193
497
498         Unreviewed. Update test expectations after r212192.
499
500         The suggested filename now includes a file extensions if the MIME type is known.
501
502         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
503         (testDownloadRemoteFile):
504         (testDownloadMIMEType):
505
506 2017-02-14  Commit Queue  <commit-queue@webkit.org>
507
508         Unreviewed, rolling out r212237.
509         https://bugs.webkit.org/show_bug.cgi?id=168298
510
511         This was a wrong fix (Requested by rniwa on #webkit).
512
513         Reverted changeset:
514
515         "Nwtr unexpectedly passes mismatch ref test if the hashes
516         doesn't match but no diff"
517         https://bugs.webkit.org/show_bug.cgi?id=168221
518         http://trac.webkit.org/changeset/212237
519
520 2017-02-13  Alex Christensen  <achristensen@webkit.org>
521
522         URLs with an invalid IPv4 address should be invalid
523         https://bugs.webkit.org/show_bug.cgi?id=168260
524
525         Reviewed by Tim Horton.
526
527         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
528         (TestWebKitAPI::TEST_F):
529         Update tests to reflect new correct behavior.
530
531 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
532
533         [WinCairo] Add Build Slave
534         https://bugs.webkit.org/show_bug.cgi?id=168263
535
536         Reviewed by Lucas Forschler.
537
538         * BuildSlaveSupport/build.webkit.org-config/config.json:
539
540 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
541
542         Fix the build after r212254
543
544         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
545         (-[DataInteractionSimulator _currentLocation]):
546
547 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
548
549         [WK2] Add test infrastructure and unit tests for data interaction
550         https://bugs.webkit.org/show_bug.cgi?id=168159
551         <rdar://problem/30477634>
552
553         Reviewed by Tim Horton.
554
555         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
556         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
557         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
558         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
559         gesture has already been recognized) at regular intervals over the course of the test.
560
561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
562         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
563         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
564         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
565
566         New test pages for data interaction.
567
568         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
569         (TestWebKitAPI::runTestsExpectingToObserveEvents):
570         (TestWebKitAPI::TEST):
571         * TestWebKitAPI/cocoa/TestWKWebView.mm:
572         (-[TestWKWebView stringByEvaluatingJavaScript:]):
573         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
574         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
575         (-[MockLongPressGestureRecognizer initWithWindow:]):
576         (-[MockLongPressGestureRecognizer locationInView:]):
577         (-[MockLongPressGestureRecognizer state]):
578         (-[MockLongPressGestureRecognizer numberOfTouches]):
579         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
580         (-[DataInteractionSimulator dealloc]):
581         (-[DataInteractionSimulator run]):
582
583         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
584         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
585         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
586
587         (-[DataInteractionSimulator _advanceProgress]):
588
589         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
590         completed, and calls _finishDataInteraction when progress is at 1.
591
592         (-[DataInteractionSimulator _finishDataInteraction]):
593         (-[DataInteractionSimulator _currentLocation]):
594         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
595         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
596         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
597         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
598         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
599
600 2017-02-13  Alex Christensen  <achristensen@webkit.org>
601
602         Percent should be allowed in non-special URL hosts
603         https://bugs.webkit.org/show_bug.cgi?id=168255
604
605         Reviewed by Tim Horton.
606
607         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
608         (TestWebKitAPI::TEST_F):
609
610 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
611
612         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
613         https://bugs.webkit.org/show_bug.cgi?id=168221
614
615         Reviewed by Ryosuke Niwa.
616
617         There is a logic error in comparing mismatch ref test images. In
618         mismatch ref tests, it should be failed if two images has no diff.
619         But, if the hashes are different, nwtr unexpectedly pass the
620         mismatch ref test.
621
622         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
623         (SingleTestRunner._compare_output_with_reference): Fail the
624         mismatch ref test if hashes of two images are equal. Invoke
625         ImageDiff if the hashes don't match.
626
627 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
628
629         Update custom line breaking iterators to the latest version of Unicode
630         https://bugs.webkit.org/show_bug.cgi?id=168182
631
632         Reviewed by Zalan Bujtas.
633
634         Treat the system's ICU as the source of truth to compare breaking positions against.
635
636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
637         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
638         (generateJavaScriptForTest):
639         (breakingLocationsFromICU):
640         (testAFewStrings):
641         (TEST):
642         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
643         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
644
645 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
646
647         [GTK] Several failing WebViewEditor API tests
648         https://bugs.webkit.org/show_bug.cgi?id=161608
649
650         Reviewed by Carlos Garcia Campos.
651
652         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
653         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
654         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
655         except the first one, which is still broken due to unrelated bug #151654.
656
657         * Scripts/run-gtk-tests:
658         (TestRunner):
659         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
660
661 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
662
663         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
664
665         * Scripts/run-gtk-tests:
666         (TestRunner):
667
668 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
669
670         Unreviewed, skip flaky form-controls-associated-signal test
671
672         * Scripts/run-gtk-tests:
673         (TestRunner):
674
675 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
676
677         [GTK] Handle caps lock indicator in event modifiers
678         https://bugs.webkit.org/show_bug.cgi?id=168186
679
680         Reviewed by Michael Catanzaro.
681
682         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
683         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
684
685 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
686
687         MiniBrowser WK1 fails to update URL for within-page navigations
688         https://bugs.webkit.org/show_bug.cgi?id=168173
689
690         Reviewed by Tim Horton.
691         
692         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
693         anchors updates the URL field.
694
695         * MiniBrowser/mac/WK1BrowserWindowController.m:
696         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
697
698 2017-02-10  John Wilander  <wilander@apple.com>
699
700         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
701         https://bugs.webkit.org/show_bug.cgi?id=167474
702         <rdar://problem/24681808>
703         <rdar://problem/24703286>
704         <rdar://problem/30290270>
705
706         This patch adds test infrastructure to allow testing 
707         of the various rules in place for data records removal.
708
709         Reviewed by Andy Estes.
710
711         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
712         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
713         (WTR::InjectedBundle::didReceiveMessageToPage):
714             Callback mechanism to tell pages that a website data store
715             scan has happened.
716         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
717         (WTR::TestRunner::setStatisticsPrevalentResource):
718         (WTR::TestRunner::isStatisticsPrevalentResource):
719         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
720         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
721         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
722         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
723         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
724         (WTR::TestRunner::statisticsFireDataModificationHandler):
725         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
726         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
727         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
728         (WTR::TestRunner::statisticsResetToConsistentState):
729         * WebKitTestRunner/InjectedBundle/TestRunner.h:
730         * WebKitTestRunner/TestController.cpp:
731         (WTR::TestController::setStatisticsPrevalentResource):
732         (WTR::TestController::isStatisticsPrevalentResource):
733         (WTR::TestController::setStatisticsHasHadUserInteraction):
734         (WTR::TestController::isStatisticsHasHadUserInteraction):
735         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
736         (WTR::TestController::statisticsFireDataModificationHandler):
737         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
738         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
739         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
740         (WTR::TestController::statisticsResetToConsistentState):
741         * WebKitTestRunner/TestController.h:
742             These are all configuration and test functions.
743         * WebKitTestRunner/TestInvocation.cpp:
744         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
745
746 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
747
748         REGRESSION(r182916) run-perf-tests never timeouts
749         https://bugs.webkit.org/show_bug.cgi?id=167626
750
751         Reviewed by Ryosuke Niwa.
752
753         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
754         was beeing ignored because the driver was created with no_timeout=True
755         unconditionally.
756         This adds a new parameter --no-timeout (disabled by default), that
757         allows to use the driver with the expected timeout values.
758         It also passes --no-timeout to DRT/WTR to ensure that timeouts
759         are always controlled by the Python Driver.
760
761         * Scripts/webkitpy/performance_tests/perftest.py:
762         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
763         (PerfTest.run): Disabling timeout should be done when the Driver is created.
764         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
765         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
766         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
767         (_run_tests_set): Pass the no-timeout parameter.
768         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
769         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
770         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
771         (MainTest.test_parse_args): Test that the argument no-timeout.
772
773 2017-02-10  Daniel Bates  <dabates@apple.com>
774
775         Detach frame from document when entering page cache
776         https://bugs.webkit.org/show_bug.cgi?id=166774
777         <rdar://problem/29904368>
778
779         Reviewed by Chris Dumez.
780
781         * DumpRenderTree/mac/DumpRenderTree.mm:
782         (resetWebPreferencesToConsistentValues):
783         * DumpRenderTree/win/DumpRenderTree.cpp:
784         (resetWebPreferencesToConsistentValues):
785         * WebKitTestRunner/TestController.cpp:
786         (WTR::TestController::resetPreferencesToConsistentValues):
787
788 2017-02-10  Tim Horton  <timothy_horton@apple.com>
789
790         Infinite UI process hang under ensurePositionInformationIsUpToDate
791         https://bugs.webkit.org/show_bug.cgi?id=168154
792         <rdar://problem/30428673>
793
794         Reviewed by Simon Fraser.
795
796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
797         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
798         (recursiveFindHighlightLongPressRecognizer):
799         (TEST):
800         Add a somewhat nasty test that does an async interaction information update, but
801         kills the Web process before it arrives, and then does a sync interaction
802         information update, which will wait for the oustanding async interaction
803         information update if we still think it's coming. Before the patch, this
804         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
805
806 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
807
808         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
809         https://bugs.webkit.org/show_bug.cgi?id=168127
810         rdar://problem/30467120
811
812         Reviewed by Tim Horton.
813
814         Reparent the web view before we try to fetch it via:
815             [[[window contentView] subviews] objectAtIndex:0];
816         which would throw an exception if the test unparented it.
817
818         * DumpRenderTree/mac/DumpRenderTree.mm:
819         (resetWebViewToConsistentStateBeforeTesting):
820         (runTest):
821
822 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
823
824         [Resource Timing] Enable Resource Timing by default in Tests
825         https://bugs.webkit.org/show_bug.cgi?id=168145
826
827         Reviewed by Ryosuke Niwa.
828
829         * DumpRenderTree/mac/DumpRenderTree.mm:
830         (resetWebPreferencesToConsistentValues):
831         * DumpRenderTree/win/DumpRenderTree.cpp:
832         (resetWebPreferencesToConsistentValues):
833         * WebKitTestRunner/TestController.cpp:
834         (WTR::TestController::resetPreferencesToConsistentValues):
835
836 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
837
838         Removing LayoutTestRelay
839         https://bugs.webkit.org/show_bug.cgi?id=165927
840
841         Reviewed by Daniel Bates.
842         Part 2
843
844         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
845         simulators through simctl (iOS 10 and later), use this functionality instead.
846
847         * BuildSlaveSupport/built-product-archive:
848         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
849         Added a FIXME that we will need to implement similar archiving machinery once we build
850         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
851         * BuildSlaveSupport/kill-old-processes:
852         (main): Remove LayoutTestRelay from list of processes.
853         * LayoutTestRelay: Removed LayoutTestRelay.
854         * Makefile:
855         * Scripts/build-layouttestrelay: Removed.
856         * Scripts/build-webkit: Removed LayoutTestRelay references.
857
858 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
859
860         [WebCrypto] Add WebCryptoAPI to watchlist
861         https://bugs.webkit.org/show_bug.cgi?id=168138
862
863         Reviewed by Youenn Fablet.
864
865         * Scripts/webkitpy/common/config/watchlist:
866
867 2017-02-10  Brady Eidson  <beidson@apple.com>
868
869         Replace all WebKit Library Version checks in WK2 with SDK version checks.
870         https://bugs.webkit.org/show_bug.cgi?id=168124
871
872         Reviewed by Geoffrey Garen.
873
874         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
875         
876         * MiniBrowser/mac/main.m:
877         (main):
878         * MobileMiniBrowser/MobileMiniBrowser/main.m:
879         (main):
880         * TestWebKitAPI/ios/mainIOS.mm:
881         (main):
882         * TestWebKitAPI/mac/mainMac.mm:
883         (main):
884         * WebKitTestRunner/ios/mainIOS.mm:
885         (main):
886         * WebKitTestRunner/mac/main.mm:
887         (setDefaultsToConsistentValuesForTesting):
888
889 2017-02-10  Alex Christensen  <achristensen@webkit.org>
890
891         Fix El Capitan build.
892
893         * Scripts/build-webkit:
894         Don't build libwebrtc anywhere for now.
895
896 2017-02-10  Andy Estes  <aestes@apple.com>
897
898         Move two MiniBrowserBundle settings out of the .pbxproj
899         https://bugs.webkit.org/show_bug.cgi?id=168106
900
901         Reviewed by Tim Horton.
902
903         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
904         the project file. This removes the project file override.
905
906         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
907
908         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
909         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
910
911 2017-02-10  Alex Christensen  <achristensen@webkit.org>
912
913         Fix 32-and-64-bit build on El Capitan.
914
915         * Scripts/build-webkit:
916         Somebody's building with something like this:
917         build-webkit ARCHS="i386 x86_64"
918         We want this to also not build libwebrtc for now.
919
920 2017-02-10  Alex Christensen  <achristensen@webkit.org>
921
922         Fix 32-bit build on El Capitan.
923
924         * Scripts/build-webkit:
925         The bot uses ARCHS=i386 instead of --32-bit.
926         This is a hack, but it should fix the bot until I can do a better fix in the morning.
927
928 2017-02-10  Alex Christensen  <achristensen@webkit.org>
929
930         Fix 32-bit build on El Capitan.
931
932         * Scripts/build-webkit:
933         Don't build i386 libwebrtc.
934
935 2017-02-09  Alex Christensen  <achristensen@webkit.org>
936
937         Unreviewed, rolling out r212040.
938
939         Broke build.  I'm not surprised
940
941         Reverted changeset:
942
943         "[WebRTC][Mac] Activate libwebrtc"
944         https://bugs.webkit.org/show_bug.cgi?id=167293
945         http://trac.webkit.org/changeset/212040
946
947 2017-02-09  Alex Christensen  <achristensen@webkit.org>
948
949         Build libwebrtc on bots without using it yet
950         https://bugs.webkit.org/show_bug.cgi?id=168062
951
952         Reviewed by Brent Fulgham.
953
954         * Scripts/build-webkit:
955
956 2017-02-09  Alex Christensen  <achristensen@webkit.org>
957
958         Don't build libwebrtc.
959
960         * Scripts/build-webkit:
961         Not ready yet.  It broke El Capitan and iOS.
962
963 2017-02-09  Alex Christensen  <achristensen@webkit.org>
964
965         Build libwebrtc on bots without using it yet
966         https://bugs.webkit.org/show_bug.cgi?id=168062
967
968         Reviewed by Brent Fulgham.
969
970         * Scripts/build-webkit:
971
972 2017-02-09  Alex Christensen  <achristensen@webkit.org>
973
974         Rename isAppleMacWebKit to isAppleCocoaWebKit
975         https://bugs.webkit.org/show_bug.cgi?id=168075
976
977         Reviewed by Geoffrey Garen.
978
979         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
980
981         * Scripts/build-api-tests:
982         * Scripts/build-dumprendertree:
983         * Scripts/build-jsc:
984         (buildMyProject):
985         * Scripts/build-layouttestrelay:
986         * Scripts/build-webkit:
987         * Scripts/build-webkittestrunner:
988         * Scripts/run-api-tests:
989         (isSupportedPlatform):
990         (runTest):
991         (listAllTests):
992         (prepareEnvironmentForRunningTestTool):
993         * Scripts/run-content-extension-tester:
994         * Scripts/run-javascriptcore-tests:
995         * Scripts/run-minibrowser:
996         * Scripts/show-pretty-diff:
997         * Scripts/webkitdirs.pm:
998         (determineBaseProductDir):
999         (determineArchitecture):
1000         (determinePassedArchitecture):
1001         (safariPath):
1002         (builtDylibPathForName):
1003         (checkFrameworks):
1004         (isAppleWebKit):
1005         (isAppleCocoaWebKit):
1006         (determineNmPath):
1007         (launcherName):
1008         (wrapperPrefixIfNeeded):
1009         (isCMakeBuild):
1010         (mobileSafariBundle):
1011         (debugSafari):
1012         (runSafari):
1013         (runMiniBrowser):
1014         (debugMiniBrowser):
1015         (runWebKitTestRunner):
1016         (debugWebKitTestRunner):
1017         (isAppleMacWebKit): Deleted.
1018         * Scripts/webkitperl/FeatureList.pm:
1019
1020 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1021
1022         Revert r211991
1023         https://bugs.webkit.org/show_bug.cgi?id=168062
1024
1025         * Scripts/build-webkit:
1026         Not quite ready yet.
1027
1028 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1029
1030         Build libwebrtc on bots without using it yet
1031         https://bugs.webkit.org/show_bug.cgi?id=168062
1032
1033         Reviewed by Brent Fulgham.
1034
1035         * Scripts/build-webkit:
1036         Build libwebrtc on Mac when we build ANGLE.
1037
1038 2017-02-09  Youenn Fablet  <youenn@apple.com>
1039
1040         Improve W3C importer command line options
1041         https://bugs.webkit.org/show_bug.cgi?id=167448
1042
1043         Reviewed by Ryosuke Niwa.
1044
1045         Making the list of test paths to import the main arguments of the script.
1046         Allow passing the source directory to import as a -s option.
1047         Adding a warning when given test paths are skipped by default in ImportExpectations.
1048
1049         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1050         Link conversion rules do not change when imported tests are downloaded by the script.
1051
1052         * Scripts/webkitpy/w3c/test_importer.py:
1053         (main):
1054         (parse_args):
1055         (TestImporter.__init__):
1056         (TestImporter.do_import):
1057         (TestImporter):
1058         (TestImporter.check_imported_expectations):
1059
1060 2017-02-08  Chris Dumez  <cdumez@apple.com>
1061
1062         Update web-platform-tests resources
1063         https://bugs.webkit.org/show_bug.cgi?id=168026
1064
1065         Reviewed by Youenn Fablet.
1066
1067         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1068
1069         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1070         (WebPlatformTestServer._copy_webkit_test_files):
1071
1072 2017-02-08  Andy Estes  <aestes@apple.com>
1073
1074         Custom protocols should not continue loading after a network process crash
1075         https://bugs.webkit.org/show_bug.cgi?id=168028
1076         <rdar://problem/27607520>
1077
1078         Reviewed by Brady Eidson.
1079
1080         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1081         (processGroup):
1082         (-[CloseWhileStartingProtocol startLoading]):
1083         (-[CloseWhileStartingProtocol stopLoading]):
1084         (TestWebKitAPI::runTest):
1085         (TestWebKitAPI::TEST):
1086
1087 2017-02-08  Dan Bernstein  <mitz@apple.com>
1088
1089         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1090         https://bugs.webkit.org/show_bug.cgi?id=168031
1091
1092         Reviewed by Tim Horton.
1093
1094         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1095         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1096         (TEST):
1097         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1098         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1099
1100 2017-02-08  Chris Dumez  <cdumez@apple.com>
1101
1102         Use smaller tiles in windows that are not active to facilitate App Napping
1103         https://bugs.webkit.org/show_bug.cgi?id=167997
1104         <rdar://problem/30358835>
1105
1106         Reviewed by Simon Fraser.
1107
1108         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1109         (WTR::PlatformWebView::setWindowIsKey):
1110         Actually update windowIsKey state of NSWindow so the WebView
1111         properly updates its activity state.
1112
1113 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1114
1115         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1116         https://bugs.webkit.org/show_bug.cgi?id=167942
1117         <rdar://problem/30315079>
1118
1119         Reviewed by Tim Horton.
1120
1121         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1122         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1123         contenteditable in these cases.
1124
1125         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1126         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1127         performDragOperation:) directly.
1128
1129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1130         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1131         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1132         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1133         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1134         (-[DragSource draggingSourceOperationMaskForLocal:]):
1135         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1136         (-[DragInfo lastMousePosition]):
1137         (-[DragInfo setLastMousePosition:]):
1138         (-[DragInfo draggingDestinationWindow]):
1139         (-[DragInfo draggingSourceOperationMask]):
1140         (-[DragInfo draggingLocation]):
1141         (-[DragInfo draggedImageLocation]):
1142         (-[DragInfo draggedImage]):
1143         (-[DragInfo draggingPasteboard]):
1144         (-[DragInfo draggingSource]):
1145         (-[DragInfo draggingSequenceNumber]):
1146         (-[DragInfo slideDraggedImageTo:]):
1147         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1148         (-[DragInfo draggingFormation]):
1149         (-[DragInfo setDraggingFormation:]):
1150         (-[DragInfo animatesToDestination]):
1151         (-[DragInfo setAnimatesToDestination:]):
1152         (-[DragInfo numberOfValidItemsForDrop]):
1153         (-[DragInfo setNumberOfValidItemsForDrop:]):
1154         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1155         (-[DragInfo springLoadingHighlight]):
1156         (-[DragInfo resetSpringLoading]):
1157         (TestWebKitAPI::getTestImage):
1158         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1159         (TestWebKitAPI::TEST):
1160         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1161
1162 2017-02-08  Jer Noble  <jer.noble@apple.com>
1163
1164         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1165         https://bugs.webkit.org/show_bug.cgi?id=168007
1166
1167         Reviewed by Alex Christensen.
1168
1169         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1170         (didFinishLoadForFrame):
1171         (TestWebKitAPI::TEST):
1172
1173 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1174
1175         Unreviewed, rolling out r211873.
1176         https://bugs.webkit.org/show_bug.cgi?id=168001
1177
1178         It's in jhbuild for consistent layout tests (Requested by
1179         mcatanzaro on #webkit).
1180
1181         Reverted changeset:
1182
1183         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1184         https://bugs.webkit.org/show_bug.cgi?id=167993
1185         http://trac.webkit.org/changeset/211873
1186
1187 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1188
1189         [GTK] Add icu packages to Tools/gtk/install-dependencies
1190         https://bugs.webkit.org/show_bug.cgi?id=167993
1191
1192         Reviewed by Michael Catanzaro.
1193
1194         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1195         depending in the GNU/Linux distribution)
1196
1197 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1198
1199         Update flakiness dashboard configuration.
1200         https://bugs.webkit.org/show_bug.cgi?id=167957
1201
1202         Reviewed by Alexey Proskuryakov.
1203
1204         * TestResultServer/static-dashboards/builders.jsonp:
1205
1206 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1207
1208         Replace a bot that has an incorrect configuration.
1209         https://bugs.webkit.org/show_bug.cgi?id=167747
1210
1211         Rubber-stamped by Alexey Proskuryakov.
1212
1213         * BuildSlaveSupport/build.webkit.org-config/config.json:
1214
1215 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1216
1217         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1218         https://bugs.webkit.org/show_bug.cgi?id=167927
1219
1220         Reviewed by Brent Fulgham.
1221
1222         Enable ComplexTextController API tests on the Win and GTK ports.
1223
1224         * TestWebKitAPI/PlatformGTK.cmake:
1225         * TestWebKitAPI/PlatformWin.cmake:
1226
1227 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1228
1229         File index appended to previous file in svn-create-patch with SVN 1.9
1230         https://bugs.webkit.org/show_bug.cgi?id=167903
1231         <rdar://problem/30387395>
1232
1233         Reviewed by Daniel Bates.
1234
1235         * Scripts/VCSUtils.pm:
1236         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1237         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1238         trailing newline character from the expected result before comparing it to the actual result.
1239
1240 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1241
1242         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1243         https://bugs.webkit.org/show_bug.cgi?id=167936
1244
1245         Reviewed by Michael Catanzaro.
1246
1247         * Scripts/webkitdirs.pm:
1248         (determineArchitecture):
1249         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1250         since r195083.
1251
1252 2017-02-07  Youenn Fablet  <youenn@apple.com>
1253
1254         Use a JSON file to define which WPT files/folders to import
1255         https://bugs.webkit.org/show_bug.cgi?id=167923
1256
1257         Reviewed by Alex Christensen.
1258
1259         * Scripts/webkitpy/w3c/test_downloader.py:
1260         (TestDownloader.__init__):
1261         (TestDownloader._init_paths_from_expectations):
1262         * Scripts/webkitpy/w3c/test_importer.py:
1263         (parse_args):
1264         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1265
1266 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1267
1268         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1269         https://bugs.webkit.org/show_bug.cgi?id=167916
1270
1271         Reviewed by Carlos Garcia Campos.
1272
1273         URL of mesa-11.0.6.tar.xz has been moved.
1274
1275         * gtk/jhbuild.modules: Fix the module path.
1276
1277 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1278
1279         Static Analyzer: Address some leaks in MiniBrowser
1280         https://bugs.webkit.org/show_bug.cgi?id=167897
1281
1282         Reviewed by Alexey Proskuryakov.
1283
1284         * MiniBrowser/mac/BrowserWindowController.m:
1285         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1286         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1287         (-[ExtensionManagerWindowController add:]):
1288         (-[ExtensionManagerWindowController remove:]):
1289         * MiniBrowser/mac/SettingsController.m:
1290         (-[SettingsController _populateMenu]):
1291         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1292         Address obvious leaks caught by the static analyzer.
1293
1294 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1295
1296         Migrate ComplexTextController to use platform-independent types
1297         https://bugs.webkit.org/show_bug.cgi?id=167833
1298
1299         Reviewed by Brent Fulgham.
1300
1301         Migrate tests away from platform-dependent types.
1302
1303         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1304         (TestWebKitAPI::TEST_F):
1305
1306 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1307
1308         Correct File Path Handling in SecurityOrigin and FileSystem
1309         https://bugs.webkit.org/show_bug.cgi?id=167894
1310         <rdar://problem/30380080>
1311
1312         Reviewed by Alexey Proskuryakov.
1313
1314         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1315         and perform same-volume checks using filesystem-compatible paths.        
1316         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1317         filesystem paths, and perform validation of same-volume checks.
1318         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1319         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1320         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1321         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1322
1323 2017-02-06  Jer Noble  <jer.noble@apple.com>
1324
1325         Playback stalls when a SourceBuffer append causes frame eviction
1326         https://bugs.webkit.org/show_bug.cgi?id=167834
1327
1328         Reviewed by Eric Carlson.
1329
1330         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1331         for the WTF::MediaTime class.
1332
1333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1334         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1335         (TestWebKitAPI::TEST):
1336         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1337         (WTF::operator<<):
1338         (TestWebKitAPI::TestSample::create):
1339         (TestWebKitAPI::TestSample::TestSample):
1340         (TestWebKitAPI::TEST_F):
1341
1342 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1343
1344         Change capitalization in platform name after r211735.
1345
1346         Unreviewed dashboard fix.
1347
1348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1349         (WebKitBuildbot):
1350
1351 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1352
1353         Move the Leaks bot to Sierra
1354         https://bugs.webkit.org/show_bug.cgi?id=167886
1355
1356         Reviewed by Daniel Bates.
1357
1358         * BuildSlaveSupport/build.webkit.org-config/config.json:
1359         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1361         (LeaksViewer._displayURLPrompt):
1362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1363         (WebKitBuildbot):
1364
1365 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1366
1367         Prevent app crash on launch during simctl install workaround
1368         https://bugs.webkit.org/show_bug.cgi?id=167685
1369
1370         Reviewed by Daniel Bates.
1371
1372         * Scripts/webkitpy/port/simulator_process.py:
1373         (SimulatorProcess.__init__): Pass environment to install.
1374         * Scripts/webkitpy/xcode/simulator.py:
1375         (Device.install_app): Accept environment, pass environment to launch.
1376
1377 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1378
1379         Rebase API tests after r211638
1380         https://bugs.webkit.org/show_bug.cgi?id=167779
1381
1382         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1383         (TestWebKitAPI::TEST_F):
1384         URLs with non-special schemes and characters like % in the host now fail to parse,
1385         more like their special counterparts and according to spec.
1386
1387 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1388
1389         Unreviewed trivial fix after r211697.
1390         https://bugs.webkit.org/show_bug.cgi?id=167863
1391
1392         * Scripts/run-javascriptcore-tests:
1393         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1394
1395 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1396
1397         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1398         https://bugs.webkit.org/show_bug.cgi?id=167850
1399
1400         Reviewed by Tim Horton.
1401
1402         * DumpRenderTree/TestRunner.cpp:
1403         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1404
1405 2017-02-04  Andreas Kling  <akling@apple.com>
1406
1407         Plug some leaks in TestController and UIScriptContext.
1408         <https://webkit.org/b/167839>
1409
1410         Reviewed by Alexey Proskuryakov.
1411
1412         Fix a couple of the leaks seen on the leaks bot.
1413
1414         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1415         (UIScriptContext::runUIScript):
1416         * WebKitTestRunner/TestController.cpp:
1417         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1418         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1419
1420 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1421
1422         WK1 mouse events are missing movementX and movementY for pointerlock.
1423         https://bugs.webkit.org/show_bug.cgi?id=167775
1424         rdar://problem/30343810
1425
1426         Reviewed by Alexey Proskuryakov.
1427
1428         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1429
1430         * DumpRenderTree/mac/EventSendingController.mm:
1431         (-[EventSendingController mouseMoveToX:Y:]):
1432         * WebKitTestRunner/mac/EventSenderProxy.mm:
1433         (WTR::EventSenderProxy::mouseMoveTo):
1434
1435 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1436
1437         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1438         https://bugs.webkit.org/show_bug.cgi?id=167774
1439
1440         Reviewed by Tim Horton.
1441
1442         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1443         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1444         web process are async, so the callback fires after the web process gets the new state.
1445
1446         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1447         (WTR::UIScriptController::removeViewFromWindow):
1448         (WTR::UIScriptController::addViewToWindow):
1449         * DumpRenderTree/mac/DumpRenderTree.mm:
1450         (createWebViewAndOffscreenWindow):
1451         (resetWebViewToConsistentStateBeforeTesting):
1452         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1453         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1454         (WTR::UIScriptController::removeViewFromWindow):
1455         (WTR::UIScriptController::addViewToWindow):
1456         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1457         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1458         (WTR::UIScriptController::removeViewFromWindow):
1459         (WTR::UIScriptController::addViewToWindow):
1460         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1461         * WebKitTestRunner/PlatformWebView.h:
1462         * WebKitTestRunner/TestController.cpp:
1463         (WTR::TestController::resetStateToConsistentValues):
1464         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1465         (WTR::PlatformWebView::removeFromWindow):
1466         (WTR::PlatformWebView::addToWindow):
1467         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1468         (WTR::UIScriptController::removeViewFromWindow):
1469         (WTR::UIScriptController::addViewToWindow):
1470         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1471         (WTR::PlatformWebView::removeFromWindow):
1472         (WTR::PlatformWebView::addToWindow):
1473         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1474         (WTR::UIScriptController::removeViewFromWindow):
1475         (WTR::UIScriptController::addViewToWindow):
1476
1477 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1478
1479         Remove check for SkipSafariExecutableEntitlementChecks
1480         https://bugs.webkit.org/show_bug.cgi?id=167762
1481
1482         Reviewed by Dan Bernstein.
1483
1484         Follow-up fix: don't break internal behavior.
1485
1486         * Scripts/webkitdirs.pm:
1487         (safariPath):
1488         (executableHasEntitlements): Deleted.
1489         (safariPathFromSafariBundle): Deleted.
1490         (installedSafariPath): Deleted.
1491
1492 2017-02-03  Daniel Bates  <dabates@apple.com>
1493
1494         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1495         https://bugs.webkit.org/show_bug.cgi?id=167810
1496         <rdar://problem/30102568>
1497
1498         Reviewed by Anders Carlsson.
1499
1500         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1501
1502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1503         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1504         (TEST):
1505         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1506         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1507         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1508         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1509
1510 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1511
1512         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1513         https://bugs.webkit.org/show_bug.cgi?id=167773
1514         <rdar://problem/30221102>
1515
1516         Reviewed by Ryosuke Niwa.
1517
1518         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1519         (TestWebKitAPI::TEST_F):
1520
1521 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1522
1523         Remove check for SkipSafariExecutableEntitlementChecks
1524         https://bugs.webkit.org/show_bug.cgi?id=167762
1525         rdar://problem/22480673
1526
1527         Reviewed by Dan Bernstein.
1528
1529         * Scripts/webkitdirs.pm:
1530         (safariPathFromSafariBundle):
1531         (skipSafariExecutableEntitlementChecks): Deleted.
1532
1533 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1534
1535         Undefined subroutine in svn-create-patch
1536         https://bugs.webkit.org/show_bug.cgi?id=167742
1537
1538         Unreviewed build-fix after r211543.
1539
1540         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1541
1542 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1543
1544         Unreviewed. Fix jhbuild dependencies build.
1545
1546         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1547         Patch updated.
1548
1549 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1550
1551         [EME][GStreamer] Fixed decryptor selection
1552         https://bugs.webkit.org/show_bug.cgi?id=167588
1553
1554         Reviewed by Žan Doberšek.
1555
1556         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1557
1558         * gtk/jhbuild.modules: Added patches to gstreamer and
1559         gst-plugins-good packages.
1560         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1561         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1562
1563 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1564
1565         Make run-benchmark script supports 'config' key in test plan.
1566         https://bugs.webkit.org/show_bug.cgi?id=167715
1567
1568         Reviewed by Ryosuke Niwa.
1569
1570         Add support for 'config' key in test paln.
1571         'config' key is a dictionary that specifies environment configurations while test is running.
1572         Specifies orientation to be portrait in MotionMark benchmark.
1573
1574         * Scripts/webkitpy/benchmark_runner/README.md:
1575         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1576         (BenchmarkRunner.__init__):
1577         (BenchmarkRunner._run_benchmark):
1578         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1579         (BrowserDriver.prepare_env):
1580         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1581         (LinuxBrowserDriver.prepare_env):
1582         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1583         (OSXBrowserDriver.prepare_env):
1584         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1585         (OSXSafariDriver.prepare_env):
1586         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1587
1588 2017-02-01  Daniel Bates  <dabates@apple.com>
1589
1590         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1591         https://bugs.webkit.org/show_bug.cgi?id=167169
1592
1593         Reviewed by David Kilzer.
1594
1595         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1596         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1597         header from the output of "svn diff" on a file that was copied or moved.
1598
1599         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1600         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1601         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1602         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1603         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1604         of a file with only a property change also does not contain any chunk range lines. Therefore
1605         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1606         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1607         we should directly test for the presence of a leading SVN diff header with an empty body and
1608         remove such lines from the diff.
1609
1610         * Scripts/VCSUtils.pm:
1611         (fixSVNPatchForAdditionWithHistory): Added.
1612         * Scripts/svn-create-patch:
1613         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1614         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1615         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1616
1617 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1618
1619         [Mac] Update CARingBuffer class
1620         https://bugs.webkit.org/show_bug.cgi?id=167656
1621
1622         Reviewed by Jer Noble.
1623
1624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1625         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1626         (TestWebKitAPI::CARingBufferTest::SetUp):
1627         (TestWebKitAPI::CARingBufferTest::setup):
1628         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1629         (TestWebKitAPI::CARingBufferTest::description):
1630         (TestWebKitAPI::CARingBufferTest::bufferList):
1631         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1632         (TestWebKitAPI::CARingBufferTest::capacity):
1633         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1634         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1635         (TestWebKitAPI::TEST_F):
1636         (TestWebKitAPI::MixingTest::run):
1637
1638 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1639
1640         [Mac] TestWebKitAPI includes system frameworks incorrectly
1641         https://bugs.webkit.org/show_bug.cgi?id=167703
1642         rdar://problem/30301498
1643
1644         Reviewed by Ryosuke Niwa.
1645
1646         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1647         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1648
1649         Also, reduced the number of subframework search paths, looks like we only need one now.
1650
1651         * TestWebKitAPI/Configurations/Base.xcconfig:
1652
1653 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1654
1655         Correct "filesHaveSameVolume" predicate
1656         https://bugs.webkit.org/show_bug.cgi?id=167696
1657         <rdar://problem/30298722>
1658
1659         Reviewed by David Kilzer.
1660
1661         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1662         percent-escaped path inputs.
1663
1664         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1665         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1666         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1667         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1668         (TestWebKitAPI::TEST_F):
1669
1670 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1671
1672         Unreviewed. Fix coding style in MiniBrowser
1673
1674         * MiniBrowser/gtk/BrowserWindow.c:
1675         (editingCommandCallback):
1676         (insertImageCommandCallback):
1677         (insertLinkCommandCallback):
1678
1679 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1680
1681         [GTK] Add an API to add a custom tab into the print dialog
1682         https://bugs.webkit.org/show_bug.cgi?id=151998
1683
1684         Reviewed by Carlos Garcia Campos.
1685
1686         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1687         that is testing a newly added API.
1688
1689         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1690         (testPrintCustomWidget):
1691         (beforeAll):
1692
1693 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1694
1695         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1696         https://bugs.webkit.org/show_bug.cgi?id=166529
1697
1698         Reviewed by Xabier Rodriguez-Calvar.
1699
1700         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1701         New patch version accepted in GStreamer upstream.
1702
1703 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1704
1705         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1706         https://bugs.webkit.org/show_bug.cgi?id=167498
1707
1708         Reviewed by Carlos Garcia Campos.
1709
1710         Depending on the distro version you can need either libxfont1-dev
1711         or libfont-dev to build with jhbuild.
1712
1713         * gtk/install-dependencies:
1714
1715 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1716
1717         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1718         https://bugs.webkit.org/show_bug.cgi?id=167594
1719
1720         Unreviewed test gardening.
1721
1722         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1723
1724         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1725         (TEST):
1726
1727 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1728
1729         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1730         https://bugs.webkit.org/show_bug.cgi?id=167676
1731
1732         Reviewed by Saam Barati.
1733
1734         * Scripts/run-javascriptcore-tests:
1735         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1736
1737 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1738
1739         Make Dump Render Tree not crash
1740         https://bugs.webkit.org/show_bug.cgi?id=167667
1741
1742         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1743         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1744         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1745         This does not fix any tests, it just fixes the crash.
1746         
1747         Reviewed by Simon Fraser.
1748
1749         * DumpRenderTree/TestRunner.cpp:
1750         (TestRunner::callUIScriptCallback):
1751
1752 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1753
1754         Workaround for simctl install failing to report install failure
1755         https://bugs.webkit.org/show_bug.cgi?id=167654
1756
1757         Reviewed by Daniel Bates.
1758
1759         simctl install will sometimes report success even though install has failed.
1760         To workaround this bug, we attempt an app launch after install to ensure
1761         install has succeeded.
1762
1763         * Scripts/webkitpy/xcode/simulator.py:
1764         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1765         (Device.launch_app): Correct comment.
1766
1767 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1768
1769         Unreviewed webkitpy fix after r211405.
1770
1771         * Scripts/webkitpy/xcode/simulator.py:
1772         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1773
1774 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1775
1776         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1777
1778         * gtk/manifest.txt.in:
1779
1780 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1781
1782         AX: enable search predication for iOS
1783         https://bugs.webkit.org/show_bug.cgi?id=167558
1784         <rdar://problem/30251367>
1785
1786         Reviewed by Joanmarie Diggs.
1787
1788         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1789         (AccessibilityUIElement::uiElementForSearchPredicate):
1790         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1791         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1792         (searchPredicateParameterizedAttributeForSearchCriteria):
1793         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1794         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1795         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1796         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1797         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1798         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1799         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1800         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1801         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1802         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1803         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1804
1805 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1806
1807         Workaround for simctl launch bug
1808         https://bugs.webkit.org/show_bug.cgi?id=167613
1809
1810         Reviewed by Daniel Bates.
1811
1812         simctl launch will sometimes fail because of a race condition when many
1813         simulators are being run simultaneously. These failures will always have
1814         an exit code of 1. This change attempts to launch an app multiple times
1815         before reporting a failure to workaround this bug.
1816
1817         * Scripts/webkitpy/xcode/simulator.py:
1818         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1819
1820 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1821
1822         Commit queue fails to look at real name aliases for the reviewer
1823         https://bugs.webkit.org/show_bug.cgi?id=167422
1824
1825         Reviewed by Joseph Pecoraro.
1826
1827         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1828         (test_has_valid_reviewer): Added tests.
1829
1830         * Scripts/webkitpy/common/config/committers.py:
1831         (CommitterList._name_to_contributor_map):
1832         Made _name_to_contributor_map include alias names.
1833
1834         * Scripts/webkitpy/common/config/committers_unittest.py:
1835         (CommittersTest.test_contributors_by_fuzzy_match):
1836         Removed subtests that are now obsolete, as these matches are strict. It is not
1837         obvious if distance based fuzzy matching for names is useful at all, but we can
1838         look into that some other time.
1839
1840 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1841
1842         QueueStatusServer should have an explicit timeout for _fetch_url
1843         https://bugs.webkit.org/show_bug.cgi?id=167467
1844
1845         Reviewed by Alexey Proskuryakov.
1846
1847         * Scripts/webkitpy/common/net/statusserver.py:
1848         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1849
1850 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1851
1852         Add support for Trac instances that host multiple projects.
1853         https://bugs.webkit.org/show_bug.cgi?id=167524
1854
1855         Reviewed by Alexey Proskuryakov.
1856
1857         When multiple projects are hosted on a single Trac instance, the current
1858         behavior will retrieve changesets from all tracked projects.
1859         This patch teaches Trac.js to get project-specific changesets from Trac.
1860         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1861         when querying the Trac timeline.
1862
1863         To tell Trac to be aware of multi-project instances we leverage the 
1864         `options` parameter when creating a new instance: 
1865
1866             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1867
1868         If this option is not provided, the original behaviour will prevail.
1869         Additionally, add corresponding tests.
1870
1871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1872         (Trac): Reason about new optional parameter 'projectIdentifier'.
1873         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1874         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1875         replace default parameter `changeset=on` with `repo-projectname=on`.
1876         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1877         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1878         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1880         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1881         Add the following tests:
1882             test("revisionURL")
1883             test("revisionURL with Trac Identifier")
1884             test("_xmlTimelineURL")
1885             test("_xmlTimelineURL with Trac Identifier")
1886         (this.view._latestProductiveIteration): Fix missing ';'.
1887
1888 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1889
1890         Correct spacing regression on inter-element complex path shaping on some fonts
1891         https://bugs.webkit.org/show_bug.cgi?id=166013
1892
1893         Reviewed by Simon Fraser.
1894
1895         Unskip existing tests and make some new tests:
1896         - Testing complex text with no origins
1897         - Testing initial expansions
1898         - Testing the sign of vertical advances
1899
1900         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1901         (TestWebKitAPI::TEST_F):
1902
1903 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1904
1905         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1906         https://bugs.webkit.org/show_bug.cgi?id=167596
1907
1908         Reviewed by Daniel Bates.
1909
1910         We avoid needing a thin directory by invoking the zip program with
1911         the list of directories from the build directory to be zipped,
1912         and by using the zip feature to exclude files matching a pattern.
1913
1914         * BuildSlaveSupport/built-product-archive:
1915         (copyBuildFiles):
1916         (createZipFromList):
1917         (archiveBuiltProduct):
1918
1919 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1920
1921         Use simctl instead of LayoutTestRelay
1922         https://bugs.webkit.org/show_bug.cgi?id=165927
1923
1924         Reviewed by Daniel Bates.
1925
1926         Part 1
1927
1928         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1929         simulators through simctl (iOS 10 and later), use this functionality instead.
1930
1931         * Scripts/webkitpy/port/base.py:
1932         (Port.__init__): Added _test_runner_process_constructor.
1933         * Scripts/webkitpy/port/darwin.py:
1934         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1935         * Scripts/webkitpy/port/driver.py:
1936         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1937         (IOSSimulatorDriver): Deleted.
1938         * Scripts/webkitpy/port/driver_unittest.py:
1939         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1940         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1941         (DriverTest.test_start_actually_starts): Ditto.
1942         * Scripts/webkitpy/port/ios.py:
1943         (IOSSimulatorPort): Remove relay_name.
1944         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1945         (IOSSimulatorPort._create_simulators): Formatting change.
1946         (IOSSimulatorPort.relay_path): Deleted.
1947         (IOSSimulatorPort._check_relay): Deleted.
1948         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1949         (IOSSimulatorPort._build_relay): Deleted.
1950         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1951         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1952         * Scripts/webkitpy/port/ios_unittest.py:
1953         (iosTest.test_32bit): Update test.
1954         (iosTest.test_64bit): Update test.
1955         * Scripts/webkitpy/port/server_process.py:
1956         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1957         (ServerProcess._set_file_nonblocking): Added to share common code.
1958         * Scripts/webkitpy/port/server_process_mock.py:
1959         (MockServerProcess.__init__): Added argument worker_number.
1960         * Scripts/webkitpy/port/simulator_process.py: Added.
1961         (SimulatorProcess): Added.
1962         (SimulatorProcess.Popen): Added.
1963         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1964         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1965         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1966         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1967         (SimulatorProcess._reset): Added. Unlink fifos.
1968         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1969         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1970         * Scripts/webkitpy/xcode/simulator.py:
1971         (Device.__init__): Accept host to run install/launch/terminate.
1972         (Device.install_app): Install app to target Device.
1973         (Device.launch_app): Launch app on target Device.
1974         (Device.terminate_app): Shutdown app on target Device.
1975         (Simulator._parse_devices): Pass host to Device.
1976
1977 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1978
1979         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1980         https://bugs.webkit.org/show_bug.cgi?id=167411
1981
1982         Reviewed by Michael Catanzaro.
1983
1984         Disable the ARM iwMMXt fast path for pixman, because it triggers
1985         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1986
1987         * gtk/jhbuild.modules:
1988
1989 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1990
1991         [GTK] Add API to handle the accelerated compositing policy
1992         https://bugs.webkit.org/show_bug.cgi?id=167509
1993
1994         Reviewed by Michael Catanzaro.
1995
1996         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1997         as a special case. Also add test cases to the get/set API.
1998
1999         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2000         (hardwareAccelerationPolicyToString):
2001         (stringToHardwareAccelerationPolicy):
2002         (cellRendererChanged):
2003         (browserSettingsDialogConstructed):
2004         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2005         (testWebKitSettings):
2006
2007 2017-01-29  Andy Estes  <aestes@apple.com>
2008
2009         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2010         https://bugs.webkit.org/show_bug.cgi?id=167563
2011         <rdar://problem/30253207>
2012
2013         Reviewed by Andreas Kling.
2014
2015         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2016         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2017         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2018         (runTest):
2019         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2020         (TEST):
2021
2022 2017-01-29  Dan Bernstein  <mitz@apple.com>
2023
2024         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2025         https://bugs.webkit.org/show_bug.cgi?id=167565
2026
2027         Reviewed by Sam Weinig.
2028
2029         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2030         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2031         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2032         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2033         (TEST):
2034         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2035         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2036         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2037         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2038
2039 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2040
2041         Add Link Preload as an off-by-default experimental feature menu item.
2042         https://bugs.webkit.org/show_bug.cgi?id=167201
2043
2044         Reviewed by Ryosuke Niwa.
2045
2046         * DumpRenderTree/mac/DumpRenderTree.mm:
2047         (resetWebPreferencesToConsistentValues):
2048         * DumpRenderTree/win/DumpRenderTree.cpp:
2049         (resetWebPreferencesToConsistentValues):
2050
2051 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2052
2053         Add User Timing Experimental Feature
2054         https://bugs.webkit.org/show_bug.cgi?id=167542
2055         <rdar://problem/22746307>
2056
2057         Reviewed by Ryosuke Niwa.
2058
2059         * DumpRenderTree/mac/DumpRenderTree.mm:
2060         (enableExperimentalFeatures):
2061         (resetWebPreferencesToConsistentValues):
2062         * DumpRenderTree/win/DumpRenderTree.cpp:
2063         (enableExperimentalFeatures):
2064
2065 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2066
2067         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2068         https://bugs.webkit.org/show_bug.cgi?id=167519
2069
2070         Reviewed by Ryosuke Niwa.
2071
2072         * QueueStatusServer/templates/statusbubble.html:
2073         To measure the bubbleContainer's width, it must not be wrapping based
2074         on its parent container. So when measuring the width temporarily set
2075         the parent to a very large width so as to not artificially wrap us.
2076         Restore the parent's width after measuring.
2077
2078 2017-01-27  Andy Estes  <aestes@apple.com>
2079
2080         [iOS] Add a test for _WKNSFileManagerExtras
2081         https://bugs.webkit.org/show_bug.cgi?id=167478
2082
2083         Reviewed by Andreas Kling.
2084
2085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2086         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2087         (expectAttributes):
2088         (TEST):
2089
2090 2017-01-27  Keith Miller  <keith_miller@apple.com>
2091
2092         run-benchmarks should make sure it passes the test url to the right application
2093         https://bugs.webkit.org/show_bug.cgi?id=167533
2094
2095         Reviewed by Joseph Pecoraro.
2096
2097         This fixes an issue when trying to run-benchmark script with the
2098         system default browser set to STP. Previously, it would run
2099         the test in STP rather than the provided build. Now, it should run
2100         in the provided build.
2101
2102         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2103         (OSXSafariDriver.launch_url):
2104
2105 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2106
2107         [Cocoa] Prepare ComplexTextController for unit testing
2108         https://bugs.webkit.org/show_bug.cgi?id=167493
2109
2110         Reviewed by Simon Fraser.
2111
2112         Addressing post-review comments from Simon Fraser.
2113
2114         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2115         (TestWebKitAPI::TEST_F):
2116
2117 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2118
2119         [Cocoa] Prepare ComplexTextController for unit testing
2120         https://bugs.webkit.org/show_bug.cgi?id=167493
2121
2122         Reviewed by Dean Jackson.
2123
2124         Create four unit tests.
2125
2126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2127         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2128         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2129         (TestWebKitAPI::TEST_F):
2130
2131 2017-01-26  Chris Dumez  <cdumez@apple.com>
2132
2133         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2134         https://bugs.webkit.org/show_bug.cgi?id=167421
2135         <rdar://problem/30188490>
2136
2137         Reviewed by Darin Adler.
2138
2139         Add a new setting allowing layout tests to enable PageCache in a window
2140         that has an opener, for convenience.
2141
2142         * DumpRenderTree/mac/DumpRenderTree.mm:
2143         (resetWebPreferencesToConsistentValues):
2144         * DumpRenderTree/win/DumpRenderTree.cpp:
2145         (resetWebPreferencesToConsistentValues):
2146         * WebKitTestRunner/TestController.cpp:
2147         (WTR::TestController::resetPreferencesToConsistentValues):
2148
2149 2017-01-26  Keith Miller  <keith_miller@apple.com>
2150
2151         classInfo should take a VM so it is not materialized from the object on each call
2152         https://bugs.webkit.org/show_bug.cgi?id=167424
2153
2154         Rubber Stamped by Michael Saboff.
2155
2156         Previously, classInfo() would get the VM from the target's
2157         MarkedBlock.  Most callers already have a VM on hand, so it is
2158         wasteful to compute the VM from the marked block every time. This
2159         patch refactors some of the most common callers of classInfo(),
2160         jsDynamicCast and inherits to take a VM as well.
2161
2162         * DumpRenderTree/TestRunner.cpp:
2163         (setAudioResultCallback):
2164
2165 2017-01-26  Jer Noble  <jer.noble@apple.com>
2166
2167         Autoplay muted videos stop playback of any streaming app in the background
2168         https://bugs.webkit.org/show_bug.cgi?id=163993
2169         <rdar://problem/29020431>
2170
2171         Reviewed by Eric Carlson.
2172
2173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2174         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2177
2178 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2179
2180         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2181         https://bugs.webkit.org/show_bug.cgi?id=167466
2182
2183         Unreviewed test gardening.
2184
2185         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2186         (TEST):
2187
2188 2017-01-26  Matt Rajca  <mrajca@apple.com>
2189
2190         Notify clients when the user plays media otherwise prevented from autoplaying
2191         https://bugs.webkit.org/show_bug.cgi?id=167390
2192
2193         Reviewed by Alex Christensen.
2194
2195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2196         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2197         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2198         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2199         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2200         (TEST):
2201         * TestWebKitAPI/cocoa/TestWKWebView.h:
2202         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2203         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2204         (-[TestWKWebView waitForLoad]):
2205         (-[TestWKWebView mouseUpAtPoint:]):
2206         * WebKitTestRunner/TestController.cpp:
2207         (WTR::TestController::createOtherPage):
2208         (WTR::TestController::createWebViewWithOptions):
2209
2210 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2211
2212         Crash when setting custom scale factor.
2213         https://bugs.webkit.org/show_bug.cgi?id=167369
2214
2215         Reviewed by Sam Weinig.
2216
2217         Added API test.
2218
2219         * TestWebKitAPI/PlatformWin.cmake:
2220         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2221         (TestWebKitAPI::WebKitCreateInstance):
2222         (TestWebKitAPI::ScaleWebView::SetUp):
2223         (TestWebKitAPI::ScaleWebView::TearDown):
2224         (TestWebKitAPI::TEST_F):
2225
2226 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2227
2228         run-benchmark nests MotionMark results by the suite name twice
2229         https://bugs.webkit.org/show_bug.cgi?id=164948
2230
2231         Reviewed by Said Abou-Hallawa.
2232
2233         Use a single level MotionMark now that this is the name of the benchmark,
2234         and we no longer have tests that aren't part of the MotionMark suite.
2235
2236         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2237
2238 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2239
2240         Unreviewed, rolling out r211193.
2241
2242         This change broke internal builds.
2243
2244         Reverted changeset:
2245
2246         "Notify clients when the user plays media otherwise prevented
2247         from autoplaying"
2248         https://bugs.webkit.org/show_bug.cgi?id=167390
2249         http://trac.webkit.org/changeset/211193
2250
2251 2017-01-25  Matt Rajca  <mrajca@apple.com>
2252
2253         Notify clients when the user plays media otherwise prevented from autoplaying
2254         https://bugs.webkit.org/show_bug.cgi?id=167390
2255
2256         Reviewed by Alex Christensen.
2257
2258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2259         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2260         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2261         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2262         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2263         (TEST):
2264         * TestWebKitAPI/cocoa/TestWKWebView.h:
2265         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2266         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2267         (-[TestWKWebView waitForLoad]):
2268         (-[TestWKWebView mouseUpAtPoint:]):
2269         * WebKitTestRunner/TestController.cpp:
2270         (WTR::TestController::createOtherPage):
2271         (WTR::TestController::createWebViewWithOptions):
2272
2273 2017-01-25  Matt Rajca  <mrajca@apple.com>
2274
2275         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2276         https://bugs.webkit.org/show_bug.cgi?id=167385
2277
2278         Reviewed by Alex Christensen.
2279
2280         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2281         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2282         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2283         (TEST): Allow inline (rather than full screen) media playback on iOS.
2284
2285 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2286
2287         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2288         https://bugs.webkit.org/show_bug.cgi?id=167414
2289
2290         Reviewed by Michael Catanzaro.
2291
2292         Add a test case to check ephemeral web views don't write favicons to the database.
2293
2294         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2295         (ephemeralViewLoadChanged):
2296         (testPrivateBrowsing):
2297         (testFaviconDatabase):
2298
2299 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2300
2301         [GTK] Add a private browsing mode to MiniBrowser
2302         https://bugs.webkit.org/show_bug.cgi?id=167413
2303
2304         Reviewed by Michael Catanzaro.
2305
2306         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2307         private windows, even on non-private instances.
2308
2309         * MiniBrowser/gtk/BrowserWindow.c:
2310         (webViewTitleChanged): Add [Private] to title window for private windows.
2311         (webViewCreate): Pass web context to browser_window_new.
2312         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2313         (browserWindowFinalize): Disconnect web context signal handlers.
2314         (browser_window_init): Add shortcut for opening private window.
2315         (browser_window_new): It now receives the context and connect to download-started here.
2316         (browser_window_get_web_context): Return the context.
2317         * MiniBrowser/gtk/BrowserWindow.h:
2318         * MiniBrowser/gtk/main.c:
2319         (createBrowserTab): Create the web view for the window web context.
2320         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2321         (aboutDataHandleRequest): Ditto.
2322         (aboutURISchemeRequestCallback): Ditto.
2323         (main): Create ephemeral web context if private command line option is used.
2324
2325 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2326
2327         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2328         https://bugs.webkit.org/show_bug.cgi?id=167409
2329
2330         Reviewed by Antti Koivisto.
2331
2332         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2333         as well as tests for the newly added matchingElementInFlatTree.
2334
2335         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2336         (TestWebKitAPI::runJavaScriptAlert):
2337         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2338         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2339         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2340
2341 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2342
2343         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2344         https://bugs.webkit.org/show_bug.cgi?id=167370
2345
2346         Reviewed by Michael Catanzaro.
2347
2348         Add several test cases of ephemeral web views.
2349
2350         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2351         (testWebViewAuthenticationStorage):
2352         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2353         (ephemeralViewloadChanged):
2354         (testCookieManagerEphemeral):
2355         (beforeAll):
2356         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2357         (testWebKitSettings):
2358         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2359         (testWebContextEphemeral):
2360         (ephemeralViewloadChanged):
2361         (testWebContextProxySettings):
2362         (beforeAll):
2363         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2364         (ephemeralViewloadChanged):
2365         (testWebViewEphemeral):
2366         (beforeAll):
2367         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2368         (ephemeralViewloadChanged):
2369         (testWebsiteDataEphemeral):
2370         (beforeAll):
2371
2372 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2373
2374         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2375         https://bugs.webkit.org/show_bug.cgi?id=167402
2376
2377         Reviewed by Ryosuke Niwa.
2378
2379         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2380         (TestWebKitAPI::TEST):
2381
2382 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2383
2384         Add simple line layout toggle to MiniBrowser
2385         https://bugs.webkit.org/show_bug.cgi?id=167405
2386
2387         Reviewed by Andreas Kling.
2388
2389         * MiniBrowser/mac/SettingsController.h:
2390         * MiniBrowser/mac/SettingsController.m:
2391         (-[SettingsController _populateMenu]):
2392         (-[SettingsController validateMenuItem:]):
2393         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2394         (-[SettingsController simpleLineLayoutEnabled]):
2395         * MiniBrowser/mac/WK1BrowserWindowController.m:
2396         (-[WK1BrowserWindowController didChangeSettings]):
2397         * MiniBrowser/mac/WK2BrowserWindowController.m:
2398         (-[WK2BrowserWindowController didChangeSettings]):
2399
2400 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2401
2402         WKR does not include my nick when commit-queue lands my patch
2403         https://bugs.webkit.org/show_bug.cgi?id=167388
2404
2405         Reviewed by Ryosuke Niwa.
2406
2407         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2408         (NewCommitBot._summarize_commit_log):
2409         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2410         Perform nickname insertion before grabbing "Patch by" details.
2411         This way we can include the nickname with the full name.
2412
2413 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2414
2415         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2416         https://bugs.webkit.org/show_bug.cgi?id=167394
2417
2418         Reviewed by Ryosuke Niwa.
2419
2420         * Scripts/webkitperl/FeatureList.pm:
2421         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2422
2423 2017-01-24  Youenn Fablet  <youenn@apple.com>
2424
2425         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2426         https://bugs.webkit.org/show_bug.cgi?id=167353
2427
2428         Reviewed by Alex Christensen.
2429
2430         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2431         (CMakeGenerator.initialize_targets):
2432
2433 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2434
2435         WKR should not confuse Miguel Gomez with Andres Gomez
2436         https://bugs.webkit.org/show_bug.cgi?id=167389
2437
2438         Reviewed by Lucas Forschler.
2439
2440         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2441         "mAndres Gomez". Fix this.
2442
2443         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2444         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2445         space on each side of the email address, so expect both spaces to be there before
2446         considering the email for replacement.
2447         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2448
2449 2017-01-24  Matt Rajca  <mrajca@apple.com>
2450
2451         Pass down website autoplay policies to media elements
2452         https://bugs.webkit.org/show_bug.cgi?id=167355
2453
2454         Reviewed by Alex Christensen.
2455
2456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2457         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2458         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2459         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2460         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2461         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2462         (TEST):
2463
2464 2017-01-24  Nan Wang  <n_wang@apple.com>
2465
2466         AX: Speak Selection does not work in an iframe
2467         https://bugs.webkit.org/show_bug.cgi?id=166794
2468         <rdar://problem/29913013>
2469
2470         Reviewed by Chris Fleizach.
2471
2472         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2473         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2474         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2475         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2476         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2477         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2478         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2479         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2480         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2481         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2482         (-[TestRunnerWKWebView dealloc]):
2483         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2484         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2485         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2486         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2487         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2488
2489 2017-01-24  Daniel Bates  <dabates@apple.com>
2490
2491         StringView.split() should use an iterator design pattern instead of allocating a Vector
2492         https://bugs.webkit.org/show_bug.cgi?id=163225
2493
2494         Reviewed by Darin Adler.
2495
2496         Add unit tests for StringView.split().
2497
2498         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2499         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2500         used in the StringView.split() unit tests.
2501         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2502         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2503         object to a Vector of String objects.
2504         (TestWebKitAPI::TEST): Added the following tests:
2505             - WTF.StringViewSplitEmptyAndNullStrings
2506             - WTF.StringViewSplitBasic
2507             - WTF.StringViewSplitWithConsecutiveSeparators
2508
2509 2017-01-23  Anders Carlsson  <andersca@apple.com>
2510
2511         The Score Esports crashes on launch
2512         https://bugs.webkit.org/show_bug.cgi?id=167338
2513         rdar://problem/29948645
2514
2515         Reviewed by Dan Bernstein.
2516
2517         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2518         (TestWebKitAPI::TEST):
2519         Add a test.
2520
2521 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2522
2523         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2524         https://bugs.webkit.org/show_bug.cgi?id=146589
2525
2526         Reviewed by Michael Catanzaro.
2527
2528         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2529         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2530
2531         * MiniBrowser/gtk/BrowserWindow.c:
2532         (webViewDecidePolicy):
2533         (newTabCallback):
2534         * MiniBrowser/gtk/main.c:
2535         (createBrowserTab):
2536         (aboutDataRequestFree):
2537         (aboutDataRequestNew):
2538         (aboutDataRequestForView):
2539         (websiteDataRemovedCallback):
2540         (websiteDataClearedCallback):
2541         (aboutDataScriptMessageReceivedCallback):
2542         (domainListFree):
2543         (aboutDataFillTable):
2544         (gotWebsiteDataCallback):
2545         (aboutDataHandleRequest):
2546         (aboutURISchemeRequestCallback):
2547         (main):
2548         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2549         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2550         (serverCallback):
2551         (beforeAll):
2552         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2553         (serverCallback):
2554         (WebsiteDataTest::WebsiteDataTest):
2555         (WebsiteDataTest::~WebsiteDataTest):
2556         (WebsiteDataTest::fetch):
2557         (WebsiteDataTest::remove):
2558         (WebsiteDataTest::clear):
2559         (testWebsiteDataConfiguration):
2560         (testWebsiteDataCache):
2561         (testWebsiteDataStorage):
2562         (testWebsiteDataDatabases):
2563         (testWebsiteDataAppcache):
2564         (beforeAll):
2565         (afterAll):
2566
2567 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2568
2569         Unreviewed, rolling out r211062.
2570         https://bugs.webkit.org/show_bug.cgi?id=167354
2571
2572         broke API tests (Requested by alexchristensen on #webkit).
2573
2574         Reverted changeset:
2575
2576         "Pass down website autoplay policies to media elements"
2577         https://bugs.webkit.org/show_bug.cgi?id=167132
2578         http://trac.webkit.org/changeset/211062
2579
2580 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2581
2582         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2583         https://bugs.webkit.org/show_bug.cgi?id=167330
2584
2585         Reviewed by Tim Horton.
2586
2587         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2588         (TestWebKitAPI::TEST_F):
2589
2590 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2591
2592         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2593         https://bugs.webkit.org/show_bug.cgi?id=167317
2594
2595         Reviewed by Sam Weinig.
2596
2597         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2598         (TestWebKitAPI::TEST_F):
2599
2600 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2601
2602         svn-create-patch should emit properties when files are moved or copied
2603         https://bugs.webkit.org/show_bug.cgi?id=167264
2604
2605         Reviewed by Daniel Bates.
2606
2607         * Scripts/svn-create-patch:
2608         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2609
2610 2017-01-23  Youenn Fablet  <youenn@apple.com>
2611
2612         [WebRTC] Filter libwebrtc link flags
2613         https://bugs.webkit.org/show_bug.cgi?id=167287
2614
2615         Reviewed by Alex Christensen.
2616
2617         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2618         (CMakeGenerator._compute_link_flags):
2619         (CMakeGenerator._compute_link_flags.keep_flag):
2620         (CMakeGenerator._generate_compile_target_options):
2621
2622 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2623
2624         [WebRTC] Make VP8 optional in libwebrtc
2625         https://bugs.webkit.org/show_bug.cgi?id=167257
2626
2627         Reviewed by Darin Adler.
2628
2629         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2630         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2631
2632 2017-01-23  Jer Noble  <jer.noble@apple.com>
2633
2634         Video details does not apear and missing scrubber in Control Center
2635         https://bugs.webkit.org/show_bug.cgi?id=167233
2636
2637         Reviewed by Alex Christensen.
2638
2639         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2640         NowPlayingControlTests for iOS.
2641
2642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2643         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2644         (-[NowPlayingTestWebView setWindowVisible:]):
2645         (TestWebKitAPI::TEST):
2646         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2647         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2648         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2649         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2650         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2651         (SOFT_LINK_CLASS):
2652         (-[TestMessageHandler addMessage:withHandler:]):
2653         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2654         (__simulated_forceClickAssociatedEventsMask):
2655         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2656         (-[TestWKWebViewHostWindow isKeyWindow]):
2657         (-[TestWKWebViewHostWindow makeKeyWindow]):
2658         (-[TestWKWebViewHostWindow resignKeyWindow]):
2659         (-[TestWKWebView initWithFrame:]):
2660         (-[TestWKWebView initWithFrame:configuration:]):
2661         (-[TestWKWebView _setUpTestWindow:]):
2662         (-[TestWKWebView performAfterReceivingMessage:action:]):
2663         (-[TestWKWebView loadTestPageNamed:]):
2664         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2665         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2666         (-[TestWKWebView waitForMessage:]):
2667         (-[TestWKWebView performAfterLoading:]):
2668         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2669         (-[TestWKWebView typeCharacter:]):
2670
2671 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2672
2673         Unreviewed. Bring back gtk-doc error messages after r209981.
2674
2675         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2676         impossible to know what's wrong.
2677
2678         * gtk/gtkdoc.py:
2679         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2680
2681 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2682
2683         [WebRTC] Update build system to make G711 optional in libwebrtc
2684         https://bugs.webkit.org/show_bug.cgi?id=167256
2685
2686         Reviewed by Alex Christensen.
2687
2688         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2689         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2690
2691 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2692
2693         Cleanup RuntimeEnabledFeatures
2694         https://bugs.webkit.org/show_bug.cgi?id=167228
2695
2696         Reviewed by Simon Fraser.
2697
2698         * DumpRenderTree/mac/DumpRenderTree.mm:
2699         (enableExperimentalFeatures):
2700         (resetWebPreferencesToConsistentValues):
2701         (setWebPreferencesForTestOptions):
2702         (resetWebViewToConsistentStateBeforeTesting):
2703         * DumpRenderTree/win/DumpRenderTree.cpp:
2704         (enableExperimentalFeatures):
2705         (resetWebPreferencesToConsistentValues):
2706         More closely match WebKitTestRunner initialization of preferences
2707         for experimental features.
2708
2709 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2710
2711         Build Fix for Windows DumpRenderTree after r210976
2712         https://bugs.webkit.org/show_bug.cgi?id=167115
2713
2714         * DumpRenderTree/win/DumpRenderTree.cpp:
2715         (resetWebPreferencesToConsistentValues):
2716
2717 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2718
2719         Remove outdated ENABLE(CSP_NEXT) build flag
2720         https://bugs.webkit.org/show_bug.cgi?id=167252
2721
2722         Reviewed by Brent Fulgham.
2723
2724         * Scripts/webkitperl/FeatureList.pm:
2725         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2726
2727 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2728
2729         Build Fix for Windows DumpRenderTree after r210976
2730
2731         * DumpRenderTree/win/DumpRenderTree.cpp:
2732         (resetWebPreferencesToConsistentValues):
2733
2734 2017-01-20  Antoine Quint  <graouts@apple.com>
2735
2736         Web Animations should be off by default and enabled as an experimental feature
2737         https://bugs.webkit.org/show_bug.cgi?id=167115
2738         <rdar://problem/30048963>
2739
2740         Reviewed by Joseph Pecoraro.
2741
2742         Turn Web Animations on in DRT.
2743
2744         * DumpRenderTree/mac/DumpRenderTree.mm:
2745         (resetWebPreferencesToConsistentValues):
2746         * DumpRenderTree/win/DumpRenderTree.cpp:
2747         (resetWebPreferencesToConsistentValues):
2748
2749 2017-01-20  Youenn Fablet  <youenn@apple.com>
2750
2751         [WebRTC] Add libwebrtc build infrastructure
2752         https://bugs.webkit.org/show_bug.cgi?id=167207
2753
2754         Reviewed by Alex Christensen.
2755
2756         Adding a script doing the libwebrtc project json to CMake file conversion.
2757
2758         * Scripts/generate-libwebrtc-cmake: Added.
2759         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2760         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2761
2762 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2763
2764         Mini Browser: Show tooltip for Experimental Features
2765         https://bugs.webkit.org/show_bug.cgi?id=167225
2766
2767         Reviewed by Alex Christensen.
2768
2769         * MiniBrowser/mac/SettingsController.m:
2770         (-[SettingsController _populateMenu]):
2771         Include the full details string as a tooltip.
2772
2773 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2774
2775         [Win] Test output results should not be written twice.
2776         https://bugs.webkit.org/show_bug.cgi?id=167197
2777
2778         Reviewed by Brent Fulgham.
2779
2780         Prevent test output from being written twice by returning early from
2781         the dump() function, if it already has been called.
2782         This patch also adds a missing newline to a test output line. 
2783         
2784         * DumpRenderTree/win/DumpRenderTree.cpp:
2785         (dump):
2786
2787 2017-01-20  Antoine Quint  <graouts@apple.com>
2788
2789         [Modern Media Controls] Turn modern media controls on by default
2790         https://bugs.webkit.org/show_bug.cgi?id=165668
2791
2792         Reviewed by Dean Jackson.
2793
2794         Enabled modern media controls by default in test runners.
2795
2796         * DumpRenderTree/TestOptions.h:
2797         * WebKitTestRunner/TestOptions.h:
2798
2799 2017-01-19  Chris Dumez  <cdumez@apple.com>
2800
2801         iterable<> should be enabled on WK1
2802         https://bugs.webkit.org/show_bug.cgi?id=167221
2803         <rdar://problem/30108531>
2804
2805         Reviewed by Youenn Fablet.
2806
2807         * DumpRenderTree/mac/DumpRenderTree.mm:
2808         (resetWebPreferencesToConsistentValues):
2809         * DumpRenderTree/win/DumpRenderTree.cpp:
2810         (resetWebPreferencesToConsistentValues):
2811         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2812         (WTR::InjectedBundle::beginTesting):
2813         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2814         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2815         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2816
2817 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2818
2819         Ensure status server logs go to log file
2820         https://bugs.webkit.org/show_bug.cgi?id=167210
2821
2822         Reviewed by Alexey Proskuryakov.
2823
2824         * Scripts/webkitpy/common/net/statusserver.py:
2825         (StatusServer.next_work_item): Change log level from debug to info in
2826         order to facilitate deubgging issues.
2827         (StatusServer.update_work_items): Same.
2828
2829 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2830
2831         Additional selection tests and interpolation fix
2832         https://bugs.webkit.org/show_bug.cgi?id=167171
2833
2834         Reviewed by Simon Fraser.
2835
2836         We weren't adding the final event when interpolating event streams.
2837
2838         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2839         (-[HIDEventGenerator interpolatedEvents:]):
2840
2841 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2842
2843         [Cocoa] Variation fonts are erroneously disabled on iOS
2844         https://bugs.webkit.org/show_bug.cgi?id=167172
2845
2846         Reviewed by Simon Fraser.
2847
2848         OpenSource builders don't seem to understand sdk=embedded*.
2849
2850         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2851
2852 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2853
2854         Unreviewed. Fix GTK+ unit tests failing since r210531.
2855
2856         Avoid using paths to files that don't actually exist.
2857
2858         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2859         (testWebKitConsoleMessageNetworkError):
2860         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2861         (testContextMenuDefaultMenu):
2862         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2863         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2864         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2865
2866 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2867
2868         [GTK] Provide API to set proxy settings
2869         https://bugs.webkit.org/show_bug.cgi?id=128674
2870
2871         Reviewed by Michael Catanzaro.
2872
2873         Add tests for new proxy settings API.
2874
2875         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2876         (serverCallback):
2877         (ProxyTest::ProxyTest):
2878         (ProxyTest::~ProxyTest):
2879         (ProxyTest::loadURIAndGetMainResourceData):
2880         (ProxyTest::proxyServerPortAsString):
2881         (testWebContextProxySettings):
2882         (beforeAll):
2883
2884 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2885
2886         Add back my old email address so old commits will still match it.
2887
2888         * Scripts/webkitpy/common/config/contributors.json:
2889
2890 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2891
2892         Remove my old email address from contributors.json and watchlist.
2893
2894         * Scripts/validate-committer-lists:
2895         (CommitterListFromGit): Change the mapping to the correct email.
2896         * Scripts/webkitpy/common/config/contributors.json:
2897         * Scripts/webkitpy/common/config/watchlist:
2898
2899 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2900
2901         Unreviewed, rolling out r210848.
2902
2903         This change introduced media-related LayoutTest failures and
2904         crashes on macOS.
2905
2906         Reverted changeset:
2907
2908         "[Modern Media Controls] Turn modern media controls on by
2909         default"
2910         https://bugs.webkit.org/show_bug.cgi?id=165668
2911         http://trac.webkit.org/changeset/210848
2912
2913 2017-01-18  Andreas Kling  <akling@apple.com>
2914
2915         Document::securityOrigin() should return a reference.
2916         <https://webkit.org/b/167124>
2917
2918         Reviewed by Sam Weinig.
2919
2920         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2921         (TestWebKitAPI::TEST_F):
2922
2923 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2924
2925         [Win] Clipboard tests are flaky.
2926         https://bugs.webkit.org/show_bug.cgi?id=167088
2927
2928         Reviewed by Brent Fulgham.
2929
2930         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2931         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2932
2933         * DumpRenderTree/win/DumpRenderTree.cpp:
2934         (main):
2935
2936 2017-01-18  Antoine Quint  <graouts@apple.com>
2937
2938         [Modern Media Controls] Turn modern media controls on by default
2939         https://bugs.webkit.org/show_bug.cgi?id=165668
2940
2941         Reviewed by Dean Jackson.
2942
2943         Enabled modern media controls by default in test runners. 
2944
2945         * DumpRenderTree/TestOptions.h:
2946         * WebKitTestRunner/TestOptions.h:
2947
2948 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2949
2950         Unreviewed, rolling out r210834
2951         https://bugs.webkit.org/show_bug.cgi?id=165668
2952
2953         It introduced dozens of test timeouts.
2954
2955         Reverted changeset:
2956         "[Modern Media Controls] Turn modern media controls on by default"
2957         https://bugs.webkit.org/show_bug.cgi?id=165668
2958         http://trac.webkit.org/changeset/210834
2959
2960 2017-01-17  Antoine Quint  <graouts@apple.com>
2961
2962         [Modern Media Controls] Turn modern media controls on by default
2963         https://bugs.webkit.org/show_bug.cgi?id=165668
2964
2965         Reviewed by Dean Jackson.
2966
2967         Enabled modern media controls by default in test runners. 
2968
2969         * DumpRenderTree/TestOptions.h:
2970         * WebKitTestRunner/TestOptions.h:
2971
2972 2017-01-17  Chris Dumez  <cdumez@apple.com>
2973
2974         Document title changed twice when setting document.title
2975         https://bugs.webkit.org/show_bug.cgi?id=167065
2976
2977         Reviewed by Darin Adler.
2978
2979         Add WebKit2GTK API test that was written by Michael Catanzaro.
2980
2981         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2982         (testWebViewTitleChange):
2983         (beforeAll):
2984
2985 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2986
2987         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2988         https://bugs.webkit.org/show_bug.cgi?id=116551
2989         <rdar://problem/13949830>
2990
2991         Reviewed by Alex Christensen.
2992
2993         * Scripts/webkitperl/FeatureList.pm:
2994         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2995         that is part of the existing WEB_TIMING feature.
2996
2997         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2998
2999 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
3000
3001         'webkit-patch post' no longer works with moved/copied files
3002         https://bugs.webkit.org/show_bug.cgi?id=166914
3003         <rdar://problem/29979707>
3004
3005         Reviewed by Daniel Bates.
3006
3007         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
3008         file outputs only the "Index:" line with an empty body.  This workaround
3009         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
3010         public email list tracking this bug is below.
3011         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
3012         
3013
3014         * Scripts/svn-create-patch:
3015         (generateDiff): Ignore an "Index:" line with an empty body.
3016
3017 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3018
3019         Remove the REQUEST_ANIMATION_FRAME flag
3020         https://bugs.webkit.org/show_bug.cgi?id=156980
3021         <rdar://problem/25906849>
3022
3023         Reviewed by Simon Fraser.
3024
3025         * Scripts/webkitperl/FeatureList.pm:
3026         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3027
3028 2017-01-15  Sam Weinig  <sam@webkit.org>
3029
3030         Add the ability to use numbers in makeString()
3031         https://bugs.webkit.org/show_bug.cgi?id=167087
3032
3033         Reviewed by Darin Adler.
3034
3035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3036         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
3037         Add tests for StringConcatenate, focusing on new numeric additions.
3038
3039 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3040
3041         Unreviewed, remove stale comment.
3042
3043         This test was fixed by r163173.
3044
3045         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3046
3047 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3048
3049         Annotate large string tests with largeHeap
3050         https://bugs.webkit.org/show_bug.cgi?id=167054
3051
3052         Reviewed by Filip Pizlo.
3053
3054         * Scripts/run-javascriptcore-tests:
3055         * Scripts/run-jsc-stress-tests:
3056
3057 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3058
3059         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3060         https://bugs.webkit.org/show_bug.cgi?id=167043
3061
3062         Reviewed by Darin Adler.
3063
3064         * Scripts/webkitperl/FeatureList.pm:
3065
3066 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3067
3068         Remove ENABLE(DETAILS_ELEMENT) guards
3069         https://bugs.webkit.org/show_bug.cgi?id=167042
3070
3071         Reviewed by Alex Christensen.
3072
3073         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3074
3075 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
3076
3077         26 MotionMark performance tests failing
3078         https://bugs.webkit.org/show_bug.cgi?id=166854
3079
3080         Reviewed by Ryosuke Niwa.
3081
3082         Unrelated change. This is the last place that we need to rename Animometer
3083         to MotionMark.
3084
3085         * Scripts/webkitpy/common/config/watchlist:
3086
3087 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
3088
3089         run-jsc-benchmarks' echo should have -e option
3090         https://bugs.webkit.org/show_bug.cgi?id=167009
3091
3092         Reviewed by Sam Weinig.
3093
3094         echo requires `-e` option to use escape sequence.
3095         Without it, in some environment (in my Fedora 25), the escape sequence is not
3096         recognized and just dumped as `\c` etc.
3097
3098         * Scripts/run-jsc-benchmarks:
3099
3100 2017-01-12  Chris Dumez  <cdumez@apple.com>
3101
3102         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3103         https://bugs.webkit.org/show_bug.cgi?id=166995
3104
3105         Reviewed by Jer Noble.
3106
3107         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3108         as some people are having trouble building without it.
3109
3110         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3111
3112 2017-01-12  Sam Weinig  <sam@webkit.org>
3113
3114         Add the ability to filter the set of bindings tests you want to run
3115         https://bugs.webkit.org/show_bug.cgi?id=166977
3116
3117         Reviewed by Tim Horton.
3118
3119         Allows doing things like:
3120             run-bindings-tests TestObj* TestCEReactions*
3121         
3122         to run only those tests that match the patterns.
3123
3124         * Scripts/run-bindings-tests:
3125         (main):
3126         Switch to using optparse and pass the remaining args as the filters.
3127
3128         * Scripts/webkitpy/bindings/main.py:
3129         (BindingsTests.__init__):
3130         Store the pattens.
3131
3132         (BindingsTests.test_matches_patterns):
3133         Add helper predicate to determine if a test should be run. When no
3134         patterns are present, all tests should run.
3135
3136         (BindingsTests.run_tests):
3137         Filter tests using the passed in patterns.
3138
3139 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
3140
3141         Followup fix after r210503.
3142         https://bugs.webkit.org/show_bug.cgi?id=166887
3143
3144         Reviewed by Alex Christensen.
3145
3146         After <http://trac.webkit.org/changeset/210503>, test results are written to a
3147         duplicated file handle on Windows. This patch fixes the remaining call sites.
3148
3149         * DumpRenderTree/PixelDumpSupport.cpp:
3150         * DumpRenderTree/TestRunner.cpp:
3151         (TestRunner::waitToDumpWatchdogTimerFired):
3152         * DumpRenderTree/TestRunner.h:
3153         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3154         * DumpRenderTree/win/DumpRenderTree.cpp:
3155         * DumpRenderTree/win/DumpRenderTreeWin.h:
3156         * DumpRenderTree/win/TestRunnerWin.cpp:
3157         (TestRunner::setSpellCheckerLoggingEnabled):
3158
3159 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
3160
3161         Add committer status for Megan
3162         https://bugs.webkit.org/show_bug.cgi?id=166954
3163
3164         Reviewed by Tim Horton.
3165
3166         Add committer status for Megan Gardner
3167
3168         * Scripts/webkitpy/common/config/contributors.json:
3169
3170 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3171
3172         Unreviewed test fix after r210599.
3173
3174         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3175         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
3176
3177 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3178
3179         Unreviewed build fix after r210599.
3180
3181         Add missing files.
3182
3183         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3184         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3185
3186 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3187
3188         File scheme should not allow access of a resource on a different volume.
3189         https://bugs.webkit.org/show_bug.cgi?id=158552
3190         <rdar://problem/15307582>
3191
3192         Reviewed by Alex Christensen.
3193
3194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3195         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3196         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3197
3198 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3199
3200         Unreviewed, rolling out r210571.
3201
3202         This change broke the 32-bit macOS build and caused LayoutTest
3203         failures.
3204
3205         Reverted changeset:
3206
3207         "File scheme should not allow access of a resource on a
3208         different volume."
3209         https://bugs.webkit.org/show_bug.cgi?id=158552
3210         http://trac.webkit.org/changeset/210571
3211
3212 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3213
3214         [GTK] install-dependencies script misses gdb
3215         https://bugs.webkit.org/show_bug.cgi?id=166917
3216
3217         Reviewed by Michael Catanzaro.
3218
3219         gdb is needed for generating the crash logs.
3220
3221         * gtk/install-dependencies:
3222
3223 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3224
3225         [GTK] No way for applications to set notification permissions without waiting for permission request
3226         https://bugs.webkit.org/show_bug.cgi?id=163366
3227
3228         Reviewed by Carlos Garcia Campos.
3229
3230         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3231         (testWebViewNotification):
3232         (setInitialNotificationPermissionsAllowedCallback):
3233         (setInitialNotificationPermissionsDisallowedCallback):
3234         (testWebViewNotificationInitialPermissionAllowed):
3235         (testWebViewNotificationInitialPermissionDisallowed):
3236         (beforeAll):
3237         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3238         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3239         (WebViewTest::WebViewTest):
3240         (WebViewTest::initializeWebView):
3241         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3242
3243 2017-01-10  Tim Horton  <timothy_horton@apple.com>
3244
3245         MobileMiniBrowser tests don't work by default
3246         https://bugs.webkit.org/show_bug.cgi?id=166910
3247
3248         Reviewed by Alex Christensen.
3249
3250         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
3251         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
3252
3253 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
3254
3255         File scheme should not allow access of a resource on a different volume.
3256         https://bugs.webkit.org/show_bug.cgi?id=158552
3257         <rdar://problem/15307582>
3258
3259         Reviewed by Alex Christensen.
3260
3261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3262         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3263         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3264
3265 2017-01-10  Mark Lam  <mark.lam@apple.com>
3266
3267         Reverting run-jsc-stress-tests' $buildType to use string values.
3268         https://bugs.webkit.org/show_bug.cgi?id=166912
3269
3270         Rubber stamped by Filip Pizlo.
3271
3272         This is so that we can test for it in the tests e.g.
3273         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
3274
3275         * Scripts/run-jsc-stress-tests:
3276
3277 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3278
3279         Temporarily add back the file removed in r210463 to unbreak internal bots.
3280
3281         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3282
3283 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
3284
3285         svn-apply failed to apply a patch (deleting file with svn property)
3286         https://bugs.webkit.org/show_bug.cgi?id=165953
3287
3288         Reviewed by Daniel Bates.
3289
3290         * Scripts/VCSUtils.pm:
3291         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
3292         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
3293
3294 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3295
3296         Update flakiness dashboard configuration.
3297         https://bugs.webkit.org/show_bug.cgi?id=166869
3298
3299         Reviewed by Alexey Proskuryakov.
3300
3301         * TestResultServer/static-dashboards/builders.jsonp:
3302         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3303
3304 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3305
3306         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
3307         https://bugs.webkit.org/show_bug.cgi?id=165232
3308
3309         Unreviewed follow-up patch after r210539 and r210523.
3310
3311         Instead of using that environment variable, the argument
3312         --display-server=xorg should be passed now.
3313
3314         The GTK+ performance bot was the only bot using this, and is
3315         already passing --display-server=xorg after r210539.
3316
3317         * Scripts/webkitpy/port/gtk.py:
3318         (GtkPort._driver_class):
3319
3320 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3321
3322         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
3323         https://bugs.webkit.org/show_bug.cgi?id=166872
3324
3325         Reviewed by Michael Catanzaro.
3326
3327         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
3328         Define the required "--display-server=driver" in the bot additionalArguments config entry.
3329         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
3330         The step RunWebKitTests already has support for it.
3331
3332         * BuildSlaveSupport/build.webkit.org-config/config.json:
3333         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3334         (RunGtkAPITests.start):
3335         (RunAndUploadPerfTests.start):
3336         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3337
3338 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
3339
3340         Unreviewed, rolling out r210531.
3341
3342         This change broke the 32-bit macOS build and caused LayoutTest
3343         failures.
3344
3345         Reverted changeset:
3346
3347         "File scheme should not allow access of a resource on a
3348         different volume."
3349         https://bugs.webkit.org/show_bug.cgi?id=158552
3350         http://trac.webkit.org/changeset/210531
3351
3352 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
3353
3354         File scheme should not allow access of a resource on a different volume.
3355         https://bugs.webkit.org/show_bug.cgi?id=158552
3356         <rdar://problem/15307582>
3357
3358         Reviewed by Alex Christensen.
3359
3360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3361         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3362         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3363
3364 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3365
3366         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
3367         https://bugs.webkit.org/show_bug.cgi?id=165232
3368
3369         Reviewed by Michael Catanzaro.
3370
3371         Add a new WaylandDriver to run the tests in the user current wayland session.
3372
3373         Also merge all the configuration options for selecting the display server inside one
3374         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
3375
3376         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
3377
3378         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
3379         (TestRunner._create_driver):
3380         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3381         (parse_args):
3382         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3383         (PerfTestsRunner._parse_args):
3384         * Scripts/webkitpy/port/gtk.py:
3385         (GtkPort.__init__):
3386         (GtkPort._driver_class):
3387         (GtkPort._search_paths):
3388         * Scripts/webkitpy/port/waylanddriver.py: Added.
3389         (WaylandDriver):
3390         (WaylandDriver.check_driver):
3391         (WaylandDriver._setup_environ_for_test):
3392         (WaylandDriver._start):
3393
3394 2017-01-09  Andy Estes  <aestes@apple.com>
3395
3396         [QuickLook] Add a layout test for webkit.org/b/135651
3397         https://bugs.webkit.org/show_bug.cgi?id=166855
3398
3399         Reviewed by Andreas Kling.
3400
3401         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3402         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
3403         errors with code WebKitErrorCannotShowURL.
3404         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3405         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
3406         not specific to WebKit2 error codes.
3407
3408 2017-01-09  Antoine Quint  <graouts@apple.com>
3409
3410         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
3411         https://bugs.webkit.org/show_bug.cgi?id=166837
3412
3413         Reviewed by Alex Christensen.
3414
3415         We now correctly handle the --absolutePath argument in DumpRenderTree and use
3416         the provided value when trying to determine the path to the test file. Failing
3417         that, we use the computed URL or the raw path provided to cover all cases.
3418         
3419         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
3420         by applying this patch and seeing the number test failures dramatically reduced
3421         with WK1 due to the option to turn modern media controls off for older media controls
3422         tests.
3423
3424         * DumpRenderTree/DumpRenderTree.h:
3425         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3426         (parseInputLine):
3427         * DumpRenderTree/TestOptions.h:
3428         * DumpRenderTree/TestOptions.mm:
3429         (TestOptions::TestOptions):
3430         * DumpRenderTree/mac/DumpRenderTree.mm:
3431         (runTest):
3432
3433 2017-01-09  Milan Crha  <mcrha@redhat.com>
3434
3435         prepare-ChangeLog: Correct help string for --style option
3436         https://bugs.webkit.org/show_bug.cgi?id=166725
3437
3438         Reviewed by Alexey Proskuryakov.
3439
3440         * Scripts/prepare-ChangeLog:
3441         (main):
3442
3443 2017-01-09  Lucas Forschler  <lforschler@apple.com>
3444
3445         https://bugs.webkit.org/show_bug.cgi?id=166839
3446         Add php7 support for macOS.
3447         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
3448
3449         Reviewed by Alexey Proskuryakov.
3450
3451         * Scripts/webkitpy/port/base.py:
3452         (Port._is_darwin_php_version_7):
3453         (Port._debian_php_version):
3454         (Port):
3455         (Port._darwin_php_version):
3456         (Port._apache_config_file_name_for_platform):
3457
3458 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3459
3460         [GTK] Should support key and code properties on keyboard events
3461         https://bugs.webkit.org/show_bug.cgi?id=166759
3462
3463         Reviewed by Carlos Garcia Campos.
3464
3465         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3466         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
3467         on tests.
3468
3469 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
3470
3471         [Win] Some tests are flaky because certain DLLs are writing to stdout.
3472         https://bugs.webkit.org/show_bug.cgi?id=166760
3473
3474         Reviewed by Darin Adler.
3475
3476         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
3477         We can work around that by duplicating and redirecting stdout.
3478
3479         * DumpRenderTree/PixelDumpSupport.cpp:
3480         (dumpWebViewAsPixelsAndCompareWithExpected):
3481         (printPNG):
3482         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3483         (logEventProc):
3484         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3485         (DRTDesktopNotificationPresenter::showDesktopNotification):
3486         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
3487         (DRTDesktopNotificationPresenter::requestNotificationPermission):
3488         * DumpRenderTree/win/DumpRenderTree.cpp:
3489         (dumpFrameScrollPosition):
3490         (dumpHistoryItem):
3491         (dumpBackForwardList):
3492         (dump):
3493         (runTest):
3494         (main):
3495         * DumpRenderTree/win/DumpRenderTreeWin.h:
3496         * DumpRenderTree/win/EditingDelegate.cpp:
3497         (EditingDelegate::shouldBeginEditingInDOMRange):
3498         (EditingDelegate::shouldEndEditingInDOMRange):
3499         (EditingDelegate::shouldInsertNode):
3500         (EditingDelegate::shouldInsertText):
3501         (EditingDelegate::shouldDeleteDOMRange):
3502         (EditingDelegate::shouldChangeSelectedDOMRange):
3503         (EditingDelegate::shouldApplyStyle):
3504         (EditingDelegate::shouldChangeTypingStyle):
3505         (EditingDelegate::doPlatformCommand):
3506         (EditingDelegate::webViewDidBeginEditing):
3507         (EditingDelegate::webViewDidChange):
3508         (EditingDelegate::webViewDidEndEditing):
3509         (EditingDelegate::webViewDidChangeTypingStyle):
3510         (EditingDelegate::webViewDidChangeSelection):
3511         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3512         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3513         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3514         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3515         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3516         (FrameLoadDelegate::didCommitLoadForFrame):
3517         (FrameLoadDelegate::didReceiveTitle):
3518         (FrameLoadDelegate::didFinishLoadForFrame):
3519         (FrameLoadDelegate::didFailLoadWithError):
3520         (FrameLoadDelegate::willPerformClientRedirectToURL):
3521         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3522         (FrameLoadDelegate::windowScriptObjectAvailable):
3523         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3524         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3525         (FrameLoadDelegate::didDisplayInsecureContent):
3526         (FrameLoadDelegate::didRunInsecureContent):
3527         (FrameLoadDelegate::webViewProgressFinishedNotification):
3528         * DumpRenderTree/win/HistoryDelegate.cpp:
3529         (HistoryDelegate::didNavigateWithNavigationData):
3530         (HistoryDelegate::didPerformClientRedirectFromURL):
3531         (HistoryDelegate::didPerformServerRedirectFromURL):
3532         (HistoryDelegate::updateHistoryTitle):
3533         (HistoryDelegate::populateVisitedLinksForWebView):
3534         * DumpRenderTree/win/PolicyDelegate.cpp:
3535         (PolicyDelegate::decidePolicyForNavigationAction):
3536         (PolicyDelegate::unableToImplementPolicyWithError):
3537         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3538         (ResourceLoadDelegate::willSendRequest):
3539         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3540         (ResourceLoadDelegate::didReceiveResponse):
3541         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3542         (ResourceLoadDelegate::didFailLoadingWithError):
3543         * DumpRenderTree/win/TestRunnerWin.cpp:
3544         (TestRunner::addDisallowedURL):
3545         (TestRunner::originsWithApplicationCache):
3546         (TestRunner::setStorageDatabaseIdleInterval):
3547         (TestRunner::closeIdleLocalStorageDatabases):
3548         (TestRunner::copyDecodedHostName):
3549         (TestRunner::copyEncodedHostName):
3550         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3551         (TestRunner::isGeolocationProviderActive):
3552         (TestRunner::pathToLocalResource):
3553         (TestRunner::setMockDeviceOrientation):
3554         (TestRunner::setMockGeolocationPosition):
3555         (TestRunner::setMockGeolocationPositionUnavailableError):
3556         (TestRunner::setSpatialNavigationEnabled):
3557         (TestRunner::setAutomaticLinkDetectionEnabled):
3558         (TestRunner::isCommandEnabled):
3559         (TestRunner::authenticateSession):
3560         (TestRunner::addChromeInputField):
3561         (TestRunner::removeChromeInputField):
3562         (TestRunner::focusWebView):
3563         (TestRunner::grantWebNotificationPermission):
3564         (TestRunner::denyWebNotificationPermission):
3565         (TestRunner::removeAllWebNotificationPermissions):
3566         (TestRunner::simulateWebNotificationClick):
3567         (TestRunner::imageCountInGeneralPasteboard):
3568         * DumpRenderTree/win/UIDelegate.cpp:
3569         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3570         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3571         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3572         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3573         (UIDelegate::webViewAddMessageToConsole):
3574         (UIDelegate::exceededDatabaseQuota):
3575         (UIDelegate::setStatusText):
3576         (UIDelegate::didPressMissingPluginButton):
3577
3578 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3579
3580         Add a setting to create editable MiniBrowser windows by default
3581         https://bugs.webkit.org/show_bug.cgi?id=166806
3582
3583         Reviewed by Beth Dakin.
3584
3585         * MiniBrowser/mac/AppDelegate.m:
3586         (-[BrowserAppDelegate createBrowserWindowController:]):
3587         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3588         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3589         * MiniBrowser/mac/SettingsController.h:
3590         * MiniBrowser/mac/SettingsController.m:
3591         (-[SettingsController _populateMenu]):
3592         (-[SettingsController validateMenuItem:]):
3593         (-[SettingsController toggleCreateEditorByDefault:]):
3594         (-[SettingsController createEditorByDefault]):
3595         Add a setting and update the key equivalents accordingly.
3596         Also make sure to make the right kind of window on launch.
3597
3598 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3599
3600         Fix the 32-bit build.
3601
3602         * MiniBrowser/mac/BrowserWindowController.h:
3603         * MiniBrowser/mac/BrowserWindowController.m:
3604
3605 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3606
3607         Fix the 32-bit build.
3608
3609         * MiniBrowser/mac/BrowserWindowController.m:
3610
3611 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3612
3613         Make it possible to drop HTML files on the MiniBrowser icon
3614         https://bugs.webkit.org/show_bug.cgi?id=166802
3615
3616         Reviewed by Simon Fraser.
3617
3618         * MiniBrowser/mac/AppDelegate.m:
3619         (-[BrowserAppDelegate application:openFile:]):
3620         * MiniBrowser/mac/Info.plist:
3621         If you're using an editable window, the usual trick of dropping on the
3622         window doesn't work anymore (it makes an <attachment> instead).
3623
3624 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3625
3626         MiniBrowser window gets smaller each time it is instantiated
3627         https://bugs.webkit.org/show_bug.cgi?id=166807
3628
3629         Reviewed by Andy Estes.
3630
3631         * MiniBrowser/mac/BrowserWindowController.m:
3632         (-[BrowserWindowController windowDidLoad]):
3633         * MiniBrowser/mac/BrowserWindow.xib:
3634         Turn on full-window content view support with IB, instead of waiting
3635         until after the views have been loaded. This seems to resolve the
3636         longstanding ever-shrinking-window problem.
3637
3638 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3639
3640         Add indent/outdent items to MiniBrowser's new format menu
3641         https://bugs.webkit.org/show_bug.cgi?id=166805
3642
3643         Reviewed by Dan Bernstein.
3644
3645         * MiniBrowser/mac/MainMenu.xib:
3646
3647 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3648
3649         Add a stock Format menu to MiniBrowser
3650         https://bugs.webkit.org/show_bug.cgi?id=166804
3651
3652         Reviewed by Andy Estes.
3653
3654         * MiniBrowser/mac/MainMenu.xib:
3655         Many of the features automatically work with editable web views.
3656         However, this seems to expose a bug where none of the font-related features
3657         (Cmd-B, for example) work until the first time the font panel is shown,
3658         per process, which will need to be investigated separately.
3659
3660 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3661
3662         Remove unused applicationWillTerminate methods from MiniBrowser
3663         https://bugs.webkit.org/show_bug.cgi?id=166803
3664
3665         Reviewed by Andy Estes.
3666
3667         * MiniBrowser/mac/AppDelegate.m:
3668         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3669         * MiniBrowser/mac/BrowserWindowController.h:
3670         * MiniBrowser/mac/BrowserWindowController.m:
3671         (-[BrowserWindowController applicationTerminating]): Deleted.