[JSC] Less contended MetaAllocator
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
2
3         [JSC] Less contended MetaAllocator
4         https://bugs.webkit.org/show_bug.cgi?id=200278
5
6         Reviewed by Mark Lam.
7
8         Update the interface.
9
10         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
11
12 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
13
14         results.webkit.org: 500 errors on API endpoints don't return JSON
15         https://bugs.webkit.org/show_bug.cgi?id=200722
16
17         Reviewed by Aakash Jain.
18
19         * resultsdbpy/resultsdbpy/controller/api_routes.py:
20         (APIRoutes.response_500): We should return the response, instead of abort.
21
22 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
23
24         results.webkit.org: Don't save configuration multiple times in upload
25         https://bugs.webkit.org/show_bug.cgi?id=200719
26
27         Reviewed by Aakash Jain.
28
29         * resultsdbpy/resultsdbpy/model/upload_context.py:
30         (UploadContext.upload_test_results): Move registering of the configuration out
31         of the branch loop.
32
33 2019-08-14  Youenn Fablet  <youenn@apple.com>
34
35         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
36         https://bugs.webkit.org/show_bug.cgi?id=200706
37
38         Reviewed by Alex Christensen.
39
40         Libwebrtc is now soft-linked so we can reenable this test.
41
42         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
43         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
44
45 2019-08-13  Sam Weinig  <weinig@apple.com>
46
47         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
48         https://bugs.webkit.org/show_bug.cgi?id=200675
49
50         Reviewed by Darin Adler.
51
52         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
53         (TestWebKitAPI::TEST):
54         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
55
56 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
57
58         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
59         https://bugs.webkit.org/show_bug.cgi?id=200456
60
61         Reviewed by Jonathan Bedard.
62
63         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
64
65         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
66
67         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
68         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
69         (pointPolygonCollisionDetect): Detact
70         (pointRightRayLineSegmentCollisionDetect):
71         (ColorBatchRender):
72         (ColorBatchRender.prototype.lazyCreateColorSeqs):
73         (ColorBatchRender.prototype.addSeq):
74         (ColorBatchRender.prototype.batchRender):
75         (ColorBatchRender.prototype.clear):
76         (xScrollStreamRenderFactory):
77         (Timeline.CanvasSeriesComponent):
78         (offscreenCachedRenderFactory): Deleted.
79
80 2019-08-13  John Wilander  <wilander@apple.com>
81
82         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
83         https://bugs.webkit.org/show_bug.cgi?id=200642
84         <rdar://problem/53962073>
85
86         Reviewed by Alex Christensen.
87
88         This patch adds test infrastructure to query whether an origin has an
89         isolated NSURLSession or not.
90
91         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
92         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
93         (WTR::TestRunner::hasStatisticsIsolatedSession):
94         * WebKitTestRunner/InjectedBundle/TestRunner.h:
95         * WebKitTestRunner/TestController.cpp:
96         (WTR::TestController::hasStatisticsIsolatedSession):
97         * WebKitTestRunner/TestController.h:
98         * WebKitTestRunner/TestInvocation.cpp:
99         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
100
101 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
102
103         Update my status in contributors.json to committer.
104
105         Reviewed by Unreviewed
106
107         * Scripts/webkitpy/common/config/contributors.json:
108
109 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
110
111         Adds WebAuthn and AppSSO into watchlist
112         https://bugs.webkit.org/show_bug.cgi?id=200647
113
114         Reviewed by Dewei Zhu.
115
116         * Scripts/webkitpy/common/config/watchlist:
117
118 2019-08-13  Chris Dumez  <cdumez@apple.com>
119
120         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
121         https://bugs.webkit.org/show_bug.cgi?id=200674
122         <rdar://problem/50692748>
123
124         Reviewed by Geoff Garen.
125
126         Add API test coverage.
127
128         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
129
130 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
131
132         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
133         https://bugs.webkit.org/show_bug.cgi?id=199857
134
135         Reviewed by Yusuke Suzuki.
136
137         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
138         (TestWebKitAPI::countThreadGroups):
139         (TestWebKitAPI::TEST):
140
141 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
142
143         AX: Homebrew is not allowed to run any script under sudo.
144         https://bugs.webkit.org/show_bug.cgi?id=173801
145
146         Reviewed by Carlos Alberto Lopez Perez.
147
148         Latest versions of Homebrew throw an error when run as root.
149         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
150
151         * gtk/install-dependencies:
152
153 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
154
155         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
156         https://bugs.webkit.org/show_bug.cgi?id=200644
157
158         Reviewed by Aakash Jain.
159
160         * Scripts/webkitpy/port/simulator_process.py:
161         (SimulatorProcess._start): Define system PID after launching app.
162
163 2019-08-12  Sam Weinig  <weinig@apple.com>
164
165         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
166         https://bugs.webkit.org/show_bug.cgi?id=200614
167
168         Reviewed by Darin Adler.
169
170         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
171         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
172         
173         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
174         StringBuilder::appendSubstring(...).
175
176         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
177         (TestWebKitAPI::TEST):
178         Update for renames.
179
180 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
181
182         Fix Crash in Mail Search
183         https://bugs.webkit.org/show_bug.cgi?id=200589
184
185         Reviewed by Tim Horton.
186
187         If you search backwards first in mail, we would crash,
188         this tests that codepath.
189
190         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
191         (TEST):
192
193 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
194
195         [iPadOS] Web pages sometimes load at half width in Safari
196         https://bugs.webkit.org/show_bug.cgi?id=200624
197         <rdar://problem/52694257>
198
199         Reviewed by Simon Fraser.
200
201         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
202         web page is created using the post-animated-resize web view dimensions, rather than the original layout
203         dimensions.
204
205         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
206
207 2019-08-12  Daniel Bates  <dabates@apple.com>
208
209         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
210         https://bugs.webkit.org/show_bug.cgi?id=200548
211
212         Reviewed by Darin Adler.
213
214         Expose infrastructure to simulate a literal raw key down and a literal key up event.
215
216         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
217         * TestRunnerShared/UIScriptContext/UIScriptController.h:
218         (WTR::UIScriptController::rawKeyDown):
219         (WTR::UIScriptController::rawKeyUp):
220         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
221         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
222         (WTR::UIScriptControllerIOS::rawKeyDown):
223         (WTR::UIScriptControllerIOS::rawKeyUp):
224
225 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
226
227         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
228         https://bugs.webkit.org/show_bug.cgi?id=200584
229
230         Reviewed by Philippe Normand.
231
232         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
233         Ignore style libwebrtc optionnal 'style issue'
234
235         * Scripts/webkitpy/style/checker.py:
236         * gstreamer/jhbuild.modules:
237         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
238
239 2019-08-12  Youenn Fablet  <youenn@apple.com>
240
241         Remove IDB-specific quota
242         https://bugs.webkit.org/show_bug.cgi?id=196545
243
244         Reviewed by Alex Christensen.
245
246         * DumpRenderTree/TestRunner.cpp:
247         (TestRunner::staticFunctions):
248         (setIDBPerOriginQuotaCallback): Deleted.
249         * DumpRenderTree/TestRunner.h:
250         * DumpRenderTree/mac/DumpRenderTree.mm:
251         (runTest):
252         * DumpRenderTree/mac/TestRunnerMac.mm:
253         (TestRunner::setIDBPerOriginQuota): Deleted.
254         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
255         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
256         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
257         * WebKitTestRunner/InjectedBundle/TestRunner.h:
258         * WebKitTestRunner/TestController.cpp:
259         (WTR::TestController::resetStateToConsistentValues):
260         (WTR::TestController::setIDBPerOriginQuota): Deleted.
261         * WebKitTestRunner/TestController.h:
262         * WebKitTestRunner/TestInvocation.cpp:
263         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
264
265 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
266
267         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
268         https://bugs.webkit.org/show_bug.cgi?id=200621
269
270         Reviewed by Dan Bernstein.
271
272         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
273
274 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
275
276         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
277         https://bugs.webkit.org/show_bug.cgi?id=200604
278         <rdar://problem/51273130>
279
280         Reviewed by Megan Gardner.
281
282         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
283         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
284         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
285         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
286         remains the same.
287
288         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
289         the caret rect at initial scale 1.
290
291         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
292
293 2019-08-09  Ali Juma  <ajuma@chromium.org>
294
295         Don't allow cross-origin iframes to autofocus
296         https://bugs.webkit.org/show_bug.cgi?id=200515
297         <rdar://problem/54092988>
298
299         Reviewed by Ryosuke Niwa.
300
301         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
302         of cross-origin iframes, since it depends on focusing one of the
303         frames.
304
305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
306         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
307         (TestWebKitAPI::TEST):
308         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
309
310 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
311
312         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
313         https://bugs.webkit.org/show_bug.cgi?id=200591
314         <rdar://problem/54102238>
315
316         Reviewed by Ryosuke Niwa and Tim Horton.
317
318         Add a new API test to exercise -supportsImagePaste.
319
320         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
321         (TestWebKitAPI::TEST):
322         * TestWebKitAPI/ios/UIKitSPI.h:
323
324 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
325
326         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
327         [ews-build] Set svn:ignore to various EWS Buildbot files
328         https://bugs.webkit.org/show_bug.cgi?id=200581
329
330         Reviewed by Jonathan Bedard.
331
332         * BuildSlaveSupport/ews-build: Added property svn:ignore.
333
334 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
335
336         [ews-build] Set svn:ignore to various EWS Buildbot files
337         https://bugs.webkit.org/show_bug.cgi?id=200581
338
339         Reviewed by Jonathan Bedard.
340
341         * BuildSlaveSupport/ews-build: Added property svn:ignore.
342
343 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
344
345         [ews] Add buildbot.tac to repository
346         https://bugs.webkit.org/show_bug.cgi?id=200580
347
348         Reviewed by Jonathan Bedard.
349
350         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
351
352 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
353
354         [GTK] Add missing spellchecking packages to dependencies script
355         https://bugs.webkit.org/show_bug.cgi?id=200574
356
357         Reviewed by Philippe Normand.
358
359         These are needed for the spellchecking test in WebContext API tests.
360
361         * gtk/install-dependencies:
362
363 2019-08-08  Jon Lee  <jonlee@apple.com>
364
365         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
366
367 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
368
369         webkitpy: Disable shared clipboard between Simulators
370         https://bugs.webkit.org/show_bug.cgi?id=200546
371
372         Reviewed by Aakash Jain.
373
374         * Scripts/webkitpy/xcode/simulated_device.py:
375         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
376         managed by run-webkit-tests.
377
378 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
379
380         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
381         https://bugs.webkit.org/show_bug.cgi?id=200539
382         <rdar://problem/54082550>
383
384         Reviewed by Dean Jackson.
385
386         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
387         * PlatformFTW.cmake: Added.
388
389 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
390
391         [iOS] Position image information should respect the image orientation
392         https://bugs.webkit.org/show_bug.cgi?id=200487
393
394         Reviewed by Simon Fraser.
395
396         Add an API test to verify the position image information is drawn rotated
397         because of respecting its image orientation.
398
399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
400         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
401         (TestWebKitAPI::TEST):
402         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
403         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
404
405 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
406
407         [GTK] Fix WebContext languages test
408         https://bugs.webkit.org/show_bug.cgi?id=200538
409
410         Reviewed by Alex Christensen.
411
412         This test broke after the format of Accepted-Languages
413         was changed in r238236, update.
414
415         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
416         (testWebContextLanguages):
417
418 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
419
420         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
421         https://bugs.webkit.org/show_bug.cgi?id=200536
422
423         Reviewed by Carlos Alberto Lopez Perez.
424
425         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
426         (testWebsiteDataDatabases): Databases take a moment to be written,
427         wait before fetching the data as it's done in other tests.
428
429 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
430
431         results.webkit.org: Use canvas for timeline
432         https://bugs.webkit.org/show_bug.cgi?id=200172
433
434         Rubber-stamped by Aakash Jain.
435
436         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
437         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
438         (Commit.compare): Ditto.
439         (_CommitBank.commitByUuid): Ditto.
440         (_CommitBank._loadSiblings): Ditto.
441         (_CommitBank._load): Ditto.
442         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
443         (tickForCommit): Deleted.
444         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
445         which encompasses all results. Crucially, this function must exclude an UUIDs which may
446         refer to results excluded because of the limit argument.
447         (renderTimeline): Deleted.
448         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
449         with those results.
450         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
451         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
452         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
453         (inPlaceCombine): Combine result objects together.
454         (statsForSingleResult): Turn a single result into a stat object.
455         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
456         (Dot): Deleted.
457         (TimelineFromEndpoint): Renamed from Timeline.
458         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
459         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
460         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
461         cache contents.
462         (TimelineFromEndpoint.reload): Remove management of nested timelines.
463         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
464         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
465         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
466
467 2019-08-08  Brady Eidson  <beidson@apple.com>
468
469         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
470         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
471
472         Reviewed by Geoff Garen.
473
474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
475         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
476
477 2019-08-08  Rob Buis  <rbuis@igalia.com>
478
479         Add runtime flag for lazy image loading
480         https://bugs.webkit.org/show_bug.cgi?id=199794
481
482         Reviewed by Darin Adler.
483
484         Set lazyImageLoading preference as part of experimental features. Add
485         TestOption for lazy image loading.
486
487         * DumpRenderTree/TestOptions.cpp:
488         (TestOptions::TestOptions):
489         * DumpRenderTree/TestOptions.h:
490         * DumpRenderTree/mac/DumpRenderTree.mm:
491         (enableExperimentalFeatures):
492         (setWebPreferencesForTestOptions):
493         * DumpRenderTree/win/DumpRenderTree.cpp:
494         (enableExperimentalFeatures):
495
496 2019-08-08  Rob Buis  <rbuis@igalia.com>
497
498         Import lazy loading WPT tests
499         https://bugs.webkit.org/show_bug.cgi?id=199795
500
501         Reviewed by Darin Adler.
502
503         Only do loading/ exception for WebKit specific, non WPT tests.
504
505         * DumpRenderTree/mac/DumpRenderTree.mm:
506         (shouldLogFrameLoadDelegates):
507         * WebKitTestRunner/TestInvocation.cpp:
508         (WTR::TestInvocation::TestInvocation):
509
510 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
511
512         [Win][MiniBrowser] Add key accelerators for reload and close window
513         https://bugs.webkit.org/show_bug.cgi?id=200497
514
515         Reviewed by Brent Fulgham.
516
517         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
518
519         * MiniBrowser/win/MainWindow.cpp:
520         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
521         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
522         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
523
524 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
525
526         Add WHLSL and WebGPU to the watchlist file
527         https://bugs.webkit.org/show_bug.cgi?id=200509
528
529         Reviewed by Robin Morisset.
530
531         * Scripts/webkitpy/common/config/watchlist:
532
533 2019-08-07  Keith Rollin  <krollin@apple.com>
534
535         Unreviewed build fix after r248317 -- disable XCBuild because it
536         breaks incremental builds.
537
538         * Scripts/webkitdirs.pm:
539         (canUseXCBuild):
540
541 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
542
543         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
544         https://bugs.webkit.org/show_bug.cgi?id=200465
545
546         Reviewed by Alex Christensen.
547
548         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
549         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
550         finishing the test.
551         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
552         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
553
554 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
555
556         Unreviewed, a build fix after r248308
557
558         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
559
560         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
561
562 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
563
564         Unreviewed, a build fix after r248319
565
566         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
567
568         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
569         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
570         (WTR::TestController::addTestKeyToKeychain):
571         (WTR::TestController::cleanUpKeychain):
572         (WTR::TestController::keyExistsInKeychain):
573
574 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
575
576         Unreviewed, a build fix after r248308
577
578         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
579
580         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
581         (WTR::TestController::addTestKeyToKeychain):
582         (WTR::TestController::cleanUpKeychain):
583         (WTR::TestController::keyExistsInKeychain):
584
585 2019-08-06  Keith Rollin  <krollin@apple.com>
586
587         Enable XCBuild for `make` and `build-webkit` builds
588         https://bugs.webkit.org/show_bug.cgi?id=200476
589         <rdar://problem/50771065>
590
591         Reviewed by Jonathan Bedard.
592
593         All projects have now been tested under XCBuild and successfully
594         build. Enable the use of XCBuild when performing builds with `make` or
595         `build-webkit` and when using a sufficient version of Xcode. We set
596         this version to Xcode 11 since Xcode 10 -- even though it supports
597         XCBuild -- does not support a build facility needed to build WebKit
598         (Bug 197072, Bug 197116, Bug 197340).
599
600         Do not enable XCBuild in the Xcode projects themselves since these
601         projects may need to be used under older versions of Xcode and there's
602         no way to make those project changes sensitive to the version of Xcode
603         being used. This means that builds performed in the Xcode IDE will not
604         use XCBuild.
605
606         * Scripts/webkitdirs.pm:
607         (canUseXCBuild):
608
609 2019-08-06  Chris Dumez  <cdumez@apple.com>
610
611         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
612         https://bugs.webkit.org/show_bug.cgi?id=200475
613
614         Reviewed by Darin Adler.
615
616         * TestWebKitAPI/Tests/WTF/StringView.cpp:
617         (TestWebKitAPI::stringViewFromLiteral):
618         (TestWebKitAPI::stringViewFromUTF8):
619
620 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
621
622         Update my status in contributors.json to reviewer.
623
624         Regained the status after following the procedure for inactive contributors.
625         See r247136 for further explanation.
626
627         * Scripts/webkitpy/common/config/contributors.json:
628
629 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
630
631         [WebAuthN] Enable LocalAuthenticator for macOS
632         https://bugs.webkit.org/show_bug.cgi?id=182772
633         <rdar://problem/43347920>
634
635         Reviewed by Brent Fulgham.
636
637         Add an entitlement file to WebKitTestRunner such that it can access
638         the modern macOS keychain.
639
640         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
641         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
642         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
643         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
644         (WTR::TestController::addTestKeyToKeychain):
645         (WTR::TestController::cleanUpKeychain):
646         (WTR::TestController::keyExistsInKeychain):
647
648 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
649
650         [results.webkit.org Timeline] Performance improvements
651         https://bugs.webkit.org/show_bug.cgi?id=200406
652
653         Reviewed by Jonathan Bedard.
654
655         1. Unhook the scroll event when a series/axis have been removed from the container
656         2. Fix the axis's cache data structure out of sync.
657         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
658         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
659
660
661         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
662         (Signal.prototype.removeListener):
663         (prototype.stopAction): Unregsiter an action handler
664         (Ref):
665         (Ref.prototype.apply):
666         (Ref.prototype.destory):
667         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
668         (ApplyNewChildren):
669         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
670         (Timeline.CanvasSeriesComponent):
671
672 2019-08-06  Jer Noble  <jer.noble@apple.com>
673
674         Add test for behavior introduced in r248174
675         https://bugs.webkit.org/show_bug.cgi?id=200446
676
677         Reviewed by Eric Carlson.
678
679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
680         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
681         (WebKit::configureSecheuristic):
682         (WebKit::TEST):
683
684 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
685
686         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
687         https://bugs.webkit.org/show_bug.cgi?id=200464
688
689         Reviewed by Ross Kirsling.
690
691         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
692         menu, Alt-F4 to close window, and etc) don't work.
693
694         WK1 WebView doesn't have this issue because it processes key events
695         properly.
696
697         * MiniBrowser/win/WebKitBrowserWindow.cpp:
698         (WebKitBrowserWindow::WebKitBrowserWindow):
699         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
700         unhandled key events to the main window.
701         * MiniBrowser/win/WebKitBrowserWindow.h:
702
703 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
704
705         iOS 13: Overflow:hidden on body prevents PDF scroll
706         https://bugs.webkit.org/show_bug.cgi?id=200435
707         rdar://problem/53942888
708
709         Reviewed by Tim Horton.
710
711         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
712         to make sure that the scroll view is scrollable.
713
714         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
715         (TestWebKitAPI::TEST):
716
717 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
718
719         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
720         https://bugs.webkit.org/show_bug.cgi?id=200400
721
722         Reviewed by Jonathan Bedard.
723
724         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
725         (StatusBubble._build_bubble):
726         (StatusBubble._queue_position):
727
728 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
729
730         run-webkit-tests asserts when the iPhone XR simulator is running
731         https://bugs.webkit.org/show_bug.cgi?id=200404
732         <rdar://problem/53878739>
733
734         Reviewed by Dean Jackson.
735
736         Support unicode in all logging statements tied to device model.
737
738         * Scripts/webkitpy/layout_tests/controllers/manager.py:
739         (Manager.run):
740         * Scripts/webkitpy/layout_tests/views/printing.py:
741         (Printer.print_baseline_search_path):
742         * Scripts/webkitpy/port/device.py:
743         (Device.__repr__):
744         * Scripts/webkitpy/port/device_port.py:
745         (DevicePort._install):
746         (DevicePort.setup_test_run):
747         (DevicePort.clean_up_test_run):
748         (DevicePort.configuration_for_upload):
749         * Scripts/webkitpy/port/ios.py:
750         (IOSPort.default_baseline_search_path):
751         * Scripts/webkitpy/xcode/device_type.py:
752         (DeviceType.__str__):
753         * Scripts/webkitpy/xcode/simulated_device.py:
754         (SimulatedDeviceManager.populate_available_devices):
755         (SimulatedDeviceManager._find_available_name):
756         (SimulatedDeviceManager._get_device_identifier_for_type):
757         (SimulatedDeviceManager._create_or_find_device_for_request):
758         (SimulatedDeviceManager._does_fulfill_request):
759         (SimulatedDeviceManager._wait_until_device_in_state):
760         (SimulatedDeviceManager._wait_until_device_is_usable):
761         (SimulatedDeviceManager._boot_device):
762         (SimulatedDeviceManager.initialize_devices):
763         (SimulatedDeviceManager.max_supported_simulators):
764         (SimulatedDeviceManager.swap):
765         (SimulatedDevice.is_usable):
766         (SimulatedDevice._shut_down):
767         (SimulatedDevice._delete):
768         (SimulatedDevice.launch_app):
769         (SimulatedDevice.__repr__):
770
771 2019-08-04  Chris Dumez  <cdumez@apple.com>
772
773         Ping loads should not prevent page caching
774         https://bugs.webkit.org/show_bug.cgi?id=200418
775         <rdar://problem/53901632>
776
777         Reviewed by Darin Adler.
778
779         Add TestOption to enable PageCache at UIProcess-level so that we can test
780         page caching when navigating cross-origin with PSON enabled.
781
782         * WebKitTestRunner/TestController.cpp:
783         (WTR::TestController::resetPreferencesToConsistentValues):
784         (WTR::updateTestOptionsFromTestHeader):
785         * WebKitTestRunner/TestOptions.h:
786         (WTR::TestOptions::hasSameInitializationOptions const):
787
788 2019-08-02  Keith Rollin  <krollin@apple.com>
789
790         Consistently use Obj-C boolean literals
791         https://bugs.webkit.org/show_bug.cgi?id=200405
792         <rdar://problem/53880043>
793
794         Reviewed by Simon Fraser, Joseph Pecoraro.
795
796         There are places where we use equivalent but different expressions for
797         Obj-C boolean objects. For example, we use both [NSNumber
798         numberWithBool:YES] and @YES. There are places where both are used in
799         the same function, such as -[WebPreferences initialize]. The boolean
800         literal is in greater use and is more succinct, so standardize on
801         that. Also, change @(YES/NO) to @YES/NO.
802
803         * DumpRenderTree/mac/ObjCController.m:
804         (-[ObjCController objectOfClass:]):
805         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
806         (TEST):
807         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
808         (overrideAddObserverForName):
809         * TestWebKitAPI/ios/mainIOS.mm:
810         (main):
811         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
812         (TestWebKitAPI::InjectedBundleController::platformInitialize):
813         * TestWebKitAPI/mac/mainMac.mm:
814         (main):
815         * WebKitLauncher/WebKitNightlyEnabler.m:
816         (enableWebKitNightlyBehaviour):
817
818 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
819
820         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
821         https://bugs.webkit.org/show_bug.cgi?id=200402
822         <rdar://problem/53823368>
823
824         Reviewed by Tim Horton.
825
826         Make it possible to run this test using the iPad simulator.
827
828         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
829
830         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
831         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
832         since this would result in differently sized text.
833
834         (mainScreenReferenceBoundsOverride):
835         * TestWebKitAPI/ios/UIKitSPI.h:
836
837 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
838
839         API tests using permanent credentials should clear credentials left by previous tests
840         https://bugs.webkit.org/show_bug.cgi?id=199729
841
842         Reviewed by Alex Christensen.
843
844         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
845         credentials will not affect tests running after. There is a case where permanent credentials were left on the
846         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
847         failure. To prevent this from happening again, add cleanup at the begining of the tests.
848
849         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
850         (TEST):
851         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
852         (TestWebKitAPI::TEST):
853
854 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
855
856         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
857         https://bugs.webkit.org/show_bug.cgi?id=200394
858         <rdar://problem/52914964>
859
860         Reviewed by Chris Fleizach.
861
862         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
863
864         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
865         (WTR::AccessibilityUIElement::isInTableCell const):
866         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
867         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
868         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
869         (WTR::AccessibilityUIElement::isInTableCell const):
870
871 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
872
873         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
874         https://bugs.webkit.org/show_bug.cgi?id=200397
875
876         Reviewed by Jonathan Bedard.
877
878         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
879
880 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
881
882         [macOS 10.15] Image dragged from Safari does not appear in Notes
883         https://bugs.webkit.org/show_bug.cgi?id=188490
884         <rdar://problem/39462717>
885
886         Reviewed by Andy Estes.
887
888         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
889
890         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
891
892 2019-08-02  Alex Christensen  <achristensen@webkit.org>
893
894         Fix API test after r248139
895         https://bugs.webkit.org/show_bug.cgi?id=200102
896
897         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
898         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
899         This was supposed to be removed as part of reverting r245322.
900
901 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
902
903         results.webkit.org: Force update cache when timeline updated
904         https://bugs.webkit.org/show_bug.cgi?id=200363
905
906         Reviewed by Jonathan Bedard.
907
908         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
909         (offscreenCachedRenderFactory): Add ability to force the redraw.
910         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
911         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
912
913 2019-08-01  Alex Christensen  <achristensen@webkit.org>
914
915         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
916         https://bugs.webkit.org/show_bug.cgi?id=200360
917
918         Reviewed by Tim Horton.
919
920         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
921         (cleanupITPDatabase):
922         (TEST):
923
924 2019-08-01  Alex Christensen  <achristensen@webkit.org>
925
926         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
927         https://bugs.webkit.org/show_bug.cgi?id=200102
928         <rdar://problem/53275114>
929
930         Reviewed by Darin Adler.
931
932         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
933         and because clicking on a TestWKWebView only works on Mac.
934
935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
936         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
937         (-[UploadDelegate initWithDirectory:]):
938         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
939         (-[UploadDelegate sentDirectory]):
940         (TEST):
941         * TestWebKitAPI/cocoa/TestWKWebView.h:
942         * TestWebKitAPI/cocoa/TestWKWebView.mm:
943         (-[TestWKWebView sendClickAtPoint:]):
944
945 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
946
947         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
948         https://bugs.webkit.org/show_bug.cgi?id=200321
949
950         Reviewed by Jonathan Bedard.
951
952         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
953         Let the axis' height be defined in the option. Timeine component will use this value as
954         padding-top for headers which allows headers start in the right position, even with multiple
955         top axises.
956         (Timeline.CanvasSeriesComponent):
957         (prototype.Timeline.CanvasContainer):
958
959 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
960
961         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
962         https://bugs.webkit.org/show_bug.cgi?id=200347
963
964         Reviewed by Jonathan Bedard.
965
966         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
967         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
968
969 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
970
971         Improve flakiness of SOAuthorizationRedirect tests
972         https://bugs.webkit.org/show_bug.cgi?id=200320
973         <rdar://problem/53767057>
974
975         Reviewed by Alex Christensen.
976
977         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
978         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
979         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
980         is executed.
981
982         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
983         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
984         (resetState):
985         (TestWebKitAPI::TEST):
986
987 2019-08-01  Keith Rollin  <krollin@apple.com>
988
989         Update TestWebKitAPI for XCBuild
990         https://bugs.webkit.org/show_bug.cgi?id=200311
991         <rdar://problem/53773804>
992
993         Reviewed by Alex Christensen.
994
995         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
996         technique. Now update WebKitLegacy to build under XCBuild after those
997         changes. This work involves adding an "Apply Configuration to
998         XCFileLists" build target, adding a check-xcfilelists.sh script,
999         adding a "Check xcfilelists" build phase that calls that script,
1000         adding knowledge of the project to the generate-xcfilelists script,
1001         creating new .xcfilelist files, and adding those to the project.
1002
1003         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1004         (Application.__init__):
1005         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1006         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
1007         (TestWebKitAPIGenerator):
1008         (TestWebKitAPIGenerator._get_project_file_path):
1009         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
1010         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
1011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1012         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
1013
1014 2019-08-01  Youenn Fablet  <youenn@apple.com>
1015
1016         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
1017         https://bugs.webkit.org/show_bug.cgi?id=200317
1018
1019         Reviewed by Eric Carlson.
1020
1021         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
1022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1023         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1024         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
1025         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1026         (TestWebKitAPI::TEST):
1027
1028 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
1029
1030         New EWS: Cannot see build status page when patch is waiting for tester
1031         https://bugs.webkit.org/show_bug.cgi?id=200333
1032
1033         Reviewed by Jonathan Bedard.
1034
1035         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1036         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
1037
1038 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1039
1040         [SOUP] Switch to use libsoup WebSockets API
1041         https://bugs.webkit.org/show_bug.cgi?id=200162
1042
1043         Reviewed by Michael Catanzaro.
1044
1045         Update libsoup version to 2.67.90.
1046
1047         * gtk/jhbuild.modules:
1048         * wpe/jhbuild.modules:
1049
1050 2019-07-31  Andy Estes  <aestes@apple.com>
1051
1052         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
1053         https://bugs.webkit.org/show_bug.cgi?id=200293
1054         <rdar://problem/52937749>
1055
1056         Reviewed by Alex Christensen.
1057
1058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1059         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
1060         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1061         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1062         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
1063         (TEST):
1064
1065 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
1066
1067         [ews-build] Enable all macOS queues on new EWS
1068         https://bugs.webkit.org/show_bug.cgi?id=199944
1069
1070         Reviewed by Jonathan Bedard.
1071
1072         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
1073         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1074         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
1075         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
1076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
1077         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
1078
1079 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1080
1081         Unreviewed test gardening, disable failing test for rdar://51752593.
1082
1083         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1084
1085 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
1086
1087         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
1088         https://bugs.webkit.org/show_bug.cgi?id=200318
1089
1090         Reviewed by Aakash Jain.
1091
1092         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1093         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
1094         (Timeline.CanvasXAxisComponent): Use getLabel function.
1095
1096 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
1097
1098         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
1099         https://bugs.webkit.org/show_bug.cgi?id=200306
1100
1101         Reviewed by Michael Catanzaro.
1102
1103         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
1104         jsc-glib-4.0-scan for example).
1105
1106         * Scripts/webkitdirs.pm:
1107         (generateBuildSystemFromCMakeProject):
1108
1109 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
1110
1111         Unreviewed test gardening, disable failing test for rdar://52355829.
1112
1113         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1114         (TEST):
1115
1116 2019-07-31  Keith Rollin  <krollin@apple.com>
1117
1118         Update WebKitLegacy for XCBuild
1119         https://bugs.webkit.org/show_bug.cgi?id=200310
1120         <rdar://problem/53773708>
1121
1122         Reviewed by Alex Christensen.
1123
1124         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
1125         technique. Now update WebKitLegacy to build under XCBuild after those
1126         changes. This work involves adding an "Apply Configuration to
1127         XCFileLists" build target, adding a check-xcfilelists.sh script,
1128         adding a "Check xcfilelists" build phase that calls that script,
1129         adding knowledge of the project to the generate-xcfilelists script,
1130         creating new .xcfilelist files, and adding those to the project.
1131
1132         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
1133         (Application.__init__):
1134         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1135         (JavaScriptCoreGenerator):
1136         (WebCoreGenerator):
1137         (WebKitGenerator):
1138         (WebKitGenerator._get_generate_unified_sources_script):
1139         (WebKitLegacyGenerator):
1140         (WebKitLegacyGenerator._get_project_file_path):
1141         (WebKitLegacyGenerator._get_generate_unified_sources_script):
1142
1143 2019-07-31  Chris Dumez  <cdumez@apple.com>
1144
1145         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1146         https://bugs.webkit.org/show_bug.cgi?id=200086
1147         <rdar://problem/53501721>
1148
1149         Reviewed by Alex Christensen.
1150
1151         re-enable the API test.
1152
1153         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1154         (TEST):
1155
1156 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1157
1158         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
1159         https://bugs.webkit.org/show_bug.cgi?id=200291
1160         <rdar://problem/53717946>
1161
1162         Reviewed by Megan Gardner.
1163
1164         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
1165         after closing the web view, while the web view's content view isn't the first responder.
1166
1167         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
1168         * TestWebKitAPI/ios/UIKitSPI.h:
1169
1170 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1171
1172         [GTK] Datalist element support for TextFieldInputType
1173         https://bugs.webkit.org/show_bug.cgi?id=98934
1174
1175         Reviewed by Michael Catanzaro.
1176
1177         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
1178
1179         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1180         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
1181         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
1182
1183 2019-07-30  Tim Horton  <timothy_horton@apple.com>
1184
1185         Remove some needless comments that snuck into the tree
1186
1187         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1188         (WTR::UIScriptController::setHardwareKeyboardAttached):
1189         (WTR::UIScriptController::playBackEventStream):
1190
1191 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1192
1193         [WebKit] Add PageLoadState::Observer C API
1194         https://bugs.webkit.org/show_bug.cgi?id=199848
1195
1196         Reviewed by Alex Christensen.
1197
1198         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1199         (WebKitBrowserWindow::WebKitBrowserWindow):
1200         (WebKitBrowserWindow::didChangeTitle):
1201         (WebKitBrowserWindow::didFinishNavigation): Deleted.
1202         * MiniBrowser/win/WebKitBrowserWindow.h:
1203         * TestWebKitAPI/CMakeLists.txt:
1204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1205         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
1206         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
1207         (TestWebKitAPI::didChangeActiveURL):
1208         (TestWebKitAPI::didChangeCanGoBack):
1209         (TestWebKitAPI::didChangeCanGoForward):
1210         (TestWebKitAPI::didChangeCertificateInfo):
1211         (TestWebKitAPI::didChangeEstimatedProgress):
1212         (TestWebKitAPI::didChangeHasOnlySecureContent):
1213         (TestWebKitAPI::didChangeIsLoading):
1214         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
1215         (TestWebKitAPI::didChangeTitle):
1216         (TestWebKitAPI::didChangeWebProcessIsResponsive):
1217         (TestWebKitAPI::didSwapWebProcesses):
1218         (TestWebKitAPI::willChangeActiveURL):
1219         (TestWebKitAPI::willChangeCanGoBack):
1220         (TestWebKitAPI::willChangeCanGoForward):
1221         (TestWebKitAPI::willChangeCertificateInfo):
1222         (TestWebKitAPI::willChangeEstimatedProgress):
1223         (TestWebKitAPI::willChangeHasOnlySecureContent):
1224         (TestWebKitAPI::willChangeIsLoading):
1225         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
1226         (TestWebKitAPI::willChangeTitle):
1227         (TestWebKitAPI::willChangeWebProcessIsResponsive):
1228         (TestWebKitAPI::didFinishNavigation):
1229         (TestWebKitAPI::TEST):
1230
1231 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
1232
1233         DumpRenderTree.app: Add CFBundleShortVersionString
1234         https://bugs.webkit.org/show_bug.cgi?id=200269
1235         <rdar://problem/53412596>
1236
1237         Rubber-stamped by Aakash Jain.
1238
1239         * DumpRenderTree/ios/Info.plist:
1240
1241 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1242
1243         Add layout test coverage for <https://webkit.org/b/200215>
1244         https://bugs.webkit.org/show_bug.cgi?id=200245
1245         <rdar://problem/52976965>
1246
1247         Reviewed by Tim Horton.
1248
1249         Add new testing infrastructure. See below for more details.
1250
1251         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1252         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1253         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1254         (WTR::UIScriptController::setWillCreateNewPageCallback):
1255         (WTR::UIScriptController::willCreateNewPageCallback const):
1256
1257         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
1258         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
1259
1260         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1261         (WTR::UIScriptController::becomeFirstResponder):
1262
1263         Add and implement a Cocoa platform hook to make the web view first responder.
1264
1265         * WebKitTestRunner/TestController.cpp:
1266         (WTR::TestController::createOtherPage):
1267         * WebKitTestRunner/TestInvocation.cpp:
1268         (WTR::TestInvocation::willCreateNewPage):
1269         * WebKitTestRunner/TestInvocation.h:
1270         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1271         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1272         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
1273
1274 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1275
1276         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
1277         https://bugs.webkit.org/show_bug.cgi?id=200217
1278
1279         Reviewed by Alex Christensen.
1280
1281         * MiniBrowser/win/BrowserWindow.h:
1282         * MiniBrowser/win/MainWindow.cpp:
1283         (MainWindow::init):
1284         (MainWindow::resizeSubViews):
1285         (MainWindow::WndProc):
1286         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
1287         * MiniBrowser/win/MiniBrowserLib.rc:
1288         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
1289         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1290         (WebKitBrowserWindow::reload):
1291         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
1292         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1293         (WebKitLegacyBrowserWindow::reload):
1294         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1295
1296 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1297
1298         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
1299         https://bugs.webkit.org/show_bug.cgi?id=200218
1300
1301         Reviewed by Alex Christensen.
1302
1303         Moved the scheme supplementing logic from
1304         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
1305
1306         * MiniBrowser/win/MainWindow.cpp:
1307         (MainWindow::loadURL):
1308         (MainWindow::onURLBarEnter):
1309         * MiniBrowser/win/MainWindow.h:
1310         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1311         (WebKitLegacyBrowserWindow::loadURL):
1312
1313 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
1314
1315         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
1316         https://bugs.webkit.org/show_bug.cgi?id=200254
1317
1318         Unreviewed infrastructure fix.
1319
1320         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
1321
1322 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
1323
1324         [Canvas Timeline] Compact canvas timeline
1325         https://bugs.webkit.org/show_bug.cgi?id=200177
1326
1327         Reviewed by Jonathan Bedard.
1328
1329         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
1330         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1331         (Timeline.CanvasSeriesComponent):
1332
1333 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1334
1335         Multiple context menu actions broken for YouTube videos
1336         https://bugs.webkit.org/show_bug.cgi?id=199999
1337
1338         Reviewed by Eric Carlson.
1339
1340         Add a test case to check copy link address, open in new window and download options are not included in the
1341         context menu for non-downloadable media.
1342
1343         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1344         (writeNextChunk):
1345         (serverCallback):
1346         (testContextMenuLiveStream):
1347         (beforeAll):
1348         (afterAll):
1349
1350 2019-07-28  Tim Horton  <timothy_horton@apple.com>
1351
1352         Reorganize UIScriptController into platform-specific subclasses
1353         https://bugs.webkit.org/show_bug.cgi?id=200027
1354
1355         Reviewed by Simon Fraser.
1356
1357         Instead of a mishmash of #ifdefs and extraneous empty functions,
1358         reorganize UIScriptController so that we have a base class
1359         with functions that assert if called (to make it harder to
1360         accidentally write a test that depends on unimplemented
1361         functionality), and override them in platform specific subclasses
1362         as functionality is added.
1363
1364         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1365         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
1366         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1367         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
1368         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1369         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1370         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1371         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1372         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
1373         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
1374         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
1375         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
1376         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
1377         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1378         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
1379         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1380
1381 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1382
1383         [Win][MiniBrowser] Remove PageLoadTestClient
1384         https://bugs.webkit.org/show_bug.cgi?id=200155
1385
1386         Reviewed by Brent Fulgham.
1387
1388         It is not used nowadays.
1389
1390         * MiniBrowser/win/CMakeLists.txt:
1391         * MiniBrowser/win/Common.cpp:
1392         (parseCommandLine):
1393         * MiniBrowser/win/Common.h:
1394         * MiniBrowser/win/MainWindow.cpp:
1395         (MainWindow::init):
1396         * MiniBrowser/win/MainWindow.h:
1397         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1398         (MiniBrowserWebHost::updateAddressBar):
1399         (MiniBrowserWebHost::didFinishLoadForFrame):
1400         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
1401         (MiniBrowserWebHost::didFailLoadWithError):
1402         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
1403         (MiniBrowserWebHost::didFirstLayoutInFrame):
1404         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
1405         * MiniBrowser/win/PageLoadTestClient.h: Removed.
1406         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1407         (ResourceLoadDelegate::identifierForInitialRequest):
1408         (ResourceLoadDelegate::willSendRequest):
1409         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1410         (ResourceLoadDelegate::didFailLoadingWithError):
1411         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1412         (WebKitBrowserWindow::create):
1413         (WebKitBrowserWindow::createNewPage):
1414         * MiniBrowser/win/WebKitBrowserWindow.h:
1415         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1416         (WebKitLegacyBrowserWindow::create):
1417         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
1418         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
1419         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1420         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
1421         * MiniBrowser/win/WinMain.cpp:
1422         (wWinMain):
1423
1424 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1425
1426         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
1427         https://bugs.webkit.org/show_bug.cgi?id=200150
1428         <rdar://problem/53280170>
1429
1430         Reviewed by Brent Fulgham.
1431
1432         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1433         (TestWebKitAPI::TEST):
1434
1435 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1436
1437         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
1438         https://bugs.webkit.org/show_bug.cgi?id=200090
1439
1440         Unreviewed follow-up fix.
1441
1442         * resultsdbpy/resultsdbpy/view/view_routes.py:
1443         (ViewRoutes.__init__): Keep /search endpoint for existing links
1444
1445 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1446
1447         results.webkit.org: Add switch to filter results by expectation
1448         https://bugs.webkit.org/show_bug.cgi?id=200134
1449
1450         Rubber-stamped by Aakash Jain.
1451
1452         Users of the results database should be able to easily differentiate tests which are expected
1453         to fail verse tests which are unexpectedly failing.
1454
1455         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1456         (Timeline.render): Respect the willFilterExpected variable.
1457         (LegendLabel): Generates html for label in the legend.
1458         (Legend): Add switch for filter results.
1459         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
1460         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1461
1462 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
1463
1464         [ews-build] Use update-webkit script in Style EWS
1465         https://bugs.webkit.org/show_bug.cgi?id=193196
1466
1467         Reviewed by Jonathan Bedard.
1468
1469         * BuildSlaveSupport/ews-build/factories.py:
1470         (StyleFactory): Updated to use CheckOutSource step as well.
1471         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
1472         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1473
1474 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1475
1476         results.webkit.org: Support buildbot 0.8 CI links
1477         https://bugs.webkit.org/show_bug.cgi?id=200146
1478
1479         Reviewed by Aakash Jain.
1480
1481         * resultsdbpy/resultsdbpy/model/ci_context.py:
1482         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
1483         (BuildbotEightURLFactory.__init__):
1484         (BuildbotEightURLFactory.url):
1485         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
1486         (URLFactoryTest.test_old_builder_url):
1487         (URLFactoryTest):
1488         (URLFactoryTest.test_old_worker_url):
1489
1490 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1491
1492         results.webkit.org: Suite results shouldn't be the landing page
1493         https://bugs.webkit.org/show_bug.cgi?id=200090
1494
1495         Reviewed by Aakash Jain.
1496
1497         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
1498         * resultsdbpy/resultsdbpy/view/view_routes.py:
1499         (ViewRoutes.__init__): Make search the landing page instead of suite results.
1500         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
1501         (WebSiteUnittest.test_main):
1502
1503 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
1504
1505         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
1506         https://bugs.webkit.org/show_bug.cgi?id=200127
1507
1508         Unreviewed follow-up fix.
1509
1510         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1511         (Dot.toString): Use self instead of this in render callback.
1512
1513 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
1514
1515         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
1516         https://bugs.webkit.org/show_bug.cgi?id=200108
1517         <rdar://problem/53521238>
1518
1519         Reviewed by Chris Dumez.
1520
1521         Added an API test.
1522
1523         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1524         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
1525         (TEST):
1526
1527 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
1528
1529         results.webkit.org: Color should be the worst result, count should include all results
1530         https://bugs.webkit.org/show_bug.cgi?id=200127
1531
1532         Rubber-stamped by Aakash Jain.
1533
1534         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1535         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
1536
1537 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
1538
1539         [Timeline]: Make timeline header width automatic, instead of fixed width
1540         https://bugs.webkit.org/show_bug.cgi?id=200059
1541
1542         Reviewed by Jonathan Bedard.
1543
1544         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1545         (.dot.crash):
1546         (.timeline>.header): Deleted.
1547         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1548         (.timeline>.content):
1549         (.timeline>.header):
1550
1551 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
1552
1553         [ESNext] Implement nullish coalescing
1554         https://bugs.webkit.org/show_bug.cgi?id=200072
1555
1556         Reviewed by Darin Adler.
1557
1558         * Scripts/run-jsc-stress-tests:
1559
1560 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1561
1562         Add Takashi Komori and Tomoki Imai as contributors
1563
1564         Unreviewed.
1565
1566         * Scripts/webkitpy/common/config/contributors.json:
1567
1568 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
1569
1570         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
1571         https://bugs.webkit.org/show_bug.cgi?id=200103
1572
1573         Reviewed by Mark Lam.
1574
1575         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
1576         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
1577
1578         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
1579         to the future implementation changes while it catches the severe issues we had.
1580
1581         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1582         (assertEmptyPointerSet):
1583         (assertHasOnlyObjects):
1584         (assertClean):
1585         (TEST):
1586         (allocateAndDeallocate):
1587
1588 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1589
1590         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
1591         https://bugs.webkit.org/show_bug.cgi?id=200074
1592
1593         Reviewed by Michael Catanzaro.
1594
1595         There was a latent issue. PluginTest::indicateTestFailure was
1596         using WTF::sleep without linking WTF.
1597
1598         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1599         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
1600
1601 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
1602
1603         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
1604         https://bugs.webkit.org/show_bug.cgi?id=200073
1605
1606         Reviewed by Michael Catanzaro.
1607
1608         * TestWebKitAPI/PlatformGTK.cmake:
1609         * TestWebKitAPI/PlatformWPE.cmake:
1610         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
1611
1612 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1613
1614         [webkitperl] runCommand doesn't work in Windows Perl
1615         https://bugs.webkit.org/show_bug.cgi?id=199900
1616
1617         Reviewed by Don Olmstead.
1618
1619         runCommand was always failing implicit fork by using 'open' with
1620         '-|' in Windows Perl. Explicitly specify the command to 'open' not
1621         to do the implicit fork.
1622
1623         There is one more difference between Windows and Unix. 'open'
1624         successes on Windows even for non existent command while it fails
1625         on Unix. So, return the same error code on Unix as well as
1626         Windows.
1627
1628         * Scripts/VCSUtils.pm: Specified the command to 'open'.
1629         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
1630         command is not available on Windows. Use Perl ($^X) instead.
1631
1632 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
1633
1634         Allow Clients to Add Fields to the AutoFillContext Dictionary.
1635         https://bugs.webkit.org/show_bug.cgi?id=199326
1636         rdar://problem/42816957
1637
1638         Reviewed by Wenson Hsieh.
1639
1640         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1641         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
1642         is being properly populated with additional context dictionary.
1643
1644         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
1645         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
1646         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
1647         which will populate the additional autofill context dictionary.
1648
1649         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
1650         populates the additional autofill context dictionary.
1651
1652         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
1653         context dictionary.
1654
1655         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
1656         input field requires strong password work.
1657
1658         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
1659         input field requires strong password work.
1660
1661         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
1662         password work.
1663
1664 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
1665
1666         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
1667         https://bugs.webkit.org/show_bug.cgi?id=199489
1668
1669         Reviewed by Aakash Jain.
1670
1671         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1672         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
1673         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
1674         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1675         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
1676         (runTest): Record test binary failure
1677         (reportTestFailures): Report test binary failure
1678         (runJSCStressTests):
1679         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
1680         (JscOnlyPort.build_jsc_command):
1681         (JscOnlyPort):
1682         (JscOnlyPort.run_javascriptcore_tests_command):
1683         * Scripts/webkitpy/common/config/ports_unittest.py:
1684         (DeprecatedPortTest.test_jsconly_port):
1685
1686 2019-07-24  Zalan Bujtas  <zalan@apple.com>
1687
1688         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
1689         https://bugs.webkit.org/show_bug.cgi?id=200079
1690         <rdar://problem/53474325>
1691
1692         Reviewed by Wenson Hsieh.
1693
1694         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
1695
1696         * WebKitTestRunner/ios/TestControllerIOS.mm:
1697         (WTR::TestController::platformResetPreferencesToConsistentValues):
1698
1699 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1700
1701         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
1702         https://bugs.webkit.org/show_bug.cgi?id=199927
1703
1704         Reviewed by Alex Christensen.
1705
1706         convertAbsolutepathToWebKitPath was failing to convert paths on
1707         Windows Perl due to path separators mismatch.
1708
1709         Renamed convertAbsolutepathToWebKitPath to
1710         convertAbsolutePathToRelativeUnixPath, and changed it to replace
1711         paths to relative Unix paths.
1712
1713         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1714         (convertAbsolutePathToRelativeUnixPath): Added.
1715         (convertAbsolutepathToWebKitPath): Deleted.
1716
1717 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1718
1719         Fix iOS API test after r247759
1720         https://bugs.webkit.org/show_bug.cgi?id=200045
1721
1722         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1723         (TEST):
1724         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
1725         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
1726
1727 2019-07-23  Keith Rollin  <krollin@apple.com>
1728
1729         Remove rest of NavigatorContentUtils support
1730         https://bugs.webkit.org/show_bug.cgi?id=200052
1731         <rdar://problem/53467357>
1732
1733         Reviewed by Alex Christensen.
1734
1735         Bug 196070 removes most of the support for the never-used
1736         NavigatorContentUtils facility. However, there were still a couple of
1737         left-over references after that change. This patch sweeps those up.
1738
1739         * Scripts/webkitperl/FeatureList.pm:
1740
1741 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1742
1743         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
1744         https://bugs.webkit.org/show_bug.cgi?id=200045
1745
1746         Reviewed by Mark Lam.
1747
1748         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1749         (TEST):
1750
1751 2019-07-23  Russell Epstein  <repstein@apple.com>
1752
1753         Unreviewed, rolling out r247745.
1754
1755         This broke API test
1756         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
1757         indicated by EWS
1758
1759         Reverted changeset:
1760
1761         "Move javaScriptConfigurationDirectory SPI from
1762         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
1763         runtime switchable"
1764         https://bugs.webkit.org/show_bug.cgi?id=200045
1765         https://trac.webkit.org/changeset/247745
1766
1767 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1768
1769         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
1770         https://bugs.webkit.org/show_bug.cgi?id=200045
1771
1772         Reviewed by Mark Lam.
1773
1774         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1775         (TEST):
1776
1777 2019-07-23  Alex Christensen  <achristensen@webkit.org>
1778
1779         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
1780         https://bugs.webkit.org/show_bug.cgi?id=199972
1781
1782         Reviewed by Jer Noble.
1783
1784         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1785         (TEST):
1786
1787 2019-07-23  Alicia Boya García  <aboya@igalia.com>
1788
1789         [WTF] Add DataMutex and MainThreadData wrappers
1790         https://bugs.webkit.org/show_bug.cgi?id=199831
1791
1792         Reviewed by Alex Christensen.
1793
1794         Added a very simple test that checks that DataMutex<T> indeed takes
1795         the lock and indeed holds data.
1796
1797         * TestWebKitAPI/CMakeLists.txt:
1798         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
1799         (TestWebKitAPI::TEST):
1800
1801 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1802
1803         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
1804         https://bugs.webkit.org/show_bug.cgi?id=200021
1805         <rdar://problem/53301325>
1806
1807         Reviewed by Ryosuke Niwa.
1808
1809         Add support for grabbing the child menu items of a context menu item.
1810
1811         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1812         (WTR::getMenuItemChildrenCallback):
1813
1814 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
1815
1816         WebKit should strip away system font names from the pasted content
1817         https://bugs.webkit.org/show_bug.cgi?id=199975
1818         <rdar://problem/53336353>
1819
1820         Reviewed by Darin Adler.
1821
1822         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
1823
1824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1825         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1826         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
1827
1828 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1829
1830         [ews-build] EWS fails to parse multi-line full_results.json
1831         https://bugs.webkit.org/show_bug.cgi?id=199992
1832
1833         Reviewed by Alexey Proskuryakov.
1834
1835         * BuildSlaveSupport/ews-build/layout_test_failures.py:
1836         (LayoutTestFailures.results_from_string): Concatenate content into single line.
1837         * BuildSlaveSupport/ews-build/steps_unittest.py:
1838         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
1839
1840 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1841
1842         resultsdbpy: Handle case where the previous commit doesn't have the changelog
1843         https://bugs.webkit.org/show_bug.cgi?id=200015
1844
1845         Reviewed by Aakash Jain.
1846
1847         * resultsdbpy/resultsdbpy/model/repository.py:
1848         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
1849
1850 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1851
1852         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
1853         https://bugs.webkit.org/show_bug.cgi?id=200013
1854         <rdar://problem/52526901>
1855
1856         Reviewed by Simon Fraser.
1857
1858         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
1859
1860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1861         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
1862         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
1863         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
1864         * TestWebKitAPI/ios/UIKitSPI.h:
1865
1866 2019-07-22  Jer Noble  <jer.noble@apple.com>
1867
1868         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
1869         https://bugs.webkit.org/show_bug.cgi?id=199971
1870         <rdar://problem/51951218>
1871
1872         Reviewed by Alex Christensen.
1873
1874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1875         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
1876         (TestWebKitAPI::TEST):
1877
1878 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1879
1880         [ews-build] Add an EWS to run services tests
1881         https://bugs.webkit.org/show_bug.cgi?id=199994
1882
1883         Reviewed by Jonathan Bedard.
1884
1885         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
1886         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
1887         * BuildSlaveSupport/ews-build/steps.py:
1888         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
1889         (RunEWSUnitTests): Build step to run EWS unit-tests.
1890         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
1891         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1892         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
1893
1894 2019-07-22  Youenn Fablet  <youenn@apple.com>
1895
1896         Disable MediaRecorder for legacy WebKit
1897         https://bugs.webkit.org/show_bug.cgi?id=200001
1898         <rdar://problem/53400030>
1899
1900         Reviewed by Eric Carlson.
1901
1902         Enable MediaRecorder for testing purposes.
1903
1904         * DumpRenderTree/mac/DumpRenderTree.mm:
1905         (createWebViewAndOffscreenWindow):
1906
1907 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
1908
1909         results.webkit.org: Timeline header is too small
1910         https://bugs.webkit.org/show_bug.cgi?id=199955
1911
1912         Reviewed by Aakash Jain.
1913
1914         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
1915         (.timeline>.header): Make timeline header larder to fit configuration names.
1916
1917 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1918
1919         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
1920         https://bugs.webkit.org/show_bug.cgi?id=199954
1921
1922         Reviewed by Geoff Garen.
1923
1924         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1925         (TEST):
1926
1927 2019-07-22  Alex Christensen  <achristensen@webkit.org>
1928
1929         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
1930         https://bugs.webkit.org/show_bug.cgi?id=199917
1931
1932         Reviewed by Sam Weinig.
1933
1934         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1935         (TEST):
1936
1937 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
1938
1939         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
1940         https://bugs.webkit.org/show_bug.cgi?id=199980
1941
1942         Reviewed by Jonathan Bedard.
1943
1944         * BuildSlaveSupport/ews-build/steps.py:
1945         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
1946         * BuildSlaveSupport/ews-build/steps_unittest.py:
1947         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
1948         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
1949
1950 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1951
1952         [webkitpy] Add an unit test for setting up the driver environment without starting it.
1953         https://bugs.webkit.org/show_bug.cgi?id=199945
1954
1955         Reviewed by Michael Catanzaro.
1956
1957         This adds an unit test for the change implemented in r247663.
1958
1959         * Scripts/webkitpy/port/driver_unittest.py:
1960         (DriverTest.test_setup_environ_base_vars):
1961         (DriverTest):
1962         (DriverTest.test_setup_environ_without_starting_driver):
1963
1964 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1965
1966         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
1967         https://bugs.webkit.org/show_bug.cgi?id=199993
1968         <rdar://problem/49523528>
1969
1970         Reviewed by Beth Dakin.
1971
1972         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
1973
1974         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1975         (TestWebKitAPI::TEST):
1976         * TestWebKitAPI/cocoa/TestWKWebView.h:
1977
1978 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
1979
1980         Add accessibilityInsertText for text insertion in edit fields.
1981         https://bugs.webkit.org/show_bug.cgi?id=199973
1982
1983         Reviewed by Chris Fleizach.
1984
1985         Renamed accessibilityInsertText to _accessibilityInsertText.
1986
1987         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1988         (AccessibilityUIElement::insertText):
1989         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1990         (AccessibilityUIElement::insertText):
1991         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1992         (WTR::AccessibilityUIElement::insertText):
1993         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1994         (WTR::AccessibilityUIElement::insertText):
1995
1996 2019-07-20  Chris Dumez  <cdumez@apple.com>
1997
1998         Speed up HashTable decoding by reserving capacity and avoiding rehashing
1999         https://bugs.webkit.org/show_bug.cgi?id=199982
2000
2001         Reviewed by Saam Barati.
2002
2003         Add API test coverage.
2004
2005         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2006         (TestWebKitAPI::TEST):
2007
2008 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
2009
2010         Add accessibilityInsertText for text insertion in edit fields.
2011         https://bugs.webkit.org/show_bug.cgi?id=199973
2012
2013         Reviewed by Chris Fleizach.
2014
2015         Glue code to run new LayoutTests.
2016         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2017         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2018         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2019         (WTR::AccessibilityUIElement::insertText):
2020         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2021         (WTR::AccessibilityUIElement::insertText):
2022         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2023         (WTR::AccessibilityUIElement::insertText):
2024         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2025         (WTR::AccessibilityUIElement::insertText):
2026
2027 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
2028
2029         Move webkit.css to opensource to support resultsdbpy's frontend
2030         https://bugs.webkit.org/show_bug.cgi?id=199957
2031
2032         Reviewed by Jonathan Bedard.
2033
2034         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
2035         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
2036         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
2037         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
2038
2039 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
2040
2041         Move Ref.js to WebKit to support resultsdbpy's frontend
2042         https://bugs.webkit.org/show_bug.cgi?id=199956
2043
2044         Reviewed by Jonathan Bedard.
2045
2046         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2047         * resultsdbpy/resultsdbpy/view/static/js/search.js:
2048         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2049         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
2050         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
2051         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
2052         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
2053         * resultsdbpy/resultsdbpy/view/templates/base.html:
2054         * resultsdbpy/resultsdbpy/view/templates/commits.html:
2055         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
2056         * resultsdbpy/resultsdbpy/view/templates/search.html:
2057         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2058         * resultsdbpy/resultsdbpy/view/view_routes.py:
2059
2060 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2061
2062         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
2063         https://bugs.webkit.org/show_bug.cgi?id=199945
2064
2065         Reviewed by Michael Catanzaro.
2066
2067         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
2068         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
2069         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
2070
2071         * Scripts/webkitpy/port/driver.py:
2072         (Driver._setup_environ_for_driver):
2073         (Driver._create_temporal_directories):
2074         (Driver):
2075         (Driver._start):
2076         (Driver._delete_temporal_directories):
2077         (Driver.stop):
2078         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
2079         (main):
2080         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
2081         (WebDriverTestRunner.__init__):
2082         * glib/api_test_runner.py:
2083         (TestRunner._setup_testing_environment): Ditto.
2084
2085 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
2086
2087         [ews-build] Display pre-existing Layout test failure names in the build summary
2088         https://bugs.webkit.org/show_bug.cgi?id=199941
2089
2090         Reviewed by Jonathan Bedard.
2091
2092         * BuildSlaveSupport/ews-build/steps.py:
2093         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2094
2095 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2096
2097         [GTK][WPE] run-webkit-tests should run with a temporal homedir
2098         https://bugs.webkit.org/show_bug.cgi?id=199738
2099
2100         Reviewed by Michael Catanzaro.
2101
2102         Run the tests with an empty homedir that is created inside the driver tmpdir.
2103         The driver tmpdir is a random directory created for each test runner that is purged after the run.
2104
2105         This is done to ensure that the test results are not affected by the user settings of any library.
2106
2107         * Scripts/webkitpy/port/driver.py:
2108         (Driver._setup_environ_for_driver):
2109         * Scripts/webkitpy/port/driver_unittest.py:
2110         (DriverTest.test_setup_environ_base_vars):
2111         (DriverTest):
2112         (DriverTest.test_create_temporal_home_dir):
2113
2114 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2115
2116         Remove pywebsockets from thirdparty
2117         https://bugs.webkit.org/show_bug.cgi?id=199710
2118
2119         Reviewed by Jonathan Bedard.
2120
2121         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
2122         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
2123
2124         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2125         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
2126         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
2127         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
2128         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
2129         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
2130         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
2131         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
2132         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
2133         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
2134         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
2135         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
2136         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
2137         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
2138         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
2139         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
2140         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
2141         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
2142         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
2143         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
2144         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
2145         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
2146
2147 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
2148
2149         results.webkit.org: Move resultsdbpy to WebKit
2150         https://bugs.webkit.org/show_bug.cgi?id=199837
2151         <rdar://problem/53172130>
2152
2153         Rubber-stamped by Aakash Jain.
2154
2155         Moving the entirety of the resultsdbpy library, which provides utilities to build
2156         a database designed to store, visualize and organize test results, into WebKit.
2157
2158         * Scripts/webkitpy/style/checker.py:
2159         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
2160         * resultsdbpy: Added.
2161         * resultsdbpy/MANIFEST.in: Added.
2162         * resultsdbpy/README.md: Added.
2163         * resultsdbpy/resultsdbpy: Added.
2164         * resultsdbpy/resultsdbpy/__init__.py: Added.
2165         * resultsdbpy/resultsdbpy/controller: Added.
2166         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
2167         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
2168         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
2169         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
2170         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
2171         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
2172         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
2173         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
2174         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
2175         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
2176         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
2177         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
2178         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
2179         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
2180         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
2181         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
2182         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
2183         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
2184         * resultsdbpy/resultsdbpy/flask_support: Added.
2185         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
2186         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
2187         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
2188         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
2189         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
2190         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
2191         * resultsdbpy/resultsdbpy/model: Added.
2192         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
2193         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
2194         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
2195         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
2196         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
2197         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
2198         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
2199         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
2200         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
2201         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
2202         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
2203         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
2204         * resultsdbpy/resultsdbpy/model/docker.py: Added.
2205         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
2206         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
2207         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
2208         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
2209         * resultsdbpy/resultsdbpy/model/model.py: Added.
2210         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
2211         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
2212         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
2213         * resultsdbpy/resultsdbpy/model/repository.py: Added.
2214         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
2215         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
2216         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
2217         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
2218         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
2219         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
2220         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
2221         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
2222         * resultsdbpy/resultsdbpy/run-tests: Added.
2223         * resultsdbpy/resultsdbpy/view: Added.
2224         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
2225         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
2226         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
2227         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
2228         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
2229         * resultsdbpy/resultsdbpy/view/static: Added.
2230         * resultsdbpy/resultsdbpy/view/static/css: Added.
2231         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
2232         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
2233         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
2234         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
2235         * resultsdbpy/resultsdbpy/view/static/js: Added.
2236         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
2237         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
2238         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
2239         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
2240         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
2241         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
2242         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
2243         * resultsdbpy/resultsdbpy/view/templates: Added.
2244         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
2245         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
2246         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
2247         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
2248         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
2249         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
2250         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
2251         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
2252         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
2253         * resultsdbpy/setup.py: Added.
2254
2255 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2256
2257         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
2258         https://bugs.webkit.org/show_bug.cgi?id=199923
2259
2260         Reviewed by Youenn Fablet.
2261
2262         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2263         (TestWebKitAPI::TEST):
2264
2265 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2266
2267         [ews-build] Enable iOS WK2 tester queue on new EWS
2268         https://bugs.webkit.org/show_bug.cgi?id=199867
2269
2270         Reviewed by Jonathan Bedard.
2271
2272         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
2273         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
2274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
2275         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
2276
2277 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
2278
2279         [ews-build] Add build step to AnalyzeLayoutTestsResults
2280         https://bugs.webkit.org/show_bug.cgi?id=199877
2281
2282         Reviewed by Jonathan Bedard.
2283
2284         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
2285
2286         * BuildSlaveSupport/ews-build/steps.py:
2287         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
2288         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
2289         (AnalyzeLayoutTestsResults.report_failure):
2290         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2291         (AnalyzeLayoutTestsResults.retry_build):
2292         (AnalyzeLayoutTestsResults._results_failed_different_tests):
2293         (AnalyzeLayoutTestsResults._report_flaky_tests):
2294         (AnalyzeLayoutTestsResults.start):
2295         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2296
2297 2019-07-18  Alex Christensen  <achristensen@webkit.org>
2298
2299         Move NetworkCache ownership from NetworkProcess to NetworkSession
2300         https://bugs.webkit.org/show_bug.cgi?id=199817
2301
2302         Reviewed by Geoff Garen.
2303
2304         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2305         (TEST):
2306         * TestWebKitAPI/cocoa/TestWKWebView.h:
2307         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2308         (-[WKWebView synchronouslyLoadRequest:]):
2309
2310 2019-07-18  Youenn Fablet  <youenn@apple.com>
2311
2312         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
2313         https://bugs.webkit.org/show_bug.cgi?id=199769
2314         <rdar://problem/49390297>
2315
2316         Reviewed by Myles C. Maxfield.
2317
2318         Add a font containing one extended character not found in system fonts.
2319
2320         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2321         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
2322
2323 2019-07-18  Konstantin Tokarev  <annulen@yandex.ru>
2324
2325         Unreviewed, Add Olivier Blin as contributor
2326
2327         * Scripts/webkitpy/common/config/contributors.json:
2328
2329 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2330
2331         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2332         https://bugs.webkit.org/show_bug.cgi?id=199855
2333
2334         Reviewed by Michael Catanzaro.
2335
2336         The webkitpy drivers for GTK and WPE use their own versions for setting
2337         up the environment and starting/stopping the drivers.
2338         This refactors those drivers to use the base class driver functions.
2339         As a benefit we get some fixes like support for setting the profiler
2340         environment variables, and a simpler code.
2341
2342         * Scripts/webkitpy/port/driver.py:
2343         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2344         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2345         * Scripts/webkitpy/port/headlessdriver.py:
2346         (HeadlessDriver._setup_environ_for_test):
2347         * Scripts/webkitpy/port/waylanddriver.py:
2348         (WaylandDriver._setup_environ_for_test):
2349         * Scripts/webkitpy/port/westondriver.py:
2350         (WestonDriver._setup_environ_for_test):
2351         (WestonDriver.stop):
2352         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2353         (WestonDriverTest.make_driver):
2354         * Scripts/webkitpy/port/xorgdriver.py:
2355         (XorgDriver._setup_environ_for_test):
2356         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2357         (XvfbDriver._setup_environ_for_test):
2358         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2359         (XvfbDriverTest.make_driver):
2360         (XvfbDriverTest.test_start):
2361         (XvfbDriverTest.test_start_arbitrary_worker_number):
2362         * Scripts/webkitpy/w3c/wpt_runner.py:
2363         (main): Start the driver before trying to get its environment to define all the environment variables.
2364         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2365         (WebDriverTestRunner.__init__): Ditto.
2366         * glib/api_test_runner.py:
2367         (TestRunner._setup_testing_environment): Ditto.
2368
2369 2019-07-17  Antoine Quint  <graouts@apple.com>
2370
2371         Disable Pointer Events prior to watchOS 6
2372         https://bugs.webkit.org/show_bug.cgi?id=199890
2373         <rdar://problem/53206113>
2374
2375         Reviewed by Dean Jackson.
2376
2377         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2378
2379 2019-07-17  Christopher Reid  <chris.reid@sony.com>
2380
2381         Bytecode cache should use FileSystem
2382         https://bugs.webkit.org/show_bug.cgi?id=199759
2383
2384         Reviewed by Yusuke Suzuki.
2385
2386         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2387
2388 2019-07-17  Jonathan Bedard  <jbedard@apple.com>
2389
2390         check-webkit-style: Add limited Python3 support
2391         https://bugs.webkit.org/show_bug.cgi?id=199870
2392
2393         Rubber-stamped by Aakash Jain.
2394
2395         Since new services will be added in the near future which are Python 3, we
2396         need to support Python 3 style checks. For now, assume all Python files are
2397         Python 2 unless otherwise specified.
2398
2399         * Scripts/webkitpy/style/checker.py:
2400         (_all_categories): Add pycodestyle to valid categories for testing.
2401         (CheckerDispatcher._create_checker): Check that the provided Python file is in
2402         one of the declared Python 3 directories.
2403         * Scripts/webkitpy/style/checkers/python.py:
2404         (Python3Checker): Add Python 3 checker, which doesn't lint and uses pycodestyle
2405         instead of pep8.
2406         (Python3Checker.__init__):
2407         (Python3Checker.check):
2408         * Scripts/webkitpy/thirdparty/__init__.py:
2409         (AutoinstallImportHook.find_module): Support auto-installing pycodestyle.
2410         (AutoinstallImportHook._install_pycodestyle):
2411
2412 2019-07-17  Sam Weinig  <weinig@apple.com>
2413
2414         Add StringBuilder member function which allows makeString() style variadic argument construction
2415         https://bugs.webkit.org/show_bug.cgi?id=198997
2416
2417         Reviewed by Darin Adler.
2418
2419         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2420         Add basic test showing that StringBuilder::flexibleAppend can be used to
2421         append one or more string adaptable types.
2422
2423         * TestWebKitAPI/CMakeLists.txt:
2424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2425         Add WTFStringUtilities.cpp
2426
2427         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2428         Add basic test showing that StringBuilder::flexibleAppend can be used to
2429         append one or more string adaptable types.
2430
2431         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2432         * TestWebKitAPI/WTFStringUtilities.cpp: Added.
2433         * TestWebKitAPI/WTFStringUtilities.h:
2434         Move WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING() and wtfStringCopyCount to WTFStringUtilities.h/cpp
2435         to allow for a single definition of StringTypeAdapter<String, void> which is required for ODR.
2436
2437 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2438
2439         Remove the file superfluously added in r247535.
2440
2441         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Removed.
2442         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
2443
2444 2019-07-17  Alex Christensen  <achristensen@webkit.org>
2445
2446         Add a runtime-disabled dialog element skeleton
2447         https://bugs.webkit.org/show_bug.cgi?id=199839
2448
2449         Reviewed by Ryosuke Niwa.
2450
2451         * DumpRenderTree/mac/DumpRenderTree.mm:
2452         (resetWebPreferencesToConsistentValues):
2453         * WebKitTestRunner/TestController.cpp:
2454         (WTR::TestController::resetPreferencesToConsistentValues):
2455         Enable the dialog element for layout tests.
2456
2457 2019-07-17  Ryosuke Niwa  <rniwa@webkit.org>
2458
2459         [iOS] Option + Up or Down Arrow key doesn’t move cursor past paragraph boundaries in WebKit2
2460         https://bugs.webkit.org/show_bug.cgi?id=199851
2461
2462         Reviewed by Wenson Hsieh.
2463
2464         Added a regression test for iOS. Unfortunately, event sender, etc... doesn't work because
2465         this code is getting directly triggered from UIKeyboard's code.
2466
2467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2468         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.h: Added.
2469         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: Added.
2470         * TestWebKitAPI/ios/UIKitSPI.h:
2471
2472 2019-07-17  Commit Queue  <commit-queue@webkit.org>
2473
2474         Unreviewed, rolling out r247505.
2475         https://bugs.webkit.org/show_bug.cgi?id=199871
2476
2477         "Caused failed ASSERT in stress test" (Requested by creid on
2478         #webkit).
2479
2480         Reverted changeset:
2481
2482         "Bytecode cache should use FileSystem"
2483         https://bugs.webkit.org/show_bug.cgi?id=199759
2484         https://trac.webkit.org/changeset/247505
2485
2486 2019-07-17  Russell Epstein  <russell_e@apple.com>
2487
2488         Adding self to contributors.json
2489
2490         Unreviewed.
2491
2492         * Scripts/webkitpy/common/config/contributors.json:
2493
2494 2019-07-17  Aakash Jain  <aakash_jain@apple.com>
2495
2496         [ews-build] Parse full_results.json for layout-tests
2497         https://bugs.webkit.org/show_bug.cgi?id=199804
2498
2499         Reviewed by Jonathan Bedard.
2500
2501         * BuildSlaveSupport/ews-build/steps.py:
2502         (RunWebKitTests.start): Monitor json output.
2503         (RunWebKitTests.commandComplete): Read json output, parse the results and set Buildbot properties accordingly. These
2504         properties would be used in subsequent AnalyzeLayoutTests build step to determine whether the failures are introduced
2505         by the patch or are pre-existing.
2506         (ReRunWebKitTests.commandComplete): Ditto.
2507         (RunWebKitTestsWithoutPatch.commandComplete): Ditto.
2508         * BuildSlaveSupport/ews-build/steps_unittest.py:
2509         (BuildStepMixinAdditions.getProperty): Added.
2510         (TestRunWebKitTests.test_parse_results_json): Added unit-tests.
2511         * BuildSlaveSupport/ews-build/layout_test_failures.py: Parse full_results.json and generate list of failing tests.
2512
2513 2019-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2514
2515         Unreviewed, rolling out r247512.
2516
2517         Broke API test runners
2518
2519         Reverted changeset:
2520
2521         "[GTK][WPE][webkitpy] Refactor drivers to use the base driver
2522         for setting up the environment and start the drivers."
2523         https://bugs.webkit.org/show_bug.cgi?id=199855
2524         https://trac.webkit.org/changeset/247512
2525
2526 2019-07-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2527
2528         [GTK][WPE][webkitpy] Refactor drivers to use the base driver for setting up the environment and start the drivers.
2529         https://bugs.webkit.org/show_bug.cgi?id=199855
2530
2531         Reviewed by Carlos Garcia Campos.
2532
2533         The webkitpy drivers for GTK and WPE use their own versions for setting
2534         up the environment and starting/stopping the drivers.
2535         This refactors those drivers to use the base class driver functions.
2536         As a benefit we get some fixes like support for setting the profiler
2537         environment variables, and a simpler code.
2538
2539         * Scripts/webkitpy/port/driver.py:
2540         (Driver._setup_environ_for_driver): This already correctly setups LOCAL_RESOURCE_ROOT and DUMPRENDERTREE_TEMP.
2541         Add the remaining environment variable XDG_CACHE_HOME that is needed for Linux.
2542         * Scripts/webkitpy/port/headlessdriver.py:
2543         (HeadlessDriver._setup_environ_for_test):
2544         * Scripts/webkitpy/port/waylanddriver.py:
2545         (WaylandDriver._setup_environ_for_test):
2546         * Scripts/webkitpy/port/westondriver.py:
2547         (WestonDriver._setup_environ_for_test):
2548         (WestonDriver.stop):
2549         * Scripts/webkitpy/port/westondriver_unittest.py: now mock _test_runner_process_constructor as base driver does.
2550         (WestonDriverTest.make_driver):
2551         * Scripts/webkitpy/port/xorgdriver.py:
2552         (XorgDriver._setup_environ_for_test):
2553         * Scripts/webkitpy/port/xvfbdriver.py: the xvfb binary is started with the port server env
2554         (XvfbDriver._setup_environ_for_test):
2555         * Scripts/webkitpy/port/xvfbdriver_unittest.py: rename the variable to make clearer that it uses the port server env.
2556         (XvfbDriverTest.make_driver):
2557         (XvfbDriverTest.test_start):
2558         (XvfbDriverTest.test_start_arbitrary_worker_number):
2559
2560 2019-07-16  Christopher Reid  <chris.reid@sony.com>
2561
2562         Bytecode cache should use FileSystem
2563         https://bugs.webkit.org/show_bug.cgi?id=199759
2564
2565         Reviewed by Yusuke Suzuki.
2566
2567         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2568
2569 2019-07-16  Jonathan Bedard  <jbedard@apple.com>
2570
2571         svn-create-patch duplicates diffs when adding directories
2572         https://bugs.webkit.org/show_bug.cgi?id=199842
2573
2574         Reviewed by Dewei Zhu.
2575
2576         * Scripts/svn-create-patch:
2577         (findKind): Add function which returns what 'kind' of file the provided path is.
2578         (generateFileList): If the path is a directory and being added, don't add it.
2579         Instead, rely on the fact that its children will be added.
2580
2581 2019-07-16  Tim Horton  <timothy_horton@apple.com>
2582
2583         NSTextFinder holes don't scroll with the page
2584         https://bugs.webkit.org/show_bug.cgi?id=199815
2585         <rdar://problem/52280514>
2586
2587         Reviewed by Simon Fraser.
2588
2589         * MiniBrowser/mac/WK2BrowserWindowController.m:
2590         (-[MiniBrowserNSTextFinder performAction:]):
2591         (-[WK2BrowserWindowController awakeFromNib]):
2592         Adopt the WebKit UI in MiniBrowser. Also, override NSTextFinder's
2593         -performAction: so that we can intercept the close action and
2594         hide our own find UI, since there is no delegate for that action yet.
2595
2596         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2597         (TEST):
2598
2599 2019-07-15  Keith Miller  <keith_miller@apple.com>
2600
2601         JSGlobalObject type macros should support feature flags and WeakRef should have one
2602         https://bugs.webkit.org/show_bug.cgi?id=199601
2603
2604         Reviewed by Mark Lam.
2605
2606         JSC options need to be set before the window is created for the test.
2607
2608         * DumpRenderTree/mac/DumpRenderTree.mm:
2609         (resetWebViewToConsistentStateBeforeTesting):
2610         * DumpRenderTree/win/DumpRenderTree.cpp:
2611         (setJSCOptions):
2612         (resetWebViewToConsistentStateBeforeTesting):
2613
2614 2019-07-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
2615
2616         [ Mojave WK1 ] Some Image tests are flakey failures and are failing in tandem with zoomed in or blank image results
2617         https://bugs.webkit.org/show_bug.cgi?id=193108
2618
2619         Reviewed by Simon Fraser.
2620
2621         Add a workaround for <rdar://problem/17084993> in createBitmapContextFromWebView().
2622         Re-request the snapshot at kCGWindowImageNominalResolution if it was captured
2623         at the wrong scale.
2624
2625         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2626         (takeWindowSnapshot):
2627         (createBitmapContextFromWebView):
2628
2629 2019-07-15  Brady Eidson  <beidson@apple.com>
2630
2631         Make WKURLSchemeTask thread safe.
2632         <rdar://problem/50471863> and https://bugs.webkit.org/show_bug.cgi?id=199764
2633
2634         Reviewed by Alex Christensen.
2635
2636         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2637
2638 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2639
2640         Unreviewed, a build fix after r247437
2641
2642         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2643         Added platform guard towards -[WKUIDelegate _presentingViewControllerForWebView:].
2644
2645 2019-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2646
2647         [macOS 10.15] Cannot unbold selected text when the system font is used
2648         https://bugs.webkit.org/show_bug.cgi?id=199788
2649         <rdar://problem/52142570>
2650
2651         Reviewed by Tim Horton.
2652
2653         Add a new API test to verify that bolding and unbolding updates the
2654         shared font manager's selected font.
2655
2656         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2657         (TestWebKitAPI::TEST):
2658
2659 2019-07-15  Jiewen Tan  <jiewen_tan@apple.com>
2660
2661         [iOS] SOAuthorizationSession should tell AppSSO whether the UIClient is capable of showing the extension UI
2662         https://bugs.webkit.org/show_bug.cgi?id=199790
2663         <rdar://problem/52790112>
2664
2665         Reviewed by Brent Fulgham.
2666
2667         Add tests to check SOAuthorization.enableEmbeddedAuthorizationViewController accordingly.
2668
2669         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2670         (-[TestSOAuthorizationDelegate _presentingViewControllerForWebView:]):
2671         (configureSOAuthorizationWebView):
2672         (TestWebKitAPI::TEST):
2673         (-[TestSOAuthorizationNavigationDelegate init]): Deleted.
2674         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]): Deleted.
2675         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2676         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
2677         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]): Deleted.
2678
2679 2019-07-15  Sihui Liu  <sihui_liu@apple.com>
2680
2681         window.openDatabase is not writable
2682         https://bugs.webkit.org/show_bug.cgi?id=199737
2683         <rdar://problem/52551332>
2684
2685         Reviewed by Chris Dumez.
2686
2687         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm:
2688         (TEST):
2689         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:
2690
2691 2019-07-15  Aakash Jain  <aakash_jain@apple.com>
2692
2693         [ews-build] Parse and display layout test failures
2694         https://bugs.webkit.org/show_bug.cgi?id=199709
2695
2696         Rubber-stamped by Jonathan Bedard.
2697
2698         * BuildSlaveSupport/ews-build/steps.py:
2699         (RunWebKitTests.start): Initialize log_observer.
2700         (RunWebKitTests._strip_python_logging_prefix): Copied from similar code in build.webkit.org buildbot config.
2701         (RunWebKitTests._parseRunWebKitTestsOutput): Ditto.
2702         (RunWebKitTests.commandComplete): Gather and parse the stdout and stderr logs.
2703         (RunWebKitTests.evaluateResult): Analyze the results and decide build status.
2704         (RunWebKitTests.getResultSummary): Update build and step summary.
2705         * BuildSlaveSupport/ews-build/steps_unittest.py: Added and updated unit-tests.
2706
2707 2019-07-15  Commit Queue  <commit-queue@webkit.org>
2708
2709         Unreviewed, rolling out r247393.
2710         https://bugs.webkit.org/show_bug.cgi?id=199797
2711
2712         broke mips and arm EWS (Requested by guijemont on #webkit).
2713
2714         Reverted changeset:
2715
2716         "run-javascriptcore-tests won't report test results for
2717         testmasm, testair, testb3, testdfg and test api"
2718         https://bugs.webkit.org/show_bug.cgi?id=199489
2719         https://trac.webkit.org/changeset/247393
2720
2721 2019-07-12  Andy Estes  <aestes@apple.com>
2722
2723         [Cocoa] -loadFileURL:allowingReadAccessToURL: should fully resolve file URLs
2724         https://bugs.webkit.org/show_bug.cgi?id=199768
2725         <rdar://problem/52002206>
2726
2727         Reviewed by Geoffrey Garen.
2728
2729         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2730         (TEST):
2731
2732 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2733
2734         [ews-build] Remove wincairo queue from old EWS and dashboard
2735         https://bugs.webkit.org/show_bug.cgi?id=199776
2736
2737         Reviewed by Don Olmstead.
2738
2739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2740         * QueueStatusServer/config/queues.py:
2741
2742 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2743
2744         [ews-build] Enable wincairo queue on new EWS
2745         https://bugs.webkit.org/show_bug.cgi?id=199593
2746
2747         Reviewed by Don Olmstead.
2748
2749         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for wincairo builder.
2750         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for wincairo factory.
2751         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2752         (StatusBubble): Enable wincairo status-bubble.
2753
2754 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2755
2756         [ews-app] Enable logging for clicking SubmitToEWS button
2757         https://bugs.webkit.org/show_bug.cgi?id=199757
2758
2759         Unreviewed minor infrastructure fix.
2760
2761         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2762         (SubmitToEWS.post): Change logging level from debug to info.
2763
2764 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2765
2766         Enable client certificate authentication unit test
2767         https://bugs.webkit.org/show_bug.cgi?id=199735
2768
2769         Reviewed by Chris Dumez.
2770
2771         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2772         (TEST):
2773         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
2774         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
2775
2776 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2777
2778         Begin unifying TestWebKitAPI build
2779         https://bugs.webkit.org/show_bug.cgi?id=199728
2780
2781         Reviewed by Keith Miller.
2782
2783         * TestWebKitAPI/Configurations/Base.xcconfig:
2784         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
2785         * TestWebKitAPI/Sources.txt: Added.
2786         * TestWebKitAPI/SourcesCocoa.txt: Added.
2787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2788
2789 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
2790
2791         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
2792         https://bugs.webkit.org/show_bug.cgi?id=199489
2793         <rdar://problem/47891081>
2794
2795         Reviewed by Aakash Jain.
2796
2797         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2798         (RunJavaScriptCoreTests.countFailures):
2799         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2800         * Scripts/run-javascriptcore-tests:
2801         (runTest):
2802         (reportTestFailures):
2803         (runJSCStressTests):
2804
2805 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
2806
2807         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
2808         https://bugs.webkit.org/show_bug.cgi?id=199743
2809
2810         Reviewed by Jonathan Bedard.
2811
2812         * BuildSlaveSupport/ews-build/steps.py:
2813         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2814
2815 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2816
2817         Unreviewed follow-up fix to r247364.
2818         [ews-build] Add build step to clean up .git/index.lock file
2819         https://bugs.webkit.org/show_bug.cgi?id=199722
2820
2821         * BuildSlaveSupport/ews-build/steps.py:
2822         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
2823         to be run after this step.
2824
2825 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
2826
2827         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
2828         https://bugs.webkit.org/show_bug.cgi?id=199524
2829         <rdar://problem/52783816>
2830
2831         Reviewed by Saam Barati.
2832
2833         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
2834         But this test has several problems.
2835
2836         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
2837            number is calculated by pageSize / sizeof(T), and this does not account the header
2838            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
2839            is very small, we can have many objects in one IsoPage. As a result, we need a large
2840            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
2841            less than numObjects.
2842
2843         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
2844            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
2845            page. This also makes the intention of this test wrong.
2846
2847         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
2848
2849         We make this test robust while we still keep this test white-box one to test the critical feature
2850         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
2851         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
2852         tier live, and check whether the deallocated memory is reused.
2853
2854         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2855         (TEST):
2856
2857 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
2858
2859         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
2860         https://bugs.webkit.org/show_bug.cgi?id=199625
2861
2862         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
2863         with ENABLE(ACCESSIBILITY) in the code.
2864
2865         Additionally, the TestRunner code generator now honors the
2866         Conditional IDL format.
2867
2868         Reviewed by Konstantin Tokarev.
2869
2870         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2871         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2872         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2873         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2874         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2875         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2876         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2877         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2878         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2879         (_generateImplementationFile):
2880
2881 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
2882
2883         [ews-build] Add build step to clean up .git/index.lock file
2884         https://bugs.webkit.org/show_bug.cgi?id=199722
2885
2886         Reviewed by Jonathan Bedard.
2887
2888         * BuildSlaveSupport/ews-build/steps.py:
2889         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
2890         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
2891         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
2892         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2893
2894 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
2895
2896         [iOS 13] Enable WebKit build
2897         https://bugs.webkit.org/show_bug.cgi?id=199481
2898         <rdar://problem/52619048>
2899
2900         Reviewed by Tim Horton.
2901
2902         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
2903
2904 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
2905
2906         Add test expectations and baselines for iOS 13
2907         https://bugs.webkit.org/show_bug.cgi?id=199329
2908
2909         Reviewed by Jonathan Bedard.
2910
2911         * Scripts/webkitpy/port/ios.py:
2912         (IOSPort): Increment current version to 13.
2913         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
2914         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
2915         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
2916         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
2917         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
2918         (IOSSimulatorTest.make_port):
2919         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
2920         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
2921         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
2922         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
2923         (IOSTest.make_port):
2924
2925 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
2926
2927         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
2928         https://bugs.webkit.org/show_bug.cgi?id=199692
2929
2930         Reviewed by Chris Fleizach.
2931
2932         Add support for output of AXDeletion and AXInsertion roles for tests.
2933         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
2934         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
2935
2936         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2937         * gtk/jhbuild.modules:
2938         * wpe/jhbuild.modules:
2939
2940 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
2941
2942         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
2943         https://bugs.webkit.org/show_bug.cgi?id=199707
2944
2945         Reviewed by Aakash Jain.
2946
2947         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
2948
2949 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
2950
2951         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
2952         https://bugs.webkit.org/show_bug.cgi?id=199693
2953         rdar://problem/51930364
2954
2955         Reviewed by Tim Horton.
2956
2957         New API tests that test scrollability with various combinations of content, insets,
2958         input accessory bars etc.
2959
2960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2961         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
2962         (TestWebKitAPI::webViewWithAutofocusedInput):
2963         (TestWebKitAPI::TEST):
2964
2965 2019-07-10  Tim Horton  <timothy_horton@apple.com>
2966
2967         Long pressing on attachments will crash the WebContent process
2968         https://bugs.webkit.org/show_bug.cgi?id=199696
2969         <rdar://problem/52920241>
2970
2971         Reviewed by Dean Jackson.
2972
2973         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2974         (TestWebKitAPI::TEST):
2975         Add a test that previously crashed.
2976
2977 2019-07-10  Dean Jackson  <dino@apple.com>
2978
2979         Support MacCatalyst in run-webkit-app
2980         https://bugs.webkit.org/show_bug.cgi?id=199690
2981
2982         Reviewed by Tim Horton.
2983
2984         Add a --maccatalyst option to run-webkit-app that
2985         can launch MacCatalyst applications with a built WebKit.
2986
2987         * Scripts/webkitdirs.pm:
2988         (argumentsForConfiguration):
2989         (determineXcodeSDK):
2990         (xcodeSDKPlatformName):
2991         (determineConfigurationProductDir):
2992         (determinePortName):
2993         (isCatalystWebKit):
2994         (isAppleCocoaWebKit):
2995         (willUseCatalystSDK):
2996
2997 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
2998
2999         [MacOS] Filter VPA info logged to stdout
3000         https://bugs.webkit.org/show_bug.cgi?id=199673
3001
3002         Reviewed by Eric Carlson.
3003
3004         * Scripts/webkitpy/port/mac.py:
3005         (MacPort.logging_patterns_to_strip):
3006
3007 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
3008
3009         Unreviewed, rolling out r247286.
3010
3011         Caused TestWTF.WTF.StringOperators to fail on debug bots
3012
3013         Reverted changeset:
3014
3015         "Add StringBuilder member function which allows makeString()
3016         style variadic argument construction"
3017         https://bugs.webkit.org/show_bug.cgi?id=198997
3018         https://trac.webkit.org/changeset/247286
3019
3020 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
3021
3022         [ews-build] Explicitly use perl or python while invoking scripts
3023         https://bugs.webkit.org/show_bug.cgi?id=199669
3024
3025         Reviewed by Jonathan Bedard.
3026
3027         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
3028         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
3029
3030 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
3031
3032         Run tests on mips EWS
3033         https://bugs.webkit.org/show_bug.cgi?id=196854
3034
3035         Reviewed by Carlos Garcia Campos.
3036
3037         * Scripts/webkitpy/common/config/ews.json:
3038
3039 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3040
3041         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
3042         https://bugs.webkit.org/show_bug.cgi?id=199579
3043
3044         Reviewed by Carlos Garcia Campos.
3045
3046         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
3047         (TestWebKitAPI::TEST):
3048
3049 2019-07-09  Chris Dumez  <cdumez@apple.com>
3050
3051         Fix integer type encoding / decoding in WKRemoteObjectCoder
3052         https://bugs.webkit.org/show_bug.cgi?id=199643
3053         <rdar://problem/52732342>
3054
3055         Reviewed by Anders Carlsson.
3056
3057         Update API test coverage.
3058
3059         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3060         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3061         (TEST):
3062         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3063         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
3064         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
3065         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
3066         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
3067
3068 2019-07-09  Sam Weinig  <weinig@apple.com>
3069
3070         Add StringBuilder member function which allows makeString() style variadic argument construction
3071         https://bugs.webkit.org/show_bug.cgi?id=198997
3072
3073         Reviewed by Darin Adler.
3074
3075         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3076         Add basic test showing that StringBuilder::flexibleAppend can be used to
3077         append one or more string adaptable types.
3078
3079 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
3080
3081         Only allow fetching and removing session credentials from WebsiteDataStore
3082         https://bugs.webkit.org/show_bug.cgi?id=199385
3083         <rdar://problem/52622080>
3084
3085         Reviewed by Alex Christensen.
3086
3087         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
3088         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
3089         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
3090
3091         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3092         (TEST):
3093         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3094         (TestWebKitAPI::TEST):
3095
3096 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3097
3098         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
3099         https://bugs.webkit.org/show_bug.cgi?id=199628
3100
3101         Reviewed by Brady Eidson.
3102
3103         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3104         (TestWebKitAPI::TEST_F):
3105
3106 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3107
3108         Remove invalid assertion in URLParser::domainToASCII
3109         https://bugs.webkit.org/show_bug.cgi?id=199624
3110
3111         Reviewed by Brady Eidson.
3112
3113         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3114         (TestWebKitAPI::TEST_F):
3115
3116 2019-07-09  Alex Christensen  <achristensen@webkit.org>
3117
3118         URLParser should reserialize IPv6 addresses that end with a colon
3119         https://bugs.webkit.org/show_bug.cgi?id=199627
3120
3121         Reviewed by Brady Eidson.
3122
3123         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3124         (TestWebKitAPI::TEST_F):
3125
3126 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3127
3128         [ews-build] Do not run unix commands for windows in PrintConfiguration
3129         https://bugs.webkit.org/show_bug.cgi?id=199605
3130
3131         Reviewed by Jonathan Bedard.
3132
3133         * BuildSlaveSupport/ews-build/steps.py:
3134
3135 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3136
3137         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
3138         https://bugs.webkit.org/show_bug.cgi?id=199487
3139
3140         Reviewed by Ross Kirsling.
3141
3142         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
3143         failing to open testglobalscope_constructors_file which was
3144         created by using tempfile.mkstemp() because it keeps the file
3145         open. Use tempfile.mkdtemp() to create temporary files in the
3146         temporary directory instead of tempfile.mkstemp().
3147
3148         * Scripts/webkitpy/bindings/main.py:
3149         (BindingsTests.run_tests):
3150         (BindingsTests.main):
3151         (BindingsTests.close_and_remove): Deleted.
3152
3153 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
3154
3155         [ews-build] Add KillOldProcesses step before running API or Layout tests
3156         https://bugs.webkit.org/show_bug.cgi?id=199592
3157
3158         Reviewed by Jonathan Bedard.
3159
3160         * BuildSlaveSupport/ews-build/factories.py:
3161
3162 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
3163
3164         test-webkitpy: Explicitly use Python 2.7 lldb library
3165         https://bugs.webkit.org/show_bug.cgi?id=199578
3166         <rdar://problem/51853557>
3167
3168         Reviewed by Aakash Jain.
3169
3170         * Scripts/webkitpy/common/system/systemhost.py:
3171         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
3172         * Scripts/webkitpy/test/main.py:
3173         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
3174
3175 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
3176
3177         Add test expectations and baselines for Catalina
3178         https://bugs.webkit.org/show_bug.cgi?id=199328
3179
3180         Reviewed by Jonathan Bedard.
3181
3182         * Scripts/webkitpy/port/mac.py:
3183         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
3184
3185 2019-07-08  Christopher Reid  <chris.reid@sony.com>
3186
3187         Implement MappedFileData for Windows
3188         https://bugs.webkit.org/show_bug.cgi?id=198269
3189
3190         Reviewed by Darin Adler.
3191
3192         * TestWebKitAPI/PlatformWin.cmake:
3193
3194 2019-07-08  Charlie Turner  <cturner@igalia.com>
3195
3196         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
3197         https://bugs.webkit.org/show_bug.cgi?id=197558
3198
3199         Reviewed by Xabier Rodriguez-Calvar.
3200
3201         On shutdown we can easily deadlock the web process if we don't
3202         ensure all network operations are completed before comitting state
3203         changes. In HLS, make sure the network operations are cancelled,
3204         and also prevent hlsdemux's retry logic from scuppering our
3205         efforts.
3206
3207         * gstreamer/jhbuild.modules: Include the patch.
3208         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
3209
3210 2019-07-08  Antoine Quint  <graouts@apple.com>
3211
3212         [Pointer Events] Enable only on the most recent version of the supported iOS family
3213         https://bugs.webkit.org/show_bug.cgi?id=199562
3214         <rdar://problem/52766511>
3215
3216         Reviewed by Dean Jackson.
3217
3218         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3219
3220 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
3221
3222         Long hang when loading a cnn.com page on iOS
3223         https://bugs.webkit.org/show_bug.cgi?id=199556
3224
3225         Reviewed by Zalan Bujtas.
3226
3227         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
3228         to load a test page of your choice.
3229
3230         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
3231         (-[WebViewController viewDidLoad]):
3232
3233 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3234
3235         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
3236         https://bugs.webkit.org/show_bug.cgi?id=199503
3237
3238         Reviewed by Wenson Hsieh.
3239
3240         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
3241         _requestActivatedElementAtPosition
3242
3243         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3244         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3245         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3246         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3247         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3248         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3249         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3250         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3251         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3252         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3253         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
3254         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
3255
3256 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3257
3258         Unreviewed, rolling out r247115.
3259
3260         Breaks lldbWebKitTester (and by extension, test-webkitpy)
3261
3262         Reverted changeset:
3263
3264         "[WHLSL] Standard library is too big to directly include in
3265         WebCore"
3266         https://bugs.webkit.org/show_bug.cgi?id=198186
3267         https://trac.webkit.org/changeset/247115
3268
3269 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
3270
3271         Unreviewed, rolling out r247123.
3272
3273         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
3274         fail.
3275
3276         Reverted changeset:
3277
3278         "Only allow fetching and removing session credentials from
3279         WebsiteDataStore"
3280         https://bugs.webkit.org/show_bug.cgi?id=199385
3281         https://trac.webkit.org/changeset/247123
3282
3283 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3284
3285         Touching media controls sometimes shows software keyboard
3286         https://bugs.webkit.org/show_bug.cgi?id=199490
3287         <rdar://problem/52076270>
3288
3289         Reviewed by Eric Carlson.
3290
3291         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
3292         ChangeLog entries for more detail.
3293
3294         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3295         (WTR::UIScriptController::hasInputSession const):
3296         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3297         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3298         (WTR::UIScriptController::hasInputSession const):
3299         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3300         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3301         (WTR::UIScriptController::hasInputSession const):
3302
3303 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
3304
3305         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
3306         https://bugs.webkit.org/show_bug.cgi?id=199458
3307
3308         Reviewed by Michael Catanzaro.
3309
3310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3311         * QueueStatusServer/config/queues.py:
3312
3313 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3314
3315         [GTK] Fix browserperfdash script after r239522
3316         https://bugs.webkit.org/show_bug.cgi?id=199496
3317
3318         Reviewed by Michael Catanzaro.
3319
3320         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
3321         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
3322
3323 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3324
3325         [webkitpy] test-webkitpy is broken on Linux since r246662
3326         https://bugs.webkit.org/show_bug.cgi?id=199493
3327
3328         Reviewed by Michael Catanzaro.
3329
3330         * Scripts/webkitpy/test/main.py:
3331         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
3332
3333 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3334
3335         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
3336         https://bugs.webkit.org/show_bug.cgi?id=199406
3337
3338         Reviewed by Michael Catanzaro.
3339
3340         Install the Woff2 libraries and headers from the system package
3341         and stop building them on the JHBuild.
3342
3343         * gtk/install-dependencies:
3344         * gtk/jhbuild.modules:
3345         * wpe/install-dependencies:
3346         * wpe/jhbuild.modules:
3347
3348 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3349
3350         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
3351         https://bugs.webkit.org/show_bug.cgi?id=199449
3352
3353         Reviewed by Michael Catanzaro.
3354
3355         * Scripts/webkitdirs.pm:
3356         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
3357
3358 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3359
3360         Unreviewed, GTK a11y tests fix after r247071
3361
3362         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3363         (WTR::AccessibilityUIElement::popupValue const):
3364
3365 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3366
3367         [ews-build] Enable WPE and GTK queues on new EWS
3368         https://bugs.webkit.org/show_bug.cgi?id=199234
3369
3370         Reviewed by Jonathan Bedard.
3371
3372         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
3373         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
3374         * BuildSlaveSupport/ews-build/steps.py:
3375         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
3376         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3377         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3378         (StatusBubble): Enable gtk and wpe status-bubbles.
3379
3380 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
3381
3382         Only allow fetching and removing session credentials from WebsiteDataStore
3383         https://bugs.webkit.org/show_bug.cgi?id=199385
3384
3385         Reviewed by Alex Christensen.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3388         (TestWebKitAPI::TEST):
3389
3390 2019-07-03  Tim Horton  <timothy_horton@apple.com>
3391
3392         UI process exception when dragging an <attachment> with no content type
3393         https://bugs.webkit.org/show_bug.cgi?id=199480
3394         <rdar://problem/44351353>
3395
3396         Reviewed by Wenson Hsieh.
3397
3398         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3399         (TestWebKitAPI::TEST):
3400         Add a test; before the change, it crashes.
3401
3402 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
3403
3404         [Catalina] Enable WebKit build
3405         https://bugs.webkit.org/show_bug.cgi?id=199209
3406
3407         Reviewed by Darin Adler.
3408
3409         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
3410
3411 2019-07-03  Sam Weinig  <weinig@apple.com>
3412
3413         Adopt simple structured bindings in more places
3414         https://bugs.webkit.org/show_bug.cgi?id=199247
3415
3416         Reviewed by Alex Christensen.
3417
3418         Replaces simple uses of std::tie() with structured bindings. Does not touch
3419         uses of std::tie() that are not initial declarations, use std::ignore or in
3420         case where the binding is captured by a lambda, as structured bindings don't
3421         work for those cases yet.
3422
3423         * TestWebKitAPI/ios/PreferredContentMode.mm:
3424         (TestWebKitAPI::TEST):
3425
3426 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
3427
3428         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
3429
3430         * BuildSlaveSupport/ews-build/steps.py:
3431         (PrintConfiguration.run):
3432
3433 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3434
3435         [ews-build] Add build steps to Install Wpe and Gtk dependencies
3436         https://bugs.webkit.org/show_bug.cgi?id=199408
3437
3438         Reviewed by Michael Catanzaro.
3439
3440         * BuildSlaveSupport/ews-build/steps.py:
3441         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
3442         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
3443         (InstallWpeDependencies): Ditto for WPE.
3444         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3445
3446 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3447
3448         [ews-build] Allow skipping uploading built product for few builders
3449         https://bugs.webkit.org/show_bug.cgi?id=199422
3450
3451         Reviewed by Michael Catanzaro.
3452
3453         * BuildSlaveSupport/ews-build/steps.py:
3454         (CompileWebKit.__init__): Added optional skipUpload parameter.
3455         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
3456
3457 2019-07-02  Tim Horton  <timothy_horton@apple.com>
3458
3459         REGRESSION (r243240): Unable to swipe back in Safari
3460         https://bugs.webkit.org/show_bug.cgi?id=199394
3461         <rdar://problem/51137447>
3462
3463         Reviewed by Wenson Hsieh.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3466         Make sure that we actually end up with swipe gesture recognizers installed
3467         after process swap and crash.
3468
3469 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
3470
3471         Enhance support of aria-haspopup per ARIA 1.1 specification.
3472         https://bugs.webkit.org/show_bug.cgi?id=199216
3473         <rdar://problem/46221342>
3474
3475         Reviewed by Chris Fleizach.
3476
3477         * DumpRenderTree/AccessibilityUIElement.cpp:
3478         (getPopupValueCallback):
3479         (AccessibilityUIElement::getJSClass):
3480         * DumpRenderTree/AccessibilityUIElement.h:
3481         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3482         (AccessibilityUIElement::popupValue const):
3483         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3484         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3485         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3486         (WTR::AccessibilityUIElement::popupValue const):
3487         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3488         (WTR::AccessibilityUIElement::popupValue const):
3489
3490 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3491
3492         [ews-build] Do not print worker environment variables in each build step [part 2]
3493         https://bugs.webkit.org/show_bug.cgi?id=199405
3494
3495         Reviewed by Jonathan Bedard.
3496
3497         * BuildSlaveSupport/ews-build/steps.py:
3498         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
3499         (CleanWorkingDirectory.__init__): Ditto.
3500         (RunBindingsTests.__init__): Ditto.
3501         (RunWebKitPerlTests.__init__): Ditto.
3502         (RunWebKitPyTests.__init__): Ditto.
3503         (CompileWebKit.__init__): Ditto.
3504         (ArchiveTestResults.__init__): Ditto.
3505         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3506
3507 2019-07-02  Jer Noble  <jer.noble@apple.com>
3508
3509         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
3510         https://bugs.webkit.org/show_bug.cgi?id=199381
3511         <rdar://problem/52483103>
3512
3513         Reviewed by Eric Carlson.
3514
3515         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
3516
3517 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3518
3519         [ews-build] Update bot configuration for WPE and GTK
3520         https://bugs.webkit.org/show_bug.cgi?id=199238
3521
3522         Reviewed by Michael Catanzaro.
3523
3524         * BuildSlaveSupport/ews-build/config.json:
3525
3526 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
3527
3528         [ews-build] Make PrintConfiguration platform aware
3529         https://bugs.webkit.org/show_bug.cgi?id=196657
3530
3531         Reviewed by Lucas Forschler.
3532
3533         * BuildSlaveSupport/ews-build/steps.py:
3534         (PrintConfiguration): Specified platform-specific command lists.
3535         (PrintConfiguration.run): Override run method and specify platform specific commands.
3536         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3537
3538 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
3539
3540         [Wasm-References] Disable references by default
3541         https://bugs.webkit.org/show_bug.cgi?id=199390
3542
3543         Reviewed by Saam Barati.
3544
3545         * Scripts/run-jsc-stress-tests:
3546
3547 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
3548
3549         Unreviewed. Revert r246965 to fix build break
3550         since r247019 reverted its related changes.
3551
3552         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3553         (WTR::AccessibilityUIElement::popupValue const): Deleted.
3554
3555 2019-07-01  Alex Christensen  <achristensen@webkit.org>
3556
3557         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
3558         https://bugs.webkit.org/show_bug.cgi?id=199371
3559         <rdar://problem/52352905>
3560
3561         Reviewed by Tim Horton.
3562
3563         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3564         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
3565         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
3566         (-[NavigationActionSPIDelegate spiCalled]):
3567         (TEST):
3568
3569 2019-07-01  Alex Christensen  <achristensen@webkit.org>
3570
3571         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
3572         https://bugs.webkit.org/show_bug.cgi?id=199296
3573         <rdar://problem/51041960>
3574
3575         Reviewed by Darin Adler.
3576
3577         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3578         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
3579
3580 2019-07-01  Truitt Savell  <tsavell@apple.com>
3581
3582         Unreviewed, rolling out r246958.
3583
3584         Broke inspector/dom/getAccessibilityPropertiesForNode.html
3585
3586         Reverted changeset:
3587
3588         "Enhance support of aria-haspopup per ARIA 1.1 specification."
3589         https://bugs.webkit.org/show_bug.cgi?id=199216
3590         https://trac.webkit.org/changeset/246958
3591
3592 2019-07-01  Philippe Normand  <pnormand@igalia.com>
3593
3594         Unreviewed, GTK a11y tests fix after r246958
3595
3596         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3597         (WTR::AccessibilityUIElement::popupValue const):
3598
3599 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
3600
3601         Enhance support of aria-haspopup per ARIA 1.1 specification.
3602         https://bugs.webkit.org/show_bug.cgi?id=199216
3603         <rdar://problem/46221342>
3604
3605         Reviewed by Chris Fleizach.
3606
3607         * DumpRenderTree/AccessibilityUIElement.cpp:
3608         (getPopupValueCallback):
3609         (AccessibilityUIElement::getJSClass):
3610         * DumpRenderTree/AccessibilityUIElement.h:
3611         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3612         (AccessibilityUIElement::popupValue const):
3613         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3614         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3615         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3616         (WTR::AccessibilityUIElement::popupValue const):
3617         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3618         (WTR::AccessibilityUIElement::popupValue const):
3619
3620 2019-06-28  Robin Morisset  <rmorisset@apple.com>
3621
3622         Adding myself as a reviewer to contributors.json.
3623
3624         Unreviewed.
3625
3626         * Scripts/webkitpy/common/config/contributors.json:
3627
3628 2019-06-28  Jer Noble  <jer.noble@apple.com>
3629
3630         Add new -[WKWebView _closeAllMediaPresentations] SPI
3631         https://bugs.webkit.org/show_bug.cgi?id=199294
3632         <rdar://problem/51965958>
3633
3634         Reviewed by Alex Christensen.
3635
3636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3637         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
3638         (TEST):
3639
3640 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
3641
3642         Add a regression test for change r246901
3643         https://bugs.webkit.org/show_bug.cgi?id=199290
3644
3645         Reviewed by Geoffrey Garen.
3646
3647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3648         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3649         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3650         (TEST):
3651         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
3652
3653 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
3654
3655         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
3656         https://bugs.webkit.org/show_bug.cgi?id=199317
3657
3658         Reviewed by Michael Catanzaro.