02fe19e61d994043a8e22a92e2a5da38316f4108
[WebKit-https.git] / Tools / ChangeLog
1 2018-02-15  Tomas Popela  <tpopela@redhat.com>
2
3         run-jsc-stress-tests - skip a test if any of the run commands evals to skip
4         https://bugs.webkit.org/show_bug.cgi?id=182729
5
6         If multiple run commands are specified and one of them evals to skip,
7         then the test is not skipped, because the run is scheduled while
8         evaluating other commands.
9
10         Remember if the test is going to be skipped - if yes, just stop
11         evaluating the other run commands.
12
13         Reviewed by Saam Barati.
14
15         * Scripts/run-jsc-stress-tests:
16
17 2018-02-14  Charlie Turner  <cturner@igalia.com>
18
19         Get Garden-O-Matic running again.
20         https://bugs.webkit.org/show_bug.cgi?id=179089
21
22         Reviewed by Carlos Alberto Lopez Perez.
23
24         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
25         (parseCommitData): Author field is not always spelled 'author' these days.
26         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
27         No longer have a 32-bit builder.
28         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
29         (ui.perf.View.base.init): createElement has a required parameter these days.
30         * Scripts/webkitpy/tool/commands/gardenomatic.py:
31         (GardenOMatic): Override use_globs so that platform lookup in config.js works.
32
33 2018-02-14  Don Olmstead  <don.olmstead@sony.com>
34
35         Remove unused ForwardingHeaders directories from Tools
36         https://bugs.webkit.org/show_bug.cgi?id=182813
37
38         Reviewed by Konstantin Tokarev.
39
40         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Removed.
41         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Removed.
42         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed.
43         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Removed.
44         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Removed.
45
46 2018-02-14  Daniel Bates  <dabates@apple.com>
47
48         Disallow cross-origin subresources from asking for credentials
49         https://bugs.webkit.org/show_bug.cgi?id=182579
50         <rdar://problem/36162271>
51
52         Reviewed by Andy Estes.
53
54         Add test option allowCrossOriginSubresourcesToAskForCredential (defaults to false)
55         so that tests can toggle between the old behavior and new behavior.
56
57         * DumpRenderTree/TestOptions.h:
58         * DumpRenderTree/TestOptions.mm:
59         (TestOptions::TestOptions):
60         * DumpRenderTree/mac/DumpRenderTree.mm:
61         (setWebPreferencesForTestOptions):
62         * WebKitTestRunner/TestController.cpp:
63         (WTR::TestController::resetPreferencesToConsistentValues):
64         (WTR::updateTestOptionsFromTestHeader):
65         * WebKitTestRunner/TestOptions.h:
66         (WTR::TestOptions::hasSameInitializationOptions const):
67
68 2018-02-12  Ryosuke Niwa  <rniwa@webkit.org>
69
70         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
71         https://bugs.webkit.org/show_bug.cgi?id=182564
72
73         Reviewed by Wenson Hsieh.
74
75         Updated assertions to make sure the trailing "}" of @list rules is includd in the style, the "style" element
76         is wrapped by "head" element (not present in the pasted markup since the fragment parsing algorithm strips away),
77         and the style content is enclosed in "<!--" and "-->".
78
79         Also use execCommand('insertHTML', ~) to insert the HTML obtained via dataTransfer.getData instead of innerHTML
80         to make sure our pasting code preserves the special style element for MSO list quirks.
81
82         Finally, added two more test cases for pasting content from Microsoft Word's compatibility mode.
83
84         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
85         (TEST):
86         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
87         (TEST):
88
89 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
90
91         [Tools] --wincairo should imply --64-bit by default.
92         https://bugs.webkit.org/show_bug.cgi?id=182753
93
94         Reviewed by Daniel Bates.
95
96         WinCairo does not currently support 32-bit and `--wincairo` itself should refer to a working platform.
97         This patch ensures x64 is determined correctly for `build-webkit --no-ninja` and `run-webkit-tests`.
98
99         * Scripts/webkitdirs.pm:
100         (determinePassedArchitecture):
101         (shouldBuild32Bit):
102         (determineShouldBuild32Bit):
103         (determineIsWin64):
104         * Scripts/webkitpy/common/config/ports.py:
105         (WinCairoPort.build_webkit_command):
106         * Scripts/webkitpy/common/config/ports_unittest.py:
107         (DeprecatedPortTest.test_wincairo_port):
108         * Scripts/webkitpy/port/win.py:
109         (WinCairoPort):
110
111 2018-02-13  Commit Queue  <commit-queue@webkit.org>
112
113         Unreviewed, rolling out r228431.
114         https://bugs.webkit.org/show_bug.cgi?id=182766
115
116         Regressed CMake build stability (Requested by dolmstead on
117         #webkit).
118
119         Reverted changeset:
120
121         "[CMake] Make WebCore headers copies"
122         https://bugs.webkit.org/show_bug.cgi?id=182512
123         https://trac.webkit.org/changeset/228431
124
125 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
126
127         [CMake] Make WebCore headers copies
128         https://bugs.webkit.org/show_bug.cgi?id=182512
129
130         Reviewed by Keith Miller.
131
132         * DumpRenderTree/CMakeLists.txt:
133         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
134         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
135         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
136         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
137         * TestWebKitAPI/PlatformGTK.cmake:
138         * TestWebKitAPI/PlatformWPE.cmake:
139         * TestWebKitAPI/PlatformWin.cmake:
140         * TestWebKitAPI/win/TestWebCoreStubs.cpp:
141         (loadResourceIntoBuffer):
142         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
143         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
144         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
145         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
146         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
147
148 2018-02-13  Chris Dumez  <cdumez@apple.com>
149
150         REGRESSION (r228299): Broke reader mode in Safari
151         https://bugs.webkit.org/show_bug.cgi?id=182697
152         <rdar://problem/37399012>
153
154         Reviewed by Ryosuke Niwa.
155
156         Add API test coverage for responding asynchronously to the decidePolicyForNavigationResponse
157         delegate.
158
159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
160         * TestWebKitAPI/Tests/WebKitCocoa/AsyncPolicyForNavigationResponse.mm: Added.
161         (-[TestAsyncNavigationDelegate webView:didFinishNavigation:]):
162         (-[TestAsyncNavigationDelegate webView:didFailNavigation:withError:]):
163         (-[TestAsyncNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
164         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
165         (-[TestAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
166         (TestWebKitAPI::TEST):
167
168 2018-02-12  John Wilander  <wilander@apple.com>
169
170         Resource Load Statistics: Classify resources as prevalent based on redirects to other prevalent resources
171         https://bugs.webkit.org/show_bug.cgi?id=182664
172         <rdar://problem/37372572>
173
174         Reviewed by Brent Fulgham.
175
176         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
178         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
179         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
180         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
181         * WebKitTestRunner/InjectedBundle/TestRunner.h:
182         * WebKitTestRunner/TestController.cpp:
183         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
184         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
185         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
186         * WebKitTestRunner/TestController.h:
187         * WebKitTestRunner/TestInvocation.cpp:
188         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
189
190 2018-02-12  Ross Kirsling  <ross.kirsling@sony.com>
191
192         download-latest-github-release .py should not use "browser download URL".
193         https://bugs.webkit.org/show_bug.cgi?id=182646
194
195         Reviewed by Per Arne Vollan.
196
197         * Scripts/download-latest-github-release.py:
198         Download request should be a proper GitHub API call and should actually include the token when applicable.
199         (Also clean up usage of args and print while we're in here.)
200
201 2018-02-12  Per Arne Vollan  <pvollan@apple.com>
202
203         EWS should run Windows tests.
204         https://bugs.webkit.org/show_bug.cgi?id=177967
205
206         Reviewed by Lucas Forschler.
207
208         This will help catch regressions at an early stage.
209
210         * Scripts/webkitpy/common/config/ews.json:
211
212 2018-02-08  Ryosuke Niwa  <rniwa@webkit.org>
213
214         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
215         https://bugs.webkit.org/show_bug.cgi?id=182564
216
217         Reviewed by Wenson Hsieh.
218
219         Added tests for pasting HTML with list items generated by Microsoft Word as well as HTML which looks like
220         the one generated by Microsoft Word but missing a proper "html" element at the beginning.
221
222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
223         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added test cases.
224         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm: Added test cases.
225         (msoListMarkupWithoutProperHTMLElement): Added.
226         * TestWebKitAPI/Tests/WebKitCocoa/mso-list.html: Added.
227
228 2018-02-09  Don Olmstead  <don.olmstead@sony.com>
229
230         [CMake] Make PAL headers copies
231         https://bugs.webkit.org/show_bug.cgi?id=182645
232
233         Reviewed by Alex Christensen.
234
235         * TestWebKitAPI/CMakeLists.txt:
236
237 2018-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
238
239         Pasting from Excel no longer provides text/html data
240         https://bugs.webkit.org/show_bug.cgi?id=182636
241         <rdar://problem/37087060>
242
243         Reviewed by Ryosuke Niwa.
244
245         Add new API tests to exercise pasting images with various other content types on macOS, and when dropping images
246         and HTML markup on iOS. See the WebCore ChangeLog for more detail.
247
248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
249         * TestWebKitAPI/Tests/WebKitCocoa/DataTransfer.html: Added.
250
251         Add a new API test harness that dumps various bits of information about a DataTransfer upon paste and drop.
252         While somewhat similar to some existing harnesses, this makes a distinction between the raw HTML data on the
253         pasteboard and the actual result of inserting said HTML into the DOM. This allows us to check that the HTML has
254         been sanitized, while making checks for the actual content of the HTML robust against inline style changes.
255
256         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
257         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm: Added.
258
259         Add a new test suite to exercise pasting mixed content types. In these test cases, the pasteboard contains a
260         file, with some combination of plain text, rich text, and URLs.
261
262         (imagePath):
263         (writeTypesAndDataToPasteboard):
264
265         Add a helper to write a var-arg list of content types and data to the general NSPasteboard.
266
267         (setUpWebView):
268         (markupString):
269         (TestWebKitAPI::TEST):
270         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
271         (TestWebKitAPI::testIconImageData):
272         (TestWebKitAPI::TEST):
273         * TestWebKitAPI/cocoa/TestWKWebView.h:
274
275         Move a private declaration of -[WKWebView paste:] out to TestWKWebView.h, so that it can be shared across
276         multiple tests. Currently, it only resides in PasteImage.mm, but I need it in PasteMixedContent.mm as well.
277
278 2018-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
279
280         Add a way to check if a host is an IP address
281         https://bugs.webkit.org/show_bug.cgi?id=182427
282
283         Reviewed by Alex Christensen.
284
285         Add unit test for URL::hostIsIPAddress().
286
287         * TestWebKitAPI/Tests/WebCore/URL.cpp:
288         (TestWebKitAPI::TEST_F):
289
290 2018-02-09  Philippe Normand  <pnormand@igalia.com>
291
292         [GStreamer] Layout test fast/replaced/border-radius-clip.html crashes with GStreamer-CRITICAL **: gst_segment_to_stream_time: assertion 'segment->format == format' failed in gst_segment_to_stream_time()
293         https://bugs.webkit.org/show_bug.cgi?id=176802
294
295         Reviewed by Xabier Rodriguez-Calvar.
296
297         * gstreamer/jhbuild.modules:
298         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Added.
299
300 2018-02-09  Philippe Normand  <pnormand@igalia.com>
301
302         [JHBuild] Update Mesa to version 17
303         https://bugs.webkit.org/show_bug.cgi?id=182599
304
305         Reviewed by Carlos Alberto Lopez Perez.
306
307         * gtk/jhbuild.modules: Update Mesa (and its dependencies, hopefully) to version 17.3.3.
308
309 2018-02-08  Chris Dumez  <cdumez@apple.com>
310
311         There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld
312         https://bugs.webkit.org/show_bug.cgi?id=182524
313         <rdar://problem/9057327>
314
315         Reviewed by Ryosuke Niwa.
316
317         Add API test coverage.
318
319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
320         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp: Added.
321         (TestWebKitAPI::runJavaScriptAlert):
322         (TestWebKitAPI::TEST):
323         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp: Added.
324         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::InjectedBundleDisableOverrideBuiltinsBehaviorTest):
325         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
326         * TestWebKitAPI/Tests/WebKit/override-builtins-test.html: Added.
327
328 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
329
330         TestController should not exercise cocoa-specific resource load statistics APIs
331         https://bugs.webkit.org/show_bug.cgi?id=182355
332
333         Reviewed by Alex Christensen.
334
335         Remove unnecessary use of platform-specific APIs in the TestController, since there are
336         cross-platform APIs to do the same thing.
337
338         Also, ensure callbacks execute before returning from TestController's functions, since
339         otherwise the tests are guaranteed to be flaky at best, and also since there's nothing to
340         prevent the TestController from being destroyed before the callbacks execute.
341
342         * WebKitTestRunner/TestController.cpp:
343         (WTR::resourceStatisticsVoidResultCallback):
344         (WTR::resourceStatisticsBooleanResultCallback):
345         (WTR::TestController::isStatisticsPrevalentResource):
346         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
347         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
348         (WTR::TestController::isStatisticsHasHadUserInteraction):
349         (WTR::TestController::isStatisticsGrandfathered):
350         (WTR::TestController::statisticsUpdateCookiePartitioning):
351         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
352         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
353         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
354         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
355         (WTR::resourceStatisticsCallback): Deleted.
356         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback): Deleted.
357         * WebKitTestRunner/TestController.h:
358         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
359         (WTR::toNSString): Deleted.
360         (WTR::TestController::setStatisticsLastSeen): Deleted.
361         (WTR::TestController::setStatisticsPrevalentResource): Deleted.
362         (WTR::TestController::isStatisticsPrevalentResource): Deleted.
363         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder): Deleted.
364         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo): Deleted.
365         (WTR::TestController::setStatisticsHasHadUserInteraction): Deleted.
366         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
367         (WTR::TestController::isStatisticsHasHadUserInteraction): Deleted.
368         (WTR::TestController::setStatisticsGrandfathered): Deleted.
369         (WTR::TestController::isStatisticsGrandfathered): Deleted.
370         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin): Deleted.
371         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin): Deleted.
372         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo): Deleted.
373         (WTR::TestController::setStatisticsTimeToLiveUserInteraction): Deleted.
374         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
375         (WTR::TestController::statisticsProcessStatisticsAndDataRecords): Deleted.
376         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
377         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
378         (WTR::TestController::statisticsSubmitTelemetry): Deleted.
379         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned): Deleted.
380         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval): Deleted.
381         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured): Deleted.
382         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval): Deleted.
383         (WTR::TestController::setStatisticsGrandfatheringTime): Deleted.
384         (WTR::TestController::setStatisticsMaxStatisticsEntries): Deleted.
385         (WTR::TestController::setStatisticsPruneEntriesDownTo): Deleted.
386         (WTR::TestController::statisticsClearInMemoryAndPersistentStore): Deleted.
387         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): Deleted.
388         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): Deleted.
389         (WTR::TestController::statisticsResetToConsistentState): Deleted.
390
391 2018-02-08  Jonathan Bedard  <jbedard@apple.com>
392
393         webkit-patch suggest-reviewers dies with AttributeError: 'NoneType' object has no attribute 'revision'
394         https://bugs.webkit.org/show_bug.cgi?id=182584
395
396         Reviewed by Daniel Bates.
397
398         It is possible that a specific revision has an empty ChangeLog. In this case, Checkout.commit_info_for_revision
399         will return 'None'. Checkout.recent_commit_infos_for_files should never return a set with 'None' in it.
400
401         * Scripts/webkitpy/common/checkout/checkout.py:
402         (Checkout.recent_commit_infos_for_files): Remove any empty commit information from the set.
403         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Add a file which references an empty ChangeLog.
404
405 2018-02-08  Matt Lewis  <jlewis3@apple.com>
406
407         Unreviewed, rolling out r228261.
408
409         This broke an internal build
410
411         Reverted changeset:
412
413         "Add a way to check if a host is an IP address"
414         https://bugs.webkit.org/show_bug.cgi?id=182427
415         https://trac.webkit.org/changeset/228261
416
417 2018-02-08  Commit Queue  <commit-queue@webkit.org>
418
419         Unreviewed, rolling out r228267, r228268, and r228269.
420         https://bugs.webkit.org/show_bug.cgi?id=182601
421
422         jhbuild socks (Requested by philn on #webkit).
423
424         Reverted changesets:
425
426         "[JHBuild] Update Mesa to version 17"
427         https://bugs.webkit.org/show_bug.cgi?id=182599
428         https://trac.webkit.org/changeset/228267
429
430         "Unreviewed, GTK build fix attempt after r228267."
431         https://trac.webkit.org/changeset/228268
432
433         "Unreviewed, final GTK build fix attempt after r228267."
434         https://trac.webkit.org/changeset/228269
435
436 2018-02-08  Philippe Normand  <pnormand@igalia.com>
437
438         Unreviewed, final GTK build fix attempt after r228267.
439
440         * gtk/jhbuild.modules: sha256sum for libdrm was for the tar.gz archive. Oops.
441
442 2018-02-08  Philippe Normand  <pnormand@igalia.com>
443
444         Unreviewed, GTK build fix attempt after r228267.
445
446         * gtk/jhbuild.modules: Update to libdrm version 2.4.89, Mesa 17 requires at least version 2.4.75.
447
448 2018-02-08  Philippe Normand  <pnormand@igalia.com>
449
450         [JHBuild] Update Mesa to version 17
451         https://bugs.webkit.org/show_bug.cgi?id=182599
452
453         Reviewed by Carlos Alberto Lopez Perez.
454
455         * gtk/jhbuild.modules: Update Mesa to version 17.3.3.
456
457 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
458
459         Add a way to check if a host is an IP address
460         https://bugs.webkit.org/show_bug.cgi?id=182427
461
462         Reviewed by Alex Christensen.
463
464         Add unit test for URL::hostIsIPAddress().
465
466         * TestWebKitAPI/Tests/WebCore/URL.cpp:
467         (TestWebKitAPI::TEST_F):
468
469 2018-02-07  Tim Horton  <timothy_horton@apple.com>
470
471         Evernote device management web view sometimes displays at the wrong scale
472         https://bugs.webkit.org/show_bug.cgi?id=182590
473         <rdar://problem/36633687>
474
475         Reviewed by Simon Fraser.
476
477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
478         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm.
479         (-[TestDelegateForScrollView dealloc]):
480         (TestWebKitAPI::TEST):
481         (-[WKScrollViewDelegateWithViewForZoomingOverridden viewForZoomingInScrollView:]):
482         Add a test that failed before the change that ensures that we don't
483         consult the external delegate for viewForZoomingInScrollView:, and that
484         we succesfully update the scale even if it matches that of the view
485         the external delegate returns for viewForZoomingInScrollView:.
486
487 2018-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
488
489         REGRESSION(r226396): File paths are inserted when dropping image files
490         https://bugs.webkit.org/show_bug.cgi?id=182557
491         <rdar://problem/37294120>
492
493         Reviewed by Ryosuke Niwa.
494
495         Tweak some image pasting API tests to ensure that file paths are not inserted when pasting images backed by
496         file paths on disk.
497
498         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
499         (TEST):
500
501 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
502
503         [GTK] Enable WebKit.GeolocationTransitionTo{High,Low}Accuracy tests
504         https://bugs.webkit.org/show_bug.cgi?id=125068
505
506         Unreviewed test gardening.
507
508         They do not appear to have failed since we started running them again in r226944.
509
510         * TestWebKitAPI/glib/TestExpectations.json:
511
512 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
513
514         [GTK] Enable WebKit.InjectedBundleFrameHitTest test
515         https://bugs.webkit.org/show_bug.cgi?id=120303
516
517         Unreviewed test gardening.
518
519         It does not appear to have failed since we started running it again in r226944.
520
521         * TestWebKitAPI/glib/TestExpectations.json:
522
523 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
524
525         [GTK] Enable WebKit.ForceRepaint test
526         https://bugs.webkit.org/show_bug.cgi?id=105532
527
528         Unreviewed test gardening.
529
530         It does not appear to have failed since we started running it again in r226944.
531
532         * TestWebKitAPI/glib/TestExpectations.json:
533
534 2018-02-07  Philippe Normand  <pnormand@igalia.com>
535
536         [JHBuild] Add libva in moduleset
537         https://bugs.webkit.org/show_bug.cgi?id=182384
538
539         Reviewed by Xabier Rodriguez-Calvar.
540
541         * gstreamer/jhbuild.modules: Add libva and disable spurious message output.
542         * gtk/install-dependencies: Remove libva from dependencies.
543         * wpe/install-dependencies: Ditto.
544
545 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
546
547         [GTK] Enable WebKit.NewFirstVisuallyNonEmptyLayoutFrames test
548         https://bugs.webkit.org/show_bug.cgi?id=85037
549
550         Unreviewed test gardening.
551
552         It does not appear to have failed since we started running it again in r226944.
553
554         * TestWebKitAPI/glib/TestExpectations.json:
555
556 2018-02-06  Leo Balter  <leonardo.balter@gmail.com>
557
558         Nit fix for ruby script called through Perl
559         https://bugs.webkit.org/show_bug.cgi?id=182552
560
561         Reviewed by Yusuke Suzuki.
562
563         * BuildSlaveSupport/build.webkit.org-config/steps.py:
564         (RunTest262Tests):
565
566 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
567
568         Remove WebCore/ForwardingHeaders directory
569         https://bugs.webkit.org/show_bug.cgi?id=182347
570
571         Reviewed by Keith Miller.
572
573         * WebKitTestRunner/TestController.cpp:
574
575 2018-02-06  Ross Kirsling  <ross.kirsling@sony.com>
576
577         webkit-patch upload should ask for confirmation before creating a new bug
578         https://bugs.webkit.org/show_bug.cgi?id=182551
579
580         Reviewed by Daniel Bates.
581
582         It is quite easy to paste unintended text into the bug number prompt. This creates a junk bug with an uneditable
583         first comment, which could result in embarrassment or potentially even a proprietary information leak.
584
585         * Scripts/webkitpy/tool/commands/upload_unittest.py:
586         (test_prepare):
587         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
588         (PromptForBugOrTitle):
589         (PromptForBugOrTitle.options):
590         (PromptForBugOrTitle.run):
591
592 2018-02-06  Youenn Fablet  <youenn@apple.com>
593
594         HasServiceWorkerRegistration bit should be sent when creating a new page
595         https://bugs.webkit.org/show_bug.cgi?id=182410
596
597         Reviewed by Chris Dumez.
598
599         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
600
601 2018-02-06  Andres Gomez  <agomez@igalia.com>
602
603         [GTK][WPE] Add dependencies watching lists for WKGTK+ and WPE
604         https://bugs.webkit.org/show_bug.cgi?id=182346
605
606         Reviewed by Michael Catanzaro.
607
608         Loren, Carlos and Andres are interested on the WKGTK+ dependencies
609         watchlist since they are running WKGTK+ EWS.
610
611         Similarly, Adrian and Carlos are running a WPE EWS.
612
613         * Scripts/webkitpy/common/config/watchlist: Added WPEDependencies
614           and WebKitGTKDependencies watchlists with the proper people.
615
616 2018-02-06  Andres Gomez  <agomez@igalia.com>
617
618         Unreviewed, canonicalize contributors.json
619
620         After Thibault's addition, automatic checks complain about
621         contributors.json with:
622
623         "[...] Use "validate-committer-lists --canonicalize" to reformat
624         it. [...]"
625
626         * Scripts/webkitpy/common/config/contributors.json: Canonicalize.
627
628 2018-02-06  Andres Gomez  <agomez@igalia.com>
629
630         Unreviewed, add Lorenzo Tilve to contributors.json
631
632         We need to add Loren to the contributors list in order to CC him
633         in Bugzilla.
634
635         * Scripts/webkitpy/common/config/contributors.json: Added Lorenzo
636           Tilve.
637
638 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
639
640         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
641         https://bugs.webkit.org/show_bug.cgi?id=182478
642
643         Reviewed by Alex Christensen.
644
645         For TestWebKitAPI, sources related to WebKitLegacy are built
646         at WebKit build. Those files should be reffered for WebKitLegacy build.
647
648         * TestWebKitAPI/PlatformWin.cmake:
649
650 2018-02-05  Daniel Bates  <dabates@apple.com>
651
652         REGRESSION (r217572): run-webkit-tests exits without emitting newline character
653         https://bugs.webkit.org/show_bug.cgi?id=182360
654
655         Rubber-stamped by Aakash Jain.
656
657         Fixes an annoyance where run-webkit-tests always exits without printing a newline character.
658         In the terminal this looks like:
659
660             $ Tools/Scripts/run-webkit-tests
661             Expected to fail, but passed: (7)
662             ...
663             Stopping WebSocket server ...$
664
665         This bug was caused by code added in r217572 to stop all run-webkit-tests started servers (e.g. an HTTP
666         server) from an at-exit handler. When run-webkit-tests runs successfully (i.e. without error or
667         control-C interruption) we would stop all such servers twice: once as part of ending the test
668         run and once from the at-exit handler. The latter never prints a trailing newline character hence
669         the state of the terminal (as depicted above). Instead LayoutTestRunner.stop_servers() should only
670         stop servers that it started in LayoutTestRunner.start_servers().
671
672         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
673         (LayoutTestRunner.__init__):
674         (LayoutTestRunner.start_servers):
675         (LayoutTestRunner.stop_servers):
676         Only start servers that run-webkit-tests has not already started and only stop servers that
677         run-webkit-tests started.
678
679         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
680         (LayoutTestRunnerTests.test_servers_started.is_websocket_server_running):
681         (LayoutTestRunnerTests.test_servers_started):
682         (LayoutTestRunnerTests.test_servers_started.is_websocket_servers_running): Deleted.
683         Update due to rename below.
684
685         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
686         (is_web_socket_server_running): Added.
687         (PyWebSocket.is_running): Deleted.
688
689         * Scripts/webkitpy/port/base.py:
690         (Port.is_http_server_running): Check if we already started the server ourself.
691         (Port.is_websocket_server_running): Formerly named is_websocket_servers_running. Modified
692         to check if we already started the server ourself. Take a similar approach as the other
693         Port.is_*_running methods and only check if an existing WebSocket server is running on the
694         non-secure server port. This is a simple heuristic and should be sufficient in practice.
695         (Port.is_wpt_server_running): Check if we already started the server ourself.
696         (Port.is_websocket_servers_running): Deleted; renamed to is_websocket_server_running().
697
698 2018-02-05  Daniel Bates  <dabates@apple.com>
699
700         prepare-ChangeLog gets confused about Python docstrings that contain the word "class" or "def"
701         https://bugs.webkit.org/show_bug.cgi?id=182405
702
703         Reviewed by David Kilzer.
704
705         String literal statements, including docstrings, do not demarcate a new scope in Python.
706         So, do not treat them like they do when building up the list of modified functions.
707
708         * Scripts/prepare-ChangeLog:
709         (get_function_line_ranges_for_python):
710         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
711         The expected ending line number for the last "pass" statement inside the scope of Class5 changed
712         from 97 to 98 because empty lines do not effect scope. This is consistent with the parsing
713         of the second "pass" statement in the scope of class Class5. A "pass" is a null operation that
714         is used as a syntactic placeholder when a statement is required. Ideally we would make
715         the parsing code smarter so as to avoid emitting ranges for "pass" statements that serve
716         not syntactic purpose.
717         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
718         (Class5):
719         (Class6):
720         (Class6.__init__):
721         (Class7):
722         (Class7.__init__):
723         (Class8):
724         (Class8.__init__):
725         Add some more tests.
726
727 2018-02-05  Matt Lewis  <jlewis3@apple.com>
728
729         Unreviewed, rolling out r228086.
730
731         This introduced a failure with API test
732         URLTest.HostIsIPAddress.
733
734         Reverted changeset:
735
736         "Add a way to check if a host is an IP address"
737         https://bugs.webkit.org/show_bug.cgi?id=182427
738         https://trac.webkit.org/changeset/228086
739
740 2018-02-05  John Wilander  <wilander@apple.com>
741
742         Storage Access API: Add testRunner.getAllStorageAccessEntries() to make testing easier and more explicit
743         https://bugs.webkit.org/show_bug.cgi?id=181601
744         <rdar://problem/36475837>
745
746         Reviewed by Alex Christensen.
747
748         http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html
749         was found to be flaky. With the testRunner.hasStorageAccessEntry() getter
750         it's possible to check access even if a frame doesn't respond timely to
751         postMessage after detach and attach.
752
753         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
754         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
755         (WTR::InjectedBundle::didReceiveMessageToPage):
756         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
757         (WTR::TestRunner::setStorageAccessAPIEnabled):
758             Just moved for source file grouping.
759         (WTR::TestRunner::getAllStorageAccessEntries):
760         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback):
761         * WebKitTestRunner/InjectedBundle/TestRunner.h:
762         * WebKitTestRunner/TestController.cpp:
763         (WTR::TestController::getAllStorageAccessEntries):
764             Note that this is just stubbed out, i.e. not implemented.
765         * WebKitTestRunner/TestController.h:
766         * WebKitTestRunner/TestInvocation.cpp:
767         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
768         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
769         * WebKitTestRunner/TestInvocation.h:
770         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
771         (WTR::TestController::getAllStorageAccessEntries):
772             This is the Cocoa-specific version of this test infrastructure.
773
774 2018-02-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
775
776         [Win] Enable multi CPU building on MSBuild.
777         https://bugs.webkit.org/show_bug.cgi?id=182446
778
779         Compiling itself already uses multi cores, but other stuff is still on single core.
780         This patch enables that by passing an argument to MSBuild.exe.
781
782         Reviewed by Alex Christensen.
783
784         * Scripts/webkitdirs.pm:
785         (determineNumberOfCPUs):
786         (buildVisualStudioProject):
787
788 2018-02-05  Alicia Boya García  <aboya@igalia.com>
789
790         Fix bug in MediaTime comparison for negative values with different scale.
791         https://bugs.webkit.org/show_bug.cgi?id=182433
792
793         Improved test coverage for MediaTime::compare().
794
795         Reviewed by Xabier Rodriguez-Calvar.
796
797         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
798         (TestWebKitAPI::TEST):
799
800 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
801
802         [SOUP] WebSockets must use system proxy settings
803         https://bugs.webkit.org/show_bug.cgi?id=126384
804
805         Reviewed by Michael Catanzaro.
806
807         Check also WebSockets in /webkit2/WebKitWebContext/proxy.
808
809         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
810         (ProxyTest::webSocketProxyServerCallback):
811         (ProxyTest::ProxyTest):
812         (ProxyTest::webSocketConnected):
813         (ProxyTest::createWebSocketAndWaitUntilConnected):
814         (webSocketServerCallback):
815         (testWebContextProxySettings):
816         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
817         (WebKitTestServer::~WebKitTestServer):
818         (WebKitTestServer::addWebSocketHandler):
819         (WebKitTestServer::removeWebSocketHandler):
820         (WebKitTestServer::getWebSocketURIForPath const):
821         (WebKitTestServer::getURIForPath const):
822         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
823         (WebKitTestServer::baseURI const):
824         (WebKitTestServer::baseWebSocketURI const):
825
826 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
827
828         Add a way to check if a host is an IP address
829         https://bugs.webkit.org/show_bug.cgi?id=182427
830
831         Reviewed by Alex Christensen.
832
833         Add unit test for URL::hostIsIPAddress().
834
835         * TestWebKitAPI/Tests/WebCore/URL.cpp:
836         (TestWebKitAPI::TEST_F):
837
838 2018-02-03  Charlie Turner  <cturner@igalia.com>
839
840         Add libmount to WPE dependencies
841         https://bugs.webkit.org/show_bug.cgi?id=182345
842
843         Reviewed by Michael Catanzaro.
844
845         * wpe/install-dependencies:
846
847 2018-02-02  Youenn Fablet  <youenn@apple.com>
848
849         W3C test exporter should allow exporting newly added files
850         https://bugs.webkit.org/show_bug.cgi?id=182369
851
852         Reviewed by Ryosuke Niwa.
853
854         * Scripts/webkitpy/common/checkout/scm/git.py:
855         (Git.apply_mail_patch):
856
857 2018-02-02  David Quesada  <david_quesada@apple.com>
858
859         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
860         https://bugs.webkit.org/show_bug.cgi?id=182363
861         rdar://problem/37093498
862
863         Reviewed by Ryosuke Niwa.
864
865         Updated ApplicationManifestParserTests to account for the new default scope behavior.
866
867         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
868         (assertManifestHasDefaultValues):
869         (TEST_F):
870
871 2018-02-02  Youenn Fablet  <youenn@apple.com>
872
873         Clearing all service worker registrations should wait for importing service worker registration to finish
874         https://bugs.webkit.org/show_bug.cgi?id=182407
875
876         Reviewed by Chris Dumez.
877
878         Make sure we finish clearing service worker registrations before running tests.
879
880         * WebKitTestRunner/TestController.cpp:
881         (WTR::TestController::resetStateToConsistentValues):
882         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
883         (WTR::clearServiceWorkerRegistrationsCallback):
884         (WTR::TestController::clearServiceWorkerRegistrations):
885         * WebKitTestRunner/TestController.h:
886
887 2018-02-02  Youenn Fablet  <youenn@apple.com>
888
889         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
890         https://bugs.webkit.org/show_bug.cgi?id=182403
891
892         Reviewed by Alex Christensen.
893
894         * WebKitTestRunner/TestController.cpp:
895         (WTR::TestController::generateContextConfiguration const):
896         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
897         (WTR::initializeWebViewConfiguration):
898
899 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
900
901         [GTK] WebDriver: tests step always times out in the bot
902         https://bugs.webkit.org/show_bug.cgi?id=182437
903
904         Reviewed by Carlos Alberto Lopez Perez.
905
906         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
907         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
908
909         * Scripts/run-webdriver-tests: Call teardown() after run().
910         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
911         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
912         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
913         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
914         the display driver once and pass it to the test runners.
915         (WebDriverTestRunner.teardown): Stop the display server.
916         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
917         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
918         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
919         (WebDriverTestRunnerSelenium.run): Ditto.
920         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
921         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
922         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
923         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
924         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
925
926 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
927
928         Unreviewed, rolling out r227999.
929
930         It didn't fix the problem
931
932         Reverted changeset:
933
934         "Unreviewed. Try to avoid webdriver tests step timing out in
935         the bots."
936         https://trac.webkit.org/changeset/227999
937
938 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
939
940         Start timeout for the run-buildbot-test script is too aggressive
941         https://bugs.webkit.org/show_bug.cgi?id=182429
942
943         Reviewed by Carlos Garcia Campos.
944
945         15 seconds is not enough waiting for the update database process
946         to complete on a system backed with rotational HDDs. Raise it to 60.
947
948         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
949         (wait_for_master_ready):
950
951 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
952
953         re-add ARM JSCOnly bots on buildbot waterfall
954         https://bugs.webkit.org/show_bug.cgi?id=182428
955
956         Reviewed by Csaba Osztrogonác.
957
958         * BuildSlaveSupport/build.webkit.org-config/config.json:
959         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
960
961 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
962
963         Remove ARM JSCOnly bots from buildbot waterfall
964         https://bugs.webkit.org/show_bug.cgi?id=182398
965
966         Reviewed by Alexey Proskuryakov.
967
968         * BuildSlaveSupport/build.webkit.org-config/config.json:
969         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
970
971 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
972
973         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
974
975         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
976         workaround for a bug in python2.7 when using multiprocess module.
977
978         * Scripts/run-webdriver-tests:
979
980 2018-02-01  Youenn Fablet  <youenn@apple.com>
981
982         Delay service worker process creation until actually needed by SWServer
983         https://bugs.webkit.org/show_bug.cgi?id=182301
984
985         Reviewed by Chris Dumez.
986
987         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
988         (function):
989
990 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
991
992         Bubbles intermittently disappear from bot watchers dashboard
993         https://bugs.webkit.org/show_bug.cgi?id=182085
994
995         Reviewed by Alexey Proskuryakov.
996
997         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
998         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
999         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
1000         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
1001
1002 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1003
1004         [GTK] Problem with Washington Post images
1005         https://bugs.webkit.org/show_bug.cgi?id=181421
1006
1007         Reviewed by Carlos Alberto Lopez Perez.
1008
1009         Add test case for the new user agent quirk.
1010
1011         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1012         (TestWebKitAPI::TEST):
1013
1014 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1015
1016         [GTK] MiniBrowser settings are just a list of names
1017         https://bugs.webkit.org/show_bug.cgi?id=182005
1018
1019         Reviewed by Sergio Villar Senin.
1020
1021         The default size we are using is too small to show the values column, and the window is not resizable because
1022         GObjectClass::constructed() is not called in the parent class.
1023
1024         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1025         (browser_settings_dialog_init): Use 600x400 as default size.
1026         (browserSettingsDialogConstructed): Chain up to parent constructed.
1027
1028 2018-01-31  Andres Gomez  <agomez@igalia.com>
1029
1030         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
1031
1032         * Scripts/webkitpy/common/config/watchlist:
1033
1034 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
1035
1036         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
1037         https://bugs.webkit.org/show_bug.cgi?id=181204
1038         <rdar://problem/36256274>
1039
1040         Reviewed by Ryosuke Niwa.
1041
1042         Implement 'testRunner.forceImmediateCompletion()' for WK1.
1043
1044         * DumpRenderTree/TestRunner.cpp:
1045         (forceImmediateCompletionCallback):
1046         (TestRunner::staticFunctions):
1047
1048 2018-01-31  Alex Christensen  <achristensen@webkit.org>
1049
1050         Unreviewed, rolling out r227942.
1051
1052         r227875 should not have been rolled out.
1053
1054         Reverted changeset:
1055
1056         "Unreviewed, rolling out r227875."
1057         https://bugs.webkit.org/show_bug.cgi?id=182357
1058         https://trac.webkit.org/changeset/227942
1059
1060 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1061
1062         Unreviewed, rolling out r227875.
1063         https://bugs.webkit.org/show_bug.cgi?id=182357
1064
1065         Missing cross-platform TestController implementation
1066
1067         Reverted changeset:
1068
1069         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
1070         https://bugs.webkit.org/show_bug.cgi?id=181958
1071         https://trac.webkit.org/changeset/227875
1072
1073         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1074         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1075         (WTR::InjectedBundle::didReceiveMessageToPage):
1076         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1077         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1078         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1079         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
1080         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1081         * WebKitTestRunner/TestInvocation.cpp:
1082         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
1083         * WebKitTestRunner/TestInvocation.h:
1084         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1085         (WTR::TestController::statisticsUpdateCookiePartitioning):
1086         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1087
1088 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1089
1090         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
1091         https://bugs.webkit.org/show_bug.cgi?id=182222
1092
1093         Reviewed by Alex Christensen.
1094
1095         Use the new API to notify when resource load statistics deletion is complete.
1096
1097         * WebKitTestRunner/TestController.cpp:
1098         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
1099         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1100         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1101
1102 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
1103
1104         Add the support for running StyleBench to run-benchmark
1105         https://bugs.webkit.org/show_bug.cgi?id=182323
1106
1107         Reviewed by Antti Koivisto.
1108
1109         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
1110
1111         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
1112         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
1113
1114 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
1115
1116         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
1117         https://bugs.webkit.org/show_bug.cgi?id=182339
1118         <rdar://problem/36041396>
1119
1120         Reviewed by Andy Estes.
1121
1122         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
1123         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
1124         check against the length of the data written.
1125
1126         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1127         (testIconImageData):
1128         (runTestWithTemporaryFolder):
1129         (TestWebKitAPI::TEST):
1130
1131 2018-01-31  Dan Bernstein  <mitz@apple.com>
1132
1133         [macOS] MiniBrowser isn’t app-sandboxed
1134         https://bugs.webkit.org/show_bug.cgi?id=182147
1135
1136         Reviewed by Sam Weinig.
1137
1138         Enable App Sandbox and add a temporary exception allowing read access to all files.
1139
1140         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
1141         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
1142         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
1143           and read access from /.
1144         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
1145
1146 2018-01-31  Philippe Normand  <pnormand@igalia.com>
1147
1148         [JHBuild] Add gstreamer-vaapi in moduleset
1149         https://bugs.webkit.org/show_bug.cgi?id=182283
1150
1151         Reviewed by Carlos Alberto Lopez Perez.
1152
1153         GStreamer-VAAPI is required for hardware-accelerated video
1154         playback support on Intel and AMD (using radeosi driver)
1155         platforms.
1156
1157         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
1158         * gtk/install-dependencies: Install libva.
1159         * wpe/install-dependencies: Ditto.
1160         * Scripts/webkitpy/port/gtk.py:
1161         (GtkPort.setup_environ_for_server): Disable va-api support when
1162         testing because it's incompatible with Mesa's softGL driver.
1163
1164 2018-01-31  Charlie Turner  <cturner@igalia.com>
1165
1166         [WPE] Update jhbuild dependencies
1167         https://bugs.webkit.org/show_bug.cgi?id=182286
1168
1169         This upgrades the following packages,
1170         glib 2.44.1 -> 2.54.3
1171         glib-networking 2.42.0 -> 2.54.1
1172         libsoup 2.48.0 -> 2.60.3
1173
1174         The initial reason for performing these upgrades was that when
1175         visiting https://youtube.com, WPE was getting TLS certificate
1176         errors. After upgrading glib-networking, these were fixed, but the
1177         upgrade introduced dependencies on newer versions of the other
1178         packages upgraded in this commit.
1179
1180         The upgrade to glib caused a linking error in gstreamer, the
1181         following errors were being logged during linking,
1182
1183         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
1184         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
1185         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
1186
1187         This was fixed by adding the glib package built in the jhbuild to
1188         harfbuzz.
1189
1190         Finally, the upgrade of glib caused the glib-warning-fix.patch to
1191         no longer apply, so this patch was removed.
1192
1193         Reviewed by Michael Catanzaro.
1194
1195         * wpe/jhbuild.modules: Added dependecies.
1196         * wpe/patches/glib-warning-fix.patch: Removed.
1197
1198 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1199
1200         Unreviewed, rolling out r227782.
1201
1202         It didn't fix the problem
1203
1204         Reverted changeset:
1205
1206         "Unreviewed. Try to avoid webdriver tests step timing out in
1207         the bots."
1208         https://trac.webkit.org/changeset/227782
1209
1210 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1211
1212         WebDriver: add domains to server config in w3c tests
1213         https://bugs.webkit.org/show_bug.cgi?id=182294
1214
1215         Reviewed by Carlos Alberto Lopez Perez.
1216
1217         Several cookie tests expect server_config to have a domains key.
1218
1219         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
1220                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
1221
1222         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1223         (WebDriverW3CExecutor.__init__):
1224
1225 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1226
1227         Unreviewed. Update W3C WebDriver imported tests.
1228
1229         Show full pytest failure logs.
1230
1231         pytest truncates long lists when printing a failed assertion.
1232         This is not great for debugging and arguably it should be the
1233         default to show the full diff when comparing lists.
1234
1235         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1236         (run):
1237
1238 2018-01-30  John Wilander  <wilander@apple.com>
1239
1240         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
1241         https://bugs.webkit.org/show_bug.cgi?id=181958
1242         https://bugs.webkit.org/show_bug.cgi?id=182072
1243         <rdar://problem/36801804>
1244         <rdar://problem/36845795>
1245
1246         Reviewed by Brent Fulgham.
1247
1248         Because of the asynchronous nature of XPC and cookies,
1249         we need callbacks in these TestRunner functions so that
1250         the layout tests can wait for state changes to finish
1251         before checking test conditions.
1252
1253         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1254         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1255         (WTR::InjectedBundle::didReceiveMessageToPage):
1256         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1257         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1258         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1259         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
1260         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1261         * WebKitTestRunner/TestInvocation.cpp:
1262         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
1263         * WebKitTestRunner/TestInvocation.h:
1264         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1265         (WTR::TestController::statisticsUpdateCookiePartitioning):
1266         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1267
1268 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1269
1270         [webkitpy] Config file for apache is copied twice.
1271         https://bugs.webkit.org/show_bug.cgi?id=182131
1272
1273         Reviewed by Daniel Bates.
1274
1275         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1276         (LayoutTestApacheHttpd.__init__):
1277         (LayoutTestApacheHttpd._copy_apache_config_file):
1278         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
1279
1280 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1281
1282         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1283         https://bugs.webkit.org/show_bug.cgi?id=182312
1284
1285         Reviewed by Michael Catanzaro.
1286
1287         * DumpRenderTree/config.h:
1288         * TestWebKitAPI/config.h:
1289         * WebKitTestRunner/config.h:
1290
1291 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1292
1293         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
1294         https://bugs.webkit.org/show_bug.cgi?id=182307
1295         <rdar://problem/36041485>
1296
1297         Reviewed by Ryosuke Niwa.
1298
1299         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
1300         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
1301         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
1302         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
1303
1304         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
1305         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1306         (TestWebKitAPI::TEST):
1307
1308 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
1309
1310         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
1311         https://bugs.webkit.org/show_bug.cgi?id=182284
1312
1313         Reviewed by Michael Catanzaro.
1314
1315         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
1316         * wpe/manifest.txt.in: Ditto.
1317
1318 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1319
1320         Unreviewed, try to fix JSCOnly build
1321         https://bugs.webkit.org/show_bug.cgi?id=177202
1322
1323         * CMakeLists.txt:
1324
1325 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1326
1327         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
1328
1329         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
1330         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
1331         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
1332         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
1333
1334         * Scripts/run-webdriver-tests:
1335         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1336         (WebDriverTestRunner.dump_results_to_json_file):
1337
1338 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1339
1340         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
1341         https://bugs.webkit.org/show_bug.cgi?id=177202
1342
1343         Reviewed by Alex Christensen.
1344
1345         * CMakeLists.txt:
1346
1347 2018-01-29  Alex Christensen  <achristensen@webkit.org>
1348
1349         Clean up API after bugs 178240 and 176474
1350         https://bugs.webkit.org/show_bug.cgi?id=182259
1351
1352         Reviewed by Dan Bernstein.
1353
1354         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1355         (TEST):
1356         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
1357
1358 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1359
1360         [WebAuthN] Add a compile-time feature flag
1361         https://bugs.webkit.org/show_bug.cgi?id=182211
1362         <rdar://problem/36936365>
1363
1364         Reviewed by Brent Fulgham.
1365
1366         * Scripts/webkitperl/FeatureList.pm:
1367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1368
1369 2018-01-29  Brady Eidson  <beidson@apple.com>
1370
1371         Make the API test added in r227737 be Mac-only.
1372
1373         Unreviewed gardening.
1374
1375         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
1376
1377 2018-01-29  Matt Lewis  <jlewis3@apple.com>
1378
1379         Unreviewed, rolling out r227731.
1380
1381         This caused and assertion failure in API tests.
1382
1383         Reverted changeset:
1384
1385         "Layout Test fast/events/beforeunload-dom-manipulation-
1386         crash.html is crashing"
1387         https://bugs.webkit.org/show_bug.cgi?id=181204
1388         https://trac.webkit.org/changeset/227731
1389
1390 2018-01-29  Youenn Fablet  <youenn@apple.com>
1391
1392         WPT test exporter should add WebKit export in its PR description
1393         https://bugs.webkit.org/show_bug.cgi?id=182246
1394
1395         Reviewed by Chris Dumez.
1396
1397         Updating PR description body to contain the words 'WebKit export'.
1398         That way, WPT PR bot will mark the PR as reviewed downstream.
1399
1400         * Scripts/webkitpy/w3c/test_exporter.py:
1401         (TestExporter.__init__):
1402         (TestExporter.make_pull_request):
1403         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1404         (TestExporterTest.test_export):
1405
1406 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
1407
1408         Add the support for running Speedometer 2.0 to run-benchmark
1409         https://bugs.webkit.org/show_bug.cgi?id=182231
1410
1411         Reviewed by Antti Koivisto.
1412
1413         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
1414         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
1415         requires aggregating the geometric mean out of total time spent in each suite.
1416
1417         Also added --show-iteration-values to show individual measured values in each iteration.
1418
1419         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1420         (BenchmarkResults.format): Added show_iteration_values as an option.
1421         (BenchmarkResults._format_tests): Ditto.
1422         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
1423         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
1424         is easily parsable as a JSON array.
1425         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
1426         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
1427         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
1428         had exactly one aggregator.
1429         (BenchmarkResults._lint_results):
1430         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
1431         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
1432         parent_aggregator_list.
1433         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
1434         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
1435         (BenchmarkResults._lint_configuration):
1436         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
1437         (test_format_values_with_no_unit_scaling): Added.
1438         (test_format_values_with_iteration_values): Added.
1439         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
1440         (test_aggregate_results_from_another_aggregator): Added.
1441         (test_lint_results): Added a test case.
1442         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1443         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
1444         (BenchmarkRunner._run_benchmark): Ditto.
1445         (BenchmarkRunner.show_results): Ditto.
1446         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
1447         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
1448         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1449         (parse_args): Added --show-iteration-values as a boolean argument.
1450         (run_benchmark_plan): Ditto.
1451         (start): Ditto.
1452         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1453         (WebServerBenchmarkRunner.__init__): Ditto.
1454
1455 2018-01-29  Brady Eidson  <beidson@apple.com>
1456
1457         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
1458         https://bugs.webkit.org/show_bug.cgi?id=182229
1459
1460         Reviewed by Chris Dumez.
1461
1462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1463         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
1464
1465 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1466
1467         WebDriver: properly recover w3c tests after a webdriver server crash
1468         https://bugs.webkit.org/show_bug.cgi?id=182242
1469
1470         Reviewed by Carlos Alberto Lopez Perez.
1471
1472         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
1473         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
1474         relaunching the server after every test failure, because other failures, even when not crashing the server,
1475         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
1476         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
1477
1478         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1479         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
1480         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1481         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
1482         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
1483         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
1484         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
1485         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
1486
1487 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
1488
1489         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
1490         https://bugs.webkit.org/show_bug.cgi?id=181204
1491         <rdar://problem/36256274>
1492
1493         Reviewed by Ryosuke Niwa.
1494
1495         Implement 'testRunner.forceImmediateCompletion()' for WK1.
1496
1497         * DumpRenderTree/TestRunner.cpp:
1498         (forceImmediateCompletionCallback):
1499         (TestRunner::staticFunctions):
1500
1501 2018-01-29  Frederic Wang  <fwang@igalia.com>
1502
1503         Unreviewed, add myself to some watch lists.
1504
1505         * Scripts/webkitpy/common/config/watchlist:
1506
1507 2018-01-27  Dan Bernstein  <mitz@apple.com>
1508
1509         HaveInternalSDK includes should be "#include?"
1510         https://bugs.webkit.org/show_bug.cgi?id=179670
1511
1512         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1513
1514 2018-01-26  Chris Dumez  <cdumez@apple.com>
1515
1516         Make sure service worker code does not launch a StorageProcess unnecessarily
1517         https://bugs.webkit.org/show_bug.cgi?id=182192
1518         <rdar://problem/36927427>
1519
1520         Reviewed by Geoffrey Garen.
1521
1522         Add API test coverage.
1523
1524         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1525
1526 2018-01-26  Chris Dumez  <cdumez@apple.com>
1527
1528         Offlined content does not work for apps on home screen
1529         https://bugs.webkit.org/show_bug.cgi?id=182070
1530         <rdar://problem/36843906>
1531
1532         Reviewed by Youenn Fablet.
1533
1534         Add API test coverage to make sure an already registered service worker is able to intercept
1535         the very first load.
1536
1537         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1538         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
1539
1540 2018-01-26  Chris Nardi  <cnardi@chromium.org>
1541
1542         Addressing post-review comments after r226614
1543         https://bugs.webkit.org/show_bug.cgi?id=182151
1544
1545         Reviewed by Myles C. Maxfield.
1546
1547         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
1548         (TestWebKitAPI::TEST):
1549
1550 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
1551
1552         Unreviewed, rolling out r224920.
1553
1554         Some Win EWS bots are not coming back up after starting reboot.
1555
1556         * EWSTools/start-queue-win.sh:
1557
1558 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1559
1560         WebDriver: simplify the tests json report
1561         https://bugs.webkit.org/show_bug.cgi?id=182171
1562
1563         Reviewed by Carlos Alberto Lopez Perez.
1564
1565         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
1566         form the subtest name. We should do the same for simplicity and compatibility with WPT.
1567
1568         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1569         (WebDriverTestRunner.dump_results_to_json_file):
1570
1571 2018-01-25  Alex Christensen  <achristensen@webkit.org>
1572
1573         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
1574         https://bugs.webkit.org/show_bug.cgi?id=182152
1575
1576         Reviewed by Joseph Pecoraro.
1577
1578         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1579         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1580         (TEST):
1581
1582 2018-01-25  Youenn Fablet  <youenn@apple.com>
1583
1584         WebPluginInfoProvider should handle null host queries
1585         https://bugs.webkit.org/show_bug.cgi?id=182112
1586
1587         Reviewed by Chris Dumez.
1588
1589         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
1590         (TEST):
1591
1592 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1593
1594         [webkitpy] Stop modifying path information only when running on Cygwin
1595         https://bugs.webkit.org/show_bug.cgi?id=182136
1596
1597         On LayoutTestApacheHttpd, some path configuration is modified when platform
1598         is Windows. This modification is only required for AppleWin running on Cygwin.
1599         WinCairo uses native Windows environment, so the condition should be changed.
1600
1601         Reviewed by Per Arne Vollan.
1602
1603         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1604         (LayoutTestApacheHttpd.__init__):
1605         (LayoutTestApacheHttpd._get_apache_config_file_path):
1606
1607 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
1608
1609         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
1610         https://bugs.webkit.org/show_bug.cgi?id=182038
1611         <rdar://problem/36812083>
1612
1613         Reviewed by Jer Noble.
1614
1615         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1616         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
1617
1618 2018-01-24  Daniel Bates  <dabates@apple.com>
1619
1620         webkit-patch upload emits irrelevant simulator warnings
1621         https://bugs.webkit.org/show_bug.cgi?id=181702
1622         <rdar://problem/36556359>
1623
1624         Reviewed by Aakash Jain.
1625
1626         Remove warning when a person explicitly passes --child-processes with a value greater than
1627         the default number of simulator instances webkitpy would have used had --child-processes
1628         been omitted. Moreover, the placement of the warning logic to support printing such a message
1629         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
1630
1631         By default, webkitpy will parallelize running tests using the maximum number of simulator
1632         instances that can be supported based on available system resources at the time run-webkit-tests
1633         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
1634         by specifying --child-processes knows what they are doing. The effects of picking a large
1635         value be obvious, the system may become sluggish.
1636
1637         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
1638         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
1639
1640         * Scripts/webkitpy/port/ios_simulator.py:
1641         (IOSSimulatorPort.__init__):
1642
1643 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
1644
1645         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
1646         https://bugs.webkit.org/show_bug.cgi?id=182102
1647
1648         Reviewed by Carlos Garcia Campos.
1649
1650         * MiniBrowser/gtk/main.c:
1651         (main): Removed the call to set_enable_webvr().
1652
1653 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1654
1655         WebDriver: add support for slow tests
1656         https://bugs.webkit.org/show_bug.cgi?id=182095
1657
1658         Reviewed by Carlos Alberto Lopez Perez.
1659
1660         Add timeout mark to slow tests.
1661
1662         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1663         (TestExpectationsMarker.__init__): Save the timeout.
1664         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
1665         (run): Pass timeout to TestExpectationsMarker constructor.
1666
1667 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1668
1669         Gracefully recover from NetworkProcess crashes in private browsing
1670         https://bugs.webkit.org/show_bug.cgi?id=182073
1671         <rdar://problem/36572023>
1672
1673         Reviewed by Geoff Garen.
1674
1675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1676         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
1677         (-[CrashDelegate webView:didFinishNavigation:]):
1678         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
1679         (-[CrashDelegate webView:didFailNavigation:withError:]):
1680         (TEST):
1681
1682 2018-01-24  Ali Juma  <ajuma@chromium.org>
1683
1684         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
1685         https://bugs.webkit.org/show_bug.cgi?id=182052
1686
1687         Reviewed by Simon Fraser.
1688
1689         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
1690         immediately.
1691
1692         Test: fast/visual-viewport/viewport-dimensions.html
1693
1694         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1695         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1696
1697 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1698
1699         Remove pre-Sierra-OS-specific code in Tools
1700         https://bugs.webkit.org/show_bug.cgi?id=182034
1701
1702         Reviewed by Tim Horton.
1703
1704         * DumpRenderTree/mac/DumpRenderTree.mm:
1705         (setDefaultsToConsistentValuesForTesting):
1706         * MiniBrowser/mac/BrowserWindowController.m:
1707         (-[BrowserWindowController windowDidLoad]):
1708         (-[BrowserWindowController share:]):
1709         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1710         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
1711         (-[EventStreamPlayer playbackTimerFired:]):
1712         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1713         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
1714         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1715         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1716         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1717         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1718         (WTR::InjectedBundle::platformInitialize):
1719         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1720         (WTR::initializeWebViewConfiguration):
1721
1722 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
1723
1724         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
1725         https://bugs.webkit.org/show_bug.cgi?id=181400
1726         <rdar://problem/36358768>
1727
1728         Reviewed by Joseph Pecoraro.
1729
1730         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
1731
1732         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
1733         Always disable poisoning when running with --leaks, as this should work locally,
1734         not just on bots.
1735
1736 2018-01-24  Daniel Bates  <dabates@apple.com>
1737
1738         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
1739         https://bugs.webkit.org/show_bug.cgi?id=181993
1740         <rdar://problem/36421080>
1741
1742         Reviewed by David Hyatt.
1743
1744         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
1745         as we no longer support this strategy.
1746
1747         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
1748
1749 2018-01-24  David Kilzer  <ddkilzer@apple.com>
1750
1751         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
1752         <https://webkit.org/b/182015>
1753         <rdar://problem/36449728>
1754
1755         Reviewed by Tim Horton.
1756
1757         * Scripts/webkitpy/style/checkers/cpp.py:
1758         (regex_for_lambdas_and_blocks): Update regex to include
1759         optional return type for block argument in Objective-C.
1760         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1761         (WebKitStyleTest.test_braces): Add test.
1762
1763 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
1764
1765         WPE-focused test gardening.
1766         https://bugs.webkit.org/show_bug.cgi?id=182051
1767
1768         Unreviewed test gardening.
1769
1770         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
1771
1772 2018-01-23  Mark Lam  <mark.lam@apple.com>
1773
1774         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
1775         https://bugs.webkit.org/show_bug.cgi?id=182017
1776         <rdar://problem/36795513>
1777
1778         Reviewed by Filip Pizlo and JF Bastien.
1779
1780         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1781         (TestWebKitAPI::TEST):
1782         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1783         (TestWebKitAPI::TEST):
1784         (TestWebKitAPI::passWithRef):
1785         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1786         (TestWebKitAPI::TEST):
1787         (TestWebKitAPI::f1):
1788         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1789         (TestWebKitAPI::TEST):
1790         (TestWebKitAPI::poisonedPtrFoo):
1791         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1792         (TestWebKitAPI::TEST):
1793         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1794         (TestWebKitAPI::TEST):
1795
1796 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
1797
1798         [WebVR] Add OpenVR to the tree and to the build
1799         https://bugs.webkit.org/show_bug.cgi?id=177298
1800
1801         Reviewed by Žan Doberšek.
1802
1803         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
1804         with reduced style checks.
1805
1806 2018-01-24  Chris Nardi  <cnardi@chromium.org>
1807
1808         Add Chris Nardi to contributors list
1809         https://bugs.webkit.org/show_bug.cgi?id=182029
1810
1811         Reviewed by Antti Koivisto.
1812
1813         * Scripts/webkitpy/common/config/contributors.json:
1814
1815 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1816
1817         Mac Sierra perf bots have been failing due to CG errors
1818         https://bugs.webkit.org/show_bug.cgi?id=181955
1819
1820         Reviewed by Antti Koivisto.
1821
1822         Ignore the CoreGraphics error messages on macOS Sierra.
1823
1824         Also added tests for ignoring lines in stdout and stderr.
1825
1826         * Scripts/webkitpy/performance_tests/perftest.py:
1827         (PerfTest.run_failed): Refactored for clarity.
1828         (PerfTest):
1829         (PerfTest.filter_ignored_lines): Added.
1830         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
1831         are now used to ignore lines in other kinds of tests than parser tests.
1832         (PerfTest._errors_to_ignore_in_sierra): Added.
1833         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
1834         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1835         (test_parse_output_with_ignored_stdout): Added.
1836         (test_parse_output_with_ignored_stderr): Added.
1837         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
1838
1839 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
1840
1841         Resign NowPlaying status when no media element is eligible
1842         https://bugs.webkit.org/show_bug.cgi?id=181914
1843         <rdar://problem/35294116>
1844
1845         Reviewed by Jer Noble.
1846
1847         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1848         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1849         (TestWebKitAPI::TEST):
1850         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1851
1852 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1853
1854         [WinCairo] Use 64-bit toolset
1855         https://bugs.webkit.org/show_bug.cgi?id=181979
1856
1857         Reviewed by Alex Christensen.
1858
1859         Use 64-bit toolset for 64-bit build in order to improve build time. 
1860
1861         * Scripts/webkitdirs.pm:
1862         (generateBuildSystemFromCMakeProject):
1863
1864 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
1865
1866         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
1867         https://bugs.webkit.org/show_bug.cgi?id=181741
1868         rdar://problem/36593581
1869
1870         Reviewed by Tim Horton.
1871         
1872         If zoomToScale:animated: is called with the current zoom level, call the callback
1873         rather than doing nothing.
1874
1875         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1876         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1877
1878 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1879
1880         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
1881         https://bugs.webkit.org/show_bug.cgi?id=180820
1882
1883         Reviewed by David Kilzer.
1884
1885         * Scripts/webkitpy/common/checkout/scm/git.py:
1886         (Git.in_working_directory):
1887         (Git.clone):
1888         (Git.read_git_config):
1889         (Git.apply_reverse_diff):
1890         * Scripts/webkitpy/common/checkout/scm/scm.py:
1891         (SCM.run):
1892         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1893         * Scripts/webkitpy/common/checkout/scm/svn.py:
1894         (SVNRepository.has_authorization_for_realm):
1895         * Scripts/webkitpy/common/net/credentials_unittest.py:
1896         * Scripts/webkitpy/common/system/abstractexecutive.py:
1897         (AbstractExecutive.run_command):
1898         * Scripts/webkitpy/common/system/executive.py:
1899         (Executive.kill_process.is):
1900         (Executive.running_pids):
1901         (Executive.kill_all):
1902         (Executive.run_command):
1903         * Scripts/webkitpy/common/system/executive_mock.py:
1904         (MockExecutive.run_command):
1905         (MockExecutive2.run_command):
1906         * Scripts/webkitpy/common/system/executive_unittest.py:
1907         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
1908         * Scripts/webkitpy/common/system/platforminfo.py:
1909         (PlatformInfo.xcode_sdk_version):
1910         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1911         (Lighttpd._check_and_kill):
1912         * Scripts/webkitpy/port/base.py:
1913         (Port._symbols_string):
1914         * Scripts/webkitpy/port/gtk.py:
1915         (GtkPort.setup_environ_for_server):
1916         * Scripts/webkitpy/port/win.py:
1917         (WinPort._runtime_feature_list):
1918         (WinPort.read_registry_value):
1919         * Scripts/webkitpy/port/win_unittest.py:
1920         (WinPortTest.test_runtime_feature_list):
1921         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1922         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
1923
1924 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1925
1926         Unreviewed, rolling out r227279 and r227373.
1927         https://bugs.webkit.org/show_bug.cgi?id=181988
1928
1929         The LayoutTest crash fix introduced an API test failure.
1930         (Requested by ryanhaddad on #webkit).
1931
1932         Reverted changesets:
1933
1934         "Resign NowPlaying status when no media element is eligible"
1935         https://bugs.webkit.org/show_bug.cgi?id=181914
1936         https://trac.webkit.org/changeset/227279
1937
1938         "Resign NowPlaying status when no media element is eligible"
1939         https://bugs.webkit.org/show_bug.cgi?id=181914
1940         https://trac.webkit.org/changeset/227373
1941
1942 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1943
1944         Unreviewed. Add test case for slow in test_expectations.py.
1945
1946         I forgot to also check slow tests in test_expectations.py unit tests.
1947
1948         * Scripts/webkitpy/common/test_expectations_unittest.py:
1949         (assert_slow):
1950         (test_build_type):
1951         (test_slow):
1952
1953 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1954
1955         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
1956
1957         * TestWebKitAPI/glib/TestExpectations.json:
1958
1959 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1960
1961         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
1962         https://bugs.webkit.org/show_bug.cgi?id=181616
1963         <rdar://problem/36484908>
1964
1965         Reviewed by Wenson Hsieh.
1966
1967         Added tests to make sure we sanitize plain HTML, not just web archives,
1968         when and only when custom pasteboard data is enabled.
1969
1970         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1971         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
1972         (writeHTMLToPasteboard): Added.
1973         (createWebViewWithCustomPasteboardDataSetting): Added.
1974
1975 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
1976
1977         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
1978         https://bugs.webkit.org/show_bug.cgi?id=181400
1979         rdar://problem/36358768
1980
1981         Reviewed by JF Bastien.
1982
1983         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
1984
1985 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1986
1987         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
1988         https://bugs.webkit.org/show_bug.cgi?id=181929
1989
1990         Reviewed by Michael Catanzaro.
1991
1992         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
1993         the website data completion callback is not called immediately, and a new file is created when the operation
1994         finishes. We need to check that the file was removing after calling clear.
1995
1996         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1997         (fileChangedCallback):
1998         (testWebsiteDataResourceLoadStatistics):
1999
2000 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2001
2002         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
2003
2004         * TestWebKitAPI/glib/TestExpectations.json:
2005
2006 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2007
2008         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
2009
2010         Partially revert r226782, the fix was wrong for the GLib version we currently use.
2011
2012         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2013         (testWebKitConsoleMessageNetworkError):
2014
2015 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2016
2017         Unreviewed. Remove unused verbose mode from GLib API tests runner.
2018
2019         * glib/api_test_runner.py:
2020         (add_options):
2021
2022 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2023
2024         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
2025         https://bugs.webkit.org/show_bug.cgi?id=181918
2026
2027         Reviewed by Tim Horton.
2028
2029         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
2030
2031         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2032
2033 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
2034
2035         Resign NowPlaying status when no media element is eligible
2036         https://bugs.webkit.org/show_bug.cgi?id=181914
2037         <rdar://problem/35294116>
2038
2039         Reviewed by Jer Noble.
2040
2041         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2042         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
2043         (TestWebKitAPI::TEST):
2044         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
2045
2046 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
2047
2048         Fix broken unit-tests after r227192
2049         https://bugs.webkit.org/show_bug.cgi?id=181909
2050
2051         Reviewed by Carlos Garcia Campos.
2052
2053         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2054
2055 2018-01-20  Chris Dumez  <cdumez@apple.com>
2056
2057         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
2058         https://bugs.webkit.org/show_bug.cgi?id=174984
2059         <rdar://problem/33665676>
2060
2061         Reviewed by Alexey Proskuryakov.
2062
2063         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
2064
2065         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2066         (TEST):
2067
2068 2018-01-20  Brian Burg  <bburg@apple.com>
2069
2070         WebDriver: fix some nits that prevent running W3C tests on Mac
2071         https://bugs.webkit.org/show_bug.cgi?id=181864
2072
2073         Reviewed by Carlos Garcia Campos.
2074
2075         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2076         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
2077         as we assume that the property exists later.
2078
2079         (WebDriverW3CWebServer.stop): If the temporary file doesn't
2080         exist for some reason, the remove call will raise and exception.
2081         Gracefully handle the case where the file isn't created due to
2082         a problem/exception that happened elsewhere.
2083
2084 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
2085
2086         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
2087         https://bugs.webkit.org/show_bug.cgi?id=181881
2088
2089         Reviewed by Alexey Proskuryakov.
2090
2091         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2092         (BubbleQueueServer):
2093         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2094         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2095         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
2096
2097 2018-01-19  Youenn Fablet  <youenn@apple.com>
2098
2099         Do not go to the storage process when registering a service worker client if there is no service worker registered
2100         https://bugs.webkit.org/show_bug.cgi?id=181740
2101         <rdar://problem/36650400>
2102
2103         Reviewed by Chris Dumez.
2104
2105         Add support for internals inside API tests.
2106
2107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2108         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
2109         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
2110         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
2111         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
2112         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
2113         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2114         (setConfigurationInjectedBundlePath):
2115         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
2116
2117 2018-01-19  John Wilander  <wilander@apple.com>
2118
2119         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
2120         https://bugs.webkit.org/show_bug.cgi?id=181822
2121         https://bugs.webkit.org/show_bug.cgi?id=175263
2122         https://bugs.webkit.org/show_bug.cgi?id=178536
2123         https://bugs.webkit.org/show_bug.cgi?id=181223
2124         https://bugs.webkit.org/show_bug.cgi?id=181482
2125         <rdar://problem/33491222>
2126         <rdar://problem/33805293>
2127         <rdar://problem/36332683>
2128         <rdar://problem/36549026>
2129
2130         Reviewed by Alex Christensen.
2131
2132         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2133         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2134         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2135         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2136         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2137         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2138         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2139         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2140
2141 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
2142
2143         run-webkit-tests fails when there is a curly brace in Xcode build output
2144         https://bugs.webkit.org/show_bug.cgi?id=181254
2145         <rdar://problem/36453374>
2146
2147         Reviewed by Daniel Bates.
2148
2149         * Scripts/webkitpy/port/base.py:
2150         (Port._run_script): Encode script output before logging it.
2151
2152 2018-01-19  Chris Dumez  <cdumez@apple.com>
2153
2154         Service worker registrations restored from disk may not be reused when the JS calls register() again
2155         https://bugs.webkit.org/show_bug.cgi?id=181810
2156         <rdar://problem/36591711>
2157
2158         Reviewed by Youenn Fablet.
2159
2160         Add API test coverage.
2161
2162         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2163         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
2164         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
2165
2166 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
2167
2168         Remove El Capitan queues from flakiness dashboard
2169         https://bugs.webkit.org/show_bug.cgi?id=181860
2170
2171         Reviewed by Aakash Jain.
2172
2173         * TestResultServer/static-dashboards/builders.jsonp:
2174
2175 2018-01-19  Keith Miller  <keith_miller@apple.com>
2176
2177         HaveInternalSDK includes should be "#include?"
2178         https://bugs.webkit.org/show_bug.cgi?id=179670
2179
2180         Reviewed by Dan Bernstein.
2181
2182         * MiniBrowser/Configurations/Base.xcconfig:
2183         * MobileMiniBrowser/Configurations/Base.xcconfig:
2184         * TestWebKitAPI/Configurations/Base.xcconfig:
2185         * WebKitTestRunner/Configurations/Base.xcconfig:
2186
2187 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2188
2189         WebDriver: driver environment not passed to pytest when running w3c tests
2190         https://bugs.webkit.org/show_bug.cgi?id=181852
2191
2192         Reviewed by Carlos Alberto Lopez Perez.
2193
2194         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
2195
2196         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2197         (WebDriverW3CExecutor.run):
2198
2199 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2200
2201         [GTK] WebDriver: wayland display no used in wayland bot
2202         https://bugs.webkit.org/show_bug.cgi?id=181851
2203
2204         Reviewed by Carlos Alberto Lopez Perez.
2205
2206         We need to handle the additionalArguments property in the WebDriverTests step.
2207
2208         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2209         (RunWebDriverTests.start):
2210
2211 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2212
2213         [GTK] TERM environment variable is not passed to the test driver.
2214         https://bugs.webkit.org/show_bug.cgi?id=181847
2215
2216         Rubber-stamped by by Carlos Garcia Campos.
2217
2218         * Scripts/webkitpy/port/base.py:
2219         (Port.to.setup_environ_for_server):
2220
2221 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2222
2223         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
2224         https://bugs.webkit.org/show_bug.cgi?id=181844
2225
2226         Reviewed by Carlos Alberto Lopez Perez.
2227
2228         We always try to create the directory where to store the json file, but when the filename is given directly,
2229         like in the bots, the current dir is used.
2230
2231         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2232         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
2233         empty string.
2234
2235 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2236
2237         [GTK] WebDriver tests are running outside the jhbuild env
2238         https://bugs.webkit.org/show_bug.cgi?id=181842
2239
2240         Reviewed by Žan Doberšek.
2241
2242         We need to enter jhbuild env in run-webdriver-tests.
2243
2244         * Scripts/run-webdriver-tests:
2245
2246 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2247
2248         [GTK] Run WebDriver tests in the bots
2249         https://bugs.webkit.org/show_bug.cgi?id=181787
2250
2251         Reviewed by Michael Catanzaro.
2252
2253         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
2254         factory for the GTK port for now.
2255
2256         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2257         (TestFactory.__init__):
2258         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2259         (RunWebDriverTests):
2260         (RunWebDriverTests.start):
2261         (RunWebDriverTests.commandComplete):
2262         (RunWebDriverTests.evaluateCommand):
2263         (RunWebDriverTests.getText):
2264         (RunWebDriverTests.getText2):
2265
2266 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2267
2268         [WinCairo] Pass correct url for http test to test driver.
2269         https://bugs.webkit.org/show_bug.cgi?id=181814
2270
2271         Reviewed by Alex Christensen.
2272
2273         * Scripts/webkitpy/port/driver.py:
2274         (Driver):
2275         (Driver.http_test_path_to_uri):
2276         (Driver.is_secure_path):
2277         (Driver.http_base_url):
2278         (Driver.uri_to_test):
2279
2280 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2281
2282         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
2283
2284         * BuildSlaveSupport/build.webkit.org-config/config.json:
2285
2286 2018-01-18  Dan Bernstein  <mitz@apple.com>
2287
2288         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
2289         https://bugs.webkit.org/show_bug.cgi?id=181803
2290
2291         Reviewed by Tim Horton.
2292
2293         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
2294         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
2295         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
2296         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
2297         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
2298         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2299         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2300         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2301         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
2302           helpers.
2303         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
2304           settings useful for defining settings that depend on the target macOS version.
2305         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
2306         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
2307
2308 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
2309
2310         Remove Opensource El Capitan queues from buildbot
2311         https://bugs.webkit.org/show_bug.cgi?id=181712
2312
2313         Reviewed by Aakash Jain.
2314
2315         * BuildSlaveSupport/build.webkit.org-config/config.json:
2316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2317         (WebKitBuildbot):
2318         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2319
2320 2018-01-18  Chris Dumez  <cdumez@apple.com>
2321
2322         Service Workers restored from persistent storage have 'redundant' state
2323         https://bugs.webkit.org/show_bug.cgi?id=181749
2324         <rdar://problem/36556486>
2325
2326         Reviewed by Youenn Fablet.
2327
2328         Add API test coverage.
2329
2330         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2331         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
2332
2333 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2334
2335         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
2336         https://bugs.webkit.org/show_bug.cgi?id=176796
2337
2338         Reviewed by Chris Fleizach.
2339
2340         Add sanity check that we have a URL before calling g_strstr_len().
2341
2342         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2343         (WTR::AccessibilityUIElement::url):
2344
2345 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2346
2347         Add triggers for Sierra test262 and perf queues
2348         https://bugs.webkit.org/show_bug.cgi?id=181799
2349
2350         Reviewed by Aakash Jain.
2351
2352         * BuildSlaveSupport/build.webkit.org-config/config.json:
2353
2354 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2355
2356         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
2357         https://bugs.webkit.org/show_bug.cgi?id=181783
2358         <rdar://problem/35785445>
2359
2360         Reviewed by Ryosuke Niwa.
2361
2362         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
2363         copying an image contains a relevant title.
2364
2365         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2366         (TestWebKitAPI::TEST):
2367         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2368         * TestWebKitAPI/ios/UIKitSPI.h:
2369
2370 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2371
2372         WebDriver: ignore the driver in selenium test names when getting expectations
2373         https://bugs.webkit.org/show_bug.cgi?id=181738
2374
2375         Reviewed by Carlos Alberto Lopez Perez.
2376
2377         In selenium tests, the driver is added as a parameter to every test which results in tests names like
2378         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
2379         driver name in the test expectations file, so we need to remove it when querying the expectations.
2380
2381         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2382         (TestExpectationsMarker.__init__): Save the param to ignore.
2383         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
2384         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
2385         (run): Pass param to ignore to TestExpectationsMarker().
2386         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2387         (WebDriverSeleniumExecutor.__init__): Save the driver name.
2388         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
2389
2390 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2391
2392         [GTK][WPE] Show unit tests unexpectedly passing in the bots
2393         https://bugs.webkit.org/show_bug.cgi?id=181726
2394
2395         Reviewed by Michael Catanzaro.
2396
2397         Now that we have the info, let's show it also in the bots.
2398
2399         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2400         (RunGLibAPITests.commandComplete):
2401
2402 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
2403
2404         Fix broken unittest after r227048
2405         https://bugs.webkit.org/show_bug.cgi?id=181760
2406
2407         Reviewed by Aakash Jain.
2408
2409
2410 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2411
2412         WEBKIT_FRAMEWORK should not modify file-global include directories
2413         https://bugs.webkit.org/show_bug.cgi?id=181656
2414
2415         Reviewed by Konstantin Tokarev.
2416
2417         * TestWebKitAPI/PlatformWPE.cmake:
2418         * TestWebKitAPI/glib/CMakeLists.txt:
2419
2420 2018-01-17  Alicia Boya García  <aboya@igalia.com>
2421
2422         Unreviewed, mark Alicia as committer in contributors.json
2423
2424         * Scripts/webkitpy/common/config/contributors.json:
2425
2426 2018-01-17  Youenn Fablet  <youenn@apple.com>
2427
2428         Put fetch Request.keepalive behind a runtime flag
2429         https://bugs.webkit.org/show_bug.cgi?id=181592
2430
2431         Reviewed by Chris Dumez.
2432
2433         * DumpRenderTree/mac/DumpRenderTree.mm:
2434         (enableExperimentalFeatures):
2435         * DumpRenderTree/win/DumpRenderTree.cpp:
2436         (enableExperimentalFeatures):
2437         * WebKitTestRunner/TestController.cpp:
2438         (WTR::TestController::resetPreferencesToConsistentValues):
2439
2440 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2441
2442         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2443         https://bugs.webkit.org/show_bug.cgi?id=181637
2444         <rdar://problem/36508471>
2445
2446         Reviewed by Tim Horton.
2447
2448         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
2449         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
2450
2451         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2452         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2453         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
2454
2455         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
2456         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
2457
2458         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2459         (webViewForTestingAttachments):
2460         (-[TestWKWebView tagsInBody]):
2461         (-[TestWKWebView expectElementTagsInOrder:]):
2462         (-[TestWKWebView expectElementTag:toComeBefore:]):
2463
2464         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
2465         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
2466
2467         (TestWebKitAPI::TEST):
2468         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2469         (WTR::InjectedBundlePage::InjectedBundlePage):
2470
2471 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2472
2473         WebDriver: add support for test expectations
2474         https://bugs.webkit.org/show_bug.cgi?id=180420
2475
2476         Reviewed by Carlos Alberto Lopez Perez.
2477
2478         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
2479
2480         * Scripts/run-webdriver-tests: Get the retval from process_results().
2481         * Scripts/webkitpy/thirdparty/__init__.py:
2482         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
2483         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2484         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
2485         (TestExpectationsMarker.__init__): Initialize expectations.
2486         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
2487         (run): Create and use TestExpectationsMarker plugin.
2488         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2489         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
2490         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2491         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
2492         (WebDriverTestRunner.run): Do not count results here.
2493         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
2494         amount of failures. Printing the test summary while processing results will be made optional in a follow up
2495         patch.
2496         (WebDriverTestRunner.process_results.report): Return the amount of failures.
2497         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2498         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
2499         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
2500         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
2501         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2502         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
2503         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
2504         (WebDriverTestRunnerW3C._scan_directory): Ditto.
2505         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
2506         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2507         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
2508
2509 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2510
2511         Unreviewed WPE gardening. Mark some known unit test failures.
2512
2513         * TestWebKitAPI/glib/TestExpectations.json:
2514
2515 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2516
2517         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
2518         https://bugs.webkit.org/show_bug.cgi?id=181724
2519
2520         Reviewed by Philippe Normand.
2521
2522         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
2523         reason to use different names. This way we can refer to the same test names for both and we can share the
2524         expectations in the TestExpectations.json file.
2525
2526         * TestWebKitAPI/glib/TestExpectations.json:
2527         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
2528
2529 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2530
2531         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
2532
2533         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
2534         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
2535
2536         * glib/api_test_runner.py:
2537         (TestRunner._run_test_glib):
2538         (TestRunner._run_google_test):
2539
2540 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2541
2542         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
2543         https://bugs.webkit.org/show_bug.cgi?id=179914
2544
2545         Reviewed by Žan Doberšek.
2546
2547         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
2548         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
2549         all symbols listed in the script are present in the library.
2550
2551         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
2552         (bss_symbols):
2553         * Scripts/check-for-invalid-symbols-in-version-script: Added.
2554         (script_symbols):
2555         * Scripts/make-dist:
2556         (Distcheck.build):
2557         (Distcheck):
2558         (Distcheck.check_symbols):
2559         (Distcheck.check):
2560
2561 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2562
2563         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
2564         https://bugs.webkit.org/show_bug.cgi?id=181722
2565
2566         Reviewed by Žan Doberšek.
2567
2568         I forgot to pass the parameters to run() when restarting.
2569
2570         * glib/glib_test_runner.py:
2571         (GLibTestRunner.run):
2572
2573 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
2574
2575         [CMake] Remove WebCoreDerivedSources library target
2576         https://bugs.webkit.org/show_bug.cgi?id=181664
2577
2578         Reviewed by Carlos Garcia Campos.
2579
2580         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
2581         * TestWebKitAPI/PlatformWin.cmake: Ditto.
2582
2583 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
2584
2585         Move Debug Test262, Release Test262 and Performance queues to Sierra
2586         https://bugs.webkit.org/show_bug.cgi?id=181692
2587
2588         Unreviewed
2589
2590 2018-01-16  Zach Li  <zachli@apple.com>
2591
2592         Add pop-up policy support in website policies.
2593         https://bugs.webkit.org/show_bug.cgi?id=181544.
2594         rdar://problem/30521400.
2595
2596         Reviewed by Alex Christensen.
2597
2598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2599         Added pop-up-check.html.
2600
2601         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
2602
2603         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2604         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2605         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2606         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2607         (TEST):
2608
2609 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2610
2611         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
2612         https://bugs.webkit.org/show_bug.cgi?id=181638
2613         <rdar://problem/36508702>
2614
2615         Reviewed by Dan Bernstein.
2616
2617         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
2618         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
2619
2620         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2621         (-[AttachmentUpdateObserver init]):
2622         (-[AttachmentUpdateObserver sourceForIdentifier:]):
2623         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
2624         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
2625         (TestWebKitAPI::TEST):
2626         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
2627
2628 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2629
2630         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
2631
2632         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
2633
2634         * glib/api_test_runner.py:
2635         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
2636         * glib/glib_test_runner.py:
2637         (GLibTestRunner.run): Use given env.
2638
2639 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2640
2641         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
2642         https://bugs.webkit.org/show_bug.cgi?id=181676
2643
2644         Reviewed by Carlos Alberto Lopez Perez.
2645
2646         The option was removed in r226967.
2647
2648         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2649         (RunGtkAPITests):
2650         (RunWPEAPITests):
2651
2652 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2653
2654         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
2655
2656         The bots are still passing that option and the step is failing because it was removed in r226967.
2657
2658         * glib/api_test_runner.py:
2659         (add_options):
2660
2661 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2662
2663         [GTK][WPE] Improve the way glib tests are run
2664         https://bugs.webkit.org/show_bug.cgi?id=181674
2665
2666         Reviewed by Žan Doberšek.
2667
2668         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
2669         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
2670         tests failing due to an expected assert in the test and unexpected crashes.
2671         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
2672         not showing the subtest name in stdout in case of timeouts.
2673         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
2674         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
2675         of every test case.
2676
2677         * glib/api_test_runner.py:
2678         (TestRunner._run_test_glib): Use GLibTestRunner.
2679         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
2680         (add_options):
2681         * glib/glib_test_runner.py: Added.
2682         (TestTimeout):
2683         (Message):
2684         (Message.__init__):
2685         (Message.create):
2686         (Message.create.read_unsigned):
2687         (Message.create.read_double):
2688         (Message.create.read_string):
2689         (GLibTestRunner):
2690         (GLibTestRunner.__init__):
2691         (GLibTestRunner._process_data):
2692         (GLibTestRunner._process_message):
2693         (GLibTestRunner._read_from_pipe):
2694         (GLibTestRunner._read_from_stderr):
2695         (GLibTestRunner._start_timeout):
2696         (GLibTestRunner._start_timeout._alarm_handler):
2697         (GLibTestRunner._stop_timeout):
2698         (GLibTestRunner._subtest_start):
2699         (GLibTestRunner._subtest_message):
2700         (GLibTestRunner._subtest_stderr):
2701         (GLibTestRunner._subtest_end):
2702         (GLibTestRunner.run):
2703
2704 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2705
2706         Unreviewed, add Thibault to contributors.json
2707
2708         It's a bit weird to add someone here before their first contribution, but this affects
2709         Bugzilla autocomplete, and that is serious business.
2710
2711         * Scripts/webkitpy/common/config/contributors.json:
2712
2713 2018-01-15  JF Bastien  <jfbastien@apple.com>
2714
2715         Remove makePoisonedUnique
2716         https://bugs.webkit.org/show_bug.cgi?id=181630
2717         <rdar://problem/36498623>
2718
2719         Reviewed by Mark Lam.
2720
2721         Update tests.
2722
2723         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2724         (TestWebKitAPI::TEST):
2725         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2726         (TestWebKitAPI::TEST):
2727
2728 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
2729
2730         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
2731         https://bugs.webkit.org/show_bug.cgi?id=181476
2732
2733         Reviewed by Michael Catanzaro.
2734
2735         Update to xorg-server 1.19.6 which depends on libxfont2, and change
2736         the lists of packages to install libxfont2-devel (or equivalent).
2737
2738         * gtk/install-dependencies:
2739         * gtk/jhbuild.modules:
2740
2741 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2742
2743         [GTK][WPE] Add support for unit test expectations
2744         https://bugs.webkit.org/show_bug.cgi?id=181589
2745
2746         Reviewed by Michael Catanzaro.
2747
2748         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
2749         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
2750         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
2751         script itself is not a good idea either.
2752
2753         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
2754         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
2755         convenient methods to query them.
2756
2757         * Scripts/run-gtk-tests:
2758         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
2759         * Scripts/run-wpe-tests:
2760         (WPETestRunner): Ditto.
2761         * Scripts/webkitpy/common/test_expectations.py: Added.
2762         (TestExpectations):
2763         (TestExpectations.__init__):
2764         (TestExpectations._port_name_for_expected):
2765         (TestExpectations._expected_value):
2766         (TestExpectations.skipped_tests):
2767         (TestExpectations.skipped_subtests):
2768         (TestExpectations._expectation_value):
2769         (TestExpectations.is_slow):
2770         (TestExpectations.get_expectation):
2771         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
2772         (MockTestExpectations):
2773         (MockTestExpectations.__init__):
2774         (MockTestExpectations.is_skip):
2775         (ExpectationsTest):
2776         (assert_exp):
2777         (assert_not_exp):
2778         (assert_bad_exp):
2779         (assert_skip):
2780         (test_basic):
2781         (test_skip):
2782         (test_flaky):
2783         (test_build_type):
2784         * TestWebKitAPI/glib/TestExpectations.json: Added.
2785         * glib/api_test_runner.py:
2786         (TestRunner): Remove SkippedTest implementation.
2787         (TestRunner.__init__): Create a TestExpectations.
2788         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
2789         (TestRunner._should_run_test_program): Ditto.
2790         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
2791         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
2792         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
2793         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
2794         (TestRunner.run_tests.report): Helper to write report to stdout.
2795
2796 2018-01-13  Mark Lam  <mark.lam@apple.com>
2797
2798         Replace all use of ConstExprPoisoned with Poisoned.
2799         https://bugs.webkit.org/show_bug.cgi?id=181542
2800         <rdar://problem/36442138>
2801
2802         Reviewed by JF Bastien.
2803
2804         1. Converted tests to using new uintptr_t& poison type.
2805         2. Added tests for Poisoned comparison operators.
2806
2807         * TestWebKitAPI/CMakeLists.txt:
2808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2809         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
2810         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2811         (TestWebKitAPI::TEST):
2812         (TestWebKitAPI::initializeTestPoison): Deleted.
2813         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2814         (TestWebKitAPI::TEST):
2815         (TestWebKitAPI::passWithRef):
2816         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2817         (TestWebKitAPI::TEST):
2818         (TestWebKitAPI::f1):
2819         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2820         (TestWebKitAPI::TEST):
2821         (TestWebKitAPI::poisonedPtrFoo):
2822         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2823         (TestWebKitAPI::TEST):
2824         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2825         (TestWebKitAPI::TEST):
2826
2827 2018-01-13  David Kilzer  <ddkilzer@apple.com>
2828
2829         check-webkit-style: false positive for [whitespace/braces] with os_log format string
2830         <https://webkit.org/b/181606>
2831
2832         Reviewed by Darin Adler.
2833
2834         * Scripts/webkitpy/style/checkers/cpp.py:
2835         (check_spacing): Modify regular expression to ignore
2836         os_log format strings like '%{public}'.
2837         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2838         (CppStyleTest.test_spacing_before_braces): Add os_log
2839         format string test.
2840
2841 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2842
2843         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
2844         https://bugs.webkit.org/show_bug.cgi?id=181626
2845
2846         Reviewed by Joseph Pecoraro.
2847
2848         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
2849         Additionally, write a new API test covering the change in r226915.
2850
2851         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2852         (webViewForTestingAttachments):
2853         (TestWebKitAPI::TEST):
2854
2855 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2856
2857         History state should be updated during client redirects with asynchronous policy decisions
2858         https://bugs.webkit.org/show_bug.cgi?id=181358
2859         <rdar://problem/35547689>
2860
2861         Reviewed by Andy Estes.
2862
2863         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2864         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
2865         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2866         (TEST):
2867
2868 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
2869
2870         webkitpy: Refactor simulator code (Part 4)
2871         https://bugs.webkit.org/show_bug.cgi?id=180555
2872         <rdar://problem/36131381>
2873
2874         Reviewed by Aakash Jain.
2875
2876         Move new_simulated_device.py to simulated_device.py.
2877
2878         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
2879         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
2880         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
2881         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
2882         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
2883
2884 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2885
2886         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
2887         https://bugs.webkit.org/show_bug.cgi?id=181595
2888
2889         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
2890         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
2891         I change the < and > to $ to make this test pass and continue to test what it used to.
2892
2893         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
2894         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2895         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2896
2897 2018-01-11  Keith Miller  <keith_miller@apple.com>
2898
2899         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
2900         https://bugs.webkit.org/show_bug.cgi?id=181573
2901
2902         Reviewed by Simon Fraser.
2903
2904         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2905
2906 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
2907
2908         [WebAuthN] Import a CBOR coder from Chromium
2909         https://bugs.webkit.org/show_bug.cgi?id=181522
2910         <rdar://problem/36055729>
2911
2912         Reviewed by Brent Fulgham.
2913
2914         This patch also imports all unit tests into our API tests to ensure all
2915         workarounds and modification against the original codebase doesn't change
2916         any original functionalities.
2917
2918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2919         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
2920         (TestWebKitAPI::TEST):
2921         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
2922         (TestWebKitAPI::TEST):
2923         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
2924         (TestWebKitAPI::eq):
2925         Workarounds applied.
2926         (TestWebKitAPI::TEST):
2927
2928 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2929
2930         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
2931         https://bugs.webkit.org/show_bug.cgi?id=181538
2932         <rdar://problem/36440580>
2933
2934         Reviewed by Aakash Jain.
2935
2936         When disambiguating a device type, it is possible that the provided device type is sufficiently
2937         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
2938         will result in a failure to disambiguate the type.
2939
2940         * Scripts/webkitpy/xcode/new_simulated_device.py:
2941         (SimulatedDeviceManager._disambiguate_device_type):
2942
2943 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
2944
2945         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
2946         https://bugs.webkit.org/show_bug.cgi?id=181136
2947         <rdar://problem/36116604>
2948
2949         Reviewed by Chris Dumez.
2950
2951         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
2952         browsing sessions.
2953
2954         * Scripts/run-gtk-tests:
2955         (GtkTestRunner): Unskip test now that it passes.
2956         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2957         (TEST): Add new WebsiteDataStoreEphemeral test.
2958
2959 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2960
2961         Unreviewed, rolling out r226816.
2962
2963         This change broke LayoutTests on the bots.
2964
2965         Reverted changeset:
2966
2967         "run-webkit-tests fails when there is a curly brace in Xcode
2968         build output"
2969         https://bugs.webkit.org/show_bug.cgi?id=181254
2970         https://trac.webkit.org/changeset/226816
2971
2972 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2973
2974         webkitpy: Fix flakey webserver tests
2975         https://bugs.webkit.org/show_bug.cgi?id=181555
2976         <rdar://problem/36448273>
2977
2978         Reviewed by Aakash Jain.
2979
2980         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2981         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
2982         determine if a specific server is running.
2983
2984 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2985
2986         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
2987         https://bugs.webkit.org/show_bug.cgi?id=181561
2988         <rdar://problem/36452652>
2989
2990         Reviewed by Aakash Jain.
2991
2992         BeautifulSoup.find may return None, this case should be gracefully handled.
2993
2994         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2995         (BugzillaQueries._parse_result_count):
2996         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
2997
2998 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
2999
3000         run-webkit-tests fails when there is a curly brace in Xcode build output
3001         https://bugs.webkit.org/show_bug.cgi?id=181254
3002
3003         Reviewed by Daniel Bates.
3004
3005         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3006         (MeteredStream.write):
3007
3008 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3009
3010         webkitpy: Reimplement simulator code (Part 3)
3011         https://bugs.webkit.org/show_bug.cgi?id=180555
3012         <rdar://problem/36131381>
3013
3014         Reviewed by Aakash Jain.
3015
3016         Remove old simulator code.
3017
3018         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
3019         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
3020         * Scripts/webkitpy/xcode/simulator.py: Removed.
3021         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
3022
3023 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3024
3025         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
3026         https://bugs.webkit.org/show_bug.cgi?id=181337
3027         <rdar://problem/36324813>
3028
3029         Reviewed by Tim Horton.
3030
3031         Add 3 new API tests for attachment element dragging.
3032
3033         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3034         (-[TestWKWebView expectElementTag:toComeBefore:]):
3035         (-[NSItemProvider expectType:withData:]):
3036         (TestWebKitAPI::TEST):
3037
3038 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
3039
3040         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
3041         https://bugs.webkit.org/show_bug.cgi?id=179621
3042         <rdar://problem/35589585>
3043
3044         Unreviewed infrastructure fix.
3045
3046         * Scripts/webkitpy/port/mac.py:
3047         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
3048         list if we are the VERSION_MAX, which usually corresponds with future.
3049
3050 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
3051
3052         CodeBlocks should be in IsoSubspaces
3053         https://bugs.webkit.org/show_bug.cgi?id=180884
3054
3055         Reviewed by Saam Barati.
3056         
3057         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
3058         shouldn't take a long time due to benchmarks we don't optimize for.
3059         
3060         * Scripts/run-jsc-benchmarks:
3061
3062 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
3063
3064         Test gardening for GTK.
3065         https://bugs.webkit.org/show_bug.cgi?id=181477
3066
3067         Unreviewed test gardening.
3068
3069         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
3070         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
3071
3072 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3073
3074         Add the new JSCOnly bot to the scheduler.
3075         https://bugs.webkit.org/show_bug.cgi?id=181487
3076
3077         Unreviewed follow-up patch after r226729
3078
3079         On r226729 I missed to add the new JSCOnly bot the default scheduler.
3080         This is needed to make the bot automatically pick each commit for testing.
3081
3082         * BuildSlaveSupport/build.webkit.org-config/config.json:
3083
3084 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3085
3086         [Attachment Support] Support dragging attachment elements out as files on iOS
3087         https://bugs.webkit.org/show_bug.cgi?id=181199
3088         <rdar://problem/36299316>
3089
3090         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
3091
3092         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
3093         attachment API tests.
3094
3095         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3096         (-[NSItemProvider expectType:withData:]):
3097         (TestWebKitAPI::TEST):
3098
3099         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
3100         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
3101         -expectType:withData: helper to inspect the item providers created from the drag source.
3102
3103         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3104         (TestWebKitAPI::TEST):
3105         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3106         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3107         (-[MockDragSession localContext]):
3108         (-[MockDragSession setLocalContext:]):
3109         (-[DataInteractionSimulator _resetSimulatedState]):
3110         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
3111         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3112         (-[DataInteractionSimulator _advanceProgress]):
3113         (-[DataInteractionSimulator endDataTransfer]):
3114
3115         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
3116         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
3117         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
3118         MockDragSession to hold on to a localContext.
3119
3120 2018-01-11  Ali Juma  <ajuma@chromium.org>
3121
3122         Unreviewed. Add Ali Juma as contributor
3123
3124         * Scripts/webkitpy/common/config/contributors.json:
3125
3126 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3127
3128         Unreviewed. Update Selenium WebDriver imported tests.
3129
3130         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
3131         environment variables.
3132
3133         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3134         (collect): Reorder the arguments to make pytest happy.
3135         (run): Ditto.
3136         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3137         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
3138
3139 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
3140
3141         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
3142         https://bugs.webkit.org/show_bug.cgi?id=181492
3143         <rdar://problem/36359679>
3144
3145         Reviewed by Alexey Proskuryakov. 
3146
3147 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
3148
3149         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
3150         https://bugs.webkit.org/show_bug.cgi?id=181475
3151
3152         Reviewed by Michael Catanzaro.
3153
3154         * gtk/install-dependencies: Update package list for Arch Linux, extend
3155         message shown at end of installation with additional tips.
3156
3157 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3158
3159         REGRESSION(r222507): Composition highlight doesn't render when using IME
3160         https://bugs.webkit.org/show_bug.cgi?id=181485
3161         <rdar://problem/35896516>
3162
3163         Reviewed by Ryosuke Niwa.
3164
3165         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
3166         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
3167         allow rendering composition backgrounds (see InlineTextBox::paint).
3168
3169         * DumpRenderTree/ios/TextInputControllerIOS.m:
3170         (+[TextInputController isSelectorExcludedFromWebScript:]):
3171         (+[TextInputController webScriptNameForSelector:]):
3172         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
3173         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
3174         * DumpRenderTree/mac/TextInputControllerMac.m:
3175         (+[TextInputController isSelectorExcludedFromWebScript:]):
3176         (+[TextInputController webScriptNameForSelector:]):
3177         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
3178         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
3179         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
3180         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
3181         (WTR::TextInputController::setMarkedText):
3182         * WebKitTestRunner/InjectedBundle/TextInputController.h:
3183
3184 2018-01-10  JF Bastien  <jfbastien@apple.com>
3185
3186         Poison small JSObject derivatives which only contain pointers
3187         https://bugs.webkit.org/show_bug.cgi?id=181483
3188         <rdar://problem/36407127>
3189
3190         Reviewed by Mark Lam.
3191
3192         Test the new move-assign and move-copy from unique_ptr, as well as
3193         nullptr_t ctors.
3194
3195         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3196         (TestWebKitAPI::TEST):
3197         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
3198         (TestWebKitAPI::TEST):
3199         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
3200         (TestWebKitAPI::TEST):
3201
3202 2018-01-10  Chris Dumez  <cdumez@apple.com>
3203
3204         Multiple http/wpt/beacon/contentextensions/ test are flaky.
3205         https://bugs.webkit.org/show_bug.cgi?id=179256
3206         <rdar://problem/35401978>
3207
3208         Reviewed by Alex Christensen.
3209
3210         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
3211         instance gets its own folder to avoid conflicts and flakiness.
3212
3213         * WebKitTestRunner/mac/TestControllerMac.mm:
3214         (WTR::TestController::platformConfigureViewForTest):
3215
3216 2018-01-10  Tim Horton  <timothy_horton@apple.com>
3217
3218         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
3219         https://bugs.webkit.org/show_bug.cgi?id=181269
3220         <rdar://problem/35110344>
3221
3222         Reviewed by Simon Fraser.
3223
3224         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3225         (WTR::UIScriptController::beginBackSwipe):
3226         (WTR::UIScriptController::completeBackSwipe):
3227         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3228         (WTR::UIScriptController::beginBackSwipe):
3229         (WTR::UIScriptController::completeBackSwipe):
3230         (WTR::UIScriptController::overridePreference):
3231         (WTR::UIScriptController::replaceTextAtRange):
3232         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3233         (WTR::PlatformWebView::setNavigationGesturesEnabled):
3234         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3235         (WTR::UIScriptController::beginBackSwipe):
3236         (WTR::UIScriptController::completeBackSwipe):
3237         Implement beginBackSwipe and completeBackSwipe on iOS (they already
3238         exist on Mac) in terms of the new WKWebView testing SPI.
3239
3240 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3241
3242         REGRESSION (r226715): ignore WARNING output in linter tests
3243         https://bugs.webkit.org/show_bug.cgi?id=181486
3244         <rdar://problem/36408847>
3245
3246         Reviewed by Aakash Jain.
3247
3248         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
3249
3250         * Scripts/webkitpy/common/system/outputcapture.py:
3251         (OutputCapture.__init__): Pass logging level to be captured.
3252         * Scripts/webkitpy/style/main_unittest.py:
3253         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
3254         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
3255         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
3256         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
3257         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
3258         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
3259         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
3260         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
3261
3262 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3263
3264         Add a JSCOnly MIPS buildbot
3265         https://bugs.webkit.org/show_bug.cgi?id=181487
3266
3267         Reviewed by Michael Catanzaro.
3268
3269         Add the new bot configs definitions for the master and update the unit tests.
3270
3271         * BuildSlaveSupport/build.webkit.org-config/config.json:
3272         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3273
3274 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3275
3276         REGRESSION (r226715): don't re-check number of simulators in child processes
3277         https://bugs.webkit.org/show_bug.cgi?id=181484
3278         <rdar://problem/36407151>
3279
3280         Reviewed by Aakash Jain.
3281
3282         * Scripts/webkitpy/port/ios_simulator.py:
3283         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
3284         are already initialized.
3285
3286 2018-01-10  Commit Queue  <commit-queue@webkit.org>
3287
3288         Unreviewed, rolling out r226667 and r226673.
3289         https://bugs.webkit.org/show_bug.cgi?id=181488
3290
3291         This caused a flaky crash. (Requested by mlewis13 on #webkit).
3292
3293         Reverted changesets:
3294
3295         "CodeBlocks should be in IsoSubspaces"
3296         https://bugs.webkit.org/show_bug.cgi?id=180884
3297         https://trac.webkit.org/changeset/226667
3298
3299         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
3300         https://bugs.webkit.org/show_bug.cgi?id=180884
3301         https://trac.webkit.org/changeset/226673
3302
3303 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3304
3305         Follow-up fix to r226715
3306         https://bugs.webkit.org/show_bug.cgi?id=180555
3307         <rdar://problem/36131381>
3308
3309         Unreviewed infrastructure fix.
3310
3311         * Scripts/webkitpy/xcode/new_simulated_device.py:
3312         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
3313         of delete.
3314
3315 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3316
3317         webkitpy: Refactor simulator code (Part 2)
3318         https://bugs.webkit.org/show_bug.cgi?id=180555
3319         <rdar://problem/36131381>
3320
3321         Reviewed by Aakash Jain.
3322
3323         The patch leverages the SimulatedDeviceManager when running layout tests.
3324         This patch is primarily code removal, since much of the IOSSimulatorPort
3325         was dedicated to managing simulators. The removed code is either now owned by the
3326         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
3327         boot multiple simulators which was made obsolete in Xcode 9.
3328
3329         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3330         (Manager._custom_device_for_test.in): Device names now have spaces in them,
3331         strip those spaces.
3332         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3333         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
3334         * Scripts/webkitpy/port/ios.py:
3335         (IOSPort.__init__): The _current_device idiom is no longer required since the
3336         SimulatedDeviceManager keeps track of any previously booted devices.
3337         (IOSPort.target_host): Even when only a single device is used, it will be accessed
3338         through the array of managed devices.
3339         (IOSPort.using_multiple_devices): Deleted.
3340         * Scripts/webkitpy/port/ios_device.py:
3341         (IOSDevicePort.using_multiple_devices): Deleted.
3342         * Scripts/webkitpy/port/ios_simulator.py:
3343         (IOSSimulatorPort): Remove constants required to manage simulators, change device
3344         class strings so they can be parsed by the DeviceType class.
3345         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
3346         the number of simulators currently booted, the number of child processes specified
3347         and the maximum number of simulators supported by this system.
3348         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
3349         devices owned by the SimulatedDeviceManager.
3350         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
3351         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
3352         the maximum number of supported simulators on this system.
3353         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
3354         request for each child process and send this list to the SimulatedDeviceManager to
3355         initialize the devices.
3356         (IOSSimulatorPort.clean_up_test_run):
3357         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
3358         specified version of iOS.
3359         (IOSSimulatorPort.reset_preferences):
3360         (IOSSimulatorPort.simulator_runtime): Deleted.
3361         (IOSSimulatorPort.simulator_device_type): Deleted.
3362         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
3363         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
3364         (IOSSimulatorPort._create_simulators): Deleted.
3365         (IOSSimulatorPort._quit_ios_simulator): Deleted.
3366         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
3367         (IOSSimulatorPort.using_multiple_devices): Deleted.
3368         (IOSSimulatorPort._create_device): Deleted.
3369         (IOSSimulatorPort.get_simulator_path): Deleted.
3370         (IOSSimulatorPort._createSimulatorApps): Deleted.
3371         (IOSSimulatorPort._createSimulatorApp): Deleted.
3372         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3373         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
3374         maximum number of simulators run on this system.
3375         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
3376         * Scripts/webkitpy/xcode/new_simulated_device.py:
3377         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
3378
3379 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3380
3381         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
3382         https://bugs.webkit.org/show_bug.cgi?id=181474
3383
3384         Reviewed by Carlos Alberto Lopez Perez.
3385
3386         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
3387         name as the name.
3388
3389         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3390         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
3391         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
3392
3393 2018-01-09  Andy Estes  <aestes@apple.com>
3394
3395         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
3396         https://bugs.webkit.org/show_bug.cgi?id=181459
3397
3398         Reviewed by Dan Bernstein.
3399
3400         * ImageDiff/cg/Configurations/Base.xcconfig:
3401
3402 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
3403
3404         font-display:fallback can cause a visual flash (which is supposed to be impossible)
3405         https://bugs.webkit.org/show_bug.cgi?id=181374
3406
3407         Reviewed by Simon Fraser.
3408
3409         The test requires Palatino.
3410
3411         * DumpRenderTree/mac/DumpRenderTree.mm:
3412         (allowedFontFamilySet):
3413         * WebKitTestRunner/mac/TestControllerMac.mm:
3414         (WTR::allowedFontFamilySet):
3415
3416 2018-01-09  Saam Barati  <sbarati@apple.com>
3417
3418         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
3419         https://bugs.webkit.org/show_bug.cgi?id=181449
3420
3421         Reviewed by JF Bastien.
3422
3423         This allows me to Cmd+f in my terminal to search for things without
3424         having the results become misaligned.
3425
3426         * Scripts/display-profiler-output:
3427
3428 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3429
3430         [webkitpy] PlatformInfo should have default argument for casual use
3431         https://bugs.webkit.org/show_bug.cgi?id=180827
3432
3433         Reviewed by David Kilzer.
3434
3435         PlatformInfo should be the only way to check platform specific thing instead
3436         of sys.platform or other various checks. If there is something you want to check,
3437         it should be placed in PlatformInfo.
3438
3439         Currently to instantiate PlatformInfo, it requires arguments, which is usually
3440         sys, platform and Executive(). They are straight forward and should be handled
3441         by default arguments. Then we can instantiate PlatformInfo more casual.
3442
3443         * Scripts/webkitpy/common/system/platforminfo.py:
3444         (PlatformInfo): Use relative module path import
3445         (PlatformInfo.__init__):
3446         (PlatformInfo.executive): Lazy instantiation of Executive()
3447         (PlatformInfo.total_bytes_memory): Accessing via above property
3448         (PlatformInfo.xcode_sdk_version): Ditto
3449         (PlatformInfo.xcode_simctl_list): Ditto
3450         (PlatformInfo.xcode_version): Ditto
3451         (PlatformInfo._win_version_str): Ditto
3452         * Scripts/webkitpy/common/system/systemhost.py:
3453         (SystemHost.__init__):
3454         * Scripts/webkitpy/common/system/user.py:
3455         (User.__init__):
3456
3457 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3458
3459         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
3460         https://bugs.webkit.org/show_bug.cgi?id=176443
3461
3462         Reviewed by Darin Adler.
3463
3464         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
3465         (TEST):
3466
3467 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
3468
3469         check-webkit-style: Verify syntax for WK_API_AVAILABLE
3470         https://bugs.webkit.org/show_bug.cgi?id=181394
3471
3472         Reviewed by Darin Adler.
3473
3474         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
3475         as the second parameter instead of ios(WK_IOS_TBA). This generally
3476         builds for iOS on EWS but not when using the public SDK. See r224057,
3477         r223207 and r226211 for example. This patch adds a basic style check
3478         for that macro to prevent this kind of mistake.
3479
3480         * Scripts/webkitpy/style/checkers/cpp.py:
3481         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
3482         (check_style): Run new style check.
3483         (CppChecker): Add build type for the new style check.
3484         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3485         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
3486
3487 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3488
3489         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
3490         https://bugs.webkit.org/show_bug.cgi?id=181420
3491         <rdar://problem/36365827>
3492
3493         Reviewed by Alex Christensen.
3494
3495         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
3496         of corresponding _WKAttachments.
3497
3498         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3499         (TestWebKitAPI::TEST):
3500
3501 2018-01-08  Alex Christensen  <achristensen@webkit.org>
3502
3503         Add WKNavigationDelegate SPI exposing WebProcess crash reason
3504         https://bugs.webkit.org/show_bug.cgi?id=181410
3505         <rdar://problem/36167199>
3506
3507         Reviewed by Wenson Hsieh.
3508
3509         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3510         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
3511         (TEST):
3512
3513 2018-01-08  Alex Christensen  <achristensen@webkit.org>
3514
3515         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
3516         https://bugs.webkit.org/show_bug.cgi?id=181408
3517         <rdar://problem/35884960>
3518
3519         Reviewed by Tim Horton.
3520
3521         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
3522         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3523
3524 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3525
3526         [Attachment Support] Expose file name and content type of WKAttachment
3527         https://bugs.webkit.org/show_bug.cgi?id=181390
3528         <rdar://problem/36336837>
3529
3530         Reviewed by Tim Horton.
3531
3532         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
3533
3534         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3535         (-[_WKAttachment synchronouslyRequestInfo:]):
3536         (-[_WKAttachment synchronouslyRequestData:]):
3537
3538         Reimplement this in terms of -synchronouslyRequestInfo:.
3539
3540         (-[_WKAttachment expectRequestedDataToBe:]):
3541         (TestWebKitAPI::TEST):
3542
3543 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3544
3545         Copying, pasting, and then deleting an attachment element breaks attachment data requests
3546         https://bugs.webkit.org/show_bug.cgi?id=181365
3547         <rdar://problem/36340647>
3548
3549         Reviewed by Tim Horton.
3550
3551         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
3552         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
3553         detail.
3554
3555         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3556         (TestWebKitAPI::TEST):
3557
3558 2018-01-08  Youenn Fablet  <youenn@apple.com>
3559
3560         navigator.onLine does not work inside service workers
3561         https://bugs.webkit.org/show_bug.cgi?id=181079
3562         <rdar://problem/36178606>
3563
3564         Reviewed by Darin Adler.
3565
3566         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3567         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
3568
3569 2018-01-07  Saam Barati  <sbarati@apple.com>
3570
3571         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
3572         https://bugs.webkit.org/show_bug.cgi?id=181372
3573
3574         Reviewed by Filip Pizlo.
3575
3576         Adding these sorting modes makes it easier to analyze functions
3577         that recompile a lot and exit a lot.
3578
3579         * Scripts/display-profiler-output:
3580
3581 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
3582
3583         Unreviewed, remove my Cisco email from contributors.json
3584
3585         * Scripts/webkitpy/common/config/contributors.json:
3586
3587 2018-01-05  JF Bastien  <jfbastien@apple.com>
3588
3589         WebAssembly: poison JS object's secrets
3590         https://bugs.webkit.org/show_bug.cgi?id=181339
3591         <rdar://problem/36325001>
3592
3593         Reviewed by Mark Lam.
3594
3595         Update tests for swap(Poisoned<k, T>, T*)
3596
3597         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
3598         (TestWebKitAPI::TEST):
3599         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3600         (TestWebKitAPI::TEST):
3601         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
3602         (TestWebKitAPI::TEST):
3603
3604 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3605
3606         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
3607         https://bugs.webkit.org/show_bug.cgi?id=181359
3608
3609         Reviewed by Tim Horton.
3610
3611         Ensure that these tests still pass using older SDKs.
3612
3613         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3614         (TestWebKitAPI::TEST):
3615
3616 2018-01-05  Alex Christensen  <achristensen@webkit.org>
3617
3618         Rebase API test after r226469
3619         https://bugs.webkit.org/show_bug.cgi?id=181308
3620
3621         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
3622         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3623         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
3624
3625 2018-01-05  Alex Christensen  <achristensen@webkit.org>
3626
3627         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
3628         https://bugs.webkit.org/show_bug.cgi?id=181217
3629
3630         Reviewed by Tim Horton.
3631
3632         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3633         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3634         (TEST):
3635
3636 2018-01-05  Alex Christensen  <achristensen@webkit.org>
3637
3638         Add WKBundleFrameCreateFrameHandle
3639         https://bugs.webkit.org/show_bug.cgi?id=181232
3640         <rdar://problem/35926696>
3641
3642         Reviewed by Tim Horton.
3643
3644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3645         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
3646         (mouseDidMoveOverElement):
3647         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
3648         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3649         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
3650         (TEST):
3651
3652 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
3653
3654         iOS: Build fix after r226432.
3655         
3656         Unreviewed. Stop duplicating speakAs symbols for iOS.
3657
3658         * DumpRenderTree/AccessibilityUIElement.cpp:
3659         (AccessibilityUIElement::speakAs):
3660
3661 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
3662
3663         Unreviewed, added myself as WebKit reviewer
3664
3665         * Scripts/webkitpy/common/config/contributors.json:
3666
3667 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
3668
3669         WPE: Build fix after r226432.
3670
3671         Unreviewed. Rename ::speak() to ::speakAs().
3672         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3673         (WTR::AccessibilityUIElement::speakAs):
3674         (WTR::AccessibilityUIElement::speak): Deleted.
3675
3676 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
3677
3678         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
3679         https://bugs.webkit.org/show_bug.cgi?id=180361
3680
3681         Reviewed by Zalan Bujtas.
3682
3683         * DumpRenderTree/AccessibilityUIElement.cpp:
3684         (speakAsCallback):
3685         (AccessibilityUIElement::speakAs):
3686         (AccessibilityUIElement::getJSClass):
3687         (speakCallback): Deleted.
3688         (AccessibilityUIElement::speak): Deleted.
3689         * DumpRenderTree/AccessibilityUIElement.h:
3690         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3691         (AccessibilityUIElement::speakAs):
3692         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3693         (AccessibilityUIElement::speakAs):
3694         (AccessibilityUIElement::speak): Deleted.
3695         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3696         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3697         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3698         (WTR::AccessibilityUIElement::speakAs):
3699         (WTR::AccessibilityUIElement::speak): Deleted.
3700         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3701         (WTR::AccessibilityUIElement::speakAs):
3702         (WTR::AccessibilityUIElement::speak): Deleted.
3703
3704 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
3705
3706         REGRESSION (r226395): test-webkitperl test expectations incorrect
3707         https://bugs.webkit.org/show_bug.cgi?id=181307
3708         <rdar://problem/36306558>
3709
3710         Rubber-stamped by Aakash Jain.
3711
3712         r226395 added two lines towards the beginning of
3713         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
3714         numbers in the test expectations need to update.
3715
3716         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
3717
3718 2018-01-04  Tim Horton  <timothy_horton@apple.com>
3719
3720         WKWebView loses minimum layout size overrides that happen while the process is terminated
3721         https://bugs.webkit.org/show_bug.cgi?id=181306
3722         <rdar://problem/34398288>
3723
3724         Reviewed by Dan Bernstein.
3725
3726         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3727         (TEST):
3728         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
3729         while the process is terminated results in the page getting the correct
3730         minimum layout size.
3731
3732 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
3733
3734         [MediaStream] Add Mock screen capture source
3735         https://bugs.webkit.org/show_bug.cgi?id=181291
3736         <rdar://problem/36298164>
3737
3738         Reviewed by Dean Jackson.
3739
3740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
3741         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
3742         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
3743
3744 2018-01-04  Lucas Forschler  <lforschler@apple.com>
3745
3746         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
3747
3748         Reviewed by Ling Ho.
3749
3750         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3751
3752 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3753
3754         [Attachment Support] Create attachment elements when dropping files on iOS
3755         https://bugs.webkit.org/show_bug.cgi?id=181192
3756         <rdar://problem/36280945>
3757
3758         Reviewed by Tim Horton.
3759
3760         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
3761         switch is enabled. See below for more details.
3762
3763         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3764         (-[NSItemProvider registerData:type:]):
3765         (platformCopyPNG):
3766         (TestWebKitAPI::TEST):
3767         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3768
3769         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
3770         source item provider when dragging rich text *without* attachments, so this should have been a check for just
3771         kUTTypeRTF instead.
3772
3773         (TestWebKitAPI::TEST):
3774
3775         Tests a few cases of inserting attachment elements via drop:
3776         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
3777             Instead of inserting the contents as inline web content, this should generate attachment elements.
3778         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
3779             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
3780             back to inserting the content as an attachment.
3781         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
3782             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
3783             or at the end).
3784
3785         * TestWebKitAPI/cocoa/TestWKWebView.h:
3786         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3787         (-[TestWKWebView objectByEvaluatingJavaScript:]):
3788
3789         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
3790         -stringByEvaluatingJavaScript to just turn around and call this.
3791
3792         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3793
3794 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
3795
3796         Replace hard-coded paths in shebangs with #!/usr/bin/env
3797         https://bugs.webkit.org/show_bug.cgi?id=181040
3798
3799         Reviewed by Alex Christensen.
3800
3801         * BuildSlaveSupport/build-launcher-app:
3802         * BuildSlaveSupport/build-launcher-dmg:
3803         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3804         * BuildSlaveSupport/built-product-archive:
3805         * BuildSlaveSupport/clean-build:
3806         * BuildSlaveSupport/delete-stale-build-files:
3807         * BuildSlaveSupport/download-built-product:
3808         * BuildSlaveSupport/gtk/buildbot/log/run:
3809         * BuildSlaveSupport/gtk/buildbot/run:
3810         * BuildSlaveSupport/gtk/pulseaudio/run:
3811         * BuildSlaveSupport/kill-old-processes:
3812         * BuildSlaveSupport/test-result-archive:
3813         * BuildSlaveSupport/win/kill-old-processes:
3814         * Scripts/SpacingHeuristics.pm:
3815         * Scripts/add-include:
3816         * Scripts/build-api-tests:
3817         * Scripts/build-dumprendertree:
3818         * Scripts/build-imagediff:
3819         * Scripts/build-jsc:
3820         * Scripts/build-webkit:
3821         * Scripts/build-webkittestrunner:
3822         * Scripts/check-Xcode-source-file-types:
3823         * Scripts/check-dom-results:
3824         * Scripts/check-for-exit-time-destructors:
3825         * Scripts/check-for-global-initializers:
3826         * Scripts/check-for-inappropriate-objc-class-names:
3827         * Scripts/check-for-weak-vtables-and-externals:
3828         * Scripts/clean-header-guards:
3829         * Scripts/compare-timing-files:
3830         * Scripts/configure-xcode-for-ios-development:
3831         * Scripts/copy-webkitlibraries-to-product-directory:
3832         * Scripts/create-exports:
3833         * Scripts/debug-minibrowser:
3834         * Scripts/debug-safari:
3835         * Scripts/debug-test-runner:
3836         * Scripts/do-file-rename:
3837         * Scripts/do-webcore-rename:
3838         * Scripts/dump-webkit-tests-run:
3839         * Scripts/ensure-valid-python:
3840         * Scripts/execAppWithEnv:
3841         * Scripts/extract-localizable-js-strings:
3842         * Scripts/filter-build-webkit:
3843         * Scripts/find-extra-includes:
3844         * Scripts/fix-blink-patch:
3845         * Scripts/generate-coverage-data:
3846         * Scripts/git-add-reviewer:
3847         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3848         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
3849         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
3850         * Scripts/make-new-script-test:
3851         * Scripts/make-script-test-wrappers:
3852         * Scripts/package-root:
3853         * Scripts/parse-malloc-history:
3854         * Scripts/report-include-statistics:
3855         * Scripts/resolve-ChangeLogs:
3856         * Scripts/run-api-tests:
3857         * Scripts/run-bindings-tests:
3858         * Scripts/run-content-extension-tester:
3859         * Scripts/run-iexploder-tests:
3860         * Scripts/run-javascriptcore-tests:
3861         * Scripts/run-jsc:
3862         * Scripts/run-leaks:
3863         * Scripts/run-mangleme-tests:
3864         * Scripts/run-minibrowser:
3865         * Scripts/run-pageloadtest:
3866         * Scripts/run-regexp-tests:
3867         * Scripts/run-safari:
3868         * Scripts/run-sunspider:
3869         * Scripts/run-test-runner:
3870         * Scripts/run-webkit-app:
3871         * Scripts/run-webkit-httpd:
3872         * Scripts/run-webkit-websocketserver:
3873         * Scripts/set-webkit-configuration:
3874         * Scripts/show-pretty-diff:
3875         * Scripts/sort-Xcode-project-file:
3876         * Scripts/split-file-by-class:
3877         * Scripts/sunspider-compare-results:
3878         * Scripts/svn-apply:
3879         * Scripts/svn-unapply:
3880         * Scripts/test-webkit-scripts:
3881         * Scripts/test-webkitperl:
3882         * Scripts/update-iexploder-cssproperties:
3883         * Scripts/update-javascriptcore-test-results:
3884         * Scripts/update-webkit:
3885         * Scripts/update-webkit-auxiliary-libs:
3886         * Scripts/update-webkit-dependency:
3887         * Scripts/update-webkit-libs-jhbuild:
3888         * Scripts/update-webkit-localizable-strings:
3889         * Scripts/update-webkit-support-libs:
3890         * Scripts/update-webkitgtk-libs:
3891         * Scripts/update-webkitwpe-libs:
3892         * Scripts/webkit-build-directory:
3893         * Scripts/webkitperl/LoadAsModule.pm:
3894         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
3895         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3896         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
3897         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
3898         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
3899         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
3900         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3901         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3902         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3903         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3904         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
3905         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
3906         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
3907         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3908         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3909         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3910         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3911         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
3912         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
3913         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
3914         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
3915         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
3916         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
3917         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
3918         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
3919         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3920         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
3921         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
3922         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
3923         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3924         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
3925         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
3926         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
3927         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
3928         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
3929         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3930         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3931         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
3932         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
3933         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
3934         * ccache/ccache-clang:
3935         * ccache/ccache-clang++:
3936         * ccache/ccache-wrapper:
3937         * gtk/install-dependencies:
3938         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
3939         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
3940         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
3941         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
3942         * iExploder/iexploder-1.3.2/tools/showtest.rb:
3943         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
3944         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
3945         * iExploder/iexploder-1.7.2/src/webserver.rb:
3946         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
3947         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
3948         * wpe/install-dependencies:
3949
3950 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
3951
3952         filter-build-webkit filters out useful compiler error lines
3953         https://bugs.webkit.org/show_bug.cgi?id=179864
3954
3955         Reviewed by Tim Horton.
3956
3957         Don't filter out lines that contain information about build errors by always showing lines
3958         after a line that contains "note:" or "error:".
3959
3960         * Scripts/filter-build-webkit:
3961         (shouldShowSubsequentLine):
3962         (shouldIgnoreLine):
3963
3964 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3965
3966         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
3967         https://bugs.webkit.org/show_bug.cgi?id=173915
3968
3969         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
3970         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
3971         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
3972         empty string in this case.
3973
3974         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3975         (emitFormSubmissionEvent):
3976
3977 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3978
3979         [GTK] Add web process API to detect when form is submitted via JavaScript
3980         https://bugs.webkit.org/show_bug.cgi?id=173915
3981
3982         Reviewed by Carlos Garcia Campos.
3983
3984         Test it.
3985
3986         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3987         (FormSubmissionTest::FormSubmissionTest):
3988         (FormSubmissionTest::~FormSubmissionTest):
3989         (FormSubmissionTest::testFormSubmissionResult):
3990         (FormSubmissionTest::willSendDOMEventCallback):
3991         (FormSubmissionTest::willCompleteCallback):
3992         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
3993         (testWebExtensionFormSubmissionSteps):
3994         (beforeAll):
3995         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3996         (DelayedSignal::DelayedSignal):
3997         (emitFormSubmissionEvent):
3998         (handleFormSubmissionCallback):
3999         (willSubmitFormCallback):
4000         (pageCreatedCallback):
4001
4002 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4003
4004         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
4005         https://bugs.webkit.org/show_bug.cgi?id=181251
4006
4007         * Scripts/run-gtk-tests:
4008         (GtkTestRunner):
4009
4010 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4011
4012         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
4013         https://bugs.webkit.org/show_bug.cgi?id=181136
4014
4015         * Scripts/run-gtk-tests:
4016         (GtkTestRunner):
4017
4018 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
4019
4020         [macOS, iOS] Adopt new secure coding APIs in WebKit
4021         https://bugs.webkit.org/show_bug.cgi?id=181085
4022         <rdar://problem/34837397>
4023
4024         Reviewed by Tim Horton.
4025
4026         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
4027         capable of supporting NSSecureCoding, so pass through the current coding routines.
4028
4029         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
4030         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
4031         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
4032         routines if necessary.
4033         (TEST): Updated for NSSecureCoding.
4034         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
4035         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
4036
4037 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
4038
4039         Remove std::chrono completely
4040         https://bugs.webkit.org/show_bug.cgi?id=181186
4041
4042         Reviewed by Alex Christensen.
4043
4044         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4045         (WTR::TestController::platformRunUntil):
4046
4047 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
4048
4049         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
4050         https://bugs.webkit.org/show_bug.cgi?id=181231
4051
4052         Reviewed by Alex Christensen.
4053
4054         Implement TestController APIs needed by ResourceLoadStatistics tests.
4055
4056         * WebKitTestRunner/TestController.cpp:
4057         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
4058         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
4059
4060 2018-01-02  Tim Horton  <timothy_horton@apple.com>
4061
4062         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
4063         https://bugs.webkit.org/show_bug.cgi?id=181219
4064
4065         Reviewed by Wenson Hsieh.
4066
4067         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4068
4069 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
4070
4071         Add a WebAuthentication runtime feature flag
4072         https://bugs.webkit.org/show_bug.cgi?id=181220
4073         <rdar://problem/36055305>
4074
4075         Reviewed by Brent Fulgham.
4076
4077         Renames the CredentialManagement runtime feature flag into WebAuthentication.
4078
4079         * DumpRenderTree/TestOptions.h:
4080         * DumpRenderTree/TestOptions.mm:
4081         (TestOptions::TestOptions):
4082         * DumpRenderTree/mac/DumpRenderTree.mm:
4083         (enableExperimentalFeatures):
4084         (setWebPreferencesForTestOptions):
4085         * WebKitTestRunner/TestController.cpp:
4086         (WTR::TestController::resetPreferencesToConsistentValues):
4087         (WTR::updateTestOptionsFromTestHeader):
4088         * WebKitTestRunner/TestOptions.h:
4089         (WTR::TestOptions::hasSameInitializationOptions const):
4090
4091 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
4092
4093         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
4094         https://bugs.webkit.org/show_bug.cgi?id=181143
4095         <rdar://problem/36200381>
4096
4097         Reviewed by Tim Horton.
4098
4099         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
4100         attachment elements are enabled.
4101
4102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4103         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4104         (TestWebKitAPI::TEST):
4105
4106 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
4107
4108         Update Credential Management API for WebAuthentication
4109         https://bugs.webkit.org/show_bug.cgi?id=181082
4110         <rdar://problem/36055239>
4111
4112         Reviewed by Brent Fulgham.
4113
4114         Enable Credential Management API for testing.
4115
4116         * DumpRenderTree/TestOptions.h:
4117         * WebKitTestRunner/TestOptions.h:
4118
4119 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
4120
4121         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
4122         https://bugs.webkit.org/show_bug.cgi?id=168194
4123
4124         Reviewed by Carlos Garcia Campos.
4125
4126         Fix an assertion and unskip the test. The order that form controls are associated is not
4127         guaranteed.
4128
4129         * Scripts/run-gtk-tests:
4130         (GtkTestRunner):
4131         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4132         (didAssociateFormControlsCallback):
4133
4134 2018-01-02  Alex Christensen  <achristensen@webkit.org>
4135
4136         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
4137         https://bugs.webkit.org/show_bug.cgi?id=180897
4138         <rdar://problem/35535328>
4139
4140         Reviewed by Brent Fulgham.
4141
4142         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
4143
4144         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4145         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
4146         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
4147         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4148         (websiteDataStoreTestWebView):
4149         (TEST):
4150
4151 == Rolled over to ChangeLog-2018-01-01 ==