[WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
4         https://bugs.webkit.org/show_bug.cgi?id=174150
5
6         Reviewed by Mark Lam.
7
8         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
9         (TestWebKitAPI::TEST):
10
11 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
12
13         Remove copy of ICU headers from WebKit
14         https://bugs.webkit.org/show_bug.cgi?id=116407
15
16         Reviewed by Alex Christensen.
17
18         * DumpRenderTree/mac/Configurations/Base.xcconfig:
19         * TestWebKitAPI/Configurations/Base.xcconfig:
20         * WebKitTestRunner/Configurations/Base.xcconfig:
21
22 2017-07-05  Chris Dumez  <cdumez@apple.com>
23
24         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
25         https://bugs.webkit.org/show_bug.cgi?id=174163
26         <rdar://problem/33067518>
27
28         Reviewed by Alex Christensen.
29
30         Add API test coverage.
31
32         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
33         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
34         (TEST):
35
36 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
37
38         When dragging a selection, clearing the selection in dragstart should not crash the web process
39         https://bugs.webkit.org/show_bug.cgi?id=174142
40         <rdar://problem/33067501>
41
42         Reviewed by Tim Horton.
43
44         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
45         drag is starting up.
46
47         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
48         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
49         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
50         (TestWebKitAPI::TEST):
51
52 2017-07-05  Daniel Bates  <dabates@apple.com>
53
54         Do not pass API::FrameInfo for source frame or clear out page of target frame on
55         API navigation
56         https://bugs.webkit.org/show_bug.cgi?id=174170
57         <rdar://problem/33140328>
58
59         Reviewed by Brady Eidson.
60
61         Update tests as needed for the behavior change.
62
63         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
64         (TEST):
65
66 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
67
68         Add WebKitPrivateFrameworkStubs for iOS 11
69         https://bugs.webkit.org/show_bug.cgi?id=173988
70
71         Reviewed by David Kilzer.
72
73         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
74         should use the same directory for private framework stubs.
75         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
76
77 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
78
79         [MediaStream] Protect request and web view during gUM client callback
80         https://bugs.webkit.org/show_bug.cgi?id=174096
81         <rdar://problem/32833102>
82
83         Reviewed by Youenn Fablet.
84
85         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
86         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
87
88 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
89
90         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
91
92         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
93
94 2017-07-05  Matt Lewis  <jlewis3@apple.com>
95
96         Unreviewed, rolling out r219128.
97
98         Spoke with engineer who originally submitted, Patch for APi
99         test to follow.
100
101         Reverted changeset:
102
103         "Unreviewed, rolling out r219070."
104         https://bugs.webkit.org/show_bug.cgi?id=174082
105         http://trac.webkit.org/changeset/219128
106
107 2017-07-05  Matt Lewis  <jlewis3@apple.com>
108
109         Unreviewed, rolling out r219070.
110
111         This revision caused consistent failures of the API test
112         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
113
114         Reverted changeset:
115
116         "Pasting single words copied to UIPasteboard inserts URLs in
117         editable areas"
118         https://bugs.webkit.org/show_bug.cgi?id=174082
119         http://trac.webkit.org/changeset/219070
120
121 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
122
123         Remove unused EFL logo from bot watcher dashboard
124         https://bugs.webkit.org/show_bug.cgi?id=174136
125
126         Reviewed by Alexey Proskuryakov.
127
128         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
130
131 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
132
133         [GTK] Add more GTK bots to dashboard
134         https://bugs.webkit.org/show_bug.cgi?id=174129
135
136         Reviewed by Carlos Alberto Lopez Perez.
137
138         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
139         them.
140
141         This also changes the sort order to put WPE above GTK so that it's not buried under all the
142         less-essential GTK bots.
143
144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
145         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
146         (WebKitBuildbot):
147
148 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
149
150         [WPE] Add WPE to bot watcher dashboard
151         https://bugs.webkit.org/show_bug.cgi?id=174119
152
153         Reviewed by Alexey Proskuryakov.
154
155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
159         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
160         (WebKitBuildbot):
161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
162         (table.queue-grid tr.platform.linux-wpe img.logo):
163
164 2017-07-03  Lucas Forschler  <lforschler@apple.com>
165
166         https://bugs.webkit.org/show_bug.cgi?id=174105
167         
168         Reviewed by Stephanie Lewis.
169
170         * BuildSlaveSupport/built-product-archive:
171         (main): Add a -minify parser option
172         (createZip): Pass along the optional Minify argument if requested
173         (minifySource): This will trim down archives, logic limited to Mac platform.
174
175 2017-07-03  Matt Rajca  <mrajca@apple.com>
176
177         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
178         https://bugs.webkit.org/show_bug.cgi?id=174103
179
180         Reviewed by Alex Christensen.
181
182         Added an API test.
183
184         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
185         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
186         (TEST): Added test.
187         * TestWebKitAPI/cocoa/TestWKWebView.h:
188         * TestWebKitAPI/cocoa/TestWKWebView.mm:
189         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
190
191 2017-07-03  Matt Lewis  <jlewis3@apple.com>
192
193         Unreviewed, rolling out r219103.
194
195         Caused multiple build failures.
196
197         Reverted changeset:
198
199         "Remove copy of ICU headers from WebKit"
200         https://bugs.webkit.org/show_bug.cgi?id=116407
201         http://trac.webkit.org/changeset/219103
202
203 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
204
205         Remove copy of ICU headers from WebKit
206         https://bugs.webkit.org/show_bug.cgi?id=116407
207
208         Reviewed by Alex Christensen.
209
210         Use WTF's copy of ICU headers.
211
212         * DumpRenderTree/mac/Configurations/Base.xcconfig:
213         * TestWebKitAPI/Configurations/Base.xcconfig:
214         * WebKitTestRunner/Configurations/Base.xcconfig:
215
216 2017-07-03  Brady Eidson  <beidson@apple.com>
217
218         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
219         https://bugs.webkit.org/show_bug.cgi?id=174073
220
221         Reviewed by Andy Estes.
222
223         * DumpRenderTree/mac/TestRunnerMac.mm:
224         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
225
226         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
227         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
228
229 2017-07-03  Matt Lewis  <jlewis3@apple.com>
230
231         Unreviewed, rolling out r219083.
232
233         The revision caused an API failure on all testing platforms.
234
235         Reverted changeset:
236
237         "[MediaStream] Protect request and web view during gUM client
238         callback"
239         https://bugs.webkit.org/show_bug.cgi?id=174096
240         http://trac.webkit.org/changeset/219083
241
242 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
243
244         webkitpy: Properly number duplicated crashlogs
245         https://bugs.webkit.org/show_bug.cgi?id=172002
246
247         Reviewed by Aakash Jain.
248
249         * Scripts/webkitpy/common/system/crashlogs.py:
250         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
251         an increasing integer.
252         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
253         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
254         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
255         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
256
257 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
258
259         WebContent processes crash when the network process crashes with pending connection requests
260         https://bugs.webkit.org/show_bug.cgi?id=174065
261         <rdar://problem/30359835>
262
263         Reviewed by Tim Horton.
264
265         Add a API to ensure UI process tries to relaunch a new network process when the network process
266         crashes with pending network connection requests.
267
268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
269         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
270         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
271         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
272         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
273
274 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
275
276         [MediaStream] Protect request and web view during gUM client callback
277         https://bugs.webkit.org/show_bug.cgi?id=174096
278         <rdar://problem/32833102>
279
280         Reviewed by Youenn Fablet.
281
282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
283         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
284
285 2017-07-03  Andy Estes  <aestes@apple.com>
286
287         [Xcode] Add an experimental setting to build with ccache
288         https://bugs.webkit.org/show_bug.cgi?id=173875
289
290         Reviewed by Tim Horton.
291
292         On systems that already have ccache(1) installed, this patch adds experimental support for
293         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
294
295         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
296         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
297         find the toolchain from which to run clang, and then invokes ccache with the required
298         arguments.
299
300         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
301         precompiled headers to work properly [1].
302
303         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
304         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
305         during linking.
306         
307         [1] https://ccache.samba.org/manual.html#_precompiled_headers
308
309         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
310         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
311         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
312         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
313         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
314         * ccache/README.md: Added.
315         * ccache/ccache-clang: Added.
316         * ccache/ccache-clang++: Added.
317         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
318
319 2017-07-03  Alex Christensen  <achristensen@webkit.org>
320
321         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
322         https://bugs.webkit.org/show_bug.cgi?id=174051
323
324         Reviewed by Tim Horton.
325
326         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
327         (TestWebKitAPI::TEST_F):
328
329 2017-07-03  Matt Lewis  <jlewis3@apple.com>
330
331         Unreviewed, rolling out r219024.
332
333         This patch cause 3 didferent test to fail.
334
335         Reverted changeset:
336
337         "REGRESSION(r215096) Queries of URLs with non-special schemes
338         should not percent-encode single quotes"
339         https://bugs.webkit.org/show_bug.cgi?id=174051
340         http://trac.webkit.org/changeset/219024
341
342 2017-07-03  Chris Dumez  <cdumez@apple.com>
343
344         Drop ResourceLoadStatisticsStore's statisticsLock
345         https://bugs.webkit.org/show_bug.cgi?id=174080
346
347         Reviewed by Brent Fulgham.
348
349         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
350
351         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
352         (WTR::TestController::isStatisticsPrevalentResource):
353         (WTR::TestController::isStatisticsHasHadUserInteraction):
354         (WTR::TestController::isStatisticsGrandfathered):
355
356 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
357
358         Pasting single words copied to UIPasteboard inserts URLs in editable areas
359         https://bugs.webkit.org/show_bug.cgi?id=174082
360         <rdar://problem/33046992>
361
362         Reviewed by Tim Horton.
363
364         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
365
366         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
367         (TestWebKitAPI::setUpWebViewForPasteboardTests):
368         (TestWebKitAPI::TEST):
369
370 2017-07-02  Brady Eidson  <beidson@apple.com>
371
372         Add API test for all parts of WebKit1 API related to favicons.
373         https://bugs.webkit.org/show_bug.cgi?id=174069
374
375         Reviewed by Andy Estes.
376
377         These two API tests cover all WebKit1 API related to icons.
378         
379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
380         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
381         (mainResourceData):
382         (defaultFaviconData):
383         (customFaviconData):
384         (imageFromData):
385         (+[IconLoadingProtocol canInitWithRequest:]):
386         (+[IconLoadingProtocol canonicalRequestForRequest:]):
387         (-[IconLoadingProtocol startLoading]):
388         (-[IconLoadingProtocol stopLoading]):
389         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
390         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
391         (TestWebKitAPI::TEST):
392
393 2017-07-01  Dan Bernstein  <mitz@apple.com>
394
395         [iOS] Remove code only needed when building for iOS 9.x
396         https://bugs.webkit.org/show_bug.cgi?id=174068
397
398         Reviewed by Tim Horton.
399
400         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
401         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
402         (WTR::initializeWebViewConfiguration):
403         * WebKitTestRunner/ios/HIDEventGenerator.mm:
404         (-[HIDEventGenerator _createIOHIDEventType:]):
405
406 2017-07-01  Brady Eidson  <beidson@apple.com>
407
408         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
409         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
410
411         Reviewed by Alex Christensen.
412
413         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
414
415 2017-07-01  Dan Bernstein  <mitz@apple.com>
416
417         [macOS] Remove code only needed when building for OS X Yosemite
418         https://bugs.webkit.org/show_bug.cgi?id=174067
419
420         Reviewed by Tim Horton.
421
422         * DumpRenderTree/mac/Configurations/Base.xcconfig:
423         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
424         * DumpRenderTree/mac/DumpRenderTree.mm:
425         (setDefaultsToConsistentValuesForTesting):
426         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
427         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
428         * MiniBrowser/Configurations/Base.xcconfig:
429         * MiniBrowser/Configurations/DebugRelease.xcconfig:
430         * TestWebKitAPI/Configurations/Base.xcconfig:
431         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
432         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
433         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
434         (TestWebKitAPI::TEST_F):
435         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
436         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
437         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
438         (TestWebKitAPI::TEST_F):
439         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
440         (TestWebKitAPI::TEST):
441         * WebKitTestRunner/Configurations/Base.xcconfig:
442         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
443         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
444         (WTR::InjectedBundle::platformInitialize):
445         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
446         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
447
448 2017-07-01  Chris Dumez  <cdumez@apple.com>
449
450         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
451         https://bugs.webkit.org/show_bug.cgi?id=174060
452
453         Reviewed by Brent Fulgham.
454
455         Port WebKitTestRunner over to the new Cocoa SPI.
456
457         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
458         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
459         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
460         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
461         no-ops since this code runs in the WebContent process, not the
462         UIProcess.
463
464         * WebKitTestRunner/TestController.cpp:
465         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
466
467 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
468
469         Unreviewed mac build fix.
470
471         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
472         (TestWebKitAPI::TEST):
473
474 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
475
476         Add API to get WKActivatedElementInfo
477         https://bugs.webkit.org/show_bug.cgi?id=174001
478         <rdar://problem/29165518>
479         
480         Tests for now SPI to get activatedElementInfo.
481
482         Reviewed by Tim Horton.
483
484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
485         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
486         (TestWebKitAPI::TEST):
487
488 2017-06-30  Chris Dumez  <cdumez@apple.com>
489
490         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
491         https://bugs.webkit.org/show_bug.cgi?id=174038
492
493         Reviewed by Brent Fulgham.
494
495         Fix typo in API name.
496
497         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
498         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
499         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
500         * WebKitTestRunner/InjectedBundle/TestRunner.h:
501         * WebKitTestRunner/TestController.cpp:
502         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
503         * WebKitTestRunner/TestController.h:
504         * WebKitTestRunner/TestInvocation.cpp:
505         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
506
507 2017-06-30  Alex Christensen  <achristensen@webkit.org>
508
509         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
510         https://bugs.webkit.org/show_bug.cgi?id=174051
511         <rdar://problem/33002846>
512
513         Reviewed by Tim Horton.
514
515         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
516         (TestWebKitAPI::TEST_F):
517
518 2017-06-30  Daniel Bates  <dabates@apple.com>
519
520         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
521         https://bugs.webkit.org/show_bug.cgi?id=165160
522         <rdar://problem/29451999>
523
524         Reviewed by Brady Eidson.
525
526         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
527         for navigations and window creation.
528
529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
530         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
531         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
532         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
533         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
534         (TEST):
535
536 2017-06-29  Jer Noble  <jer.noble@apple.com>
537
538         Make Legacy EME API controlled by RuntimeEnabled setting.
539         https://bugs.webkit.org/show_bug.cgi?id=173994
540
541         Reviewed by Sam Weinig.
542
543         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
544
545 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
546
547         Follow-up fix for r218996
548
549         Unreviewed infrastructure fix.
550
551         Repeated calls to 'ios_version' make the log noisy, memoize the function.
552
553         * Scripts/webkitpy/port/ios_simulator.py:
554         (IOSSimulatorPort): Memoize ios_version().
555
556 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
557
558         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
559         https://bugs.webkit.org/show_bug.cgi?id=174017
560         <rdar://problem/32959782>
561
562         Reviewed by Simon Fraser.
563
564         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
565         changes, the caret would appear outside of the iframe.
566
567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
568         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
569         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
570         (checkDragCaretRectIsContainedInRect):
571         (TestWebKitAPI::TEST):
572         * TestWebKitAPI/ios/DataInteractionSimulator.h:
573         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
574         (-[DataInteractionSimulator _resetSimulatedState]):
575         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
576         (-[DataInteractionSimulator _advanceProgress]):
577         (-[DataInteractionSimulator lastKnownDragCaretRect]):
578
579 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
580
581         Add support for different versions of iOS when loading test expectations
582         https://bugs.webkit.org/show_bug.cgi?id=173774
583         <rdar://problem/32951132>
584
585         Rubber-stamped by Aakash Jain.
586
587         When running layout tests, we should support multiple version of iOS the same way we do Mac.
588
589         * Scripts/webkitpy/port/ios.py:
590         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
591         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
592         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
593         * Scripts/webkitpy/port/ios_device.py:
594         (IOSDevicePort.ios_version): Ask connected devices for implementation.
595         * Scripts/webkitpy/port/ios_device_unittest.py:
596         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
597         (IOSDeviceTest.test_baseline_searchpath): Ditto.
598         (IOSDeviceTest.test_expectations_ordering): Ditto.
599         * Scripts/webkitpy/port/ios_simulator.py:
600         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
601         ask the platform.
602
603 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
604
605         Fontconfig build breaks with glibc 2.15+
606         https://bugs.webkit.org/show_bug.cgi?id=174019
607
608         Reviewed by Carlos Alberto Lopez Perez.
609
610         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
611
612         * wpe/jhbuild.modules:
613         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
614
615 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
616
617         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
618         https://bugs.webkit.org/show_bug.cgi?id=174010
619         <rdar://problem/32597802>
620
621         Reviewed by Tim Horton.
622
623         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
624         snapshot fails for any reason.
625
626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
627         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
628         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
629         (TestWebKitAPI::TEST):
630
631 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
632
633         AX: Cannot call setValue() on contenteditable or ARIA text controls
634         https://bugs.webkit.org/show_bug.cgi?id=173520
635
636         Reviewed by Ryosuke Niwa.
637
638         Add setValue() method to WKTR (already existed in DRT).
639
640         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
641         (WTR::AccessibilityUIElement::setValue):
642         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
643         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
644         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
645         (WTR::AccessibilityUIElement::setValue):
646
647 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
648
649         getBoundingClientRect returns wrong value for combination of page zoom and scroll
650         https://bugs.webkit.org/show_bug.cgi?id=173841
651         rdar://problem/32983841
652
653         Reviewed by Dean Jackson.
654
655         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
656         always did text zooming.
657
658         * MiniBrowser/mac/WK1BrowserWindowController.m:
659         (-[WK1BrowserWindowController zoomIn:]):
660         (-[WK1BrowserWindowController zoomOut:]):
661         (-[WK1BrowserWindowController canResetZoom]):
662         (-[WK1BrowserWindowController resetZoom:]):
663
664 2017-06-29  John Wilander  <wilander@apple.com>
665
666         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
667         https://bugs.webkit.org/show_bug.cgi?id=173940
668         <rdar://problem/33018125>
669
670         Reviewed by Brent Fulgham.
671
672         This change allows the TestController to turn off
673         regular resource load statistics telemetry submission
674         and to manually control when telemetry is calculated
675         and submitted.
676
677         * WebKitTestRunner/TestController.cpp:
678         (WTR::TestController::initialize):
679             Turns off automatic resource load statistics telemetry submission.
680
681 2017-06-29  Commit Queue  <commit-queue@webkit.org>
682
683         Unreviewed, rolling out r218512.
684         https://bugs.webkit.org/show_bug.cgi?id=173981
685
686         "It changes the behavior of the JS API's JSEvaluateScript
687         which breaks TurboTax" (Requested by saamyjoon on #webkit).
688
689         Reverted changeset:
690
691         "test262: Completion values for control flow do not match the
692         spec"
693         https://bugs.webkit.org/show_bug.cgi?id=171265
694         http://trac.webkit.org/changeset/218512
695
696 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
697
698         Add WebKitSystemInterface for iOS 11
699         https://bugs.webkit.org/show_bug.cgi?id=173936
700
701         Reviewed by Lucas Forschler.
702
703         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
704
705 2017-06-28  Keith Miller  <keith_miller@apple.com>
706
707         VMTraps has some races
708         https://bugs.webkit.org/show_bug.cgi?id=173941
709
710         Reviewed by Michael Saboff.
711
712         Add new testing mode for testing the Watchdog with our stress
713         tests.
714
715         * Scripts/run-jsc-stress-tests:
716
717 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
718
719         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
720         https://bugs.webkit.org/show_bug.cgi?id=173877
721
722         Reviewed by Brady Eidson.
723
724         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
725         the next tests.
726
727         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
728         (testGetFavicon):
729
730 2017-06-28  Tim Horton  <timothy_horton@apple.com>
731
732         MobileSafari was constantly using 10-15% CPU viewing a PDF
733         https://bugs.webkit.org/show_bug.cgi?id=173944
734         <rdar://problem/33039910>
735
736         Reviewed by Simon Fraser.
737
738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
739         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
740         Add a test that we ever call the stable presentation update callback
741         when we have a WKPDFView up, instead of infinitely looping.
742
743 2017-06-28  Alex Christensen  <achristensen@webkit.org>
744
745         Prevent displaying URLs with small capital letters
746         https://bugs.webkit.org/show_bug.cgi?id=173949
747         <rdar://problem/32952058>
748
749         Reviewed by Brent Fulgham.
750
751         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
752         (TestWebKitAPI::TEST):
753
754 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
755
756         Unreviewed test fix.
757
758         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
759
760         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
761
762 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
763
764         Teach ResourceLoadStatistics to recognize changes in the file system
765         https://bugs.webkit.org/show_bug.cgi?id=173800
766         <rdar://problem/32937842>
767
768         Reviewed by Chris Dumez.
769
770         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
771         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
772         (TestWebKitAPI::FileMonitorTest::tempFilePath):
773         (TestWebKitAPI::handleFileModification):
774         (TestWebKitAPI::handleFileDeletion):
775         (TestWebKitAPI::resetTestState):
776         (TestWebKitAPI::TEST_F):
777
778 2017-06-28  Brady Eidson  <beidson@apple.com>
779
780         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
781         https://bugs.webkit.org/show_bug.cgi?id=173874
782
783         Reviewed by Alex Christensen.
784
785         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
786
787 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
788
789         Unreviewed, adding Don Olmstead to contributors.json
790
791         * Scripts/webkitpy/common/config/contributors.json:
792
793 2017-06-28  Alex Christensen  <achristensen@webkit.org>
794
795         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
796         https://bugs.webkit.org/show_bug.cgi?id=173886
797         <rdar://problem/32543191>
798
799         Reviewed by Andy Estes.
800
801         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
802         (ParsedRange::ParsedRange):
803         (-[TestSchemeHandler initWithVideoData:]):
804         (-[TestSchemeHandler webView:startURLSchemeTask:]):
805         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
806         (TEST):
807
808 2017-06-27  JF Bastien  <jfbastien@apple.com>
809
810         WebAssembly: running out of executable memory should throw OoM
811         https://bugs.webkit.org/show_bug.cgi?id=171537
812         <rdar://problem/32963338>
813
814         Reviewed by Saam Barati.
815
816         * Scripts/run-jsc-stress-tests: add a configuration which runs the
817         tests under limited executable memory and avoids non-WebAssembly
818         code generation so that we more reliably run out of executable
819         memory in WebAssembly.
820
821 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
822
823         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
824         https://bugs.webkit.org/show_bug.cgi?id=173854
825         <rdar://problem/32236827>
826
827         Reviewed by Ryosuke Niwa and Tim Horton.
828
829         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
830
831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
832         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
833         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
834         (TestWebKitAPI::TEST):
835
836 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
837
838         [PAL] Add symbol export macros for PAL
839         https://bugs.webkit.org/show_bug.cgi?id=171519
840
841         Reviewed by Konstantin Tokarev.
842
843         * DumpRenderTree/config.h:
844         * TestWebKitAPI/CMakeLists.txt:
845         * TestWebKitAPI/config.h:
846         * WebKitTestRunner/config.h:
847
848 2017-06-27  John Wilander  <wilander@apple.com>
849
850         Resource Load Statistics: Add telemetry
851         https://bugs.webkit.org/show_bug.cgi?id=173499
852         <rdar://problem/32826094>
853
854         Reviewed by Brent Fulgham.
855
856         Adds three new testRunner functions:
857         - installStatisticsDidRunTelemetryCallback()
858         - statisticsFireTelemetryHandler()
859         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
860
861         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
862         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
863         (WTR::InjectedBundle::didReceiveMessageToPage):
864         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
865         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
866         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
867         (WTR::TestRunner::statisticsFireTelemetryHandler):
868         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
869         * WebKitTestRunner/InjectedBundle/TestRunner.h:
870         * WebKitTestRunner/TestController.cpp:
871         (WTR::TestController::resetStateToConsistentValues):
872         (WTR::TestController::statisticsFireTelemetryHandler):
873         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
874         * WebKitTestRunner/TestController.h:
875         * WebKitTestRunner/TestInvocation.cpp:
876         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
877
878 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
879
880         Add missing includes to fix compilation error on FreeBSD
881         https://bugs.webkit.org/show_bug.cgi?id=172919
882
883         Reviewed by Mark Lam.
884
885         * ImageDiff/cairo/PlatformImageCairo.cpp:
886
887 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
888
889         Unreviewed, rolling out r218783.
890
891         Causing accessibility/mac/setting-attributes-is-
892         asynchronous.html to crash consistently on mac-wk2 Debug
893
894         Reverted changeset:
895
896         "AX: Cannot call setValue() on contenteditable or ARIA text
897         controls"
898         https://bugs.webkit.org/show_bug.cgi?id=173520
899         http://trac.webkit.org/changeset/218783
900
901 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
902
903         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
904         https://bugs.webkit.org/show_bug.cgi?id=173825
905
906         Reviewed by Saam Barati.
907
908         * DumpRenderTree/JavaScriptThreading.cpp:
909         (runJavaScriptThread):
910         (startJavaScriptThreads):
911         * DumpRenderTree/mac/DumpRenderTree.mm:
912         (runThread):
913         (runPthread):
914         (testThreadIdentifierMap):
915
916 2017-06-26  David Kilzer  <ddkilzer@apple.com>
917
918         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
919         <https://webkit.org/b/173837>
920
921         Reviewed by Geoffrey Garen.
922
923         The clang static analyzer can't reason about objects that are
924         assigned to a delegate as +1 retained, and then released
925         later in a different method when the delegate is cleared.
926
927         Instead, use a common idiom where the object setting the
928         delegate retains it as an instance variable on initialization.
929         Then the same object clears the delegate and releases its
930         instance variable during teardown.
931
932         Also add EXPECT_TRUE() tests to make sure the delegate objects
933         match before teardown.
934
935         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
936         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
937         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
938         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
939         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
940         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
941
942 2017-06-26  David Kilzer  <ddkilzer@apple.com>
943
944         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
945         <https://webkit.org/b/173836>
946
947         Reviewed by Brady Eidson.
948
949         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
950         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
951         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
952         objects in this test.
953
954 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
955
956         [ATK] Add support for aria-details and aria-errormessage
957         https://bugs.webkit.org/show_bug.cgi?id=172588
958
959         Reviewed by Chris Fleizach.
960
961         Add additional methods to test ARIA properties which are exposed via
962         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
963         to versions which support the details and error-message relation types.
964
965         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
966         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
967         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
968         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
969         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
970         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
971         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
972         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
973         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
974         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
975         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
976         * gtk/jhbuild.modules:
977
978 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
979
980         Unreviewed. Add libfii to GTK+ install dependencies script.
981
982         * gtk/install-dependencies:
983
984 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
985
986         Unreviewed, rolling out r215190.
987
988         Broke product select element on GNOME Bugzilla
989
990         Reverted changeset:
991
992         "[GTK] Misplaced right click menu on web page due to
993         deprecated gtk_menu_popup()"
994         https://bugs.webkit.org/show_bug.cgi?id=170553
995         http://trac.webkit.org/changeset/215190
996
997 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
998
999         Remove Reflect.enumerate
1000         https://bugs.webkit.org/show_bug.cgi?id=173806
1001
1002         Reviewed by Yusuke Suzuki.
1003
1004         * Scripts/run-jsc-stress-tests:
1005
1006 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
1007
1008         AX: Cannot call setValue() on contenteditable or ARIA text controls
1009         https://bugs.webkit.org/show_bug.cgi?id=173520
1010
1011         Reviewed by Ryosuke Niwa.
1012
1013         Add setValue() method to WKTR (already existed in DRT).
1014
1015         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1016         (WTR::AccessibilityUIElement::setValue):
1017         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1018         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1019         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1020         (WTR::AccessibilityUIElement::setValue):
1021
1022 2017-06-23  Keith Miller  <keith_miller@apple.com>
1023
1024         Switch VMTraps to use halt instructions rather than breakpoint instructions
1025         https://bugs.webkit.org/show_bug.cgi?id=173677
1026
1027         Reviewed by JF Bastien.
1028
1029         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1030         (TEST):
1031
1032 2017-06-23  Youenn Fablet  <youenn@apple.com>
1033
1034         Set getUserMedia permission to true by default on WTR
1035         https://bugs.webkit.org/show_bug.cgi?id=173610
1036
1037         Reviewed by Alex Christensen.
1038
1039         Adding a way to reset the getUserMedia permission to pending.
1040
1041         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1042         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1043         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
1044         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1045         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1046         (WTR::TestRunner::setUserMediaPermissionAsUnset):
1047         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1048         * WebKitTestRunner/TestController.cpp:
1049         (WTR::TestController::resetStateToConsistentValues):
1050         (WTR::TestController::setUserMediaPermissionAsUnset):
1051         * WebKitTestRunner/TestController.h:
1052         * WebKitTestRunner/TestInvocation.cpp:
1053         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1054
1055 2017-06-23  Alex Christensen  <achristensen@webkit.org>
1056
1057         Add SPI to WKURLSchemeTask for redirection
1058         https://bugs.webkit.org/show_bug.cgi?id=173730
1059
1060         Reviewed by Brady Eidson.
1061
1062         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1063         (-[SchemeHandler webView:startURLSchemeTask:]):
1064         (-[SchemeHandler webView:stopURLSchemeTask:]):
1065         (TEST):
1066         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
1067         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
1068         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
1069         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
1070         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
1071
1072 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1073
1074         [WPE] Use JSC API to send script messages from web extension in tests
1075         https://bugs.webkit.org/show_bug.cgi?id=173757
1076
1077         Reviewed by Žan Doberšek.
1078
1079         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
1080         to run postMessage().
1081
1082         Fixes: /wpe/WebKitSecurityManager/file-xhr
1083                /wpe/WebKitConsoleMessage/console-api
1084                /wpe/WebKitConsoleMessage/js-exception
1085                /wpe/WebKitConsoleMessage/network-error
1086                /wpe/WebKitConsoleMessage/security-error
1087
1088         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1089         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
1090         (beforeAll): Ditto.
1091         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1092         (testWebContextSecurityFileXHR): Ditto.
1093         (beforeAll): Ditto.
1094         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1095         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
1096         (pageCreatedCallback): Remove ifdefs.
1097
1098 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1099
1100         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
1101
1102         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
1103         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
1104         doesn't exist yet in WPE.
1105
1106         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1107         (testWebViewJavaScriptDialogs):
1108         (testWebViewWindowProperties):
1109
1110 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1111
1112         [GTK] Upgrade pixman and cairo in jhbuild
1113         https://bugs.webkit.org/show_bug.cgi?id=173710
1114
1115         Reviewed by Carlos Alberto Lopez Perez.
1116
1117         * gtk/jhbuild.modules:
1118
1119 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1120
1121         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
1122         https://bugs.webkit.org/show_bug.cgi?id=173711
1123
1124         Reviewed by Carlos Alberto Lopez Perez.
1125
1126         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
1127         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
1128
1129         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1130         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
1131
1132 2017-06-22  David Kilzer  <ddkilzer@apple.com>
1133
1134         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
1135         <https://webkit.org/b/173721>
1136
1137         Reviewed by Joseph Pecoraro.
1138
1139         Use RetainPtr<> to create NSMutableDictionary and NSNumber
1140         objects to fix leaks and to avoid the autoreleasepool.
1141
1142         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
1143         (TEST):
1144
1145 2017-06-22  Matt Lewis  <jlewis3@apple.com>
1146
1147         Unreviewed, rolling out r218633.
1148
1149         The test is failing frequently on Sierra Debug and Windows
1150
1151         Reverted changeset:
1152
1153         "AX: Cannot call setValue() on contenteditable or ARIA text
1154         controls"
1155         https://bugs.webkit.org/show_bug.cgi?id=173520
1156         http://trac.webkit.org/changeset/218633
1157
1158 2017-06-22  David Kilzer  <ddkilzer@apple.com>
1159
1160         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
1161         <https://webkit.org/b/173690>
1162
1163         Reviewed by Chris Dumez.
1164
1165         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
1166         ownership of malloc()-ed memory, then frees it when it's
1167         released.  These tests were passing global variables into the
1168         method, which is not malloc()-ed memory, which violates the API
1169         contract.
1170
1171         The fix is to switch to use
1172         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
1173         NO for the last argument.
1174
1175         Caught by the clang static analyzer.
1176
1177         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1178         (TEST):
1179         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1180         (TEST):
1181
1182 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1183
1184         [GTK] Upgrade Harfbuzz to version 1.4.2
1185         https://bugs.webkit.org/show_bug.cgi?id=173592
1186
1187         Reviewed by Carlos Alberto Lopez Perez.
1188
1189         * gtk/jhbuild.modules:
1190
1191 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1192
1193         [WPE] Update WPEBackend-mesa
1194         https://bugs.webkit.org/show_bug.cgi?id=173705
1195
1196         Reviewed by Carlos Alberto Lopez Perez.
1197
1198         A crash has been fixed, needed for unit tests to work.
1199
1200         * wpe/jhbuild.modules:
1201
1202 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1203
1204         Remove unused coordinated graphics C API
1205         https://bugs.webkit.org/show_bug.cgi?id=173706
1206
1207         Reviewed by Žan Doberšek.
1208
1209         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
1210         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
1211         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
1212         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
1213         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
1214         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
1215
1216 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1217
1218         [WPE] Build glib API tests
1219         https://bugs.webkit.org/show_bug.cgi?id=173702
1220
1221         Reviewed by Žan Doberšek.
1222
1223         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
1224         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
1225         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
1226         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
1227         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
1228         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
1229         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
1230         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
1231         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
1232         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
1233         and implement the missing features.
1234
1235         * CMakeLists.txt:
1236         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
1237         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1238         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1239         (testAutomationSessionRequestSession):
1240         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1241         (testWebKitWebViewSessionState):
1242         (testWebKitWebViewSessionStateWithFormData):
1243         (testWebKitWebViewNavigationAfterSessionRestore):
1244         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1245         (beforeAll):
1246         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1247         (testCookieManagerEphemeral):
1248         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1249         (testBlobDownload):
1250         (beforeAll):
1251         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1252         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1253         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1254         (testProcessPerWebView):
1255         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1256         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1257         (testWebViewCreateNavigationData):
1258         (testWebViewJavaScriptDialogs):
1259         (testWebViewWindowProperties):
1260         (testWebViewMouseTarget):
1261         (testWebViewGeolocationPermissionRequests):
1262         (testWebViewUserMediaPermissionRequests):
1263         (testWebViewAudioOnlyUserMediaPermissionRequests):
1264         (testWebViewFileChooserRequest):
1265         (beforeAll):
1266         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1267         (beforeAll):
1268         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1269         (testPrivateBrowsing):
1270         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1271         (testFindControllerHide):
1272         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1273         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1274         (testWebKitSettings):
1275         (beforeAll):
1276         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1277         (testWebViewNewWithUserContentManager):
1278         (beforeAll):
1279         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1280         (testWebContextEphemeral):
1281         (testWebContextProxySettings):
1282         (beforeAll):
1283         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1284         (testWebViewWebContext):
1285         (testWebViewWebContextLifetime):
1286         (testWebViewEphemeral):
1287         (testWebViewSettings):
1288         (testWebViewCanShowMIMEType):
1289         (testWebViewPageVisibility):
1290         (testWebViewIsPlayingAudio):
1291         (beforeAll):
1292         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1293         (testWebsiteDataEphemeral):
1294         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1295         (documentLoadedCallback):
1296         (pageCreatedCallback):
1297         (methodCallCallback):
1298         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
1299         * TestWebKitAPI/glib/CMakeLists.txt:
1300         * TestWebKitAPI/glib/PlatformGTK.cmake:
1301         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1302         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1303         (main):
1304         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1305         (Test::adoptView):
1306         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1307         (WebKitTestBus::run):
1308         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1309         (WebViewTest::~WebViewTest):
1310         (WebViewTest::initializeWebView):
1311         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1312         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
1313         (WebViewTest::platformDestroy):
1314         (WebViewTest::platformInitializeWebView):
1315         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
1316         (WebViewTest::resizeView):
1317         (WebViewTest::hideView):
1318         (parentWindowMapped):
1319         (WebViewTest::showInWindow):
1320         (WebViewTest::showInWindowAndWaitUntilMapped):
1321         (WebViewTest::mouseMoveTo):
1322         (WebViewTest::clickMouseButton):
1323         (WebViewTest::emitPopupMenuSignal):
1324         (WebViewTest::keyStroke):
1325         (WebViewTest::doMouseButtonEvent):
1326         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
1327         (WebViewTest::platformDestroy):
1328         (WebViewTest::platformInitializeWebView):
1329         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
1330         (WebViewTest::resizeView):
1331         (WebViewTest::hideView):
1332         (WebViewTest::mouseMoveTo):
1333         (WebViewTest::clickMouseButton):
1334         (WebViewTest::keyStroke):
1335
1336 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1337
1338         [GTK] Move WebKit2 GLib API tests to glib directories
1339         https://bugs.webkit.org/show_bug.cgi?id=173642
1340
1341         Reviewed by Žan Doberšek.
1342
1343         * CMakeLists.txt:
1344         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
1345         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
1346         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
1347         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
1348         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
1349         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
1350         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
1351         (testWebKitConsoleMessageNetworkError):
1352         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
1353         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
1354         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
1355         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
1356         (testLoadFromGResource):
1357         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
1358         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
1359         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
1360         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
1361         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
1362         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
1363         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
1364         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
1365         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
1366         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
1367         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
1368         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
1369         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
1370         (testWebViewRunJavaScript):
1371         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
1372         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
1373         (registerGResource):
1374         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
1375         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
1376         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
1377         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
1378         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
1379         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
1380         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
1381         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
1382         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
1383         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
1384         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
1385         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
1386         * TestWebKitAPI/glib/CMakeLists.txt: Added.
1387         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
1388         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
1389         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
1390         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
1391         (registerGResource):
1392         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
1393         (Test::getResourcesDir):
1394         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
1395         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
1396         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
1397         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
1398         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
1399         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
1400
1401 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1402
1403         [WPE] Add initial web extensions API
1404         https://bugs.webkit.org/show_bug.cgi?id=173640
1405
1406         Reviewed by Žan Doberšek.
1407
1408         Add style checker exceptions for WPE web extensions API files.
1409
1410         * Scripts/webkitpy/style/checker.py:
1411
1412 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1413
1414         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
1415         https://bugs.webkit.org/show_bug.cgi?id=173659
1416         <rdar://problem/32879788>
1417
1418         Reviewed by Tim Horton.
1419
1420         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
1421
1422         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
1423
1424         Augment this test page to log dragend and dragstart events on the drag source as well.
1425
1426         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1427         (checkStringArraysAreEqual):
1428         (TestWebKitAPI::TEST):
1429
1430 2017-06-21  Antoine Quint  <graouts@apple.com>
1431
1432         Ensure DRT always logs rAF suspension debugging code
1433         https://bugs.webkit.org/show_bug.cgi?id=173681
1434
1435         Reviewed by Tim "Mr. T" Horton.
1436
1437         * DumpRenderTree/mac/DumpRenderTree.mm:
1438         (resetWebPreferencesToConsistentValues):
1439
1440 2017-06-21  Chris Dumez  <cdumez@apple.com>
1441
1442         Allow constructing a WTF:Function from a function pointer
1443         https://bugs.webkit.org/show_bug.cgi?id=173660
1444
1445         Reviewed by Alex Christensen.
1446
1447         Add API test coverage.
1448
1449         * TestWebKitAPI/Tests/WTF/Function.cpp:
1450         (TestWebKitAPI::returnThree):
1451         (TestWebKitAPI::returnFour):
1452         (TestWebKitAPI::returnPassedValue):
1453         (TestWebKitAPI::TEST):
1454
1455 2017-06-21  Antoine Quint  <graouts@apple.com>
1456
1457         Add logging to identify when the Page suspends scripted animations
1458         https://bugs.webkit.org/show_bug.cgi?id=173626
1459
1460         Reviewed by Tim Horton.
1461
1462         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
1463
1464         * DumpRenderTree/mac/DumpRenderTree.mm:
1465         (resetWebPreferencesToConsistentValues):
1466
1467 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
1468
1469         AX: Cannot call setValue() on contenteditable or ARIA text controls
1470         https://bugs.webkit.org/show_bug.cgi?id=173520
1471
1472         Reviewed by Ryosuke Niwa.
1473
1474         Add setValue() method to WKTR (already existed in DRT).
1475
1476         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1477         (WTR::AccessibilityUIElement::setValue):
1478         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1479         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1480         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1481         (WTR::AccessibilityUIElement::setValue):
1482
1483 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
1484
1485         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
1486         as one of the dependencies required to build the product.
1487
1488         Rubber-stamped by Carlos Garcia Campos.
1489
1490         * gtk/install-dependencies:
1491         * wpe/install-dependencies:
1492
1493 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
1494
1495         Disable font variations on macOS Sierra and iOS 10
1496         https://bugs.webkit.org/show_bug.cgi?id=173618
1497         <rdar://problem/32879164>
1498
1499         Reviewed by Jon Lee.
1500
1501         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1502
1503 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1504
1505         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
1506         https://bugs.webkit.org/show_bug.cgi?id=173578
1507         <rdar://problem/32825028>
1508
1509         Reviewed by Tim Horton.
1510
1511         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
1512         a custom popover does not cause dragging to fail when the popover is presented.
1513
1514         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1515         (-[DataInteractionSimulator _advanceProgress]):
1516
1517 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1518
1519         [WPE] Add initial implementation of glib API
1520         https://bugs.webkit.org/show_bug.cgi?id=173546
1521
1522         Reviewed by Žan Doberšek.
1523
1524         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
1525         include WPE glib API files.
1526
1527         * Scripts/webkitperl/FeatureList.pm:
1528         * Scripts/webkitpy/style/checker.py:
1529         * Scripts/webkitpy/style/checkers/cpp.py:
1530         (check_identifier_name_in_declaration):
1531
1532 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1533
1534         [GTK] Upgrade to ICU to version 57.1
1535         https://bugs.webkit.org/show_bug.cgi?id=173538
1536
1537         Reviewed by Žan Doberšek.
1538
1539         * gtk/jhbuild.modules:
1540
1541 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1542
1543         [GTK] Remove unneeded modules from the jhbuild
1544         https://bugs.webkit.org/show_bug.cgi?id=170540
1545
1546         Reviewed by Michael Catanzaro.
1547
1548         We are building libxslt and libffi that we don't really need to build from sources.
1549
1550         * gtk/jhbuild.modules:
1551
1552 2017-06-19  Frederic Wang  <fwang@igalia.com>
1553
1554         [Mac] Add an experimental feature setting for async frame scrolling
1555         https://bugs.webkit.org/show_bug.cgi?id=173359
1556
1557         Reviewed by Simon Fraser.
1558
1559         * DumpRenderTree/mac/DumpRenderTree.mm:
1560         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
1561         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
1562         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1563         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
1564
1565 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
1566
1567         Unreviewed, adding myself to contributors.json
1568
1569         * Scripts/webkitpy/common/config/contributors.json:
1570
1571 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
1572
1573         test262: Completion values for control flow do not match the spec
1574         https://bugs.webkit.org/show_bug.cgi?id=171265
1575
1576         Reviewed by Saam Barati.
1577
1578         * Scripts/run-jsc-stress-tests:
1579         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
1580
1581 2017-06-19  Zalan Bujtas  <zalan@apple.com>
1582
1583         Opening certain mails brings up a mail that grows indefinitely.
1584         https://bugs.webkit.org/show_bug.cgi?id=173562
1585         <rdar://problem/32766579>
1586
1587         Reviewed by Tim Horton.
1588
1589         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1590         (TEST):
1591
1592 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1593
1594         [iOS DnD] Support .zip archives for file uploads via drag and drop
1595         https://bugs.webkit.org/show_bug.cgi?id=173511
1596         <rdar://problem/32521025>
1597
1598         Reviewed by Tim Horton.
1599
1600         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
1601         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
1602
1603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1604         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
1605         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1606         (testZIPArchive):
1607         (TestWebKitAPI::TEST):
1608
1609 2017-06-18  Darin Adler  <darin@apple.com>
1610
1611         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
1612         https://bugs.webkit.org/show_bug.cgi?id=173526
1613
1614         Reviewed by Sam Weinig.
1615
1616         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
1617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1618
1619         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
1620         tests for assignment before destruction ones.
1621
1622         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
1623         as a function, so it can be used in WTF::Function tests.
1624
1625         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
1626         Added tests for swap and for assignment before deref.
1627
1628         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
1629         to inline everything. Also removed the unnecessary clearing of the log every time
1630         the DerivedRefLogger constructor is called.
1631         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
1632
1633         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
1634         Added tests for assignment before deref and similar for releaseNonNull.
1635
1636 2017-06-19  Sam Weinig  <sam@webkit.org>
1637
1638         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
1639         https://bugs.webkit.org/show_bug.cgi?id=173513
1640
1641         Reviewed by Alex Christensen.
1642
1643         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1644         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1645         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
1646
1647 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
1648
1649         [Win] fast/dom/assign-to-window-status.html is flaky.
1650         https://bugs.webkit.org/show_bug.cgi?id=173512
1651
1652         Reviewed by Alex Christensen.
1653
1654         We should not dump status callbacks when test is done.
1655
1656         * DumpRenderTree/win/UIDelegate.cpp:
1657         (UIDelegate::setStatusText):
1658
1659 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1660
1661         [WPE][JHBuild] Update WPEBackend-mesa
1662         https://bugs.webkit.org/show_bug.cgi?id=173433
1663
1664         Unreviewed.
1665
1666         Update WPEBackend-mesa back (like it was done originally in r218344)
1667         after fixing the issue with the DISPLAY environment variables that
1668         caused the crashes.
1669
1670         * wpe/jhbuild.modules:
1671
1672 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1673
1674         Rename unit test file after r218482
1675         https://bugs.webkit.org/show_bug.cgi?id=173483
1676
1677         Unreviewed.
1678
1679         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
1680
1681 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1682
1683         Unreviewed. Fix wrong style checker condition added in r218487.
1684
1685         * Scripts/webkitpy/style/checkers/cpp.py:
1686         (check_identifier_name_in_declaration):
1687
1688 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
1689
1690         Missing <functional> includes make builds fail with GCC 7.x
1691         https://bugs.webkit.org/show_bug.cgi?id=173544
1692
1693         Unreviewed gardening.
1694
1695         Fix compilation with GCC 7.
1696
1697         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1698         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1699
1700 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1701
1702         [GTK] Move GTK+ API files that could be shared to glib dirs
1703         https://bugs.webkit.org/show_bug.cgi?id=173545
1704
1705         Reviewed by Žan Doberšek.
1706
1707         Update paths of GTK+ API in watchlist and style checker.
1708
1709         * Scripts/webkitpy/common/config/watchlist:
1710         * Scripts/webkitpy/style/checker.py:
1711         * Scripts/webkitpy/style/checkers/cpp.py:
1712         (check_identifier_name_in_declaration):
1713
1714 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1715
1716         Port setup_environ_for_server should not set environment variables related with the driver.
1717         https://bugs.webkit.org/show_bug.cgi?id=173483
1718
1719         Reviewed by Carlos Garcia Campos.
1720
1721         The port setup_environ_for_server() should not set environment variables
1722         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
1723         This varibles should be only set on the driver setup_environ_for_test().
1724
1725         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
1726         into the test environment even when running the tests with a driver
1727         that is not the Xorg or Xvfb one.
1728
1729         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
1730         (Port.to.setup_environ_for_server):
1731         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
1732         (Driver._setup_environ_for_driver):
1733         * Scripts/webkitpy/port/driver_unittest.py:
1734         (DriverTest.test_setup_environ_for_test):
1735         (DriverTest):
1736         (DriverTest.test_setup_environ_base_vars):
1737         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
1738         (GtkPort.setup_environ_for_server):
1739         * Scripts/webkitpy/port/wayland_unittest.py: Added.
1740         (WaylandDriverTest):
1741         (WaylandDriverTest.make_driver):
1742         (WaylandDriverTest.make_environment):
1743         (WaylandDriverTest.test_checkdriver):
1744         (WaylandDriverTest.test_environment_needed_variables):
1745         (WaylandDriverTest.test_environment_forbidden_variables):
1746         (WaylandDriverTest.test_environment_optional_variables):
1747         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
1748         (WaylandDriver.check_driver):
1749         (WaylandDriver._setup_environ_for_test):
1750         * Scripts/webkitpy/port/xorgdriver.py:
1751         (XorgDriver.check_driver):
1752         (XorgDriver._setup_environ_for_test):
1753         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
1754         (XorgDriverTest):
1755         (XorgDriverTest.make_driver):
1756         (XorgDriverTest.make_environment):
1757         (XorgDriverTest.test_checkdriver):
1758         (XorgDriverTest.test_environment_needed_variables):
1759         (XorgDriverTest.test_environment_forbidden_variables):
1760         (XorgDriverTest.test_environment_optional_variables):
1761         * Scripts/webkitpy/port/xvfbdriver.py:
1762         (XvfbDriver._setup_environ_for_test):
1763         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1764         (XvfbDriverTest.assertDriverStartSuccessful):
1765
1766
1767 2017-05-14 Frederic Wang  <fwang@igalia.com>
1768
1769         Add heuristic to avoid flattening "fullscreen" iframes
1770         https://bugs.webkit.org/show_bug.cgi?id=171914
1771
1772         Reviewed by Simon Fraser.
1773
1774         * DumpRenderTree/mac/DumpRenderTree.mm:
1775         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
1776
1777 2017-06-18  Chris Dumez  <cdumez@apple.com>
1778
1779         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
1780         https://bugs.webkit.org/show_bug.cgi?id=173522
1781         <rdar://problem/31185739>
1782
1783         Reviewed by Darin Adler.
1784
1785         Add API test for re-entering Function's assignment operators.
1786
1787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1788         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
1789         (TestWebKitAPI::TestObject::TestObject):
1790         (TestWebKitAPI::TestObject::~TestObject):
1791         (TestWebKitAPI::TestObject::operator()):
1792         (TestWebKitAPI::TEST):
1793
1794 2017-06-16  Dan Bernstein  <mitz@apple.com>
1795
1796         [Cocoa] Some declarations have missing or incorrect availability attributes
1797         https://bugs.webkit.org/show_bug.cgi?id=173508
1798
1799         Reviewed by Tim Horton.
1800
1801         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1802         (TestWebKitAPI::TEST): Updated for renames.
1803
1804 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1805
1806         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
1807         https://bugs.webkit.org/show_bug.cgi?id=173366
1808         <rdar://problem/32767014>
1809
1810         Reviewed by Tim Horton.
1811
1812         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
1813         change in behavior.
1814
1815         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1817         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1818         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
1819         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
1820         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
1821         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
1822         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1823         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1824         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
1825         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
1826         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
1827         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
1828         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
1829         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1830         (-[MockDragDropSession initWithItems:location:window:]):
1831         (-[MockDragDropSession allowsMoveOperation]):
1832         (-[MockDragDropSession isRestrictedToDraggingApplication]):
1833         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
1834         (-[MockDragDropSession canLoadObjectsOfClass:]):
1835         (-[MockDragDropSession canLoadObjectsOfClasses:]):
1836         (-[MockDragDropSession items]):
1837         (-[MockDragDropSession setItems:]):
1838         (-[MockDragDropSession locationInView:]):
1839         (-[MockDataOperationSession initWithProviders:location:window:]):
1840         (-[MockDataOperationSession session]):
1841         (-[MockDataOperationSession isLocal]):
1842         (-[MockDataOperationSession progress]):
1843         (-[MockDataOperationSession setProgressIndicatorStyle:]):
1844         (-[MockDataOperationSession progressIndicatorStyle]):
1845         (-[MockDataOperationSession operationMask]):
1846         (-[MockDataOperationSession localDragSession]):
1847         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
1848         (-[MockDataOperationSession canCreateItemsOfClass:]):
1849         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
1850         (-[MockDataInteractionSession initWithWindow:]):
1851         (-[MockDataInteractionSession localOperationMask]):
1852         (-[MockDataInteractionSession externalOperationMask]):
1853         (-[MockDataInteractionSession session]):
1854         (-[DataInteractionSimulator _advanceProgress]):
1855
1856 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1857
1858         Show punycode to user if a URL has dotless i or j followed by diacritic dot
1859         https://bugs.webkit.org/show_bug.cgi?id=173431
1860
1861         Reviewed by Darin Adler.
1862
1863         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1864         (TestWebKitAPI::TEST):
1865
1866 2017-06-16  Chris Dumez  <cdumez@apple.com>
1867
1868         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
1869         https://bugs.webkit.org/show_bug.cgi?id=173472
1870         <rdar://problem/28858817>
1871
1872         Reviewed by Brady Eidson.
1873
1874         Add API test coverage.
1875
1876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1877         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
1878         (TEST):
1879
1880 2017-06-16  Brady Eidson  <beidson@apple.com>
1881
1882         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
1883         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
1884
1885         Reviewed by Daniel Bates.
1886
1887         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1888
1889 2017-06-16  Chris Dumez  <cdumez@apple.com>
1890
1891         DRT fails to reset page visibility between tests
1892         https://bugs.webkit.org/show_bug.cgi?id=173485
1893
1894         Reviewed by Alexey Proskuryakov.
1895
1896         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
1897         Fix this to address flakiness.
1898
1899         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
1900         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
1901         The test became flaky without the DRT change and was no longer flaky with the DRT
1902         change.
1903
1904         WebKitTestRunner already does this.
1905
1906         * DumpRenderTree/mac/DumpRenderTree.mm:
1907         (resetWebViewToConsistentStateBeforeTesting):
1908
1909 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1910
1911         Implement basic authentication in MiniBrowser
1912         https://bugs.webkit.org/show_bug.cgi?id=173443
1913
1914         Reviewed by Tim Horton.
1915
1916         * MiniBrowser/mac/WK2BrowserWindowController.m:
1917         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
1918
1919 2017-06-16  Jer Noble  <jer.noble@apple.com>
1920
1921         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1922         https://bugs.webkit.org/show_bug.cgi?id=173398
1923         <rdar://problem/32592961>
1924
1925         Reviewed by Eric Carlson.
1926
1927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1928         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1929         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1930         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1931         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1932         (TestWebKitAPI::TEST):
1933         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1934
1935 2017-06-16  Matt Lewis  <jlewis3@apple.com>
1936
1937         Unreviewed, rolling out r218375.
1938
1939         The API test MediaStreamTrackDetached is still timing out
1940         after the patch
1941
1942         Reverted changeset:
1943
1944         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1945         reports no recording to WebKit clients"
1946         https://bugs.webkit.org/show_bug.cgi?id=173398
1947         http://trac.webkit.org/changeset/218375
1948
1949 2017-06-15  Jer Noble  <jer.noble@apple.com>
1950
1951         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1952         https://bugs.webkit.org/show_bug.cgi?id=173398
1953         <rdar://problem/32592961>
1954
1955         Reviewed by Eric Carlson.
1956
1957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1958         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1959         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1960         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1961         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1962         (TestWebKitAPI::TEST):
1963         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1964
1965 2017-06-15  Matt Lewis  <jlewis3@apple.com>
1966
1967         Unreviewed, rolling out r218365.
1968
1969         The revision caused API timeouts on all builds.
1970
1971         Reverted changeset:
1972
1973         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1974         reports no recording to WebKit clients"
1975         https://bugs.webkit.org/show_bug.cgi?id=173398
1976         http://trac.webkit.org/changeset/218365
1977
1978 2017-06-15  Jer Noble  <jer.noble@apple.com>
1979
1980         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1981         https://bugs.webkit.org/show_bug.cgi?id=173398
1982         <rdar://problem/32592961>
1983
1984         Reviewed by Eric Carlson.
1985
1986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1987         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1988         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1989         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1990         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1991         (TestWebKitAPI::TEST):
1992         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1993
1994 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1995
1996         REGRESSION(r218344): [WPE] Thousands of layout test crashes
1997         https://bugs.webkit.org/show_bug.cgi?id=173433
1998
1999         Unreviewed.
2000
2001         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
2002
2003 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2004
2005         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
2006         https://bugs.webkit.org/show_bug.cgi?id=173061
2007
2008         Reviewed by Žan Doberšek.
2009
2010         Launch dyz <https://github.com/Igalia/dyz> with the script
2011         run-minibrowser for the wpe port. It is now built as part of the
2012         WPE dependencies with JHBuild.
2013
2014         * Scripts/run-minibrowser:
2015         * Scripts/webkitdirs.pm:
2016         (launcherPath):
2017         (launcherName):
2018         * wpe/install-dependencies: Luajit is needed for building dyz.
2019         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
2020
2021 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2022
2023         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
2024         https://bugs.webkit.org/show_bug.cgi?id=173338
2025         <rdar://problem/32777720>
2026
2027         Reviewed by Tim Horton.
2028
2029         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
2030         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
2031         these remaining items on drop.
2032
2033         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2034         (TestWebKitAPI::TEST):
2035         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2036         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2037
2038         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
2039
2040         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
2041
2042 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
2043
2044         [Win] Crash in accessibility layout test.
2045         https://bugs.webkit.org/show_bug.cgi?id=173401
2046
2047         Reviewed by Brent Fulgham.
2048
2049         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
2050         member will be automatically released when the _variant_t object goes out of scope if the vt member
2051         does not equal VT_UNKNOWN | VT_BYREF.
2052         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
2053
2054         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2055         (AccessibilityUIElement::titleUIElement):
2056
2057 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2058
2059         [GTK] Add API to allow overriding popup menus
2060         https://bugs.webkit.org/show_bug.cgi?id=172905
2061
2062         Reviewed by Michael Catanzaro.
2063
2064         Add a unit test to check the new API.
2065
2066         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2067         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
2068         (OptionMenuTest::OptionMenuTest):
2069         (OptionMenuTest::~OptionMenuTest):
2070         (OptionMenuTest::destroyMenu):
2071         (OptionMenuTest::showOptionMenuCallback):
2072         (OptionMenuTest::menuCloseCallback):
2073         (OptionMenuTest::showOptionMenu):
2074         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
2075         (OptionMenuTest::close):
2076         (OptionMenuTest::activateItem):
2077         (OptionMenuTest::selectItem):
2078         (testOptionMenuSimple):
2079         (testOptionMenuGroups):
2080         (testOptionMenuActivate):
2081         (testOptionMenuSelect):
2082         (beforeAll):
2083         (afterAll):
2084
2085 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
2086
2087         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
2088         https://bugs.webkit.org/show_bug.cgi?id=173399
2089
2090         Reviewed by Per Arne Vollan.
2091
2092         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
2093         Curl port needs to do nothing because libcurl doesn't have disk cache.
2094
2095         * DumpRenderTree/win/DumpRenderTree.cpp:
2096         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
2097         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
2098
2099 2017-06-14  Tomas Popela  <tpopela@redhat.com>
2100
2101         [GTK] integer expression expected if running Tools/gtk/install-dependencies
2102         https://bugs.webkit.org/show_bug.cgi?id=173356
2103
2104         Reviewed by Michael Catanzaro.
2105
2106         Use the correct operator to compare the strings.
2107
2108         * gtk/install-dependencies:
2109
2110 2017-06-14  Commit Queue  <commit-queue@webkit.org>
2111
2112         Unreviewed, rolling out r218285.
2113         https://bugs.webkit.org/show_bug.cgi?id=173391
2114
2115         API test fails on iOS (Requested by alexchristensen on
2116         #webkit).
2117
2118         Reverted changeset:
2119
2120         "Add SPI for immediate injection of user scripts"
2121         https://bugs.webkit.org/show_bug.cgi?id=173342
2122         http://trac.webkit.org/changeset/218285
2123
2124 2017-06-14  Chris Dumez  <cdumez@apple.com>
2125
2126         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
2127         https://bugs.webkit.org/show_bug.cgi?id=173384
2128         <rdar://problem/32723779>
2129
2130         Reviewed by Dan Bernstein.
2131
2132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2133         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
2134         Add API test coverage.
2135
2136         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2137         (TestWebKitAPI::Util::sleep):
2138         Update implementation of Util::sleep() so that we actually run the run loop.
2139         Otherwise, we don't process events while sleeping.
2140
2141 2017-06-14  Alex Christensen  <achristensen@webkit.org>
2142
2143         Add SPI for immediate injection of user scripts
2144         https://bugs.webkit.org/show_bug.cgi?id=173342
2145         <rdar://problem/29202285>
2146
2147         Reviewed by Brady Eidson.
2148
2149         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2150         (waitForMessage):
2151         (TEST):
2152
2153 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
2154
2155         Add WPE to the flakiness dashboard
2156         https://bugs.webkit.org/show_bug.cgi?id=173365
2157
2158         Reviewed by Carlos Alberto Lopez Perez.
2159
2160         * TestResultServer/static-dashboards/builders.jsonp:
2161         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2162         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2163         (resetGlobals):
2164         * TestResultServer/static-dashboards/loader_unittests.js:
2165
2166 2017-06-14  Brady Eidson  <beidson@apple.com>
2167
2168         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
2169         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
2170
2171         Reviewed by Alex Christensen.
2172
2173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2174         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
2175         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
2176         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
2177         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
2178         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
2179         (TEST):
2180
2181 2017-06-14  Tim Horton  <timothy_horton@apple.com>
2182
2183         WKContentViewEditingActions API test always fails
2184         https://bugs.webkit.org/show_bug.cgi?id=173374
2185
2186         Reviewed by Wenson Hsieh.
2187
2188         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
2189         (TEST):
2190         selectAll isn't working, because canPerformAction for selectAll returns NO
2191         if selectionIsNone (which is true in the non-contenteditable case).
2192         Instead, make use of r218180's test page, which knows how to select itself.
2193         Also, reset the pasteboard at the beginning of the test to reduce confusion
2194         (I landed the test broken because my simulator had the correct text
2195         stuck in its pasteboard).
2196
2197 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
2198
2199         Configure screen scale for running layout tests on plus devices
2200         https://bugs.webkit.org/show_bug.cgi?id=173319
2201
2202         Reviewed by Tim Horton.
2203
2204         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
2205         * DumpRenderTree/mac/DumpRenderTree.mm:
2206         (dumpRenderTree): Set screen scale to 2.0.
2207         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
2208         add _setScale for UIScreen.
2209         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
2210         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
2211         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
2212         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
2213         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
2214         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
2215         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
2216         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
2217         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
2218         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
2219
2220 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
2221
2222         Add iOS 11 support to the bot watcher's dashboard
2223         https://bugs.webkit.org/show_bug.cgi?id=173369
2224
2225         Reviewed by Lucas Forschler.
2226
2227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
2228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
2229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
2230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
2231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2233
2234 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2235
2236         [GTK][WPE] Raise the timeout values for layout tests
2237         https://bugs.webkit.org/show_bug.cgi?id=173368
2238
2239         Reviewed by Carlos Garcia Campos.
2240
2241         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
2242         When running under valgrind a 10x multiplier is applied.
2243
2244         * Scripts/webkitpy/port/gtk.py:
2245         (GtkPort.default_timeout_ms):
2246         * Scripts/webkitpy/port/gtk_unittest.py:
2247         (GtkPortTest.test_default_timeout_ms):
2248         * Scripts/webkitpy/port/wpe.py:
2249         (WPEPort.default_timeout_ms):
2250         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
2251         (WPEPortTest):
2252         (WPEPortTest.make_port):
2253         (WPEPortTest.test_default_timeout_ms):
2254         (WPEPortTest.test_get_crash_log):
2255
2256 2017-06-14  Alex Christensen  <achristensen@webkit.org>
2257
2258         Test persistent WKHTTPCookieStorages on iOS.
2259         https://bugs.webkit.org/show_bug.cgi?id=173284
2260
2261         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2262         (TEST):
2263         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
2264
2265 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
2266
2267         [Win] DRT should not use disk cache.
2268         https://bugs.webkit.org/show_bug.cgi?id=173361
2269
2270         Reviewed by Darin Adler.
2271
2272         Like on macOS/iOS, DRT on Windows should only use memory cache.
2273
2274         * DumpRenderTree/win/DumpRenderTree.cpp:
2275         (setDefaultsToConsistentValuesForTesting):
2276         (prepareConsistentTestingEnvironment):
2277
2278 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
2279
2280         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
2281         https://bugs.webkit.org/show_bug.cgi?id=171668
2282
2283         Reviewed by Jer Noble.
2284
2285         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
2286         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
2287         Infinity when the double value passed as argument is greater than 2^64.
2288
2289         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
2290         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
2291         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
2292         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
2293         method. No behavior change for rational MediaTime.
2294
2295         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
2296         (TestWebKitAPI::TEST):
2297
2298 2017-06-13  Alex Christensen  <achristensen@webkit.org>
2299
2300         Test persistent WKHTTPCookieStorages on iOS
2301         https://bugs.webkit.org/show_bug.cgi?id=173284
2302         <rdar://problem/32260156>
2303
2304         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2305         (TEST):
2306
2307 2017-06-13  Matt Rajca  <mrajca@apple.com>
2308
2309         WebsitePolicies: let clients select specific autoplay quirks
2310         https://bugs.webkit.org/show_bug.cgi?id=173343
2311
2312         Reviewed by Alex Christensen.
2313
2314         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2315         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2316         (TEST): Updated tests.
2317
2318 2017-06-13  Daniel Bates  <dabates@apple.com>
2319
2320         Implement W3C Secure Contexts Draft Specification
2321         https://bugs.webkit.org/show_bug.cgi?id=158121
2322         <rdar://problem/26012994>
2323
2324         Reviewed by Brent Fulgham.
2325
2326         Part 4
2327
2328         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
2329         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
2330         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
2331
2332         * DumpRenderTree/TestOptions.h:
2333         * DumpRenderTree/TestOptions.mm:
2334         (TestOptions::TestOptions):
2335         * DumpRenderTree/mac/DumpRenderTree.mm:
2336         (setWebPreferencesForTestOptions):
2337         * DumpRenderTree/win/DumpRenderTree.cpp:
2338         (enableExperimentalFeatures):
2339         * WebKitTestRunner/TestController.cpp:
2340         (WTR::TestController::resetPreferencesToConsistentValues):
2341         (WTR::updateTestOptionsFromTestHeader):
2342         * WebKitTestRunner/TestOptions.h:
2343         (WTR::TestOptions::hasSameInitializationOptions):
2344
2345 2017-06-13  Alex Christensen  <achristensen@webkit.org>
2346
2347         Test persistent WKHTTPCookieStorages on iOS
2348         https://bugs.webkit.org/show_bug.cgi?id=173284
2349         <rdar://problem/32260156>
2350
2351         Reviewed by Alexey Proskuryakov.
2352
2353         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2354         (TEST):
2355
2356 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2357
2358         [GTK] Blob download doesn't work
2359         https://bugs.webkit.org/show_bug.cgi?id=172442
2360
2361         Reviewed by Carlos Alberto Lopez Perez.
2362
2363         Add a unit test to check blob downloads.
2364
2365         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2366         (testBlobDownload):
2367         (beforeAll):
2368
2369 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2370
2371         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
2372         https://bugs.webkit.org/show_bug.cgi?id=173316
2373
2374         Reviewed by Alex Christensen.
2375
2376         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
2377
2378         * gtk/manifest.txt.in:
2379
2380 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2381
2382         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
2383         https://bugs.webkit.org/show_bug.cgi?id=173315
2384
2385         Reviewed by Darin Adler.
2386
2387         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
2388         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
2389         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
2390         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
2391         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
2392         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
2393         WKGeolocationManagerRef is not destroyed.
2394
2395         * WebKitTestRunner/GeolocationProviderMock.cpp:
2396         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2397         * WebKitTestRunner/GeolocationProviderMock.h:
2398
2399 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2400
2401         Unable to paste text that was copied from a page into the universal search field
2402         https://bugs.webkit.org/show_bug.cgi?id=173293
2403         <rdar://problem/32440918>
2404
2405         Reviewed by Ryosuke Niwa.
2406
2407         Adds 2 new unit tests for copying plain and rich selected web content.
2408         See WebCore and WebKit ChangeLogs for more detail.
2409
2410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2411         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
2412         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
2413         (TestWebKitAPI::dataForPasteboardType):
2414         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2415         (TestWebKitAPI::TEST):
2416
2417 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
2418
2419         AX: [ATK] Implement missing AtkRelation types
2420         https://bugs.webkit.org/show_bug.cgi?id=155494
2421
2422         Reviewed by Darin Adler.
2423
2424         Add additional methods to test ARIA properties which are exposed via
2425         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
2426
2427         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2428         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
2429         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
2430         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
2431         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
2432         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
2433         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
2434         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
2435         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2436         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2437         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2438         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
2439         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
2440         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
2441         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
2442         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
2443         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
2444         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
2445
2446 2017-06-12  Daniel Bates  <dabates@apple.com>
2447
2448         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
2449         https://bugs.webkit.org/show_bug.cgi?id=173286
2450         <rdar://problem/32726102>
2451
2452         Reviewed by Brent Fulgham.
2453
2454         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2455         (TestWebKitAPI::TEST_F):
2456
2457 2017-06-12  Lucas Forschler  <lforschler@apple.com>
2458
2459         <rdar://problem/32683422>
2460         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
2461
2462         Reviewed by Conrad Schultz.
2463
2464         * Scripts/copy-webkitlibraries-to-product-directory:
2465
2466 2017-06-12  Tim Horton  <timothy_horton@apple.com>
2467
2468         [iOS] Cmd-C doesn't copy text from WKWebView
2469         https://bugs.webkit.org/show_bug.cgi?id=173277
2470         <rdar://problem/32396742>
2471
2472         Reviewed by Dan Bernstein.
2473
2474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2475         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
2476         Add a test ensuring that -copy on WKContentView will cause text to be copied.
2477
2478 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
2479
2480         [WebCrypto] Remove experimental feature flag of SubtleCrypto
2481         https://bugs.webkit.org/show_bug.cgi?id=173197
2482         <rdar://problem/32688148>
2483
2484         Reviewed by Brent Fulgham.
2485
2486         * DumpRenderTree/mac/DumpRenderTree.mm:
2487         (enableExperimentalFeatures):
2488         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2489         (WTR::InjectedBundle::beginTesting):
2490         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2491         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
2492         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2493
2494 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2495
2496         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
2497         https://bugs.webkit.org/show_bug.cgi?id=173238
2498         <rdar://problem/31943370>
2499
2500         Reviewed by Ryosuke Niwa and Tim Horton.
2501
2502         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
2503         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
2504         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
2505
2506         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2507         (TestWebKitAPI::TEST):
2508         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2509         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2510         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
2511         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
2512
2513 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2514
2515         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
2516         https://bugs.webkit.org/show_bug.cgi?id=173225
2517         <rdar://problem/32713144>
2518
2519         Reviewed by Tim Horton.
2520
2521         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
2522         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
2523
2524         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2525         (TestWebKitAPI::TEST):
2526
2527 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
2528
2529         Return correct process names for iOS on-device testing
2530         https://bugs.webkit.org/show_bug.cgi?id=173263
2531
2532         Reviewed by Alex Christensen.
2533
2534         When running tests on iOS devices, process names do not end with '.Development'
2535         as they do on Mac and iOS simulator.
2536
2537         * WebKitTestRunner/TestController.cpp:
2538         (WTR::TestController::webProcessName): Return correct process name without '.Development'
2539         for iOS on-device testing.
2540         (WTR::TestController::networkProcessName): Ditto.
2541         (WTR::TestController::databaseProcessName): Ditto.
2542
2543 2017-06-12  Chris Dumez  <cdumez@apple.com>
2544
2545         Regression(r217867): Legacy SessionHistoryEntryData format should not change
2546         https://bugs.webkit.org/show_bug.cgi?id=173267
2547         <rdar://problem/32701257>
2548
2549         Reviewed by Simon Fraser.
2550
2551         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
2552         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
2553         though as this covers the crash that r217867 was fixing.
2554
2555         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
2556         (TestWebKitAPI::createSessionStateData):
2557         (TestWebKitAPI::TEST):
2558         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
2559
2560 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2561
2562         [GTK] Stop dismissing menus attached to the web view for every injected event
2563         https://bugs.webkit.org/show_bug.cgi?id=172708
2564
2565         Reviewed by Alex Christensen.
2566
2567         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
2568         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
2569         events while the menu is open.
2570
2571         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2572         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
2573         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2574         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
2575
2576 2017-06-12  Miguel Gomez  <magomez@igalia.com>
2577
2578         [GTK][WPE] Enable GStreamer GL on development builds
2579         https://bugs.webkit.org/show_bug.cgi?id=173248
2580
2581         Enable GStreamer GL for GTK and WPE.
2582
2583         Reviewed by Carlos Garcia Campos.
2584
2585         * Scripts/webkitperl/FeatureList.pm:
2586
2587 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2588
2589         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
2590
2591         Notifications are no longer cleared on page navigation.
2592
2593         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2594         (testWebViewNotification):
2595
2596 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2597
2598         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
2599
2600         DBus interface and object path names were updated in r217831.
2601
2602         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
2603
2604 2017-06-10  Dan Bernstein  <mitz@apple.com>
2605
2606         Reverted r218056 because it made the IDE reindex constantly.
2607
2608         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2609         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2610         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2611         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2612         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2613         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2614         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2615         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2616
2617 2017-06-10  Dan Bernstein  <mitz@apple.com>
2618
2619         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
2620         https://bugs.webkit.org/show_bug.cgi?id=173223
2621
2622         Reviewed by Sam Weinig.
2623
2624         The rebuilds were happening due to a difference in the compiler options that the IDE and
2625         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
2626         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
2627         specify an appropriate path in CLANG_INDEX_STORE_PATH.
2628
2629         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2630         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2631         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2632         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2633         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2634         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2635         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2636         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2637
2638 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
2639
2640         webkitpy: Reduce polling in ServerProcess
2641         https://bugs.webkit.org/show_bug.cgi?id=173116
2642
2643         Reviewed by Ryosuke Niwa.
2644
2645         We should be smarter about polling. We do not need to poll every time a line is read from
2646         stdout and stderr since lines are usually read from cached data. We should only poll
2647         when extracting that cached data from stdout and stderr.
2648
2649         * Scripts/webkitpy/port/driver.py:
2650         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
2651         and on ServerProcess to poll the process if not data is available in stdout and stderr.
2652         * Scripts/webkitpy/port/driver_unittest.py:
2653         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
2654         ServerProcess.
2655         * Scripts/webkitpy/port/server_process.py:
2656         (ServerProcess._read): Allow for data to be read from _output even if the process has
2657         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
2658         * Scripts/webkitpy/port/server_process_mock.py:
2659         (MockServerProcess): Add number_of_times_polled.
2660         (MockServerProcess.poll): Increment number_of_times_polled.
2661         (MockServerProcess.has_crashed): Poll before returning crash state.
2662         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
2663         just like a ServerProcess would.
2664         (MockServerProcess.read_stdout): Ditto.
2665         * Scripts/webkitpy/port/server_process_unittest.py:
2666         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
2667         process from ending before stdout and stderr are read. This is the reason this test was flakey.
2668         (TestServerProcess):
2669         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
2670         the processes is polled.
2671         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
2672         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
2673
2674 2017-06-10  Andy Estes  <aestes@apple.com>
2675
2676         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
2677         https://bugs.webkit.org/show_bug.cgi?id=173190
2678         <rdar://problem/31360659>
2679
2680         Reviewed by Brady Eidson.
2681         
2682         Added a release assert that tries to create a proper test failure if the web process crashes.
2683
2684         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2685         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
2686
2687 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2688
2689         [iOS DnD] Add a hook to perform two-step drops in editable content
2690         https://bugs.webkit.org/show_bug.cgi?id=172992
2691         <rdar://problem/32590174>
2692
2693         Reviewed by Tim Horton.
2694
2695         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
2696         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
2697                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
2698
2699         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
2700         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2701         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
2702
2703         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
2704         be overridden. Currently, this is overridden to just return true.
2705
2706         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2707         (TestWebKitAPI::TEST):
2708         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2709         (WTR::InjectedBundlePage::InjectedBundlePage):
2710
2711 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2712
2713         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
2714         https://bugs.webkit.org/show_bug.cgi?id=173103
2715
2716         Reviewed by Xabier Rodriguez-Calvar.
2717
2718         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
2719         when building the WPE port through build-webkit.
2720
2721 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2722
2723         [WPE] Enable MEDIA_SOURCE for build-webkit builds
2724         https://bugs.webkit.org/show_bug.cgi?id=173136
2725
2726         Reviewed by Xabier Rodriguez-Calvar.
2727
2728         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
2729
2730 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2731
2732         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
2733         https://bugs.webkit.org/show_bug.cgi?id=173098
2734
2735         Reviewed by Žan Doberšek.
2736
2737         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
2738         assuming that all tests containing forms define ids for the form elements like
2739         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
2740
2741         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2742         (formControlsAssociatedCallback):
2743
2744 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
2745
2746         webkitpy: Run sample/spindump on iOS devices
2747         https://bugs.webkit.org/show_bug.cgi?id=171881
2748         <rdar://problem/32084602>
2749
2750         Reviewed by Daniel Bates.
2751
2752         * Scripts/webkitpy/port/darwin.py:
2753         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
2754         requires sudo to run spindump.
2755         * Scripts/webkitpy/port/ios_device.py:
2756         (IOSDevicePort.look_for_new_samples): Deleted.
2757         (IOSDevicePort.sample_process): Deleted.
2758         * Scripts/webkitpy/port/ios_device_unittest.py:
2759         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
2760         (IOSDeviceTest.test_spindump):
2761         (IOSDeviceTest.test_sample_process):
2762         (IOSDeviceTest.test_sample_process_exception):
2763         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2764         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
2765
2766 2017-06-08  Keith Miller  <keith_miller@apple.com>
2767
2768         WebAssembly: We should only create wrappers for functions that can be exported
2769         https://bugs.webkit.org/show_bug.cgi?id=173088
2770
2771         Reviewed by Saam Barati.
2772
2773         Add quick mode for wasm tests.
2774
2775         * Scripts/run-jsc-stress-tests:
2776
2777 2017-06-08  Darin Adler  <darin@apple.com>
2778
2779         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
2780         https://bugs.webkit.org/show_bug.cgi?id=173106
2781
2782         Reviewed by Sam Weinig.
2783
2784         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
2785         destroyed last.
2786         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
2787         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2788
2789 2017-06-07  Dan Bernstein  <mitz@apple.com>
2790
2791         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
2792         https://bugs.webkit.org/show_bug.cgi?id=173086
2793
2794         Reviewed by Andy Estes.
2795
2796         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2797         (TEST):
2798
2799 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
2800
2801         Add High Sierra support to WebKit tools
2802         https://bugs.webkit.org/show_bug.cgi?id=173080
2803
2804         Rubber-stamped by Daniel Bates.
2805
2806         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
2807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
2808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2810         Added dashboard support.
2811
2812         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2813         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2814         Trigger the right build queues on check-in.
2815
2816         * Scripts/webkitpy/common/system/platforminfo.py:
2817         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2818         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2819         * Scripts/webkitpy/port/mac.py:
2820         * Scripts/webkitpy/port/mac_unittest.py:
2821         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2822         Added cases for Sierra, and updated tests for new baseline search paths.
2823
2824 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
2825
2826         Unreviewed, rolling out r217902.
2827
2828         This change appears to have caused imported/w3c/web-platform-
2829         tests/fetch/api/cors tests to fail on El Capitan.
2830
2831         Reverted changeset:
2832
2833         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
2834         https://bugs.webkit.org/show_bug.cgi?id=172930
2835         http://trac.webkit.org/changeset/217902
2836
2837 2017-06-07  Daniel Bates  <dabates@apple.com>
2838
2839         Teach run-webkit-tests how to run HTTPS Web Platform Tests
2840         https://bugs.webkit.org/show_bug.cgi?id=172930
2841         <rdar://problem/32570201>
2842
2843         Reviewed by Youenn Fablet.
2844
2845         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
2846         that is conditioned on the page being delivered over a secure protocol. One example of such
2847         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
2848
2849         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
2850         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
2851         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
2852
2853         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2854         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
2855         to the Web Platform Tests HTTPS server.
2856         * Scripts/webkitpy/port/base.py:
2857         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
2858         * Scripts/webkitpy/port/driver.py:
2859         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
2860         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
2861         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
2862         indicate that they should be considered private instance variables.
2863         (Driver.is_web_platform_test): Update code for renamed instance variables.
2864         (Driver):
2865         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
2866         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
2867         determine the base URL to use to access the test.
2868         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
2869         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
2870
2871 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
2872
2873         Support removal of authentication data through the Website data store API.
2874         https://bugs.webkit.org/show_bug.cgi?id=171217
2875
2876         Reviewed by Brady Eidson.
2877
2878         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2879         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2880         (WTR::InjectedBundle::didReceiveMessageToPage):
2881         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2882         (WTR::TestRunner::removeAllSessionCredentials):
2883         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
2884         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2885         * WebKitTestRunner/TestController.h:
2886         * WebKitTestRunner/TestInvocation.cpp:
2887         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2888         (WTR::TestInvocation::didRemoveAllSessionCredentials):
2889         * WebKitTestRunner/TestInvocation.h:
2890         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2891         (WTR::TestController::removeAllSessionCredentials):
2892
2893 2017-06-07  Charlie Turner  <cturner@igalia.com>
2894
2895         Add Charlie Turner as contributor
2896         https://bugs.webkit.org/show_bug.cgi?id=173055
2897
2898         Reviewed by Carlos Alberto Lopez Perez.
2899
2900         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
2901         of webkit-patch upload, which reordered some fields and removed a newline.
2902
2903         * Scripts/webkitpy/common/config/contributors.json:
2904
2905 2017-06-06  Chris Dumez  <cdumez@apple.com>
2906
2907         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
2908         https://bugs.webkit.org/show_bug.cgi?id=173033
2909         <rdar://problem/32591099>
2910
2911         Reviewed by Simon Fraser.
2912
2913         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
2914         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
2915
2916         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2917         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
2918         (TestWebKitAPI::didFinishLoadForFrame):
2919         (TestWebKitAPI::setPageLoaderClient):
2920         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
2921         (TestWebKitAPI::TEST):
2922
2923 2017-06-06  Andy Estes  <aestes@apple.com>
2924
2925         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
2926         https://bugs.webkit.org/show_bug.cgi?id=172849
2927         <rdar://problem/32567454>
2928
2929         Reviewed by Darin Adler.
2930
2931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2932         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
2933         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2934         (TestWebKitAPI::TEST):
2935
2936 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
2937
2938         [preload] Conditional support for media preloading and align media `as` values.
2939         https://bugs.webkit.org/show_bug.cgi?id=172501
2940
2941         Reviewed by Dean Jackson.
2942
2943         Turn on media preloading preference for tests.
2944
2945         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
2946         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
2947         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
2948
2949 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2950
2951         webkitpy: Return correct process names from SimulatorProcess
2952         https://bugs.webkit.org/show_bug.cgi?id=172940
2953
2954         Reviewed by Aakash Jain.
2955
2956         * Scripts/webkitpy/port/darwin.py:
2957         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
2958         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
2959         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
2960         * Scripts/webkitpy/port/driver.py:
2961         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
2962         _server_process.name() will not return the correct process name for iOS.
2963         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2964         (Driver._read_block): Ditto.
2965         * Scripts/webkitpy/port/driver_unittest.py:
2966         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
2967         process_name() instead of name().
2968         * Scripts/webkitpy/port/server_process.py:
2969         (ServerProcess._start): Use process_name() instead of name().
2970         (ServerProcess.stop): Ditto.
2971         (ServerProcess.name): Deleted.
2972         * Scripts/webkitpy/port/simulator_process.py:
2973         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2974
2975 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
2976
2977         test-webkitpy: stop forking unsafely from within a spawned process
2978         https://bugs.webkit.org/show_bug.cgi?id=172774
2979
2980         Reviewed by Darin Adler.
2981
2982         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2983         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
2984         it's going to be used.
2985         (Builder.force_build):
2986
2987 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2988
2989         webkitpy: Process crash-logs for iOS devices
2990         https://bugs.webkit.org/show_bug.cgi?id=171976
2991         <rdar://problem/32134551>
2992
2993         Reviewed by David Kilzer.
2994
2995         When running layout tests on an iOS device, crash logs should be processed.
2996         Implement crash log searching and parsing for iOS devices.
2997
2998         * Scripts/webkitpy/common/system/crashlogs.py:
2999         (CrashLogs): Moved process regular expression for Darwin to class variable.
3000         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
3001         (CrashLogs.find_newest_log): Add iOS as a potential platform.
3002         (CrashLogs.find_all_logs): Ditto.
3003         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
3004         Do not assume that a Darwin crash log starts with the process.
3005         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
3006         shared code for parsing Darwin crash logs.
3007         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
3008         object so that crash logs already on the system before testing are not parsed.
3009         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
3010         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
3011         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
3012         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3013         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
3014         * Scripts/webkitpy/common/system/systemhost.py:
3015         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
3016         systems is just the crashlog, use this behavior by default.
3017         * Scripts/webkitpy/common/system/systemhost_mock.py:
3018         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
3019         systems is just the crashlog, use this behavior by default.
3020         * Scripts/webkitpy/port/apple.py:
3021         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
3022         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
3023         the system before testing begins
3024         * Scripts/webkitpy/port/base.py:
3025         (Port._get_crash_log): Pass optional target host when getting crash logs.
3026         * Scripts/webkitpy/port/darwin.py:
3027         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
3028         CrashLogs object.
3029         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
3030         logs to be skipped to CrashLogs object.
3031         * Scripts/webkitpy/port/darwin_testcase.py:
3032         (DarwinTest.test_get_crash_log): Removed unused local function.
3033         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
3034         * Scripts/webkitpy/port/device.py:
3035         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
3036         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
3037         * Scripts/webkitpy/port/driver.py:
3038         (Driver._get_crash_log): Pass optional target host when getting crash logs.
3039         * Scripts/webkitpy/port/gtk.py:
3040         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
3041         * Scripts/webkitpy/port/ios.py: Ditto.
3042         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
3043         to be skipped for each host.
3044         * Scripts/webkitpy/port/ios_device.py:
3045         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
3046         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
3047         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
3048         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
3049         host is specified. Else, search all connected devices for the specified crash-log.
3050         (IOSDevicePort.look_for_new_crash_logs): Deleted.
3051         * Scripts/webkitpy/port/ios_device_unittest.py:
3052         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
3053         (IOSDeviceTest.test_get_crash_log): Ditto.
3054         * Scripts/webkitpy/port/simulator_process.py:
3055         (SimulatorProcess.process_name): Check the provided bundle for the process name.
3056         * Scripts/webkitpy/port/win.py:
3057         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
3058         logs to be skipped to CrashLogs object.
3059         * Scripts/webkitpy/port/wpe.py:
3060         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
3061
3062 2017-06-06  David Kilzer  <ddkilzer@apple.com>
3063
3064         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
3065         <https://webkit.org/b/172804>
3066
3067         Reviewed by Darin Adler.
3068
3069         WTF_ATTRIBUTE_PRINTF() only works outside the current
3070         compilation unit if it's on the declaration, not the
3071         implementation, of a function or class method.
3072
3073         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3074         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3075         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3076         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3077         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
3078         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3079         - Remove redundant CRASH() macro definition.  Use the one from
3080           <wtf/Assertions.h> instead.
3081
3082 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
3083
3084         Move Resource Timing / User Timing from experimental features into main preferences
3085         https://bugs.webkit.org/show_bug.cgi?id=172950
3086
3087         Reviewed by Darin Adler.
3088
3089         * DumpRenderTree/mac/DumpRenderTree.mm:
3090         (enableExperimentalFeatures):
3091         (resetWebPreferencesToConsistentValues):
3092         * DumpRenderTree/win/DumpRenderTree.cpp:
3093         (enableExperimentalFeatures):
3094         (resetWebPreferencesToConsistentValues):
3095         * WebKitTestRunner/TestController.cpp:
3096         (WTR::TestController::resetPreferencesToConsistentValues):
3097         Move out no longer experimental features to the main list.
3098
3099 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3100
3101         [WPE] Add an install-dependencies script
3102         https://bugs.webkit.org/show_bug.cgi?id=172948
3103
3104         Reviewed by Žan Doberšek.
3105
3106         It is based on the gtk/install-dependencies script.
3107         Includes support for Debian based distrubutions, Fedora and Arch.
3108         It has been tested on a minimal Debian 9 chroot.
3109
3110         * wpe/install-dependencies: Added.
3111
3112 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3113
3114         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
3115         https://bugs.webkit.org/show_bug.cgi?id=172891
3116         <rdar://problem/32204540>
3117
3118         Reviewed by Darin Adler.
3119
3120         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
3121         contenteditable. See WebCore ChangeLog for more details.
3122
3123         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3124         (TestWebKitAPI::TEST):
3125
3126 2017-06-05  Daniel Bates  <dabates@apple.com>
3127
3128         webkitpy: Abstract Executive class
3129         https://bugs.webkit.org/show_bug.cgi?id=172928
3130         <rdar://problem/32569531>
3131
3132         Reviewed by Ryosuke Niwa.
3133
3134         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
3135         This will make it straightforward to create additional derived classes that
3136         adhere to the same interface, say for iOS on-device testing.
3137
3138         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
3139         (AbstractExecutive):
3140         (AbstractExecutive.run_and_throw_if_fail):
3141         (AbstractExecutive.cpu_count):
3142         (AbstractExecutive.interpreter_for_script):
3143         (AbstractExecutive.shell_command_for_script):
3144         (AbstractExecutive.kill_process):
3145         (AbstractExecutive.check_running_pid):
3146         (AbstractExecutive.running_pids):
3147         (AbstractExecutive.wait_newest):
3148         (AbstractExecutive.wait_limited):
3149         (AbstractExecutive.interrupt):
3150         (AbstractExecutive.default_error_handler):
3151         (AbstractExecutive.ignore_error):
3152         (AbstractExecutive._stringify_args):
3153         (AbstractExecutive.command_for_printing):
3154         (AbstractExecutive.run_command):
3155         (AbstractExecutive.popen):
3156         (AbstractExecutive.run_in_parallel):
3157         * Scripts/webkitpy/common/system/executive.py:
3158         (Executive):
3159         (Executive.cpu_count):
3160         (Executive.running_pids):
3161         (Executive.kill_all):
3162         (Executive._compute_stdin):
3163         (Executive.interpreter_for_script): Deleted.
3164         (Executive.shell_command_for_script): Deleted.
3165         (Executive.wait_newest): Deleted.
3166         (Executive.wait_limited): Deleted.
3167         (Executive.default_error_handler): Deleted.
3168         (Executive.ignore_error): Deleted.
3169         (Executive.command_for_printing): Deleted.
3170
3171 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
3172
3173         webkitpy: Add iOS to platform
3174         https://bugs.webkit.org/show_bug.cgi?id=172931
3175
3176         Reviewed by Daniel Bates.
3177
3178         * Scripts/webkitpy/common/system/platforminfo.py:
3179         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
3180         (PlatformInfo.is_ios): Added.
3181         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
3182         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3183         (MockPlatformInfo.is_ios): Added.
3184
3185 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3186
3187         [WPE][JHBuild] Switch github repository from git:// to https://
3188         https://bugs.webkit.org/show_bug.cgi?id=172921
3189
3190         Reviewed by Alex Christensen.
3191
3192         * wpe/jhbuild.modules:
3193
3194 2017-06-05  Tim Horton  <timothy_horton@apple.com>
3195
3196         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
3197         https://bugs.webkit.org/show_bug.cgi?id=172887
3198         <rdar://problem/32546061>
3199
3200         Reviewed by Sam Weinig.
3201
3202         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3203         (WTR::UIScriptController::applyAutocorrection):
3204         applyAutocorrection can call its completion handler synchronously,
3205         which makes UIScriptController unhappy (see bug 172884).
3206
3207 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
3208
3209         webkitpy: Add contextmanager to disable logging for a block
3210         https://bugs.webkit.org/show_bug.cgi?id=172876
3211
3212         Reviewed by Daniel Bates.
3213
3214         Add a context manager which will use an OutputCapture object to capture logging
3215         in a block and hold it in a variable.
3216
3217         * Scripts/webkitpy/common/system/outputcapture.py:
3218         (OutputCaptureScope):
3219         (OutputCaptureScope.__init__): Construct with OutputCapture object.
3220         (OutputCaptureScope.__enter__): Begin capturing output. 
3221         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
3222         output and retain the resulting log.
3223         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
3224         (OutputCaptureTest.test_output_capture_scope): Added.
3225
3226 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3227
3228         Cleanup FrameView::autoSizeIfEnabled.
3229         https://bugs.webkit.org/show_bug.cgi?id=172889
3230         <rdar://problem/32550783>
3231
3232         Reviewed by Tim Horton.
3233
3234         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3235         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
3236         (TEST):
3237
3238 2017-06-02  Chris Dumez  <cdumez@apple.com>
3239
3240         ResourceLoadStatistics are not using unique paths during test runs
3241         https://bugs.webkit.org/show_bug.cgi?id=172861
3242         <rdar://problem/32442251>
3243
3244         Reviewed by Darin Adler.
3245
3246         Make sure WebKitTestRunner sets a temporary path for saving resource
3247         load statistics.
3248
3249         * WebKitTestRunner/TestController.cpp:
3250         (WTR::TestController::generateContextConfiguration):
3251
3252 2017-06-02  Brady Eidson  <beidson@apple.com>
3253
3254         Prevent scheme handlers from handling all built-in URL schemes.
3255         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
3256
3257         Reviewed by Andy Estes.
3258
3259         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3260
3261 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
3262
3263         [JSCOnly] Build static jsc.exe on Windows
3264         https://bugs.webkit.org/show_bug.cgi?id=172833
3265
3266         Reviewed by Konstantin Tokarev.
3267
3268         * CMakeLists.txt:
3269         * Scripts/build-jsc:
3270
3271 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3272
3273         Disable ViewportSizeForViewportUnits tests on iOS.
3274         https://bugs.webkit.org/show_bug.cgi?id=172872
3275
3276         Reviewed by Tim Horton.
3277
3278         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
3279
3280 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3281
3282         Allow clients to override viewport size for CSS viewport units.
3283         https://bugs.webkit.org/show_bug.cgi?id=172838
3284         <rdar://problem/32523441>
3285
3286         Reviewed by Tim Horton.
3287
3288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3289         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
3290         (TEST):
3291
3292 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
3293
3294         Get <chrono> out of StdLibExtras.h
3295         https://bugs.webkit.org/show_bug.cgi?id=172744
3296
3297         Reviewed by Zalan Bujtas.
3298
3299         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3300
3301 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
3302
3303         [WPE] Enable SUBTLE_CRYPTO
3304         https://bugs.webkit.org/show_bug.cgi?id=172756
3305
3306         Reviewed by Michael Catanzaro.
3307
3308         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
3309         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
3310         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
3311         exhausting entropy when running the crypto layout tests.
3312
3313 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3314
3315         [GTK] Bump GTK+ and its dependencies in jhbuild
3316         https://bugs.webkit.org/show_bug.cgi?id=171918
3317
3318         Reviewed by Carlos Alberto Lopez Perez.
3319
3320         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3321         (WTR::initializeGtkSettings):
3322         * gtk/jhbuild.modules:
3323         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
3324         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
3325
3326 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3327
3328         [GTK] Bump wayland and weston in jhbuild
3329         https://bugs.webkit.org/show_bug.cgi?id=171921
3330
3331         Reviewed by Carlos Alberto Lopez Perez.
3332
3333         * gtk/jhbuild.modules:
3334         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
3335
3336 2017-06-01  Andy Estes  <aestes@apple.com>
3337
3338         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
3339         https://bugs.webkit.org/show_bug.cgi?id=172828
3340
3341         Reviewed by Beth Dakin.
3342
3343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3344
3345 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
3346
3347         webkitpy: Remove unneeded simulator teardown
3348         https://bugs.webkit.org/show_bug.cgi?id=171891
3349
3350         Reviewed by Aakash Jain.
3351
3352         * Scripts/webkitpy/port/ios_simulator.py:
3353         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
3354         for communication between Python and WebKitTestRunner/DumpRenderTree.
3355
3356 2017-06-01  Keith Miller  <keith_miller@apple.com>
3357
3358         Undo rollout in r217638 with bug fix
3359         https://bugs.webkit.org/show_bug.cgi?id=172824
3360
3361         Unreviewed, reland patch with unused set_state code removed.
3362
3363         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3364         (runThreadMessageTest):
3365         (TEST):
3366
3367 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
3368
3369         webkitpy: Do not send 0 or -1 as a pid to kill_process
3370         https://bugs.webkit.org/show_bug.cgi?id=172818
3371
3372         Reviewed by Darin Adler.
3373
3374         Sending a signal to process 0 will result in all processes in the group receiving 
3375         the signal. Sending a signal to process -1 will result in all non-system processes
3376         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
3377         should consider these cases
3378
3379         * Scripts/webkitpy/common/system/executive.py:
3380         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
3381         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
3382         never be running, although os.kill may succeed.
3383         * Scripts/webkitpy/port/simulator_process.py:
3384         (SimulatorProcess.stop): Do not kill process if it is undefined.
3385
3386 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
3387
3388         JSC EWS bot does not run on WTF only patches
3389         https://bugs.webkit.org/show_bug.cgi?id=172777
3390         rdar://problem/32495975
3391
3392         Reviewed by Aakash Jain.
3393
3394         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
3395         (CheckPatchRelevance): Add a missing comma.
3396
3397 2017-05-31  Commit Queue  <commit-queue@webkit.org>
3398
3399         Unreviewed, rolling out r217611 and r217631.
3400         https://bugs.webkit.org/show_bug.cgi?id=172785
3401
3402         "caused wasm-hashset-many.html to become flaky." (Requested by
3403         keith_miller on #webkit).
3404
3405         Reverted changesets:
3406
3407         "Reland r216808, underlying lldb bug has been fixed."
3408         https://bugs.webkit.org/show_bug.cgi?id=172759
3409         http://trac.webkit.org/changeset/217611
3410
3411         "Use dispatch queues for mach exceptions"
3412         https://bugs.webkit.org/show_bug.cgi?id=172775
3413         http://trac.webkit.org/changeset/217631
3414
3415 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
3416
3417         EWS bots should reboot themselves more frequently
3418         https://bugs.webkit.org/show_bug.cgi?id=172402
3419
3420         Reviewed by Alexey Proskuryakov.
3421
3422         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
3423
3424         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
3425
3426 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
3427
3428         Reallocate hardware for iOS bots.
3429         https://bugs.webkit.org/show_bug.cgi?id=172657
3430
3431         Reviewed by Alexey Proskuryakov.
3432
3433         * BuildSlaveSupport/build.webkit.org-config/config.json:
3434
3435 2017-05-31  Andy Estes  <aestes@apple.com>
3436
3437         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
3438         https://bugs.webkit.org/show_bug.cgi?id=172366
3439
3440         Reviewed by Daniel Bates.
3441
3442         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3443
3444 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
3445
3446         Unreviewed, add Jiewen Tan as a reviewer
3447
3448         * Scripts/webkitpy/common/config/contributors.json:
3449
3450 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
3451
3452         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
3453         https://bugs.webkit.org/show_bug.cgi?id=172770
3454
3455         Reviewed by Michael Catanzaro.
3456
3457         * MiniBrowser/gtk/BrowserWindow.c:
3458         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
3459         which caused the body of the if-clause to be accidentally empty.
3460
3461 2017-05-31  Keith Miller  <keith_miller@apple.com>
3462
3463         Reland r216808, underlying lldb bug has been fixed.
3464         https://bugs.webkit.org/show_bug.cgi?id=172759
3465
3466         Unreviewed, relanding old patch. See: rdar://problem/31183352
3467
3468         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3469         (runThreadMessageTest):
3470         (TEST):
3471
3472 2017-05-31  Matt Lewis  <jlewis3@apple.com>
3473
3474         Unreviewed, rolling out r217603.
3475
3476         This patch broke the internal builds.
3477
3478         Reverted changeset:
3479
3480         "Get <chrono> out of StdLibExtras.h"
3481         https://bugs.webkit.org/show_bug.cgi?id=172744
3482         http://trac.webkit.org/changeset/217603
3483
3484 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
3485
3486         Make ResourceLoadStatistics testing more reliable
3487         https://bugs.webkit.org/show_bug.cgi?id=172730
3488         <rdar://problem/32028373>
3489
3490         Reviewed by Andy Estes.
3491
3492         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
3493         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
3494
3495         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3496         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3497
3498 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3499
3500         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
3501         https://bugs.webkit.org/show_bug.cgi?id=172757
3502
3503         Reviewed by Xabier Rodriguez-Calvar.
3504
3505         When needed, add the jhbuild wrapper at the beginning of the array
3506         that will be invoked to execute the run-jsc-stress-test or testapi
3507         commands.
3508
3509         * Scripts/run-javascriptcore-tests:
3510         (runJSCStressTests):
3511         * Scripts/webkitdirs.pm:
3512         (shouldUseJhbuild):
3513
3514 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
3515
3516         Get <chrono> out of StdLibExtras.h
3517         https://bugs.webkit.org/show_bug.cgi?id=172744
3518
3519         Reviewed by Saam Barati.
3520
3521         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3522
3523 2017-05-30  Tim Horton  <timothy_horton@apple.com>
3524
3525         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
3526         https://bugs.webkit.org/show_bug.cgi?id=172735
3527         <rdar://problem/32015977>
3528
3529         Reviewed by Enrica Casucci.
3530
3531         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3532         (WTR::UIScriptController::applyAutocorrection):
3533         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3534         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3535         (WTR::UIScriptController::applyAutocorrection):
3536         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3537         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3538         (WTR::UIScriptController::applyAutocorrection):
3539         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
3540         because I don't know how to tap the button in the autocorrection bar from a test.
3541
3542 2017-05-30  Daniel Bates  <dabates@apple.com>
3543
3544         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
3545         https://bugs.webkit.org/show_bug.cgi?id=172671
3546
3547         Reviewed by Alex Christensen.
3548
3549         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
3550         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
3551
3552         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
3553         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
3554         to trigger a navigation to test it.
3555         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
3556         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
3557
3558 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
3559
3560         webkitpy: Start servers before setting-up for testing
3561         https://bugs.webkit.org/show_bug.cgi?id=172176
3562         <rdar://problem/32225538>
3563
3564         Reviewed by Alexey Proskuryakov.
3565
3566         On-device testing requires that servers are started before ports set-up their
3567         test environments.
3568
3569         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3570         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
3571         Servers are unconditionally stopped on exit.
3572         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
3573         Manager now stops servers.
3574         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
3575         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
3576         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3577         (Manager.__init__): Delay construction of the test runner until we can determine
3578         if servers need to be started.
3579         (Manager.run): Determine if servers need to be started and construct the test runner.
3580         Shut servers down when the test run is finished.
3581         (Manager._run_tests): Move the determination of servers to run into Manager.run.
3582         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3583         (is_wpt_server_running): Server is not running if no config is found.
3584         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3585         (PyWebSocket.is_running): Check if this WebSocket server is running.
3586         * Scripts/webkitpy/port/base.py:
3587         (Port.__init__): Define secure WebSocket server.
3588         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
3589
3590 2017-05-30  Daniel Bates  <dabates@apple.com>
3591
3592         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
3593         https://bugs.webkit.org/show_bug.cgi?id=172603
3594         <rdar://problem/32471306>
3595
3596         Reviewed by Brady Eidson.
3597
3598         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
3599         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
3600         unloading is initiated for a page that registered a onbeforeunload handler.
3601
3602         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
3603         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
3604         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
3605
3606         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
3607         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
3608         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
3609         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
3610
3611         * MiniBrowser/mac/WK2BrowserWindowController.m:
3612         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3613         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
3614         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
3615         (sawDialog):
3616         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3617         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3618         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3619
3620 2017-05-30  Alex Christensen  <achristensen@webkit.org>
3621