01bf7578e8e9367e0a1325ac81907bf0c6a633f8
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
2
3         Unreviewed. Update my email.
4
5         * Scripts/webkitpy/common/config/committers.py:
6
7 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
8
9         Update pywebsocket to 0.7.6 from 0.7.4
10         https://bugs.webkit.org/show_bug.cgi?id=88975
11
12         Reviewed by Kent Tamura.
13
14         This new version of pywebsocket introduce following features.
15          - Allow handlers to send a close frame with empty body in response of
16              a client initiated closing handshake
17          - Implement perframe compression extension
18          - Support client certificate authentication
19
20         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
21         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
22         (_create_control_frame):
23         (Stream._receive_frame):
24         (Stream.send_message):
25         (Stream.receive_message):
26         (Stream._send_closing_handshake):
27         (Stream.close_connection):
28         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
29         (ExtensionParsingException):
30         (ExtensionParsingException.__init__):
31         (_parse_extension_param):
32         (_parse_extension):
33         (parse_extensions):
34         (format_extension):
35         (format_extensions):
36         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
37         (_parse_compression_method):
38         (_create_accepted_method_desc):
39         (PerFrameCompressionExtensionProcessor):
40         (PerFrameCompressionExtensionProcessor.__init__):
41         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
42         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
43         (PerFrameCompressionExtensionProcessor.get_extension_response):
44         (PerFrameCompressionExtensionProcessor.setup_stream_options):
45         (PerFrameCompressionExtensionProcessor.get_compression_processor):
46         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
47         (parse_token_list):
48         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
49         (Handshaker._parse_extensions):
50         (Handshaker._send_handshake):
51         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
52         (WebSocketServer._create_sockets):
53         (_get_logger_from_class):
54         (_configure_logging):
55         (_build_option_parser):
56         (_main.if):
57         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
58         (RepeatedXorMasker.mask):
59
60 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
61
62         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
63
64         Reviewed by Noam Rosenthal.
65
66         * qmake/mkspecs/features/features.prf:
67
68 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
69
70         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
71         https://bugs.webkit.org/show_bug.cgi?id=88399
72
73         Reviewed by Kenneth Rohde Christiansen.
74
75         Update initialization of WKPageLoaderClient.
76
77         * MiniBrowser/mac/BrowserWindowController.m:
78         (-[BrowserWindowController awakeFromNib]):
79         * WebKitTestRunner/TestController.cpp:
80         (WTR::TestController::initialize):
81
82 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
83
84         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
85         https://bugs.webkit.org/show_bug.cgi?id=84577
86
87         Reviewed by Ryosuke Niwa.
88
89         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
90         LayoutTestController.
91
92         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
93         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
94
95 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
96
97         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
98         https://bugs.webkit.org/show_bug.cgi?id=88340
99
100         Reviewed by Kenneth Rohde Christiansen.
101
102         Update initialization of WKPageLoaderClient.
103
104         * MiniBrowser/mac/BrowserWindowController.m:
105         (-[BrowserWindowController awakeFromNib]):
106         * WebKitTestRunner/TestController.cpp:
107         (WTR::TestController::initialize):
108
109 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
110
111         Unreviewed, rolling out r120268.
112         http://trac.webkit.org/changeset/120268
113         https://bugs.webkit.org/show_bug.cgi?id=89060
114
115         WebCompositor::setPerTilePaintingEnabled hits an assertion in
116         DEBUG (Requested by dominicc|work on #webkit).
117
118         * DumpRenderTree/chromium/WebPreferences.cpp:
119         (WebPreferences::applyTo):
120
121 2012-06-13  Tim Horton  <timothy_horton@apple.com>
122
123         REGRESSION (r120252): run-webkit-tests on Mac fails
124         https://bugs.webkit.org/show_bug.cgi?id=89057
125
126         Reviewed by Dan Bernstein.
127
128         get_option will happily return None (the default only kicks in if
129         the option is actually *not set*). We should instead check get_option's
130         return value and default to "x86_64" architecture ourselves.
131
132         * Scripts/webkitpy/layout_tests/port/mac.py:
133         (MacPort.__init__):
134
135 2012-06-13  Ian Vollick  <vollick@chromium.org>
136
137         [chromium] Certain settings in CCSettings could be global
138         https://bugs.webkit.org/show_bug.cgi?id=88384
139
140         Reviewed by James Robinson.
141
142         * DumpRenderTree/chromium/WebPreferences.cpp:
143         (WebPreferences::applyTo):
144
145 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
146
147         new-run-webkit-tests does not support --32-bit like ORWT did
148         https://bugs.webkit.org/show_bug.cgi?id=71634
149
150         Reviewed by Ojan Vafai.
151
152         This patch adds support for 32-bit apple mac builds, adding the
153         --32-bit flag for compatibility with ORWT and fixing the port
154         architecture() definition to actually return the correct values.
155
156         * Scripts/webkitpy/layout_tests/port/apple.py:
157         (ApplePort._generate_all_test_configurations):
158         * Scripts/webkitpy/layout_tests/port/factory.py:
159         (port_options):
160         * Scripts/webkitpy/layout_tests/port/mac.py:
161         (MacPort):
162         (MacPort.__init__):
163         (MacPort._build_driver_flags):
164         (MacPort.setup_environ_for_server):
165         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
166         (test_sample_process_throws_exception):
167         (test_32bit):
168         (test_32bit.run_script):
169         (test_64bit):
170         (test_64bit.run_script):
171         * Scripts/webkitpy/layout_tests/port/webkit.py:
172         (WebKitPort._build_driver):
173         (WebKitPort._build_driver_flags):
174         * Scripts/webkitpy/layout_tests/port/win.py:
175         (WinPort):
176
177 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
178
179         Remove webkitpy code to support legacy test_expectations.txt files
180         https://bugs.webkit.org/show_bug.cgi?id=89038
181
182         Reviewed by Dirk Pranke.
183
184         * Scripts/webkitpy/layout_tests/port/base.py:
185         (Port.path_to_test_expectations_file):
186         (Port.expectations_dict):
187         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
188         (PortTest.test_uses_test_expectations_file):
189         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
190         (WebKitPortTest.test_path_to_test_expectations_file):
191         (test_test_expectations):
192         * Scripts/webkitpy/style/checker.py:
193         (CheckerDispatcher.should_skip_without_warning):
194         (CheckerDispatcher._create_checker):
195         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
196         (TestExpectationsTestCase._expect_port_for_expectations_path):
197         * Scripts/webkitpy/tool/steps/commit.py:
198         (Commit._check_test_expectations):
199         * Scripts/webkitpy/tool/steps/commit_unittest.py:
200         (CommitTest.test_check_test_expectations):
201
202 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
203
204         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
205         https://bugs.webkit.org/show_bug.cgi?id=88948
206
207         Reviewed by Ojan Vafai.
208
209         In the final patch of this run, we remove the
210         test_expectations() and test_expectation_overrides() methods
211         from the Port class - callers must now use just
212         expectations_dict().
213
214         Note that support for the cascade in new-run-webkit-tests is
215         complete but only Chromium uses it; webkit-patch
216         rebaseline-expectations still does not support updating entries
217         in any file other than the first expectations file, however.
218
219         * Scripts/webkitpy/layout_tests/port/base.py:
220         (Port.path_to_test_expectations_file):
221         (Port.uses_test_expectations_file):
222         (Port.expectations_files):
223         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
224         (PortTest.test_additional_expectations):
225         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
226         (ChromiumPortTest.test_expectations_files):
227         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
228         (TestGoogleChromePort.test_get_google_chrome_port):
229         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
230         (test_test_expectations):
231         (test_legacy_test_expectations):
232
233 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
234
235         nrwt: implement the actual cascade of TestExpectations
236         https://bugs.webkit.org/show_bug.cgi?id=88947
237
238         Reviewed by Ojan Vafai.
239
240         This change implements the actual cascade by removing the
241         concept of 'overrides' from the TestExpectations object and
242         parsing each file separately.
243
244         There is an actual semantic change in this patch, in that
245         setting an expectation on a directory in one file will override
246         the expectations on any individual tests set in prior files. The
247         test_overrides__directory() unit test verifies this.
248
249         Otherwise, this patch mostly consists of deleting code :).
250
251         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
252         (TestExpectationsModel.__init__):
253         (TestExpectationsModel.add_expectation_line):
254         (TestExpectationsModel._add_test):
255         (TestExpectationsModel._already_seen_better_match):
256         (TestExpectations.__init__):
257         (TestExpectations._add_expectations):
258         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
259         (test_overrides__directory):
260
261 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
262
263         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
264         https://bugs.webkit.org/show_bug.cgi?id=88946
265
266         Reviewed by Ojan Vafai.
267
268         In preparation for fully supporting cascading expectations files
269         and removing the 'overrides' concept.
270
271         There should be no functional changes in this patch.
272
273         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
274         (ManagerTest.test_update_summary_with_result):
275         (ResultSummaryTest.get_result_summary):
276         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
277         (TestExpectations.__init__):
278         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
279         (parse_exp):
280         (SkippedTests.check):
281         (RemoveConfigurationsTest.test_remove):
282         (test_remove_line):
283         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
284         (LintTest.test_all_configurations.FakePort.__init__):
285         (LintTest.test_all_configurations.FakePort.expectations_dict):
286         (LintTest.test_lint_test_files__errors):
287         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
288         (test_overrides_are_included_correctly):
289
290 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
291
292         webkitpy: rework the TestExpectations style checker in preparation for the cascade
293         https://bugs.webkit.org/show_bug.cgi?id=88945
294
295         Reviewed by Ojan Vafai.
296
297         This patch changes the style checker to call the
298         TestExpectations parser directly and be oblivious as to what the
299         port's actual expectations are.
300
301         * Scripts/webkitpy/style/checkers/test_expectations.py:
302         (TestExpectationsChecker.__init__):
303         (TestExpectationsChecker.check_test_expectations):
304
305 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
306
307         nrwt: restructure the port classes to handle multiple expectations files
308         https://bugs.webkit.org/show_bug.cgi?id=88944
309
310         Reviewed by Ojan Vafai.
311
312         This patch restructures the Port classes so that each port
313         returns a list of TestExpectations files to be used (in a new, public,
314         expectations_files() method), and the base implementation rolls them
315         up into the ordered expectations_dict(), which becomes a public
316         method.
317
318         port.path_to_test_expectations_file(), port.test_expectations(),
319         and port.test_expectations_overrides() are then reimplemented as
320         wrappers around port.expectations_dict().
321         port.test_expectations() and port.test_expectations_overrides()
322         will eventually be removed when the cascade is fully completed,
323         and port.path_to_test_expectations_file() will be removed when
324         the rebaselining tool supports the cascade
325         (expectations_files() may also become private at that point).
326
327         There should be no functional changes in this patch, but a bunch
328         of custom logic gets deleted!
329
330         * Scripts/webkitpy/layout_tests/port/base.py:
331         (Port.expectations_dict):
332         (Port):
333         (Port.expectations_files):
334         (Port.test_expectations):
335         (Port.test_expectations_overrides):
336         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
337         (PortTest.test_additional_expectations):
338         (PortTest.test_uses_test_expectations_file):
339         * Scripts/webkitpy/layout_tests/port/chromium.py:
340         (ChromiumPort.all_baseline_variants):
341         (ChromiumPort.expectations_files):
342         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
343         (ChromiumPortTest.test_overrides_and_builder_names):
344         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
345         (_expectations_files):
346         (GoogleChromeLinux32Port.expectations_files):
347         (GoogleChromeLinux64Port.expectations_files):
348         (GoogleChromeMacPort.expectations_files):
349         (GoogleChromeWinPort.expectations_files):
350         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
351         (TestGoogleChromePort._verify_expectations_overrides):
352         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
353         (PortTestCase.test_expectations_ordering):
354         * Scripts/webkitpy/layout_tests/port/webkit.py:
355         (WebKitPort._skipped_file_search_paths):
356         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
357         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
358         (test_rebaseline_updates_expectations_file):
359         (test_rebaseline_does_not_include_overrides):
360         (test_rebaseline_expectations):
361         (test_overrides_are_included_correctly):
362
363 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
364
365         [WinCairo] Update URL of WinCairoRequirements.zip download.
366         https://bugs.webkit.org/show_bug.cgi?id=89009
367
368         Reviewed by Martin Robinson.
369
370         * Tools/Scripts/update-webkit-dependency: Put fallback code
371         to download a "last update" time from servers that don't properly
372         report Last-Modified in their HTTP header.
373         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
374         for the WinCairo build requirements bundle.
375
376 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
377
378         nrwt: preliminary cleanup before supporting cascading expectations files
379         https://bugs.webkit.org/show_bug.cgi?id=88942
380
381         Reviewed by Ojan Vafai.
382
383         This change just prepares the TestExpectations parser to get filenames
384         along with the expectations, and improves the warning messages so that
385         they contain the filenames along with the line numbers.
386
387         There should be no functional changes in this patch.
388
389         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
390         (TestExpectationEditorTests.make_parsed_expectation_lines):
391         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
392         (TestExpectationParser.parse):
393         (TestExpectationParser.expectation_for_skipped_test):
394         (TestExpectationParser._tokenize):
395         (TestExpectationParser._tokenize_list):
396         (TestExpectationLine):
397         (TestExpectationsModel.__init__):
398         (TestExpectationsModel._already_seen_better_match):
399         (TestExpectations.__init__):
400         (TestExpectations._shorten_filename):
401         (TestExpectations._report_warnings):
402         (TestExpectations._add_skipped_tests):
403         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
404         (TestExpectationParserTests._tokenize):
405         (TestExpectationParserTests.test_tokenize_blank):
406         (TestExpectationParserTests.test_tokenize_missing_colon):
407         (TestExpectationParserTests.test_tokenize_extra_colon):
408         (TestExpectationParserTests.test_tokenize_empty_comment):
409         (TestExpectationParserTests.test_tokenize_comment):
410         (TestExpectationParserTests.test_tokenize_missing_equal):
411         (TestExpectationParserTests.test_tokenize_extra_equal):
412         (TestExpectationParserTests.test_tokenize_valid):
413         (TestExpectationParserTests.test_tokenize_valid_with_comment):
414         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
415         (TestExpectationParserTests.test_parse_empty_string):
416         (TestExpectationSerializerTests._tokenize):
417         (TestExpectationSerializerTests.assert_round_trip):
418         (TestExpectationSerializerTests.assert_list_round_trip):
419         * Scripts/webkitpy/tool/servers/gardeningserver.py:
420         (GardeningExpectationsUpdater.update_expectations):
421
422 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
423
424         [Gtk] Enable link prefetch support in the developer builds
425         https://bugs.webkit.org/show_bug.cgi?id=89011
426
427         Reviewed by Martin Robinson.
428
429         Enable the link prefetch support for Gtk by default in developer
430         builds.
431
432         * Scripts/webkitperl/FeatureList.pm:
433
434 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
435
436         Update buildbot master in autoinstaller to match build.webkit.org
437         https://bugs.webkit.org/show_bug.cgi?id=88992
438
439         Reviewed by Adam Barth.
440
441         * Scripts/webkitpy/thirdparty/__init__.py:
442         (AutoinstallImportHook._install_buildbot):
443
444 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
445
446         Unreviewed, rolling out r120209.
447         http://trac.webkit.org/changeset/120209
448         https://bugs.webkit.org/show_bug.cgi?id=89007
449
450         Broke the WebKit2 mac build. (Requested by andersca on
451         #webkit).
452
453         * MiniBrowser/mac/BrowserWindowController.m:
454         (-[BrowserWindowController awakeFromNib]):
455         * WebKitTestRunner/TestController.cpp:
456         (WTR::TestController::initialize):
457
458 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
459
460         check-webkit-style needs to respect Qt API coding style
461         https://bugs.webkit.org/show_bug.cgi?id=88995
462
463         Reviewed by Csaba Osztrogonác.
464
465         Add -whitespace/declaration exception to Qt API files.
466
467         * Scripts/webkitpy/style/checker.py:
468
469 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
470
471         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
472         https://bugs.webkit.org/show_bug.cgi?id=88340
473
474         Reviewed by Kenneth Rohde Christiansen.
475
476         Update initialization of WKPageLoaderClient.
477
478         * MiniBrowser/mac/BrowserWindowController.m:
479         (-[BrowserWindowController awakeFromNib]):
480         * WebKitTestRunner/TestController.cpp:
481         (WTR::TestController::initialize):
482
483 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
484
485         [Qt] Handle multiple held buttons in touch mocking.
486         https://bugs.webkit.org/show_bug.cgi?id=88865
487
488         Reviewed by Kenneth Rohde Christiansen.
489
490         Add handling for multiple held mouse-buttons in the appropiate places.
491         To do this last-pos and start-pos are now also read from the last recorded
492         touch-point instead from object-global variables.
493
494         * MiniBrowser/qt/MiniBrowserApplication.cpp:
495         (MiniBrowserApplication::notify):
496         (MiniBrowserApplication::updateTouchPoint):
497         * MiniBrowser/qt/MiniBrowserApplication.h:
498         (MiniBrowserApplication):
499
500 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
501
502         [Qt] Make it possible to disable -Werror in production builds
503
504         Reviewed by Tor Arne Vestbø.
505
506         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
507         something qt5.git's qtwebkit.pri will soon do.
508
509         * qmake/mkspecs/features/unix/default_post.prf:
510
511 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
512
513         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
514         https://bugs.webkit.org/show_bug.cgi?id=85790
515
516         Reviewed by Gustavo Noronha Silva.
517
518         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
519         code in webkitdirs.pm.
520
521         * Scripts/webkitdirs.pm:
522         (jhbuildConfigurationChanged):
523         (saveJhbuildMd5):
524         (cleanJhbuild):
525         (buildAutotoolsProject):
526         (generateBuildSystemFromCMakeProject):
527
528 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
529
530         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
531         https://bugs.webkit.org/show_bug.cgi?id=88763
532
533         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
534         extension.
535
536         Reviewed by Simon Hausmann.
537
538         * qmake/config.tests/libzlib: Added.
539         * qmake/config.tests/libzlib/libzlib.cpp: Added.
540         (main):
541         * qmake/config.tests/libzlib/libzlib.pro: Added.
542         * qmake/mkspecs/features/features.prf:
543         * qmake/sync.profile:
544
545 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
546
547         [BlackBerry] Enable MEDIA_STREAM by default
548         https://bugs.webkit.org/show_bug.cgi?id=88849
549
550         Reviewed by Antonio Gomes.
551
552         * Scripts/webkitperl/FeatureList.pm:
553
554 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
555
556         Prevent stderr output from messing up detection of build path
557
558         https://bugs.webkit.org/show_bug.cgi?id=88075
559
560         Warnings such as 'perl: warning: Setting locale failed' will otherwise
561         end up as the build path when calling out to webkit-build-directory.
562
563         Reviewed by Ojan Vafai.
564
565         * Scripts/webkitpy/layout_tests/port/config.py:
566         (Config.build_directory):
567
568 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
569
570         Update the builder name for Apple Lion builders.
571
572         * Scripts/webkitpy/layout_tests/port/builders.py:
573
574 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
575
576         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
577         https://bugs.webkit.org/show_bug.cgi?id=88874
578
579         Reviewed by Simon Hausmann.
580
581         Rename main.cpp in QtTestBrowser because on Windows
582         it conflicts with main.cpp from DumpRenderTree.
583
584         * QtTestBrowser/QtTestBrowser.pro:
585         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
586         (launcherMain):
587         (LauncherApplication):
588         (LauncherApplication::urls):
589         (LauncherApplication::isRobotized):
590         (LauncherApplication::robotTimeout):
591         (LauncherApplication::robotExtraTime):
592         (LauncherApplication::applyDefaultSettings):
593         (LauncherApplication::LauncherApplication):
594         (requiresGraphicsView):
595         (LauncherApplication::handleUserOptions):
596         (main):
597
598 2012-06-12  Lucas Forschler  <lforschler@apple.com>
599
600         Wrap bot types inside ().
601         https://bugs.webkit.org/show_bug.cgi?id=88893
602         
603         Reviewed by Stephanie Lewis.
604
605         * BuildSlaveSupport/build.webkit.org-config/config.json:
606
607 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
608
609         [soup] Prevent setting or editing httpOnly cookies from JavaScript
610         https://bugs.webkit.org/show_bug.cgi?id=88760
611
612         Reviewed by Gustavo Noronha Silva.
613
614         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
615         to v2.33.2 for both GTK and EFL ports.
616
617         * efl/jhbuild.modules:
618         * gtk/jhbuild.modules:
619
620 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
621
622         [EFL] Enable SHADOW_DOM flag
623         https://bugs.webkit.org/show_bug.cgi?id=87732
624
625         Reviewed by Kentaro Hara.
626
627         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
628         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
629         SHADOW_DOM by default in DRT.
630         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
631         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
632         Chromium and Mac ports.
633         (drtViewAdd):
634         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
635         at compile time for EFL port.
636
637 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
638
639         WinLauncher should show loading errors
640         https://bugs.webkit.org/show_bug.cgi?id=80760
641
642         Reviewed by Brent Fulgham.
643
644         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
645         (WinLauncherWebHost::didFailProvisionalLoadWithError):
646         * WinLauncher/WinLauncher.h:
647         (WinLauncherWebHost::didFailProvisionalLoadWithError):
648         (WinLauncherWebHost):
649
650 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
651
652         [EFL][WK2] Add MiniBrowserEfl.
653         https://bugs.webkit.org/show_bug.cgi?id=61850
654
655         Reviewed by Chang Shu.
656
657         Implement MiniBrowser for EFL.
658
659         * CMakeLists.txt:
660         * MiniBrowser/efl/CMakeLists.txt: Added.
661         * MiniBrowser/efl/main.c: Added.
662         (_MiniBrowser):
663         (main_signal_exit):
664         (on_ecore_evas_resize):
665         (browserCreate):
666         (main):
667
668 2012-06-12  Helder Correia  <helder.correia@nokia.com>
669
670         Unreviewed. Update my email address in committers.py.
671
672         * Scripts/webkitpy/common/config/committers.py:
673
674 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
675
676         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
677         https://bugs.webkit.org/show_bug.cgi?id=84707
678
679         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
680         use_lib64 variable is preconfigured to True by jhbuild.
681
682         Reviewed by Dirk Pranke.
683
684         * efl/jhbuildrc:
685
686 2012-06-12  Dana Jansens  <danakj@chromium.org>
687
688         Add zlieber@chromium.org to contributors list
689         https://bugs.webkit.org/show_bug.cgi?id=88904
690
691         Unreviewed.
692
693         * Scripts/webkitpy/common/config/committers.py:
694
695 2012-06-12  Lucas Forschler  <lforschler@apple.com>
696
697         Rename Apple bots to a standard convention.
698         https://bugs.webkit.org/show_bug.cgi?id=88893
699         
700         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
701
702         Reviewed by Simon Fraser.
703
704         * BuildSlaveSupport/build.webkit.org-config/config.json:
705
706 2012-06-12  Mike West  <mkwst@chromium.org>
707
708         Make document.documentURI readonly from JavaScript
709         https://bugs.webkit.org/show_bug.cgi?id=65187
710
711         Reviewed by Alexey Proskuryakov.
712
713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
714         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
715         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
716         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
717         (TestWebKitAPI):
718         (TestWebKitAPI::TEST):
719
720 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
721
722         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
723         https://bugs.webkit.org/show_bug.cgi?id=88715
724
725         Reviewed by Noam Rosenthal.
726
727         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
728
729         * Scripts/webkitperl/FeatureList.pm:
730
731 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
732
733         [Qt] Fix -Werror for the buildbots
734         https://bugs.webkit.org/show_bug.cgi?id=88223
735
736         Rubber-stamped by Tor Arne Vestbø.
737
738         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
739
740         * qmake/mkspecs/features/unix/default_post.prf:
741
742 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
743
744         [REGRESSION][WTR] Build fail with werror after r120054
745         https://bugs.webkit.org/show_bug.cgi?id=88862
746
747         Reviewed by Csaba Osztrogonác.
748
749         Some static helpers become unused after counterValueForElementById
750         has moved to Internals. Let's remove them.
751
752         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
753         (WTR):
754
755 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
756
757         [Qt] Slave losts cause build break on bots
758         https://bugs.webkit.org/show_bug.cgi?id=38980
759
760         Minor fix after r59261.
761
762         Reviewed by Tor Arne Vestbø.
763
764         * Scripts/build-webkit:
765         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
766
767 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
768
769         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
770         https://bugs.webkit.org/show_bug.cgi?id=84406
771
772         Reviewed by Hajime Morita.
773
774         Move the counterValueForElementById from LayoutTestCotroller to Internals and
775         remove the old platform specific implementations as it exclusively tests WebCore functionality.
776
777         * DumpRenderTree/LayoutTestController.cpp:
778         (LayoutTestController::staticFunctions):
779         * DumpRenderTree/LayoutTestController.h:
780         (LayoutTestController):
781         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
782         * DumpRenderTree/chromium/LayoutTestController.cpp:
783         (LayoutTestController::LayoutTestController):
784         (LayoutTestController::setPOSIXLocale):
785         * DumpRenderTree/chromium/LayoutTestController.h:
786         (LayoutTestController):
787         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
788         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
789         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
790         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
791         * DumpRenderTree/qt/LayoutTestControllerQt.h:
792         (LayoutTestController):
793         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
794         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
795         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
796         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
797         (WTR):
798         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
799         (LayoutTestController):
800
801 2012-06-11  Hans Wennborg  <hans@chromium.org>
802
803         Speech JavaScript API: Make SpeechRecognitionError an Event
804         https://bugs.webkit.org/show_bug.cgi?id=88784
805
806         Reviewed by Adam Barth.
807
808         Make it possible to have MockWebSpeechRecognizer fire error events.
809
810         * DumpRenderTree/chromium/LayoutTestController.cpp:
811         (LayoutTestController::LayoutTestController):
812         (LayoutTestController::setMockSpeechRecognitionError):
813         * DumpRenderTree/chromium/LayoutTestController.h:
814         (LayoutTestController):
815         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
816         (WebKit):
817         (ErrorTask):
818         (WebKit::ErrorTask::ErrorTask):
819         (MockWebSpeechRecognizer::addMockResult):
820         (MockWebSpeechRecognizer::setError):
821         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
822         (MockWebSpeechRecognizer):
823
824 2012-06-11  Ojan Vafai  <ojan@chromium.org>
825
826         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
827         https://bugs.webkit.org/show_bug.cgi?id=88836
828
829         Reviewed by Dirk Pranke.
830
831         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
832         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
833
834 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
835
836         [EFL] Remove CMakeCache.txt before building
837         https://bugs.webkit.org/show_bug.cgi?id=88717
838
839         Reviewed by Antonio Gomes.
840
841         Remove CMake cache file before every build to avoid using outdated
842         build flags when new features get enabled. This will avoid unexpected
843         failures on the bots due to outdated build flags.
844
845         * Scripts/webkitdirs.pm:
846         (generateBuildSystemFromCMakeProject):
847
848 2012-06-11  Vincent Scheib  <scheib@chromium.org>
849
850         Add new Pointer Lock spec attribute webkitPointerLockElement.
851         https://bugs.webkit.org/show_bug.cgi?id=88799
852
853         Reviewed by Dimitri Glazkov.
854
855         Part of a series of refactoring changes to update pointer lock API to
856         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
857
858         New attribute webkitPointerLockElement added. Follow up patches
859         will remove the previous isLocked attribute. Tests updated to use
860         the new attribute.
861
862         WebViewHost logic required modification to correctly repond to
863         a lock, unlock, pointerLockElement call series. Specifically,
864         unlocking must be queued after a lock command is issued always
865         as the lock state may not be set yet with a lock request in flight.
866
867         * DumpRenderTree/chromium/WebViewHost.cpp:
868         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
869         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
870
871 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
872
873         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
874         https://bugs.webkit.org/show_bug.cgi?id=88804
875
876         Reviewed by Tony Chang.
877
878         Protect box-decoration-break behind a feature flag enabled by default.
879
880         * Scripts/webkitperl/FeatureList.pm:
881         * qmake/mkspecs/features/features.pri:
882
883 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
884
885         [CMAKE][EFL] Remove duplicated executable output path
886         https://bugs.webkit.org/show_bug.cgi?id=88765
887
888         Reviewed by Daniel Bates.
889
890         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
891         need to define again because it is already defined in top-level CMake file.
892
893         * DumpRenderTree/efl/CMakeLists.txt:
894         * EWebLauncher/CMakeLists.txt:
895
896 2012-06-11  Ojan Vafai  <ojan@chromium.org>
897
898         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
899         https://bugs.webkit.org/show_bug.cgi?id=88816
900
901         Reviewed by Dirk Pranke.
902
903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
904         Expose a way to clear AsynchronousCaches.
905         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
907         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
908
909 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
910
911         nrwt exits early too frequently
912         https://bugs.webkit.org/show_bug.cgi?id=73843
913
914         Reviewed by Ryosuke Niwa.
915
916         Change the defaults for new-run-webkit-tests for both
917         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
918         to zero (i.e., we will never exit early by default).
919
920         If people want their buildbots to exit early it is their
921         responsibility to update their buildbot configs appropriately.
922
923         Note that we have tests that ensure that these flags work for
924         non-zero numbers, but we don't have tests that either test the
925         default or ensure that zero means "run all of the tests". I
926         think that's okay but can add tests if others disagree.
927
928         Also note that it looks like no changes on the build.webkit.org
929         master.cfg are necessary; all of the bots seem to be using the
930         RunWebKitTests wrapper which is already setting the flags. There
931         is a NewRunWebKitTests wrapper, but that looks to be unused; I
932         will delete that in a separate patch.
933
934         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
935         (parse_args):
936
937 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
938
939         [EFL] [DRT] Reset CacheModel before running each test
940         https://bugs.webkit.org/show_bug.cgi?id=87534
941
942         Reviewed by Gustavo Noronha Silva.
943
944         Reset cache model to default before running each test to fix some
945         flaky tests on EFL build bots. Also fix case value in setCacheModel.
946
947         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
948         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
949         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
950         (LayoutTestController::setCacheModel):
951
952 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
953
954         [GTK] Memory leaks in DRT EventSender.cpp
955         https://bugs.webkit.org/show_bug.cgi?id=88774
956
957         Reviewed by Martin Robinson.
958
959         Fix a few possible memory leaks in EventSender code.
960
961         * DumpRenderTree/gtk/EventSender.cpp:
962         (contextClickCallback): Free the event returned by gdk_event_new().
963         (mouseDownCallback): Ditto.
964         (mouseUpCallback): Ditto.
965
966 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
967
968         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
969         https://bugs.webkit.org/show_bug.cgi?id=88661
970
971         Reviewed by Dirk Pranke.
972
973         Pass string length explicitly when creating String object from
974         non-null-terminated UChar* returned by characters().
975
976         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
977         (LayoutTestController::pathToLocalResource):
978
979 2012-06-11  David Dorwin  <ddorwin@chromium.org>
980
981         [chromium] Provide access to the WebPlugin created by the helper plugin widget
982         https://bugs.webkit.org/show_bug.cgi?id=88028
983
984         Reviewed by Adam Barth.
985
986         Added isPlaceholder() to WebPlugin.
987
988         * DumpRenderTree/chromium/TestWebPlugin.h:
989         (TestWebPlugin::isPlaceholder):
990
991 2012-06-11  Tony Chang  <tony@chromium.org>
992
993         rebaseline from garden-o-matic leaves N processes each time it is run
994         https://bugs.webkit.org/show_bug.cgi?id=88586
995
996         Reviewed by Dirk Pranke.
997
998         This appears to only be a problem on python 2.7. Maybe a bug causing
999         pools to not be garbage collected?
1000
1001         * Scripts/webkitpy/common/system/executive.py:
1002         (Executive.run_in_parallel): close() and join() the process pool.
1003         * Scripts/webkitpy/common/system/executive_unittest.py:
1004         (ExecutiveTest.test_run_in_parallel):
1005
1006 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
1007
1008         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
1009         https://bugs.webkit.org/show_bug.cgi?id=87841
1010
1011         Reviewed by Simon Hausmann.
1012
1013         * qmake/config.tests/libwebp/libwebp.cpp: Added.
1014         (main):
1015         * qmake/config.tests/libwebp/libwebp.pro: Added.
1016         * qmake/sync.profile:
1017
1018 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
1019
1020         Expose layoutTestController as testRunner
1021         https://bugs.webkit.org/show_bug.cgi?id=88210
1022
1023         Reviewed by Darin Adler.
1024
1025         * DumpRenderTree/LayoutTestController.cpp:
1026         (LayoutTestController::makeWindowObject):
1027         * DumpRenderTree/chromium/TestShell.cpp:
1028         (TestShell::bindJSObjectsToWindow):
1029         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1030         (WebCore::DumpRenderTree::initJSObjects):
1031         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1032         (WTR::LayoutTestController::makeWindowObject):
1033
1034 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
1035
1036         [Chromium] Remove JavaScriptCore dependencies from gyp
1037         https://bugs.webkit.org/show_bug.cgi?id=88510
1038
1039         Reviewed by Adam Barth.
1040
1041         Chromium doesn't support JSC any more and there doesn't seem to be
1042         a strong interest in using GYP as the common build system in other
1043         ports.
1044
1045         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1046         * Scripts/generate-project-files: Removed.
1047
1048 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
1049
1050         Add UNDO_MANAGER flag
1051         https://bugs.webkit.org/show_bug.cgi?id=87908
1052
1053         Reviewed by Tony Chang.
1054
1055         * Scripts/webkitperl/FeatureList.pm:
1056         * qmake/mkspecs/features/features.pri:
1057
1058 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1059
1060         webkit-patch land-safely should set cq? if the patch author is not in committers.py
1061         https://bugs.webkit.org/show_bug.cgi?id=88689
1062
1063         Reviewed by Dirk Pranke.
1064
1065         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
1066         in committers.py or the contributor cannot commit. If anything, the contributor can still
1067         set cq+ on thier patches manually so I don't think this will be an issue for people who
1068         don't list their Bugzille email on committers.py.
1069
1070         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1071         (Bugzilla._commit_queue_flag):
1072         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1073         (test_commit_queue_flag):
1074         (test_commit_queue_flag.assert_commit_queue_flag):
1075
1076 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
1077
1078         remove obsolete NewRunWebKitTests buildbot master factory classes
1079         https://bugs.webkit.org/show_bug.cgi?id=88693
1080
1081         Reviewed by Ryosuke Niwa.
1082
1083         I believe these aren't used any more ...
1084
1085         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1086         (RunWebKitTests.getText2):
1087         (BuildAndTestLeaksFactory):
1088
1089 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
1090
1091         [Chromium-Android] Build DumpRenderTree with Android SDK
1092         https://bugs.webkit.org/show_bug.cgi?id=88598
1093
1094         Change WebKit side of DRT related code according to some recent changes at chromium side.
1095
1096         Reviewed by Adam Barth.
1097
1098         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1099         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1100         (ChromiumAndroidPort.__init__):
1101         (ChromiumAndroidPort._path_to_driver):
1102
1103 2012-06-08  Wei James  <james.wei@intel.com>
1104
1105         Add app_abi option for DumpRenderTree_apk
1106         https://bugs.webkit.org/show_bug.cgi?id=88626
1107
1108         Reviewed by Adam Barth.
1109
1110         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1111
1112 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1113
1114         [GTK] Add API to get the library version to WebKit2 GTK+
1115         https://bugs.webkit.org/show_bug.cgi?id=88426
1116
1117         Reviewed by Martin Robinson.
1118
1119         * gtk/generate-gtkdoc:
1120         (get_webkit2_options): Add built sources to the list of files, but
1121         ignore enum types and marshallers.
1122
1123 2012-06-07  Vincent Scheib  <scheib@chromium.org>
1124
1125         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
1126         https://bugs.webkit.org/show_bug.cgi?id=88604
1127
1128         Reviewed by Kent Tamura.
1129
1130         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
1131         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
1132
1133         * DumpRenderTree/chromium/WebViewHost.cpp:
1134         (WebViewHost::requestPointerUnlock):
1135
1136 2012-06-08  Hans Wennborg  <hans@chromium.org>
1137
1138         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
1139         https://bugs.webkit.org/show_bug.cgi?id=87976
1140
1141         Reviewed by Kent Tamura.
1142
1143         Provide a mock implementation of WebSpeechRecognizer for
1144         DumpRenderTree. This will allow better testing of the API via layout
1145         tests.
1146
1147         * DumpRenderTree/DumpRenderTree.gypi:
1148         * DumpRenderTree/chromium/LayoutTestController.cpp:
1149         (LayoutTestController::LayoutTestController):
1150         (LayoutTestController::addMockSpeechRecognitionResult):
1151         * DumpRenderTree/chromium/LayoutTestController.h:
1152         (LayoutTestController):
1153         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
1154         (MockWebSpeechRecognizer::create):
1155         (MockWebSpeechRecognizer::start):
1156         (MockWebSpeechRecognizer::stop):
1157         (MockWebSpeechRecognizer::abort):
1158         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
1159         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
1160         (MockWebSpeechRecognizer::ResultTask::runIfValid):
1161         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
1162         (WebKit):
1163         (MockWebSpeechRecognizer):
1164         (MockWebSpeechRecognizer::addMockResult):
1165         (MockWebSpeechRecognizer::taskList):
1166         (ClientCallTask):
1167         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
1168         (ResultTask):
1169         (MockWebSpeechRecognizer::ResultTask::ResultTask):
1170         (NoMatchTask):
1171         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
1172         * DumpRenderTree/chromium/WebViewHost.cpp:
1173         (WebViewHost::speechRecognizer):
1174         * DumpRenderTree/chromium/WebViewHost.h:
1175         (WebViewHost):
1176         (WebViewHost::mockSpeechRecognizer):
1177
1178 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
1179
1180         check-webkit-style needs to be taught about <public/Foo.h>
1181         https://bugs.webkit.org/show_bug.cgi?id=88524
1182
1183         Reviewed by David Levin.
1184
1185         * Scripts/webkitpy/style/checkers/cpp.py:
1186         (_classify_include):
1187         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1188         (OrderOfIncludesTest.test_public_primary_header):
1189         (OrderOfIncludesTest.test_classify_include):
1190
1191 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
1192
1193         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1194         https://bugs.webkit.org/show_bug.cgi?id=67255
1195
1196         Reviewed by Dirk Pranke.
1197
1198         Implement pathToLocalResource to redirect file:///tmp URL's to
1199         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
1200         LayoutTests sub-directory of the WebKit source tree.
1201
1202         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1203         (LayoutTestController::pathToLocalResource):
1204
1205 2012-06-07  Tony Payne  <tpayne@chromium.org>
1206
1207         [chromium] Allow LayoutTests under new git workflow
1208         https://bugs.webkit.org/show_bug.cgi?id=88575
1209
1210         On Windows, chromium indirects through git.bat. Adds the same hack that
1211         is currently used for discovering svn.bat to support the new git
1212         workflow.
1213
1214         Reviewed by Dirk Pranke.
1215
1216         * Scripts/webkitpy/common/checkout/scm/git.py:
1217         (Git): Replaces all hard-coded references to 'git' with the class
1218         variable executable_name.
1219         (Git._check_git_architecture):
1220         (Git.in_working_directory):
1221         (Git.find_checkout_root):
1222         (Git.read_git_config):
1223         (Git.discard_local_commits):
1224         (Git.local_commits):
1225         (Git.working_directory_is_clean):
1226         (Git.clean_working_directory):
1227         (Git.status_command):
1228         (Git.add_list):
1229         (Git.delete_list):
1230         (Git.exists):
1231         (Git._current_branch):
1232         (Git.changed_files):
1233         (Git._changes_files_for_commit):
1234         (Git.revisions_changing_file):
1235         (Git.conflicted_files):
1236         (Git.svn_revision):
1237         (Git.create_patch):
1238         (Git._run_git_svn_find_rev):
1239         (Git.contents_at_revision):
1240         (Git.diff_for_file):
1241         (Git.show_head):
1242         (Git.committer_email_for_revision):
1243         (Git.apply_reverse_diff):
1244         (Git.revert_files):
1245         (Git.commit_with_message):
1246         (Git._commit_on_branch):
1247         (Git.svn_commit_log):
1248         (Git.last_svn_commit_log):
1249         (Git.svn_blame):
1250         (Git._branch_ref_exists):
1251         (Git.delete_branch):
1252         (Git.remote_merge_base):
1253         (Git.commit_locally_with_message):
1254         (Git.push_local_commits_to_server):
1255         (Git.commit_ids_from_commitish_arguments):
1256         (Git.commit_message_for_local_commit):
1257         (Git.files_changed_summary_for_commit):
1258         * Scripts/webkitpy/common/host.py:
1259         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
1260         that duplicates the logic in the existing 'svn.bat' hack.
1261
1262 2012-06-07  Ojan Vafai  <ojan@chromium.org>
1263
1264         Style build architectures like build versions for non-layout test failures
1265         https://bugs.webkit.org/show_bug.cgi?id=88590
1266
1267         Reviewed by Tony Chang.
1268
1269         Since we show the list of failing tests after the architecture, we want the
1270         buildtype and architecture to be grouped together visually.
1271
1272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
1273         (.effects a.failing-builder>span.architecture):
1274
1275 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
1276
1277         [Chromium] Remove header dependency of ImageDiff to WTF
1278         https://bugs.webkit.org/show_bug.cgi?id=88422
1279
1280         Reviewed by Ryosuke Niwa.
1281
1282         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1283         * DumpRenderTree/chromium/ImageDiff.cpp:
1284         (untestedCompareImages):
1285
1286 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
1287
1288         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
1289         https://bugs.webkit.org/show_bug.cgi?id=88491
1290
1291         Reviewed by Dirk Pranke.
1292
1293         DRT should enable WebAudio when WebAudio feature is enabled,
1294         so that the WebAudio feature could be tested by the Layouttest.
1295
1296         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
1297         (LayoutTestController::overridePreference):
1298
1299 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
1300
1301         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
1302         https://bugs.webkit.org/show_bug.cgi?id=88581
1303
1304         Reviewed by Ojan Vafai.
1305
1306         webkit-paptch rebaseline-expectations was ignoring what the
1307         expected results for a test were and pulling down all the result
1308         files from a bot. This could lead to us pulling down old,
1309         incorrect .txt or .png files. With this patch we will now only
1310         pull down expectations of the appropriate file types (so an
1311         IMAGE failure will only pull the png and not the txt file).
1312
1313         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1314         (has_pixel_failures):
1315         (suffixes_for_expectations):
1316         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1317         (FunctionsTest.test_suffixes_for_expectations):
1318         * Scripts/webkitpy/tool/commands/rebaseline.py:
1319         (AbstractRebaseliningCommand.__init__):
1320         (RebaselineExpectations._is_supported_port):
1321         (RebaselineExpectations._update_expectations_file):
1322         (RebaselineExpectations._tests_to_rebaseline):
1323         (RebaselineExpectations._rebaseline_port):
1324         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1325         (test_overrides_are_included_correctly):
1326
1327 2012-06-07  Ojan Vafai  <ojan@chromium.org>
1328
1329         Fix recent null pointer error regression in the flakiness dashboard
1330         https://bugs.webkit.org/show_bug.cgi?id=88573
1331
1332         Reviewed by Dirk Pranke.
1333
1334         * TestResultServer/static-dashboards/builders.js:
1335         (requestBuilderList):
1336         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1337
1338 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
1339
1340         Add Konrad Piascik to committers.py
1341         https://bugs.webkit.org/show_bug.cgi?id=88560
1342
1343         Unreviewed.
1344
1345         * Scripts/webkitpy/common/config/committers.py:
1346
1347 2012-06-07  Tony Chang  <tony@chromium.org>
1348
1349         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
1350         https://bugs.webkit.org/show_bug.cgi?id=77368
1351
1352         Reviewed by Ojan Vafai.
1353
1354         It doesn't look like we ever get a rect with width or height of 0.
1355         I ran css1, css2.1, fast/forms, and tables without any crashes.
1356
1357         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1358         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
1359
1360 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
1361
1362         run-webkit-tests --lint-test-files gives an error when run on linux
1363         https://bugs.webkit.org/show_bug.cgi?id=88551
1364
1365         Reviewed by Ojan Vafai.
1366
1367         We weren't mapping the expectations properly for the
1368         google-chrome ports.
1369
1370         * Scripts/webkitpy/layout_tests/port/base.py:
1371         (Port.path_to_test_expectations_file):
1372         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1373         (TestGoogleChromePort.test_path_to_expectations):
1374
1375 2012-06-07  Daniel Erat  <derat@chromium.org>
1376
1377         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
1378         https://bugs.webkit.org/show_bug.cgi?id=88263
1379
1380         Reviewed by Tony Chang.
1381
1382         * DumpRenderTree/chromium/LayoutTestController.cpp:
1383         (LayoutTestController::LayoutTestController):
1384         (LayoutTestController::reset):
1385         (LayoutTestController::setTextSubpixelPositioning):
1386         * DumpRenderTree/chromium/LayoutTestController.h:
1387         (LayoutTestController):
1388         * DumpRenderTree/chromium/fonts.conf:
1389
1390 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
1391
1392         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
1393         https://bugs.webkit.org/show_bug.cgi?id=88060
1394
1395         Reviewed by Martin Robinson.
1396
1397         Spin the main loop before acquiring the pixel content. This ensures things
1398         like late size allocations are finished before calling gtk_widget_draw,
1399         avoiding assertions and subsequent empty pixel results.
1400
1401         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1402         (createBitmapContextFromWebView):
1403
1404 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1405
1406         [Qt] Improve the visual of the viewport info box
1407         https://bugs.webkit.org/show_bug.cgi?id=88410
1408
1409         Reviewed by Tor Arne Vestbø.
1410
1411         Improve the visual and make it possible to see the content more easy.
1412
1413         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1414
1415 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
1416
1417         [EFL][WK2] Compile webkit1 and webkit2 by default.
1418         https://bugs.webkit.org/show_bug.cgi?id=85041
1419
1420         Reviewed by Chang Shu.
1421
1422         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
1423         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
1424
1425         * Scripts/build-webkit:
1426
1427 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1428
1429         Unreviewed, rolling out r119662.
1430         http://trac.webkit.org/changeset/119662
1431         https://bugs.webkit.org/show_bug.cgi?id=88487
1432
1433         Broke builds (Requested by rniwa on #webkit).
1434
1435         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1436         * DumpRenderTree/chromium/ImageDiff.cpp:
1437         (untestedCompareImages):
1438
1439 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
1440
1441         [Chromium] Remove header dependency of ImageDiff to WTF
1442         https://bugs.webkit.org/show_bug.cgi?id=88422
1443
1444         Reviewed by Adam Barth.
1445
1446         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1447         * DumpRenderTree/chromium/ImageDiff.cpp:
1448         (untestedCompareImages):
1449
1450 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
1451
1452         [WebKit] DeviceOrientation cleanup
1453         https://bugs.webkit.org/show_bug.cgi?id=88406
1454
1455         Reviewed by Kent Tamura.
1456
1457         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
1458
1459         * DumpRenderTree/chromium/LayoutTestController.cpp:
1460         (LayoutTestController::setMockDeviceOrientation):
1461
1462 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1463
1464         webkitpy: add support for an ordered dict of test expectations
1465         https://bugs.webkit.org/show_bug.cgi?id=87802
1466
1467         Reviewed by Ojan Vafai.
1468
1469         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
1470         support a cascaded list of test expectations files. An easy way
1471         to think of this is as an ordered dictionary of name -> contents
1472         for files, where the name is usually a path on disk (I say
1473         usually because we want to support other kinds of expectations
1474         like the compile-time skips for unsupported features in
1475         webkit.py, and we want to continue to support "in-memory" test
1476         expectations that don't require a filesystem).
1477
1478         Conveniently there is an OrderedDict implementation in Python
1479         2.7+ and it is available as a backport, so the first step in
1480         adding this support is to use that implementation. Subsequent
1481         patches will update the test_expectations.py module (and other
1482         callers) to access the dict directly.
1483
1484         This patch just changes the base internal implementation and
1485         provides wrappers for compatibility. The derived ports
1486         (WebKitPort, TestPort, etc.) still need to be updated.
1487
1488         * Scripts/webkitpy/layout_tests/port/base.py:
1489         (Port._expectations_dict):
1490         (Port.test_expectations):
1491         (Port):
1492         (Port._expectations_overrides_dict):
1493         (Port.test_expectations_overrides):
1494         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1495         (PortTestCase.test_expectations_ordering):
1496         (PortTestCase):
1497         (PortTestCase.test_expectations_overrides_ordering):
1498         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
1499         (OrderedDict):
1500         (OrderedDict.__init__):
1501         (OrderedDict.clear):
1502         (OrderedDict.__setitem__):
1503         (OrderedDict.__delitem__):
1504         (OrderedDict.__iter__):
1505         (OrderedDict.__reversed__):
1506         (OrderedDict.popitem):
1507         (OrderedDict.__reduce__):
1508         (OrderedDict.__repr__):
1509         (OrderedDict.copy):
1510         (OrderedDict.fromkeys):
1511
1512 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
1513
1514         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
1515
1516         * gtk/run-api-tests:
1517         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
1518
1519 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1520
1521         nrwt should look in 'out' for binaries on chromium win to support ninja
1522         https://bugs.webkit.org/show_bug.cgi?id=88273
1523
1524         Reviewed by Tony Chang.
1525
1526         This patch standardizes the search algorithm the chromium ports
1527         use to figure out which driver to run. We will look in a
1528         chromium location before a webkit location (e.g., in
1529         Source/WebKit/chromium/out before out/) and we will look in the
1530         "legacy" directory (xcodebuild) before the directory ninja uses
1531         (out).
1532
1533         Unfortunately due to the way the test code is set up testing the
1534         properly requires some duplication of test code. I will fix that
1535         in a followup patch.
1536
1537         * Scripts/webkitpy/layout_tests/port/chromium.py:
1538         (ChromiumPort):
1539         (ChromiumPort._static_build_path):
1540         (ChromiumPort._build_path):
1541         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1542         (ChromiumLinuxPort):
1543         (ChromiumLinuxPort._determine_driver_path_statically):
1544         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1545         (ChromiumLinuxPortTest.test_build_path):
1546         (ChromiumLinuxPortTest):
1547         (ChromiumLinuxPortTest.test_driver_name_option):
1548         (ChromiumLinuxPortTest.path_to_image_diff):
1549         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1550         (ChromiumMacPort):
1551         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1552         (ChromiumMacPortTest.test_build_path):
1553         (ChromiumMacPortTest):
1554         (ChromiumMacPortTest.test_driver_name_option):
1555         (ChromiumMacPortTest.path_to_image_diff):
1556         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1557         (ChromiumPortTest.test_overrides_and_builder_names):
1558         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1559         (ChromiumWinPort):
1560         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1561         (ChromiumWinTest.test_build_path):
1562         (ChromiumWinTest.test_operating_system):
1563         (ChromiumWinTest):
1564         (ChromiumWinTest.test_driver_name_option):
1565         (ChromiumWinPortTest.path_to_image_diff):
1566         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1567         (PortTestCase.assert_build_path):
1568
1569 2012-06-06  Jessie Berlin  <jberlin@apple.com>
1570
1571         Remove very red Windows WebKit2 testers
1572         https://bugs.webkit.org/show_bug.cgi?id=88452
1573
1574         Reviewed by Steve Falkenburg.
1575
1576         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
1577         need to focus on getting the WK1 testers green.
1578
1579         * BuildSlaveSupport/build.webkit.org-config/config.json:
1580
1581 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1582
1583         get rebaselining tools to kinda work with the skia overrides file
1584         https://bugs.webkit.org/show_bug.cgi?id=88456
1585
1586         Reviewed by Ryosuke Niwa.
1587
1588         Update rebaseline-expectations so that we read in the overrides
1589         when looking for tests to rebaseline, but don't read in the
1590         overrides when we are writing the expectations file back out.
1591         This prevents the overrides from getting written into the main
1592         file. This is kind of a hack but will have to do until we
1593         support multiple expectations files properly.
1594
1595         * Scripts/webkitpy/tool/commands/rebaseline.py:
1596         (RebaselineExpectations._expectations):
1597         (RebaselineExpectations._update_expectations_file):
1598         (RebaselineExpectations._tests_to_rebaseline):
1599         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1600         (test_overrides_are_included_correctly):
1601
1602 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1603
1604         webkitpy: two manager_worker_broker_unittest tests are broken
1605         https://bugs.webkit.org/show_bug.cgi?id=88445
1606
1607         Reviewed by Ojan Vafai.
1608
1609         These tests were never updated when we removed the
1610         --worker-model argument, and we were passing 'inline' instead of
1611         1 (for the number of workers) :(. As a result we were creating
1612         multiprocessing queues unnecessarily and that was failing on cygwin.
1613
1614         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1615         (InterfaceTest.test_managerconnection_is_abstract):
1616         (InterfaceTest.test_workerconnection_is_abstract):
1617
1618 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
1619
1620         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
1621         https://bugs.webkit.org/show_bug.cgi?id=87406
1622
1623         Reviewed by Dirk Pranke.
1624
1625         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1626         (TestExpectations.__init__):
1627         * Scripts/webkitpy/tool/commands/rebaseline.py:
1628         (RebaselineTest._update_expectations_file):
1629         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1630         (test_rebaseline_does_not_include_overrides):
1631
1632 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1633
1634         webkitpy: perf tests unit tests fail on chromium win
1635         https://bugs.webkit.org/show_bug.cgi?id=88279
1636
1637         Reviewed by Ryosuke Niwa.
1638
1639         I'm seeing weird failures running the unit tests in my win32
1640         checkout, and we don't really expect webpagereplay to work on
1641         win32 anyway, so I'm skipping the import of that module for now
1642         and adding a warning.
1643
1644         * Scripts/run-perf-tests:
1645         * Scripts/webkitpy/performance_tests/perftest.py:
1646
1647 2012-06-06  Yong Li <yoli@rim.com>
1648
1649         Unreviewed. Update my email address in committers.py.
1650
1651         * Scripts/webkitpy/common/config/committers.py:
1652
1653 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
1654
1655         Add Robert Kroeger  to commiters.py
1656         https://bugs.webkit.org/show_bug.cgi?id=88415
1657
1658         Unreviewed.
1659
1660         * Scripts/webkitpy/common/config/committers.py:
1661
1662 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1663
1664         [EFL][DRT] http/tests/globalhistory testcases do not pass
1665         https://bugs.webkit.org/show_bug.cgi?id=82579
1666
1667         Reviewed by Csaba Osztrogonác.
1668
1669         DRT has provided callbacks for ewk_view "global history delegate" signals.
1670
1671         * DumpRenderTree/efl/DumpRenderTree.cpp:
1672         (isGlobalHistoryTest): Aux function to ident global history testcase.
1673         (createLayoutTestController):
1674         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1675         (DumpRenderTreeChrome::createView):
1676         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
1677         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
1678         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
1679         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
1680         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
1681         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1682         (DumpRenderTreeChrome):
1683
1684 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
1685
1686         [Qt] run-qtwebkit-tests hangs with -j1
1687         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
1688         This could happen due to an uncancelled timer after results were returned. This timer was
1689         started only if --timeout was set.
1690         https://bugs.webkit.org/show_bug.cgi?id=85475
1691
1692         Reviewed by Csaba Osztrogonác.
1693
1694         * Scripts/run-qtwebkit-tests:
1695         (run_test):
1696
1697 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
1698
1699         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
1700         https://bugs.webkit.org/show_bug.cgi?id=88327
1701
1702         Reviewed by Kenneth Rohde Christiansen.
1703
1704         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
1705         * MiniBrowser/qt/icons/contents_width.png: Added.
1706         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
1707         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
1708
1709 2012-06-05  Jon Lee  <jonlee@apple.com>
1710
1711         Buildbot fix.
1712
1713         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
1714         in the function. Store in a local variable.
1715         (loadBuilderConfig):
1716
1717 2012-06-05  Jon Lee  <jonlee@apple.com>
1718
1719         Buildbot fix.
1720
1721         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1722         (loadBuilderConfig):
1723
1724 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1725
1726         webkitpy: clean up win-specific path handling and tests
1727         https://bugs.webkit.org/show_bug.cgi?id=88281
1728
1729         Reviewed by Adam Barth.
1730
1731         There was a bunch of inconsistent logic for handling path
1732         conversions for win32 and cygwin paths due to us sometimes
1733         looking at sys.platform and sometimes using mock hosts. This
1734         patch cleans everything up so that we are required to pass
1735         PlatformInfo objects to the path module and stop trying to do
1736         different things when running on cygwin or win32 hosts (except
1737         in the path_unittest module itself).
1738
1739         This may slightly reduce test coverage for the win32 code paths
1740         but will be a lot easier to follow and maintain.
1741
1742         * Scripts/webkitpy/common/system/path.py:
1743         (abspath_to_uri):
1744         (_convert_path):
1745         * Scripts/webkitpy/common/system/path_unittest.py:
1746         (AbspathTest.platforminfo):
1747         (AbspathTest.test_abspath_to_uri_cygwin):
1748         (AbspathTest.test_abspath_to_uri_unixy):
1749         (AbspathTest.test_abspath_to_uri_win):
1750         (AbspathTest.test_abspath_to_uri_escaping_unixy):
1751         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
1752         (AbspathTest.test_stop_cygpath_subprocess):
1753         * Scripts/webkitpy/common/system/platforminfo.py:
1754         (PlatformInfo.__init__):
1755         (PlatformInfo.is_cygwin):
1756         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1757         (MockPlatformInfo.is_cygwin):
1758         * Scripts/webkitpy/layout_tests/port/base.py:
1759         (Port.to.show_results_html_file):
1760         * Scripts/webkitpy/layout_tests/port/driver.py:
1761         (Driver.test_to_uri):
1762         (Driver.uri_to_test):
1763         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1764         (DriverTest.test_test_to_uri):
1765         (DriverTest.test_uri_to_test):
1766         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1767         (MockDRTPortTest.make_port):
1768         (MockDRTTest.input_line):
1769         (MockChromiumDRTTest.test_pixeltest__fails):
1770         * Scripts/webkitpy/layout_tests/port/test.py:
1771         * Scripts/webkitpy/layout_tests/port/win.py:
1772         (WinPort.show_results_html_file):
1773         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1774         (MainTest.test_unexpected_failures):
1775         (MainTest.test_results_directory_absolute):
1776         (MainTest.test_results_directory_default):
1777         (MainTest.test_results_directory_relative):
1778
1779 2012-06-05  Jon Lee  <jonlee@apple.com>
1780
1781         Workaround buildbot bug when merging build requests.
1782         https://bugs.webkit.org/show_bug.cgi?id=88158
1783
1784         Reviewed by Mark Rowe.
1785
1786         For expediency, we still want testers to pick the latest build to test, but to ensure
1787         that the builders are reporting the correct revision number, we should let the building bots
1788         run as they normally would. That is, the builder picks the oldest revision, and merges
1789         subsequent requests. Because merged requests get appended to the list of changes for a given
1790         build, the last change in that list is also the latest change. When we used pickLatestBuild
1791         for the builders, this was not the case (it would always report the penultimate change).
1792
1793         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
1794
1795         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
1796         for all Apple builders.
1797         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
1798         the latest build to run.
1799         (loadBuilderConfig):
1800
1801 2012-06-05  Jessie Berlin  <jberlin@apple.com>
1802
1803         [Win] DumpRenderTree should call resetInternalsObject
1804         https://bugs.webkit.org/show_bug.cgi?id=88346
1805
1806         Reviewed by Simon Fraser.
1807
1808         Invoke it on Windows in the same place it is invoked on Mac.
1809
1810         * DumpRenderTree/win/DumpRenderTree.cpp:
1811         (resetWebViewToConsistentStateBeforeTesting):
1812
1813 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1814
1815         [GTK] Fix two more memory leaks in DRT
1816         https://bugs.webkit.org/show_bug.cgi?id=88255
1817
1818         Reviewed by Martin Robinson.
1819
1820         Fixed memory leaks in GTK's DRT code.
1821
1822         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1823         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
1824         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
1825         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1826         (createBitmapContextFromWebView): Free the cairo surface.
1827
1828 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1829
1830         [Qt] Building when a top directory is named Source
1831         https://bugs.webkit.org/show_bug.cgi?id=77727
1832
1833         Reviewed by Tor Arne Vestbø.
1834
1835         Change regex to only replace the last instance of OUT_PWD.
1836
1837         * qmake/mkspecs/features/default_pre.prf:
1838
1839 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
1840
1841         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
1842         https://bugs.webkit.org/show_bug.cgi?id=73176
1843
1844         Reviewed by Adam Barth.
1845
1846         Two more APIs are added in Custom Scheme Handler specification.
1847         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
1848         One is 'isProtocolHandlerRegistered' to query whether the specific URL
1849         is registered or not.
1850         The other is 'unregisterProtocolHandler' to remove the registered URL.
1851
1852         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
1853
1854 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
1855
1856         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
1857         https://bugs.webkit.org/show_bug.cgi?id=83879
1858
1859         Reviewed by Carlos Garcia Campos.
1860
1861         Make minibrowser connect to the new 'permission requests' signal
1862         to allow users handle the Geolocation permission requests.
1863
1864         * MiniBrowser/gtk/BrowserWindow.c:
1865         (geolocationRequestDialogCallback): Callback for the dialog asking
1866         the user for allowing or not geolocation permission requests.
1867         (webViewDecidePermissionRequest): Launch a dialog to ask the user
1868         whether to allow or deny geolocation permission requests.
1869         (browserWindowConstructed): Connect to 'permission-request' signal.
1870
1871 2012-06-04  Chase Phillips  <cmp@google.com>
1872
1873         Make a builder group support+expect multiple loads.
1874         https://bugs.webkit.org/show_bug.cgi?id=88260
1875
1876         Change BuilderGroup to allow expecting multiple
1877         loads.  This allows merging results for a given set
1878         of builders into one group.
1879
1880         Add a test that verifies that the group count
1881         increments correctly based on successful and failed
1882         list loads.
1883
1884         Reviewed by Ojan Vafai.
1885
1886         * TestResultServer/static-dashboards/builders.js:
1887         (BuilderGroup):
1888         (BuilderGroup.prototype.setbuilder):
1889         (BuilderGroup.prototype.append):
1890         (BuilderGroup.prototype.loaded):
1891         (requestBuilderList.xhr.onload):
1892         (requestBuilderList.xhr.onerror):
1893         (onErrorLoadingBuilderList):
1894         (loadBuildersList):
1895         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1896         (test):
1897         * TestResultServer/static-dashboards/run-unittests.html:
1898
1899 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
1900
1901         Python test fix attempt for Chromium Windows.
1902
1903         * Scripts/webkitpy/layout_tests/port/driver.py:
1904         (Driver.uri_to_test):
1905
1906 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
1907
1908         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
1909         https://bugs.webkit.org/show_bug.cgi?id=88243
1910
1911         Reviewed by Adam Barth.
1912
1913         * qmake/mkspecs/features/features.prf:
1914
1915 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1916
1917         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
1918         https://bugs.webkit.org/show_bug.cgi?id=88280
1919
1920         Unreviewed, build fix.
1921
1922         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1923         (TestServerProcess.test_basic):
1924
1925 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1926
1927         test-webkitpy is hanging under cygwin
1928         https://bugs.webkit.org/show_bug.cgi?id=88269
1929
1930         Reviewed by Ryosuke Niwa.
1931
1932         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
1933         so we need to skip any tests that use it.
1934
1935         * Scripts/webkitpy/common/system/executive.py:
1936         (Executive.run_in_parallel):
1937         * Scripts/webkitpy/common/system/executive_unittest.py:
1938         (ExecutiveTest.test_run_in_parallel):
1939
1940 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1941
1942         test-webkitpy is failing on win32 after r115054
1943         https://bugs.webkit.org/show_bug.cgi?id=88264
1944
1945         Reviewed by Ryosuke Niwa.
1946
1947         The failing http_server test was improperly suppressed (the
1948         tuple was missing a comma, and so wasn't a tuple at all, just a
1949         string) and so we were skipping *all* tests on win32. The right
1950         way to skip a single test is to disable it inside the test
1951         itself.
1952
1953         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1954         (TestHttpServer.test_start_cmd):
1955         * Scripts/webkitpy/test/test_finder.py:
1956         (TestFinder._default_names):
1957         * Scripts/webkitpy/test/main.py:
1958         (Tester.run): Add error message if we don't find any tests to run.
1959         * Scripts/webkitpy/test/main_unittest.py:
1960             
1961
1962 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1963
1964         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
1965         https://bugs.webkit.org/show_bug.cgi?id=88215
1966
1967         Reviewed by Martin Robinson.
1968
1969         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
1970         for newly allocated strings.
1971
1972         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1973         (attributeSetToString):
1974         (AccessibilityUIElement::allAttributes):
1975
1976 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1977
1978         [GTK] Memory leaks in DumpRenderTree.cpp
1979         https://bugs.webkit.org/show_bug.cgi?id=88213
1980
1981         Reviewed by Martin Robinson.
1982
1983         Fixed memory leaks in DumpRenderTree.
1984
1985         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1986         (appendString): Accepts const gchar* as the second argument.
1987         (dumpFramesAsText): Free the string returned by g_strdup_printf().
1988         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
1989
1990 2012-06-04  David Dorwin  <ddorwin@chromium.org>
1991
1992         Enable Chromium media player to instantiate a plugin
1993         https://bugs.webkit.org/show_bug.cgi?id=87399
1994
1995         Reviewed by Kent Tamura.
1996
1997         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
1998
1999         * DumpRenderTree/chromium/WebViewHost.cpp:
2000         (WebViewHost::createPopupMenu):
2001
2002 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
2003
2004         [GTK][WK2] Implement geolocation provider for the GTK port
2005         https://bugs.webkit.org/show_bug.cgi?id=83877
2006
2007         Reviewed by Carlos Garcia Campos.
2008
2009         * gtk/generate-gtkdoc:
2010         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
2011
2012 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2013
2014         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
2015         https://bugs.webkit.org/show_bug.cgi?id=87668
2016
2017         Reviewed by Ryosuke Niwa.
2018
2019         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
2020         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
2021         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
2022
2023         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2024         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2025
2026 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
2027
2028         [EFL] Refactor ewk_view_context_paint code.
2029         https://bugs.webkit.org/show_bug.cgi?id=85588
2030
2031         Reviewed by Hajime Morita.
2032
2033         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
2034
2035 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
2036
2037         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
2038         https://bugs.webkit.org/show_bug.cgi?id=87869
2039
2040         Reviewed by Andreas Kling.
2041
2042         Replace %lld by PRId64 macro to print an int64_t value and silent a
2043         compilation warning on 64-Bit.
2044
2045         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2046         (onExceededApplicationCacheQuota):
2047
2048 2012-06-03  Varun Jain  <varunjain@google.com>
2049
2050         [chromium] Add new gesture type (two finger tap) that triggers context menu.
2051         https://bugs.webkit.org/show_bug.cgi?id=88173
2052
2053         Reviewed by Adam Barth.
2054
2055         * DumpRenderTree/chromium/EventSender.cpp:
2056         (EventSender::EventSender):
2057         (EventSender::gestureTwoFingerTap):
2058         (EventSender::gestureEvent):
2059         * DumpRenderTree/chromium/EventSender.h:
2060         (EventSender):
2061
2062 2012-06-02  Zeno Albisser  <zeno@webkit.org>
2063
2064         Fix and enable WebGL for WebKit2 on Qt.
2065         https://bugs.webkit.org/show_bug.cgi?id=86214
2066
2067         Enable WebGL by default for Qt MiniBrowser.
2068
2069         Reviewed by Noam Rosenthal.
2070
2071         * MiniBrowser/qt/qml/BrowserWindow.qml:
2072
2073 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
2074
2075         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
2076         https://bugs.webkit.org/show_bug.cgi?id=88164
2077
2078         Reviewed by Kentaro Hara.
2079
2080         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
2081         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
2082
2083         * Scripts/VCSUtils.pm:
2084         (adjustPathForRecentRenamings):
2085         (fixChangeLogPatch):
2086
2087 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
2088
2089         Rename test_expectations.txt to TestExpectations
2090         https://bugs.webkit.org/show_bug.cgi?id=86690
2091
2092         Reviewed by Dirk Pranke.
2093
2094         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
2095         We can the code to read test_expectations.txt once we've successfully transitioned.
2096
2097         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2098         (TestExpectationParser._check_path_does_not_exist):
2099         (TestExpectationParser._tokenize):
2100         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
2101         * Scripts/webkitpy/layout_tests/port/base.py:
2102         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
2103         test_expectations.txt if one exists and the path to TestExpectations otherwise.
2104         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2105         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
2106         virtual.
2107         * Scripts/webkitpy/layout_tests/port/chromium.py:
2108         (ChromiumPort.path_from_chromium_base):
2109         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2110         (ChromiumAndroidPort.test_expectations):
2111         * Scripts/webkitpy/layout_tests/port/test.py:
2112         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
2113         (TestPort.__init__):
2114         * Scripts/webkitpy/layout_tests/port/webkit.py:
2115         (WebKitPort.baseline_search_path):
2116         (WebKitPort.test_expectations):
2117         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
2118         tests to base as a follow up.
2119         (WebKitPortTest.test_path_to_test_expectations_file):
2120         (test_test_expectations):
2121         (test_legacy_test_expectations):
2122         * Scripts/webkitpy/style/checker.py:
2123         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
2124         with one for TestExpectations.
2125         * Scripts/webkitpy/style/checkers/test_expectations.py:
2126         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
2127         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2128         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
2129         test_expectations.txt.
2130         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2131         (TestExpectationsTestCase.assert_lines_lint):
2132         * Scripts/webkitpy/tool/commands/queries.py:
2133         (PrintExpectations.__init__):
2134         * Scripts/webkitpy/tool/commands/rebaseline.py:
2135         (RebaselineExpectations):
2136         * Scripts/webkitpy/tool/steps/commit.py:
2137         (Commit._check_test_expectations):
2138         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2139         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
2140         (CommitTest.test_check_test_expectations): For TestExpectations.
2141         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
2142         * TestResultServer/static-dashboards/dashboard_base.js:
2143         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
2144         Error only when neither exists.
2145         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2146         (processMissingAndExtraExpectations):
2147         (htmlForTestsWithExpectationsButNoFailures):
2148         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2149
2150 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
2151
2152         Remove dependency from ImageDiff to WTF
2153         https://bugs.webkit.org/show_bug.cgi?id=88147
2154
2155         Reviewed by Adam Barth.
2156
2157         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2158
2159 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
2160
2161         NRWT seems to leak (more?) temp dirs
2162         https://bugs.webkit.org/show_bug.cgi?id=88126
2163
2164         Re-land r119297 with chromium fix (weren't calling the
2165         super() method if not in --test-shell mode in start().
2166         Add unit tests to chromium_unittest as well to check.
2167
2168         * Scripts/webkitpy/layout_tests/port/chromium.py:
2169         (ChromiumDriver.start):
2170         * Scripts/webkitpy/layout_tests/port/webkit.py:
2171         (WebKitDriver.__del__):
2172         (WebKitDriver._start):
2173         (WebKitDriver.run_test):
2174         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2175         (WebKitDriverTest.test_check_for_driver_crash):
2176         (WebKitDriverTest.test_stop_cleans_up_properly):
2177         (WebKitDriverTest):
2178         (WebKitDriverTest.test_two_starts_cleans_up_properly):
2179         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2180         (ChromiumDriverTest.test_stop_cleans_up_properly):
2181         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
2182
2183 2012-06-01  Tim Horton  <timothy_horton@apple.com>
2184
2185         Lots of "failed download-built-product" on Apple bots
2186         https://bugs.webkit.org/show_bug.cgi?id=88158
2187
2188         Reviewed by Jessie Berlin.
2189         
2190         Disable mergeRequests on all Apple builders. This is a speculative fix.
2191
2192         * BuildSlaveSupport/build.webkit.org-config/config.json:
2193
2194 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2195
2196         Unreviewed, rolling out r119297.
2197         http://trac.webkit.org/changeset/119297
2198         https://bugs.webkit.org/show_bug.cgi?id=88156
2199
2200         May have broken Chromium bots (Requested by rniwa on #webkit).
2201
2202         * Scripts/webkitpy/layout_tests/port/webkit.py:
2203         (WebKitDriver.__del__):
2204         (WebKitDriver.run_test):
2205         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2206         (WebKitDriverTest.test_check_for_driver_crash):
2207         (WebKitDriverTest.test_stop_cleans_up_properly):
2208
2209 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
2210
2211         nrwt seems to leak tmpdirs
2212         https://bugs.webkit.org/show_bug.cgi?id=88126
2213
2214         Reviewed by Ojan Vafai.
2215
2216         Fix leak possibly introduced in r118979 - we now will
2217         make sure we clean up any stale temp directories during the
2218         start routine and attempt to clean up again in __del__. It
2219         turns out that asserting in __del__ logs a message but is
2220         caught by the runtime, so it's mostly useless.
2221
2222         * Scripts/webkitpy/layout_tests/port/webkit.py:
2223         (WebKitDriver.__del__):
2224         (WebKitDriver._start):
2225         (WebKitDriver.run_test):
2226         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2227         (WebKitDriverTest.test_check_for_driver_crash):
2228         (WebKitDriverTest.test_stop_cleans_up_properly):
2229         (WebKitDriverTest):
2230         (WebKitDriverTest.test_two_starts_cleans_up_properly):
2231
2232 2012-06-01  Michael Saboff  <msaboff@apple.com>
2233
2234         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
2235         https://bugs.webkit.org/show_bug.cgi?id=88109
2236
2237         Reviewed by Geoffrey Garen.
2238
2239         Additional test case.
2240
2241         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2242         (TestWebKitAPI::TEST):
2243
2244 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
2245
2246         [Qt] Use -Werror only in developer builds
2247
2248         Rubber-stamped by Tor Arne Vestbø.
2249
2250         In production builds -Werror with custom toolchains and wierd system
2251         headers, -Werror is of no use and just creates confusion. So use it
2252         only if Qt is configured with -developer-build.
2253
2254         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
2255         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
2256         only if qt_developer_build is set.
2257
2258 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
2259
2260         [watchlist] Add myself to loader and v8 bindings changes
2261         https://bugs.webkit.org/show_bug.cgi?id=88112
2262
2263         Reviewed by Adam Barth.
2264
2265         * Scripts/webkitpy/common/config/watchlist:
2266
2267 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
2268
2269         Adding Jacky Jiang to committers.py
2270         https://bugs.webkit.org/show_bug.cgi?id=88122
2271
2272         Reviewed by Rob Buis.
2273
2274         Adding myself to committers.py as a Committer.
2275
2276         * Scripts/webkitpy/common/config/committers.py:
2277
2278 2012-06-01  Jessie Berlin  <jberlin@apple.com>
2279
2280         Fix Windows build.
2281
2282         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2283
2284 2012-06-01  Jessie Berlin  <jberlin@apple.com>
2285
2286         Windows WK2 MouseMoveAfterCrash API test failing
2287         https://bugs.webkit.org/show_bug.cgi?id=69982
2288
2289         Disable the test on Windows to get the bots greener.
2290
2291         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2292         (TestWebKitAPI::TEST):
2293
2294 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
2295
2296         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
2297         https://bugs.webkit.org/show_bug.cgi?id=86866
2298
2299         Reviewed by Adam Barth.
2300
2301         Catch new "intent,service,register" signal on the frame and print out
2302         information about the Web Intent service in EFL's DumpRenderTree.
2303
2304         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2305         (DumpRenderTreeChrome::createView):
2306         (DumpRenderTreeChrome::onFrameCreated):
2307         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
2308         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2309         (DumpRenderTreeChrome):
2310
2311 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
2312
2313         The ChangeLog parser cannot handle reviewers with initials in their name
2314         https://bugs.webkit.org/show_bug.cgi?id=87864
2315
2316         Reviewed by Ryosuke Niwa.
2317
2318         Add support in the ChangeLog parser for reviewer names that have
2319         initials in them.
2320
2321         * Scripts/webkitpy/common/checkout/changelog.py:
2322         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
2323         in the replacement string. This allows for matching the word characters before a
2324         period, without totally throwing them away.
2325         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
2326         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2327         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
2328
2329 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
2330
2331         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
2332         https://bugs.webkit.org/show_bug.cgi?id=86865
2333
2334         Reviewed by Adam Barth.
2335
2336         Add deliverWebIntent method to LayoutTestController and provide
2337         implementation for EFL port.
2338
2339         * DumpRenderTree/LayoutTestController.cpp:
2340         (deliverWebIntentCallback):
2341         (LayoutTestController::staticFunctions):
2342         * DumpRenderTree/LayoutTestController.h:
2343         (LayoutTestController):
2344         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2345         (LayoutTestController::deliverWebIntent):
2346         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2347         (LayoutTestController::deliverWebIntent):
2348         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2349         (LayoutTestController::deliverWebIntent):
2350         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2351         (LayoutTestController::deliverWebIntent):
2352         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2353         (LayoutTestController::deliverWebIntent):
2354         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2355         (LayoutTestController::deliverWebIntent):
2356
2357 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2358
2359         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
2360
2361         Reviewed by Simon Hausmann.
2362
2363         * Tools.pro:
2364
2365 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
2366
2367         Add public page loading performance tests using web-page-replay
2368         https://bugs.webkit.org/show_bug.cgi?id=84008
2369
2370         Reviewed by Dirk Pranke.
2371
2372         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
2373         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
2374         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
2375
2376         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
2377         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
2378         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
2379         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
2380
2381         * Scripts/webkitpy/layout_tests/port/driver.py:
2382         (Driver.is_external_http_test): Added.
2383         * Scripts/webkitpy/layout_tests/port/webkit.py:
2384         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
2385         * Scripts/webkitpy/performance_tests/perftest.py:
2386         (PerfTest.__init__): Takes port.
2387         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
2388         (PerfTest):
2389         (PerfTest.run): Calls run_single.
2390         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
2391         (ChromiumStylePerfTest.__init__):
2392         (PageLoadingPerfTest.__init__):
2393         (PageLoadingPerfTest.run):
2394         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
2395         (ReplayServer.__init__):
2396         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
2397         but it caused a dead lock on some web pages.
2398         (ReplayServer.stop):
2399         (ReplayServer.__del__):
2400         (ReplayPerfTest):
2401         (ReplayPerfTest.__init__):
2402         (ReplayPerfTest._start_replay_server):
2403         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
2404         The subsequent runs of the same test will just use test.wpr.
2405         (ReplayPerfTest.run_single):
2406         (PerfTestFactory):
2407         (PerfTestFactory.create_perf_test):
2408         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2409         (MainTest.test_parse_output):
2410         (MainTest.test_parse_output_with_failing_line):
2411         (TestPageLoadingPerfTest.test_run):
2412         (TestPageLoadingPerfTest.test_run_with_bad_output):
2413         (TestReplayPerfTest):
2414         (TestReplayPerfTest.ReplayTestPort):
2415         (TestReplayPerfTest.ReplayTestPort.__init__):
2416         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
2417         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
2418         (TestReplayPerfTest.ReplayTestPort._driver_class):
2419         (TestReplayPerfTest.MockReplayServer):
2420         (TestReplayPerfTest.MockReplayServer.__init__):
2421         (TestReplayPerfTest.MockReplayServer.stop):
2422         (TestReplayPerfTest._add_file):
2423         (TestReplayPerfTest._setup_test):
2424         (TestReplayPerfTest.test_run_single):
2425         (TestReplayPerfTest.test_run_single.run_test):
2426         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
2427         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
2428         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
2429         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
2430         (TestReplayPerfTest.test_prepare):
2431         (TestReplayPerfTest.test_prepare.run_test):
2432         (TestReplayPerfTest.test_prepare_calls_run_single):
2433         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
2434         (TestPerfTestFactory.test_regular_test):
2435         (TestPerfTestFactory.test_inspector_test):
2436         (TestPerfTestFactory.test_page_loading_test):
2437         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2438         (PerfTestsRunner):
2439         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
2440         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
2441         (PerfTestsRunner._collect_tests._is_test_file):
2442         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
2443         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2444         (create_runner):
2445         (run_test):
2446         (_tests_for_runner):
2447         (test_run_test_set):
2448         (test_run_test_set_kills_drt_per_run):
2449         (test_run_test_pause_before_testing):
2450         (test_run_test_set_for_parser_tests):
2451         (test_run_test_set_with_json_output):
2452         (test_run_test_set_with_json_source):
2453         (test_run_test_set_with_multiple_repositories):
2454         (test_run_with_upload_json):
2455         (test_upload_json):
2456         (test_upload_json.MockFileUploader.upload_single_text_file):
2457         (_add_file):
2458         (test_collect_tests):
2459         (test_collect_tests_with_multile_files):
2460         (test_collect_tests_with_multile_files.add_file):
2461         (test_collect_tests_with_skipped_list):
2462         (test_collect_tests_with_page_load_svg):
2463         (test_collect_tests_should_ignore_replay_tests_by_default):
2464         (test_collect_tests_with_replay_tests):
2465         (test_parse_args):
2466         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
2467         (AutoinstallImportHook.find_module):
2468         (AutoinstallImportHook._install_webpagereplay):
2469
2470 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
2471
2472         Support building the Android port of chromium with Ninja
2473         https://bugs.webkit.org/show_bug.cgi?id=87545
2474
2475         Reviewed by Adam Barth.
2476
2477         Ensures that shared libraries are looked up in a generator-agnostic
2478         way and that output is placed in the correct directory.
2479
2480         Depends on http://codereview.chromium.org/10386188/
2481
2482         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2483
2484 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
2485
2486         [Chromium] Chromium DRT should be able to load external resources
2487         https://bugs.webkit.org/show_bug.cgi?id=87893
2488
2489         Reviewed by Dirk Pranke.
2490
2491         Allow external resources to be loaded when the main frame's URL is also an external resource.
2492         This change is analogous to r118231 for Mac port.
2493
2494         * DumpRenderTree/chromium/WebViewHost.cpp:
2495         (blockRequest):
2496         (isLocalhost):
2497         (hostIsUsedBySomeTestsToGenerateError):
2498         (WebViewHost::willSendRequest):
2499
2500 2012-05-31  Anders Carlsson  <andersca@apple.com>
2501
2502         Build fixes.
2503
2504         Disable the C++11 extensions warning.
2505
2506         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2507         * TestWebKitAPI/Configurations/Base.xcconfig:
2508         * WebKitTestRunner/Configurations/Base.xcconfig:
2509
2510 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
2511
2512         [WK2] window.internals settings are not reset between tests
2513         https://bugs.webkit.org/show_bug.cgi?id=87783
2514
2515         Reviewed by Mihai Parparita.
2516
2517         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2518         (WTR::InjectedBundle::done): Call resetAfterTest().
2519
2520         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2521         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
2522         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
2523         This needs to be done after a tets, because the code assumes that there is an object
2524         with this name in global scope.
2525
2526         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2527
2528 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2529
2530         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
2531         https://bugs.webkit.org/show_bug.cgi?id=85006
2532
2533         Reviewed by Tor Arne Vestbø.
2534
2535         Added navigation_policy_decision implementation for DumpRenderTreeView.
2536         Added LayoutTestController::setCustomPolicyDelegate implementation.
2537         Modified LayoutTestController::waitForPolicyDelegate.
2538
2539         * DumpRenderTree/efl/DumpRenderTree.cpp:
2540         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2541         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2542         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
2543         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2544         (navigationTypeToString): aux function
2545         (onNavigationPolicyDecision): navigation_policy_decision implementation
2546         (drtViewAdd):
2547         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2548         (LayoutTestController::setCustomPolicyDelegate):
2549         (LayoutTestController::waitForPolicyDelegate):
2550
2551 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2552
2553         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
2554         https://bugs.webkit.org/show_bug.cgi?id=86195
2555
2556         Reviewed by Gustavo Noronha Silva.
2557
2558         Implement clearApplicationCacheForOrigin in EFL
2559         LayoutTestController.
2560
2561         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2562         (LayoutTestController::clearApplicationCacheForOrigin):
2563
2564 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2565
2566         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
2567         https://bugs.webkit.org/show_bug.cgi?id=87955
2568
2569         Reviewed by Simon Hausmann.
2570
2571         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2572         * DumpRenderTree/qt/EventSenderQt.cpp:
2573         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
2574         * DumpRenderTree/qt/main.cpp:
2575         * QtTestBrowser/cookiejar.cpp:
2576         * QtTestBrowser/launcherwindow.cpp:
2577         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2578         * qmake/mkspecs/features/default_post.prf:
2579
2580 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
2581
2582         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
2583
2584         Rubber-stamped by Kenneth Rohde Christiansen.
2585
2586         * qmake/config.tests/libpng/libpng.pro:
2587
2588 2012-05-30  Peter Beverloo  <peter@chromium.org>
2589
2590         [Chromium] Automatically install 64-bit linker for Android
2591         https://bugs.webkit.org/show_bug.cgi?id=79780
2592
2593         Reviewed by Adam Barth.
2594
2595         Change the update-webkit-chromium script to check whether the 64-bit
2596         linker needs to be installed as part of the update process. The actual
2597         code for doing these checks and "installing" it has been added to the
2598         webkitdirs.pm script.
2599
2600         The linker itself is part of the third_party/aosp repository, which
2601         will be pulled in through the DEPS change.
2602
2603         * Scripts/update-webkit-chromium:
2604         * Scripts/webkitdirs.pm:
2605         (chromiumInstall64BitAndroidLinkerIfNeeded):
2606         (chromiumReplaceAndroidLinkerIfNeeded):
2607
2608 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2609
2610         https://bugs.webkit.org/show_bug.cgi?id=87803
2611         Layout tests often fail trying to stat nonexistent logs 
2612
2613         Reviewed by Dirk Pranke.
2614
2615         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
2616         try/catch block around accessing the logs as a precaution.
2617
2618         * Scripts/webkitpy/common/system/crashlogs.py:
2619         (CrashLogs._find_newest_log_darwin):
2620
2621 2012-05-30  Gavin Peters  <gavinp@chromium.org>
2622
2623         Add a LayoutTest for prerender remove after stop.
2624         https://bugs.webkit.org/show_bug.cgi?id=87860
2625
2626         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
2627         can be tested by LayoutTests now.
2628
2629         Reviewed by Adam Barth.
2630
2631         * DumpRenderTree/DumpRenderTree.gypi:
2632         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
2633         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
2634         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
2635         (MockWebPrerenderingSupport::add):
2636         (MockWebPrerenderingSupport::cancel):
2637         (MockWebPrerenderingSupport::abandon):
2638         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
2639         (MockWebPrerenderingSupport):
2640         * DumpRenderTree/chromium/TestShell.cpp:
2641         (TestShell::initialize):
2642         * DumpRenderTree/chromium/TestShell.h:
2643         (TestShell):
2644         * DumpRenderTree/chromium/WebViewHost.cpp:
2645         (WebViewHost::willAddPrerender):
2646         (WebViewHost::setWebWidget):
2647         * DumpRenderTree/chromium/WebViewHost.h:
2648         (WebViewHost):
2649
2650 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2651
2652         https://bugs.webkit.org/show_bug.cgi?id=87717
2653         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
2654
2655         Reviewed by Dirk Pranke.
2656
2657         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
2658         If there isn't a crash log found for the process add a message saying
2659         the process was unresponsive.
2660
2661         * Scripts/webkitpy/layout_tests/port/webkit.py:
2662         (WebKitDriver.__init__):
2663         (WebKitDriver._check_for_driver_crash):
2664         (WebKitDriver.run_test):
2665         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2666         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
2667         (WebKitDriverTest):
2668         (WebKitDriverTest.test_check_for_driver_crash):
2669         * WebKitTestRunner/TestController.cpp:
2670         (WTR):
2671         (WTR::TestController::runTest):
2672
2673 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2674
2675         https://bugs.webkit.org/show_bug.cgi?id=87714
2676         Mac crash logs can take a really long time to be written out.
2677
2678         Reviewed by Dirk Pranke.
2679
2680         Make a second pass looking for crash logs after the tests have completed running.
2681
2682         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2683         (use_trac_links_in_results_html):
2684         (Manager.run):
2685         * Scripts/webkitpy/layout_tests/port/base.py:
2686         (Port.repository_paths):
2687         (Port.look_for_new_crash_logs):
2688         * Scripts/webkitpy/layout_tests/port/mac.py:
2689         (MacPort.look_for_new_crash_logs):
2690         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2691         (test_get_crash_log):
2692         (test_look_for_new_crash_logs):
2693         (test_look_for_new_crash_logs.fake_time_cb):
2694
2695 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2696
2697         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
2698
2699         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2700         (LayoutWebViewEventHandler::OnAlertEvent):
2701         (LayoutWebViewEventHandler::OnConfirmEvent):
2702         (LayoutWebViewEventHandler):
2703         (LayoutWebViewEventHandler::OnPromptEvent):
2704         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2705         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2706
2707 2012-05-30  Ojan Vafai  <ojan@chromium.org>
2708
2709         Only give lint errors for -expected.png png files that lack a checksum
2710         https://bugs.webkit.org/show_bug.cgi?id=87875
2711
2712         Reviewed by Tony Chang.
2713
2714         We have other pngs in the tree, e.g. for the inspector, that legitimately
2715         lack a checksum.
2716
2717         * Scripts/webkitpy/style/checkers/png.py:
2718         (PNGChecker.check):
2719         * Scripts/webkitpy/style/checkers/png_unittest.py:
2720         (PNGCheckerTest.test_check):
2721
2722 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
2723
2724         nrwt: seems to leak temp dirs
2725         https://bugs.webkit.org/show_bug.cgi?id=87795
2726
2727         Reviewed by Ojan Vafai.
2728
2729         There appears to be a bug where the chromium bots are creating
2730         temporary directories and not cleaning them up that started
2731         after the switch to WebKitDriver. It's possible that __del__
2732         wasn't getting called in a timely manner (or at all), and it's
2733         generally bad style to rely on __del__ being called, so this
2734         code changes things so that we create a temp dir in
2735         driver.start() and remove it in driver.stop(). We could be
2736         paranoid and leave the __del__ code in, but there doesn't seem
2737         to be much advantage to it. If there are bugs that result in
2738         drivers being started but not stopped, we have other problems.
2739
2740         * Scripts/webkitpy/common/system/filesystem_mock.py:
2741         (MockFileSystem.__init__):
2742         (MockFileSystem._mktemp):
2743         (MockFileSystem.mkdtemp):
2744         * Scripts/webkitpy/layout_tests/port/webkit.py:
2745         (WebKitDriver.__init__):
2746         (WebKitDriver._start):
2747         (WebKitDriver.stop):
2748         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2749         (WebKitDriverTest.test_check_for_driver_crash):
2750         (WebKitDriverTest):
2751         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
2752         (WebKitDriverTest.test_stop_cleans_up_properly):
2753
2754 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2755
2756         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
2757         https://bugs.webkit.org/show_bug.cgi?id=86841
2758
2759         Reviewed by Adam Barth.
2760
2761         Print the number of MessagePorts for each new intent in EFL's DRT.
2762         This output is expected by several Web Intents test cases.
2763
2764         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2765         (DumpRenderTreeChrome::onFrameIntentNew):
2766
2767 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2768
2769         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
2770
2771         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2772
2773 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2774
2775         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
2776         https://bugs.webkit.org/show_bug.cgi?id=87829
2777
2778         Reviewed by Adam Barth.
2779
2780         EFL's LayoutTestController now makes uses of the new helper method in
2781         DumpRenderTreeSupportEfl in order to send the intent response. This is
2782         now needed because the Ewk_Intent_Request postResult / postFailure
2783         methods were made private.
2784
2785         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2786         (LayoutTestController::sendWebIntentResponse):
2787
2788 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
2789
2790         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
2791         https://bugs.webkit.org/show_bug.cgi?id=86296
2792
2793         Reviewed by Tony Chang.
2794
2795         * DumpRenderTree/win/DRTDataObject.cpp: Added.
2796         (cfHDropFormat):
2797         (cfFileNameWFormat):
2798         (cfUrlWFormat):
2799         (WCEnumFormatEtc):
2800         (WCEnumFormatEtc::WCEnumFormatEtc):
2801         (WCEnumFormatEtc::QueryInterface):
2802         (WCEnumFormatEtc::AddRef):
2803         (WCEnumFormatEtc::Release):
2804         (WCEnumFormatEtc::Next):
2805         (WCEnumFormatEtc::Skip):
2806         (WCEnumFormatEtc::Reset):
2807         (WCEnumFormatEtc::Clone):
2808         (DRTDataObject::createInstance):
2809         (DRTDataObject::DRTDataObject):
2810         (DRTDataObject::~DRTDataObject):
2811         (DRTDataObject::QueryInterface):
2812         (DRTDataObject::AddRef):
2813         (DRTDataObject::Release):
2814         (DRTDataObject::GetData):
2815         (DRTDataObject::GetDataHere):
2816         (DRTDataObject::QueryGetData):
2817         (DRTDataObject::GetCanonicalFormatEtc):
2818         (DRTDataObject::SetData):
2819         (DRTDataObject::CopyMedium):
2820         (DRTDataObject::EnumFormatEtc):
2821         (DRTDataObject::DAdvise):
2822         (DRTDataObject::DUnadvise):
2823         (DRTDataObject::EnumDAdvise):
2824         (DRTDataObject::clearData):
2825         * DumpRenderTree/win/DRTDataObject.h: Added.
2826         (DRTDataObject):
2827         * DumpRenderTree/win/DRTDropSource.cpp: Added.
2828         (DRTDropSource::DRTDropSource):
2829         (DRTDropSource::~DRTDropSource):
2830         (DRTDropSource::QueryInterface):
2831         (DRTDropSource::AddRef):
2832         (DRTDropSource::Release):
2833         (DRTDropSource::createInstance):
2834         (DRTDropSource::QueryContinueDrag):
2835         (DRTDropSource::GiveFeedback):
2836         * DumpRenderTree/win/DRTDropSource.h: Added.
2837         (DRTDropSource):
2838         * DumpRenderTree/win/DumpRenderTree.vcproj:
2839         * DumpRenderTree/win/EventSender.cpp:
2840         (beginDragWithFilesCallback):
2841
2842 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
2843
2844         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
2845         https://bugs.webkit.org/show_bug.cgi?id=58593
2846
2847         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
2848         to WebKitTestRunner's LayoutTestController. The flag is modified via the
2849         public C API of the WebProcess.
2850
2851         Reviewed by Darin Adler.
2852
2853         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2854         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2855         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
2856         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
2857         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2858
2859 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2860
2861         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
2862         https://bugs.webkit.org/show_bug.cgi?id=87848
2863
2864         Reviewed by Csaba Osztrogonác.
2865
2866         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
2867         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
2868         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
2869
2870         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2871         (DumpRenderTreeChrome::extraViews):
2872         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2873         (DumpRenderTreeChrome):
2874
2875 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2876
2877         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
2878         https://bugs.webkit.org/show_bug.cgi?id=87833
2879
2880         Reviewed by Tor Arne Vestbø.
2881
2882         Print "postProgressFinishedNotification" message if frame load finished 
2883         to unskip http/tests/loading/progress-finished-callback.html.
2884
2885         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2886         (DumpRenderTreeChrome::onFrameLoadFinished):
2887
2888 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
2889
2890         [EFL][WK2] Fix WebKit2-EFL build
2891         https://bugs.webkit.org/show_bug.cgi?id=83693
2892
2893         Reviewed by Carlos Garcia Campos.
2894
2895         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
2896
2897 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
2898
2899         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
2900         (They only used to check for Skipped in platform/qt-5.0-wk1)
2901         https://bugs.webkit.org/show_bug.cgi?id=87376
2902
2903         Reviewed by Csaba Osztrogonác.
2904
2905         * Scripts/old-run-webkit-tests:
2906         (buildPlatformResultHierarchy):
2907         * Scripts/webkitpy/layout_tests/port/qt.py:
2908         (QtPort.baseline_search_path):
2909
2910 2012-05-29  Ojan Vafai  <ojan@chromium.org>
2911
2912         Add a linter error for pngs that lack an embedded checksum
2913         https://bugs.webkit.org/show_bug.cgi?id=87793
2914
2915         Reviewed by Dirk Pranke.
2916
2917         * Scripts/read-checksum-from-png:
2918         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
2919         (read_checksum):
2920         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
2921         (ReadChecksumFromPngTest):
2922         (ReadChecksumFromPngTest.test_read_checksum):
2923         * Scripts/webkitpy/layout_tests/port/base.py:
2924         * Scripts/webkitpy/style/checkers/png.py:
2925         (PNGChecker.check):
2926         * Scripts/webkitpy/style/checkers/png_unittest.py:
2927         (PNGCheckerTest.test_check):
2928
2929 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2930
2931         https://bugs.webkit.org/show_bug.cgi?id=87720
2932         WebProcess is often killed due to being unresponsive on the bots
2933
2934         Reviewed by Alexey Proskuryakov.
2935
2936         Blind attempt to improve flakiness on the bots by reducing the number
2937         of crashes due to an unresponsive process.  This helped on my personal machine
2938         under stress conditions.  I don't have enough cores to hit the problem
2939         under normal conditions.
2940
2941         * WebKitTestRunner/TestController.cpp:
2942         (WTR):
2943
2944 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2945
2946         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
2947         https://bugs.webkit.org/show_bug.cgi?id=87779
2948
2949         Reviewed by Eric Seidel.
2950
2951         Update output to match the names in scm.py as per
2952         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
2953
2954         * Scripts/webkitpy/tool/commands/rebaseline.py:
2955         (RebaselineTest.execute):
2956         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2957         (test_rebaseline_test_and_print_scm_changes):
2958         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2959         (GardeningServerTest.test_rebaselineall):
2960
2961 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2962
2963         https://bugs.webkit.org/show_bug.cgi?id=87711
2964
2965         Reviewed by Jessie Berlin.
2966
2967         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
2968         are better maintained.
2969
2970         * BuildSlaveSupport/build.webkit.org-config/config.json:
2971
2972 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2973
2974         webkit-patch optimize-baselines should add/delete files in batches from the vcs
2975         https://bugs.webkit.org/show_bug.cgi?id=87538
2976
2977         Reviewed by Ojan Vafai.
2978
2979         Invoking git and svn on one file at a time is kinda slow. We
2980         should batch the add and rm operations together.
2981
2982         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2983         (BaselineOptimizer._move_baselines):
2984
2985 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2986
2987         garden-o-matic should rebaseline baselines in parallel
2988         https://bugs.webkit.org/show_bug.cgi?id=87451
2989
2990         Reviewed by Ojan Vafai.
2991                                                                                
2992         This modifies garden-o-matic so that we will fetch all                  
2993         of the baselines in parallel from the bots, and then                    
2994         optimize the baselines serially (since that should be fairly            
2995         quick and we get into trouble if we optimize in parallel due            
2996         to concurrent access to the source control system).                     
2997
2998         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
2999         so that the files that need to be modified in the SCM are returned to 
3000         garden-o-matic rather than actually added or removed. This is done so that
3001         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
3002         concurrently). In order to safely return the files (as a JSON dict) I
3003         needed to shift all of the logging in rebaseline-test to use the logging
3004         module (and hence log to stderr).
3005
3006         I also had to stub out a line in chromium.py that would get confused if
3007         the skia overrides file didn't exist in a mock checkout.
3008
3009         * Scripts/webkitpy/common/system/executive.py:
3010         (Executive.popen):
3011         (Executive):
3012         (Executive.run_in_parallel):
3013         (_run_command_thunk):
3014         * Scripts/webkitpy/common/system/executive_mock.py:
3015         (MockExecutive.run_in_parallel):
3016         * Scripts/webkitpy/common/system/executive_unittest.py:
3017         (ExecutiveTest.test_run_in_parallel):
3018         * Scripts/webkitpy/layout_tests/port/chromium.py:
3019         (ChromiumPort._expectations_file_contents):
3020         * Scripts/webkitpy/tool/commands/rebaseline.py:
3021         (AbstractRebaseliningCommand.__init__):
3022         (RebaselineTest.__init__):
3023         (RebaselineTest._copy_existing_baseline):
3024         (RebaselineTest._save_baseline):
3025         (RebaselineTest):
3026         (RebaselineTest._add_to_scm):
3027         (RebaselineTest._rebaseline_test):
3028         (RebaselineTest.execute):
3029         (RebaselineExpectations._rebaseline_port):
3030         (RebaselineExpectations.execute):
3031         (Rebaseline._builder_to_pull_from):
3032         (Rebaseline.execute):
3033         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3034         (test_rebaseline_updates_expectations_file):
3035         (test_rebaseline_test):
3036         (test_rebaseline_test_and_print_scm_changes):
3037         (test_rebaseline_and_copy_test):
3038         (test_rebaseline_and_copy_test_no_existing_result):
3039         (test_rebaseline_and_copy_test_with_lion_result):
3040         (test_rebaseline_and_copy_no_overwrite_test):
3041         (test_rebaseline_expectations):
3042         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3043         (GardeningHTTPRequestHandler._rebaseline_commands):
3044         (GardeningHTTPRequestHandler):
3045         (GardeningHTTPRequestHandler._files_to_add):
3046         (GardeningHTTPRequestHandler._optimize_baselines):
3047         (GardeningHTTPRequestHandler.rebaselineall):
3048         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3049         (GardeningServerTest._post_to_path):
3050         (GardeningServerTest.test_rebaselineall):
3051         (GardeningServerTest.test_rebaselineall.run_command):
3052
3053 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
3054
3055         Fix the type of dispatch_time() offset
3056
3057         Rubber-stamped by Joseph Pecoraro.
3058
3059         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
3060
3061         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3062         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3063
3064 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
3065
3066         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
3067
3068         [BlackBerry] OpenGL content is not rendered on simulator
3069         https://bugs.webkit.org/show_bug.cgi?id=87721
3070
3071         Reviewed by George Staikos.
3072
3073         Fixed by enabling GLES2 support in simulator builds.
3074
3075         To experiment with building without OpenGL support, you can set the
3076         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
3077
3078         PR #150695
3079
3080         * Scripts/webkitdirs.pm:
3081         (blackberryCMakeArguments):
3082
3083 2012-05-29  David Barr  <davidbarr@chromium.org>
3084
3085         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
3086         https://bugs.webkit.org/show_bug.cgi?id=87685
3087
3088         Reviewed by Eric Seidel.
3089
3090         Add a configuration option for CSS image-resolution support, disabling it by default.
3091
3092         * Scripts/webkitperl/FeatureList.pm:
3093         * qmake/mkspecs/features/features.pri:
3094
3095 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3096
3097         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
3098
3099         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
3100             valid for C++/ObjC++ but not for C [enabled by default]"
3101
3102         Reviewed by Simon Hausmann.
3103
3104         * qmake/mkspecs/features/unix/default_post.prf:
3105
3106 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3107
3108         [Qt] Sync up favicon-implementation with WebView url changes in r118158
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=87133
3111
3112         We now base64-encode the page url in the image-provider url, so that any
3113         normalization done by QUrl will not mess up the page-url. The logic of
3114         creating and parsing the provider-url has been moved into the image
3115         provider, to keep it in one place.
3116
3117         We were also releasing icons (even ones we hadn't retained), which we can't
3118         do since we don't know when the icon url is no longer in use.
3119
3120         Reviewed-by Simon Hausmann.
3121
3122         * MiniBrowser/qt/icons/favicon.png:
3123         * MiniBrowser/qt/qml/BrowserWindow.qml:
3124
3125 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3126
3127         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
3128         https://bugs.webkit.org/show_bug.cgi?id=87654
3129
3130         Reviewed by Csaba Osztrogonác.
3131
3132         Event sender provides strings for all the key events.
3133         Also KeyEventInfo constructor parameters order was changed to simplify the case when
3134         a key event has empty string.
3135
3136         * DumpRenderTree/efl/EventSender.cpp:
3137         (KeyEventInfo::KeyEventInfo):
3138         (keyPadNameFromJSValue):
3139         (keyNameFromJSValue):
3140
3141 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3142
3143         [Qt] Cancel potential url-edit when going back/forward
3144
3145         Reviewed by Kenneth Rohde Christiansen.
3146
3147         * MiniBrowser/qt/qml/BrowserWindow.qml:
3148
3149 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
3150
3151         [EFL] Compilation warning in DumpRenderTreeView.cpp
3152         https://bugs.webkit.org/show_bug.cgi?id=87636
3153
3154         Reviewed by Filip Pizlo.
3155
3156         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
3157         specifier in printf. Also fix the return type for
3158         onExceededApplicationCacheQuota callback.
3159
3160         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3161         (onExceededApplicationCacheQuota):
3162
3163 2012-05-29  Hironori Bono  <hbono@chromium.org>
3164
3165         Adding Hironori Bono to committers.py.
3166         https://bugs.webkit.org/show_bug.cgi?id=87697
3167
3168         * Scripts/webkitpy/common/config/committers.py:
3169
3170 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
3171
3172         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
3173         https://bugs.webkit.org/show_bug.cgi?id=80135
3174
3175         Reviewed by Rob Buis.
3176
3177         Implemented interface function didReceiveAuthenticationChallenge in class
3178         DumpRenderTree.
3179
3180         Resubmit the patch reverted by r115104 after the digest infinite loop
3181         issue for BlackBerry porting get identified and fixed.
3182
3183         Internally reviewed by Joe Mason <jmason@rim.com>
3184
3185         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3186         (drtCredentialDescription):
3187         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
3188         (WebKit):
3189         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3190         (WebCore):
3191         (DumpRenderTree):
3192
3193 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3194
3195         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
3196         https://bugs.webkit.org/show_bug.cgi?id=42328
3197
3198         Reviewed by Eric Seidel.
3199
3200         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
3201         move to windows.internals.settings.
3202
3203         * DumpRenderTree/LayoutTestController.cpp:
3204         (LayoutTestController::staticFunctions):
3205         * DumpRenderTree/LayoutTestController.h:
3206         (LayoutTestController):
3207         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3208         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3209         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3210         (DRTDevToolsAgent):
3211         * DumpRenderTree/chromium/LayoutTestController.cpp:
3212         (LayoutTestController::LayoutTestController):
3213         * DumpRenderTree/chromium/LayoutTestController.h:
3214         (LayoutTestController):
3215         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3216         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3217         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3218         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3219         * DumpRenderTree/mac/DumpRenderTree.mm:
3220         (resetWebViewToConsistentStateBeforeTesting):
3221         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3222         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3223         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3224         (LayoutTestController):
3225         * DumpRenderTree/win/DumpRenderTree.cpp:
3226         (resetWebViewToConsistentStateBeforeTesting):
3227         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3228         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3229         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3230         (LayoutTestController):
3231
3232 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3233
3234         Move allowRoundingHacks to Internals interface
3235         https://bugs.webkit.org/show_bug.cgi?id=87328
3236
3237         Reviewed by Hajime Morita.
3238
3239         Remove allowRoundingHacks functions, because it is able to work in the
3240         cross-port way through the Internals interface.
3241
3242         * DumpRenderTree/LayoutTestController.cpp:
3243         (LayoutTestController::staticFunctions):
3244         * DumpRenderTree/LayoutTestController.h:
3245         (LayoutTestController):
3246         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3247         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3248         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3249         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3250         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3251         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3252
3253 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
3254
3255         Fix mac build with older XCode by defining NSEC_PER_MSEC.
3256         https://bugs.webkit.org/show_bug.cgi?id=87616
3257
3258         Reviewed by Hajime Morita.
3259
3260         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
3261         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
3262         Patch just adds a #ifndef / #define check.
3263
3264         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3265         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3266
3267 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3268
3269         [EFL] Enable blob support for the EFL port
3270         https://bugs.webkit.org/show_bug.cgi?id=85363
3271
3272         Reviewed by Hajime Morita.
3273
3274         Enable Blob support by default for the EFL port.
3275
3276         * Scripts/webkitperl/FeatureList.pm:
3277
3278 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
3279
3280         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
3281         https://bugs.webkit.org/show_bug.cgi?id=87582
3282
3283         Reviewed by Darin Adler.
3284
3285         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
3286         possible to test pages in a similar way as they are loaded in Browsers.
3287
3288         * DumpRenderTree/LayoutTestController.cpp:
3289         (LayoutTestController::LayoutTestController):
3290         (setUseDeferredFrameLoadingCallback):
3291         (LayoutTestController::staticFunctions):
3292         * DumpRenderTree/LayoutTestController.h:
3293         (LayoutTestController::useDeferredFrameLoading):
3294         (LayoutTestController::setUseDeferredFrameLoading):
3295         (LayoutTestController):
3296         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3297         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3298
3299 2012-05-27  David Barton  <dbarton@mathscribe.com>
3300
3301         [watchlist] Improve MathML rule
3302         https://bugs.webkit.org/show_bug.cgi?id=87592
3303
3304         Reviewed by Adam Barth.
3305
3306         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
3307         but if this changed the rule would be slow. We protect against this, clarify the rule,
3308         and make it more similar to existing rules.
3309
3310         * Scripts/webkitpy/common/config/watchlist:
3311
3312 2012-05-27  David Barton  <dbarton@mathscribe.com>
3313
3314         [watchlist] Add myself & a rule for MathML
3315         https://bugs.webkit.org/show_bug.cgi?id=87586
3316
3317         Reviewed by Adam Barth.
3318
3319         * Scripts/webkitpy/common/config/watchlist:
3320
3321 2012-05-26  David Kilzer  <ddkilzer@apple.com>
3322
3323         Use xcrun to find path to nm for Mac port
3324         <http://webkit.org/b/87588>
3325
3326         Reviewed by Dan Bernstein.
3327
3328         * Scripts/webkitpy/layout_tests/port/mac.py:
3329         (MacPort.nm_command): Add. Tries to find a path for the nm
3330         command using xcrun.  Falls back to returning 'nm'.
3331         * Scripts/webkitpy/layout_tests/port/webkit.py:
3332         (WebKitPort.nm_command): Add. Returns 'nm'.
3333         (WebKitPort._webcore_symbols_string): Call self.nm_command().
3334
3335 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
3336
3337         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
3338
3339         Reviewed by Eric Seidel.
3340
3341         * DumpRenderTree/win/DumpRenderTree.vcproj:
3342         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3343         (FrameLoadDelegate::FrameLoadDelegate):
3344         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
3345         * DumpRenderTree/win/FrameLoadDelegate.h:
3346         (FrameLoadDelegate):
3347         * DumpRenderTree/win/TextInputController.cpp: Added.
3348         (setMarkedTextCallback):
3349         (hasMarkedTextCallback):
3350         (unmarkTextCallback):
3351         (markedRangeCallback):
3352         (insertTextCallback):
3353         (firstRectForCharacterRangeCallback):
3354         (selectedRangeCallback):
3355         (TextInputController::makeWindowObject):
3356         (TextInputController::getJSClass):
3357         (TextInputController::staticValues):
3358         (TextInputController::staticFunctions):
3359         * DumpRenderTree/win/TextInputController.h: Added.
3360         (TextInputController):
3361         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
3362         (TextInputController::setMarkedText):
3363         (TextInputController::hasMarkedText):
3364         (TextInputController::unmarkText):
3365         (TextInputController::markedRange):
3366         (TextInputController::insertText):
3367         (TextInputController::firstRectForCharacterRange):
3368         (TextInputController::selectedRange):
3369
3370 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
3371
3372         webkitpy: change scm.add(), scm.delete() to accept multiple paths
3373         https://bugs.webkit.org/show_bug.cgi?id=87528
3374
3375         Reviewed by Ojan Vafai.
3376
3377         launching git or svn for individual files can be slow; this
3378         change will hand multiple paths at once to git and svn so they
3379         can be added in a batch.
3380
3381         * Scripts/webkitpy/common/checkout/scm/git.py:
3382         (Git.add_list):
3383         (Git.delete_list):
3384         * Scripts/webkitpy/common/checkout/scm/scm.py:
3385         (SCM.add):
3386         (SCM):
3387         (SCM.add_list):
3388         (SCM.delete):
3389         (SCM.delete_list):
3390         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3391         (MockSCM.add):
3392         (MockSCM):
3393         (MockSCM.add_list):
3394         (MockSCM.delete):
3395         (MockSCM.delete_list):
3396         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3397         (_shared_test_exists):
3398         (_shared_test_added_files):
3399         (_test_delete_list):
3400         * Scripts/webkitpy/common/checkout/scm/svn.py:
3401         (SVN.add_list):
3402         (SVN.delete_list):
3403
3404 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3405
3406         [NRWT] Add unit testing for perf tests on locked shards
3407         https://bugs.webkit.org/show_bug.cgi?id=87489
3408
3409         Reviewed by Dirk Pranke.
3410
3411         Adding utests that makes sure that perf tests are running in locked
3412         shards and by passing --no-http won't break NRWT (r118421).
3413
3414         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3415         (ShardingTests):
3416         (ShardingTests.test_shard_by_dir):
3417         (ShardingTests.test_shard_every_file):
3418         (ShardingTests.test_shard_in_two):
3419         (ShardingTests.test_multiple_locked_shards):
3420         (LockCheckingManager):
3421         (LockCheckingManager.__init__):
3422         (LockCheckingManager.handle_finished_list):
3423         (ManagerTest.test_http_locking):
3424         (ManagerTest):
3425         (ManagerTest.test_perf_locking):
3426         * Scripts/webkitpy/layout_tests/port/test.py:
3427
3428 2012-05-25  Jessie Berlin  <jberlin@apple.com>
3429
3430         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
3431         https://bugs.webkit.org/show_bug.cgi?id=87511
3432
3433         Reviewed by Alexey Proskuryakov.
3434
3435         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
3436
3437         * DumpRenderTree/win/EventSender.cpp:
3438         (keyDownCallback):
3439
3440 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
3441
3442         Adding Ken Buchanan to committers.py
3443         https://bugs.webkit.org/show_bug.cgi?id=87443
3444
3445         Unreviewed.
3446
3447         Adding self to committers.py as a Committer.
3448
3449         * Scripts/webkitpy/common/config/committers.py:
3450
3451 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
3452
3453         [Qt] Buildfix for newer Qt5
3454         https://bugs.webkit.org/show_bug.cgi?id=87257
3455
3456         Reviewed by Simon Hausmann.
3457
3458         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
3459
3460 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
3461
3462         [Qt] Unreviewed fix after r118484.
3463
3464         Enable CSS_EXCLUSIONS and CSS_REGIONS.
3465         They were enabled uncoditinally before r118484.
3466
3467         * qmake/mkspecs/features/features.pri:
3468
3469 2012-05-24  Tim Horton  <timothy_horton@apple.com>
3470
3471         Add feature defines for web-facing parts of CSS Regions and Exclusions
3472         https://bugs.webkit.org/show_bug.cgi?id=87442
3473         <rdar://problem/10887709>
3474
3475         Reviewed by Dan Bernstein.
3476
3477         * Scripts/webkitperl/FeatureList.pm:
3478
3479 2012-05-24  Hironori Bono  <hbono@chromium.org>
3480
3481         Enable grammar checking on Chromium when we paste text (Take 2)
3482         https://bugs.webkit.org/show_bug.cgi?id=74393
3483
3484         Reviewed by Ryosuke Niwa.
3485
3486         This change enables grammar checking on Chromium and implements a mock grammar
3487         checker to fix a failing test.
3488
3489         * DumpRenderTree/DumpRenderTree.gypi:
3490         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
3491         (MockGrammarCheck::checkGrammarOfString):
3492         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
3493         (WebKit):
3494         (MockGrammarCheck):
3495         * DumpRenderTree/chromium/WebViewHost.cpp:
3496         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
3497
3498 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3499
3500         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
3501         https://bugs.webkit.org/show_bug.cgi?id=86842
3502
3503         Reviewed by Antonio Gomes.
3504
3505         Add support for overriding the application cache support preference
3506         through EFL's LayoutTestController.
3507
3508         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3509         (LayoutTestController::overridePreference):
3510
3511 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3512
3513         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
3514         https://bugs.webkit.org/show_bug.cgi?id=85209
3515
3516         Reviewed by Antonio Gomes.
3517
3518         Set developer extras setting called twice on the test startup. Hence, removing
3519         an unnecessary extra call which set wrong value. 
3520
3521         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3522         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3523
3524 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
3525
3526         garden-o-matic should not fetch from debug bots if it also knows about the release bots
3527         https://bugs.webkit.org/show_bug.cgi?id=86916
3528
3529         Reviewed by Adam Barth.
3530
3531         Note that if release and debug are failing differently, debug
3532         will be ignored ...
3533
3534         Note: also change the use of a fake port name from
3535         "mock-port-name" to "test-mac-leopard" to make it more friendly
3536         to the port factory ("mock" actually is a real port).
3537
3538         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3539         (GardeningHTTPRequestHandler._builders_to_fetch_from):
3540         (GardeningHTTPRequestHandler.rebaselineall):
3541         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3542         (GardeningServerTest.test_rebaselineall):
3543         (GardeningServerTest.test_rebaseline_new_port):
3544
3545 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
3546
3547         nrwt: fix baseline search path for official chrome builders
3548         https://bugs.webkit.org/show_bug.cgi?id=87432
3549
3550         Reviewed by Tony Chang.
3551
3552         The official chrome builders need to use the win7 and SL
3553         baseline paths, not the XP and Leopard paths. Linux is correct.
3554
3555         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3556         (GoogleChromeMacPort.determine_full_port_name):
3557         (GoogleChromeWinPort.determine_full_port_name):
3558         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3559         (TestGoogleChromePort._verify_baseline_search_path_startswith):
3560         (TestGoogleChromePort.test_get_google_chrome_port):
3561
3562 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3563
3564         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
3565         https://bugs.webkit.org/show_bug.cgi?id=86800
3566
3567         Reviewed by Dirk Pranke.
3568
3569         Don't launch a HTTP server with lock based only on the existence of
3570         locked shards since we now run perf on locked shards too.
3571
3572         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3573         (Manager._run_tests):
3574
3575 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
3576
3577         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
3578         https://bugs.webkit.org/show_bug.cgi?id=87128
3579
3580         Reviewed by Dirk Pranke.
3581
3582         * Scripts/webkitpy/layout_tests/port/base.py:
3583         (Port.driver_name):
3584         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3585         (ChromiumLinuxPort._path_to_driver):
3586         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3587         (ChromiumPortTest.test_driver_name_option):
3588         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3589         (ChromiumWinPort._path_to_driver):
3590         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3591         (parse_args):
3592
3593 2012-05-24  John Mellor  <johnme@chromium.org>
3594
3595         Font Boosting: Add compile flag and runtime setting
3596         https://bugs.webkit.org/show_bug.cgi?id=87394
3597
3598         Reviewed by Adam Barth.
3599
3600         Add ENABLE_FONT_BOOSTING.
3601
3602         * Scripts/webkitperl/FeatureList.pm:
3603         * qmake/mkspecs/features/features.pri:
3604
3605 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3606
3607         [EFL] [DRT] keyboard-related tests do not pass
3608         https://bugs.webkit.org/show_bug.cgi?id=85369
3609
3610         Reviewed by Gustavo Noronha Silva.
3611
3612         Add SHIFT modifier for capital letters as VK_ 
3613         codes do not distinguish between lows and caps and also to be consistent
3614         with other ports which send caps as lowercase letters with the shift key down.
3615
3616         * DumpRenderTree/efl/EventSender.cpp:
3617         (keyNameFromJSValue): 
3618
3619 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
3620
3621         [WK2] Let the client give local files universal access on a case by case basis
3622         https://bugs.webkit.org/show_bug.cgi?id=87174
3623         <rdar://problem/11024330>
3624
3625         Reviewed by Maciej Stachowiak.
3626
3627         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
3628         Added initialization of a new structure member to prevent build failure.
3629
3630 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
3631
3632         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
3633         https://bugs.webkit.org/show_bug.cgi?id=87203
3634
3635         Reviewed by Andreas Kling.
3636
3637         Add the required changes to make
3638         fast/events/keydown-leftright-keys.html pass after r118001.
3639
3640         * DumpRenderTree/efl/EventSender.cpp:
3641         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
3642         into the proper X11 keysym definitions.
3643
3644 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3645
3646         Unreviewed, rolling out r118352.
3647         http://trac.webkit.org/changeset/118352
3648         https://bugs.webkit.org/show_bug.cgi?id=87390
3649
3650         Caused 6 editing/spelling tests crash/fail on chromium in
3651         debug. (Requested by vsevik on #webkit).
3652
3653         * DumpRenderTree/DumpRenderTree.gypi:
3654         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
3655         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
3656         * DumpRenderTree/chromium/WebViewHost.cpp:
3657         (WebViewHost::finishLastTextCheck):
3658
3659 2012-05-24  Peter Beverloo  <peter@chromium.org>
3660
3661         Add John Mellor as a contributor
3662         https://bugs.webkit.org/show_bug.cgi?id=87389
3663
3664         Reviewed by Kenneth Rohde Christiansen.
3665
3666         John will be working on Font Boosting and is very involved with various
3667         web-facing subjects of Chrome for Android, such as viewport.
3668
3669         * Scripts/webkitpy/common/config/committers.py:
3670
3671 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3672
3673         [EFL][DRT] LayoutTestController's setCacheModel() implementation
3674         https://bugs.webkit.org/show_bug.cgi?id=86840
3675
3676         Reviewed by Csaba Osztrogonác.
3677
3678         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3679         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
3680         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3681         (LayoutTestController::setCacheModel): Implementation added.
3682
3683 2012-05-24  Hironori Bono  <hbono@chromium.org>
3684
3685         Enable grammar checking on Chromium when we paste text.
3686         https://bugs.webkit.org/show_bug.cgi?id=74393
3687
3688         Reviewed by Hajime Morita.
3689
3690         This change enables grammar checking on Chromium and implements a mock grammar
3691         checker to fix a failing test.
3692
3693         * DumpRenderTree/DumpRenderTree.gypi:
3694         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
3695         (MockGrammarCheck::checkGrammarOfString):
3696         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
3697         (WebKit):
3698         (MockGrammarCheck):
3699         * DumpRenderTree/chromium/WebViewHost.cpp:
3700         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
3701
3702 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
3703
3704         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
3705
3706         * qmake/mkspecs/features/features.pri:
3707
3708 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
3709
3710         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
3711         https://bugs.webkit.org/show_bug.cgi?id=86867
3712
3713         Reviewed by Adam Barth.
3714
3715         Add implementation for sendWebIntentResponse() in EFL's
3716         LayoutTestController and add empty implementation for other ports.
3717
3718         * DumpRenderTree/LayoutTestController.cpp:
3719         (sendWebIntentResponseCallback):
3720         (LayoutTestController::staticFunctions):
3721         * DumpRenderTree/LayoutTestController.h:
3722         (LayoutTestController):
3723         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3724         (LayoutTestController::sendWebIntentResponse):
3725         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3726         (DumpRenderTreeChrome::currentIntentRequest):
3727         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3728         (DumpRenderTreeChrome::onFrameIntentNew):
3729         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3730         (DumpRenderTreeChrome):
3731         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3732         (LayoutTestController::sendWebIntentResponse):
3733         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3734         (LayoutTestController::sendWebIntentResponse):
3735         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3736         (LayoutTestController::sendWebIntentResponse):
3737         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3738         (LayoutTestController::sendWebIntentResponse):
3739         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3740         (LayoutTestController::sendWebIntentResponse):
3741
3742 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
3743
3744         [EFL] The EFL port has no support for title directionality
3745         https://bugs.webkit.org/show_bug.cgi?id=86462
3746
3747         Reviewed by Gustavo Noronha Silva.
3748
3749         Update "title,changed" signal handlers in DRT and EWebLauncher to
3750         reflect the change from const char* to Ewk_Text_With_Direction* type
3751         for the title.
3752
3753         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3754         (DumpRenderTreeChrome::onTitleChanged):
3755         * EWebLauncher/main.c:
3756         (title_set):
3757         (on_title_changed):
3758         (on_key_down):
3759
3760 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3761
3762         Change EFL debug build name with more detail one
3763         https://bugs.webkit.org/show_bug.cgi?id=87254
3764
3765         Reviewed by Ryosuke Niwa.
3766
3767         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
3768         In addition, remove efl-linux-debug triggerable since nobody uses it.
3769
3770         * BuildSlaveSupport/build.webkit.org-config/config.json:
3771
3772 2012-05-23  Kangil Han  <kangil.han@samsung.com>
3773
3774         [EFL][DRT] Fix WebCore library path and rebaseline result
3775         https://bugs.webkit.org/show_bug.cgi?id=86355
3776
3777         Reviewed by Dirk Pranke.
3778
3779         Currently EFL DRT uses wrong WebCore library path when running DRT.
3780         Therefore, this patch adjusted the path correctly.
3781
3782         * Scripts/webkitpy/layout_tests/port/efl.py:
3783         (EflPort._path_to_webcore_library):
3784
3785 2012-05-23  Ojan Vafai  <ojan@chromium.org>
3786
3787         add back the ability to disable flexbox
3788         https://bugs.webkit.org/show_bug.cgi?id=87147
3789
3790         Reviewed by Tony Chang.
3791
3792         * Scripts/webkitperl/FeatureList.pm:
3793
3794 2012-05-23  Tony Chang  <tony@chromium.org>
3795
3796         Remove the Chromium Grid Layout bot from the waterfall
3797         https://bugs.webkit.org/show_bug.cgi?id=87311
3798
3799         Reviewed by Ryosuke Niwa.
3800
3801         I removed the compiler define in r117613, so we don't need a separate
3802         bot to compile/test this code.
3803
3804         * BuildSlaveSupport/build.webkit.org-config/config.json:
3805
3806 2012-05-23  Ian Vollick  <vollick@chromium.org>
3807
3808         Add vollick to list of contributors.
3809         https://bugs.webkit.org/show_bug.cgi?id=87305
3810
3811         Reviewed by Adam Barth.
3812
3813         * Scripts/webkitpy/common/config/committers.py:
3814
3815 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
3816
3817         [Chromium-Android] Fix chromium_android_unittest
3818         https://bugs.webkit.org/show_bug.cgi?id=87196
3819
3820         Reviewed by Tony Chang.
3821
3822         Update unit tests after ChromiumAndroidPort supported apk based
3823         DumpRenderTree.
3824
3825         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3826         (ChromiumAndroidPortTest):
3827         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
3828         (ChromiumAndroidPortTest.test_get_last_stacktrace):
3829         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
3830         (ChromiumAndroidDriverTest):
3831         (ChromiumAndroidDriverTest.setUp):
3832         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
3833         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
3834
3835 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3836
3837         [watchlist] Add myself and create a watch rule to catch Attribute related patches
3838         https://bugs.webkit.org/show_bug.cgi?id=87303
3839
3840         Reviewed by Alexis Menard.
3841
3842         * Scripts/webkitpy/common/config/watchlist:
3843
3844 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
3845
3846         garden-o-matic should not fetch from debug bots if it also knows about the release bots
3847         https://bugs.webkit.org/show_bug.cgi?id=86916
3848
3849         Reviewed by Adam Barth.
3850
3851         This change pushes all of the logic for rebaselining a cluster
3852         of failures (a list of tests failing a list of suffixes on a
3853         list of bots) onto the server, so there is a single call from
3854         the web page; we will then be able to optimize the performance
3855         of the rebaselining better.
3856
3857         Also remove the 'optimizebaseline' entry point on garden-o-matic
3858         (and the client-side call) since we don't need it any more.
3859
3860         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3861         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3862         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3863         (GardeningHTTPRequestHandler.rebaselineall):
3864         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3865
3866 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
3867
3868         Mac DRT should be able to load external URLs for replay performance tests
3869         https://bugs.webkit.org/show_bug.cgi?id=86191
3870
3871         Reviewed by Alexey Proskuryakov.
3872
3873         Let external URL requests go through if the test file is not a local file or hosted at localhost.
3874         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
3875         "DumpRenderTree http://localhost:8000/".
3876
3877         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3878         (isLocalhost):
3879         (hostIsUsedBySomeTestsToGenerateError):
3880         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3881
3882 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
3883
3884         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
3885         debug symbols for easier debugging.
3886         https://bugs.webkit.org/show_bug.cgi?id=87151
3887
3888         Reviewed by Kevin Ollivier.
3889
3890         * waf/build/settings.py:
3891         (common_configure):
3892
3893 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3894
3895         Unreviewed. Move myself to reviewers.
3896
3897         * Scripts/webkitpy/common/config/committers.py:
3898
3899 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
3900
3901         [EFL] Implements the registerProtocolHandler method and option.
3902         https://bugs.webkit.org/show_bug.cgi?id=73638
3903
3904         Reviewed by Andreas Kling.
3905
3906         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
3907
3908 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
3909
3910         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
3911         https://bugs.webkit.org/show_bug.cgi?id=87221
3912
3913         Reviewed by Martin Robinson.
3914
3915         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
3916         rightShift key names into proper GDK key symbols.
3917
3918         * DumpRenderTree/gtk/EventSender.cpp:
3919         (createKeyPressEvent):
3920
3921 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3922
3923         [Qt] Make the web view's url property follow the active url
3924
3925         https://bugs.webkit.org/show_bug.cgi?id=77554
3926
3927         Update  the location bar in the minibrowser to behave
3928         a bit more like normal browsers in terms of when the url will change
3929         and how active focus is handled.
3930
3931         Reviewed by Simon Hausmann.
3932
3933         * MiniBrowser/qt/qml/BrowserWindow.qml:
3934
3935 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3936
3937         [Qt] Remove references to $$QT_SOURCE_TREE
3938
3939         With a modularized Qt, it's ambigious. What we really want is qtbase,
3940         which qtcore is a proxy for (we assume it will always live in qtbase).
3941
3942         Reviewed by Tor Arne Vestbø.
3943
3944         * DumpRenderTree/qt/DumpRenderTree.pro:
3945
3946 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3947
3948         [Qt] Fix qmake conditional for c++-11 compat warnings
3949
3950         Reviewed by Tor Arne Vestbø.
3951
3952         * qmake/mkspecs/features/unix/default_post.prf:
3953
3954 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
3955
3956         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
3957         https://bugs.webkit.org/show_bug.cgi?id=85956
3958
3959         Reviewed by Gustavo Noronha Silva.
3960
3961         Catch new "load,provisional,failed" signal and print
3962         didFailProvisionalLoadWithError messages when LayoutTestController's
3963         dumpFrameLoadCallbacks() returns true. Also make sure the
3964         didFailLoadWithError message is not printed in case of provisional
3965         load failure.
3966
3967         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3968         (DumpRenderTreeChrome::createView):
3969         (DumpRenderTreeChrome::onFrameCreated):
3970         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
3971         (DumpRenderTreeChrome::onFrameLoadError):
3972         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3973         (DumpRenderTreeChrome):
3974
3975 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
3976
3977         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
3978         https://bugs.webkit.org/show_bug.cgi?id=86366
3979
3980         Reviewed by Antonio Gomes.
3981
3982         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
3983
3984         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3985         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3986
3987 2012-05-22  Darin Adler  <darin@apple.com>
3988
3989         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
3990         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
3991
3992 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3993
3994         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
3995         https://bugs.webkit.org/show_bug.cgi?id=86922
3996
3997         Because we have new platformInit() in TestShellAndroid.cpp, and
3998         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
3999         is split into TestShellPosix.cpp and TestShellX11.cpp.
4000
4001         Reviewed by Kent Tamura.
4002
4003         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4004         * DumpRenderTree/DumpRenderTree.gypi:
4005         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
4006         (platformInit):
4007         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
4008         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
4009         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
4010         (AlarmHandler):
4011         (TestShell::waitTestFinished):
4012         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
4013         (openStartupDialog): from TestShellGtk.cpp
4014         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
4015         (setupFontconfig):
4016         (platformInit):
4017
4018 2012-05-22  Kangil Han  <kangil.han@samsung.com>
4019
4020         [EFL][DRT] Implement touch event
4021         https://bugs.webkit.org/show_bug.cgi?id=86720
4022
4023         Reviewed by Hajime Morita.
4024
4025         Currently EFL DRT doesn't support touch event.
4026         Therefore, this patch enabled it and implemented some eventSender function callbacks.
4027
4028         * DumpRenderTree/efl/EventSender.cpp:
4029         (TouchEventInfo::TouchEventInfo):
4030         (TouchEventInfo):
4031         (touchPointList):
4032         (sendTouchEvent):
4033         (addTouchPointCallback):
4034         (touchStartCallback):
4035         (updateTouchPointCallback):
4036         (touchMoveCallback):
4037         (cancelTouchPointCallback):
4038         (touchCancelCallback):
4039         (releaseTouchPointCallback):
4040         (touchEndCallback):
4041         (clearTouchPointsCallback):
4042         (setTouchModifierCallback):
4043         * Scripts/webkitperl/FeatureList.pm:
4044
4045 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
4046
4047         [Chromium-Android] Fix chromium_android_unittest
4048         https://bugs.webkit.org/show_bug.cgi?id=87196
4049
4050         Not reviewed.
4051         Temporarily disable chromium_android_unittest.
4052
4053         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
4054         (ChromiumAndroidPortTest):
4055         (ChromiumAndroidDriverTest):
4056
4057 2012-05-22  Jessie Berlin  <jberlin@apple.com>
4058
4059         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
4060         https://bugs.webkit.org/show_bug.cgi?id=64313
4061
4062         Reviewed by Jon Honeycutt.
4063
4064         Add it.
4065
4066         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4067         Make sure to generate the binding.
4068
4069         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4070         (WTR::LayoutTestController::setDefersLoading):
4071         Call WKBundlePageSetDefersLoading.
4072         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4073
4074 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
4075
4076         [Chromium-Android] Run DumpRenderTree as an apk (python part)
4077         https://bugs.webkit.org/show_bug.cgi?id=86923
4078
4079         chromium_android.py is modified to support running DumpRenderTree as
4080         an apk, so that we can run the tests (e.g. video) requiring features
4081         implemented in Java on Android.
4082
4083         Reviewed by Adam Barth.
4084
4085         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4086         (ChromiumAndroidPort.__init__):
4087         (ChromiumAndroidPort.default_child_processes):
4088         (ChromiumAndroidPort.check_wdiff):
4089         (ChromiumAndroidPort.check_build):
4090         (ChromiumAndroidPort.start_helper):
4091         (ChromiumAndroidPort.skipped_layout_tests):
4092         (ChromiumAndroidPort):
4093         (ChromiumAndroidPort._path_to_driver):
4094         (ChromiumAndroidPort._get_crash_log):
4095         (ChromiumAndroidPort._push_executable):
4096         (ChromiumAndroidPort._run_adb_command):
4097         (ChromiumAndroidPort._get_last_stacktrace):
4098         (ChromiumAndroidPort._get_logcat):
4099         (ChromiumAndroidPort._setup_performance):
4100         (ChromiumAndroidDriver):
4101         (ChromiumAndroidDriver.__init__):
4102         (ChromiumAndroidDriver._command_wrapper):
4103         (ChromiumAndroidDriver.cmd_line):
4104         (ChromiumAndroidDriver._file_exists_on_device):
4105         (ChromiumAndroidDriver._deadlock_detector):
4106         (ChromiumAndroidDriver._start):
4107         (ChromiumAndroidDriver.run_test):
4108         (ChromiumAndroidDriver.stop):
4109         (ChromiumAndroidDriver._write_command_and_read_line):
4110         (ChromiumAndroidDriver._output_image):
4111         (ChromiumAndroidDriver._get_stderr):
4112
4113 2012-05-22  Joshua Bell  <jsbell@chromium.org>
4114
4115         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
4116
4117         Unreviewed gardening.
4118
4119         * Scripts/webkitpy/layout_tests/port/base.py:
4120         (Port.driver_name):
4121         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4122         (ChromiumLinuxPort._path_to_driver):
4123         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4124         (ChromiumPortTest.test_overrides_and_builder_names):
4125         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4126         (ChromiumWinPort._path_to_driver):
4127         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4128         (parse_args):
4129
4130 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
4131
4132         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
4133         https://bugs.webkit.org/show_bug.cgi?id=87176
4134
4135         Reviewed by Tony Chang.
4136
4137         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4138         * DumpRenderTree/DumpRenderTree.gypi:
4139
4140 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
4141
4142         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
4143         https://bugs.webkit.org/show_bug.cgi?id=87128
4144
4145         Reviewed by Dirk Pranke.
4146
4147         * Scripts/webkitpy/layout_tests/port/base.py:
4148         (Port.driver_name):
4149         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4150         (ChromiumLinuxPort._path_to_driver):
4151         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4152         (ChromiumPortTest.test_driver_name_option):
4153         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4154         (ChromiumWinPort._path_to_driver):
4155         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4156         (parse_args):
4157
4158 2012-05-22  Jessie Berlin  <jberlin@apple.com>
4159
4160         WTR fix after r118001.
4161
4162         Rubber-stamped by Alexey Proskuryakov.
4163
4164         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
4165
4166         * WebKitTestRunner/mac/EventSenderProxy.mm:
4167         (WTR::EventSenderProxy::keyDown):
4168
4169 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
4170
4171         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
4172         https://bugs.webkit.org/show_bug.cgi?id=86684
4173
4174         Reviewed by Darin Fisher.
4175
4176         * DumpRenderTree/chromium/LayoutTestController.cpp:
4177         (LayoutTestController::numberOfPages):
4178         * DumpRenderTree/chromium/WebViewHost.cpp:
4179         (WebViewHost::printPage):
4180
4181 == Rolled over to ChangeLog-2012-05-22 ==