Try CRLF to LF change in r139407 again.
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Try CRLF to LF change in r139407 again.
4
5         * BuildSlaveSupport/delete-stale-build-files:
6         (main):
7         (webkitBuildDirectory):
8         * BuildSlaveSupport/kill-old-processes:
9         (main):
10
11 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
12
13         [GTK] Disable the unit tests timeout when running from make check
14         https://bugs.webkit.org/show_bug.cgi?id=106670
15
16         Reviewed by Philippe Normand.
17
18         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
19
20 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
21
22         Yet another unreviewed fix after r139431.
23
24         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
25         the correct order.
26
27 2013-01-11  Dan Carney  <dcarney@google.com>
28
29         [chromium] move some whitespace and resize related methods to TestRunner library
30         https://bugs.webkit.org/show_bug.cgi?id=106655
31
32         Reviewed by Jochen Eisinger.
33
34         * DumpRenderTree/chromium/DRTTestRunner.cpp:
35         (DRTTestRunner::DRTTestRunner):
36         * DumpRenderTree/chromium/DRTTestRunner.h:
37         (DRTTestRunner):
38         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
39         (WebKit):
40         (WebTestRunner::WebTestDelegate::setClientWindowRect):
41         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
42         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
43         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
44         (WebTestRunner::TestRunner::TestRunner):
45         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
46         (WebTestRunner):
47         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
48         (WebTestRunner::TestRunner::enableAutoResizeMode):
49         (WebTestRunner::TestRunner::disableAutoResizeMode):
50         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
51         (TestRunner):
52         * DumpRenderTree/chromium/WebViewHost.cpp:
53         (WebViewHost::setClientWindowRect):
54         * DumpRenderTree/chromium/WebViewHost.h:
55         (WebViewHost):
56
57 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
58
59         Unreviewed. Update my e-mail addresses.
60
61         * Scripts/webkitpy/common/config/committers.py:
62
63 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
64
65         Another unreviewed fix after r139431.
66
67         In a way, this is also a generic bug fix, since previously isEfl()
68         would fail when called from run-efl-tests and we thus did not use
69         jhbuild to run our tests. This now resulted in us calling
70         "jhbuild-wrapper run" without specifying a platform.
71
72         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
73         to work.
74
75 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
76
77         [Qt][WK1] Web Audio support
78         https://bugs.webkit.org/show_bug.cgi?id=106651
79
80         Reviewed by Jocelyn Turcotte.
81
82         Implements support for dumping audio data in DumpRenderTree.
83
84         Adds WebAudio to toggleable features in QtTestBrowser.
85
86         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
87         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
88
89         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
90         (WebCore::DumpRenderTree::dump):
91         * DumpRenderTree/qt/TestRunnerQt.cpp:
92         (TestRunner::reset):
93         (TestRunner::overridePreference):
94         (TestRunner::setAudioData):
95         * DumpRenderTree/qt/TestRunnerQt.h:
96         (TestRunner::shouldDumpAsAudio):
97         (TestRunner::audioData):
98         (TestRunner):
99         * QtTestBrowser/launcherwindow.cpp:
100         (LauncherWindow::applyPrefs):
101         (LauncherWindow::createChrome):
102         (LauncherWindow::toggleWebAudio):
103         * QtTestBrowser/launcherwindow.h:
104         (WindowOptions::WindowOptions):
105         (WindowOptions):
106         (LauncherWindow):
107         * qmake/mkspecs/features/features.prf:
108         * qmake/mkspecs/features/features.pri:
109
110 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
111
112         Unreviewed jhbuild-related fix after r139431.
113
114         * Scripts/webkitpy/layout_tests/port/efl.py:
115         (EflPort.__init__): Pass a string to set_option_default(), since
116         shlex.split() will be called on it later.
117
118 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
119
120         Unreviewed typo fixes after r139431.
121
122         * Scripts/run-javascriptcore-tests:
123
124 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
125
126         [jhbuild] Remove the "run-with-jhbuild" scripts.
127         https://bugs.webkit.org/show_bug.cgi?id=106572
128
129         Reviewed by Martin Robinson.
130
131         Both ports which use jhbuild were mostly duplicating the
132         `run-with-jhbuild' script in their own directories for no clear reason.
133
134         The script itself was just a thin wrapper around the `jhbuild-wrapper',
135         so just start using that directly and get rid of a useless middle man.
136
137         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
138         instead.
139
140         * Scripts/run-javascriptcore-tests:
141         * Scripts/run-launcher:
142         * Scripts/webkitdirs.pm:
143         (runAutogenForAutotoolsProjectIfNecessary):
144         (buildAutotoolsProject):
145         (jhbuildWrapperPrefixIfNeeded):
146         (generateBuildSystemFromCMakeProject):
147         (buildCMakeGeneratedProject):
148         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
149         (run):
150         * Scripts/webkitpy/layout_tests/port/efl.py:
151         (EflPort.__init__):
152         (EflPort._image_diff_command):
153         * efl/run-with-jhbuild: Removed.
154         * gtk/run-with-jhbuild: Removed.
155
156 2013-01-11  Alan Cutter  <alancutter@chromium.org>
157
158         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
159         https://bugs.webkit.org/show_bug.cgi?id=106636
160
161         Reviewed by Adam Barth.
162
163         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
164
165         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
166         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
167         * EWSTools/screen-config:
168         * EWSTools/start-queue.sh:
169
170 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
171
172         kill-old-processes and delete-stale-build-files use CRLF linebreaks
173         https://bugs.webkit.org/show_bug.cgi?id=106622
174
175         Reviewed by Simon Fraser.
176
177         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
178         Also escape clang\+\+ correctly in kill-old-processes.
179
180         * BuildSlaveSupport/delete-stale-build-files:
181         * BuildSlaveSupport/kill-old-processes:
182
183 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
184
185         Build fix after r139357. It was missing a comma.
186
187         * QueueStatusServer/model/queues.py:
188         (Queue):
189
190 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
191
192         Fixing AuthenticationError when running test-webkitpy as a non-committer.
193         https://bugs.webkit.org/show_bug.cgi?id=106420
194
195         Reviewed by Eric Seidel.
196
197         * Scripts/webkitpy/common/checkout/scm/git.py:
198         (Git.push_local_commits_to_server):
199         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
200         * Scripts/webkitpy/common/checkout/scm/svn.py:
201         (SVNRepository):
202         (SVNRepository.has_authorization_for_realm):
203
204 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
205
206         [EFL][jhbuild] Use tarballs for gstreamer instead of git
207         https://bugs.webkit.org/show_bug.cgi?id=106552
208
209         Reviewed by Laszlo Gombos.
210
211         Use tarballs for gstreamer instead of git in EFL's jhbuild
212         to work around intermittent network issues on our build
213         bots. Tarballs are fully cached and require no network
214         operation if their checksum matches.
215
216         * efl/jhbuild.modules:
217
218 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
219
220         Add Mac WK2 EWS bots
221         https://bugs.webkit.org/show_bug.cgi?id=106590
222
223         Reviewed by Adam Barth.
224
225         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
226         Also add a deprecated MacWK2Port class.
227
228         * QueueStatusServer/model/queues.py:
229         (Queue):
230         * Scripts/webkitpy/common/config/ports.py:
231         (DeprecatedPort.port):
232         (MacWK2Port):
233         (MacWK2Port.run_webkit_tests_command):
234         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
235         (MacEWS):
236         (MacWK2EWS):
237         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
238         (_test_ewses):
239
240 2013-01-10  Dan Carney  <dcarney@google.com>
241
242         [chromium] move webpermissionclient related methods to TestRunner library
243         https://bugs.webkit.org/show_bug.cgi?id=106548
244
245         Reviewed by Jochen Eisinger.
246
247         * DumpRenderTree/DumpRenderTree.gypi:
248         * DumpRenderTree/chromium/DRTTestRunner.cpp:
249         (DRTTestRunner::DRTTestRunner):
250         (DRTTestRunner::reset):
251         * DumpRenderTree/chromium/DRTTestRunner.h:
252         (DRTTestRunner):
253         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
254         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
255         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
256         (WebKit):
257         (WebTestRunner::WebTestRunner::webPermissions):
258         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
259         (WebTestRunner::TestRunner::TestRunner):
260         (WebTestRunner::TestRunner::setDelegate):
261         (WebTestRunner):
262         (WebTestRunner::TestRunner::reset):
263         (WebTestRunner::TestRunner::webPermissions):
264         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
265         (WebTestRunner::TestRunner::setImagesAllowed):
266         (WebTestRunner::TestRunner::setScriptsAllowed):
267         (WebTestRunner::TestRunner::setStorageAllowed):
268         (WebTestRunner::TestRunner::setPluginsAllowed):
269         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
270         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
271         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
272         (WebTestRunner):
273         (TestRunner):
274         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
275         (WebTestRunner):
276         (WebTestRunner::WebPermissions::WebPermissions):
277         (WebTestRunner::WebPermissions::~WebPermissions):
278         (WebTestRunner::WebPermissions::allowImage):
279         (WebTestRunner::WebPermissions::allowScriptFromSource):
280         (WebTestRunner::WebPermissions::allowStorage):
281         (WebTestRunner::WebPermissions::allowPlugins):
282         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
283         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
284         (WebTestRunner::WebPermissions::setImagesAllowed):
285         (WebTestRunner::WebPermissions::setScriptsAllowed):
286         (WebTestRunner::WebPermissions::setStorageAllowed):
287         (WebTestRunner::WebPermissions::setPluginsAllowed):
288         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
289         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
290         (WebTestRunner::WebPermissions::setDelegate):
291         (WebTestRunner::WebPermissions::setDumpCallbacks):
292         (WebTestRunner::WebPermissions::reset):
293         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
294         (WebTestRunner):
295         (WebPermissions):
296         * DumpRenderTree/chromium/TestShell.cpp:
297         (TestShell::initialize):
298         (TestShell::resetTestController):
299         (TestShell::createNewWindow):
300         * DumpRenderTree/chromium/TestShell.h:
301         (TestShell):
302         * DumpRenderTree/chromium/WebViewHost.cpp:
303         (WebViewHost::normalizeLayoutTestURL):
304         * DumpRenderTree/chromium/WebViewHost.h:
305         (WebViewHost):
306
307 2013-01-10  Alan Cutter  <alancutter@chromium.org>
308
309         Split EWS tool cold-boot.sh into modular components
310         https://bugs.webkit.org/show_bug.cgi?id=106527
311
312         Reviewed by Adam Barth.
313
314         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
315         Updated GCE bot build scripts to match.
316         Unable to test scripts directly as they depend on being in the repository to work!
317
318         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
319         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
320         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
321         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
322         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
323
324 2013-01-10  Julie Parent  <jparent@chromium.org>
325
326         Dashboard Cleanup: Do not generate the page if we are about to reload.
327         https://bugs.webkit.org/show_bug.cgi?id=106584
328
329         Reviewed by Dirk Pranke.
330
331         Move the logic to determine if we should generate the page into
332         parseParameters() since that is where we have the knowledge to
333         determine it, and return that value to handleLocationChange, 
334         rather than passing the changed parameters back to handleLocationChange
335         and having it make the decision.
336         
337         This is logically equivalent, save one case: when we are about to do
338         a reload, we know that there is no reason to generate the page.  Old
339         code was causing an extra page generation in this case.
340         
341         * TestResultServer/static-dashboards/dashboard_base.js:
342         (parseParameters):
343         (handleLocationChange):
344
345 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
346
347         [jhbuild] Use the "configure" script to build glib
348         https://bugs.webkit.org/show_bug.cgi?id=106569
349
350         Reviewed by Martin Robinson.
351
352         So far both EFL and GTK have been using autogen.sh to build glib.
353         While that does work most of the time, it's not really needed since
354         we are downloading and building stable releases from tarballs.
355         Additionally, autogen.sh fails to work with automake 1.13 due to the
356         usage of some macros that have been removed (this has already been
357         fixed in glib master).
358
359         * efl/jhbuild.modules:
360         * gtk/jhbuild.modules:
361
362 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
363
364         Changing tests to be consistent and use self.scm rather then recreating the scm object.
365         (Missed a couple)
366         https://bugs.webkit.org/show_bug.cgi?id=106536
367
368         Reviewed by Eric Seidel.
369
370         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
371
372 2013-01-10  Tony Chang  <tony@chromium.org>
373
374         Speed up supplemental dependency computation
375         https://bugs.webkit.org/show_bug.cgi?id=106503
376
377         Reviewed by Adam Barth.
378
379         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
380
381         * WebKitTestRunner/CMakeLists.txt:
382
383 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
384
385         Remove the ENABLE_ANIMATION_API feature define occurences
386         https://bugs.webkit.org/show_bug.cgi?id=106544
387
388         Reviewed by Simon Fraser.
389
390         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
391         feature define handling still lingers in various build systems and configurations
392         but is of no use, so it should be removed.
393
394         * Scripts/webkitperl/FeatureList.pm:
395         * qmake/mkspecs/features/features.pri:
396
397 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
398
399         [GTK] Add support for loading web process extensions
400         https://bugs.webkit.org/show_bug.cgi?id=105631
401
402         Reviewed by Gustavo Noronha Silva.
403
404         * MiniBrowser/gtk/GNUmakefile.am:
405         * MiniBrowser/gtk/main.c:
406         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
407         bundle lib from build dir.
408         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
409         located in WebProcess/InjectedBundle/API/gtk.
410         * gtk/generate-gtkdoc:
411         (get_webkit2_options): Scan also files in
412         WebProcess/InjectedBundle/API/gtk to generate API docs.
413         (get_webkit2_options.injected_bundle_src_path): Helper function to
414         build paths in WebProcess/InjectedBundle/API/gtk.
415
416 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
417
418         [EFL][WK2] Writing immediately to created windows (open) fails
419         https://bugs.webkit.org/show_bug.cgi?id=105276
420
421         Reviewed by Kenneth Rohde Christiansen.
422
423         Do not reset 'about:blank' url for the new pages in mini browser.
424
425         * MiniBrowser/efl/main.c:
426         (window_create):
427
428 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
429
430         Changing tests to be consistent and use self.scm rather then recreating the scm object.
431         https://bugs.webkit.org/show_bug.cgi?id=106536
432
433         Reviewed by Eric Seidel.
434
435         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
436
437 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
438
439         Converting to unittest2 so we can use assertItemsEqual, making tests
440         not dependent on order of items.
441         https://bugs.webkit.org/show_bug.cgi?id=106532
442
443         Before:
444         Ran 1733 tests in 38.385s
445         FAILED (failures=1, errors=22)
446
447         After:
448         Ran 1733 tests in 32.298s
449         FAILED (failures=0, errors=22)
450
451         Reviewed by Eric Seidel.
452
453         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
454         * Scripts/webkitpy/thirdparty/__init__.py:
455         (AutoinstallImportHook._install_unittest2):
456
457 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
458
459         [EFL] Add gstreamer 1.0.5 to jhbuild
460         https://bugs.webkit.org/show_bug.cgi?id=106178
461
462         Reviewed by Laszlo Gombos.
463
464         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
465
466         * efl/jhbuild.modules:
467
468 2013-01-09  Alan Cutter  <alancutter@chromium.org>
469
470         Updated parameters in GCE build scripts so they now work.
471         https://bugs.webkit.org/show_bug.cgi?id=106523
472
473         Reviewed by Adam Barth.
474
475         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
476         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
477         * EWSTools/cold-boot.sh:
478
479 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
480
481         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
482         https://bugs.webkit.org/show_bug.cgi?id=106520
483
484         Reviewed by James Robinson.
485
486         Part of a larger refactoring series. See tracking bug 82948.
487
488         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
489         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
490
491 2013-01-09  Julie Parent  <jparent@chromium.org>
492
493         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
494         https://bugs.webkit.org/show_bug.cgi?id=106514
495
496         This is old code, as these can no longer get out of sync.
497         permmaLinkURLHash is generated from currentState, which is set only
498         from the location.  The commment about how these can get out of sync
499         refers to a function that no longer exists.
500         
501         Reviewed by Dirk Pranke.
502
503         * TestResultServer/static-dashboards/dashboard_base.js:
504         (handleLocationChange):
505
506 2013-01-09  Julie Parent  <jparent@chromium.org>
507
508         Dashboard Cleanup: Reload the page as soon as we know we need to.
509         https://bugs.webkit.org/show_bug.cgi?id=106515
510
511         No need to continue parsing all of the data once we know that
512         we need to do a reload.
513         
514         Reviewed by Dirk Pranke.
515
516         * TestResultServer/static-dashboards/dashboard_base.js:
517         (parseParameters):
518
519 2013-01-09  Eric Seidel  <eric@webkit.org>
520
521         run-perf-tests --chromium-android --profile should show symbols for the kernel
522         https://bugs.webkit.org/show_bug.cgi?id=106498
523
524         Reviewed by Adam Barth.
525
526         Turns out this was easy, once I finally read the output from "perf report".
527         It appears there may be a bug in "perf record" on android, as it complains
528         about not being able to read from /proc/kallsyms even when
529         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
530         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
531         but rather just flip it to 0 long enough to grab the /proc/kallsyms
532         and then flip it back to whatever the device had.
533
534         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
535         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
536         to symbol names.  Its world-readable, but will return all 0s if you
537         don't have permission to see the kernel symbols.  kptr_restrict
538         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
539         1 is only a specific group, and 2 is "no one, not even root".
540         By default kptr_restrict is 2 on Android it seems.
541         More kptr_restrict docs: http://lwn.net/Articles/420403/
542
543         I also took this opportunity to clean up how the perf record command
544         was built for use/display in AndroidPerf.profile_after_exit and
545         change to always using long-form names for the arguments (to hopefully help readability).
546
547         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
548         (AndroidPerf.__init__):
549         (profile_after_exit):
550         (ChromiumAndroidDriver.__init__):
551         (ChromiumAndroidDriver._update_kallsyms_cache):
552         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
553
554 2013-01-09  Julie Parent  <jparent@chromium.org>
555
556         Dashboard cleanup: remove dead code.
557         https://bugs.webkit.org/show_bug.cgi?id=106509
558
559         Reviewed by Dirk Pranke.
560
561         * TestResultServer/static-dashboards/dashboard_base.js:
562         (parseParameters):
563
564 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
565
566         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
567         https://bugs.webkit.org/show_bug.cgi?id=105638
568
569         Reviewed by Martin Robinson.
570
571         The test was failing for two reasons:
572         - AccessibilityRenderObject::correspondingLabelForControlElement() was
573           not ignoring the ARIA labelled-by property
574         - AccessibilityController::accessibleElementById() was not implemented
575
576         Because getting an element by ID cannot be done in the UIProcess, the
577         decision was made to expose the element's ID as an accessible attribute
578         of the object.
579
580         In addition, fixing the bug in AccessibilityRenderObject made it possible
581         to eliminate the Gtk platform-specific expectations for another test.
582
583         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
584         (childElementById): Added. Walks the tree looking for the AtkObject
585         Attribute which exposes the HTML element's ID.
586         (AccessibilityController::accessibleElementById): Implemented.
587         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
588         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
589         when there is no title, as is done with the Mac port.
590         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
591         (WTR):
592         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
593         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
594         Attribute which exposes the HTML element's ID.
595         (WTR):
596         (WTR::AccessibilityController::accessibleElementById): Implemented.
597         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
598         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
599         even when there is no title, as is done with the Mac port.
600
601 2013-01-09  Gregg Tavares  <gman@google.com>
602
603         Add Gregg Tavares as a committer
604         https://bugs.webkit.org/show_bug.cgi?id=106492
605
606         Unreviewed.
607
608         * Scripts/webkitpy/common/config/committers.py:
609
610 2013-01-09  Roger Fong  <roger_fong@apple.com>
611
612         Enable seamless iFrames for Windows DRT.
613         https://bugs.webkit.org/show_bug.cgi?id=106468.
614
615         Rubberstamped by Timothy Horton.
616
617         * DumpRenderTree/win/DumpRenderTree.cpp:
618         (resetDefaultsToConsistentValues):
619
620 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
621
622         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
623         https://bugs.webkit.org/show_bug.cgi?id=93979
624
625         Reviewed by Benjamin Poulain.
626
627         Implement eventSender.scheduleAsynchronousKeyDown() in
628         WebKitTestRunner.
629
630         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
631         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
632         (WTR::createKeyDownMessageBody):
633         (WTR::EventSendingController::keyDown):
634         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
635         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
636         (EventSendingController):
637         * WebKitTestRunner/TestController.cpp:
638         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
639         (WTR::TestController::didReceiveMessageFromInjectedBundle):
640         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
641         * WebKitTestRunner/TestController.h:
642         (TestController):
643
644 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
645
646         [chromium] move resource load callback dumping to TestRunner library
647         https://bugs.webkit.org/show_bug.cgi?id=106449
648
649         Reviewed by Adam Barth.
650
651         * DumpRenderTree/chromium/DRTTestRunner.cpp:
652         (DRTTestRunner::DRTTestRunner):
653         (DRTTestRunner::reset):
654         * DumpRenderTree/chromium/DRTTestRunner.h:
655         (DRTTestRunner):
656         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
657         (WebKit):
658         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
659         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
660         (WebKit):
661         (WebTestProxyBase):
662         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
663         (WebTestRunner::WebTestProxy::willRequestResource):
664         (WebTestRunner::WebTestProxy::willSendRequest):
665         (WebTestRunner::WebTestProxy::didReceiveResponse):
666         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
667         (WebTestRunner::WebTestProxy::didFailResourceLoad):
668         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
669         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
670         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
671         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
672         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
673         (WebTestRunner::TestRunner::TestRunner):
674         (WebTestRunner::TestRunner::reset):
675         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
676         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
677         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
678         (WebTestRunner):
679         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
680         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
681         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
682         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
683         (TestRunner):
684         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
685         (WebTestRunner::WebTestProxyBase::reset):
686         (WebTestRunner):
687         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
688         (WebTestRunner::WebTestProxyBase::willRequestResource):
689         (WebTestRunner::WebTestProxyBase::willSendRequest):
690         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
691         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
692         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
693         * DumpRenderTree/chromium/WebViewHost.cpp:
694         (WebViewHost::willSendRequest):
695         (WebViewHost::makeURLErrorDescription):
696         (WebViewHost::reset):
697         * DumpRenderTree/chromium/WebViewHost.h:
698         (WebViewHost):
699
700 2013-01-09  Dan Carney  <dcarney@google.com>
701
702         [chromium] move dumpcreateview methods to testrunner library
703         https://bugs.webkit.org/show_bug.cgi?id=106434
704
705         Reviewed by Adam Barth.
706
707         * DumpRenderTree/chromium/DRTTestRunner.cpp:
708         (DRTTestRunner::DRTTestRunner):
709         (DRTTestRunner::reset):
710         * DumpRenderTree/chromium/DRTTestRunner.h:
711         (DRTTestRunner):
712         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
713         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
714         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
715         (WebTestRunner::TestRunner::TestRunner):
716         (WebTestRunner::TestRunner::reset):
717         (WebTestRunner::TestRunner::shouldDumpCreateView):
718         (WebTestRunner):
719         (WebTestRunner::TestRunner::dumpCreateView):
720         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
721         (TestRunner):
722
723 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
724
725         webkitpy cleanup: Merge additional_comment_text into comment_text
726         https://bugs.webkit.org/show_bug.cgi?id=106421
727
728         Reviewed by Adam Barth.
729
730         * Scripts/webkitpy/common/config/committervalidator.py:
731         (CommitterValidator.reject_patch_from_commit_queue):
732         (CommitterValidator.reject_patch_from_review_queue):
733         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
734         (Bugzilla.set_flag_on_attachment):
735         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
736         (MockBugzilla.set_flag_on_attachment):
737         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
738         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
739         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
740         * Scripts/webkitpy/tool/commands/queues_unittest.py:
741
742 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
743
744         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
745         https://bugs.webkit.org/show_bug.cgi?id=106464
746
747         Reviewed by Martin Robinson.
748
749         Current version in jhbuild.modules (2.26.0) is giving trouble to
750         when trying to build WebKitGTK from scratch, due to a segmentation
751         fault error in gdk-pixbuf-query-loader during the 'make'
752         phase. Raising the version to 2.26.5 fixes this issue.
753
754         * gtk/jhbuild.modules: Version raised, checksums updated.
755
756 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
757
758         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
759         https://bugs.webkit.org/show_bug.cgi?id=90968.
760
761         Reviewed by Csaba Osztrogonác.
762
763         Added functionality in DRT and WTR to use any timeout value while running
764         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
765         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
766         to indicate whether the current port supports setting timeout value
767         per test (it's False by default; I enabled it only on Qt).
768         Also corrected a typo in driver.py
769
770         * DumpRenderTree/DumpRenderTree.h:
771         (TestCommand::TestCommand):
772         (TestCommand):
773         * DumpRenderTree/DumpRenderTreeCommon.cpp:
774         (parseInputLine):
775         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
776         (WebCore::DumpRenderTree::processLine):
777         * Scripts/webkitpy/layout_tests/port/base.py:
778         (Port.supports_per_test_timeout):
779         * Scripts/webkitpy/layout_tests/port/driver.py:
780         (Driver.run_test):
781         (Driver._command_from_driver_input):
782         * Scripts/webkitpy/layout_tests/port/qt.py:
783         (QtPort.supports_per_test_timeout):
784         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
785         (WTR::InjectedBundle::InjectedBundle):
786         (WTR::InjectedBundle::didReceiveMessage):
787         (WTR::InjectedBundle::beginTesting):
788         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
789         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
790         (WTR::TestRunner::setCustomTimeout):
791         (WTR):
792         * WebKitTestRunner/InjectedBundle/TestRunner.h:
793         (TestRunner):
794         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
795         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
796         * WebKitTestRunner/TestController.cpp:
797         (WTR::TestController::TestController):
798         (WTR::TestController::getCustomTimeout):
799         (WTR):
800         (WTR::TestCommand::TestCommand):
801         (TestCommand):
802         (WTR::parseInputLine):
803         (WTR::TestController::runTest):
804         (WTR::TestController::runUntil):
805         * WebKitTestRunner/TestController.h:
806         (TestController):
807         * WebKitTestRunner/TestInvocation.cpp:
808         (WTR::TestInvocation::TestInvocation):
809         (WTR::TestInvocation::setCustomTimeout):
810         (WTR):
811         (WTR::TestInvocation::invoke):
812         * WebKitTestRunner/TestInvocation.h:
813         (TestInvocation):
814
815 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
816
817         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
818         https://bugs.webkit.org/show_bug.cgi?id=106290
819
820         Reviewed by Martin Robinson.
821
822         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
823         the macro isn't enabled.
824
825         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
826
827 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
828
829         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
830         https://bugs.webkit.org/show_bug.cgi?id=103653
831
832         Reviewed by Anders Carlsson.
833
834         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
835         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
836         client callback.
837
838         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
839         methods to the JavaScript API.
840         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
841         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
842         (WTR::TestRunner::setAuthenticationUsername): Ditto.
843         (WTR::TestRunner::setAuthenticationPassword): Ditto.
844         * WebKitTestRunner/InjectedBundle/TestRunner.h:
845         (TestRunner): Added new declarations for the above.
846         * WebKitTestRunner/TestController.cpp:
847         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
848         callback.
849         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
850         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
851         the authentication information passed from the InjectedBundle.
852         * WebKitTestRunner/TestController.h:
853         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
854         to communicate with the TestController.
855         (WTR::TestController::setAuthenticationUsername): Ditto.
856         (WTR::TestController::setAuthenticationPassword): Ditto.
857         (TestController):
858         * WebKitTestRunner/TestInvocation.cpp:
859         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
860         information from the InjectedBundle.
861         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
862         text to the TestInvocation text output.
863         * WebKitTestRunner/TestInvocation.h:
864         (TestInvocation): Added declaration for new method.
865
866 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
867
868         Add myself as a watcher for Web Geolocation
869
870         Unreviewed.
871
872         * Scripts/webkitpy/common/config/watchlist:
873
874 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
875
876         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
877         https://bugs.webkit.org/show_bug.cgi?id=106364
878
879         Reviewed by Eric Seidel.
880
881         When the setup_test_run method is called on the subclasses of the base Port
882         interface, the parent method should also be called via super(), despite the
883         parent method not doing anything at the moment.
884
885         The according calls to super() are required in the ChromiumPort, EflPort
886         and GtkPort implementations.
887
888         * Scripts/webkitpy/layout_tests/port/chromium.py:
889         (ChromiumPort.setup_test_run):
890         * Scripts/webkitpy/layout_tests/port/efl.py:
891         (EflPort.setup_test_run):
892         * Scripts/webkitpy/layout_tests/port/gtk.py:
893         (GtkPort.setup_test_run):
894
895 2013-01-08  Julie Parent  <jparent@chromium.org>
896
897         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
898         https://bugs.webkit.org/show_bug.cgi?id=106356
899
900         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
901         dashboard_base, assigned by Loader, and used only by dashboard_base to
902         create error messages.  Moved the variables to be privates on the Loader
903         object, moved error message creation to _getLoadingErrorMessages on the
904         Loader object, and now pass the errors back to dashboard base via the
905         resourceLoadingComplete callback.
906         
907         Also removed the now unused clearError function, it was only being used
908         by unit tests to clean up global state.
909         
910         Reviewed by Dirk Pranke.
911
912         * TestResultServer/static-dashboards/dashboard_base.js:
913         (resourceLoadingComplete):
914         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
915         * TestResultServer/static-dashboards/loader.js:
916         (.):
917         * TestResultServer/static-dashboards/loader_unittests.js:
918
919 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
920
921         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
922         https://bugs.webkit.org/show_bug.cgi?id=106354
923
924         Reviewed by Eric Seidel.
925
926         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
927         instead of those two inheriting from it. Also add a mock object of the
928         sanitizer that's used in unit tests.
929
930         * Scripts/webkitpy/layout_tests/port/efl.py:
931         (EflPort):
932         (EflPort.__init__):
933         (EflPort.setup_test_run):
934         (EflPort.clean_up_test_run):
935         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
936         importing order.
937         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
938         * Scripts/webkitpy/layout_tests/port/gtk.py:
939         (GtkPort):
940         (GtkPort.__init__):
941         (GtkPort.setup_test_run):
942         (GtkPort.clean_up_test_run):
943         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
944         importing order.
945         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
946         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
947         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
948         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
949         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
950         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
951         (PulseAudioSanitizerMock.unload_pulseaudio_module):
952         (PulseAudioSanitizerMock.restore_pulseaudio_module):
953
954 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
955
956         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
957         https://bugs.webkit.org/show_bug.cgi?id=106324
958
959         Reviewed by Adam Barth.
960
961         Since the frame load callbacks are part of the WebFrameClient, the
962         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
963         methods.
964
965         * DumpRenderTree/chromium/DRTTestRunner.cpp:
966         (DRTTestRunner::DRTTestRunner):
967         (DRTTestRunner::reset):
968         * DumpRenderTree/chromium/DRTTestRunner.h:
969         (DRTTestRunner):
970         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
971         (WebTestInterfaces):
972         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
973         (WebKit):
974         (WebTestProxyBase):
975         (WebTestRunner):
976         (WebTestRunner::WebTestProxy::WebTestProxy):
977         (WebTestProxy):
978         (WebTestRunner::WebTestProxy::didInvalidateRect):
979         (WebTestRunner::WebTestProxy::didScrollRect):
980         (WebTestRunner::WebTestProxy::scheduleComposite):
981         (WebTestRunner::WebTestProxy::scheduleAnimation):
982         (WebTestRunner::WebTestProxy::setWindowRect):
983         (WebTestRunner::WebTestProxy::show):
984         (WebTestRunner::WebTestProxy::didAutoResize):
985         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
986         (WebTestRunner::WebTestProxy::startDragging):
987         (WebTestRunner::WebTestProxy::shouldBeginEditing):
988         (WebTestRunner::WebTestProxy::shouldEndEditing):
989         (WebTestRunner::WebTestProxy::shouldInsertNode):
990         (WebTestRunner::WebTestProxy::shouldInsertText):
991         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
992         (WebTestRunner::WebTestProxy::shouldDeleteRange):
993         (WebTestRunner::WebTestProxy::shouldApplyStyle):
994         (WebTestRunner::WebTestProxy::didBeginEditing):
995         (WebTestRunner::WebTestProxy::didChangeSelection):
996         (WebTestRunner::WebTestProxy::didChangeContents):
997         (WebTestRunner::WebTestProxy::didEndEditing):
998         (WebTestRunner::WebTestProxy::registerIntentService):
999         (WebTestRunner::WebTestProxy::dispatchIntent):
1000         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
1001         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
1002         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
1003         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
1004         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
1005         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
1006         (WebTestRunner::WebTestProxy::didReceiveTitle):
1007         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
1008         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
1009         (WebTestRunner::WebTestProxy::didFailLoad):
1010         (WebTestRunner::WebTestProxy::didFinishLoad):
1011         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
1012         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
1013         (WebTestRunner::WebTestProxy::didRunInsecureContent):
1014         (WebTestRunner::WebTestProxy::didDetectXSS):
1015         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1016         (WebTestRunner::WebTestRunner::setTestIsRunning):
1017         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
1018         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
1019         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1020         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
1021         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
1022         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1023         (WebTestRunner::TestRunner::TestRunner):
1024         (WebTestRunner::TestRunner::reset):
1025         (WebTestRunner::TestRunner::setTestIsRunning):
1026         (WebTestRunner):
1027         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
1028         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
1029         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1030         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
1031         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
1032         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
1033         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
1034         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
1035         (WebTestRunner::TestRunner::dumpTitleChanges):
1036         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1037         (TestRunner):
1038         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1039         (WebTestInterfaces::Internal):
1040         (WebTestRunner::WebTestInterfaces::Internal::webView):
1041         (WebTestRunner::WebTestInterfaces::Internal::Internal):
1042         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
1043         (WebTestRunner):
1044         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
1045         (WebTestRunner::WebTestInterfaces::setWebView):
1046         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
1047         (WebTestRunner::WebTestInterfaces::webView):
1048         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1049         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
1050         (WebTestRunner):
1051         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
1052         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
1053         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
1054         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
1055         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
1056         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1057         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
1058         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
1059         (WebTestRunner::WebTestProxyBase::didFailLoad):
1060         (WebTestRunner::WebTestProxyBase::didFinishLoad):
1061         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
1062         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
1063         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
1064         (WebTestRunner::WebTestProxyBase::didDetectXSS):
1065         * DumpRenderTree/chromium/TestShell.cpp:
1066         (TestShell::runFileTest):
1067         (TestShell::testFinished):
1068         * DumpRenderTree/chromium/TestShell.h:
1069         (TestShell):
1070         * DumpRenderTree/chromium/WebViewHost.cpp:
1071         (WebViewHost::didStartProvisionalLoad):
1072         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1073         (WebViewHost::didFailProvisionalLoad):
1074         (WebViewHost::didCommitProvisionalLoad):
1075         (WebViewHost::didReceiveTitle):
1076         (WebViewHost::didFailLoad):
1077         (WebViewHost::didFinishLoad):
1078         * DumpRenderTree/chromium/WebViewHost.h:
1079         (WebViewHost):
1080
1081 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1082
1083         [GTK] Lower the default timeout value for WebKitTestRunner
1084         https://bugs.webkit.org/show_bug.cgi?id=106353
1085
1086         Reviewed by Dirk Pranke.
1087
1088         The default timeout value for WebKitTestRunner should be lowered.
1089         The current value (80 seconds) is irrational and just leads to producing
1090         text failures for layout tests that genuinely time out. This just leads
1091         to more deviation from the GTK WK1 port in terms of test expectations.
1092
1093         The value used is the same as when running the DumpRenderTree, that's
1094         6 seconds in release builds and 12 seconds in debug builds.
1095
1096         * Scripts/webkitpy/layout_tests/port/gtk.py:
1097         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1098         (GtkPortTest.test_default_timeout_ms):
1099
1100 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1101
1102         test-webkitpy shows failure output on my linux box
1103         https://bugs.webkit.org/show_bug.cgi?id=101261
1104
1105         Reviewed by Eric Seidel.
1106
1107         Mock out the PulseAudioSanitizer methods when creating testing instances
1108         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
1109         PulseAudio output when the sanitizer was trying to unload modules which
1110         were already unloaded by another unit test that was being run in parallel.
1111
1112         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1113         (EflPortTest):
1114         (EflPortTest.make_port):
1115         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1116         (GtkPortTest):
1117         (GtkPortTest.make_port):
1118
1119 2013-01-08  Julie Parent  <jparent@chromium.org>
1120
1121         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
1122         https://bugs.webkit.org/show_bug.cgi?id=106254
1123
1124         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
1125         only to figure out if we should call addBuilderLoadErrors during
1126         handleLocationChange, which was called when the loader completed and on
1127         any hash change, but we only ever wanted to call addBuilderLoadErrors
1128         on the initial loader load.  Moved the call of addBuilderLoadErrors to
1129         resourceLoadingComplete rather than handleLocationChange, so now we
1130         only call it when we want to, and the check can go away completely.
1131
1132         Reviewed by Dirk Pranke.
1133
1134         * TestResultServer/static-dashboards/dashboard_base.js:
1135         (addBuilderLoadErrors):
1136         (resourceLoadingComplete):
1137         (handleLocationChange):
1138         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1139
1140 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
1141
1142         Add aboxhall@chromium.org to accessibility watchlist.
1143
1144         Unreviewed.
1145
1146         * Scripts/webkitpy/common/config/watchlist:
1147
1148 2013-01-08  Dan Winship  <danw@gnome.org>
1149
1150         Add Apache 2.4 support for Fedora 18
1151         https://bugs.webkit.org/show_bug.cgi?id=104478
1152
1153         Reviewed by Martin Robinson.
1154
1155         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
1156         need a separate config.
1157
1158         * Scripts/webkitpy/layout_tests/port/base.py:
1159         (Port._apache_version):
1160         (Port._apache_config_file_name_for_platform):
1161         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1162         * Scripts/run-webkit-httpd:
1163         * Scripts/webkitperl/httpd.pm:
1164         (getApacheVersion):
1165         (getDefaultConfigForTestDirectory):
1166         (getHTTPDConfigPathForTestDirectory):
1167
1168 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1169
1170         Make the override-feature-defines script compatible with Python v3
1171         https://bugs.webkit.org/show_bug.cgi?id=105742
1172
1173         Reviewed by Martin Robinson.
1174
1175         Instead of printing output through a statement, use the print function and format
1176         the output using the str.format method. This makes the script runnable with Python v3.
1177
1178         * gtk/override-feature-defines:
1179         (adjust_feature_defines_makefile):
1180
1181 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
1182
1183         [Qt] Fix libxml2 config test
1184         https://bugs.webkit.org/show_bug.cgi?id=106317
1185
1186         Reviewed by Simon Hausmann.
1187
1188         Don't assume standard include/libxml2, libxml-2.0.pc should know
1189         where it's headers are.
1190
1191         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
1192
1193 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1194
1195         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
1196         https://bugs.webkit.org/show_bug.cgi?id=106195
1197
1198         Reviewed by Philippe Normand.
1199
1200         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
1201         to make the Python code compatible with Python 3. This includes modifying
1202         print statements, exception handling, dictionary iteration and
1203         byte-sequence-to-string conversion.
1204
1205         * gtk/common.py:
1206         (get_build_path):
1207         (pkg_config_file_variable):
1208         (gtk_version_of_pkg_config_file):
1209         * gtk/generate-gtkdoc:
1210         (print_missing_api):
1211         * gtk/gtkdoc.py:
1212         (GTKDoc.__init__):
1213         (GTKDoc._run_command):
1214
1215 2013-01-02  Steve Block  <steveblock@chromium.org>
1216
1217         Add chromium.org email address for Steve Block.
1218
1219         Unreviewed.
1220
1221         * Scripts/webkitpy/common/config/committers.py:
1222
1223 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
1224
1225         Rationalize closure call heuristics and profiling
1226         https://bugs.webkit.org/show_bug.cgi?id=106270
1227
1228         Reviewed by Oliver Hunt.
1229         
1230         Add ability to use display-profiler-output via a pipe, and add the ability to dump
1231         all generated code ('display *' or 'd *').
1232
1233         * Scripts/display-profiler-output:
1234
1235 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1236
1237         Sorted more xcodeproj files.
1238
1239         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1241         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1242
1243 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1244
1245         Sorted xcodeproj files.
1246
1247         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1248         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1249
1250 2013-01-07  Dan Bernstein  <mitz@apple.com>
1251
1252         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
1253         https://bugs.webkit.org/show_bug.cgi?id=106261
1254
1255         Reviewed by Simon Fraser.
1256
1257         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
1258
1259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1260         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
1261         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
1262         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
1263         (TestWebKitAPI):
1264         (TestWebKitAPI::TEST):
1265
1266 2013-01-07  Ojan Vafai  <ojan@chromium.org>
1267
1268         Add the Apple MountainLion bots to garden-o-matic.
1269         Eventually, we really should move away from hardcoding
1270         the list of bots.
1271
1272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1273
1274 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1275
1276         [chromium] move web audio related methods to testrunner library
1277         https://bugs.webkit.org/show_bug.cgi?id=106211
1278
1279         Reviewed by Adam Barth.
1280
1281         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1282         (DRTTestRunner::DRTTestRunner):
1283         (DRTTestRunner::reset):
1284         * DumpRenderTree/chromium/DRTTestRunner.h:
1285         (DRTTestRunner):
1286         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1287         (WebKit):
1288         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
1289         (WebTestRunner::WebTestRunner::audioData):
1290         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1291         (WebTestRunner::TestRunner::TestRunner):
1292         (WebTestRunner::TestRunner::reset):
1293         (WebTestRunner::TestRunner::shouldDumpAsAudio):
1294         (WebTestRunner):
1295         (WebTestRunner::TestRunner::audioData):
1296         (WebTestRunner::TestRunner::setAudioData):
1297         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1298         (TestRunner):
1299         * DumpRenderTree/chromium/TestShell.cpp:
1300         (TestShell::dump):
1301
1302 2013-01-07  Mike West  <mkwst@chromium.org>
1303
1304         Make the IFRAME_SEAMLESS flag runtime-enabled.
1305         https://bugs.webkit.org/show_bug.cgi?id=106213
1306
1307         Reviewed by Ojan Vafai.
1308
1309         * DumpRenderTree/chromium/TestShell.cpp:
1310         (TestShell::TestShell):
1311         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1312         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1313         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1314         (resetDefaultsToConsistentValues):
1315         * DumpRenderTree/mac/DumpRenderTree.mm:
1316         (resetDefaultsToConsistentValues):
1317         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1318         (WebCore::WebPage::resetSettings):
1319         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1320         (WTR::InjectedBundle::beginTesting):
1321             Ensure that seamless IFrames are enabled for layout tests in each of
1322             the ports that support seamless IFrames.
1323
1324 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1325
1326         [chromium] move dumpAsText and friends to the TestRunner library
1327         https://bugs.webkit.org/show_bug.cgi?id=106222
1328
1329         Reviewed by Adam Barth.
1330
1331         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
1332
1333         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1334         (DRTTestRunner::DRTTestRunner):
1335         (DRTTestRunner::reset):
1336         * DumpRenderTree/chromium/DRTTestRunner.h:
1337         (DRTTestRunner):
1338         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1339         (WebTestRunner::WebTestRunner::shouldDumpAsText):
1340         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
1341         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
1342         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
1343         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
1344         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
1345         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1346         (WebTestRunner::TestRunner::TestRunner):
1347         (WebTestRunner::TestRunner::reset):
1348         (WebTestRunner::TestRunner::shouldDumpAsText):
1349         (WebTestRunner):
1350         (WebTestRunner::TestRunner::setShouldDumpAsText):
1351         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
1352         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
1353         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
1354         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
1355         (WebTestRunner::TestRunner::dumpAsText):
1356         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
1357         (WebTestRunner::TestRunner::dumpChildFramesAsText):
1358         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1359         (TestRunner):
1360
1361 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1362
1363         Build fix attempt after r138810.
1364
1365         Apparently python 2.6 is really bad at floating point computation.
1366
1367         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1368         (MainTest.test_run_memory_test):
1369
1370 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1371
1372         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
1373         https://bugs.webkit.org/show_bug.cgi?id=106172
1374
1375         Reviewed by Tony Chang.
1376
1377         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
1378         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
1379         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
1380         test on perf-o-matic and perf. test's results page.
1381
1382         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
1383
1384         * Scripts/webkitpy/performance_tests/perftest.py:
1385         (PerfTestMetric): Added.
1386         (PerfTestMetric.__init__): Added.
1387         (PerfTestMetric.metric): Added.
1388         (PerfTestMetric.has_values): Added.
1389         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
1390         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
1391         conversions to be done on the client side (perf-o-matic and results page).
1392         (PerfTestMetric.append): Added.
1393         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
1394         a result for this metric.
1395         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
1396         (PerfTestMetric.compute_statistics): Moved from PerfTest.
1397
1398         (PerfTest._create_driver): Extracted from PerfTest.run.
1399         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
1400         as needed.
1401         (PerfTest._run_with_driver):
1402         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
1403         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
1404         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
1405
1406         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
1407         from other perf tests, there isn't much point in sharing the code here.
1408
1409         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
1410         statistics for the measured values.
1411
1412         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1413         (TestPerfTestMetric): Added.
1414         (TestPerfTestMetric.test_init_set_missing_unit): Added.
1415         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
1416         (TestPerfTestMetric.test_has_values): Added.
1417         (TestPerfTestMetric.test_append): Added.
1418         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
1419         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
1420
1421         (TestPerfTest._assert_results_are_correct): Updated as needed.
1422         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
1423         in PerfTest.run now after generating the results dictionary.
1424         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
1425
1426 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
1427
1428         Support size_t multiplication and division operators on LayoutUnit
1429         https://bugs.webkit.org/show_bug.cgi?id=83848
1430
1431         Reviewed by Emil A Eklund.
1432
1433         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1434         Added some simple tests for the new operators using size_t.
1435
1436 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1437
1438         [Qt] run-webkit-tests cleanup for parallel NRWT
1439         https://bugs.webkit.org/show_bug.cgi?id=106220
1440
1441         Reviewed by Dirk Pranke.
1442
1443         * Scripts/run-webkit-tests:
1444         (useNewRunWebKitTests):
1445         * Scripts/webkitpy/layout_tests/port/qt.py:
1446         (QtPort):
1447         (QtPort.default_child_processes):
1448
1449 2013-01-07  Philippe Normand  <pnormand@igalia.com>
1450
1451         Create a GStreamerAudio watchlist and add myself to it.
1452
1453         Unreviewed.
1454
1455         * Scripts/webkitpy/common/config/watchlist:
1456
1457 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
1458
1459         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
1460         Also removed the empty mac directory.
1461
1462         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
1463         * BuildSlaveSupport/download-built-product: Added property svn:executable.
1464         * BuildSlaveSupport/mac: Removed.
1465         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
1466
1467 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1468
1469         Add a script to delete stale zero-byte build files
1470         https://bugs.webkit.org/show_bug.cgi?id=106131
1471
1472         Reviewed by Tony Chang.
1473
1474         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
1475
1476         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1477         (DeleteStaleBuildFiles): Added.
1478         (Factory.__init__): Add DeleteStaleBuildFiles step.
1479         * BuildSlaveSupport/delete-stale-build-files: Added.
1480         (main): Delete zero-byte files except ones intentionally generated by our build process.
1481         (webkitBuildDirectory): Copied from build-product-archive.
1482
1483 2013-01-04  Michael Pruett  <michael@68k.org>
1484
1485         [GTK] Fix build error on GTK due to r138836
1486         https://bugs.webkit.org/show_bug.cgi?id=106154
1487
1488         Reviewed by Kentaro Hara.
1489
1490         * GNUmakefile.am:
1491
1492 2013-01-04  Dan Bernstein  <mitz@apple.com>
1493
1494         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
1495         https://bugs.webkit.org/show_bug.cgi?id=106121
1496
1497         Reviewed by Adele Peterson.
1498
1499         Added test for -[DOMTHMLTableCellElement _cellAbove].
1500
1501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1502         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
1503         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
1504         (TestWebKitAPI):
1505         (TestWebKitAPI::expectCellAboveCell):
1506         (TestWebKitAPI::TEST):
1507         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
1508
1509 2013-01-04  Eric Seidel  <eric@webkit.org>
1510
1511         FlakyTestReporter should be re-enabled and taught how to post patches
1512         https://bugs.webkit.org/show_bug.cgi?id=103839
1513
1514         Reviewed by Adam Barth.
1515
1516         This moves LayoutTestResultsReader off of the DeprecatedPort object.
1517         It also adds a real Port object to the EWS and CommitQueue objects
1518         using a new PatchProcessingQueue superclass.
1519         PatchProcessingQueue doesn't seem to be the cleanest insertion point
1520         but works for this purpose.
1521         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
1522         to resolve a FIXME.
1523
1524         This required some hacks/shiming between the non-specific "old"
1525         port names which the EWS system is currently using, and the new
1526         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
1527
1528         Hopefully this will fix the flaky test reporter and results uploading.
1529         Certainly it's another small step towards getting rid of the old ports.py
1530         infrastructure and making the NRWT Port class common webkitpy infrastructure.
1531
1532         Now that DeprecatedPort is no longer used for the results directory
1533         I removed all the explicit results-dir code which webkit-patch was using
1534         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
1535
1536         * Scripts/webkitpy/common/config/ports.py:
1537         (DeprecatedPort.run_perl_unittests_command):
1538         * Scripts/webkitpy/common/config/ports_mock.py:
1539         (MockPort.name):
1540         * Scripts/webkitpy/common/system/outputcapture.py:
1541         (OutputCapture.assert_outputs):
1542         * Scripts/webkitpy/layout_tests/port/apple.py:
1543         (ApplePort.determine_full_port_name):
1544         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1545         (LayoutTestResultsReader.__init__):
1546         (LayoutTestResultsReader):
1547         (LayoutTestResultsReader._read_file_contents):
1548         (LayoutTestResultsReader._create_layout_test_results):
1549         (LayoutTestResultsReader._create_unit_test_results):
1550         (LayoutTestResultsReader.results):
1551         (LayoutTestResultsReader.archive):
1552         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1553         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1554         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1555         (test_missing_unit_test_results_path):
1556         (test_layout_test_results):
1557         (test_archive_last_layout_test_results):
1558         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1559         (AbstractEarlyWarningSystem):
1560         (AbstractEarlyWarningSystem.__init__):
1561         (AbstractEarlyWarningSystem.begin_work_queue):
1562         (AbstractEarlyWarningSystem.run_command):
1563         * Scripts/webkitpy/tool/commands/queues.py:
1564         (AbstractPatchQueue.work_item_log_path):
1565         (PatchProcessingQueue):
1566         (PatchProcessingQueue._new_port_name_from_old):
1567         (PatchProcessingQueue.begin_work_queue):
1568         (PatchProcessingQueue._upload_results_archive_for_patch):
1569         (CommitQueue):
1570         (CommitQueue.begin_work_queue):
1571         (CommitQueue.run_command):
1572         (AbstractReviewQueue):
1573         (AbstractReviewQueue.__init__):
1574         (AbstractReviewQueue.begin_work_queue):
1575         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1576         (AbstractPatchQueueTest.test_next_patch):
1577         (PatchProcessingQueueTest):
1578         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1579         * Scripts/webkitpy/tool/steps/runtests.py:
1580         (RunTests.run):
1581         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1582
1583 2013-01-04  Dana Jansens  <danakj@chromium.org>
1584
1585         [chromium] Remove lost-compositor-context layout tests
1586         https://bugs.webkit.org/show_bug.cgi?id=106089
1587
1588         Reviewed by James Robinson.
1589
1590         Remove the loseCompositorContext() test function.
1591
1592         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1593         (WebTestRunner::TestRunner::TestRunner):
1594         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1595         (TestRunner):
1596
1597 2013-01-04  Adam Klein  <adamk@chromium.org>
1598
1599         Remove ENABLE_MUTATION_OBSERVERS #define
1600         https://bugs.webkit.org/show_bug.cgi?id=105459
1601
1602         Reviewed by Ryosuke Niwa.
1603
1604         * Scripts/webkitperl/FeatureList.pm:
1605         * qmake/mkspecs/features/features.pri:
1606
1607 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1608
1609         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
1610         https://bugs.webkit.org/show_bug.cgi?id=106078
1611
1612         Reviewed by Tony Chang.
1613
1614         This patch updates values for individual iterations in dummy performance tests used in
1615         perftest_unittest.py and perftest_integrationtest.py so that they match up with
1616         statistics such as stdev and median reported in those tests. This change is required
1617         to resolve the bug 97510.
1618
1619         This patch also refactors integration tests by extracting *TestData classes that
1620         centralizes the definitions of each dummy performance test's text (DRT output),
1621         runner output, and parsed results (JSON) so that we may share more data between
1622         python tests.
1623
1624         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1625         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
1626         Use self.assertAlmostEqual when comparing the standard deviation.
1627         (MainTest.test_parse_output):
1628         (test_parse_output_with_failing_line):
1629         (test_parse_output_with_description): Use _assert_results_are_correct.
1630         (test_parse_output_with_subtests): Ditto.
1631
1632         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1633         (InspectorPassTestData): Extracted from tests below.
1634         (EventTargetWrapperTestData): Ditto.
1635         (SomeParserTestData): Ditto.
1636         (MemoryTestData): Ditto.
1637         (TestDriver.run_test): Moved test definitions out of the method.
1638         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
1639         (MainTest._load_output_json): Extracted from create_runner.
1640         (MainTest.create_runner):
1641         (MainTest.test_run_test_set_for_parser_tests):
1642         (MainTest.test_run_memory_test):
1643         (MainTest._test_run_with_json_output):
1644         (MainTest.test_run_with_json_output):
1645         (MainTest.test_run_with_description):
1646         (MainTest.test_run_generates_json_by_default):
1647         (MainTest.test_run_merges_output_by_default):
1648         (MainTest.test_run_respects_reset_results):
1649         (MainTest.test_run_generates_and_show_results_page):
1650         (MainTest.test_run_with_slave_config_json):
1651         (MainTest.test_run_with_multiple_repositories):
1652
1653 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
1654
1655         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
1656         https://bugs.webkit.org/show_bug.cgi?id=106045
1657
1658         Reviewed by Carlos Garcia Campos.
1659
1660         Update test results to confirm that compositions without preedits do not trigger
1661         a composition confirmation.
1662
1663         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
1664         (TestWebKitAPI::verifyCanceledComposition):
1665
1666 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
1667
1668         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
1669         https://bugs.webkit.org/show_bug.cgi?id=105958
1670
1671         Reviewed by Alexey Proskuryakov.
1672
1673         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
1674
1675         * WebKitTestRunner/mac/EventSenderProxy.mm:
1676         (KeyMappingEntry):
1677         (WTR):
1678         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
1679
1680 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
1681
1682         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
1683         https://bugs.webkit.org/show_bug.cgi?id=106073
1684
1685         Reviewed by Ryosuke Niwa.
1686
1687         Check that the element being compared to is not nil. 
1688         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
1689         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
1690         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
1691         sometimes before on parallel WebKitTestRunner runs.
1692
1693         * DumpRenderTree/AccessibilityUIElement.cpp:
1694         (AccessibilityUIElement::isEqual):
1695         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1696         (WTR::AccessibilityUIElement::isEqual):
1697
1698 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1699
1700         Downloads can be flaky, so try downloading multiple times.
1701         https://bugs.webkit.org/show_bug.cgi?id=105976
1702
1703         Reviewed by Eric Seidel.
1704
1705         * Scripts/webkitpy/common/system/autoinstall.py:
1706         (AutoInstaller._download_to_stream):
1707
1708 2013-01-03  Eric Seidel  <eric@webkit.org>
1709
1710         Rename Tool.port to deprecated_port in preparation for removing more callers
1711         https://bugs.webkit.org/show_bug.cgi?id=106076
1712
1713         Reviewed by Ryosuke Niwa.
1714
1715         This resolves a long-standing FIXME to rename this method. :)
1716
1717         * Scripts/webkitpy/tool/bot/botinfo.py:
1718         (BotInfo.summary_text):
1719         * Scripts/webkitpy/tool/bot/irc_command.py:
1720         (Rollout._update_working_copy):
1721         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1722         (LayoutTestResultsReader._create_layout_test_results):
1723         (LayoutTestResultsReader._create_unit_test_results):
1724         (LayoutTestResultsReader._results_directory):
1725         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1726         (test_missing_unit_test_results_path):
1727         * Scripts/webkitpy/tool/main.py:
1728         (WebKitPatch.deprecated_port):
1729         * Scripts/webkitpy/tool/mocktool.py:
1730         (MockTool.deprecated_port):
1731         * Scripts/webkitpy/tool/steps/build.py:
1732         (Build.build):
1733         * Scripts/webkitpy/tool/steps/checkstyle.py:
1734         (CheckStyle.run):
1735         * Scripts/webkitpy/tool/steps/commit.py:
1736         (Commit._check_test_expectations):
1737         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1738         (PrepareChangeLog.run):
1739         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1740         (PrepareChangeLogForDEPSRoll.run):
1741         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1742         (PrepareChangeLogForRevert.run):
1743         * Scripts/webkitpy/tool/steps/runtests.py:
1744         (RunTests.run):
1745         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1746         (StepsTest.test_runtests_args):
1747         * Scripts/webkitpy/tool/steps/update.py:
1748         (Update._update_command):
1749
1750 2013-01-03  Eric Seidel  <eric@webkit.org>
1751
1752         Add myself to the webkitpy watchlist.
1753
1754         Unreviewed.
1755
1756         * Scripts/webkitpy/common/config/watchlist:
1757
1758 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1759
1760         Cleanup perftest* tests and add a test for computing statistics
1761         https://bugs.webkit.org/show_bug.cgi?id=105685
1762
1763         Reviewed by Eric Seidel.
1764
1765         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
1766         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
1767
1768         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
1769
1770         * Scripts/webkitpy/performance_tests/perftest.py:
1771         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
1772         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
1773         accurate result for the mean.
1774         (PageLoadingPerfTest.run_single):
1775         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1776         (MainTest.test_compute_statistics):
1777         (MainTest.test_compute_statistics.compute_statistics): Added.
1778         (TestPageLoadingPerfTest.test_run): floatify values.
1779         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
1780         correctly recognizes them as integers.
1781
1782         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
1783         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
1784         (TestDriver): Moved out of MainTest.
1785         (MainTest): Got rid of assertWritten and all unit tests.
1786         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
1787         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1788         (MainTest.test_run_test_set_for_parser_tests):
1789         (MainTest.test_run_memory_test):
1790         (MainTest._test_run_with_json_output):
1791         (MainTest.test_run_generates_json_by_default):
1792         (MainTest.test_run_merges_output_by_default):
1793         (MainTest.test_run_respects_reset_results):
1794         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
1795         parsing output JSON files. Just verify that the output path is correct instead.
1796         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1797         (MainTest): Removed all integration tests.
1798         (MainTest.create_runner): Simplified.
1799
1800 2013-01-03  Julie Parent  <jparent@chromium.org>
1801
1802         Dashboard cleanup: remove usage of global g_defaultBuilderName
1803         https://bugs.webkit.org/show_bug.cgi?id=106043
1804
1805         Use now public defaultBuilder() from the BuilderGroup, rather
1806         than global variable.
1807
1808         Also eliminates the setup() and initBuilders() functions since we
1809         no longer need to track the global.
1810
1811         Reviewed by Adam Barth.
1812
1813         * TestResultServer/static-dashboards/builders.js:
1814         (BuilderGroup.prototype.defaultBuilder):
1815         (BuilderGroup.prototype.master):
1816         * TestResultServer/static-dashboards/dashboard_base.js:
1817         (parseParameters):
1818         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1819         (updateDefaultBuilderState):
1820         * TestResultServer/static-dashboards/loader.js:
1821         (.):
1822         * TestResultServer/static-dashboards/loader_unittests.js:
1823
1824 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1825
1826         Disable an intermittently failing unit test for now.
1827         The failure is tracked by the bug 106051.
1828
1829         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1830         (TestWebKitAPI::TEST):
1831
1832 2013-01-03  Dan Bernstein  <mitz@apple.com>
1833
1834         No way to obtain a DOMNode given a JS wrapper for a Node
1835         https://bugs.webkit.org/show_bug.cgi?id=106033
1836
1837         Added a test for +[DOMNode _nodeFromJSWrapper:].
1838
1839         Reviewed by Sam Weinig.
1840
1841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1842         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
1843         (TestWebKitAPI):
1844         (TestWebKitAPI::TEST):
1845
1846 2013-01-03  Emil A Eklund  <eae@chromium.org>
1847
1848         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
1849         https://bugs.webkit.org/show_bug.cgi?id=105961
1850
1851         Reviewed by Levi Weintraub.
1852         
1853         Add tests for LayoutUnit::ceil and floor.
1854
1855         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1856         (TestWebKitAPI::TEST):
1857         (TestWebKitAPI):
1858
1859 2013-01-03  Julie Parent  <jparent@chromium.org>
1860
1861         Add unit test for default builder for the dashboards.
1862         https://bugs.webkit.org/show_bug.cgi?id=105972
1863
1864         Reviewed by Dirk Pranke.
1865
1866         * TestResultServer/static-dashboards/loader_unittests.js:
1867
1868 2013-01-03  Tony Chang  <tony@chromium.org>
1869
1870         Generate internal.settings from Settings.in
1871         https://bugs.webkit.org/show_bug.cgi?id=104740
1872
1873         Reviewed by Adam Barth.
1874
1875         * GNUmakefile.am: Compile new generated files on GTK+.
1876         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1877         with both extra_sources and add_output_to_sources=false will still
1878         compile the files in extra_sources. This makes it possible to compile
1879         InternalSettingsGenerated.cpp and not be confused by
1880         InternalSettingsGenerated.idl.
1881
1882 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
1883
1884         [style] WebIDL-reflecting uppercase enums reported as style violation
1885         https://bugs.webkit.org/show_bug.cgi?id=105832
1886
1887         Reviewed by Tony Chang.
1888
1889         Recognize the enum as WebIDL-reflecting one if there's a comment present that
1890         indicates this. In enums spanning over multiple lines, the comment is expected
1891         on the first line. In enums placed in one line, the comment is expected at the
1892         end of that line.
1893
1894         WebIDL-reflecting enum values are required to be written in uppercase and as such
1895         violate the common rule of these values being written in InterCaps. Annotating
1896         enums this way makes it possible to avoid false style violation reports.
1897
1898         The comment is of form '// Web(?:Kit)?IDL enum'.
1899
1900         * Scripts/webkitpy/style/checkers/cpp.py:
1901         (_EnumState.__init__):
1902         (_EnumState.process_clean_line):
1903         (check_enum_casing):
1904         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1905         (NoNonVirtualDestructorsTest.test_enum_casing):
1906
1907 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1908
1909         Adding favicon.ico to the garden-o-matic.
1910         https://bugs.webkit.org/show_bug.cgi?id=105982
1911
1912         Reviewed by Adam Barth.
1913
1914         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1915         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
1916
1917 2013-01-03  Jonathan Liu  <net147@gmail.com>
1918
1919         [Qt] Fix library linking order
1920         https://bugs.webkit.org/show_bug.cgi?id=105818
1921
1922         Some Qt libraries are linked before the private static libraries
1923         that depend on them which results in QtWebKit failing to link.
1924
1925         Copy Qt module dependencies from QT to QT_PRIVATE when creating
1926         module to ensure the Qt libraries are linked after the private
1927         static libraries that depend on them.
1928
1929         Reviewed by Tor Arne Vestbø.
1930
1931         * qmake/mkspecs/features/default_post.prf:
1932
1933 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
1934
1935         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
1936         https://bugs.webkit.org/show_bug.cgi?id=102209
1937
1938         Reviewed by Gyuyoung Kim.
1939
1940         Set tooltip on the elm_window instead of ewk_view, and add delay to
1941         show the tooltip window.
1942
1943         Setting tooltip on the ewk_view makes elementary error message because
1944         ewk_view is not an elementary widget. To remove the error message,
1945         tooltip should be set on the elm_window.
1946
1947         Most browsers show the tooltip after a mouse pointer stays on an
1948         element object that has tooltip text.
1949         But elm_tooltip widget itself doesn't have delay or handle mouse
1950         events to show/hide.
1951
1952         So additional codes are added to show/hide tooltip widget along with
1953         mouse events.
1954           1) When a mouse pointer stays for a second on an element which has
1955              tooltip text, then tooltip widget is displayed.
1956           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
1957              widget.
1958
1959         * MiniBrowser/efl/main.c:
1960         (_Tooltip_Information):
1961         (_Browser_Window):
1962         (on_tooltip_show):
1963         (window_tooltip_hide):
1964         (window_tooltip_update):
1965         (on_mouse_in):
1966         (on_mouse_move):
1967         (on_mouse_out):
1968         (window_free):
1969         (on_tooltip_text_set):
1970         (on_tooltip_text_unset):
1971         (window_create):
1972
1973 2013-01-02  Tony Chang  <tony@chromium.org>
1974
1975         Unreviewed, rolling out r138661.
1976         http://trac.webkit.org/changeset/138661
1977         https://bugs.webkit.org/show_bug.cgi?id=104740
1978
1979         Compile problems on EFL
1980
1981         * GNUmakefile.am:
1982         * qmake/mkspecs/features/default_post.prf:
1983
1984 2013-01-02  Tony Chang  <tony@chromium.org>
1985
1986         Generate internal.settings from Settings.in
1987         https://bugs.webkit.org/show_bug.cgi?id=104740
1988
1989         Reviewed by Adam Barth.
1990
1991         * GNUmakefile.am: Compile new generated files on GTK+.
1992         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1993         with both extra_sources and add_output_to_sources=false will still
1994         compile the files in extra_sources. This makes it possible to compile
1995         InternalSettingsGenerated.cpp and not be confused by
1996         InternalSettingsGenerated.idl.
1997
1998 2013-01-02  Adam Barth  <abarth@webkit.org>
1999
2000         Remove old-run-webkit-tests support from webkitpy
2001         https://bugs.webkit.org/show_bug.cgi?id=105619
2002
2003         Reviewed by Eric Seidel.
2004
2005         This patch removes support for webkitpy parsing the
2006         old-run-webkit-tests results format. There doesn't seem to be any
2007         reason to keep this code around anymore now that most bots have
2008         switched to new-run-webkit-tests.
2009
2010         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2011         (Builder.fetch_layout_test_results):
2012         * Scripts/webkitpy/common/net/layouttestresults.py:
2013         (path_for_layout_test):
2014         (LayoutTestResults.results_from_string):
2015         (LayoutTestResults):
2016         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2017         (LayoutTestResultsTest.test_results_from_string):
2018         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2019         (test_flaky_test_failure):
2020         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2021         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2022         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2023         (PatchAnalysisTask._test_patch):
2024         * Scripts/webkitpy/tool/commands/queuestest.py:
2025         (QueuesTest.assert_queue_outputs):
2026
2027 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
2028
2029         [Qt][WK2] Add simple UI to find text from page
2030         https://bugs.webkit.org/show_bug.cgi?id=96481
2031
2032         Reviewed by Jocelyn Turcotte.
2033
2034         Find bar that slides between navigation bar and WebView.
2035
2036         * MiniBrowser/qt/BrowserWindow.cpp:
2037         (BrowserWindow::toggleFind):
2038         * MiniBrowser/qt/BrowserWindow.h:
2039         (BrowserWindow):
2040         * MiniBrowser/qt/MiniBrowser.qrc:
2041         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2042         (MiniBrowserApplication::notify):
2043         * MiniBrowser/qt/icons/find.png: Added.
2044         * MiniBrowser/qt/qml/BrowserWindow.qml:
2045
2046 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
2047
2048         Regression(r138603): Caused 2 webkitpy tests to fail
2049         https://bugs.webkit.org/show_bug.cgi?id=105913
2050
2051         Reviewed by Kentaro Hara.
2052
2053         Fix 2 webkitpy tests that started to fail after
2054         r138603.
2055
2056         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2057         (IRCCommandTest._sheriff_test_data_url): Make sure the
2058         returned test file URL is valid no matter what the
2059         current working directory is.
2060         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2061         (IRCBotTest.test_help): Add "sheriffs" command to the
2062         list of available commands.
2063
2064 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
2065
2066         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
2067         https://bugs.webkit.org/show_bug.cgi?id=105897
2068
2069         Reviewed by Alexey Proskuryakov.
2070
2071         Dump in WebKitTestRunner the message that is expected by layout tests
2072         when the missing plugin button is clicked.
2073
2074         * WebKitTestRunner/TestController.cpp:
2075         (WTR::TestController::createWebViewWithOptions):
2076         (WTR::TestController::unavailablePluginButtonClicked):
2077         (WTR):
2078         * WebKitTestRunner/TestController.h:
2079         (TestController):
2080
2081 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
2082
2083         [EFL] Enable MHTML feature
2084         https://bugs.webkit.org/show_bug.cgi?id=105815
2085
2086         Reviewed by Laszlo Gombos.
2087
2088         Enable MHTML feature for EFL port by default.
2089
2090         * Scripts/webkitperl/FeatureList.pm:
2091
2092 2013-01-01  Alan Cutter  <alancutter@chromium.org>
2093
2094         sheriff-bot should know who the gardeners/sheriffs are
2095         https://bugs.webkit.org/show_bug.cgi?id=105698
2096
2097         Reviewed by Eric Seidel.
2098
2099         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
2100
2101         * Scripts/webkitpy/tool/bot/irc_command.py:
2102         (Current):
2103         (Current._retrieve_webkit_sheriffs):
2104         (Current.execute):
2105         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2106         (IRCCommandTest.test_current):
2107         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
2108         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
2109         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
2110         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
2111         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
2112
2113 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2114
2115         [GTK] Move ImageDiff to the Tools directory root
2116         https://bugs.webkit.org/show_bug.cgi?id=105421
2117
2118         Reviewed by Kenneth Rohde Christiansen.
2119
2120         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
2121         * GNUmakefile.am:
2122         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
2123
2124 2012-12-30  Mike West  <mkwst@chromium.org>
2125
2126         Add myself to watchlists for CSP and console logs.
2127         https://bugs.webkit.org/show_bug.cgi?id=105874
2128
2129         Reviewed by Dirk Pranke.
2130
2131         Because I really, really, really need more email.
2132
2133         * Scripts/webkitpy/common/config/committers.py:
2134             Add mkwst+watchlist@chromium.org as a contributor.
2135         * Scripts/webkitpy/common/config/watchlist:
2136             Create watchlist categories for 1) the various mechanisms used to
2137             generate console messages, and 2) CSP usage and files.
2138
2139 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2140
2141         [EFL] Enable TEMPLATE_ELEMENT feature
2142         https://bugs.webkit.org/show_bug.cgi?id=105865
2143         
2144         Reviewed by Laszlo Gombos.
2145
2146         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
2147
2148 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
2149
2150         Unreviewed GTK gardening of the unit tests.
2151
2152         Skip the TestInspectorServer unit test that's timing out completely.
2153
2154         * Scripts/run-gtk-tests:
2155         (TestRunner):
2156
2157 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2158
2159         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
2160         https://bugs.webkit.org/show_bug.cgi?id=105855
2161
2162         Reviewed by Vsevolod Vlasov.
2163
2164         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
2165         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
2166
2167         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2168         (ReportMemoryUsageVisitor):
2169         (clang::AddMemberCallVisitor::VisitCallExpr):
2170         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2171         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
2172
2173 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2174
2175         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
2176         https://bugs.webkit.org/show_bug.cgi?id=105852
2177
2178         Reviewed by Alexander Pavlov.
2179
2180         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2181         (clang):
2182         (AddMemberCallVisitor):
2183         (ReportMemoryUsageVisitor):
2184         (clang::ReportMemoryUsageAction::ParseArgs):
2185         (clang::AddMemberCallVisitor::VisitCallExpr):
2186         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2187         (clang::ReportMemoryUsageVisitor::emitWarning):
2188         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
2189         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
2190         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
2191
2192 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
2193
2194         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
2195         https://bugs.webkit.org/show_bug.cgi?id=105835
2196
2197         Reviewed by Dirk Pranke.
2198
2199         The BeautifulSoup module is a third-party import and as such we don't have much control
2200         over its testing. Because of that it should be omitted from code coverage checking.
2201
2202         * Scripts/webkitpy/test/main.py:
2203         (Tester._run_tests):
2204
2205 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
2206
2207         [GTK][WK2] Add support for IME Composition
2208         https://bugs.webkit.org/show_bug.cgi?id=65093
2209
2210         Reviewed by Carlos Garcia Campos.
2211
2212         Update unit tests for GtkInputMethodFilter to note whether or not an event
2213         was a fake event synthesized for composition purposes. This is now used
2214         for WebKit2.
2215
2216         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2217         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
2218         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
2219         (TestWebKitAPI::TEST):
2220         * gtk/generate-gtkdoc:
2221         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
2222         generation.
2223
2224 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
2225
2226         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
2227         https://bugs.webkit.org/show_bug.cgi?id=105800
2228
2229         Reviewed by Yury Semikhatsky.
2230
2231         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2232         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
2233         (clang):
2234
2235 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
2236
2237         Create a GTK build system watchlist and add myself to it
2238         https://bugs.webkit.org/show_bug.cgi?id=105769
2239
2240         Reviewed by Dirk Pranke.
2241
2242         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
2243         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
2244         omitted on purpose due to relatively high change rate they are exposed to.
2245
2246         The new watchlist would be of use to me as the GTK build system recently went
2247         through a series of changes that included a changed policy on adding configuration
2248         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
2249         mailing list about this change will be published later, but I'd also like to be
2250         notified of any pending changes to these files just so I can check the changes are
2251         in compliance with the new policy.
2252
2253         * Scripts/webkitpy/common/config/watchlist:
2254
2255 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
2256
2257         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
2258         As example ..../DevTools/src/third_party/WebKit
2259
2260         * Scripts/webkitpy/common/webkit_finder.py:
2261         (WebKitFinder.webkit_base):
2262
2263 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
2264
2265         [EFL][WK2] Refactor snapshot taking code
2266         https://bugs.webkit.org/show_bug.cgi?id=105687
2267
2268         Reviewed by Kenneth Rohde Christiansen.
2269
2270         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
2271         since the function was renamed to follow naming style.
2272
2273         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2274         (WTR::PlatformWebView::windowSnapshotImage):
2275
2276 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
2277
2278         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
2279         https://bugs.webkit.org/show_bug.cgi?id=105725
2280
2281         Reviewed by Yury Semikhatsky.
2282
2283         MemberType value names were adjusted according to Style Guide.
2284         Existing tests were extended with link type validation.
2285
2286         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2287
2288 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2289
2290         [BlackBerry] DRT - Crashed when running pixels tests
2291         https://bugs.webkit.org/show_bug.cgi?id=105711
2292
2293         RIM PR 270003
2294
2295         Reviewed by George Staikos.
2296
2297         Calling window->post() here will result in buffer swapping which is
2298         only allowed in UI thread now, and I found we don't need to call it
2299         for GL renderer.
2300
2301         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2302         (createBitmapContextFromWebView):
2303
2304 2012-12-22  Dan Winship  <danw@gnome.org>
2305
2306         Add a patch to fix libxml2 2.9.0 regression
2307         https://bugs.webkit.org/show_bug.cgi?id=104494
2308
2309         Reviewed by Martin Robinson.
2310
2311         * gtk/jhbuild.modules:
2312         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
2313
2314 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2315
2316         Unreviewed update of status to reviewer.
2317
2318         * Scripts/webkitpy/common/config/committers.py:
2319
2320 2012-12-23  Philippe Normand  <pnormand@igalia.com>
2321
2322         [GTK][jhbuild] Bump GStreamer to 1.0.4
2323         https://bugs.webkit.org/show_bug.cgi?id=105640
2324
2325         Reviewed by Martin Robinson.
2326
2327         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
2328
2329 2012-12-21  Nico Weber  <thakis@chromium.org>
2330
2331         chromium: webkit-build-directory doesn't handle ninja output dirs
2332         https://bugs.webkit.org/show_bug.cgi?id=105671
2333
2334         Reviewed by Daniel Bates.
2335
2336         Teach webkit-build-directory to detect the ninja build directory.
2337
2338         * Scripts/webkitdirs.pm:
2339         (determineBaseProductDir):
2340         (determineIsChromiumNinja):
2341
2342 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
2343
2344         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
2345         https://bugs.webkit.org/show_bug.cgi?id=95477
2346
2347         Reviewed by Sam Weinig.
2348
2349         Co-authored by Jia Pu.
2350
2351         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
2352         we can have consistent autocorrection behavior when running tests.
2353
2354         * DumpRenderTree/mac/DumpRenderTree.mm:
2355         (resetDefaultsToConsistentValues):
2356         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2357         (WTR::InjectedBundle::platformInitialize):
2358
2359 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
2360
2361         [GTK] Add WebKit1-specific TestExpectations file
2362         https://bugs.webkit.org/show_bug.cgi?id=97562
2363
2364         Reviewed by Dirk Pranke.
2365
2366         Implement the expectations_files method inside the GtkPort class that
2367         returns the list of the TestExpectations files the current test configuration
2368         requires. The method is implemented in a similar way as on the EFL port.
2369         A unit test is also added.
2370
2371         * Scripts/webkitpy/layout_tests/port/gtk.py:
2372         (GtkPort._search_paths):
2373         (GtkPort):
2374         (GtkPort.expectations_files):
2375         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2376         (GtkPortTest.test_expectations_files):
2377
2378 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2379
2380         [EFL] Enable feature option for the CSS sticky position
2381         https://bugs.webkit.org/show_bug.cgi?id=105630
2382
2383         Reviewed by Kenneth Rohde Christiansen.
2384
2385         Enable CSS sticky position feature by default for the
2386         EFL port. This feature option was added in r138252.
2387
2388         No new tests. Existing layout tests pass.
2389
2390         * Scripts/webkitperl/FeatureList.pm:
2391
2392 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2393
2394         [WK2] REGRESSION(r138232): It made 4 tests timeout
2395         https://bugs.webkit.org/show_bug.cgi?id=105623
2396
2397         Reviewed by Kenneth Rohde Christiansen.
2398
2399         r138232 changed functionality so that empty text output
2400         no longer leads to a dump() call, which leads to a timeout.
2401         Instead do a text dump if there is text output or if there
2402         is no audio output.
2403
2404         * WebKitTestRunner/TestInvocation.cpp:
2405         (WTR::TestInvocation::dumpResults):
2406
2407 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2408
2409         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2410         https://bugs.webkit.org/show_bug.cgi?id=105309
2411
2412         On Windows the library name is Qt5WebKitWidgets as well.
2413         So r138136 should not have adjusted the library name for Windows.
2414
2415         Reviewed by Simon Hausmann.
2416
2417         * Scripts/webkitdirs.pm:
2418         (builtDylibPathForName):
2419
2420 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2421
2422         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
2423         https://bugs.webkit.org/show_bug.cgi?id=105424
2424
2425         This change will allow us to run a very specific
2426         subset of the available LayoutTests on a mac buildbot.
2427         The new baseline search path for mac will look as follows:
2428         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
2429
2430         Reviewed by Dirk Pranke.
2431
2432         * Scripts/webkitpy/layout_tests/port/qt.py:
2433         (QtPort._search_paths):
2434         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2435         (QtPortTest):
2436
2437 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2438
2439         [EFL] Build break with latest EFL libraries.
2440         https://bugs.webkit.org/show_bug.cgi?id=104827
2441
2442         Reviewed by Laszlo Gombos.
2443
2444         The eo EFL package is introduced and evas and ecore use it since 1.8.
2445         While introducing Eo, EFL changed several structures of Evas and Ecore
2446         from own specific class to Eo.
2447
2448         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
2449         Ecore_Timer to build with latest EFL libraries.
2450
2451         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
2452         * EWebLauncher/CMakeLists.txt: Ditto.
2453         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2454         * ImageDiff/PlatformEfl.cmake: Ditto.
2455         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
2456         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
2457         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
2458         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
2459         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
2460
2461 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
2462
2463         TestExpectation fallback is broken
2464         https://bugs.webkit.org/show_bug.cgi?id=105583
2465
2466         Reviewed by Ryosuke Niwa.
2467
2468         When I added support for the -wk2 in port names, it looks
2469         like I broke the way we computed the list of TestExpectations
2470         files so that the implementation-version directory was left out :(.
2471         Fixed and cleaned up the tests.
2472
2473         * Scripts/webkitpy/layout_tests/port/base.py:
2474         (Port.expectations_files):
2475         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2476         (TestWebKitPort.__init__):
2477         (PortTestCase.test_skipped_directories_for_symbols):
2478         (test_skipped_directories_for_features):
2479         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2480         (test_skipped_tests_for_unsupported_features_empty_test_list):
2481         (test_skipped_layout_tests):
2482         (test_expectations_files):
2483
2484 2012-12-20  Anders Carlsson  <andersca@apple.com>
2485
2486         Don't include WebKit2 headers when building TestWebKitAPI on windows
2487         https://bugs.webkit.org/show_bug.cgi?id=105582
2488
2489         Reviewed by Tim Horton.
2490
2491         * TestWebKitAPI/config.h:
2492         * TestWebKitAPI/win/main.cpp:
2493
2494 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
2495
2496         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
2497         https://bugs.webkit.org/show_bug.cgi?id=105370
2498
2499         Reviewed by Simon Fraser.
2500
2501         Re-enable the test.
2502
2503         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2504         (TestWebKitAPI::TEST):
2505
2506 2012-12-20  Nico Weber  <thakis@chromium.org>
2507
2508         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
2509         https://bugs.webkit.org/show_bug.cgi?id=105498
2510
2511         Reviewed by Dirk Pranke.
2512
2513         Use the newest binary available rather than an than always picking one
2514         build directory over another based on iteration order.
2515
2516         * Scripts/webkitpy/layout_tests/port/chromium.py:
2517         (ChromiumPort._static_build_path):
2518         Check for timestamps.
2519         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2520         (ChromiumMacPortTest.test_build_path_timestamps):
2521         Test that out / xcodebuild selection happens based on timestamps
2522         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2523         (ChromiumWinPortTest.test_build_path_timestamps):
2524         Test that out / build selection happens based on timestamps
2525
2526 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
2527
2528         Lots of sticky tests failing in WK2
2529         https://bugs.webkit.org/show_bug.cgi?id=105464
2530
2531         Reviewed by Beth Dakin.
2532
2533         WebKitTestRunner had a race between snapshotting in the UI process,
2534         and resettting after the test in the web process. InjectedBundle::done()
2535         was a bad place to call page()->resetAfterTest(), because of this race;
2536         it could reset the scroll position before the UI snapshot had been obtained.
2537         
2538         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
2539         for the "Reset" message which will come in before the next test.
2540
2541         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2542         (WTR::InjectedBundle::didReceiveMessage):
2543         (WTR::InjectedBundle::done):
2544
2545 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
2546
2547         DFG speculation checks that take JumpList should consolidate OSRExits
2548         https://bugs.webkit.org/show_bug.cgi?id=105401
2549
2550         Reviewed by Oliver Hunt.
2551
2552         Update the profiler to understand that an OSR exit may have multiple
2553         candidate exit sites.
2554
2555         * Scripts/display-profiler-output:
2556
2557 2012-12-20  Eric Seidel  <eric@webkit.org>
2558
2559         EWSes do not need to dump build/test logs when things pass
2560         https://bugs.webkit.org/show_bug.cgi?id=105402
2561
2562         Reviewed by Dirk Pranke.
2563
2564         When we were first writing the commit-queue and EWS system
2565         and running them locally, we thought it was important to see the
2566         build/test output as it happened.  Now these queues have been running
2567         for years, and we don't use this feature anymore.  So this patch
2568         makes us stop tee-ing the output directly to stdout, and instead
2569         only print any output from commands when they fail.
2570
2571         I also added some logging when we execute each command
2572         since we are no longer printing the command output itself.
2573         This should make it much easier to see errors with the EWS
2574         system itself, now that all the passing-build output is removed.
2575
2576         This required updating a zillion unittests, since we have a bunch of
2577         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
2578         already approximating this behavior by using a "logging" Executive.
2579         I disabled logging in those cases to avoid redundant logging in those tests.
2580
2581         * Scripts/webkitpy/common/system/executive.py:
2582         (Executive.command_for_printing):
2583         (Executive.run_command):
2584         * Scripts/webkitpy/common/system/executive_mock.py:
2585         (MockExecutive.command_for_printing):
2586         (MockExecutive.run_command):
2587         * Scripts/webkitpy/common/system/executive_unittest.py:
2588         (ExecutiveTest.test_auto_stringify_args):
2589         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2590         (EarlyWarningSytemTest._default_expected_logs):
2591         (_test_ews):
2592         (_test_ewses):
2593         * Scripts/webkitpy/tool/commands/queues.py:
2594         (AbstractQueue.run_webkit_patch):
2595         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2596         (AbstractQueueTest._assert_run_webkit_patch):
2597         (CommitQueueTest.test_commit_queue):
2598         (test_rollout):
2599         (test_rollout_lands):
2600         (test_manual_reject_during_processing):
2601         (StyleQueueTest.test_style_queue_with_style_exception):
2602         (test_style_queue_with_watch_list_exception):
2603
2604 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
2605
2606         AX: support clickPoint in DRT for chromium
2607         https://bugs.webkit.org/show_bug.cgi?id=97359
2608
2609         Reviewed by Chris Fleizach.
2610
2611         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2612         several more tests can pass.
2613
2614         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2615         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2616         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2617         (WebTestRunner):
2618         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2619         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2620         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2621         (AccessibilityUIElement):
2622
2623 2012-12-20  Dan Bernstein  <mitz@apple.com>
2624
2625         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
2626         https://bugs.webkit.org/show_bug.cgi?id=99268
2627
2628         Reviewed by Alexey Proskuryakov.
2629
2630         * Scripts/prepare-ChangeLog:
2631         (generateNewChangeLogs): Removed the "Additional information of the change" line.
2632
2633 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2634
2635         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
2636
2637         * Scripts/run-gtk-tests:
2638         (TestRunner):
2639
2640 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2641
2642         [Qt] Move ImageDiff to the Tools directory root
2643         https://bugs.webkit.org/show_bug.cgi?id=105420
2644
2645         Reviewed by Tor Arne Vestbø.
2646
2647         Moved ImageDiff from outside DumpRenderTree because it is also a
2648         dependency when running pixel tests for WebKit2.
2649
2650         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
2651         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
2652         * Tools.pro:
2653
2654 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
2655
2656         [GTK] Remove the --enable-unstable-features configuration option
2657         https://bugs.webkit.org/show_bug.cgi?id=105327
2658
2659         Reviewed by Martin Robinson.
2660
2661         Add a missing feature option for the CSS sticky position feature.
2662
2663         * Scripts/webkitperl/FeatureList.pm:
2664
2665 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2666
2667         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
2668
2669         * Scripts/run-gtk-tests:
2670         (TestRunner):
2671
2672 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2673
2674         [EFL] MiniBrowser does not play Infinite Gangnam Style
2675         https://bugs.webkit.org/show_bug.cgi?id=103531
2676
2677         Reviewed by Kenneth Rohde Christiansen.
2678
2679         For EFL we would like this feature to be built by default.
2680
2681         * Scripts/webkitperl/FeatureList.pm:
2682
2683 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
2684
2685         [Qt] EWS bots should call qmake always
2686         https://bugs.webkit.org/show_bug.cgi?id=90049
2687
2688         Reviewed by Simon Hausmann.
2689
2690         * Scripts/webkitdirs.pm:
2691         (buildQMakeProjects):
2692
2693 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
2694
2695         [chromium] fix stray printf in TestRunner's WebTestProxy
2696         https://bugs.webkit.org/show_bug.cgi?id=105515
2697
2698         Reviewed by Ryosuke Niwa.
2699
2700         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2701         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
2702
2703 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2704
2705         [WK2] WebAudio WKTR support
2706         https://bugs.webkit.org/show_bug.cgi?id=95084
2707
2708         Reviewed by Kenneth Rohde Christiansen.
2709
2710         Implementing audio data dump support for WebKitTestRunner,
2711         by adding the API to the IDL, enabling IPC for transferring
2712         the audio data as bytebuffer and dumping it according
2713         to run-webkit-tests script's expectations.
2714         This enables audio testing on WebKit2 ports.
2715         Based on initial wip-patch from Philippe Normand - thanks.
2716
2717         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
2718         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
2719         (WTR::TestRunner::setAudioData):
2720         (WTR):
2721         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
2722         (TestRunner):
2723         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
2724         (WTR::InjectedBundle::done):
2725         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
2726         (WTR::InjectedBundle::setAudioResult):
2727         (InjectedBundle):
2728         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2729         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
2730         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
2731         (WTR::TestInvocation::dumpResults):
2732         (WTR):
2733         (WTR::TestInvocation::dumpAudio):
2734         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
2735         * WebKitTestRunner/TestInvocation.h:
2736         (TestInvocation):
2737
2738 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
2739
2740         [GTK] Count failed and timed out tests separately
2741         https://bugs.webkit.org/show_bug.cgi?id=105448
2742
2743         Reviewed by Carlos Garcia Campos.
2744
2745         Display the number of tests that fail, time out and are skipped
2746         separately in the buildbot page.
2747
2748         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2749         (RunGtkAPITests.commandComplete):
2750         (RunGtkAPITests.evaluateCommand):
2751         (RunGtkAPITests.getText2):
2752         * Scripts/run-gtk-tests:
2753         (TestRunner.run_tests):
2754
2755 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
2756
2757         PerfTest.parse_output does too much
2758         https://bugs.webkit.org/show_bug.cgi?id=105391
2759
2760         Reviewed by Tony Chang.
2761
2762         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
2763         Also moved the code to output test results into PerfTest._run_with_driver.
2764
2765         * Scripts/webkitpy/performance_tests/perftest.py:
2766         (PerfTest.__init__): Added _description.
2767         (PerfTest.description): Added.
2768         (PerfTest._run_with_driver): Moved the code to output test description and test results.
2769         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
2770         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
2771         respectively. Also removed the code that allowed some tests to omit values since all tests report each
2772         iteration now since r136492.
2773         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
2774         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
2775         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
2776         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
2777         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
2778         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
2779         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2780         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
2781         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
2782         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
2783         so that it's not string-concatenated with the next line.
2784         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
2785         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
2786
2787 2012-12-19  Alexis Menard  <alexis@webkit.org>
2788
2789         Implement CSS parsing for CSS transitions unprefixed.
2790         https://bugs.webkit.org/show_bug.cgi?id=104804
2791
2792         Reviewed by Dean Jackson.
2793
2794         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
2795         to cover the work of unprefixing Transforms, Animations and 
2796         Transitions. It will let the possibility of each ports to turn it off 
2797         in their release branches until we're confident that these CSS 
2798         properties are ready to be unprefixed.
2799
2800         * Scripts/webkitperl/FeatureList.pm:
2801         * qmake/mkspecs/features/features.pri:
2802
2803 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
2804
2805         2 clampTo unit tests are failing
2806         https://bugs.webkit.org/show_bug.cgi?id=105253
2807
2808         Reviewed by Emil A Eklund.
2809
2810         Removed clampToUnsigned as it was actually testing exactly what
2811         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
2812         to precision loss (fix suggested by Emil).
2813
2814         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2815
2816 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2817
2818         [EFL] Move ImageDiff to the Tools directory root
2819         https://bugs.webkit.org/show_bug.cgi?id=105305
2820
2821         Reviewed by Laszlo Gombos.
2822
2823         We previously moved this directory from the DRT directory to
2824         efl/ImageDiff. The major reason for doing so was because ImageDiff does
2825         not depend on DumpRenderTree but for legacy reasons was living inside the
2826         DRT folder, even though it is needed when running pixel tests for WK2.
2827
2828         Now we are moving to Tool directory root as other ports agreed to do the same.
2829
2830         * CMakeLists.txt:
2831         * ImageDiff/CMakeLists.txt: Added.
2832         * ImageDiff/PlatformEfl.cmake: Added.
2833         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
2834         * efl/ImageDiff/CMakeLists.txt: Removed.
2835
2836 2012-12-19  Zeno Albisser  <zeno@webkit.org>
2837
2838         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2839         https://bugs.webkit.org/show_bug.cgi?id=105309
2840
2841         The version number is only used as a part
2842         of the library name on Linux.
2843
2844         Reviewed by Kenneth Rohde Christiansen.
2845
2846         * Scripts/webkitdirs.pm:
2847         (builtDylibPathForName):
2848
2849 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
2850
2851         [GTK] Tests that time out are not considered as failures.
2852         https://bugs.webkit.org/show_bug.cgi?id=105318
2853
2854         Reviewed by Martin Robinson.
2855
2856         Fix parsing of the GTK API tests log files.
2857
2858         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2859         (RunGtkAPITests.commandComplete):
2860
2861 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
2862
2863         Unreviewed, rolling out r138061.
2864         https://bugs.webkit.org/show_bug.cgi?id=105396
2865
2866         Original patch:
2867         http://trac.webkit.org/changeset/138061
2868         https://bugs.webkit.org/show_bug.cgi?id=97359
2869
2870         It is crashing on Debug bots
2871
2872         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2873         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2874         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2875         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2876         (AccessibilityUIElement):
2877
2878 2012-12-18  Alice Liu  <alice.liu@apple.com>
2879
2880         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
2881         Add SPI to WebKit1 WebFrame for hit testing
2882
2883         Reviewed by Dan Bernstein.
2884
2885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
2886         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
2887         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
2888         Then hit-tests at three points, expecting to hit the two divs and body element. 
2889
2890 2012-12-18  Alice Liu  <alice.liu@apple.com>
2891
2892         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
2893         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
2894
2895         Reviewed by Anders Carlsson.
2896
2897         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
2898         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
2899         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
2900         Loads html with a single div element. In an isolated world, creates a property on that node.
2901         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
2902             - Existence of the isolated property in the isolated world.
2903             - Existence of the standard property in the standard world.
2904             - Non-existence of the isolated property in the standard world.
2905             - Non-existence of the standard property in the isolated world.
2906
2907 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
2908
2909         Disable the SimplifyMarkup API test, wich asserts in debug builds.
2910         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
2911         
2912         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2913         (TestWebKitAPI::TEST):
2914
2915 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
2916
2917         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
2918         https://bugs.webkit.org/show_bug.cgi?id=104279
2919
2920         Reviewed by David Kilzer.
2921
2922         Add a build phase script that checks a framework's header files for
2923         Platform.h and Compiler.h macros. Also add some tests for the script.
2924
2925         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
2926         Script to be used in build phases to check for inappropriate macros in headers.
2927
2928         * Scripts/test-webkitruby: Added.
2929         Script that can be used to run all webkitruby tests.
2930
2931         * Scripts/test-webkit-scripts:
2932         Also run the ruby tests.
2933
2934         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
2935         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
2936         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
2937         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
2938         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
2939         Tests for the new script.
2940
2941 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
2942
2943         AX: support clickPoint in DRT for chromium
2944         https://bugs.webkit.org/show_bug.cgi?id=97359
2945
2946         Reviewed by Chris Fleizach.
2947
2948         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2949         several more tests can pass.
2950
2951         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2952         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2953         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2954         (WebTestRunner):
2955         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2956         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2957         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2958         (AccessibilityUIElement):
2959
2960 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2961
2962         Build fix after r138045.
2963
2964         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2965         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
2966         is not explicitly specified. The condition was backwards but never matched so we
2967         always ran the test regardless of whether it's listed in the skipped list or not.
2968         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2969         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
2970
2971 2012-12-18  Emil A Eklund  <eae@chromium.org>
2972
2973         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
2974         https://bugs.webkit.org/show_bug.cgi?id=105332
2975         
2976         Reviewed by Levi Weintraub.
2977         
2978         Create new test suite for LayoutUnit tests as the KURL tests are
2979         of the incompatible TEST_F type.
2980
2981         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2982         (TestWebKitAPI):
2983         (TestWebKitAPI::TEST_F):
2984
2985 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2986
2987         Running a skipped test with run-perf-tests could alert the user
2988         https://bugs.webkit.org/show_bug.cgi?id=105219
2989
2990         Reviewed by Eric Seidel.
2991
2992         Force run skipped performance tests explicitly specified in the command line.
2993         Also warn the user when the specified paths don't exist.
2994
2995         * Scripts/webkitpy/layout_tests/port/base.py:
2996         (Port.relative_test_filename):
2997         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2998         (PerfTestsRunner._parse_args):
2999         (PerfTestsRunner._collect_tests):
3000         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3001         (test_collect_tests_with_skipped_list_and_files):
3002
3003 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
3004
3005         Chrome Android java output is too verbose
3006         https://bugs.webkit.org/show_bug.cgi?id=105247
3007
3008         Reviewed by Tony Chang.
3009
3010         Pass -quiet to ant to suppress extraneous output.
3011
3012         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3013         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3014
3015 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3016
3017         Consider removing --pause-before-testing option
3018         https://bugs.webkit.org/show_bug.cgi?id=105248
3019
3020         Reviewed by Eric Seidel.
3021
3022         Remove --pause-before-testing option.
3023
3024         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
3025         (DriverProxy.start): Removed.
3026         * Scripts/webkitpy/performance_tests/perftest.py:
3027         (PerfTest.__init__):
3028         (PerfTest.test_path): Renamed from path_or_url.
3029         (PerfTest.run):
3030         (PerfTest): Removed "driver" argument.
3031         (PerfTest._run_with_driver):
3032         (PerfTest.run_single):
3033         (ChromiumStylePerfTest.__init__):
3034         (PageLoadingPerfTest.__init__):
3035         (PageLoadingPerfTest.run_single):
3036         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
3037         (ReplayPerfTest.__init__):
3038         (ReplayPerfTest.prepare):
3039         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3040         (TestPageLoadingPerfTest.test_run):
3041         (TestPageLoadingPerfTest.test_run_with_memory_output):
3042         (TestPageLoadingPerfTest.test_run_with_bad_output):
3043         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3044         (PerfTestsRunner._parse_args):
3045         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
3046         (PerfTestsRunner._run_single_test): Removed "driver" argument.
3047         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3048         (run_test):
3049         (test_run_test_pause_before_testing): Removed.
3050
3051 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
3052
3053         [GTK] Tests that time out are not considered as failures.
3054         https://bugs.webkit.org/show_bug.cgi?id=105318
3055
3056         Reviewed by Martin Robinson.
3057
3058         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3059         (RunGtkAPITests.commandComplete):
3060         Consider log lines that end with TIMEOUT as errors.
3061
3062         * Scripts/run-gtk-tests:
3063         (TestRunner.run_tests):
3064         Consider timeouts as failures when returning the number of failed
3065         tests.
3066
3067 2012-12-18  Pravin D  <pravin.d@samsung.com>
3068
3069         Unreviewed, adding secondary email.
3070
3071         * Scripts/webkitpy/common/config/committers.py:
3072
3073 2012-12-18  Pravin D  <pravin.d@samsung.com>
3074
3075         Unreviewed, promoting myself to committer's list.
3076
3077         * Scripts/webkitpy/common/config/committers.py:
3078
3079 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3080
3081         [EFL] ImageDiff does not build on WebKit2 only builds
3082         https://bugs.webkit.org/show_bug.cgi?id=105288
3083
3084         Reviewed by Kenneth Rohde Christiansen.
3085
3086         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
3087         the folder with things which are EFL-specific.
3088
3089         ImageDiff will be built by default now regardless of WebKit API flavor
3090         you choose.
3091
3092         * CMakeLists.txt:
3093         * DumpRenderTree/efl/CMakeLists.txt:
3094         * efl/ImageDiff/CMakeLists.txt: Added.
3095         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
3096
3097 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3098
3099         [EFL][WK2] When creating new windows, use the opener's context
3100         https://bugs.webkit.org/show_bug.cgi?id=105283
3101
3102         Reviewed by Laszlo Gombos.
3103
3104         Use the context of the opener if exists.
3105
3106         * MiniBrowser/efl/main.c:
3107         (on_key_down):
3108         (on_window_create):
3109         (window_create):
3110         (elm_main):
3111
3112 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3113
3114         [EFL][WK2] Gardening of TestWebKitAPI tests
3115         https://bugs.webkit.org/show_bug.cgi?id=105268
3116
3117         Reviewed by Kenneth Rohde Christiansen.
3118
3119         Some tests were marked as failing but are passing and the newly added
3120         LayoutUnit should have it's own binary because it conflicts with the
3121         fixture used by KURL and is failing on the bots because of that.
3122
3123         * TestWebKitAPI/CMakeLists.txt:
3124         * TestWebKitAPI/PlatformEfl.cmake:
3125
3126 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3127
3128         [chromium] move webintent related methods to TestRunner library
3129         https://bugs.webkit.org/show_bug.cgi?id=105164
3130
3131         Reviewed by Darin Fisher.
3132
3133         Also deleted the unused deliveredIntentFailure and
3134         deliveredIntentResult methods.
3135
3136         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3137         (DRTTestRunner::DRTTestRunner):
3138         * DumpRenderTree/chromium/DRTTestRunner.h:
3139         (DRTTestRunner):
3140         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3141         (WebKit):
3142         (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
3143         (WebTestRunner::WebTestDelegate::currentWebIntentRequest):
3144         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3145         (WebKit):
3146         (WebTestProxyBase):
3147         (WebTestRunner::WebTestProxy::registerIntentService):
3148         (WebTestRunner::WebTestProxy::dispatchIntent):
3149         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3150         (WebTestRunner::TestRunner::TestRunner):
3151         (WebTestRunner::TestRunner::sendWebIntentResponse):
3152         (WebTestRunner):
3153         (WebTestRunner::TestRunner::deliverWebIntent):
3154         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3155         (TestRunner):
3156         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3157         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3158         (WebTestRunner::WebTestProxyBase::registerIntentService):
3159         (WebTestRunner):
3160         (WebTestRunner::WebTestProxyBase::dispatchIntent):
3161         * DumpRenderTree/chromium/WebViewHost.cpp:
3162         (WebViewHost::setCurrentWebIntentRequest):
3163         (WebViewHost::currentWebIntentRequest):
3164         * DumpRenderTree/chromium/WebViewHost.h:
3165         (WebKit):
3166         (WebViewHost):
3167
3168 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3169
3170         [chromium] move editing callback dumping to the WebTestProxy
3171         https://bugs.webkit.org/show_bug.cgi?id=105013
3172
3173         Reviewed by Darin Fisher.
3174
3175         To decide whether or not to dump the editing callbacks, the WebTestProxy
3176         needs to query the TestRunner. For this purpose, I introduce a
3177         WebTestRunner class that just exposes the shouldDumpEditingCallbacks
3178         method. In contrast to e.g. WebEventSender, the WebTestRunner is just
3179         an interface, and it is not owned by the WebTestInterfaces, but the
3180         embedder of the TestRunner library must provide it. This will change
3181         once all TestRunner methods are in the library.
3182
3183         * DumpRenderTree/DumpRenderTree.gypi:
3184         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3185         (DRTTestRunner::DRTTestRunner):
3186         (DRTTestRunner::reset):
3187         * DumpRenderTree/chromium/DRTTestRunner.h:
3188         (DRTTestRunner):
3189         (DRTTestRunner::taskList):
3190         (DRTTestRunner::WorkQueue::taskList):
3191         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3192         (WebTestRunner):
3193         (WebTestInterfaces):
3194         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3195         (WebKit):
3196         (WebTestRunner):
3197         (WebTestProxyBase):
3198         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3199         (WebTestRunner::WebTestProxy::shouldEndEditing):
3200         (WebTestRunner::WebTestProxy::shouldInsertNode):
3201         (WebTestRunner::WebTestProxy::shouldInsertText):
3202         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3203         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3204         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3205         (WebTestRunner::WebTestProxy::didBeginEditing):
3206         (WebTestRunner::WebTestProxy::didChangeSelection):
3207         (WebTestRunner::WebTestProxy::didChangeContents):
3208         (WebTestRunner::WebTestProxy::didEndEditing):
3209         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
3210         (WebTestRunner):
3211         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
3212         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3213         (WebTestRunner::TestRunner::TestRunner):
3214         (WebTestRunner::TestRunner::~TestRunner):
3215         (WebTestRunner):
3216         (WebTestRunner::TestRunner::reset):
3217         (WebTestRunner::TestRunner::shouldDumpEditingCallbacks):
3218         (WebTestRunner::TestRunner::dumpEditingCallbacks):
3219         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3220         (TestRunner):
3221         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3222         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
3223         (WebTestRunner::WebTestInterfaces::Internal::setTestRunner):
3224         (WebTestInterfaces::Internal):
3225         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3226         (WebTestRunner::WebTestInterfaces::testRunner):
3227         (WebTestRunner):
3228         (WebTestRunner::WebTestInterfaces::setTestRunner):
3229         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3230         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3231         (WebTestRunner):
3232         (WebTestRunner::WebTestProxyBase::shouldBeginEditing):
3233         (WebTestRunner::WebTestProxyBase::shouldEndEditing):
3234         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
3235         (WebTestRunner::WebTestProxyBase::shouldInsertText):
3236         (WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
3237         (WebTestRunner::WebTestProxyBase::shouldDeleteRange):
3238         (WebTestRunner::WebTestProxyBase::shouldApplyStyle):
3239         (WebTestRunner::WebTestProxyBase::didBeginEditing):
3240         (WebTestRunner::WebTestProxyBase::didChangeSelection):
3241         (WebTestRunner::WebTestProxyBase::didChangeContents):
3242         (WebTestRunner::WebTestProxyBase::didEndEditing):
3243         * DumpRenderTree/chromium/TestShell.cpp:
3244         (TestShell::initialize):
3245         (TestShell::createNewWindow):
3246         * DumpRenderTree/chromium/WebViewHost.cpp:
3247         (WebViewHost::shouldBeginEditing):
3248         (WebViewHost::shouldEndEditing):
3249         (WebViewHost::shouldInsertNode):
3250         (WebViewHost::shouldInsertText):
3251         (WebViewHost::shouldChangeSelectedRange):
3252         (WebViewHost::shouldDeleteRange):
3253         (WebViewHost::shouldApplyStyle):
3254         * DumpRenderTree/chromium/WebViewHost.h:
3255         (WebViewHost):
3256
3257 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3258
3259         [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
3260         https://bugs.webkit.org/show_bug.cgi?id=105154
3261
3262         Reviewed by Tony Chang.
3263
3264         If the settings are modified directly, the embedder can't keep track of
3265         them and might accidentially override the changed settings.
3266
3267         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3268         (WebPreferences):
3269         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3270         (WebTestRunner::TestRunner::TestRunner):
3271         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
3272         (WebTestRunner):
3273         (WebTestRunner::TestRunner::setMinimumTimerInterval):
3274         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3275         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3276         (TestRunner):
3277         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3278         (WebTestRunner::WebPreferences::reset):
3279         (WebTestRunner::WebPreferences::applyTo):
3280
3281 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3282
3283         Unreviewed unit test skipping.
3284
3285         Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.
3286
3287         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3288         (TestWebKitAPI):
3289         (TestWebKitAPI::TEST):
3290
3291 2012-12-17  Dean Jackson  <dino@apple.com>
3292
3293         Unreviewed. Add Silvia Pfeiffer to contributor list.
3294
3295         * Scripts/webkitpy/common/config/committers.py:
3296
3297 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3298
3299         build.webkit.org - add more google windows bots
3300         https://bugs.webkit.org/show_bug.cgi?id=105225
3301
3302         Reviewed by Eric Seidel.
3303
3304         Adds two more windows bots (google-windows-3, a builder, and
3305         google-windows-4, a tester) for the Chromium configs.
3306
3307         * BuildSlaveSupport/build.webkit.org-config/config.json:
3308
3309 2012-12-17  Eric Seidel  <eric@webkit.org>
3310
3311         Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
3312         https://bugs.webkit.org/show_bug.cgi?id=105217
3313
3314         Reviewed by Dirk Pranke.
3315
3316         Previously --profile would fail strangely if find_unused_filename returned None
3317         (which would happen as soon as we had 100 report files).
3318         Now we'll search through 1000 filenames before giving up (and assert if we failed to find one).
3319         I also made some minor cleanups to the output of perf, and tried to make the
3320         commands more self-documenting by using long-names for args.
3321
3322         * Scripts/webkitpy/common/system/profiler.py:
3323         (SingleFileOutputProfiler.__init__):
3324         (Perf.attach_to_pid):
3325         (Perf.profile_after_exit):
3326
3327 2012-12-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3328
3329         Unreviewed, rolling out r137198.
3330         http://trac.webkit.org/changeset/137198
3331         https://bugs.webkit.org/show_bug.cgi?id=105212
3332
3333         This patch is causing API behavior compatibility problems
3334         (Requested by zdobersek on #webkit).
3335
3336         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3337         (willSendRequestCallback):
3338
3339 2012-12-17  Elliott Sprehn  <esprehn@chromium.org>
3340
3341         Unreviewed. Adding myself to committers list.
3342
3343         * Scripts/webkitpy/common/config/committers.py:
3344
3345 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3346
3347         nrwt: shuffle code around for cleanup in run_webkit_tests.py
3348         https://bugs.webkit.org/show_bug.cgi?id=105078
3349
3350         Reviewed by Ojan Vafai.
3351
3352         This patch reorders functions so that run_webkit_tests can be
3353         understood in a top-down matter better, and to make things slightly
3354         more sensible when I merge manager.py into it.
3355
3356         Also, this adds tests for the actual main() routine, which had several
3357         bugs get through testing a week or two ago.
3358
3359         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3360         (main):
3361         (parse_args):
3362         (_set_up_derived_options):
3363         (run):
3364         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3365         (RunTest):
3366         (RunTest.test_no_http_tests):
3367         (PortTest.disabled_test_mac_lion):
3368         (MainTest):
3369         (MainTest.test_exception_handling):
3370         (MainTest.test_exception_handling.interrupting_run):
3371         (MainTest.test_exception_handling.successful_run):
3372         (MainTest.test_exception_handling.successful_run.FakeRunDetails):
3373         (MainTest.test_exception_handling.exception_raising_run):
3374
3375 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3376
3377         webkitpy: move --lint-test-files code into its own module
3378         https://bugs.webkit.org/show_bug.cgi?id=105077
3379
3380         Reviewed by Eric Seidel.
3381
3382         It really didn't need to be in run_webkit_tests.py anymore.
3383         This patch adds a new lint-test-expectations scripts to Tools/Scripts;
3384         rwt --lint-test-files is still supported for backwards compatibility
3385         for now.
3386
3387         * Scripts/lint-test-expectations: Added.
3388         * Scripts/webkitpy/layout_tests/lint_test_expectations.py: Added.
3389         (lint):
3390         (main):
3391         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: Added.
3392         (FakePort):
3393         (FakePort.__init__):
3394         (FakePort.test_configuration):
3395         (FakePort.expectations_dict):
3396         (FakePort.skipped_layout_tests):
3397         (FakePort.all_test_configurations):
3398         (FakePort.configuration_specifier_macros):
3399         (FakePort.get_option):
3400         (FakeFactory):
3401         (FakeFactory.__init__):
3402         (FakeFactory.get):
3403         (FakeFactory.all_port_names):
3404         (LintTest):
3405         (LintTest.test_all_configurations):
3406         (LintTest.test_lint_test_files):
3407         (LintTest.test_lint_test_files__errors):
3408         (MainTest):
3409         (MainTest.test_success):
3410         (MainTest.test_success.interrupting_lint):
3411         (MainTest.test_success.successful_lint):
3412         (MainTest.test_success.exception_raising_lint):
3413         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3414         (main):
3415         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3416         (StreamTestingMixin.assertNotEmpty):
3417
3418 2012-12-17  Adam Klein  <adamk@chromium.org>
3419
3420         build-webkit: rename --template-tag to --template-element to match ENABLE #define name
3421         https://bugs.webkit.org/show_bug.cgi?id=105072
3422
3423         Reviewed by Laszlo Gombos.
3424
3425         * Scripts/webkitperl/FeatureList.pm:
3426
3427 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3428
3429         Add some unit testing for WTF::clampTo* functions
3430         https://bugs.webkit.org/show_bug.cgi?id=105060
3431
3432         Reviewed by Emil A Eklund.
3433
3434         The new tests are targeted at clamping to int / unsigned and float as those are
3435         the one explicitely exposed through more dedicated functions (like clampToInteger,
3436         clampToPositiveInteger and clampToFloat).
3437
3438         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3439
3440 2012-12-17  Eric Seidel  <eric@webkit.org>
3441
3442         rpt --profile --chromium-android throws exception
3443         https://bugs.webkit.org/show_bug.cgi?id=105061
3444
3445         Reviewed by Daniel Bates.
3446
3447         Somehow popen(args) got turned into popen(*args) at some point,
3448         which caused my new stringify code to fail when args was passed by name.
3449         Fixed and tested.
3450
3451         * Scripts/webkitpy/common/system/executive.py:
3452         (Executive._stringify_args):
3453         (Executive):
3454         (Executive.popen):
3455         * Scripts/webkitpy/common/system/executive_unittest.py:
3456         (ExecutiveTest.test_popen_args):
3457
3458 2012-12-17  Mark Pilgrim  <pilgrim@chromium.org>
3459
3460         Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
3461         https://bugs.webkit.org/show_bug.cgi?id=105054
3462
3463         Reviewed by Jochen Eisinger.
3464
3465         Part of a refactoring series; see tracking bug 82948.
3466
3467         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3468         (NotificationPresenter::show):
3469         * DumpRenderTree/chromium/Task.cpp:
3470         (postTask):
3471         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
3472
3473 2012-12-17  Emil A Eklund  <eae@chromium.org>
3474
3475         Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled
3476         https://bugs.webkit.org/show_bug.cgi?id=104955
3477
3478         Reviewed by Julien Chaffraix.
3479
3480         Add tests for LayoutUnit.
3481
3482         * TestWebKitAPI/CMakeLists.txt:
3483         * TestWebKitAPI/ForwardingHeaders: Added.
3484         * TestWebKitAPI/ForwardingHeaders/WebCore: Added.
3485         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Added.
3486         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3487         * TestWebKitAPI/TestWebKitAPI.gypi:
3488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3489         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Added.
3490         (TestWebKitAPI):
3491         (TestWebKitAPI::TEST):
3492         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3493
3494 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3495
3496         [chromium] removed unused preferences from testRunner.overridePreference
3497         https://bugs.webkit.org/show_bug.cgi?id=105169
3498
3499         Reviewed by Tony Chang.
3500
3501         Most notably this removes the code related to font family maps which is
3502         now handled via window.internals.settings
3503
3504         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3505         (WebPreferences):
3506         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3507         (WebTestRunner::TestRunner::overridePreference):
3508         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3509         (TestRunner):
3510         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3511         (WebTestRunner::WebPreferences::applyTo):
3512
3513 2012-12-17  James Robinson  <jamesr@chromium.org>
3514
3515         [chromium] Move creation of WebLayerTreeView to WebWidgetClient
3516         https://bugs.webkit.org/show_bug.cgi?id=105071
3517
3518         Reviewed by Adrienne Walker.
3519
3520         Update WebViewHost for the new WebWidgetClient interface.
3521
3522         * DumpRenderTree/chromium/WebViewHost.cpp:
3523         (WebViewHost::initializeLayerTreeView):
3524         (WebViewHost::layerTreeView):
3525         (WebViewHost::~WebViewHost):
3526         * DumpRenderTree/chromium/WebViewHost.h:
3527         (WebViewHost):
3528
3529 2012-12-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3530
3531         [EFL][WK2] window_create doesn't receive the url
3532         https://bugs.webkit.org/show_bug.cgi?id=105184
3533
3534         Reviewed by Alexis Menard.
3535
3536         * MiniBrowser/efl/main.c: Use the url supplied to window_create
3537         (on_window_create):
3538
3539 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3540
3541         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3542         https://bugs.webkit.org/show_bug.cgi?id=105026
3543
3544         Reviewed by Yury Semikhatsky.
3545
3546         Old SFINAE test was replaced with new one based on this article:
3547         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3548
3549         New test which covers this problem was added.
3550
3551         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3552
3553 2012-12-17  Anthony Scian  <ascian@rim.com>
3554
3555         [Blackberry] Static code analysis warning fixes
3556         https://bugs.webkit.org/show_bug.cgi?id=105129
3557
3558         Reviewed by Rob Buis.
3559
3560         Added null checks for fopen calls, no recovery attempted; access fault prevention only.
3561
3562         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3563         (BlackBerry::WebKit::createFile):
3564         (BlackBerry::WebKit::DumpRenderTree::runTest):
3565
3566 2012-12-17  John Mellor  <johnme@chromium.org>
3567
3568         Add Anton Vayvod and Tim Volodine as contributors in committers.py
3569         https://bugs.webkit.org/show_bug.cgi?id=105025
3570
3571         Unreviewed. Adds two contributors to committers.py.
3572         They are initially contributing to the Text Autosizing feature (master bug: 84186).
3573
3574         * Scripts/webkitpy/common/config/committers.py:
3575
3576 2012-12-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3577
3578         Unreviewed, add myself to committers.py.
3579
3580         * Scripts/webkitpy/common/config/committers.py:
3581
3582 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3583
3584         [Qt] remove some unnecessary CONFIG additions
3585
3586         Reviewed by Simon Hausmann.
3587
3588         qt is already added by spec_pre.prf, warn_on and depend_includepath by
3589         default_pre.prf.
3590
3591         * qmake/mkspecs/features/default_post.prf:
3592
3593 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3594
3595         Unreviewed, rolling out r137892.
3596         http://trac.webkit.org/changeset/137892
3597         https://bugs.webkit.org/show_bug.cgi?id=105026
3598
3599         it broke compilation on windows
3600
3601         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3602
3603 2012-12-14  Ilya Tikhonovsky  <loislo@chromium.org>
3604
3605         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3606         https://bugs.webkit.org/show_bug.cgi?id=105026
3607
3608         Reviewed by Yury Semikhatsky.
3609
3610         Old SFINAE test was replaced with new one based on this article:
3611         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3612
3613         New test which covers this problem was added.
3614
3615         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3616
3617 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3618
3619         [Qt] rely on automatic output directory setup
3620
3621         Reviewed by Simon Hausmann.
3622
3623         Now being a proper qt module (by virtue of having load(qt_build_config)
3624         in .qmake.conf), webkit gets the path setup goodies for free.
3625
3626         This also fixes Makefile.api.Debug/Release trying to generate qrc_WebKit.cpp
3627         at the same time, instead of the debug and release version ending up in different
3628         directories as they should.
3629
3630         * qmake/mkspecs/features/default_pre.prf:
3631
3632 2012-12-17  Charles Wei  <charles.wei@torchmobile.com.cn>