Web Inspector: Provide UIString descriptions to improve localizations
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
2
3         Web Inspector: Provide UIString descriptions to improve localizations
4         https://bugs.webkit.org/show_bug.cgi?id=195132
5         <rdar://problem/48457817>
6
7         Reviewed by Devin Rousso.
8
9         Allow WI.UIString to take:
10         - WI.UIString(string, key, comment)
11         - WI.UIString(string, comment)
12         - WI.UIString(string)
13
14         * Scripts/extract-localizable-js-strings:
15
16 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
17
18         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
19         https://bugs.webkit.org/show_bug.cgi?id=197579
20
21         Reviewed by Tim Horton.
22
23         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
24         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
25         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
26         ensure that the the focused element has been blurred.
27
28         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
29
30 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
31
32         Add a tool to block spammer accounts
33         https://bugs.webkit.org/show_bug.cgi?id=197537
34
35         Reviewed by Darin Adler.
36
37         Usage: block-spammers email1 email2 ...
38
39         The tool finds and hides all bugs and comments from this account. Before any work
40         is done, these bugs and comments are displayed for confirmation.
41
42         * Scripts/block-spammers: Added.
43         (get_bugzilla_token):
44         (invalidate_bugzilla_token):
45         (get_user_info):
46         (get_user_info_self):
47         (can_use_this_tool):
48         (disable_user):
49         (get_bugs_created_by_user):
50         (get_bugs_commented_on_by_user):
51         (get_comments):
52         (hide_bug):
53         (hide_comments):
54         (ask_yes_no):
55         (sanitized_string):
56         (main):
57
58 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
59
60         run-apit-tests: Add --iterations and --repeat-each
61         https://bugs.webkit.org/show_bug.cgi?id=197563
62
63         Reviewed by Aakash Jain.
64
65         * Scripts/webkitpy/api_tests/manager.py:
66         (Manager.run): Add --iterations and --repeat-each/
67         * Scripts/webkitpy/api_tests/run_api_tests.py:
68         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
69
70 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
71
72         New EWS: Clicking on white bubble navigates to page with only bubbles
73         https://bugs.webkit.org/show_bug.cgi?id=197520
74
75         Reviewed by Lucas Forschler.
76
77         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
78
79 2019-05-03  Daniel Bates  <dabates@apple.com>
80
81         [lldb-webkit] Support adding pretty-printing for qualified types
82         https://bugs.webkit.org/show_bug.cgi?id=197518
83
84         Reviewed by Darin Adler.
85
86         Remove all "::"s from the name of the specified type when computing the name for the Python classes
87         that will provide summary and synthetic details as LLDB is not happy about registering such classes
88         when they contain :: in their name.
89
90         * lldb/lldb_webkit.py:
91         (addSummaryAndSyntheticFormattersForRawBitmaskType):
92
93 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
94
95         New EWS: patches on recently added queues listed as #1 for older bugs
96         https://bugs.webkit.org/show_bug.cgi?id=197496
97
98         Reviewed by Lucas Forschler.
99
100         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
101         (StatusBubble._build_bubble):
102         (StatusBubble._queue_position):
103
104 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
105
106         webkit-patch --no-review upload does not submit patch to New EWS
107         https://bugs.webkit.org/show_bug.cgi?id=197519
108         <rdar://problem/50424887>
109
110         Reviewed by Lucas Forschler.
111
112         * Scripts/webkitpy/tool/steps/submittoews.py:
113         (SubmitToEWS.run): Submit to both old and new EWS.
114         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
115         * Scripts/webkitpy/common/net/ewsserver.py: Added.
116         (EWSServer._server_url): Method to return server url.
117         (EWSServer._post_patch_to_ews): Method to post patch to ews.
118         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
119         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
120         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
121         * Scripts/webkitpy/common/net/statusserver_mock.py:
122         (MockStatusServer.submit_to_ews): Updated the log text.
123         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
124         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
125         * Scripts/webkitpy/tool/main.py:
126         (WebKitPatch.__init__): Initialize ews_server. 
127         * Scripts/webkitpy/tool/mocktool.py:
128         (MockTool.__init__): Ditto.
129
130 2019-05-03  Chris Dumez  <cdumez@apple.com>
131
132         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
133         https://bugs.webkit.org/show_bug.cgi?id=197574
134         <rdar://problem/50453181>
135
136         Reviewed by Tim Horton.
137
138         Add API test coverage.
139
140         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
141         (TEST):
142
143 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
144
145         [JSC] Generator CodeBlock generation should be idempotent
146         https://bugs.webkit.org/show_bug.cgi?id=197552
147
148         Reviewed by Keith Miller.
149
150         * Scripts/run-javascriptcore-tests:
151         (runJSCStressTests):
152         * Scripts/run-jsc-stress-tests:
153
154 2019-05-03  Commit Queue  <commit-queue@webkit.org>
155
156         Unreviewed, rolling out r244881.
157         https://bugs.webkit.org/show_bug.cgi?id=197559
158
159         Breaks compilation of jsconly on linux, breaking compilation
160         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
161         guijemont on #webkit).
162
163         Reverted changeset:
164
165         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
166         WEBKIT_COPY_FILES"
167         https://bugs.webkit.org/show_bug.cgi?id=197174
168         https://trac.webkit.org/changeset/244881
169
170 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
171
172         Unreviewed WPE build fix after r244898.
173
174         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
175         (WTR::TestController::abortModal): Add the missing (no-op) definition.
176
177 2019-05-02  Alex Christensen  <achristensen@webkit.org>
178
179         Mark U+01C0 as a homograph of U+006C
180         https://bugs.webkit.org/show_bug.cgi?id=197526
181         <rdar://problem/50301904>
182
183         Reviewed by Tim Horton.
184
185         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
186         (TestWebKitAPI::TEST):
187
188 2019-05-02  Chris Dumez  <cdumez@apple.com>
189
190         Add test coverage for <rdar://problem/49731231>
191         https://bugs.webkit.org/show_bug.cgi?id=196730
192         <rdar://problem/49731231>
193
194         Reviewed by Ryosuke Niwa.
195
196         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
197         to match DumpRenderTree.
198
199         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
200         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
201         (WTR::TestRunner::abortModal):
202         * WebKitTestRunner/InjectedBundle/TestRunner.h:
203         * WebKitTestRunner/TestController.cpp:
204         (WTR::TestController::runModal):
205         * WebKitTestRunner/TestController.h:
206         * WebKitTestRunner/TestInvocation.cpp:
207         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
208         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
209         (WTR::TestController::abortModal):
210         * WebKitTestRunner/ios/TestControllerIOS.mm:
211         (WTR::TestController::abortModal):
212         * WebKitTestRunner/mac/TestControllerMac.mm:
213         (WTR::TestController::abortModal):
214         * WebKitTestRunner/win/TestControllerWin.cpp:
215         (WTR::TestController::abortModal):
216
217 2019-05-02  Christopher Reid  <chris.reid@sony.com>
218
219         [CMake] Add support for LTO builds
220         https://bugs.webkit.org/show_bug.cgi?id=188986
221
222         Reviewed by Don Olmstead.
223
224         Add support to configure --lto-mode with cmake builds.
225
226         * Scripts/build-webkit:
227         * Scripts/webkitdirs.pm:
228         (generateBuildSystemFromCMakeProject):
229
230 2019-05-02  John Wilander  <wilander@apple.com>
231
232         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
233         https://bugs.webkit.org/show_bug.cgi?id=197521
234         <rdar://problem/49651503>
235
236         Reviewed by Brent Fulgham.
237
238         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
239         (TestWebKitAPI::TEST):
240            Added a test for host strings with leading dots since they are
241            often used for the domain attribute in cookies.
242
243 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
244
245         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
246         https://bugs.webkit.org/show_bug.cgi?id=197510
247
248         Reviewed by Alex Christensen.
249
250         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
251         (TestWebKitAPI::TEST):
252
253 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
254
255         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
256         https://bugs.webkit.org/show_bug.cgi?id=197174
257
258         Reviewed by Alex Christensen.
259
260         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
261
262         * TestWebKitAPI/PlatformGTK.cmake:
263         * TestWebKitAPI/PlatformWPE.cmake:
264
265 2019-05-02  Alex Christensen  <achristensen@webkit.org>
266
267         Build fix for internal branch.
268
269         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
270         RetainPtr.h was not explicitly included.
271
272 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
273
274         webkitpy: Ignore errors when shutting down an already shutdown simulator
275         <https://bugs.webkit.org/show_bug.cgi?id=197514>
276         <rdar://problem/50390247>
277
278         Reviewed by Lucas Forschler.
279
280         * Scripts/webkitpy/xcode/simulated_device.py:
281         (SimulatedDevice._shut_down):
282
283 2019-05-02  Frederic Wang  <fwang@igalia.com>
284
285         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
286         https://bugs.webkit.org/show_bug.cgi?id=196142
287
288         This patch introduces some experimental runtime flag to let users
289         disable MathML features that are removed from MathML Core [1]. For now,
290         these features are only disabled on GTK and WPE ports.
291
292         [1] https://mathml-refresh.github.io/mathml-core/
293
294         Reviewed by Rob Buis.
295
296         * DumpRenderTree/TestOptions.cpp:
297         (TestOptions::TestOptions):
298         * DumpRenderTree/TestOptions.h:
299         * DumpRenderTree/mac/DumpRenderTree.mm:
300         (setWebPreferencesForTestOptions):
301
302 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
303
304         TestWebKitAPI config.h should be aware of what suite is being built
305         https://bugs.webkit.org/show_bug.cgi?id=196583
306
307         Reviewed by Konstantin Tokarev.
308
309         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
310         benefit the macro defines BUILDING_* for the executable which allows the includes
311         of the config.h to be tailored to the test suite being built. Because of that the
312         dependencies of the Test* executable are specific to the test suite which may
313         speed up the build.
314
315         Some source files were including "PlatformUtilities.h" which includes WebKit headers
316         when "Utilities.h" is what was needed.
317
318         * TestWebKitAPI/CMakeLists.txt:
319         * TestWebKitAPI/PlatformGTK.cmake:
320         * TestWebKitAPI/PlatformJSCOnly.cmake:
321         * TestWebKitAPI/PlatformMac.cmake:
322         * TestWebKitAPI/PlatformPlayStation.cmake:
323         * TestWebKitAPI/PlatformUtilities.h:
324         * TestWebKitAPI/PlatformWPE.cmake:
325         * TestWebKitAPI/PlatformWin.cmake:
326         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
327         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
328         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
329         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
330         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
331         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
332         * TestWebKitAPI/config.h:
333
334 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
335
336         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
337         https://bugs.webkit.org/show_bug.cgi?id=181950
338         <rdar://problem/43357371>
339
340         Reviewed by Brent Fulgham.
341
342         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
343         (TestWebKitAPI::TEST_F):
344
345 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
346
347         Remove webkitpy and bindings EWS queues from dashboard
348         https://bugs.webkit.org/show_bug.cgi?id=197475
349
350         Reviewed by Alexey Proskuryakov.
351
352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
353
354 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
355
356         Remove webkitpy and bindings test queues from old EWS
357         https://bugs.webkit.org/show_bug.cgi?id=197468
358
359         Reviewed by Alexey Proskuryakov.
360
361         * QueueStatusServer/config/queues.py:
362
363 2019-04-30  Tim Horton  <timothy_horton@apple.com>
364
365         Fix the WebKitTestRunner build
366         https://bugs.webkit.org/show_bug.cgi?id=197449
367         <rdar://problem/50334169>
368
369         Reviewed by Alexey Proskuryakov.
370
371         * WebKitTestRunner/mac/EventSenderProxy.mm:
372         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
373         (WTR::EventSenderProxy::mouseForceChanged):
374         Use some SPI instead of IPI.
375
376 2019-04-30  Chris Dumez  <cdumez@apple.com>
377
378         Regression(PSON) URL scheme handlers can no longer respond asynchronously
379         https://bugs.webkit.org/show_bug.cgi?id=197426
380         <rdar://problem/50256169>
381
382         Reviewed by Brady Eidson.
383
384         Add API test coverage.
385
386         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
387         (-[PSONScheme setShouldRespondAsynchronously:]):
388         (-[PSONScheme webView:startURLSchemeTask:]):
389         (-[PSONScheme webView:stopURLSchemeTask:]):
390
391 2019-04-30  Chris Dumez  <cdumez@apple.com>
392
393         Unreviewed, rolling out r244802.
394
395         Caused an API test failure
396
397         Reverted changeset:
398
399         "Regression(PSON) URL scheme handlers can no longer respond
400         asynchronously"
401         https://bugs.webkit.org/show_bug.cgi?id=197426
402         https://trac.webkit.org/changeset/244802
403
404 2019-04-30  Chris Dumez  <cdumez@apple.com>
405
406         Regression(PSON) URL scheme handlers can no longer respond asynchronously
407         https://bugs.webkit.org/show_bug.cgi?id=197426
408         <rdar://problem/50256169>
409
410         Reviewed by Brady Eidson.
411
412         Add API test coverage.
413
414         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
415         (-[PSONScheme setShouldRespondAsynchronously:]):
416         (-[PSONScheme webView:startURLSchemeTask:]):
417         (-[PSONScheme webView:stopURLSchemeTask:]):
418
419 2019-04-30  Chris Dumez  <cdumez@apple.com>
420
421         Only use a related page's process if that page has not been closed yet
422         https://bugs.webkit.org/show_bug.cgi?id=197393
423         <rdar://problem/50302423>
424
425         Reviewed by Tim Horton.
426
427         Add API test coverage.
428
429         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
430
431 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
432
433         [ews-build] Enable Bindings tests queue on new EWS
434         https://bugs.webkit.org/show_bug.cgi?id=197424
435
436         Reviewed by Lucas Forschler.
437
438         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
439         (StatusBubble):
440         * BuildSlaveSupport/ews-build/config.json:
441
442 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
443
444         [ews-build] Configure ews151 for running various tests
445         https://bugs.webkit.org/show_bug.cgi?id=197419
446
447         Reviewed by Lucas Forschler.
448
449         * BuildSlaveSupport/ews-build/config.json:
450
451 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
452
453         [ews-build] Parse and display bindings test failures
454         https://bugs.webkit.org/show_bug.cgi?id=197423
455
456         Reviewed by Lucas Forschler.
457
458         * BuildSlaveSupport/ews-build/steps.py:
459         (RunBindingsTests.__init__): Set timeout of 5 minutes.
460         (RunBindingsTests.start): Initialize log_observer for json output.
461         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
462         (RunBindingsTests._addToLog): Method to add message to log.
463         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
464
465 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
466
467         Unreviewed. Add myself as a committer.
468
469         * Scripts/webkitpy/common/config/contributors.json:
470
471 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
472
473         [ews-build] Enable webkitpy queue on new EWS
474         https://bugs.webkit.org/show_bug.cgi?id=197396
475
476         Reviewed by Lucas Forschler.
477
478         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
479         (StatusBubble):
480         * BuildSlaveSupport/ews-build/config.json:
481
482 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
483
484         [ews-build] Parse and display webkitpy failures
485         https://bugs.webkit.org/show_bug.cgi?id=197395
486
487         Reviewed by Lucas Forschler.
488
489         * BuildSlaveSupport/ews-build/steps.py:
490         (RunWebKitPyTests.start): Initialize log_observer for json output.
491         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
492         (RunWebKitPyTests._addToLog): Method to add message to log.
493         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
494
495 2019-04-29  Alex Christensen  <achristensen@webkit.org>
496
497         <rdar://problem/50299396> Fix internal High Sierra build
498         https://bugs.webkit.org/show_bug.cgi?id=197388
499
500         * DumpRenderTree/mac/Configurations/Base.xcconfig:
501         * MiniBrowser/Configurations/Base.xcconfig:
502         * MobileMiniBrowser/Configurations/Base.xcconfig:
503         * TestWebKitAPI/Configurations/Base.xcconfig:
504         * WebKitTestRunner/Configurations/Base.xcconfig:
505
506 2019-04-29  Youenn Fablet  <youenn@apple.com>
507
508         Remove spurious GVA printf logging
509         https://bugs.webkit.org/show_bug.cgi?id=197368
510         <rdar://problem/35975256>
511
512         Reviewed by Alexey Proskuryakov.
513
514         * Scripts/webkitpy/port/mac.py:
515         (MacPort.logging_patterns_to_strip):
516
517 2019-04-29  Youenn Fablet  <youenn@apple.com>
518
519         getDisplayMedia should be called on user gesture
520         https://bugs.webkit.org/show_bug.cgi?id=197356
521         <rdar://problem/50296074>
522
523         Reviewed by Eric Carlson.
524
525         Update test configuration to inject internals
526         so that we can use it to simulate a user click to call getDisplayMedia.
527
528         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
529         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
530         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
531
532 2019-04-26  Stephanie Lewis  <slewis@apple.com>
533
534         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
535         https://bugs.webkit.org/show_bug.cgi?id=197339
536
537         Reviewed by Dewei Zhu.
538
539         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
540         test run for setup steps that are too expensive to do every iteration.
541
542         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
543         (BenchmarkRunner._run_benchmark):
544         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
545         (BrowserDriver):
546         (BrowserDriver.prepare_initial_env):
547         (BrowserDriver.restore_env_after_all_testing):
548         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
549         (LinuxBrowserDriver.prepare_initial_env):
550         (LinuxBrowserDriver.restore_env_after_all_testing):
551         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
552         (OSXBrowserDriver.prepare_initial_env):
553         (OSXBrowserDriver.restore_env_after_all_testing):
554
555 2019-04-28  Andy Estes  <aestes@apple.com>
556
557         Fix the watchOS engineering build.
558
559         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
560         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
561
562 2019-04-27  Chris Dumez  <cdumez@apple.com>
563
564         [WKTR] Move test timeout handling to the UIProcess
565         https://bugs.webkit.org/show_bug.cgi?id=197333
566
567         Reviewed by Darin Adler.
568
569         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
570         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
571         every WebContent process in the case of swapping.
572
573         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
574         would lead to crashes when firing the timer.
575
576         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
577         (WTR::InjectedBundle::didReceiveMessageToPage):
578         (WTR::InjectedBundle::done):
579         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
580         (WTR::InjectedBundle::shouldDumpPixels const):
581         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
582         (WTR::TestRunner::TestRunner):
583         (WTR::TestRunner::waitUntilDone):
584         (WTR::TestRunner::setWaitUntilDone):
585         * WebKitTestRunner/InjectedBundle/TestRunner.h:
586         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
587         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
588         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
589         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
590         * WebKitTestRunner/TestInvocation.cpp:
591         (WTR::TestInvocation::TestInvocation):
592         (WTR::TestInvocation::createTestSettingsDictionary):
593         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
594         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
595         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
596         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
597         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
598         (WTR::TestInvocation::setWaitUntilDone):
599         (WTR::TestInvocation::done):
600         * WebKitTestRunner/TestInvocation.h:
601
602 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
603
604         [JSC] linkPolymorphicCall now does GC
605         https://bugs.webkit.org/show_bug.cgi?id=197306
606
607         Reviewed by Saam Barati.
608
609         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
610         To add this test, we add `runWithoutBaseOption`.
611
612         * Scripts/run-jsc-stress-tests:
613
614 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
615
616         Update inactive reviewers' status to 'contributor'.
617
618         Accidentally skipped one at first.
619
620         * Scripts/webkitpy/common/config/contributors.json:
621
622 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
623
624         Update inactive reviewers' status to 'contributor'.
625
626         * Scripts/webkitpy/common/config/contributors.json: The change.
627
628         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
629         * Scripts/webkitpy/common/checkout/checkout_mock.py:
630         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
631         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
632         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
633         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
634         * Scripts/webkitpy/tool/commands/queries_unittest.py:
635         * Scripts/webkitpy/tool/commands/upload_unittest.py:
636         Sadly, regression tests operate on a crazy mix of mock and live data for
637         contributors.json. It would be a substantial project to mock all code paths,
638         so changing the tests instead.
639
640 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
641
642         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
643         https://bugs.webkit.org/show_bug.cgi?id=197171
644         <rdar://problem/47454979>
645
646         Reviewed by Youenn Fablet.
647
648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
650         (TestWebKitAPI::TEST):
651
652 2019-04-26  David Kilzer  <ddkilzer@apple.com>
653
654         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
655         <https://webkit.org/b/197314>
656         <rdar://problem/50245252>
657
658         Reviewed by Simon Fraser.
659
660         * WebKitTestRunner/UIScriptControllerCocoa.mm:
661         (WTR::UIScriptController::lastUndoLabel const):
662         (WTR::UIScriptController::firstRedoLabel const):
663         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
664
665         * WebKitTestRunner/ios/HIDEventGenerator.mm:
666         (-[HIDEventGenerator sendEventStream:completionBlock:]):
667         - Call -autorelease to fix leak of NSDictionary.
668
669         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
670         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
671         (WTR::UIScriptController::selectFormPopoverTitle const):
672         (WTR::UIScriptController::textContentType const):
673         (WTR::UIScriptController::formInputLabel const):
674         (WTR::UIScriptController::scrollingTreeAsText const):
675         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
676
677 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
678
679         webkitpy: Running a single test will always use the default device
680         https://bugs.webkit.org/show_bug.cgi?id=195472
681         <rdar://problem/48724825>
682
683         Reviewed by Lucas Forschler.
684
685         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
686         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
687         requested will be run regardless of what shard they are in.
688
689         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
690         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
691         * Scripts/webkitpy/layout_tests/controllers/manager.py:
692         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
693         on the default device type.
694         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
695         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
696         (RunTest.test_run_part): Ditto.
697
698 2019-04-26  Alex Christensen  <achristensen@webkit.org>
699
700         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
701         https://bugs.webkit.org/show_bug.cgi?id=197165
702
703         Reviewed by Youenn Fablet.
704
705         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
706
707 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
708
709         Replace iOS build queue hardware
710         https://bugs.webkit.org/show_bug.cgi?id=197312
711
712         Reviewed by Aakash Jain.
713
714         * BuildSlaveSupport/build.webkit.org-config/config.json:
715         Use newer hardware that supports macOS Mojave.
716
717 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
718
719         check-webkit-style complains the first block in while loop.
720         https://bugs.webkit.org/show_bug.cgi?id=197307
721
722         The style checker shouldn't complain about an open brace on
723         its own line if the last non-whitespace character on the previous
724         non-blank line is another open brace, because it's likely to
725         indicate the begining of a nested code block.
726
727         Reviewed by Alex Christensen.
728
729         * Scripts/webkitpy/style/checkers/cpp.py:
730         (check_braces):
731         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
732         (WebKitStyleTest.test_braces):
733
734 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
735
736         Stop IDB transactions to release locked database files when network process is ready to suspend
737         https://bugs.webkit.org/show_bug.cgi?id=196372
738         <rdar://problem/48930116>
739
740         Reviewed by Brady Eidson.
741
742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
743         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
744         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
745         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
746         (runTestAndCheckResult):
747         (keepNetworkProcessActive):
748         (TEST):
749
750 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
751
752         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
753         https://bugs.webkit.org/show_bug.cgi?id=188357
754         <rdar://problem/42986633>
755
756         Reviewed by Dean Jackson.
757
758         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
759         tests would fall into low memory mode and have different behavior.
760         
761         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
762         to Internals, so it's shared by DRT and WTR.
763         
764         We no longer need the WK2 C SPI glue.
765
766         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
767         (WTR::InjectedBundlePage::prepare):
768
769 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
770
771         webkitpy: Including skipped tests in the final count
772         https://bugs.webkit.org/show_bug.cgi?id=197298
773         <rdar://problem/49705424>
774
775         Reviewed by Lucas Forschler.
776
777         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
778         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
779
780 2019-04-25  Timothy Hatcher  <timothy@apple.com>
781
782         Disable date and time inputs on iOSMac.
783         https://bugs.webkit.org/show_bug.cgi?id=197287
784         rdar://problem/46794376
785
786         Reviewed by Wenson Hsieh.
787
788         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
789
790 2019-04-25  Alex Christensen  <achristensen@webkit.org>
791
792         Fix test-webkitpy after r244653
793         https://bugs.webkit.org/show_bug.cgi?id=197131
794
795         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
796         Also use C++17.
797
798 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
799
800         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
801         https://bugs.webkit.org/show_bug.cgi?id=196991
802         <rdar://problem/45507423>
803
804         Reviewed by Alex Christensen.
805
806         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
807         (-[NavigationTestDelegate init]):
808         (-[NavigationTestDelegate waitForDidFinishNavigation]):
809         (-[NavigationTestDelegate webView:didFinishNavigation:]):
810         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
811         (TestWebKitAPI::TEST):
812         (TEST): Deleted.
813
814 2019-04-25  Alex Christensen  <achristensen@webkit.org>
815
816         Revert some code accidentally committed with r244653
817         https://bugs.webkit.org/show_bug.cgi?id=197131
818
819         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
820         (TestWebKitAPI::TEST):
821
822 2019-04-25  Alex Christensen  <achristensen@webkit.org>
823
824         Start using C++17
825         https://bugs.webkit.org/show_bug.cgi?id=197131
826
827         Reviewed by Darin Adler.
828
829         * DumpRenderTree/mac/Configurations/Base.xcconfig:
830         * MiniBrowser/Configurations/Base.xcconfig:
831         * MobileMiniBrowser/Configurations/Base.xcconfig:
832         * TestWebKitAPI/Configurations/Base.xcconfig:
833         * WebKitTestRunner/Configurations/Base.xcconfig:
834
835 2019-04-25  Commit Queue  <commit-queue@webkit.org>
836
837         Unreviewed, rolling out r244627.
838         https://bugs.webkit.org/show_bug.cgi?id=197282
839
840         Causing internal build failures (Requested by ShawnRoberts on
841         #webkit).
842
843         Reverted changeset:
844
845         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
846         https://bugs.webkit.org/show_bug.cgi?id=197171
847         https://trac.webkit.org/changeset/244627
848
849 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
850
851         [GTK] Hardcoded text color in input fields
852         https://bugs.webkit.org/show_bug.cgi?id=126907
853
854         Reviewed by Michael Catanzaro.
855
856         Add dark-mode command line option to MiniBrowser.
857
858         * MiniBrowser/gtk/main.c:
859         (main):
860
861 2019-04-24  Zalan Bujtas  <zalan@apple.com>
862
863         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
864         https://bugs.webkit.org/show_bug.cgi?id=196948
865         <rdar://problem/49927131>
866
867         Reviewed by Tim Horton.
868
869         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
870         (TEST):
871         The expected order of incoming events is
872         1. didInvalidateIntrinsicContentSize
873         2. didFirstLayout
874         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
875         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
876         (and remember, all we care about is ordering).
877
878 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
879
880         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
881         https://bugs.webkit.org/show_bug.cgi?id=197171
882         <rdar://problem/47454979>
883
884         Reviewed by Youenn Fablet.
885
886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
887         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
888         (TestWebKitAPI::TEST):
889
890 2019-04-24  Brady Eidson  <beidson@apple.com>
891
892         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
893         https://bugs.webkit.org/show_bug.cgi?id=191362
894
895         Reviewed by Alex Christensen.
896
897         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
898           from an XHR to a custom protocol.
899
900 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
901
902         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
903         https://bugs.webkit.org/show_bug.cgi?id=197273
904
905         Reviewed by Dean Jackson.
906
907         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
908         so that WebCoreTestSupport::resetInternalsObject() is always run.
909
910         * DumpRenderTree/mac/DumpRenderTree.mm:
911         (resetWebViewToConsistentStateBeforeTesting):
912         (runTest):
913
914 2019-04-24  John Wilander  <wilander@apple.com>
915
916         Age out unconverted Ad Click Attributions after one week.
917         https://bugs.webkit.org/show_bug.cgi?id=197238
918         <rdar://problem/50177349>
919
920         Reviewed by Chris Dumez.
921
922         This patch adds infrastructure to allow tests to expire all unconverted
923         attributions early.
924
925         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
926         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
927         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
928         * WebKitTestRunner/InjectedBundle/TestRunner.h:
929         * WebKitTestRunner/TestController.cpp:
930         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
931         * WebKitTestRunner/TestController.h:
932         * WebKitTestRunner/TestInvocation.cpp:
933         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
934
935 2019-04-24  Chris Dumez  <cdumez@apple.com>
936
937         Fix flaky crashes in a couple of PSON API tests
938         https://bugs.webkit.org/show_bug.cgi?id=197239
939
940         Reviewed by Tim Horton.
941
942         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
943
944         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
945
946 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
947
948         Make it possible to control the renderTreeAsText output by setting options on testRunner
949         https://bugs.webkit.org/show_bug.cgi?id=197133
950
951         Reviewed by Sam Weinig.
952
953         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
954         that make sense in testing (those that don't dump unstable data like addresses), and plumb
955         these flags through the various framework layers.
956
957         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
958
959         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
960         and hand-code DumpRenderTree bindings.
961
962         Some cleanup of the TestRunners, using member initializers.
963
964         * DumpRenderTree/TestRunner.cpp:
965         (TestRunner::TestRunner):
966         (setRenderTreeDumpOptionsCallback):
967         (TestRunner::staticFunctions):
968         (TestRunner::setRenderTreeDumpOptions):
969         * DumpRenderTree/TestRunner.h:
970         (TestRunner::renderTreeDumpOptions const):
971         * DumpRenderTree/mac/DumpRenderTree.mm:
972         (dump):
973         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
974         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
975         (WTR::InjectedBundlePage::dump):
976         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
977         (WTR::TestRunner::TestRunner):
978         (WTR::TestRunner::setRenderTreeDumpOptions):
979         * WebKitTestRunner/InjectedBundle/TestRunner.h:
980         (WTR::TestRunner::renderTreeDumpOptions const):
981
982 2019-04-24  Alex Christensen  <achristensen@webkit.org>
983
984         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
985         https://bugs.webkit.org/show_bug.cgi?id=197078
986         <rdar://problem/49564348>
987
988         Reviewed by Geoff Garen.
989
990         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
991         (TEST_F):
992         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
993         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
994         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
995
996 2019-04-24  Alex Christensen  <achristensen@webkit.org>
997
998         Add unit test for r239322
999         https://bugs.webkit.org/show_bug.cgi?id=197236
1000
1001         Reviewed by Chris Dumez.
1002
1003         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1004         May as well add the test infrastructure which was needed before and will be needed in the future.
1005
1006         * TestWebKitAPI/TCPServer.cpp:
1007         (TestWebKitAPI::TCPServer::TCPServer):
1008         * TestWebKitAPI/TCPServer.h:
1009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1010         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1011         (TestWebKitAPI::TEST):
1012         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1013         (TestWebKitAPI::downloadAtRate):
1014         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1015         (TEST):
1016         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1017         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1018         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1019         (TestWebKitAPI::TEST):
1020         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1021         (TEST):
1022
1023 2019-04-24  Chris Dumez  <cdumez@apple.com>
1024
1025         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1026         https://bugs.webkit.org/show_bug.cgi?id=197214
1027         <rdar://problem/49237544>
1028
1029         Reviewed by Alex Christensen.
1030
1031         Extend API test coverage.
1032
1033         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1034         (TEST):
1035
1036 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1037
1038         [Build][GStreamer] Update to 1.16.0
1039         https://bugs.webkit.org/show_bug.cgi?id=197157
1040
1041         Reviewed by Xabier Rodriguez-Calvar.
1042
1043         The upstreamed patches were removed and a new one was added for a
1044         regression detected in the scaletempo GStreamer element. The GNOME
1045         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1046         on the way, as it is the preferred build system now in GStreamer
1047         1.16.
1048
1049         * flatpak/files/httpd-autogen.sh:
1050         * flatpak/flatpakutils.py:
1051         (FlatpakPackage.install):
1052         (WebkitFlatpak.run_in_sandbox):
1053         * flatpak/org.webkit.CommonModules.yaml:
1054         * flatpak/org.webkit.WebKit.yaml:
1055         * gstreamer/jhbuild.modules:
1056         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1057         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1058         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1059         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1060         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1061         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1062         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1063         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1064         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1065         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1066         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1067         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1068         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1069         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1070         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1071         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1072         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1073         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1074         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1075         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1076         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1077         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1078
1079 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1080
1081         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1082         https://bugs.webkit.org/show_bug.cgi?id=197156
1083
1084         Reviewed by Michael Catanzaro.
1085
1086         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1087         support was added.
1088
1089         * MiniBrowser/gtk/BrowserTab.c:
1090         (browser_tab_set_background_color): Set the passed in color as web view background color.
1091         * MiniBrowser/gtk/BrowserTab.h:
1092         * MiniBrowser/gtk/BrowserWindow.c:
1093         (browser_window_init): Initialize backgroundColor.
1094         (browser_window_append_view): Call browser_tab_set_background_color().
1095         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1096         are added.
1097         * MiniBrowser/gtk/main.c:
1098         (main): Call browser_window_set_background_color() before creating the tabs.
1099
1100 2019-04-23  John Wilander  <wilander@apple.com>
1101
1102         Move Ad Click Attribution from internal feature to experimental feature
1103         https://bugs.webkit.org/show_bug.cgi?id=197218
1104         <rdar://problem/47651691>
1105
1106         Reviewed by Brent Fulgham.
1107
1108         * DumpRenderTree/TestOptions.cpp:
1109         (TestOptions::TestOptions):
1110
1111 2019-04-23  Andy Estes  <aestes@apple.com>
1112
1113         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1114         https://bugs.webkit.org/show_bug.cgi?id=196749
1115         <rdar://problem/35773454>
1116
1117         Reviewed by Daniel Bates.
1118
1119         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1120
1121         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1122         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1123         (-[QuickLookDelegate webView:didFinishNavigation:]):
1124         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1125         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1126         (runTest):
1127         (runTestDecideBeforeLoading):
1128         (runTestDecideAfterLoading):
1129         (TEST):
1130
1131 2019-04-23  John Wilander  <wilander@apple.com>
1132
1133         Remove Ad Click Attribution data when removing website data
1134         https://bugs.webkit.org/show_bug.cgi?id=197215
1135         <rdar://problem/47668988>
1136
1137         Reviewed by Chris Dumez.
1138
1139         This patch adds test infrastructure to delete Ad Click Attribution data
1140         through WebsiteDataStore::removeData().
1141
1142         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1143         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1144         (WTR::TestRunner::clearAdClickAttribution):
1145         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1146         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1147         * WebKitTestRunner/TestController.cpp:
1148         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1149         * WebKitTestRunner/TestController.h:
1150         * WebKitTestRunner/TestInvocation.cpp:
1151         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1152
1153 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1154
1155         webkitpy: Kill unresponsive worker processes
1156         https://bugs.webkit.org/show_bug.cgi?id=197205
1157         <rdar://problem/50104388>
1158
1159         Reviewed by Lucas Forschler.
1160
1161         * Scripts/webkitpy/common/message_pool.py:
1162         (_MessagePool.__init__): Add close timeout.
1163         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1164
1165 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1166
1167         Add unit tests for WKWebView.serverTrust
1168         https://bugs.webkit.org/show_bug.cgi?id=197202
1169
1170         Reviewed by Youenn Fablet
1171
1172         * TestWebKitAPI/TCPServer.cpp:
1173         (TestWebKitAPI::deleter<BIO>::operator()):
1174         (TestWebKitAPI::deleter<SSL>::operator()):
1175         (TestWebKitAPI::deleter<X509>::operator()):
1176         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1177         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1178         (TestWebKitAPI::TCPServer::TCPServer):
1179         (TestWebKitAPI::TCPServer::listenForConnections):
1180         * TestWebKitAPI/TCPServer.h:
1181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1182         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1183         (TestWebKitAPI::TEST):
1184         (verifyCertificateAndPublicKey):
1185         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1186         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1187         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1188         (TestWebKitAPI::downloadAtRate):
1189         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1190         (TEST):
1191         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1192         (TEST):
1193
1194 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1195
1196         Unreviewed, rolling out r244556.
1197         https://bugs.webkit.org/show_bug.cgi?id=197212
1198
1199         Causing build failures on multiple builders (Requested by
1200         ShawnRoberts on #webkit).
1201
1202         Reverted changeset:
1203
1204         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1205         https://bugs.webkit.org/show_bug.cgi?id=197171
1206         https://trac.webkit.org/changeset/244556
1207
1208 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1209
1210         Fix iOS build.
1211         https://bugs.webkit.org/show_bug.cgi?id=195537
1212
1213         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1214         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1215         AdoptWK constructor is private now.  Use adoptWK instead.
1216
1217 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1218
1219         Accessibility text search and selection API enhancements.
1220         https://bugs.webkit.org/show_bug.cgi?id=197095
1221         <rdar://problem/48181791>
1222
1223         Reviewed by Chris Fleizach.
1224
1225         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1226
1227         * DumpRenderTree/AccessibilityTextMarker.h:
1228         * DumpRenderTree/AccessibilityUIElement.cpp:
1229         (searchTextWithCriteriaCallback):
1230         (AccessibilityUIElement::getJSClass):
1231         * DumpRenderTree/AccessibilityUIElement.h:
1232         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1233         (convertVectorToObjectArray):
1234         (convertNSArrayToVector):
1235         (searchTextParameterizedAttributeForCriteria):
1236         (AccessibilityUIElement::getLinkedUIElements):
1237         (AccessibilityUIElement::getDocumentLinks):
1238         (AccessibilityUIElement::getChildren):
1239         (AccessibilityUIElement::getChildrenWithRange):
1240         (AccessibilityUIElement::rowHeaders const):
1241         (AccessibilityUIElement::columnHeaders const):
1242         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1243         (AccessibilityUIElement::searchTextWithCriteria):
1244         (AccessibilityUIElement::attributesOfColumnHeaders):
1245         (AccessibilityUIElement::attributesOfRowHeaders):
1246         (AccessibilityUIElement::attributesOfColumns):
1247         (AccessibilityUIElement::attributesOfRows):
1248         (AccessibilityUIElement::attributesOfVisibleCells):
1249         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1250         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1251         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1252         (WTR::convertVectorToObjectArray):
1253         (WTR::convertNSArrayToVector):
1254         (WTR::searchTextParameterizedAttributeForCriteria):
1255         (WTR::AccessibilityUIElement::getLinkedUIElements):
1256         (WTR::AccessibilityUIElement::getDocumentLinks):
1257         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1258         (WTR::AccessibilityUIElement::getChildren):
1259         (WTR::AccessibilityUIElement::getChildrenWithRange):
1260         (WTR::AccessibilityUIElement::rowHeaders const):
1261         (WTR::AccessibilityUIElement::columnHeaders const):
1262         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1263         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1264         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1265         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1266         (WTR::AccessibilityUIElement::attributesOfColumns):
1267         (WTR::AccessibilityUIElement::attributesOfRows):
1268         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1269         (WTR::convertElementsToObjectArray): Deleted.
1270
1271 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1272
1273         Multiple File Input Icon Set Regardless of File List
1274         https://bugs.webkit.org/show_bug.cgi?id=195537
1275
1276         Reviewed by Alexey Proskuryakov.
1277
1278         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1279         display string in iOS file inputs
1280
1281         * DumpRenderTree/TestRunner.cpp:
1282         (SetOpenPanelFilesMediaIconCallback):
1283         (TestRunner::staticFunctions):
1284         (TestRunner::setOpenPanelFilesMediaIcon):
1285         * DumpRenderTree/TestRunner.h:
1286         (TestRunner::openPanelFilesMediaIcon const):
1287         * DumpRenderTree/mac/UIDelegate.mm:
1288         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1289         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1290         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1291         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1292         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1293         * WebKitTestRunner/TestController.cpp:
1294         (WTR::runOpenPanel):
1295         (WTR::TestController::resetStateToConsistentValues):
1296         * WebKitTestRunner/TestController.h:
1297         (WTR::TestController::openPanelFileURLsMediaIcon const):
1298         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1299         * WebKitTestRunner/TestInvocation.cpp:
1300         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1301
1302 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1303
1304         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1305         https://bugs.webkit.org/show_bug.cgi?id=197171
1306         <rdar://problem/47454979>
1307
1308         Reviewed by Youenn Fablet.
1309
1310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1311         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1312         (TestWebKitAPI::TEST):
1313
1314 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1315
1316         [ews-build] Add unit tests for UnApplyPatchIfRequired
1317         https://bugs.webkit.org/show_bug.cgi?id=197197
1318
1319         Reviewed by Lucas Forschler.
1320
1321         * BuildSlaveSupport/ews-build/steps_unittest.py:
1322         (TestUnApplyPatchIfRequired):
1323         (TestUnApplyPatchIfRequired.test_success):
1324         (TestUnApplyPatchIfRequired.test_failure):
1325         (TestUnApplyPatchIfRequired.test_skip):
1326
1327 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1328
1329         [ews-build] Add unit tests for CleanWorkingDirectory
1330         https://bugs.webkit.org/show_bug.cgi?id=197195
1331
1332         Reviewed by Lucas Forschler.
1333
1334         * BuildSlaveSupport/ews-build/steps_unittest.py:
1335         (TestCleanWorkingDirectory):
1336         (TestCleanWorkingDirectory.test_success):
1337         (TestCleanWorkingDirectory.test_failure):
1338
1339 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1340
1341         [ews-build] Use explicit imports instead of wildcard imports
1342         https://bugs.webkit.org/show_bug.cgi?id=197194
1343
1344         Reviewed by Lucas Forschler.
1345
1346         * BuildSlaveSupport/ews-build/factories.py:
1347         * BuildSlaveSupport/ews-build/loadConfig.py:
1348         * BuildSlaveSupport/ews-build/steps_unittest.py:
1349
1350 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1351
1352         [ews-build] Add unit tests for DownloadBuiltProduct
1353         https://bugs.webkit.org/show_bug.cgi?id=197193
1354
1355         Reviewed by Lucas Forschler.
1356
1357         * BuildSlaveSupport/ews-build/steps_unittest.py:
1358         (TestDownloadBuiltProduct):
1359         (TestDownloadBuiltProduct.setUp):
1360         (TestDownloadBuiltProduct.tearDown):
1361         (TestDownloadBuiltProduct.test_success):
1362         (TestDownloadBuiltProduct.test_failure):
1363
1364 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1365
1366         [ews-app] Exception while loading status-bubble when no build step has started
1367         https://bugs.webkit.org/show_bug.cgi?id=196676
1368
1369         Reviewed by Lucas Forschler.
1370
1371         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1372         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1373
1374 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1375
1376         [PlayStation] Support running of JSC tests on remote playstation devices
1377         https://bugs.webkit.org/show_bug.cgi?id=197170
1378
1379         Reviewed by Ross Kirsling.
1380
1381         Script changes
1382
1383         * Scripts/run-javascriptcore-tests:
1384         (runJSCStressTests): Pass arguments for playstation to
1385         run-jsc-stress-tests
1386         * Scripts/run-jsc-stress-tests:
1387         Handle $hostOS=="playstation" for determineArchitecture, turning
1388         off $isFTLPlatform and runProfiler and defaulting test writer.
1389         * Scripts/webkitdirs.pm:
1390         (jscPath): PlayStation WebKit executables have .elf extension
1391         (executableProductDir): PlayStation builds on Windows hosts but
1392         uses bin directory rather than bin64/bin32 for executable output
1393         location.
1394         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1395
1396 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1397
1398         [CMake][Win] Use target oriented design for WebKit
1399         https://bugs.webkit.org/show_bug.cgi?id=197173
1400
1401         Reviewed by Alex Christensen.
1402
1403         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1404         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1405
1406 2019-04-23  Chris Dumez  <cdumez@apple.com>
1407
1408         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1409         https://bugs.webkit.org/show_bug.cgi?id=197097
1410         <rdar://problem/50048318>
1411
1412         Reviewed by Alex Christensen.
1413
1414         Add API test coverage.
1415
1416         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1417         (-[PSONScheme webView:startURLSchemeTask:]):
1418
1419 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1420
1421         [ATK] Implement AtkComponentIface scroll_to methods
1422         https://bugs.webkit.org/show_bug.cgi?id=196856
1423
1424         Reviewed by Michael Catanzaro.
1425
1426         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1427         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1428         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1429         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1430
1431 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1432
1433         [ews-build] Improve summary for UploadBuiltProduct step
1434         https://bugs.webkit.org/show_bug.cgi?id=197182
1435
1436         Reviewed by Lucas Forschler.
1437
1438         * BuildSlaveSupport/ews-build/steps.py:
1439         (UploadBuiltProduct): Added descriptionDone.
1440         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1441         * BuildSlaveSupport/ews-build/steps_unittest.py:
1442         (TestUploadBuiltProduct.test_success): Updated unit-test.
1443         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1444
1445 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1446
1447         [ews-build] Trigger queues only after uploading the archive
1448         https://bugs.webkit.org/show_bug.cgi?id=197180
1449
1450         Reviewed by Lucas Forschler.
1451
1452         * BuildSlaveSupport/ews-build/factories.py:
1453         (Factory.__init__):
1454         (BuildFactory.__init__): Remove trigger step from factories.
1455         (BuildFactory.propertiesToPassToTriggers): Deleted.
1456         * BuildSlaveSupport/ews-build/steps.py:
1457         (ConfigureBuild.__init__): Confiure triggers property.
1458         (Trigger): Step to trigger other queues.
1459         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1460         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1461
1462 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1463
1464         Deprecate WKContextCreateWithInjectedBundlePath
1465         https://bugs.webkit.org/show_bug.cgi?id=197169
1466
1467         Reviewed by Youenn Fablet.
1468
1469         * TestWebKitAPI/PlatformUtilities.cpp:
1470         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1471         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1472
1473 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1474
1475         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1476         https://bugs.webkit.org/show_bug.cgi?id=197093
1477         <rdar://problem/49708268>
1478
1479         Reviewed by Chris Dumez.
1480
1481         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1482         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1483         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1484         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1485         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1486
1487         * TestWebKitAPI/TCPServer.cpp:
1488         (TestWebKitAPI::TCPServer::TCPServer):
1489         (TestWebKitAPI::TCPServer::~TCPServer):
1490         (TestWebKitAPI::TCPServer::socketBindListen):
1491         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1492         * TestWebKitAPI/TCPServer.h:
1493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1494         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1495         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1496         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1497         (respondWithChallengeThenOK):
1498         (TestWebKitAPI::TEST):
1499         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1500         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1501         (TEST):
1502
1503 2019-04-22  Chris Dumez  <cdumez@apple.com>
1504
1505         Delayed WebProcessLaunch may break the _relatedWebView SPI
1506         https://bugs.webkit.org/show_bug.cgi?id=197160
1507
1508         Reviewed by Alex Christensen.
1509
1510         Add API test coverage.
1511
1512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1513
1514 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1515
1516         Use curl to download packages for webkitpy autoinstaller
1517         https://bugs.webkit.org/show_bug.cgi?id=197164
1518
1519         Reviewed by Darin Adler.
1520
1521         * Scripts/webkitpy/common/system/autoinstall.py:
1522         (AutoInstaller._download): Use curl(1) to download packages necessary for
1523         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1524         errors which are not present when using curl(1).
1525
1526 2019-04-22  Chris Dumez  <cdumez@apple.com>
1527
1528         Unreviewed, rolling out r244502.
1529
1530         Caused crashes on the bots
1531
1532         Reverted changeset:
1533
1534         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1535         https://bugs.webkit.org/show_bug.cgi?id=197160
1536         https://trac.webkit.org/changeset/244502
1537
1538 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1539
1540         Unreviewed, rolling out r244437.
1541
1542         Still breaks internal tests.
1543
1544         Reverted changeset:
1545
1546         "InjectedBundle parameters often need initialization function
1547         called before unarchiving"
1548         https://bugs.webkit.org/show_bug.cgi?id=189709
1549         https://trac.webkit.org/changeset/244437
1550
1551 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1552
1553         [ews-build] Use singular verb in failure description in case of single api test failure
1554         https://bugs.webkit.org/show_bug.cgi?id=197013
1555
1556         Reviewed by Lucas Forschler.
1557
1558         * BuildSlaveSupport/ews-build/steps.py:
1559         (AnalyzeAPITestsResults.analyzeResults):
1560
1561 2019-04-22  Chris Dumez  <cdumez@apple.com>
1562
1563         Delayed WebProcessLaunch may break the _relatedWebView SPI
1564         https://bugs.webkit.org/show_bug.cgi?id=197160
1565
1566         Reviewed by Alex Christensen.
1567
1568         Add API test coverage.
1569
1570         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1571
1572 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1573
1574         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1575         https://bugs.webkit.org/show_bug.cgi?id=194630
1576
1577         Reviewed by Michael Catanzaro.
1578
1579         Return early from getAttributeSet() is passed in accessible is nullptr.
1580
1581         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1582
1583 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1584
1585         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1586         https://bugs.webkit.org/show_bug.cgi?id=197145
1587         <rdar://problem/50078170>
1588
1589         Reviewed by Darin Adler.
1590
1591         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1592         focus, or showing the font manager.
1593
1594         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1595         (TestWebKitAPI::TEST):
1596         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1597         (TEST):
1598         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1599         (TestWebKitAPI::TEST):
1600
1601 2019-04-21  Brian Burg  <bburg@apple.com>
1602
1603         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1604         https://bugs.webkit.org/show_bug.cgi?id=197125
1605         <rdar://problem/50061468>
1606
1607         Reviewed by Darin Adler.
1608
1609         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1610         using this class rather than making our own ./wpt serve invocation.
1611
1612         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1613         (WebDriverW3CWebServer):
1614         (WebDriverW3CWebServer.document_root): Expose this to clients.
1615         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1616
1617         (WebDriverW3CWebServer.__enter__):
1618         (WebDriverW3CWebServer.__exit__):
1619         Make it possible to use the web server with a 'with' statement.
1620
1621 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1622
1623         [CMake][Win] Use target oriented design for WebKitLegacy
1624         https://bugs.webkit.org/show_bug.cgi?id=197112
1625
1626         Reviewed by Konstantin Tokarev.
1627
1628         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1629
1630         * DumpRenderTree/CMakeLists.txt:
1631         * DumpRenderTree/PlatformWin.cmake:
1632         * DumpRenderTree/win/EventSender.cpp:
1633
1634 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1635
1636         Update text for old EWS submit button
1637         https://bugs.webkit.org/show_bug.cgi?id=197140
1638
1639         Reviewed by Alexey Proskuryakov.
1640
1641         * QueueStatusServer/templates/statusbubble.html:
1642
1643 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1644
1645         [ews-app] New EWS should poll bugzilla more frequently
1646         https://bugs.webkit.org/show_bug.cgi?id=197138
1647
1648         Reviewed by Alexey Proskuryakov.
1649
1650         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1651         (FetchLoop.__init__):
1652
1653 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1654
1655         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1656         https://bugs.webkit.org/show_bug.cgi?id=197139
1657
1658         Reviewed by Alexey Proskuryakov.
1659
1660         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1661         * QueueStatusServer/templates/statusbubble.html:
1662
1663 2019-04-20  Chris Dumez  <cdumez@apple.com>
1664
1665         Unreviewed, fix iOS build with recent SDKs.
1666
1667         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1668
1669 2019-04-19  Keith Miller  <keith_miller@apple.com>
1670
1671         Add script to merge run_benchmark jsons
1672         https://bugs.webkit.org/show_bug.cgi?id=197107
1673
1674         Reviewed by Michael Saboff.
1675
1676         The script basically recursively decends through all json objects until it gets
1677         to an array or JSON primitive and concats or takes the first value, respectively.
1678
1679         This patch also adds +x bits to the compare-results script so it
1680         can be run directly from the command line. I had to add a new line so that svn
1681         will accept the change... yay svn!
1682
1683         * Scripts/compare-results:
1684         * Scripts/merge-result-jsons: Added.
1685         (readJSONFile):
1686         (deepAppend):
1687         (mergeJSONs):
1688         (main):
1689
1690 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1691
1692         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1693         https://bugs.webkit.org/show_bug.cgi?id=197079
1694
1695         Reviewed by Darin Adler.
1696
1697         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1698
1699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1700         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1701
1702 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1703
1704         Unreviewed, rolling out r244434.
1705         https://bugs.webkit.org/show_bug.cgi?id=197089
1706
1707         caused 1 API test failure (Requested by zalan on #webkit).
1708
1709         Reverted changeset:
1710
1711         "Regression (r244291): Broken API Test
1712         AutoLayoutRenderingProgressRelativeOrdering"
1713         https://bugs.webkit.org/show_bug.cgi?id=196948
1714         https://trac.webkit.org/changeset/244434
1715
1716 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1717
1718         Add new compatibility mode API on WKNavigation
1719         https://bugs.webkit.org/show_bug.cgi?id=197069
1720         <rdar://problem/50025800>
1721
1722         Reviewed by Tim Horton.
1723
1724         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1725
1726         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1727         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1728         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1729
1730 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1731
1732         [CMake] Make WebCore headers copies
1733         https://bugs.webkit.org/show_bug.cgi?id=182512
1734         <rdar://problem/37510435>
1735
1736         Reviewed by Alex Christensen.
1737
1738         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1739         ports.
1740
1741         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1742         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1743
1744         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1745         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1746         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1747         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1748         * TestWebKitAPI/CMakeLists.txt:
1749         * TestWebKitAPI/PlatformWin.cmake:
1750         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1751         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1752         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1753
1754 2019-04-18  Jer Noble  <jer.noble@apple.com>
1755
1756         Add support for parsing FairPlayStreaming PSSH boxes.
1757         https://bugs.webkit.org/show_bug.cgi?id=197064
1758
1759         Reviewed by Eric Carlson.
1760
1761         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1762         (TestWebKitAPI::TEST):
1763
1764 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1765
1766         InjectedBundle parameters often need initialization function called before unarchiving
1767         https://bugs.webkit.org/show_bug.cgi?id=189709
1768         <rdar://problem/44573653>
1769
1770         Reviewed by Ryosuke Niwa.
1771
1772         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1773         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1774
1775 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1776
1777         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1778         https://bugs.webkit.org/show_bug.cgi?id=196948
1779         <rdar://problem/49927131>
1780
1781         Reviewed by Tim Horton.
1782
1783         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1784         (TEST): 
1785         The expected order of incoming events is
1786         1. didInvalidateIntrinsicContentSize
1787         2. didFirstLayout
1788         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1789         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1790         (and remember, all we care about is ordering).
1791
1792 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1793
1794         Unreviewed, rolling out r244299.
1795
1796         Breaks internal tests.
1797
1798         Reverted changeset:
1799
1800         "InjectedBundle parameters often need initialization function
1801         called before unarchiving"
1802         https://bugs.webkit.org/show_bug.cgi?id=189709
1803         https://trac.webkit.org/changeset/244299
1804
1805 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1806
1807         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1808         https://bugs.webkit.org/show_bug.cgi?id=197053
1809
1810         Reviewed by Saam Barati.
1811
1812         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1813         (TestWebKitAPI::TEST):
1814
1815 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1816
1817         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1818         https://bugs.webkit.org/show_bug.cgi?id=197028
1819         <rdar://problem/49985290>
1820
1821         Reviewed by Wenson Hsieh.
1822
1823         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1824         (TEST):
1825         Liberal application of waitForNextPresentationUpdate works around a race
1826         where if the page rapidly changes its viewport arguments (or an API client
1827         rapidly changes its viewport arguments), we'd get stuck thinking that the
1828         user had intentionally zoomed the page, and stop resetting the initial scale.
1829         This deserves a separate bug, but no need to keep the test failing while
1830         we think about it.
1831
1832 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1833
1834         REGRESSION (r241988): Switching tabs is slow
1835         https://bugs.webkit.org/show_bug.cgi?id=197037
1836         <rdar://problem/49951473>
1837
1838         Reviewed by Simon Fraser.
1839
1840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1841         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1842         (TEST):
1843         * TestWebKitAPI/cocoa/TestWKWebView.h:
1844         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1845         (-[TestWKWebView addToTestWindow]):
1846         Add a test that hangs without this fix.
1847
1848 2019-04-17  Truitt Savell  <tsavell@apple.com>
1849
1850         Unreviewed, rolling out r244400.
1851
1852         Caused testing to exit early with assertionon Debug WK2
1853
1854         Reverted changeset:
1855
1856         "UI↔Web deadlock when printing with a JavaScript alert
1857         visible"
1858         https://bugs.webkit.org/show_bug.cgi?id=196839
1859         https://trac.webkit.org/changeset/244400
1860
1861 2019-04-17  Brady Eidson  <beidson@apple.com>
1862
1863         Link clicks in PDFs shouldn't send referrer headers.
1864         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1865
1866         Reviewed by Tim Horton.
1867
1868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1869         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1870         (putPDFBytesCallback):
1871         (emptyReleaseInfoCallback):
1872         (createPDFWithLinkToURL):
1873         (TEST):
1874
1875 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1876
1877         UI↔Web deadlock when printing with a JavaScript alert visible
1878         https://bugs.webkit.org/show_bug.cgi?id=196839
1879         <rdar://problem/49157642>
1880
1881         Reviewed by Andy Estes.
1882
1883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1884         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1885         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1886         (TEST):
1887
1888 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1889
1890         WKRetainPtr's adoption constructor should be private
1891         https://bugs.webkit.org/show_bug.cgi?id=197019
1892
1893         Reviewed by Tim Horton.
1894
1895         * DumpRenderTree/mac/DumpRenderTree.mm:
1896         (dumpFramesAsText):
1897         * TestWebKitAPI/InjectedBundleController.cpp:
1898         (TestWebKitAPI::InjectedBundleController::initialize):
1899         * TestWebKitAPI/PlatformUtilities.cpp:
1900         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1901         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1902         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1903         (TestWebKitAPI::Util::toWK):
1904         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1905         (TestWebKitAPI::TEST):
1906         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1907         (TestWebKitAPI::TEST):
1908         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1909         (TestWebKitAPI::TEST):
1910         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1911         (TestWebKitAPI::TEST):
1912         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1913         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1914         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1915         (TestWebKitAPI::TEST):
1916         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1917         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1918         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1919         (TestWebKitAPI::TEST):
1920         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1921         (TestWebKitAPI::TEST):
1922         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1923         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1924         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1925         (TestWebKitAPI::TEST):
1926         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1927         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1928         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1929         (TestWebKitAPI::TEST):
1930         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1931         (TestWebKitAPI::TEST):
1932         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1933         (TestWebKitAPI::TEST):
1934         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1935         (TestWebKitAPI::TEST):
1936         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1937         (TestWebKitAPI::TEST):
1938         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1939         (TestWebKitAPI::TEST):
1940         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1941         (TestWebKitAPI::TEST):
1942         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1943         (TestWebKitAPI::TEST):
1944         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1945         (TestWebKitAPI::TEST):
1946         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1947         (TestWebKitAPI::TEST):
1948         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1949         (TestWebKitAPI::TEST):
1950         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1951         (TestWebKitAPI::TEST):
1952         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1953         (TestWebKitAPI::TEST):
1954         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1955         (TestWebKitAPI::TEST):
1956         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1957         (TestWebKitAPI::TEST):
1958         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1959         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1960         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1961         (TestWebKitAPI::TEST):
1962         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1963         (TestWebKitAPI::TEST):
1964         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1965         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1966         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1967         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1968         (TestWebKitAPI::TEST):
1969         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1970         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1971         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1972         (TestWebKitAPI::TEST):
1973         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1974         (TestWebKitAPI::TEST):
1975         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1976         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1977         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1978         (TestWebKitAPI::TEST):
1979         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1980         (TestWebKitAPI::loadAlternateHTMLString):
1981         (TestWebKitAPI::TEST):
1982         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1983         (TestWebKitAPI::TEST):
1984         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1985         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1986         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1987         (TestWebKitAPI::buildAndPerformTest):
1988         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1989         (TestWebKitAPI::TEST):
1990         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1991         (TestWebKitAPI::TEST):
1992         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1993         (TestWebKitAPI::TEST):
1994         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1995         (TestWebKitAPI::TEST):
1996         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1997         (TestWebKitAPI::TEST):
1998         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1999         (TestWebKitAPI::TEST):
2000         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2001         (TestWebKitAPI::TEST):
2002         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2003         (TestWebKitAPI::TEST):
2004         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2005         (TestWebKitAPI::TEST):
2006         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2007         (TestWebKitAPI::TEST):
2008         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2009         (TestWebKitAPI::TEST):
2010         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2011         (TestWebKitAPI::TEST):
2012         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2013         (TestWebKitAPI::TEST):
2014         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2015         (TestWebKitAPI::TEST):
2016         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2017         (TestWebKitAPI::TEST):
2018         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2019         (TestWebKitAPI::TEST):
2020         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2021         (TestWebKitAPI::TEST):
2022         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2023         (TestWebKitAPI::TEST):
2024         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2025         (TestWebKitAPI::TEST):
2026         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2027         (TestWebKitAPI::TEST):
2028         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2029         (TestWebKitAPI::TEST):
2030         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2031         (TestWebKitAPI::TEST):
2032         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2033         (TestWebKitAPI::TEST):
2034         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2035         (TestWebKitAPI::TEST):
2036         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2037         (TestWebKitAPI::TEST):
2038         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2039         (TestWebKitAPI::TEST):
2040         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2041         (TestWebKitAPI::TEST):
2042         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2043         (TestWebKitAPI::TEST):
2044         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2045         (TestWebKitAPI::TEST):
2046         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2047         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2048         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2049         (TestWebKitAPI::TEST):
2050         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2051         (TestWebKitAPI::TEST):
2052         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2053         (TestWebKitAPI::TEST):
2054         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2055         (TestWebKitAPI::TEST):
2056         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2057         (TestWebKitAPI::TEST):
2058         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2059         (TestWebKitAPI::TEST):
2060         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2061         (TestWebKitAPI::TEST):
2062         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2063         (TestWebKitAPI::TEST):
2064         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2065         (TestWebKitAPI::TEST):
2066         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2067         (TestWebKitAPI::TEST):
2068         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2069         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2070         (TEST):
2071         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2072         (TEST):
2073         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2074         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2075         (TEST):
2076         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2077         (TestWebKitAPI::TEST):
2078         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2079         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2080         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2081         (WTR::getMenuItemTitleCallback):
2082         (WTR::createMouseMessageBody):
2083         (WTR::EventSendingController::mouseDown):
2084         (WTR::EventSendingController::mouseUp):
2085         (WTR::EventSendingController::mouseMoveTo):
2086         (WTR::EventSendingController::mouseForceClick):
2087         (WTR::EventSendingController::startAndCancelMouseForceClick):
2088         (WTR::EventSendingController::mouseForceDown):
2089         (WTR::EventSendingController::mouseForceUp):
2090         (WTR::EventSendingController::mouseForceChanged):
2091         (WTR::EventSendingController::leapForward):
2092         (WTR::EventSendingController::scheduleAsynchronousClick):
2093         (WTR::createKeyDownMessageBody):
2094         (WTR::EventSendingController::keyDown):
2095         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2096         (WTR::EventSendingController::mouseScrollBy):
2097         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2098         (WTR::EventSendingController::continuousMouseScrollBy):
2099         (WTR::EventSendingController::addTouchPoint):
2100         (WTR::EventSendingController::updateTouchPoint):
2101         (WTR::EventSendingController::setTouchModifier):
2102         (WTR::EventSendingController::setTouchPointRadius):
2103         (WTR::EventSendingController::touchStart):
2104         (WTR::EventSendingController::touchMove):
2105         (WTR::EventSendingController::touchEnd):
2106         (WTR::EventSendingController::touchCancel):
2107         (WTR::EventSendingController::clearTouchPoints):
2108         (WTR::EventSendingController::releaseTouchPoint):
2109         (WTR::EventSendingController::cancelTouchPoint):
2110         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2111         (WTR::InjectedBundle::didCreatePage):
2112         (WTR::InjectedBundle::didReceiveMessage):
2113         (WTR::InjectedBundle::didReceiveMessageToPage):
2114         (WTR::InjectedBundle::booleanForKey):
2115         (WTR::InjectedBundle::done):
2116         (WTR::InjectedBundle::dumpToStdErr):
2117         (WTR::InjectedBundle::outputText):
2118         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2119         (WTR::InjectedBundle::postAddChromeInputField):
2120         (WTR::InjectedBundle::postRemoveChromeInputField):
2121         (WTR::InjectedBundle::postFocusWebView):
2122         (WTR::InjectedBundle::postSetBackingScaleFactor):
2123         (WTR::InjectedBundle::postSetWindowIsKey):
2124         (WTR::InjectedBundle::postSetViewSize):
2125         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2126         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2127         (WTR::InjectedBundle::setGeolocationPermission):
2128         (WTR::InjectedBundle::setMockGeolocationPosition):
2129         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2130         (WTR::InjectedBundle::isGeolocationProviderActive const):
2131         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2132         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2133         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2134         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2135         (WTR::InjectedBundle::setCustomPolicyDelegate):
2136         (WTR::InjectedBundle::setHidden):
2137         (WTR::InjectedBundle::setCacheModel):
2138         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2139         (WTR::InjectedBundle::processWorkQueue):
2140         (WTR::InjectedBundle::queueBackNavigation):
2141         (WTR::InjectedBundle::queueForwardNavigation):
2142         (WTR::InjectedBundle::queueLoad):
2143         (WTR::InjectedBundle::queueLoadHTMLString):
2144         (WTR::InjectedBundle::queueReload):
2145         (WTR::InjectedBundle::queueLoadingScript):
2146         (WTR::InjectedBundle::queueNonLoadingScript):
2147         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2148         (WTR::frameToStr):
2149         (WTR::InjectedBundlePage::InjectedBundlePage):
2150         (WTR::dumpFrameDescriptionSuitableForTestResult):
2151         (WTR::dumpFrameScrollPosition):
2152         (WTR::dumpDescendantFrameScrollPositions):
2153         (WTR::dumpFrameText):
2154         (WTR::dumpDescendantFramesText):
2155         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2156         (WTR::TestRunner::shouldDumpPixels const):
2157         (WTR::TestRunner::setDumpPixels):
2158         (WTR::TestRunner::whatToDump const):
2159         (WTR::TestRunner::setWhatToDump):
2160         (WTR::TestRunner::setWaitUntilDone):
2161         (WTR::TestRunner::shouldWaitUntilDone const):
2162         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2163         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2164         (WTR::TestRunner::clearAllDatabases):
2165         (WTR::TestRunner::setIDBPerOriginQuota):
2166         (WTR::TestRunner::originsWithApplicationCache):
2167         (WTR::TestRunner::setCanOpenWindows):
2168         (WTR::TestRunner::setXSSAuditorEnabled):
2169         (WTR::TestRunner::setMediaDevicesEnabled):
2170         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2171         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2172         (WTR::TestRunner::setCustomUserAgent):
2173         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2174         (WTR::TestRunner::setModernMediaControlsEnabled):
2175         (WTR::TestRunner::setWebGL2Enabled):
2176         (WTR::TestRunner::setWritableStreamAPIEnabled):
2177         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2178         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2179         (WTR::TestRunner::setAllowsAnySSLCertificate):
2180         (WTR::TestRunner::setPluginsEnabled):
2181         (WTR::TestRunner::setValueForUser):
2182         (WTR::TestRunner::setAudioResult):
2183         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2184         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2185         (WTR::TestRunner::setAlwaysAcceptCookies):
2186         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2187         (WTR::TestRunner::isDoingMediaCapture const):
2188         (WTR::TestRunner::queueLoad):
2189         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2190         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2191         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2192         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2193         (WTR::TestRunner::setAuthenticationUsername):
2194         (WTR::TestRunner::setAuthenticationPassword):
2195         (WTR::TestRunner::secureEventInputIsEnabled const):
2196         (WTR::TestRunner::setBlockAllPlugins):
2197         (WTR::TestRunner::setPluginSupportedMode):
2198         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2199         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2200         (WTR::TestRunner::setNavigationGesturesEnabled):
2201         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2202         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2203         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2204         (WTR::TestRunner::terminateNetworkProcess):
2205         (WTR::TestRunner::terminateServiceWorkerProcess):
2206         (WTR::TestRunner::runUIScript):
2207         (WTR::TestRunner::setStatisticsDebugMode):
2208         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2209         (WTR::TestRunner::setStatisticsLastSeen):
2210         (WTR::TestRunner::setStatisticsPrevalentResource):
2211         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2212         (WTR::TestRunner::dumpResourceLoadStatistics):
2213         (WTR::TestRunner::isStatisticsPrevalentResource):
2214         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2215         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2216         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2217         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2218         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2219         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2220         (WTR::TestRunner::setStatisticsGrandfathered):
2221         (WTR::TestRunner::isStatisticsGrandfathered):
2222         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2223         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2224         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2225         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2226         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2227         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2228         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2229         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2230         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2231         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2232         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2233         (WTR::TestRunner::statisticsSubmitTelemetry):
2234         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2235         (WTR::TestRunner::setStatisticsIsRunningTest):
2236         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2237         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2238         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2239         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2240         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2241         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2242         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2243         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2244         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2245         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2246         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2247         (WTR::TestRunner::statisticsResetToConsistentState):
2248         (WTR::TestRunner::setStorageAccessAPIEnabled):
2249         (WTR::TestRunner::getAllStorageAccessEntries):
2250         (WTR::TestRunner::addMockMediaDevice):
2251         (WTR::TestRunner::clearMockMediaDevices):
2252         (WTR::TestRunner::removeMockMediaDevice):
2253         (WTR::TestRunner::resetMockMediaDevices):
2254         (WTR::TestRunner::connectMockGamepad):
2255         (WTR::TestRunner::disconnectMockGamepad):
2256         (WTR::TestRunner::setMockGamepadDetails):
2257         (WTR::TestRunner::setMockGamepadAxisValue):
2258         (WTR::TestRunner::setMockGamepadButtonValue):
2259         (WTR::TestRunner::removeAllSessionCredentials):
2260         (WTR::TestRunner::clearDOMCache):
2261         (WTR::TestRunner::clearDOMCaches):
2262         (WTR::TestRunner::hasDOMCache):
2263         (WTR::TestRunner::domCacheSize):
2264         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2265         (WTR::TestRunner::getApplicationManifestThen):
2266         (WTR::TestRunner::injectUserScript):
2267         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2268         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2269         (WTR::TestRunner::addTestKeyToKeychain):
2270         (WTR::TestRunner::cleanUpKeychain):
2271         (WTR::TestRunner::keyExistsInKeychain):
2272         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2273         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2274         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2275         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2276         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2277         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2278         * WebKitTestRunner/TestController.cpp:
2279         (WTR::TestController::initialize):
2280         (WTR::parseStringTestHeaderValueAsRelativePath):
2281         (WTR::updateTestOptionsFromTestHeader):
2282         (WTR::TestController::runTest):
2283         (WTR::TestController::didReceiveLiveDocumentsList):
2284         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2285         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2286         (WTR::TestController::didFinishNavigation):
2287         (WTR::TestController::didReceiveAuthenticationChallenge):
2288         * WebKitTestRunner/TestInvocation.cpp:
2289         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2290         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2291         (WTR::TestInvocation::uiScriptDidComplete):
2292         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2293         * WebKitTestRunner/WebNotificationProvider.cpp:
2294         (WTR::WebNotificationProvider::closeWebNotification):
2295         * WebKitTestRunner/WorkQueueManager.cpp:
2296         (WTR::ScriptItem::ScriptItem):
2297         (WTR::WorkQueueManager::queueLoad):
2298         (WTR::WorkQueueManager::queueLoadHTMLString):
2299
2300 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2301
2302         Add a comment to make my test from r244139 less mysterious.
2303         https://bugs.webkit.org/show_bug.cgi?id=196744
2304
2305         As suggested by Darin Adler.
2306
2307         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2308         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2309
2310 2019-04-17  Chris Dumez  <cdumez@apple.com>
2311
2312         Remember device orientation permission for the duration of the browsing session
2313         https://bugs.webkit.org/show_bug.cgi?id=196992
2314         <rdar://problem/49946067>
2315
2316         Reviewed by Alex Christensen.
2317
2318         Add API test coverage.
2319
2320         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2321         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2322         (TEST):
2323
2324 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2325
2326         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2327         https://bugs.webkit.org/show_bug.cgi?id=196675
2328
2329         Reviewed by Lucas Forschler.
2330
2331         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2332         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2333
2334 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2335
2336         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2337         https://bugs.webkit.org/show_bug.cgi?id=196919
2338         <rdar://problem/41630459>
2339
2340         Reviewed by Tim Horton.
2341
2342         Add iOS support for several new testing hooks. See below for more detail.
2343
2344         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2345         (WTR::UIScriptController::isDismissingMenu const):
2346
2347         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2348         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2349         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2350
2351         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2352         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2353         (WTR::UIScriptController::isDismissingMenu const):
2354         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2355         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2356         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2357         (WTR::InjectedBundle::didReceiveMessageToPage):
2358         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2359         (WTR::TestRunner::setAllowedMenuActions):
2360
2361         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2362         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2363         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2364         against the name of the custom action.
2365
2366         (WTR::TestRunner::installCustomMenuAction):
2367
2368         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2369         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2370         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2371         triggered.
2372
2373         (WTR::TestRunner::performCustomMenuAction):
2374
2375         Invoked when the custom menu action is triggered.
2376
2377         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2378         * WebKitTestRunner/TestController.cpp:
2379         (WTR::TestController::installCustomMenuAction):
2380         (WTR::TestController::setAllowedMenuActions):
2381         * WebKitTestRunner/TestController.h:
2382         * WebKitTestRunner/TestInvocation.cpp:
2383         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2384         (WTR::TestInvocation::performCustomMenuAction):
2385
2386         Add plumbing to call back into the injected bundle when performing the custom action.
2387
2388         * WebKitTestRunner/TestInvocation.h:
2389         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2390         (WTR::TestController::installCustomMenuAction):
2391         (WTR::TestController::setAllowedMenuActions):
2392         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2393         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2394         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2395         (-[TestRunnerWKWebView becomeFirstResponder]):
2396         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2397
2398         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2399         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2400         in the Mail app on iOS.
2401
2402         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2403         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2404         (-[TestRunnerWKWebView resetCustomMenuAction]):
2405         (-[TestRunnerWKWebView performCustomAction:]):
2406         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2407         (-[TestRunnerWKWebView _willHideMenu]):
2408         (-[TestRunnerWKWebView _didHideMenu]):
2409         * WebKitTestRunner/ios/TestControllerIOS.mm:
2410         (WTR::TestController::platformResetStateToConsistentValues):
2411
2412         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2413         if specified.
2414
2415         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2416         (WTR::UIScriptController::isDismissingMenu const):
2417
2418 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2419
2420         Allow sharing from imageSheet on an image document
2421         https://bugs.webkit.org/show_bug.cgi?id=196891
2422         <rdar://problem/25377386>
2423
2424         Reviewed by Tim Horton.
2425
2426         Test to make sure that the correct imageURL is extracted from an image element.
2427
2428         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2429         (TestWebKitAPI::TEST):
2430
2431 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2432
2433         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2434         https://bugs.webkit.org/show_bug.cgi?id=196995
2435
2436         Reviewed by Brady Eidson.
2437
2438         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2439         (TEST):
2440
2441 2019-04-16  Chris Dumez  <cdumez@apple.com>
2442
2443         URL set by document.open() is not communicated to the UIProcess
2444         https://bugs.webkit.org/show_bug.cgi?id=196941
2445         <rdar://problem/49237544>
2446
2447         Reviewed by Geoff Garen.
2448
2449         Add API test coverage.
2450
2451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2452         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2453         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2454         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2455         (TEST):
2456
2457 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2458
2459         Unreviewed, rolling out r244321.
2460         https://bugs.webkit.org/show_bug.cgi?id=196968
2461
2462         Causing all WK2 Debug builds to exit early after Assertion
2463         failures. (Requested by ShawnRoberts on #webkit).
2464
2465         Reverted changeset:
2466
2467         "URL set by document.open() is not communicated to the
2468         UIProcess"
2469         https://bugs.webkit.org/show_bug.cgi?id=196941
2470         https://trac.webkit.org/changeset/244321
2471
2472 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2473
2474         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2475         https://bugs.webkit.org/show_bug.cgi?id=196948
2476
2477         Reviewed by Zalan Bujtas.
2478
2479         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2480         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2481
2482 2019-04-15  Chris Dumez  <cdumez@apple.com>
2483
2484         URL set by document.open() is not communicated to the UIProcess
2485         https://bugs.webkit.org/show_bug.cgi?id=196941
2486         <rdar://problem/49237544>
2487
2488         Reviewed by Geoffrey Garen.
2489
2490         Add API test coverage.
2491
2492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2493         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2494         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2495         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2496         (TEST):
2497
2498 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2499
2500         Using Tools/Scripts/clean-webkit should not install requests
2501         https://bugs.webkit.org/show_bug.cgi?id=196940
2502
2503         Reviewed by Lucas Forschler.
2504
2505         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2506         existing, depending on the path autoinstalled is run through.
2507         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2508         needed.
2509         (Port.configuration_for_upload):
2510         (Port.commits_for_upload):
2511
2512 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2513
2514         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2515         https://bugs.webkit.org/show_bug.cgi?id=196773
2516
2517         Reviewed by Jer Noble.
2518
2519         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2520         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2521         (TEST):
2522
2523 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2524
2525         ews-build should clearly indicate flaky test failures
2526         https://bugs.webkit.org/show_bug.cgi?id=196947
2527
2528         Reviewed by Lucas Forschler.
2529
2530         * BuildSlaveSupport/ews-build/steps.py:
2531         (AnalyzeAPITestsResults.analyzeResults):
2532
2533 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2534
2535         InjectedBundle parameters often need initialization function called before unarchiving
2536         https://bugs.webkit.org/show_bug.cgi?id=189709
2537         <rdar://problem/44573653>
2538
2539         Reviewed by Ryosuke Niwa.
2540
2541         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2542         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2543
2544 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2545
2546         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2547         https://bugs.webkit.org/show_bug.cgi?id=196681
2548
2549         Reviewed by Darin Adler.
2550
2551         Added tests.
2552
2553         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2554         (WTF_HashSet.RemoveIf):
2555         (WTF_HashSet.RemoveIfShrinkToBestSize):
2556
2557 2019-04-15  John Wilander  <wilander@apple.com>
2558
2559         Send delayed Ad Click Attribution conversion requests to the click source
2560         https://bugs.webkit.org/show_bug.cgi?id=196838
2561         <rdar://problem/47650157>
2562
2563         Reviewed by Chris Dumez and Youenn Fablet.
2564
2565         This patch adds test infrastructure to override the default behavior in
2566         WebKit::NetworkAdClickAttribution.
2567
2568         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2569         (TestWebKitAPI::TEST):
2570         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2572         (WTR::TestRunner::dumpAdClickAttribution):
2573         (WTR::TestRunner::clearAdClickAttribution):
2574         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2575         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2576         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2577         * WebKitTestRunner/TestController.cpp:
2578         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2579         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2580         * WebKitTestRunner/TestController.h:
2581         * WebKitTestRunner/TestInvocation.cpp:
2582         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2583
2584 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2585
2586         [ews-app] status-bubble should display position in queue
2587         https://bugs.webkit.org/show_bug.cgi?id=196607
2588
2589         Reviewed by Lucas Forschler.
2590
2591         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2592         (StatusBubble._build_bubble):
2593         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2594
2595 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2596
2597         [ews-build] Do not run clean build by default on EWS builders
2598         https://bugs.webkit.org/show_bug.cgi?id=196897
2599
2600         Reviewed by Lucas Forschler.
2601
2602         * BuildSlaveSupport/ews-build/steps.py:
2603         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2604         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2605         untracked directories like WebKitBuild).
2606         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2607         untracked files/directories (like WebKitBuild).
2608
2609 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2610
2611         TestRunner::notifyDone() should be safely reentrant
2612         https://bugs.webkit.org/show_bug.cgi?id=196898
2613
2614         Reviewed by Darin Adler.
2615
2616         It is currently possible that TestRunner::notifyDone() will call itself, since
2617         notifyDone() will force a repaint, which can start executing JavaScript, which
2618         may call notifyDone() again. This can lead to test failures and flakiness.
2619         Fix this by setting the m_waitToDump flag before calling the dump() method.
2620
2621         * DumpRenderTree/mac/TestRunnerMac.mm:
2622         (TestRunner::notifyDone):
2623         (TestRunner::forceImmediateCompletion):
2624         * DumpRenderTree/win/TestRunnerWin.cpp:
2625         (TestRunner::notifyDone):
2626         (TestRunner::forceImmediateCompletion):
2627
2628 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2629
2630         [GTK][WPE] Add enable-media websetting
2631         https://bugs.webkit.org/show_bug.cgi?id=196863
2632
2633         Reviewed by Michael Catanzaro.
2634
2635         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2636         (testWebKitSettings): Add test for the enable-media web-setting.
2637
2638 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2639
2640         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2641         https://bugs.webkit.org/show_bug.cgi?id=196905
2642         <rdar://problem/49886096>
2643
2644         Reviewed by Tim Horton.
2645
2646         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2647         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2648         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2649         delay timer, we end up with this sequence of events in the problematic (failure) case:
2650
2651         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2652             ...IPC from UI to web process...
2653         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2654             ...IPC from web to UI process...
2655         (c) [UI]    Invoke completion handler for script #1
2656         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2657             ...IPC from UI to web process...
2658         (e) [Web]   Evaluate script #2 in the web process
2659         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2660
2661         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2662         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2663         #2 is run in step (e).
2664
2665         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2666         the UI process by waiting on a script message posted by the web process, after attachment updates are
2667         dispatched.
2668
2669         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2670         (TestWebKitAPI::TEST):
2671
2672 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2673
2674         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2675         https://bugs.webkit.org/show_bug.cgi?id=196909
2676
2677         Reviewed by Wenson Hsieh.
2678
2679         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2680         (TestWebKitAPI::TEST):
2681
2682 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2683
2684         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2685         https://bugs.webkit.org/show_bug.cgi?id=196880
2686
2687         Reviewed by Yusuke Suzuki.
2688
2689         Add a new function for bytecode cache tests that does not forceDiskCache
2690         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2691         test added in this patch, since the code is invalid and therefore won't be
2692         cached. It should also be useful for tests that evaluate dynamically
2693         generated code.
2694
2695         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2696         * Scripts/run-jsc-stress-tests:
2697
2698 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2699
2700         Update AudioSession route sharing policy
2701         https://bugs.webkit.org/show_bug.cgi?id=196776
2702         <rdar://problem/46501611>
2703
2704         Reviewed by Jer Noble.
2705
2706         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2707         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2708         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2709         (TestWebKitAPI::TEST):
2710
2711 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2712
2713         [iOS] Software keyboard is shown too frequently on some websites
2714         https://bugs.webkit.org/show_bug.cgi?id=195856
2715         <rdar://problem/49191395>
2716
2717         Reviewed by Darin Adler.
2718
2719         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2720
2721         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2722         (WTR::UIScriptController::setHardwareKeyboardAttached):
2723         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2724         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2725         (WTR::UIScriptController::setHardwareKeyboardAttached):
2726         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2727         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2728
2729         Additionally link against GraphicsServices in WebKitTestRunner.
2730
2731         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2732         (WTR::TestController::platformResetStateToConsistentValues):
2733         (WTR::UIScriptController::setHardwareKeyboardAttached):
2734
2735 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2736
2737         [GTK][WPE] Fix pacman install-dependencies packages
2738         https://bugs.webkit.org/show_bug.cgi?id=196817
2739
2740         Reviewed by Žan Doberšek.
2741         
2742         python3-setuptools is called python-setuptools
2743         ruby-highline is only available on AUR
2744         libv4l-devel is incorporated in v4l-utils
2745
2746         * gtk/install-dependencies:
2747         * wpe/install-dependencies:
2748
2749 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2750
2751         [GTK] REGRESSION(r243860): Many tests failing
2752         https://bugs.webkit.org/show_bug.cgi?id=196791
2753
2754         Reviewed by Joanmarie Diggs.
2755
2756         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2757         multiple documents and check that accessibility hierarchy is updated after a navigation.
2758
2759         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2760         (loadChangedCallback):
2761         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2762         (AccessibilityTest::AccessibilityTest):
2763         (AccessibilityTest::~AccessibilityTest):
2764         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2765         (AccessibilityTest::findTestServerApplication):
2766         (AccessibilityTest::findDocumentWeb):
2767         (AccessibilityTest::findRootObject):
2768         (AccessibilityTest::waitUntilChildrenRemoved):
2769         (AccessibilityTest::ensureProxy):
2770         (testAtspiBasicHierarchy):
2771         (beforeAll):
2772         (afterAll):
2773
2774 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2775
2776         [ews-build] Handle bug titles with unicode characters
2777         https://bugs.webkit.org/show_bug.cgi?id=196802
2778
2779         Reviewed by Dewei Zhu.
2780
2781         * BuildSlaveSupport/ews-build/steps.py:
2782         (ValidatePatch._is_bug_closed):
2783
2784 2019-04-11  Michael Saboff  <msaboff@apple.com>
2785
2786         Improve the Inline Cache Stats code
2787         https://bugs.webkit.org/show_bug.cgi?id=196836
2788
2789         Reviewed by Saam Barati.
2790
2791         Added a new script to consolidate and arrange the output of --useICStats option.
2792
2793         This script merges the output from every group into one large table and sorts it from most common to
2794         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2795         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2796         Put together, this is useful to see what property accesses are not getting cached.
2797
2798         * Scripts/ic-stats.py: Added.
2799         (ICStats):
2800         (ICStats.__init__):
2801         (ICStats.parse):
2802         (ICStats.dumpStats):
2803         (usage):
2804
2805 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2806
2807         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2808         https://bugs.webkit.org/show_bug.cgi?id=196809
2809         <rdar://49800762>
2810
2811         Reviewed by Brady Eidson.
2812
2813         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2814         (TEST):
2815
2816 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2817
2818         requestAnimationFrame should execute before the next frame
2819         https://bugs.webkit.org/show_bug.cgi?id=177484
2820
2821         Reviewed by Simon Fraser.
2822
2823         Add trace points for the page RenderingUpdate.
2824
2825         * Tracing/SystemTracePoints.plist:
2826
2827 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2828
2829         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2830         https://bugs.webkit.org/show_bug.cgi?id=196760
2831
2832         Reviewed by Don Olmstead.
2833
2834         vswhere.exe has been bundled since Visual Studio 2017 version
2835         15.2. We shouldn't download vswhere.exe.
2836
2837         * Scripts/build-jsc: Do not call update-vswhere.py.
2838         * Scripts/build-webkit: Ditto.
2839         * Scripts/update-vswhere.py: Removed.
2840         * Scripts/webkitdirs.pm:
2841         (requireModulesForVSWhere): Deleted.
2842         (pickCurrentVisualStudioInstallation): Deleted.
2843         (visualStudioInstallDirVSWhere): Return the latest installed VS
2844         installation path by using the bundled vswhere.exe.
2845         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2846         (visualStudioInstallDirFallback): Removed.
2847
2848 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2849
2850         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2851         https://bugs.webkit.org/show_bug.cgi?id=196780
2852
2853         Reviewed by Alexey Proskuryakov.
2854
2855         * BuildSlaveSupport/ews-build/steps.py:
2856         * BuildSlaveSupport/ews-build/steps_unittest.py:
2857
2858 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2859
2860         Add SPI WKNavigationResponse._downloadAttribute
2861         https://bugs.webkit.org/show_bug.cgi?id=196755
2862         <rdar://49587365>
2863
2864         Reviewed by Brady Eidson.
2865
2866         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2867         (-[NavigationResponseTestDelegate navigationResponse]):
2868         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2869         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2870         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2871         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2872         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2873         (readRequest):
2874         (writeResponse):
2875         (TEST):
2876
2877 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2878
2879         Add modern API for overriding the page's specified viewport configuration
2880         https://bugs.webkit.org/show_bug.cgi?id=167734
2881         <rdar://problem/30331795>
2882
2883         Reviewed by Simon Fraser.
2884
2885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2886         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2887
2888 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2889
2890         Add support for incremental bytecode cache updates
2891         https://bugs.webkit.org/show_bug.cgi?id=195000
2892
2893         Reviewed by Filip Pizlo.
2894
2895         Exit when the initial run to generate bytecode fails.
2896
2897         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2898
2899 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2900
2901         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2902         https://bugs.webkit.org/show_bug.cgi?id=196744
2903         <rdar://49415309>
2904
2905         Reviewed by Chris Dumez.
2906
2907         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2908         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2909
2910 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2911
2912         Add a way to opt into modern compatibility mode in layout tests
2913         https://bugs.webkit.org/show_bug.cgi?id=196770
2914         <rdar://problem/49777550>
2915
2916         Reviewed by Antoine Quint.
2917
2918         Add a new test option to enable modern compatibility mode in layout tests.
2919
2920         * WebKitTestRunner/TestController.cpp:
2921         (WTR::updateTestOptionsFromTestHeader):
2922         * WebKitTestRunner/TestController.h:
2923         * WebKitTestRunner/TestOptions.h:
2924         (WTR::TestOptions::hasSameInitializationOptions const):
2925         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2926         (WTR::TestController::platformCreateWebView):
2927         (WTR::TestController::enableModernCompatibilityMode):
2928
2929 2019-04-10  Andy Estes  <aestes@apple.com>
2930
2931         Try to fix the 32-bit watchOS build.
2932
2933         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2934         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2935
2936 2019-04-10  Antoine Quint  <graouts@apple.com>
2937
2938         Enable Pointer Events on watchOS
2939         https://bugs.webkit.org/show_bug.cgi?id=196771
2940         <rdar://problem/49040909>
2941
2942         Reviewed by Dean Jackson.
2943
2944         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2945
2946 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2947
2948         Unreviewed. Fix WPE accessibility tests after r244059.
2949
2950         We are failing to load the injected bundle due to undefined symbol
2951         AccessibilityUIElement::replaceTextInRange().
2952
2953         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2954         (WTR::AccessibilityUIElement::replaceTextInRange):
2955
2956 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2957
2958         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2959         https://bugs.webkit.org/show_bug.cgi?id=196727
2960
2961         Reviewed by Fujii Hironori.
2962
2963         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2964         (WebKitBrowserWindow::create):
2965
2966 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2967
2968         [ews-build] Add unit tests for PrintConfiguration
2969         https://bugs.webkit.org/show_bug.cgi?id=196752
2970
2971         Reviewed by Dewei Zhu.
2972
2973         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2974
2975 2019-04-09  Keith Rollin  <krollin@apple.com>
2976
2977         Unreviewed build maintenance -- update .xcfilelists.
2978
2979         * DumpRenderTree/DerivedSources-input.xcfilelist:
2980         * DumpRenderTree/DerivedSources-output.xcfilelist:
2981
2982 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2983
2984         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2985         https://bugs.webkit.org/show_bug.cgi?id=196743
2986         <rdar://problem/43897551>
2987
2988         Reviewed by Tim Horton.
2989
2990         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2991         (TEST):
2992
2993 2019-04-09  Youenn Fablet  <youenn@apple.com>
2994
2995         Close service worker database on network process suspension
2996         https://bugs.webkit.org/show_bug.cgi?id=196623
2997         <rdar://problem/48930869>
2998
2999         Reviewed by Alex Christensen.
3000
3001         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3002
3003 2019-04-09  Daniel Bates  <dabates@apple.com>
3004
3005         [iPad] Should open popover when the spacebar is pressed
3006         https://bugs.webkit.org/show_bug.cgi?id=196360
3007         <rdar://problem/49389129>
3008
3009         Reviewed by Brent Fulgham.
3010
3011         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3012
3013         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3014         (WTR::UIScriptController::isShowingPopover const): Added.
3015         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3016         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3017         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3018         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3019         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3020         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3021         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3022         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3023         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3024         (WTR::UIScriptController::isShowingPopover const): Added.
3025         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3026         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3027         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3028         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3029         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3030         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3031         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3032         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3033         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3034         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3035         (WTR::UIScriptController::isShowingPopover const): Added.
3036         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3037         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3038
3039 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3040
3041         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3042         https://bugs.webkit.org/show_bug.cgi?id=196665
3043         <rdar://45115669>
3044
3045         Reviewed by Geoff Garen.
3046
3047         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3048         (goBack):
3049         (+[SimpleLookupContext sharedLookupContext]):
3050         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3051         (TEST):
3052         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3053         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3054
3055 2019-04-09  John Wilander  <wilander@apple.com>
3056
3057         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3058         https://bugs.webkit.org/show_bug.cgi?id=196558
3059         <rdar://problem/47650245>
3060
3061         Reviewed by Youenn Fablet.
3062
3063         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3064         (TestWebKitAPI::TEST):
3065             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3066
3067 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3068
3069         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3070         https://bugs.webkit.org/show_bug.cgi?id=196720
3071
3072         Reviewed by Konstantin Tokarev.
3073
3074         * TestWebKitAPI/PlatformMac.cmake:
3075
3076 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3077
3078         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3079         https://bugs.webkit.org/show_bug.cgi?id=196694
3080         <rdar://problem/48388734>
3081
3082         Rubber-stamped by Aakash Jain.
3083
3084         * Scripts/webkitpy/port/image_diff.py:
3085         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3086         * Scripts/webkitpy/port/server_process.py:
3087         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3088         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3089         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3090         * Scripts/webkitpy/port/server_process_mock.py:
3091         (MockServerProcess.has_available_stdout):
3092         * Scripts/webkitpy/port/server_process_unittest.py:
3093         (TestServerProcess.serial_test_basic):
3094
3095 2019-04-09  Jer Noble  <jer.noble@apple.com>
3096
3097         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3098         https://bugs.webkit.org/show_bug.cgi?id=196097
3099
3100         Reviewed by Eric Carlson.
3101
3102         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3103
3104         * DumpRenderTree/mac/DumpRenderTree.mm:
3105         (resetWebPreferencesToConsistentValues):
3106         * WebKitTestRunner/TestController.cpp:
3107         (WTR::TestController::resetPreferencesToConsistentValues):
3108
3109 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3110
3111         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3112         https://bugs.webkit.org/show_bug.cgi?id=196690
3113
3114         Reviewed by Michael Catanzaro.
3115
3116         * QueueStatusServer/config/queues.py:
3117         * Scripts/webkitpy/common/config/ews.json:
3118         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3119         (test_ews_name):
3120
3121 2019-04-09  Chris Dumez  <cdumez@apple.com>
3122
3123         Loads using loadHTMLString() cause flashing when process-swapping
3124         https://bugs.webkit.org/show_bug.cgi?id=196714
3125         <rdar://problem/49637354>
3126
3127         Reviewed by Antti Koivisto.
3128
3129         Add API test coverage.
3130
3131         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3132
3133 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3134
3135         Unreviewed. Fix ATK accessibility tests after r244059.
3136
3137         We are failing to load the injected bundle due to undefined symbol
3138         AccessibilityUIElement::replaceTextInRange().
3139
3140         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3141         (WTR::AccessibilityUIElement::replaceTextInRange):
3142
3143 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3144
3145         AX: Support API: accessibilityReplaceRange:withText
3146         https://bugs.webkit.org/show_bug.cgi?id=196636
3147
3148         Unreviewed build fix for Windows port.
3149
3150         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3151         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3152
3153 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3154
3155         [CMake][WinCairo] Separate copied headers into different directories
3156         https://bugs.webkit.org/show_bug.cgi?id=196655
3157
3158         Reviewed by Michael Catanzaro.
3159
3160         * DumpRenderTree/CMakeLists.txt:
3161         * MiniBrowser/win/CMakeLists.txt:
3162         * TestWebKitAPI/CMakeLists.txt:
3163         * TestWebKitAPI/PlatformWin.cmake:
3164
3165 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3166
3167         Log stack-trace for run-webkit-tests when interrupted
3168         https://bugs.webkit.org/show_bug.cgi?id=176393
3169         <rdar://problem/34262310>
3170
3171         Reviewed by Lucas Forschler.
3172
3173         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3174         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3175         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3176         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3177         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3178         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3179         (main): Set handlers to log stack trace on interruption.
3180
3181 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3182
3183         AX: Support API: accessibilityReplaceRange:withText
3184         https://bugs.webkit.org/show_bug.cgi?id=196636
3185
3186         Unreviewed build fix for Windows port.
3187
3188         * DumpRenderTree/AccessibilityUIElement.cpp:
3189         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3190
3191 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3192
3193         [ews-build] Scripts using Buildbot API have CORS error
3194         https://bugs.webkit.org/show_bug.cgi?id=196709
3195
3196         Reviewed by Alexey Proskuryakov.
3197
3198         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3199
3200 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3201
3202         AX: Support API: accessibilityReplaceRange:withText
3203         https://bugs.webkit.org/show_bug.cgi?id=196636
3204
3205         Reviewed by Daniel Bates.
3206
3207         * DumpRenderTree/AccessibilityUIElement.cpp:
3208         (replaceTextInRangeCallback):
3209         (AccessibilityUIElement::replaceTextInRange):
3210         (AccessibilityUIElement::getJSClass):
3211         * DumpRenderTree/AccessibilityUIElement.h:
3212         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3213         (AccessibilityUIElement::replaceTextInRange):
3214         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3215         (AccessibilityUIElement::replaceTextInRange):
3216         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3217         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3218         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3219         (WTR::AccessibilityUIElement::replaceTextInRange):
3220         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3221         (WTR::AccessibilityUIElement::replaceTextInRange):
3222
3223 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3224
3225         [iOS] Do not allow starting selection drags when selection views are not visible
3226         https://bugs.webkit.org/show_bug.cgi?id=196686
3227         <rdar://problem/49399192>
3228
3229         Reviewed by Tim Horton.
3230
3231         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3232         also add some new API tests to cover scenarios where the web view is not first responder.
3233
3234         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3235         (TestWebKitAPI::TEST):
3236         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3237
3238         Add a switch to optionally make the web view first responder when starting the simulated drag.
3239
3240         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3241         (-[DragAndDropSimulator initWithWebView:]):
3242         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3243
3244 2019-04-08  Justin Fan  <justin_fan@apple.com>
3245
3246         [Web GPU] Fix Web GPU experimental feature on iOS
3247         https://bugs.webkit.org/show_bug.cgi?id=196632
3248
3249         Reviewed by Myles C. Maxfield.
3250
3251         Properly make Web GPU available on iOS 11+.
3252
3253         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3254
3255 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3256
3257         [ews-build] Do not upload archive when Compile Fails
3258         https://bugs.webkit.org/show_bug.cgi?id=196674
3259
3260         Reviewed by Alexey Proskuryakov.
3261
3262         * BuildSlaveSupport/ews-build/factories.py:
3263         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3264         * BuildSlaveSupport/ews-build/steps.py:
3265         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3266         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3267         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3268
3269 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3270
3271         Enable DFG on MIPS
3272         https://bugs.webkit.org/show_bug.cgi?id=196689
3273
3274         Reviewed by Žan Doberšek.
3275
3276         Since the bytecode change, we enabled the baseline JIT on mips in
3277         r240432, but DFG is still missing. With this change, all tests are
3278         passing on a ci20 board.
3279
3280         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3281
3282 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3283
3284         [Flatpak] Second run update-webkitwpe-flatpak fails
3285         https://bugs.webkit.org/show_bug.cgi?id=192702
3286
3287         Reviewed by Carlos Garcia Campos.
3288
3289         * flatpak/flatpakutils.py:
3290         (FlatpakObject.flatpak): Fix typo.
3291         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3292         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3293
3294 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3295
3296         [GTK][WPE] outlook.live.com displays old-fashioned UI
3297         https://bugs.webkit.org/show_bug.cgi?id=196642
3298
3299         Reviewed by Carlos Garcia Campos.
3300
3301         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3302         (TestWebKitAPI::TEST): New Mac platform quirk test.
3303
3304 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3305
3306         Unreviewed, rolling out r243956.
3307         https://bugs.webkit.org/show_bug.cgi?id=196688
3308
3309         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3310         by aakashjain on #webkit).
3311
3312         Reverted changeset:
3313
3314         "Clicking "Go Back" from a safe browsing warning from an
3315         iframe should navigate the WKWebView back to the previous
3316         page"
3317         https://bugs.webkit.org/show_bug.cgi?id=196665
3318         https://trac.webkit.org/changeset/243956
3319
3320 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3321
3322         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3323         https://bugs.webkit.org/show_bug.cgi?id=196669
3324
3325         Reviewed by Geoffrey Garen.
3326
3327         Added three new unit tests for WeakHashSet.
3328
3329         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3330         (WTF_WeakPtr.WeakHashSetConstObjects):
3331         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3332         (WTF_WeakPtr.WeakHashSetComputeSize):
3333
3334 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3335
3336         Hide next and previous form control buttons when WKWebView is editable
3337         https://bugs.webkit.org/show_bug.cgi?id=196672
3338         <rdar://problem/35625321>
3339
3340         Reviewed by Tim Horton.
3341
3342         Add a new API test.
3343
3344         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3345         (-[TestWKWebView lastTrailingBarButtonGroup]):
3346         (TestWebKitAPI::TEST):
3347         * TestWebKitAPI/ios/UIKitSPI.h:
3348
3349 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3350
3351         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3352         https://bugs.webkit.org/show_bug.cgi?id=196077
3353         <rdar://problem/49108202>
3354
3355         Reviewed by Chris Dumez.
3356
3357         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3358         on new web view.
3359
3360         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3361
3362 2019-04-05  Saam Barati  <sbarati@apple.com>
3363
3364         Make compare-results understand MotionMark
3365         https://bugs.webkit.org/show_bug.cgi?id=196666
3366
3367         Reviewed by Yusuke Suzuki.
3368
3369         * Scripts/compare-results:
3370         (PLT5Results):
3371         (detectMotionMark):
3372         (detectMotionMark1_1):
3373         (motionMarkResults):
3374         (motionMark1_1Results):
3375         (detectBenchmark):
3376         (biggerIsBetter):
3377         (main):
3378
3379 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3380
3381         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3382         https://bugs.webkit.org/show_bug.cgi?id=196665
3383         <rdar://45115669>
3384
3385         Reviewed by Geoff Garen.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3388         (goBack):
3389         (+[SimpleLookupContext sharedLookupContext]):
3390         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3391         (TEST):
3392         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3393         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3394
3395 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3396
3397         [ews-build] Add configuration and architecture for windows builders
3398         https://bugs.webkit.org/show_bug.cgi?id=196660
3399
3400         Reviewed by Lucas Forschler.
3401
3402         * BuildSlaveSupport/ews-build/config.json:
3403
3404 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3405
3406         webkitpy: Don't run subsequent rounds if interrupted
3407         https://bugs.webkit.org/show_bug.cgi?id=196646
3408
3409         Reviewed by Aakash Jain.
3410
3411         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3412         (Manager.run): Bail out if interrupted.
3413
3414 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3415
3416         Test sessionStorage in PSON private browsing mode
3417         https://bugs.webkit.org/show_bug.cgi?id=196561
3418
3419         Reviewed by Alex Christensen.
3420
3421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3422
3423 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3424
3425         Unreviewed, rolling out r243833.
3426         https://bugs.webkit.org/show_bug.cgi?id=196645
3427
3428         This change breaks build of WPE and GTK ports (Requested by
3429         annulen on #webkit).
3430
3431         Reverted changeset:
3432
3433         "[CMake][WTF] Mirror XCode header directories"
3434         https://bugs.webkit.org/show_bug.cgi?id=191662
3435         https://trac.webkit.org/changeset/243833
3436
3437 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3438
3439         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3440         https://bugs.webkit.org/show_bug.cgi?id=196635
3441
3442         Reviewed by Antti Koivisto.
3443         
3444         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3445         for a test to enable async frame scrolling via:
3446             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3447         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3448         
3449         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3450
3451         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3452         (WTR::InjectedBundle::beginTesting):
3453         * WebKitTestRunner/TestController.cpp:
3454         (WTR::TestController::resetPreferencesToConsistentValues):
3455
3456 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3457
3458         Use a correct LC_RPATH when building with ASan
3459         https://bugs.webkit.org/show_bug.cgi?id=196576
3460
3461         Reviewed by David Kilzer.
3462
3463         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3464         so that ../Frameworks is checked. This is simpler and more reliable than updating
3465         each SPC service xcconfig.
3466
3467 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3468
3469         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3470         https://bugs.webkit.org/show_bug.cgi?id=196629
3471
3472         Reviewed by Lucas Forschler.
3473
3474         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3475
3476 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3477
3478         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3479         https://bugs.webkit.org/show_bug.cgi?id=196618
3480
3481         Reviewed by Lucas Forschler.
3482
3483         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3484         (StatusBubble): Added QUEUE_TRIGGERS.
3485         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3486         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3487         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3488         its parent(builder).
3489
3490 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3491
3492         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3493         https://bugs.webkit.org/show_bug.cgi?id=196625
3494
3495         Reviewed by Lucas Forschler.
3496
3497         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3498         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3499
3500 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3501
3502         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3503         https://bugs.webkit.org/show_bug.cgi?id=196630
3504
3505         Reviewed by Wenson Hsieh.
3506
3507         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3508
3509 2019-04-04  Youenn Fablet  <youenn@apple.com>
3510
3511         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3512         https://bugs.webkit.org/show_bug.cgi?id=196543
3513
3514         Reviewed by Alex Christensen.
3515
3516         * WebKitTestRunner/TestController.cpp:
3517         (WTR::TestController::generatePageConfiguration):
3518
3519 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3520
3521         [ews-app] Status bubble should not display skipped buildbot steps
3522         https://bugs.webkit.org/show_bug.cgi?id=196584
3523
3524         Reviewed by Lucas Forschler.
3525
3526         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3527
3528 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3529
3530         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3531         https://bugs.webkit.org/show_bug.cgi?id=196620
3532
3533         Reviewed by Lucas Forschler.
3534
3535         * BuildSlaveSupport/ews-app/ews/config.py:
3536
3537 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3538
3539         [Win] DumpRenderTreeWatchDog.py is not checked into source
3540         https://bugs.webkit.org/show_bug.cgi?id=196567
3541         <rdar://problem/49525901>
3542
3543         Reviewed by Lucas Forschler.
3544
3545         This script is used on Win EWS bots to terminate hanging DRT processes.
3546
3547         * EWSTools/dumprendertreewatchdog.py: Added.
3548
3549 2019-04-04  Chris Dumez  <cdumez@apple.com>
3550
3551         Unreviewed, roll out r243858 which made tests time out.
3552
3553         Disable new API tests on Windows instead.
3554
3555         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3556         (TestWebKitAPI::TEST):
3557
3558 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3559
3560         [ATK] Cleanup WebPageAccessibilityObjectAtk
3561         https://bugs.webkit.org/show_bug.cgi?id=196537
3562
3563         Reviewed by Michael Catanzaro.
3564
3565         Also consider files under atk directories as exceptions for GObject conventions.
3566
3567         * Scripts/webkitpy/style/checkers/cpp.py:
3568         (check_identifier_name_in_declaration):
3569
3570 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3571
3572         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3573         https://bugs.webkit.org/show_bug.cgi?id=196588
3574         <rdar://problem/49365787>
3575
3576         Unreviewed build fix for Windows port.
3577
3578         error C3861: 'kill': identifier not found
3579
3580         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3581         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3582
3583 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3584
3585         [ews-build] Cancel build and similar operations should have authentication
3586         https://bugs.webkit.org/show_bug.cgi?id=196520
3587
3588         Reviewed by Dewei Zhu.
3589
3590         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3591         environment variables.
3592
3593 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3594
3595         [ews-build] Do not trigger queues which are not in production yet
3596         https://bugs.webkit.org/show_bug.cgi?id=196581
3597
3598         Reviewed by Dewei Zhu.
3599
3600         * BuildSlaveSupport/ews-build/config.json:
3601
3602 2019-04-03  Chris Dumez  <cdumez@apple.com>
3603
3604         Unreviewed, fix typo in the name of API test added in r243848.
3605
3606         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3607         (TestWebKitAPI::TEST):
3608
3609 2019-04-03  Chris Dumez  <cdumez@apple.com>
3610
3611         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3612         https://bugs.webkit.org/show_bug.cgi?id=196588
3613         <rdar://problem/49365787>
3614
3615         Reviewed by Ryosuke Niwa.
3616
3617         Add API test coverage.
3618
3619         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3620         (TestWebKitAPI::nullJavaScriptCallback):
3621         (TestWebKitAPI::didCrashCheckFrames):
3622         (TestWebKitAPI::TEST):
3623
3624 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3625
3626         run-webkit-tests: Upload test results (new results database)
3627         https://bugs.webkit.org/show_bug.cgi?id=196577
3628         <rdar://problem/34841155>
3629
3630         Reviewed by Lucas Forschler.
3631
3632         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3633         (Manager.run): Upload results after each device shard, since the configuration will be
3634         different for each device.
3635         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3636         uploaded to a results database.
3637         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3638         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3639
3640 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3641
3642         -apple-trailing-word is needed for browser detection
3643         https://bugs.webkit.org/show_bug.cgi?id=196575
3644
3645         Unreviewed.
3646
3647         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3648
3649 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3650
3651         [CMake][WTF] Mirror XCode header directories
3652         https://bugs.webkit.org/show_bug.cgi?id=191662
3653
3654         Reviewed by Konstantin Tokarev.
3655
3656         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3657         builds.
3658
3659         * CMakeLists.txt:
3660         * DumpRenderTree/CMakeLists.txt:
3661         * DumpRenderTree/PlatformWin.cmake:
3662         * MiniBrowser/win/CMakeLists.txt:
3663         * TestWebKitAPI/CMakeLists.txt:
3664         * TestWebKitAPI/PlatformWin.cmake:
3665         * WebKitTestRunner/PlatformGTK.cmake: