Get rid of Retry status in webkit-queues
[WebKit-https.git] / Tools / ChangeLog
1 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2
3         Get rid of Retry status in webkit-queues
4         https://bugs.webkit.org/show_bug.cgi?id=137135
5
6         Reviewed by Ryosuke Niwa.
7
8         * QueueStatusServer/config/messages.py: Removed Retry.
9
10         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
11         no longer needs to check the latest status. It just always both unlocks the patch
12         and removes it from WorkItems.
13
14         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
15         I don't understand why we even needed to check for retries here, but now that there
16         are no retries, that code can go to /dev/null.
17
18         * QueueStatusServer/loggers/recordpatchevent.py:
19         (RecordPatchEvent.started):
20         (RecordPatchEvent.retrying): Deleted.
21         Fixed retry counting, it should work for all queues now.
22
23         * QueueStatusServer/model/queuestatus.py:
24         (QueueStatus.is_retry_request): Deleted. These are no more.
25
26         * Scripts/webkitpy/common/net/statusserver_mock.py:
27         (MockStatusServer.release_lock):
28         * Scripts/webkitpy/tool/commands/queues_unittest.py:
29         Did whatever it took to keep passing the tests. The particular test doesn't seem
30         quite right, but whatever.
31
32         * Scripts/webkitpy/tool/commands/queues.py:
33         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
34         and let others pick up. Also, added explicit returns for clarity.
35         (AbstractPatchQueue._did_retry): Deleted.
36
37 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
38
39         [EFL] Fix the gst-libav build on ARM Thumb2
40         https://bugs.webkit.org/show_bug.cgi?id=137022
41
42         Reviewed by Zoltan Herczeg.
43
44         * efl/jhbuild.modules:
45         * efl/patches/gst-libav.patch: Added.
46
47 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
48
49         [EFL] Bump up dependencies not to conflict with the GTK port.
50         https://bugs.webkit.org/show_bug.cgi?id=137143
51
52         Reviewed by Gyuyoung Kim.
53
54         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
55         installing and removing different versions of libgnutls-dev, thus
56         hindering the development for both ports on the same machine. GTK is
57         using the newer version of the package, now bumping up EFL to use the 
58         same.
59
60         * efl/install-dependencies:
61
62 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
63
64         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
65         https://bugs.webkit.org/show_bug.cgi?id=136854
66
67         Reviewed by Gyuyoung Kim.
68
69         'Escape' key should exit fullscreen first and then should be used to stop page load.
70
71         * MiniBrowser/efl/main.c:
72         (on_key_down):
73
74 2014-09-25  Dean Jackson  <dino@apple.com>
75
76         Add Said to the contributors list so his name completes in bugzilla.
77
78         * Scripts/webkitpy/common/config/contributors.json:
79
80 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
81
82         EWS only repeats its cycle every two hours
83         https://bugs.webkit.org/show_bug.cgi?id=137129
84
85         Reviewed by Ryosuke Niwa.
86
87         * QueueStatusServer/app.yaml: Updated version.
88
89         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
90
91         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
92         the patch from work items.
93
94         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
95
96         * QueueStatusServer/main.py: Added release-lock.
97
98         * QueueStatusServer/model/activeworkitems.py:
99         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
100
101         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
102         we don't want it to be immediately picked up again, it's better to give other patches
103         a chance.
104
105         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
106         these interactive versions, but OK.
107
108         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
109         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
110         or svn is down).
111
112         * Scripts/webkitpy/tool/commands/queues.py:
113         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
114         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
115         meaning that these handlers could never do the right thing. We'd either get a duplicate
116         _did_fail, or try to unlock an already unlocked patch.
117         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
118         making it eligible for retry immediately.
119
120         * Scripts/webkitpy/common/net/statusserver.py:
121         (StatusServer._post_release_lock):
122         (StatusServer.release_lock):
123         Added a call to release-lock.
124
125 2014-09-25  Roger Fong  <roger_fong@apple.com>
126
127         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
128
129         * Scripts/webkitpy/common/system/path.py:
130         (_CygPath.convert):
131
132 2014-09-25  Roger Fong  <roger_fong@apple.com>
133
134         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
135
136         * Scripts/webkitpy/common/system/path.py:
137         (_CygPath.convert):
138
139 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
140
141         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
142         https://bugs.webkit.org/show_bug.cgi?id=136377
143
144         Reviewed by Philippe Normand.
145
146         * Scripts/webkitdirs.pm:
147         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
148
149 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
150
151         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
152         https://bugs.webkit.org/show_bug.cgi?id=137117
153
154         Tools/efl/install-dependencies relies on apt-get to install packages.
155         Unfortunately, if a package does not exist (e.g., for a given
156         architecture) then apt-get install is not able to ignore the missing
157         package and install the rest but fails to run entirely (and there
158         seems to be no intent to change this behaviour).
159
160         On ARM64, the luajit package is missing and currently it needs manual
161         editing of install-dependencies to get the script install as much as it
162         can.
163
164         This patch separates the installation of the universally available
165         packages from those which might not be available for all architectures.
166
167         Reviewed by Gyuyoung Kim.
168
169         * efl/install-dependencies:
170
171 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
172
173         Remove WinCE port from trunk
174         https://bugs.webkit.org/show_bug.cgi?id=136951
175
176         Reviewed by Alex Christensen.
177
178         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
179         (_should_file_trigger_build):
180         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
181         (ShouldBuildTest):
182         * CMakeLists.txt:
183         * DumpRenderTree/win/DRTDataObject.cpp:
184         (DRTDataObject::CopyMedium):
185         * Scripts/build-webkit:
186         * Scripts/webkit-build-directory:
187         * Scripts/webkitdirs.pm:
188         (argumentsForConfiguration):
189         (builtDylibPathForName):
190         (isAppleWinWebKit):
191         (launcherPath):
192         (launcherName):
193         (shouldRemoveCMakeCache):
194         (cmakeBasedPortArguments):
195         (cmakeBasedPortName):
196         (isCMakeBuild):
197         (isWinCE): Deleted.
198         (determineIsWinCE): Deleted.
199         * Scripts/webkitperl/FeatureList.pm:
200         * Scripts/webkitpy/port/port_testcase.py:
201         (test_apache_config_file_name_for_platform):
202         * TestWebKitAPI/config.h:
203         * WinCELauncher/CMakeLists.txt: Removed.
204         * WinCELauncher/main.cpp: Removed.
205         * gtk/manifest.txt:
206
207 2014-09-23  David Farler  <dfarler@apple.com>
208
209         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
210         https://bugs.webkit.org/show_bug.cgi?id=136895
211
212         Reviewed by David Kilzer.
213
214         Create Device, DeviceType, and Runtime data classes.
215         Create Simulator class represent simctl output.
216
217         Wherever possible, use structured data classes anywhere a raw
218         identifier or UDID string was used for a cleaner implementation
219         and to encapsulate the inherent fragility of scraping simctl output.
220
221         Create a suitably named testing device if one doesn't exist.
222
223         Finally, accurately handle having multiple simulator runtimes (SDKs)
224         installed in the active Xcode.app bundle.
225
226         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
227         (_set_up_derived_options):
228         * Scripts/webkitpy/port/driver.py:
229         (IOSSimulatorDriver.cmd_line):
230         Construct DeviceType and Runtime objects from identifiers passed at the
231         command line, still providing sensible defaults for 32- and 64-bit testing.
232         * Scripts/webkitpy/port/ios.py:
233         (IOSSimulatorPort.__init__):
234         (IOSSimulatorPort.setup_test_run):
235         (IOSSimulatorPort):
236         (IOSSimulatorPort.testing_device):
237         Cache the testing device once it is created or found.
238         (IOSSimulatorPort.reset_preferences):
239         Get the device path from the Device object instead of consructing it
240         in the port class.
241         (IOSSimulatorPort.simulator_udid): Deleted.
242         Get the UDID from the testing_device :: Device object itself.
243         * Scripts/webkitpy/xcode/simulator.py:
244         Created Device, DeviceType, Runtime, and Simulator classes.
245         (get_runtimes): Deleted.
246         (get_devices): Deleted.
247         (get_device_types): Deleted.
248         (get_latest_runtime): Deleted.
249
250 2014-09-24  Roger Fong  <roger_fong@apple.com>
251
252         [Windows] Tentative fix for Windows test bots.
253
254         * Scripts/webkitpy/common/system/path.py:
255         (_CygPath.convert):
256
257 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
258
259         Change more build.webkit.org links to https
260         https://bugs.webkit.org/show_bug.cgi?id=137049
261
262         Reviewed by Csaba Osztrogonác.
263
264         Fix appspot, svn.webkit.org and Trac links.
265
266         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
267         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
270         (ViewController.prototype._domForBuildName):
271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
273         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
274         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
275         (.):
276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
277         (EWS):
278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
280         (TestHistory):
281         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
282
283 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
284
285         Update the list of u-szeged contributors.
286
287         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
288
289         * Scripts/webkitpy/common/config/contributors.json:
290
291 2014-09-23  Roger Fong  <roger_fong@apple.com>
292
293         [Windows] More debugging for the Windows bots.
294
295         * Scripts/webkitpy/common/system/path.py:
296         (_CygPath):
297
298 2014-09-23  Roger Fong  <roger_fong@apple.com>
299
300         Unreviewed. Fix for r173899, those tabs should be spaces.
301
302         * Scripts/webkitpy/port/driver.py:
303         (Driver._command_from_driver_input):
304         (Driver): Deleted.
305
306 2014-09-23  Roger Fong  <roger_fong@apple.com>
307
308         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
309
310         * Scripts/webkitpy/port/driver.py:
311         (Driver):
312
313 2014-09-23  Jer Noble  <jer.noble@apple.com>
314
315         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
316         https://bugs.webkit.org/show_bug.cgi?id=137031
317
318         Reviewed by Joseph Pecoraro.
319
320         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
321         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
322         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
323         ChangeLog locations before passing them to createCommitMessage().
324
325         * Scripts/commit-log-editor:
326
327 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
328
329         W3C test importer should detect manual and reference tests according their filenames
330         https://bugs.webkit.org/show_bug.cgi?id=133852
331
332         Reviewed by Bem Jones-Bey.
333
334         * Scripts/webkitpy/w3c/test_parser.py:
335         (TestParser.analyze_test): Adding checks based on WPT filename rules.
336         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
337         (TestParser):
338         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
339         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
340         * Scripts/webkitpy/w3c/test_parser_unittest.py:
341         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
342
343 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
344
345         Unreviewed, add Rebecca Hauck as a contributor.
346
347         * Scripts/webkitpy/common/config/contributors.json:
348
349 2014-09-23  David Kilzer  <ddkilzer@apple.com>
350
351         Switch build.webkit.org URLs to https
352
353         Reviewed by Lucas Forschler and Alexey Proskuryakov.
354
355         * TestResultServer/app.yaml: Update version to this commit
356         revision.
357
358         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
359         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
362         (WebKitBuildbot):
363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
364         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
366         (.):
367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
368         (WebKitBuildbot):
369         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
370         * Scripts/webkitpy/common/config/urls.py:
371         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
372         (test_builder_with_name):
373         * Scripts/webkitpy/tool/commands/queries.py:
374         (TreeStatus):
375         * TestResultServer/generate_builders_json.py:
376         (main):
377         * TestResultServer/generate_builders_json_unittest.py:
378         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
379         (GenerateBuildersJsonTest):
380         (GenerateBuildersJsonTest.test_generate_json_data):
381         * TestResultServer/static-dashboards/builders.jsonp:
382         * TestResultServer/static-dashboards/flakiness_dashboard.js:
383         (loadExpectationsLayoutTests):
384         * TestResultServer/static-dashboards/timeline_explorer.js:
385
386 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
387
388         W3C test importer should copy .htaccess files
389         https://bugs.webkit.org/show_bug.cgi?id=136850
390
391         Reviewed by Bem Jones-Bey.
392
393         * Scripts/webkitpy/w3c/test_importer.py:
394         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
395         (TestImporter):
396         (TestImporter.find_importable_tests): Making use of new helper function.
397
398 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
399
400         Trying to revive bot watcher's dashboard after HSTS.
401
402         Unreviewed.
403
404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
405         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
406
407 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
408
409         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
410         https://bugs.webkit.org/show_bug.cgi?id=137026
411
412         Reviewed by Csaba Osztrogonác.
413
414         * BuildSlaveSupport/wait-for-SVN-server.py:
415         (getLatestSVNRevision):
416         (waitForSVNRevision):
417
418 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
419
420         Remove unlinkZeroFiles from build-webkit
421         https://bugs.webkit.org/show_bug.cgi?id=137018
422
423         Reviewed by Csaba Osztrogonác.
424
425         * Scripts/build-webkit:
426         (unlinkZeroFiles): Deleted.
427
428 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
429
430         [GTK] Minibrowser : Add keyboard support for stop page load
431         https://bugs.webkit.org/show_bug.cgi?id=136857
432
433         Reviewed by Philippe Normand.
434
435         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
436
437         * MiniBrowser/gtk/BrowserWindow.c:
438         (stopPageLoad): Callback to stop page load.
439         (browser_window_init):
440
441 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
442
443         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
444         https://bugs.webkit.org/show_bug.cgi?id=136813
445
446         Reviewed by Gyuyoung Kim.
447
448         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
449
450         * MiniBrowser/efl/main.c:
451         (on_key_down):
452
453 2014-09-22  Daniel Bates  <dabates@apple.com>
454
455         [Cocoa] Add UI delegate callback when window.close() is called
456         https://bugs.webkit.org/show_bug.cgi?id=137008
457         <rdar://problem/17801001>
458
459         Reviewed by Anders Carlsson.
460
461         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
462         for window opened via JavaScript (i.e. window.open()).
463
464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
465         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
466         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
467
468 2014-09-22  Youenn Fablet  <youennf@gmail.com>
469
470         W3C importer should import html files within resources folders
471         https://bugs.webkit.org/show_bug.cgi?id=127548
472
473         Reviewed by Ryosuke Niwa.
474         
475         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
476
477         * Scripts/webkitpy/w3c/test_importer.py:
478         (TestImporter.find_importable_tests):
479
480 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
481
482         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
483         https://bugs.webkit.org/show_bug.cgi?id=136998
484
485         Reviewed by Philippe Normand.
486
487         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
488         (testWebViewCanShowMIMEType): Remove the check of PDF as
489         unsupported MIME type.
490
491 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
492
493         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
494
495         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
496         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
497
498         * Scripts/webkitpy/common/config/watchlist: Use
499         Source/WebCore/platform/gtk/po/ as directory to watch for
500         WebKitGTKTranslations rule and add berto and myself to the list of
501         watchers.
502
503 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
504
505         Fix syntaxError in watchlist since r173594
506         https://bugs.webkit.org/show_bug.cgi?id=136996
507
508         Reviewed by Philippe Normand.
509
510         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
511
512 2014-09-20  Sam Weinig  <sam@webkit.org>
513
514         Make possible HashSet<std::unique_ptr<>>
515         https://bugs.webkit.org/show_bug.cgi?id=136166
516
517         Reviewed by Darin Adler.
518
519         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
520         * TestWebKitAPI/Counters.cpp: Added.
521         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
522         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
523         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
524         translation unit.
525     
526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
527         Add new files.
528
529         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
530         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
531
532         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
533         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
534
535 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
536
537         run-webkit-tests should count tests submitted as absolute paths once
538         https://bugs.webkit.org/show_bug.cgi?id=136848
539
540         Reviewed by Darin Adler.
541
542         * Scripts/webkitpy/port/base.py:
543         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
544
545 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
546
547         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
548         https://bugs.webkit.org/show_bug.cgi?id=136974
549
550         Reviewed by Chris Fleizach.
551
552         * DumpRenderTree/AccessibilityUIElement.cpp:
553         (selectTextWithCriteriaCallback):
554         Be sure to release the string if it was allocated.
555
556 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
557
558         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
559         https://bugs.webkit.org/show_bug.cgi?id=136966
560
561         Reviewed by Daniel Bates.
562
563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
564         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
565
566 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
567
568         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
569         https://bugs.webkit.org/show_bug.cgi?id=136917
570
571         Reviewed by Darin Adler.
572
573         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
574
575         * TestWebKitAPI/PlatformEfl.cmake:
576         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
577         (TestWebKitAPI::didFinishLoadForFrame):
578         (TestWebKitAPI::TEST):
579         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
580
581 2014-09-19  Daniel Bates  <dabates@apple.com>
582
583         Always assume internal SDK when building configuration Production
584         https://bugs.webkit.org/show_bug.cgi?id=136925
585         <rdar://problem/18362399>
586
587         Reviewed by Dan Bernstein.
588
589         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
590         * MiniBrowser/Configurations/DebugRelease.xcconfig:
591         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
592         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
593
594 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
595
596         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
597         https://bugs.webkit.org/show_bug.cgi?id=136847
598
599         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
600
601         Reviewed by Alexey Proskuryakov.
602
603         * WebKitTestRunner/TestController.cpp:
604         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
605
606 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
607
608         [GTK] Missing inspector files in the tarball
609         https://bugs.webkit.org/show_bug.cgi?id=136952
610
611         Reviewed by Gustavo Noronha Silva.
612
613         * gtk/manifest.txt: Add
614         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
615         to the tarball.
616
617 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
618
619         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
620         https://bugs.webkit.org/show_bug.cgi?id=136632
621
622         Reviewed by Gustavo Noronha Silva.
623
624         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
625         the gtk icons.
626         * gtk/manifest.txt: Only include the free icons in the tarball.
627
628 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
629
630         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
631         https://bugs.webkit.org/show_bug.cgi?id=136943
632
633         Reviewed by Philippe Normand.
634
635         Update the script to receive the list of files from the command
636         line instead of scanning the given directories.
637
638         * gtk/generate-inspector-gresource-manifest.py:
639         (get_filenames): Convert filenames to use relative paths.
640         (find_all_files_in_directory): Deleted.
641         (find_all_files_in_directory.select_file): Deleted.
642
643 2014-09-18  Tanay C  <tanay.c@samsung.com>
644
645         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
646         https://bugs.webkit.org/show_bug.cgi?id=136739
647
648         Reviewed by Gyuyoung Kim.
649
650         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
651         (on_mouse_wheel): Modified.
652
653 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
654
655         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
656         https://bugs.webkit.org/show_bug.cgi?id=136923
657
658         Reviewed by Gustavo Noronha Silva.
659
660         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
661         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
662         the source.
663
664 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
665
666         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
667         https://bugs.webkit.org/show_bug.cgi?id=136856
668
669         Reviewed by Darin Adler.
670
671         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
672         (RunLLINTCLoopTests.countFailures):
673         (Run32bitJSCTests.countFailures):
674         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
675         (RunLLINTCLoopTestsTest.test_failures):
676         (RunLLINTCLoopTestsTest.test_failure):
677         (RunLLINTCLoopTestsTest.test_no_failure):
678         (Run32bitJSCTestsTest.test_failures):
679         (Run32bitJSCTestsTest.test_failure):
680         (Run32bitJSCTestsTest.test_no_failure):
681
682 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
683
684         GMainLoopSource is exposed to race conditions
685         https://bugs.webkit.org/show_bug.cgi?id=135800
686
687         Reviewed by Carlos Garcia Campos.
688
689         Add unit tests for GMainLoopSource.
690
691         The tests check correct behavior of GMainLoopSource in various conditions --
692         from the most simple rescheduling to rescheduling during dispatch, cancelling
693         or destroying the GMainLoopSource during dispatch, proper destroy callback
694         dispatching etc.
695
696         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
697         State of the GMainLoopSource object (either ready, sheduled or active) is
698         thoroughly tested throughout the lifetime of that object.
699
700         Still missing are tests for socket callbacks, which are a bit trickier because
701         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
702         are also not tested thoroughly, simply because it is at the moment impossible
703         to test that the objects are actually destroyed when the corresponding source
704         is finally deleted.
705
706         * TestWebKitAPI/PlatformGTK.cmake:
707         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
708         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
709         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
710         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
711         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
712         (TestWebKitAPI::GMainLoopSourceTest::finish):
713         (TestWebKitAPI::GMainLoopSourceTest::source):
714         (TestWebKitAPI::TEST):
715
716 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
717
718         Unreviewed, Update my email in contributors.json
719
720         * Scripts/webkitpy/common/config/contributors.json:
721
722 2014-09-17  Daniel Bates  <dabates@apple.com>
723
724         Unreviewed, rolling out r173695.
725
726         Broke building third-party Legacy WebKit apps; will
727         investigate offline
728
729         Reverted changeset:
730
731         "[iOS] Make WebCore build with public iOS SDK"
732         https://bugs.webkit.org/show_bug.cgi?id=136487
733         http://trac.webkit.org/changeset/173695
734
735 2014-09-17  Daniel Bates  <dabates@apple.com>
736
737         [iOS] Make WebCore build with public iOS SDK
738         https://bugs.webkit.org/show_bug.cgi?id=136487
739
740         Reviewed by David Kilzer.
741
742         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
743
744         * DumpRenderTree/mac/CheckedMalloc.cpp:
745
746 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
747
748         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
749         https://bugs.webkit.org/show_bug.cgi?id=136889
750
751         Reviewed by Gustavo Noronha Silva.
752
753         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
754         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
755         event was added to the events vector.
756         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
757         (loadFailedCallback): Do not assume the web view URI is the
758         failing URI when the load fails before the committed state.
759         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
760         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
761         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
762         (LoadTrackingTest::loadFailedWithTLSErrors): Add
763         LoadFailedWithTLSErrors event to the events vector.
764         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
765
766 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
767
768         [EFL][GTK] Remove WebKit1 related codes
769         https://bugs.webkit.org/show_bug.cgi?id=136853
770
771         Reviewed by Csaba Osztrogonác.
772
773         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
774         from scripts.
775
776         * BuildSlaveSupport/build.webkit.org-config/config.json:
777         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
778         (Compile32bitJSC):
779         (BuildAndTestWebKit2Factory):
780         (CompileWebKit1Only): Deleted.
781         (CompileWebKit2Only): Deleted.
782         (BuildAndTestWebKit1OnlyFactory): Deleted.
783         (BuildAndTestWebKit2OnlyFactory): Deleted.
784         * Scripts/build-webkit:
785         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
786         * Scripts/webkitpy/common/config/ports.py:
787         (GtkWK2Port.build_webkit_command):
788         (EflWK2Port.build_webkit_command):
789         * Scripts/webkitpy/common/config/ports_unittest.py:
790         (DeprecatedPortTest.test_gtk_wk2_port):
791         * Scripts/webkitpy/port/efl.py:
792         (EflPort.build_webkit_command):
793         * Scripts/webkitpy/port/gtk.py:
794         (GtkPort._built_libraries_path):
795         (GtkPort._search_paths):
796         (GtkPort.test_expectations_file_position):
797         (GtkPort.build_webkit_command):
798         (GtkPort.run_webkit_tests_command):
799         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
800
801 2014-09-16  Daniel Bates  <dabates@apple.com>
802
803         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
804         https://bugs.webkit.org/show_bug.cgi?id=136862
805
806         Reviewed by David Kilzer.
807
808         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
809         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
810         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
811         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
812
813 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
814
815         Mac queue slaves should reboot every so often
816         https://bugs.webkit.org/show_bug.cgi?id=136791
817
818         Reviewed by Alexey Proskuryakov.
819
820         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
821
822         * EWSTools/start-queue-mac.sh:
823
824 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
825
826         Unreviewed gardening, skip one more tests on Windows.
827
828         * Scripts/run-javascriptcore-tests:
829
830 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
831
832         JSC test gardening
833         https://bugs.webkit.org/show_bug.cgi?id=136823
834
835         Reviewed by Geoffrey Garen.
836
837         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
838
839 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
840
841         Remove shouldAbortEarly cruft from master.cfg
842         https://bugs.webkit.org/show_bug.cgi?id=136779
843
844         Reviewed by Csaba Osztrogonác.
845
846         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
847         (ConfigureBuild.start):
848         (RunWebKitTests.start):
849         (RunWebKit2Tests.start): Deleted.
850
851 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
852
853         Remove ORWT related crufts from webkitdirs.pm
854         https://bugs.webkit.org/show_bug.cgi?id=136821
855
856         Reviewed by Alexey Proskuryakov.
857
858         * Scripts/webkitdirs.pm:
859         (isPerianInstalled): Deleted.
860         (determineIPhoneSimulatorVersion): Deleted.
861         (iPhoneSimulatorVersion): Deleted.
862         (isSnowLeopard): Deleted.
863         (isLion): Deleted.
864         (quitIOSSimulator): Deleted.
865
866 2014-09-15  Roger Fong  <roger_fong@apple.com>
867
868         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
869         https://bugs.webkit.org/show_bug.cgi?id=25160
870
871         * Scripts/run-javascriptcore-tests:
872
873 2014-09-15  Lucas Forschler  <lforschler@apple.com>
874
875         Add another Apple build slave to the Mountain Lion Debug WK1 queue
876         
877         Rubber stamped by Matt Hanson.
878         
879         * BuildSlaveSupport/build.webkit.org-config/config.json:
880
881 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
882
883         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
884         https://bugs.webkit.org/show_bug.cgi?id=136822
885
886         Reviewed by Gyuyoung Kim.
887
888         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
889         initialized as we already does it in PlatformWebView::PlatformWebView
890         calling ewk_init(). The reason for that was to ensure testing for example,
891         WTF where creating the view is not mandatory.
892
893         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
894         in order to properly initalize and release EWebKit.
895
896         * TestWebKitAPI/PlatformEfl.cmake:
897         * TestWebKitAPI/efl/PlatformWebView.cpp:
898         (TestWebKitAPI::PlatformWebView::PlatformWebView):
899         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
900         * TestWebKitAPI/efl/main.cpp:
901         (main):
902
903 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
904
905         [WinCairo] Make it easier to enable/disable GStreamer.
906         https://bugs.webkit.org/show_bug.cgi?id=135766
907
908         Reviewed by Brent Fulgham.
909
910         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
911
912         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
913
914 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
915
916         Web Inspector: remind about rebaselining generator test results
917         https://bugs.webkit.org/show_bug.cgi?id=136759
918
919         Reviewed by Joseph Pecoraro.
920
921         For now, we can implement this as a watchlist message. Add watchlist
922         groups and messages for the inspector and web replay generators.
923
924         * Scripts/webkitpy/common/config/watchlist:
925
926 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
927
928         build.webkit.org/dashboard: Overlapping text when status is long
929         https://bugs.webkit.org/show_bug.cgi?id=136794
930
931         Reviewed by Timothy Hatcher.
932
933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
934         (.status-line): Replaces height with min-height.
935
936 2014-09-12  Timothy Hatcher  <timothy@apple.com>
937
938         Make Brian Burg a WebKit reviewer.
939
940         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
941
942 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
943
944         Multiple EWS or commit bots can pick up processing of the same patch
945         https://bugs.webkit.org/show_bug.cgi?id=136793
946
947         Reviewed by Ryosuke Niwa.
948
949         Change timeout from one hour to two hours. This will let bots finish, and in the
950         unlikely event of a bot being frozen, will only delay patch processing restart by
951         one hour.
952
953         * QueueStatusServer/app.yaml:
954         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
955
956 2014-09-11  Andy Estes  <aestes@apple.com>
957
958         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
959         https://bugs.webkit.org/show_bug.cgi?id=136768
960
961         Reviewed by Tim Horton.
962
963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
964         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
965         (TestWebKitAPI::TEST):
966
967 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
968
969         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
970         https://bugs.webkit.org/show_bug.cgi?id=136669
971
972         Reviewed by Antti Koivisto.
973
974         * Scripts/run-gtk-tests:
975         (TestRunner): Unskip SSL test.
976
977 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
978
979         Strip extraneous AVFoundation and CoreMedia logging
980         https://bugs.webkit.org/show_bug.cgi?id=136747
981
982         Reviewed by Jer Noble.
983
984         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
985         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
986
987         * Scripts/webkitpy/port/base.py:
988         (Port.stderr_patterns_to_strip): Base class, empty list
989
990         * Scripts/webkitpy/port/driver.py:
991         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
992
993         * Scripts/webkitpy/port/ios.py:
994         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
995
996         * Scripts/webkitpy/port/mac.py:
997         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
998
999
1000 2014-09-11  Michael Saboff  <msaboff@apple.com>
1001
1002         lldb_webkit.py:btjs doesn't work with release builds
1003         https://bugs.webkit.org/show_bug.cgi?id=136760
1004
1005         Reviewed by Jer Noble.
1006
1007         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
1008         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
1009         we can't get a valid result from trying either call.  In that case, we fallback to
1010         just showing the PC.  Also added check for both entry points.  If neither is found,
1011         we issue a warning and output the stack trace without JavaScript annotations.
1012
1013         * lldb/lldb_webkit.py:
1014         (btjs):
1015
1016 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
1017
1018         webkitpy test failures from import-w3c-tests
1019         https://bugs.webkit.org/show_bug.cgi?id=136752
1020
1021         Reviewed by Bem Jones-Bey.
1022
1023         This patch fixes a bug in import-w3c-tests where we were appending
1024         the wrong set of files to the copy_list. This also updates the tests
1025         to clear the failures introduced in the patch for bug 135929.
1026
1027         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1028         (W3CTestConverterTest.test_read_prefixed_property_list):
1029         * Scripts/webkitpy/w3c/test_parser.py:
1030         (TestParser.analyze_test):
1031         (TestParser.support_files):
1032         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1033
1034 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
1035
1036         Blink merge: Speculative fix for windows run-webkit-tests hangs
1037         https://bugs.webkit.org/show_bug.cgi?id=136727
1038
1039         Reviewed by Csaba Osztrogonác.
1040
1041         Merged from Blink (patch by Dirk Pranke):
1042         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
1043
1044         * Scripts/webkitpy/common/system/executive.py:
1045         (Executive.kill_process):
1046
1047 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1048
1049         Added myself as a committer.
1050
1051         Unreviewed.
1052
1053         * Scripts/webkitpy/common/config/contributors.json:
1054
1055 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
1056
1057         [JavaScriptCore] Fix FTL on platform EFL.
1058         https://bugs.webkit.org/show_bug.cgi?id=133571
1059
1060         Reviewed by Filip Pizlo.
1061
1062         * efl/install-dependencies: Revert r169181.
1063         * efl/jhbuild.modules: Clone and build a custom branch.
1064         This branch contains some fix for FTL of platform EFL.
1065         The branch is a fork of llvm r206311.
1066
1067 2014-09-10  Tanay C  <tanay.c@samsung.com>
1068
1069         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
1070         https://bugs.webkit.org/show_bug.cgi?id=136698
1071
1072         Reviewed by Gyuyoung Kim.
1073
1074         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
1075         (on_mouse_wheel): Added.
1076         (window_free):
1077         (window_create):
1078
1079 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
1080
1081         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
1082         https://bugs.webkit.org/show_bug.cgi?id=136284
1083
1084         Reviewed by Gyuyoung Kim.
1085
1086         * MiniBrowser/efl/main.c:
1087         (window_create):
1088
1089 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
1090
1091         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
1092         https://bugs.webkit.org/show_bug.cgi?id=135929
1093
1094         Reviewed by Bem Jones-Bey.
1095
1096         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
1097         were made when this script was originally written with respect to relative paths
1098         in ref files. This patch updates import-w3c-tests to update paths in ref files if
1099         they move relative to the test file.
1100
1101
1102         * Scripts/webkitpy/w3c/test_converter.py:
1103         (convert_for_webkit):
1104         (_W3CTestConverter.__init__):
1105         (_W3CTestConverter.convert_reference_relpaths):
1106         (_W3CTestConverter.convert_style_data):
1107         (_W3CTestConverter.convert_attributes_if_needed):
1108         * Scripts/webkitpy/w3c/test_importer.py:
1109         (TestImporter.find_importable_tests):
1110         (TestImporter.import_tests):
1111         * Scripts/webkitpy/w3c/test_parser.py:
1112         (TestParser.load_file):
1113         (TestParser.analyze_test):
1114         (TestParser.support_files):
1115
1116 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1117
1118         [GTK] allow overwriting destination of download
1119         https://bugs.webkit.org/show_bug.cgi?id=136372
1120
1121         Reviewed by Carlos Garcia Campos.
1122
1123         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1124         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
1125         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
1126         (createFileAtDestination): Added
1127         (testDownloadOverwriteDestinationAllowed): Added
1128         (testDownloadOverwriteDestinationDisallowed): Added
1129         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
1130         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
1131         (beforeAll): New tests
1132
1133 2014-08-05  David Farler  <dfarler@apple.com>
1134
1135         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
1136         https://bugs.webkit.org/show_bug.cgi?id=135551
1137
1138         Reviewed by Daniel Bates.
1139
1140         Prevent printing invalid Unicode strings going to stderr.
1141         Also, make filesystem.py more tolerant about receiving
1142         Unicode (encoded as UTF-8) when writing to files, in the
1143         rare case that an NSError description will make it to
1144         stderr, such as -[LTRelayController createUniqueApp].
1145
1146         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1147         (-[LTRelayController launchSimulator]): Removed.
1148         (-[LTRelayController createUniqueApp]):
1149         Don't explicitly try to uninstall the app. It is automatically handled
1150         when installing an app with the same bundle identifier.
1151         (-[LTRelayController start]):
1152         (-[LTRelayController bootDevice]): Removed.
1153         The device already boots as a part of starting the simulator. Attempting
1154         to boot a second time may cause spurious stderr output.
1155         * Scripts/webkitpy/port/driver.py:
1156         (IOSSimulatorDriver._setup_environ_for_driver):
1157         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
1158         Open the iOS Simulator once instead of the LayoutTestRelay trying
1159         to do it.
1160         * Scripts/webkitpy/port/ios.py:
1161         (IOSSimulatorPort._get_crash_log):
1162         Make sure stderr is at least an empty string.
1163         (IOSSimulatorPort):
1164         (IOSSimulatorPort.developer_dir):
1165         New property for setting up DEVELOPER_DIR in the driver environment.
1166
1167 2014-09-09  Dan Bernstein  <mitz@apple.com>
1168
1169         Clean up the MiniBrowser Xcode project
1170         https://bugs.webkit.org/show_bug.cgi?id=136684
1171
1172         Reviewed by Tim Horton.
1173
1174         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
1175         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
1176         WebKit2.framework. Upgraded project file version.
1177
1178 2014-09-09  Daniel Bates  <dbates@webkit.org>
1179
1180         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
1181         https://bugs.webkit.org/show_bug.cgi?id=136379
1182
1183         Reviewed by David Kilzer.
1184
1185         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
1186         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
1187         and sets a property on F (say, the executable bit).
1188
1189         * Scripts/svn-apply:
1190         (patch): Only add file if the diff has text chunks.
1191         * Scripts/svn-unapply:
1192         (patch): Only delete added file if the diff has text chunks.
1193
1194 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1195
1196         [GTK] Unreviewed GTK gardening.
1197
1198         * Scripts/run-gtk-tests:
1199         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
1200
1201 2014-09-09  Christophe Dumez  <cdumez@apple.com>
1202
1203         Update my email in contributors.json
1204         https://bugs.webkit.org/show_bug.cgi?id=136671
1205
1206         Reviewed by Andreas Kling.
1207
1208         * Scripts/webkitpy/common/config/contributors.json:
1209
1210 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1211
1212         [EFL] Enable fixed layout by default
1213         https://bugs.webkit.org/show_bug.cgi?id=136607
1214
1215         Reviewed by Csaba Osztrogonác.
1216
1217         Fixed layout is being used by Tizen platform by default. However, the feature
1218         has still many defects now. So, we need to enable it by default, then should fix
1219         those bugs. 
1220
1221         * MiniBrowser/efl/main.c:
1222
1223 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1224
1225         Remove FILTERS flag
1226         https://bugs.webkit.org/show_bug.cgi?id=136571
1227
1228         Reviewed by Darin Adler.
1229
1230         * Scripts/webkitperl/FeatureList.pm:
1231
1232 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
1233
1234         Dashboard metrics should ignore commits that didn't trigger builds
1235         https://bugs.webkit.org/show_bug.cgi?id=136618
1236
1237         Reviewed by Darin Adler.
1238
1239         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
1240         other platforms etc. It does not make sense to count wait time for these, as it
1241         can be arbitrarily long.
1242
1243         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
1244
1245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1246         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
1247
1248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1249         We used to walk the timeline to see which revisions are fully tested, but that's not
1250         correct. A revision that's only tested by a subset of queues finishes independently
1251         of another that's tested by another subset. Now, we just search for the answer for
1252         each revision individually.
1253
1254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
1255         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
1256         the analyzer now reports. Removed best time, which is more confusing than meaningful.
1257
1258 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1259
1260         Remove EWebLauncher from webkitdirs.pm
1261         https://bugs.webkit.org/show_bug.cgi?id=136622
1262
1263         Reviewed by Gyuyoung Kim.
1264
1265         * Scripts/webkitdirs.pm:
1266         (launcherName):
1267
1268 2014-09-06  Sam Weinig  <sam@webkit.org>
1269
1270         XPCPtr should be converted into an all purpose smart pointer for os_objects
1271         https://bugs.webkit.org/show_bug.cgi?id=136602
1272
1273         Reviewed by Darin Adler.
1274
1275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1276         * TestWebKitAPI/Tests/WTF/darwin: Added.
1277         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
1278         Add basic unit tests for OSObjectPtr.
1279
1280 2014-09-06  Saam Barati  <saambarati1@gmail.com>
1281
1282         Unreviewed. Add myself as a committer.
1283
1284         * Scripts/webkitpy/common/config/contributors.json:
1285
1286 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1287
1288         Unreviewed, EFL build fix when SHARED_CORE is on.
1289
1290         * TestWebKitAPI/PlatformEfl.cmake:
1291
1292 2014-09-05  Lucas Forschler  <lforschler@apple.com>
1293
1294         <https://webkit.org/b/136586> Add bots to Apple build/test queues
1295         
1296         Reviewed by Daniel Bates.
1297
1298         * BuildSlaveSupport/build.webkit.org-config/config.json:
1299
1300 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
1301
1302         Buildbot metrics page gives wrong results after a new bot gets added
1303         https://bugs.webkit.org/show_bug.cgi?id=136516
1304
1305         Reviewed by Tim Horton.
1306
1307         Part 2: Fix elapsed times.
1308
1309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1310         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
1311         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
1312
1313 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1314
1315         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
1316         https://bugs.webkit.org/show_bug.cgi?id=136562
1317
1318         Reviewed by Martin Robinson.
1319
1320         * Scripts/run-gtk-tests:
1321         (TestRunner): Remove failure expectations for tests that now pass.
1322
1323 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
1324
1325         Dashboard metrics page wastes a lot of time sorting iterations
1326         https://bugs.webkit.org/show_bug.cgi?id=136559
1327
1328         Reviewed by Tim Horton.
1329
1330         Also fixes comments here and there, and adds a missing "var".
1331
1332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1333         (BuildbotIteration.prototype._parseData):
1334         (BuildbotIteration.prototype._updateWithData):
1335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1336         (BuildbotQueue.prototype.loadAll):
1337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1338         (Analyzer.prototype._countTimes):
1339
1340 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1341
1342         [GTK] Unreviewed GTK gardening.
1343
1344         * Scripts/run-gtk-tests:
1345         (TestRunner): Skip tests failing since r173272.
1346
1347 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
1348
1349         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
1350         https://bugs.webkit.org/show_bug.cgi?id=136561
1351
1352         Reviewed by Tim Horton.
1353         
1354         Log for calloc() and CGBitmapContextCreate() failures.
1355
1356         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1357         (createBitmapContext):
1358         (createBitmapContextFromWebView):
1359
1360 2014-09-04  Andy Estes  <aestes@apple.com>
1361
1362         Fix the Mac Production build after r173283.
1363
1364         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
1365
1366 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
1367
1368         [Win] webkitpy test suite frequently fails to complete
1369         https://bugs.webkit.org/show_bug.cgi?id=136546
1370
1371         Reviewed by Daniel Bates.
1372
1373         Properly convert the ASCII crash log produced by ntsd into
1374         a unicode string as early as possible so that we handle it
1375         properly when generating our logs and other test support output.
1376
1377         We were mixing ASCII/unicode strings under Windows, which was
1378         causing test system failures when we processed some crash logs.
1379
1380         Also do a better job of handling garbage pid entries in the
1381         Cygwin lock files.
1382
1383         * Scripts/webkitpy/common/system/crashlogs.py:
1384         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
1385         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
1386         handle the strings as unicode from that point on.
1387         * Scripts/webkitpy/port/http_lock.py:
1388         (HttpLock._current_lock_pid): Add logging and handle case of
1389         the current_pid failing to cleanly convert to 'int'.
1390         * Scripts/webkitpy/port/win.py:
1391         (WinPort): Add 64-bit architecture as a known target for the
1392         Windows build.
1393
1394 2014-09-04  Andy Estes  <aestes@apple.com>
1395
1396         Address additional review feedback after landing r173283.
1397
1398         Reviewed by Daniel Bates.
1399
1400         * DumpRenderTree/config.h: Removed redundant includes.
1401         * TestWebKitAPI/config.h: Ditto.
1402         * WebKitTestRunner/config.h: Ditto.
1403
1404 2014-09-03  Andy Estes  <aestes@apple.com>
1405
1406         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
1407         https://bugs.webkit.org/show_bug.cgi?id=136521
1408
1409         Reviewed by Anders Carlsson.
1410
1411         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
1412         * TestWebKitAPI/config.h: Ditto.
1413         * WebKitTestRunner/config.h: Ditto.
1414
1415 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
1416
1417         REGRESSION: Dashboard metrics page aggregation counts performance bots
1418         https://bugs.webkit.org/show_bug.cgi?id=136539
1419
1420         Reviewed by Tim Horton.
1421
1422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1423
1424 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
1425
1426         [Win] Perl test fix.
1427
1428         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
1429         VersionStamp.exe tool, not just the driver script.
1430
1431 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1432
1433         Remove CSS_FILTERS flag
1434         https://bugs.webkit.org/show_bug.cgi?id=136529
1435
1436         Reviewed by Dirk Schulze.
1437
1438         * Scripts/webkitperl/FeatureList.pm:
1439
1440 2014-09-04  Commit Queue  <commit-queue@webkit.org>
1441
1442         Unreviewed, rolling out r173201.
1443         https://bugs.webkit.org/show_bug.cgi?id=136538
1444
1445         Improves the situation but also introduces additional crashes.
1446         (Requested by zdobersek on #webkit).
1447
1448         Reverted changeset:
1449
1450         "GMainLoopSource is exposed to race conditions"
1451         https://bugs.webkit.org/show_bug.cgi?id=135800
1452         http://trac.webkit.org/changeset/173201
1453
1454 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
1455
1456         Buildbot metrics page gives wrong results after a new bot gets added
1457         https://bugs.webkit.org/show_bug.cgi?id=136516
1458
1459         Part 1: Fix red/green counters. Dashboard is considered green at a given time
1460         if all the bots that ever had results before this time are green.
1461
1462         This doesn't (and cannot) address situations where the bot gets removed and then
1463         re-added. It also gives wrong results after a bot gets removed, because it doesn't
1464         know that it was ever displayed on the dashboard.
1465
1466         Reviewed by Darin Adler.
1467
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1469         (Analyzer.prototype._dashboardIsAllGreen):
1470         (Analyzer.prototype._updateStretchOfRedCounters):
1471         (Analyzer.prototype._countPercentageOfGreen):
1472         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
1473
1474 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
1475
1476         [Win] Unreviewed test fix.
1477
1478         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
1479         test if user doesn't have the VersionStamp.exe program.
1480
1481 2014-09-03  Dana Burkart  <dburkart@apple.com>
1482
1483         Unreviewed. Add myself as a committer.
1484
1485         * Scripts/webkitpy/common/config/contributors.json:
1486
1487 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
1488
1489         build.webkit.org/dashboard performance popover is unstyled
1490         https://bugs.webkit.org/show_bug.cgi?id=136499
1491
1492         Reviewed by Tim Horton.
1493
1494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1495         (.performance-popover):
1496         (.performance-popover .dashboard-link):
1497
1498 2014-09-03  Saam Barati  <saambarati1@gmail.com>
1499
1500         Create tests for type profiling
1501         https://bugs.webkit.org/show_bug.cgi?id=136161
1502
1503         Reviewed by Geoffrey Garen.
1504
1505         Have run-javascriptcore-tests run the newly created
1506         tests for the type profiler.
1507
1508         * Scripts/run-javascriptcore-tests:
1509         * Scripts/run-jsc-stress-tests:
1510
1511 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
1512
1513         [Win] Revise test environment for Windows build.
1514         https://bugs.webkit.org/show_bug.cgi?id=136486
1515
1516         Reviewed by David Kilzer.
1517
1518         The various calls to get the Safari path really only have
1519         meaning on the Mac. Other ports get access to the build
1520         and test environment separately, so remove the various
1521         checks in the Safari-specific code to simplify things.
1522
1523         Remove some 64-bit hacks used on Windows now that the
1524         various tools know how to find the 64-bit runtime environment.
1525
1526         * Scripts/run-javascriptcore-tests: 
1527         * Scripts/webkitdirs.pm:
1528         (safariPathFromSafariBundle): Revise to expect Mac.
1529         (installedSafariPath): Ditto.
1530         (safariPath): Ditto.
1531         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
1532         (setPathForRunningWebKitApp): Get rid of unused SafariPath
1533         argument for Windows runs.
1534
1535 2014-09-03  Dana Burkart  <dburkart@apple.com>
1536
1537         Dashboard should show performance bots.
1538         https://bugs.webkit.org/show_bug.cgi?id=136386
1539
1540         Reviewed by Alexey Proskuryakov.
1541
1542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1543         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
1544         (BuildbotIteration.prototype._parseData):
1545         Support possible performance failures.
1546
1547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
1548         New QueueView to manage the way we present performance data.
1549
1550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1551         (BuildbotQueue):
1552         Support new 'performance' and 'performanceTestName' keys.
1553
1554
1555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1556         Add performance column to the main page.
1557
1558         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1559         (WebKitBuildbot):
1560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1561         (body):
1562         Make sure everything fits on 13 inch screens.
1563
1564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1565
1566 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
1567
1568         GMainLoopSource is exposed to race conditions
1569         https://bugs.webkit.org/show_bug.cgi?id=135800
1570
1571         Reviewed by Carlos Garcia Campos.
1572
1573         Add a unit test for GMainLoopSource that tests different
1574         types of rescheduling tasks on already-active sources.
1575
1576         * TestWebKitAPI/PlatformGTK.cmake:
1577         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
1578         (GMainLoopSourceTest::GMainLoopSourceTest):
1579         (GMainLoopSourceTest::~GMainLoopSourceTest):
1580         (GMainLoopSourceTest::runLoop):
1581         (GMainLoopSourceTest::finish):
1582         (GMainLoopSourceTest::source):
1583         (testGMainLoopSourceBasicRescheduling):
1584         (testGMainLoopSourceReentrantRescheduling):
1585         (testGMainLoopSourceDifferentThreadRescheduling):
1586         (beforeAll):
1587         (afterAll):
1588         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1589         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1590         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1591         (TestWebKitAPI::GMainLoopSourceTest::finish):
1592         (TestWebKitAPI::GMainLoopSourceTest::source):
1593         (TestWebKitAPI::TEST):
1594
1595 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
1596
1597         Make sure WK1 prefs are initialized in MiniBrowser
1598         https://bugs.webkit.org/show_bug.cgi?id=136465
1599
1600         Reviewed by Tim Horton.
1601         
1602         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
1603         for WK2 windows, to make sure that WebPreferences are updated (to get
1604         layer borders to work consistently).
1605
1606         * MiniBrowser/mac/WK1BrowserWindowController.m:
1607         (-[WK1BrowserWindowController awakeFromNib]):
1608
1609 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
1610
1611         check-webkit-style should complain about C++ comments in Platform.h
1612         https://bugs.webkit.org/show_bug.cgi?id=133802
1613
1614         Reviewed by Csaba Osztrogonác.
1615
1616         * Scripts/webkitpy/style/checkers/cpp.py:
1617         (check_platformh_comments):
1618         (_process_lines):
1619         (CppChecker):
1620         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1621         (CppStyleTest.test_platformh_comment):
1622
1623 2014-09-02  Brendan Long  <self@brendanlong.com>
1624
1625         [Gtk] Make install-dependencies work on Arch Linux
1626         https://bugs.webkit.org/show_bug.cgi?id=136374
1627
1628         Reviewed by Philippe Normand.
1629
1630         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
1631
1632 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
1633
1634         Provide column numbers to DTrace willExecute/didExecute probes
1635         https://bugs.webkit.org/show_bug.cgi?id=136434
1636
1637         Reviewed by Antti Koivisto.
1638
1639         Create a directory for DTrace scripts. Add an example script that
1640         shows how to use static probes provided by JavaScriptCore's profiler.
1641
1642         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
1643
1644 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1645
1646         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
1647         https://bugs.webkit.org/show_bug.cgi?id=136431
1648
1649         Reviewed by Martin Robinson.
1650
1651         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
1652         Add missing dependencies for librsvg (glib and cairo).
1653
1654 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1655
1656         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
1657         https://bugs.webkit.org/show_bug.cgi?id=136425
1658
1659         Reviewed by Martin Robinson.
1660
1661         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
1662
1663 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
1664
1665         Update my list of email addresses in contributors.json
1666         https://bugs.webkit.org/show_bug.cgi?id=136424
1667
1668         Reviewed by Gyuyoung Kim.
1669
1670         * Scripts/webkitpy/common/config/contributors.json:
1671
1672 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
1673
1674         [RJST] eager-no-cjit should really mean eager
1675         https://bugs.webkit.org/show_bug.cgi?id=136407
1676
1677         Reviewed by Mark Hahnenberg.
1678         
1679         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
1680         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
1681         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
1682         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
1683         threshold setting that NO_CJIT_OPTIONS was currently setting
1684         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
1685         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
1686         
1687         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
1688
1689         * Scripts/run-jsc-stress-tests:
1690
1691 2014-08-29  Daniel Bates  <dabates@apple.com>
1692
1693         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
1694         https://bugs.webkit.org/show_bug.cgi?id=136388
1695
1696         Reviewed by David Kilzer.
1697
1698         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
1699         support building a command line tool for the iOS Simulator. You must run this
1700         script as root.
1701
1702         The script uses the xcspec files in the OS X SDK to create xcspec files in the
1703         iOS Simulator SDK with the product- and package- type definitions to build a
1704         command line tool, if applicable.
1705
1706         * Scripts/configure-xcode-for-ios-development: Added.
1707
1708 2014-08-29  Tim Horton  <timothy_horton@apple.com>
1709
1710         Remove Windows WebKit2 code from TestWebKitAPI
1711         https://bugs.webkit.org/show_bug.cgi?id=136385
1712
1713         Reviewed by Alexey Proskuryakov.
1714
1715         * TestWebKitAPI/PlatformUtilities.h:
1716         * TestWebKitAPI/PlatformWebView.h:
1717         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
1718         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1719         (TestWebKitAPI::TEST): Deleted.
1720         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1721         (TestWebKitAPI::TEST):
1722         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1723         (TestWebKitAPI::TEST):
1724         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
1725         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
1726         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
1727         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
1728         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
1729         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
1730         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
1731
1732 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1733
1734         [JSC] Some JSC tests are dependent on the machine time zone.
1735         https://bugs.webkit.org/show_bug.cgi?id=136363
1736
1737         Reviewed by Filip Pizlo.
1738
1739         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
1740         Unskip the tests that were skipped on r99580.
1741
1742 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1743
1744         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
1745         https://bugs.webkit.org/show_bug.cgi?id=135560
1746
1747         Reviewed by Gyuyoung Kim.
1748
1749         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
1750
1751 2014-08-28  Daniel Bates  <dabates@apple.com>
1752
1753         [Win] update-webkit should update auxiliary libs by default
1754
1755         Reviewed by Dan Bernstein.
1756
1757         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
1758         from updating the Windows auxiliary libs by default. We should make update-webkit update the
1759         Windows auxiliary libs by default. This will make its behavior match its usage text.
1760
1761         * Scripts/update-webkit:
1762
1763 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
1764
1765         build-webkit --inspector-frontend tries to copy files from old inspector path
1766         https://bugs.webkit.org/show_bug.cgi?id=136346
1767
1768         Reviewed by Timothy Hatcher.
1769
1770         Remove the old code path for copying inspector resources. It doesn't work.
1771         Complain if this option is passed to CMake-based builds.
1772
1773         * Scripts/build-webkit:
1774         * Scripts/webkitdirs.pm:
1775         (copyInspectorFrontendFiles): Deleted.
1776
1777 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
1778
1779         Dashboard metrics page could show longest stretch of red
1780         https://bugs.webkit.org/show_bug.cgi?id=136334
1781
1782         Reviewed by Sam Weinig.
1783
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1785         (Analyzer.prototype._updateStretchOfRedCounters):
1786         (Analyzer.prototype._countPercentageOfGreen):
1787         When counting percentage of green, also keep track of how long the page was red.
1788
1789         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
1790         (MetricsView.prototype._update.addDivider):
1791         (MetricsView.prototype._update.appendQueueResults):
1792         Show it in aggregate queues (can't think of a reason to have it in individual ones).
1793
1794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
1795         Changed to use an explicit divider element between green time and performance groups,
1796         as there are too many combinations to easily express in CSS.
1797
1798 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1799
1800         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
1801         https://bugs.webkit.org/show_bug.cgi?id=136248
1802
1803         Reviewed by Gustavo Noronha Silva.
1804
1805         Add new test case for webkit_uri_response_get_http_headers().
1806
1807         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1808         (testURIResponseHTTPHeaders):
1809         (serverCallback):
1810         (beforeAll):
1811
1812 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
1813
1814         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
1815         https://bugs.webkit.org/show_bug.cgi?id=131668
1816
1817         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1818         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
1819
1820 2014-08-27  Zalan Bujtas  <zalan@apple.com>
1821
1822         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
1823         https://bugs.webkit.org/show_bug.cgi?id=136264
1824
1825         Reviewed by Simon Fraser.
1826         
1827         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
1828         functions. ->snappedIntSize()/snapSizeToDevicePixel().
1829         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
1830
1831         Covered by existing tests.
1832
1833         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1834         (TestWebKitAPI::TEST): Deleted.
1835
1836 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
1837
1838         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
1839         https://bugs.webkit.org/show_bug.cgi?id=131668
1840
1841         Reviewed by Daniel Bates.
1842
1843         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
1844         to not just hardcode.
1845
1846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1847         (EWS.prototype.queueStatusURL): Added.
1848
1849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1850         (EWSQueue.prototype.get statusPageURL): Use the above function.
1851         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
1852
1853         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1854         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
1855         are no patches in the queue. The popover has other useful information, such as charts
1856         link and bot status.
1857
1858 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
1859
1860         https://bugs.webkit.org/show_bug.cgi?id=136317
1861         Dashboard metrics page sometimes shows 0 for best time
1862
1863         Reviewed by Tim Horton.
1864
1865         This also affects regular dashboard display in a good way - iterations that failed
1866         due to infrastructure misbehavior will more reliably show up as yellow and not red.
1867
1868         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1869         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
1870         updated if we rename steps.
1871         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
1872         do it once.
1873         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
1874         that failed e.g. at downloading built archive step are not productive.
1875
1876 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
1877
1878         [Win] Unreviewed gardening.
1879
1880         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
1881         of logs assembled into the final build output.
1882
1883 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
1884
1885         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
1886         https://bugs.webkit.org/show_bug.cgi?id=136196
1887
1888         Reviewed by Timothy Hatcher.
1889
1890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
1891         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
1892         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
1893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
1894         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
1895         A date range picker control with dependencies.
1896         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
1897         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
1898         (it didn't happen again upon re-opening the picker).
1899         - Made made style tweaks to match Dashboard UI.
1900
1901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1902         Don't create objects that are not needed by the given app, and thus are not loaded at all.
1903
1904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
1905         Math to count all the things. Only supports open source tree and trunk at the moment,
1906         but written with internal tree and branches in mind.
1907
1908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
1909         Like dashboard Main.js, draws the UI and creates all necessary objects.
1910
1911         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
1912         A view for table cells.
1913
1914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1915         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
1916         Metrics page has individual platforms initially scrolled away form the view, so 
1917         it needs to scroll down to reveal what's being configured.
1918
1919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1920         Added Array.prototype.average and Array.prototype.median.
1921
1922         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1923         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
1924         in settings mode.
1925
1926         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
1927         Additional style rules.
1928
1929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
1930         The metrics page.
1931
1932 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1933
1934         Remove networkinfo watch category in watchlist
1935         https://bugs.webkit.org/show_bug.cgi?id=136279
1936
1937         Reviewed by Alexey Proskuryakov.
1938
1939         Network info was removed. So, it is not needed anymore.
1940
1941         * Scripts/webkitpy/common/config/watchlist:
1942
1943 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
1944
1945         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
1946         https://bugs.webkit.org/show_bug.cgi?id=136281
1947
1948         Reviewed by Tim Horton.
1949
1950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1951         Track and expose whether the itertion is being loaded. Made update() a no-op if
1952         the iteration is already being loaded.
1953
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1955         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
1956         loading everything at once, ask the queue to load a little more. We can always repeat
1957         if we still don't have enough data.
1958
1959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1960         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
1961         10 more iterations intelligently.
1962
1963 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
1964
1965         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
1966         https://bugs.webkit.org/show_bug.cgi?id=136283
1967
1968         Reviewed by Tim Horton.
1969
1970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1971         Don't.
1972
1973 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
1974
1975         build.webkit.org/dashboard raises an exception after a hidden platform is removed
1976         https://bugs.webkit.org/show_bug.cgi?id=136282
1977
1978         Reviewed by Tim Horton.
1979
1980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1981         (updateHiddenPlatforms): Check that the platform is still valid.
1982
1983 2014-08-26  Matt Lilek  <mrl@apple.com>
1984
1985         Add WebKit SPI to control the navigator.standalone property
1986         https://bugs.webkit.org/show_bug.cgi?id=136189
1987
1988         Reviewed by Andy Estes.
1989
1990         Add API test for WKPreferences
1991
1992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1993         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1994         (TEST):
1995
1996 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1997
1998         Remove ENABLE_DRT environment variable to enable SHARED_CORE
1999         https://bugs.webkit.org/show_bug.cgi?id=136205
2000
2001         Reviewed by Andrei Bucur.
2002
2003         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
2004         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
2005
2006         * Scripts/webkitdirs.pm:
2007         (generateBuildSystemFromCMakeProject):
2008
2009 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
2010
2011         [Win] Version stamp should include package-level version
2012         https://bugs.webkit.org/show_bug.cgi?id=136266
2013         <rdar://problem/18134138>
2014
2015         Reviewed by David Kilzer.
2016
2017         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
2018         tests for the full 3+ digit version.
2019         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
2020         Confirm that the final output DLL uses the 3+ digit version.
2021
2022 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
2023
2024         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
2025         https://bugs.webkit.org/show_bug.cgi?id=136258
2026         <rdar://problem/18134138>
2027
2028         Reviewed by Tim Horton.
2029
2030         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
2031         values from passing through the 32-bit OLE_HANDLE data type.
2032
2033         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2034         (AccessibilityController::rootElement):
2035         * DumpRenderTree/win/DumpRenderTree.cpp:
2036         (resetWebViewToConsistentStateBeforeTesting):
2037         (runTest):
2038         (createWebViewAndOffscreenWindow):
2039         * DumpRenderTree/win/FrameLoadDelegate.h:
2040         (FrameLoadDelegate::didReceiveIcon):
2041         * DumpRenderTree/win/TestRunnerWin.cpp:
2042         (TestRunner::setWindowIsKey):
2043         * DumpRenderTree/win/UIDelegate.cpp:
2044         (UIDelegate::trackCustomPopupMenu):
2045         (UIDelegate::drawHeaderInRect):
2046         (UIDelegate::drawFooterInRect):
2047         (UIDelegate::webViewClose):
2048         (UIDelegate::webViewFocus):
2049         (UIDelegate::webViewSetCursor):
2050         (UIDelegate::drawBackground):
2051         * DumpRenderTree/win/UIDelegate.h:
2052         (UIDelegate::webViewFirstResponder):
2053         (UIDelegate::makeFirstResponder):
2054         (UIDelegate::contextMenuItemsForElement):
2055         (UIDelegate::addCustomMenuDrawingData):
2056         (UIDelegate::cleanUpCustomMenuDrawingData):
2057         (UIDelegate::webViewLostFocus):
2058         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2059         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
2060         * WinLauncher/PrintWebUIDelegate.cpp:
2061         (PrintWebUIDelegate::drawHeaderInRect):
2062         (PrintWebUIDelegate::drawFooterInRect):
2063         * WinLauncher/PrintWebUIDelegate.h:
2064         (PrintWebUIDelegate::webViewFirstResponder):
2065         (PrintWebUIDelegate::makeFirstResponder):
2066         (PrintWebUIDelegate::contextMenuItemsForElement):
2067         (PrintWebUIDelegate::trackCustomPopupMenu):
2068         (PrintWebUIDelegate::addCustomMenuDrawingData):
2069         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
2070         * WinLauncher/WinLauncher.cpp:
2071         (WinLauncher::prepareViews):
2072         * WinLauncher/WinLauncherWebHost.h:
2073         (WinLauncherWebHost::didReceiveIcon):
2074
2075 2014-08-26  Daniel Bates  <dabates@apple.com>
2076
2077         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
2078
2079         Rubber-stamped by Tim Horton.
2080
2081         The Windows and iOS ports are the only ports that make use of WebCore headers
2082         in DumpRenderTree.
2083
2084         * DumpRenderTree/config.h:
2085
2086 2014-08-26  Dan Bernstein  <mitz@apple.com>
2087
2088         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
2089         https://bugs.webkit.org/show_bug.cgi?id=136254
2090
2091         Reviewed by Tim Horton.
2092
2093         * Scripts/webkitdirs.pm:
2094         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
2095         not the invoking script.
2096
2097 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
2098
2099         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
2100         https://bugs.webkit.org/show_bug.cgi?id=136127
2101
2102         Reviewed by Gyuyoung Kim.
2103
2104         Add espeak dependency.
2105
2106         * efl/install-dependencies:
2107
2108 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
2109
2110         Remove a little more accidentally landed code from r172891.
2111
2112         iteration.branch also wasn't meant to be landed.
2113
2114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2115         (BuildbotIteration.prototype._parseData):
2116
2117 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
2118
2119         REGRESSION (r172891): Internal dashboard is broken.
2120
2121         Removing some accidentally landed code - I needed "changes" for another patch, but
2122         not here, and then I decided to not use it anyway.
2123
2124         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2125         (BuildbotIteration.prototype._parseData):
2126
2127 2014-08-25  Daniel Bates  <dabates@apple.com>
2128
2129         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
2130         (https://bugs.webkit.org/show_bug.cgi?id=136108)
2131
2132         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
2133         so that we can compile DumpRenderTree for iOS.
2134
2135         * DumpRenderTree/config.h:
2136
2137 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
2138
2139         Make build.webkit.org/dashboard work with changeset_show_files=location
2140         https://bugs.webkit.org/show_bug.cgi?id=136237
2141
2142         Reviewed by Tim Horton.
2143
2144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2145         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
2146         from description before getting title, and also actually parse the location into
2147         result object when available.
2148
2149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2150         (String.prototype.startsWith): Added.
2151
2152 2014-08-25  Tanay C  <tanay.c@samsung.com>
2153
2154         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
2155         https://bugs.webkit.org/show_bug.cgi?id=135795
2156
2157         Reviewed by Gyuyoung Kim.
2158
2159         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
2160         (history_list_hide): Hiding and dereferencing the history list and items
2161         (on_key_down):
2162         (on_mouse_down):
2163         (on_back_button_clicked): Early return for longpress 
2164         (on_forward_button_clicked): Early return for longpress 
2165         (list_item_label_get): Populate item labels
2166         (on_list_item_select): Navigates on selection from history list
2167         (navigation_button_longpress_process): Populates the history list and displays it
2168         (on_forward_button_longpress):
2169         (on_back_button_longpress):
2170         (window_create): Add the widget for history list
2171
2172 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2173
2174         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
2175         https://bugs.webkit.org/show_bug.cgi?id=136152
2176
2177         Reviewed by Philippe Normand.
2178
2179         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
2180         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
2181         Cherry pick upstream patches daa194 and 4e3d101.
2182
2183 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
2184
2185         GenericHashTraits::peek() is producing copies of passed-in temporary values
2186         https://bugs.webkit.org/show_bug.cgi?id=131461
2187
2188         Reviewed by Darin Adler.
2189
2190         Add a test case that checks the number of copies and moves of the mapped objects
2191         when calling HashMap::get(). Exactly one copy of the mapped value should be
2192         performed when there exists a value that is mapped to the specified key, and
2193         exactly one move and no copies of the empty value should be performed when there
2194         isn't any mapped value for the specified key.
2195
2196         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
2197         (CopyMoveCounter::TestingScope::TestingScope):
2198         (CopyMoveCounter::CopyMoveCounter):
2199         (CopyMoveCounter::operator=):
2200         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2201         (TestWebKitAPI::TEST):
2202
2203 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
2204
2205         [EFL] Introduce DEVELOPER_MODE
2206         https://bugs.webkit.org/show_bug.cgi?id=135884
2207
2208         Reviewed by Gyuyoung Kim.
2209
2210         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
2211         (generateBuildSystemFromCMakeProject):
2212
2213 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
2214
2215         build.webkit.org/dashboard unnecessarily loads results of hidden queues
2216         https://bugs.webkit.org/show_bug.cgi?id=136195
2217
2218         Reviewed by Tim Horton.
2219
2220         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
2221
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2224         Don't start an update just because a queue object was created. Periodic updates
2225         are triggered by views, so it only makes sense to do the same for the initial update.
2226
2227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2228         Now that Trac object doesn't auto-load, start loading here.
2229
2230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2231         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
2232         a data member added by subclasses later. With this.platform being undefined, it
2233         always looked like this queue was not hidden.
2234         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
2235
2236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2237         (Trac): Don't load anything here, the client may choose to load a custom date range.
2238         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
2239
2240 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
2241
2242         build.webkit.org/dashboard: Further improve Trac loading
2243         https://bugs.webkit.org/show_bug.cgi?id=136174
2244
2245         Reviewed by Timothy Hatcher.
2246
2247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2248         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
2249         error, the oldest commit within the range wasn't returned. The correct argument for
2250         "no limit" is 0.
2251         (Trac.prototype.load): Added a function to load a specific time range.
2252         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
2253         positioned with regards to ones that were already known.
2254
2255 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
2256
2257         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
2258         https://bugs.webkit.org/show_bug.cgi?id=136182
2259
2260         Reviewed by Timothy Hatcher.
2261
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2263         Make it possible to create a complete BuildbotIteration object with JSON, not only by
2264         loading data from the network.
2265
2266         An iteration has three states:
2267         1. Just created, it only knows the revision, and whether it's already finished.
2268         BuildbotIteration constructor used to create these.
2269         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
2270         3. Data about tests is fetched.
2271
2272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2273         Make it possible to pull all data from a buildbot queue. This needs to be better
2274         optimized eventually, as it's somewhat slow.
2275
2276 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2277
2278         Remove LevelDB.
2279         https://bugs.webkit.org/show_bug.cgi?id=136170
2280
2281         Reviewed by Gyuyoung Kim.
2282
2283         * Scripts/webkitpy/common/config/watchlist:
2284         * Scripts/webkitpy/style/checker.py:
2285
2286 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2287
2288         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
2289         https://bugs.webkit.org/show_bug.cgi?id=136153
2290
2291         Reviewed by Martin Robinson.
2292
2293         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
2294
2295 2014-08-21  Alex Christensen  <achristensen@webkit.org>
2296
2297         [Win] Another unreviewed build fix.
2298
2299         * DumpRenderTree/config.h:
2300         Defined WEBCORE_EXPORT on Windows.
2301
2302 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
2303
2304         [EFL][WK2] Minibrowser : Add stop button to abort page load
2305         https://bugs.webkit.org/show_bug.cgi?id=136122
2306
2307         Reviewed by Gyuyoung Kim.
2308
2309         * MiniBrowser/efl/main.c:
2310         (on_key_down):
2311         (on_stop_button_clicked): Callback for stop button press.
2312         (window_create):
2313
2314 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2315
2316         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
2317         https://bugs.webkit.org/show_bug.cgi?id=134070
2318
2319         Reviewed by Martin Robinson.
2320
2321         * Scripts/webkitpy/port/base.py:
2322         (Port.__init__): Set default _jhbuild_wrapper variable.
2323         (Port._should_use_jhbuild): Implement generic check.
2324         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
2325         to make it consistent with the other ports.
2326         * Scripts/webkitpy/port/gtk.py:
2327         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
2328         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
2329         querying the jhbuild with printenv. Also check that the path contains
2330         the libraries we expect. Preload this path only for XvfbDriver.
2331         * Scripts/webkitpy/port/xvfbdriver.py:
2332         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
2333         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
2334         configured at setup_environ_for_server()
2335         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2336         (XvfbDriverTest.make_driver): Get the port default environment.
2337         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
2338         should include the environment that is passed when running Xvfb.
2339         (XvfbDriverTest.test_start_pixel_tests): Ditto.
2340         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
2341         (XvfbDriverTest.test_start_next_worker): Ditto.
2342         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
2343         prevent future problems when the version is raised. Add also a
2344         comment with a warning.
2345         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
2346         that has the llvm optimized Gallium libGL libraries.
2347
2348 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2349
2350         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
2351         https://bugs.webkit.org/show_bug.cgi?id=136125
2352
2353         Reviewed by Csaba Osztrogonác.
2354
2355         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2356         (RunLLINTCLoopTests.countFailures):
2357         (Run32bitJSCTests.countFailures):
2358         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2359         (RunLLINTCLoopTestsTest):
2360         (RunLLINTCLoopTestsTest.assertResults):
2361         (RunLLINTCLoopTestsTest.test_failures):
2362         (RunLLINTCLoopTestsTest.test_failure):
2363         (RunLLINTCLoopTestsTest.test_no_failure):
2364         (Run32bitJSCTestsTest):
2365         (Run32bitJSCTestsTest.assertResults):
2366         (Run32bitJSCTestsTest.test_failures):
2367         (Run32bitJSCTestsTest.test_failure):
2368         (Run32bitJSCTestsTest.test_no_failure):
2369
2370 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2371
2372         Unreviewed, EFL build fix since r172814.
2373
2374         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
2375
2376 2014-08-20  Alex Christensen  <achristensen@webkit.org>
2377
2378         Introducing WEBCORE_EXPORT macro.
2379         https://bugs.webkit.org/show_bug.cgi?id=136108
2380
2381         Reviewed by Antti Koivisto.
2382
2383         * TestWebKitAPI/config.h:
2384         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
2385
2386 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
2387
2388         import-w3c-tests doesn't import .svg support files
2389         https://bugs.webkit.org/show_bug.cgi?id=135928
2390
2391         Reviewed by Bem Jones-Bey.
2392
2393         This patch fixes the W3C import script to not treat all
2394         files with an xml mimetype as convertible tests, which
2395         was causing SVG support files to not be imported.
2396
2397         * Scripts/webkitpy/w3c/test_importer.py:
2398         (TestImporter.find_importable_tests):
2399
2400 2014-08-19  Dan Bernstein  <mitz@apple.com>
2401
2402         update-webkit should not check for the presence of Apple’s Internal directory
2403         Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
2404
2405         Reviewed by Tim Horton.
2406
2407         * Scripts/update-webkit:
2408
2409 2014-08-19  Zalan Bujtas  <zalan@apple.com>
2410
2411         Remove ENABLE(SUBPIXEL_LAYOUT).
2412         https://bugs.webkit.org/show_bug.cgi?id=136077
2413
2414         Reviewed by Simon Fraser.
2415
2416         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
2417
2418         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2419
2420 2014-08-19  Akos Kiss  <akiss@inf.u-szeged.hu>
2421
2422         Let the caller define JSC_timeout for run-javascriptcore-tests
2423         https://bugs.webkit.org/show_bug.cgi?id=136068
2424
2425         Reviewed by Csaba Osztrogonác.
2426
2427         Keep the 60 second timeout for jsc tests as the default setting but
2428         don't override the value of JSC_timeout if already set.
2429
2430         * Scripts/run-javascriptcore-tests:
2431
2432 2014-08-19  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2433
2434         Remove obsolete run-javascriptcore-tests result parsing from master.cfg
2435         https://bugs.webkit.org/show_bug.cgi?id=136039
2436
2437         Reviewed by Csaba Osztrogonác.
2438
2439         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2440         (RunJavaScriptCoreTests.commandComplete):
2441         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2442         (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
2443         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
2444         (RunJavaScriptCoreTestsTest):
2445         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
2446         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
2447         (test_layout_failure_new_output): Deleted.
2448         (test_layout_crash_new_output): Deleted.
2449         (test_mozilla_and_layout_failure_new_output): Deleted.
2450         (test_jsc_stress_failure_new_output): Deleted.
2451         (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
2452
2453 2014-08-19  Alexey Proskuryakov  <ap@apple.com>
2454
2455         build.webkit.org/dashboard should not request 50 revisions from trac each time
2456         https://bugs.webkit.org/show_bug.cgi?id=127130
2457
2458         build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
2459         https://bugs.webkit.org/show_bug.cgi?id=127131
2460
2461         Reviewed by Timothy Hatcher.
2462
2463         Turns out that requesting 50 builds is much slower than requesting by date - even
2464         if the request ends up returning more than 50 results. There is no way to only
2465         request updates, but this change brings request time from 6-8 seconds down to
2466         less than a second.
2467
2468         This patch generalizes date handling for later use in metrics code. As part of the
2469         rewrite, I made newly fetched data update author e-mail in previously fetched
2470         revisions, as it changes after commit queue first lands.
2471
2472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2473         Updated for event rename. I changed the trac event to not contain the list of new
2474         commits, as we now sometimes update old commits, and that couldn't be expressed
2475         in event data. We never used the list anywhere in the first place.
2476
2477         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2478         (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
2479         without arguments, return commits for today and yesterday.
2480         (Trac.prototype._loaded):
2481         (Trac.prototype.update): Moved the function for processing loaded results out of
2482         here for clarity, and also because I'm going to have a separate loading code path
2483         for metrics.
2484
2485 2014-08-18  Dan Bernstein  <mitz@apple.com>
2486
2487         Added an update-webkit option to override the ../Internal check.
2488         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
2489
2490         Reviewed by Tim Horton.
2491
2492         * Scripts/update-webkit:
2493         Added an explicit --internal option to control updating ../Internal, defaulting to whether
2494         ../Internal exists.
2495         (runSvnUpdate): Moved to webkitdirs.pm.
2496         (runGitUpdate): Ditto.
2497         * Scripts/webkitdirs.pm:
2498         (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
2499         (runGitUpdate): Moved from update-webkit.
2500
2501 2014-08-18  Pratik Solanki  <psolanki@apple.com>
2502
2503         Make update-webkit more lenient for pure git svn repositories
2504         https://bugs.webkit.org/show_bug.cgi?id=135805
2505
2506         Reviewed by Oliver Hunt.
2507
2508         Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
2509         call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
2510         provide an optimization when you have a git repository setup. We should not fail if the
2511         git setup does not have svn-remote.svn.fetch set.
2512
2513         * Scripts/update-webkit:
2514         (runGitUpdate):
2515
2516 2014-08-18  Simon Fraser  <simon.fraser@apple.com>
2517
2518         Enable Web Inspector in MiniBrowser WK2 windows
2519         https://bugs.webkit.org/show_bug.cgi?id=136045
2520
2521         Reviewed by Tim Horton.
2522         
2523         Set the pref to enable developer extras for all WK2 windows.
2524
2525         * MiniBrowser/mac/WK2BrowserWindowController.m:
2526         (-[WK2BrowserWindowController awakeFromNib]):
2527
2528 2014-08-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2529
2530         master.cfg should handle special return codes of run-perf-tests
2531         https://bugs.webkit.org/show_bug.cgi?id=135974
2532
2533         Reviewed by Ryosuke Niwa.
2534
2535         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2536         (RunAndUploadPerfTests.getText2):
2537         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2538         (RunAndUploadPerfTestsTest):
2539         (RunAndUploadPerfTestsTest.assertResults):
2540         (RunAndUploadPerfTestsTest.test_tests_failed):
2541         (RunAndUploadPerfTestsTest.test_build_bad_build):
2542         (RunAndUploadPerfTestsTest.test_build_bad_source_json):
2543         (RunAndUploadPerfTestsTest.test_build_bad_marge):
2544         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
2545         (RunAndUploadPerfTestsTest.test_build_bad_preparation):
2546
2547 2014-08-17  Brent Fulgham  <bfulgham@apple.com>
2548
2549         [Win] Unreviewed change to force rebuild
2550         (plus drive-by add an accessor I wanted for
2551         some future tooling).
2552
2553         * WinLauncher/WinLauncher.h:
2554         (WinLauncher::webView): Added.
2555
2556 2014-08-16  Mark Hahnenberg  <mhahnenb@gmail.com>
2557
2558         Update contributors.json for my new email
2559         https://bugs.webkit.org/show_bug.cgi?id=136021
2560
2561         Reviewed by Filip Pizlo.
2562
2563         * Scripts/webkitpy/common/config/contributors.json:
2564
2565 2014-08-15  Alexey Proskuryakov  <ap@apple.com>
2566
2567         REGRESSION (r172660): WebKit2.TerminateTwice asserts
2568         https://bugs.webkit.org/show_bug.cgi?id=136012
2569
2570         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
2571
2572 2014-08-15  Ryuan Choi  <ryuan.choi@samsung.com>
2573
2574         Unreviewed build fix attempt on the CMake based pots since r172665
2575
2576         * TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.
2577
2578 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
2579
2580         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
2581         https://bugs.webkit.org/show_bug.cgi?id=131596
2582
2583         Reviewed by Joseph Pecoraro.
2584
2585         * Scripts/run-inspector-generator-tests: Added.
2586         (main):
2587         * Scripts/webkitpy/inspector/__init__.py: Added.
2588         * Scripts/webkitpy/inspector/main.py: Added.
2589         (InspectorGeneratorTests):
2590         (InspectorGeneratorTests.__init__):
2591         (InspectorGeneratorTests.generate_from_json):
2592         (InspectorGeneratorTests.write_error_file):
2593         (InspectorGeneratorTests.detect_changes):
2594         (InspectorGeneratorTests.run_tests):
2595         (InspectorGeneratorTests.main):
2596
2597 2014-08-15  Rebecca Hauck  <rhauck@adobe.com>
2598
2599         run-webkit-tests should skip 'support' directories
2600         https://bugs.webkit.org/show_bug.cgi?id=135910
2601
2602         Reviewed by Bem Jones-Bey.
2603         
2604         This patch adds the 'support' directory to the list
2605         of dirs to skip when looking for runnable tests.
2606         the W3C uses this name for support files, so tests
2607         imported from the W3C will not work without this change
2608         or without many edits.
2609
2610         * Scripts/webkitpy/port/base.py:
2611         (Port._real_tests):
2612
2613 2014-08-14  Brent Fulgham  <bfulgham@apple.com>
2614
2615         [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
2616         https://bugs.webkit.org/show_bug.cgi?id=135948
2617         <rdar://problem/18022221>
2618
2619         Reviewed by David Kilzer.
2620
2621         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests
2622         for RC_ProjectBuildVersion.
2623
2624 2014-08-05  David Farler  <dfarler@apple.com>
2625
2626         [iOS] run-webkit-tests runs webkit-build-directory on every test
2627         https://bugs.webkit.org/show_bug.cgi?id=135409
2628
2629         Reviewed by Daniel Bates.
2630
2631         * Scripts/webkitpy/port/ios.py:
2632         (IOSSimulatorPort.__init__): Cache Mac build directory.
2633         (IOSSimulatorPort.relay_path): Use cached build directory.
2634         (IOSSimulatorPort._path_to_image_diff): Use cached build directory.
2635
2636 2014-08-14  Zan Dobersek  <zdobersek@igalia.com>
2637
2638         Initialize a separate variable (TestWTF_SOURCES) with the list of files
2639         that are built into the TestWTF executable and move it above the platform-specific
2640         config file inclusion. This makes it possible to add platform-specific files to that
2641         list (e.g. GUniquePtr.cpp for the GTK port).
2642
2643         Rubber-stamped by Carlos Garcia Campos.
2644
2645         * TestWebKitAPI/CMakeLists.txt:
2646         * TestWebKitAPI/PlatformGTK.cmake:
2647
2648 2014-08-13  Akos Kiss  <akiss@inf.u-szeged.hu>
2649
2650         [EFL] Bump up and patch dependencies to allow building for aarch64
2651         https://bugs.webkit.org/show_bug.cgi?id=135885
2652
2653         Reviewed by Gyuyoung Kim.
2654
2655         The currently used versions of pixman, libffi, glib, glib-networking,
2656         and fontconfig fail to configure for aarch64, so they are bumped up to
2657         the latest stable version.
2658
2659         Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
2660         ARM NEON assembly support, so it is patched with a change that has been
2661         accepted by upstream.
2662
2663         * efl/jhbuild.modules:
2664         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
2665
2666 2014-08-13  Mark Rowe  <mrowe@apple.com>
2667
2668         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
2669
2670         Reviewed by Darin Adler.
2671
2672         * DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
2673
2674 2014-08-13  Alex Christensen  <achristensen@webkit.org>
2675
2676         Progress towards CMake on Mac.
2677         https://bugs.webkit.org/show_bug.cgi?id=135819
2678
2679         Reviewed by Laszlo Gombos.
2680
2681         * WebKitTestRunner/CMakeLists.txt:
2682         Added new cpp parameter for the extension of the generated files.
2683
2684 2014-08-13  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2685
2686         Make check-webkit-style run sort-export-file
2687         https://bugs.webkit.org/show_bug.cgi?id=135877
2688
2689         Reviewed by Csaba Osztrogonác.
2690
2691         * Scripts/webkitpy/style/checker.py:
2692         (_all_categories):
2693         (FileType):
2694         (CheckerDispatcher._file_type):
2695         (CheckerDispatcher._create_checker):
2696         * Scripts/webkitpy/style/checkers/exportfile.py: Added.
2697         (ExportFileChecker):
2698         (ExportFileChecker.__init__):
2699         (ExportFileChecker.check):
2700         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.
2701         (handle_style_error):
2702         (MockErrorHandler):
2703         (MockErrorHandler.__init__):
2704         (MockErrorHandler.turn_off_line_filtering):
2705         (MockErrorHandler.__call__):
2706         (ExportFileTest):
2707         (ExportFileTest.setUp):
2708         (ExportFileTest.tearDown):
2709         (ExportFileTest.test_sorted):
2710         (ExportFileTest.test_non_sorted):
2711         (ExportFileTest.test_parse_error):
2712
2713 2014-08-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2714
2715         [EFL] Sets the persistent storage for cookies in MiniBrowser
2716         https://bugs.webkit.org/show_bug.cgi?id=135875
2717
2718         Reviewed by Gyuyoung Kim.
2719
2720         In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
2721         for non-session cookies can be stored persistently.
2722
2723         * MiniBrowser/efl/main.c:
2724         (elm_main):
2725
2726 2014-08-12  Daniel Bates  <dabates@apple.com>
2727
2728         [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
2729         https://bugs.webkit.org/show_bug.cgi?id=135845
2730
2731         Reviewed by Andy Estes.
2732
2733         Towards building the iOS WebKit port using the public SDK, remove the logic
2734         added to build-webkit to build projects WebKitSystemInterface and
2735         WebKitAdditions when building the iOS WebKit port.
2736
2737         * Scripts/build-webkit:
2738
2739 2014-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2740
2741         [GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
2742         https://bugs.webkit.org/show_bug.cgi?id=135850
2743
2744         Reviewed by Philippe Normand.
2745
2746         After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
2747         Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.
2748
2749         * gtk/install-dependencies:
2750
2751 2014-08-12  Eduardo Lima Mitev  <elima@igalia.com>
2752
2753         [GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
2754         https://bugs.webkit.org/show_bug.cgi?id=135798
2755
2756         Reviewed by Philippe Normand.
2757
2758         * Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to
2759             toggle SUBTLE_CRYPTO feature.
2760
2761 2014-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
2762
2763         [EFL] Disable ecore logs about bad fd
2764         https://bugs.webkit.org/show_bug.cgi?id=135831
2765
2766         Reviewed by Gyuyoung Kim.
2767
2768         ecore checks EBADF and prints the warnings.
2769         But, it looks noise in layout test because it's not webkit issue.
2770         This patch disables it until we found right solution.
2771
2772         * efl/jhbuild.modules:
2773         * efl/patches/ecore_remove_warnings.patch: Added.
2774
2775 2014-08-12  Shivakumar JM  <shiva.jm@samsung.com>
2776
2777         [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
2778         https://bugs.webkit.org/show_bug.cgi?id=135791
2779
2780         Reviewed by Gyuyoung Kim.
2781
2782         Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
2783         user.
2784
2785         * MiniBrowser/efl/main.c:
2786         (on_download_request):
2787
2788 2014-08-11  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2789
2790         [EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
2791         https://bugs.webkit.org/show_bug.cgi?id=135606
2792
2793         Reviewed by Gyuyoung Kim.
2794
2795         TestWebKitAPI does not initialize EWebkit using ewk_init()
2796         which is not recommended.
2797
2798         * TestWebKitAPI/efl/PlatformWebView.cpp:
2799         (TestWebKitAPI::createEcoreEvas):
2800         Renamed from initEcoreEvas() since it doesn't not initialize
2801         ecore evas.
2802
2803         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2804         Call ewk_init() that initalizes all EFL modules needed by EWebKit
2805         instead of ecore_evas_init() only.
2806
2807         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2808         Call ewk_shutdown() to finalize EWebkit.
2809         (TestWebKitAPI::initEcoreEvas): Deleted.
2810
2811 2014-08-11  Dan Bernstein  <mitz@apple.com>
2812
2813         Added an update-webkit option to update the auxiliary libraries or not.
2814         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
2815
2816         Reviewed by Tim Horton.
2817
2818         * Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless
2819         an Internal directory exists alongside the WebKit root directory.
2820
2821 2014-08-11  Bem Jones-Bey  <bjonesbe@adobe.com>
2822
2823         Remove hg changeset from w3c-import.log
2824         https://bugs.webkit.org/show_bug.cgi?id=135735
2825
2826         Reviewed by Ryosuke Niwa.
2827
2828         Since the csswg's test suite is now accessible via github and it is
2829         possible to push changes by creating github pull requests, the hg
2830         changeset makes less sense, as many people will just use a clone of
2831         the git repo. There isn't an obvious thing to replace it with, so
2832         might as well remove it for now instead of having it just be set to
2833         UNKNOWN in imports.
2834
2835         This also adds a pointer to the github repo in the generated comments
2836         in the w3c-import.log.
2837
2838         * Scripts/webkitpy/w3c/test_importer.py:
2839         (TestImporter.__init__): Remove changeset handling.
2840         (TestImporter.do_import): Ditto.
2841         (TestImporter.write_import_log): Ditto.
2842         (TestImporter.load_changeset): Deleted.
2843
2844 2014-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2845
2846         Unreviewed. Fix GTK+ make distcheck.
2847
2848         * gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.
2849
2850 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
2851
2852         Unbreak webkitpy unit tests by checking for the existence of the image diff template
2853         file before trying to open it (as the tests do for results.html).
2854
2855         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2856         (TestResultWriter.write_image_diff_files):
2857
2858 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
2859
2860         Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
2861         https://bugs.webkit.org/show_bug.cgi?id=135780
2862
2863         Reviewed by Dan Bates.
2864         
2865         Pull the HTML for the image diff file into a separate file, for easier hackability.
2866
2867         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2868         (TestResultWriter.write_image_diff_files):
2869
2870 2014-08-08  Mark Lam  <mark.lam@apple.com>
2871
2872         Gardening: fix Windows build after r172259.
2873
2874         Not reviewed.
2875
2876         * DumpRenderTree/win/TestRunnerWin.cpp:
2877         (TestRunner::addMockSpeechInputResult): Deleted.
2878         (TestRunner::setMockSpeechInputDumpRect): Deleted.
2879         (TestRunner::startSpeechInput): Deleted.
2880
2881 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
2882
2883         make clean does not work in OpenSource, fails in WebKitLibraries
2884         https://bugs.webkit.org/show_bug.cgi?id=135734
2885
2886         Reviewed by David Kilzer.
2887
2888         * Scripts/copy-webkitlibraries-to-product-directory:
2889         Add a --clean switch that removes possible WebKitSystemInterface
2890         and LLVM libraries and headers that may have been copied to the
2891         product directory.
2892
2893 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
2894
2895         commit-log-message has extra blank line at the top of pre-populated message
2896         https://bugs.webkit.org/show_bug.cgi?id=135744
2897
2898         Reviewed by Csaba Osztrogonác.
2899
2900         Do not add a blank leading line in single ChangeLog commit messages.
2901
2902         * Scripts/commit-log-editor:
2903         (createCommitMessage):
2904         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2905         (test_commit_message_for_one_reviewed_changelog):
2906         (test_commit_message_for_one_rollout_changelog):
2907
2908 2014-08-07  Brent Fulgham  <bfulgham@apple.com>
2909
2910         [Win] Unreviewed gardening.
2911
2912         Have 'Assemble Build Logs' step work properly for DebugSuffix target
2913         (both 32-bit and 64-bit).
2914
2915         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2916
2917 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
2918
2919         Get rid of INPUT_SPEECH
2920         https://bugs.webkit.org/show_bug.cgi?id=135672
2921
2922         Reviewed by Andreas Kling.
2923
2924         * DumpRenderTree/TestRunner.cpp:
2925         (TestRunner::staticFunctions):
2926         (addMockSpeechInputResultCallback): Deleted.
2927         (setMockSpeechInputDumpRectCallback): Deleted.
2928         * DumpRenderTree/TestRunner.h:
2929         * DumpRenderTree/mac/TestRunnerMac.mm:
2930         (TestRunner::addMockSpeechInputResult): Deleted.
2931         (TestRunner::setMockSpeechInputDumpRect): Deleted.
2932         (TestRunner::startSpeechInput): Deleted.
2933
2934 2014-08-07  Bem Jones-Bey  <bjonesbe@adobe.com>
2935
2936         The support directory shouldn't be skipped unconditionally in test import
2937         https://bugs.webkit.org/show_bug.cgi?id=135660
2938
2939         Reviewed by Ryosuke Niwa.
2940
2941         The 'DIRS_TO_SKIP' should only be skipped when in the root directory
2942         of the test repo, as that's the only time they are special. In
2943         addition, instead of hardcoding .hg and .git as special, skip all
2944         directories that begin with '.', just like with files that begin with '.'.
2945         
2946         In order to make this work, the root directory must always be
2947         passed in, so the interface to the script has been changed to take the
2948         root directory, and if one wants to only import a subset of the tests,
2949         a new -t option can be used to limit the tests imported.
2950
2951         * Scripts/webkitpy/w3c/test_importer.py:
2952         (main): Remove repo_dir command line argument.
2953         (parse_args): Add -t option and set expected non-option args to 1.
2954         (TestImporter.__init__): Remove repo_dir.
2955         (TestImporter.do_import): Handle the varying number of import
2956             directories.
2957         (TestImporter.should_keep_subdir): Helper for find_importable_tests to
2958             determine if a subdirectory should be skipped.
2959         (TestImporter.find_importable_tests): Filter directories using new
2960             helper.
2961         (TestImporter.import_tests): Remove use of repo_dir.
2962         (TestImporter.setup_destination_directory): Unused, Deleted. 
2963         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2964         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Update for
2965             new API.
2966         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
2967
2968 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2969
2970         [GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
2971         https://bugs.webkit.org/show_bug.cgi?id=135695
2972
2973         Reviewed by Gustavo Noronha Silva.
2974
2975         Use WebKitNavigationAction API.
2976
2977         * MiniBrowser/gtk/BrowserWindow.c:
2978         (webViewDecidePolicy):
2979         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
2980         (testNavigationPolicy):
2981
2982 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2983
2984         [GTK] Test /webkit2/WebKitUserContentManager/injected-script fails
2985         https://bugs.webkit.org/show_bug.cgi?id=135696
2986
2987         Reviewed by Sergio Villar Senin.
2988
2989         Don't assume the JavaScript result is always a valid pointer. In case of JavaScript
2990         exception (that happens when testing the script hasn't been injected) the JavaScript
2991         result is NULL.
2992
2993         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2994         (isScriptInjectedForURLAtPath):
2995
2996 2014-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2997
2998         [GTK] Disable IndexedDB
2999         https://bugs.webkit.org/show_bug.cgi?id=135692
3000
3001         Reviewed by Carlos Garcia Campos.
3002
3003         * Scripts/webkitperl/FeatureList.pm:
3004
3005 2014-08-06  Dean Jackson  <dino@apple.com>
3006
3007         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
3008         https://bugs.webkit.org/show_bug.cgi?id=135675
3009
3010         Reviewed by Sam Weinig.
3011
3012         * Scripts/webkitperl/FeatureList.pm:
3013
3014 2014-08-06  David Farler  <dfarler@apple.com>
3015
3016         Set DSYMUTIL_NUM_THREADS to the number of logical cores
3017         https://bugs.webkit.org/show_bug.cgi?id=135655
3018
3019         Reviewed by Mark Rowe.
3020
3021         * Scripts/webkitdirs.pm:
3022         (buildXCodeProject): Set before calling xcodebuild.
3023
3024 2014-08-06  Adrian Perez de Castro  <aperez@igalia.com>
3025
3026         [GTK] Add support for user scripts to WebKitUserContentManager
3027         https://bugs.webkit.org/show_bug.cgi?id=134738
3028
3029         Reviewed by Carlos Garcia Campos.
3030
3031         Add support for user scripts, to complement the user style sheet
3032         support already present in WebKitUserContentManager. Most of the
3033         moving parts are already present, so this just adds a boxed type
3034         for user scripts (WebKitUserScript) and the corresponding methods
3035         to add and remove scripts from the WebKitUserContentManager.
3036
3037         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3038         Add test case for injected user scripts.
3039         (isScriptInjectedForURLAtPath):
3040         (removeOldInjectedContentAndResetLists):
3041         (testUserContentManagerInjectedStyleSheet):
3042         (testUserContentManagerInjectedScript):
3043         (beforeAll):
3044         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
3045
3046 2014-08-06  Philippe Normand  <pnormand@igalia.com>
3047
3048         [GTK] run-launcher --gtk still fails
3049         https://bugs.webkit.org/show_bug.cgi?id=135642
3050
3051         Reviewed by Carlos Garcia Campos.
3052
3053         The perl interpreter is confused by the combination of string
3054         concatenation and a ternary in the same line. Using a separate
3055         variable to determine the library file extension fixes this issue.
3056
3057         * Scripts/webkitdirs.pm:
3058         (builtDylibPathForName): Use an intermediate variable, it's more
3059         readable and unambiguous.
3060
3061 2014-07-29  Filip Pizlo  <fpizlo@apple.com>
3062
3063         Merge r170564, r170571, r170604, r170628, r170672, r170680, r170724, r170728, r170729, r170819, r170821, r170836, r170855, r170860, r170890, r170907, r170929, r171052, r171106, r171152, r171153, r171214 from ftlopt.
3064
3065     2014-06-25  Filip Pizlo  <fpizlo@apple.com>
3066     
3067             [ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
3068             https://bugs.webkit.org/show_bug.cgi?id=134333
3069     
3070             Reviewed by Geoffrey Garen.
3071     
3072             * Scripts/display-profiler-output:
3073     
3074 2014-08-05  David Farler  <dfarler@apple.com>
3075
3076         [iOS] Run ImageDiff in the sim bootstrap
3077         https://bugs.webkit.org/show_bug.cgi?id=135624
3078
3079         Reviewed by David Kilzer.
3080
3081         * Scripts/webkitpy/port/image_diff.py:
3082         (ImageDiffer.stop):
3083         (IOSSimulatorImageDiffer):
3084         (IOSSimulatorImageDiffer._start):
3085         * Scripts/webkitpy/port/ios.py:
3086         (IOSSimulatorPort.diff_image):
3087
3088 2014-08-05  David Farler  <dfarler@apple.com>
3089
3090         [iOS] run-webkit-tests: defaults for --runtime and --device-type flags
3091         https://bugs.webkit.org/show_bug.cgi?id=135441
3092
3093         Reviewed by Tim Horton.
3094
3095         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3096         (parse_args):
3097         (_set_up_derived_options):
3098         If using the ios-simulator platform and runtime or device-type
3099         aren't defined, get the latest runtime from the active Xcode.app
3100         and pick a default device type based on the desired architecture:
3101         iPhone 5 for i386 and iPhone 5s for x86_64.
3102         * Scripts/webkitpy/xcode/__init__.py: Added.
3103         * Scripts/webkitpy/xcode/simulator.py: Added.
3104
3105 2014-08-05  David Farler  <dfarler@apple.com>
3106
3107         [iOS] simctl can hang if run quickly after shutting down CoreSimulator services
3108         https://bugs.webkit.org/show_bug.cgi?id=135626
3109
3110         Reviewed by Dan Bernstein.
3111
3112         * Scripts/webkitpy/port/ios.py:
3113         (IOSSimulatorPort.setup_test_run):
3114         Remove call to simctl shutdown <device> - telling the simulator app to quit
3115         will shut down all booted devices.
3116
3117 2014-08-05  Alexey Proskuryakov  <ap@apple.com>
3118
3119         Remove an unused argument from BuildbotQueue.update()
3120         https://bugs.webkit.org/show_bug.cgi?id=135623
3121
3122         Reviewed by Timothy Hatcher.
3123
3124         Also remaned a constant to better match what it means.
3125
3126         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3127
3128 2014-08-05  Vivek Galatage  <vivek.vg@samsung.com>
3129
3130         [gtk] Include llvm-dev(el) package to satisfy mesa build configuration
3131         https://bugs.webkit.org/show_bug.cgi?id=135555
3132
3133         Reviewed by Philippe Normand.
3134
3135         Initial setup of gtk on linux requires this package to be installed.
3136         This is required during the build configuration of mesa through jhbuild.
3137
3138         * gtk/install-dependencies:
3139
3140 2014-08-05  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3141
3142         Fix the commit-log-editor after r167243 and add more unit tests
3143         https://bugs.webkit.org/show_bug.cgi?id=131727
3144
3145         Reviewed by Csaba Osztrogonác.
3146
3147         * Scripts/commit-log-editor:
3148         (createCommitMessage):
3149         (removeLongestCommonPrefixEndingInNewline):
3150         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3151         (CommitMessageForThisCommitTest):
3152         (CommitMessageForThisCommitTest.mock_changelog):
3153         (CommitMessageForThisCommitTest.mock_checkout_for_test):
3154         (CommitMessageForThisCommitTest.test_commit_message_for_unreviewed_changelogs_with_different_messages):
3155         (test_commit_message_for_one_reviewed_changelog):
3156         (test_commit_message_for_changelogs_with_same_messages):
3157         (test_commit_message_for_changelogs_with_different_messages):
3158         (test_commit_message_for_one_rollout_changelog):
3159         (test_commit_message_for_rollout_changelogs_with_different_directories):
3160         (setUp): Deleted.
3161         (test_commit_message_for_this_commit): Deleted.
3162
3163 2014-08-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3164
3165         [GTK] run-launcher --gtk is broken
3166         https://bugs.webkit.org/show_bug.cgi?id=135571
3167
3168         Reviewed by Martin Robinson.
3169
3170         * Scripts/webkitdirs.pm:
3171         (builtDylibPathForName): Search for libwebkit2gtk-4.0
3172
3173 2014-08-04  Matt Baker  <mattbaker@apple.com>
3174
3175         lldb_webkit.py throws exception when generating summary of null StringImpl
3176         https://bugs.webkit.org/show_bug.cgi?id=129448
3177
3178         Reviewed by Jer Noble.
3179
3180         Added checks for null StringImpl and 0 byte ReadMemory calls.
3181
3182         * lldb/lldb_webkit.py:
3183         (WTFStringImpl_SummaryProvider):
3184         (ustring_to_string):
3185         (lstring_to_string):
3186         (WTFStringImplProvider.to_string):
3187         (WTFStringImplProvider.is_initialized):
3188
3189 2014-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3190
3191         [GTK] Do not include JavaScriptCore stress tests in release tarballs
3192         https://bugs.webkit.org/show_bug.cgi?id=135503
3193
3194         Reviewed by Martin Robinson.
3195
3196         * gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
3197
3198 2014-07-30  David Farler  <dfarler@apple.com>
3199
3200         build-webkittestrunner doesn't build the app target for iOS SDKs
3201         https://bugs.webkit.org/show_bug.cgi?id=135433
3202
3203         Reviewed by Dan Bernstein.
3204
3205         * Scripts/build-dumprendertree: Build the app target on iOS.
3206         * Scripts/build-webkittestrunner: Build the app target on iOS.
3207         * Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
3208         (buildXCodeProject):
3209         * Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
3210         (IOSSimulatorPort._build_driver_flags):
3211
3212 2014-07-30  David Farler  <dfarler@apple.com>
3213
3214         Remove iOS Perl DumpRenderTree support target
3215         https://bugs.webkit.org/show_bug.cgi?id=135271
3216
3217         Reviewed by Dan Bernstein.
3218
3219         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
3220         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
3221         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
3222         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
3223         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
3224         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
3225         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
3226         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
3227         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
3228         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
3229         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
3230         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
3231         * DumpRenderTree/ios/PerlSupport/Makefile: Removed.
3232
3233 2014-07-30  David Farler  <dfarler@apple.com>
3234
3235         Remove old-run-webkit-tests
3236         https://bugs.webkit.org/show_bug.cgi?id=135374
3237
3238         Reviewed by Csaba Osztrogonác.
3239
3240         * Scripts/old-run-webkit-tests: Removed.
3241
3242 2014-08-02  Dan Bernstein  <mitz@apple.com>
3243
3244         prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
3245         https://bugs.webkit.org/show_bug.cgi?id=135542
3246
3247         Reviewed by Tim Horton.
3248
3249         * Scripts/prepare-ChangeLog:
3250         (main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
3251         findChangeLogs.
3252         (findChangeLogs): Don’t require a ChangeLog file to exist if unless the
3253         requireChangeLogToExist argument is true.
3254
3255 2014-08-01  Dan Bernstein  <mitz@apple.com>
3256
3257         commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
3258         https://bugs.webkit.org/show_bug.cgi?id=135527
3259
3260         Reviewed by Tim Horton.
3261
3262         * Scripts/commit-log-editor:
3263         In the case of a git repository when there are no changed ChangeLog files, changed to pass
3264         the --delimiters option to prepare-ChangeLog, then process each entry in the output using
3265         commitMessageFromChangeLogEntry.
3266         (commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
3267         (sortKey): Factored out from createCommitMessage.
3268         (createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
3269         subroutines.
3270
3271         * Scripts/prepare-ChangeLog:
3272         (main): Parse new --delimiters option.
3273         (generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
3274         the label before each change log entry, and a "~" delimiter on a new line after each entry.
3275
3276 2014-08-01  Bear Travis  <betravis@adobe.com>
3277
3278         [Feature Queries] Enable Feature Queries on EFL/GTK
3279         https://bugs.webkit.org/show_bug.cgi?id=134902
3280
3281         Reviewed by Benjamin Poulain.
3282
3283         Turn the feature on by default for the build script.
3284
3285         * Scripts/webkitperl/FeatureList.pm:
3286
3287 2014-08-01  Timothy Horton  <timothy_horton@apple.com>
3288
3289         Build fix for 32-bit after r171926.
3290
3291         * MiniBrowser/mac/SettingsController.h:
3292         * MiniBrowser/mac/SettingsController.m:
3293
3294 2014-08-01  Tim Horton  <timothy_horton@apple.com>
3295
3296         Confusing build fix after r171926.
3297
3298         * MiniBrowser/mac/AppDelegate.h:
3299         * MiniBrowser/mac/AppDelegate.m:
3300         * MiniBrowser/mac/SettingsController.m:
3301
3302 2014-08-01  Tim Horton  <timothy_horton@apple.com>
3303
3304         Make it easer to add switches to MiniBrowser
3305         https://bugs.webkit.org/show_bug.cgi?id=135499
3306
3307         Reviewed by Simon Fraser.
3308
3309         Add a single class to manage a set of persistent, global settings for MiniBrowser.
3310         Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
3311
3312         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3313         Add SettingsController.{m, h}.
3314
3315         * MiniBrowser/mac/AppDelegate.h:
3316         Move _browserWindowControllers to the implementation.
3317         Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
3318         of that; instead, we'll receive didChangeSettings.
3319
3320         * MiniBrowser/mac/AppDelegate.m:
3321         Move the default URL, default URL preference key, and use-WebKit2-by-default
3322         preference key into SettingsController.
3323
3324         (-[BrowserAppDelegate awakeFromNib]):
3325         Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
3326
3327         (-[BrowserAppDelegate newWindow:]):
3328         Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
3329
3330         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3331         SettingsController now takes care of reading the default URL preference.
3332         WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
3333
3334         (-[BrowserAppDelegate didChangeSettings]):
3335         When settings change, update the key equivalents for the new-window menu items, as they
3336         might have changed (as use-WebKit2-by-default is one of the settings).
3337
3338         Dispatch settings change notifications to all live BrowserControllers.
3339
3340         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3341         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
3342         (-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
3343         (-[BrowserAppDelegate validateMenuItem:]): Deleted.
3344         All menu item validation for settings is moved into SettingsController.
3345
3346         * MiniBrowser/mac/BrowserWindowController.h:
3347         Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
3348         the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
3349
3350         * MiniBrowser/mac/MainMenu.xib:
3351         Remove the settings menu items from the "Debug" menu.
3352
3353         * MiniBrowser/mac/SettingsController.h: Added.
3354         * MiniBrowser/mac/SettingsController.m: Added.
3355         (+[SettingsController shared]):
3356         (-[SettingsController menu]):
3357
3358         (-[SettingsController _addItemWithTitle:action:indented:]):
3359         (-[SettingsController _addHeaderWithTitle:]):
3360         NSMenuItem-creating helpers.
3361
3362         (-[SettingsController _populateMenu]):
3363         Build the menu. Ideally this and the validation step would eventually be made more dynamic.
3364
3365         (-[SettingsController validateMenuItem:]):
3366         Validate menu items; since they can be used to toggle the default state of a setting,
3367         we'll always return YES. However, we will use this opportunity to set the 'checked' state
3368         of each item.
3369
3370
3371         (-[SettingsController _toggleBooleanDefault:]):
3372         Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
3373
3374         (-[SettingsController toggleUseWebKit2ByDefault:]):
3375         (-[SettingsController useWebKit2ByDefault]):
3376         (-[SettingsController toggleUseTransparentWindows:]):
3377         (-[SettingsController useTransparentWindows]):
3378         (-[SettingsController toggleUsePaginatedMode:]):
3379         (-[SettingsController usePaginatedMode]):
3380         (-[SettingsController toggleUseUISideCompositing:]):
3381         (-[SettingsController useUISideCompositing]):
3382         (-[SettingsController toggleShowLayerBorders:]):
3383         (-[SettingsController layerBordersVisible]):
3384         (-[SettingsController toggleShowTiledScrollingIndicator:]):
3385         (-[SettingsController tiledScrollingIndicatorVisible]):
3386         (-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
3387         (-[SettingsController subPixelCSSOMMetricsEnabled]):
3388         (-[SettingsController defaultURL]):
3389         Toggle or return the current state of each preference.
3390
3391         * MiniBrowser/mac/WK1BrowserWindowController.m:
3392         (-[WK1BrowserWindowController awakeFromNib]):
3393         (-[WK1BrowserWindowController validateMenuItem:]):
3394         (-[WK1BrowserWindowController windowWillClose:]):
3395         (-[WK1BrowserWindowController find:]):
3396         (-[WK1BrowserWindowController dumpSourceToConsole:]):
3397         (-[WK1BrowserWindowController didChangeSettings]):
3398         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3399         (-[WK1BrowserWindowController isPaginated]): Deleted.
3400         (-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
3401         (-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
3402         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
3403         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
3404         (-[WK1BrowserWindowController layerBordersVisible]): Deleted.
3405         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
3406         * MiniBrowser/mac/WK2BrowserWindowController.m:
3407         (-[WK2BrowserWindowController awakeFromNib]):
3408         (-[WK2BrowserWindowController validateMenuItem:]):
3409         (-[WK2BrowserWindowController forceRepaint:]):
3410         (-[WK2BrowserWindowController windowWillClose:]):
3411         (-[WK2BrowserWindowController didChangeSettings]):
3412         (-[WK2BrowserWindowController isPaginated]): Deleted.
3413         (-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
3414         (-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
3415         (-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
3416         (-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
3417         (-[WK2BrowserWindowController layerBordersVisible]): Deleted.
3418         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
3419         (-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
3420         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
3421
3422 2014-08-01  Tim Horton  <timothy_horton@apple.com>
3423
3424         MiniBrowser doesn't support data URLs
3425         https://bugs.webkit.org/show_bug.cgi?id=135492
3426
3427         Reviewed by Simon Fraser.
3428
3429         * MiniBrowser/mac/BrowserWindowController.m:
3430         (-[BrowserWindowController addProtocolIfNecessary:]):
3431         Don't add http:// to data: URLs.
3432
3433         * MiniBrowser/mac/WK2BrowserWindowController.m:
3434         (-[WK2BrowserWindowController fetch:]):
3435         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
3436         Percent-escape the contents of the address field before trying to make a URL.
3437         Percent-unescape the URL when displaying it in the address field.
3438         This is not great, but trivial and good-enough-for-Minibrowser.
3439
3440 2014-07-31  Ryuan Choi  <ryuan.choi@samsung.com>
3441
3442         [EFL][WK2] MiniBrower comes to crash when combo box is pressed
3443         https://bugs.webkit.org/show_bug.cgi?id=135378
3444
3445         Reviewed by Gyuyoung Kim.
3446
3447         "clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
3448         and removes Ewk_Popup_Menu instance.
3449
3450         * MiniBrowser/efl/main.c:
3451         (on_popup_menu_show):
3452         (on_popup_menu_discarded): Deleted.
3453
3454 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
3455
3456         [Win] Use RC_PROJECTBUILDVERSION as build portion of version
3457         https://bugs.webkit.org/show_bug.cgi?id=135478
3458
3459         Reviewed by David Kilzer.
3460
3461         Add new test suite for the version-stamp program.
3462
3463         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
3464
3465 2014-07-31  Dan Bernstein  <mitz@apple.com>
3466
3467         Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
3468         which loads HTTPS content without calling the delegate.
3469
3470         Rubber-stamped by Alexey Proskuryakov.
3471
3472         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3473         (WTR::InjectedBundle::platformInitialize):
3474         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3475         (WTR::InjectedBundle::platformInitialize):
3476
3477 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
3478
3479         Unreviewed typo correction (and build fix).
3480
3481         * MiniBrowser/mac/WK2BrowserWindowController.m:
3482         (-[WK2BrowserWindowController awakeFromNib]): Use correct
3483         property name (_fullScreenIsEnabled -> _fullScreenEnabled)
3484
3485 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
3486
3487         MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
3488         https://bugs.webkit.org/show_bug.cgi?id=135482
3489
3490         Reviewed by Simon Fraser.
3491
3492         * MiniBrowser/mac/WK2BrowserWindowController.m:
3493         (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
3494         feature.
3495
3496 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
3497
3498         [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
3499         https://bugs.webkit.org/show_bug.cgi?id=135472
3500
3501         Reviewed by Dan Bernstein.
3502
3503         We now handle server trust challenges, and don't need such hacks.
3504
3505         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3506         (WTR::InjectedBundle::platformInitialize):
3507         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3508         (WTR::InjectedBundle::platformInitialize):
3509
3510 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
3511
3512         media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
3513         on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
3514         https://bugs.webkit.org/show_bug.cgi?id=135418
3515
3516         Reviewed by Anders Carlsson.
3517
3518         This was only happening in shared web process mode, because WKBundlePostMessage
3519         has different behavior then. When there is no process, the message is dropped on
3520         the floor in multiple process mode, but it's stored to be delivered after launch
3521         in shared process mode.
3522
3523         So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
3524         that was delivered immediately after launch, when there was nothing to reset.
3525
3526         We don't actually need to reset anything at this point, as the previous call has
3527         already reset everything UI process side, and web process is brand new. All we need
3528         is to reattach the page to a process, as invoke() expects one to exist.
3529
3530         * WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
3531         * WebKitTestRunner/TestController.h:
3532         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
3533
3534 2014-07-31  Dan Bernstein  <mitz@apple.com>
3535
3536         [WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
3537         https://bugs.webkit.org/show_bug.cgi?id=115282
3538
3539         Reviewed by Sam Weinig.
3540
3541         * WebKitTestRunner/TestController.cpp:
3542         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
3543         local host server trust protection space.
3544         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
3545         credential to server trust challenges.
3546
3547 2014-07-31  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3548
3549         [webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
3550         https://bugs.webkit.org/show_bug.cgi?id=135381
3551
3552         Reviewed by Csaba Osztrogonác.
3553
3554         * Scripts/webkitpy/port/base.py:
3555         (Port.diff_text):
3556         * Scripts/webkitpy/port/base_unittest.py:
3557         (PortTest.test_diff_text):
3558
3559 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3560
3561         Unreviewed. Fix GTK+ make distcheck.
3562
3563         * gtk/make-dist.py:
3564         (ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
3565         version to find the pkg-config file.
3566         * gtk/manifest.txt: Add missing resource to the tarball.
3567
3568 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3569
3570         [GTK] make distcheck is building from sources dir instead of dist dir
3571         https://bugs.webkit.org/show_bug.cgi?id=135457
3572
3573         Reviewed by Philippe Normand.
3574
3575         * gtk/make-dist.py:
3576         (Distcheck.configure): Use dist_dir as source dir.
3577         (Distcheck.check): Pass dist_dir to configure().
3578
3579 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3580
3581         [GTK] Do not include files that are not in git in the tarball
3582         https://bugs.webkit.org/show_bug.cgi?id=134804
3583
3584         Reviewed by Philippe Normand.
3585
3586         Skip all files in the source tree that are not under version control
3587         except for files added from the build dir like the documentation.
3588
3589         * gtk/make-dist.py:
3590         (Directory.__init__): Initialize the list of files under control version.
3591         (Directory.list_cms_files): Helper function to list all files
3592         under the control version for the current source root.
3593         (Directory.should_skip_file): Return True for files that are not
3594         under control version only when the source root is also under
3595         control version.
3596         (Directory.get_files): Filter the files also using should_skip_file().
3597
3598 2014-07-29  David Farler  <dfarler@apple.com>
3599
3600         iOS Simulator LayoutTestRelay
3601         https://bugs.webkit.org/show_bug.cgi?id=135269
3602
3603         Reviewed by David Kilzer.
3604
3605         * LayoutTestRelay/Configurations/Base.xcconfig: Added.
3606         * LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
3607         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
3608         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
3609         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
3610         (-[LTPipeRelay inPipePath]):
3611         (-[LTPipeRelay outPipePath]):
3612         (-[LTPipeRelay errorPipePath]):
3613         (-[LTPipeRelay outputStream]):
3614         (-[LTPipeRelay initWithPrefix:]):
3615         (-[LTPipeRelay setup]):
3616         (-[LTPipeRelay tearDown]):
3617         (-[LTPipeRelay connect]):
3618         (-[LTPipeRelay disconnect]):
3619         (-[LTPipeRelay createFIFOs]):
3620         (-[LTPipeRelay destroyFIFOs]):
3621         (-[LTPipeRelay relayStream:]):
3622         (-[LTPipeRelay stream:handleEvent:]):
3623         * LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
3624         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
3625         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.
3626         (-[LTRelayController uniqueAppPath]):
3627         (-[LTRelayController uniqueAppURL]):
3628         (-[LTRelayController uniqueAppIdentifier]):
3629         (-[LTRelayController processName]):
3630         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
3631         (-[LTRelayController readFileHandle:]):
3632         (-[LTRelayController receivedStandardOutputData:]):
3633         (-[LTRelayController receivedStandardErrorData:]):
3634         (-[LTRelayController disconnected]):
3635         (-[LTRelayController connected]):
3636         (-[LTRelayController crashWithMessage:]):
3637         (-[LTRelayController launchSimulator]):
3638         (-[LTRelayController bootDevice]):
3639         (-[LTRelayController createUniqueApp]):
3640         (-[LTRelayController killApp]):
3641         (-[LTRelayController launchApp]):
3642         (-[LTRelayController start]):
3643         * LayoutTestRelay/LayoutTestRelay/main.m: Added.
3644         (usage):
3645         (getTestingSimDevice):
3646         (getRequiredStringArgument):
3647         (getRemainderArguments):
3648         (main):
3649         * LayoutTestRelay/Makefile: Added.
3650         * Tools/Scripts/build-layouttestrelay: Added.
3651
3652 2014-07-29  Brent Fulgham  <bfulgham@apple.com>
3653
3654         [Win] Modify version numbering scheme to support 5-tuple versions
3655         https://bugs.webkit.org/show_bug.cgi?id=135400