build.webkit.org/dashboard: Cannot click on green tester bubbles
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
2
3         build.webkit.org/dashboard: Cannot click on green tester bubbles
4         https://bugs.webkit.org/show_bug.cgi?id=137909
5
6         Reviewed by Darin Adler.
7
8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
9         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
10
11 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
12
13         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
14         https://bugs.webkit.org/show_bug.cgi?id=137932
15
16         Reviewed by Simon Fraser.
17
18         This is the first step in moving over to native Windows rendering for our layout tests.
19         Once this change lands, approximately 300 tests will start failing on Windows. I will
20         rebaseline these changes against our test hardware and update this bug with the
21         commits related to that work.
22
23         * DumpRenderTree/win/DumpRenderTree.cpp:
24         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
25         we use native Windows drawing style.
26
27 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
28
29         Fix FTL Native Inlining for EFL
30         https://bugs.webkit.org/show_bug.cgi?id=137774
31
32         Reviewed by Michael Saboff.
33
34         Added Clang as an optional module to jhbuild.
35
36         * efl/jhbuild.modules:
37
38 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
39
40         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
41         https://bugs.webkit.org/show_bug.cgi?id=137832
42
43         Reviewed by Carlos Garcia Campos.
44
45         Ensure each test sets the TLS errors policy that it really needs.
46         Have each test except testTLSErrorsPolicy stash and restore the original
47         TLS errors policy. Update testTLSErrorsPolicy to account for the new
48         default policy.
49
50         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
51         (testSSL):
52         (testInsecureContent):
53         (testTLSErrorsPolicy):
54         (testTLSErrorsRedirect):
55         (testTLSErrorsHTTPAuth):
56         (testLoadFailedWithTLSErrors):
57         (beforeAll):
58
59 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
60
61         Unreviewed. Unskip inspector server unit tests.
62
63         They should pass now.
64
65         * Scripts/run-gtk-tests:
66         (TestRunner):
67
68 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
69
70         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
71         https://bugs.webkit.org/show_bug.cgi?id=132044
72
73         Reviewed by Brian Burg.
74
75         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
76         (openRemoteDebuggingSession): Remove trailing slash when
77         concatenating base inspector URL with the page, because the
78         inspector returns the relative paths with a leading slash.
79
80 2014-10-20  Tanay C  <tanay.c@samsung.com>
81
82         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
83         https://bugs.webkit.org/show_bug.cgi?id=137023
84
85         Reviewed by Gyuyoung Kim.
86
87         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
88         (search_box_show): Modified.
89         (search_box_hide): Modified.
90         (on_search_field_activated): Modified.
91         (on_search_backward_button_clicked): Modified.
92         (on_search_forward_button_clicked): Modified.
93         (on_search_case_option_changed): Added.
94         (on_search_word_start_option_changed): Added.
95         (window_create): Modified.
96
97 2014-10-20  Tanay C  <tanay.c@samsung.com>
98
99         [GTK][Minibrowser] Escape key does not hide the search box
100         https://bugs.webkit.org/show_bug.cgi?id=137734
101
102         Reviewed by Philippe Normand.
103
104         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
105         (stopPageLoad): Modified.
106
107 2014-10-18  Antti Koivisto  <antti@apple.com>
108
109         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
110         https://bugs.webkit.org/show_bug.cgi?id=137855
111
112         Reviewed by Dan Bernstein.
113
114         Test and warn if the dumped response mime type differs from the platform response mime type.
115
116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
117         (WTR::InjectedBundlePage::didReceiveResponseForResource):
118         (WTR::InjectedBundlePage::platformResponseMimeType):
119         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
120         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
121         (WTR::InjectedBundlePage::platformResponseMimeType):
122
123 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
124
125         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
126         https://bugs.webkit.org/show_bug.cgi?id=137835
127
128         Reviewed by Andreas Kling.
129
130         * Scripts/run-inspector-perf-tests.py: Removed.
131         This script is stale, as PerformanceTests/inspector no longer exists.
132
133 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
134
135         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
136
137         * Scripts/webkitpy/port/ios.py:
138         (IOSSimulatorPort.default_baseline_search_path):
139
140 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
141
142         [iOS] Simplify test fallback paths for iOS Simulator testing
143         https://bugs.webkit.org/show_bug.cgi?id=137830
144
145         Reviewed by Zalan Bujtas.
146         
147         Make the fallback paths be:
148             ios-simulator -> generic
149             ios-simulator-wk2->ios-simulator -> generic
150         
151         so don't include mac in the fallback path. Also remove the
152         version handling for simplicity.
153
154         * Scripts/webkitpy/port/ios.py:
155         (IOSSimulatorPort):
156         (IOSSimulatorPort.default_baseline_search_path):
157
158 2014-10-17  Dana Burkart  <dburkart@apple.com>
159
160         Fix typos in the dashboard config file.
161
162         Unreviewed.
163
164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
165         (WebKitBuildbot):
166
167 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
168
169         [Win] Allow WinLauncher to specify Custom User Agent strings
170         https://bugs.webkit.org/show_bug.cgi?id=137828
171
172         Reviewed by Dean Jackson.
173
174         * WinLauncher/Common.cpp: Add support for custom user agent strings.
175         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
176         and set the user agent strings.
177         * WinLauncher/WinLauncher.h:
178         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
179         resources and dialog for setting custom User Agent strings.
180         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
181
182 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
183
184         [iOS] Turn off font autosizing for iOS WebKitTestRunner
185         https://bugs.webkit.org/show_bug.cgi?id=137806
186
187         Reviewed by Sam Weinig.
188
189         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
190         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
191         to disable font autosizing.
192         
193         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
194         test controller to set platform-specific prefs.
195
196         * WebKitTestRunner/TestController.cpp:
197         (WTR::TestController::resetPreferencesToConsistentValues):
198         (WTR::TestController::platformResetPreferencesToConsistentValues):
199         * WebKitTestRunner/TestController.h:
200         * WebKitTestRunner/ios/TestControllerIOS.mm:
201         (WTR::TestController::platformResetPreferencesToConsistentValues):
202         * WebKitTestRunner/mac/TestControllerMac.mm:
203         (WTR::TestController::platformResetPreferencesToConsistentValues):
204
205 2014-10-16  Dan Bernstein  <mitz@apple.com>
206
207         OSObjectPtr is missing leakRef()
208         https://bugs.webkit.org/show_bug.cgi?id=137798
209
210         Reviewed by Sam Weinig.
211
212         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
213         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
214
215 2014-10-16  Lucas Forschler  <lforschler@apple.com>
216
217         Update target platform to remove Leopard, Snow Leopard, Lion.
218         Add Yosemite. 
219         
220         Unreviewed.
221
222         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
223         (_should_file_trigger_build):
224
225 2014-10-16  David Kilzer  <ddkilzer@apple.com>
226
227         commit-queue: fails to replace OO-PS! with reviewer name
228         <http://webkit.org/b/137795>
229
230         Reviewed by Alexey Proskuryakov.
231
232         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
233         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
234         email addresses to unauthenticated page loads, so we must always
235         authenticate before getting bug data so we get full email
236         addresses.
237
238 2014-10-16  David Kilzer  <ddkilzer@apple.com>
239
240         commit-queue: fails to close bugs after successfully landing patches
241         <http://webkit.org/b/137794>
242
243         Reviewed by Alexey Proskuryakov.
244
245         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
246         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
247         tell Mechanize to use the second <textarea> on the page with
248         name="comment".
249
250 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
251
252         [Win] Update DRT to match Mac Logic
253         https://bugs.webkit.org/show_bug.cgi?id=137787
254
255         Reviewed by Dean Jackson.
256
257         * DumpRenderTree/win/DumpRenderTree.cpp:
258         (initialize): 0 -> nullptr
259         (runTest): Initialize MSG structure before using.
260         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
261         Also, cleanly shut down COM when exiting.
262         * DumpRenderTree/win/FrameLoadDelegate.cpp:
263         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
264         header and add printf to match Mac.
265         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
266         * DumpRenderTree/win/FrameLoadDelegate.h:
267         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
268         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
269         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
270         (isLocalhost): Added.
271         (hostIsUsedBySomeTestsToGenerateError): Added.
272         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
273         of certain error and redirect host names.
274         * DumpRenderTree/win/UIDelegate.cpp:
275         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
276         anything should be output to the console. This modifies behavior to match the Mac.
277         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
278         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
279         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
280         (UIDelegate::webViewAddMessageToConsole): Ditto.
281         * WinLauncher/PageLoadTestClient.cpp:
282         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
283         added last week.
284
285 2014-10-16  Commit Queue  <commit-queue@webkit.org>
286
287         Unreviewed, rolling out r174754.
288         https://bugs.webkit.org/show_bug.cgi?id=137789
289
290         Speculative fix for Windows test was ineffective. (Requested
291         by rfong on #webkit).
292
293         Reverted changeset:
294
295         "[Windows] Add some more logging to debug Windows test
296         issues."
297         http://trac.webkit.org/changeset/174754
298
299 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
300
301         Unreviewed, add myself to CoordinatedGraphics watchers.
302
303         * Scripts/webkitpy/common/config/watchlist:
304
305 2014-10-15  Roger Fong  <roger_fong@apple.com>
306
307         [Windows] Speculative Windows test fix.
308
309         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
310
311 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
312
313         import-w3c-test rewrites relative src paths in ref files incorrectly
314         https://bugs.webkit.org/show_bug.cgi?id=137586
315
316         This patch fixes a bug in test_converter.py where src paths were getting 
317         rewritten as ../../some-path instead of <script src="../../some-path>". 
318         It also adds support for rewriting src paths in style  elements, which was 
319         missing before and it adds tests for this case.
320
321         Reviewed by Bem Jones-Bey.
322
323         * Scripts/webkitpy/w3c/test_converter.py:
324         (_W3CTestConverter.convert_attributes_if_needed):
325         * Scripts/webkitpy/w3c/test_converter_unittest.py:
326         (test_convert_attributes_if_needed):
327         (verify_reference_relative_paths):
328
329 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
330
331         Add --json flag to test-webkitpy to emit JSON formatted test results
332         to stdout
333         https://bugs.webkit.org/show_bug.cgi?id=137353
334
335         Reviewed by Daniel Bates.
336
337         * Scripts/webkitpy/port/server_process_unittest.py:
338         Adds the read method to MockFile to allow the stdout of test_webkitpy
339         to be redirected without causing erroneous test failures.
340         In particular,
341         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
342         and
343         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
344         because when redirecting to a file, the
345         _wait_for_data_and_update_buffers_using_select method in 
346         server_process.py will find that there is a read file descriptor in
347         its call to select.select, which eventually leads to it calling read()
348         on the MockFile object.
349         (MockFile.read):
350         * Scripts/webkitpy/test/main.py:
351         Adds the _print_results_as_json method and the --json flag which
352         determines whether _print_results_as_json will get called.
353         (Tester._parse_args):
354         (Tester._print_results_as_json):
355         (Tester._print_results_as_json.result_dict_from_tuple):
356         (Tester._run_tests):
357
358 2014-10-13  David Farler  <dfarler@apple.com>
359
360         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
361         https://bugs.webkit.org/show_bug.cgi?id=137662
362
363         Reviewed by Darin Adler.
364
365         The layout test harness can close LayoutTestRelay's subprocess
366         stdout and stderr in the case of a timeout or if a run is
367         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
368         finds that no one is listening to its stdout/stderr (broken
369         pipe), then just exit(1), there is nothing to report.
370
371         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
372         (-[LTRelayController didReceiveStdoutData:]):
373         Add @try/@catch for NSFileHandleOperationException.
374         (-[LTRelayController didReceiveStderrData:]):
375         Add @try/@catch for NSFileHandleOperationException.
376
377 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
378
379         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
380         https://bugs.webkit.org/show_bug.cgi?id=137060
381
382         Reviewed by Philippe Normand.
383
384         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
385
386         * MiniBrowser/gtk/BrowserWindow.c:
387         (zoomInCallback):
388         (zoomOutCallback):
389         (defaultZoomCallback): Callback for default zoom keyboard support.
390         (browser_window_init):
391
392 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
393
394         [Mac] DRT stderr logging after the test completes gets attributed to the next test
395
396         Reviewed by Alexey Proskuryakov.
397         
398         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
399         logging to stderr to get associated with the next test.
400         
401         Fix by logging #EOF to stderr later, after we've completely finished with this test.
402
403         * DumpRenderTree/mac/DumpRenderTree.mm:
404         (dumpTestResults):
405         (runTest):
406
407 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
408
409         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
410
411         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
412
413 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
414
415         [cmake] Fix the make build after r174683
416         https://bugs.webkit.org/show_bug.cgi?id=137703
417
418         Reviewed by Martin Robinson.
419
420         * Scripts/webkitdirs.pm:
421         (buildCMakeGeneratedProject):
422
423 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
424
425         Adding myself to the watchlist to CachedFont
426
427         Unreviewed.
428
429         * Scripts/webkitpy/common/config/watchlist:
430
431 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
432
433         [EFL][GTK] Make it possible to get verbose output with ninja
434         https://bugs.webkit.org/show_bug.cgi?id=137606
435
436         Reviewed by Csaba Osztrogonác.
437
438         * Scripts/webkitdirs.pm:
439         (buildCMakeGeneratedProject):
440
441 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
442
443         [EFL] Make it possible to use ninja for EFL build too
444         https://bugs.webkit.org/show_bug.cgi?id=137605
445
446         Reviewed by Csaba Osztrogonác.
447
448         * Scripts/webkitdirs.pm:
449         (generateBuildSystemFromCMakeProject):
450         * efl/install-dependencies:
451
452 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
453
454         [GTK] Minibrowser : Add home buton and keyboard support for home page load
455         https://bugs.webkit.org/show_bug.cgi?id=137486
456
457         Reviewed by Philippe Normand.
458
459         * MiniBrowser/gtk/BrowserWindow.c:
460         (loadHomePage): Callback for home page load.
461         (browser_window_init):
462         * MiniBrowser/gtk/BrowserWindow.h:
463         * MiniBrowser/gtk/main.c:
464         (main):
465
466 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
467
468         import-w3c-tests doesn't prefix property values
469         https://bugs.webkit.org/show_bug.cgi?id=137600
470
471         Reviewed by Bem Jones-Bey.
472
473         Some property values are prefixed in WebKit. Modified the W3C import
474         script in order to prefix property values and not only properties.
475         The patch re-uses most of the already existent logic to prefix
476         properties.
477
478         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
479         from CSSValueKeywords.in and adapt converter to modify both properties
480         and property values.
481         (convert_for_webkit):
482         (_W3CTestConverter.__init__):
483         (_W3CTestConverter.output):
484         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
485         (_W3CTestConverter):
486         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
487         (_W3CTestConverter.add_webkit_prefix_following_regex):
488         (_W3CTestConverter.convert_reference_relpaths):
489         (_W3CTestConverter.convert_style_data):
490         (_W3CTestConverter.convert_attributes_if_needed):
491         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
492         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
493         include checks for property values too.
494         (W3CTestConverterTest.test_read_prefixed_property_list):
495         (verify_no_conversion_happened):
496         (verify_prefixed_properties):
497         (verify_prefixed_property_values):
498         (generate_test_content_properties_and_values):
499         (generate_test_content):
500         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
501         prefixed property values and inform about them.
502         (TestImporter.import_tests):
503         (TestImporter.write_import_log):
504
505 2014-10-13  Jer Noble  <jer.noble@apple.com>
506
507         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
508         https://bugs.webkit.org/show_bug.cgi?id=137533
509
510         Reviewed by Andy Estes.
511
512         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
513
514         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
515         (TestWebKitAPI::isMSEEnabledCallback):
516         (TestWebKitAPI::TEST):
517
518 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
519
520         [Win] Implement a page load profiling tool
521         https://bugs.webkit.org/show_bug.cgi?id=137673
522
523         Reviewed by Dean Jackson.
524
525         Add a tool to capture and summarize page load statistics.
526
527         * WinLauncher/Common.cpp:
528         (parseCommandLine): Move from WinMain.cpp so that it can
529         be shared with internal tools.
530         * WinLauncher/PageLoadTestClient.cpp: Added.
531         (PageLoadTestClient::PageLoadTestClient):
532         (PageLoadTestClient::pageLoadStartedAtTime):
533         (PageLoadTestClient::didStartProvisionalLoad):
534         (PageLoadTestClient::didCommitLoad):
535         (PageLoadTestClient::didFirstLayoutForMainFrame):
536         (PageLoadTestClient::didHandleOnLoadEvents):
537         (PageLoadTestClient::didFinishLoad):
538         (PageLoadTestClient::didFailLoad):
539         (PageLoadTestClient::didInitiateResourceLoad):
540         (PageLoadTestClient::didEndResourceLoad):
541         (PageLoadTestClient::pageLoadEndedAtTime):
542         (PageLoadTestClient::endPageLoad):
543         (PageLoadTestClient::clearPageLoadState):
544         (PageLoadTestClient::shouldConsiderPageLoadEnded):
545         (PageLoadTestClient::maybeEndPageLoadSoon):
546         (PageLoadTestClient::setPageURL):
547         (PageLoadTestClient::dumpRunStatistics):
548         * WinLauncher/PrintWebUIDelegate.cpp:
549         (PrintWebUIDelegate::createWebViewWithRequest): Handle
550         nullptr URL properly.
551         * WinLauncher/ResourceLoadDelegate.cpp: Added.
552         (ResourceLoadDelegate::QueryInterface):
553         (ResourceLoadDelegate::AddRef):
554         (ResourceLoadDelegate::Release):
555         (ResourceLoadDelegate::identifierForInitialRequest):
556         (ResourceLoadDelegate::willSendRequest):
557         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
558         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
559         (ResourceLoadDelegate::didReceiveResponse):
560         (ResourceLoadDelegate::didReceiveContentLength):
561         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
562         (ResourceLoadDelegate::didFailLoadingWithError):
563         (ResourceLoadDelegate::plugInFailedWithError):
564         * WinLauncher/ResourceLoadDelegate.h: Added.
565         (ResourceLoadDelegate::ResourceLoadDelegate):
566         * WinLauncher/WinLauncher.cpp:
567         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
568         page loading statistics.
569         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
570         and set private load delegate state.
571         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
572         that sets the view's resource load delegate.
573         (WinLauncher::loadURL): If no URL is passed, load the test document.
574         * WinLauncher/WinLauncher.h:
575         (WinLauncher::pageLoadTestClient):
576         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
577         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
578         * WinLauncher/WinLauncherWebHost.cpp:
579         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
580         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
581         it could be used from other source files.
582         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
583         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
584         (WinLauncherWebHost::didFailLoadWithError): Ditto.
585         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
586         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
587         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
588         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
589         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
590         * WinLauncher/WinLauncherWebHost.h:
591         * WinLauncher/WinMain.cpp:
592         (wWinMain): Create and use new delegates for gathering page load data.
593         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
594
595 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
596
597         Improve the test image diffs page
598         https://bugs.webkit.org/show_bug.cgi?id=137674
599
600         Reviewed by Alexey Proskuryakov.
601         
602         Don't treat the input file as a format string, otherwise we have to escape special
603         characters. Just do a couple of replaces.
604
605         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
606         (TestResultWriter.write_image_diff_files):
607
608 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
609
610         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
611         https://bugs.webkit.org/show_bug.cgi?id=137659
612
613         Reviewed by Martin Robinson.
614
615         * Scripts/webkitpy/port/xvfbdriver.py:
616         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
617
618 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
619
620         Add more detailed wait time information to EWS metrics
621         https://bugs.webkit.org/show_bug.cgi?id=137649
622
623         Reviewed by Daniel Bates.
624
625         Added average and worst time (we used to only have median), and also a percentage
626         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
627
628         There is always some wait due to the polling nature of the queues, which is well understood
629         and doesn't need to be measured. What needs to be measured is whether there is enough
630         bot machines to process patches as soon as they are submitted.
631
632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
633         (Analyzer.prototype._analyzeBubblePerformance):
634         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
635         (MetricsBubbleView.prototype._update):
636
637 2014-10-11  Jer Noble  <jer.noble@apple.com>
638
639         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
640         https://bugs.webkit.org/show_bug.cgi?id=137533
641
642         Reviewed by Darin Adler.
643
644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
645         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
646         (TestWebKitAPI::TEST):
647         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
648         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
649
650 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
651
652         iOS DRT snapshots are limited to the page visible area
653         https://bugs.webkit.org/show_bug.cgi?id=137650
654
655         Reviewed by Daniel Bates.
656         
657         LegacyTileCache drawing was limited to the window's visible area, found by
658         crawling up the layer hierarchy to the root layer. This caused test snapshots to
659         be missing non-composited content outside the iPhone visible area, which hinders
660         testing.
661         
662         Fix by adding a test-only mode where the window visible area is the entire window.
663         
664         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
665         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
666         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
667         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
668         for the DRT window.
669         
670
671 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
672
673         Page not fully rendered in iOS DRT snapshots
674         https://bugs.webkit.org/show_bug.cgi?id=137638
675
676         Reviewed by Tim Horton.
677         
678         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
679         to ensure that the page has laid out and is rendered by the time we take
680         the snapshot.
681
682         * DumpRenderTree/mac/DumpRenderTree.mm:
683         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
684         (-[DumpRenderTree _webThreadInvoked]): Moved.
685         (-[DumpRenderTree _waitForWebThreadThenDump]):
686         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
687         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
688         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
689         relies on dispatch_async too, and the inner block won't complete until the outer block
690         has completed.
691         (dumpTestResults): Move the guts of dump() here.
692         (runTest): Whitespace.
693
694 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
695
696         Adding svn:ignore so that .pyc files don't show up as new.
697
698         * Scripts/webkitpy/xcode: Added property svn:ignore.
699
700 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
701
702         [EFL] Introduce EWebKit_Extension
703         https://bugs.webkit.org/show_bug.cgi?id=134921
704
705         Reviewed by Gyuyoung Kim.
706
707         * MiniBrowser/efl/main.c: Added x option to test extension path.
708         (window_create):
709         (elm_main):
710         * Scripts/webkitpy/common/config/watchlist:
711         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
712         * Scripts/webkitpy/style/checker.py:
713         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
714
715 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
716
717         After r174628 we send the test process a SIGTERM before the SIGKILL.
718
719         * Scripts/webkitpy/common/system/executive_unittest.py:
720         (ExecutiveTest.serial_test_kill_process):
721
722 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
723
724         [EFL] Enable WebP support.
725         https://bugs.webkit.org/show_bug.cgi?id=136156
726
727         Reviewed by Gyuyoung Kim.
728
729         Include libwebp-dev package to support WebP for WK2 Efl.
730
731         * efl/install-dependencies:
732
733 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
734
735         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
736         https://bugs.webkit.org/show_bug.cgi?id=137485
737
738         Reviewed by Sergio Villar Senin.
739
740         Update GMainLoopSource tests. Most of the tests are now run twice,
741         first with a GMainLoopSource and then with a
742         GThreadSafeMainLoopSource, since both should have the same
743         behaviour. The threading test uses GThreadSafeMainLoopSource and
744         the delete on destroy test uses GMainLoopSource. The tests
745         themselves haven't changed, since there's no change in behaviour.
746
747         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
748         (TestWebKitAPI::GMainLoopSourceTest::source):
749         (TestWebKitAPI::basicRescheduling):
750         (TestWebKitAPI::TEST):
751         (TestWebKitAPI::reentrantRescheduling):
752         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
753         (TestWebKitAPI::basicDestroyCallbacks):
754         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
755         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
756
757 2014-10-10  Dana Burkart  <dburkart@apple.com>
758
759         Fix fat-fingered function name in git-add-reviewer.
760
761         Unreviewed.
762
763         * Scripts/git-add-reviewer:
764         (getConfigValue):
765
766 2014-10-10  David Farler  <dfarler@apple.com>
767
768         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
769         https://bugs.webkit.org/show_bug.cgi?id=137528
770
771         Reviewed by Simon Fraser.
772
773         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
774         and SIGKILL the paired simulator app before exiting cleanly.
775
776         webkitpy only uses SIGKILL to kill processes which you cannot
777         catch. Send SIGTERM to the process and give it chance to do
778         its thing before sending SIGKILL. Sending a SIGKILL to an already
779         dead PID is safe.
780
781         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
782         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
783         (-[LTRelayController finish]):
784         * LayoutTestRelay/LayoutTestRelay/main.m:
785         (receivedSignal):
786         (main):
787
788 2014-10-10  David Farler  <dfarler@apple.com>
789
790         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
791         https://bugs.webkit.org/show_bug.cgi?id=137527
792
793         Reviewed by Simon Fraser.
794
795         NSFileHandle doesn't notify of EOF in its readability handler.
796         Use a dispatch_source_t and an event handler that is called when reading is possible.
797         In the handler block, do a run-of-the-mill read(2) from standard input and
798         detect EOF in the usual way by checking that zero bytes were read.
799
800         Once an EOF is received, the FIFOs are disconnected, the simulator app
801         is killed, and the relay exits with status 0.
802
803         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
804         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
805         (-[LTRelayController didDisconnect]):
806         (-[LTRelayController didConnect]):
807         (-[LTRelayController launchApp]):
808         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
809         confusion with this new dispatch source, called "standardInputDispatchSource".
810         (-[LTRelayController finish]): Added.
811         (-[LTRelayController readFileHandle:]): Deleted.
812
813 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
814
815         [EFL] Crash on facebook.com
816         https://bugs.webkit.org/show_bug.cgi?id=137562
817
818         Reviewed by Chris Dumez.
819
820         Crash occurs on the facebook.com when the webview is resized
821         after the <select> item is clicked but no item is chosen.
822         This crash is just caused by the reference of invalidated variable.
823         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
824         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
825         on MiniBrowser is called.
826         As a result, just set ewk_menu to NULL in order to prevent crash condition.
827
828         * MiniBrowser/efl/main.c:
829         (on_popup_menu_hide):
830
831 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
832
833         A small wording change for clarity.
834
835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
836         (MetricsBubbleView.prototype._update):
837
838 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
839
840         Dashboard metrics page should have EWS statistics
841         https://bugs.webkit.org/show_bug.cgi?id=137626
842
843         Reviewed by Ryosuke Niwa.
844
845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
846         (BubbleQueue): Put shortName in the object, so that it's actually useful.
847
848         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
849         (BubbleQueueServer): Re-ordered queues to match bubble order.
850         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
851         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
852
853         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
854         Added analysis for bubble queues.
855
856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
857
858         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
859         (buildBubbleQueuesTable): Build the UI.
860
861         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
862         Added JS sources to load.
863
864         * QueueStatusServer/app.yaml: To update app version.
865
866         * QueueStatusServer/handlers/processingtimesjson.py: Added.
867
868         * QueueStatusServer/main.py: Added a handler for processing-times-json.
869
870 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
871
872         REGRESSION: Commit queue doesn't process rollouts
873         https://bugs.webkit.org/show_bug.cgi?id=137623
874
875         Reviewed by Tim Horton.
876
877         * QueueStatusServer/app.yaml:
878         * QueueStatusServer/handlers/updateworkitems.py:
879         (UpdateWorkItems._work_items_from_request):
880
881 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
882
883         Fix syntax error after r174601.
884
885         * Scripts/run-javascriptcore-tests:
886
887 2014-10-10  Michael Saboff  <msaboff@apple.com>
888
889         Add ability to select tarfile name in run-jsc-stress-tests
890         https://bugs.webkit.org/show_bug.cgi?id=137614
891
892         Reviewed by Mark Hahnenberg.
893
894         Added optional file name argument to the --tarball option.  
895
896         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
897         extra test given after the options wont be used for the optional tarball file name.
898         * Scripts/run-jsc-stress-tests:
899
900 2014-10-10  Chris Dumez  <cdumez@apple.com>
901
902         Unreviewed, update my information in contributors.json
903
904         Use my preferred first name and update my expertise areas.
905
906         * Scripts/webkitpy/common/config/contributors.json:
907
908 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
909
910         Fix perl scripts to run with env on Linux
911         https://bugs.webkit.org/show_bug.cgi?id=137601
912
913         Reviewed by Csaba Osztrogonác.
914
915         Use of arguments in #! is nonstandard and does not behave the same on
916         different systems. Linux would look for an executable named "perl -w" 
917         "use warnings;" does the same things in a more portable way.
918
919         * Scripts/commit-log-editor:
920         * Scripts/num-cpus:
921         * Scripts/prepare-ChangeLog:
922         * Scripts/run-launcher:
923         * Scripts/svn-create-patch:
924
925 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
926
927         [jhbuild] We should be able to disable wiping on configuration change
928         https://bugs.webkit.org/show_bug.cgi?id=137446
929
930         Reviewed by Csaba Osztrogonác.
931
932         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
933         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
934         or passing --no-wipe-on-change command line option.
935
936         * Scripts/update-webkit-libs-jhbuild:
937
938 2014-10-09  Andy Estes  <aestes@apple.com>
939
940         Teach webkitpy about OS X Yosemite
941         https://bugs.webkit.org/show_bug.cgi?id=137585
942
943         Reviewed by Simon Fraser.
944
945         * Scripts/webkitpy/common/system/platforminfo.py:
946         (PlatformInfo._determine_mac_version):
947         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
948         (TestPlatformInfo.test_os_version):
949         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
950         (TestExpectationParser):
951         * Scripts/webkitpy/port/builders.py:
952         * Scripts/webkitpy/port/mac.py:
953         (MacPort):
954         * Scripts/webkitpy/port/mac_unittest.py:
955         (test_versions):
956         (test_baseline_search_path):
957         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
958         (TestRebaselineTest.test_baseline_directory):
959         (TestRebaselineExpectations.test_rebaseline_expectations):
960
961 2014-10-09  Dana Burkart  <dburkart@apple.com>
962
963         Add Mac OS Yosemite dashboard support.
964
965         Rubber-stamped by Lucas Forschler.
966
967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
972
973 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
974
975         Add Babak to contributors.json and add historical email addresses for some contributors
976         https://bugs.webkit.org/show_bug.cgi?id=137546
977
978         Reviewed by Christophe Dumez.
979
980         contributors.json is used to analyze historical commit data and change logs.
981
982         Add back historical email addresses for some contributors and also add Babak (Shafiei).
983
984         * Scripts/webkitpy/common/config/contributors.json:
985
986 2014-10-09  Lucas Forschler  <lforschler@apple.com>
987
988         Add Mac OS Yosemite webkit build infrastructure.
989         
990         This patch adds 15 bots to our build.webkit.org configuration.
991         We are matching the current Mavericks machines 1:1.
992         
993         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
994         
995         Reviewed by Matt Hanson.
996
997         * BuildSlaveSupport/build.webkit.org-config/config.json:
998
999 2014-10-09  Dana Burkart  <dburkart@apple.com>
1000
1001         Don't use backticks when running commands, as we run into sh-related
1002         interpolation issues. Also, fix our usage of system() to properly
1003         retrieve the status code.
1004         https://bugs.webkit.org/show_bug.cgi?id=137541
1005
1006         Reviewed by Darin Adler.
1007
1008         * Scripts/git-add-reviewer:
1009         (interactive):
1010         (nonInteractive):
1011         (requireCleanWorkTree):
1012         (cherryPick):
1013         (commit):
1014         (addReviewerToFile):
1015         (head):
1016         (isAncestor):
1017         (toCommit):
1018         (changeLogsForCommit):
1019         (resetToCommit):
1020         (getConfigValue):
1021         (runCommandWithOutput):
1022
1023 2014-10-09  Tim Horton  <timothy_horton@apple.com>
1024
1025         Add a WebKit1 preference for selection services
1026         https://bugs.webkit.org/show_bug.cgi?id=137498
1027         <rdar://problem/18572699>
1028
1029         Reviewed by Simon Fraser.
1030
1031         * MiniBrowser/mac/WK1BrowserWindowController.m:
1032         (-[WK1BrowserWindowController awakeFromNib]):
1033         Turn on image and selection services in the Legacy WebKit MiniBrowser.
1034
1035 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
1036
1037         Get the patch scripts running on Haiku
1038         https://bugs.webkit.org/show_bug.cgi?id=137559
1039
1040         Reviewed by Benjamin Poulain.
1041
1042         Use /usr/bin/env instead of hardcoding path to perl.
1043         Declare haiku platform in platforminfo.py to avoid check-webkit-style
1044         failure.
1045
1046         * Scripts/commit-log-editor:
1047         * Scripts/num-cpus:
1048         * Scripts/prepare-ChangeLog:
1049         * Scripts/run-launcher:
1050         * Scripts/svn-create-patch:
1051         * Scripts/webkitpy/common/system/platforminfo.py:
1052         (PlatformInfo._determine_os_name):
1053
1054 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
1055
1056         StyleQueue should throw a PatchIsNotValid exception to achieve
1057         consistency with CommitQueue and EWS
1058         https://bugs.webkit.org/show_bug.cgi?id=137500
1059
1060         Reviewed by Alexey Proskuryakov.
1061
1062         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1063         Adds a call to validate() in run().
1064         (StyleQueueTask.run):
1065         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1066         Adds a return False in the patch is not valid exception statement.
1067         (AbstractEarlyWarningSystem.review_patch):
1068         * Scripts/webkitpy/tool/commands/queues.py:
1069         Adds a return False in the patch is not valid exception statement in
1070         commit queue, and adds an except statement to catch PatchIsNotValid
1071         exceptions in style queue.
1072         (CommitQueue.process_work_item):
1073         (StyleQueue.review_patch):
1074
1075 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1076
1077         Race condition with WebKitWebView:is-loading after starting page load
1078         https://bugs.webkit.org/show_bug.cgi?id=136692
1079
1080         Reviewed by Gustavo Noronha Silva.
1081
1082         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1083         (loadChangedCallback): Only check is-loading is false when load
1084         has finished if the load didn't fail due to a cancellation.
1085         (loadFailedCallback): Only check is-loading is false if the load
1086         didn't fail due to a cancellation.
1087         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1088         (WebViewTest::loadURI): Check is-loading is true and active URI is
1089         the requested one rigth after requesting the load.
1090         (WebViewTest::loadHtml): Ditto.
1091         (WebViewTest::loadPlainText): Ditto.
1092         (WebViewTest::loadBytes): Ditto.
1093         (WebViewTest::loadRequest): Ditto.
1094         (WebViewTest::loadAlternateHTML): Ditto.
1095         (WebViewTest::goBack): Ditto.
1096         (WebViewTest::goForward): Ditto.
1097         (WebViewTest::goToBackForwardListItem): Ditto.
1098
1099 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
1100
1101         [Win] Resolve various static analyzer warnings in Tools.
1102         https://bugs.webkit.org/show_bug.cgi?id=137534
1103
1104         Reviewed by Dean Jackson.
1105
1106         * DumpRenderTree/cg/ImageDiffCG.cpp:
1107         (main): User proper printf specifiers.
1108         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1109         (AccessibilityUIElement::childrenCount): Handle possibility that
1110         gcc_accChildCount returns with an error.
1111         (accessibilityState): Ditto for gcc_accState.
1112         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1113         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
1114         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
1115         be treated as such.
1116         * DumpRenderTree/win/DumpRenderTree.cpp:
1117         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
1118         by comparing an unsigned value as being greater-than zero.
1119         * DumpRenderTree/win/EditingDelegate.cpp:
1120         (dump): Pass proper character pointer type to printf.
1121         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
1122         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1123         (EditingDelegate::shouldInsertNode): Ditto.
1124         (EditingDelegate::shouldInsertText): Ditto.
1125         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1126         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1127         (EditingDelegate::shouldApplyStyle): Ditto.
1128         * DumpRenderTree/win/EventSender.cpp:
1129         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
1130         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
1131         system headers.
1132         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
1133         from CreateDIBSection.
1134         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
1135         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
1136         older versions of MSVC we no longer support.
1137         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
1138         for 64-bit builds.
1139         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
1140         * TestWebKitAPI/TestsController.h: Ditto.
1141         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
1142         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
1143         performing bitwise | before the comparison is done.
1144
1145 2014-10-08  Ada Chan  <adachan@apple.com>
1146
1147         Add a test for WKPageIsPlayingAudio().
1148         https://bugs.webkit.org/show_bug.cgi?id=137048
1149
1150         Reviewed by Darin Adler.
1151
1152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1153         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
1154         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
1155         (TestWebKitAPI::nullJavaScriptCallback):
1156         (TestWebKitAPI::didFinishLoadForFrame):
1157         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
1158         (TestWebKitAPI::setUpClients):
1159         (TestWebKitAPI::TEST):
1160         This test loads a page with a video in it. When the page is loaded, we first check that
1161         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
1162         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
1163         now returns true for the page.
1164         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
1165         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
1166         This is a video copied from LayoutTests/media/content.
1167
1168 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
1169
1170         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
1171         https://bugs.webkit.org/show_bug.cgi?id=137516
1172
1173         Reviewed by Alexey Proskuryakov.
1174
1175         * Scripts/webkitpy/thirdparty/__init__.py:
1176         (AutoinstallImportHook._install_irc):
1177
1178 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1179
1180         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
1181         https://bugs.webkit.org/show_bug.cgi?id=137520
1182
1183         Reviewed by Philippe Normand.
1184
1185         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
1186         For other distributions, we are already installing libjpeg-turbo.
1187         So, do the same for Debian and derivatives.
1188
1189         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
1190
1191 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1192
1193         [webkitpy] Add back the workaround to replace ZipFile.extractall()
1194         https://bugs.webkit.org/show_bug.cgi?id=137519
1195
1196         Reviewed by Csaba Osztrogonác.
1197
1198         It was removed by <http://trac.webkit.org/changeset/174266>,
1199         because the comment stated it is a workaround for buggy python
1200         2.6.1 which shipped on Snow Leopard. But it turned out the bug
1201         is still valid with python 2.7 shipped on the latest Ubuntu
1202         (12.04 and 14.04) and OS X 10.9.
1203
1204         * Scripts/webkitpy/common/system/autoinstall.py:
1205         (AutoInstaller):
1206         (AutoInstaller._extract_all):
1207         (AutoInstaller._unzip):
1208
1209 2014-10-08  Commit Queue  <commit-queue@webkit.org>
1210
1211         Unreviewed, rolling out r174335.
1212         https://bugs.webkit.org/show_bug.cgi?id=137515
1213
1214         It broke EFL layout test totally (Requested by gyuyoung on
1215         #webkit).
1216
1217         Reverted changeset:
1218
1219         "[EFL] Introduce EWebKit_Extension"
1220         https://bugs.webkit.org/show_bug.cgi?id=134921
1221         http://trac.webkit.org/changeset/174335
1222
1223 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1224
1225         [GTK] Make forwarding headers generation depend on source code
1226         https://bugs.webkit.org/show_bug.cgi?id=137394
1227
1228         Reviewed by Philippe Normand.
1229
1230         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
1231         * TestWebKitAPI/PlatformGTK.cmake: Only run
1232         generate-forwarding-headers.pl when source code changes.
1233         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
1234
1235 2014-10-07  Tanay C  <tanay.c@samsung.com>
1236
1237         Remove build warnings in Hashmap API tests
1238         https://bugs.webkit.org/show_bug.cgi?id=137484
1239
1240         Reviewed by Darin Adler.
1241
1242         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1243         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
1244
1245 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
1246
1247         Commit queue doesn't drop obsolete patches sometimes
1248         https://bugs.webkit.org/show_bug.cgi?id=137460
1249
1250         Reviewed by Alexey Proskuryakov.
1251
1252         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1253         Adds another test patch for use in queues_unittest.py.
1254         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1255         (MockBugzilla):
1256         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1257         Raises a PatchIsNotValid exception in the case of validate() returning
1258         false.
1259         (CommitQueueTask.run):
1260         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1261         Raises a PatchIsNotValid exception in the case of validate() returning
1262         false.
1263         (EarlyWarningSystemTask.run):
1264         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1265         Defines PatchIsNotValid exception. 
1266         (PatchIsNotValid):
1267         (PatchIsNotValid.__init__):
1268         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1269         Remove call to validate() and instead catches the PatchIsNotValid
1270         exception.
1271         (AbstractEarlyWarningSystem.review_patch):
1272         * Scripts/webkitpy/tool/commands/queues.py:
1273         Adds logic to catch the PatchIsNotValid exception.
1274         (CommitQueue.process_work_item):
1275         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1276         Adds the test_non_valid_patch test to ensure that invalid patches are
1277         handled properly, and don't just result in indefinite spinning.
1278         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1279         (test_non_valid_patch):
1280
1281 2014-10-07  Daniel Bates  <dabates@apple.com>
1282
1283         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
1284         https://bugs.webkit.org/show_bug.cgi?id=137499
1285
1286         Reviewed by Simon Fraser.
1287
1288         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
1289         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
1290         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
1291         bit simulator builds of iOS WebKit.
1292
1293         * Scripts/webkitpy/port/ios.py:
1294         (IOSSimulatorPort._generate_all_test_configurations):
1295
1296 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1297
1298         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
1299         https://bugs.webkit.org/show_bug.cgi?id=137482
1300
1301         Reviewed by Martin Robinson.
1302
1303         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
1304
1305 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1306
1307         [SOUP] TLS errors should take precedence over HTTP authentication
1308         https://bugs.webkit.org/show_bug.cgi?id=137300
1309
1310         Reviewed by Sergio Villar Senin.
1311
1312         Add a test case to check that authenticate signal is not emitted
1313         in case of TLS errors, and the load fails instead.
1314
1315         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1316         (webViewAuthenticationCallback):
1317         (testTLSErrorsHTTPAuth):
1318         (httpsServerCallback):
1319         (beforeAll):
1320
1321 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
1322
1323         Make webkit-patch find-users useful
1324         https://bugs.webkit.org/show_bug.cgi?id=137475
1325
1326         Reviewed by Alexey Proskuryakov.
1327
1328         Make find-users use the CommitterList instead of accessing Bugzilla.
1329
1330         This essentially exposes the same functionality as webkitbot's whois command.
1331
1332         * Scripts/webkitpy/tool/commands/findusers.py:
1333         (FindUsers.execute):
1334
1335 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
1336
1337         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
1338         https://bugs.webkit.org/show_bug.cgi?id=137289
1339
1340         Unreviewed build fix.
1341
1342         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1343         (AccessibilityUIElement::getChildrenWithRange):
1344
1345 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1346
1347         build.webkit.org/dashboard: Add commit queue
1348         https://bugs.webkit.org/show_bug.cgi?id=137462
1349
1350         Reviewed by Tim Horton.
1351
1352         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
1353         Style queue is still invisible, as it doesn't have an associated platform, and also
1354         we never have problems with it anyway, so it's not worth watching.
1355
1356         The UI now allows for adding more bots to the Other column (such as leaks bot).
1357         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
1358         sources of data in a cell.
1359
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
1361         (BubbleQueue):
1362         (BubbleQueue.prototype.get statusPageURL):
1363         (BubbleQueue.prototype.update):
1364         (BubbleQueue.prototype.loadDetailedStatus):
1365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
1366         (BubbleQueueServer):
1367         (BubbleQueueServer.prototype.jsonQueueLengthURL):
1368         (BubbleQueueServer.prototype.jsonQueueStatusURL):
1369         (BubbleQueueServer.prototype.queueStatusURL):
1370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
1371         (BubbleQueueView):
1372         (BubbleQueueView.prototype.update.appendQueue):
1373         (BubbleQueueView.prototype.update):
1374         (BubbleQueueView.prototype._addQueueHeadingToPopover):
1375         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
1376         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
1377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
1378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
1379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
1380         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1383         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
1384         (.bubble-server-popover .latest-status-no-link):
1385         (.bubble-server-popover .bot-status-description):
1386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1387
1388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1389         (buildAggregateTable):
1390         (buildQueuesTable):
1391         Removed dysfunctional support for EWS for now. It will be different.
1392
1393 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1394
1395         One more case of incorrect comparison in recordpatchevent.py
1396         https://bugs.webkit.org/show_bug.cgi?id=137459
1397
1398         Reviewed by Tim Horton.
1399
1400         * QueueStatusServer/app.yaml:
1401         * QueueStatusServer/loggers/recordpatchevent.py:
1402         (RecordPatchEvent.started):
1403
1404 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1405
1406         webkit-queues PatchLog is incorrect for patches that took less than a second
1407         https://bugs.webkit.org/show_bug.cgi?id=137453
1408
1409         Reviewed by Tim Horton.
1410
1411         * QueueStatusServer/app.yaml: Updated app version.
1412
1413         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
1414         Don't bail out for patches that took 0 seconds to process (as frequently happens
1415         when a patch is obsolete).
1416
1417 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
1418
1419         EWS bubble hover shows wrong timestamps
1420         https://bugs.webkit.org/show_bug.cgi?id=137252
1421
1422         Reviewed by Alexey Proskuryakov.
1423
1424         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
1425
1426         * QueueStatusServer/handlers/queuestatusjson.py:
1427         (QueueStatusJSON.get):
1428         * QueueStatusServer/handlers/statusbubble.py:
1429         (StatusBubble._iso_time):
1430
1431 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
1432
1433         Unreviewed, updated list of email addresses in contributors.json
1434
1435         * Scripts/webkitpy/common/config/contributors.json: Added my former
1436         email address in Igalia, for the sake of completeness.
1437
1438 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1439
1440         Unreviewed, moved myself to the list of committers.
1441
1442         * Scripts/webkitpy/common/config/contributors.json:
1443
1444 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
1445
1446         [EFL] Introduce EWebKit_Extension
1447         https://bugs.webkit.org/show_bug.cgi?id=134921
1448
1449         Reviewed by Gyuyoung Kim.
1450
1451         * MiniBrowser/efl/main.c: Added x option to test extension path.
1452         (window_create):
1453         (elm_main):
1454         * Scripts/webkitpy/common/config/watchlist:
1455         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1456         * Scripts/webkitpy/style/checker.py:
1457         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1458
1459 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
1460
1461         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
1462         https://bugs.webkit.org/show_bug.cgi?id=137390
1463
1464         Reviewed by Carlos Garcia Campos.
1465
1466         * Scripts/update-webkit-libs-jhbuild:
1467
1468 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1469
1470         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
1471         https://bugs.webkit.org/show_bug.cgi?id=137391
1472
1473         Reviewed by Martin Robinson.
1474
1475         Add a custom command to only re-generate
1476         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
1477
1478         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1479
1480 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1481
1482         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
1483         https://bugs.webkit.org/show_bug.cgi?id=135502
1484
1485         Reviewed by Martin Robinson.
1486
1487         When writing to stdout/stderr fails due to a UnicodeDecodeError
1488         exception, try again without encoding the output.
1489
1490         * gtk/gtkdoc.py:
1491         (GTKDoc._run_command):
1492
1493 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1494
1495         Bugzilla status bubble displays an exception showing attachment 175738
1496         https://bugs.webkit.org/show_bug.cgi?id=137410
1497
1498         Reviewed by Tim Horton.
1499
1500         * QueueStatusServer/app.yaml: Update version.
1501
1502         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
1503         Don't fail even if expected status message is missing.
1504
1505         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
1506         the field in the same way it's defined in QueueStatus table.
1507
1508 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1509
1510         Record latest message in PatchLog for quick access
1511         https://bugs.webkit.org/show_bug.cgi?id=137405
1512
1513         Fixing a typo.
1514
1515         * QueueStatusServer/app.yaml:
1516         * QueueStatusServer/handlers/releasepatch.py:
1517
1518 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1519
1520         Record latest message in PatchLog for quick access
1521         https://bugs.webkit.org/show_bug.cgi?id=137405
1522
1523         Reviewed by Ryosuke Niwa.
1524
1525         It's no SQL...
1526
1527         * QueueStatusServer/handlers/releasepatch.py:
1528         * QueueStatusServer/handlers/updatestatus.py:
1529         * QueueStatusServer/loggers/recordpatchevent.py:
1530         * QueueStatusServer/model/patchlog.py:
1531
1532 2014-10-02  David Farler  <dfarler@apple.com>
1533
1534         -asan-blacklist option also renamed to generic -fsanitize-blacklist
1535         https://bugs.webkit.org/show_bug.cgi?id=137377
1536
1537         Reviewed by Daniel Bates.
1538
1539         * asan/asan.xcconfig:
1540         -asan-blacklist -> -fsanitize-blacklist
1541
1542         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1543
1544 2014-10-03  Roger Fong  <roger_fong@apple.com>
1545
1546         [Windows] Include batch size argument to layout tests on Windows.
1547
1548         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1549         (RunWebKitTests.start): 
1550         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
1551         These crashes seem to happen on random tests though generally in a spread out fashion.
1552         It seems possible that the DRT instance is being clobbered somehow after running too many
1553         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
1554
1555 2014-10-03  Roger Fong  <roger_fong@apple.com>
1556
1557         [Windows] Settle for 2 chid processes running NRWT on Windows.
1558
1559         * Scripts/webkitpy/port/win.py:
1560         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
1561
1562 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
1563
1564         [GTK] Bump up and patch dependencies to allow building for aarch64
1565         https://bugs.webkit.org/show_bug.cgi?id=137147
1566
1567         Reviewed by Martin Robinson.
1568
1569         The currently used versions of pixman, libffi, librsvg, glib,
1570         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
1571         and/or build for aarch64, so they are bumped up and patched where
1572         necessary. Wherever possible, the same versions and patches were used as
1573         for the EFL port bump-up
1574         (https://bugs.webkit.org/show_bug.cgi?id=135885).
1575
1576         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
1577         regression by crashing http/tests/media/video-redirect.html . A patch
1578         already in upstream fixes that bug.
1579
1580         This change does not touch xserver, which also needs bumping up, but 
1581         will be dealt with later.
1582
1583         * gtk/jhbuild.modules:
1584         Specified versions and patches necessary to correctly build for aarch64.
1585         * gtk/patches/gst-events-arent-gstobjects.patch:
1586         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
1587         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
1588         Added. Patches gst-plugins-base to configure correctly for aarch64.
1589         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
1590         Added. Bumps up config.guess and config.sub in librsvg to recognize
1591         aarch64.
1592         * gtk/patches/libxml2-2.9.0-dtd.patch:
1593         Removed. Not necessary for libxml2 v2.9.1 anymore.
1594
1595 2014-09-28  Sam Weinig  <sam@webkit.org>
1596
1597         Remove RefPtrHashMap
1598         https://bugs.webkit.org/show_bug.cgi?id=137200
1599
1600         Reviewed by Darin Adler.
1601
1602         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1603         (TestWebKitAPI::TEST):
1604         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
1605         a minimum of refcount churn occurs.
1606
1607 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1608
1609         Remove workarounds for versions of Python before 2.7
1610         https://bugs.webkit.org/show_bug.cgi?id=137338
1611
1612         Reviewed by Csaba Osztrogonác.
1613
1614         * Scripts/webkitpy/common/system/autoinstall.py:
1615         (AutoInstaller._extract_targz):
1616         (AutoInstaller._unzip):
1617         (AutoInstaller): Deleted.
1618         (AutoInstaller._extract_all): Deleted.
1619         * Scripts/webkitpy/common/webkitunittest.py:
1620         (TestCase.setUp): Deleted.
1621         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1622         (TestConfigurationConverter.collapse_macros):
1623         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1624         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1625         (TestConfigurationConverter):
1626         (TestConfigurationConverter.combinations): Deleted.
1627         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1628         * Scripts/webkitpy/port/base.py:
1629
1630 2014-10-03  Commit Queue  <commit-queue@webkit.org>
1631
1632         Unreviewed, rolling out r174264.
1633         https://bugs.webkit.org/show_bug.cgi?id=137392
1634
1635         It broke run-webkit-tests (Requested by ebalazsfalvi on
1636         #webkit).
1637
1638         Reverted changeset:
1639
1640         "Remove workarounds for versions of Python before 2.7"
1641         https://bugs.webkit.org/show_bug.cgi?id=137338
1642         http://trac.webkit.org/changeset/174264
1643
1644 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1645
1646         Remove workarounds for versions of Python before 2.7
1647         https://bugs.webkit.org/show_bug.cgi?id=137338
1648
1649         Reviewed by Csaba Osztrogonác.
1650
1651         * Scripts/webkitpy/common/system/autoinstall.py:
1652         (AutoInstaller._extract_targz):
1653         (AutoInstaller._unzip):
1654         (AutoInstaller): Deleted.
1655         (AutoInstaller._extract_all): Deleted.
1656         * Scripts/webkitpy/common/webkitunittest.py:
1657         (TestCase.setUp): Deleted.
1658         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1659         (TestConfigurationConverter.collapse_macros):
1660         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1661         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1662         (TestConfigurationConverter):
1663         (TestConfigurationConverter.combinations): Deleted.
1664         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1665         * Scripts/webkitpy/port/base.py:
1666         * Scripts/webkitpy/port/driver.py:
1667         (ContentBlock.__init__):
1668         * Scripts/webkitpy/port/server_process.py:
1669         (ServerProcess._reset):
1670
1671 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1672
1673         Remove autoinstaller workaround for python 2.6
1674         https://bugs.webkit.org/show_bug.cgi?id=137343
1675
1676         Reviewed by Daniel Bates.
1677
1678         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
1679         2.6, nor Snow Leopard is supported anymore, so the workaround is not
1680         needed anymore.
1681
1682         * Scripts/webkitpy/common/system/autoinstall.py:
1683         (AutoInstaller.install):
1684         * Scripts/webkitpy/test/main.py:
1685         (Tester._run_tests):
1686         * Scripts/webkitpy/thirdparty/__init__.py:
1687         (AutoinstallImportHook._install_mechanize):
1688         (AutoinstallImportHook._install_pep8):
1689         (AutoinstallImportHook._install_pylint):
1690         (AutoinstallImportHook._install_buildbot):
1691         (AutoinstallImportHook._install_coverage):
1692         (AutoinstallImportHook._install_eliza):
1693         (AutoinstallImportHook._install_irc):
1694         (AutoinstallImportHook._install):
1695         (autoinstall_everything):
1696
1697 2014-10-02  Daniel Bates  <dabates@apple.com>
1698
1699         Use version number 101000 instead of 10100 for OS X Yosemite
1700         https://bugs.webkit.org/show_bug.cgi?id=137372
1701
1702         Reviewed by Mark Rowe.
1703
1704         The version number for OS X Yosemite is 101000.
1705
1706         * DumpRenderTree/mac/TextInputController.m:
1707
1708 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
1709
1710         update-work-items should never delete items
1711         https://bugs.webkit.org/show_bug.cgi?id=137366
1712
1713         Reviewed by Ryosuke Niwa.
1714
1715         As we don't just replace the whole list any more, indicate which items are high
1716         priority, and which are not. Hight priority ones will be prepended to the queue,
1717         others will be appended.
1718
1719         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
1720         But hopefully we will never have many rollouts competing like that.
1721
1722         * QueueStatusServer/app.yaml: Update version.
1723
1724         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
1725         priority and regular items separately. Removed some error handling that used to
1726         end up in returning status 500 - an uncaught exception does that automatically.
1727
1728         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
1729
1730         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
1731
1732         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
1733         priority items.
1734
1735         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1736         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
1737         line that complicated testing.
1738
1739         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
1740
1741         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
1742         priority items into separate lists.
1743
1744         * Scripts/webkitpy/common/net/statusserver_mock.py:
1745         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1746         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1747         Updated tests.
1748
1749 2014-10-02  Brendan Long  <b.long@cablelabs.com>
1750
1751         Annoying build warnings in WTFString API tests
1752         https://bugs.webkit.org/show_bug.cgi?id=137360
1753
1754         Reviewed by Darin Adler.
1755
1756         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1757         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
1758
1759 2014-10-02  Roger Fong  <roger_fong@apple.com>
1760
1761         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
1762
1763         * Scripts/webkitpy/port/win.py:
1764         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
1765
1766 2014-10-02  David Farler  <dfarler@apple.com>
1767
1768         Move ASan arguments from LLVM (-mllvm) to the frontend
1769         https://bugs.webkit.org/show_bug.cgi?id=137365
1770
1771         Reviewed by David Kilzer.
1772
1773         * asan/asan.xcconfig:
1774         Remove the -mllvm prefix to the asan-blacklist argument, moving it
1775         to the clang frontend.
1776
1777         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1778
1779 2014-10-02  Commit Queue  <commit-queue@webkit.org>
1780
1781         Unreviewed, rolling out r174120.
1782         https://bugs.webkit.org/show_bug.cgi?id=137350
1783
1784         While number of failures is reasonable with 2 processes, test
1785         results seem to be inconsistent between runs (Requested by
1786         rfong on #webkit).
1787
1788         Reverted changeset:
1789
1790         "[Windows] Back to 2 child processes for NRWT on Windows."
1791         http://trac.webkit.org/changeset/174120
1792
1793 2014-10-02  Jeff Miller  <jeffm@apple.com>
1794
1795         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
1796         https://bugs.webkit.org/show_bug.cgi?id=137347
1797
1798         Reviewed by Dan Bernstein.
1799
1800         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1801         Use WebKitSystemInterfaceYosemite on OS X 10.10.
1802
1803         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1804         Ditto.
1805
1806 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1807
1808         [GTK] [JHBuild] Switch sourceware.org mirror to http.
1809
1810         Unreviewed.
1811
1812         The ftp access is recently failing to work as expected, and the
1813         bots fail to download the file.
1814         The same mirror is available via http and seems to work better.
1815
1816         * gtk/jhbuild.modules:
1817
1818 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1819
1820         Unreviewed, rolling out r174185.
1821         https://bugs.webkit.org/show_bug.cgi?id=137334
1822
1823         Patch that adds logging causes webkitpy failures (Requested by
1824         rfong on #webkit).
1825
1826         Reverted changeset:
1827
1828         "commitqueuetasks_unittest references a non-existent member
1829         variable"
1830         https://bugs.webkit.org/show_bug.cgi?id=137303
1831         http://trac.webkit.org/changeset/174185
1832
1833 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1834
1835         EWS and Commit Queue should know better than to spew 500 failed
1836         results in the case of extremely red patches.
1837         https://bugs.webkit.org/show_bug.cgi?id=137324
1838
1839         Reviewed by Alexey Proskuryakov.
1840
1841         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1842         Adds a check for did_exceed_test_failure_limit.
1843         (AbstractEarlyWarningSystem._failing_tests_message):
1844         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1845         Alters the task mock to respond properly to
1846         results_from_patch_test_run(patch)
1847         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1848         * Scripts/webkitpy/tool/commands/queues.py:
1849         Adds a check for did_exceed_test_failure_limit.
1850         (CommitQueue._failing_tests_message):
1851
1852 2014-10-01  Daniel Bates  <dabates@apple.com>
1853
1854         Unreviewed, rolling out r174192.
1855
1856         Revert the unit test fix in r174192 since we reverted r174187
1857         in r174194 due to correctness issues. See
1858         <http://webkit.org/b/137329> for more details.
1859
1860         Reverted changeset:
1861
1862         "Test fix after r174187"
1863         http://trac.webkit.org/changeset/174192
1864
1865 2014-10-01  Mark Rowe  <mrowe@apple.com>
1866
1867         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
1868
1869         Reviewed by Dan Bernstein.
1870
1871         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
1872         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
1873         for the LLVM components when on Yosemite.
1874
1875 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1876
1877         Unreviewed, rolling out r174187.
1878         https://bugs.webkit.org/show_bug.cgi?id=137329
1879
1880         webkitpy failures, and thorton says the patch is wrong
1881         (Requested by dethbakin on #webkit).
1882
1883         Reverted changeset:
1884
1885         "[Windows] Increase layout test timeout for Windows following
1886         r174162."
1887         http://trac.webkit.org/changeset/174187
1888
1889 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
1890
1891         Test fix after r174187
1892
1893         * Scripts/webkitpy/port/win_unittest.py:
1894         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
1895
1896 2014-10-01  Roger Fong  <roger_fong@apple.com>
1897
1898         [Windows] Increase layout test timeout for Windows following r174162.
1899
1900         * Scripts/webkitpy/port/win.py:
1901         (WinPort.default_timeout_ms):
1902
1903 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1904
1905         commitqueuetasks_unittest references a non-existent member variable
1906         when mock-reporting flaky tests.
1907         https://bugs.webkit.org/show_bug.cgi?id=137303
1908
1909         Reviewed by Daniel Bates.
1910
1911         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1912         (MockCommitQueue.report_flaky_tests):
1913         Makes the appropriate name change.
1914         (test_simple_flaky_test_failure):
1915         Adds a unit test to make sure that the code is excercised.
1916
1917 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1918
1919         EWS is inconclusively spinning forever on a patch that breaks 500+
1920         tests
1921         https://bugs.webkit.org/show_bug.cgi?id=137223
1922
1923         Reviewed by Tim Horton.
1924
1925         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1926         Checks to see whether the tests have exceeded the failure limit, and
1927         only spins off another test if they have not exceeded the limit.
1928         (PatchAnalysisTask._test_patch):
1929
1930 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
1931
1932         Unreviewed, add Katie Madonna as a contributor.
1933
1934         * Scripts/webkitpy/common/config/contributors.json:
1935
1936 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1937
1938         commitqueuetasks_unittest does not construct FailingTestCommitQueue
1939         objects properly in its test cases.
1940         https://bugs.webkit.org/show_bug.cgi?id=137281
1941
1942         Reviewed by Daniel Bates.
1943
1944         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1945         (FailingTestCommitQueue.test_results):
1946         Adds an assert to make FailingTestCommitQueue harder to mis-use.
1947         (test_double_flaky_test_failure):
1948         Nests the intended test failure strings into one-length lists.
1949         (test_red_test_failure):
1950         Nests the intended test failure strings into one-length lists.
1951
1952 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1953
1954         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
1955         https://bugs.webkit.org/show_bug.cgi?id=136987
1956
1957         Reviewed by Daniel Bates.
1958
1959         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1960         Specify the default encoding for all WebKit developers to get consistent results.
1961
1962 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1963
1964         EWS is too eager to say that a patch does not apply to trunk of repository
1965         https://bugs.webkit.org/show_bug.cgi?id=137290
1966
1967         Reviewed by Ryosuke Niwa.
1968
1969         * QueueStatusServer/app.yaml: Updated app version.
1970
1971         * QueueStatusServer/handlers/statusbubble.py:
1972         (StatusBubble._build_bubble):
1973         (StatusBubble._build_bubbles_for_attachment):
1974         Rewrote to make more sense.
1975
1976 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1977
1978         Remove thirdparty/unittest2 from webkitpy
1979         https://bugs.webkit.org/show_bug.cgi?id=137251
1980
1981         Reviewed by Brent Fulgham.
1982
1983         Additionally ordered imports in related webkitpy files and
1984         removed unnecessary shebangs from unittest files.
1985
1986         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
1987         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1988         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1989         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1990         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1991         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1992         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1993         * Scripts/webkitpy/common/config/committers_unittest.py:
1994         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1995         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
1996         * Scripts/webkitpy/common/config/ports_unittest.py:
1997         * Scripts/webkitpy/common/config/urls_unittest.py:
1998         * Scripts/webkitpy/common/editdistance_unittest.py:
1999         * Scripts/webkitpy/common/find_files_unittest.py:
2000         * Scripts/webkitpy/common/lru_cache_unittest.py:
2001         * Scripts/webkitpy/common/memoized_unittest.py:
2002         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
2003         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2004         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2005         * Scripts/webkitpy/common/net/credentials_unittest.py:
2006         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2007         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2008         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2009         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2010         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2011         * Scripts/webkitpy/common/net/statusserver_unittest.py:
2012         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
2013         * Scripts/webkitpy/common/newstringio_unittest.py:
2014         * Scripts/webkitpy/common/prettypatch_unittest.py:
2015         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
2016         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2017         * Scripts/webkitpy/common/system/environment_unittest.py:
2018         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
2019         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
2020         * Scripts/webkitpy/common/system/executive_unittest.py:
2021         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2022         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2023         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2024         * Scripts/webkitpy/common/system/logtesting.py:
2025         * Scripts/webkitpy/common/system/logutils_unittest.py:
2026         * Scripts/webkitpy/common/system/outputcapture.py:
2027         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2028         * Scripts/webkitpy/common/system/outputtee_unittest.py:
2029         * Scripts/webkitpy/common/system/path_unittest.py:
2030         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2031         * Scripts/webkitpy/common/system/profiler_unittest.py:
2032         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
2033         * Scripts/webkitpy/common/system/user_unittest.py:
2034         * Scripts/webkitpy/common/system/workspace_unittest.py:
2035         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2036         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
2037         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
2038         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
2039         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
2040         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
2041         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
2042         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
2043         * Scripts/webkitpy/common/webkitunittest.py:
2044         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2045         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2046         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2047         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2048         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2049         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2050         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2051         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
2052         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
2053         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2054         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2055         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2056         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
2057         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2058         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2059         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
2060         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2061         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2062         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2063         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2064         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2065         * Scripts/webkitpy/port/base_unittest.py:
2066         * Scripts/webkitpy/port/builders_unittest.py:
2067         * Scripts/webkitpy/port/config_unittest.py:
2068         * Scripts/webkitpy/port/driver_unittest.py:
2069         * Scripts/webkitpy/port/efl_unittest.py:
2070         * Scripts/webkitpy/port/factory_unittest.py:
2071         * Scripts/webkitpy/port/gtk_unittest.py:
2072         * Scripts/webkitpy/port/http_lock_unittest.py:
2073         * Scripts/webkitpy/port/image_diff_unittest.py:
2074         * Scripts/webkitpy/port/leakdetector_unittest.py:
2075         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
2076         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2077         * Scripts/webkitpy/port/mock_drt_unittest.py:
2078         * Scripts/webkitpy/port/port_testcase.py:
2079         * Scripts/webkitpy/port/server_process_unittest.py:
2080         * Scripts/webkitpy/port/westondriver_unittest.py:
2081         * Scripts/webkitpy/port/win_unittest.py:
2082         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2083         * Scripts/webkitpy/style/checker_unittest.py:
2084         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2085         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2086         * Scripts/webkitpy/style/checkers/common_unittest.py:
2087         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2088         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
2089         * Scripts/webkitpy/style/checkers/js_unittest.py:
2090         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
2091         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
2092         * Scripts/webkitpy/style/checkers/png_unittest.py:
2093         * Scripts/webkitpy/style/checkers/python_unittest.py:
2094         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2095         * Scripts/webkitpy/style/checkers/text_unittest.py:
2096         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
2097         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
2098         * Scripts/webkitpy/style/checkers/xml_unittest.py:
2099         * Scripts/webkitpy/style/error_handlers_unittest.py:
2100         * Scripts/webkitpy/style/filereader_unittest.py:
2101         * Scripts/webkitpy/style/filter_unittest.py:
2102         * Scripts/webkitpy/style/main_unittest.py:
2103         * Scripts/webkitpy/style/optparser_unittest.py:
2104         * Scripts/webkitpy/style/patchreader_unittest.py:
2105         * Scripts/webkitpy/test/finder_unittest.py:
2106         * Scripts/webkitpy/test/main.py: Ordered imports.
2107         * Scripts/webkitpy/test/main_unittest.py:
2108         * Scripts/webkitpy/test/printer.py: Ordered imports.
2109         (Printer.configure):
2110         * Scripts/webkitpy/test/runner_unittest.py:
2111         * Scripts/webkitpy/test/skip_unittest.py:
2112         * Scripts/webkitpy/thirdparty/__init__.py:
2113         (AutoinstallImportHook._install_irc):
2114         (AutoinstallImportHook._install_unittest2): Deleted.
2115         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2116         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
2117         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2118         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2119         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2120         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2121         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2122         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2123         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2124         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2125         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2126         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2127         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2128         * Scripts/webkitpy/tool/commands/download_unittest.py:
2129         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2130         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
2131         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2132         * Scripts/webkitpy/tool/commands/queuestest.py:
2133         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2134         * Scripts/webkitpy/tool/grammar_unittest.py:
2135         * Scripts/webkitpy/tool/mocktool_unittest.py:
2136         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2137         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2138         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2139         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
2140         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
2141         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2142         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2143         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2144         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2145         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
2146         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2147         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2148         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2149         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2150         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2151         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2152         * Scripts/webkitpy/tool/steps/update_unittest.py:
2153         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2154         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2155         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2156         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2157         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2158
2159 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
2160
2161         LayoutTestResults and ExpectedFailures should know about the
2162         interrupted flag from the json results file
2163         https://bugs.webkit.org/show_bug.cgi?id=137229
2164
2165         Reviewed by Daniel Bates.
2166
2167         Changes LayoutTestResults to use the interrupted flag instead of
2168         counting failures.
2169
2170         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2171         (BuilderTest._install_fetch_build._mock_fetch_build):
2172         (BuilderTest.test_latest_layout_test_results):
2173         * Scripts/webkitpy/common/net/layouttestresults.py:
2174         Removes notion of failure_limit_count, and adds
2175         did_exceed_test_failure_limit.
2176
2177         (LayoutTestResults.results_from_string):
2178         (LayoutTestResults.__init__):
2179         (LayoutTestResults.did_exceed_test_failure_limit):
2180         (LayoutTestResults): Deleted.
2181         (LayoutTestResults.set_failure_limit_count): Deleted.
2182         (LayoutTestResults.failure_limit_count): Deleted.
2183         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2184         Removes unit test for failure_limit_count logic.
2185
2186         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
2187         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2188         Instead of providing a class method that returns a list of
2189         TestResults objects, resultsjsonparser now provides a class
2190         ParsedJSONResults that serves as an interface between the results.json
2191         file and the rest of webkitpy.
2192
2193         (ParsedJSONResults):
2194         (ParsedJSONResults.__init__):
2195         (ParsedJSONResults.did_exceed_test_failure_limit):
2196         (ParsedJSONResults.test_results):
2197         (ResultsJSONParser): Deleted.
2198         (ResultsJSONParser.parse_results_json): Deleted.
2199         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2200         Updates the unit test so that it can test the new ResultsJSONParser
2201         class.
2202
2203         (ParsedJSONResultsTest):
2204         (test_basic):
2205         (ResultsJSONParserTest): Deleted.
2206         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2207         Updates the unit test to instantiate ResultsJSONParser objects rather
2208         than simple lists of TestResult objects.
2209
2210         (MockCommitQueue.test_results):
2211         (FailingTestCommitQueue.test_results):
2212         (test_flaky_test_failure):
2213         (test_failed_archive):
2214         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2215         Updates ExpectedFailures to use the did_exceed_test_failure_limit
2216         method rather than counting the number of failed tests.
2217
2218         (ExpectedFailures._should_trust):
2219         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2220         Updates MockResults to more closely resemble the updated
2221         LayoutTestResults class.
2222
2223         (MockResults.__init__):
2224         (MockResults.did_exceed_test_failure_limit):
2225         (ExpectedFailuresTest.test_can_trust_results):
2226         (ExpectedFailuresTest.test_unexpected_failures_observed):
2227         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
2228         (MockResults.failure_limit_count): Deleted.
2229         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2230         Removes a FIXME regarding the use of the
2231         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
2232
2233         (LayoutTestResultsReader.results):
2234         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2235         Updates test to not check the now-nonexistant failure_count_limit
2236         method.
2237
2238         (test_missing_unit_test_results_path):
2239         (test_layout_test_results):
2240         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2241         Accounts for name change: ResultsJSONParserTest ->
2242         ParsedJSONParserTest.
2243
2244         (RebaselineTestTest.test_gather_baselines):
2245
2246 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2247
2248         [EFL] Rename TEST_THEME_DIR macro
2249         https://bugs.webkit.org/show_bug.cgi?id=137244
2250
2251         Reviewed by Csaba Osztrogonác.
2252
2253         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
2254         DEFAULT_THEME_DIR is better than it.
2255
2256         * MiniBrowser/efl/main.c:
2257         (window_create):
2258         * TestWebKitAPI/efl/PlatformWebView.cpp:
2259         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2260         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2261         (WTR::PlatformWebView::PlatformWebView):
2262
2263 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2264
2265         Windows EWS went purple when it failed to build
2266         https://bugs.webkit.org/show_bug.cgi?id=137267
2267
2268         Reviewed by Ryosuke Niwa.
2269
2270         * QueueStatusServer/app.yaml: Update the version.
2271
2272         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
2273         Make it work for style and win-ews queues.
2274
2275 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
2276
2277         It should be fun and easy to run every possible JavaScript benchmark from the command line
2278         https://bugs.webkit.org/show_bug.cgi?id=137245
2279
2280         Reviewed by Oliver Hunt.
2281         
2282         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
2283         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
2284         having their own private scripts for doing benchmark runs, and didn't share them in the open
2285         source community, because of fears about the shady licensing of the benchmarks suites that
2286         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
2287         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
2288         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
2289         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
2290         but some of them are. The non-public tests are exclusively those that were not made by any
2291         WebKit contributor, but which JSC/WebKit devs found useful for testing.
2292
2293         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
2294         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
2295         checked into WebKit svn at all) can be run by passing the path to them via a configuration
2296         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
2297         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
2298         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
2299         probably never be checked in because there is no license text anywhere in that benchmark.
2300         A valid ~/.run-jsc-benchmarks file will just be something like:
2301         
2302             {
2303                 "OctanePath": "/path/to/Octane2",
2304                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
2305             }
2306         
2307         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
2308         run-jsc-benchmarks will just gracefully avoid running that test suite.
2309         
2310         Finally, a word about policy: it is understood that different organizations that do
2311         development on JSC may find themselves having internal benchmarks that they cannot share
2312         because of weird licensing. It happens - usually because the organization doing JSC
2313         development found some test in the wild that is owned by someone else and therefore cannot
2314         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
2315         that add support for some new kind of benchmark suite even if the suite is not made public
2316         as part of the same patch - so long as the patch isn't too invasive. An example of
2317         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
2318         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
2319         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
2320         completely open-sourced and committed to the WebKit repo - but the reality is that this
2321         can't always be done safely.
2322
2323         * Scripts/bencher: Removed.
2324         * Scripts/run-jsc-benchmarks: Added.
2325
2326 2014-09-30  Roger Fong  <roger_fong@apple.com>
2327
2328         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
2329
2330         * Scripts/webkitpy/port/drdiver.py:
2331         (Driver.stop):
2332         * Scripts/webkitpy/port/server_process.py:
2333         (ServerProcess.stop):
2334
2335 2014-09-30  Roger Fong  <roger_fong@apple.com>
2336
2337         [Windows] Back to 2 child processes for NRWT on Windows.
2338
2339         * Scripts/webkitpy/port/win.py:
2340         (WinPort.default_child_processes):
2341         Changing the number of processes to 1 did not have an effect on the layout test results. 
2342         It does introduce an issue with one of the workers hanging indefinitely and causing the 
2343         layout tests to timeout as a whole occasionally, but we should just fix that.
2344
2345 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2346
2347         Remove an accidentally committed line..
2348
2349         * QueueStatusServer/handlers/statusbubble.py:
2350         (StatusBubble._build_bubble):
2351
2352 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2353
2354         build.webkit.org/dashboard: Switch EWS view to using actual retry count
2355         https://bugs.webkit.org/show_bug.cgi?id=137240
2356
2357         Reviewed by Ryosuke Niwa.
2358
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2360         (EWSQueue.prototype.loadDetailedStatus):
2361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2362         (EWSQueueView.prototype._popoverContentForEWSQueue):
2363         Use the new retry_count data member from JSON.
2364
2365         * QueueStatusServer/app.yaml: Updating the version.
2366
2367         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
2368         Instead of message_count, produce retry_count.
2369
2370 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2371
2372         EWS doesn't need to show all the bubbles when a patch fails to apply
2373         https://bugs.webkit.org/show_bug.cgi?id=137256
2374
2375         Reviewed by Ryosuke Niwa.
2376
2377         * QueueStatusServer/app.yaml: Updated app version.
2378
2379         * QueueStatusServer/handlers/statusbubble.py:
2380         (StatusBubble._build_bubble):
2381         (StatusBubble._build_bubbles_for_attachment):
2382         (StatusBubble.get):
2383         * QueueStatusServer/templates/statusbubble.html:
2384         When some queues fail to apply, and no queues had meaningful output (meaning that
2385         they will almost certainly fail to apply later), we can show a single bubble
2386         telling the user just that.
2387
2388 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2389
2390         [EFL] Bump EFL version to 1.11.2
2391         https://bugs.webkit.org/show_bug.cgi?id=137118
2392
2393         Reviewed by Gyuyoung Kim.
2394
2395         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
2396         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
2397
2398         * efl/jhbuild.modules:
2399         * efl/patches/ecore.patch: Removed.
2400
2401 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2402
2403         REGRESSION(r173929): [GTK] TestInspector fails after r173929
2404         https://bugs.webkit.org/show_bug.cgi?id=137247
2405
2406         Reviewed by Philippe Normand.
2407
2408         Wait until can-attach property changes before trying to attach the
2409         inspector after resizing the view.
2410
2411         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
2412         (testInspectorDefault):
2413
2414 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2415
2416         Require Python 2.7 version
2417         https://bugs.webkit.org/show_bug.cgi?id=137112
2418
2419         Reviewed by Csaba Osztrogonác.
2420
2421         * Scripts/ensure-valid-python:
2422         (checkPythonVersion):
2423         * Scripts/webkitpy/common/version_check.py:
2424
2425 2014-09-30  Martin Hock  <mhock@apple.com>
2426
2427         Skip a JSC test after r174036.
2428         https://bugs.webkit.org/show_bug.cgi?id=137236
2429
2430         Reviewed by Csaba Osztrogonác.
2431
2432         * Scripts/run-javascriptcore-tests:
2433
2434 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2435
2436         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
2437         https://bugs.webkit.org/show_bug.cgi?id=137212
2438
2439         This moves TestNetscapePlugin to a new folder (lib/plugins).
2440         We should not use the same directory for TestNetscapePlugin and
2441         the other libraries, because we end up scanning all the .so in the
2442         lib dir for every test.
2443
2444         Reviewed by Carlos Garcia Campos.
2445
2446         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
2447         * Scripts/webkitpy/port/efl.py:
2448         (EflPort.setup_environ_for_server): Update plugin path.
2449         * Scripts/webkitpy/port/gtk.py:
2450         (GtkPort.setup_environ_for_server): Update plugin path.
2451         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
2452
2453 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2454
2455         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
2456
2457         Rubber-stamped by Tim Horton.
2458
2459         * QueueStatusServer/app.yaml:
2460         * QueueStatusServer/handlers/statusbubble.py:
2461         (StatusBubble._build_bubble):
2462
2463 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2464
2465         Typo fix, suggested by Tim Horton.
2466
2467         * QueueStatusServer/handlers/statusbubble.py:
2468         (StatusBubble._build_message_for_provisional_failure):
2469
2470 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2471
2472         Improve Bugzilla status bubbles
2473         https://bugs.webkit.org/show_bug.cgi?id=137232
2474
2475         Reviewed by Ryosuke Niwa.
2476
2477         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
2478
2479         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
2480         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
2481         that are stuck, as it was only confusing that they disappeared after 99.
2482
2483         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
2484         by old bubbles. We need a lot more information to determine color, so the implementation
2485         can not be here.
2486
2487         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
2488         always have a link for consistency. Added code to convert timestamps in tooltips
2489         to local time zone.
2490
2491 2014-09-29  Commit Queue  <commit-queue@webkit.org>
2492
2493         Unreviewed, rolling out r174045.
2494         https://bugs.webkit.org/show_bug.cgi?id=137231
2495
2496         Introduced a crash during page loading tests on Mac (Requested
2497         by rniwa on #webkit).
2498
2499         Reverted changeset:
2500
2501         "Replace OSObjectPtr with RetainPtr/adoptOS"
2502         https://bugs.webkit.org/show_bug.cgi?id=137158
2503         http://trac.webkit.org/changeset/174045
2504
2505 2014-09-29  Tim Horton  <timothy_horton@apple.com>
2506
2507         Add Jake as a contributor.
2508
2509         * Scripts/webkitpy/common/config/contributors.json:
2510
2511 2014-09-29  Roger Fong  <roger_fong@apple.com>
2512
2513         [Windows] Skip a javascriptcore test following r174036.
2514
2515         * Scripts/run-javascriptcore-tests:
2516
2517 2014-09-29  Roger Fong  <roger_fong@apple.com>
2518
2519         [Windows] Reduce number of processes used by NRWT on Windows to 1.
2520
2521         * Scripts/webkitpy/port/win.py:
2522         (WinPort.default_child_processes):
2523         Reduce number of processes to 1 so we can get a good baseline for what failures
2524         we should be expecting to see from the Windows bots.
2525
2526 2014-09-29  Darin Adler  <darin@apple.com>
2527
2528         Tweak and tighten SVG font converter
2529         https://bugs.webkit.org/show_bug.cgi?id=136956
2530
2531         Reviewed by Myles Maxfield.
2532
2533         I was investigating behavior of String::toInt, String::toDouble, and
2534         String::toFloat for various failure cases, and decided to start some
2535         unit tests for those functions here.
2536
2537         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2538         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
2539         StringToDouble testing.
2540
2541 2014-09-29  Philippe Normand  <pnormand@igalia.com>
2542
2543         [GTK][CMake] TestWebCore target build sometimes fail
2544         https://bugs.webkit.org/show_bug.cgi?id=137207
2545
2546         Reviewed by Csaba Osztrogon.
2547
2548         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
2549         headers are generated before the TestWebCore target is built.
2550
2551 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2552
2553         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
2554         https://bugs.webkit.org/show_bug.cgi?id=137209
2555
2556         Reviewed by Philippe Normand.
2557
2558         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
2559         from the WebCore test sources.
2560
2561 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
2562
2563         Allow webkit-patch upload to respect the --directory argument with git checkouts
2564         https://bugs.webkit.org/show_bug.cgi?id=137166
2565
2566         Reviewed by Darin Adler.
2567
2568         We simply hadn't plumbed it through.
2569
2570         * Scripts/webkitpy/common/checkout/scm/detection.py:
2571         (SCMDetector.detect_scm_system):
2572         * Scripts/webkitpy/common/checkout/scm/git.py:
2573         (Git.__init__):
2574         (Git.changed_files):
2575
2576 2014-09-26  Sam Weinig  <sam@webkit.org>
2577
2578         Replace OSObjectPtr with RetainPtr/adoptOS
2579         https://bugs.webkit.org/show_bug.cgi?id=137158
2580
2581         Reviewed by Dan Bernstein.
2582
2583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2584         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
2585         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
2586         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
2587
2588 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
2589
2590         Disable function.arguments
2591         https://bugs.webkit.org/show_bug.cgi?id=137167
2592
2593         Rubber stamped by Geoffrey Garen
2594         
2595         Enable the feature by default during tests.
2596
2597         * Scripts/run-jsc-stress-tests:
2598
2599 2014-09-26  Beth Dakin  <bdakin@apple.com>
2600
2601         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
2602         https://bugs.webkit.org/show_bug.cgi?id=137089
2603
2604         Reviewed by Tim Horton.
2605
2606         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
2607         tests run at 1x, but that code does not seem to execute at the right time for 
2608         these tests, so if we just ensure we start out at 1x, that appears to fix these 
2609         tests and does not break the HiDPI tests either.
2610         * WebKitTestRunner/TestController.cpp:
2611         (WTR::TestController::createWebViewWithOptions):
2612
2613 2014-09-26  Roger Fong  <roger_fong@apple.com>
2614
2615         [Windows] Decrease default number of child processes used by Windows.
2616
2617         * Scripts/webkitpy/port/win.py:
2618         (WinPort.default_child_processes):
2619         Having too many seems to cause many tests to crash or timeout. 
2620         We may even need to make it have only 1 child process if we’re still seeing problems after this.
2621
2622 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2623
2624         Mac EWS bots do not keep logs as promised
2625         https://bugs.webkit.org/show_bug.cgi?id=137151
2626
2627         Reviewed by Ryosuke Niwa.
2628
2629         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
2630
2631 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2632
2633         Get rid of webkit-queues dashboard
2634         https://bugs.webkit.org/show_bug.cgi?id=137141
2635
2636         Reviewed by Ryosuke Niwa.
2637
2638         * QueueStatusServer/app.yaml: Updated version.
2639
2640         * QueueStatusServer/templates/dashboard.html: Removed.
2641         * QueueStatusServer/handlers/dashboard.py: Removed.
2642         * QueueStatusServer/main.py:
2643         Kill it!
2644
2645         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
2646         (.status-cell): Deleted.
2647         (.status-cell:hover): Deleted.
2648         (.status-cell.pass): Deleted.
2649         (.status-cell.fail): Deleted.
2650         (.status-cell.pending): Deleted.
2651         (.status-cell.error): Deleted.
2652         * QueueStatusServer/stylesheets/dashboard.css: Removed.
2653         * QueueStatusServer/templates/activebots.html:
2654         * QueueStatusServer/templates/patch.html:
2655         * QueueStatusServer/templates/queuestatus.html:
2656         * QueueStatusServer/templates/recentstatus.html:
2657         Renamed dashboard.css to common.css, and removed dashboard-only rules.
2658
2659 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2660
2661         Get rid of Retry status in webkit-queues
2662         https://bugs.webkit.org/show_bug.cgi?id=137135
2663
2664         Reviewed by Ryosuke Niwa.
2665
2666         * QueueStatusServer/config/messages.py: Removed Retry.
2667
2668         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
2669         no longer needs to check the latest status. It just always both unlocks the patch
2670         and removes it from WorkItems.
2671
2672         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
2673         I don't understand why we even needed to check for retries here, but now that there
2674         are no retries, that code can go to /dev/null.
2675
2676         * QueueStatusServer/loggers/recordpatchevent.py:
2677         (RecordPatchEvent.started):
2678         (RecordPatchEvent.retrying): Deleted.
2679         Fixed retry counting, it should work for all queues now.
2680
2681         * QueueStatusServer/model/queuestatus.py:
2682         (QueueStatus.is_retry_request): Deleted. These are no more.
2683
2684         * Scripts/webkitpy/common/net/statusserver_mock.py:
2685         (MockStatusServer.release_lock):
2686         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2687         Did whatever it took to keep passing the tests. The particular test doesn't seem
2688         quite right, but whatever.
2689
2690         * Scripts/webkitpy/tool/commands/queues.py:
2691         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
2692         and let others pick up. Also, added explicit returns for clarity.
2693         (AbstractPatchQueue._did_retry): Deleted.
2694
2695 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
2696
2697         [EFL] Fix the gst-libav build on ARM Thumb2
2698         https://bugs.webkit.org/show_bug.cgi?id=137022
2699
2700         Reviewed by Zoltan Herczeg.
2701
2702         * efl/jhbuild.modules:
2703         * efl/patches/gst-libav.patch: Added.
2704
2705 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
2706
2707         [EFL] Bump up dependencies not to conflict with the GTK port.
2708         https://bugs.webkit.org/show_bug.cgi?id=137143
2709
2710         Reviewed by Gyuyoung Kim.
2711
2712         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
2713         installing and removing different versions of libgnutls-dev, thus
2714         hindering the development for both ports on the same machine. GTK is
2715         using the newer version of the package, now bumping up EFL to use the 
2716         same.
2717
2718         * efl/install-dependencies:
2719
2720 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
2721
2722         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
2723         https://bugs.webkit.org/show_bug.cgi?id=136854
2724
2725         Reviewed by Gyuyoung Kim.
2726
2727         'Escape' key should exit fullscreen first and then should be used to stop page load.
2728
2729         * MiniBrowser/efl/main.c:
2730         (on_key_down):
2731
2732 2014-09-25  Dean Jackson  <dino@apple.com>
2733
2734         Add Said to the contributors list so his name completes in bugzilla.
2735
2736         * Scripts/webkitpy/common/config/contributors.json:
2737
2738 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
2739
2740         EWS only repeats its cycle every two hours
2741         https://bugs.webkit.org/show_bug.cgi?id=137129
2742
2743         Reviewed by Ryosuke Niwa.
2744
2745         * QueueStatusServer/app.yaml: Updated version.
2746
2747         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
2748
2749         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
2750         the patch from work items.
2751
2752         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
2753
2754         * QueueStatusServer/main.py: Added release-lock.
2755
2756         * QueueStatusServer/model/activeworkitems.py:
2757         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
2758
2759         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
2760         we don't want it to be immediately picked up again, it's better to give other patches
2761         a chance.
2762
2763         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
2764         these interactive versions, but OK.
2765
2766         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
2767         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
2768         or svn is down).
2769
2770         * Scripts/webkitpy/tool/commands/queues.py:
2771         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
2772         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
2773         meaning that these handlers could never do the right thing. We'd either get a duplicate
2774         _did_fail, or try to unlock an already unlocked patch.
2775         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
2776         making it eligible for retry immediately.
2777
2778         * Scripts/webkitpy/common/net/statusserver.py:
2779         (StatusServer._post_release_lock):
2780         (StatusServer.release_lock):
2781         Added a call to release-lock.
2782
2783 2014-09-25  Roger Fong  <roger_fong@apple.com>
2784
2785         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
2786
2787         * Scripts/webkitpy/common/system/path.py:
2788         (_CygPath.convert):
2789
2790 2014-09-25  Roger Fong  <roger_fong@apple.com>
2791
2792         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
2793
2794         * Scripts/webkitpy/common/system/path.py:
2795         (_CygPath.convert):
2796
2797 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2798
2799         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
2800         https://bugs.webkit.org/show_bug.cgi?id=136377
2801
2802         Reviewed by Philippe Normand.
2803
2804         * Scripts/webkitdirs.pm:
2805         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
2806
2807 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
2808
2809         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
2810         https://bugs.webkit.org/show_bug.cgi?id=137117
2811
2812         Tools/efl/install-dependencies relies on apt-get to install packages.
2813         Unfortunately, if a package does not exist (e.g., for a given
2814         architecture) then apt-get install is not able to ignore the missing
2815         package and install the rest but fails to run entirely (and there
2816         seems to be no intent to change this behaviour).
2817
2818         On ARM64, the luajit package is missing and currently it needs manual
2819         editing of install-dependencies to get the script install as much as it
2820         can.
2821
2822         This patch separates the installation of the universally available
2823         packages from those which might not be available for all architectures.
2824
2825         Reviewed by Gyuyoung Kim.
2826
2827         * efl/install-dependencies:
2828
2829 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
2830
2831         Remove WinCE port from trunk
2832         https://bugs.webkit.org/show_bug.cgi?id=136951
2833
2834         Reviewed by Alex Christensen.
2835
2836         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2837         (_should_file_trigger_build):
2838         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2839         (ShouldBuildTest):
2840         * CMakeLists.txt:
2841         * DumpRenderTree/win/DRTDataObject.cpp:
2842         (DRTDataObject::CopyMedium):
2843         * Scripts/build-webkit:
2844         * Scripts/webkit-build-directory:
2845         * Scripts/webkitdirs.pm:
2846         (argumentsForConfiguration):
2847         (builtDylibPathForName):
2848         (isAppleWinWebKit):
2849         (launcherPath):
2850         (launcherName):
2851         (shouldRemoveCMakeCache):
2852         (cmakeBasedPortArguments):
2853         (cmakeBasedPortName):
2854         (isCMakeBuild):
2855         (isWinCE): Deleted.
2856         (determineIsWinCE): Deleted.
2857         * Scripts/webkitperl/FeatureList.pm:
2858         * Scripts/webkitpy/port/port_testcase.py:
2859         (test_apache_config_file_name_for_platform):
2860         * TestWebKitAPI/config.h:
2861         * WinCELauncher/CMakeLists.txt: Removed.
2862         * WinCELauncher/main.cpp: Removed.
2863         * gtk/manifest.txt:
2864
2865 2014-09-23  David Farler  <dfarler@apple.com>
2866
2867         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
2868         https://bugs.webkit.org/show_bug.cgi?id=136895
2869
2870         Reviewed by David Kilzer.
2871
2872         Create Device, DeviceType, and Runtime data classes.
2873         Create Simulator class represent simctl output.
2874
2875         Wherever possible, use structured data classes anywhere a raw
2876         identifier or UDID string was used for a cleaner implementation
2877         and to encapsulate the inherent fragility of scraping simctl output.
2878
2879         Create a suitably named testing device if one doesn't exist.
2880
2881         Finally, accurately handle having multiple simulator runtimes (SDKs)
2882         installed in the active Xcode.app bundle.
2883
2884         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2885         (_set_up_derived_options):
2886         * Scripts/webkitpy/port/driver.py:
2887         (IOSSimulatorDriver.cmd_line):
2888         Construct DeviceType and Runtime objects from identifiers passed at the
2889         command line, still providing sensible defaults for 32- and 64-bit testing.
2890         * Scripts/webkitpy/port/ios.py:
2891         (IOSSimulatorPort.__init__):
2892         (IOSSimulatorPort.setup_test_run):
2893         (IOSSimulatorPort):
2894         (IOSSimulatorPort.testing_device):
2895         Cache the testing device once it is created or found.
2896         (IOSSimulatorPort.reset_preferences):
2897         Get the device path from the Device object instead of consructing it
2898         in the port class.
2899         (IOSSimulatorPort.simulator_udid): Deleted.
2900         Get the UDID from the testing_device :: Device object itself.
2901         * Scripts/webkitpy/xcode/simulator.py:
2902         Created Device, DeviceType, Runtime, and Simulator classes.
2903         (get_runtimes): Deleted.
2904         (get_devices): Deleted.
2905         (get_device_types): Deleted.
2906         (get_latest_runtime): Deleted.
2907
2908 2014-09-24  Roger Fong  <roger_fong@apple.com>
2909
2910         [Windows] Tentative fix for Windows test bots.
2911
2912         * Scripts/webkitpy/common/system/path.py:
2913         (_CygPath.convert):
2914
2915 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
2916
2917         Change more build.webkit.org links to https
2918         https://bugs.webkit.org/show_bug.cgi?id=137049
2919
2920         Reviewed by Csaba Osztrogonác.
2921
2922         Fix appspot, svn.webkit.org and Trac links.
2923
2924         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2925         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2927         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
2928         (ViewController.prototype._domForBuildName):
2929         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2930         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2931         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2932         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2933         (.):
2934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2935         (EWS):
2936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2938         (TestHistory):
2939         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2940
2941 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
2942
2943         Update the list of u-szeged contributors.
2944
2945         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
2946
2947         * Scripts/webkitpy/common/config/contributors.json:
2948
2949 2014-09-23  Roger Fong  <roger_fong@apple.com>
2950
2951         [Windows] More debugging for the Windows bots.
2952
2953         * Scripts/webkitpy/common/system/path.py:
2954         (_CygPath):
2955
2956 2014-09-23  Roger Fong  <roger_fong@apple.com>
2957
2958         Unreviewed. Fix for r173899, those tabs should be spaces.
2959
2960         * Scripts/webkitpy/port/driver.py:
2961         (Driver._command_from_driver_input):
2962         (Driver): Deleted.
2963
2964 2014-09-23  Roger Fong  <roger_fong@apple.com>
2965
2966         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
2967
2968         * Scripts/webkitpy/port/driver.py:
2969         (Driver):
2970
2971 2014-09-23  Jer Noble  <jer.noble@apple.com>
2972
2973         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
2974         https://bugs.webkit.org/show_bug.cgi?id=137031
2975
2976         Reviewed by Joseph Pecoraro.
2977
2978         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
2979         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
2980         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
2981         ChangeLog locations before passing them to createCommitMessage().
2982
2983         * Scripts/commit-log-editor:
2984
2985 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2986
2987         W3C test importer should detect manual and reference tests according their filenames
2988         https://bugs.webkit.org/show_bug.cgi?id=133852
2989
2990         Reviewed by Bem Jones-Bey.
2991
2992         * Scripts/webkitpy/w3c/test_parser.py:
2993         (TestParser.analyze_test): Adding checks based on WPT filename rules.
2994         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
2995         (TestParser):
2996         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
2997         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
2998         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2999         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
3000
3001 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
3002
3003         Unreviewed, add Rebecca Hauck as a contributor.
3004
3005         * Scripts/webkitpy/common/config/contributors.json:
3006
3007 2014-09-23  David Kilzer  <ddkilzer@apple.com>
3008
3009         Switch build.webkit.org URLs to https
3010
3011         Reviewed by Lucas Forschler and Alexey Proskuryakov.
3012
3013         * TestResultServer/app.yaml: Update version to this commit
3014         revision.
3015
3016         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
3020         (WebKitBuildbot):
3021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3024         (.):
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3026         (WebKitBuildbot):
3027         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3028         * Scripts/webkitpy/common/config/urls.py:
3029         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3030         (test_builder_with_name):
3031         * Scripts/webkitpy/tool/commands/queries.py:
3032         (TreeStatus):
3033         * TestResultServer/generate_builders_json.py:
3034         (main):
3035         * TestResultServer/generate_builders_json_unittest.py:
3036         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
3037         (GenerateBuildersJsonTest):
3038         (GenerateBuildersJsonTest.test_generate_json_data):
3039         * TestResultServer/static-dashboards/builders.jsonp:
3040         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3041         (loadExpectationsLayoutTests):
3042         * TestResultServer/static-dashboards/timeline_explorer.js:
3043
3044 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3045
3046         W3C test importer should copy .htaccess files
3047         https://bugs.webkit.org/show_bug.cgi?id=136850
3048
3049         Reviewed by Bem Jones-Bey.
3050
3051         * Scripts/webkitpy/w3c/test_importer.py:
3052         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
3053         (TestImporter):
3054         (TestImporter.find_importable_tests): Making use of new helper function.
3055
3056 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
3057
3058         Trying to revive bot watcher's dashboard after HSTS.
3059
3060         Unreviewed.
3061
3062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3063         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
3064
3065 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3066
3067         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
3068         https://bugs.webkit.org/show_bug.cgi?id=137026
3069
3070         Reviewed by Csaba Osztrogonác.
3071
3072         * BuildSlaveSupport/wait-for-SVN-server.py:
3073         (getLatestSVNRevision):
3074         (waitForSVNRevision):
3075
3076 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3077
3078         Remove unlinkZeroFiles from build-webkit
3079         https://bugs.webkit.org/show_bug.cgi?id=137018
3080
3081         Reviewed by Csaba Osztrogonác.
3082
3083         * Scripts/build-webkit:
3084         (unlinkZeroFiles): Deleted.
3085
3086 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
3087
3088         [GTK] Minibrowser : Add keyboard support for stop page load
3089         https://bugs.webkit.org/show_bug.cgi?id=136857
3090
3091         Reviewed by Philippe Normand.
3092
3093         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
3094
3095         * MiniBrowser/gtk/BrowserWindow.c:
3096         (stopPageLoad): Callback to stop page load.
3097         (browser_window_init):
3098
3099 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
3100
3101         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
3102         https://bugs.webkit.org/show_bug.cgi?id=136813
3103
3104         Reviewed by Gyuyoung Kim.
3105
3106         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
3107
3108         * MiniBrowser/efl/main.c:
3109         (on_key_down):
3110
3111 2014-09-22  Daniel Bates  <dabates@apple.com>
3112
3113         [Cocoa] Add UI delegate callback when window.close() is called
3114         https://bugs.webkit.org/show_bug.cgi?id=137008
3115         <rdar://problem/17801001>
3116
3117         Reviewed by Anders Carlsson.
3118
3119         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
3120         for window opened via JavaScript (i.e. window.open()).
3121
3122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3123         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
3124         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
3125
3126 2014-09-22  Youenn Fablet  <youennf@gmail.com>
3127
3128         W3C importer should import html files within resources folders
3129         https://bugs.webkit.org/show_bug.cgi?id=127548
3130
3131         Reviewed by Ryosuke Niwa.
3132         
3133         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
3134
3135         * Scripts/webkitpy/w3c/test_importer.py:
3136         (TestImporter.find_importable_tests):
3137
3138 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3139
3140         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
3141         https://bugs.webkit.org/show_bug.cgi?id=136998
3142
3143         Reviewed by Philippe Normand.
3144
3145         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3146         (testWebViewCanShowMIMEType): Remove the check of PDF as
3147         unsupported MIME type.
3148
3149 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3150
3151         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
3152
3153         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
3154         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
3155
3156         * Scripts/webkitpy/common/config/watchlist: Use
3157         Source/WebCore/platform/gtk/po/ as directory to watch for
3158         WebKitGTKTranslations rule and add berto and myself to the list of
3159         watchers.
3160
3161 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
3162
3163         Fix syntaxError in watchlist since r173594
3164         https://bugs.webkit.org/show_bug.cgi?id=136996
3165
3166         Reviewed by Philippe Normand.
3167
3168         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
3169
3170 2014-09-20  Sam Weinig  <sam@webkit.org>
3171
3172         Make possible HashSet<std::unique_ptr<>>
3173         https://bugs.webkit.org/show_bug.cgi?id=136166
3174
3175         Reviewed by Darin Adler.
3176
3177         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
3178         * TestWebKitAPI/Counters.cpp: Added.
3179         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
3180         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
3181         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
3182         translation unit.
3183     
3184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3185         Add new files.
3186
3187         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3188         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
3189
3190         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3191         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
3192
3193 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3194
3195         run-webkit-tests should count tests submitted as absolute paths once
3196         https://bugs.webkit.org/show_bug.cgi?id=136848
3197
3198         Reviewed by Darin Adler.
3199
3200         * Scripts/webkitpy/port/base.py:
3201         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
3202
3203 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
3204
3205         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
3206         https://bugs.webkit.org/show_bug.cgi?id=136974
3207
3208         Reviewed by Chris Fleizach.
3209
3210         * DumpRenderTree/AccessibilityUIElement.cpp:
3211         (selectTextWithCriteriaCallback):
3212         Be sure to release the string if it was allocated.
3213
3214 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
3215
3216         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
3217         https://bugs.webkit.org/show_bug.cgi?id=136966
3218
3219         Reviewed by Daniel Bates.
3220
3221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3222         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
3223
3224 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3225
3226         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
3227         https://bugs.webkit.org/show_bug.cgi?id=136917
3228
3229         Reviewed by Darin Adler.
3230
3231         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
3232
3233         * TestWebKitAPI/PlatformEfl.cmake:
3234         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
3235         (TestWebKitAPI::didFinishLoadForFrame):
3236         (TestWebKitAPI::TEST):
3237         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
3238
3239 2014-09-19  Daniel Bates  <dabates@apple.com>
3240
3241         Always assume internal SDK when building configuration Production
3242         https://bugs.webkit.org/show_bug.cgi?id=136925
3243         <rdar://problem/18362399>
3244
3245         Reviewed by Dan Bernstein.
3246
3247         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3248         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3249         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3250         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3251
3252 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3253
3254         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
3255         https://bugs.webkit.org/show_bug.cgi?id=136847
3256
3257         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
3258
3259         Reviewed by Alexey Proskuryakov.
3260
3261         * WebKitTestRunner/TestController.cpp:
3262         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
3263
3264 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3265
3266         [GTK] Missing inspector files in the tarball
3267         https://bugs.webkit.org/show_bug.cgi?id=136952
3268
3269         Reviewed by Gustavo Noronha Silva.
3270
3271         * gtk/manifest.txt: Add
3272         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
3273         to the tarball.
3274
3275 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3276
3277         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
3278         https://bugs.webkit.org/show_bug.cgi?id=136632
3279
3280         Reviewed by Gustavo Noronha Silva.
3281
3282         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
3283         the gtk icons.
3284         * gtk/manifest.txt: Only include the free icons in the tarball.
3285
3286 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3287
3288         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
3289         https://bugs.webkit.org/show_bug.cgi?id=136943
3290
3291         Reviewed by Philippe Normand.
3292
3293         Update the script to receive the list of files from the command
3294         line instead of scanning the given directories.
3295
3296         * gtk/generate-inspector-gresource-manifest.py:
3297         (get_filenames): Convert filenames to use relative paths.
3298         (find_all_files_in_directory): Deleted.
3299         (find_all_files_in_directory.select_file): Deleted.
3300
3301 2014-09-18  Tanay C  <tanay.c@samsung.com>
3302
3303         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
3304         https://bugs.webkit.org/show_bug.cgi?id=136739
3305
3306         Reviewed by Gyuyoung Kim.
3307
3308         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
3309         (on_mouse_wheel): Modified.
3310
3311 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3312
3313         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
3314         https://bugs.webkit.org/show_bug.cgi?id=136923
3315
3316         Reviewed by Gustavo Noronha Silva.
3317
3318         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3319         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
3320         the source.
3321
3322 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
3323
3324         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
3325         https://bugs.webkit.org/show_bug.cgi?id=136856
3326
3327         Reviewed by Darin Adler.
3328
3329         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3330         (RunLLINTCLoopTests.countFailures):
3331         (Run32bitJSCTests.countFailures):
3332         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3333         (RunLLINTCLoopTestsTest.test_failures):
3334         (RunLLINTCLoopTestsTest.test_failure):
3335         (RunLLINTCLoopTestsTest.test_no_failure):
3336         (Run32bitJSCTestsTest.test_failures):
3337         (Run32bitJSCTestsTest.test_failure):
3338         (Run32bitJSCTestsTest.test_no_failure):
3339
3340 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
3341
3342         GMainLoopSource is exposed to race conditions
3343         https://bugs.webkit.org/show_bug.cgi?id=135800
3344
3345         Reviewed by Carlos Garcia Campos.
3346
3347         Add unit tests for GMainLoopSource.
3348
3349         The tests check correct behavior of GMainLoopSource in various conditions --
3350         from the most simple rescheduling to rescheduling during dispatch, cancelling
3351         or destroying the GMainLoopSource during dispatch, proper destroy callback
3352         dispatching etc.
3353
3354         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
3355         State of the GMainLoopSource object (either ready, sheduled or active) is
3356         thoroughly tested throughout the lifetime of that object.
3357
3358         Still missing are tests for socket callbacks, which are a bit trickier because
3359         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
3360         are also not tested thoroughly, simply because it is at the moment impossible
3361         to test that the objects are actually destroyed when the corresponding source
3362         is finally deleted.
3363
3364         * TestWebKitAPI/PlatformGTK.cmake:
3365         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
3366         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3367         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3368         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3369         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
3370         (TestWebKitAPI::GMainLoopSourceTest::finish):
3371         (TestWebKitAPI::GMainLoopSourceTest::source):
3372         (TestWebKitAPI::TEST):
3373
3374 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
3375
3376         Unreviewed, Update my email in contributors.json
3377
3378         * Scripts/webkitpy/common/config/contributors.json:
3379
3380 2014-09-17  Daniel Bates  <dabates@apple.com>
3381
3382         Unreviewed, rolling out r173695.
3383
3384         Broke building third-party Legacy WebKit apps; will
3385         investigate offline
3386
3387         Reverted changeset:
3388
3389         "[iOS] Make WebCore build with public iOS SDK"
3390         https://bugs.webkit.org/show_bug.cgi?id=136487
3391         http://trac.webkit.org/changeset/173695
3392
3393 2014-09-17  Daniel Bates  <dabates@apple.com>
3394
3395         [iOS] Make WebCore build with public iOS SDK
3396         https://bugs.webkit.org/show_bug.cgi?id=136487
3397
3398         Reviewed by David Kilzer.
3399
3400         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
3401
3402         * DumpRenderTree/mac/CheckedMalloc.cpp:
3403
3404 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3405
3406         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
3407         https://bugs.webkit.org/show_bug.cgi?id=136889
3408
3409         Reviewed by Gustavo Noronha Silva.
3410
3411         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3412         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
3413         event was added to the events vector.
3414         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3415         (loadFailedCallback): Do not assume the web view URI is the
3416         failing URI when the load fails before the committed state.
3417         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
3418         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
3419         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
3420         (LoadTrackingTest::loadFailedWithTLSErrors): Add
3421         LoadFailedWithTLSErrors event to the events vector.
3422         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3423
3424 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
3425
3426         [EFL][GTK] Remove WebKit1 related codes
3427         https://bugs.webkit.org/show_bug.cgi?id=136853
3428
3429         Reviewed by Csaba Osztrogonác.
3430
3431         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
3432         from scripts.
3433
3434         * BuildSlaveSupport/build.webkit.org-config/config.json:
3435         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3436         (Compile32bitJSC):
3437         (BuildAndTestWebKit2Factory):
3438         (CompileWebKit1Only): Deleted.
3439         (CompileWebKit2Only): Deleted.
3440         (BuildAndTestWebKit1OnlyFactory): Deleted.
3441         (BuildAndTestWebKit2OnlyFactory): Deleted.
3442         * Scripts/build-webkit:
3443         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3444         * Scripts/webkitpy/common/config/ports.py:
3445         (GtkWK2Port.build_webkit_command):
3446         (EflWK2Port.build_webkit_command):
3447         * Scripts/webkitpy/common/config/ports_unittest.py:
3448         (DeprecatedPortTest.test_gtk_wk2_port):
3449         * Scripts/webkitpy/port/efl.py:
3450         (EflPort.build_webkit_command):
3451         * Scripts/webkitpy/port/gtk.py:
3452         (GtkPort._built_libraries_path):
3453         (GtkPort._search_paths):
3454         (GtkPort.test_expectations_file_position):
3455         (GtkPort.build_webkit_command):
3456         (GtkPort.run_webkit_tests_command):
3457         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
3458
3459 2014-09-16  Daniel Bates  <dabates@apple.com>
3460
3461         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3462         https://bugs.webkit.org/show_bug.cgi?id=136862
3463
3464         Reviewed by David Kilzer.
3465
3466         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3467         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3468         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
3469         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
3470
3471 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3472
3473         Mac queue slaves should reboot every so often
3474         https://bugs.webkit.org/show_bug.cgi?id=136791
3475
3476         Reviewed by Alexey Proskuryakov.
3477
3478         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
3479
3480         * EWSTools/start-queue-mac.sh:
3481
3482 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3483
3484         Unreviewed gardening, skip one more tests on Windows.
3485
3486         * Scripts/run-javascriptcore-tests:
3487
3488 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3489
3490         JSC test gardening
3491         https://bugs.webkit.org/show_bug.cgi?id=136823
3492
3493         Reviewed by Geoffrey Garen.
3494
3495         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
3496
3497 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3498
3499         Remove shouldAbortEarly cruft from master.cfg
3500         https://bugs.webkit.org/show_bug.cgi?id=136779
3501
3502         Reviewed by Csaba Osztrogonác.
3503
3504         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3505         (ConfigureBuild.start):
3506         (RunWebKitTests.start):
3507         (RunWebKit2Tests.start): Deleted.
3508
3509 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3510
3511         Remove ORWT related crufts from webkitdirs.pm
3512         https://bugs.webkit.org/show_bug.cgi?id=136821
3513
3514         Reviewed by Alexey Proskuryakov.
3515
3516         * Scripts/webkitdirs.pm:
3517         (isPerianInstalled): Deleted.
3518         (determineIPhoneSimulatorVersion): Deleted.
3519         (iPhoneSimulatorVersion): Deleted.
3520         (isSnowLeopard): Deleted.
3521         (isLion): Deleted.
3522         (quitIOSSimulator): Deleted.
3523
3524 2014-09-15  Roger Fong  <roger_fong@apple.com>
3525
3526         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
3527         https://bugs.webkit.org/show_bug.cgi?id=25160
3528
3529         * Scripts/run-javascriptcore-tests:
3530
3531 2014-09-15  Lucas Forschler  <lforschler@apple.com>
3532
3533         Add another Apple build slave to the Mountain Lion Debug WK1 queue
3534         
3535         Rubber stamped by Matt Hanson.
3536         
3537         * BuildSlaveSupport/build.webkit.org-config/config.json:
3538
3539 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3540
3541         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
3542         https://bugs.webkit.org/show_bug.cgi?id=136822
3543
3544         Reviewed by Gyuyoung Kim.
3545
3546         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
3547         initialized as we already does it in PlatformWebView::PlatformWebView
3548         calling ewk_init(). The reason for that was to ensure testing for example,
3549         WTF where creating the view is not mandatory.
3550
3551         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
3552         in order to properly initalize and release EWebKit.
3553
3554         * TestWebKitAPI/PlatformEfl.cmake:
3555         * TestWebKitAPI/efl/PlatformWebView.cpp:
3556         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3557         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3558         * TestWebKitAPI/efl/main.cpp:
3559         (main):
3560
3561 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
3562
3563         [WinCairo] Make it easier to enable/disable GStreamer.
3564         https://bugs.webkit.org/show_bug.cgi?id=135766
3565
3566         Reviewed by Brent Fulgham.
3567
3568         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
3569
3570         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
3571
3572 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
3573
3574         Web Inspector: remind about rebaselining generator test results
3575         https://bugs.webkit.org/show_bug.cgi?id=136759
3576
3577         Reviewed by Joseph Pecoraro.
3578
3579         For now, we can implement this as a watchlist message. Add watchlist
3580         groups and messages for the inspector and web replay generators.
3581
3582         * Scripts/webkitpy/common/config/watchlist:
3583
3584 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3585
3586         build.webkit.org/dashboard: Overlapping text when status is long
3587         https://bugs.webkit.org/show_bug.cgi?id=136794
3588
3589         Reviewed by Timothy Hatcher.
3590
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3592         (.status-line): Replaces height with min-height.
3593
3594 2014-09-12  Timothy Hatcher  <timothy@apple.com>
3595
3596         Make Brian Burg a WebKit reviewer.
3597
3598         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
3599
3600 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3601
3602         Multiple EWS or commit bots can pick up processing of the same patch
3603         https://bugs.webkit.org/show_bug.cgi?id=136793
3604
3605         Reviewed by Ryosuke Niwa.
3606
3607         Change timeout from one hour to two hours. This will let bots finish, and in the
3608         unlikely event of a bot being frozen, will only delay patch processing restart by
3609         one hour.
3610
3611         * QueueStatusServer/app.yaml:
3612         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
3613
3614 2014-09-11  Andy Estes  <aestes@apple.com>
3615
3616         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
3617         https://bugs.webkit.org/show_bug.cgi?id=136768
3618
3619         Reviewed by Tim Horton.
3620
3621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3622         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
3623         (TestWebKitAPI::TEST):
3624
3625 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3626
3627         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
3628         https://bugs.webkit.org/show_bug.cgi?id=136669
3629
3630         Reviewed by Antti Koivisto.
3631
3632         * Scripts/run-gtk-tests:
3633         (TestRunner): Unskip SSL test.