Add SPI to WKURLSchemeTask for redirection
[WebKit-https.git] / Tools / ChangeLog-2013-04-24
1 2013-04-23  David Grogan  <dgrogan@chromium.org>
2
3         Unreviewed. Remove myself from watchlist.
4
5         * Scripts/webkitpy/common/config/watchlist:
6
7 2013-04-23  Jessie Berlin  <jberlin@apple.com>
8
9         NRWT: confusing warning about a line being in a Skipped file when it is really just listed
10         in _missing_symbol_to_skipped_tests in base.py
11         https://bugs.webkit.org/show_bug.cgi?id=108884
12
13         Reviewed by Tim Horton.
14
15         Remove symbol-based skipped list detection.
16
17         * Scripts/webkitpy/port/base.py:
18         (Port._missing_feature_to_skipped_tests):
19         (Port._skipped_tests_for_unsupported_features):
20         * Scripts/webkitpy/port/port_testcase.py:
21         (PortTestCase.test_path_to_test_expectations_file):
22
23 2013-04-23  Benjamin Poulain  <bpoulain@apple.com>
24
25         Remove wxWebKit support from the Tools
26         https://bugs.webkit.org/show_bug.cgi?id=115005
27
28         Reviewed by Andreas Kling.
29
30         The wxWebKit port is no longer actively maintained by Kevin
31         on webkit.org. Remove the code until new maintainers resume the work.
32
33         * DumpRenderTree/DumpRenderTree.h:
34         * DumpRenderTree/config.h:
35         * DumpRenderTree/wscript: Removed.
36         * DumpRenderTree/wx/DumpRenderTreeWx.cpp: Removed.
37         * DumpRenderTree/wx/DumpRenderTreeWx.h: Removed.
38         * DumpRenderTree/wx/GCControllerWx.cpp: Removed.
39         * DumpRenderTree/wx/TestRunnerWx.cpp: Removed.
40         * DumpRenderTree/wx/WorkQueueItemWx.cpp: Removed.
41         * Scripts/build-dumprendertree:
42         * Scripts/build-jsc:
43         (buildMyProject):
44         * Scripts/build-webkit:
45         * Scripts/old-run-webkit-tests:
46         * Scripts/run-launcher:
47         * Scripts/webkitdirs.pm:
48         (argumentsForConfiguration):
49         (determineConfigurationProductDir):
50         (determinePassedArchitecture):
51         (builtDylibPathForName):
52         (determineIsQt):
53         (isAppleWebKit):
54         (launcherPath):
55         (launcherName):
56         (checkRequiredSystemConfig):
57         * Scripts/webkitpy/common/config/contributionareas.py:
58         * waf/build/build_utils.py: Removed.
59         * waf/build/settings.py: Removed.
60         * waf/build/waf_extensions.py: Removed.
61         * waf/build/wxpresets.py: Removed.
62         * wx/browser/browser.cpp: Removed.
63         * wx/browser/wscript: Removed.
64         * wx/install-unix-extras: Removed.
65         * wx/packaging/build-debian-installer.py: Removed.
66         * wx/packaging/build-mac-installer.py: Removed.
67         * wx/packaging/build-win-installer.py: Removed.
68         * wx/packaging/debian/changelog: Removed.
69         * wx/packaging/debian/compat: Removed.
70         * wx/packaging/debian/control: Removed.
71         * wx/packaging/debian/copyright: Removed.
72         * wx/packaging/debian/python-webkitwx.install: Removed.
73         * wx/packaging/debian/rules: Removed.
74         * wx/packaging/wxWebKitInstaller.iss.in: Removed.
75
76 2013-04-23  Zeno Albisser  <zeno@webkit.org>
77
78         [Qt] Fix test_build_check for Qt on Mac after r148075.
79         https://bugs.webkit.org/show_bug.cgi?id=115038
80
81         Reviewed by Csaba Osztrogonác.
82
83         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
84         (RunTest.test_build_check):
85             run-webkit-tests is supposed to fail, if it is run on a different
86             platform than specified on the command line.
87             However, Qt allows exactly this for Qt-platforms to allow comparing
88             of test results of different baselines.
89             Before r148075 "chromium-linux-x86" was used for testing.
90             This patch changes the port_name to gtk when running the test on mac.
91
92 2013-04-23  Xan Lopez  <xlopez@igalia.com>
93
94         [BlackBerry] Do not access BackForwardListImpl from DRT
95         https://bugs.webkit.org/show_bug.cgi?id=115041
96
97         Reviewed by Carlos Garcia Campos.
98
99         Use the right class to access the bflist functionality.
100
101         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
102         (BlackBerry::WebKit::dumpBackForwardListForWebView):
103
104 2013-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
105
106         [GTK] Add webkit_uri_request_get_http_headers to WebKit2 GTK+ API
107         https://bugs.webkit.org/show_bug.cgi?id=112160
108
109         Reviewed by Andreas Kling.
110
111         * MiniBrowser/gtk/GNUmakefile.am: Add missing libsoup flags to
112         CPPFLAGS.
113
114 2013-04-23  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
115
116         [WK2] Make EFL WKView API shareable between ports
117         https://bugs.webkit.org/show_bug.cgi?id=114734
118
119         Reviewed by Anders Carlsson.
120
121         * TestWebKitAPI/PlatformEfl.cmake:
122         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
123
124             Updated project files accordingly to updated WKView API files
125             structure.
126
127 2013-04-23  Andreas Kling  <akling@apple.com>
128
129         Add Benjamin Poulain's @apple.com address to his entry. Unreviewed.
130
131         * Scripts/webkitpy/common/config/contributors.json:
132
133 2013-04-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
134
135         Respect image-rendering setting for determing image-rendering quality
136         https://bugs.webkit.org/show_bug.cgi?id=113405
137
138         Reviewed by Benjamin Poulain.
139
140         Remove CSS4 Images option. It is not ready for implementation.
141
142         * Scripts/webkitperl/FeatureList.pm:
143
144 2013-04-22  Mark Rowe  <mrowe@apple.com>
145
146         <http://webkit.org/b/114989> Add a user default to allow use of the Safari binary rather than SafariForWebKitDevelopment
147
148         Reviewed by Anders Carlsson.
149
150         * Scripts/webkitdirs.pm:
151         (skipSafariExecutableEntitlementChecks): Look for the SkipSafariExecutableEntitlementChecks default in the
152         /Library/Preferences/org.webkit.BuildConfiguration preference domain.
153         (safariPathFromSafariBundle): If the user default is set asking us to skip the entitlement checks, return
154         the path to the regular Safari binary.
155
156 2013-04-22  Ryuan Choi  <ryuan.choi@samsung.com>
157
158        Unreviewed Efl build fix after r148921
159
160         * TestWebKitAPI/CMakeLists.txt:
161
162 2013-04-22  Benjamin Poulain  <benjamin@webkit.org>
163
164         Remove the memory instrumentation code
165         https://bugs.webkit.org/show_bug.cgi?id=114931
166
167         Reviewed by Andreas Kling.
168
169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
170         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Removed.
171
172 2013-04-22  Martin Robinson  <mrobinson@igalia.com>
173
174         [GTK] Enable introspection always for developer builds
175         https://bugs.webkit.org/show_bug.cgi?id=114983
176
177         Reviewed by Gustavo Noronha Silva.
178
179         * Scripts/webkitdirs.pm:
180         (runAutogenForAutotoolsProjectIfNecessary): Always enable introspection
181         when using build-webkit.
182         * gtk/jhbuildrc: Enable documentation for all jhbuild modules and explicitly
183         choose the memory gsettings backend while in the jhbuild. This eliminates
184         warnings from programs that fall back to the memory backend.
185
186 2013-04-22  Zan Dobersek  <zdobersek@igalia.com>
187
188         [GTK] Set up libPlatform.la
189         https://bugs.webkit.org/show_bug.cgi?id=114168
190
191         Reviewed by Martin Robinson.
192
193         * GNUmakefile.am: Link the DumpRenderTree executable against both libPlatform.la and libPlatformGtk.la libraries.
194
195 2013-04-22  Xuefei Ren  <xren@blackberry.com>
196
197         fix build warning(unused parameter)
198         https://bugs.webkit.org/show_bug.cgi?id=114855
199
200         Reviewed by Rob Buis.
201
202         remove warning(unused parameter) in
203         Tools/DumpRenderTree/blackberry/EventSender.cpp
204
205         * DumpRenderTree/blackberry/EventSender.cpp:
206         (getDragModeCallback):
207
208 2013-04-22  Alberto Garcia  <agarcia@igalia.com>
209
210         [BlackBerry] Add dummy implementation of AccessibilityController::accessibleElementById()
211         https://bugs.webkit.org/show_bug.cgi?id=114939
212
213         Reviewed by Carlos Garcia Campos.
214
215         This was added in r129308.
216
217         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
218         (AccessibilityController::accessibleElementById):
219
220 2013-04-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
221
222         Unreviewed EFL build fix after r148855.
223
224         * TestWebKitAPI/PlatformEfl.cmake:
225
226 2013-04-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
227
228         [EFL][WK2] Mark WKViewClientWebProcessCallbacks API test as failing
229         https://bugs.webkit.org/show_bug.cgi?id=114922
230
231         Reviewed by Gyuyoung Kim.
232
233         Mark WKViewClientWebProcessCallbacks API test as failing on WK2 EFL.
234
235         * TestWebKitAPI/PlatformEfl.cmake:
236
237 2013-04-20  Zan Dobersek  <zdobersek@igalia.com>
238
239         [GTK] Fix baseline positioning issue by updating Freetype
240         https://bugs.webkit.org/show_bug.cgi?id=106775
241
242         Reviewed by Martin Robinson.
243
244         * gtk/jhbuild.modules: Bump the Freetype Jhbuild dependency to 2.4.11.
245         * gtk/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added. This is the Freetype
246         patch (committed as e0469372) that fixes rounding issues for smaller fonts. It is bound to be included
247         in the 2.4.12 release of Freetype (not released yet) but is provided here as its effect on baselines is
248         considered positive and will reduce the amout of future rebaselining.
249
250 2013-04-20  Manuel Rego Casasnovas  <rego@igalia.com>
251
252         [GTK] Fix unit test webkit2/WebKitFindController/hide
253         https://bugs.webkit.org/show_bug.cgi?id=89810
254
255         Reviewed by Carlos Garcia Campos.
256
257         * Scripts/run-gtk-tests:
258         (TestRunner): Unskip test webkit2/WebKitFindController/hide.
259
260 2013-04-19  Ryosuke Niwa  <rniwa@webkit.org>
261
262         Build fixes for the flakiness dashboard.
263
264         * TestResultServer/static-dashboards/flakiness_dashboard.js:
265
266 2013-04-17  Gustavo Noronha Silva  <gns@gnome.org>
267
268         [GTK] Make the 32 bits bot only build and run API tests
269         https://bugs.webkit.org/show_bug.cgi?id=113532
270
271         Reviewed by Martin Robinson.
272
273         * BuildSlaveSupport/build.webkit.org-config/config.json: make the 32 bits bot use the new BuildAndAPITest type
274         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
275         (BuildAndAPITestFactory): new factory that builds and runs API tests, only used by the GTK+ 32 bits bot at the
276         moment;
277         (BuildAndAPITestFactory.__init__): add API tests step for platforms that have it.
278
279 2013-04-19  Andras Becsi  <andras.becsi@digia.com>
280
281         [Qt] Only use thin archives on Linux
282
283         Rubber-stamped by Jocelyn Turcotte.
284
285         Since "thin archive" is a feature of GNU's ar
286         we limit the usage to Linux to avoid problems
287         with other configurations (eg. macx-g++).
288
289         * qmake/mkspecs/features/default_pre.prf:
290
291 2013-04-19  Krzysztof Czech  <k.czech@samsung.com>
292
293         [GTK][WK2] accessibility/language-attribute.html is failing
294         https://bugs.webkit.org/show_bug.cgi?id=106342
295
296         Reviewed by Gyuyoung Kim.
297
298         Adds support for getting language information.
299
300         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
301         (WTR::AccessibilityUIElement::language):
302
303 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
304
305         [Dashboard] Remove the isToTWebKit member variable from the BuilderGroup interface
306         https://bugs.webkit.org/show_bug.cgi?id=114805
307
308         Reviewed by Benjamin Poulain.
309
310         Remove the isToTWebKit member variable from the BuilderGroup and all its usages as it now defaults to true for every
311         builder group. The isTipOfTreeWebKitBuilder method now returns true by default but should be removed in a follow-up patch.
312         The BuilderGroup constructor does not accept the isToTWebKit parameter anymore so all the callsites are adjusted accordingly.
313
314         * TestResultServer/static-dashboards/builders.js:
315         (BuilderGroup):
316         (loadBuildersList):
317         * TestResultServer/static-dashboards/dashboard_base.js:
318         (isTipOfTreeWebKitBuilder):
319         (expectationsMap):
320         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
321         (test):
322
323 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
324
325         [Dashboard] htmlForIndividualTests unit test should include its dummy builder under the webkit.org builder master
326         https://bugs.webkit.org/show_bug.cgi?id=114804
327
328         Reviewed by Benjamin Poulain.
329
330         The htmlForIndividualTests unit test should include its dummy builder under the sole supported webkit.org builder master
331         just so the unit tests properly functions.
332
333         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
334
335 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
336
337         [Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code
338         https://bugs.webkit.org/show_bug.cgi?id=114803
339
340         Reviewed by Benjamin Poulain.
341
342         Remove three Chromium-specific helper functions that were used to determine Chromium DEPS, Content Shell and WebKit ToT
343         test runners. These are not required anymore and thus removed along with a couple of unit tests that were testing these
344         methods' correct behavior.
345
346         * TestResultServer/static-dashboards/builders.js:
347         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
348
349 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
350
351         [Dashboard] Remove the Chromium-specific builder masters
352         https://bugs.webkit.org/show_bug.cgi?id=114802
353
354         Reviewed by Benjamin Poulain.
355
356         Remove all the Chromium-specific builder masters, the webkit.org builder master is the only one currently supported.
357
358         * TestResultServer/static-dashboards/builders.js:
359
360 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
361
362         [Dashboard] Remove all the Chromium-specific builder groups
363         https://bugs.webkit.org/show_bug.cgi?id=114801
364
365         Reviewed by Benjamin Poulain.
366
367         Remove all the Chromium-specific builder groups, all of these are not supported anymore.
368
369         * TestResultServer/static-dashboards/builders.js:
370
371 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
372
373         [Dashboard] Only accept the 'group' parameter if present in the layout tests builders group
374         https://bugs.webkit.org/show_bug.cgi?id=114799
375
376         Reviewed by Benjamin Poulain.
377
378         The layout tests builder group is the only one supported, all the other Chromium-specific builder groups are
379         bound to be removed.
380
381         * TestResultServer/static-dashboards/history.js:
382         (.):
383
384 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
385
386         [Dashboard] Remove Chromium-specific builder loading code from loadBuildersList
387         https://bugs.webkit.org/show_bug.cgi?id=114797
388
389         Reviewed by Benjamin Poulain.
390
391         Remove anything Chromium-specific from the builder-loading code, specifically removing support for loading builder data
392         for anything other that the layout-tests type and removing support for loading builder data from builders connected
393         to the Chromium-specific builder groups which are no longer supported.
394
395         * TestResultServer/static-dashboards/builders.js:
396
397 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
398
399         [Dashboard] The currentBuilderGroupCategory method should return the layout tests builder groups by default
400         https://bugs.webkit.org/show_bug.cgi?id=114796
401
402         Reviewed by Benjamin Poulain.
403
404         With the Chromium builders no longer uploading results and the layout-tests test type the only one supported by the
405         WebKit's dashboard, the currentBuilderGroupCategory can now return LAYOUT_TESTS_BUILDER_GROUPS as the default builder
406         group category.
407
408         * TestResultServer/static-dashboards/dashboard_base.js:
409         (currentBuilderGroupCategory):
410
411 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
412
413         [Dashboard] Narrow down the test types list to only layout-tests
414         https://bugs.webkit.org/show_bug.cgi?id=114795
415
416         Reviewed by Ryosuke Niwa.
417
418         Remove all the redundant test types that the webkit.org builders do not upload results for. All of the removed
419         test types were specific to the Chromium builders.
420
421         * TestResultServer/static-dashboards/dashboard_base.js:
422
423 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
424
425         [Dashboard] The revision rows for aggregate results should no longer include Chromium revisions
426         https://bugs.webkit.org/show_bug.cgi?id=114760
427
428         Reviewed by Benjamin Poulain.
429
430         With the Chromium builders no longer present there's no need to display the Chromium revision range under the
431         aggregate results. Only the first half of the htmlForRevisionRows method (the one returning the table row listing the
432         WebKit revisions) is now relevant - the method is therefor removed and its callsites updated to directly call the
433         htmlForTableRow method that returns the table row containing all the relevant WebKit revisions.
434
435         * TestResultServer/static-dashboards/aggregate_results.js:
436         (htmlForSummaryTable):
437         (htmlForTestType):
438
439 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
440
441         [Dashboard] Remove Chromium-specific cases from the construction of the chart HTML for aggregate results
442         https://bugs.webkit.org/show_bug.cgi?id=114759
443
444         Reviewed by Benjamin Poulain.
445
446         Aggregate results are not viewable for Chromium builders anymore, meaning the WebKit revisions are shown by default.
447         This means the code in the chartHTML method can be simplified, defaulting the revision key to WEBKIT_REVISIONS_KEY
448         and the revision label to 'WebKit Revision'.
449
450         * TestResultServer/static-dashboards/aggregate_results.js:
451         (chartHTML):
452
453 2013-04-18  Xuefei Ren  <xren@blackberry.com>
454
455         remove build warning(unused parameter)
456         https://bugs.webkit.org/show_bug.cgi?id=114670
457
458         Reviewed by Rob Buis.
459
460         remove builde warning (unused parameter) in
461         Tools/DumpRenderTree/blackberry
462
463         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
464         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
465         (AccessibilityUIElement::scrollToGlobalPoint):
466         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
467         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
468         (BlackBerry::WebKit::DumpRenderTree::didReceiveResponseForFrame):
469         * DumpRenderTree/blackberry/EventSender.cpp:
470         (getDragModeCallback):
471         (setDragModeCallback):
472         (mouseWheelToCallback):
473         (contextClickCallback):
474         (mouseDownCallback):
475         (mouseUpCallback):
476         (mouseMoveToCallback):
477         (beginDragWithFilesCallback):
478         (leapForwardCallback):
479         (keyDownCallback):
480         (textZoomInCallback):
481         (textZoomOutCallback):
482         (zoomPageInCallback):
483         (zoomPageOutCallback):
484         (addTouchPointCallback):
485         (updateTouchPointCallback):
486         (setTouchModifierCallback):
487         (touchStartCallback):
488         (touchCancelCallback):
489         (touchMoveCallback):
490         (touchEndCallback):
491         (clearTouchPointsCallback):
492         (cancelTouchPointCallback):
493         (releaseTouchPointCallback):
494         (scalePageByCallback):
495         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
496         (TestRunner::authenticateSession):
497         (TestRunner::setSpatialNavigationEnabled):
498         (TestRunner::apiTestNewWindowDataLoadBaseURL):
499         (TestRunner::setPluginsEnabled):
500         (TestRunner::setApplicationCacheOriginQuota):
501         (TestRunner::addMockSpeechInputResult):
502         (TestRunner::setViewModeMediaFeature):
503         (TestRunner::deleteLocalStorageForOrigin):
504         (TestRunner::applicationCacheDiskUsageForOrigin):
505         (TestRunner::grantWebNotificationPermission):
506         (TestRunner::denyWebNotificationPermission):
507         (TestRunner::simulateWebNotificationClick):
508         (TestRunner::simulateLegacyWebNotificationClick):
509
510 2013-04-18  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
511
512         [WK2][EFL] Text Checker's settings refactor
513         https://bugs.webkit.org/show_bug.cgi?id=111713
514
515         Reviewed by Andreas Kling.
516
517         * MiniBrowser/efl/main.c:
518         (window_create):
519         Use a new text checker API to enable spell checking.
520
521 2013-04-18  Seokju Kwon  <seokju.kwon@gmail.com>
522
523         [EFL] Add a newline to the end of log message
524         https://bugs.webkit.org/show_bug.cgi?id=114659
525
526         Reviewed by Gyuyoung Kim.
527
528         Move a newline to info() definition.
529
530         * EWebLauncher/main.c:
531         (on_load_finished):
532         (on_tooltip_text_set):
533         (on_tooltip_text_unset):
534         (on_inputmethod_changed):
535         (on_focus_out):
536         (on_focus_in):
537         (on_key_down):
538         (windowCreate):
539         * MiniBrowser/efl/main.c:
540         (on_key_down):
541         (on_download_request):
542         (on_download_finished):
543         (on_download_failed):
544         (on_refresh_button_clicked):
545         (on_popup_menu_discarded):
546         (on_popup_menu_item_clicked):
547         (popup_menu_populate):
548         (on_popup_menu_show):
549         (on_window_create):
550         (context_popup_item_selected_cb):
551         (on_context_menu_show):
552         (on_context_menu_hide):
553         (window_create):
554
555 2013-04-17  Zan Dobersek  <zandobersek@gmail.com>
556
557         [Dashboard] Remove code for showing 'WebKit roll' annotations in timelines for Chromium builders
558         https://bugs.webkit.org/show_bug.cgi?id=114755
559
560         Reviewed by Ryosuke Niwa.
561
562         The Chromium builders are no longer available to inspect so there's no need for the code that used to show
563         the 'WebKit roll' annotations in the Chromium builders' timeline.
564
565         * TestResultServer/static-dashboards/timeline_explorer.js:
566
567 2013-04-17  Zan Dobersek  <zandobersek@gmail.com>
568
569         [Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
570         https://bugs.webkit.org/show_bug.cgi?id=114756
571
572         Reviewed by Ryosuke Niwa.
573
574         Clean up the updating of the timeline in the timeline explorer, defaulting to the webkit.org build master when
575         constructing the results URL and removing the possible row addition containing the Chromium commit range that
576         only applied to Chromium builders in the first place. Also removes the now-redundant shouldShowWebKitRevisionsOnly
577         method.
578
579         * TestResultServer/static-dashboards/timeline_explorer.js:
580
581 2013-04-17  Alberto Garcia  <agarcia@igalia.com>
582
583         media-stream and xslt are no longer configurable options in the GTK+ port
584         https://bugs.webkit.org/show_bug.cgi?id=114736
585
586         Reviewed by Martin Robinson.
587
588         media-stream support was removed in r145199 and XSLT is a hard
589         requirement since r145859. Attempting to pass those options to the
590         configure script, only results in a warning.
591
592         * Scripts/webkitdirs.pm:
593         (buildAutotoolsProject):
594
595 2013-04-17  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
596
597         [EFL][WK2] Implement context menu in MiniBrowser
598         https://bugs.webkit.org/show_bug.cgi?id=102932
599
600         Reviewed by Gyuyoung Kim.
601
602         Added context menu support for EFL port using Elementary context popup.
603
604         * MiniBrowser/efl/main.c:
605         (_Browser_Window):
606         (context_popup_item_selected_cb):
607         (context_popup_populate):
608         (on_context_menu_show):
609         (on_context_menu_hide):
610         (window_create):
611
612 2013-04-17  Csaba Osztrogonác  <ossy@webkit.org>
613
614         REGRESSION(r148588): It broke the Qt WK2 EWS
615         https://bugs.webkit.org/show_bug.cgi?id=114737
616
617         Reviewed by Jocelyn Turcotte.
618
619         * Scripts/webkitpy/common/config/ews.json: "Qt WK2 EWS" should use qt-wk2 port.
620         * Scripts/webkitpy/common/config/ports.py:
621         (DeprecatedPort.port):
622         (QtPort.build_webkit_command): qt port shouldn't build WebKit2.
623         (QtPort.run_webkit_tests_command): qt port runs WK1 tests.
624         (QtWK2Port): Added.
625         (QtWK2Port.build_webkit_command): qt-wk2 port builds WK1 and WK2 too.
626         (QtWK2Port.run_webkit_tests_command): qt-wk2 port runs WK2 tests.
627         * Scripts/webkitpy/common/config/ports_unittest.py:
628         (DeprecatedPortTest.test_qt_port):
629         (DeprecatedPortTest):
630         (DeprecatedPortTest.test_qt_wk2_port):
631
632 2013-04-17  Zan Dobersek  <zdobersek@igalia.com>
633
634         Unreviewed.
635
636         * Scripts/webkitpy/common/config/ports_unittest.py:
637         (DeprecatedPortTest.test_efl_port): Adjusting the expected outcome of the EFL build-webkit command after r148589.
638
639 2013-04-17  Allan Sandfeld Jensen  <allan.jensen@digia.com>
640
641         [Qt] Enable sub-pixel layout.
642         https://bugs.webkit.org/show_bug.cgi?id=113199
643
644         Reviewed by Jocelyn Turcotte.
645
646         * qmake/mkspecs/features/features.pri:
647
648 2013-04-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
649
650         Add Efl WebKit2 EWS bot
651         https://bugs.webkit.org/show_bug.cgi?id=114564
652
653         Reviewed by Ryosuke Niwa.
654
655         Added EflWK2EWS, and add myself a watcher for EflWK2EWS.
656         Also add a deprecated EflWK2Port class.
657
658         Besides clean up eflews watchers.
659
660         * QueueStatusServer/config/queues.py:
661         * Scripts/webkitpy/common/config/ews.json:
662         * Scripts/webkitpy/common/config/ports.py:
663         (DeprecatedPort.port):
664         (EflPort.build_webkit_command):
665         (EflWK2Port):
666         (EflWK2Port.build_webkit_command):
667
668 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
669
670         Isolate Early Warning System definitions into a JSON
671         https://bugs.webkit.org/show_bug.cgi?id=114558
672
673         Reviewed by Benjamin Poulain.
674
675         Added ews.json to common/config, and made tool/commands/__init__.py call
676         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
677
678         Reland the patch since the EWS failure was a false positive.
679
680         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
681         * Scripts/webkitpy/tool/commands/__init__.py:
682         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
683         (AbstractEarlyWarningSystem):
684         (AbstractEarlyWarningSystem.__init__):
685         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
686         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
687         (EarlyWarningSystemTest._default_expected_logs):
688         (_test_ews):
689         (test_ewses):
690
691 2013-04-16  Sam Weinig  <sam@webkit.org>
692
693         Fix fallout after r148545.
694
695         * WebKitTestRunner/TestController.cpp:
696         (WTR::TestController::resetStateToConsistentValues):
697         Remove calls to non-existent API functions.
698
699 2013-04-13  Roger Fong  <roger_fong@apple.com>
700
701         Unreviewed. Disable WinEWS tests, simply not enough bots.
702
703         All bots are running consistently now but the queue still keeps growing.
704         Until we get more bots or make the tests faster, it doesn't seem wise to keep running tests.
705
706         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
707         (WinEWS):
708
709 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
710
711         The list of contributors in committers.py should be a separate JSON
712         https://bugs.webkit.org/show_bug.cgi?id=114673
713
714         Reviewed by Anders Carlsson.
715
716         Added webkitpy/common/config/contributors.json, made CommitterList load it.
717
718         * EWSTools/start-queue-mac.sh:
719         * EWSTools/start-queue.sh:
720         * Scripts/webkitpy/common/checkout/commitinfo.py:
721         (CommitInfo.committer):
722         * Scripts/webkitpy/common/config/contributors.json: Added.
723         * Scripts/webkitpy/common/config/committers.py:
724         (Reviewer.__init__):
725         (CommitterList.__init__):
726         (CommitterList.load_json): Added.
727         (CommitterList.load_json.emails):
728         (CommitterList.load_json.nicks):
729         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
730         (MockCommitInfo.author):
731
732 2013-04-16  Manuel Rego Casasnovas  <rego@igalia.com>
733
734         [EFL] Bump libsoup dependency to 2.42.0
735         https://bugs.webkit.org/show_bug.cgi?id=113927
736
737         Reviewed by Gyuyoung Kim.
738
739         Update libsoup required version to v2.42.0 and GLib to v2.36.0 as
740         required by libsoup for EFL port.
741
742         * efl/jhbuild.modules:
743         * efl/patches/libsoup-2.40-auth-fix.patch: Removed as it's already
744         included in v2.42.0.
745
746 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
747
748         Remove Account class from committers.py
749         https://bugs.webkit.org/show_bug.cgi?id=114671
750
751         Reviewed by Csaba Osztrogonác.
752
753         Account class was added to support watch list email addresses that are not associated with
754         a particular contributor but nobody uses these email address since Chromium port forked.
755
756         Remove it.
757
758         Also removed account_by_login from CommitterList since it was never called except its unittests.
759
760         * Scripts/webkitpy/common/checkout/changelog.py:
761         * Scripts/webkitpy/common/config/committers.py:
762         (Contributor):
763         (Contributor.matches_glob):
764         (Reviewer.__init__):
765         (CommitterList.__init__):
766         (CommitterList._email_to_account_map):
767         (CommitterList._login_to_account_map):
768         (CommitterList.contributors_by_fuzzy_match):
769         (CommitterList.contributor_by_email):
770         (CommitterList.contributor_by_name):
771         (CommitterList.committer_by_email):
772         (CommitterList.reviewer_by_email):
773         * Scripts/webkitpy/common/config/committers_unittest.py:
774         (CommittersTest.test_committer_lookup):
775         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
776         (Bugzilla._commit_queue_flag):
777         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
778         (test_commit_queue_flag):
779         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
780         (WatchListParser._validate):
781
782 2013-04-16  Mike West  <mkwst@chromium.org>
783
784         Unreviewed update to the watchlist.
785
786         Removing 'mkwst+watchlist@chromium.org' from committers.py and the
787         watchist file; moving to 'mkwst@chromium.org' instead.
788
789         * Scripts/webkitpy/common/config/committers.py:
790         * Scripts/webkitpy/common/config/watchlist:
791
792 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
793
794         Move webkitpy.layout_tests.port to webkitpy.port
795         https://bugs.webkit.org/show_bug.cgi?id=114668
796
797         Reviewed by Maciej Stachowiak.
798
799         Moved. Port objects knows a lot more than just layout_tests. They doesn't belong down in layout_tests.
800
801         * Scripts/webkitpy/common/host.py:
802         * Scripts/webkitpy/common/host_mock.py:
803         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
804         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
805         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
806         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
807         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
808         * Scripts/webkitpy/layout_tests/port: Removed.
809         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
810         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
811         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
812         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
813         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
814         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
815         * Scripts/webkitpy/performance_tests/perftest.py:
816         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
817         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
818         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
819         * Scripts/webkitpy/port: Copied from Tools/Scripts/webkitpy/layout_tests/port.
820         * Scripts/webkitpy/port/apple.py:
821         * Scripts/webkitpy/port/base.py:
822         * Scripts/webkitpy/port/base_unittest.py:
823         * Scripts/webkitpy/port/config_unittest.py:
824         (ConfigTest.test_default_configuration__standalone):
825         * Scripts/webkitpy/port/driver_unittest.py:
826         * Scripts/webkitpy/port/efl.py:
827         * Scripts/webkitpy/port/efl_unittest.py:
828         * Scripts/webkitpy/port/factory.py:
829         * Scripts/webkitpy/port/factory_unittest.py:
830         * Scripts/webkitpy/port/gtk.py:
831         * Scripts/webkitpy/port/gtk_unittest.py:
832         * Scripts/webkitpy/port/image_diff.py:
833         * Scripts/webkitpy/port/image_diff_unittest.py:
834         * Scripts/webkitpy/port/leakdetector_unittest.py:
835         * Scripts/webkitpy/port/mac.py:
836         * Scripts/webkitpy/port/mac_unittest.py:
837         * Scripts/webkitpy/port/mock_drt.py:
838         * Scripts/webkitpy/port/mock_drt_unittest.py:
839         * Scripts/webkitpy/port/port_testcase.py:
840         * Scripts/webkitpy/port/qt.py:
841         * Scripts/webkitpy/port/qt_unittest.py:
842         * Scripts/webkitpy/port/server_process_unittest.py:
843         * Scripts/webkitpy/port/test.py:
844         * Scripts/webkitpy/port/win.py:
845         * Scripts/webkitpy/port/win_unittest.py:
846         * Scripts/webkitpy/port/xvfbdriver.py:
847         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
848         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
849         * Scripts/webkitpy/tool/commands/gardenomatic.py:
850         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
851         * Scripts/webkitpy/tool/commands/queries.py:
852         * Scripts/webkitpy/tool/commands/queries_unittest.py:
853         * Scripts/webkitpy/tool/commands/rebaseline.py:
854         * Scripts/webkitpy/tool/servers/gardeningserver.py:
855         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
856         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
857         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
858
859 2013-04-16  Commit Queue  <rniwa@webkit.org>
860
861         Unreviewed, rolling out r148498.
862         http://trac.webkit.org/changeset/148498
863         https://bugs.webkit.org/show_bug.cgi?id=114669
864
865         Appears to have broken EWS (Requested by rniwa on #webkit).
866
867         * Scripts/webkitpy/common/config/ews.json: Removed.
868         * Scripts/webkitpy/tool/commands/__init__.py:
869         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
870         (AbstractEarlyWarningSystem):
871         (AbstractEarlyWarningSystem.__init__):
872         (AbstractEarlyWarningSystem.handle_script_error.does):
873         (GtkEWS):
874         (GtkWK2EWS):
875         (EflEWS):
876         (QtEWS):
877         (QtWK2EWS):
878         (WinEWS):
879         (MacEWS):
880         (MacWK2EWS):
881         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
882         (EarlyWarningSystemTest._default_expected_logs):
883         (_test_ews):
884         (test_ewses):
885
886 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
887
888         Isolate Early Warning System definitions into a JSON
889         https://bugs.webkit.org/show_bug.cgi?id=114558
890
891         Reviewed by Benjamin Poulain.
892
893         Added ews.json to common/config, and made tool/commands/__init__.py call
894         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
895
896         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
897         * Scripts/webkitpy/tool/commands/__init__.py:
898         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
899         (AbstractEarlyWarningSystem):
900         (AbstractEarlyWarningSystem.__init__):
901         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
902         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
903         (EarlyWarningSystemTest._default_expected_logs):
904         (_test_ews):
905         (test_ewses):
906
907 2013-04-15  Ryosuke Niwa  <rniwa@webkit.org>
908
909         WKR gets stuck when there are many merges
910         https://bugs.webkit.org/show_bug.cgi?id=114632
911
912         Reviewed by Andreas Kling.
913
914         Move the last revision forward when it exists in a branch.
915         Otherwise, we'll be stuck looping over revisions made to merge patches.
916
917         * Scripts/webkitpy/tool/commands/newcommitbot.py:
918         (NewCommitBot.next_work_item):
919
920 2013-04-15  Gustavo Noronha Silva  <gns@gnome.org>
921
922         [GTK] Missing a few packages for building on stock Fedora
923         https://bugs.webkit.org/show_bug.cgi?id=113916
924
925         Reviewed by Philippe Normand.
926
927         * gtk/install-dependencies: add packages that are missing.
928
929 2013-04-15  Zan Dobersek  <zdobersek@igalia.com>
930
931         REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
932         https://bugs.webkit.org/show_bug.cgi?id=114602
933
934         Reviewed by Ryosuke Niwa.
935
936         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
937         (CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
938         interface so its value doesn't leak into the following tests.
939
940 2013-04-15  Zan Dobersek  <zandobersek@gmail.com>
941
942         Deprecate land-cowboy in favor of land-cowhand
943         https://bugs.webkit.org/show_bug.cgi?id=104470
944
945         Reviewed by Darin Adler.
946
947         Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
948
949         * Scripts/webkitpy/tool/commands/download.py:
950         (LandCowhand):
951         (LandCowboy):
952         (LandCowboy._prepare_state):
953         * Scripts/webkitpy/tool/commands/download_unittest.py:
954         (test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
955         also checking the deprecation message in the output of the latter.
956
957 2013-04-15  Jonathan Liu  <net147@gmail.com>
958
959         Improve Windows cmd.exe detection
960         https://bugs.webkit.org/show_bug.cgi?id=114620
961
962         Reviewed by Jocelyn Turcotte.
963
964         The current detection code handles Windows cmd.exe and Cygwin shell
965         but not does not handle MSYS shell correctly. Simplify and improve the
966         detection by checking MINGW_IN_SHELL instead as used in other places
967         (e.g. qt_functions.prf).
968
969         * qmake/mkspecs/features/default_pre.prf:
970
971 2013-04-15  Manuel Rego Casasnovas  <rego@igalia.com>
972
973         [webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
974         https://bugs.webkit.org/show_bug.cgi?id=114506
975
976         Reviewed by Philippe Normand.
977
978         * Scripts/webkitpy/common/system/executive.py:
979         (Executive.cpu_count): Modify function in order to use the environment
980         variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
981         greater than 0.
982
983 2013-04-15  Xan Lopez  <xlopez@igalia.com>
984
985         [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
986         https://bugs.webkit.org/show_bug.cgi?id=114615
987
988         Reviewed by Carlos Garcia Campos.
989
990         Enable the style scoped feature if we have support for it.
991
992         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
993         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
994
995 2013-04-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
996
997         [Qt] QtMultimedia not used when GStreamer is not found
998         https://bugs.webkit.org/show_bug.cgi?id=111842
999
1000         Reviewed by Philippe Normand.
1001
1002         Fallback to using QtMultimedia when native libraries are not found.
1003
1004         * qmake/mkspecs/features/features.prf:
1005
1006 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1007
1008         Build fix attempt for webkitbot. Unicodify everything.
1009
1010         * Scripts/webkitpy/tool/bot/irc_command.py:
1011         (Whois.execute):
1012
1013 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1014
1015         webkitbot should provide full name, email address, and IRC nicknames on whois
1016         https://bugs.webkit.org/show_bug.cgi?id=114494
1017
1018         Reviewed by Benjamin Poulain.
1019
1020         A response like the one below is useless. Improve it:
1021         webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?
1022
1023         We now report full name, email address, committer/reviewer status, and IRC nickname.
1024
1025         Also teach webkitbot how to respond to ping.
1026
1027         * Scripts/webkitpy/tool/bot/irc_command.py:
1028         (PingPong): Moved 
1029         (PingPong.execute):
1030         (Whois._full_record_and_nick): Renamed and rewritten.
1031         (Whois.execute):
1032
1033         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1034         (IRCCommandTest.test_whois): Updated test cases as needed.
1035
1036         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1037         (IRCBotTest.test_help): Added ping.
1038
1039         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1040         (NewCommitBot): Teached WKR how to respond to hi.
1041
1042 2013-04-13  Anders Carlsson  <andersca@apple.com>
1043
1044         Add form delegate method that's invoked right before sending a submit event to a form element
1045         https://bugs.webkit.org/show_bug.cgi?id=114575
1046
1047         Reviewed by Dan Bernstein.
1048
1049         Add a test.
1050
1051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1052         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.
1053         (-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
1054         (TestWebKitAPI):
1055         (TestWebKitAPI::TEST):
1056         
1057         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1058         (TestWebKitAPI::Util::toSTD):
1059         Don't crash when a null NSString is passed to toSTD.
1060
1061 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1062
1063         Python test fix attempt after r148360.
1064
1065         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1066         (test_command_help):
1067
1068 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1069
1070         Merge AbstractDeclarativeCommand into Command as a comment suggests
1071         https://bugs.webkit.org/show_bug.cgi?id=114559
1072
1073         Reviewed by Antti Koivisto.
1074
1075         Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
1076         We need to merge a lot more classes to make webkitpy hackable.
1077
1078         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
1079         (AbstractLocalServerCommand):
1080         (AbstractLocalServerCommand.__init__):
1081         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1082         (AbstractSequencedCommand):
1083         (AbstractSequencedCommand.__init__):
1084         * Scripts/webkitpy/tool/commands/adduserstogroups.py:
1085         (AddUsersToGroups):
1086         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1087         (AnalyzeChangeLog):
1088         (AnalyzeChangeLog.__init__):
1089         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
1090         * Scripts/webkitpy/tool/commands/bugfortest.py:
1091         (BugForTest):
1092         * Scripts/webkitpy/tool/commands/bugsearch.py:
1093         (BugSearch):
1094         * Scripts/webkitpy/tool/commands/chromechannels.py:
1095         (ChromeChannels):
1096         (__init__):
1097         * Scripts/webkitpy/tool/commands/download.py:
1098         (AbstractPatchProcessingCommand):
1099         * Scripts/webkitpy/tool/commands/findusers.py:
1100         (FindUsers):
1101         * Scripts/webkitpy/tool/commands/openbugs.py:
1102         (OpenBugs):
1103         * Scripts/webkitpy/tool/commands/queries.py:
1104         (BugsToCommit):
1105         (PatchesInCommitQueue):
1106         (PatchesToCommitQueue):
1107         (PatchesToCommitQueue.__init__):
1108         (PatchesToReview):
1109         (PatchesToReview.__init__):
1110         (PatchesToReview.execute):
1111         (WhatBroke):
1112         (ResultsFor):
1113         (FailureReason):
1114         (FindFlakyTests):
1115         (TreeStatus):
1116         (CrashLog):
1117         (PrintExpectations):
1118         (PrintExpectations.__init__):
1119         (PrintBaselines):
1120         (PrintBaselines.__init__):
1121         * Scripts/webkitpy/tool/commands/queues.py:
1122         (AbstractQueue.__init__):
1123         * Scripts/webkitpy/tool/commands/rebaseline.py:
1124         (AbstractRebaseliningCommand):
1125         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1126         (SuggestNominations):
1127         (SuggestNominations.__init__):
1128         * Scripts/webkitpy/tool/commands/upload.py:
1129         (CommitMessageForCurrentDiff):
1130         (CommitMessageForCurrentDiff.__init__):
1131         (CleanPendingCommit):
1132         (CleanReviewQueue):
1133         (AssignToCommitter):
1134         (PostCommits):
1135         (PostCommits.__init__):
1136         (MarkBugFixed):
1137         (MarkBugFixed.__init__):
1138         (CreateBug):
1139         (CreateBug.__init__):
1140         * Scripts/webkitpy/tool/multicommandtool.py:
1141         (Command):
1142         (Command.__init__):
1143         (Command.main):
1144         (HelpCommand):
1145         (HelpCommand.__init__):
1146         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1147         (TrivialCommand):
1148         (TrivialCommand.__init__):
1149         (LikesToRetry):
1150         (LikesToRetry.__init__):
1151         (CommandTest.test_name_with_arguments):
1152         (CommandTest.test_required_arguments):
1153         (test_command_help):
1154
1155 2013-04-13  Ed Bartosh  <bartosh@gmail.com>
1156
1157         [EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
1158         https://bugs.webkit.org/show_bug.cgi?id=114048
1159
1160         Reviewed by Gyuyoung Kim.
1161
1162         Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)
1163
1164         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1165         (TestRunner::setViewModeMediaFeature):
1166
1167 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1168
1169         Merge watchlistloader into host since it's an unnecessary indirection
1170         https://bugs.webkit.org/show_bug.cgi?id=114555
1171
1172         Reviewed by Antti Koivisto.
1173
1174         We don't need a class to load a file.
1175
1176         * Scripts/webkitpy/common/host.py:
1177         (Host.watch_list):
1178         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
1179         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
1180
1181 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1182
1183         Rename JSONResultsGeneratorBase to JSONResultsGenerator
1184         https://bugs.webkit.org/show_bug.cgi?id=114553
1185
1186         Reviewed by Philippe Normand.
1187
1188         Renamed now that we've got rid of the old JSONResultsGenerator in r148352.
1189
1190         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1191         (JSONLayoutResultsGenerator):
1192         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1193         (JSONResultsGenerator):
1194         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1195         (JSONGeneratorTest._test_json_generation):
1196         (JSONGeneratorTest._verify_json_results):
1197
1198 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1199
1200         Remove more Chromium specific code from webkitpy
1201         https://bugs.webkit.org/show_bug.cgi?id=114552
1202
1203         Reviewed by Philippe Normand.
1204
1205         * Scripts/webkitpy/common/host.py:
1206         (Host.checkout):
1207         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1208         (JSONResultsGeneratorBase):
1209         (JSONResultsGeneratorBase.__init__):
1210         (JSONResultsGeneratorBase._is_results_all_of_type):
1211         * Scripts/webkitpy/layout_tests/port/base.py:
1212         (Port):
1213         (Port.expected_filename):
1214         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1215         (PerfTestsRunner._parse_args):
1216         * Scripts/webkitpy/tool/commands/queues.py:
1217         (PatchProcessingQueue._new_port_name_from_old):
1218         (CommitQueue.did_pass_testing_ews):
1219         * Scripts/webkitpy/tool/commands/rebaseline.py:
1220         (RebaselineTest._results_url):
1221         (Rebaseline._builder_with_name):
1222         * Scripts/webkitpy/tool/mocktool.py:
1223         (MockTool.irc):
1224
1225 2013-04-13  Zan Dobersek  <zdobersek@igalia.com>
1226
1227         Fix flakiness dashboard unit test failures
1228         https://bugs.webkit.org/show_bug.cgi?id=114518
1229
1230         Reviewed by Ryosuke Niwa.
1231
1232         Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
1233         test cases to simulate loading the builders list from the webkit.org build master, replacing
1234         the Chromium builders and platforms that are used in tests with builders and platforms for the
1235         Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
1236         functionality of the dashboard.
1237
1238         This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
1239         code and hopefully general simplification of the dashboard codebase coming in near future.
1240
1241         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1242         (resetGlobals):
1243         (test):
1244         * TestResultServer/static-dashboards/loader_unittests.js:
1245
1246 2013-04-12  David Kilzer  <ddkilzer@apple.com>
1247
1248         BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
1249
1250         Reviewed by Chris Fleizach.
1251
1252         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
1253         -_accessibilityPath from the WebAccessibilityObjectWrapper
1254         class.
1255         (_CGPathEnumerationIteration): Remove unused CGPoint* variable.
1256
1257 2013-04-12  Jeffrey Pfau  <jpfau@apple.com>
1258
1259         Unreviewed, remove an old email address for myself.
1260
1261         * Scripts/webkitpy/common/config/committers.py:
1262
1263 2013-04-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1264
1265         [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
1266         https://bugs.webkit.org/show_bug.cgi?id=110743
1267
1268         Reviewed by Benjamin Poulain.
1269
1270         Adding a new test file to check if loading a page just after WebProcess
1271         has crashed (or was terminated) works. The test executes the
1272         following steps (Load, Crash, Load), thus stressing WebProcess
1273         reattach and process termination code path.
1274
1275         * TestWebKitAPI/GNUmakefile.am:
1276         * TestWebKitAPI/PlatformEfl.cmake:
1277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1278         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1279         (TestWebKitAPI::setPageLoaderClient):
1280         (TestWebKitAPI::TEST):
1281         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
1282         (TestWebKitAPI):
1283         (WebKit2CrashLoader):
1284         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1285         (TestWebKitAPI::WebKit2CrashLoader::loadUrl):
1286         (TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
1287         (TestWebKitAPI::didFinishLoad):
1288         (TestWebKitAPI::TEST):
1289         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1290
1291 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1292
1293         [Mac] REGRESSION: Auto substitution strips new lines
1294         https://bugs.webkit.org/show_bug.cgi?id=114537
1295
1296         Reviewed by Enrica Casucci.
1297
1298         Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
1299
1300         * DumpRenderTree/mac/DumpRenderTree.mm:
1301         (resetDefaultsToConsistentValues):
1302
1303 2013-04-09  Roger Fong  <roger_fong@apple.com>
1304
1305         Re-enable WinEWS tests.
1306
1307         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1308         (WinEWS):
1309
1310 2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1311
1312         [GTK] Split GtkAuthenticationDialog in two widgets
1313         https://bugs.webkit.org/show_bug.cgi?id=103644
1314
1315         Reviewed by Xan Lopez.
1316
1317         * gtk/generate-gtkdoc:
1318         (get_webkit2_options): Do not generate api docs for
1319         WebKitAuthenticationDialog which is private in WebKit2.
1320         (get_webkit1_options): Do not generate api docs for
1321         webkitauthenticationdialog which is private in WebKit1.
1322
1323 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1324
1325         WebKit Queues should capitalize K in Wk2
1326         https://bugs.webkit.org/show_bug.cgi?id=114524
1327
1328         Reviewed by Philippe Normand.
1329
1330         * QueueStatusServer/model/queues.py:
1331         (Queue.display_name):
1332
1333 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1334
1335         [Mac] Enable spellchecking tests added in r141471
1336         https://bugs.webkit.org/show_bug.cgi?id=108525
1337
1338         Reviewed by Darin Adler.
1339
1340         * DumpRenderTree/mac/DumpRenderTree.mm:
1341         (createWebViewAndOffscreenWindow):
1342         (resetDefaultsToConsistentValues):
1343         * WebKitTestRunner/TestController.cpp:
1344         (WTR::TestController::resetStateToConsistentValues):
1345
1346 2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>
1347
1348         [GTK] Enable WebKit2 building on GTK EWSs
1349         https://bugs.webkit.org/show_bug.cgi?id=114500
1350
1351         Reviewed by Philippe Normand.
1352
1353         Add configuration in order to be able to setup GTK EWSs building
1354         WebKit2. A new queue gtk-wk2-ews is added.
1355
1356         * QueueStatusServer/config/queues.py:
1357         * Scripts/webkitpy/common/config/ports.py:
1358         (DeprecatedPort.port):
1359         (GtkWK2Port):
1360         (GtkWK2Port.build_webkit_command):
1361         (GtkWK2Port.run_webkit_tests_command):
1362         * Scripts/webkitpy/common/config/ports_unittest.py:
1363         (DeprecatedPortTest.test_gtk_port):
1364         (DeprecatedPortTest):
1365         (DeprecatedPortTest.test_gtk_wk2_port):
1366         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1367         (GtkWK2EWS):
1368
1369 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1370
1371         Remove Chromium scripts
1372         https://bugs.webkit.org/show_bug.cgi?id=114492
1373
1374         Reviewed by Benjamin Poulain.
1375
1376         * Scripts/run-chromium-webkit-unit-tests: Removed.
1377         * Scripts/update-webkit-chromium: Removed.
1378
1379 2013-04-12  Commit Queue  <rniwa@webkit.org>
1380
1381         Unreviewed, rolling out r148262.
1382         http://trac.webkit.org/changeset/148262
1383         https://bugs.webkit.org/show_bug.cgi?id=114493
1384
1385         Cairo dep should now build, rolling r148247 back in (Requested
1386         by zdobersek on #webkit).
1387
1388         * Scripts/webkitdirs.pm:
1389         (buildAutotoolsProject):
1390         * gtk/jhbuild.modules:
1391
1392 2013-04-11  Commit Queue  <rniwa@webkit.org>
1393
1394         Unreviewed, rolling out r148247.
1395         http://trac.webkit.org/changeset/148247
1396         https://bugs.webkit.org/show_bug.cgi?id=114490
1397
1398         Cairo dep fails to build on builders due to missing EGL
1399         headers (Requested by zdobersek on #webkit).
1400
1401         * Scripts/webkitdirs.pm:
1402         (buildAutotoolsProject):
1403         * gtk/jhbuild.modules:
1404
1405 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
1406
1407         [GTK] Add accelerated 2D canvas support using cairo-gl
1408         https://bugs.webkit.org/show_bug.cgi?id=104672
1409
1410         Reviewed by Alejandro G. Castro.
1411
1412         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
1413         dependencies, don't override value of the setting determined by configure.
1414         This will make it easier for people using build-webkit, but not the
1415         WebKit JHBuild.
1416
1417         * Scripts/webkitdirs.pm:
1418         (buildAutotoolsProject): Add a blacklist for settings to never override.
1419         * gtk/jhbuild.modules: Build CairoGL.
1420
1421 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1422
1423         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
1424         https://bugs.webkit.org/show_bug.cgi?id=114477
1425
1426         Reviewed by Benjamin Poulain.
1427
1428         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1429
1430 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1431
1432         Leaks builder should not be triggered upon new commits
1433         https://bugs.webkit.org/show_bug.cgi?id=114475
1434
1435         Reviewed by Jessie Berlin.
1436
1437         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
1438         the leak builder when builds are done.
1439
1440         * BuildSlaveSupport/build.webkit.org-config/config.json:
1441
1442 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
1443
1444         [GTK] Windows build failure after r136056
1445         https://bugs.webkit.org/show_bug.cgi?id=114121
1446
1447         Reviewed by Martin Robinson.
1448
1449         * TestWebKitAPI/config.h: Make sure defines are correct for other
1450         Windows ports than apple-win.
1451
1452 2013-04-11  Ojan Vafai  <ojan@chromium.org>
1453
1454         Remove myself from watchlists.
1455         * Scripts/webkitpy/common/config/watchlist:
1456
1457 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1458
1459         Build fix. Don't hard-code queues.webkit.org at least during the transition.
1460
1461         * QueueStatusServer/templates/statusbubble.html:
1462
1463 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1464
1465         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
1466         https://bugs.webkit.org/show_bug.cgi?id=114397
1467
1468         Reviewed by Benjamin Poulain.
1469
1470         Reland the patch since Alan appears to have finished the migration.
1471
1472         * Scripts/webkitpy/common/net/statusserver.py:
1473         (StatusServer):
1474
1475 2013-04-11  Brian Holt  <brian.holt@samsung.com>
1476
1477         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
1478         https://bugs.webkit.org/show_bug.cgi?id=76796
1479
1480         Reviewed by Chris Fleizach.
1481
1482         Make the Gtk window for the DRT a toplevel so that it gets the
1483         focus from the window manager when the test starts.
1484
1485         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1486         (main):
1487
1488 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1489
1490         Use CSS4 image-rendering to determing image scaling quality
1491         https://bugs.webkit.org/show_bug.cgi?id=113405
1492
1493         Reviewed by Simon Fraser.
1494
1495         Introduce new flag to enable experimental support for CSS4 Images.
1496
1497         * Scripts/webkitperl/FeatureList.pm:
1498
1499 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1500
1501         Remove code for Chromium from wkbuild.py
1502         https://bugs.webkit.org/show_bug.cgi?id=114423
1503
1504         Reviewed by Benjamin Poulain.
1505
1506         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1507         (_should_file_trigger_build):
1508         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1509         (ShouldBuildTest):
1510
1511 2013-04-11  Philippe Normand  <pnormand@igalia.com>
1512
1513         Unreviewed, update my IRC nickname.
1514
1515         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
1516
1517 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1518
1519         Remove the rest of Chromium code from webkitpy
1520         https://bugs.webkit.org/show_bug.cgi?id=114420
1521
1522         Reviewed by Benjamin Poulain.
1523
1524         * Scripts/webkitpy/common/config/urls.py:
1525         (view_revision_url):
1526         * Scripts/webkitpy/common/host.py:
1527         (Host._engage_awesome_locale_hacks):
1528         (Host.initialize_scm):
1529         (Host):
1530         * Scripts/webkitpy/common/host_mock.py:
1531         (MockHost.__init__):
1532         (MockHost.checkout):
1533         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
1534         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1535         (JSONResultsGeneratorBase._insert_generic_metadata):
1536         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1537         (TestExpectationParser._tokenize_line):
1538         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1539         (ExpectationSyntaxTests.test_bare_name_and_bugs):
1540         (ExpectationSyntaxTests.test_warnings):
1541         * Scripts/webkitpy/layout_tests/port/base.py:
1542         (Port.skips_perf_test):
1543         (Port.path_to_test_expectations_file):
1544         (Port._port_flag_for_scripts):
1545         * Scripts/webkitpy/style/checkers/cpp.py:
1546         (check_function_definition):
1547         (check_include_line):
1548         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1549         (OrderOfIncludesTest.test_check_wtf_includes):
1550         (WebKitStyleTest.test_webkit_export_check):
1551         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1552         (TestExpectationsTestCase.test_valid_expectations):
1553         * Scripts/webkitpy/tool/bot/irc_command.py:
1554         (Rollout.execute):
1555         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1556         (IRCCommandTest.test_whois):
1557         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1558         (IRCBotTest.test_help):
1559         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1560         (SheriffBotTest.test_command_aliases):
1561
1562 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1563
1564         roll-chromium-deps doesn't roll DEPS
1565         https://bugs.webkit.org/show_bug.cgi?id=114421
1566
1567         Reviewed by Antti Koivisto.
1568
1569         Roll DEPS. Rolling DEPS. Rolled DEPS.
1570
1571         * Scripts/webkitpy/tool/bot/irc_command.py:
1572         (RollChromiumDEPS.execute):
1573
1574 2013-04-11  Glenn Adams  <glenn@skynav.com>
1575
1576         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
1577         https://bugs.webkit.org/show_bug.cgi?id=114418
1578
1579         Reviewed by Ryosuke Niwa.
1580
1581         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1582         (MockSCM.add): Remove optional remove_exit_code argument.
1583         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
1584         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1585         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
1586         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
1587
1588 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1589
1590         Fix roll-chromium-deps and hi.
1591
1592         * Scripts/webkitpy/tool/bot/irc_command.py:
1593         (Hi.execute):
1594         (RollChromiumDEPS.execute):
1595
1596 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1597
1598         Remove webkitpy code to roll Chromium DEPS
1599         https://bugs.webkit.org/show_bug.cgi?id=114415
1600
1601         Reviewed by Benjamin Poulain.
1602
1603         Removed the code to roll Chromium DEPS in WebKit.
1604
1605         * Scripts/webkitpy/common/checkout/checkout.py:
1606         (Checkout.bug_id_for_this_commit):
1607         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1608         (MockCheckout.commit_message_for_this_commit):
1609         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1610         (CheckoutTest.test_suggested_reviewers):
1611         * Scripts/webkitpy/common/checkout/deps.py: Removed.
1612         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
1613         * Scripts/webkitpy/tool/bot/irc_command.py:
1614         (RollChromiumDEPS): Teach webkitbot a sense of humor.
1615         (RollChromiumDEPS.execute):
1616         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1617         (IRCCommandTest.test_create_bug):
1618         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1619         (IRCBotTest.test_revert):
1620         * Scripts/webkitpy/tool/bot/sheriff.py:
1621         (Sheriff.post_rollout_patch):
1622         * Scripts/webkitpy/tool/commands/__init__.py:
1623         * Scripts/webkitpy/tool/commands/roll.py: Removed.
1624         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
1625         * Scripts/webkitpy/tool/steps/__init__.py:
1626         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
1627         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
1628         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
1629
1630 2013-04-11  Glenn Adams  <glenn@skynav.com>
1631
1632         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
1633         https://bugs.webkit.org/show_bug.cgi?id=114386
1634
1635         Reviewed by Benjamin Poulain.
1636
1637         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
1638         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
1639         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
1640         by default and to return exit code 1 if a file/dir had already been added.
1641
1642         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1643         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
1644         * Scripts/webkitpy/common/checkout/scm/svn.py:
1645         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
1646
1647 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1648
1649         Unreviewed.
1650
1651         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
1652
1653 2013-04-10  Glenn Adams  <glenn@skynav.com>
1654
1655         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
1656         https://bugs.webkit.org/show_bug.cgi?id=114410
1657
1658         Reviewed by Ryosuke Niwa.
1659
1660         * Scripts/webkitpy/common/checkout/scm/git.py:
1661         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
1662         * Scripts/webkitpy/common/checkout/scm/scm.py:
1663         (SCM.add): Remove optional return_exit_code argument.
1664         (SCM.add_list): Remove optional return_exit_code argument.
1665         * Scripts/webkitpy/common/checkout/scm/svn.py:
1666         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
1667
1668 2013-04-10  Eric Seidel  <eric@webkit.org>
1669
1670         Remove myself from the watchlists, I'm getting too much bug mail. :)
1671
1672         * Scripts/webkitpy/common/config/watchlist:
1673
1674 2013-04-10  Commit Queue  <rniwa@webkit.org>
1675
1676         Unreviewed, rolling out r148158.
1677         http://trac.webkit.org/changeset/148158
1678         https://bugs.webkit.org/show_bug.cgi?id=114405
1679
1680         We need to migrate status data (Requested by rniwa on
1681         #webkit).
1682
1683         * Scripts/webkitpy/common/net/statusserver.py:
1684         (StatusServer):
1685
1686 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
1687
1688         Mass remove all the empty directories
1689
1690         Rubberstamped by Ryosuke Niwa.
1691
1692         * BuildSlaveSupport/gtk/crashmon/log: Removed.
1693         * BuildSlaveSupport/gtk/xvfb/log: Removed.
1694         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
1695         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
1696         * MiniBrowser/gtk/WebBundle: Removed.
1697         * MiniBrowser/win: Removed.
1698         * QtTestPlatformPlugin/mac: Removed.
1699         * Scripts/webkitpy/tool/bot/testdata: Removed.
1700         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
1701         * efl/ImageDiff: Removed.
1702         * iExploder/htdocs: Removed.
1703         * iExploder/iexploder-1.7.2/output: Removed.
1704         * iExploder/tools: Removed.
1705         * qmake/config.tests/libexecdir: Removed.
1706         * qmake/config.tests/libjpeg: Removed.
1707         * qmake/config.tests/libpng: Removed.
1708
1709 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1710
1711         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
1712         https://bugs.webkit.org/show_bug.cgi?id=114397
1713
1714         Reviewed by Benjamin Poulain.
1715
1716         * Scripts/webkitpy/common/net/statusserver.py:
1717         (StatusServer):
1718
1719 2013-04-10  Adam Barth  <abarth@webkit.org>
1720
1721         Remove abarth from watchlists
1722         https://bugs.webkit.org/show_bug.cgi?id=114390
1723
1724         Reviewed by Ryosuke Niwa.
1725
1726         I'm trying to cut down on the amount of bugmail I get so that I'll have
1727         more of a chance to notice a piece of bugmail directed at me.
1728
1729         * Scripts/webkitpy/common/config/watchlist:
1730
1731 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1732
1733         webkit-test-results.appspot.com loads the dashboard for Chromium by default
1734         https://bugs.webkit.org/show_bug.cgi?id=114381
1735
1736         Reviewed by Benjamin Poulain.
1737
1738         Changed the defaults.
1739
1740         * TestResultServer/static-dashboards/builders.js:
1741         * TestResultServer/static-dashboards/dashboard_base.js:
1742         (currentBuilderGroupCategory):
1743
1744 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1745
1746         Remove Chromium EWS bots from the queue status server
1747         https://bugs.webkit.org/show_bug.cgi?id=113988
1748
1749         Reviewed by Benjamin Poulain.
1750
1751         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
1752
1753         * QueueStatusServer/app.yaml:
1754         * QueueStatusServer/config/queues.py:
1755         * QueueStatusServer/model/queues.py:
1756         (Queue.short_name):
1757         (Queue.display_name):
1758         * QueueStatusServer/model/queues_unittest.py:
1759         (QueueTest.test_short_name):
1760         (QueueTest.test_display_name):
1761         (QueueTest.test_name_with_underscores):
1762         * QueueStatusServer/templates/activebots.html:
1763
1764 2013-04-10  Ojan Vafai  <ojan@chromium.org>
1765
1766         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
1767         https://bugs.webkit.org/show_bug.cgi?id=114370
1768
1769         Reviewed by Ryosuke Niwa.
1770
1771         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
1772         Unfortunately, there's no way to test this until this is committed and there is
1773         a master restart.
1774
1775         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1781         * TestResultServer/generate_builders_json.py:
1782         * TestResultServer/static-dashboards/dashboard_base.js:
1783         * TestResultServer/static-dashboards/loader.js:
1784
1785 2013-04-10  Glenn Adams  <glenn@skynav.com>
1786
1787         [Qt] Fix regression to test-webkitpy.
1788         https://bugs.webkit.org/show_bug.cgi?id=114368
1789
1790         Reviewed by Ryosuke Niwa.
1791
1792         * Scripts/webkitpy/layout_tests/port/factory.py:
1793         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
1794         (PortFactory.get): Remove obsolete chromium port related code.
1795         * Scripts/webkitpy/layout_tests/port/mac.py:
1796         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
1797
1798 2013-04-10  Anders Carlsson  <andersca@apple.com>
1799
1800         Remove unneeded headers from FrameLoader.h
1801         https://bugs.webkit.org/show_bug.cgi?id=114223
1802
1803         Reviewed by Geoffrey Garen.
1804
1805         Add back headers implicitly included by other headers.
1806
1807         * WebKitTestRunner/WorkQueueManager.cpp:
1808
1809 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1810
1811         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
1812         https://bugs.webkit.org/show_bug.cgi?id=114365
1813
1814         Reviewed by Martin Robinson.
1815
1816         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
1817         The patch addresses crashes in the tally_event_reply method. It is already committed into the
1818         at-spi2-atk source tree and will be available with the next stable release, after which the
1819         patch should be removed and the dependency version bumped.
1820
1821         * gtk/jhbuild.modules:
1822         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
1823
1824 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
1825
1826         [WinCairo] Unreviewed build fix. Correct DropBox download link.
1827
1828         * Scripts/update-webkit-wincairo-libs: Revise download URL to
1829         match change in DropBox server behavior.
1830
1831 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
1832
1833         Removed an annoying message from svn-create-patch
1834         https://bugs.webkit.org/show_bug.cgi?id=114332
1835
1836         Reviewed by Alexey Proskuryakov.
1837
1838         I see this message basically every time I write a patch, so it must not
1839         be true.
1840
1841         * Scripts/svn-create-patch:
1842         (generateDiff):
1843
1844 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
1845
1846         [GTK] Add support for Page Visibility
1847         https://bugs.webkit.org/show_bug.cgi?id=97324
1848
1849         Reviewed by Sam Weinig.
1850
1851         Implemented test runner API for page visibility layout tests.
1852
1853         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1854         (TestRunner::resetPageVisibility):
1855         (TestRunner::setPageVisibility):
1856         * Scripts/webkitperl/FeatureList.pm:
1857
1858 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1859
1860         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
1861         https://bugs.webkit.org/show_bug.cgi?id=114342
1862
1863         Reviewed by Gyuyoung Kim.
1864
1865         Commit 148033 only added an implementation for the Mac port, which made
1866         other ports fail most tests since loading the injected bundle failed
1867         with a missing symbol.
1868
1869         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1870         (WTR::AccessibilityUIElement::pathDescription):
1871
1872 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
1873
1874         [EFL] Add spell checking option to MiniBrowser
1875         https://bugs.webkit.org/show_bug.cgi?id=114282
1876
1877         Reviewed by Ryosuke Niwa.
1878
1879         Spell checking is enabled by adding a flag (t/text-checking)
1880         with launching MiniBrowser.
1881
1882         * MiniBrowser/efl/main.c:
1883         (window_create):
1884         (elm_main):
1885
1886 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1887
1888         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
1889         https://bugs.webkit.org/show_bug.cgi?id=113281
1890
1891         Reviewed by Darin Adler.
1892
1893         * Scripts/run-gtk-tests:
1894         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
1895
1896 2013-04-09  Glenn Adams  <glenn@skynav.com>
1897
1898         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
1899
1900         Unreviewed.
1901
1902         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1903         (RunTest.test_build_check):
1904
1905 2013-04-09  Glenn Adams  <glenn@skynav.com>
1906
1907         [webkitpy] Remove chromium ports.
1908         https://bugs.webkit.org/show_bug.cgi?id=114326
1909
1910         Reviewed by Dirk Pranke.
1911
1912         As a side effect, also:
1913
1914         - remove chromium builders from webkitpy.layout_tests.port.builders
1915         - remove chromium builders from rebaseline
1916         - rewrite chromium dependent tests in rebaseline_unittest
1917         - remove chromium platform from garden-o-matic
1918         - select apple platform as default platform in garden-o-matic
1919         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
1920
1921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1923         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1924         (BaselineOptimizerTest.test_move_baselines):
1925         (BaselineOptimizerTest.test_efl):
1926         (BaselineOptimizerTest.test_no_add_mac_future):
1927         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1928         (BaselineOptimizerTest.test_common_directory_includes_root):
1929         (BaselineOptimizerTest.test_complex_shadowing):
1930         (BaselineOptimizerTest.test_virtual_ports_filtered):
1931         * Scripts/webkitpy/layout_tests/port/builders.py:
1932         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
1933         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
1934         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
1935         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
1936         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
1937         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
1938         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
1939         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
1940         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
1941         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
1942         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
1943         * Scripts/webkitpy/layout_tests/port/factory.py:
1944         (platform_options):
1945         (PortFactory):
1946         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1947         (FactoryTest.test_qt):
1948         (FactoryTest.test_get_from_builder_name):
1949         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1950         (RunTest.test_build_check):
1951         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1952         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1953         * Scripts/webkitpy/tool/commands/rebaseline.py:
1954         (Rebaseline._builders_to_pull_from):
1955         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1956         (_BaseTestCase):
1957         (_BaseTestCase.setUp):
1958         (TestRebaselineTest.setUp):
1959         (TestRebaselineTest.test_baseline_directory):
1960         (test_rebaseline_updates_expectations_file):
1961         (test_rebaseline_does_not_include_overrides):
1962         (test_rebaseline_test):
1963         (test_rebaseline_test_and_print_scm_changes):
1964         (test_rebaseline_and_copy_test):
1965         (test_rebaseline_and_copy_test_no_existing_result):
1966         (test_rebaseline_and_copy_test_with_lion_result):
1967         (test_rebaseline_and_copy_no_overwrite_test):
1968         (TestRebaselineExpectations.test_rebaseline_expectations):
1969
1970 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1971
1972         newcommitbot (WKR) requires a subversion checkout
1973         https://bugs.webkit.org/show_bug.cgi?id=114309
1974
1975         Reviewed by Benjamin Poulain.
1976
1977         Directly talk to the subversion server instead of relying on a local checkout.
1978         This allows us to run WKR off of a git clone.
1979
1980         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1981         (NewCommitBot.next_work_item):
1982         (NewCommitBot.process_work_item):
1983
1984 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1985
1986         webkitbot refers to sheriffbot in help
1987         https://bugs.webkit.org/show_bug.cgi?id=114307
1988
1989         Reviewed by Benjamin Poulain.
1990
1991         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
1992
1993         * Scripts/webkitpy/tool/bot/irc_command.py:
1994         (Help):
1995         (Help.execute):
1996         (RollChromiumDEPS.execute):
1997         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1998         (IRCBotTest.test_help):
1999         * Scripts/webkitpy/tool/bot/sheriff.py:
2000         (Sheriff.name):
2001
2002 2013-04-06  Roger Fong  <roger_fong@apple.com>
2003
2004         Kill old processes between runs on WinEWS bots.
2005         Temporarily disable tests to let bots catch up again.
2006
2007         * EWSTools/start-queue-win.sh:
2008         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2009         (WinEWS):
2010
2011 2013-04-09  Glenn Adams  <glenn@skynav.com>
2012
2013         [webkitpy] Remove chromium deprecated port support.
2014         https://bugs.webkit.org/show_bug.cgi?id=114228
2015
2016         Reviewed by Ryosuke Niwa.
2017
2018         * Scripts/webkitpy/common/config/ports.py:
2019         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
2020         (ChromiumPort): Removed.
2021         (ChromiumAndroidPort): Removed.
2022         (ChromiumXVFBPort): Removed.
2023         * Scripts/webkitpy/common/config/ports_unittest.py:
2024         (DeprecatedPortTest.test_chromium_port): Removed.
2025         (DeprecatedPortTest.test_chromium_android_port): Removed.
2026         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
2027         * Scripts/webkitpy/tool/steps/update_unittest.py:
2028         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
2029         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
2030
2031 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
2032
2033         AX: The bounding paths should be made available through accessibility
2034         https://bugs.webkit.org/show_bug.cgi?id=113817
2035
2036         Reviewed by David Kilzer.
2037
2038         Add a pathDescription property for testing so that it's possible
2039         to verify that a path is being returned correctly.
2040
2041         * DumpRenderTree/AccessibilityUIElement.cpp:
2042         (getPathDescriptionCallback):
2043         (AccessibilityUIElement::pathDescription):
2044         (AccessibilityUIElement::getJSClass):
2045         * DumpRenderTree/AccessibilityUIElement.h:
2046         (AccessibilityUIElement):
2047         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2048         (_CGPathEnumerationIteration):
2049         (AccessibilityUIElement::pathDescription):
2050         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2051         (AccessibilityUIElement::pathDescription):
2052         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2053         (WTR::AccessibilityUIElement::pathDescription):
2054         (WTR):
2055         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2056         (AccessibilityUIElement):
2057         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2058         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2059         (WTR::AccessibilityUIElement::pathDescription):
2060         (WTR):
2061
2062 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2063
2064         [EFL] Declare TEST_THEME_DIR in a single place.
2065         https://bugs.webkit.org/show_bug.cgi?id=114285
2066
2067         Reviewed by Anders Carlsson.
2068
2069         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
2070
2071         * DumpRenderTree/efl/CMakeLists.txt:
2072         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2073         (DumpRenderTreeChrome::createView):
2074         (DumpRenderTreeChrome::createInspectorView):
2075         (DumpRenderTreeChrome::initialize):
2076         (DumpRenderTreeChrome::onDownloadRequest):
2077         * EWebLauncher/CMakeLists.txt:
2078         * EWebLauncher/main.c:
2079         (findThemePath):
2080         * EWebLauncher/url_bar.c:
2081         (url_bar_add):
2082         * MiniBrowser/efl/CMakeLists.txt:
2083         * MiniBrowser/efl/main.c:
2084         (window_create):
2085         * TestWebKitAPI/PlatformEfl.cmake:
2086         * TestWebKitAPI/efl/PlatformWebView.cpp:
2087         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2088         * WebKitTestRunner/PlatformEfl.cmake:
2089         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2090         (WTR::PlatformWebView::PlatformWebView):
2091
2092 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
2093
2094         [GTK][AC] upversion of clutter and its dependecy
2095         https://bugs.webkit.org/show_bug.cgi?id=114016
2096
2097         Reviewed by Gustavo Noronha Silva.
2098
2099         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
2100
2101         * gtk/jhbuild-optional.modules:
2102
2103 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2104
2105         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
2106         https://bugs.webkit.org/show_bug.cgi?id=89875
2107
2108         Reviewed by Maciej Stachowiak.
2109
2110         Add unit tests to verify if the handling of the open, openat, creat syscall
2111         is being done right. We check if the Read/Write/ReadAndWrite permissions
2112         are respected, if the canonical path is being resolved and if
2113         the permissions are falling back to the topmost parent directory with a
2114         policy set when the directory being opened has no policy.
2115
2116         We also test if any attempt of blocking SIGSYS is silently ignored.
2117         SIGSYS cannot be blocked because in it's handler is where we hook
2118         syscalls to the broker process.
2119
2120         Also added libseccomp to EFL's jhbuild to make the life of developers
2121         willing to help easier.
2122
2123         * Scripts/webkitperl/FeatureList.pm:
2124         * TestWebKitAPI/PlatformEfl.cmake:
2125         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
2126         (TestWebKitAPI):
2127         (SeccompEnvironment):
2128         (TestWebKitAPI::SeccompEnvironment::SetUp):
2129         (TestWebKitAPI::SeccompEnvironment::TearDown):
2130         (TestWebKitAPI::dummyHandler):
2131         (TestWebKitAPI::TEST):
2132         (TestWebKitAPI::stressTest):
2133         * efl/jhbuild.modules:
2134         * qmake/mkspecs/features/features.pri:
2135
2136 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
2137
2138         REGRESSION: Autocorrection doesn't work in DumpRenderTree
2139         https://bugs.webkit.org/show_bug.cgi?id=113846
2140
2141         Reviewed by Alexey Proskuryakov.
2142
2143         The problem was that we were replacing NSSpellCheck's dictionary with our own
2144         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
2145
2146         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
2147         and "would" respectively in DumpRenderTree.
2148
2149         * DumpRenderTree/mac/DumpRenderTree.mm:
2150         (resetDefaultsToConsistentValues):
2151
2152 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
2153
2154         Remove the gyp files for Tools
2155         https://bugs.webkit.org/show_bug.cgi?id=114248
2156
2157         Reviewed by Ryosuke Niwa.
2158
2159         * DumpRenderTree/DumpRenderTree.gyp: Removed.
2160         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
2161         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
2162         * DumpRenderTree/DumpRenderTree.gypi: Removed.
2163         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
2164         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
2165         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
2166         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
2167
2168 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2169
2170         WKR (new-commit-bot) is too slow
2171         https://bugs.webkit.org/show_bug.cgi?id=110087
2172
2173         Reviewed by Geoffrey Garen.
2174
2175         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
2176         Just run "svn log -r <revision>" instead to cut down the delay.
2177
2178         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
2179
2180         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2181         (NewCommitBot):
2182         (NewCommitBot.next_work_item):
2183         (NewCommitBot._is_empty_log):
2184         (NewCommitBot._update_checkout):
2185
2186 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2187
2188         Build fix. Can't remove appendCustomBuildFlags.
2189
2190         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2191         (appendCustomBuildFlags):
2192
2193 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2194
2195         Remove Chromium builders from build.webkit.org
2196         https://bugs.webkit.org/show_bug.cgi?id=113990
2197
2198         Reviewed by Benjamin Poulain.
2199
2200         Removed.
2201
2202         * BuildSlaveSupport/build.webkit.org-config/config.json:
2203         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2204         (InstallGtkDependencies):
2205         (RunUnitTests.start):
2206         (RunWebKit2Tests.start):
2207         (Factory.__init__):
2208         (unitTestsSupported):
2209         (TestFactory.__init__):
2210         (BuildAndTestFactory.__init__):
2211         (BuildAndPerfTestFactory.__init__):
2212         (BuildAndPerfTestWebKit2Factory.__init__):
2213         (DownloadAndPerfTestFactory.__init__):
2214         (loadBuilderConfig):
2215         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2216
2217 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
2218
2219         Remove HTML Notification
2220         https://bugs.webkit.org/show_bug.cgi?id=114231
2221
2222         Reviewed by Ryosuke Niwa.
2223
2224         * qmake/mkspecs/features/features.pri:
2225
2226 2013-04-08  Glenn Adams  <glenn@skynav.com>
2227
2228         Remove chromium EWS support, and fix broken test.
2229         https://bugs.webkit.org/show_bug.cgi?id=114221
2230
2231         Reviewed by Ryosuke Niwa.
2232
2233         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2234         (AbstractChromiumEWS): Removed.
2235         (ChromiumLinuxEWS): Removed.
2236         (ChromiumLinuxDebugEWS): Removed.
2237         (ChromiumWindowsEWS): Removed.
2238         (ChromiumAndroidEWS): Removed.
2239         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2240         (EarlyWarningSystemTest): Fix misspelled class name.
2241         (test_ewses): Fix entry point name to ensure test is run.
2242
2243 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
2244
2245         [WIN] Remove WebKit2 source code
2246         https://bugs.webkit.org/show_bug.cgi?id=114096
2247
2248         Reviewed by Anders Carlsson.
2249
2250         Remove the windows specific parts of the MiniBrowser.
2251
2252         * MiniBrowser/MiniBrowser.vcproj: Removed.
2253         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
2254         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
2255         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
2256         * MiniBrowser/win/BrowserView.cpp: Removed.
2257         * MiniBrowser/win/BrowserView.h: Removed.
2258         * MiniBrowser/win/BrowserWindow.cpp: Removed.
2259         * MiniBrowser/win/BrowserWindow.h: Removed.
2260         * MiniBrowser/win/MiniBrowser.cpp: Removed.
2261         * MiniBrowser/win/MiniBrowser.h: Removed.
2262         * MiniBrowser/win/MiniBrowser.rc: Removed.
2263         * MiniBrowser/win/main.cpp: Removed.
2264         * MiniBrowser/win/resource.h: Removed.
2265         * MiniBrowser/win/stdafx.cpp: Removed.
2266         * MiniBrowser/win/stdafx.h: Removed.
2267
2268 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2269
2270         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
2271
2272         * Scripts/webkitpy/common/config/irc.py:
2273
2274 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
2275
2276         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
2277         https://bugs.webkit.org/show_bug.cgi?id=113139
2278
2279         Reviewed by Anders Carlsson.
2280
2281         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2282         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2283         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2284         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
2285         (ToStringAndValueOfObject):
2286         (ToStringAndValueOfObject::ToStringAndValueOfObject):
2287         (ScriptableObject):
2288         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
2289         (ToStringAndValueOfObject::ScriptableObject::invoke):
2290         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
2291         (ToStringAndValueOfObject::NPP_GetValue):
2292         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2293         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2294         * GNUmakefile.am:
2295
2296 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
2297
2298         [GTK] Bump gnome-themes-standard to 3.6.0
2299         https://bugs.webkit.org/show_bug.cgi?id=114155
2300
2301         Reviewed by Martin Robinson.
2302
2303         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
2304         dependency of gnome-themes-standard accordingly.
2305
2306 2013-04-08  David Levin  <levin@chromium.org>
2307
2308         Remove my watchlist entries.
2309         https://bugs.webkit.org/show_bug.cgi?id=114180
2310
2311         Reviewed by Adam Barth.
2312
2313         * Scripts/webkitpy/common/config/committers.py:
2314         * Scripts/webkitpy/common/config/watchlist:
2315
2316 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2317
2318         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
2319         https://bugs.webkit.org/show_bug.cgi?id=114161
2320
2321         Reviewed by Gyuyoung Kim.
2322
2323         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
2324         as it is crashing due to Bug 111074.
2325
2326         * TestWebKitAPI/PlatformEfl.cmake:
2327
2328 2013-04-07  David Kilzer  <ddkilzer@apple.com>
2329
2330         Remove the rest of SVG_DOM_OBJC_BINDINGS
2331         <http://webkit.org/b/114112>
2332
2333         Reviewed by Geoffrey Garen.
2334
2335         * Scripts/webkitperl/FeatureList.pm:
2336         - Remove --svg-dom-objc-bindings switch.
2337         * qmake/mkspecs/features/features.pri:
2338         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
2339
2340 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
2341
2342         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
2343         https://bugs.webkit.org/show_bug.cgi?id=114089
2344
2345         Reviewed by Chris Fleizach.
2346
2347         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
2348         * DumpRenderTree/AccessibilityController.cpp:
2349         * DumpRenderTree/AccessibilityUIElement.cpp:
2350         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2351         (DumpRenderTreeChrome::DumpRenderTreeChrome):
2352         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2353         (DumpRenderTreeChrome):
2354
2355 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
2356
2357         Build fix after r147857, remove remaining USE(JSC) guards.
2358
2359         Unreviewed.
2360
2361         * DumpRenderTree/config.h:
2362         * TestWebKitAPI/config.h:
2363         * WebKitTestRunner/config.h:
2364
2365 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2366
2367         Rename sheriffbot to webkitbot
2368         https://bugs.webkit.org/show_bug.cgi?id=114109
2369
2370         Reviewed by Benjamin Poulain.
2371
2372         Renamed since sheriffbot will be used in Blink.
2373
2374         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2375         (SheriffBot):
2376         (SheriffBot.begin_work_queue):
2377
2378 2013-04-06  Oliver Hunt  <oliver@apple.com>
2379
2380         Unify the many and varied stack trace mechanisms, and make the result sane.
2381         https://bugs.webkit.org/show_bug.cgi?id=114072
2382
2383         Reviewed by Filip Pizlo.
2384
2385         The commandline jsc executable no longer requires arguments, so
2386         I've made run-jsc work without them.
2387
2388         * Scripts/run-jsc:
2389
2390 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
2391
2392         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
2393         https://bugs.webkit.org/show_bug.cgi?id=114086
2394
2395         Reviewed by Tim Horton.
2396
2397         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
2398
2399 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
2400
2401         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
2402         https://bugs.webkit.org/show_bug.cgi?id=114083
2403
2404         Reviewed by Ryosuke Niwa.
2405
2406         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
2407         in TestWebKitAPI and WebKitTestRunner.
2408
2409         * TestWebKitAPI/config.h:
2410         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2411         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2412         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2413         (WTR::InjectedBundle::platformInitialize):
2414
2415 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
2416
2417         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
2418         https://bugs.webkit.org/show_bug.cgi?id=114094
2419
2420         Reviewed by Anders Carlsson.
2421
2422         * Scripts/run-jsc:
2423
2424 2013-04-05  Ojan Vafai  <ojan@chromium.org>
2425
2426         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
2427         https://bugs.webkit.org/show_bug.cgi?id=114080
2428
2429         Reviewed by Ryosuke Niwa.
2430
2431         This way, the WebKit and Blink dashboard code can change as appropriate without
2432         needing to consider the other project's needs. This still doesn't update the
2433         buildbots to upload to the new location, or the dashboard code to pull the
2434         results.json files from the new location, but it at least allows for changing the
2435         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
2436
2437         * TestResultServer/app.yaml:
2438
2439 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2440
2441         Re-enable testing on the commit queue
2442         https://bugs.webkit.org/show_bug.cgi?id=114078
2443
2444         Reviewed by Darin Adler.
2445
2446         Re-enabled the feature and the associated tests.
2447
2448         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2449         (CommitQueueTask.run):
2450         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2451         (CommitQueueTaskTest._run_through_task):
2452         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2453         (CommitQueueTest._mock_test_result):
2454
2455 2013-04-05  Oliver Hunt  <oliver@apple.com>
2456
2457         Unify the many and varied stack trace mechanisms, and make the result sane.
2458         https://bugs.webkit.org/show_bug.cgi?id=114072
2459
2460         Reviewed by Filip Pizlo.
2461
2462         The commandline jsc executable no longer requires arguments, so
2463         I've made run-jsc work without them.
2464
2465         * Scripts/run-jsc:
2466
2467 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2468
2469         AX: Make SVG Group containers accessible elements
2470         https://bugs.webkit.org/show_bug.cgi?id=113939
2471
2472         Reviewed by Simon Fraser.
2473
2474         Implement axController.elementAtPoint for iOS.
2475         Implement a correct version of clickPoint for iOS.
2476
2477         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2478         (AccessibilityController::elementAtPoint):
2479         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2480         (AccessibilityUIElement::clickPointX):
2481         (AccessibilityUIElement::clickPointY):
2482
2483 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2484
2485         Unreviewed, rolling out r147773 and r147774.
2486         http://trac.webkit.org/changeset/147773
2487         http://trac.webkit.org/changeset/147774
2488         https://bugs.webkit.org/show_bug.cgi?id=114056
2489
2490         Causing some exceptions on AppEngine I don't understand
2491         (Requested by rniwa on #webkit).
2492
2493         * QueueStatusServer/config/queues.py:
2494         * QueueStatusServer/model/queues.py:
2495         (Queue.short_name):
2496         (Queue.display_name):
2497         * QueueStatusServer/model/queues_unittest.py:
2498         (QueueTest.test_short_name):
2499         (QueueTest.test_display_name):
2500         (QueueTest.test_name_with_underscores):
2501
2502 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
2503
2504         Fixed run-bindings-tests by removing V8
2505         https://bugs.webkit.org/show_bug.cgi?id=114053
2506
2507         Reviewed by Benjamin Poulain.
2508
2509         * Scripts/run-bindings-tests:
2510         (main):
2511
2512 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2513
2514         Build fix.
2515
2516         * QueueStatusServer/model/queues.py:
2517         (Queue.short_name):
2518         (Queue.display_name):
2519
2520 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2521
2522         Remove Chromium EWS bots from the queue status server
2523         https://bugs.webkit.org/show_bug.cgi?id=113988
2524
2525         Reviewed by Benjamin Poulain.
2526
2527         Removed Chromium EWS bots.
2528
2529         * QueueStatusServer/config/queues.py:
2530         * QueueStatusServer/model/queues.py:
2531         (Queue.short_name):
2532         (Queue.display_name):
2533         * QueueStatusServer/model/queues_unittest.py:
2534         (QueueTest.test_short_name):
2535         (QueueTest.test_display_name):
2536         (QueueTest.test_name_with_underscores):
2537
2538 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2539
2540         [EFL] Enable indexed database
2541         https://bugs.webkit.org/show_bug.cgi?id=107248
2542
2543         Reviewed by Alexis Menard.
2544
2545         * Scripts/webkitperl/FeatureList.pm:
2546
2547 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
2548
2549         Remove vestiges of Chromium bits from watchlists.
2550         https://bugs.webkit.org/show_bug.cgi?id=114047
2551
2552         Reviewed by Ryosuke Niwa.
2553
2554         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
2555
2556 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2557
2558         Add James Craig to the contributors list.
2559
2560         * Scripts/webkitpy/common/config/committers.py:
2561
2562 2013-04-04  Kent Tamura  <tkent@chromium.org>
2563
2564         Remove ChromiumPublicApi pattern, and cc/message rules for it.
2565
2566         * Scripts/webkitpy/common/config/watchlist:
2567
2568 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
2569
2570         Temporarily disable the Python unittests broken by the commit queue not running layout tests
2571         https://bugs.webkit.org/show_bug.cgi?id=113997
2572
2573         Reviewed by Ryosuke Niwa.
2574
2575         Disable the tests until Ryosuke gets the time and hardware to have
2576         a testing commit-queue.
2577
2578         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2579         (CommitQueueTaskTest):
2580         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2581         (CommitQueueTest):
2582
2583 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2584
2585         Remove Chromium builders from build.webkit.org
2586         https://bugs.webkit.org/show_bug.cgi?id=113990
2587
2588         Reviewed by Benjamin Poulain.
2589
2590         Land the part to disable triggering of Chromium builders first so that we may start
2591         deleting more Chromium code that breaks the update step.
2592
2593         * BuildSlaveSupport/build.webkit.org-config/config.json:
2594
2595 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
2596
2597         Remove Chromium's DumpRenderTree
2598         https://bugs.webkit.org/show_bug.cgi?id=113989
2599
2600         Reviewed by Kent Tamura.
2601
2602         On second thought, let's not go to Camelot. It is a silly place.
2603
2604         * DumpRenderTree/mac/DumpRenderTree.mm:
2605         (resetDefaultsToConsistentValues):
2606
2607 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
2608
2609         Nixed the defunct chromium folder from DumpRenderTree
2610         https://bugs.webkit.org/show_bug.cgi?id=113993
2611
2612         Reviewed by Ryosuke Niwa.
2613
2614         * DumpRenderTree/chromium: Removed.
2615         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
2616         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
2617         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
2618         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
2619         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
2620         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
2621         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
2622         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
2623         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
2624         * DumpRenderTree/chromium/MockPlatform.h: Removed.
2625         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
2626         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
2627         * DumpRenderTree/chromium/Task.cpp: Removed.
2628         * DumpRenderTree/chromium/Task.h: Removed.
2629         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
2630         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
2631         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
2632         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
2633         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
2634         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
2635         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
2636         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
2637         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2638         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
2639         * DumpRenderTree/chromium/TestRunner: Removed.
2640         * DumpRenderTree/chromium/TestRunner/public: Removed.
2641         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
2642         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
2643         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
2644         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
2645         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
2646         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
2647         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
2648         * DumpRenderTree/chromium/TestRunner/src: Removed.
2649         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
2650         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
2651         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
2652         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
2653         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
2654         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
2655         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
2656         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
2657         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
2658         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
2659         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
2660         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
2661         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
2662         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
2663         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
2664         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
2665         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
2666         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
2667         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
2668         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
2669         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
2670         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
2671         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
2672         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
2673         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
2674         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
2675         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
2676         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
2677         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
2678         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
2679         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
2680         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
2681         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
2682         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
2683         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
2684         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
2685         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
2686         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
2687         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
2688         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
2689         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
2690         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
2691         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
2692         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
2693         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
2694         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
2695         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
2696         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
2697         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
2698         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
2699         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
2700         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
2701         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
2702         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
2703         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
2704         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
2705         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2706         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
2707         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
2708         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2709         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
2710         * DumpRenderTree/chromium/TestShell.cpp: Removed.
2711         * DumpRenderTree/chromium/TestShell.h: Removed.
2712         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2713         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
2714         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
2715         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
2716         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
2717         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
2718         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
2719         * DumpRenderTree/chromium/WebViewHost.h: Removed.
2720         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
2721         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
2722         * DumpRenderTree/chromium/config.h: Removed.
2723         * DumpRenderTree/chromium/fonts.conf: Removed.
2724
2725 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2726
2727         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
2728
2729         Rubber stamped by Benjamin Poulain.
2730
2731         * RebaselineQueueServer: Removed.
2732         * RebaselineQueueServer/app.yaml: Removed.
2733         * RebaselineQueueServer/handlers: Removed.
2734         * RebaselineQueueServer/handlers/__init__.py: Removed.
2735         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
2736         * RebaselineQueueServer/handlers/pages.py: Removed.
2737         * RebaselineQueueServer/index.yaml: Removed.
2738         * RebaselineQueueServer/main.py: Removed.
2739         * RebaselineQueueServer/model: Removed.
2740         * RebaselineQueueServer/model/__init__.py: Removed.
2741         * RebaselineQueueServer/model/queueentry.py: Removed.
2742         * RebaselineQueueServer/static: Removed.
2743         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
2744         * RebaselineQueueServer/static/styles.css: Removed.
2745         * RebaselineQueueServer/templates: Removed.
2746         * RebaselineQueueServer/templates/builder-picker.html: Removed.
2747         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
2748         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
2749         * RebaselineQueueServer/templates/home.html: Removed.
2750
2751 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2752
2753         Fix setup-commit-queue and temporarily disable testing on commit-queue
2754         https://bugs.webkit.org/show_bug.cgi?id=113979
2755
2756         Reviewed by Benjamin Poulain.
2757
2758         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
2759         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
2760
2761         * EWSTools/setup-commit-queue.sh:
2762         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2763         (CommitQueueTask.run):
2764
2765 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2766
2767         temporarily make flakiness dashboard work again webkit.org bots
2768         https://bugs.webkit.org/show_bug.cgi?id=113972
2769
2770         Reviewed by Ojan Vafai.
2771
2772         This patch disables the chromium.org layout test bots TestExpectations
2773         parsing temporarily until we can work out the right way to split into
2774         two instances for webkit.org and chromium.org and figure out which
2775         code to delete where :).
2776
2777         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2778
2779 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2780
2781         Fix webkitpy tests after r147678.
2782
2783         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2784         (CommitQueueTest.test_commit_queue):
2785         (test_manual_reject_during_processing):
2786
2787 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2788
2789         The commit queue should use Mac MountainLion port
2790         https://bugs.webkit.org/show_bug.cgi?id=113971
2791
2792         Reviewed by Lucas Forschler.
2793
2794         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
2795         * Scripts/webkitpy/tool/commands/queues.py:
2796         (CommitQueue):
2797
2798 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2799
2800         turn off running tests on chromium linux EWS bots
2801         https://bugs.webkit.org/show_bug.cgi?id=113959
2802
2803         Reviewed by Geoffrey Garen.
2804
2805         Now that the Chromium port is no longer being maintained
2806         there's little point in running the tests. Soon we should
2807         just shut this bot off altogether.
2808
2809         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2810         (ChromiumLinuxEWS):
2811
2812 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
2813
2814         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
2815
2816         * Scripts/webkitpy/common/config/watchlist:
2817
2818 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
2819
2820         Indentation fix to get webkit-patch working again after r147625
2821
2822         Unreviewed.
2823
2824         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2825         (MacEWS):
2826         (MacWK2EWS):
2827
2828 2013-04-04  Lucas Forschler  <lforschler@apple.com>
2829
2830         Turn tests back on for Mac WK1/WK2 EWS.
2831         
2832         Unreviewed.
2833         
2834         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2835         (MacEWS):
2836         (MacWK2EWS):
2837
2838 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
2839
2840         [GTK][WK2] MiniBrowser custom URI scheme support
2841         https://bugs.webkit.org/show_bug.cgi?id=112419
2842
2843         Reviewed by Carlos Garcia Campos.
2844
2845         Add support for about URIs in MiniBrowser. An example about page is show
2846         with URI "about:minibrowser", the rest of the cases it will show a
2847         proper message explaining that the about page didn't exist.
2848
2849         Internally it uses "minibrowser-about" prefix instead of "about", but
2850         from the user point of view it works with "about" prefix.
2851
2852         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
2853         (getInternalURI): Method to convert URIs from "about" prefix to
2854         "minibrowser-about".
2855         (getExternalURI): Opposite method.
2856         (webViewURIChanged): Use "about" prefix to show the URI to users.
2857         (webViewEnterFullScreen): Ditto.
2858         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
2859         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
2860         (aboutURISchemeRequestCallback): Callback to manage about calls.
2861         (main): Register the URI scheme to manage about URIs.
2862
2863 2013-04-03  Roger Fong  <roger_fong@apple.com>
2864
2865         Re-enable WinEWS tests.
2866
2867         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2868         (WinEWS):
2869
2870 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
2871
2872         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
2873         https://bugs.webkit.org/show_bug.cgi?id=113883
2874
2875         Reviewed by Martin Robinson.
2876
2877         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
2878         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
2879         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
2880
2881 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2882
2883         [GTK] Include Pango in jhbuild-optional.modules
2884         https://bugs.webkit.org/show_bug.cgi?id=113878
2885
2886         Reviewed by Martin Robinson.
2887
2888         Since r147547 Pango 1.32.0 is required. Including the module in the
2889         JHBuild optional moduleset.
2890
2891         * gtk/jhbuild-optional.modules: Add Pango module.
2892
2893 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2894
2895         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
2896         https://bugs.webkit.org/show_bug.cgi?id=113864
2897
2898         Moving setDefersLoading from TestRunnerQt to TestRunner
2899         requires access to the non-Qt TestRunner.
2900         As long as we instantiate both TestRunner and TestRunnerQt,
2901         we need a separate getter for the non-Qt TestRunner instance.
2902
2903         Reviewed by Simon Hausmann.
2904
2905         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2906         (WebPage::resetSettings):
2907         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2908         (DumpRenderTree::jscTestRunner):
2909         * DumpRenderTree/qt/TestRunnerQt.cpp:
2910         (TestRunner::setDefersLoading):
2911             Moving setDefersLoading from TestRunnerQt
2912             to TestRunner.
2913         * DumpRenderTree/qt/TestRunnerQt.h:
2914         (TestRunnerQt):
2915
2916 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2917
2918         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2919         https://bugs.webkit.org/show_bug.cgi?id=104779
2920
2921         Reviewed by Carlos Garcia Campos.
2922
2923         * Scripts/run-gtk-tests:
2924         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2925         passing in current trunk.
2926
2927 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
2928
2929         Fix HAVE(QTTESTSUPPORT) logic
2930
2931         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
2932         resulting in HAVE(QTTESTSUPPORT) never being true.
2933         Move that logic down in sanitizeFeatures.
2934
2935         Rubber-stamped by Tor Arne Vestbø.
2936
2937         * qmake/mkspecs/features/features.prf:
2938
2939 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2940
2941         [GTK] Bump required versions of some dependencies
2942         https://bugs.webkit.org/show_bug.cgi?id=113282
2943
2944         Reviewed by Martin Robinson.
2945
2946         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2947
2948 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2949
2950         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
2951         https://bugs.webkit.org/show_bug.cgi?id=113809
2952
2953         Reviewed by Philippe Normand.
2954
2955         Newer Linux kernels have removed some deprecated macros from v4l2
2956         headers, causing gst-plugins-good's build to break. We don't need it
2957         right now, so just disable it.
2958
2959         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
2960
2961 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2962
2963         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
2964         https://bugs.webkit.org/show_bug.cgi?id=113535
2965
2966         Reviewed by Simon Hausmann.
2967
2968         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
2969
2970         * qmake/mkspecs/features/features.prf:
2971
2972 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2973
2974         [Qt] Move logic of simple forwarding functions to TestRunner.
2975         https://bugs.webkit.org/show_bug.cgi?id=113863
2976
2977         Reviewed by Simon Hausmann.
2978
2979         * DumpRenderTree/qt/TestRunnerQt.cpp:
2980         (TestRunner::setTextDirection):
2981         (TestRunner::goBack):
2982         (TestRunner::evaluateScriptInIsolatedWorld):
2983         (TestRunner::addUserStyleSheet):
2984         * DumpRenderTree/qt/TestRunnerQt.h:
2985         (TestRunnerQt):
2986
2987 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2988
2989         [Qt] Disable media support using QuickTime if deployment target != SDK
2990
2991         We link to a single libWebKitSystemInterface static lib, so unless the
2992         deployment target matches the SDK let's not pretend like we'll be able
2993         to run on anything lower than the SDK version.
2994
2995         Reviewed by Simon Hausmann.
2996
2997         * qmake/mkspecs/features/features.prf:
2998
2999 2013-04-02  James Craig  <james@cookiecrook.com>
3000
3001         AXRoleDescripton for DL is "list"; should be "description list"
3002         https://bugs.webkit.org/show_bug.cgi?id=111665
3003
3004         Reviewed by Chris Fleizach.
3005
3006         Defining the role and description strings.
3007
3008         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3009
3010 2013-04-02  Roger Fong  <roger_fong@apple.com>
3011
3012         Unreviewed. Disable running tests on Win EWS queue.
3013
3014         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3015         (WinEWS):
3016
3017 2013-04-02  Lucas Forschler  <lforschler@apple.com>
3018
3019         Disable running tests on the MAC WK2 EWS queue.
3020         
3021         Unreviewed.
3022         
3023         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3024         (MacWK2EWS):
3025
3026 2013-04-02  Julie Parent  <jparent@chromium.org>
3027
3028         Dashboard refactor: Move dashboard specific history related features to History.
3029         https://bugs.webkit.org/show_bug.cgi?id=113717
3030
3031         Reviewed by Ojan Vafai.
3032         
3033         Each dashboard now creates its own History object, with a custom
3034         configuration. This changes from just overriding global functions
3035         to passing in callbacks for generatePage, handleValidHashParameter,
3036         and handleQueryParameterChange. Same with passing in defaultStateValues
3037         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
3038         variables.
3039         
3040         All functions related to these features are now (mostly) private
3041         function on History. 
3042         
3043         Loader no longer needs a loadingComplete callback, since it can just
3044         initialize the history object itself.
3045
3046         * TestResultServer/static-dashboards/aggregate_results.js:
3047         (handleValidHashParameter):
3048         * TestResultServer/static-dashboards/dashboard_base.js:
3049         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3050         (generatePage):
3051         (.switch.return):
3052         (handleQueryParameterChange):
3053         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3054         (resetGlobals):
3055         * TestResultServer/static-dashboards/history.js:
3056         (.):
3057         * TestResultServer/static-dashboards/loader.js:
3058         (.):
3059         * TestResultServer/static-dashboards/loader_unittests.js:
3060         * TestResultServer/static-dashboards/timeline_explorer.js:
3061         (generatePage):
3062         (initCurrentBuilderTestResults):
3063         * TestResultServer/static-dashboards/treemap.js:
3064         (generatePage):
3065         (.switch.return):
3066         (handleQueryParameterChange):
3067
3068 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3069
3070         Unreviewed, rolling out r147401.
3071         http://trac.webkit.org/changeset/147401
3072         https://bugs.webkit.org/show_bug.cgi?id=113767
3073
3074         The patch makes it extremely hard to set up the dependencies
3075         properly on the GTK builders (Requested by zdobersek on
3076         #webkit).
3077
3078         * gtk/jhbuild.modules:
3079
3080 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3081
3082         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
3083         https://bugs.webkit.org/show_bug.cgi?id=113382
3084
3085         Reviewed by Gyuyoung Kim.
3086
3087         Do not show the empty tooltip box if the text is null.
3088
3089         * MiniBrowser/efl/main.c:
3090         (popup_menu_populate):
3091
3092 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3093
3094         [GTK] Bump required versions of some dependencies
3095         https://bugs.webkit.org/show_bug.cgi?id=113282
3096
3097         Reviewed by Martin Robinson.
3098
3099         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
3100
3101 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3102
3103         Unreviewed, rolling out r147319.
3104         http://trac.webkit.org/changeset/147319
3105         https://bugs.webkit.org/show_bug.cgi?id=113707
3106
3107         The unit test is still failing on the buildbot (Requested by
3108         zdobersek on #webkit).
3109
3110         * Scripts/run-gtk-tests:
3111         (TestRunner):
3112
3113 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
3114
3115         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
3116         https://bugs.webkit.org/show_bug.cgi?id=104779
3117
3118         Reviewed by Carlos Garcia Campos.
3119
3120         * Scripts/run-gtk-tests:
3121         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
3122         passing in current trunk.
3123
3124 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3125
3126         Unreviewed, rolling out r147289.
3127         http://trac.webkit.org/changeset/147289
3128         https://bugs.webkit.org/show_bug.cgi?id=113678
3129
3130         broke Win7 (dbg) build (Requested by shinyak|gardener on
3131         #webkit).
3132
3133         * DumpRenderTree/DumpRenderTree.gypi:
3134         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
3135         (WebTestRunner):
3136         (WebUserMediaClientMock):
3137         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
3138         (WebTestRunner::WebUserMediaClientMock::taskList):
3139         * Scripts/webkitpy/style/checkers/cpp.py:
3140         (check_function_definition):
3141
3142 2013-03-31  Adam Barth  <abarth@webkit.org>
3143
3144         configure-svn-config.sh fails
3145         https://codereview.chromium.org/13392007/
3146
3147         Reviewed by Eric Seidel.
3148
3149         This script was trying to use "svn checkout" to dowload a file from
3150         svn.webkit.org, but "svn checkout" only works with directories.
3151         Instead, we should use "svn export".
3152
3153         * EWSTools/configure-svn-config.sh:
3154
3155 2013-03-31  Wei Jia  <wjia@chromium.org>
3156
3157         Allow WebUserMediaClientMock to be used by client
3158         https://bugs.webkit.org/show_bug.cgi?id=113633
3159
3160         Reviewed by Adam Barth.
3161
3162         Export WebUserMediaClientMock.
3163         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
3164
3165         * DumpRenderTree/DumpRenderTree.gypi:
3166         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
3167         (WebUserMediaClientMock):
3168         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
3169         * Scripts/webkitpy/style/checkers/cpp.py:
3170         (check_function_definition):
3171
3172 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
3173
3174         Expose FeatureObserver data to WebKit clients
3175         https://bugs.webkit.org/show_bug.cgi?id=113613
3176
3177         Reviewed by Sam Weinig.
3178
3179         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3180         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
3181
3182 2013-03-29  Greg Hughes  <ghughes@apple.com>
3183
3184         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
3185         https://bugs.webkit.org/show_bug.cgi?id=112276
3186
3187         Reviewed by Chris Fleizach.
3188
3189         Added support to test accessibility search predicates with multiple keys.  
3190
3191         * DumpRenderTree/AccessibilityUIElement.cpp:
3192         (uiElementForSearchPredicateCallback):
3193         * DumpRenderTree/AccessibilityUIElement.h:
3194         (AccessibilityUIElement):
3195         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3196         (AccessibilityUIElement::uiElementForSearchPredicate):
3197         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3198         (AccessibilityUIElement::uiElementForSearchPredicate):
3199         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3200         (AccessibilityUIElement::uiElementForSearchPredicate):
3201         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3202         (AccessibilityUIElement::uiElementForSearchPredicate):
3203         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3204         (AccessibilityUIElement::uiElementForSearchPredicate):
3205         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3206         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3207         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3208         (AccessibilityUIElement):
3209         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3210         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3211         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3212         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3213         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3214
3215 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
3216
3217         Fix a typo in r147147 to fix Mac EWS.
3218
3219         * Scripts/webkitpy/tool/commands/queues.py:
3220         (PatchProcessingQueue._new_port_name_from_old):
3221
3222 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
3223
3224         [EFL] Build break with latest EFL libraries after r146265
3225         https://bugs.webkit.org/show_bug.cgi?id=113558
3226
3227         Unreviewed build fix.
3228
3229         * TestWebKitAPI/PlatformWebView.h:
3230         * WebKitTestRunner/PlatformWebView.h:
3231
3232 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3233
3234         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
3235
3236         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
3237         in libgcrypt build.
3238
3239 2013-03-28  Lucas Forschler  <lforschler@apple.com>
3240
3241         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
3242
3243         Unreviewed.
3244
3245         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3246         (MacEWS):
3247
3248 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3249
3250         Use the right OS name on Mac EWS instead of mac-future.
3251
3252         Rubber-stamped by Dirk Pranke.
3253
3254         * Scripts/webkitpy/tool/commands/queues.py:
3255         (PatchProcessingQueue._new_port_name_from_old):
3256         (PatchProcessingQueue.begin_work_queue):
3257         (PatchProcessingQueue._upload_results_archive_for_patch):
3258
3259 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
3260
3261         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
3262         https://bugs.webkit.org/show_bug.cgi?id=112546
3263
3264         Reviewed by Martin Robinson.
3265
3266         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
3267         moved back to Source/WebCore/platform. Fix an indentation issue as well.
3268
3269 2013-03-28  Ming Xie  <mxie@blackberry.com>
3270
3271         [BlackBerry] Committer Email Updates
3272         https://bugs.webkit.org/show_bug.cgi?id=113435
3273
3274         Reviewed by Rob Buis.
3275
3276         Add the @blackberry.com email address for all our BlackBerry
3277         WebKit committers. This is the first step for our email address
3278         migration.
3279
3280         * Scripts/webkitpy/common/config/committers.py:
3281
3282 2013-03-28  Philippe Normand  <pnormand@igalia.com>
3283
3284         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
3285         https://bugs.webkit.org/show_bug.cgi?id=113508
3286
3287         Reviewed by Martin Robinson.
3288
3289         Prevent the GStreamer plugin scanner to load system-wide
3290         plugins. Only the ones built in JHBuild should be loaded and used
3291         at runtime.
3292
3293         * efl/jhbuildrc:
3294         * gtk/jhbuildrc:
3295
3296 2013-03-27  Philippe Normand  <pnormand@igalia.com>
3297
3298         [GTK] run-launcher --gtk -2 fails on a WK2-only build
3299         https://bugs.webkit.org/show_bug.cgi?id=113386
3300
3301         Reviewed by Carlos Garcia Campos.
3302
3303         * Scripts/webkitdirs.pm:
3304         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
3305         version to 3.0. Reflect this change so the builtDylibPathForName
3306         function doesn't fail to report the library as found.
3307
3308 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
3309
3310         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
3311         https://bugs.webkit.org/show_bug.cgi?id=113484
3312
3313         Unreviewed build fix.
3314
3315         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
3316
3317         * TestWebKitAPI/CMakeLists.txt:
3318         * WebKitTestRunner/CMakeLists.txt:
3319
3320 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
3321
3322         Revision for the internal jhbuild is too old
3323         https://bugs.webkit.org/show_bug.cgi?id=113324
3324
3325         Reviewed by Martin Robinson.
3326
3327         Update the minimum required version to a point where jhbuild won't
3328         fail installing packages when trying to remove a symlink to a directory.
3329
3330         * jhbuild/jhbuild-wrapper: Updated revision.
3331
3332 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
3333
3334         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
3335         https://bugs.webkit.org/show_bug.cgi?id=113203
3336
3337         Reviewed by Philippe Normand.
3338
3339         We build our libsoup without GNOME support. gst-plugins-good does separate
3340         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
3341         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
3342         build failures as the headers of those diverge. We do not use souphttpsrc, so
3343         disable it when building gst-plugins-good.
3344
3345         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
3346
3347 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
3348
3349         Build fix after r146852. Please another reference to the Lion leaks builder.
3350
3351         * BuildSlaveSupport/build.webkit.org-config/config.json:
3352
3353 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
3354
3355         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
3356         https://bugs.webkit.org/show_bug.cgi?id=113421
3357
3358         Reviewed by Dirk Pranke.
3359
3360         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
3361         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
3362         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
3363         in the GTK-specific TestExpectations files.
3364
3365         To avoid this only enable the warnings only when not using WKTR.
3366
3367         * Scripts/webkitpy/layout_tests/port/gtk.py:
3368         (GtkPort.warn_if_bug_missing_in_test_expectations):
3369
3370 2013-03-27  Antti Koivisto  <antti@apple.com>
3371
3372         Fix Zalan's email.
3373
3374         * Scripts/webkitpy/common/config/committers.py:
3375
3376 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3377
3378         master.cfg cleanup
3379         https://bugs.webkit.org/show_bug.cgi?id=113195
3380
3381         Reviewed by Ryosuke Niwa.
3382
3383         * BuildSlaveSupport/build.webkit.org-config/config.json:
3384         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3385
3386 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3387
3388         master.cfg fine-tuning for Qt Mountain Lion Release bot
3389         https://bugs.webkit.org/show_bug.cgi?id=113191
3390
3391         Reviewed by Ryosuke Niwa.
3392
3393         * BuildSlaveSupport/build.webkit.org-config/config.json:
3394           - Rename the slave due to its location change.
3395           - Update the platform of the slave.
3396         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3397         (RunQtAPITests): Enable running WK2 API tests on Qt.
3398         (RunQtAPITests.start):
3399         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
3400         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
3401
3402 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3403
3404         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
3405         https://bugs.webkit.org/show_bug.cgi?id=113403
3406
3407         Reviewed by Kenneth Rohde Christiansen.
3408
3409         As of Evas 1.7.5, when Wayland is detected on the system, support for
3410         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
3411         The code, however, seems to depend on a few other flags which must be
3412         explicitly enabled.
3413
3414         If those additional GL-related options are passed, we end up
3415         having issues on the WebKit side, so disable Wayland support for
3416         now.
3417
3418         * efl/jhbuild.modules:
3419
3420 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3421
3422         Unreviewed, rolling out r146864.
3423         http://trac.webkit.org/changeset/146864
3424         https://bugs.webkit.org/show_bug.cgi?id=113391
3425
3426         causes crashes on Wk2 EFL release bot (Requested by drott on
3427         #webkit).
3428
3429         * Scripts/webkitperl/FeatureList.pm:
3430
3431 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3432
3433         [jhbuild] Correctly specify an alternate number of make jobs.
3434         https://bugs.webkit.org/show_bug.cgi?id=113396
3435
3436         Reviewed by Philippe Normand.
3437
3438         So far, we were using the `MAKEFLAGS' environment variable to pass the
3439         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
3440         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
3441
3442         We now behave more closely to the rest of the WebKit tools by first
3443         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
3444         not set, just letting jhbuild itself figure out how many jobs to use.
3445
3446         * efl/jhbuildrc:
3447         * gtk/jhbuildrc:
3448
3449 2013-03-27  Zeno Albisser  <zeno@webkit.org>
3450
3451         [Qt] Remove Qt specific WorkQueueItem definitions.
3452         https://bugs.webkit.org/show_bug.cgi?id=112891
3453
3454         This patch is preparation work for removing
3455         WorkQueue related code from TestRunnerQt and
3456         replacing it with generic TestRunner code.
3457
3458         Reviewed by Benjamin Poulain.
3459
3460         * DumpRenderTree/qt/TestRunnerQt.cpp:
3461         (TestRunnerQt::queueBackNavigation):
3462         (TestRunnerQt::queueForwardNavigation):
3463         (TestRunnerQt::queueLoadHTMLString):
3464         (TestRunnerQt::queueReload):
3465         (TestRunnerQt::queueLoadingScript):
3466         (TestRunnerQt::queueNonLoadingScript):
3467         (TestRunner::queueLoad):
3468         * DumpRenderTree/qt/TestRunnerQt.h:
3469         (TestRunnerQt):
3470         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3471         (LoadItem::invoke):
3472         (LoadHTMLStringItem::invoke):
3473         (LoadAlternateHTMLStringItem::invoke):
3474         (ReloadItem::invoke):
3475         (ScriptItem::invoke):
3476         (BackForwardItem::invoke):
3477         * DumpRenderTree/qt/WorkQueueItemQt.h:
3478         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
3479         (LoadAlternateHTMLStringItem):
3480
3481 2013-03-26  Julie Parent  <jparent@chromium.org>
3482
3483         Flakiness dashboard: simplify logic around which tests to show.
3484         https://bugs.webkit.org/show_bug.cgi?id=113250
3485
3486         Reviewed by Ojan Vafai.
3487         
3488         The different filters for showing results are only used for layout
3489         tests, otherwise, we show everything.
3490         
3491         Change the defaults to false (what layout tests used), and only
3492         look at the values when viewing layout tests.
3493
3494         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3495         (htmlForTestsWithExpectationsButNoFailures):
3496         (shouldHideTest):
3497
3498 2013-03-26  Isaac Levy  <ilevy@google.com>
3499
3500         Update bots on test-results.appspot
3501         https://bugs.webkit.org/show_bug.cgi?id=113333
3502
3503         Reviewed by Ojan Vafai.
3504
3505         * TestResultServer/static-dashboards/builders.jsonp:
3506
3507 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
3508
3509         Unreviewed GTK gardening.
3510
3511         * Scripts/run-gtk-tests:
3512         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
3513
3514 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3515
3516         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
3517         https://bugs.webkit.org/show_bug.cgi?id=113287
3518
3519         Reviewed by Jocelyn Turcotte.
3520
3521         * Scripts/run-qtwebkit-tests:
3522         (Options.__init__):
3523
3524 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
3525
3526         [EFL] Enable IndexedDB by default
3527         https://bugs.webkit.org/show_bug.cgi?id=107248
3528
3529         Reviewed by Laszlo Gombos.
3530
3531         * Scripts/webkitperl/FeatureList.pm:
3532         Enable IndexedDB by default on EFL.
3533
3534 2013-03-26  Alan Cutter  <alancutter@chromium.org>
3535
3536         Sheriffbot should explain rollout failures in a human readable form.
3537         https://bugs.webkit.org/show_bug.cgi?id=107092
3538
3539         Reviewed by Ryosuke Niwa.
3540
3541         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
3542
3543         * Scripts/webkitpy/tool/bot/irc_command.py:
3544         (Rollout._check_diff_failure):
3545         (Rollout.execute):
3546         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3547         (IRCCommandTest.test_rollout):
3548
3549 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
3550
3551         Unreviewed GTK gardening.
3552
3553         * Scripts/run-gtk-tests:
3554         (TestRunner): Skipping a failing unit test after r146518.
3555
3556 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>