[ews-build] Get master_hostname dynamically in master.cfg
[WebKit-https.git] / Tools / ChangeLog-2012-05-22
1 2012-05-21  Gavin Barraclough  <barraclough@apple.com>
2
3         Disable private names by default in WebCore
4         https://bugs.webkit.org/show_bug.cgi?id=87088
5
6         Reviewed by Geoff Garen.
7
8         r117859 introduced a preliminary implementation of ES6-like private name objects to JSC.
9         These are probably not yet ready to be web-facing, so disabling by default in WebCore.
10         Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.
11
12         * DumpRenderTree/mac/DumpRenderTree.mm:
13         (resetDefaultsToConsistentValues):
14             - Enable private name support in DRT.
15         * WebKitTestRunner/TestController.cpp:
16         (WTR::TestController::resetStateToConsistentValues):
17             - Enable private name support in WKTR.
18
19 2012-05-22  Martin Robinson  <mrobinson@igalia.com>
20
21         Fix a small syntax error in the GTK+ API test runner.
22
23         Reviewed by Gustavo Noronha Silva.
24
25         * gtk/run-api-tests:
26         (TestRunner._setup_testing_environment): When reporting the error use
27         the correct Python format string syntax.
28
29 2012-05-22  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
30
31         [GTK][DRT] Wrong cache model is taken in LayoutTestController's setCacheModel()
32         https://bugs.webkit.org/show_bug.cgi?id=86962
33
34         Reviewed by Gustavo Noronha Silva.
35
36         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
37         (LayoutTestController::setCacheModel): Sets WEBKIT_CACHE_MODEL_WEB_BROWSER if argument is 2.
38
39 2012-05-22  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
40
41         [EFL][DRT] Key modifier bit flags have enum type.
42         https://bugs.webkit.org/show_bug.cgi?id=86838
43
44         Reviewed by Antonio Gomes.
45
46         Refactoring. Key modifier flags are unsigned int.
47         Key modifier bit flags used have enum type. It caused problems as a key can have several modifiers 
48         at the same time and the union of modifiers (i.e. EvasKeyModifierControl | EvasKeyModifierShift) 
49         would have been out of EvasKeyModifier enum.
50
51         * DumpRenderTree/efl/EventSender.cpp:
52         (KeyEventInfo::KeyEventInfo):
53         (KeyEventInfo):
54         (MouseEventInfo::MouseEventInfo):
55         (MouseEventInfo):
56         (setEvasModifiers):
57         (modifiersFromJSValue):
58         (mouseDownCallback):
59         (mouseUpCallback):
60         (keyPadNameFromJSValue):
61         (keyNameFromJSValue):
62         (createKeyEventInfo):
63         (sendKeyDown):
64
65 2012-05-22  Takashi Sakamoto  <tasak@google.com>
66
67         Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property
68         https://bugs.webkit.org/show_bug.cgi?id=86694
69
70         Modify keyDown to create left- and right- control, shift, and alt
71         keyevent for a test to check that keyLocation property can have
72         DOM_KEY_LOCATION_LEFT for left-control, shift, and alt, and
73         DOM_KEY_LOCATION_RIGHT for right-control, shift, and alt.
74
75         Reviewed by Alexey Proskuryakov.
76
77         * DumpRenderTree/chromium/EventSender.cpp:
78         (EventSender::keyDown):
79         * DumpRenderTree/mac/EventSendingController.mm:
80         (-[EventSendingController keyDown:withModifiers:withLocation:]):
81
82 2012-05-22  Christophe Dumez  <christophe.dumez@intel.com>
83
84         [EFL] EFL's DRT needs to print information about received Web Intents
85         https://bugs.webkit.org/show_bug.cgi?id=86864
86
87         Reviewed by Adam Barth.
88
89         Catch "intent,new" signal in EFL's DumpRenderTree and dump information
90         about the intent. This output is expected by several webintents test
91         cases.
92
93         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
94         (DumpRenderTreeChrome::createView):
95         (DumpRenderTreeChrome::onFrameCreated):
96         (DumpRenderTreeChrome::onFrameIntentNew):
97         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
98         (DumpRenderTreeChrome):
99
100 2012-05-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
101
102         [EFL] Add support to enable/disable DOM paste 
103         https://bugs.webkit.org/show_bug.cgi?id=85040
104
105         Reviewed by Gustavo Noronha Silva.
106
107         Enable JavascriptCanAccessClipboard setting on each test startup so
108         that test cases which rely on clipboard can be unskipped.
109
110         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
111         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
112
113 2012-05-22  Hugo Parente Lima  <hugo.lima@openbossa.org>
114
115         [Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events
116         https://bugs.webkit.org/show_bug.cgi?id=87044
117
118         Reviewed by Alexis Menard.
119
120         Use sendOrQueueEvent instead of m_testController->mainWebView()->sendEvent
121
122         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
123         (WTR::EventSenderProxy::keyDown):
124
125 2012-05-22  Zan Dobersek  <zandobersek@gmail.com>
126
127         [Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results
128         https://bugs.webkit.org/show_bug.cgi?id=86284
129
130         Reviewed by Martin Robinson.
131
132         Paint the current dirty regions of the web view once more before
133         dumping pixel results.
134
135         * DumpRenderTree/gtk/DumpRenderTree.cpp:
136         (dump):
137
138 2012-05-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
139
140         GCC 4.7 and C++11 support.
141         https://bugs.webkit.org/show_bug.cgi?id=86465
142
143         Reviewed by Darin Adler.
144
145         Update detection of C++11 mode in GCC.
146
147         * qmake/mkspecs/features/unix/default_post.prf:
148
149 2012-05-22  Hao Zheng  <zhenghao@chromium.org>
150
151         [chromium] WebViewHost should use ENABLE guards for some features.
152         https://bugs.webkit.org/show_bug.cgi?id=87087
153
154         Reviewed by Kent Tamura.
155
156         These features are disabled on OS(ANDROID) and so shouldn't be
157         compiled when the feature is off.
158
159         * DumpRenderTree/chromium/WebViewHost.cpp:
160         (WebViewHost::reset):
161         * DumpRenderTree/chromium/WebViewHost.h:
162         (WebViewHost):
163
164 2012-05-21  Christophe Dumez  <christophe.dumez@intel.com>
165
166         [EFL] EFL's DumpRenderTree does not print didReceiveTitle messages
167         https://bugs.webkit.org/show_bug.cgi?id=85971
168
169         Reviewed by Antonio Gomes.
170
171         Listen for the "title,changed" signal on the frames instead of the
172         view so that we get notified for other frame than the main one.
173         Print out the didReceiveTitle messages which are expected if
174         LayoutTestController's dumpFrameLoadCallbacks() returns true.
175
176         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
177         (DumpRenderTreeChrome::createView):
178         (DumpRenderTreeChrome::onFrameTitleChanged):
179         (DumpRenderTreeChrome::onFrameCreated):
180         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
181         (DumpRenderTreeChrome):
182
183 2012-05-21  Raphael Kubo da Costa  <rakuco@webkit.org>
184
185         [EFL] Unreviewed, reverting r116461.
186
187         r116461 caused a regression in the pixel tests, as scrollbars
188         stopped being rendered in the PNGs.
189
190         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
191         (createBitmapContextFromWebView):
192
193 2012-05-21  Brady Eidson  <beidson@apple.com>
194
195         <rdar://problem/11460336> and https://bugs.webkit.org/show_bug.cgi?id=87061
196         WKPageGetScaleFactor can return 0.0 after a session is restored
197
198         Reviewed by Beth Dakin.
199
200         Loads a simple page, creates a session from it, restores that session, then
201         queries the page scale factor for the appropriate value of 1.0.
202
203         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
204         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: Added.
205         (TestWebKitAPI):
206         (TestWebKitAPI::didFinishLoadForFrame):
207         (TestWebKitAPI::setPageLoaderClient):
208         (TestWebKitAPI::createSessionState):
209         (TestWebKitAPI::TEST):
210
211 2012-05-21  Hugo Parente Lima  <hugo.lima@openbossa.org>
212
213         [WK2] Remove a useless #if on Tools/WebKitTestRunner/TestController.cpp
214         https://bugs.webkit.org/show_bug.cgi?id=87047
215
216         Reviewed by Alexis Menard.
217
218         * WebKitTestRunner/TestController.cpp:
219         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
220
221 2012-05-21  Dirk Pranke  <dpranke@chromium.org>
222
223         webkitpy: clean up the TestExpectations constructor
224         https://bugs.webkit.org/show_bug.cgi?id=86926
225
226         Reviewed by Ojan Vafai.
227
228         The TestExpectations constructor was attempting to pretend
229         it didn't need to get stuff from the Port, and as a result we
230         had a complicated constructor with a bunch of arguments, and
231         calling it was too complicated (although it made testing a
232         little easier and simplified the style checker).
233
234         This patch has the constructor pull all the data it needs from
235         the port directly, and allows us to delete a bunch of code.
236
237         * Scripts/webkitpy/layout_tests/controllers/manager.py:
238         (Manager.parse_expectations):
239         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
240         (ManagerTest.test_update_summary_with_result):
241         (ResultSummaryTest.get_result_summary):
242         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
243         (TestExpectations.__init__):
244         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
245         (parse_exp):
246         (SkippedTests.check):
247         (RemoveConfigurationsTest.test_remove):
248         (test_remove_line):
249         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
250         (lint):
251         (run):
252         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
253         (LintTest.test_all_configurations.FakePort.__init__):
254         (LintTest.test_all_configurations.FakePort.test_expectations):
255         (LintTest.test_all_configurations.FakePort.skipped_layout_tests):
256         (LintTest.test_all_configurations.FakePort):
257         (LintTest.test_all_configurations.FakePort.all_test_configurations):
258         (LintTest.test_all_configurations.FakePort.configuration_specifier_macros):
259         (LintTest.test_all_configurations.FakePort.path_from_webkit_base):
260         (LintTest.test_all_configurations.FakePort.get_option):
261         (LintTest.test_all_configurations.FakeFactory.__init__):
262         (LintTest.test_all_configurations.FakeFactory.all_port_names):
263         (LintTest.test_all_configurations):
264         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
265         (Testprinter.get_result_summary):
266         * Scripts/webkitpy/style/checkers/test_expectations.py:
267         (TestExpectationsChecker.check_test_expectations):
268         * Scripts/webkitpy/tool/commands/queries.py:
269         (PrintExpectations._model):
270         * Scripts/webkitpy/tool/commands/rebaseline.py:
271         (RebaselineTest._update_expectations_file):
272         (RebaselineExpectations._expectations):
273
274 2012-05-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
275
276         [GTK] DRT support for layoutTestController.setSerializeHTTPLoads
277         https://bugs.webkit.org/show_bug.cgi?id=86653
278
279         Reviewed by Gustavo Noronha Silva.
280
281         Add missing implementation setSerializeHTTPLoads to allow
282         testing resource load order.
283
284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
285         (resetDefaultsToConsistentValues):
286         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
287         (LayoutTestController::setSerializeHTTPLoads):
288
289 2012-05-21  Elliot Poger  <epoger@chromium.org>
290
291         add skia_test_expectations override file to chromium NRWT
292         https://bugs.webkit.org/show_bug.cgi?id=86749
293
294         Reviewed by Dirk Pranke
295
296         * Scripts/webkitpy/layout_tests/port/base.py:
297         (Port.test_expectations_overrides):
298         * Scripts/webkitpy/layout_tests/port/chromium.py:
299         (ChromiumPort.test_expectations_overrides):
300         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
301         (ChromiumPortTest.test_overrides_and_builder_names):
302
303 2012-05-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
304
305         webkitdirs.pm: Fix undefined CXXFLAGS variable
306         https://bugs.webkit.org/show_bug.cgi?id=87000
307
308         Reviewed by Martin Robinson.
309
310         Fixes a warning on Autotools and CMake buildsystem when
311         CXXFLAGS is not defined.
312
313         * Scripts/webkitdirs.pm:
314         (runAutogenForAutotoolsProjectIfNecessary):
315         (generateBuildSystemFromCMakeProject):
316
317 2012-05-21  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
318
319         Move setEditingBehavior() from layoutTestController to window.internals
320         https://bugs.webkit.org/show_bug.cgi?id=42689
321
322         Reviewed by Hajime Morita and Kenneth Rohde Christiansen.
323
324         Remove code that implements setEditingBehavior() for each platform. Note that
325         During the InternalsObject reset the behavior is changed back to the platform
326         default.
327
328         Qt and Chromium ports set a default editing behavior for running tests different
329         from the platform default, so they still keep code for resetting to the desired
330         editing behavior. Other ports use the their defaults, that are restored by
331         internals object.
332
333         * DumpRenderTree/LayoutTestController.cpp:
334         (LayoutTestController::staticFunctions):
335         * DumpRenderTree/LayoutTestController.h:
336         (LayoutTestController):
337         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
338         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
339         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
340         * DumpRenderTree/chromium/LayoutTestController.cpp:
341         (LayoutTestController::LayoutTestController):
342         * DumpRenderTree/chromium/LayoutTestController.h:
343         (LayoutTestController):
344         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
345         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
346         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
347         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
348         * DumpRenderTree/mac/DumpRenderTree.mm:
349         (resetDefaultsToConsistentValues):
350         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
351         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
352         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
353         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
354         * DumpRenderTree/qt/LayoutTestControllerQt.h:
355         (LayoutTestController):
356         * DumpRenderTree/win/DumpRenderTree.cpp:
357         (resetDefaultsToConsistentValues):
358         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
359         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
360
361 2012-05-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
362
363         [EFL] PlatformKeyboardEventEfl is missing ESC key handling.
364         https://bugs.webkit.org/show_bug.cgi?id=86837
365
366         Reviewed by Kenneth Rohde Christiansen.
367
368         * DumpRenderTree/efl/EventSender.cpp:
369         (keyNameFromJSValue): Added ESC key handling.
370
371 2012-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
372
373         [GTK] Add GCancellable parameter to all methods using gio async pattern
374         https://bugs.webkit.org/show_bug.cgi?id=86843
375
376         Reviewed by Gustavo Noronha Silva.
377
378         * MiniBrowser/gtk/BrowserWindow.c:
379         (browser_window_load_uri):
380
381 2012-05-20  Daniel Bates  <dbates@webkit.org>
382
383         svn-apply cannot apply patches to files that contain space
384         characters in their path
385         https://bugs.webkit.org/show_bug.cgi?id=85742
386
387         Reviewed by Eric Seidel.
388
389         Fixes an issue where svn-apply cannot apply a patch to a file
390         if there is a space in its file path.
391
392         The regular expression we were using to fix up +++/--- lines
393         was too strict; it only matched file paths that contained non-
394         whitespace characters. Instead, it's sufficient to match file
395         paths whose characters aren't in the set {\t, \n, \r}.
396
397         * Scripts/VCSUtils.pm:
398         (parseSvnDiffHeader):
399         (runCommand): Added.
400         * Scripts/svn-apply:
401         (scmWillDeleteFile): Modified to call runCommand() so as to
402         handle querying git for a file whose path may contain a space
403         character.
404         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
405           - Added test case "new file with spaces in its name".
406         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: Added.
407
408 2012-05-20  Daniel Bates  <dbates@webkit.org>
409
410         svn-apply fails to apply a patch that moves files from directory A to A/B
411         https://bugs.webkit.org/show_bug.cgi?id=86973
412
413         Reviewed by Eric Seidel.
414
415         Fixes an issue where svn-apply fails to apply a patch that moves files in a
416         directory A to some sub-directory B in A with a Git checkout of WebKit.
417
418         Currently, svn-apply only creates new directories along a file system path that
419         it hasn't already processed. That is, if svn-apply creates/traverses all the
420         intermediate directories along the path A/B then it will assume the directory A/B
421         exists for all subsequent requests to create sub-directories in A/B (e.g. A/B/C).
422         When moving a file F in directory A to directory A/B using a Git checkout, Git
423         may remove directory A if F is the last file in A. Therefore, svn-apply will fail
424         to create sub-directory B in A (since A no longer exists).
425
426         * Scripts/svn-apply:
427         (addDirectoriesIfNeeded):
428
429 2012-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
430
431         [Chromium] Print layout test result on buildbot
432         https://bugs.webkit.org/show_bug.cgi?id=86965
433
434         Reviewed by Eric Seidel.
435
436         * Scripts/run-webkit-tests: Add chrome-bot to buildbot user list.
437         (runningOnBuildBot):
438
439 2012-05-19  Kevin Ollivier  <kevino@theolliviers.com>
440
441         [wx] Unreviewed build fix. Don't stop the build if a build system update check fails.
442         
443         * waf/build/build_utils.py:
444         (download_if_newer):
445
446 2012-05-19  Ryosuke Niwa  <rniwa@webkit.org>
447
448         Build fix. Sometimes --suffixes isn't supplied.
449
450         * Scripts/webkitpy/tool/servers/gardeningserver.py:
451         (GardeningHTTPRequestHandler.rebaseline):
452         (GardeningHTTPRequestHandler.optimizebaselines):
453
454 2012-05-19  Ryosuke Niwa  <rniwa@webkit.org>
455
456         Add "Lion" -> "mac-lion" to the builder port map.
457
458         * Scripts/webkitpy/layout_tests/port/builders.py:
459
460 2012-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
461
462         Unreviewed, rolling out r117675.
463         http://trac.webkit.org/changeset/117675
464         https://bugs.webkit.org/show_bug.cgi?id=86938
465
466         Broke builds. You can't initialize members by members
467         themselves (Requested by rniwa on #webkit).
468
469         * DumpRenderTree/chromium/LayoutTestController.cpp:
470         (LayoutTestController::numberOfPages):
471         * DumpRenderTree/chromium/WebViewHost.cpp:
472         (WebViewHost::printPage):
473
474 2012-05-18  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
475
476         [chromium] User overloaded printBegin() webkit API to support auto fit to page functionality.
477         https://bugs.webkit.org/show_bug.cgi?id=86684
478
479         Reviewed by Darin Fisher.
480
481         * DumpRenderTree/chromium/LayoutTestController.cpp:
482         (LayoutTestController::numberOfPages):
483         * DumpRenderTree/chromium/WebViewHost.cpp:
484         (WebViewHost::printPage):
485
486 2012-05-18  Raphael Kubo da Costa  <rakuco@webkit.org>
487
488         [EFL][DRT] Make it possible to enable CSS Grid Layout.
489         https://bugs.webkit.org/show_bug.cgi?id=86921
490
491         Reviewed by Tony Chang.
492
493         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
494         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
495         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
496         (LayoutTestController::overridePreference):
497
498 2012-05-18  Dirk Pranke  <dpranke@chromium.org>
499
500         scm.add() doesn't work properly with svn 1.7
501         https://bugs.webkit.org/show_bug.cgi?id=86779
502
503         Reviewed by Eric Seidel.
504
505         Re-land the change in r117526 with a fix to maintain
506         compatibility with SVN 1.4.4 (yay Leopard!); turns out
507         that "svn info foo" works correctly in 1.4.4 but
508         "svn info" from the directory "foo" doesn't if foo is
509         not part of a checkout. in_working_directory() and
510         value_from_svn_info() were using the arguments inconsistently,
511         leading to weird errors.
512
513         * Scripts/webkitpy/common/checkout/scm/scm.py:
514         (SCM):
515         (SCM.in_working_directory):
516         * Scripts/webkitpy/common/checkout/scm/svn.py:
517         (SVN):
518         (SVN.in_working_directory):
519
520 2012-05-18  Levi Weintraub  <leviw@chromium.org>
521
522         Unreviewed. Moving myself from committer to reviewer.
523
524         * Scripts/webkitpy/common/config/committers.py:
525
526 2012-05-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
527
528         [EFL] Buildbot output does not print result stats anymore
529         https://bugs.webkit.org/show_bug.cgi?id=85366
530
531         Reviewed by Ryosuke Niwa.
532
533         Make run-webkit-tests pass --verbose to new-run-webkit-tests
534         on EFL Debug bot.
535
536         * Scripts/run-webkit-tests:
537         (runningOnBuildBot):
538
539 2012-05-18  Tony Chang  <tony@chromium.org>
540
541         remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
542         https://bugs.webkit.org/show_bug.cgi?id=86767
543
544         Reviewed by Ojan Vafai.
545
546         * DumpRenderTree/chromium/LayoutTestController.cpp:
547         (LayoutTestController::overridePreference):
548         * DumpRenderTree/chromium/WebPreferences.cpp:
549         (WebPreferences::reset):
550         (WebPreferences::applyTo):
551         * DumpRenderTree/chromium/WebPreferences.h:
552         (WebPreferences):
553         * Scripts/webkitperl/FeatureList.pm:
554
555 2012-05-18  Hugo Parente Lima  <hugo.lima@openbossa.org>
556
557         [Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
558         https://bugs.webkit.org/show_bug.cgi?id=86731
559
560         Reviewed by Simon Hausmann.
561
562         Set the page visibility on a single page instead of on all pages
563         from the page group.
564
565         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
566         (WTR::LayoutTestController::setPageVisibility):
567         (WTR::LayoutTestController::resetPageVisibility):
568
569 2012-05-18  Yi Shen  <yi.4.shen@nokia.com>
570
571         REGRESSION (r102553): Smart links do not work
572         https://bugs.webkit.org/show_bug.cgi?id=85463
573
574         Reviewed by Ryosuke Niwa.
575
576         Add LayoutTestController::setAutomaticLinkDetectionEnabled().
577
578         * DumpRenderTree/LayoutTestController.cpp:
579         (setAutomaticLinkDetectionEnabledCallback):
580         (LayoutTestController::staticFunctions):
581         * DumpRenderTree/LayoutTestController.h:
582         (LayoutTestController):
583         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
584         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
585         * DumpRenderTree/chromium/LayoutTestController.cpp:
586         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
587         * DumpRenderTree/chromium/LayoutTestController.h:
588         (LayoutTestController):
589         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
590         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
591         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
592         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
593         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
594         (LayoutTestController::setAutomaticLinkDetectionEnabled): Set automatic link detection enabled.
595         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
596         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
597         * DumpRenderTree/qt/LayoutTestControllerQt.h:
598         (LayoutTestController):
599         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
600         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
601         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
602         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
603
604 2012-05-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
605
606         [EFL] Add shortcut to dump Security Origin and Web Database information
607         https://bugs.webkit.org/show_bug.cgi?id=86521
608
609         Reviewed by Gustavo Noronha Silva.
610
611         Added key combination (CTRL+s) to dump information about the
612         security origin and databases of the main frame. Useful for API
613         testing and debugging.
614
615         * EWebLauncher/main.c:
616         (on_key_down):
617
618 2012-05-18  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
619
620         [EFL] DRT needs an implementation of layoutTestController.setSerializeHTTPLoads
621         https://bugs.webkit.org/show_bug.cgi?id=86101
622
623         Reviewed by Ryosuke Niwa.
624
625         Add missing implementation setSerializeHTTPLoads to allow
626         testing resource load order.
627
628         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
629         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
630         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
631         (LayoutTestController::setSerializeHTTPLoads):
632
633 2012-05-18  Jochen Eisinger  <jochen@chromium.org>
634
635         [chromium] plumb the frame for which a drag was initiated to the WebViewClient
636
637         https://bugs.webkit.org/show_bug.cgi?id=86670
638
639         Reviewed by Kent Tamura.
640
641         * DumpRenderTree/chromium/WebViewHost.cpp:
642         (WebViewHost::startDragging):
643         * DumpRenderTree/chromium/WebViewHost.h:
644         (WebViewHost):
645
646 2012-05-18  Christophe Dumez  <christophe.dumez@intel.com>
647
648         [EFL] appcache tests are flaky
649         https://bugs.webkit.org/show_bug.cgi?id=86619
650
651         Reviewed by Ryosuke Niwa.
652
653         Correctly set the application cache database path in EFL's
654         DumpRenderTree initialization code.
655
656         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
657         (DumpRenderTreeChrome::initialize):
658
659 2012-05-17  Raphael Kubo da Costa  <rakuco@webkit.org>
660
661         [EFL][DRT] Call resetInternalsObject() after each test.
662         https://bugs.webkit.org/show_bug.cgi?id=86793
663
664         Reviewed by Antonio Gomes.
665
666         We need to reset the internals object's settings after running
667         each test so that there are no interferences between each test's
668         results.
669
670         * DumpRenderTree/efl/DumpRenderTree.cpp:
671         (runTest):
672
673 2012-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>
674
675         Unreviewed, rolling out r117526.
676         http://trac.webkit.org/changeset/117526
677         https://bugs.webkit.org/show_bug.cgi?id=86801
678
679         broke Chromium Mac 10.5 layout test canaries (Requested by
680         pkasting on #webkit).
681
682         * Scripts/webkitpy/common/checkout/scm/scm.py:
683         (SCM):
684         (SCM.in_working_directory):
685         * Scripts/webkitpy/common/checkout/scm/svn.py:
686         (SVN):
687         (SVN.in_working_directory):
688
689 2012-05-17  Dirk Pranke  <dpranke@chromium.org>
690
691         scm.add() doesn't work properly with svn 1.7
692         https://bugs.webkit.org/show_bug.cgi?id=86779
693
694         Reviewed by Ojan Vafai.
695
696         The code relied on '.svn' directories being present
697         in order to tell if a directory had already been added to the
698         repository; this is no longer true in SVN 1.7.
699
700         * Scripts/webkitpy/common/checkout/scm/scm.py:
701         (SCM):
702         (SCM.in_working_directory):
703         * Scripts/webkitpy/common/checkout/scm/svn.py:
704         (SVN):
705         (SVN.in_working_directory):
706
707 2012-05-17  Jon Lee  <jonlee@apple.com>
708
709         Update Apple buildbots to prioritize latest changelists
710         https://bugs.webkit.org/show_bug.cgi?id=86766
711
712         Reviewed by Brady Eidson.
713
714         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
715         (pickLatestBuild): Function to get the most pick the most recent build request.
716         (loadBuilderConfig): Configure builders in the AppleMac and AppleWin categories to
717         use the pickLatestBuild function when choosing which request to build next.
718
719 2012-05-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
720
721         [Qt] Fix MiniBrowser by using correct syntax for qrc URLs
722         https://bugs.webkit.org/show_bug.cgi?id=86761
723
724         Reviewed by Alexis Menard.
725
726         * MiniBrowser/qt/BrowserWindow.cpp:
727         (BrowserWindow::BrowserWindow):
728         (BrowserWindow::updateVisualMockTouchPoints):
729
730 2012-05-17  Thiago Marcos P. Santos  <thiago.santos@intel.com>
731
732         [EFL] Add API for Web Database handling
733         https://bugs.webkit.org/show_bug.cgi?id=85178
734
735         Reviewed by Antonio Gomes.
736
737         Use the newly introduced Web Database API in EFL's DRT.
738
739         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
740         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
741         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
742         (LayoutTestController::clearAllDatabases):
743
744 2012-05-17  Dan Bernstein  <mitz@apple.com>
745
746         REGRESSION (r117428): WebKit API/SPI was removed
747         https://bugs.webkit.org/show_bug.cgi?id=86748
748
749         Reverted r117428.
750
751         * DumpRenderTree/LayoutTestController.cpp:
752         (setDomainRelaxationForbiddenForURLSchemeCallback):
753         (LayoutTestController::staticFunctions):
754         * DumpRenderTree/LayoutTestController.h:
755         (LayoutTestController):
756         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
757         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
758         * DumpRenderTree/chromium/LayoutTestController.cpp:
759         (LayoutTestController::LayoutTestController):
760         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
761         * DumpRenderTree/chromium/LayoutTestController.h:
762         (LayoutTestController):
763         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
764         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
765         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
766         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
767         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
768         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
769         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
770         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
771         * DumpRenderTree/qt/LayoutTestControllerQt.h:
772         (LayoutTestController):
773         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
774         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
775         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
776         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
777
778 2012-05-17  Li Yin  <li.yin@intel.com>
779
780         [chromium] run-webkit-tests can't work on ubuntu 12.04
781         https://bugs.webkit.org/show_bug.cgi?id=86565
782
783         Reviewed by Kent Tamura.
784
785         On ubuntu 12.04, the package ttf-thai-tlwg install the Garuda.ttf
786         into /usr/share/fonts/truetype/tlwg/Garuda.ttf, not /usr/share/fonts/truetype/thai/Garuda.ttf
787
788         * DumpRenderTree/chromium/TestShellLinux.cpp:
789         (checkAndLoadFontFile):
790         (setupFontconfig):
791
792 2012-05-17  Elliot Poger  <epoger@chromium.org>
793
794         Add setting of additional_expectations option to 
795         chromium_unittest.test_overrides_and_builder_names(),
796         so we can test order in which the base and chromium expectations files
797         are combined.
798
799         https://bugs.webkit.org/show_bug.cgi?id=86642
800
801         Reviewed by Dirk Pranke.
802
803         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
804         (ChromiumPortTest.test_overrides_and_builder_names):
805
806 2012-05-17  Balazs Kelemen  <kbalazs@webkit.org>
807
808         [Qt] Web process hangs while waiting for plugin process connection during layouttests
809         https://bugs.webkit.org/show_bug.cgi?id=86620
810
811         Reviewed by Csaba Osztrogonác.
812
813         Reenable TestNetscapePlugin with Qt 4.
814
815         * Tools.pro:
816
817 2012-05-17  Hugo Parente Lima  <hugo.lima@openbossa.org>
818
819         [Qt][WK2] fast/events/page-visibility-* tests fail
820         https://bugs.webkit.org/show_bug.cgi?id=83263
821
822         Reviewed by Kenneth Rohde Christiansen.
823
824         Handle "preview" state and avoid string conversion.
825
826         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
827         (WTR::LayoutTestController::setPageVisibility):
828
829 2012-05-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
830
831         Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
832         https://bugs.webkit.org/show_bug.cgi?id=86704
833
834         Reviewed by Eric Seidel.
835
836         Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
837         cross-port way through the InternalSettings interface.
838
839         * DumpRenderTree/LayoutTestController.cpp:
840         (LayoutTestController::staticFunctions):
841         * DumpRenderTree/LayoutTestController.h:
842         (LayoutTestController):
843         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
844         * DumpRenderTree/chromium/LayoutTestController.cpp:
845         (LayoutTestController::LayoutTestController):
846         * DumpRenderTree/chromium/LayoutTestController.h:
847         (LayoutTestController):
848         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
849         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
850         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
851         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
852         * DumpRenderTree/qt/LayoutTestControllerQt.h:
853         (LayoutTestController):
854         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
855         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
856
857 2012-05-17  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
858
859         [EFL] [DRT] EFL's DumpRenderTree should support LayoutTestController's dumpEditingCallbacks()
860         https://bugs.webkit.org/show_bug.cgi?id=84835
861
862         Reviewed by Eric Seidel.
863
864         Added editing callbacks implementation.
865
866         * DumpRenderTree/efl/CMakeLists.txt: Add EditingCallbacks.cpp to compilation.
867         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Invoke connectEditingCallbacks.
868         (DumpRenderTreeChrome::createView):
869         * DumpRenderTree/efl/EditingCallbacks.cpp: Added. Dump editing callbacks.
870         (dumpPath):
871         (dumpRange):
872         (insertActionString):
873         (selectionAffinityString):
874         (shouldBeginEditing):
875         (shouldEndEditing):
876         (shouldInsertNode):
877         (shouldInsertText):
878         (shouldDeleteRange):
879         (shouldChangeSelectedRange):
880         (shouldApplyStyle):
881         (editingBegan):
882         (userChangedContents):
883         (editingEnded):
884         (selectionChanged):
885         (connectEditingCallbacks):
886         * DumpRenderTree/efl/EditingCallbacks.h: Added.
887
888 2012-05-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
889
890         Unreviewed. Roll out r117382 because of layout test crashes on EFL debug buildbot.
891
892         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
893         (DumpRenderTreeChrome::initialize):
894
895 2012-05-17  Kentaro Hara  <haraken@chromium.org>
896
897         [Performance test] In perftest.py, do not include 'description' in 'results'
898         https://bugs.webkit.org/show_bug.cgi?id=86696
899
900         Reviewed by Csaba Osztrogoná.
901
902         'results' in perftest.py should not include any data that is not expected
903         by the perf bot server. We do not need to send 'description' to the perf bot
904         server since 'description' is always the same.
905
906         Thus this patch just removes 'description' from 'results'.
907
908         * Scripts/webkitpy/performance_tests/perftest.py:
909         (PerfTest.parse_output):
910         (PerfTest.output_statistics):
911         (ChromiumStylePerfTest.parse_output):
912         (PageLoadingPerfTest.run):
913
914 2012-05-17  Kentaro Hara  <haraken@chromium.org>
915
916         [Performance test] Always fill results['description'] in perftest.py
917         https://bugs.webkit.org/show_bug.cgi?id=86696
918
919         Reviewed by Ryosuke Niwa.
920
921         This is a follow-up patch for r117397 to fix perf bot failures.
922         This patch fills results['description'] always.
923
924         * Scripts/webkitpy/performance_tests/perftest.py:
925         (PageLoadingPerfTest.run):
926
927 2012-05-16  Kentaro Hara  <haraken@chromium.org>
928
929         [Performance test] Support "description" for PerfTestRunner.run and PerfTestRunner.runPerSecond
930         https://bugs.webkit.org/show_bug.cgi?id=86696
931
932         Reviewed by Ryosuke Niwa.
933
934         We want to add some description for each PerfTestRunner.run and
935         PerfTestRunner.runPerSecond, so that people can know what each
936         run is testing.
937
938         Output example:
939
940         $ ./Tools/Scripts/run-perf-tests Bindings/first-child.html
941         Running Bindings/first-child.html (1 of 1)
942         DESCRIPTION: Benchmark for DOM attributes that return a Node object.
943         RESULT Bindings: first-child= 788.359076534 runs/s
944         median= 797.508097751 runs/s, stdev= 19.0972905207 runs/s, min= 746.666666667 runs/s, max= 801.001251564 runs/s
945
946         * Scripts/webkitpy/performance_tests/perftest.py:
947         (PerfTest):
948         (PerfTest.parse_output):
949         (PerfTest.output_statistics):
950
951 2012-05-16  Christophe Dumez  <christophe.dumez@intel.com>
952
953         [EFL] appcache tests are flaky
954         https://bugs.webkit.org/show_bug.cgi?id=86619
955
956         Reviewed by Gustavo Noronha Silva.
957
958         Correctly set the application cache database path in EFL's
959         DumpRenderTree initialization code.
960
961         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
962         (DumpRenderTreeChrome::initialize):
963
964 2012-05-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
965
966         Add new build slave for EFL port.
967         https://bugs.webkit.org/show_bug.cgi?id=86567
968
969         Reviewed by Ryosuke Niwa.
970
971         Add a build slave for EFL 32-bit linux build.
972
973         * BuildSlaveSupport/build.webkit.org-config/config.json:
974
975 2012-05-16  Kihong Kwon  <kihong.kwon@samsung.com>
976
977         [EFL] Support for Battery Status API on the WebKit-Efl
978         https://bugs.webkit.org/show_bug.cgi?id=83254
979
980         Reviewed by Chang Shu.
981
982         Add e_dbus libraries to jhbuild's modules list.
983
984         * efl/jhbuild.modules:
985
986 2012-05-16  Christophe Dumez  <christophe.dumez@intel.com>
987
988         [EFL] Rounding errors on 32-bit machines causes tests to fail
989         https://bugs.webkit.org/show_bug.cgi?id=86194
990
991         Reviewed by Martin Robinson.
992
993         Pass additional CXXFLAGS to CMake in an attempt to harmonize floating
994         point values between 32-bit and 64-bit architectures.
995         Same flags are already used by Qt and GTK ports. 
996
997         * Scripts/webkitdirs.pm:
998         (determineArchitecture):
999         (generateBuildSystemFromCMakeProject):
1000
1001 2012-05-16  Balazs Kelemen  <kbalazs@webkit.org>
1002
1003         [Qt] Web process hangs while waiting for plugin process connection during layouttests
1004         https://bugs.webkit.org/show_bug.cgi?id=86620
1005
1006         Reviewed by Csaba Osztrogonác.
1007
1008         Temporary workaround not to fail layout tests.
1009
1010         * Tools.pro: Disable TestNetscapePlugin.
1011
1012 2012-05-16  Dinu Jacob  <dinu.jacob@nokia.com>
1013
1014         Add didFinishProgress BundleUIClient callback
1015         https://bugs.webkit.org/show_bug.cgi?id=86541
1016
1017         Reviewed by Kenneth Rohde Christiansen.
1018
1019         Added support for dumpProgressFinishedCallback.
1020
1021         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1022         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1023         (WTR::InjectedBundlePage::InjectedBundlePage):
1024         (WTR::InjectedBundlePage::didFinishProgress):
1025         (WTR):
1026         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1027         (InjectedBundlePage):
1028         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1029         (WTR::LayoutTestController::LayoutTestController):
1030         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1031         (WTR::LayoutTestController::dumpProgressFinishedCallback):
1032         (WTR::LayoutTestController::setShouldDumpProgressFinishedCallback):
1033         (WTR::LayoutTestController::shouldDumpProgressFinishedCallback):
1034         (LayoutTestController):
1035
1036 2012-05-15  Pierre Rossi  <pierre.rossi@gmail.com>
1037
1038         [Qt] Enable SVG Fonts by default
1039         https://bugs.webkit.org/show_bug.cgi?id=86463
1040
1041         Reviewed by Nikolas Zimmermann.
1042
1043         * qmake/mkspecs/features/features.pri:
1044
1045 2012-05-16  Christophe Dumez  <christophe.dumez@intel.com>
1046
1047         [EFL] EFL's LayoutTestController does not implement setApplicationCacheOriginQuota
1048         https://bugs.webkit.org/show_bug.cgi?id=85585
1049
1050         Reviewed by Gustavo Noronha Silva.
1051
1052         Implement setApplicationCacheOriginQuota in EFL's
1053         LayoutTestController.
1054
1055         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1056         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1057         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1058         (onExceededApplicationCacheQuota):
1059         (drtViewAdd):
1060         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1061         (LayoutTestController::setApplicationCacheOriginQuota):
1062
1063 2012-05-16  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1064
1065         [EFL] EFL's LayoutTestController  evaluateScriptInIsolatedWorld implementation
1066         https://bugs.webkit.org/show_bug.cgi?id=83776
1067
1068         Reviewed by Tor Arne Vestbø.
1069
1070         Added missing implementation of LayoutTestController::evaluateScriptInIsolatedWorld().
1071
1072         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1073         (LayoutTestController::evaluateScriptInIsolatedWorld):
1074
1075 2012-05-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1076
1077         Unreviewed. Add myself as a committer.
1078
1079         * Scripts/webkitpy/common/config/committers.py:
1080
1081 2012-05-15  Kangil Han  <kangil.han@samsung.com>
1082
1083         [EFL][DRT] Fix eventSender key providing
1084         https://bugs.webkit.org/show_bug.cgi?id=84710
1085
1086         Reviewed by Andreas Kling.
1087
1088         Currently eventSender doesn't provide key event correctly.
1089         For example, 'Right' will be visible when 'right arrow' key event is fired.
1090         Given circumstance, nothing has to be shown.
1091         Therefore, this patch fixed incorrectly provided key event.
1092
1093         * DumpRenderTree/efl/EventSender.cpp:
1094         (KeyEventInfo::KeyEventInfo):
1095         (KeyEventInfo):
1096         (keyPadNameFromJSValue):
1097         (keyNameFromJSValue):
1098         (createKeyEventInfo):
1099         (sendKeyDown):
1100
1101 2012-05-15  Dan Bernstein  <mitz@apple.com>
1102
1103         Fixed a typo.
1104
1105         * Scripts/copy-webkitlibraries-to-product-directory:
1106
1107 2012-05-15  Kihong Kwon  <kihong.kwon@samsung.com>
1108
1109         [EFL] Enable Fullscreen API
1110         https://bugs.webkit.org/show_bug.cgi?id=85870
1111
1112         Reviewed by Antonio Gomes.
1113
1114         Enable full screen api feature on the EFL port.
1115         There are two failed test cases under LayoutTests/fullscreen.
1116         They are going to be fixed with other patch.
1117
1118         * Scripts/webkitperl/FeatureList.pm:
1119
1120 2012-05-15  James Robinson  <jamesr@chromium.org>
1121
1122         [chromium] Chromium port never sets USE(CG) so code behind it is dead
1123         https://bugs.webkit.org/show_bug.cgi?id=86537
1124
1125         Reviewed by Adrienne Walker.
1126
1127         Deletes code behind USE(CG) in chromium-specific code and removes unneeded USE(SKIA) guards.
1128
1129         * DumpRenderTree/chromium/WebViewHost.cpp:
1130         (WebViewHost::paintRect):
1131
1132 2012-05-15  James Robinson  <jamesr@chromium.org>
1133
1134         [chromium] Remove WEBKIT_USING_(SKIA|CG) #defines
1135         https://bugs.webkit.org/show_bug.cgi?id=86536
1136
1137         Reviewed by Adam Barth.
1138
1139         Deletes dead WEBKIT_USING_CG code and #ifdefs guarding it.
1140
1141         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1142         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1143         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1144         * DumpRenderTree/chromium/WebViewHost.cpp:
1145         (WebViewHost::paintPagesWithBoundaries):
1146
1147 2012-05-15  James Robinson  <jamesr@chromium.org>
1148
1149         [chromium] Unreviewed build fix.
1150
1151         Partial revert of r117166 - it appears making DumpRenderTree depend on webkit_platform causes crashes in the
1152         component build, at least on linux.  This restores Tools/DumpRenderTree to its pre-r117166 state.
1153
1154         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1155         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1156         (TestWebPlugin::initialize):
1157
1158 2012-05-15  Elliot Poger  <epoger@google.com>
1159
1160         add unit test for NRWT's --additional-expectations option
1161         https://bugs.webkit.org/show_bug.cgi?id=86501
1162
1163         Reviewed by Ojan Vafai.
1164
1165         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1166         (PortTest.test_additional_expectations):
1167
1168 2012-05-15  James Robinson  <jamesr@chromium.org>
1169
1170         [chromium] Move createOffscreenGraphicsContext3D() from WebKitPlatformSupport to Platform
1171         https://bugs.webkit.org/show_bug.cgi?id=86524
1172
1173         Reviewed by Adam Barth.
1174
1175         Updates TestWebPlugin to use the Platform headers and updates the build dependencies so it can.
1176
1177         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1178         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1179         (TestWebPlugin::initialize):
1180
1181 2012-05-15  Jessie Berlin  <jberlin@apple.com>
1182
1183         WKContextSetCacheModel(contextref, kWKCacheModelDocumentViewer) doesn't prevent pages from
1184         going into the PageCache.
1185         https://bugs.webkit.org/show_bug.cgi?id=85891
1186
1187         Reviewed by Brady Eidson.
1188
1189         Set the cache model in DOMWindowExtensionNoCache so that the page cache is not used. This is
1190         better than using pages with unload handlers because we may find a way to make pages with
1191         unload handlers cacheable in the future.
1192
1193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1194         Remove simple-iframe-unload.html and simple-unload.html, since they are no longer used.
1195
1196         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1197         (TestWebKitAPI::TEST):
1198         Set the cache model to kWKCacheModelDocumentViewer.
1199
1200         * TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Removed.
1201         * TestWebKitAPI/Tests/WebKit2/simple-unload.html: Removed.
1202
1203 2012-05-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1204
1205         [Qt] Add infra for testing double-tap to zoom functionality etc
1206         https://bugs.webkit.org/show_bug.cgi?id=86474
1207
1208         Reviewed by Simon Hausmann.
1209
1210         The WebViewportInfo class was renamed to QWebKitTest in preparation
1211         of becoming a separate module. Adapt the use API.
1212
1213         * MiniBrowser/qt/qml/BrowserWindow.qml:
1214         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1215
1216 2012-05-15  Csaba Osztrogonác  <ossy@webkit.org>
1217
1218         Introduce ENABLE_CSS_VARIABLES compile flag.
1219         https://bugs.webkit.org/show_bug.cgi?id=86338
1220
1221         Reviewed by Hajime Morita.
1222
1223         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Unittest fix after r117028.
1224         (WebKitPortTest.test_skipped_directories_for_symbols):
1225
1226 2012-05-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1227
1228         Teach webkit-patch to gracefully handle writes of raw utf-8 encoded strings to sys.stdout
1229
1230         https://bugs.webkit.org/show_bug.cgi?id=85809
1231
1232         webkit-patch overrides sys.stdout with a StreamWriter that ensures we write utf8
1233         output to stdout, but StreamWriter will by default always encode the object that's
1234         passed to write(). This blows up when the object is a raw string, already encoded
1235         as utf8, and does not match the default behavior of sys.stdout.
1236
1237         To solve this in one place, instead of every single call-site that might write
1238         raw strings, we extend the stdout-wrapper to assume raw strings are utf8 before
1239         passing them on to StreamWriter.write(). This has the benefit of also making the
1240         stacktrace easy to read in the case where this assumption does not hold.
1241
1242         The source of this particular bug was that Executive.run_and_throw_if_fail() will
1243         tee the output of the subprocess, and in the case of running prepare-ChangeLog this
1244         might produce non-ascii output, which gets written directly to sys.stdout as raw
1245         utf8-encoded strings.
1246
1247         Reviewed by Dirk Pranke.
1248
1249         * Scripts/webkit-patch:
1250
1251 2012-05-15  Tomasz Morawski  <t.morawski@samsung.com>
1252
1253         [EFL][DRT] Split ewk_private.h file to multiple private files.
1254         https://bugs.webkit.org/show_bug.cgi?id=84572
1255
1256         Reviewed by Antonio Gomes.
1257
1258         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1259
1260 2012-05-15  Michael Brüning  <michael.bruning@nokia.com>
1261
1262         [Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with timeout
1263         https://bugs.webkit.org/show_bug.cgi?id=83576
1264
1265         Reviewed by Simon Hausmann.
1266
1267         Set the PlatformWebView for the Qt port to accept all SSL certificates.
1268
1269         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1270         (WTR::PlatformWebView::PlatformWebView):
1271
1272 2012-05-14  Luke Macpherson  <macpherson@chromium.org>
1273
1274         Introduce ENABLE_CSS_VARIABLES compile flag.
1275         https://bugs.webkit.org/show_bug.cgi?id=86338
1276
1277         Reviewed by Dimitri Glazkov.
1278
1279         Add a configuration option for CSS Variables support, disabling it by default.
1280
1281         * Scripts/webkitperl/FeatureList.pm:
1282         * Scripts/webkitpy/layout_tests/port/webkit.py:
1283         (WebKitPort._missing_symbol_to_skipped_tests):
1284         * qmake/mkspecs/features/features.pri:
1285
1286 2012-05-14  Nate Chapin  <japhet@chromium.org>
1287
1288         Add end-of-life test cases for https://bugs.webkit.org/show_bug.cgi?id=86131.
1289
1290         Reviewed by Adam Barth.
1291
1292         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1293         (callDeletePlugin):
1294         (pluginHasProperty):
1295         (pluginHasMethod):
1296         (pluginGetProperty):
1297         (pluginSetProperty):
1298         (pluginInvoke):
1299
1300 2012-05-14  Dirk Pranke  <dpranke@chromium.org>
1301
1302         Re-enable "drt mode" on chromium-mac-leopard
1303         https://bugs.webkit.org/show_bug.cgi?id=83076
1304
1305         Unreviewed, build fix (change?).
1306
1307         This change is another attempt to gather data on
1308         the flakiness and timeouts we're seeing on Mac SL
1309         now that we have another bot.
1310
1311         * Scripts/webkitpy/layout_tests/port/chromium.py:
1312         (ChromiumDriver.__init__):
1313
1314 2012-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1315
1316         Unreviewed, rolling out r116981.
1317         http://trac.webkit.org/changeset/116981
1318         https://bugs.webkit.org/show_bug.cgi?id=86402
1319
1320         Caused compositing and mathml tests to fail. (Requested by
1321         rakuco on #webkit).
1322
1323         * Scripts/webkitpy/layout_tests/port/efl.py:
1324         (EflPort._path_to_webcore_library):
1325
1326 2012-05-14  Dirk Pranke  <dpranke@chromium.org>
1327
1328         Fix regressions in garden-o-matic after r116988.
1329
1330         Unreviewed, build fix.
1331
1332         I had a typo in a field name in checkout.js, and unfortunately
1333         the unittests had the same typo :(.
1334
1335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1336         (.):
1337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1338
1339 2012-05-14  Dirk Pranke  <dpranke@chromium.org>
1340
1341         garden-o-matic should specify which types of baselines to rebaseline
1342         https://bugs.webkit.org/show_bug.cgi?id=86242
1343
1344         Reviewed by Adam Barth.
1345
1346         This change modifies garden-o-matic so that we are explicit
1347         about whether to rebaseline the text file, the image file, or
1348         both. This should prevent us from pulling incorrect or
1349         unexpected baselines off the bots.
1350
1351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1352         (.):
1353         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1354         (.):
1355         * Scripts/webkitpy/tool/commands/rebaseline.py:
1356         (AbstractRebaseliningCommand):
1357         (AbstractRebaseliningCommand.__init__):
1358         (RebaselineTest):
1359         (RebaselineTest._rebaseline_test_and_update_expectations):
1360         (RebaselineTest.execute):
1361         (OptimizeBaselines):
1362         (OptimizeBaselines._optimize_baseline):
1363         (OptimizeBaselines.execute):
1364         (AnalyzeBaselines):
1365         (AnalyzeBaselines._analyze_baseline):
1366         (AnalyzeBaselines.execute):
1367         (RebaselineExpectations._rebaseline_port):
1368         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1369         (GardeningHTTPRequestHandler.rebaseline):
1370         (GardeningHTTPRequestHandler.optimizebaselines):
1371         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1372         (GardeningServerTest.test_rebaseline):
1373         (GardeningServerTest.test_rebaseline_new_port):
1374         (GardeningServerTest.test_optimizebaselines):
1375
1376 2012-05-14  Kangil Han  <kangil.han@samsung.com>
1377
1378         [EFL][DRT] Fix WebCore library path
1379         https://bugs.webkit.org/show_bug.cgi?id=86355
1380
1381         Reviewed by Dirk Pranke.
1382
1383         Currently EFL DRT uses wrong WebCore library path when running DRT.
1384         This patch simply adjusted it.
1385
1386         * Scripts/webkitpy/layout_tests/port/efl.py:
1387         (EflPort._path_to_webcore_library):
1388
1389 2012-05-14  Wei James  <james.wei@intel.com>
1390
1391         [Chromium] ImageDiff should be build for host on Android
1392         https://bugs.webkit.org/show_bug.cgi?id=82039
1393
1394         Reviewed by Adam Barth.
1395
1396         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1397
1398 2012-05-14  Joone Hur  <joone@webkit.org>
1399
1400         Unreviewed. Updating email for committers.py script.
1401
1402         * Scripts/webkitpy/common/config/committers.py:
1403
1404 2012-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1405
1406         Unreviewed. Fix make distcheck.
1407
1408         * GNUmakefile.am: Add run-api-tests script to EXTRA_DIST.
1409         * gtk/run-api-tests:
1410         (TestRunner._lookup_atspi2_binary): Handle the case when
1411         pkg_config_file_variable() return None.
1412
1413 2012-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1414
1415         Unreviewed, rolling out r116935.
1416         http://trac.webkit.org/changeset/116935
1417         https://bugs.webkit.org/show_bug.cgi?id=86373
1418
1419         Something is still broken (Requested by Ossy on #webkit).
1420
1421         * Scripts/webkitpy/common/checksvnconfigfile.py: Removed.
1422         * Scripts/webkitpy/style/checkers/png.py:
1423         (PNGChecker.check):
1424         (PNGChecker):
1425         (PNGChecker._config_file_path):
1426         * Scripts/webkitpy/tool/commands/download.py:
1427         (Land):
1428         * Scripts/webkitpy/tool/steps/__init__.py:
1429         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Removed.
1430         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Removed.
1431
1432 2012-05-14  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1433
1434         [Qt] Doesn't build with ENABLE_INSPECTOR=0
1435         https://bugs.webkit.org/show_bug.cgi?id=85056
1436
1437         Reviewed by Tor Arne Vestbø.
1438
1439         * WebKitTestRunner/TestInvocation.cpp: Ifdef otherwise unused static function.
1440         * qmake/mkspecs/features/features.prf:
1441         * qmake/mkspecs/features/features.pri:
1442
1443 2012-05-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1444
1445         [Qt] Make sure dialogs have their parent and attached properties set before Component.onCompleted
1446         https://bugs.webkit.org/show_bug.cgi?id=86222
1447
1448         The WebView QML api for dialogs is based on delegates for each dialog, which
1449         are implemented as components. Since there's no explicit API to show the dialog,
1450         the natural place to allow the dialog to choose how to display itself is in
1451         Component.onCompleted.
1452
1453         The issue was that we were using QQmlComponent::create() when instantiating the
1454         component, at which point the component did not have a parent or it's attached
1455         WebView property set. That meant that we had to do some ugly workaround in our
1456         test, using a 1ms timer, to get a callback once the parent was there.
1457
1458         We now use the QQmlComponent::beginCreate() -> QQmlComponent::completeCreate()
1459         pair, which allows us to set the relevant properties before triggering the
1460         Component.onCompleted callback. We were already doing this for the context
1461         menus (except for setting the parent, which we did afterwards).
1462
1463         Reviewed by Simon Hausmann.
1464
1465         * MiniBrowser/qt/qml/BrowserWindow.qml:
1466         * MiniBrowser/qt/qml/Dialog.qml:
1467
1468 2012-05-14  Balazs Ankes  <bank@inf.u-szeged.hu>
1469
1470         webkit-patch land should automatically add svn:mime-type for .png files
1471         https://bugs.webkit.org/show_bug.cgi?id=75825
1472         I refactored the png.py to avoid code duplication.
1473
1474         Reviewed by Dirk Pranke.
1475
1476         * Scripts/webkitpy/common/checksvnconfigfile.py: Added.
1477         (check):
1478         (_config_file_path):
1479         (errorstr_autoprop):
1480         (errorstr_png):
1481         * Scripts/webkitpy/style/checkers/png.py:
1482         (PNGChecker.check):
1483         * Scripts/webkitpy/tool/commands/download.py:
1484         (Land):
1485         * Scripts/webkitpy/tool/steps/__init__.py:
1486         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
1487         (AddSvnMimetypeForPng):
1488         (AddSvnMimetypeForPng.__init__):
1489         (AddSvnMimetypeForPng.run):
1490         (AddSvnMimetypeForPng._check_pngs):
1491         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
1492         (MockSCMDetector):
1493         (MockSCMDetector.__init__):
1494         (MockSCMDetector.display_name):
1495         (AddSvnMimetypeForPngTest):
1496         (AddSvnMimetypeForPngTest.test_run):
1497
1498 2012-05-14  David Kilzer  <ddkilzer@apple.com>
1499
1500         webkit-patch apply-attachment is very slow for big patches
1501         https://bugs.webkit.org/show_bug.cgi?id=74929
1502
1503         Add "excludefield=attachmentdata" to the URL everywhere
1504         "ctype=xml" is used to exclude this field from the XML.
1505
1506         Reviewed by Adam Barth.
1507
1508         * Scripts/prepare-ChangeLog:
1509         (fetchBugDescriptionFromURL):
1510         * Scripts/webkitpy/common/config/urls.py:
1511         * Scripts/webkitpy/common/config/urls_unittest.py:
1512         (URLsTest.test_parse_bug_id):
1513         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1514         (Bugzilla.bug_url_for_bug_id):
1515
1516 2012-05-13  Ryosuke Niwa  <rniwa@webkit.org>
1517
1518         performance tests should be able to measure runs/sec rather than time
1519         https://bugs.webkit.org/show_bug.cgi?id=86021
1520
1521         Reviewed by Ojan Vafai.
1522
1523         Allow " runs/s" or " ms" to appear after numerical values in tests.
1524
1525         * Scripts/webkitpy/performance_tests/perftest.py:
1526         (PerfTest):
1527
1528 2012-05-12  Tim Horton  <timothy_horton@apple.com>
1529
1530         run-safari and co. should support --guard-malloc command line argument
1531         https://bugs.webkit.org/show_bug.cgi?id=86287
1532
1533         Reviewed by Dan Bernstein.
1534
1535         Add setUpGuardMallocIfNeeded(), which consults the argument --guard-malloc on OS X,
1536         setting DYLD_INSERT_LIBRARIES="/usr/lib/libgmalloc.dylib" if it's enabled.
1537
1538         Use setUpGuardMallocIfNeeded() before running a WebKit app (whether standalone or
1539         in the debugger). This will cause gmalloc to be loaded for gdb as well, but this
1540         tends to be harmless.
1541
1542         Change "malloc guard" to the more common "Guard Malloc" in run-webkit-tests.
1543
1544         * Scripts/old-run-webkit-tests:
1545         * Scripts/webkitdirs.pm:
1546         (appendToEnvironmentVariableList):
1547         (setUpGuardMallocIfNeeded):
1548         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
1549         (runMacWebKitApp):
1550         (execMacWebKitAppForDebugging):
1551         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1552         (parse_args):
1553
1554 2012-05-11  Ojan Vafai  <ojan@chromium.org>
1555
1556         Add previous/next buttons the garden-o-matics perf panel
1557         https://bugs.webkit.org/show_bug.cgi?id=86280
1558
1559         Reviewed by Dimitri Glazkov.
1560
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1562         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js:
1563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css:
1564
1565 2012-05-11  Kevin Ollivier  <kevino@theolliviers.com>
1566
1567         [wx] Unreviewed build fix. Fix memory exhausted errors from 32-bit ld on *nix.
1568
1569         * waf/build/settings.py:
1570         (common_configure):
1571
1572 2012-05-11  Dirk Pranke  <dpranke@chromium.org>
1573
1574         webkit-patch rebaseline should fetch stale expectations :)
1575         https://bugs.webkit.org/show_bug.cgi?id=86231
1576
1577         Unreviewed, build fix.
1578
1579         This change reverts r115492 and goes back to fetching individual
1580         baselines from the layout tests directory, rather than fetching
1581         entire zip files. The performance hit over networks for people
1582         far away from the bots has turned out to be severe, so we need a
1583         better solution to this.
1584
1585         * Scripts/webkitpy/tool/commands/rebaseline.py:
1586         (RebaselineTest._results_url):
1587         (RebaselineTest._file_name_for_expected_result):
1588         (RebaselineTest._rebaseline_test):
1589         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1590         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1591         (test_rebaseline_updates_expectations_file):
1592         (test_rebaseline_test):
1593         (test_rebaseline_and_copy_test):
1594         (test_rebaseline_and_copy_test_no_existing_result):
1595         (test_rebaseline_and_copy_test_with_lion_result):
1596         (test_rebaseline_and_copy_no_overwrite_test):
1597
1598 2012-05-11  Christophe Dumez  <christophe.dumez@intel.com>
1599
1600         [GTK] LayoutTests/svg/batik/text/verticalText.svg fails to display Chinese characters
1601         https://bugs.webkit.org/show_bug.cgi?id=86198
1602
1603         Reviewed by Martin Robinson.
1604
1605         Update webkitgtk-fonts package to v0.0.3 in order to get new Kochi
1606         Mincho / Gothic fonts to display Japanese and Chinese characters.
1607
1608         * gtk/jhbuild.modules:
1609
1610 2012-05-11  Christophe Dumez  <christophe.dumez@intel.com>
1611
1612         [EFL][DRT] SVG Batik test fails to display Chinese characters
1613         https://bugs.webkit.org/show_bug.cgi?id=84461
1614
1615         Reviewed by Martin Robinson.
1616
1617         Update webkitgtk-fonts package from v0.0.1 to v0.0.3 in order to get
1618         new Kochi Mincho / Gothic fonts to display Japanese and Chinese
1619         characters.
1620
1621         * DumpRenderTree/efl/CMakeLists.txt:
1622         * efl/jhbuild.modules:
1623
1624 2012-05-11  Philippe Normand  <pnormand@igalia.com>
1625
1626         Unreviewed, GTK 64-bit Debug bot fix attempt.
1627
1628         * Scripts/webkitpy/layout_tests/port/gtk.py:
1629         (GtkPort._get_gdb_output): Ignore unicode decoding errors when
1630         processing gdb output.
1631
1632 2012-05-11  Gustavo Noronha Silva  <gns@gnome.org>
1633
1634         REGRESSION(r116205): [GTK]: build no longer supports thin archives
1635         https://bugs.webkit.org/show_bug.cgi?id=86207
1636
1637         * GNUmakefile.am: link libWebCoreModules to DRT.
1638
1639 2012-05-10  Ojan Vafai  <ojan@chromium.org>
1640
1641         Add a perf tab to garden-o-matic
1642         https://bugs.webkit.org/show_bug.cgi?id=86169
1643
1644         Reviewed by Dimitri Glazkov.
1645
1646         This is a first stab at making it easier to view the Chromium WebKit canary
1647         perf graphs. For now, it's just a couple select elements and an iframe.
1648
1649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js: Added.
1656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js: Added.
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1658         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css: Added.
1659         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1660
1661 2012-05-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1662
1663         Move resumeAnimations to use Internals interface
1664         https://bugs.webkit.org/show_bug.cgi?id=86063
1665
1666         Reviewed by Alexey Proskuryakov.
1667
1668         Remove resumeAnimations functions, because it is able to work in the 
1669         cross-port way through the Internals interface.
1670
1671         * DumpRenderTree/LayoutTestController.cpp:
1672         (LayoutTestController::staticFunctions):
1673         * DumpRenderTree/LayoutTestController.h:
1674         (LayoutTestController):
1675         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1676         * DumpRenderTree/chromium/LayoutTestController.cpp:
1677         (LayoutTestController::LayoutTestController):
1678         * DumpRenderTree/chromium/LayoutTestController.h:
1679         (LayoutTestController):
1680         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1681         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1682         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1683         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1684         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1685         (LayoutTestController):
1686         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1687         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1688         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1689         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1690         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1691         (LayoutTestController):
1692
1693 2012-05-10  Alexey Proskuryakov  <ap@apple.com>
1694
1695         Crash in 3rd party WebKit apps that disable cache at a wrong time
1696         https://bugs.webkit.org/show_bug.cgi?id=86027
1697         <rdar://problem/10615880>
1698
1699         Reviewed by Antti Koivisto.
1700
1701         Added a test that's very similar to MemoryCachePruneWithinResourceLoadDelegate,
1702         but for disabling the cache instead of triggering a prune.
1703
1704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1705         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.html: Added.
1706         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm: Added.
1707         (-[MemoryCacheDisableTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1708         (-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1709         (-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1710         (-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1711         (TestWebKitAPI::TEST):
1712
1713 2012-05-10  Anders Carlsson  <andersca@apple.com>
1714
1715         WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
1716         https://bugs.webkit.org/show_bug.cgi?id=86164
1717         <rdar://problem/9551196>
1718
1719         Reviewed by Sam Weinig.
1720
1721         Update for WK2 API changes.
1722
1723         * MiniBrowser/mac/BrowserWindowController.m:
1724         (-[BrowserWindowController awakeFromNib]):
1725         * WebKitTestRunner/TestController.cpp:
1726         (WTR::TestController::createOtherPage):
1727         (WTR::TestController::initialize):
1728
1729 2012-05-10  Dirk Pranke  <dpranke@chromium.org>
1730
1731         nrwt: [chromium] fix path to asan symbolize script
1732         https://bugs.webkit.org/show_bug.cgi?id=86161
1733
1734         Reviewed by Abhishek Arya.
1735
1736         * Scripts/webkitpy/layout_tests/port/chromium.py:
1737         (ChromiumPort._get_crash_log):
1738
1739 2012-05-10  Lei Zhang  <thestig@chromium.org>
1740
1741         [chromium] Set Valgrind environment variables for layout tests.
1742         https://bugs.webkit.org/show_bug.cgi?id=86156
1743
1744         Reviewed by Dirk Pranke.
1745
1746         * Scripts/webkitpy/layout_tests/port/chromium.py:
1747         (ChromiumPort.setup_environ_for_server):
1748
1749 2012-05-10  Raphael Kubo da Costa  <rakuco@webkit.org>
1750
1751         [webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
1752         https://bugs.webkit.org/show_bug.cgi?id=86145
1753
1754         Reviewed by Dirk Pranke.
1755
1756         The GTK+ and EFL ports use jhbuild to build a few base libraries
1757         which are then used when building the port itself. Programs such
1758         as DRT and ImageDiff are then supposed to be run with the
1759         `run-with-jhbuild' wrapper so that the libraries are properly
1760         found and loaded.
1761
1762         This was already the case for DumpRenderTree (EflPort defines the
1763         'wrapper' option for that), but it was not possible to do the same
1764         with ImageDiff so far.
1765
1766         The code which created the ImageDiff command-line call has been
1767         moved to a separate method, _image_diff_command, which is then
1768         overridden by EflPort to add the jhbuild wrapper.
1769
1770         * Scripts/webkitpy/layout_tests/port/efl.py:
1771         (EflPort.__init__):
1772         (EflPort._image_diff_command):
1773         * Scripts/webkitpy/layout_tests/port/webkit.py:
1774         (WebKitPort):
1775         (WebKitPort._image_diff_command):
1776         (WebKitPort._start_image_diff_process):
1777
1778 2012-05-10  Zan Dobersek  <zandobersek@gmail.com>
1779
1780         [GTK] ENABLE_IFRAME_SEAMLESS support
1781         https://bugs.webkit.org/show_bug.cgi?id=85843
1782
1783         Reviewed by Eric Seidel.
1784
1785         Add the iframe-seamless option to the options list. This makes it
1786         possible to enable the iframe seamless support through build-webkit
1787         script. Enabled by default for all the ports.
1788
1789         * Scripts/webkitperl/FeatureList.pm:
1790
1791 2012-05-10  Raphael Kubo da Costa  <rakuco@webkit.org>
1792
1793         [EFL][webkitpy] Do not redefine check_build() in EflPort.
1794         https://bugs.webkit.org/show_bug.cgi?id=86124
1795
1796         Reviewed by Dirk Pranke.
1797
1798         Remove an old FIXME and do not redefine check_build in EflPort;
1799         once build-dumprendertree recognizes --efl, we can use the
1800         check_build implementation in WebKitPort.
1801
1802         * Scripts/build-dumprendertree:
1803         * Scripts/webkitpy/layout_tests/port/efl.py:
1804         (EflPort.check_build):
1805
1806 2012-05-10  Tommy Widenflycht  <tommyw@google.com>
1807
1808         [chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
1809         https://bugs.webkit.org/show_bug.cgi?id=86087
1810
1811         Reviewed by Adam Barth.
1812
1813         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
1814         (MockExtraData):
1815         (WebKit):
1816         (WebKit::WebUserMediaClientMock::requestUserMedia):
1817
1818 2012-05-10  Varun Jain  <varunjain@google.com>
1819
1820         [chromium] Trigger context menu for long press gesture
1821         https://bugs.webkit.org/show_bug.cgi?id=85919
1822
1823         Reviewed by Adam Barth.
1824
1825         * DumpRenderTree/chromium/EventSender.cpp:
1826         (EventSender::EventSender):
1827         (EventSender::gestureLongPress):
1828         (EventSender::gestureEvent):
1829         * DumpRenderTree/chromium/EventSender.h:
1830         (EventSender):
1831
1832 2012-05-10  Takashi Toyoshima  <toyoshim@chromium.org>
1833
1834         don't use autoinstall to import pywebsocket but check it in WebKit directly.
1835         https://bugs.webkit.org/show_bug.cgi?id=86107
1836
1837         Reviewed by Adam Barth.
1838
1839         This change removes pywebsocket from webkitpy's autoinstall list and
1840         imports pywebsocket 0.7.4 directly into webkitpy/thirparty.
1841
1842         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1843         (PyWebSocket._prepare_config):
1844         * Scripts/webkitpy/thirdparty/__init__.py:
1845         (AutoinstallImportHook.find_module):
1846         (AutoinstallImportHook._install_irc):
1847         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1848         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
1849         (ThirdpartyTest.test_import_hook.MockImportHook._install_eliza):
1850         (ThirdpartyTest):
1851         (ThirdpartyTest.test_import_hook):
1852         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Added.
1853         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Added.
1854         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Added.
1855         (ConnectionTerminatedException):
1856         (InvalidFrameException):
1857         (BadOperationException):
1858         (UnsupportedFrameException):
1859         (InvalidUTF8Exception):
1860         (StreamBase):
1861         (StreamBase.__init__):
1862         (StreamBase._read):
1863         (StreamBase._write):
1864         (StreamBase.receive_bytes):
1865         (StreamBase._read_until):
1866         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Added.
1867         (for):
1868         (StreamHixie75):
1869         (StreamHixie75.for):
1870         (StreamHixie75.__init__):
1871         (StreamHixie75.send_message):
1872         (StreamHixie75._read_payload_length_hixie75):
1873         (StreamHixie75.receive_message):
1874         (StreamHixie75._send_closing_handshake):
1875         (StreamHixie75.close_connection):
1876         (StreamHixie75.send_ping):
1877         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Added.
1878         (Frame):
1879         (Frame.__init__):
1880         (create_length_header):
1881         (create_header):
1882         (_build_frame):
1883         (_filter_and_format_frame_object):
1884         (create_binary_frame):
1885         (create_text_frame):
1886         (FragmentedFrameBuilder):
1887         (FragmentedFrameBuilder.to):
1888         (FragmentedFrameBuilder.__init__):
1889         (FragmentedFrameBuilder.build):
1890         (_create_control_frame):
1891         (create_ping_frame):
1892         (create_pong_frame):
1893         (create_close_frame):
1894         (StreamOptions):
1895         (StreamOptions.__init__):
1896         (Stream):
1897         (Stream.for):
1898         (Stream.__init__):
1899         (Stream._receive_frame):
1900         (Stream._receive_frame_as_frame_object):
1901         (Stream.send_message):
1902         (Stream.receive_message):
1903         (Stream._send_closing_handshake):
1904         (Stream.close_connection):
1905         (Stream.send_ping):
1906         (Stream._send_pong):
1907         (Stream._drain_received_data):
1908         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Added.
1909         (is_control_opcode):
1910         (ExtensionParameter):
1911         (ExtensionParameter.__init__):
1912         (ExtensionParameter.name):
1913         (ExtensionParameter.add_parameter):
1914         (ExtensionParameter.get_parameters):
1915         (ExtensionParameter.get_parameter_names):
1916         (ExtensionParameter.has_parameter):
1917         (ExtensionParameter.get_parameter_value):
1918         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Added.
1919         (DispatchException):
1920         (DispatchException.__init__):
1921         (_default_passive_closing_handshake_handler):
1922         (_normalize_path):
1923         (_create_path_to_resource_converter):
1924         (_create_path_to_resource_converter.converter):
1925         (_enumerate_handler_file_paths):
1926         (_HandlerSuite):
1927         (_HandlerSuite.__init__):
1928         (_source_handler_file):
1929         (_extract_handler):
1930         (Dispatcher):
1931         (Dispatcher.maintains):
1932         (Dispatcher.__init__):
1933         (Dispatcher.add_resource_path_alias):
1934         (Dispatcher.source_warnings):
1935         (Dispatcher.do_extra_handshake):
1936         (Dispatcher.transfer_data):
1937         (Dispatcher.passive_closing_handshake):
1938         (Dispatcher.get_handler_suite):
1939         (Dispatcher._source_handler_files_in_dir):
1940         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Added.
1941         (ExtensionProcessorInterface):
1942         (ExtensionProcessorInterface.get_extension_response):
1943         (ExtensionProcessorInterface.setup_stream_options):
1944         (DeflateStreamExtensionProcessor):
1945         (DeflateStreamExtensionProcessor.__init__):
1946         (DeflateStreamExtensionProcessor.get_extension_response):
1947         (DeflateStreamExtensionProcessor.setup_stream_options):
1948         (DeflateFrameExtensionProcessor):
1949         (DeflateFrameExtensionProcessor.__init__):
1950         (DeflateFrameExtensionProcessor.get_extension_response):
1951         (DeflateFrameExtensionProcessor.setup_stream_options):
1952         (DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter):
1953         (DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.__init__):
1954         (DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.filter):
1955         (DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter):
1956         (DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.__init__):
1957         (DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.filter):
1958         (DeflateFrameExtensionProcessor.set_response_window_bits):
1959         (DeflateFrameExtensionProcessor.set_response_no_context_takeover):
1960         (DeflateFrameExtensionProcessor.enable_outgoing_compression):
1961         (DeflateFrameExtensionProcessor.disable_outgoing_compression):
1962         (DeflateFrameExtensionProcessor._outgoing_filter):
1963         (DeflateFrameExtensionProcessor._incoming_filter):
1964         (get_extension_processor):
1965         (get_extension_processor.is):
1966         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Added.
1967         (try):
1968         (do_handshake):
1969         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Added.
1970         (AbortedByUserException):
1971         (HandshakeException):
1972         (HandshakeException.__init__):
1973         (VersionException):
1974         (VersionException.__init__):
1975         (get_default_port):
1976         (validate_subprotocol):
1977         (parse_host_header):
1978         (format_header):
1979         (build_location):
1980         (get_mandatory_header):
1981         (validate_mandatory_header):
1982         (check_request_line):
1983         (check_header_lines):
1984         (parse_token_list):
1985         (_parse_extension_param):
1986         (_parse_extension):
1987         (parse_extensions):
1988         (format_extensions):
1989         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/draft75.py: Added.
1990         (Handshaker):
1991         (Handshaker.performs):
1992         (Handshaker.__init__):
1993         (Handshaker.do_handshake):
1994         (Handshaker._set_resource):
1995         (Handshaker._set_origin):
1996         (Handshaker._set_location):
1997         (Handshaker._set_subprotocol):
1998         (Handshaker._set_protocol_version):
1999         (Handshaker._sendall):
2000         (Handshaker._send_handshake):
2001         (Handshaker._check_header_lines):
2002         (Handshaker._check_first_lines):
2003         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Added.
2004         (compute_accept):
2005         (Handshaker):
2006         (Handshaker.__init__):
2007         (Handshaker._validate_connection_header):
2008         (Handshaker.do_handshake):
2009         (Handshaker._get_origin):
2010         (Handshaker._check_version):
2011         (Handshaker._set_protocol):
2012         (Handshaker._parse_extensions):
2013         (Handshaker._validate_key):
2014         (Handshaker._get_key):
2015         (Handshaker._send_handshake):
2016         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Added.
2017         (Handshaker):
2018         (Handshaker.__init__):
2019         (Handshaker.do_handshake):
2020         (Handshaker._set_resource):
2021         (Handshaker._set_subprotocol):
2022         (Handshaker._set_location):
2023         (Handshaker._set_origin):
2024         (Handshaker._set_protocol_version):
2025         (Handshaker._set_challenge_response):
2026         (Handshaker._get_key_value):
2027         (Handshaker._get_challenge):
2028         (Handshaker._send_handshake):
2029         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Added.
2030         (ApacheLogHandler):
2031         (ApacheLogHandler.__init__):
2032         (ApacheLogHandler.emit):
2033         (_configure_logging):
2034         (_parse_option):
2035         (_create_dispatcher):
2036         (headerparserhandler):
2037         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Added.
2038         (_is_char):
2039         (_is_ctl):
2040         (ParsingState):
2041         (ParsingState.__init__):
2042         (peek):
2043         (consume):
2044         (consume_string):
2045         (consume_lws):
2046         (consume_lwses):
2047         (consume_token):
2048         (consume_token_or_quoted_string):
2049         (quote_if_necessary):
2050         (parse_uri):
2051         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Added.
2052         (MemorizingFile):
2053         (MemorizingFile.__init__):
2054         (MemorizingFile.__getattribute__):
2055         (MemorizingFile.readline):
2056         (MemorizingFile.get_memorized_lines):
2057         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Added.
2058         (close_connection):
2059         (send_message):
2060         (receive_message):
2061         (send_ping):
2062         (MessageReceiver):
2063         (MessageReceiver.receives):
2064         (MessageReceiver.provides):
2065         (MessageReceiver.should):
2066         (MessageReceiver.__init__):
2067         (MessageReceiver.run):
2068         (MessageReceiver.receive):
2069         (MessageReceiver.receive_nowait):
2070         (MessageReceiver.stop):
2071         (MessageSender):
2072         (MessageSender.sends):
2073         (MessageSender.provides):
2074         (MessageSender.should):
2075         (MessageSender.__init__):
2076         (MessageSender.run):
2077         (MessageSender.send):
2078         (MessageSender.send_nowait):
2079         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Added.
2080         (_StandaloneConnection):
2081         (_StandaloneConnection.__init__):
2082         (_StandaloneConnection.get_local_addr):
2083         (_StandaloneConnection.get_remote_addr):
2084         (_StandaloneConnection.write):
2085         (_StandaloneConnection.read):
2086         (_StandaloneConnection.get_memorized_lines):
2087         (_StandaloneRequest):
2088         (_StandaloneRequest.__init__):
2089         (_StandaloneRequest.get_uri):
2090         (_StandaloneRequest.get_method):
2091         (_StandaloneRequest.is_https):
2092         (_StandaloneRequest._drain_received_data):
2093         (_StandaloneSSLConnection):
2094         (_StandaloneSSLConnection.for):
2095         (_StandaloneSSLConnection.__init__):
2096         (_StandaloneSSLConnection.__getattribute__):
2097         (_StandaloneSSLConnection.__setattr__):
2098         (_StandaloneSSLConnection.makefile):
2099         (WebSocketServer):
2100         (WebSocketServer.__init__):
2101         (WebSocketServer._create_sockets):
2102         (WebSocketServer.server_bind):
2103         (WebSocketServer.server_activate):
2104         (WebSocketServer.server_close):
2105         (WebSocketServer.fileno):
2106         (WebSocketServer.handle_error):
2107         (WebSocketServer.get_request):
2108         (WebSocketServer.serve_forever):
2109         (WebSocketServer.shutdown):
2110         (WebSocketRequestHandler):
2111         (WebSocketRequestHandler.setup):
2112         (WebSocketRequestHandler.setup.SocketServer):
2113         (WebSocketRequestHandler.__init__):
2114         (WebSocketRequestHandler.parse_request):
2115         (WebSocketRequestHandler.log_request):
2116         (WebSocketRequestHandler.log_error):
2117         (WebSocketRequestHandler.is_cgi):
2118         (_configure_logging):
2119         (_alias_handlers):
2120         (_build_option_parser):
2121         (ThreadMonitor):
2122         (ThreadMonitor.__init__):
2123         (ThreadMonitor.run):
2124         (_parse_args_and_config):
2125         (_main):
2126         (_main.if):
2127         (_main.if.__check_script):
2128         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Copied from Tools/Scripts/webkitpy/thirdparty/__init___unittest.py.
2129         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Added.
2130         (get_stack_trace):
2131         (prepend_message_to_exception):
2132         (__translate_interp):
2133         (get_script_interp):
2134         (wrap_popen3_for_win):
2135         (wrap_popen3_for_win.__wrap_popen3):
2136         (hexify):
2137         (get_class_logger):
2138         (NoopMasker):
2139         (NoopMasker.__init__):
2140         (NoopMasker.mask):
2141         (RepeatedXorMasker):
2142         (RepeatedXorMasker.__init__):
2143         (RepeatedXorMasker.mask):
2144         (DeflateRequest):
2145         (DeflateRequest.for):
2146         (DeflateRequest.__init__):
2147         (DeflateRequest.__getattribute__):
2148         (DeflateRequest.__setattr__):
2149         (_Deflater):
2150         (_Deflater.__init__):
2151         (_Deflater.compress_and_flush):
2152         (_Inflater):
2153         (_Inflater.__init__):
2154         (_Inflater.decompress):
2155         (_Inflater.append):
2156         (_Inflater.reset):
2157         (_RFC1979Deflater):
2158         (_RFC1979Deflater.that):
2159         (_RFC1979Deflater.__init__):
2160         (_RFC1979Deflater.filter):
2161         (_RFC1979Inflater):
2162         (_RFC1979Inflater.for):
2163         (_RFC1979Inflater.__init__):
2164         (_RFC1979Inflater.filter):
2165         (DeflateSocket):
2166         (DeflateSocket.for):
2167         (DeflateSocket.__init__):
2168         (DeflateSocket.recv):
2169         (DeflateSocket.sendall):
2170         (DeflateSocket.send):
2171         (DeflateConnection):
2172         (DeflateConnection.for):
2173         (DeflateConnection.__init__):
2174         (DeflateConnection.get_remote_addr):
2175         (DeflateConnection.put_bytes):
2176         (DeflateConnection.read):
2177         (DeflateConnection.write):
2178         (_is_ewouldblock_errno):
2179         (drain_received_data):
2180
2181 2012-05-10  Raphael Kubo da Costa  <rakuco@webkit.org>
2182
2183         [EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
2184         https://bugs.webkit.org/show_bug.cgi?id=86117
2185
2186         Reviewed by Adam Barth.
2187
2188         Simplify the code used to wrap driver calls with jhbuild: we can
2189         just define the 'wrapper' option instead of having to create a
2190         Driver class just for that.
2191
2192         * Scripts/webkitpy/layout_tests/port/efl.py:
2193         (EflPort.__init__):
2194         (EflPort._port_flag_for_scripts):
2195
2196 2012-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2197
2198         Unreviewed, rolling out r116633.
2199         http://trac.webkit.org/changeset/116633
2200         https://bugs.webkit.org/show_bug.cgi?id=86093
2201
2202         Breaks EFL tests (Requested by kov on #webkit).
2203
2204         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2205         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2206         * DumpRenderTree/efl/EventSender.cpp:
2207         (keyDownCallback):
2208         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2209         (LayoutTestController::setTabKeyCyclesThroughElements):
2210
2211 2012-05-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2212
2213         [EFL] Memory leaks found in EFL DRT
2214         https://bugs.webkit.org/show_bug.cgi?id=85889
2215
2216         Reviewed by Gustavo Noronha Silva.
2217
2218         Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
2219         created with JSStringCreateWithUTF8CString.
2220
2221         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2222         (DumpRenderTreeChrome::onWindowObjectCleared):
2223         * DumpRenderTree/efl/EventSender.cpp:
2224         (modifiersFromJSValue):
2225
2226 2012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
2227
2228         [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
2229         https://bugs.webkit.org/show_bug.cgi?id=82864
2230
2231         Reviewed by Gustavo Noronha Silva.
2232
2233         Add missing implementation for setTabKeyCyclesThroughElements to EFL's LayoutTestController
2234         in order to unskip fast/events/keypress-insert-tab.html
2235
2236         * DumpRenderTree/efl/EventSender.cpp:
2237         (keyDownCallback):
2238         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2239         (LayoutTestController::setTabKeyCyclesThroughElements):
2240
2241 2012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
2242
2243         [EFL][DRT] EventSender - set delayed event information if it was not set before
2244         https://bugs.webkit.org/show_bug.cgi?id=85972
2245
2246         Reviewed by Gustavo Noronha Silva.
2247
2248         Reset delayed event information if it is missing.
2249
2250         * DumpRenderTree/efl/EventSender.cpp:
2251         (feedOrQueueMouseEvent):
2252
2253 2012-05-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2254
2255         WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
2256         https://bugs.webkit.org/show_bug.cgi?id=85806
2257
2258         The m_pendingAPIRequestURL member is used (presumably) to mask over the async
2259         nature of WebKit2, so that starting a load of a URL will reflect that URL
2260         immedeatly from activeURL, even if the request has not been passed over to
2261         the web process yet and reflected there.
2262
2263         This works well, except in the case of the initial request, where the main
2264         frame creation happens on the web process side and is notified back to the
2265         UI process. Until we've recived the notification we don't know about the main
2266         frame, and this race condition will potentially give us an empty url instead
2267         of the pending request.
2268
2269         To solve this we always return the pending API request if it's set, even
2270         when there's no mainframe yet (that we known about).
2271
2272         Reviewed by Simon Hausmann.
2273
2274         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2275
2276 2012-05-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2277
2278         [EFL][DRT] Clear added user style sheets before a new testcase execution.
2279         https://bugs.webkit.org/show_bug.cgi?id=84792
2280
2281         Reviewed Gustavo Noronha Silva.
2282
2283         The added user style sheets from the previous testcases are cleared in order to avoid 
2284         flaky results.
2285
2286         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2287         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2288
2289 2012-05-09  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2290
2291         Move suspendAnimations to use Internals interface.
2292         https://bugs.webkit.org/show_bug.cgi?id=85986
2293
2294         Reviewed by Ryosuke Niwa.
2295
2296         Remove suspendAnimations functions, because it is able to work in the 
2297         cross-port way through the Internals interface
2298
2299         * DumpRenderTree/LayoutTestController.cpp:
2300         (LayoutTestController::staticFunctions):
2301         * DumpRenderTree/LayoutTestController.h:
2302         (LayoutTestController):
2303         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2304         * DumpRenderTree/chromium/LayoutTestController.cpp:
2305         (LayoutTestController::LayoutTestController):
2306         * DumpRenderTree/chromium/LayoutTestController.h:
2307         (LayoutTestController):
2308         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2309         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2310         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2311         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2312         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2313         (LayoutTestController):
2314         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2315         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2316
2317 2012-05-09  Kent Tamura  <tkent@chromium.org>
2318
2319         [Chromium] Attempt to fix an Android build error.
2320         https://bugs.webkit.org/show_bug.cgi?id=86045
2321
2322         * DumpRenderTree/DumpRenderTree.gypi:
2323
2324 2012-05-09  Ojan Vafai  <ojan@chromium.org>
2325
2326         Don't show partytime if there are non-layout test failures.
2327         https://bugs.webkit.org/show_bug.cgi?id=86056
2328
2329         Reviewed by Dimitri Glazkov.
2330
2331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
2333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2334
2335 2012-05-09  Hayato Ito  <hayato@chromium.org>
2336
2337         Improve a warning message for a reftest having an unused expectation file.
2338         https://bugs.webkit.org/show_bug.cgi?id=85975
2339
2340         Reviewed by Adam Barth.
2341
2342         The current warning message is not intuitive. It might be better to update the message
2343         so that it encourage users to remove unused expectation files.
2344
2345         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2346         (SingleTestRunner.__init__):
2347
2348 2012-05-09  Ojan Vafai  <ojan@chromium.org>
2349
2350         Change "losing test coverage" to cover all non-layout test problems in garden-o-matic
2351         https://bugs.webkit.org/show_bug.cgi?id=86043
2352
2353         Reviewed by Adam Barth.
2354
2355         -Get rid of the gtest iframe.
2356         -Cover all non-layout test problems. Before we wouldn't catch compile failures
2357         or gtest failures since they were not on the webkit testing bots.
2358         -Include the list of failing steps next to the builder name. This is a lot less
2359         cluttered than you'd expect and already helped me find a compile failure early.
2360
2361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2362         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2364         Delete unused map.
2365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2366         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2367         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2373
2374 2012-05-09  Jessie Berlin  <jberlin@apple.com>
2375
2376         Crash using the new WKBundleDOMWindowExtensions APIs.
2377         https://bugs.webkit.org/show_bug.cgi?id=85888
2378
2379         Reviewed by Brady Eidson.
2380
2381         Cached frames can live slightly longer than the page, but most clients unregister themselves
2382         and do other cleanup in the willDestroyPage callback, making them miss the
2383         willDestroyGlobalObjectForDOMWindowExtension callbacks.
2384
2385         The calls to willDestroyGlobalObjectForDOMWindowExtension in the DOMWindowExtensionBasic
2386         test were all being invoked underneath WebPage::close. This is unrealistic. Update that test
2387         to destroy the BundleDOMWindowExtensions in response to the willDestroyPage callback.
2388
2389         Add a test to verify that willDestroyGlobalObjectForDOMWindowExtension is being called for
2390         pages that don't go into the page cache.
2391
2392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2393         Add DOMWindowExtensionNoCache.cpp, DOMWindowExtensionNoCache_Bundle.cpp, simple-unload.html
2394         and simple-iframe-unload.html
2395
2396         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2397         (TestWebKitAPI):
2398         Remove the expected messages for willDestroyGlobalObjectForDOMWindowExtension.
2399         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2400         Do not bother to keep track of the live extension count - all of them are expected to be
2401         live until the test completes.
2402         (TestWebKitAPI::TEST):
2403         Fix the calls to EXPECT to pass the expected value first, and use EXPECT_WK_STREQ so that
2404         message failures will be clearer.
2405         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2406         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
2407         Clean up the BundleDOMWindowExtensions.
2408         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
2409         Add an ASSERT_NOT_REACHED.
2410
2411         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Added.
2412         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2413         Keep track of the messages received so they can be checked at the end of the test.
2414         (TestWebKitAPI::TEST):
2415         Navigate to uncacheable pages and back.
2416         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp.
2417         (DOMWindowExtensionNoCache):
2418         (TestWebKitAPI::DOMWindowExtensionNoCache::DOMWindowExtensionNoCache):
2419         Set up all the states for each BundleDOMWindowExtension.
2420         (TestWebKitAPI::DOMWindowExtensionNoCache::frameLoadFinished):
2421         Tell the UI Process about the states of the BundleDOMWindowExtensions.
2422         (TestWebKitAPI::DOMWindowExtensionNoCache::sendExtensionStateMessage):
2423         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2424         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
2425         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
2426         Remvoe the remaining BundleDOMWindowExtensions, send the updated state, and finish the test.
2427         (TestWebKitAPI::DOMWindowExtensionNoCache::updateExtensionStateRecord):
2428         (TestWebKitAPI::DOMWindowExtensionNoCache::sendBundleMessage):
2429         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
2430         (TestWebKitAPI::DOMWindowExtensionNoCache::willDisconnectDOMWindowExtensionFromGlobalObject):
2431         ASSERT that these pages not going into the page cache are not getting disconnected to go into
2432         the page cache.
2433         (TestWebKitAPI::DOMWindowExtensionNoCache::didReconnectDOMWindowExtensionToGlobalObject):
2434         Ditto about getting reconnected when coming out of the page cache.
2435         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyGlobalObjectForDOMWindowExtension):
2436         Tell the UI Process, update the state, and get rid of the BundleDOMWindowExtension.
2437         (TestWebKitAPI::didFinishLoadForFrameCallback):
2438         (TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
2439         (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
2440         (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
2441         (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
2442
2443         * TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Added.
2444         * TestWebKitAPI/Tests/WebKit2/simple-unload.html: Added.
2445
2446 2012-05-09  Adam Barth  <abarth@webkit.org>
2447
2448         [Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
2449         https://bugs.webkit.org/show_bug.cgi?id=86045
2450
2451         Reviewed by Eric Seidel.
2452
2453         * DumpRenderTree/DumpRenderTree.gypi:
2454
2455 2012-05-09  Adam Barth  <abarth@webkit.org>
2456
2457         [Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
2458         https://bugs.webkit.org/show_bug.cgi?id=86041
2459
2460         Reviewed by Eric Seidel.
2461
2462         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2463
2464 2012-05-09  Adam Barth  <abarth@webkit.org>
2465
2466         [Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
2467         https://bugs.webkit.org/show_bug.cgi?id=86040
2468
2469         Reviewed by Kent Tamura.
2470
2471         * DumpRenderTree/chromium/TestShell.cpp:
2472         (TestShell::dumpImage):
2473
2474 2012-05-09  Raphael Kubo da Costa  <rakuco@webkit.org>
2475
2476         [EFL] Build fix after r116464.
2477
2478         `ulong' is a type defined by glibc, so it is not very
2479         portable. Use `unsigned long' instead.
2480
2481         * DumpRenderTree/efl/EventSender.cpp:
2482         (DelayedEvent::DelayedEvent):
2483         (DelayedEvent):
2484         (leapForwardCallback):
2485
2486 2012-05-09  Adam Barth  <abarth@webkit.org>
2487
2488         [Chromium] LayoutTestController should use ENABLE guards for some features
2489         https://bugs.webkit.org/show_bug.cgi?id=86030
2490
2491         Reviewed by Eric Seidel.
2492
2493         These features are disabled on OS(ANDROID) and so shouldn't be compiled
2494         when the feature is off.
2495
2496         * DumpRenderTree/chromium/LayoutTestController.cpp:
2497         (LayoutTestController::LayoutTestController):
2498         * DumpRenderTree/chromium/LayoutTestController.h:
2499         (LayoutTestController):
2500         * DumpRenderTree/chromium/TestShell.h:
2501         (TestShell):
2502
2503 2012-05-09  Tom Zakrajsek  <tomz@codeaurora.org>
2504
2505         Fix overzealous re-opened since blocked by... message
2506         https://bugs.webkit.org/show_bug.cgi?id=86020
2507
2508         Reviewed by Adam Barth.
2509
2510         Changed CreateBug behavior to only re-open a blocked bug if it
2511         was RESOLVED.  Also had to update the test infrastructure slightly
2512         to allow for distinct mock commit revisions, so one could point
2513         to a RESOLVED bug for testing while another pointed to an OPEN bug.
2514
2515         Also moved default created mock bug to be 60001 instead of 50004
2516         which already exists as a reference mock bug.
2517
2518         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2519         (MockCheckout.__init__):
2520         (MockCheckout.commit_info_for_revision):
2521         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2522         (MockBugzilla.create_bug):
2523         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2524         * Scripts/webkitpy/tool/commands/download_unittest.py:
2525         (test_create_rollout_resolved):
2526         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2527         (FailureReasonTest.test_blame_line_for_revision):
2528         * Scripts/webkitpy/tool/steps/createbug.py:
2529         (CreateBug.run):
2530
2531 2012-05-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
2532
2533         Use suitable viewport values on XHTML-MP pages.
2534         https://bugs.webkit.org/show_bug.cgi?id=85425
2535
2536         Reviewed by Kenneth Rohde Christiansen.
2537
2538         Enable LEGACY_VIEWPORT_ADAPTION on Qt port.
2539
2540         * qmake/mkspecs/features/features.prf:
2541
2542 2012-05-09  Jochen Eisinger  <jochen@chromium.org>
2543
2544         When creating a new page during a navigation, prime the initial document with the correct referrer policy
2545         https://bugs.webkit.org/show_bug.cgi?id=86001
2546
2547         Reviewed by Adam Barth.
2548
2549         Store the referrer policy in the request, so the network stack can comply with it.
2550
2551         * DumpRenderTree/chromium/WebViewHost.cpp:
2552         (WebViewHost::willSendRequest):
2553
2554 2012-05-09  Vivek Galatage  <vivekgalatage@gmail.com>
2555
2556         Remove CYGWIN=tty from environment variable as its no longer supported
2557         https://bugs.webkit.org/show_bug.cgi?id=85791
2558
2559         The CYGWIN=tty environment variable is no longer supported from Cygwin
2560         version 1.7.10. This fix avoids addition of this environment variable
2561         for Cygwin versions greater than 1.7.9. For supporting older versions
2562         i.e. 1.7.9 or older, the script takes care of retaining the environment
2563         variable.
2564
2565         Reviewed by Adam Roben.
2566
2567         * Scripts/webkitdirs.pm:
2568         (setupAppleWinEnv):
2569
2570 2012-05-09  Dirk Pranke  <dpranke@chromium.org>
2571
2572         nrwt: --skip-failing-tests should also skip flaky tests
2573         https://bugs.webkit.org/show_bug.cgi?id=85941
2574
2575         Reviewed by Ojan Vafai.
2576
2577         This changes --skip-failing-tests so that we skip tests that
2578         are believed to pass sometimes as well as tests that are
2579         believed to always fail.
2580
2581         In addition, in testing this I discovered that we had lousy
2582         test coverage of the details of retrying test failures and
2583         --clobber-old-results, so I wrote some more tests.
2584
2585         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2586         (Manager.prepare_lists_and_print_output):
2587         * Scripts/webkitpy/layout_tests/port/test.py:
2588         (unit_test_list):
2589         (TestPort.__init__):
2590         (TestDriver.run_test):
2591         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2592         (MainTest.test_skip_failing_tests):
2593         (MainTest.test_retrying_and_flaky_tests):
2594
2595 2012-05-09  Christophe Dumez  <christophe.dumez@intel.com>
2596
2597         [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()
2598         https://bugs.webkit.org/show_bug.cgi?id=84435
2599
2600         Reviewed by Antonio Gomes.
2601
2602         Catch the "icon,changed" signal on the frames in EFL's DumpRenderTree
2603         to support LayoutTestController's dumpIconChanges().
2604
2605         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2606         (DumpRenderTreeChrome::createView):
2607         (DumpRenderTreeChrome::onFrameIconChanged):
2608         (DumpRenderTreeChrome::onFrameCreated):
2609         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2610         (DumpRenderTreeChrome):
2611
2612 2012-05-09  Dominik Röttsches  <dominik.rottsches@intel.com>
2613
2614         webkit-patch upload Fails Behind Load-balancing Proxies
2615         https://bugs.webkit.org/show_bug.cgi?id=85980
2616
2617         Reviewed by Adam Barth.
2618
2619         Unchecking the login restriction to IP to allow the tool
2620         to function behind load-balancing proxies that use multiple
2621         outgoing IPs.
2622
2623         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2624         (Bugzilla.authenticate):
2625
2626 2012-05-09  Hao Zheng  <zhenghao@chromium.org>
2627
2628         [Chromium-android] Add unit test for Android layout test script (chromium_android.py)
2629         https://bugs.webkit.org/show_bug.cgi?id=80852
2630
2631         Reviewed by Adam Barth.
2632
2633         Add some tests to ensure that chromium android port works to some
2634         extent. Some methods is hard to test, as they rely on the actual
2635         behavior on device, e.g. pushing files to device.
2636
2637         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2638         (ChromiumAndroidPort.get_last_stacktrace): Check if dir exists.
2639         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2640         (ChromiumAndroidPortTest):
2641         (ChromiumAndroidPortTest.test_attributes):
2642         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2643         (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_dir):
2644         (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_file):
2645         (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_non_empty):
2646         (ChromiumAndroidDriverTest):
2647         (ChromiumAndroidDriverTest.setUp):
2648         (ChromiumAndroidDriverTest.test_get_drt_return_value):
2649         (ChromiumAndroidDriverTest.test_has_crash_hint):
2650         (ChromiumAndroidDriverTest.test_read_prompt):
2651         (ChromiumAndroidDriverTest.test_test_shell_command):
2652         (ChromiumAndroidDriverTest.test_write_command_and_read_line):
2653
2654 2012-05-09  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2655
2656         [Qt] ORWT fails with Qt 5 and WK2.
2657         https://bugs.webkit.org/show_bug.cgi?id=85968
2658
2659         Reviewed by Csaba Osztrogonác.
2660
2661         The Qt5 binary does not have a -style argument, so avoid using it.
2662
2663         * Scripts/old-run-webkit-tests:
2664
2665 2012-05-09  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2666
2667         [EFL][DRT] LayoutTestController addUserScript implementation
2668         https://bugs.webkit.org/show_bug.cgi?id=84718
2669
2670         Reviewed by Antonio Gomes.
2671
2672         Added implementation of addUserScript() to LayoutTestController.
2673
2674         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2675         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): clear added user scripts
2676         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2677         (LayoutTestController::addUserScript): added implementation
2678
2679 2012-05-09  Dan Bernstein  <mitz@apple.com>
2680
2681         Made build-webkit copy WebKitLibraries to the right location again after r116257
2682
2683         Reviewed by Mark Rowe.
2684
2685         * Scripts/build-webkit: Pass the built product directory to copy-webkitlibraries-to-product-directory.
2686         * Scripts/copy-webkitlibraries-to-product-directory: Use the first argument, if present, as the
2687         product directory.
2688
2689 2012-05-08  Ojan Vafai  <ojan@chromium.org>
2690
2691         Show the chromium non-layout test bots in garden-o-matic
2692         https://bugs.webkit.org/show_bug.cgi?id=85903
2693
2694         Reviewed by Eric Seidel.
2695
2696         This is just a single-line high-level overview of the chromium non-layout test bots.
2697         This means that Chromium WebKit gardeners only need to keep garden-o-matic open in
2698         order to do their job.
2699
2700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2704         (#chromium-gtests iframe):
2705         (#chromium-gtests):
2706         (#gtest-label):
2707
2708 2012-05-08  Kangil Han  <kangil.han@samsung.com>
2709
2710         [EFL][DRT] Implement TextInputController.
2711         https://bugs.webkit.org/show_bug.cgi?id=78559
2712
2713         Reviewed by Martin Robinson.
2714
2715         TextInputController has been created for an input emulation purpose in DRT.
2716         However, not like other ports, EFL doesn't have it.
2717         Therefore, this patch will enable EFL port to have an input emulation in DRT.
2718
2719         * DumpRenderTree/efl/CMakeLists.txt:
2720         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2721         (DumpRenderTreeChrome::onWindowObjectCleared):
2722         * DumpRenderTree/efl/TextInputController.cpp: Added.
2723         (setMarkedTextCallback):
2724         (hasMarkedTextCallback):
2725         (markedRangeCallback):
2726         (insertTextCallback):
2727         (unmarkTextCallback):
2728         (firstRectForCharacterRangeCallback):
2729         (selectedRangeCallback):
2730         (makeTextInputController):
2731         * DumpRenderTree/efl/TextInputController.h: Added.
2732
2733 2012-04-23  Raphael Kubo da Costa  <rakuco@webkit.org>
2734
2735         [EFL] Pass a WTF::String directly from DRT to ewebkit when possible
2736         https://bugs.webkit.org/show_bug.cgi?id=84634
2737
2738         Reviewed by Gustavo Noronha Silva.
2739
2740         Drop unnecessary const char* -> WTF::String conversions by
2741         creating String objects directly in LayoutTestController out of
2742         JSStringRef's and passing them to DumpRenderTreeSupportEfl.
2743
2744         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2745         (LayoutTestController::queueLoad):
2746         (LayoutTestController::setValueForUser):
2747         (LayoutTestController::findString):
2748         (LayoutTestController::addUserStyleSheet):
2749
2750 2012-05-08  Alexander Shalamov  <alexander.shalamov@intel.com>
2751
2752         [EFL][DRT] EventSender needs implementation of leapForward function
2753         https://bugs.webkit.org/show_bug.cgi?id=83486
2754
2755         Reviewed by Eric Seidel.
2756
2757         Implemented leapForward function in Efl's DRT. This function is required
2758         to delay and queue event execution and simulate real user behavior.
2759
2760         * DumpRenderTree/efl/EventSender.cpp:
2761         (DelayedEvent):
2762         (MouseEventInfo::MouseEventInfo):
2763         (MouseEventInfo):
2764         (sendClick):
2765         (mouseDownCallback):
2766         (mouseUpCallback):
2767         (mouseMoveToCallback):
2768         (leapForwardCallback):
2769         (mouseScrollByCallback):
2770         (feedOrQueueMouseEvent):
2771         (feedMouseEvent):
2772         (feedQueuedMouseEvents):
2773
2774 2012-05-08  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2775
2776         [GTK] Memory leak in DRT EventSender.cpp
2777         https://bugs.webkit.org/show_bug.cgi?id=85886
2778
2779         Reviewed by Martin Robinson.
2780
2781         Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
2782         JSString created with JSStringCreateWithUTF8CString.
2783
2784         * DumpRenderTree/gtk/EventSender.cpp:
2785         (gdkModifersFromJSValue):
2786
2787 2012-05-08  Christophe Dumez  <christophe.dumez@intel.com>
2788
2789         [EFL] glib dependency needs to be updated in jhbuild
2790         https://bugs.webkit.org/show_bug.cgi?id=85878
2791
2792         Reviewed by Martin Robinson.
2793
2794         Bump glib version from 2.31.8 to 2.32.2 in jhbuild.modules. This
2795         addresses flakiness in media tests due to possible deadlock with the
2796         following output on stderr:
2797         GStreamer-WARNING **: wrong STREAM_LOCK count 0
2798
2799         The bug was fixed upstream by:
2800         http://git.gnome.org/browse/glib/commit/?id=265f265c677bc5399dbb1cfa449cb4b915a6459f
2801
2802         * efl/jhbuild.modules:
2803
2804 2012-05-07  Alexis Menard  <alexis.menard@openbossa.org>
2805
2806         [Qt] Unbreak debugging of WebKit2.
2807         https://bugs.webkit.org/show_bug.cgi?id=85839
2808
2809         Reviewed by Simon Hausmann.
2810
2811         When you attach GDB to a running process, it stops it.
2812         http://trac.webkit.org/changeset/115958 introduced a pause() 
2813         call to wait the debugger to be attached to then continue 
2814         the execution of the WebProcess. Unfortunately the pause()
2815         function does not return unless a signal handler is called.
2816         This patch introduce an event handler to exit from the paused
2817         state when the debugger send the signal SIGCONT. The old code
2818         works with older version of GDB (<7.0) but not with newer
2819         versions where the behavior of pause() is correct.
2820
2821         * WebKitTestRunner/qt/main.cpp:
2822         (sigcontHandler):
2823         (main):
2824
2825 2012-05-08  Christophe Dumez  <christophe.dumez@intel.com>
2826
2827         [EFL][DRT] EFL's DRT does not fully support page visibility
2828         https://bugs.webkit.org/show_bug.cgi?id=85032
2829
2830         Reviewed by Antonio Gomes.
2831
2832         * DumpRenderTree/LayoutTestController.cpp:
2833         (resetPageVisibilityCallback): Fix incorrect argumentCount check.
2834         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2835         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Properly
2836         reset page visibility setting between tests.
2837         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2838         (LayoutTestController::setPageVisibility): Add support for "preview"
2839         visibility state.
2840
2841 2012-05-08  Gavin Peters  <gavinp@chromium.org>
2842
2843         [webkit-patch] Return meaningful results from single-result queries.
2844         https://bugs.webkit.org/show_bug.cgi?id=85367
2845
2846         Reviewed by Dirk Pranke.
2847
2848         Sometimes a quicksearch returns a single result by just redirecting to the page for that single
2849         bug. This patch hacks around that by noticing the redirect target is a single page, and constructing
2850         a result list consisting of that one bug.
2851
2852         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2853         (BugzillaQueries._fetch_bugs_from_advanced_query):
2854
2855 2012-05-08  Gavin Peters  <gavinp@chromium.org>
2856
2857         [webkit-patch] Add new chrome-channels command to track down current chrome release channels for a committed bug.
2858         https://bugs.webkit.org/show_bug.cgi?id=85368
2859
2860         Reviewed by Eric Seidel.
2861
2862         * Scripts/webkitpy/common/config/urls.py:
2863         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2864         (MockBugzillaQueries.fetch_bugs_matching_quicksearch):
2865         * Scripts/webkitpy/common/net/omahaproxy.py: Added.
2866         (OmahaProxy):
2867         (OmahaProxy.__init__):
2868         (OmahaProxy.set_url):
2869         (OmahaProxy._json_url):
2870         (OmahaProxy._get_json):
2871         (OmahaProxy.get_revisions):
2872         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Added.
2873         (MockOmahaProxy):
2874         (MockOmahaProxy.__init__):
2875         (OmahaProxyTest):
2876         (OmahaProxyTest.test_get_revisions):
2877         * Scripts/webkitpy/tool/commands/__init__.py:
2878         * Scripts/webkitpy/tool/commands/bugsearch.py:
2879         (BugSearch):
2880         * Scripts/webkitpy/tool/commands/chromechannels.py: Added.
2881         (ChromeChannels):
2882         (__init__):
2883         (execute):
2884         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Added.
2885         (MockOmahaProxy):
2886         (MockOmahaProxy.get_revisions):
2887         (TestableChromeChannels):
2888         (TestableChromeChannels.__init__):
2889         (ChromeChannelsTest):
2890         (ChromeChannelsTest.test_single_bug):
2891         (ChromeChannelsTest.test_with_query):
2892
2893 2012-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2894
2895         Unreviewed. Fix GTK+ unit tests.
2896
2897         * gtk/common.py:
2898         (pkg_config_file_variable):
2899
2900 2012-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2901
2902         [GTK] Google tests that time out are leaked
2903         https://bugs.webkit.org/show_bug.cgi?id=84973
2904
2905         Reviewed by Philippe Normand.
2906
2907         Move Tools/Scripts/run-gtk-tests to Tools/gtk/run-api-tests
2908         leaving run-gtk-tests as simple wrapper that runs run-api-tests in
2909         a jhbuild environment when jhbuild is available.
2910
2911         * Scripts/run-gtk-tests: Run Tools/gtk/run-api-tests directly or
2912         with jhbuild if present.
2913         * gtk/common.py:
2914         (pkg_config_file_variable): Generic function to get a variable
2915         from a pkg-config file.
2916         (prefix_of_pkg_config_file): Use pkg_config_file_variable with 'prefix'.
2917         * gtk/run-api-tests: Copied from Tools/Scripts/run-gtk-tests.
2918         (TestRunner.__init__): Use common.build_path() to get the programs path.
2919         (TestRunner._lookup_atspi2_binary): Use
2920         common.pkg_config_file_variable() to get the 'exec_prefix'.
2921         (TestRunner._start_accessibility_daemons): Use subprocess.Popen()
2922         directly instead of helper _create_process that has been removed.
2923         (TestRunner._setup_testing_environment): Use subprocess.Popen()
2924         directly instead of helper _create_process that has been
2925         removed. Use common.top_level_path() and common.build_path()
2926         instead of custom methods that have been removed too.
2927         (TestRunner._run_test_command): Use subprocess.Popen() directly
2928         instead of helper _create_process that has been removed.
2929
2930 2012-05-08  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2931
2932         [EFL] [DRT] Clear extra views before setting a blank page
2933         https://bugs.webkit.org/show_bug.cgi?id=85608
2934
2935         Reviewed by Kenneth Rohde Christiansen.
2936
2937         We need to clear the extra views before setting a blank page,
2938         otherwise it will cause more events interactions and sometimes
2939         trigger a unload(). This was causing frame-crash-with-page-cache.html
2940         to leak events to the next test causing any subsequent test to
2941         fail.
2942
2943         * DumpRenderTree/efl/DumpRenderTree.cpp:
2944         (runTest):
2945         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2946         (DumpRenderTreeChrome::clearExtraViews):
2947         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2948         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2949         (DumpRenderTreeChrome):
2950
2951 2012-05-08  Balazs Kelemen  <kbalazs@webkit.org>
2952
2953         [Qt] X11 plugins need to be reworked for Qt5+WK1
2954         https://bugs.webkit.org/show_bug.cgi?id=80691
2955
2956         Reviewed by Simon Hausmann.
2957
2958         Implement basic windowless plugin support with Qt5.
2959
2960         * qmake/mkspecs/features/features.prf:
2961         Enable NPAPI plugins if X11 libraries are available.
2962         * qmake/mkspecs/features/functions.prf:
2963         Added a convenience function to determine availability
2964         of X11 libraries.
2965
2966 2012-05-07  Raphael Kubo da Costa  <rakuco@webkit.org>
2967
2968         [webkitpy] Remove Python 2.5-specific workaround from http_server_base.py.
2969         https://bugs.webkit.org/show_bug.cgi?id=85852
2970
2971         Reviewed by Dirk Pranke.
2972
2973         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2974         (HttpServerBase._is_server_running_on_all_ports): Revert the part
2975         of r89412 which was a workaround for an issue with Python 2.5 on
2976         Mac 10.5.
2977
2978 2012-05-07  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2979
2980         webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
2981         https://bugs.webkit.org/show_bug.cgi?id=81481
2982
2983         Reviewed by Dirk Pranke.
2984
2985         FreeBSD has the same sysctl interface present in Darwin to query
2986         the number of CPUs available, so use that too.
2987
2988         * Scripts/webkitdirs.pm:
2989         (determineNumberOfCPUs): Share the sysctl call with Darwin.
2990         (isFreeBSD): Added.
2991
2992 2012-05-07  Alexis Menard  <alexis.menard@openbossa.org>
2993
2994         Unreviewed Qt build fix in Debug.
2995
2996         We need some system includes here for getpid() to be recognized.
2997
2998         * WebKitTestRunner/qt/main.cpp:
2999
3000 2012-05-07  Ojan Vafai  <ojan@chromium.org>
3001
3002         When embedding the flakiness dashboard, hide popups when the frame is blurred.
3003         https://bugs.webkit.org/show_bug.cgi?id=85684
3004
3005         Reviewed by Dirk Pranke.
3006
3007         If you show a popup, then click elsewhere in garden-o-matic, it will now
3008         properly hide it.
3009
3010         * TestResultServer/static-dashboards/dashboard_base.js:
3011         (showPopup):
3012         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3013         (showPopupForBuild):
3014         (generatePageForIndividualTests.if):
3015         (generatePageForIndividualTests):
3016         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js: Added.
3017         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3018         * TestResultServer/static-dashboards/run-embedded-unittests.html: Added.
3019
3020 2012-05-07  Ian Vollick  <vollick@chromium.org>
3021
3022         [chromium] WebViewHost should setCompositorSurfaceReady
3023         https://bugs.webkit.org/show_bug.cgi?id=85418
3024
3025         Reviewed by James Robinson.
3026
3027         * DumpRenderTree/chromium/WebViewHost.cpp:
3028         (WebViewHost::setWebWidget):
3029
3030 2012-05-07  Jon Lee  <jonlee@apple.com>
3031
3032         WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
3033         https://bugs.webkit.org/show_bug.cgi?id=42331
3034         <rdar://problem/8193641>
3035
3036         Reviewed by Darin Adler.
3037
3038         This patch sets up the framework for supporting dumpFrameLoadCallbacks, as well as
3039         outputting some of the required strings. As tests become unskipped the other callbacks
3040         can be supported.
3041
3042         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Add dumpFrameLoadCallbacks()
3043         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3044         (WTR::InjectedBundle::didReceiveMessage): pass in the dictionary containing keys needed to initialize
3045         dump callbacks for the layoutTestController.
3046         (WTR::InjectedBundle::booleanForKey): Helper function to extract boolean value from key in WKDictionaryRef.
3047         Output some warning if we are trying to extract a value that is not a boolean.
3048         (WTR::InjectedBundle::beginTesting): Update to take in the dictionary passed in by the TestController.
3049         We cannot set the bits on the layoutTestController until it has been created in beginTesting().
3050         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3051         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3052         (WTR::InjectedBundle::didReceiveMessage):
3053         (WTR):
3054         (WTR::InjectedBundle::beginTesting):
3055         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3056         (InjectedBundle):
3057         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3058         (WTR):
3059         (WTR::dumpFrameDescriptionSuitableForTestResult): Static function similar to
3060         -[WebFrame _drt_descriptionSuitableForTestResult] in DumpRenderTree.
3061         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Output string.
3062         (WTR::InjectedBundlePage::didCommitLoadForFrame): Output string.
3063         (WTR::InjectedBundlePage::didFinishLoadForFrame): Output string.
3064         (WTR::InjectedBundlePage::didReceiveTitleForFrame): Output string.
3065         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame): Output string.
3066         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Output string. In WK1 it's
3067         "willPerformClientRedirectToURL" so we will have to use that value here.
3068         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): Output string.
3069         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame): Output string.
3070         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3071         (WTR::LayoutTestController::LayoutTestController): Initialize to not dump frame load callbacks.
3072         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3073         (WTR::LayoutTestController::dumpFrameLoadCallbacks): Change to use setShouldDumpFrameLoadCallbacks.
3074         (WTR::LayoutTestController::setShouldDumpFrameLoadCallbacks): Set bit.
3075         (WTR::LayoutTestController::shouldDumpFrameLoadCallbacks): Return bit.
3076         (LayoutTestController): Added m_dumpFrameLoadCallbacks to track whether to dump the output.
3077         * WebKitTestRunner/TestInvocation.cpp:
3078         (WTR::shouldLogFrameLoadDelegates): Similar to DRT.
3079         (WTR::TestInvocation::invoke): Based on the URL loaded, set the bit in the dictionary that gets passed
3080         to the injected bundle.
3081
3082 2012-05-07  Tommy Widenflycht  <tommyw@google.com>
3083
3084         [chromium] MediaStream API: Enhance WebUserMediaClientMock and add a test for it
3085         https://bugs.webkit.org/show_bug.cgi?id=85618
3086
3087         Reviewed by Adam Barth.
3088
3089         Adding the capability to control which MediaStreamTracks actually get created,
3090         and adding a test that exercises the JS api using that capability.
3091
3092         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
3093         (WebKit::WebUserMediaClientMock::requestUserMedia):
3094         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3095         * DumpRenderTree/chromium/WebViewHost.cpp:
3096         (WebViewHost::testMediaStreamClient):
3097         * DumpRenderTree/chromium/WebViewHost.h:
3098         (WebViewHost):
3099
3100 2012-05-07  Zan Dobersek  <zandobersek@gmail.com>
3101
3102         [Gtk] WebGL feature is not built anymore through build-webkit after r116251
3103         https://bugs.webkit.org/show_bug.cgi?id=85788
3104
3105         Reviewed by Martin Robinson.
3106
3107         Enable WebGL by default for the Gtk port. The feature is already enabled by
3108         default in configure.ac, so there's no reason it shouldn't be enabled when
3109         building through build-webkit.
3110
3111         * Scripts/webkitperl/FeatureList.pm:
3112
3113 2012-05-07  Csaba Osztrogonác  <ossy@webkit.org>
3114
3115         Unittest fix after r116288, because now there are more than 5 hit for the 'Eric' word.
3116         We have only 2 'Gavin', so it is a better choice than 'Eric' for unit testing.
3117
3118         Reviewed by Tor Arne Vestbø.
3119
3120         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3121         (IRCCommandTest.test_whois):
3122
3123 2012-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3124
3125         Unreviewed, rolling out r116299, r116301, and r116303.
3126         http://trac.webkit.org/changeset/116299
3127         http://trac.webkit.org/changeset/116301
3128         http://trac.webkit.org/changeset/116303
3129         https://bugs.webkit.org/show_bug.cgi?id=85795
3130
3131         Build is still broken (Requested by Ossy on #webkit).
3132
3133         * DumpRenderTree/qt/DumpRenderTree.pro:
3134         * DumpRenderTree/qt/main.cpp:
3135         (main):
3136         * QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Removed.
3137         * QtTestPlatformPlugin/TestIntegration.cpp: Removed.
3138         * QtTestPlatformPlugin/TestIntegration.h: Removed.
3139         * QtTestPlatformPlugin/mac/TestFontDatabase.h: Removed.
3140         * QtTestPlatformPlugin/mac/TestFontDatabase.mm: Removed.
3141         * QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Removed.
3142         * QtTestPlatformPlugin/main.cpp: Removed.
3143         * QtTestPlatformPlugin/testplatform.json: Removed.
3144         * Tools.pro:
3145         * WebKitTestRunner/Target.pri:
3146         * WebKitTestRunner/qt/main.cpp:
3147         (main):
3148
3149 2012-05-07  Balazs Kelemen  <kbalazs@webkit.org>
3150
3151         Unreviewed Qt build fix.
3152
3153         One more try to learn how to use
3154         const with a pointer array.
3155
3156         * DumpRenderTree/qt/main.cpp:
3157         (initializeTestPlatformPlugin):
3158
3159 2012-05-07  Balazs Kelemen  <kbalazs@webkit.org>
3160
3161         Unreviewed build fix after r116299.
3162
3163         * DumpRenderTree/qt/main.cpp:
3164         (initializeTestPlatformPlugin):
3165
3166 2012-05-07  Balazs Kelemen  <kbalazs@webkit.org>
3167
3168         [Qt] Add test specific platform plugin to achieve unified layout test results
3169         https://bugs.webkit.org/show_bug.cgi?id=80996
3170
3171         Reviewed by Simon Hausmann.
3172
3173         Added QtTestPlatformPlugin as a new project under Tools.
3174         This is a Qt5-ish platform plugin that can be used to tweak the
3175         platform support interfaces in order to unify layout test results.
3176         For now it only overrides the font database on Mac and redirects
3177         everything else to the real platform plugin. The font database it
3178         provides mimics the way how we set up test fonts with fontconfig on Linux.
3179         Make DumpRenderTree and WebKitTestRunner use this platform plugin.
3180
3181         * DumpRenderTree/qt/DumpRenderTree.pro:
3182         * DumpRenderTree/qt/main.cpp:
3183         (initializeTestPlatformPlugin):
3184         (main):
3185         * QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Added.
3186         * QtTestPlatformPlugin/TestIntegration.cpp: Added.
3187         (TestIntegration::TestIntegration):
3188         (TestIntegration::fontDatabase):
3189         * QtTestPlatformPlugin/TestIntegration.h: Added.
3190         (TestIntegration):
3191         (TestIntegration::hasCapability):
3192         (TestIntegration::createPlatformPixmap):
3193         (TestIntegration::createPlatformWindow):
3194         (TestIntegration::createPlatformBackingStore):
3195         (TestIntegration::createPlatformOpenGLContext):
3196         (TestIntegration::createPlatformSharedGraphicsCache):
3197         (TestIntegration::guiThreadEventDispatcher):
3198         (TestIntegration::clipboard):
3199         (TestIntegration::drag):
3200         (TestIntegration::inputContext):
3201         (TestIntegration::accessibility):
3202         (TestIntegration::nativeInterface):
3203         (TestIntegration::services):
3204         (TestIntegration::styleHint):
3205         (TestIntegration::platformTheme):
3206         * QtTestPlatformPlugin/mac/TestFontDatabase.h: Added.
3207         (TestFontDatabase):
3208         * QtTestPlatformPlugin/mac/TestFontDatabase.mm: Added.
3209         (TestFontDatabase::populateFontDatabase):
3210         * QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Added.
3211         (TestIntegration::fontDatabase):
3212         * QtTestPlatformPlugin/main.cpp: Added.
3213         (TestIntegrationPlugin::keys):
3214         (TestIntegrationPlugin::create):
3215         (TestIntegrationPlugin::initialize):
3216         * QtTestPlatformPlugin/testplatform.json: Added.
3217         * Tools.pro:
3218         * WebKitTestRunner/Target.pri:
3219         * WebKitTestRunner/qt/main.cpp:
3220         (main):
3221
3222 2012-05-07  Christophe Dumez  <christophe.dumez@intel.com>
3223
3224         [EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
3225         https://bugs.webkit.org/show_bug.cgi?id=85609
3226
3227         Reviewed by Simon Hausmann.
3228
3229         Flakiness was caused by the fact that
3230         media/crash-closing-page-with-media-as-plugin-fallback.html and
3231         media/video-poster-blocked-by-willsendrequest.html use the same PNG
3232         file as poster attribute in the video tag. The PNG file gets cached
3233         when the first test is executed and this somehow causes the second
3234         test to fail. 
3235
3236         The flakiness was addressed by clearing the memory and page caches
3237         between tests.
3238
3239         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3240         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3241
3242 2012-05-07  Eric Seidel  <eric@webkit.org>
3243
3244         Add values for all features to Qt's features.pri
3245         https://bugs.webkit.org/show_bug.cgi?id=85746
3246
3247         Reviewed by Tor Arne Vestbø.
3248
3249         When generate-feature-files generates features.pri it provides a value
3250         for every possible ENABLE_.  In prepration for landing generate-feature-files
3251         it seems appropriate to add a value for all possible ENABLEs to the existing
3252         features.pri.  This lets me make sure that I'm getting them all right!
3253
3254         * qmake/mkspecs/features/features.pri:
3255
3256 2012-05-07  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3257
3258         Added myself as a committer.
3259
3260         Not reviewed.
3261
3262         * Scripts/webkitpy/common/config/committers.py:
3263
3264 2012-05-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3265
3266         [EFL][DRT] Implement LayoutTestController::execCommand
3267         https://bugs.webkit.org/show_bug.cgi?id=82286
3268
3269         Reviewed by Antonio Gomes.
3270
3271         Add missing implementation execCommand and isCommandEnabled to EFL's
3272         LayoutTestController. 
3273
3274         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3275         (LayoutTestController::execCommand):
3276         (LayoutTestController::isCommandEnabled):
3277
3278 2012-05-06  Hayato Ito  <hayato@chromium.org>
3279
3280         [prepare-ChangeLog] Excludes a reference file used by reftests from test files.
3281         https://bugs.webkit.org/show_bug.cgi?id=74268
3282
3283         Reviewed by Ryosuke Niwa.
3284
3285         * Scripts/prepare-ChangeLog:
3286         (generateFileList):
3287
3288 2012-05-06  Mary Wu  <mary.wu@torchmobile.com.cn>
3289
3290         Add a contributor to committers.py
3291         https://bugs.webkit.org/show_bug.cgi?id=85761
3292
3293         Reviewed by Unreviewed.
3294
3295         Add myself to committers.py contributor.
3296
3297         * Scripts/webkitpy/common/config/committers.py:
3298
3299 2012-05-06  Dan Bernstein  <mitz@apple.com>
3300
3301         Tools part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
3302         https://bugs.webkit.org/show_bug.cgi?id=85739
3303
3304         Reviewed by Daniel Bates.
3305
3306         * Scripts/build-webkit: Moved code that copies from WebKitLibraries to the product directory
3307         from here...
3308         * Scripts/copy-webkitlibraries-to-product-directory: ...to this new script.
3309
3310 2012-05-06  Andy Estes  <aestes@apple.com>
3311
3312         Fix the build after r116246.
3313
3314         * DumpRenderTree/LayoutTestController.cpp: Remove an unused function.
3315
3316 2012-05-06  Eric Seidel  <eric@webkit.org>
3317
3318         Update several build-webkit options to match the #defines they toggle
3319         https://bugs.webkit.org/show_bug.cgi?id=85744
3320
3321         Reviewed by Adam Barth.
3322
3323         Most notable here is fixing --3d-canvas to be --webgl these days --
3324         the define was renamed 15 months ago!
3325
3326         * Scripts/webkitperl/FeatureList.pm:
3327
3328 2012-05-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3329
3330         [EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
3331         https://bugs.webkit.org/show_bug.cgi?id=83687
3332
3333         Reviewed by Antonio Gomes.
3334
3335         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3336         (LayoutTestController::setJavaScriptCanAccessClipboard):
3337
3338 2012-05-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3339
3340         Convert isPageBoxVisible to use Internals interface.
3341         https://bugs.webkit.org/show_bug.cgi?id=85692
3342
3343         Reviewed by Darin Adler.
3344
3345         Remove isPageBoxVisible functions, because it is able to work in the
3346         cross-port way through the Internals interface.
3347
3348         * DumpRenderTree/LayoutTestController.cpp:
3349         (LayoutTestController::staticFunctions):
3350         * DumpRenderTree/LayoutTestController.h:
3351         (LayoutTestController):
3352         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3353         * DumpRenderTree/chromium/LayoutTestController.cpp:
3354         (LayoutTestController::LayoutTestController):
3355         * DumpRenderTree/chromium/LayoutTestController.h:
3356         (LayoutTestController):
3357         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3358         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3359         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3360         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3361         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3362         (LayoutTestController):
3363         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3364         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3365
3366 2012-05-06  Tom Zakrajsek  <tomz@codeaurora.org>
3367
3368         sheriffbot isn't reopening patches after it lands rollouts
3369         https://bugs.webkit.org/show_bug.cgi?id=64418
3370
3371         Reviewed by Adam Barth.
3372
3373         * Scripts/webkitpy/tool/commands/download_unittest.py:
3374         * Scripts/webkitpy/tool/steps/createbug.py:
3375         (CreateBug.run):
3376
3377 2012-05-04  Raphael Kubo da Costa  <rakuco@webkit.org>
3378
3379         webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
3380         https://bugs.webkit.org/show_bug.cgi?id=85697
3381
3382         Reviewed by Eric Seidel.
3383
3384         * Scripts/new-run-webkit-tests: Instead of manually detecting whether
3385         the path separator should be ':' or ';' by checking sys.platform, rely
3386         on os.pathsep which has exactly the same information (os.pathsep is
3387         ':' for Cygwin, from what I could check in Python's sources).
3388
3389 2012-05-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3390
3391         Unreviewed, rolling out r116223.
3392         http://trac.webkit.org/changeset/116223
3393         https://bugs.webkit.org/show_bug.cgi?id=85718
3394
3395         The bots need to set XDG_DATA_DIRS (Requested by rakuco on
3396         #webkit).
3397
3398         * efl/jhbuildrc:
3399         * gtk/jhbuildrc:
3400
3401 2012-05-05  Raphael Kubo da Costa  <rakuco@webkit.org>
3402
3403         [jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
3404         https://bugs.webkit.org/show_bug.cgi?id=85717
3405
3406         Reviewed by Martin Robinson.
3407
3408         After r116209, the XDG_DATA_DIRS environment variable is now
3409         passed by webkitpy's layout_tests code to run-with-jhbuild, so
3410         instead of setting a few defaults in jhbuildrc we can now rely on
3411         the values set and really used by each system.
3412
3413         * efl/jhbuildrc:
3414         * gtk/jhbuildrc:
3415
3416 2012-05-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3417
3418         [Qt] Buildfix for --minimal build after r116107.
3419
3420         Reviewed by Csaba Osztrogonác.
3421
3422         * qmake/mkspecs/features/features.prf:
3423
3424 2012-05-05  Zan Dobersek  <zandobersek@gmail.com>
3425
3426         [Gtk] GtkDriver is not required anymore after r116134
3427         https://bugs.webkit.org/show_bug.cgi?id=85699
3428
3429         Reviewed by Csaba Osztrogonác.
3430
3431         Remove GtkDriver as it was replaced by the XvfbDriver and is
3432         no longer needed.
3433
3434         * Scripts/webkitpy/layout_tests/port/gtk.py:
3435
3436 2012-05-05  Zan Dobersek  <zandobersek@gmail.com>
3437
3438         Increase the display ID for the Xvfb process to use if pixel_tests argument
3439         is true rather than if pixel_tests option is present. This fixes the
3440         XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.
3441
3442         Rubber-stamped by Csaba Osztrogonác.
3443
3444         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3445         (XvfbDriver._start):
3446
3447 2012-05-04  Raphael Kubo da Costa  <rakuco@webkit.org>
3448
3449         webkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
3450         https://bugs.webkit.org/show_bug.cgi?id=85694
3451
3452         Reviewed by Martin Robinson.
3453
3454         This is sort of a follow-up to r100674: $XDG_DATA_DIRS should be
3455         preserved, as it is particularly useful for Linux/Unix
3456         environments.  As a real use case, if shared-mime-info is
3457         installed into a non-trivial prefix, Glib and other libraries will
3458         have trouble to properly identify mimetypes (in ResourceResponses,
3459         for example) as the base freedesktop.org mimetype file will not be
3460         found.
3461
3462         * Scripts/webkitpy/layout_tests/port/base.py:
3463         (Port.to.setup_environ_for_server):
3464
3465 2012-05-04  Gustavo Noronha Silva  <gns@gnome.org>
3466
3467         [GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
3468         https://bugs.webkit.org/show_bug.cgi?id=85691
3469
3470         * GNUmakefile.am: no longer link libWebCoreModules to DumpRenderTree.
3471
3472 2012-05-04  Eric Seidel  <eric@webkit.org>
3473
3474         Make capitalization and descriptions in FeatureList.pm more consistent to make easier to autogenerate
3475         https://bugs.webkit.org/show_bug.cgi?id=85583
3476
3477         Reviewed by Daniel Bates.
3478
3479         * Scripts/webkitperl/FeatureList.pm:
3480
3481 2012-05-04  Eric Seidel  <eric@webkit.org>
3482
3483         Sort entries in FeaturesList.pm to make them easier to autogenerate
3484         https://bugs.webkit.org/show_bug.cgi?id=85584
3485
3486         Reviewed by Daniel Bates.
3487
3488         No functional changes, only sorting.
3489
3490         * Scripts/webkitperl/FeatureList.pm:
3491
3492 2012-05-04  Andy Estes  <aestes@apple.com>
3493
3494         REGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
3495         https://bugs.webkit.org/show_bug.cgi?id=85675
3496
3497         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
3498         (TestWebKitAPI::TEST): Disable the test.
3499
3500 2012-04-30  Jer Noble  <jer.noble@apple.com>
3501
3502         Full screen will exit during a provisional load of a non-ancestor iframe.
3503         https://bugs.webkit.org/show_bug.cgi?id=85230
3504
3505         Reviewed by Maciej Stachowiak .
3506
3507         Add support for the new UIDelegate webView:closeFullScreenWithListener: method:
3508         * DumpRenderTree/mac/UIDelegate.mm:
3509         (-[UIDelegate webView:closeFullScreenWithListener:]):
3510
3511         Add support for the new closeFullScreen injected bundle method:
3512         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3513         (WTR::InjectedBundlePage::InjectedBundlePage):
3514         (WTR::InjectedBundlePage::closeFullScreen):
3515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3516
3517 2012-05-04  Ojan Vafai  <ojan@chromium.org>
3518
3519         Fix test naming to be camel-case like the methods they are testing.
3520
3521         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3522         (test):
3523
3524 2012-05-04  Ojan Vafai  <ojan@chromium.org>
3525
3526         Show the results links in the embedded flakiness dashboard
3527         https://bugs.webkit.org/show_bug.cgi?id=85660
3528
3529         Reviewed by Adam Barth.
3530
3531         Turns out these links don't add much visual noise and it's annoying
3532         to have to go to the dashboard from garden-o-matic just to view the
3533         results for a test.
3534