Add SPI WKNavigationResponse._downloadAttribute
[WebKit-https.git] / Tools / ChangeLog-2011-02-16
1 2011-02-16  Anders Carlsson  <andersca@apple.com>
2
3         Reviewed by Adam Roben.
4
5         Assertion failure in DrawingAreaImpl::display when calling WKPageForceRepaint on a page that uses accelerated compositing
6         https://bugs.webkit.org/show_bug.cgi?id=54575
7         <rdar://problem/8979594>
8
9         Add test.
10         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: Added.
12         (TestWebKitAPI::didForceRepaint):
13         (TestWebKitAPI::didFinishLoadForFrame):
14         (TestWebKitAPI::TEST):
15         * TestWebKitAPI/Tests/WebKit2/simple-accelerated-compositing.html: Added.
16         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
17         * TestWebKitAPI/win/copy-resources.cmd:
18
19 2011-02-16  Sergio Villar Senin  <svillar@igalia.com>
20
21         Reviewed by Martin Robinson.
22
23         [Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
24         https://bugs.webkit.org/show_bug.cgi?id=54537
25
26         Added handler for resource-request-starting emitted in
27         FrameLoader's willSendRequest(). The current implementation
28         removes the headers set in setWillSendRequestClearHeader.
29
30         * DumpRenderTree/gtk/DumpRenderTree.cpp:
31         (willSendRequestCallback):
32         (createWebView):
33
34 2011-02-16  Csaba Osztrogonác  <ossy@webkit.org>
35
36         Reviewed by Andreas Kling.
37
38         [Qt] Qt build system can't handle removing headers from tree
39         https://bugs.webkit.org/show_bug.cgi?id=54466
40
41         * Scripts/build-webkit: Remove Qt makefiles from productDir before build.
42
43 2011-02-16  Ilya Tikhonovsky  <loislo@chromium.org>
44
45         Reviewed by Yury Semikhatsky.
46
47         Web Inspector: chromium: DRT is crashing on the tests in inspector-enabled folder.
48         https://bugs.webkit.org/show_bug.cgi?id=54548
49
50         * DumpRenderTree/chromium/TestShell.cpp:
51         (TestShell::runFileTest):
52
53 2011-02-16  Sheriff Bot  <webkit.review.bot@gmail.com>
54
55         Unreviewed, rolling out r77898.
56         http://trac.webkit.org/changeset/77898
57         https://bugs.webkit.org/show_bug.cgi?id=54541
58
59         Leopard Debug hasn't compiled for a long time (Requested by
60         abarth on #webkit).
61
62         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
63         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
64
65 2011-02-15  Xianzhu Wang  <wangxianzhu@google.com>
66
67         Reviewed by Kent Tamura.
68
69         Fixed a small bug about --no-timeout option.
70         https://bugs.webkit.org/show_bug.cgi?id=52873
71
72         * DumpRenderTree/chromium/DumpRenderTree.cpp:
73         (main):
74
75 2011-02-15  Kenneth Russell  <kbr@google.com>
76
77         Reviewed by Darin Fisher.
78
79         Allow controlling minimum DOMTimer interval on a per-page basis
80         https://bugs.webkit.org/show_bug.cgi?id=54312
81
82         Implemented new method setMinimumTimerInterval in
83         LayoutTestController for all ports.
84
85         * DumpRenderTree/LayoutTestController.cpp:
86         (setMinimumTimerIntervalCallback):
87         (LayoutTestController::staticFunctions):
88         * DumpRenderTree/LayoutTestController.h:
89         * DumpRenderTree/chromium/LayoutTestController.cpp:
90         (LayoutTestController::LayoutTestController):
91         (LayoutTestController::setMinimumTimerInterval):
92         * DumpRenderTree/chromium/LayoutTestController.h:
93         * DumpRenderTree/chromium/WebViewHost.cpp:
94         (WebViewHost::reset):
95         * DumpRenderTree/gtk/DumpRenderTree.cpp:
96         (resetDefaultsToConsistentValues):
97         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
98         (LayoutTestController::setMinimumTimerInterval):
99         * DumpRenderTree/mac/DumpRenderTree.mm:
100         (resetWebViewToConsistentStateBeforeTesting):
101         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
102         (LayoutTestController::setMinimumTimerInterval):
103         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
104         (WebCore::WebPage::resetSettings):
105         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
106         (LayoutTestController::setMinimumTimerInterval):
107         * DumpRenderTree/qt/LayoutTestControllerQt.h:
108         * DumpRenderTree/win/DumpRenderTree.cpp:
109         (resetWebViewToConsistentStateBeforeTesting):
110         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
111         (LayoutTestController::setMinimumTimerInterval):
112
113 2011-02-15  Martin Robinson  <mrobinson@igalia.com>
114
115         Reviewed by Xan Lopez.
116
117         [Freetype] Better map CSS font weight to Fontconfig font weight
118         https://bugs.webkit.org/show_bug.cgi?id=54323
119
120         Add the WeightWatcher fonts to the list of sourced fonts when intializing
121         DRT. This will allow us to pass tests that use WeightWatcher.
122
123         * DumpRenderTree/gtk/DumpRenderTree.cpp:
124         (initializeFonts): Source the WebkitWeightWatcher fonts.
125
126 2011-02-15  Dirk Pranke  <dpranke@chromium.org>
127
128         Reviewed by Tony Chang.
129
130         Make new-run-webkit-tests --processes work under Windows' weird
131         multiprocessing model. This requires us to be running a Python
132         file that can be imported as a module, so I've modified the
133         new-run-webkit-tests script to spawn a subprocess runing
134         webkitpy.layout_tests.run_webkit_tests.py. I've also modified
135         the manager_worker_broker tests because you can't pickle a
136         nested class. This requires us to use globals to pass queues
137         back and forth for testing, but the alternative is to pass extra
138         arguments to start_worker() and that feels like a bad tradeoff
139         just for testing.
140
141         https://bugs.webkit.org/show_bug.cgi?id=54431
142
143         * Scripts/new-run-webkit-tests:
144         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
145
146 2011-02-15  Brady Eidson  <beidson@apple.com>
147
148         Reviewed by Darin Adler.
149
150         <rdar://problem/9002047> and https://bugs.webkit.org/show_bug.cgi?id=54426
151         WebFrameLoaderClient::shouldGoToHistoryItem needs implementation
152
153         Add dummy implementations to keep our tools building.
154
155         * MiniBrowser/mac/BrowserWindowController.m:
156         (-[BrowserWindowController awakeFromNib]):
157
158         * WebKitTestRunner/TestController.cpp:
159         (WTR::TestController::initialize):
160
161 2011-02-15  David Levin  <levin@chromium.org>
162
163         Reviewed by Shinichiro Hamaji.
164
165         check-webkit-style should do some detection for valid uses of WEBKIT_API (in chromium public api).
166         https://bugs.webkit.org/show_bug.cgi?id=52271
167
168         * Scripts/webkitpy/style/checkers/cpp.py: Added the check for WEBKIT_API usage.
169         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
170
171 2011-02-14  Dirk Pranke  <dpranke@chromium.org>
172
173         Unreviewed, build fix.
174
175         Fix minor regression introduced in r78522. For some reason, Python
176         provides a platform.mac_ver() routine on Linux, so we need to
177         check to make sure it's returning something in addition to
178         checking for its existence.
179
180         * Scripts/webkitpy/layout_tests/port/mac.py:
181
182 2011-02-14  Dirk Pranke  <dpranke@chromium.org>
183
184         Reviewed by Mihai Parparita.
185
186         Clean up the way we handle platform names in
187         new-run-webkit-tests. Previously, if you specified
188         '--platform mac' or '--platform chromium-mac' on the command
189         line, it would use that platform name to determine baseline search
190         paths, etc. This is almost never the right thing to do, because
191         it ignores the existence of version-specific baselines.
192         
193         So, I changed this so that ports that support versions must
194         always use a version, and the version should default to the
195         version of the operating system that the port is being run on
196         (e.g., if you're running on Leopard, then passing '--platform
197         mac' will default to the 'mac-leopard' port). This means that
198         port.name() should always include a version-specific suffix if
199         the port supports versions.
200
201         However, we still support things like '--platform mac' as input
202         so that the user doesn't have to explicitly specify a version,
203         both for convenience and so we don't have to make buildbot
204         configs more complicated than they already are.
205
206         Also, I cleaned up how the baselines were being searched
207         on the chromium-mac port (this is one of the two bugs that
208         prompted this refactoring), and made the logic easier to follow
209         and more consistent across the mac and chromium ports
210         
211         Lastly, I added a port.get_all_names() method that could be used
212         to get the names of all of the ports to search, rather than having
213         to guess (incorrectly) from the list of directories under
214         LayoutTests/platform (this last thing was necessary because the
215         deduplicate_tests unittest broke as the fallback dirs changed).
216
217         https://bugs.webkit.org/show_bug.cgi?id=54248
218
219         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
220         * Scripts/webkitpy/layout_tests/port/factory.py:
221         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
222         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
223         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
224         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
225         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
226         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
227         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
228         * Scripts/webkitpy/layout_tests/port/mac.py:
229         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
230         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
231
232 2011-02-14  Dirk Pranke  <dpranke@chromium.org>
233
234         Reviewed by Adam Barth.
235
236         update-webkit hangs in a git-only checkout
237
238         Previously it would hang forever trying to do a 'git svn
239         rebase'. Now, it will default to a 'git pull' if the
240         svn-remote.svn.fetch variable isn't set, and bail out if it
241         doesn't know where to pull from.
242
243         https://bugs.webkit.org/show_bug.cgi?id=54265
244
245         * Scripts/update-webkit:
246         * Scripts/VCSUtils.pm:
247
248 2011-02-14  Dirk Pranke  <dpranke@chromium.org>
249
250         Reviewed by Mihai Parparita.
251
252         This patch modifies NRWT's Worker clas to use the new
253         WorkerMixin class to actually run tests. With this patch, the
254         multiprocess version of NRWT is fully functional and just needs
255         the values for --worker-model and --child-processes to be corrected
256         in the port/* classes to start using the new code by default.
257
258         https://bugs.webkit.org/show_bug.cgi?id=54082
259
260         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
261
262 2011-02-14  Dirk Pranke  <dpranke@chromium.org>
263
264         Reviewed by Mihai Parparita.
265
266         This patch shuffles code out of dump_render_tree_thread and
267         single_test_runner and into a new worker_mixin class that will
268         be shared by both TestShellThread and Worker. This change
269         restores single_test_runner to its state as of r77606 - it is
270         stateless again. It also prunes TestShellThread to pretty much
271         just the logic used for the original shared-memory access.
272
273         https://bugs.webkit.org/show_bug.cgi?id=54079
274
275         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
276         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
277         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Added.
278
279 2011-02-14  Dirk Pranke  <dpranke@chromium.org>
280
281         Reviewed by Ojan Vafai.
282
283         This patch updates NRWT to add per-worker and per-shard test stats
284         into TestRunner2, bringing it to parity with TestRunner.
285
286         https://bugs.webkit.org/show_bug.cgi?id=54074
287
288         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
289
290 2011-02-14  Dirk Pranke  <dpranke@chromium.org>
291
292         Reviewed by Tony Chang.
293
294         nrwt multiprocessing: add code to handle interrupts and wedged
295         threads.
296         https://bugs.webkit.org/show_bug.cgi?id=54072
297
298         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
299         Adds the cancel(), is_alive(), join(), and log_wedged_worker()
300         methods to the WorkerConnection class
301
302         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
303         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
304         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
305         Adds the cancel() method to the Worker class
306
307 2011-02-14  Dirk Pranke  <dpranke@chromium.org>
308
309         Reviewed by Tony Chang.
310
311         update the NRWT multiprocessing code to spawn multiple workers
312         instead of just using one.
313
314         https://bugs.webkit.org/show_bug.cgi?id=54071
315
316         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
317
318 2011-02-12  Chang Shu  <cshu@webkit.org>
319
320         Unreviewed.
321
322         Update my own email addresses and IRC nickname.
323
324         * Scripts/webkitpy/common/config/committers.py:
325
326 2011-02-11  Dirk Pranke  <dpranke@chromium.org>
327
328         Reviewed by Tony Chang.
329
330         This patch adds to NRWT most of the support needed to run the new
331         message-based workers in separate threads or processes. The code
332         isn't fully complete yet because we don't support cancel() or
333         is_alive().
334
335         https://bugs.webkit.org/show_bug.cgi?id=54070
336
337         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
338         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
339         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
340         * Scripts/webkitpy/layout_tests/port/base.py:
341         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
342         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
343
344 2011-02-11  Sailesh Agrawal  <sail@chromium.org>
345
346         Reviewed by Kenneth Russell.
347
348         plugins/invalidate_rect.html fails on chromium-mac
349         https://bugs.webkit.org/show_bug.cgi?id=54051
350
351         This change fixes the invalidate_rect.html test failure on Windows.
352
353         There were two problems. First, the test specified that the plugin was window less by doing <embed ... windowedPlugin="false"></embed>. The windowedPlugin parameter was never being read by the plugin. Fix was to simply set the NPPVpluginWindowBool variable based on the parameter.
354
355         The second problem was that the plugin never handled paint events on Windows. Fix was to simply copy the Mac code to handle paint events.
356
357         This change also updates the build path in chromium_win.py to use the new Source directory.
358
359         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
360         (invalidateRect):
361         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
362         (NPP_New):
363         (handleEventWin):
364         (NPP_HandleEvent):
365         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
366
367 2011-02-11  Csaba Osztrogonác  <ossy@webkit.org>
368
369         Reviewed by Andreas Kling.
370
371         [Qt] Increase the timeout of Qt API tests to 120 seconds.
372
373         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
374
375 2011-02-10  Zhenyao Mo  <zmo@google.com>
376
377         Unreviewed, build fix.
378
379         * DumpRenderTree/DumpRenderTree.gypi:
380
381 2011-02-10  Dirk Pranke  <dpranke@chromium.org>
382
383         Reviewed by Tony Chang.
384
385         This patch adds the bulk of the remaining functionality for
386         the NRWT message-passing implementation. The patch adds a new
387         Worker class that will eventually replace the TestShellThread
388         class in dump_render_tree_thread.py, and implements enough of
389         TestRunner2 and the inline version of the manager_worker_broker
390         to actually be able to send a full set of messages back and
391         forth. The Worker stubs do not actually run tests, and there's
392         lots of error handling and stats needed, but this is the core
393         logic.
394
395         https://bugs.webkit.org/show_bug.cgi?id=54068
396
397         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
398         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
399         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
400         * Scripts/webkitpy/layout_tests/layout_package/worker.py: Added.
401         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
402
403 2011-02-10  Zhenyao Mo  <zmo@google.com>
404
405         Unreviewed, build fix.
406
407         * DumpRenderTree/DumpRenderTree.gypi:
408
409 2011-02-10  Zhenyao Mo  <zmo@google.com>
410
411         Unreviewed, build fix.
412
413         * DumpRenderTree/DumpRenderTree.gypi:
414
415 2011-02-10  Zhenyao Mo  <zmo@google.com>
416
417         Unreviewed, attempt to fix crashing plugin tests.
418
419         * DumpRenderTree/DumpRenderTree.gypi:
420
421 2011-02-10  Zhenyao Mo  <zmo@google.com>
422
423         Unreviewed, build fix.
424
425         * DumpRenderTree/DumpRenderTree.gypi:
426
427 2011-02-10  Sam Weinig  <sam@webkit.org>
428
429         Try and fix some crashing tests on the chromium build bot.
430
431         * DumpRenderTree/DumpRenderTree.gypi:
432
433 2011-02-10  Anders Carlsson  <andersca@apple.com>
434
435         Reviewed by Sam Weinig.
436
437         Log an error if a plug-in test can't be found
438         https://bugs.webkit.org/show_bug.cgi?id=54252
439
440         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
441         (PluginTest::create):
442         Return null if the test wasn't found.
443
444         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
445         (NPP_New):
446         Report an error if PluginTest::create returns null.
447
448 2011-02-10  Robert Hogan  <robert@webkit.org>
449
450         Reviewed by Laszlo Gombos.
451
452         [Qt] Return menu items from eventSender.contextMenu()
453         https://bugs.webkit.org/show_bug.cgi?id=53039
454
455         * DumpRenderTree/qt/EventSenderQt.cpp:
456         (EventSender::contextClick):
457         * DumpRenderTree/qt/EventSenderQt.h:
458
459 2011-02-10  Adam Roben  <aroben@apple.com>
460
461         Test showing and hiding the find indicator on Windows
462
463         Test for <http://webkit.org/b/54213> <rdar://problem/8983261> REGRESSION (r78198): Crash in
464         FindIndicator::contentImage when scrolling page
465
466         Reviewed by Steve Falkenburg.
467
468         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added.
469         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
470         (TestWebKitAPI::findIndicatorCallback): Record that the callback was called, and save the
471         bitmap.
472         (TestWebKitAPI::initialize): Hook up our callbacks.
473         (TestWebKitAPI::TEST): Test showing then hiding the find indicator to see if we crash.
474
475         * TestWebKitAPI/PlatformWebView.h:
476         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
477         (TestWebKitAPI::PlatformWebView::page):
478         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
479         (TestWebKitAPI::PlatformWebView::page):
480         Made page a const member function.
481
482         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
483
484 2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>
485
486         Reviewed by Martin Robinson.
487
488         [GTK] Log signals from AtkDocument interface also in AccessibilityController
489         https://bugs.webkit.org/show_bug.cgi?id=54198
490
491         Trace AtkDocument's signals emission through AccessibilityController.
492
493         Also, taken the code related to adding and removing global
494         listeners for ATK signals out to a separate file, for the sake of
495         clarity and to ease future additions.
496
497         * DumpRenderTree/gtk/AccessibilityCallbacks.h: Added.
498         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp: Added
499         (printAccessibilityEvent): Print information about an event.
500         (axObjectEventListener): Global listener for AtkObject's signals.
501         (axDocumentEventListener): Global listener for AtkDocument's signals.
502         (connectAccessibilityCallbacks): Connect all global listeners.
503         (disconnectAccessibilityCallbacks): Disconnect all global listeners.
504
505         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
506         (AccessibilityController::setLogAccessibilityEvents): Call to
507         connectAccessibilityCallbacks and disconnectAccessibilityCallbacks.
508
509         * GNUmakefile.am: Added new files.
510
511 2011-02-09  Martin Robinson  <mrobinson@igalia.com>
512
513         Reviewed by Gustavo Noronha Silva.
514
515         [GTK] Default error page is interfering with tests which require failed loads
516         https://bugs.webkit.org/show_bug.cgi?id=54157
517
518         Disable the default error page during DRT runs. This prevents unexpected loads
519         from interfering with tests that have planned failed loads.
520
521         * DumpRenderTree/gtk/DumpRenderTree.cpp:
522         (webViewLoadError): Added, disable default handler.
523         (createWebView): Connect the new load-error handler.
524
525 2011-02-10  Zoltan Horvath  <zoltan@webkit.org>
526
527         Reviewed by Andreas Kling.
528
529         [Qt] Add UrlLoader and command line argument handling to MiniBrowser
530         https://bugs.webkit.org/show_bug.cgi?id=54192
531  
532         Copy and modify files from QtTestBrowser's implementation.
533
534         * MiniBrowser/qt/BrowserWindow.cpp:
535         (BrowserWindow::BrowserWindow):
536         (BrowserWindow::newWindow):
537         * MiniBrowser/qt/BrowserWindow.h:
538         * MiniBrowser/qt/MiniBrowser.pro:
539         * MiniBrowser/qt/MiniBrowserApplication.cpp: Copied from QtTestBrowser/launcherwindow.cpp
540         (MiniBrowserApplication::MiniBrowserApplication):
541         (MiniBrowserApplication::handleUserOptions):
542         * MiniBrowser/qt/MiniBrowserApplication.h: Copied from QtTestBrowser/launcherwindow.h
543         (WindowOptions::WindowOptions):
544         (MiniBrowserApplication::urls):
545         (MiniBrowserApplication::isRobotized):
546         (MiniBrowserApplication::robotTimeout):
547         (MiniBrowserApplication::robotExtraTime):
548         * MiniBrowser/qt/UrlLoader.cpp: Copied from QtTestBrowser/urlloader.cpp
549         (UrlLoader::UrlLoader):
550         (UrlLoader::loadNext):
551         (UrlLoader::checkIfFinished):
552         (UrlLoader::frameLoadStarted):
553         (UrlLoader::frameLoadFinished):
554         (UrlLoader::loadUrlList):
555         (UrlLoader::getUrl):
556         * MiniBrowser/qt/UrlLoader.h: Copied from QtTestBrowser/urlloader.h 
557         * MiniBrowser/qt/main.cpp:
558         (main):
559         * MiniBrowser/qt/utils.cpp: Copied from QtTestBrowser/utils.cpp 
560         (takeOptionValue):
561         (formatKeys):
562         (enumToKeys):
563         (appQuit):
564         (urlFromUserInput):
565         * MiniBrowser/qt/utils.h: Copied from QtTestBrowser/utils.h
566
567 2011-02-10  Zoltan Horvath  <zoltan@webkit.org>
568
569         Reviewed by Andreas Kling.
570
571         check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
572         https://bugs.webkit.org/show_bug.cgi?id=54200
573
574         * Scripts/webkitpy/style/checker.py:
575         * Scripts/webkitpy/style/checker_unittest.py:
576
577 2011-02-10  Peter Varga  <pvarga@webkit.org>
578
579         Reviewed by Csaba Osztrogonác.
580
581         Remove PCRE source from trunk
582         https://bugs.webkit.org/show_bug.cgi?id=54188
583
584         * wx/build/settings.py:
585
586 2011-02-10  David Levin  <levin@chromium.org>
587
588         Reviewed by Shinichiro Hamaji.
589
590         check-webkit-style should be able to figure out function modifiers and return type.
591         https://bugs.webkit.org/show_bug.cgi?id=54124
592
593         * Scripts/webkitpy/style/checkers/cpp.py:
594         (_rfind_in_lines): A way to search backwards in lines.
595         (_FunctionState.modifiers_and_return_type):
596         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for the new functionality.
597
598 2011-02-09  Adam Roben  <aroben@apple.com>
599
600         Test that WM_PRINT doesn't trigger an assertion
601
602         Test for <http://webkit.org/b/54145> <rdar://problem/8979559> WM_PRINT doesn't work with new
603         drawing area (assertion failure in DrawingAreaProxyImpl in Debug builds)
604
605         Reviewed by Darin Adler.
606
607         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Added.
608         (TestWebKitAPI::TEST): Send a WM_PRINT message to a WKView.
609
610 2011-02-09  Adam Roben  <aroben@apple.com>
611
612         Test that having a WKView paint after being resized while hidden doesn't cause a crash
613
614         Test for <http://webkit.org/b/54142> <rdar://problem/8979365> Crash in
615         DrawingAreaProxyImpl::paint when WKView paints after being resized while hidden
616
617         Reviewed by Darin Adler.
618
619         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
620         (TestWebKitAPI::TEST): Force the WKView to paint after resizing it while hidden.
621
622 2011-02-09  Adam Roben  <aroben@apple.com>
623
624         Add a test that resizes a WKView while it's hidden
625
626         Test for <http://webkit.org/b/54141> <rdar://problem/8979195> WKView draws at wrong size,
627         performs badly if is resized while hidden (assertion fails in
628         BackingStore::incorporateUpdate in Debug builds)
629
630         Reviewed by Darin Adler.
631
632         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Added.
633         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
634         (TestWebKitAPI::setPageLoaderClient): Hook up our didFinishLoadForFrame callback.
635         (TestWebKitAPI::flushMessages): Load a URL and wait for the load to complete. This ensures
636         that all pending messages have been handled by the UI and web process.
637         (TestWebKitAPI::timerCallback): Kill the timer and record that it fired.
638         (TestWebKitAPI::runForDuration): Set a timer and run the run loop until it fires.
639         (TestWebKitAPI::waitForBackingStoreUpdate): Wait for half a second to give the web process a
640         chance to display, then flush all pending messages.
641         (TestWebKitAPI::TEST): Resize the WKView while it's hidden, then show it again and wait for
642         the backing store to update. This triggers the assertion from bug 54141.
643
644         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
645         (TestWebKitAPI::PlatformWebView::resizeTo): Implemented.
646
647         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
648
649 2011-02-10  Philippe Normand  <pnormand@igalia.com>
650
651         Unreviewed, GTK build fix after roll out of r78157...
652
653         * GNUmakefile.am:
654
655 2011-02-10  Eric Seidel  <eric@webkit.org>
656
657         Unreviewed, rolling out r78157.
658         http://trac.webkit.org/changeset/78157
659         https://bugs.webkit.org/show_bug.cgi?id=54150
660
661         Fails on a bunch of bots
662
663         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
664         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Removed.
665         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
666         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
667
668 2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>
669
670         Reviewed by Xan Lopez.
671
672         [GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test
673         https://bugs.webkit.org/show_bug.cgi?id=54185
674
675         * DumpRenderTree/gtk/DumpRenderTree.cpp:
676         (resetDefaultsToConsistentValues):
677
678 2011-02-10  Philippe Normand  <pnormand@igalia.com>
679
680         Unreviewed GTK build fix.
681
682         Adding
683         Tools/DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp
684         in the build, fixing the
685         plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html
686         test.
687
688         * GNUmakefile.am:
689
690 2011-02-10  Mario Sanchez Prada  <msanchez@igalia.com>
691
692         Reviewed by Chris Fleizach.
693
694         [GTK] Add support in DRT to log "accessibility events"
695         https://bugs.webkit.org/show_bug.cgi?id=54116
696
697         Added a way to log accessibility related events, in a
698         platform-dependant way.
699
700         Add new function to AccessibilityController.
701
702         * DumpRenderTree/AccessibilityController.h:
703         * DumpRenderTree/AccessibilityController.cpp:
704         (logAccessibilityEventsCallback): New callback.
705         (AccessibilityController::getJSClass): Added new function.
706         (AccessibilityController::resetToConsistentState): Initialized
707         calling setLogAccessibilityEvents(false).
708
709         Provided implementation for the GTK port.
710
711         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
712         (accessibility_event_listener): Common listener for logging
713         information about all the signals emitted by any AtkObject.
714         (AccessibilityController::setLogAccessibilityEvents): Add or
715         remove listeners for signals, as specified by the parameter.
716
717         Provide dummy implementations for mac and win ports.
718
719         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
720         (AccessibilityController::setLogAccessibilityEvents):
721         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
722         (AccessibilityController::setLogAccessibilityEvents):
723
724 2011-02-09  Hayato Ito  <hayato@chromium.org>
725
726         Reviewed by Tony Chang.
727
728         [NRWT] Remove encoding parameters where we can assume data can be
729         written in binary mode.
730
731         https://bugs.webkit.org/show_bug.cgi?id=54066
732
733         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
734         * Scripts/webkitpy/layout_tests/port/base.py:
735
736 2011-02-09  Dirk Pranke  <dpranke@chromium.org>
737
738         Reviewed by Tony Chang.
739
740         nrwt multiprocessing: minor cleanup prior to implementing the new worker
741
742         This patch renames AbstractManager to ManagerConnection and
743         changes some argument names to be more consistent between
744         manager_worker_broker and message_broker. It also fixes a couple
745         of typos in message_broker. These changes will be tested by code
746         introduced in the next patch.
747        
748         https://bugs.webkit.org/show_bug.cgi?id=54067
749
750         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
751         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:
752
753 2011-02-09  Anders Carlsson  <andersca@apple.com>
754
755         Reviewed by Sam Weinig.
756
757         Repro crash with Sony Google TV ad at Gizmodo
758         https://bugs.webkit.org/show_bug.cgi?id=54150
759         <rdar://problem/8782346>
760
761         Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.
762
763         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
764         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added.
765         (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream):
766         (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy):
767         (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
768         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
769         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
770
771 2011-02-09  David Levin  <levin@chromium.org>
772
773         Reviewed by Eric Seidel.
774
775         check-webkit-style: The error message about NULL should be more clear for comments.
776         https://bugs.webkit.org/show_bug.cgi?id=53786
777
778         * Scripts/webkitpy/style/checkers/cpp.py: Clarified the error message.
779         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Fixed the corresponding test.
780
781 2011-02-09  Nebojsa Ciric  <cira@chromium.org>
782
783         Reviewed by Darin Fisher.
784
785         Implements Locale object of JavaScript internationalization API proposal, as an
786         v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
787         and in this patch we just provide flags, tests and build rules for chromium port.
788         https://bugs.webkit.org/show_bug.cgi?id=49414
789
790         * DumpRenderTree/chromium/TestShell.cpp:
791         (TestShell::TestShell):
792
793 2011-02-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
794
795         Reviewed by Kenneth Rohde Christiansen.
796
797         [Qt] Remove UiTools dependency from MiniBrowser
798         https://bugs.webkit.org/show_bug.cgi?id=54096
799
800         * MiniBrowser/qt/MiniBrowser.pro:
801
802 2011-02-08  Hayato Ito  <hayato@chromium.org>
803
804         Reviewed by Tony Chang.
805
806         [NRWT] Pull up rebaseline code from compare_output() function defined
807         in text_diff.py and image_diff.py into a SingleTestRunner.
808
809         This patch is a first step for eliminating test_type/* classes.
810
811         https://bugs.webkit.org/show_bug.cgi?id=53071
812
813         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
814         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
815         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
816         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
817
818 2011-02-07  Ojan Vafai  <ojan@chromium.org>
819
820         Reviewed by Mihai Parparita.
821
822         stop generating results.json files
823         https://bugs.webkit.org/show_bug.cgi?id=53977
824
825         We've only used incremental_results.json for a while now
826         and there are plans to start generating a results.json file that matches
827         the format of unexpected_results.json.
828
829         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
830         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
831         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
832         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
833         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
834
835 2011-02-08  Sailesh Agrawal  <sail@chromium.org>
836
837         Reviewed by Kenneth Russell.
838
839         Invalidate rect doesn't work for windowless plugins on Chromium
840         https://bugs.webkit.org/show_bug.cgi?id=53117
841
842         Added two new utility methods.
843         - layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
844         - plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect
845         This is used to test that invalidating a rect correctly causes a repaint of the plugin.
846
847         * DumpRenderTree/LayoutTestController.cpp:
848         (displayInvalidatedRegionCallback):
849         (LayoutTestController::staticFunctions):
850         * DumpRenderTree/LayoutTestController.h:
851         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
852         (invalidateRect):
853         (pluginInvoke):
854         * DumpRenderTree/chromium/LayoutTestController.cpp:
855         (LayoutTestController::LayoutTestController):
856         (LayoutTestController::displayInvalidatedRegion):
857         * DumpRenderTree/chromium/LayoutTestController.h:
858         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
859
860 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
861
862         Reviewed by Tony Chang.
863
864         new-run-webkit-tests: move the logic that starts and stops the
865         servers from dump_render_tree_thread into single_test_runner
866         so that we can reuse it in the new multiprocessing worker class
867         as well.
868
869         https://bugs.webkit.org/show_bug.cgi?id=53840
870
871         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
872         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
873  
874 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
875
876         Reviewed by Mihai Parparita.
877
878         new-run-webkit-tests: split out thread stack logging code into a sharable module
879
880         This patch splits out the code used to find and log thread
881         stacks from NRWT-specific packages to something generic and
882         shareable by other python modules. It will be shared in the near
883         future by the manager_worker_broker module, for example.
884
885         https://bugs.webkit.org/show_bug.cgi?id=53656
886
887         * Scripts/webkitpy/common/system/stack_utils.py: Added.
888         * Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
889         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
890         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
891
892 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
893
894         Reviewed by Tony Chang.
895
896         new-run-webkit-tests: move a bunch of testing logic out of
897         dump_render_tree_thread and into single_test_runner so that we
898         will be able to reuse it in the new multiprocessing worker class as well.
899
900         https://bugs.webkit.org/show_bug.cgi?id=53838
901
902         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
903         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
904
905         
906 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
907
908         Reviewed by Ojan Vafai.
909
910         new-run-webkit-tests: remove no longer needed WatchableThread
911         class.
912
913         https://bugs.webkit.org/show_bug.cgi?id=53839
914
915         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
916
917 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
918
919         Reviewed by Tony Chang.
920
921         new-run-webkit-tests: add stubs for the Manager objects that
922         will abstract the concurrency implementation (inline / threads /
923         processes). These classes do nothing yet and are not wired up to
924         anything.
925
926         https://bugs.webkit.org/show_bug.cgi?id=53477
927
928         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
929         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
930
931 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
932
933         Reviewed by Tony Chang.
934
935         new-run-webkit-tests: add simplified message broker for new-style
936         messaging. This change adds a very simple message broker that
937         will be used to shuttle messages between the TestRunner2 manager
938         thread and the Worker threads. For now the class is not used by
939         anything, but the eventual usage can be seen in the patches
940         attached to bug 49566.
941
942         https://bugs.webkit.org/show_bug.cgi?id=53158
943
944         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
945         * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
946
947 2011-02-08  Adam Barth  <abarth@webkit.org>
948
949         Reviewed by Dimitri Glazkov.
950
951         chromium-win builder shouldn't run python or perl tests
952         https://bugs.webkit.org/show_bug.cgi?id=54032
953
954         These tests don't pass on this builder because the builder isn't
955         running in cygwin.  There isn't really any point in running them and
956         making the bot red forever.
957
958         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
959
960 2011-02-08  Brady Eidson  <beidson@apple.com>
961
962         Reviewed by Darin Adler.
963
964         <rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
965         didChangeBackForwardList should include some context about what changed
966
967         * MiniBrowser/mac/BrowserWindowController.m:
968         (didChangeBackForwardList):
969
970 2011-02-08  Sam Weinig  <sam@webkit.org>
971
972         Reviewed by Anders Carlsson.
973
974         WK2: Add ability to pass context to policy delegate methods
975         https://bugs.webkit.org/show_bug.cgi?id=54031
976
977         * MiniBrowser/mac/BrowserWindowController.m:
978         (decidePolicyForNavigationAction):
979         (decidePolicyForNewWindowAction):
980         (decidePolicyForMIMEType):
981         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
982         (TestWebKitAPI::decidePolicyForNavigationAction):
983         (TestWebKitAPI::decidePolicyForNewWindowAction):
984         (TestWebKitAPI::decidePolicyForMIMEType):
985         Update policy client for new API.
986
987 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
988
989         Reviewed by Xan Lopez.
990
991         [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
992         https://bugs.webkit.org/show_bug.cgi?id=54033
993
994         Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
995         call DumpRenderTreeSupportGtk. Turn off the icon database between tests.
996
997         * DumpRenderTree/gtk/DumpRenderTree.cpp:
998         (resetDefaultsToConsistentValues): Turn off the icon database.
999         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1000         (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk
1001         method.
1002
1003 2011-02-08  Kundu Suchismita  <suchi.kundu@nokia.com>
1004
1005         Reviewed by Laszlo Gombos.
1006
1007         Local Storage settings can be enable/disable from "Develop" menu
1008         https://bugs.webkit.org/show_bug.cgi?id=52296
1009
1010         * QtTestBrowser/launcherwindow.cpp:
1011         (LauncherWindow::createChrome):
1012         (LauncherWindow::toggleLocalStorage):
1013         (LauncherWindow::toggleOfflineStorageDatabase):
1014         (LauncherWindow::toggleOfflineWebApplicationCache):
1015         (LauncherWindow::setOfflineStorageDefaultQuota):
1016         * QtTestBrowser/launcherwindow.h:
1017         (WindowOptions::WindowOptions):
1018         * QtTestBrowser/main.cpp:
1019         (LauncherApplication::handleUserOptions):
1020
1021 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
1022
1023         Reviewed by Eric Seidel.
1024
1025         [GTK] EventSender.keyDown does not support non-array modifier arguments
1026         https://bugs.webkit.org/show_bug.cgi?id=53962
1027
1028         Support handling either an array or a string for the modifier argument
1029         to EventSender.keyDown.
1030
1031         * DumpRenderTree/gtk/EventSender.cpp:
1032         (gdkModifierFromJSValue): Added this helper which factors out the
1033         string comparison bits.
1034         (gdkModifersFromJSValue): Test up front whether the value is a string,
1035         to handle it specially.
1036
1037 2011-02-08  Benjamin Poulain  <ikipou@gmail.com>
1038
1039         Reviewed by Csaba Osztrogonác.
1040
1041         openDatabaseSync() stop responding after too many call
1042         https://bugs.webkit.org/show_bug.cgi?id=53945
1043
1044         Reset the database quota to a known state between each test.
1045
1046         Define a quota for the known origins at each test run and delete
1047         all the databases.
1048         This way, the database related test do not depend on previous
1049         allocations.
1050
1051         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1052         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1053         (WebCore::DumpRenderTree::dumpDatabaseQuota):
1054         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1055         (LayoutTestController::reset):
1056
1057 2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1058
1059         Reviewed by Martin Robinson.
1060
1061         [GTK] DRT's TextInputController is unimplemented on GTK
1062         https://bugs.webkit.org/show_bug.cgi?id=52997
1063
1064         Initial implementation of TextInputController for GTK port.
1065
1066         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1067         (webViewWindowObjectCleared):
1068         * DumpRenderTree/gtk/TextInputController.cpp: Added.
1069         (setMarkedTextCallback):
1070         (insertTextCallback):
1071         (unmarkTextCallback):
1072         (firstRectForCharacterRangeCallback):
1073         (selectedRangeCallback):
1074         (getClass):
1075         (makeTextInputController):
1076         * DumpRenderTree/gtk/TextInputController.h: Added.
1077         * GNUmakefile.am:
1078
1079 2011-02-07  Tony Chang  <tony@chromium.org>
1080
1081         Reviewed by Adam Barth.
1082
1083         clean up python imports
1084         https://bugs.webkit.org/show_bug.cgi?id=53966
1085
1086         Convert "import A.B.C.D as D" to "from A.B.C import D" and
1087         make some imports absolute as required by PEP-8
1088
1089         * Scripts/webkitpy/common/checkout/scm.py:
1090         * Scripts/webkitpy/common/net/irc/ircbot.py:
1091         * Scripts/webkitpy/common/system/logutils.py:
1092         * Scripts/webkitpy/common/system/logutils_unittest.py:
1093         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1094         * Scripts/webkitpy/layout_tests/port/chromium.py:
1095         * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
1096         * Scripts/webkitpy/layout_tests/port/webkit.py:
1097         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
1098         * Scripts/webkitpy/tool/bot/irc_command.py:
1099         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1100         * Scripts/webkitpy/tool/commands/download.py:
1101         * Scripts/webkitpy/tool/commands/prettydiff.py:
1102         * Scripts/webkitpy/tool/commands/queries.py:
1103         * Scripts/webkitpy/tool/commands/roll.py:
1104         * Scripts/webkitpy/tool/commands/stepsequence.py:
1105         * Scripts/webkitpy/tool/commands/upload.py:
1106         * Scripts/webkitpy/tool/main.py:
1107
1108 2011-02-07  James Robinson  <jamesr@chromium.org>
1109
1110         Reviewed by Adam Barth.
1111
1112         Teach do-webcore-rename about the WebKit move to Source/
1113         https://bugs.webkit.org/show_bug.cgi?id=53967
1114
1115         * Scripts/do-webcore-rename:
1116
1117 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
1118
1119         Reviewed by Dan Bernstein.
1120
1121         Add resource load client for injected bundle and move willSendRequest there
1122         https://bugs.webkit.org/show_bug.cgi?id=53972
1123
1124         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1125         (didCreatePage):
1126         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1127         (WTR::InjectedBundlePage::InjectedBundlePage):
1128         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1129         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1130         (WTR::InjectedBundlePage::didReceiveContentLengthForResource):
1131         (WTR::InjectedBundlePage::didFinishLoadForResource):
1132         (WTR::InjectedBundlePage::didFailLoadForResource):
1133         (WTR::InjectedBundlePage::willSendRequestForFrame):
1134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1135
1136 2011-02-07  Adam Barth  <abarth@webkit.org>
1137
1138         Add Leopard Debug back to the core builders.
1139
1140         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1141         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1142
1143 2011-02-07  Adam Klein  <adamk@chromium.org>
1144
1145         Reviewed by Jian Li.
1146
1147         [chromium] Remove deprecated method WebNotification::dir
1148         https://bugs.webkit.org/show_bug.cgi?id=53735
1149
1150         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1151         (NotificationPresenter::show):
1152
1153 2011-02-07  Adam Barth  <abarth@webkit.org>
1154
1155         Reviewed by Eric Seidel.
1156
1157         Remove Leopard Debug as a core builder
1158         https://bugs.webkit.org/show_bug.cgi?id=53971
1159
1160         The Leopard Debug builder has been failing to compile for several days.
1161         My understanding is that folks are working on fixing the build, but for
1162         the time being we should probably remove it from the list of core
1163         builders so that the core waterfall can be green.  We can certainly add
1164         it back once the build is fixed.
1165
1166         Also, I've removed the Tiger builders because those no longer appear to
1167         be attached to the buildbot master.
1168
1169         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1170         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1171
1172 2011-02-01  Ojan Vafai  <ojan@chromium.org>
1173
1174         Reviewed by Adam Roben.
1175
1176         include svn revisions in git diffs for the code review tool to use
1177         https://bugs.webkit.org/show_bug.cgi?id=53569
1178
1179         * Scripts/webkitpy/common/checkout/scm.py:
1180         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1181
1182 2011-02-03  MORITA Hajime  <morrita@google.com>
1183
1184         Reviewed by Darin Fisher.
1185
1186         [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
1187         https://bugs.webkit.org/show_bug.cgi?id=51013
1188
1189         Gave DRT implementation for requestTextCheck().
1190
1191         * DumpRenderTree/chromium/LayoutTestController.cpp:
1192         (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
1193         * DumpRenderTree/chromium/WebViewHost.cpp:
1194         (invokeFinishLastTextCheck): Added.
1195         (WebViewHost::requestTextCheck): Added.
1196         (WebViewHost::finishLastTextCheck): Added.
1197         * DumpRenderTree/chromium/WebViewHost.h:
1198
1199 2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>
1200
1201         Reviewed by Martin Robinson.
1202
1203         [Gtk] Implement layoutTestController.findString
1204         https://bugs.webkit.org/show_bug.cgi?id=50237
1205
1206         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1207         (LayoutTestController::findString):
1208
1209 2011-02-07  Chang Shu  <chang.shu@nokia.com>
1210
1211         Reviewed by Darin Adler.
1212
1213         We should disable spatial navigation explicitly during the initialization
1214         of DumpRenderTree.
1215         https://bugs.webkit.org/show_bug.cgi?id=53928
1216
1217         * DumpRenderTree/mac/DumpRenderTree.mm:
1218         (resetDefaultsToConsistentValues):
1219
1220 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
1221
1222         Not reviewed.
1223
1224         Fix WebKitTestRunner build on the SL bot.
1225
1226         * WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
1227         of ICU headers.
1228
1229 2011-02-07  Csaba Osztrogonác  <ossy@webkit.org>
1230
1231         Unreviewed.
1232
1233         [Qt][WK2] Buildfix after r77794.
1234
1235        WebKitTestRunner does not block remote resources or complain about them
1236        https://bugs.webkit.org/show_bug.cgi?id=42139
1237        <rdar://problem/8183942>
1238
1239         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.
1240
1241 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
1242
1243         Not reviewed.
1244
1245         More bot appeasement.
1246
1247         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1248
1249 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
1250
1251         Not reviewed.
1252
1253         Remove accidental references to directories on my laptop.
1254
1255         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1256
1257 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
1258
1259         Reviewed by Antti Koivisto.
1260
1261         WebKitTestRunner does not block remote resources or complain about them
1262         https://bugs.webkit.org/show_bug.cgi?id=42139
1263         <rdar://problem/8183942>
1264
1265         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1266         (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required
1267         checks (using KURL, to avoid need to invent a whole URL API).
1268         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore
1269         directly to get at KURL symbols.
1270
1271 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
1272
1273         Reviewed by Daniel Bates.
1274
1275         Add WebKit2 bot to list of expected builders in Python regression test results.
1276         https://bugs.webkit.org/show_bug.cgi?id=53905
1277
1278         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1279
1280 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
1281
1282         Reviewed by Ryosuke Niwa.
1283
1284         Update test expectations for new core builder
1285         https://bugs.webkit.org/show_bug.cgi?id=53904
1286
1287         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1288
1289 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
1290
1291         Reviewed by David Levin.
1292
1293         Add WebKit2 test bot to core builders
1294         https://bugs.webkit.org/show_bug.cgi?id=53901
1295
1296         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1297
1298 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
1299
1300         Another unreviewed Chromium build fix.
1301
1302         * DumpRenderTree/chromium/LayoutTestController.cpp:
1303         (LayoutTestController::pathToLocalResource):
1304
1305 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
1306
1307         Unreviewed Chromium build fix.
1308
1309         * DumpRenderTree/chromium/LayoutTestController.cpp:
1310         (LayoutTestController::pathToLocalResource):
1311
1312 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
1313
1314         Reviewed by Darin Adler.
1315
1316         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
1317         https://bugs.webkit.org/show_bug.cgi?id=52867
1318
1319         * DumpRenderTree/chromium/ImageDiff.cpp:
1320         (Image::craeteFromStdin): Call adoptArrayPtr.
1321
1322 2011-02-06  James Kozianski  <koz@chromium.org>
1323
1324         Reviewed by Ojan Vafai.
1325
1326         Add classes for representing test outputs.
1327         https://bugs.webkit.org/show_bug.cgi?id=52136
1328
1329         These classes will make it easier to write scripts that deal with test
1330         outputs such as rebaselining and deduping scripts. The intent is that
1331         eventually we will be have buildbot return TestOutputs for a
1332         particular build which can be compared with TestOutputs derived from a
1333         local LayoutTests directory.
1334
1335         * Scripts/webkitpy/common/net/testoutput.py: Added.
1336         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
1337         * Scripts/webkitpy/common/net/testoutputset.py: Added.
1338         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
1339         * Scripts/webkitpy/common/system/zip_mock.py: Added.
1340
1341 2011-02-06  Robert Hogan  <robert@webkit.org>
1342
1343         Reviewed by Andreas Kling.
1344
1345         [Qt] Clear page's groupName even when not in DRT
1346         https://bugs.webkit.org/show_bug.cgi?id=53874
1347
1348         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1349         (WebCore::DumpRenderTree::windowCloseRequested):
1350
1351 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
1352
1353         Reviewed by Andreas Kling.
1354
1355         [CMake] Add dependencies for Visual Studio projects
1356         https://bugs.webkit.org/show_bug.cgi?id=53773
1357
1358         Add a WebKit dependecy to WinCELauncher, so CMake can 
1359         generate the correct build order for the solution.
1360
1361         * CMakeListsWinCE.txt:
1362
1363 2011-02-06  Andreas Kling  <kling@webkit.org>
1364
1365         Reviewed by Antonio Gomes.
1366
1367         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
1368         https://bugs.webkit.org/show_bug.cgi?id=53869
1369
1370         * MiniBrowser/qt/BrowserView.cpp:
1371         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
1372         * MiniBrowser/qt/BrowserWindow.cpp:
1373         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
1374         * MiniBrowser/qt/BrowserWindow.h:
1375
1376 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
1377
1378         Reviewed by Dan Bernstein.
1379
1380         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
1381         https://bugs.webkit.org/show_bug.cgi?id=42690
1382         <rdar://problem/8213851>
1383
1384         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1385         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1386         (WTR::InjectedBundlePage::willSendRequestForFrame):
1387         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1388         (WTR::LayoutTestController::LayoutTestController):
1389         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1390         (WTR::LayoutTestController::willSendRequestReturnsNull):
1391         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
1392
1393 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1394
1395         Unreviewed, rolling out r77720.
1396         http://trac.webkit.org/changeset/77720
1397         https://bugs.webkit.org/show_bug.cgi?id=53854
1398
1399         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
1400         #webkit).
1401
1402         * Scripts/webkitpy/common/system/executive.py:
1403
1404 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1405
1406         Unreviewed, rolling out r77725.
1407         http://trac.webkit.org/changeset/77725
1408         https://bugs.webkit.org/show_bug.cgi?id=53844
1409
1410         It broke Qt minimal build (Requested by Ossy_ on #webkit).
1411
1412         * QtTestBrowser/launcherwindow.cpp:
1413         (LauncherWindow::createChrome):
1414         * QtTestBrowser/launcherwindow.h:
1415         (WindowOptions::WindowOptions):
1416         * QtTestBrowser/main.cpp:
1417         (LauncherApplication::handleUserOptions):
1418
1419 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
1420
1421         Reviewed by Adam Barth.
1422
1423         [GTK] plugins/plugin-document-back-forward.html fails
1424         https://bugs.webkit.org/show_bug.cgi?id=53833
1425
1426         Add the new "alert on load" functionality for the Unix version of the
1427         test plugin. This functionality was originally introduced in r77706.
1428
1429         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1430         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
1431
1432 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
1433
1434         Reviewed by Andreas Kling.
1435
1436         Local Storage settings can be enable/disable from "Develop" menu
1437         https://bugs.webkit.org/show_bug.cgi?id=52296
1438
1439         * QtTestBrowser/launcherwindow.cpp:
1440         (LauncherWindow::createChrome):
1441         (LauncherWindow::toggleLocalStorage):
1442         (LauncherWindow::toggleOfflineStorageDatabase):
1443         (LauncherWindow::toggleOfflineWebApplicationCache):
1444         (LauncherWindow::setOfflineStorageDefaultQuota):
1445         * QtTestBrowser/launcherwindow.h:
1446         (WindowOptions::WindowOptions):
1447         * QtTestBrowser/main.cpp:
1448         (LauncherApplication::handleUserOptions):
1449
1450 2011-02-04  Tony Chang  <tony@chromium.org>
1451
1452         Reviewed by Eric Seidel.
1453
1454         get test-webkitpy running on win32 python
1455         https://bugs.webkit.org/show_bug.cgi?id=53822
1456
1457         The test harness crashes with a WindowsError because it can't find
1458         'svn' when using subprocess.Popen.  This gets us past the error
1459         so we can see the failing tests on the Chromium Win Release Tests
1460         bot.
1461
1462         * Scripts/webkitpy/common/system/executive.py:
1463
1464 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
1465
1466         Reviewed by Gustavo Noronha Silva.
1467
1468         [GTK] fast/events/pagehide-timeout.html fails
1469         https://bugs.webkit.org/show_bug.cgi?id=53771
1470
1471         Add knowledge of the document browser cache model the DRT. When resetting
1472         WebKit settings to consistent values between tests, default to the document
1473         browser cache model.
1474
1475         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1476         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
1477         cache model between tests.
1478         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1479         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
1480         document browser cache model.
1481
1482 2011-02-04  Adam Barth  <abarth@webkit.org>
1483
1484         Reviewed by Eric Seidel.
1485
1486         PluginDocuments don't create widgets for plugins on back/forward
1487         https://bugs.webkit.org/show_bug.cgi?id=53474
1488
1489         Teach the test plugin how to call alert on load.
1490
1491         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1492         (NPP_New):
1493
1494 2011-02-04  Adam Roben  <aroben@apple.com>
1495
1496         Add a test case for encode/decode of FormData/FormDataElement
1497
1498         If the fix made in r77401 is broken, this new test will crash.
1499
1500         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
1501
1502         Reviewed by Sam Weinig.
1503
1504         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
1505         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
1506
1507         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
1508         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
1509         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
1510         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
1511         form, an return the session state data.
1512         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
1513         and restore it into another WKPage.
1514
1515         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
1516
1517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1518         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1519         * TestWebKitAPI/win/copy-resources.cmd:
1520         Added new files.
1521
1522 2011-02-04  Adam Roben  <aroben@apple.com>
1523
1524         Move code to run JavaScript tests into its own files
1525
1526         This will allow other tests to use this mechanism.
1527
1528         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
1529         world
1530
1531         Reviewed by Sam Weinig.
1532
1533         * TestWebKitAPI/JavaScriptTest.cpp: Added.
1534         * TestWebKitAPI/JavaScriptTest.h: Added.
1535         Moved code here...
1536
1537         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
1538
1539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1540         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1541         Added the new files.
1542
1543 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
1544
1545         Reviewed by Mihai Parparita.
1546
1547         merge test expectations for chromium, chromium-gpu. The
1548         chromium-gpu port will no longer maintain its own
1549         test expectations file.
1550
1551         Also add in a graphics_type() call on the port object to
1552         determine what graphics type to use in the test configuration,
1553         and log the configuration as a config setting.
1554
1555         https://bugs.webkit.org/show_bug.cgi?id=53562
1556
1557         * Scripts/webkitpy/layout_tests/port/base.py:
1558         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1559         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1560         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1561
1562 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
1563
1564         Reviewed by Pavel Feldman.
1565
1566         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
1567         https://bugs.webkit.org/show_bug.cgi?id=53781
1568
1569         * Scripts/check-inspector-strings:
1570
1571 2011-02-04  Adam Roben  <aroben@apple.com>
1572
1573         Include the crashing function in the link to a crash log on Mac
1574
1575         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
1576         function that crashed on Mac
1577
1578         Reviewed by David Kilzer.
1579
1580         * Scripts/old-run-webkit-tests:
1581         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
1582         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
1583         the crash log.
1584
1585 2011-02-04  Adam Roben  <aroben@apple.com>
1586
1587         Link to Mac crash logs from results.html
1588
1589         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
1590         results.html
1591
1592         Reviewed by David Kilzer.
1593
1594         * Scripts/old-run-webkit-tests:
1595         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
1596         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
1597
1598 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
1599
1600         Reviewed by Dan Bernstein.
1601
1602         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
1603         https://bugs.webkit.org/show_bug.cgi?id=52897
1604         <rdar://problem/8898294>
1605
1606         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1607         (WTR::InjectedBundlePage::InjectedBundlePage):
1608         (WTR::InjectedBundlePage::willSendRequestForFrame):
1609         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1610
1611 2011-02-03  Ivan Krstić  <ike@apple.com>
1612
1613         Unreviewed.
1614
1615         Adding myself to committers.py.
1616
1617         * Scripts/webkitpy/common/config/committers.py:
1618
1619 2011-02-03  James Kozianski  <koz@chromium.org>
1620
1621         Reviewed by Dimitri Glazkov.
1622
1623         Add navigator.registerProtocolHandler behind a flag.
1624         https://bugs.webkit.org/show_bug.cgi?id=52609
1625
1626         * Scripts/build-webkit:
1627
1628 2011-02-03  Hayato Ito  <hayato@chromium.org>
1629
1630         Reviewed by Eric Seidel.
1631
1632         [NRWT] Remove TestArgs class, which is wrongly used.
1633
1634         https://bugs.webkit.org/show_bug.cgi?id=53063
1635
1636         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1637         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1638         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1639         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1640         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1641         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1642
1643 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
1644
1645         Reviewed by Kenneth Russell.
1646
1647         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
1648         https://bugs.webkit.org/show_bug.cgi?id=53714
1649
1650         * Scripts/build-webkit: change --3d-canvas build option
1651           to set ENABLE_WEBGL
1652
1653 2011-02-03  Hayato Ito  <hayato@chromium.org>
1654
1655         Reviewed by Tony Chang.
1656
1657         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
1658         move _run_single_test() and _process_output() functions from
1659         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
1660
1661         This is clean up and acts as a preparation for elimination of test_types/*
1662         classes. These classes will move to the single_test_runner module introduced
1663         in this patch.
1664
1665         https://bugs.webkit.org/show_bug.cgi?id=53004
1666
1667         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1668         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
1669         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1670         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
1671         * Scripts/webkitpy/layout_tests/port/base.py:
1672         * Scripts/webkitpy/layout_tests/port/chromium.py:
1673         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1674         * Scripts/webkitpy/layout_tests/port/test.py:
1675         * Scripts/webkitpy/layout_tests/port/webkit.py:
1676         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1677         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1678         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1679
1680 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1681
1682         Unreviewed, build fix.
1683
1684         Delete a line that was accidentally missed in r77586; without it
1685         there is still a race between the two threads.
1686
1687         https://bugs.webkit.org/show_bug.cgi?id=51572
1688
1689         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1690
1691 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1692
1693         Reviewed by Tony Chang.
1694
1695         nrwt: handle "broken pipe" notifications from DRT more cleanly.
1696
1697         https://bugs.webkit.org/show_bug.cgi?id=52927
1698
1699         * Scripts/webkitpy/layout_tests/port/server_process.py:
1700         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1701
1702 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1703
1704         Reviewed by Kenneth Russell.
1705
1706         Update, resubmit change to bug 51572. I think the race that was
1707         fixed in r76703 caused the hang that caused us to roll this
1708         patch out before, so I'd like to try again.
1709
1710         https://bugs.webkit.org/show_bug.cgi?id=51572
1711
1712         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1713         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1714
1715 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
1716
1717         Unreviewed.
1718
1719         Adding myself to committers.py.
1720
1721         * Scripts/webkitpy/common/config/committers.py:
1722
1723 2011-02-03  Adam Roben  <aroben@apple.com>
1724
1725         Include the crashing function in the link to a crash log
1726
1727         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
1728         function that crashed
1729
1730         Reviewed by David Kilzer.
1731
1732         * Scripts/old-run-webkit-tests:
1733         (crashLocation): Added. Returns the location of the crash.
1734         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
1735         could be determined.
1736
1737 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1738
1739         Unreviewed, build fix.
1740
1741         Actually make the changes suggested by Mihai in his review
1742         of bug 53720 :(
1743
1744         https://bugs.webkit.org/show_bug.cgi?id=53720
1745
1746         * Scripts/webkitpy/layout_tests/port/test_files.py:
1747         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1748
1749 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1750
1751         Reviewed by Mihai Parparita.
1752
1753         new-run-webkit-tests: Fix bug introduced in r77434 that was
1754         causing us to run the canvas GPU tests on the Mac GPU port. This
1755         bug revealed that we were not setting the port.name() field
1756         properly in many cases, so I've cleaned up all of that code, and
1757         removed a few comments about "version-specific" GPU ports that
1758         don't exist and just confused things.
1759
1760         Testing also revealed that port.abspath_for_test() wasn't
1761         normalizing paths on Windows properly, so I fixed that as well.
1762
1763         https://bugs.webkit.org/show_bug.cgi?id=53719
1764
1765         * Scripts/webkitpy/layout_tests/port/base.py:
1766         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1767         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1768
1769 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
1770
1771         Reviewed by Mihai Parparita.
1772
1773         new-run-webkit-tests: fix normalization of paths on windows when gathering files
1774
1775         r77434 introduced a bug that was causing the test expectations
1776         for the GPU ports to not be treated properly. It turns out that
1777         when we gathered the list of test files on Windows, we would
1778         return paths of the form "c:\LayoutTests/fast/canvas", and the
1779         mixture of backslashes and forward slashes was confusing things.
1780
1781         This patch normalizes all of the filenames returned from
1782         test_files.find(), and adds better tests for this (fixing a
1783         couple of other bugs found in the meantime).
1784
1785         https://bugs.webkit.org/show_bug.cgi?id=53720
1786
1787         * Scripts/webkitpy/layout_tests/port/test.py:
1788         * Scripts/webkitpy/layout_tests/port/test_files.py:
1789         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1790
1791 2011-02-03  Adam Roben  <aroben@apple.com>
1792
1793         Add links to Windows crash logs in results.html
1794
1795         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
1796         results.html
1797
1798         Reviewed by David Kilzer.
1799
1800         * Scripts/old-run-webkit-tests:
1801         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
1802         createDebuggerCommandFile).
1803         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
1804         tool has exited.
1805         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
1806         it into the test results directory tree. Only implemented for Cygwin currently.
1807         (findNewestFileMatchingGlob): Added. Does what it says.
1808         (htmlForResultsSection): Only link to files that exist.
1809         (linksForErrorTest): Add a link to the crash log.
1810         (deleteExpectedAndActualResults): Delete any old crash log for this test.
1811         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
1812         hardcoding it here.
1813
1814 2011-02-03  Adam Roben  <aroben@apple.com>
1815
1816         Tell the debugger the path to the WebKit source tree when saving a crash log
1817
1818         This allows the debugger to include the crashing line of code in the log.
1819
1820         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
1821         of code
1822
1823         Reviewed by Sam Weinig.
1824
1825         * Scripts/old-run-webkit-tests:
1826         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
1827         file and returns the path to that file. The commands we pass came from
1828         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
1829         WebKit source code lives.
1830         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
1831         line using -c, save them to a file and specify the path to that file using -cf. This works
1832         around what is presumably a bug in Windows's command line parsing, where having multiple
1833         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
1834         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
1835         together to make them easier to modify in the future.
1836
1837 2011-02-02  Sam Weinig  <sam@webkit.org>
1838
1839         Reviewed by Anders Carlsson.
1840
1841         Add notification of the end of a rubber band.
1842         <rdar://problem/8940648>
1843
1844         * MiniBrowser/mac/BrowserWindowController.m:
1845         (-[BrowserWindowController awakeFromNib]):
1846         * WebKitTestRunner/TestController.cpp:
1847         (WTR::TestController::createOtherPage):
1848         (WTR::TestController::initialize):
1849         Stub out the new WKUIClient function.
1850
1851 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
1852
1853         Unreviewed.
1854
1855         Adding myself to committers.py.
1856
1857         * Scripts/webkitpy/common/config/committers.py:
1858
1859 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
1860
1861         Reviewed by Csaba Osztrogonác.
1862
1863         [Qt][WK2] MiniBrowser's window size should be 800x600
1864         https://bugs.webkit.org/show_bug.cgi?id=53670
1865
1866         Make layout test failure debugging easier.
1867         * MiniBrowser/qt/BrowserWindow.cpp:
1868         (BrowserWindow::BrowserWindow):
1869
1870 2011-02-02  Andy Estes  <aestes@apple.com>
1871
1872         Reviewed by Mark Rowe.
1873
1874         'update-webkit' should handle OpenSource and Internal using different
1875         VCSs.
1876
1877         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
1878         Internal directory.
1879
1880 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1881
1882         Reviewed by Mihai Parparita.
1883
1884         new-run-webkit-tests: hardcode the directories to scan for tests
1885         for GPU bots instead of SKIPping them. See bug 53562 for some
1886         context, but we will now hard-code the list of directories to
1887         use by default instead of skipping over directories in the
1888         expectations file. We do this so that we will be able to merge
1889         the expectations files without getting conflicting SKIP
1890         directives. Note that this change will reduce the # of tests
1891         being run on the Mac GPU bots, because we're accidentally
1892         including some today.
1893
1894         https://bugs.webkit.org/show_bug.cgi?id=53631
1895
1896         * Scripts/webkitpy/layout_tests/port/base.py:
1897         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1898         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1899
1900 2011-02-02  Sam Weinig  <sam@webkit.org>
1901
1902         Reviewed by Beth Dakin.
1903
1904         Add ChromeClient function to paint custom overhang areas.
1905         https://bugs.webkit.org/show_bug.cgi?id=53639
1906
1907         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1908         (WTR::InjectedBundlePage::InjectedBundlePage):
1909         Stub out new callback.
1910
1911 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1912
1913         Reviewed by Tony Chang.
1914
1915         new-run-webkit-tests: support chromium code paths in mock_drt
1916
1917         https://bugs.webkit.org/show_bug.cgi?id=53471
1918
1919         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1920         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1921
1922 2011-02-02  Adam Klein  <adamk@chromium.org>
1923
1924         Reviewed by Tony Chang.
1925
1926         Update new-run-webkit-tests --chromium to put output under Source/...
1927         https://bugs.webkit.org/show_bug.cgi?id=53612
1928
1929         * BuildSlaveSupport/test-result-archive:
1930         * Scripts/webkitpy/layout_tests/port/chromium.py:
1931
1932 2011-01-28  Tony Chang  <tony@chromium.org>
1933
1934         Reviewed by Eric Seidel.
1935
1936         [chromium] remove --use-test-shell from NRWT
1937         https://bugs.webkit.org/show_bug.cgi?id=53346
1938
1939         I've already started removing some of the bindings like eventSender so
1940         this already doesn't work isn't useful.  Also updated some comments to
1941         refer to DRT instead of test_shell.
1942
1943         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1944         * Scripts/webkitpy/layout_tests/port/chromium.py:
1945         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1946         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1947         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1948         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1949         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1950         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1951
1952 2011-02-02  Steve Lacey  <sjl@chromium.org>
1953
1954         Reviewed by Eric Carlson.
1955
1956         Implement basic media statistics on media elements.
1957         https://bugs.webkit.org/show_bug.cgi?id=53322
1958
1959         * Scripts/build-webkit:
1960
1961 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
1962
1963         [wx] Build fixes for wxWebKit.
1964
1965         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1966         (LayoutTestController::setSerializeHTTPLoads):
1967         * wx/browser/wscript:
1968         * wx/build/build_utils.py:
1969         * wx/build/settings.py:
1970
1971 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1972
1973         Reviewed by Mihai Parparita.
1974
1975         new-run-webkit-tests: stop skipping so many tests
1976
1977         r77163 introduced a regression where we weren't resetting test
1978         expectations properly and were skipping too many tests as a
1979         result. This patch fixes that and adds a test for it.
1980
1981         https://bugs.webkit.org/show_bug.cgi?id=53551
1982
1983         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1984         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1985
1986 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1987
1988         Reviewed by Tony Chang.
1989
1990         new-run-webkit-tests: add first stub of test_runner2. This
1991         will add support for the 'inline', 'threads', and 'processes'
1992         flags to --worker-model, but for now the implementatios just
1993         fall back on the old ones.
1994
1995         https://bugs.webkit.org/show_bug.cgi?id=53157
1996
1997         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1998         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1999
2000 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
2001
2002         Reviewed by James Robinson.
2003
2004         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
2005         https://bugs.webkit.org/show_bug.cgi?id=53522
2006
2007         * Scripts/run-chromium-webkit-unit-tests:
2008
2009 2011-02-01  Adam Barth  <abarth@webkit.org>
2010
2011         Reviewed by Mihai Parparita.
2012
2013         Using Control-C to cancel webkit-patch or other python tools causes
2014         unpleasant traceback console spew
2015         https://bugs.webkit.org/show_bug.cgi?id=53462
2016
2017         Catch the exception and don't print the stack trace.
2018
2019         * Scripts/webkit-patch:
2020
2021 2011-02-01  Scott Cameron  <sccameron@rim.com>
2022
2023         Reviewed by Daniel Bates.
2024
2025         Use Windows format for MinGW HTTPD path.
2026         https://bugs.webkit.org/show_bug.cgi?id=53503
2027
2028         * Scripts/webkitperl/httpd.pm:
2029           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
2030             so that we don't have to escape the space characters in the path. Also,
2031             changed path to Windows-style path and removed FIXME comment.
2032
2033 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
2034
2035         Reviewed by Andreas Kling.
2036
2037         [Qt][WK2] Add a way to use shared process model in MiniBrowser
2038         https://bugs.webkit.org/show_bug.cgi?id=53090
2039
2040         * MiniBrowser/qt/BrowserView.cpp:
2041         (BrowserView::BrowserView): Removed the m_context member.
2042         From now the context is guaranteed to be non-null and we
2043         don't need to store that in the object.
2044         * MiniBrowser/qt/BrowserView.h:
2045         * MiniBrowser/qt/BrowserWindow.cpp:
2046         Added static bool to determine that new windows need to be
2047         created with their own context or not. Use the same context
2048         and web process by default to be inilne with the other ports.
2049         (BrowserWindow::BrowserWindow):
2050         (BrowserWindow::newWindow):
2051         * MiniBrowser/qt/BrowserWindow.h:
2052         * MiniBrowser/qt/main.cpp:
2053         (main): Added command line switch to be able to use the
2054         non-shared process model. Simplify the handling of the command line
2055         switches a little bit.
2056
2057 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
2058
2059         Reviewed by Andreas Kling.
2060
2061         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
2062         https://bugs.webkit.org/show_bug.cgi?id=53491
2063
2064         * MiniBrowser/qt/BrowserWindow.cpp:
2065         (BrowserWindow::BrowserWindow):
2066         (BrowserWindow::toggleFullScreenMode):
2067         * MiniBrowser/qt/BrowserWindow.h:
2068
2069 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
2070
2071         Reviewed by Andreas Kling.
2072
2073         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
2074         https://bugs.webkit.org/show_bug.cgi?id=53489
2075
2076         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
2077         to Settings menu.
2078
2079         * MiniBrowser/qt/BrowserWindow.cpp:
2080         (BrowserWindow::BrowserWindow):
2081         (BrowserWindow::toggleFrameFlattening):
2082         (BrowserWindow::toggleDisableJavaScript):
2083         (BrowserWindow::toggleAutoLoadImages):
2084         * MiniBrowser/qt/BrowserWindow.h:
2085
2086 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
2087
2088         Reviewed by Tony Chang.
2089
2090         [Chromium] Switch chromium-mac to use ChromiumDriver
2091         https://bugs.webkit.org/show_bug.cgi?id=53461
2092         
2093         For the sake of consistency with the other Chromium platforms (and so
2094         that chromium-mac picks up special flags like --enable-hardware-gpu),
2095         switch chromium-mac from the WebKitDriver to ChromiumDriver.
2096
2097         * Scripts/webkitpy/layout_tests/port/chromium.py:
2098
2099 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
2100
2101         Reviewed by Mihai Parparita.
2102
2103         The current modifier parsing code in test_expectations is
2104         fragile and hard-coded, so it's not easy to understand the logic
2105         or easily add new types of modifiers (like GPU vs. CPU testing
2106         for graphics tests, or 32-bit vs. 64-bit differences).
2107
2108         This is the first of two patches that will add in more generic
2109         support and then eliminate the GPU-specific test expectations
2110         files for Chromium.
2111
2112         This patch adds two standalone objects for handling modifiers. The
2113         rules for interpreting modifiers, precedence, and conflicts are
2114         given in the docstring to the ModifierMatcher class, which
2115         returns ModifierMatchResult objects.
2116         
2117         This patch also adds routines to the Port interface and a
2118         default set of values in the base object, in order to obtain the
2119         values needed on a given test run. These values are then passed
2120         to the expectation parser. This also allows us to clean up the
2121         logic used to lint all of the different configurations in a
2122         single test_expectations.txt file.
2123
2124         The next patch will merge in the separate GPU expectations file.
2125
2126         https://bugs.webkit.org/show_bug.cgi?id=51222
2127
2128         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2129         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2130         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2131         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2132         * Scripts/webkitpy/layout_tests/port/base.py:
2133         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2134         * Scripts/webkitpy/layout_tests/port/chromium.py:
2135         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2136         * Scripts/webkitpy/layout_tests/port/test.py:
2137         * Scripts/webkitpy/layout_tests/port/webkit.py:
2138         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2139         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2140         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2141         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
2142         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2143
2144 2011-01-31  Scott Cameron  <sccameron@rim.com>
2145
2146         Reviewed by Daniel Bates.
2147
2148         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
2149         https://bugs.webkit.org/show_bug.cgi?id=50036
2150
2151         This will add an Apache2.2 configuration file and modifies scripts to allow
2152         running an httpd server in an MSYS environment.
2153
2154         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
2155         in order to allow for simple installation/execution.  Simply install the latest
2156         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
2157         be able to execute run-webkit-httpd.
2158         
2159
2160         * Scripts/run-webkit-httpd:
2161         * Scripts/webkitperl/httpd.pm:
2162
2163 2011-01-31  Tony Chang  <tony@chromium.org>
2164
2165         Reviewed by Eric Seidel.
2166
2167         mac DRT should report RTL scroll offset relative to top right corner
2168         https://bugs.webkit.org/show_bug.cgi?id=53324
2169
2170         * DumpRenderTree/mac/DumpRenderTree.mm:
2171         (dumpFrameScrollPosition):
2172
2173 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
2174
2175         Reviewed by Andreas Kling.
2176
2177         [Qt] Add Take Screen Shot action to MiniBrowser
2178         https://bugs.webkit.org/show_bug.cgi?id=53422
2179
2180         Add Take Screen Shot action to MiniBrowser's view menu.
2181
2182         * MiniBrowser/qt/BrowserWindow.cpp:
2183         (BrowserWindow::BrowserWindow):
2184         (BrowserWindow::screenshot):
2185         * MiniBrowser/qt/BrowserWindow.h:
2186
2187 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2188
2189         Reviewed by Xan Lopez.
2190
2191         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
2192         https://bugs.webkit.org/show_bug.cgi?id=53379
2193
2194         Remove left over #ifdef's. I thought all of the conditional code
2195         had been freed from the condition, but I forgot to check DRT.
2196
2197         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2198         (resetDefaultsToConsistentValues):
2199         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2200         (LayoutTestController::setAlwaysAcceptCookies):
2201
2202 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
2203
2204         Unreviewed, build fix.
2205
2206         Fix regression introduced in r77093 - path.rsplit() doesn't
2207         take keyword arguments.
2208
2209         https://bugs.webkit.org/show_bug.cgi?id=53326
2210
2211         * Scripts/webkitpy/common/system/filesystem_mock.py:
2212
2213 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
2214
2215         Reviewed by Mihai Parparita.
2216
2217         Add more unit tests for rebaseline-chromium-webkit-tests. This
2218         change involves restructuring a bunch of r-c-w-t code to make it
2219         more testable as well. We also add wrapper classes for handling
2220         testing zip files and fetching URLs.
2221
2222         https://bugs.webkit.org/show_bug.cgi?id=53040
2223
2224         * Scripts/webkitpy/common/system/urlfetcher.py:
2225         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
2226         * Scripts/webkitpy/common/system/zipfileset_mock.py:
2227         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2228         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2229         * Scripts/webkitpy/tool/mocktool.py:
2230
2231 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
2232
2233         Reviewed by Eric Seidel.
2234
2235         Clean up of the filesystem-related modules used in webkitpy.
2236         I've added relpath() to the filesystem interface, modified
2237         ospath.relpath() so that it could work with the filesystem
2238         interface, and modified the fileset* routines to use the
2239         filesystem interface consistently.
2240
2241         This patch also adds a close() routine to the fileset routines
2242         to indicate that the caller is done with the fileset. This
2243         allows zipfileset to clean up after itself when it creates
2244         tempfiles to store downloads.
2245
2246         https://bugs.webkit.org/show_bug.cgi?id=53326
2247
2248         * Scripts/webkitpy/common/system/directoryfileset.py:
2249         * Scripts/webkitpy/common/system/fileset.py:
2250         * Scripts/webkitpy/common/system/filesystem.py:
2251         * Scripts/webkitpy/common/system/filesystem_mock.py:
2252         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2253         * Scripts/webkitpy/common/system/ospath.py:
2254         * Scripts/webkitpy/common/system/zipfileset.py:
2255         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2256
2257 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
2258
2259         Reviewed by Csaba Osztrogonác.
2260
2261         [Qt][WK2]REGRESSION (r76991): Fix build errors
2262         https://bugs.webkit.org/show_bug.cgi?id=53400
2263
2264         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
2265         and remove WebKit2Prefix.h from the build.
2266         * MiniBrowser/qt/MiniBrowser.pro:
2267
2268 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
2269
2270         Unreviewed.
2271
2272         [Qt][WK2] Buildfix.
2273
2274         * MiniBrowser/qt/MiniBrowser.pro:
2275
2276 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
2277
2278         Reviewed by Adam Roben.
2279         
2280         define NOMINMAX when building ImageDiff, as we do elsewhere.
2281
2282         Add various clampToInt() methods to MathExtras.h
2283         https://bugs.webkit.org/show_bug.cgi?id=52910
2284
2285         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2286
2287 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
2288
2289         Reviewed by Darin Adler.
2290
2291         WebKitTestRunner needs layoutTestController.setPOSIXLocale
2292         https://bugs.webkit.org/show_bug.cgi?id=42682
2293
2294         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2295         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2296         (WTR::InjectedBundle::resetLocalSettings):
2297         (WTR::InjectedBundle::didReceiveMessage):
2298         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2299         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2300         (WTR::LayoutTestController::setPOSIXLocale):
2301         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2302
2303 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2304  
2305          Reviewed by Mihai Parparita.
2306  
2307          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
2308  
2309          This patch re-enables this test and changes it to
2310          handle all of the mac platform versions, not just the one
2311          it is running on.
2312  
2313          https://bugs.webkit.org/show_bug.cgi?id=53356
2314  
2315          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2316  
2317 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2318
2319         Unreviewed, build fix.
2320
2321         Take two. The fix in 77023 didn't work, because we were
2322         still calling path.abspath_to_uri, which calls _cygpath under
2323         the covers, and it appears the cygpath on the bots does
2324         something different than it does on my machine. This patch
2325         removes the calls to path.abspath_to_uri, so it should be safe.
2326         If it doesn't work, I'll roll it out along with r76982 and 77023.
2327
2328         https://bugs.webkit.org/show_bug.cgi?id=53126
2329
2330         * Scripts/webkitpy/layout_tests/port/test.py:
2331
2332 2011-01-28  David Kilzer  <ddkilzer@apple.com>
2333
2334         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
2335         <http://webkit.org/b/53353>
2336
2337         Reviewed by Mark Rowe.
2338
2339         * Scripts/webkitdirs.pm:
2340         (checkRequiredSystemConfig): Check the Xcode marketing version
2341         in addition to the DevCoreTools build version before complaining
2342         about an old version of Xcode.  Also make the Mac OS X version
2343         check use Perl's built-in version string comparitor.
2344
2345 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2346
2347         Unreviewed, build fix.
2348
2349         Work around breakage on Win 7 Release bot caused by r76982
2350         and the fact that windows ports use "file:////" instead of
2351         "file:///". Ideally the test code should be isolated from
2352         this, but it isn't yet. Will fix properly in a bit.
2353
2354         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2355
2356 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2357
2358         Reviewed by Tony Chang.
2359
2360         new-run-webkit-tests: change worker model values to
2361         "old-inline", "old-threads" in preparation for test_runner2 /
2362         multiprocessing changes.
2363
2364         https://bugs.webkit.org/show_bug.cgi?id=53156
2365
2366         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2367         * Scripts/webkitpy/layout_tests/port/base.py:
2368         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2369         * Scripts/webkitpy/layout_tests/port/mac.py:
2370         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2371
2372 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2373
2374         Reviewed by Tony Chang.
2375
2376         committers.py - add an IRC nickname for dpranke
2377         https://bugs.webkit.org/show_bug.cgi?id=53335
2378
2379         * Scripts/webkitpy/common/config/committers.py:
2380
2381 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2382
2383         Reviewed by Tony Chang.
2384
2385         new-run-webkit-tests: add a "mock DRT" port implementation
2386         and a separate class that emulates what we expect the
2387         DumpRenderTree behavior to be.
2388
2389         This will eventually replace port/dryrun.py and allow us to get
2390         better test coverage of the new-run-webkit-tests code as well as
2391         a reference for what new-run-webkit-tests expects from DRT.
2392
2393         This is the first attempt at this, and it is pretty bare-boned. It
2394         really only has been tested on the 'mac' port (and a little on
2395         the 'chromium-mac' port.
2396
2397         https://bugs.webkit.org/show_bug.cgi?id=53126
2398
2399         * Scripts/webkitpy/common/system/filesystem_mock.py:
2400         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2401         * Scripts/webkitpy/layout_tests/port/factory.py:
2402         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
2403         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
2404         * Scripts/webkitpy/layout_tests/port/test.py:
2405
2406 2011-01-28  Pratik Solanki  <psolanki@apple.com>
2407
2408         Unreviewed. Removing .swp file checked in by mistake.
2409
2410         * Scripts/.webkitdirs.pm.swp: Removed.
2411
2412 2011-01-28  Pratik Solanki  <psolanki@apple.com>
2413
2414         Reviewed by David Kilzer.
2415
2416         Space not necessary for undefined feature
2417         https://bugs.webkit.org/show_bug.cgi?id=53317
2418
2419         * Scripts/build-webkit:
2420
2421 2011-01-28  Chang Shu  <chang.shu@nokia.com>
2422
2423         Reviewed by Andreas Kling.
2424
2425         Reset NetworkAccessManager to clean up credentials from previous tests.
2426         This change causes no performance overhead either.
2427         https://bugs.webkit.org/show_bug.cgi?id=36688
2428
2429         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2430         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2431         (WebCore::DumpRenderTree::open):
2432         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2433
2434 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
2435
2436         Reviewed by Andreas Kling.
2437
2438         [Qt] Add Zoom Text Only action to MiniBrowser
2439         https://bugs.webkit.org/show_bug.cgi?id=53297
2440
2441         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
2442
2443         * MiniBrowser/qt/BrowserWindow.cpp:
2444         (BrowserWindow::BrowserWindow):
2445         (BrowserWindow::zoomIn):
2446         (BrowserWindow::zoomOut):
2447         (BrowserWindow::resetZoom):
2448         (BrowserWindow::toggleZoomTextOnly):
2449         (BrowserWindow::applyZoom):
2450         * MiniBrowser/qt/BrowserWindow.h:
2451
2452 2011-01-28  Adam Barth  <abarth@webkit.org>
2453
2454         Reviewed by Eric Seidel.
2455
2456         Add webkit-patch roll-chromium-deps
2457         https://bugs.webkit.org/show_bug.cgi?id=53288
2458
2459         This command updates the Source/WebKit/chromium/DEPS file with the
2460         last-known good revision of Chromium (or a revision specified on the
2461         command line).  I'd eventually like to turn this into a SheriffBot
2462         command, but this is the first step.
2463
2464         This patch somewhat sprawled because I needed to move a bunch of code
2465         out of ChangeLog that should never have been there in the first place.
2466         Also, I had to fix a bug in MockUser in order to test the new command.
2467
2468         * Scripts/webkitpy/common/checkout/api.py:
2469         * Scripts/webkitpy/common/checkout/changelog.py:
2470         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2471         * Scripts/webkitpy/common/checkout/deps.py: Added.
2472         * Scripts/webkitpy/common/config/urls.py:
2473         * Scripts/webkitpy/tool/commands/__init__.py:
2474         * Scripts/webkitpy/tool/commands/download_unittest.py:
2475         * Scripts/webkitpy/tool/commands/roll.py: Added.
2476         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
2477         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2478         * Scripts/webkitpy/tool/mocktool.py:
2479         * Scripts/webkitpy/tool/steps/__init__.py:
2480         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
2481         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2482         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
2483         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2484         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
2485         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2486
2487 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
2488
2489         Reviewed by Laszlo Gombos.
2490
2491         Get rid of prefix header dependency for WebKit2 build system
2492         https://bugs.webkit.org/show_bug.cgi?id=50174
2493
2494         Change the style checker so that it enforces config.h include for
2495         WebKit2.
2496
2497         * Scripts/webkitpy/style/checker.py:
2498
2499 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
2500
2501         Reviewed by Darin Adler.
2502
2503         execCommand("Paste") doesn't work in WebKitTestRunner
2504         https://bugs.webkit.org/show_bug.cgi?id=52785
2505
2506         Enable both of the settings needed to allow paste.
2507         
2508         * WebKitTestRunner/TestController.cpp:
2509         (WTR::TestController::resetStateToConsistentValues):
2510
2511 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
2512
2513         Reviewed by Andreas Kling.
2514
2515         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
2516         https://bugs.webkit.org/show_bug.cgi?id=48440
2517
2518         Preserve user input when toggling use of QGraphicsView
2519
2520         * QtTestBrowser/launcherwindow.cpp:
2521         (LauncherWindow::initializeView):
2522         (LauncherWindow::loadFinished):
2523         * QtTestBrowser/launcherwindow.h:
2524         * QtTestBrowser/mainwindow.cpp:
2525         (MainWindow::addressUrl):
2526         * QtTestBrowser/mainwindow.h:
2527
2528 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
2529
2530         Reviewed by Mihai Parparita.
2531
2532         new-run-webkit-tests: turn off pixel tests correctly by default
2533         for webkit-based ports. r70013 (bug 47510) used
2534         port.set_option_default() to attempt to set default values, but
2535         that didn't work correctly. I have removed set_option_default
2536         for now since it was only being used in two places and in three
2537         useless unit tests. There is a separate bug open to fix the
2538         option parsing (48095), so this workaround is fine for now.
2539
2540         https://bugs.webkit.org/show_bug.cgi?id=53217
2541
2542         * Scripts/webkitpy/layout_tests/port/webkit.py:
2543         * Scripts/webkitpy/layout_tests/port/base.py:
2544         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2545
2546 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
2547
2548         Rubber-stamped by Ariya Hidayat.
2549
2550         Trivial crash fix in WTR.
2551
2552         * WebKitTestRunner/TestController.cpp:
2553         (WTR::TestController::initialize): Increase the size
2554         of the vector by one to be able to store the null character.
2555
2556 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
2557
2558         Reviewed by Csaba Osztrogonác.
2559
2560         [Qt][WK2] WTR should be initialized in the same way as DRT
2561         https://bugs.webkit.org/show_bug.cgi?id=53240
2562
2563         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2564         (WTR::activateFonts): Added missing initialization steps.
2565
2566 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
2567
2568         Unreviewed. 
2569
2570         Adding myself to committers.py.
2571
2572         * Scripts/webkitpy/common/config/committers.py:
2573
2574 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2575
2576         Reviewed by Csaba Osztrogonác.
2577
2578         [Qt] [Symbian] Move project files into Source
2579         https://bugs.webkit.org/show_bug.cgi?id=52891
2580
2581         Fix the Symbian build after the project files
2582         are moved to Source directory. On Symbian qmake
2583         needs to run in the same directory where the main
2584         pro files (WebKit.pro, Tools.pro) are located.
2585
2586         * Scripts/webkitdirs.pm: Change to the directory where the pro file
2587         is located before running qmake for Symbian. Qmake on Symbian
2588         does not properly honor the "-o" option, work it around by setting
2589         the name of the Makefile to bld.inf.
2590
2591 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
2592
2593         Reviewed by Andreas Kling.
2594
2595         [Qt] Add simple zooming features to MiniBrowser
2596         https://bugs.webkit.org/show_bug.cgi?id=53231
2597
2598         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
2599
2600         * MiniBrowser/qt/BrowserWindow.cpp:
2601         (BrowserWindow::BrowserWindow):
2602         (BrowserWindow::zoomIn):
2603         (BrowserWindow::zoomOut):
2604         (BrowserWindow::resetZoom):
2605         (BrowserWindow::updateUserAgentList):
2606         (BrowserWindow::applyZoom):
2607         * MiniBrowser/qt/BrowserWindow.h:
2608
2609 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
2610
2611         Reviewed by Dan Bernstein.
2612
2613         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
2614         https://bugs.webkit.org/show_bug.cgi?id=42319
2615         
2616         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
2617
2618         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2619         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2620         (WTR::LayoutTestController::showWebInspector):
2621         (WTR::LayoutTestController::closeWebInspector):
2622         (WTR::LayoutTestController::evaluateInWebInspector):
2623         (WTR::LayoutTestController::setTimelineProfilingEnabled):
2624         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2625         * WebKitTestRunner/TestInvocation.cpp:
2626         (WTR::shouldOpenWebInspector):
2627         (WTR::TestInvocation::invoke):
2628         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2629
2630 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
2631
2632         Reviewed by Xan Lopez.
2633
2634         [GTK] Pixel dumps do not include scrollbars in output images
2635         https://bugs.webkit.org/show_bug.cgi?id=53216
2636
2637         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
2638         that have scrollbars.
2639
2640         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2641         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
2642         instead of the web view itself.
2643
2644 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
2645
2646         Reviewed by Mihai Parparita.
2647
2648         Fix regression introduced in r76322 ... new-run-webkit-tests
2649         was attempting to save the image diff output as a UTF-8-encoded
2650         file.
2651
2652         https://bugs.webkit.org/show_bug.cgi?id=53210
2653
2654         * Scripts/webkitpy/layout_tests/port/webkit.py:
2655
2656 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2657
2658         Unreviewed, rolling out r76709.
2659         http://trac.webkit.org/changeset/76709
2660         https://bugs.webkit.org/show_bug.cgi?id=53194
2661
2662         "broke python tests on non-snowleopard platforms" (Requested
2663         by dpranke on #webkit).
2664
2665         * Scripts/webkitpy/layout_tests/port/factory.py:
2666         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
2667         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
2668
2669 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
2670
2671         Reviewed by Tony Chang.
2672
2673         new-run-webkit-tests: add a "mock DRT" port implementation
2674         and a separate class that emulates what we expect the
2675         DumpRenderTree behavior to be.
2676
2677         This will eventually replace port/dryrun.py and allow us to get
2678         better test coverage of the new-run-webkit-tests code as well as
2679         a reference for what new-run-webkit-tests expects from DRT.
2680
2681         This is the first attempt at this, and it is pretty bare-boned. It
2682         really only has been tested on the 'mac' port (and a little on
2683         the 'chromium-mac' port.
2684
2685         https://bugs.webkit.org/show_bug.cgi?id=53126
2686
2687         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
2688         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
2689         * Scripts/webkitpy/layout_tests/port/factory.py:
2690
2691 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
2692
2693         Reviewed by Tony Chang.
2694
2695         Add '--no-timeout' option to Chromium DRT to ease debugging.
2696         https://bugs.webkit.org/show_bug.cgi?id=52873
2697
2698         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2699         (main):
2700
2701 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2702
2703         Reviewed by Andreas Kling.
2704
2705         [Qt] Fix qt_minimal build
2706         https://bugs.webkit.org/show_bug.cgi?id=53172
2707
2708         * QtTestBrowser/locationedit.h:
2709
2710 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
2711
2712         Reviewed by Antonio Gomes.
2713
2714         QtTestBrowser should have a UI Setting to disable plugins
2715         https://bugs.webkit.org/show_bug.cgi?id=52408
2716         
2717         Added a new action item named "Disable Plugins"
2718         under the "Settings" menu. 
2719
2720         * QtTestBrowser/launcherwindow.cpp:
2721         (LauncherWindow::createChrome):
2722         (LauncherWindow::togglePlugins):
2723         * QtTestBrowser/launcherwindow.h:
2724
2725 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
2726
2727         Reviewed by Adam Barth.
2728
2729         Move main CMakeLists.txt into Source directory
2730         https://bugs.webkit.org/show_bug.cgi?id=52888
2731
2732         * Scripts/webkitdirs.pm:
2733
2734 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
2735
2736         Reviewed by Eric Seidel.
2737
2738         Improve label text in submit-to-ews
2739         https://bugs.webkit.org/show_bug.cgi?id=53130
2740
2741         * QueueStatusServer/templates/submittoews.html:
2742
2743 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
2744
2745         Reviewed by Antonio Gomes.
2746
2747         QtTestBrowser should have a UI Settings to prevent loading images
2748         https://bugs.webkit.org/show_bug.cgi?id=52409
2749         
2750         Added a new action item named "DisableAutoLoadImages"
2751         under the "Settings" menu 
2752
2753         * QtTestBrowser/launcherwindow.cpp:
2754         (LauncherWindow::createChrome):
2755         (LauncherWindow::toggleAutoLoadImages):
2756         * QtTestBrowser/launcherwindow.h:
2757
2758 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
2759
2760         Reviewed by Tony Chang.
2761
2762         Minor bug fixes and cleanup for filesystem wrappers, port/* test
2763         classes, test_expectations.py. This change adds "test-win" and
2764         "test-mac" variants to the test port so that we can better test
2765         rebaselining, and adds a MockUser() object for reuse in testing.
2766
2767         https://bugs.webkit.org/show_bug.cgi?id=53036
2768
2769         * Scripts/webkitpy/common/system/filesystem.py:
2770         * Scripts/webkitpy/common/system/filesystem_mock.py:
2771         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2772         * Scripts/webkitpy/layout_tests/port/factory.py:
2773         * Scripts/webkitpy/layout_tests/port/base.py:
2774         * Scripts/webkitpy/layout_tests/port/test.py:
2775         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2776         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2777         * Scripts/webkitpy/tool/mocktool.py:
2778
2779 2011-01-25  Tony Chang  <tony@chromium.org>
2780
2781         Reviewed by Dimitri Glazkov.
2782
2783         [chromium] remove unused layoutTestController callback
2784         https://bugs.webkit.org/show_bug.cgi?id=53103
2785
2786         This method is used by a test_shell_test, but not needed by DRT.
2787
2788         * DumpRenderTree/chromium/LayoutTestController.cpp:
2789         (LayoutTestController::LayoutTestController):
2790         * DumpRenderTree/chromium/LayoutTestController.h:
2791
2792 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2793
2794         Reviewed by Andreas Kling.
2795
2796         [GTK] Remove 64 bits release bot from the buildbot master
2797         https://bugs.webkit.org/show_bug.cgi?id=52899
2798
2799         Removes the 64 bits release slave from the buildbot configuration,
2800         so that we can use it as an EWS.
2801
2802         * BuildSlaveSupport/build.webkit.org-config/config.json:
2803
2804 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2805
2806         Reviewed by Dan Bernstein.
2807
2808         Implement database quota callback to fix storage tests on WebKit2 bot
2809         https://bugs.webkit.org/show_bug.cgi?id=53064
2810
2811         * WebKitTestRunner/TestController.cpp:
2812         (WTR::exceededDatabaseQuota):
2813         (WTR::TestController::createOtherPage):
2814         (WTR::TestController::initialize):
2815
2816 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2817
2818         Reviewed by Anders Carlsson.
2819
2820         Use designated temp directory for the database for WebKit2
2821         https://bugs.webkit.org/show_bug.cgi?id=53052
2822         
2823         Adopt the new WK2 API for this.
2824
2825         * WebKitTestRunner/TestController.cpp:
2826         (WTR::TestController::libraryPathForTesting):
2827         (WTR::TestController::initialize):
2828         * WebKitTestRunner/TestController.h:
2829         * WebKitTestRunner/mac/TestControllerMac.mm:
2830         (WTR::TestController::platformLibraryPathForTesting):
2831         * WebKitTestRunner/qt/TestControllerQt.cpp:
2832         (WTR::TestController::platformLibraryPathForTesting):
2833         * WebKitTestRunner/win/TestControllerWin.cpp:
2834         (WTR::TestController::platformLibraryPathForTesting):
2835
2836 2011-01-24  Lucas Forschler  <lforschler@apple.com>
2837
2838         Reviewed by Stephanie Lewis.
2839
2840         Add a new Leopard test bot.
2841
2842         * BuildSlaveSupport/build.webkit.org-config/config.json:
2843
2844 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2845
2846         Reviewed by Adam Barth.
2847
2848         Add EFL Builder to core waterfall
2849         https://bugs.webkit.org/show_bug.cgi?id=52704
2850
2851         Add EFL Builder to the core waterfall again.
2852
2853         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2854         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2855
2856 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
2857
2858         Reviewed by Tony Chang.
2859
2860         new-run-webkit-tests fails to start HTTP server if there are proxy settings
2861         https://bugs.webkit.org/show_bug.cgi?id=52872
2862
2863         Force disabling proxy to resolve the problem.
2864
2865         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2866         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2867
2868 2011-01-24  Andreas Kling  <kling@webkit.org>
2869
2870         Reviewed by Darin Adler.
2871
2872         check-webkit-style: Update exemptions following Source/ move.
2873         https://bugs.webkit.org/show_bug.cgi?id=53017
2874
2875         * Scripts/webkitpy/style/checker.py:
2876         * Scripts/webkitpy/style/checker_unittest.py:
2877
2878 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2879
2880         Rubber-stamped by Csaba Osztrogonác.
2881
2882         [Qt] Move project files into Source
2883         https://bugs.webkit.org/show_bug.cgi?id=52891
2884
2885         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
2886
2887 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
2888
2889         Reviewed by Yury Semikhatsky.
2890
2891         Web Inspector: Find duplicate strings in localizedStrings.js
2892
2893         https://bugs.webkit.org/show_bug.cgi?id=53005
2894
2895         * Scripts/check-inspector-strings:
2896
2897 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
2898
2899         Reviewed by Andreas Kling.
2900
2901         [Qt] Regroup MiniBrowser's menubar and add open file action
2902         https://bugs.webkit.org/show_bug.cgi?id=53000
2903
2904         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
2905
2906         * MiniBrowser/qt/BrowserWindow.cpp:
2907         (BrowserWindow::BrowserWindow):
2908         (BrowserWindow::openFile):
2909         (BrowserWindow::~BrowserWindow):
2910         * MiniBrowser/qt/BrowserWindow.h:
2911
2912 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
2913
2914         Unreviewed fix after r76496
2915
2916         [Qt] Move project files into Source
2917         https://bugs.webkit.org/show_bug.cgi?id=52891
2918
2919         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
2920         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
2921         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
2922
2923 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2924
2925         Reviewed by Csaba Osztrogonác.
2926
2927         [Qt] Move project files into Source
2928         https://bugs.webkit.org/show_bug.cgi?id=52891
2929
2930         * DerivedSources.pro: Renamed from DerivedSources.pro.
2931         * DumpRenderTree/qt/DumpRenderTree.pro:
2932         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2933         * MiniBrowser/DerivedSources.pro:
2934         * MiniBrowser/qt/MiniBrowser.pro:
2935         * QtTestBrowser/QtTestBrowser.pro:
2936         * Scripts/webkitdirs.pm:
2937         * Tools.pro: Added.
2938         * WebKitTestRunner/DerivedSources.pro:
2939         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2940         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2941
2942 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
2943
2944         Reviewed by Dan Bernstein.
2945
2946         Beefed up --threaded mode to catch even more kinds of errors.
2947         https://bugs.webkit.org/show_bug.cgi?id=52971
2948
2949         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
2950         context group to force JSC to mark multiple threads. (This used to be
2951         the default, but it changed in SnowLeopard.)
2952         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
2953         to give threading mistakes more chances to show themselves.
2954         (startJavaScriptThreads):
2955         (stopJavaScriptThreads):
2956
2957 2011-01-22  Robert Hogan  <robert@webkit.org>
2958
2959         Reviewed by Andreas Kling.
2960
2961         [Qt] Support layoutTestController.addURLToRedirect()
2962         https://bugs.webkit.org/show_bug.cgi?id=52956
2963
2964         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2965         (LayoutTestController::addURLToRedirect):
2966         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2967
2968 2011-01-22  Robert Hogan  <robert@webkit.org>
2969
2970         Reviewed by Kenneth Rohde Christiansen.
2971
2972         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
2973         https://bugs.webkit.org/show_bug.cgi?id=49802
2974
2975         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2976         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2977         (WebCore::DumpRenderTree::open):
2978
2979 2011-01-21  Adam Barth  <abarth@webkit.org>
2980
2981         Reviewed by Maciej Stachowiak.
2982
2983         Disable mac_unittest.py that fails on some of the Mac bots
2984         https://bugs.webkit.org/show_bug.cgi?id=52947
2985
2986         As noted in the comment, this test does not appear to be correct
2987         because the function this test is testing returns different results
2988         depending on which flavor of Mac the test is run on.  This patch
2989         disable the test.  Hopefully we can re-enable the test once we've
2990         probably insulated the test from its environment.
2991
2992         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2993
2994 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2995
2996         Reviewed by Mihai Parparita.
2997
2998         Fix bug introduced in r76322 that caused NRWT to not actually
2999         read the Skipped files properly.
3000
3001         https://bugs.webkit.org/show_bug.cgi?id=52771
3002
3003         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3004         * Scripts/webkitpy/layout_tests/port/webkit.py:
3005         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3006
3007 2011-01-21  Sam Weinig  <sam@webkit.org>
3008
3009         Reviewed by Geoffrey Sean Garen and Mark Rowe.
3010
3011         WebKitTestRunner needs the HOME environment variable to be set.
3012         <rdar://problem/8896573>
3013
3014         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
3015         it exists.
3016
3017 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
3018
3019         Reviewed by Eric Seidel.
3020
3021         Suppress a few remaining integration tests so that none of the
3022         layout_test unit tests ever read from the filesystem or launch
3023         subprocesses that aren't part of the unit tests.
3024
3025         Also fix a minor bug in the printing unit tests that was
3026         incorrectly relying on sys.argv.
3027
3028         https://bugs.webkit.org/show_bug.cgi?id=52863
3029
3030         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3031         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3032         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3033
3034 2011-01-21  Darin Adler  <darin@apple.com>
3035
3036        Fix Mac build.
3037
3038         * MiniBrowser/mac/BrowserWindowController.m:
3039         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
3040
3041 2011-01-20  Darin Adler  <darin@apple.com>
3042
3043         Reviewed by Dan Bernstein.
3044
3045         WebKit2: Implement showModalDialog
3046         https://bugs.webkit.org/show_bug.cgi?id=52855
3047
3048         This fixes WebKitTestRunner to compile, but more work is probably
3049         needed to get it to pass the tests.
3050
3051         * WebKitTestRunner/TestController.cpp:
3052         (WTR::TestController::runModal): Added. Calls through to the
3053         platform-specific version of runModal.
3054         (WTR::TestController::createOtherPage): Changed to be a private
3055         static member function so it can refer to runModal, which is
3056         a private static member function.
3057         (WTR::TestController::initialize): Pass 0 for the runModal
3058         function since we don't need to run the main window modal.
3059         I suspect this is wrong and will need to change.
3060         * WebKitTestRunner/TestController.h: Added declarations for
3061         the functions added above.
3062         * WebKitTestRunner/mac/TestControllerMac.mm:
3063         (WTR::TestController::runModal): Added. Untested implementation.
3064         * WebKitTestRunner/qt/TestControllerQt.cpp:
3065         (WTR::TestController::runModal): Added.
3066         * WebKitTestRunner/win/TestControllerWin.cpp:
3067         (WTR::TestController::runModal): Added.
3068
3069 2011-01-21  Eric Seidel  <eric@webkit.org>
3070
3071         Reviewed by Adam Barth.
3072
3073         Split Host object off from WebKitPatch for easier re-use
3074         https://bugs.webkit.org/show_bug.cgi?id=52284
3075
3076         new-run-webkit-tests and other tools are eventually going to want one of these.
3077         Basically you need to inherit from this class if you want to pretend to be a
3078         self.tool object for Steps/Commands.
3079
3080         * Scripts/webkitpy/common/host.py: Added.
3081         * Scripts/webkitpy/tool/main.py:
3082
3083 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
3084
3085         Reviewed by Adam Barth.
3086
3087         Disable the tests that start and stop the http server and web
3088         server, so that we don't have to worry about port collisions on
3089         the bots.
3090
3091         https://bugs.webkit.org/show_bug.cgi?id=52861
3092
3093         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3094
3095 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
3096
3097         Reviewed by Eric Seidel.
3098
3099         nrwt: rewrite google_chrome_unittest to use mock filesystem.
3100         
3101         https://bugs.webkit.org/show_bug.cgi?id=52772
3102         
3103         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3104
3105 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
3106
3107         Reviewed by Eric Siedel.
3108
3109         nrwt: clean up almost all remaining port references, remove
3110         unnecessary import clauses. The only remaining references are
3111         in places where a mock filesystem makes no sense or can't be
3112         used, and in one routine in port/google_chrome_unittest that
3113         I'll rewrite in a separate patch.
3114
3115         https://bugs.webkit.org/show_bug.cgi?id=52771
3116
3117         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3118         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3119         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3120         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3121         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3122         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3123         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3124         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3125         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3126         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3127         * Scripts/webkitpy/layout_tests/port/gtk.py:
3128         * Scripts/webkitpy/layout_tests/port/mac.py:
3129         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3130         * Scripts/webkitpy/layout_tests/port/qt.py:
3131         * Scripts/webkitpy/layout_tests/port/webkit.py:
3132         * Scripts/webkitpy/layout_tests/port/win.py:
3133         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3134
3135 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
3136
3137         Reviewed by Mihai Parparita.
3138
3139         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
3140
3141         https://bugs.webkit.org/show_bug.cgi?id=52762
3142
3143         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3144         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3145
3146 2011-01-20  Tony Chang  <tony@chromium.org>
3147
3148         Reviewed by Ojan Vafai.
3149
3150         [chromium] fix the paths used for the rebaseline tool
3151         https://bugs.webkit.org/show_bug.cgi?id=52857
3152
3153         Some of the bots were renamed so the path to grab the results zip
3154         file has changed.
3155
3156         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3157
3158 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
3159
3160         Reviewed by Tony Chang.
3161
3162         Fix bug introduced in r72688 / bug 52768 that broke the
3163         generation of the output filename links in the results.html
3164         output. Apparently none of the unit tests actually checked to
3165         make sure the generated links were correct :(
3166
3167         https://bugs.webkit.org/show_bug.cgi?id=52854
3168
3169         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3170         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
3171
3172 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
3173
3174         Reviewed by Darin Adler.
3175
3176         https://bugs.webkit.org/show_bug.cgi?id=52849
3177         Make window.print work with WebKit2
3178
3179         * MiniBrowser/mac/BrowserWindowController.m:
3180         (-[BrowserWindowController awakeFromNib]):
3181         * WebKitTestRunner/TestController.cpp:
3182         (WTR::createOtherPage):
3183         (WTR::TestController::initialize):
3184         Added zeroes to WKPageUIClient structures to avoid build failures.
3185
3186 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
3187
3188         Reviewed by Eric Seidel.
3189
3190         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
3191
3192         https://bugs.webkit.org/show_bug.cgi?id=52756
3193
3194         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3195         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3196         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3197         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3198         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3199         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3200
3201 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
3202
3203         Reviewed by Antonio Gomes.
3204
3205         QtTestBrowser should have a seperate menu for Settings
3206         https://bugs.webkit.org/show_bug.cgi?id=52817
3207         
3208         Added a new menu item named "Settings"
3209         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
3210
3211         * QtTestBrowser/launcherwindow.cpp:
3212         (LauncherWindow::createChrome):
3213
3214 2011-01-20  Sam Weinig  <sam@webkit.org>
3215
3216         Reviewed by John Sullivan.
3217
3218         Update update-webkit-localizable-strings with new path to WebKit.
3219
3220         * Scripts/update-webkit-localizable-strings:
3221
3222 2011-01-20  James Robinson  <jamesr@chromium.org>
3223
3224         Reviewed by Darin Fisher.
3225
3226         Implement mozilla's requestAnimationFrame API
3227         https://bugs.webkit.org/show_bug.cgi?id=51218
3228
3229         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
3230
3231         * DumpRenderTree/chromium/WebViewHost.cpp:
3232         (invokeScheduleComposite):
3233         (WebViewHost::scheduleAnimation):
3234         (WebViewHost::paintInvalidatedRegion):
3235         * DumpRenderTree/chromium/WebViewHost.h:
3236
3237 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
3238
3239         Reviewed by Adam Roben.
3240
3241         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
3242         https://bugs.webkit.org/show_bug.cgi?id=42327
3243
3244         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
3245         for methods that take their normal arguments but also a JSContextRef.
3246         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
3247         for evaluateScriptInIsolatedWorld.
3248         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3249         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
3250         this call is for an isolated world.
3251         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3252         (WTR::worldMap): Helper to create a world map.
3253         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
3254         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
3255         added LayoutTestController API.
3256         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3257
3258 2011-01-19  Adam Roben  <aroben@apple.com>
3259
3260         Convert paths in environment variables back to msys-style inside commit-log-editor
3261
3262         When this script gets run from inside git commit, msys-style paths in the environment will
3263         have been turned into Windows-style paths with forward slashes. This screws up functions
3264         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
3265         the paths back to msys-style before doing anything else.
3266
3267         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
3268         using msysgit's Perl and multiple ChangeLogs have been edited
3269
3270         Reviewed by David Kilzer.
3271
3272         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
3273         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
3274         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
3275
3276 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
3277
3278         [Win] Unreviewed build fix after r76248.
3279
3280         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
3281
3282 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
3283
3284         Reviewed by Csaba Osztrogonác.
3285
3286         Refactoring of the custom allocation framework
3287         https://bugs.webkit.org/show_bug.cgi?id=49897
3288
3289         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
3290         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
3291         equivalent macro implementation at the necessary places.
3292 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
3293
3294         Unreviewed. 
3295
3296         Adding myself to committers.py.
3297
3298         * Scripts/webkitpy/common/config/committers.py:
3299
3300 2011-01-20  Adam Barth  <abarth@webkit.org>
3301
3302         Reviewed by Tony Chang.
3303
3304         Chromium builders don't delete unversioned directories when DEPS change
3305         https://bugs.webkit.org/show_bug.cgi?id=52745
3306
3307         If we pass this option to gclient sync, gclient will delete directories
3308         that are no longer part of DEPS instead of leaving them around to
3309         confuse us later.  Apparently, the downstream buildbots use this option
3310         already.
3311
3312         * Scripts/update-webkit-chromium:
3313
3314 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3315
3316         Unreviewed, build fix - I pulled this patch in to fix an issue
3317         revealed by r76195 running on some new bots). Also fix a couple
3318         of other issues revealed in testing.
3319
3320         nrwt: remove fs refs from layout_package/json*
3321
3322         https://bugs.webkit.org/show_bug.cgi?id=52754
3323
3324         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3325         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3326         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3327         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3328         * Scripts/webkitpy/layout_tests/port/base.py:
3329
3330 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3331
3332         Unreviewed, build fix.
3333
3334         Fix a couple of minor bugs discovered while bringing up new bots
3335         for testing.
3336
3337         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3338         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3339
3340 2011-01-19  James Robinson  <jamesr@chromium.org>
3341
3342         Unreviewed, rolling out r76194.
3343         http://trac.webkit.org/changeset/76194
3344         https://bugs.webkit.org/show_bug.cgi?id=51218
3345
3346         Caused mysterious compile failure on the chromium win
3347         build.webkit.org bots
3348
3349         * DumpRenderTree/chromium/WebViewHost.cpp:
3350         (WebViewHost::paintInvalidatedRegion):
3351         * DumpRenderTree/chromium/WebViewHost.h:
3352
3353 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3354
3355         Reviewed by Mihai Parparita.
3356
3357         remove fs refs from test_runner, dump_render_tree_thread
3358
3359         https://bugs.webkit.org/show_bug.cgi?id=52753
3360
3361         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3362         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3363         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3364         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3365
3366 2011-01-19  James Robinson  <jamesr@chromium.org>
3367
3368         Reviewed by Darin Fisher.
3369
3370         Implement mozilla's requestAnimationFrame API
3371         https://bugs.webkit.org/show_bug.cgi?id=51218
3372
3373         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
3374
3375         * DumpRenderTree/chromium/WebViewHost.cpp:
3376         (invokeScheduleComposite):
3377         (WebViewHost::scheduleAnimation):
3378         (WebViewHost::paintInvalidatedRegion):
3379         * DumpRenderTree/chromium/WebViewHost.h:
3380
3381 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3382
3383         Unreviewed, build fix.
3384
3385         Fix a few incorrect "self._filesystem" references introduced in
3386         r76184.
3387
3388         * Scripts/webkitpy/layout_tests/port/chromium.py:
3389         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3390
3391 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3392
3393         Reviewed by Mihai Parparita.
3394
3395         add a .sep property, abspath(), isabs(), mtime(), and
3396         open_text_file_for_writing() to filesystem modules. Some of
3397         these properties are not needed in this patch but will be needed
3398         in subsequent patches (I'm doing this to avoid having to track
3399         multiple versions of a single file).
3400
3401         Also, change most of the port/* modules to use the filesystem
3402         objects instead of referencing the filesystem directly.
3403
3404         https://bugs.webkit.org/show_bug.cgi?id=52748
3405
3406         * Scripts/webkitpy/common/system/filesystem.py:
3407         * Scripts/webkitpy/common/system/filesystem_mock.py:
3408         * Scripts/webkitpy/layout_tests/port/__init__.py:
3409         * Scripts/webkitpy/layout_tests/port/base.py:
3410         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3411         * Scripts/webkitpy/layout_tests/port/chromium.py:
3412         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3413         * Scripts/webkitpy/layout_tests/port/config.py:
3414         * Scripts/webkitpy/layout_tests/port/test.py:
3415         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3416
3417 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
3418
3419         Reviewed by Anders Carlsson.
3420
3421         If resetting between tests times out, treat it as a WebProcess crash
3422         https://bugs.webkit.org/show_bug.cgi?id=52757
3423
3424         * WebKitTestRunner/TestController.cpp:
3425         (WTR::TestController::runTest):
3426
3427 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
3428
3429         Reviewed by Darin Adler.
3430
3431         https://bugs.webkit.org/show_bug.cgi?id=52739
3432         Make it possible for a WebKit2 client to print headers and footers
3433
3434         Added dummy implementations for new printing UIClient calls.
3435
3436         * MiniBrowser/mac/BrowserWindowController.m:
3437         (-[BrowserWindowController awakeFromNib]):
3438         * WebKitTestRunner/TestController.cpp:
3439         (WTR::createOtherPage):
3440         (WTR::TestController::initialize):
3441
3442 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3443
3444         Reviewed by Ojan Vafai.
3445
3446         Change webkitpy/layout_tests/port/test.py to use the
3447         in-memory filesystem for cleaner unit testing. This
3448         change allows us to kill a lot of code that was
3449         specific to the test port, at the cost of being a
3450         little less clear about how things would work if
3451         you didn't have a filesystem.
3452
3453         https://bugs.webkit.org/show_bug.cgi?id=52605
3454
3455         * Scripts/webkitpy/layout_tests/port/test.py:
3456
3457 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3458
3459         Unreviewed, build fix.
3460
3461         Fix test failure caused by committing attachment 79368 instead
3462         of attachment 79461 on bug 52604.
3463
3464         * Scripts/webkitpy/common/system/filesystem_mock.py:
3465
3466 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3467
3468         Reviewed by Mihai Parparita.
3469
3470         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
3471         unit testing. os.walk() is too much of a hassle to implement on
3472         top of the in-memory mock filesystem and adding the necessary
3473         interface to files_under() gives clients a cleaner API anyway
3474         (for this particular usage model).
3475
3476         https://bugs.webkit.org/show_bug.cgi?id=52691
3477
3478         * Scripts/webkitpy/common/system/filesystem.py:
3479         * Scripts/webkitpy/common/system/filesystem_mock.py:
3480         * Scripts/webkitpy/layout_tests/port/test_files.py:
3481         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3482
3483 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
3484
3485         Reviewed by Tony Chang.
3486
3487         Change more modules in the layout-tests code to use the
3488         filesystem wrapper for cleaner unit testing.
3489
3490         This patch also adds the glob() wrapper to the filesystem
3491         abstraction.
3492         
3493         https://bugs.webkit.org/show_bug.cgi?id=52604
3494
3495         * Scripts/webkitpy/layout_tests/port/test_files.py:
3496         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3497         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3498         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3499         * Scripts/webkitpy/common/system/filesystem.py:
3500         * Scripts/webkitpy/common/system/filesystem_mock.py:
3501
3502 2011-01-19  Levi Weintraub  <leviw@chromium.org>
3503
3504         Unreviewed.
3505
3506         Updating my email addresses and irc nick.
3507
3508         * Scripts/webkitpy/common/config/committers.py:
3509
3510 2011-01-19  Tony Chang  <tony@chromium.org>
3511
3512         Reviewed by Mihai Parparita.
3513
3514         [chromium] [linux] if check-sys-deps fails, output the failure reason
3515         https://bugs.webkit.org/show_bug.cgi?id=52671
3516
3517         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
3518             error handler functions.
3519         * Scripts/webkitpy/layout_tests/port/chromium.py:
3520             output the error text from --check-sys-deps
3521         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3522
3523 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
3524
3525         Reviewed by Andreas Kling.
3526
3527         [Qt] QtTestBrowser crashes when closing if Facebook is opened
3528         https://bugs.webkit.org/show_bug.cgi?id=52554
3529         
3530         QtNetworkAccessManager is created in a thread and set as
3531         member variable in QWebPage. When the thread is destroyed
3532         the object is still used. So fix will set the object to
3533         NULL once the thread is destroyed.
3534
3535         * QtTestBrowser/launcherwindow.cpp:
3536         (LauncherWindow::~LauncherWindow):
3537
3538 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
3539
3540         Rubber stamped by Csaba Osztrogonac
3541
3542         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
3543
3544 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
3545
3546         Reviewed by Tony Chang.
3547
3548         new-run-webkit-tests: add a --build-directory command line argument
3549
3550         Official Google Chrome builds use a non-standard build directory
3551         location. This patch adds a --build-directory argument that
3552         allows that location to be specified on the command line. Only
3553         Chromium-based builds will use this flag for now, but anyone can
3554         in the future.
3555
3556         There are no unit tests for this since it's difficult to test
3557         until mock filesystems are fully supported in the code. This was
3558         tested by hand for now.
3559
3560         https://bugs.webkit.org/show_bug.cgi?id=52694
3561
3562         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: