Put keygen element behind a runtime flag and disable it by default
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Put keygen element behind a runtime flag and disable it by default
4         https://bugs.webkit.org/show_bug.cgi?id=200850
5
6         Reviewed by Antti Koivisto.
7
8         * Interfaces/IWebPreferencesPrivate.idl:
9         * WebPreferenceKeysPrivate.h:
10         * WebPreferences.cpp:
11         (WebPreferences::keygenElementEnabled):
12         (WebPreferences::setKeygenElementEnabled):
13         * WebPreferences.h:
14         * WebView.cpp:
15         (WebView::notifyPreferencesChanged):
16
17 2019-08-19  Fujii Hironori  <Hironori.Fujii@sony.com>
18
19         [WinCairo][WK1] A browser window starts as an inactive window because AcceleratedCompositingContext::acceleratedCompositingAvailable creates temporary window
20         https://bugs.webkit.org/show_bug.cgi?id=200493
21
22         Reviewed by Ross Kirsling.
23
24         Reverted r179962.
25
26         * WebCoreSupport/AcceleratedCompositingContext.cpp:
27         (AcceleratedCompositingContext::acceleratedCompositingAvailable): Deleted.
28         * WebCoreSupport/AcceleratedCompositingContext.h:
29         * WebView.cpp:
30         (WebView::notifyPreferencesChanged):
31
32 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
33
34         Remove IDB-specific quota
35         https://bugs.webkit.org/show_bug.cgi?id=196545
36         <rdar://problem/54201783>
37
38         Reviewed by Youenn Fablet.
39
40         * Interfaces/IWebDatabaseManager.idl:
41         * WebDatabaseManager.cpp:
42         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
43         * WebDatabaseManager.h:
44
45 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
46
47         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
48         https://bugs.webkit.org/show_bug.cgi?id=200620
49
50         Reviewed by Geoffrey Garen.
51
52         * FullscreenVideoController.cpp:
53         (FullscreenVideoController::FullscreenVideoController):
54         * Plugins/PluginStream.cpp:
55         (WebCore::PluginStream::didReceiveData):
56         * Plugins/PluginView.cpp:
57         (WebCore::PluginView::load):
58         * Plugins/PluginViewWin.cpp:
59         (WebCore::PluginView::wndProc):
60         * WebCoreSupport/WebChromeClient.cpp:
61         (WebChromeClient::WebChromeClient):
62         * WebCoreSupport/WebFrameLoaderClient.cpp:
63         (WebFrameLoaderClient::WebFrameLoaderClient):
64         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
65         * WebCoreSupport/WebInspectorClient.cpp:
66         (WebInspectorClient::openLocalFrontend):
67         (WebInspectorClient::highlight):
68         * WebElementPropertyBag.cpp:
69         (WebElementPropertyBag::WebElementPropertyBag):
70         * WebHistoryItem.cpp:
71         (WebHistoryItem::initFromDictionaryRepresentation):
72         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
73         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
74         * WebNotificationCenter.cpp:
75         (WebNotificationCenter::WebNotificationCenter):
76         * WebView.cpp:
77         (WebView::handleMouseEvent):
78         (WebView::registerEmbeddedViewMIMEType):
79         (WebView::enterVideoFullscreenForVideoElement):
80         (WebView::addUserScriptToGroup):
81         (WebView::addUserStyleSheetToGroup):
82         (WebView::setAcceleratedCompositing):
83
84 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
85
86         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
87         https://bugs.webkit.org/show_bug.cgi?id=200620
88
89         Reviewed by Geoffrey Garen.
90
91         * FullscreenVideoController.cpp:
92         * FullscreenVideoController.h:
93         * Plugins/PluginMessageThrottlerWin.h:
94         * WebCachedFramePlatformData.h:
95         * WebCoreSupport/AcceleratedCompositingContext.h:
96         * WebCoreSupport/WebChromeClient.h:
97         * WebCoreSupport/WebContextMenuClient.h:
98         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
99         * WebCoreSupport/WebDragClient.h:
100         * WebCoreSupport/WebEditorClient.h:
101         * WebCoreSupport/WebFrameLoaderClient.cpp:
102         * WebCoreSupport/WebGeolocationClient.h:
103         * WebCoreSupport/WebInspectorClient.h:
104         * WebDatabaseManager.cpp:
105         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
106         * WebNodeHighlight.h:
107         * WebNotificationCenter.cpp:
108         * WebNotificationCenter.h:
109
110 2019-08-15  Brent Fulgham  <bfulgham@apple.com>
111
112         [FTW] Enable CoreFoundation use if building for Apple target
113         https://bugs.webkit.org/show_bug.cgi?id=200799
114
115         Reviewed by Alex Christensen.
116
117         * FullscreenVideoController.cpp:
118         (FullscreenVideoController::FullscreenVideoController):
119         (FullscreenVideoController::enterFullscreen):
120         (FullscreenVideoController::exitFullscreen):
121         (FullscreenVideoController::createHUDWindow):
122         * FullscreenVideoController.h:
123         * WebView.cpp:
124         (WebView::exitFullscreenIfNeeded):
125
126 2019-08-15  Youenn Fablet  <youenn@apple.com>
127
128         Always create a Document with a valid SessionID
129         https://bugs.webkit.org/show_bug.cgi?id=200727
130
131         Reviewed by Alex Christensen.
132
133         Implement WebKit1 sessionID getter like done for WebKit2.
134         Either the loader client has a page in which case the page session ID is used
135         or the client has no page, in which case the default session ID is used.
136         This is the same behavior as CachedResourceLoader.
137
138         * WebCoreSupport/WebFrameLoaderClient.cpp:
139         (WebFrameLoaderClient::sessionID const):
140
141 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
142
143         Unreviewed, rolling out r248526.
144
145         Caused two IndexedDB perf tests to fail
146
147         Reverted changeset:
148
149         "Remove IDB-specific quota"
150         https://bugs.webkit.org/show_bug.cgi?id=196545
151         https://trac.webkit.org/changeset/248526
152
153 2019-08-14  Youenn Fablet  <youenn@apple.com>
154
155         ThreadableBlobRegistry::blobSize should take a SessionID as parameter
156         https://bugs.webkit.org/show_bug.cgi?id=200671
157
158         Reviewed by Alex Christensen.
159
160         * WebCoreSupport/WebPlatformStrategies.cpp:
161
162 2019-08-13  Youenn Fablet  <youenn@apple.com>
163
164         Blob registries should be keyed by session IDs
165         https://bugs.webkit.org/show_bug.cgi?id=200567
166         <rdar://problem/54120212>
167
168         Reviewed by Alex Christensen.
169
170         * WebCoreSupport/WebPlatformStrategies.cpp:
171         (WebPlatformStrategies::createBlobRegistry):
172
173 2019-08-12  Youenn Fablet  <youenn@apple.com>
174
175         Remove IDB-specific quota
176         https://bugs.webkit.org/show_bug.cgi?id=196545
177
178         Reviewed by Alex Christensen.
179
180         * Interfaces/IWebDatabaseManager.idl:
181         * WebDatabaseManager.cpp:
182         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
183         * WebDatabaseManager.h:
184
185 2019-08-09  Per Arne Vollan  <pvollan@apple.com>
186
187         [Win] Remove compiler workaround for VS2013
188         https://bugs.webkit.org/show_bug.cgi?id=200582
189
190         Reviewed by Don Olmstead.
191
192         A VS2013 compiler workaround can be removed now.
193
194         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp:
195         (DllMain):
196
197 2019-08-08  Per Arne Vollan  <pvollan@apple.com>
198
199         [Win] Fix internal build
200         https://bugs.webkit.org/show_bug.cgi?id=200519
201
202         Reviewed by Alex Christensen.
203
204         Switch to the String::wideCharacers method, since its return type is compatible with the Win32 api.
205
206         * WebDownloadCFNet.cpp:
207         (WebDownload::didFinish):
208
209 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
210
211         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
212         https://bugs.webkit.org/show_bug.cgi?id=200539
213         <rdar://problem/54082550>
214
215         Reviewed by Dean Jackson.
216
217         * AccessibleBase.cpp:
218         (AccessibleBase::get_locale):
219         * CFDictionaryPropertyBag.cpp:
220         (ConvertCFTypeToVariant):
221         (CFDictionaryPropertyBag::Read):
222         (CFDictionaryPropertyBag::Write):
223         * CFDictionaryPropertyBag.h:
224         * COMPropertyBag.h:
225         (HashType>::Read):
226         (HashType>::GetPropertyInfo):
227         * MarshallingHelpers.cpp:
228         * MarshallingHelpers.h:
229         * WebApplicationCache.cpp:
230         * WebArchive.cpp:
231         * WebArchive.h:
232         * WebCache.cpp:
233         * WebCoreSupport/WebFrameLoaderClient.cpp:
234         * WebDatabaseManager.cpp:
235         * WebHistory.cpp:
236         * WebHistoryItem.cpp:
237         * WebKitCOMAPI.cpp:
238         * WebKitCOMAPI.h:
239         * WebKitDLL.cpp:
240         * WebLocalizableStrings.cpp:
241         * WebLocalizableStrings.h:
242         * WebMutableURLRequest.cpp:
243         * WebPreferences.cpp:
244         * WebPreferences.h:
245         * WebView.cpp:
246         * WebView.h:
247
248 2019-08-08  Rob Buis  <rbuis@igalia.com>
249
250         Add runtime flag for lazy image loading
251         https://bugs.webkit.org/show_bug.cgi?id=199794
252
253         Reviewed by Darin Adler.
254
255         Set lazyImageLoading runtime flag if preference is set.
256
257         * Interfaces/IWebPreferencesPrivate.idl:
258         * WebPreferenceKeysPrivate.h:
259         * WebPreferences.cpp:
260         (WebPreferences::initializeDefaultSettings):
261         (WebPreferences::lazyImageLoadingEnabled):
262         (WebPreferences::setLazyImageLoadingEnabled):
263         * WebPreferences.h:
264         * WebView.cpp:
265         (WebView::notifyPreferencesChanged):
266
267 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
268
269         [Win][WK1] Can't change Web Inspector frontend height in high DPI
270         https://bugs.webkit.org/show_bug.cgi?id=200153
271
272         Reviewed by Don Olmstead.
273
274         * WebCoreSupport/WebInspectorClient.cpp:
275         (WebInspectorFrontendClient::setAttachedWindowHeight):
276         Applied deviceScaleFactor to the argument height.
277
278 2019-07-26  Konstantin Tokarev  <annulen@yandex.ru>
279
280         [Win] Remove unused methods from WebPluginInfoProvider
281         https://bugs.webkit.org/show_bug.cgi?id=200178
282
283         Reviewed by Brent Fulgham.
284
285         These methods are guarded with PLATFORM(MAC) and have no definitions.
286         Also remove unused friend declaration.
287
288         * WebCoreSupport/WebPluginInfoProvider.h:
289
290 2019-07-25  Fujii Hironori  <Hironori.Fujii@sony.com>
291
292         [Win][WK1] The inspected webview window is misplaced after changing Web Inspector frontend window height
293         https://bugs.webkit.org/show_bug.cgi?id=200152
294
295         Reviewed by Brent Fulgham.
296
297         In WebInspectorFrontendClient::setAttachedWindowHeight, the size
298         of m_inspectedWebViewHwnd was changed to the whole host window
299         size. But, it's too tall because MiniBrowser's host window has a
300         toolbar. The toolbar height should be taken into account.
301
302         Change to the height of m_inspectedWebViewHwnd to the sum of
303         inspected WebView and inspector frontend WebView heights.
304
305         * WebCoreSupport/WebInspectorClient.cpp:
306         (WebInspectorFrontendClient::setAttachedWindowHeight):
307
308 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
309
310         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
311         https://bugs.webkit.org/show_bug.cgi?id=200021
312         <rdar://problem/53301325>
313
314         Reviewed by Ryosuke Niwa.
315
316         Implement a new editing client hook.
317
318         * WebCoreSupport/WebEditorClient.h:
319
320 2019-07-13  Zalan Bujtas  <zalan@apple.com>
321
322         Cannot bring up custom media controls at all on v.youku.com
323         https://bugs.webkit.org/show_bug.cgi?id=199699
324         <rdar://problem/51835327>
325
326         Reviewed by Simon Fraser.
327
328         * WebActionPropertyBag.cpp:
329         (WebActionPropertyBag::Read):
330         * WebView.cpp:
331         (WebView::handleContextMenuEvent):
332         (WebView::elementAtPoint):
333
334 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
335
336         [WinCairo] ASSERTION FAILED: info.bmBitsPixel == 32 in createCairoContextWithHDC
337         https://bugs.webkit.org/show_bug.cgi?id=198323
338
339         Reviewed by Per Arne Vollan.
340
341         WebView::paint binds m_backingStoreBitmap to a DC by using
342         SelectObject. WebView::paint can be called recursively, but
343         m_backingStoreBitmap can't be bound to multiple DCs at the same
344         time. Then, SelectObject was failing in such case.
345
346         Call WebCore::Page::updateRendering before binding
347         m_backingStoreBitmap instead of after it.
348
349         Reverted r202744 change which won't be needed since this change.
350
351         * WebView.cpp:
352         (WebView::scrollBackingStore): Removed r202744's change.
353         (WebView::updateBackingStore): Removed m_page->updateRendering().
354         (WebView::paint): Do m_page->updateRendering() before binding m_backingStoreBitmap.
355         * WebView.h: Removed unused WebView::isPainting.
356
357 2019-07-02  Devin Rousso  <drousso@apple.com>
358
359         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
360         https://bugs.webkit.org/show_bug.cgi?id=198956
361
362         Reviewed by Matt Baker.
363
364         * WebCoreSupport/WebInspectorClient.h:
365         * WebCoreSupport/WebInspectorClient.cpp:
366         (WebInspectorFrontendClient::resetWindowState): Added.
367
368 2019-06-30  Fujii Hironori  <Hironori.Fujii@sony.com>
369
370         [Win] Multiline mode of tooltip control does word-wrapping very slowly
371         https://bugs.webkit.org/show_bug.cgi?id=198989
372
373         Reviewed by Ross Kirsling.
374
375         * WebView.cpp:
376         (truncatedString): Added.
377         (WebView::setToolTip): Use truncatedString.
378
379 2019-06-16  Darin Adler  <darin@apple.com>
380
381         Rename AtomicString to AtomString
382         https://bugs.webkit.org/show_bug.cgi?id=195276
383
384         Reviewed by Michael Catanzaro.
385
386         * many files: Let do-webcore-rename do the renaming.
387
388 2019-05-31  Don Olmstead  <don.olmstead@sony.com>
389
390         [CMake] Add WebKit::WTF target
391         https://bugs.webkit.org/show_bug.cgi?id=198400
392
393         Reviewed by Konstantin Tokarev.
394
395         Use the WebKit::WTF target.
396
397         * WebKitQuartzCoreAdditions/CMakeLists.txt:
398
399 2019-05-30  Simon Fraser  <simon.fraser@apple.com>
400
401         Use an OptionSet<> for GraphicsLayerPaintingPhase
402         https://bugs.webkit.org/show_bug.cgi?id=198404
403
404         Reviewed by Tim Horton.
405
406         Replace GraphicsLayerPaintingPhase with OptionSet<GraphicsLayerPaintingPhase>.
407
408         No behavior change.
409
410         * WebCoreSupport/AcceleratedCompositingContext.cpp:
411         (AcceleratedCompositingContext::paintContents):
412         * WebCoreSupport/AcceleratedCompositingContext.h:
413         * WebView.cpp:
414         (WebView::paintContents):
415         * WebView.h:
416
417 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
418
419         [iOS] Dropped text, attachments, and images should animate into place
420         https://bugs.webkit.org/show_bug.cgi?id=198243
421         <rdar://problem/35205373>
422
423         Reviewed by Tim Horton.
424
425         * WebCoreSupport/WebChromeClient.cpp:
426         (WebChromeClient::didFinishLoadingImageForElement):
427         * WebCoreSupport/WebChromeClient.h:
428
429 2019-05-03  Daniel Bates  <dabates@apple.com>
430
431         Pass KeyboardEvent by reference in more places
432         https://bugs.webkit.org/show_bug.cgi?id=197480
433
434         Reviewed by Wenson Hsieh.
435
436         * WebCoreSupport/WebEditorClient.cpp:
437         (WebEditorClient::handleKeyboardEvent):
438         (WebEditorClient::handleInputMethodKeydown):
439         * WebCoreSupport/WebEditorClient.h:
440         * WebView.cpp:
441         (WebView::handleEditingKeyboardEvent):
442         * WebView.h:
443
444 2019-05-02  Frederic Wang  <fwang@igalia.com>
445
446         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
447         https://bugs.webkit.org/show_bug.cgi?id=196142
448
449         This patch introduces some experimental runtime flag to let users
450         disable MathML features that are removed from MathML Core [1]. For now,
451         these features are only disabled on GTK and WPE ports.
452
453         [1] https://mathml-refresh.github.io/mathml-core/
454
455         Reviewed by Rob Buis.
456
457         * Interfaces/IWebPreferencesPrivate.idl:
458         * WebPreferenceKeysPrivate.h:
459         * WebPreferences.cpp:
460         (WebPreferences::initializeDefaultSettings):
461         (WebPreferences::coreMathMLEnabled):
462         (WebPreferences::setCoreMathMLEnabled):
463         * WebPreferences.h:
464         * WebView.cpp:
465         (WebView::notifyPreferencesChanged):
466
467 2019-04-24  Zalan Bujtas  <zalan@apple.com>
468
469         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
470         https://bugs.webkit.org/show_bug.cgi?id=196948
471         <rdar://problem/49927131>
472
473         Reviewed by Tim Horton.
474
475         * WebCoreSupport/WebChromeClient.cpp:
476         (WebChromeClient::intrinsicContentsSizeChanged const):
477         * WebCoreSupport/WebChromeClient.h:
478
479 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
480
481         Make it possible to control the renderTreeAsText output by setting options on testRunner
482         https://bugs.webkit.org/show_bug.cgi?id=197133
483
484         Reviewed by Sam Weinig.
485
486         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
487         that make sense in testing (those that don't dump unstable data like addresses), and plumb
488         these flags through the various framework layers.
489
490         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
491
492         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
493         and hand-code DumpRenderTree bindings.
494
495         Some cleanup of the TestRunners, using member initializers.
496
497         * Interfaces/IWebFramePrivate.idl:
498         * WebFrame.cpp:
499         (toRenderAsTextFlags):
500         (WebFrame::renderTreeAsExternalRepresentation):
501         (WebFrame::renderTreeAsExternalRepresentationForPrinting):
502         * WebFrame.h:
503
504 2019-04-23  Chris Dumez  <cdumez@apple.com>
505
506         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
507         https://bugs.webkit.org/show_bug.cgi?id=197097
508         <rdar://problem/50048318>
509
510         Reviewed by Alex Christensen.
511
512         * WebCoreSupport/WebFrameLoaderClient.cpp:
513         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
514         * WebCoreSupport/WebFrameLoaderClient.h:
515
516 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
517
518         [CMake][Win] Use target oriented design for WebKitLegacy
519         https://bugs.webkit.org/show_bug.cgi?id=197112
520
521         Reviewed by Konstantin Tokarev.
522
523         Fix an include directory.
524
525         * WebKitQuartzCoreAdditions/CMakeLists.txt:
526
527 2019-04-18  Jer Noble  <jer.noble@apple.com>
528
529         Refactoring: Pull all fullscreen code out of Document and into its own helper class
530         https://bugs.webkit.org/show_bug.cgi?id=197017
531
532         Reviewed by Eric Carlson.
533
534         * WebCoreSupport/WebChromeClient.cpp:
535         (WebChromeClient::createWindow):
536         * WebView.cpp:
537         (WebView::fullScreenClientWillEnterFullScreen):
538         (WebView::fullScreenClientDidEnterFullScreen):
539         (WebView::fullScreenClientWillExitFullScreen):
540         (WebView::fullScreenClientDidExitFullScreen):
541
542 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
543
544         requestAnimationFrame should execute before the next frame
545         https://bugs.webkit.org/show_bug.cgi?id=177484
546
547         Reviewed by Simon Fraser.
548
549         * WebView.cpp:
550         (WebView::updateBackingStore):
551         (WebView::flushPendingGraphicsLayerChangesSoon):
552         (WebView::flushPendingGraphicsLayerChanges):
553         Call Page::updateRendering() which implements "Update the rendering"
554         step of the HTML Event Loop specification.
555
556 2019-04-10  Devin Rousso  <drousso@apple.com>
557
558         Web Inspector: save sheet should be anchored underneath the tab bar when detached
559         https://bugs.webkit.org/show_bug.cgi?id=196722
560         <rdar://problem/49613280>
561
562         Reviewed by Timothy Hatcher.
563
564         * WebCoreSupport/WebInspectorClient.h:
565         * WebCoreSupport/WebInspectorClient.cpp:
566         (WebInspectorFrontendClient::setSheetRect): Added.
567
568 2019-04-10  Alex Christensen  <achristensen@webkit.org>
569
570         Add SPI WKNavigationResponse._downloadAttribute
571         https://bugs.webkit.org/show_bug.cgi?id=196755
572         <rdar://49587365>
573
574         Reviewed by Brady Eidson.
575
576         * WebCoreSupport/WebFrameLoaderClient.cpp:
577         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
578         * WebCoreSupport/WebFrameLoaderClient.h:
579
580 2019-04-05  Commit Queue  <commit-queue@webkit.org>
581
582         Unreviewed, rolling out r243833.
583         https://bugs.webkit.org/show_bug.cgi?id=196645
584
585         This change breaks build of WPE and GTK ports (Requested by
586         annulen on #webkit).
587
588         Reverted changeset:
589
590         "[CMake][WTF] Mirror XCode header directories"
591         https://bugs.webkit.org/show_bug.cgi?id=191662
592         https://trac.webkit.org/changeset/243833
593
594 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
595
596         [CMake][WTF] Mirror XCode header directories
597         https://bugs.webkit.org/show_bug.cgi?id=191662
598
599         Reviewed by Konstantin Tokarev.
600
601         * WebKitQuartzCoreAdditions/CMakeLists.txt:
602
603 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
604
605         Implement ResizeObserver.
606         https://bugs.webkit.org/show_bug.cgi?id=157743
607
608         Reviewed by Simon Fraser.
609
610         * Interfaces/IWebPreferencesPrivate.idl:
611         * WebPreferenceKeysPrivate.h:
612         * WebPreferences.cpp:
613         (WebPreferences::initializeDefaultSettings):
614         (WebPreferences::resizeObserverEnabled):
615         (WebPreferences::setResizeObserverEnabled):
616         * WebPreferences.h:
617         * WebView.cpp:
618         (WebView::notifyPreferencesChanged):
619
620 2019-03-17  Fujii Hironori  <Hironori.Fujii@sony.com>
621
622         [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
623         https://bugs.webkit.org/show_bug.cgi?id=195741
624
625         Reviewed by Ross Kirsling.
626
627         * WebCoreSupport/WebFrameNetworkingContext.cpp:
628         (WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
629
630 2019-03-13  Ryan Haddad  <ryanhaddad@apple.com>
631
632         Unreviewed attempt to fix the Windows build after r242920.
633
634         * WebCoreSupport/WebFrameLoaderClient.h:
635
636 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
637
638         [Win] Fix a slew of simple clang-cl warnings.
639         https://bugs.webkit.org/show_bug.cgi?id=195652
640
641         Reviewed by Don Olmstead.
642
643         * Interfaces/AccessibleComparable.idl: -Wmissing-braces
644         * Plugins/PluginDatabaseWin.cpp: -Wunused-function
645         (WebCore::addJavaPluginDirectory): Deleted.
646         * WebCoreSupport/AcceleratedCompositingContext.cpp:
647         (AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder
648         * WebCoreSupport/WebEditorClient.cpp:
649         (WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
650         (undoNameForEditAction): -Wswitch
651         * WebCoreSupport/WebFrameLoaderClient.cpp:
652         (WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
653         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable
654         * WebCoreSupport/WebInspectorClient.cpp:
655         (WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder
656         * WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
657         * WebError.cpp:
658         (WebError::WebError): -Wreorder
659         * WebFrame.cpp:
660         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses
661         * WebHistory.cpp: -Wunused-function (x5)
662         (areEqualOrClose): Deleted.
663         (addDayToSystemTime): Deleted.
664         (getDayBoundaries): Deleted.
665         (beginningOfDay): Deleted.
666         (dateKey): Deleted.
667         * WebNotificationCenter.cpp:
668         (WebNotificationCenter::removeObserver): -Wunused-variable
669         * WebView.cpp: -Wunused-function, -Wreorder
670         (WebView::addVisitedLinks): -Wunused-variable
671
672 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
673
674         Unreviewed, rolling out r242688, r242643, r242624.
675
676         Caused multiple layout test failures and crashes on iOS and macOS.
677
678         Reverted changeset:
679
680         "requestAnimationFrame should execute before the next frame"
681         https://bugs.webkit.org/show_bug.cgi?id=177484
682         https://trac.webkit.org/changeset/242624/webkit
683
684         * WebView.cpp:
685         (WebView::updateBackingStore):
686         (WebView::flushPendingGraphicsLayerChangesSoon):
687         (WebView::flushPendingGraphicsLayerChanges):
688
689 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
690
691         requestAnimationFrame should execute before the next frame
692         https://bugs.webkit.org/show_bug.cgi?id=177484
693
694         Reviewed by Simon Fraser.
695
696         * WebView.cpp:
697         (WebView::updateBackingStore):
698         (WebView::flushPendingGraphicsLayerChangesSoon):
699         (WebView::flushPendingGraphicsLayerChanges):
700         Call Page::renderingUpdate() which implements  "Update the rendering"
701         step of the HTML Event Loop specification.
702
703 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
704
705         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
706         https://bugs.webkit.org/show_bug.cgi?id=195346
707
708         Reviewed by Fujii Hironori.
709
710         * COMPropertyBag.h:
711         (HashType>::GetPropertyInfo):
712         (HashType>::LoadObject):
713         * DOMCoreClasses.cpp:
714         (DOMNode::addEventListener):
715         (DOMNode::removeEventListener):
716         (DOMWindow::addEventListener):
717         (DOMWindow::removeEventListener):
718         (DOMElement::font):
719         * DOMHTMLClasses.cpp:
720         (DOMHTMLInputElement::setValueForUser):
721         (DOMHTMLInputElement::replaceCharactersInRange):
722         * Plugins/PluginDatabaseWin.cpp:
723         (WebCore::addPluginPathsFromRegistry):
724         (WebCore::PluginDatabase::getPluginPathsInDirectories const):
725         (WebCore::addMozillaPluginDirectories):
726         (WebCore::addWindowsMediaPlayerPluginDirectory):
727         (WebCore::addAdobeAcrobatPluginDirectory):
728         (WebCore::addJavaPluginDirectory):
729         (WebCore::safariPluginsDirectory):
730         (WebCore::addMacromediaPluginDirectories):
731         * Plugins/PluginPackageWin.cpp:
732         (WebCore::getVersionInfo):
733         (WebCore::PluginPackage::fetchInfo):
734         (WebCore::PluginPackage::load):
735         * Plugins/PluginViewWin.cpp:
736         (WebCore::PluginView::handlePostReadFile):
737         * WebCoreSupport/WebChromeClient.cpp:
738         (WebChromeClient::runOpenPanel):
739         * WebCoreSupport/WebEditorClient.cpp:
740         (WebEditorClient::checkSpellingOfString):
741         (WebEditorClient::checkGrammarOfString):
742         * WebCoreSupport/WebInspectorClient.cpp:
743         (WebInspectorFrontendClient::updateWindowTitle):
744         * WebLocalizableStrings.cpp:
745         (LocalizedString::operator LPCTSTR const):
746         * WebView.cpp:
747         (createContextMenuFromItems):
748         (WebView::setToolTip):
749         Use wchar helpers as needed.
750
751 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
752
753         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
754         https://bugs.webkit.org/show_bug.cgi?id=195053
755         <rdar://problem/48134710>
756
757         Reviewed by Ryosuke Niwa.
758
759         * WebCoreSupport/WebEditorClient.h:
760
761 2019-02-20  Darin Adler  <darin@apple.com>
762
763         Finish removing String::format
764         https://bugs.webkit.org/show_bug.cgi?id=194893
765
766         Reviewed by Daniel Bates.
767
768         * FullscreenVideoController.cpp:
769         (timeToString): Use makeString and pad.
770
771 2019-02-27  Simon Fraser  <simon.fraser@apple.com>
772
773         Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)
774
775         * FullscreenVideoController.cpp:
776         (timeToString):
777
778 2019-02-26  Philippe Normand  <pnormand@igalia.com>
779
780         [WPE] Add API for webview background color configuration
781         https://bugs.webkit.org/show_bug.cgi?id=192305
782
783         Reviewed by Michael Catanzaro.
784
785         * WebCoreSupport/WebFrameLoaderClient.cpp:
786         (WebFrameLoaderClient::transitionToCommittedForNewPage): Create
787         FrameView with background color.
788
789 2019-02-20  Darin Adler  <darin@apple.com>
790
791         Finish removing String::format
792         https://bugs.webkit.org/show_bug.cgi?id=194893
793
794         Reviewed by Daniel Bates.
795
796         * FullscreenVideoController.cpp:
797         (timeToString): Use makeString and pad.
798
799 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
800
801         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
802         https://bugs.webkit.org/show_bug.cgi?id=194703
803         <rdar://problem/48111775>
804
805         Reviewed by Ryosuke Niwa.
806
807         * WebCoreSupport/WebEditorClient.cpp:
808         (undoNameForEditAction):
809
810 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
811
812         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
813         https://bugs.webkit.org/show_bug.cgi?id=194670
814         <rdar://problem/39066529>
815
816         Reviewed by Tim Horton.
817
818         * WebCoreSupport/WebEditorClient.cpp:
819         (WebEditorClient::replacementURLForResource): Deleted.
820         * WebCoreSupport/WebEditorClient.h:
821
822 2019-02-10  Darin Adler  <darin@apple.com>
823
824         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
825         https://bugs.webkit.org/show_bug.cgi?id=194487
826
827         Reviewed by Daniel Bates.
828
829         * WebView.cpp:
830         (webKitVersionString): Use makeString instead of String::format.
831
832 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
833
834         Allow pages to trigger programmatic paste from script on iOS
835         https://bugs.webkit.org/show_bug.cgi?id=194271
836         <rdar://problem/47808810>
837
838         Reviewed by Ryosuke Niwa.
839
840         * WebCoreSupport/WebEditorClient.h:
841
842 2019-02-06  Daniel Bates  <dabates@apple.com>
843
844         Standardize on ControlKey instead of CtrlKey
845         https://bugs.webkit.org/show_bug.cgi?id=194317
846
847         Reviewed by Tim Horton.
848
849         * AccessibleBase.cpp:
850         (AccessibleBase::get_accKeyboardShortcut):
851         * WebView.cpp:
852         (WebView::keyDown):
853
854 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
855
856         PageOverlayController's layers should be created lazily
857         https://bugs.webkit.org/show_bug.cgi?id=194199
858         rdar://problem/46571593
859
860         Reviewed by Tim Horton.
861
862         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
863         and use them to only parent the overlay-hosting layers when necessary.
864
865         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
866         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
867         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
868         compositing updates that parents the layerWithDocumentOverlays().
869
870         View overlays are added to the layer tree via the DrawingArea. When we go between having
871         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
872         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
873         compositing flush (this has to be done manually because view overlay layers are outside the
874         subtree managed by RenderLayerCompositor).
875         
876         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
877         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
878         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
879         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
880
881         * WebCoreSupport/WebChromeClient.cpp:
882         (WebChromeClient::attachViewOverlayGraphicsLayer):
883         * WebCoreSupport/WebChromeClient.h:
884
885 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
886
887         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
888         https://bugs.webkit.org/show_bug.cgi?id=194189
889
890         Reviewed by Geoffrey Garen.
891
892         Pass the policy check identifier around functions and store it in WebFramePolicyListener
893         so that we can send it back to WebCore with the navigation policy decision.
894
895         * WebCoreSupport/WebFrameLoaderClient.cpp:
896         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
897         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
898         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
899         (WebFrameLoaderClient::dispatchWillSubmitForm):
900         (WebFrameLoaderClient::setUpPolicyListener):
901         * WebCoreSupport/WebFrameLoaderClient.h:
902
903 2019-01-31  Alex Christensen  <achristensen@webkit.org>
904
905         Revert r238819 which is unneeded and caused a performance regression.
906         https://bugs.webkit.org/show_bug.cgi?id=192272
907         <rdar://problem/46664625>
908
909         * WebCoreSupport/WebFrameLoaderClient.cpp:
910         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
911         * WebCoreSupport/WebFrameLoaderClient.h:
912
913 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
914
915         [Curl] Fix DRT crash related to private browsing.
916         https://bugs.webkit.org/show_bug.cgi?id=193816
917
918         Reviewed by Alex Christensen.
919
920         * WebCoreSupport/WebFrameNetworkingContext.cpp:
921         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
922
923 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
924
925         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
926         https://bugs.webkit.org/show_bug.cgi?id=193941
927
928         Reviewed by Alex Christensen.
929
930         * Plugins/PluginMessageThrottlerWin.cpp:
931         * Plugins/PluginView.cpp:
932         * Plugins/PluginViewWin.cpp:
933
934 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
935
936         Move FileSystem to WTF
937         https://bugs.webkit.org/show_bug.cgi?id=193602
938
939         Reviewed by Yusuke Suzuki.
940
941         * Plugins/PluginDatabase.cpp:
942         * Plugins/PluginPackage.h:
943         * Plugins/PluginStream.h:
944         * WebApplicationCache.cpp:
945         * WebDatabaseManager.cpp:
946         * WebDownloadCurl.cpp:
947         * WebPreferences.cpp:
948         * WebView.cpp:
949
950 2019-01-22  Alex Christensen  <achristensen@webkit.org>
951
952         Move NetworkStorageSession ownership to NetworkProcess
953         https://bugs.webkit.org/show_bug.cgi?id=193580
954
955         Reviewed by Geoff Garen.
956
957         * WebCoreSupport/WebFrameNetworkingContext.cpp:
958         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
959         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
960         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
961         (WebFrameNetworkingContext::storageSession const):
962         * WebDownloadCFNet.cpp:
963         (WebDownload::didReceiveAuthenticationChallenge):
964         * WebPreferences.cpp:
965         (WebPreferences::clearNetworkLoaderSession):
966         (WebPreferences::switchNetworkLoaderToNewTestingSession):
967
968 2019-01-15  Darin Adler  <darin@apple.com>
969
970         Use references rather than pointers for register/unregister functions, and more
971         https://bugs.webkit.org/show_bug.cgi?id=175028
972
973         Reviewed by Daniel Bates.
974
975         * Plugins/PluginView.cpp:
976         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
977         (WebCore::PluginView::~PluginView): Ditto.
978         * WebView.cpp:
979         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
980         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
981         (WebView::fullScreenClientDidExitFullScreen): Ditto.
982
983 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
984
985         [Win][HighDPI] Repaint glitches when scrolling.
986         https://bugs.webkit.org/show_bug.cgi?id=173152
987         <rdar://problem/45269953>
988
989         Reviewed by Brent Fulgham.
990
991         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
992         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
993         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
994
995         * WebView.cpp:
996         (WebView::scrollBackingStore):
997
998 2019-01-17  Alex Christensen  <achristensen@webkit.org>
999
1000         Stop using NetworkStorageSession::storageSession in WebCore
1001         https://bugs.webkit.org/show_bug.cgi?id=193529
1002
1003         Reviewed by Tim Horton.
1004
1005         * WebView.cpp:
1006         (WebView::initWithFrame):
1007
1008 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1009
1010         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1011         https://bugs.webkit.org/show_bug.cgi?id=193368
1012
1013         Reviewed by Geoff Garen.
1014
1015         * WebDownloadCFNet.cpp:
1016         (WebDownload::didReceiveAuthenticationChallenge):
1017
1018 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1019
1020         Fix Windows build after r240014
1021         https://bugs.webkit.org/show_bug.cgi?id=161106
1022
1023         * WebView.cpp:
1024
1025 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1026
1027         Stop using CookiesStrategy
1028         https://bugs.webkit.org/show_bug.cgi?id=161106
1029
1030         Reviewed by Don Olmstead and Antti Koivisto.
1031
1032         * Plugins/PluginView.cpp:
1033         (WebCore::PluginView::getValueForURL):
1034         (WebCore::PluginView::setValueForURL):
1035         * WebCoreSupport/WebPlatformStrategies.cpp:
1036         (WebPlatformStrategies::createBlobRegistry):
1037         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1038         (WebPlatformStrategies::cookiesForDOM): Deleted.
1039         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1040         (WebPlatformStrategies::cookiesEnabled): Deleted.
1041         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1042         (WebPlatformStrategies::getRawCookies): Deleted.
1043         (WebPlatformStrategies::deleteCookie): Deleted.
1044         * WebCoreSupport/WebPlatformStrategies.h:
1045         * WebView.cpp:
1046         (WebView::initWithFrame):
1047
1048 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1049
1050         Stop using NetworkStorageSession in WebProcess
1051         https://bugs.webkit.org/show_bug.cgi?id=193236
1052
1053         Reviewed by Don Olmstead.
1054
1055         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1056         (WebFrameNetworkingContext::storageSession const):
1057         * WebCoreSupport/WebFrameNetworkingContext.h:
1058         * WebCoreSupport/WebPlatformStrategies.cpp:
1059         (WebPlatformStrategies::cookiesForDOM):
1060         (WebPlatformStrategies::setCookiesFromDOM):
1061         (WebPlatformStrategies::cookiesEnabled):
1062         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1063         (WebPlatformStrategies::getRawCookies):
1064         (WebPlatformStrategies::deleteCookie):
1065         * WebCoreSupport/WebPlatformStrategies.h:
1066
1067 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1068
1069         Unreviewed, rolling out r239727.
1070
1071         Broke API tests
1072
1073         Reverted changeset:
1074
1075         "Stop using NetworkStorageSession in WebProcess"
1076         https://bugs.webkit.org/show_bug.cgi?id=193236
1077         https://trac.webkit.org/changeset/239727
1078
1079 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1080
1081         Remove "using namespace std;"
1082         https://bugs.webkit.org/show_bug.cgi?id=192973
1083
1084         Reviewed by Alex Christensen.
1085
1086         * FullscreenVideoController.cpp:
1087         * WebFrame.cpp:
1088         (WebFrame::drawFooter):
1089         * WebHistory.cpp:
1090         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
1091         * WebKitQuartzCoreAdditions/CAView.cpp:
1092         * WebView.cpp:
1093         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
1094         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
1095         (WebView::setCacheModel):
1096         (WebView::maxCacheModelInAnyInstance):
1097
1098 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1099
1100         Use Ref<> as much as possible
1101         https://bugs.webkit.org/show_bug.cgi?id=192808
1102
1103         Reviewed by Alex Christensen.
1104
1105         * Plugins/PluginDatabase.cpp:
1106         (WebCore::PluginDatabase::refresh):
1107         * Plugins/PluginView.cpp:
1108         (WebCore::PluginView::mediaCanStart):
1109         (WebCore::PluginView::performRequest):
1110         (WebCore::PluginView::bindingInstance):
1111         * Plugins/PluginView.h:
1112         * WebCoreSupport/WebFrameLoaderClient.cpp:
1113         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
1114         (WebFrameLoaderClient::createPlugin):
1115         (WebFrameLoaderClient::createJavaAppletWidget):
1116         * WebCoreSupport/WebFrameLoaderClient.h:
1117         * WebFrame.cpp:
1118         (WebFrame::loadData):
1119         (WebFrame::loadPlainTextString):
1120         (WebFrame::loadHTMLString):
1121         * WebFrame.h:
1122         * WebKitQuartzCoreAdditions/CAView.cpp:
1123         (WKQCA::CAView::create):
1124         * WebKitQuartzCoreAdditions/CAView.h:
1125         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
1126         (WKQCA::CVDisplayLink::create):
1127         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
1128         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
1129         (WKQCA::getImageCopy):
1130         * WebView.cpp:
1131         (WebView::addUserScriptToGroup):
1132         (WebView::addUserStyleSheetToGroup):
1133
1134 2018-12-20  Chris Dumez  <cdumez@apple.com>
1135
1136         Use Optional::valueOr() instead of Optional::value_or()
1137         https://bugs.webkit.org/show_bug.cgi?id=192933
1138
1139         Reviewed by Geoffrey Garen.
1140
1141         * WebSecurityOrigin.cpp:
1142         (WebSecurityOrigin::port):
1143
1144 2018-12-19  Chris Dumez  <cdumez@apple.com>
1145
1146         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1147         https://bugs.webkit.org/show_bug.cgi?id=192728
1148         <rdar://problem/46746779>
1149
1150         Reviewed by Geoff Garen.
1151
1152         * Plugins/*:
1153         * WebCoreSupport/*:
1154
1155 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1156
1157         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
1158         https://bugs.webkit.org/show_bug.cgi?id=192617
1159
1160         Reviewed by Alex Christensen.
1161
1162         * COMEnumVariant.h:
1163         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
1164         (COMEnumVariant<ContainerType>::createInstance): Ditto.
1165         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
1166         * COMPropertyBag.h:
1167         (HashType>::createInstance): Removed 'typename' from non dependent names.
1168         (HashType>::adopt): Ditto.
1169         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
1170         (HashType>::GetPropertyInfo): Ditto.
1171
1172 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1173
1174         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
1175         https://bugs.webkit.org/show_bug.cgi?id=192618
1176
1177         Reviewed by Alex Christensen.
1178
1179         Classes which implement COM interface usually doesn't need the
1180         virtual destructor because it has Release() virtual method to
1181         destruct itself.
1182
1183         Marked 'final' such classes to suppress clang-cl's compilation
1184         warnings.
1185
1186         * COMEnumVariant.h:
1187         * COMPropertyBag.h:
1188         * DefaultDownloadDelegate.h:
1189         * DefaultPolicyDelegate.h:
1190         * MemoryStream.h:
1191         * WebActionPropertyBag.h:
1192         * WebApplicationCache.h:
1193         * WebArchive.h:
1194         * WebBackForwardList.h:
1195         * WebCache.h:
1196         * WebCoreStatistics.h:
1197         * WebCoreSupport/WebEditorClient.cpp:
1198         * WebCoreSupport/WebInspectorDelegate.h:
1199         * WebDataSource.h:
1200         * WebDatabaseManager.cpp:
1201         * WebDatabaseManager.h:
1202         * WebDownload.h:
1203         * WebDropSource.h:
1204         * WebElementPropertyBag.h:
1205         * WebError.h:
1206         * WebFrame.cpp:
1207         * WebFrame.h:
1208         * WebFramePolicyListener.h:
1209         * WebGeolocationPolicyListener.h:
1210         * WebGeolocationPosition.h:
1211         * WebHTMLRepresentation.h:
1212         * WebHistory.h:
1213         * WebHistoryItem.h:
1214         * WebInspector.h:
1215         * WebJavaScriptCollector.h:
1216         * WebKitClassFactory.h:
1217         * WebKitMessageLoop.h:
1218         * WebKitStatistics.h:
1219         * WebMutableURLRequest.h:
1220         * WebNavigationData.h:
1221         * WebNotification.h:
1222         * WebNotificationCenter.h:
1223         * WebPreferences.h:
1224         * WebResource.h:
1225         * WebScriptWorld.h:
1226         * WebSecurityOrigin.h:
1227         * WebSerializedJSValue.h:
1228         * WebTextRenderer.h:
1229         * WebURLAuthenticationChallenge.h:
1230         * WebURLAuthenticationChallengeSender.h:
1231         * WebURLCredential.h:
1232         * WebURLProtectionSpace.h:
1233         * WebURLResponse.h:
1234         * WebUserContentURLPattern.h:
1235         * WebView.cpp:
1236         * WebView.h:
1237         * WebWorkersPrivate.h:
1238
1239 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1240
1241         [Win][Clang] Fix warning -Wmissing-field-initializers
1242         https://bugs.webkit.org/show_bug.cgi?id=192584
1243
1244         Reviewed by Yusuke Suzuki.
1245
1246         Initialize a struct with '{ }' instead of '= {0}'.
1247
1248         * WebKitMessageLoop.cpp:
1249         (WebKitMessageLoop::run):
1250         * WebView.cpp:
1251         (WebView::onMenuCommand):
1252         (WebView::gesture):
1253         (WebView::setShouldInvertColors):
1254         (WebView::initializeToolTipWindow):
1255         (WebView::setToolTip):
1256         (WebView::fullScreenClientForceRepaint):
1257
1258 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1259
1260         Turn WritingDirection into an enum class
1261         https://bugs.webkit.org/show_bug.cgi?id=192401
1262         Work towards <rdar://problem/42075638>
1263
1264         Reviewed by Dan Bernstein.
1265
1266         Change WritingDirection from an enum to an enum class. No change in behavior.
1267
1268         * WebFrame.cpp:
1269         (WebFrame::setTextDirection):
1270
1271 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1272
1273         Use WallTime for file time
1274         https://bugs.webkit.org/show_bug.cgi?id=192287
1275
1276         Reviewed by Darin Adler.
1277
1278         * Plugins/PluginDatabase.cpp:
1279         (WebCore::PluginDatabase::refresh):
1280
1281 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1282
1283         Fix Windows build.
1284
1285         * WebView.cpp:
1286
1287 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1288
1289         Fix Windows build.
1290
1291         * WebCoreSupport/WebFrameLoaderClient.h:
1292
1293 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1294
1295         Fix Windows build.
1296
1297         * WebCoreSupport/WebFrameLoaderClient.h:
1298
1299 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1300
1301         Move URL from WebCore to WTF
1302         https://bugs.webkit.org/show_bug.cgi?id=190234
1303
1304         Reviewed by Keith Miller.
1305
1306         * MarshallingHelpers.cpp:
1307         * MarshallingHelpers.h:
1308         * Plugins/PluginDatabase.cpp:
1309         * Plugins/PluginDatabase.h:
1310         * Plugins/PluginDatabaseWin.cpp:
1311         * Plugins/PluginStream.h:
1312         * Plugins/PluginView.h:
1313         * WebCoreSupport/WebContextMenuClient.h:
1314         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
1315         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
1316         * WebCoreSupport/WebFrameLoaderClient.h:
1317         * WebCoreSupport/WebPlatformStrategies.h:
1318         * WebCoreSupport/WebPluginInfoProvider.cpp:
1319         (WebPluginInfoProvider::webVisiblePluginInfo):
1320         * WebCoreSupport/WebPluginInfoProvider.h:
1321         * WebCoreSupport/WebVisitedLinkStore.h:
1322         * WebDataSource.cpp:
1323         * WebDownload.h:
1324         * WebElementPropertyBag.cpp:
1325         * WebFrame.h:
1326         * WebHistory.cpp:
1327         * WebHistory.h:
1328         * WebHistoryItem.cpp:
1329         * WebResource.cpp:
1330         (WebResource::WebResource):
1331         * WebResource.h:
1332         * WebSecurityOrigin.cpp:
1333         * WebURLResponse.cpp:
1334         (WebURLResponse::createInstance):
1335         * WebUserContentURLPattern.cpp:
1336         * WebView.h:
1337
1338 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1339
1340         Remove dead code from an earlier attempt at implementing safe browsing
1341         https://bugs.webkit.org/show_bug.cgi?id=192067
1342
1343         Reviewed by Chris Dumez.
1344
1345         * WebCoreSupport/WebFrameLoaderClient.cpp:
1346         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1347         * WebCoreSupport/WebFrameLoaderClient.h:
1348
1349 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1350
1351         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
1352         https://bugs.webkit.org/show_bug.cgi?id=191959
1353
1354         Reviewed by Alex Christensen.
1355
1356         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
1357
1358 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
1359
1360         [Win] Reduce the use of WKSI library calls: CoreAnimation
1361         https://bugs.webkit.org/show_bug.cgi?id=191777
1362         <rdar://problem/46140542>
1363
1364         Reviewed by Zalan Bujtas.
1365
1366         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
1367         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
1368         directives for WebKitSystemInterface.lib.
1369
1370         * FullscreenVideoController.cpp:
1371         * WebKitGraphics.cpp:
1372         * WebPreferences.cpp:
1373
1374 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1375
1376         Address post-review feedback after r238438
1377         https://bugs.webkit.org/show_bug.cgi?id=191913
1378
1379         Reviewed by Ryosuke Niwa.
1380
1381         * AccessibleTextImpl.cpp:
1382         (AccessibleText::replaceText):
1383
1384 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1385
1386         Web Inspector: "Reload Web Inspector" button no longer partially works
1387         https://bugs.webkit.org/show_bug.cgi?id=191773
1388         <rdar://problem/46139932>
1389
1390         Reviewed by Devin Rousso.
1391
1392         * WebCoreSupport/WebInspectorClient.cpp:
1393         (WebInspectorFrontendClient::reopen):
1394         * WebCoreSupport/WebInspectorClient.h:
1395
1396 2018-11-17  Devin Rousso  <drousso@apple.com>
1397
1398         Web Inspector: Network: add button to show system certificate dialog
1399         https://bugs.webkit.org/show_bug.cgi?id=191458
1400         <rdar://problem/45977019>
1401
1402         Reviewed by Joseph Pecoraro.
1403
1404         * WebCoreSupport/WebInspectorClient.h:
1405         * WebCoreSupport/WebInspectorClient.cpp:
1406         (WebInspectorFrontendClient::showCertificate): Added.
1407
1408 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
1409
1410         [Win] Reduce the use of WKSI library calls: CFNetwork
1411         https://bugs.webkit.org/show_bug.cgi?id=191718
1412         <rdar://problem/46108732>
1413
1414         Reviewed by Alex Christensen.
1415
1416         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
1417         make the same calls on Windows, like we did for iOS and macOS back in 2017.
1418
1419         * WebCache.cpp:
1420         (WebCache::cacheFolder):
1421         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1422         * WebCoreSupport/WebPlatformStrategies.cpp:
1423         * WebError.cpp:
1424         (WebError::localizedDescription):
1425         (WebError::sslPeerCertificate):
1426         * WebURLResponse.cpp:
1427         (WebURLResponse::sslPeerCertificate):
1428         (WebURLResponse::certificateDictionary const):
1429         * WebView.cpp:
1430         (WebView::setCacheModel):
1431
1432 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
1433
1434         [Win] Reduce the use of WKSI library calls: Font Handling
1435         https://bugs.webkit.org/show_bug.cgi?id=191701
1436         <rdar://problem/46104809>
1437
1438         Reviewed by Myles C. Maxfield.
1439
1440         Update to use the old font handling routines moved from WKSI to FontCascade.
1441
1442         * WebPreferences.cpp:
1443         (WebPreferences::setFontSmoothing):
1444         (WebPreferences::setFontSmoothingContrast):
1445         * WebView.cpp:
1446         (systemParameterChanged):
1447
1448 2018-11-14  Timothy Hatcher  <timothy@apple.com>
1449
1450         Default the view background color and text color to different values when in dark mode.
1451         https://bugs.webkit.org/show_bug.cgi?id=191607
1452         rdar://problem/46045854
1453
1454         Reviewed by Dean Jackson.
1455
1456         * WebFrame.cpp:
1457         (WebFrame::updateBackground): Drop backgroundColor.
1458         * WebCoreSupport/WebFrameLoaderClient.cpp:
1459         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
1460
1461 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1462
1463         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1464         https://bugs.webkit.org/show_bug.cgi?id=191612
1465
1466         Reviewed by Matt Baker.
1467
1468         * WebCoreSupport/WebInspectorClient.cpp:
1469         (WebInspectorFrontendClient::destroyInspectorView):
1470
1471 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1472
1473         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1474         https://bugs.webkit.org/show_bug.cgi?id=189230
1475         <rdar://problem/44050379>
1476
1477         Reviewed by Joseph Pecoraro.
1478
1479         Runs all png images through zopflipng. This results in a smaller file
1480         size and takes care of this issue as a byproduct.
1481
1482         * WebKit.resources/deleteButton.png:
1483         * WebKit.resources/deleteButtonPressed.png:
1484         * WebKit.resources/fsVideoAudioVolumeHigh.png:
1485         * WebKit.resources/fsVideoAudioVolumeLow.png:
1486         * WebKit.resources/fsVideoExitFullscreen.png:
1487         * WebKit.resources/fsVideoPause.png:
1488         * WebKit.resources/fsVideoPlay.png:
1489         * WebKit.resources/missingImage.png:
1490         * WebKit.resources/nullplugin.png:
1491         * WebKit.resources/panEastCursor.png:
1492         * WebKit.resources/panIcon.png:
1493         * WebKit.resources/panNorthCursor.png:
1494         * WebKit.resources/panNorthEastCursor.png:
1495         * WebKit.resources/panNorthWestCursor.png:
1496         * WebKit.resources/panSouthCursor.png:
1497         * WebKit.resources/panSouthEastCursor.png:
1498         * WebKit.resources/panSouthWestCursor.png:
1499         * WebKit.resources/panWestCursor.png:
1500         * WebKit.resources/searchCancel.png:
1501         * WebKit.resources/searchCancelPressed.png:
1502         * WebKit.resources/searchMagnifier.png:
1503         * WebKit.resources/searchMagnifierResults.png:
1504         * WebKit.resources/textAreaResizeCorner.png:
1505         * WebKit.resources/verticalTextCursor.png:
1506         * WebKit.resources/zoomInCursor.png:
1507         * WebKit.resources/zoomOutCursor.png:
1508
1509 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1510
1511         Unreviewed Windows build fix for r238049.
1512
1513         * WebView.cpp:
1514         (WebView::initWithFrame):
1515
1516 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1517
1518         Unreviewed MSVC build fix after r238039 (and r238046).
1519
1520         * WebDocumentLoader.h:
1521         * WebView.cpp:
1522         (WebView::setShouldApplyMacFontAscentHack):
1523
1524 2018-11-09  Antti Koivisto  <antti@apple.com>
1525
1526         Use OptionSet for layout milestones
1527         https://bugs.webkit.org/show_bug.cgi?id=191470
1528
1529         Reviewed by Dean Jackson.
1530
1531         * WebCoreSupport/WebFrameLoaderClient.cpp:
1532         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1533         * WebCoreSupport/WebFrameLoaderClient.h:
1534
1535 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1536
1537         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1538         https://bugs.webkit.org/show_bug.cgi?id=191455
1539
1540         Reviewed by Brent Fulgham.
1541
1542         * WebHistory.h: Marked with 'override' and removed 'virtual'.
1543
1544 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1545
1546         Add a storage limit for IndexedDB
1547         https://bugs.webkit.org/show_bug.cgi?id=190598
1548         <rdar://problem/44654715>
1549
1550         Reviewed by Chris Dumez.
1551
1552         * Interfaces/IWebDatabaseManager.idl:
1553         * WebDatabaseManager.cpp:
1554         (WebDatabaseManager::setIDBPerOriginQuota):
1555         * WebDatabaseManager.h:
1556
1557 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1558
1559         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
1560         https://bugs.webkit.org/show_bug.cgi?id=191105
1561
1562         Reviewed by Brent Fulgham.
1563
1564         * DOMHTMLClasses.h:
1565         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
1566         instead of own setNodeValue.
1567
1568 2018-10-25  Antoine Quint  <graouts@apple.com>
1569
1570         [Web Animations] Turn Web Animations CSS Integration off by default
1571         https://bugs.webkit.org/show_bug.cgi?id=190901
1572
1573         Reviewed by Dean Jackson.
1574
1575         * WebPreferences.cpp:
1576         (WebPreferences::initializeDefaultSettings):
1577
1578 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1579
1580         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1581         https://bugs.webkit.org/show_bug.cgi?id=190744
1582
1583         Reviewed by Alex Christensen.
1584
1585         clang-cl reports compilation warnings for inconsistent 'override'
1586         keyword usage.
1587
1588         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
1589         This can't be marked 'override' if !USE(CA).
1590
1591         * WebView.cpp:
1592         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
1593         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
1594         Declare flushPendingGraphicsLayerChanges only if USE(CA).
1595
1596 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1597
1598         Clean up FrameLoader two-state enums
1599         https://bugs.webkit.org/show_bug.cgi?id=190731
1600
1601         Reviewed by Chris Dumez.
1602
1603         * WebCoreSupport/WebFrameLoaderClient.cpp:
1604         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1605         * WebCoreSupport/WebFrameLoaderClient.h:
1606
1607 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1608
1609         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1610         https://bugs.webkit.org/show_bug.cgi?id=190675
1611
1612         Reviewed by Chris Dumez.
1613
1614         * BackForwardList.cpp:
1615         (BackForwardList::backItem):
1616         (BackForwardList::currentItem):
1617         (BackForwardList::forwardItem):
1618         (BackForwardList::backListCount const):
1619         (BackForwardList::forwardListCount const):
1620         (BackForwardList::itemAtIndex):
1621         * BackForwardList.h:
1622
1623 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
1624
1625         Unreviewed attempt to fix the Windows build after r237112.
1626
1627         * Plugins/PluginView.cpp:
1628         (WebCore::PluginView::performRequest):
1629
1630 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1631
1632         Replace HistoryItem* with HistoryItem& where possible
1633         https://bugs.webkit.org/show_bug.cgi?id=190617
1634
1635         Reviewed by Chris Dumez.
1636
1637         * BackForwardList.cpp:
1638         (BackForwardList::goToItem):
1639         * BackForwardList.h:
1640         * WebBackForwardList.cpp:
1641         (WebBackForwardList::goToItem):
1642
1643 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1644
1645         Fix Windows build.
1646
1647         * WebView.cpp:
1648         (WebView::loadBackForwardListFromOtherView):
1649
1650 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1651
1652         Fix WinCairo build.
1653
1654         * WebView.cpp:
1655         (WebView::backForwardList):
1656
1657 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1658
1659         Modernize BackForwardClient.h
1660         https://bugs.webkit.org/show_bug.cgi?id=190610
1661
1662         Reviewed by Chris Dumez.
1663
1664         * BackForwardList.cpp:
1665         (BackForwardList::backListCount const):
1666         (BackForwardList::forwardListCount const):
1667         (BackForwardList::backListCount): Deleted.
1668         (BackForwardList::forwardListCount): Deleted.
1669         * BackForwardList.h:
1670         * WebView.cpp:
1671         (WebView::initWithFrame):
1672         (WebView::backForwardList):
1673
1674 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1675
1676         Remove unused WebView._globalHistoryItem
1677         https://bugs.webkit.org/show_bug.cgi?id=190601
1678
1679         Reviewed by Chris Dumez.
1680
1681         * WebCoreSupport/WebFrameLoaderClient.cpp:
1682         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1683         * WebCoreSupport/WebFrameLoaderClient.h:
1684         * WebView.cpp:
1685         (WebView::globalHistoryItem):
1686         (WebView::setGlobalHistoryItem): Deleted.
1687         * WebView.h:
1688
1689 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1690
1691         Remove unused parameters from FrameLoaderClient::createFrame
1692         https://bugs.webkit.org/show_bug.cgi?id=190587
1693
1694         Reviewed by Chris Dumez.
1695
1696         * WebCoreSupport/WebFrameLoaderClient.cpp:
1697         (WebFrameLoaderClient::createFrame):
1698         * WebCoreSupport/WebFrameLoaderClient.h:
1699
1700 2018-10-15  Chris Dumez  <cdumez@apple.com>
1701
1702         Unreviewed Windows build fix after r237112.
1703
1704         * Plugins/PluginView.cpp:
1705         (WebCore::PluginView::performRequest):
1706         (WebCore::PluginView::load):
1707
1708 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1709
1710         Remove InjectedBundle processing of back/forward lists
1711         https://bugs.webkit.org/show_bug.cgi?id=190459
1712
1713         Reviewed by Chris Dumez.
1714
1715         * WebCoreSupport/WebFrameLoaderClient.cpp:
1716         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1717         * WebCoreSupport/WebFrameLoaderClient.h:
1718
1719 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1720
1721         Remove ParsedURLString
1722         https://bugs.webkit.org/show_bug.cgi?id=190154
1723
1724         Reviewed by Chris Dumez.
1725
1726         * WebDownloadCurl.cpp:
1727         (WebDownload::initWithRequest):
1728         * WebURLResponse.cpp:
1729         (WebURLResponse::createInstance):
1730
1731 2018-09-28  Chris Dumez  <cdumez@apple.com>
1732
1733         Drop support for cross-origin-window-policy header
1734         https://bugs.webkit.org/show_bug.cgi?id=190081
1735
1736         Reviewed by Ryosuke Niwa.
1737
1738         * WebPreferenceKeysPrivate.h:
1739         * WebPreferences.cpp:
1740         (WebPreferences::initializeDefaultSettings):
1741         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1742         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1743         * WebView.cpp:
1744         (WebView::notifyPreferencesChanged):
1745
1746 2018-09-27  Antoine Quint  <graouts@apple.com>
1747
1748         [Web Animations] Turn Web Animations with CSS integration on
1749         https://bugs.webkit.org/show_bug.cgi?id=184819
1750         <rdar://problem/39597337>
1751
1752         Reviewed by Dean Jackson.
1753
1754         * WebPreferences.cpp:
1755         (WebPreferences::initializeDefaultSettings):
1756
1757 2018-09-21  Alex Christensen  <achristensen@webkit.org>
1758
1759         Use a Variant for FormDataElement
1760         https://bugs.webkit.org/show_bug.cgi?id=189777
1761
1762         Reviewed by Chris Dumez.
1763
1764         * WebMutableURLRequest.cpp:
1765         (WebMutableURLRequest::setHTTPBody):
1766
1767 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1768
1769         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
1770         https://bugs.webkit.org/show_bug.cgi?id=189612
1771
1772         Reviewed by Alex Christensen.
1773
1774         Non-trivial types can't be used as aruguments of LOG_ERROR and
1775         ASSERT_WITH_MESSAGE.
1776
1777         * DefaultPolicyDelegate.cpp:
1778         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
1779         static_cast<BSTR> to convert BString.
1780         * WebLocalizableStrings.cpp:
1781         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
1782         char* by using 'key.utf8().data()'.
1783
1784 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
1785
1786         Unreviewed, rolling out r235953.
1787
1788         Caused layout test crashes under GuardMalloc.
1789
1790         Reverted changeset:
1791
1792         "Make GraphicsLayers ref-counted, so their tree can persist
1793         when disconnected from RenderLayerBackings"
1794         https://bugs.webkit.org/show_bug.cgi?id=189521
1795         https://trac.webkit.org/changeset/235953
1796
1797 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1798
1799         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
1800         https://bugs.webkit.org/show_bug.cgi?id=189538
1801
1802         Reviewed by Per Arne Vollan.
1803
1804         * WebPreferences.cpp:
1805         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
1806         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
1807         Apply static_cast to the result of OR-ed CFPropertyListFormat.
1808         (WebPreferences::screenFontSubstitutionEnabled):
1809         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
1810
1811 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1812
1813         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
1814         https://bugs.webkit.org/show_bug.cgi?id=189539
1815
1816         Reviewed by Alex Christensen.
1817
1818         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
1819         * WebCoreSupport/WebInspectorClient.cpp:
1820         (WebInspectorWndProc): Ditto.
1821         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
1822         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
1823
1824 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1825
1826         Refactor WebCore::EditAction to be an 8-bit enum class
1827         https://bugs.webkit.org/show_bug.cgi?id=189383
1828
1829         Reviewed by Dan Bernstein.
1830
1831         * WebCoreSupport/WebEditorClient.cpp:
1832         (undoNameForEditAction):
1833
1834 2018-09-04  Frederic Wang  <fwang@igalia.com>
1835
1836         Add basic support for ScrollIntoViewOptions
1837         https://bugs.webkit.org/show_bug.cgi?id=189258
1838
1839         Reviewed by Simon Fraser.
1840
1841         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
1842         can build despite the new scrollIntoView function.
1843
1844 2018-08-31  Chris Dumez  <cdumez@apple.com>
1845
1846         Unreviewed Windows build fix after r235562.
1847
1848         * WebCoreSupport/WebFrameLoaderClient.cpp:
1849         (WebFrameLoaderClient::dispatchWillSubmitForm):
1850
1851 2018-08-31  Chris Dumez  <cdumez@apple.com>
1852
1853         Assertion hit in ~CompletionHandler() from ~WebFrame()
1854         https://bugs.webkit.org/show_bug.cgi?id=189199
1855         <rdar://problem/42657233>
1856
1857         Reviewed by Youenn Fablet.
1858
1859         * WebCoreSupport/WebFrameLoaderClient.cpp:
1860         (WebFrameLoaderClient::dispatchWillSubmitForm):
1861         * WebCoreSupport/WebFrameLoaderClient.h:
1862
1863 2018-08-31  Frederic Wang  <fwang@igalia.com>
1864
1865         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1866         https://bugs.webkit.org/show_bug.cgi?id=182053
1867
1868         Reviewed by Simon Fraser.
1869
1870         Add developer flag to use standard behavior for scrolling* attributes.
1871
1872         * Interfaces/IWebPreferencesPrivate.idl:
1873         * WebPreferenceKeysPrivate.h:
1874         * WebPreferences.cpp:
1875         (WebPreferences::initializeDefaultSettings):
1876         (WebPreferences::CSSOMViewScrollingAPIEnabled):
1877         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
1878         * WebPreferences.h:
1879         * WebView.cpp:
1880         (WebView::notifyPreferencesChanged):
1881
1882 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
1883
1884         [CMake] Replace AVFoundationSupport.py using CMake
1885         https://bugs.webkit.org/show_bug.cgi?id=182891
1886
1887         Reviewed by Per Arne Vollan.
1888
1889         Remove references to the config.h contained in WebCore as it should
1890         not be accessible from outside of WebCore.
1891
1892         * WebKitPrefix.h:
1893
1894 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1895
1896         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1897         https://bugs.webkit.org/show_bug.cgi?id=188496
1898         <rdar://problem/43216836>
1899
1900         Reviewed by Tim Horton.
1901
1902         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
1903         header directly.
1904
1905         * WebCoreSupport/WebDragClient.cpp:
1906
1907 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1908
1909         Add some plumbing for safe browsing
1910         https://bugs.webkit.org/show_bug.cgi?id=188709
1911
1912         Reviewed by Tim Horton.
1913
1914         * WebCoreSupport/WebFrameLoaderClient.cpp:
1915         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1916         * WebCoreSupport/WebFrameLoaderClient.h:
1917
1918 2018-08-02  David Fenton  <david_fenton@apple.com>
1919
1920         Unreviewed, rolling out r234489.
1921
1922         Caused 50+ crashes and 60+ API failures on iOS
1923
1924         Reverted changeset:
1925
1926         "[WTF] Rename String::format to String::deprecatedFormat"
1927         https://bugs.webkit.org/show_bug.cgi?id=188191
1928         https://trac.webkit.org/changeset/234489
1929
1930 2018-08-01  Tomas Popela  <tpopela@redhat.com>
1931
1932         [WTF] Rename String::format to String::deprecatedFormat
1933         https://bugs.webkit.org/show_bug.cgi?id=188191
1934
1935         Reviewed by Darin Adler.
1936
1937         It should be replaced with string concatenation.
1938
1939         * FullscreenVideoController.cpp:
1940         (timeToString):
1941         * WebView.cpp:
1942         (webKitVersionString):
1943
1944 2018-07-30  Rob Buis  <rbuis@igalia.com>
1945
1946         https://bugs.webkit.org/show_bug.cgi?id=188137
1947         Merge PlatformCookieJar functions into NetworkStorageSession
1948
1949         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1950
1951         Reviewed by Alex Christensen.
1952
1953         * WebCoreSupport/WebPlatformStrategies.cpp:
1954         (WebPlatformStrategies::cookiesForDOM):
1955         (WebPlatformStrategies::setCookiesFromDOM):
1956         (WebPlatformStrategies::cookiesEnabled):
1957         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1958         (WebPlatformStrategies::getRawCookies):
1959         (WebPlatformStrategies::deleteCookie):
1960         * WebPreferences.cpp:
1961         (WebPreferences::clearNetworkLoaderSession):
1962
1963 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1964
1965         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1966         https://bugs.webkit.org/show_bug.cgi?id=187963
1967
1968         Reviewed by Alex Christensen.
1969
1970         * Plugins/PluginPackageWin.cpp:
1971         (WebCore::PluginPackage::fetchInfo):
1972         Update split/splitAllowingEmptyEntries usage.
1973
1974 2018-07-18  Antoine Quint  <graouts@apple.com>
1975
1976         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
1977         https://bugs.webkit.org/show_bug.cgi?id=187722
1978
1979         Reviewed by Myles Maxfield.
1980
1981         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
1982
1983         * DOMCoreClasses.cpp:
1984         (DOMElement::font):
1985
1986 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1987
1988         Disable cross-origin-window-policy by default
1989         https://bugs.webkit.org/show_bug.cgi?id=187509
1990
1991         Reviewed by Chris Dumez.
1992
1993         * WebPreferences.cpp:
1994         (WebPreferences::initializeDefaultSettings):
1995
1996 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1997
1998         [WTF] Add user-defined literal for ASCIILiteral
1999         https://bugs.webkit.org/show_bug.cgi?id=186839
2000
2001         Reviewed by Darin Adler.
2002
2003         * Plugins/PluginStream.cpp:
2004         (WebCore::PluginStream::startStream):
2005         * WebCoreSupport/WebContextMenuClient.cpp:
2006         (WebContextMenuClient::searchWithGoogle):
2007
2008 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2009
2010         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
2011         https://bugs.webkit.org/show_bug.cgi?id=186623
2012
2013         Reviewed by Youenn Fablet.
2014
2015         * WebCoreSupport/WebPluginInfoProvider.cpp:
2016         (WebPluginInfoProvider::pluginInfo):
2017         (WebPluginInfoProvider::webVisiblePluginInfo):
2018         * WebCoreSupport/WebPluginInfoProvider.h:
2019
2020 2018-06-13  Chris Dumez  <cdumez@apple.com>
2021
2022         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
2023         https://bugs.webkit.org/show_bug.cgi?id=186545
2024
2025         Reviewed by Brady Eidson.
2026
2027         Update client delegate now that parameter type has changed.
2028
2029         * WebCoreSupport/WebFrameLoaderClient.cpp:
2030         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2031         * WebCoreSupport/WebFrameLoaderClient.h:
2032
2033 2018-06-11  Chris Dumez  <cdumez@apple.com>
2034
2035         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
2036         https://bugs.webkit.org/show_bug.cgi?id=186441
2037
2038         Reviewed by Brady Eidson.
2039
2040         Rename existing flag to something a bit more generic, now that it is used for
2041         more things than bypassing the navigation policy check.
2042
2043         * WebView.cpp:
2044         (WebView::goToBackForwardItem):
2045         (WebView::loadBackForwardListFromOtherView):
2046
2047 2018-06-04  Chris Dumez  <cdumez@apple.com>
2048
2049         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2050         https://bugs.webkit.org/show_bug.cgi?id=186287
2051         <rdar://problem/40783352>
2052
2053         Reviewed by Youenn Fablet.
2054
2055         * Interfaces/IWebPreferencesPrivate.idl:
2056         * WebPreferenceKeysPrivate.h:
2057         * WebPreferences.cpp:
2058         (WebPreferences::initializeDefaultSettings):
2059         (WebPreferences::crossOriginWindowPolicySupportEnabled):
2060         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
2061         * WebPreferences.h:
2062         * WebView.cpp:
2063         (WebView::notifyPreferencesChanged):
2064
2065 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2066
2067         [JSC] Pass VM& parameter as much as possible
2068         https://bugs.webkit.org/show_bug.cgi?id=186085
2069
2070         Reviewed by Saam Barati.
2071
2072         * Plugins/PluginPackage.cpp:
2073         (WebCore::NPN_Invoke):
2074
2075 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2076
2077         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
2078         https://bugs.webkit.org/show_bug.cgi?id=186125
2079
2080         Unreviewed build fix
2081
2082         * WebActionPropertyBag.cpp:
2083         (WebActionPropertyBag::Read):
2084         (findMouseEvent): Deleted.
2085
2086 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
2087
2088         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
2089         https://bugs.webkit.org/show_bug.cgi?id=186027
2090
2091         Unreviewed build fix
2092
2093         * WebMutableURLRequest.cpp:
2094         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
2095         (WebMutableURLRequest::setClientCertificate):
2096
2097 2018-05-25  Chris Dumez  <cdumez@apple.com>
2098
2099         Minor ApplicationCacheStorage clean up
2100         https://bugs.webkit.org/show_bug.cgi?id=185984
2101
2102         Reviewed by Youenn Fablet.
2103
2104         * WebApplicationCache.cpp:
2105         (WebApplicationCache::originsWithCache):
2106
2107 2018-05-24  Chris Dumez  <cdumez@apple.com>
2108
2109         Reduce copying of FontCascadeDescription objects by moving them around
2110         https://bugs.webkit.org/show_bug.cgi?id=185963
2111
2112         Reviewed by Simon Fraser.
2113
2114         Reduce copying of FontCascadeDescription objects by moving them around when possible.
2115
2116         * FullscreenVideoController.cpp:
2117         (FullscreenVideoController::draw):
2118
2119 2018-05-15  Antoine Quint  <graouts@apple.com>
2120
2121         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2122         https://bugs.webkit.org/show_bug.cgi?id=185647
2123
2124         Reviewed by Dean Jackson.
2125
2126         Rename the Web Animations CSS integration flag.
2127
2128         * Interfaces/IWebPreferencesPrivate.idl:
2129         * WebPreferenceKeysPrivate.h:
2130         * WebPreferences.cpp:
2131         (WebPreferences::initializeDefaultSettings):
2132         (WebPreferences::webAnimationsCSSIntegrationEnabled):
2133         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
2134         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
2135         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
2136         * WebPreferences.h:
2137         * WebView.cpp:
2138         (WebView::notifyPreferencesChanged):
2139
2140 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2141
2142         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
2143         https://bugs.webkit.org/show_bug.cgi?id=185505
2144
2145         Unreviewed serious crash fix
2146
2147         Windows port crashes soon since Bug 184996.
2148
2149         * WebPreferences.cpp:
2150         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
2151         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
2152
2153 2018-05-07  Daniel Bates  <dabates@apple.com>
2154
2155         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2156         https://bugs.webkit.org/show_bug.cgi?id=185170
2157
2158         Reviewed by Per Arne Vollan.
2159
2160         * WebCache.cpp:
2161         (WebCache::empty):
2162
2163 2018-04-27  Chris Dumez  <cdumez@apple.com>
2164
2165         Use WindowProxy instead of DOMWindow in our IDL
2166         https://bugs.webkit.org/show_bug.cgi?id=185022
2167
2168         Reviewed by Sam Weinig.
2169
2170         * DOMCoreClasses.cpp:
2171         (DOMDocument::getComputedStyle):
2172
2173 2018-04-23  Daniel Bates  <dabates@apple.com>
2174
2175         Implement Same-Site cookies
2176         https://bugs.webkit.org/show_bug.cgi?id=159464
2177         <rdar://problem/27196358>
2178
2179         Reviewed by Brent Fulgham.
2180
2181         Pass the Same-Site info through the strategy.
2182
2183         * WebCoreSupport/WebPlatformStrategies.cpp:
2184         (WebPlatformStrategies::cookiesForDOM):
2185         (WebPlatformStrategies::setCookiesFromDOM):
2186         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2187         (WebPlatformStrategies::getRawCookies):
2188         * WebCoreSupport/WebPlatformStrategies.h:
2189
2190 2018-04-23  Daniel Bates  <dabates@apple.com>
2191
2192         Implement Same-Site cookies
2193         https://bugs.webkit.org/show_bug.cgi?id=159464
2194         <rdar://problem/27196358>
2195
2196         Reviewed by Brent Fulgham.
2197
2198         Pass the Same-Site info through the strategy.
2199
2200         * WebCoreSupport/WebPlatformStrategies.cpp:
2201         (WebPlatformStrategies::cookiesForDOM):
2202         (WebPlatformStrategies::setCookiesFromDOM):
2203         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2204         (WebPlatformStrategies::getRawCookies):
2205         * WebCoreSupport/WebPlatformStrategies.h:
2206
2207 2018-04-20  Youenn Fablet  <youenn@apple.com>
2208
2209         Make PluginData cache its web visible plugins
2210         https://bugs.webkit.org/show_bug.cgi?id=184421
2211
2212         Reviewed by Chris Dumez.
2213
2214         * WebCoreSupport/WebPluginInfoProvider.cpp:
2215         (WebPluginInfoProvider::pluginInfo):
2216         (WebPluginInfoProvider::webVisiblePluginInfo):
2217         * WebCoreSupport/WebPluginInfoProvider.h:
2218
2219 2018-04-19  Chris Dumez  <cdumez@apple.com>
2220
2221         Rename JSDOMWindowProxy to JSWindowProxy
2222         https://bugs.webkit.org/show_bug.cgi?id=184797
2223
2224         Reviewed by Sam Weinig.
2225
2226         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2227
2228         * WebFrame.cpp:
2229         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2230
2231 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2232
2233         Unreviewed rollout of r230632. Regression in memory usage.
2234
2235         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2236
2237         * WebPreferences.cpp:
2238         (WebPreferences::initializeDefaultSettings):
2239
2240 2018-04-17  Chris Dumez  <cdumez@apple.com>
2241
2242         Unreviewed attempt to fix the Windows build after r230721
2243
2244         * WebCoreSupport/WebFrameLoaderClient.cpp:
2245         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2246
2247 2018-04-17  Chris Dumez  <cdumez@apple.com>
2248
2249         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2250         https://bugs.webkit.org/show_bug.cgi?id=184678
2251         <rdar://problem/39422122>
2252
2253         Reviewed by Alex Christensen.
2254
2255         Add new parameter to dispatchDecidePolicyForNavigationAction.
2256
2257         * WebCoreSupport/WebFrameLoaderClient.cpp:
2258         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2259         * WebCoreSupport/WebFrameLoaderClient.h:
2260
2261 2018-04-12  Antoine Quint  <graouts@apple.com>
2262
2263         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2264         https://bugs.webkit.org/show_bug.cgi?id=184569
2265         <rdar://problem/38671301>
2266
2267         Reviewed by Jon Lee.
2268
2269         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
2270
2271         * WebPreferences.cpp:
2272
2273 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2274
2275         [WTF] Remove StaticLock
2276         https://bugs.webkit.org/show_bug.cgi?id=184332
2277
2278         Reviewed by Mark Lam.
2279
2280         * WebKitQuartzCoreAdditions/CAView.cpp:
2281         (WKQCA::CAView::releaseAllD3DResources):
2282         * WebLocalizableStrings.cpp:
2283
2284 2018-04-03  Chris Dumez  <cdumez@apple.com>
2285
2286         Drop MainFrame class
2287         https://bugs.webkit.org/show_bug.cgi?id=184191
2288
2289         Reviewed by Darin Adler.
2290
2291         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2292         relationship between the Page and the MainFrame.
2293
2294         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2295
2296         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2297         * WebCoreSupport/WebContextMenuClient.cpp:
2298         * WebCoreSupport/WebDragClient.cpp:
2299         * WebDropSource.cpp:
2300         * WebFrame.cpp:
2301         * WebView.cpp:
2302
2303 2018-03-26  Chris Dumez  <cdumez@apple.com>
2304
2305         Use SecurityOriginData more consistently in Service Worker code
2306         https://bugs.webkit.org/show_bug.cgi?id=183969
2307
2308         Reviewed by Darin Adler.
2309
2310         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2311
2312         * WebDatabaseManager.cpp:
2313         (WebDatabaseManager::databasesWithOrigin):
2314         (WebDatabaseManager::deleteOrigin):
2315         (WebDatabaseManager::deleteDatabase):
2316         (WebDatabaseManager::setQuota):
2317         * WebSecurityOrigin.cpp:
2318         (WebSecurityOrigin::usage):
2319         (WebSecurityOrigin::quota):
2320         (WebSecurityOrigin::setQuota):
2321
2322 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2323
2324         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
2325         https://bugs.webkit.org/show_bug.cgi?id=183911
2326         <rdar://problem/38762306>
2327
2328         Reviewed by Youenn Fablet.
2329
2330         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
2331
2332         * WebView.cpp:
2333         (WebView::WebView):
2334
2335 2018-03-25  Commit Queue  <commit-queue@webkit.org>
2336
2337         Unreviewed, rolling out r229954.
2338         https://bugs.webkit.org/show_bug.cgi?id=184000
2339
2340         Caused many layout tests to crash on Apple High Sierra,
2341         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
2342         by dydz on #webkit).
2343
2344         Reverted changeset:
2345
2346         "Use SecurityOriginData more consistently in Service Worker
2347         code"
2348         https://bugs.webkit.org/show_bug.cgi?id=183969
2349         https://trac.webkit.org/changeset/229954
2350
2351 2018-03-24  Chris Dumez  <cdumez@apple.com>
2352
2353         Use SecurityOriginData more consistently in Service Worker code
2354         https://bugs.webkit.org/show_bug.cgi?id=183969
2355
2356         Reviewed by Darin Adler.
2357
2358         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2359
2360         * WebDatabaseManager.cpp:
2361         (WebDatabaseManager::databasesWithOrigin):
2362         (WebDatabaseManager::deleteOrigin):
2363         (WebDatabaseManager::deleteDatabase):
2364         (WebDatabaseManager::setQuota):
2365         * WebSecurityOrigin.cpp:
2366         (WebSecurityOrigin::usage):
2367         (WebSecurityOrigin::quota):
2368         (WebSecurityOrigin::setQuota):
2369
2370 2018-03-23  Chris Dumez  <cdumez@apple.com>
2371
2372         Unreviewed attempt to fix Windows build after r229926.
2373
2374         * WebView.cpp:
2375
2376 2018-03-23  Brady Eidson  <beidson@apple.com>
2377
2378         Go to back/forward list items after a process-swapped navigation.
2379         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
2380
2381         Reviewed by Andy Estes.
2382
2383         * WebView.cpp:
2384         (WebView::goToBackForwardItem):
2385         (WebView::loadBackForwardListFromOtherView):
2386
2387 2018-03-23  Miguel Gomez  <magomez@igalia.com>
2388
2389         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
2390         https://bugs.webkit.org/show_bug.cgi?id=183892
2391
2392         Remove the UpdateContentsFlag parameter as it's not used anymore.
2393
2394         Reviewed by Žan Doberšek.
2395
2396         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2397         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
2398
2399 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
2400
2401         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
2402         https://bugs.webkit.org/show_bug.cgi?id=183335
2403
2404         Reviewed by Alex Christensen.
2405
2406         * Plugins/PluginDatabaseWin.cpp:
2407         * Plugins/PluginMessageThrottlerWin.cpp:
2408         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
2409         * Plugins/PluginPackageWin.cpp:
2410         (WebCore::PluginPackage::load):
2411         * Plugins/PluginView.h:
2412         * Plugins/PluginViewWin.cpp:
2413         * Plugins/npapi.cpp:
2414         * WebCoreSupport/WebFrameLoaderClient.cpp:
2415         (WebFrameLoaderClient::createPlugin):
2416         (WebFrameLoaderClient::createJavaAppletWidget):
2417         * WebView.cpp:
2418         (WebView::WebViewWndProc):
2419
2420 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
2421
2422         [Win] Layout Test fast/html/menuitem-element.html is failing.
2423         https://bugs.webkit.org/show_bug.cgi?id=179299
2424
2425         Reviewed by Per Arne Vollan.
2426
2427         * Interfaces/IWebPreferencesPrivate.idl:
2428         * WebPreferenceKeysPrivate.h:
2429         * WebPreferences.cpp:
2430         (WebPreferences::menuItemElementEnabled):
2431         (WebPreferences::setMenuItemElementEnabled):
2432         * WebPreferences.h:
2433         * WebView.cpp:
2434         (WebView::notifyPreferencesChanged):
2435         Add private web preference "menuItemElementEnabled".
2436
2437 2018-03-12  Antoine Quint  <graouts@apple.com>
2438
2439         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
2440         https://bugs.webkit.org/show_bug.cgi?id=183504
2441         <rdar://problem/38372965>
2442
2443         Reviewed by Dean Jackson and Jon Lee.
2444
2445         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
2446         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
2447
2448         * Interfaces/IWebPreferencesPrivate.idl:
2449         * WebPreferences.cpp:
2450         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2451         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2452         * WebPreferenceKeysPrivate.h
2453         * WebPreferences.h:
2454         * WebView.cpp:
2455         (WebView::notifyPreferencesChanged):
2456
2457 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2458
2459         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
2460         https://bugs.webkit.org/show_bug.cgi?id=183429
2461
2462         Reviewed by Mark Lam.
2463
2464         * WebFrame.cpp:
2465         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2466
2467 2018-03-08  Tim Horton  <timothy_horton@apple.com>
2468
2469         Stop linking ApplicationServices directly
2470         https://bugs.webkit.org/show_bug.cgi?id=182867
2471         <rdar://problem/38252142>
2472
2473         Reviewed by Alex Christensen.
2474
2475         The frameworks that we use that live inside ApplicationServices
2476         have mostly moved out, so import them directly.
2477
2478         * FullscreenVideoController.cpp:
2479
2480 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2481
2482         Fix std::make_unique / new[] using system malloc
2483         https://bugs.webkit.org/show_bug.cgi?id=182975
2484
2485         Reviewed by JF Bastien.
2486
2487         Use Vector instead.
2488
2489         * MarshallingHelpers.cpp:
2490         (MarshallingHelpers::safeArrayToStringArray):
2491         (MarshallingHelpers::safeArrayToIntArray):
2492         * Plugins/PluginPackageWin.cpp:
2493         (WebCore::PluginPackage::fetchInfo):
2494         * WebPreferences.cpp:
2495         (WebPreferences::copyWebKitPreferencesToCFPreferences):
2496         * WebView.cpp:
2497         (WebView::onMenuCommand):
2498
2499 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2500
2501         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2502         https://bugs.webkit.org/show_bug.cgi?id=183312
2503
2504         Reviewed by Mark Lam.
2505
2506         Remove wtf/CurrentTime.h include pragma.
2507
2508         * WebDownload.cpp:
2509         * WebDownloadCFNet.cpp:
2510         * WebDropSource.cpp:
2511
2512 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2513
2514         Remove monotonicallyIncreasingTime
2515         https://bugs.webkit.org/show_bug.cgi?id=182911
2516
2517         Reviewed by Michael Catanzaro.
2518
2519         * FullscreenVideoController.cpp:
2520         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
2521         * Plugins/PluginMessageThrottlerWin.cpp:
2522         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
2523         (WebCore::PluginMessageThrottlerWin::appendMessage):
2524         * Plugins/PluginMessageThrottlerWin.h:
2525         * WebView.cpp:
2526         (WebView::notifyAnimationStarted):
2527         * WebView.h:
2528
2529 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2530
2531         [Win][DRT] Implement setSpatialNavigationEnabled.
2532         https://bugs.webkit.org/show_bug.cgi?id=183166
2533
2534         Reviewed by Per Arne Vollan.
2535
2536         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
2537
2538         * Interfaces/IWebPreferencesPrivate.idl:
2539         * WebPreferenceKeysPrivate.h:
2540         * WebPreferences.cpp:
2541         (WebPreferences::initializeDefaultSettings):
2542         (WebPreferences::spatialNavigationEnabled):
2543         (WebPreferences::setSpatialNavigationEnabled):
2544         * WebPreferences.h:
2545         * WebView.cpp:
2546         (WebView::notifyPreferencesChanged):
2547
2548 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2549
2550         Reduce use of NetworkingContext in WebKit
2551         https://bugs.webkit.org/show_bug.cgi?id=183213
2552
2553         Reviewed by Brady Eidson.
2554
2555         * Plugins/PluginView.cpp:
2556         (WebCore::PluginView::getValueForURL):
2557
2558 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
2559
2560         Fix WebCore includes within WebKitLegacy
2561         https://bugs.webkit.org/show_bug.cgi?id=183147
2562
2563         Reviewed by Tim Horton.
2564
2565         * Plugins/PluginDatabase.cpp:
2566         * Plugins/PluginDatabaseWin.cpp:
2567         * Plugins/PluginDebug.cpp:
2568         * Plugins/PluginDebug.h:
2569         * Plugins/PluginMainThreadScheduler.cpp:
2570         * Plugins/PluginMessageThrottlerWin.cpp:
2571         * Plugins/PluginMessageThrottlerWin.h:
2572         * Plugins/PluginPackage.cpp:
2573         * Plugins/PluginPackage.h:
2574         * Plugins/PluginPackageWin.cpp:
2575         * Plugins/PluginStream.cpp:
2576         * Plugins/PluginStream.h:
2577         * Plugins/PluginView.cpp:
2578         * Plugins/PluginView.h:
2579         * Plugins/PluginViewWin.cpp:
2580         * Plugins/npapi.cpp:
2581         * WebCoreSupport/WebChromeClient.cpp:
2582         * WebCoreSupport/WebContextMenuClient.cpp:
2583         * WebCoreSupport/WebFrameLoaderClient.cpp:
2584         * WebCoreSupport/WebInspectorClient.cpp:
2585         * WebCoreSupport/WebPlatformStrategies.cpp:
2586         * WebFrame.cpp:
2587         * WebKitMessageLoop.cpp:
2588         * WebView.cpp:
2589         * storage/WebDatabaseProvider.cpp:
2590
2591 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2592
2593         Remove currentTime() / currentTimeMS()
2594         https://bugs.webkit.org/show_bug.cgi?id=183052
2595
2596         Reviewed by Mark Lam.
2597
2598         * WebCoreSupport/WebFrameLoaderClient.cpp:
2599         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2600         * WebCoreSupport/WebFrameLoaderClient.h:
2601         * WebDownload.h:
2602         * WebDownloadCFNet.cpp:
2603         (WebDownload::didStart):
2604         (WebDownload::didReceiveData):
2605         (WebDownload::didFinish):
2606
2607 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
2608
2609         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
2610         https://bugs.webkit.org/show_bug.cgi?id=182883
2611
2612         Reviewed by Per Arne Vollan.
2613
2614         * WebKitPrefix.h:
2615
2616 2018-02-16  Dean Jackson  <dino@apple.com>
2617
2618         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
2619         https://bugs.webkit.org/show_bug.cgi?id=182894
2620
2621         Reviewed by Tim Horton.
2622
2623         Rename OPENGL_ES_2 to OPENGL_ES.
2624
2625         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2626
2627 2018-02-16  Youenn Fablet  <youenn@apple.com>
2628
2629         Allow specifying which plug-ins are supported
2630         https://bugs.webkit.org/show_bug.cgi?id=182748
2631
2632         Reviewed by Chris Dumez.
2633
2634         * WebCoreSupport/WebPluginInfoProvider.cpp:
2635         (WebPluginInfoProvider::getPluginInfo):
2636         * WebCoreSupport/WebPluginInfoProvider.h:
2637
2638 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
2639
2640         WebCore headers should not be included relatively within dependent projects
2641         https://bugs.webkit.org/show_bug.cgi?id=182805
2642
2643         Reviewed by Chris Dumez.
2644
2645         * FullscreenVideoController.h:
2646
2647 2018-02-13  Commit Queue  <commit-queue@webkit.org>
2648
2649         Unreviewed, rolling out r228431.
2650         https://bugs.webkit.org/show_bug.cgi?id=182766
2651
2652         Regressed CMake build stability (Requested by dolmstead on
2653         #webkit).
2654
2655         Reverted changeset:
2656
2657         "[CMake] Make WebCore headers copies"
2658         https://bugs.webkit.org/show_bug.cgi?id=182512
2659         https://trac.webkit.org/changeset/228431
2660
2661 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
2662
2663         [CMake] Make WebCore headers copies
2664         https://bugs.webkit.org/show_bug.cgi?id=182512
2665
2666         Reviewed by Keith Miller.
2667
2668         * FullscreenVideoController.h:
2669         * Plugins/PluginDatabase.cpp:
2670         * Plugins/PluginDatabaseWin.cpp:
2671         * Plugins/PluginDebug.cpp:
2672         * Plugins/PluginMainThreadScheduler.cpp:
2673         * Plugins/PluginMessageThrottlerWin.cpp:
2674         * Plugins/PluginPackage.cpp:
2675         * Plugins/PluginPackageWin.cpp:
2676         * Plugins/PluginStream.cpp:
2677         * Plugins/PluginView.cpp:
2678         * Plugins/PluginViewWin.cpp:
2679         * Plugins/npapi.cpp:
2680         * WebKitMessageLoop.cpp:
2681         * WebKitPrefix.h:
2682         * storage/WebDatabaseProvider.cpp:
2683
2684 2018-01-13  Darin Adler  <darin@apple.com>
2685
2686         Event improvements
2687         https://bugs.webkit.org/show_bug.cgi?id=179591
2688
2689         Reviewed by Chris Dumez.
2690
2691         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
2692         * WebFrame.cpp: Ditto.
2693
2694         * WebScriptWorld.cpp:
2695         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
2696
2697         * WebView.cpp: Removed include of ScriptValue.h.
2698         (WebView::handleEditingKeyboardEvent): Updated for name change from
2699         keyEvent to underlyingPlatformEvent.
2700
2701 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2702
2703         Remove WebCore/ForwardingHeaders directory
2704         https://bugs.webkit.org/show_bug.cgi?id=182347
2705
2706         Reviewed by Keith Miller.
2707
2708         * Plugins/PluginView.cpp:
2709         * Plugins/PluginViewWin.cpp:
2710         * WebCoreSupport/WebInspectorClient.cpp:
2711         * WebCoreSupport/WebInspectorClient.h:
2712         * WebFrame.cpp:
2713         * WebJavaScriptCollector.cpp:
2714         * WebView.cpp:
2715
2716 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2717
2718         Unreviewed, another attempt to fix the Windows build after r227479.
2719
2720         * WebFrame.cpp:
2721         (WebFrame::elementWithName):
2722
2723 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2724
2725         Unreviewed, try to fix the Windows build after r227479.
2726
2727         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
2728
2729         * WebFrame.cpp:
2730         (WebFrame::elementWithName):
2731         (WebFrame::controlsInForm):
2732
2733 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
2734
2735         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
2736         https://bugs.webkit.org/show_bug.cgi?id=181859
2737         <rdar://problem/36659886>
2738
2739         Reviewed by Alex Christensen.
2740         
2741         Use local include patch.
2742
2743         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
2744         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
2745         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
2746
2747 2018-01-17  Youenn Fablet  <youenn@apple.com>
2748
2749         Put fetch Request.keepalive behind a runtime flag
2750         https://bugs.webkit.org/show_bug.cgi?id=181592
2751
2752         Reviewed by Chris Dumez.
2753
2754         * WebPreferences.cpp:
2755         (WebPreferences::fetchAPIKeepAliveEnabled):
2756         (WebPreferences::setFetchAPIKeepAliveEnabled):
2757         * WebPreferences.h:
2758         * WebView.cpp:
2759         (WebView::notifyPreferencesChanged):
2760
2761 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2762
2763         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2764         https://bugs.webkit.org/show_bug.cgi?id=181637
2765         <rdar://problem/36508471>
2766
2767         Reviewed by Tim Horton.
2768
2769         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2770
2771         * WebCoreSupport/WebEditorClient.cpp:
2772         (WebEditorClient::replacementURLForResource):
2773         * WebCoreSupport/WebEditorClient.h:
2774
2775 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2776
2777         Remove std::chrono completely
2778         https://bugs.webkit.org/show_bug.cgi?id=181186
2779
2780         Reviewed by Alex Christensen.
2781
2782         * Plugins/PluginStream.cpp:
2783         (WebCore::lastModifiedDateMS):
2784
2785 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2786
2787         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
2788         https://bugs.webkit.org/show_bug.cgi?id=181173
2789
2790         Reviewed by Alex Christensen.
2791
2792         * WebNodeHighlight.cpp:
2793         (WebNodeHighlight::update): Scale the GraphicsContext.
2794
2795 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2796
2797         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
2798         https://bugs.webkit.org/show_bug.cgi?id=181160
2799
2800         Reviewed by Myles C. Maxfield.
2801
2802         * Plugins/PluginView.cpp:
2803         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
2804
2805 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2806
2807         Enable picture-in-picture from inline element on suspend.
2808         https://bugs.webkit.org/show_bug.cgi?id=180942
2809         rdar://problem/34745234
2810
2811         Reviewed by Jer Noble.
2812
2813         Update signature of enterVideoFullscreenForVideoElement.
2814
2815         * WebCoreSupport/WebChromeClient.cpp:
2816         (WebChromeClient::enterVideoFullscreenForVideoElement):
2817         * WebCoreSupport/WebChromeClient.h:
2818
2819 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2820
2821         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
2822         https://bugs.webkit.org/show_bug.cgi?id=180926
2823
2824         Reviewed by Tim Horton.
2825
2826         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
2827         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
2828
2829         * WebCoreSupport/WebFrameLoaderClient.cpp:
2830         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
2831         (WebFrameLoaderClient::pageID const): Ditto.
2832
2833 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2834
2835         Remove unnecessary boolean result of start() functions
2836         https://bugs.webkit.org/show_bug.cgi?id=180856
2837
2838         Reviewed by Darin Adler.
2839
2840         It always returns true.
2841
2842         * WebDownloadCurl.cpp:
2843         (WebDownload::start):
2844
2845 2017-12-14  John Wilander  <wilander@apple.com>
2846
2847         Storage Access API: Implement frame-specific access in the document.cookie layer
2848         https://bugs.webkit.org/show_bug.cgi?id=180682
2849         <rdar://problem/35982257>
2850
2851         Reviewed by Alex Christensen.
2852
2853         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2854         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2855         CookiesStrategy::getRawCookies() now take optional parameters for
2856         frameID and pageID to allow frame-specific scoping of cookies.
2857
2858         This change makes the return values of FrameLoaderClient::frameID()
2859         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2860         WebCore can call those getters and get the right return values in
2861         WebKit and std:nullopt in WebKitLegacy.
2862
2863         * WebCoreSupport/WebFrameLoaderClient.cpp:
2864         (WebFrameLoaderClient::pageID const):
2865         (WebFrameLoaderClient::frameID const):
2866             Now return an optional.
2867         * WebCoreSupport/WebFrameLoaderClient.h:
2868         * WebCoreSupport/WebPlatformStrategies.cpp:
2869         (WebPlatformStrategies::cookiesForDOM):
2870         (WebPlatformStrategies::setCookiesFromDOM):
2871         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2872         (WebPlatformStrategies::getRawCookies):
2873         * WebCoreSupport/WebPlatformStrategies.h:
2874
2875 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2876
2877         [WTF] Thread::create should have Thread::tryCreate
2878         https://bugs.webkit.org/show_bug.cgi?id=180333
2879
2880         Reviewed by Darin Adler.
2881
2882         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
2883         (WKQCA::CVDisplayLink::start):
2884
2885 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2886
2887         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
2888         https://bugs.webkit.org/show_bug.cgi?id=180572
2889
2890         Reviewed by Mark Lam.
2891
2892         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
2893         Also we use Lock instead of Mutex.
2894
2895         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
2896         (WKQCA::CAD3DRenderer::swapChain):
2897         (WKQCA::CAD3DRenderer::renderAndPresent):
2898         (WKQCA::CAD3DRenderer::renderToImage):
2899         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2900         (WKQCA::CAD3DRenderer::renderInternal):
2901         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
2902         * WebKitQuartzCoreAdditions/CAView.cpp:
2903         (WKQCA::CAView::Handle::create):
2904         Return Ref<Handle> instead of RefPtr<>.
2905
2906         (WKQCA::CAView::Handle::lock):
2907         (WKQCA::CAView::Handle::view const):
2908         (WKQCA::CAView::Handle::clear):
2909         (WKQCA::views):
2910         (WKQCA::viewsNeedingUpdate):
2911         (WKQCA::CAView::releaseAllD3DResources):
2912         (WKQCA::CAView::CAView):
2913         (WKQCA::CAView::~CAView):
2914         (WKQCA::CAView::setLayer):
2915         (WKQCA::CAView::update):
2916         (WKQCA::CAView::drawToWindow):
2917         (WKQCA::CAView::drawToWindowInternal):
2918         (WKQCA::CAView::drawToImage):
2919         (WKQCA::CAView::willDraw):
2920         (WKQCA::CAView::drawIntoDC):
2921         (WKQCA::CAView::setShouldInvertColors):
2922         (WKQCA::CAView::scheduleNextDraw):
2923         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2924         (WKQCA::CAView::contextDidChange):
2925         (WKQCA::CAView::updateSoon):
2926         (WKQCA::CAView::updateViewsNow):
2927         (WKQCA::CAView::d3dDevice9):
2928         (WKQCA::CAView::Handle::mutex): Deleted.
2929         (WKQCA::globalStateMutex): Deleted.
2930         (): Deleted.
2931         * WebKitQuartzCoreAdditions/CAView.h:
2932
2933 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2934
2935         Use StaticLock instead of NeverDestroyed<Lock>
2936         https://bugs.webkit.org/show_bug.cgi?id=180507
2937
2938         Reviewed by Saam Barati.
2939
2940         * WebLocalizableStrings.cpp:
2941         (findCachedString):
2942         (cacheString):
2943         (mainBundleLocStrings): Deleted.
2944         (frameworkLocStringsMutex): Deleted.
2945
2946 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
2947
2948         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
2949         https://bugs.webkit.org/show_bug.cgi?id=180431
2950         <rdar://problem/34531264>
2951
2952         Reviewed by Simon Fraser.
2953
2954         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
2955         'override' to make sure this doesn't break in the future.
2956
2957         * WebView.cpp:
2958         (WebView::notifyAnimationStarted):
2959         (WebView::paintContents):
2960         * WebView.h:
2961
2962 2017-11-23  Darin Adler  <darin@apple.com>
2963
2964         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2965         https://bugs.webkit.org/show_bug.cgi?id=179981
2966
2967         Reviewed by Sam Weinig.
2968
2969         * WebView.cpp:
2970         (WebView::searchFor): Use |= instead of | to build FindOptions.
2971         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
2972         (WebView::findString): Create FindOptions with |=; the old code just passed a
2973         WebKit FindOptions through without converting to WebCore::FindOptions.
2974
2975 2017-11-23  Darin Adler  <darin@apple.com>
2976
2977         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2978         https://bugs.webkit.org/show_bug.cgi?id=179907
2979
2980         Reviewed by Sam Weinig.
2981
2982         * Plugins/PluginDatabaseWin.cpp:
2983         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
2984         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
2985         * WebDownloadCFNet.cpp:
2986         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
2987
2988         * WebView.cpp:
2989         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
2990         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
2991         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
2992         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
2993         the code does not cause any change in behavior.
2994
2995 2017-11-22  Ali Juma  <ajuma@chromium.org>
2996
2997         Implement VisualViewport API attributes
2998         https://bugs.webkit.org/show_bug.cgi?id=179385
2999
3000         Reviewed by Frédéric Wang.
3001
3002         Add a VisualViewportAPI preference.
3003
3004         * Interfaces/IWebPreferencesPrivate.idl:
3005         * WebPreferenceKeysPrivate.h:
3006         * WebPreferences.cpp:
3007         (WebPreferences::initializeDefaultSettings):
3008         (WebPreferences::visualViewportAPIEnabled):
3009         (WebPreferences::setVisualViewportAPIEnabled):
3010         * WebPreferences.h:
3011         * WebView.cpp:
3012         (WebView::notifyPreferencesChanged):
3013
3014 2017-11-22  Commit Queue  <commit-queue@webkit.org>
3015
3016         Unreviewed, rolling out r225093.
3017         https://bugs.webkit.org/show_bug.cgi?id=179938
3018
3019         Compilation failed on WinCairo 64-bit Release (Requested by
3020         fredw on #webkit).
3021
3022         Reverted changeset:
3023
3024         "Implement VisualViewport API attributes"
3025         https://bugs.webkit.org/show_bug.cgi?id=179385
3026         https://trac.webkit.org/changeset/225093
3027
3028 2017-11-21  Ali Juma  <ajuma@chromium.org>
3029
3030         Implement VisualViewport API attributes
3031         https://bugs.webkit.org/show_bug.cgi?id=179385
3032
3033         Reviewed by Frédéric Wang.
3034
3035         Add a VisualViewportAPI preference.
3036
3037         * Interfaces/IWebPreferencesPrivate.idl:
3038         * WebPreferenceKeysPrivate.h:
3039         * WebPreferences.cpp:
3040         (WebPreferences::initializeDefaultSettings):
3041         (WebPreferences::visualViewportAPIEnabled):
3042         (WebPreferences::setVisualViewportAPIEnabled):
3043         * WebPreferences.h:
3044         * WebView.cpp:
3045         (WebView::notifyPreferencesChanged):
3046
3047 2017-11-14  Alex Christensen  <achristensen@webkit.org>
3048
3049         Clean up old URL parser remnants
3050         https://bugs.webkit.org/show_bug.cgi?id=179573
3051
3052         Reviewed by Darin Adler.
3053
3054         * WebCoreSupport/WebContextMenuClient.cpp:
3055         (WebContextMenuClient::searchWithGoogle):
3056         Use https if we do end up searching with google.
3057
3058 2017-11-12  Darin Adler  <darin@apple.com>
3059
3060         More is<> and downcast<>, less static_cast<>
3061         https://bugs.webkit.org/show_bug.cgi?id=179600
3062
3063         Reviewed by Chris Dumez.
3064
3065         * WebView.cpp:
3066         (WebView::handleEditingKeyboardEvent): Use downcast.
3067
3068 2017-11-09  Christopher Reid  <chris.reid@sony.com>
3069
3070         Use enum classes within FileSystem
3071         https://bugs.webkit.org/show_bug.cgi?id=175172
3072
3073         Reviewed by Darin Adler.
3074
3075         * Plugins/PluginDatabase.cpp:
3076
3077 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
3078
3079         [Win] Add WebKitQuartzCoreAdditions library.
3080         https://bugs.webkit.org/show_bug.cgi?id=179331
3081
3082         Reviewed by Alex Christensen.
3083
3084         * WebKitQuartzCoreAdditions: Added.
3085         * WebKitQuartzCoreAdditions/API: Added.
3086         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
3087         (toImage):
3088         (WKCACFImageGetWidth):
3089         (WKCACFImageGetHeight):
3090         (WKCACFImageCopyFileMapping):
3091         (WKCACFImageCreateWithImage):
3092         (WKCACFImageFinalize):
3093         (WKCACFImageCopyFormattingDescription):
3094         (WKCACFImageCopyDebugDescription):
3095         (WKCACFImageGetTypeID):
3096         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
3097         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
3098         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
3099         (toView):
3100         (toImpl):
3101         (WKCACFViewCreate):
3102         (WKCACFViewSetLayer):
3103         (WKCACFViewUpdate):
3104         (WKCACFViewFlushContext):
3105         (WKCACFViewInvalidateRects):
3106         (WKCACFViewCanDraw):
3107         (WKCACFViewDraw):
3108         (WKCACFViewCopyDrawnImage):
3109         (WKCACFViewDrawIntoDC):
3110         (contextDidChangeCallback):
3111         (WKCACFViewSetContextDidChangeCallback):
3112         (WKCACFViewGetLastCommitTime):
3113         (WKCACFViewSetContextUserData):
3114         (WKCACFViewGetContext):
3115         (WKCACFViewFinalize):
3116         (WKCACFViewCopyFormattingDescription):
3117         (WKCACFViewCopyDebugDescription):
3118         (WKCACFViewGetTypeID):
3119         (WKCACFViewSetShouldInvertColors):
3120         (WKCACFViewGetD3DDevice9):
3121         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
3122         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
3123         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
3124         (WKQCA::dllInstance):
3125         (DllMain):
3126         (WKCACFShutDown):
3127         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
3128         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
3129         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
3130         (WKQCA::d3d):
3131         (WKQCA::initialPresentationParameters):
3132         (WKQCA::CAD3DRenderer::shared):
3133         (WKQCA::CAD3DRenderer::CAD3DRenderer):
3134         (WKQCA::CAD3DRenderer::swapChain):
3135         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
3136         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
3137         (WKQCA::CAD3DRenderer::initialize):
3138         (WKQCA::D3DMatrixOrthoOffCenterRH):
3139         (WKQCA::prepareDevice):
3140         (WKQCA::updateBounds):
3141         (WKQCA::CAD3DRenderer::renderAndPresent):
3142         (WKQCA::CAD3DRenderer::renderToImage):
3143         (WKQCA::CAD3DRenderer::setDeviceIsLost):
3144         (WKQCA::CAD3DRenderer::renderInternal):
3145         (WKQCA::CAD3DRenderer::postProcess):
3146         (WKQCA::CAD3DRenderer::resetD3DDevice):
3147         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
3148         (WKQCA::CAD3DRenderer::release):
3149         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
3150         (WKQCA::D3DPostProcessingContext::sceneTexture const):
3151         (WKQCA::D3DPostProcessingContext::overlayQuad const):
3152         (WKQCA::CAD3DRenderer::d3dDevice9 const):
3153         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
3154         (WKQCA::CAView::Handle::create):
3155         (WKQCA::CAView::Handle::~Handle):
3156         (WKQCA::CAView::Handle::mutex):
3157         (WKQCA::CAView::Handle::view const):
3158         (WKQCA::CAView::Handle::clear):
3159         (WKQCA::CAView::Handle::Handle):
3160         (WKQCA::globalStateMutex):
3161         (WKQCA::registerMessageWindowClass):
3162         (WKQCA::createMessageWindow):
3163         (WKQCA::CAView::releaseAllD3DResources):
3164         (WKQCA::CAView::CAView):
3165         (WKQCA::CAView::~CAView):
3166         (WKQCA::CAView::create):
3167         (WKQCA::CAView::setContextDidChangeCallback):
3168         (WKQCA::CAView::setLayer):
3169         (WKQCA::CAView::update):
3170         (WKQCA::CAView::invalidateRects):
3171         (WKQCA::CAView::drawToWindow):
3172         (WKQCA::CAView::drawToWindowInternal):
3173         (WKQCA::CAView::drawToImage):
3174         (WKQCA::CAView::willDraw):
3175         (WKQCA::CAView::didDraw):
3176         (WKQCA::CAView::drawIntoDC):
3177         (WKQCA::CAView::setShouldInvertColors):
3178         (WKQCA::CAView::scheduleNextDraw):
3179         (WKQCA::CAView::displayLinkReachedCAMediaTime):
3180         (WKQCA::CAView::contextDidChangeCallback):
3181         (WKQCA::CAView::contextDidChange):
3182         (WKQCA::CAView::updateSoon):
3183         (WKQCA::CAView::updateViewsNow):
3184         (WKQCA::CAView::d3dDevice9):
3185         * WebKitQuartzCoreAdditions/CAView.h: Added.
3186         (WKQCA::CAView::context const):
3187         (WKQCA::CAView::canDraw const):
3188         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
3189         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
3190         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
3191         (WKQCA::CVDisplayLink::CVDisplayLink):
3192         (WKQCA::CVDisplayLink::~CVDisplayLink):
3193         (WKQCA::CVDisplayLink::create):
3194         (WKQCA::CVDisplayLink::start):
3195         (WKQCA::CVDisplayLink::stop):
3196         (WKQCA::CVDisplayLink::setPaused):
3197         (WKQCA::CVDisplayLink::runIOThread):
3198         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
3199         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
3200         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
3201         * WebKitQuartzCoreAdditions/Image.cpp: Added.
3202         (WKQCA::numBytesForSize):
3203         (WKQCA::Image::create):
3204         (WKQCA::Image::Image):
3205         (WKQCA::Image::~Image):
3206         (WKQCA::bitmapInfo):
3207         (WKQCA::Image::createDIB const):
3208         (WKQCA::Image::copyFileMapping):
3209         * WebKitQuartzCoreAdditions/Image.h: Added.
3210         (WKQCA::Image::size const):
3211         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
3212         (WKQCA::getBackBufferRectAsRenderTarget):
3213         (WKQCA::getSystemMemoryCopy):
3214         (WKQCA::copyRectToBitmap):
3215         (WKQCA::getImageCopy):
3216         (WKQCA::getBackBufferRectAsImage):
3217         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
3218         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
3219         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
3220         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
3221         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
3222
3223 2017-11-06  Christopher Reid  <chris.reid@sony.com>
3224
3225         Use enum classes within FileSystem
3226         https://bugs.webkit.org/show_bug.cgi?id=175172
3227
3228         Reviewed by Myles C. Maxfield.
3229
3230         * Plugins/PluginDatabase.cpp:
3231
3232 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
3233
3234         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
3235         https://bugs.webkit.org/show_bug.cgi?id=178333
3236
3237         Reviewed by Darin Adler.
3238
3239         * WebCoreSupport/WebFrameLoaderClient.cpp:
3240         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
3241
3242 2017-11-02  Alex Christensen  <achristensen@webkit.org>
3243
3244         Use CompletionHandlers for redirects
3245         https://bugs.webkit.org/show_bug.cgi?id=179163
3246
3247         Reviewed by Tim Horton.
3248
3249         * Plugins/PluginStream.cpp:
3250         (WebCore::PluginStream::willSendRequest):
3251         * Plugins/PluginStream.h:
3252         (WebCore::PluginStreamClient::~PluginStreamClient):
3253         (WebCore::PluginStreamClient::streamDidFinishLoading):
3254         (WebCore::PluginStream::create):
3255         (WebCore::PluginStream::setLoadManually):
3256
3257 2017-11-02  Christopher Reid  <chris.reid@sony.com>
3258
3259         Add a FileSystem namespace to FileSystem.cpp
3260         https://bugs.webkit.org/show_bug.cgi?id=179063
3261
3262         Reviewed by Darin Adler.
3263
3264         * Plugins/PluginDatabase.cpp:
3265         * Plugins/PluginPackage.cpp:
3266         * Plugins/PluginStream.cpp:
3267         * Plugins/PluginStream.h:
3268         * WebApplicationCache.cpp:
3269         * WebDatabaseManager.cpp:
3270         * WebDownloadCurl.cpp:
3271         * WebPreferences.cpp:
3272         * WebView.cpp:
3273
3274 2017-10-31  Alex Christensen  <achristensen@webkit.org>
3275
3276         Fix Windows build after r224260
3277
3278         * WebView.cpp:
3279         (WebView::gesture):
3280
3281 2017-10-28  Zalan Bujtas  <zalan@apple.com>
3282
3283         [FrameView::layout cleanup] Move core layout logic to a separate class.
3284         https://bugs.webkit.org/show_bug.cgi?id=178771
3285         <rdar://problem/35166542>
3286
3287         Reviewed by Simon Fraser.
3288
3289         Move layout code out from FrameView to LayoutContext.
3290
3291         * WebFrame.cpp:
3292         (WebFrame::layout):
3293
3294 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3295
3296         Fix Windows build
3297         https://bugs.webkit.org/show_bug.cgi?id=178892
3298
3299         * AccessibleBase.cpp:
3300         (MSAARole):
3301
3302 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3303
3304         Fix Windows build
3305         https://bugs.webkit.org/show_bug.cgi?id=178892
3306
3307         * AccessibleBase.cpp:
3308         (AccessibleBase::state const):
3309         (MSAARole):
3310
3311 2017-10-25  Youenn Fablet  <youenn@apple.com>
3312
3313         Enable ServiceWorker to fetch resources
3314         https://bugs.webkit.org/show_bug.cgi?id=178673
3315
3316         Reviewed by Brady Eidson.
3317
3318         Added implementation to the new getters.
3319         They are noop in the context of WK1.
3320
3321         * WebCoreSupport/WebFrameLoaderClient.cpp:
3322         (WebFrameLoaderClient::pageID const):
3323         (WebFrameLoaderClient::frameID const):
3324         (WebFrameLoaderClient::sessionID const):
3325         * WebCoreSupport/WebFrameLoaderClient.h:
3326
3327 2017-10-20  Antoine Quint  <graouts@apple.com>
3328
3329         [Web Animations] Provide basic timeline and animation interfaces
3330         https://bugs.webkit.org/show_bug.cgi?id=178526
3331
3332         Reviewed by Dean Jackson.
3333
3334         Remove the WEB_ANIMATIONS compile-time flag.
3335
3336         * WebView.cpp:
3337         (WebView::notifyPreferencesChanged):
3338
3339 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3340
3341         [Curl] Clean up old style code in old curl files.
3342         https://bugs.webkit.org/show_bug.cgi?id=178569
3343
3344         Reviewed by Ryosuke Niwa.
3345
3346         * WebCache.cpp:
3347         (WebCache::cacheFolder):
3348         (WebCache::setCacheFolder):
3349         * WebView.cpp:
3350         (WebView::setCacheModel):
3351
3352 2017-10-19  Sam Weinig  <sam@webkit.org>
3353
3354         [Settings] Move global settings into their own file
3355         https://bugs.webkit.org/show_bug.cgi?id=178512
3356
3357         Reviewed by Darin Adler.
3358
3359         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
3360
3361         * WebView.cpp:
3362         (WebView::initWithFrame):
3363
3364 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
3365
3366         Replace some stack raw pointers with RefPtrs within WebCore/html
3367         https://bugs.webkit.org/show_bug.cgi?id=178201
3368         <rdar://problem/34841692>
3369
3370         Reviewed by Ryosuke Niwa.
3371
3372         * WebView.cpp:
3373         (WebView::handleEditingKeyboardEvent):
3374         Change the type of node as toNode() is changed to return RefPtr.
3375
3376 2017-10-16  Sam Weinig  <sam@webkit.org>
3377
3378         [Settings] Remove all custom code from Settings.h/cpp
3379         https://bugs.webkit.org/show_bug.cgi?id=178330
3380
3381         Reviewed by Simon Fraser.
3382
3383         * WebView.cpp:
3384         (WebView::notifyPreferencesChanged):
3385             
3386             Update for naming changes of FrameFlattening now that it is an enum class.
3387
3388 2017-10-11  Chris Dumez  <cdumez@apple.com>
3389
3390         Modernize Geolocation code
3391         https://bugs.webkit.org/show_bug.cgi?id=178148
3392
3393         Reviewed by Ryosuke Niwa.
3394
3395         * WebCoreSupport/WebGeolocationClient.cpp:
3396         (WebGeolocationClient::lastPosition):
3397         * WebCoreSupport/WebGeolocationClient.h:
3398         * WebGeolocationPosition.cpp:
3399         (WebGeolocationPosition::initWithTimestamp):
3400         (core):
3401         * WebGeolocationPosition.h:
3402         (WebGeolocationPosition::impl const):
3403
3404 2017-10-05  Chris Dumez  <cdumez@apple.com>
3405
3406         Drop unused parameters for CookiesStrategy::cookiesEnabled()
3407         https://bugs.webkit.org/show_bug.cgi?id=177957
3408
3409         Reviewed by Alex Christensen.
3410
3411         * WebCoreSupport/WebPlatformStrategies.cpp:
3412         (WebPlatformStrategies::cookiesEnabled):
3413         * WebCoreSupport/WebPlatformStrategies.h:
3414
3415 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3416
3417         [Curl] Reimplement CurlDownload with CurlRequest
3418         https://bugs.webkit.org/show_bug.cgi?id=177779
3419
3420         Reviewed by Alex Christensen.
3421
3422         * WebDownload.h:
3423         * WebDownloadCurl.cpp:
3424         (WebDownload::init):
3425         (WebDownload::didReceiveResponse):
3426
3427 2017-09-29  Chris Dumez  <cdumez@apple.com>
3428
3429         Split some logic out of VisitedLinkStore and make it reusable
3430         https://bugs.webkit.org/show_bug.cgi?id=177575
3431
3432         Reviewed by Alex Christensen.
3433
3434         * WebCoreSupport/WebVisitedLinkStore.cpp:
3435         (WebVisitedLinkStore::addVisitedLink):
3436         (WebVisitedLinkStore::isLinkVisited):
3437         (WebVisitedLinkStore::addVisitedLinkHash):
3438         * WebCoreSupport/WebVisitedLinkStore.h:
3439
3440 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3441
3442         Make PolicyAction an encodable enum class
3443         https://bugs.webkit.org/show_bug.cgi?id=177480
3444
3445         Reviewed by Antti Koivisto.
3446
3447         * WebCoreSupport/WebFrameLoaderClient.cpp:
3448         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3449         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3450         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3451         * WebFramePolicyListener.cpp:
3452         (WebFramePolicyListener::use):
3453         (WebFramePolicyListener::download):
3454         (WebFramePolicyListener::ignore):
3455         (WebFramePolicyListener::continueSubmit):
3456
3457 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3458
3459         [Win] fast/canvas/2d.getPath.modification.html is failing.
3460         https://bugs.webkit.org/show_bug.cgi?id=176534
3461
3462         Reviewed by Alex Christensen.
3463
3464         We need to enable Inspector additions at runtime in order to expose the getPath function.
3465
3466         * Interfaces/IWebPreferencesPrivate.idl:
3467         * WebPreferenceKeysPrivate.h:
3468         * WebPreferences.cpp:
3469         (WebPreferences::initializeDefaultSettings):
3470         (WebPreferences::setDataTransferItemsEnabled):
3471         (WebPreferences::inspectorAdditionsEnabled):
3472         (WebPreferences::setInspectorAdditionsEnabled):
3473         * WebPreferences.h:
3474         * WebView.cpp:
3475         (WebView::notifyPreferencesChanged):
3476
3477 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3478
3479         Modernize Geolocation code
3480         https://bugs.webkit.org/show_bug.cgi?id=176496
3481
3482         Reviewed by Andy Estes.
3483
3484         * WebCoreSupport/WebGeolocationClient.cpp:
3485         (WebGeolocationClient::requestPermission):
3486         * WebCoreSupport/WebGeolocationClient.h:
3487         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
3488         (WebGeolocationClient::cancelPermissionRequest): Deleted.
3489         * WebGeolocationPolicyListener.h:
3490         * WebView.cpp:
3491         (WebView::initWithFrame):
3492         (WebView::geolocationDidFailWithError):
3493
3494 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3495
3496         [Win] Enable DatatransferItems in DRT.
3497         https://bugs.webkit.org/show_bug.cgi?id=176424
3498
3499         Reviewed by Brent Fulgham.
3500
3501         * Interfaces/IWebPreferencesPrivate.idl:
3502         * WebPreferenceKeysPrivate.h:
3503         * WebPreferences.cpp:
3504         (WebPreferences::initializeDefaultSettings):
3505         (WebPreferences::QueryInterface):
3506         (WebPreferences::isSecureContextAttributeEnabled):
3507         (WebPreferences::dataTransferItemsEnabled):
3508         (WebPreferences::setDataTransferItemsEnabled):
3509         * WebPreferences.h:
3510         * WebView.cpp:
3511         (WebView::notifyPreferencesChanged):
3512
3513 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3514
3515         Unreviewed build fix #2 after r221275.
3516
3517         * WebCoreSupport/WebPlatformStrategies.cpp:
3518         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3519         to match new API.
3520         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
3521
3522 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3523
3524         Unreviewed build fix after r221275.
3525
3526         * WebCoreSupport/WebPlatformStrategies.cpp:
3527         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3528         to match new API.
3529
3530 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
3531
3532         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
3533         https://bugs.webkit.org/show_bug.cgi?id=176031
3534
3535         Reviewed by Brent Fulgham.
3536
3537         When the function in the FramePolicyFunction parameter is called, it has already been moved
3538         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
3539         function by using the stored member instead.
3540
3541         * WebCoreSupport/WebFrameLoaderClient.cpp:
3542         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3543         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3544         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3545
3546 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3547
3548         Unreviewed, try to fix the Windows build after r221064
3549
3550         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
3551
3552         * WebCoreSupport/WebEditorClient.h:
3553
3554 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3555
3556         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3557         https://bugs.webkit.org/show_bug.cgi?id=175370
3558         <rdar://problem/33799806>
3559
3560         Reviewed by Ryosuke Niwa.
3561
3562         Adjust WebEditorClient for interface changes.
3563
3564         * WebCoreSupport/WebEditorClient.h:
3565
3566 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3567
3568         Unreviewed build fix after r221017.
3569
3570         Correct copy/paste error.
3571
3572         * WebCoreSupport/WebPlatformStrategies.cpp:
3573         (WebPlatformStrategies::cookiesForDOM):
3574
3575 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3576
3577         Unreviewed build fix after r221017.
3578
3579         * WebCoreSupport/WebPlatformStrategies.cpp:
3580         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
3581         * WebCoreSupport/WebPlatformStrategies.h:
3582
3583 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3584
3585         Remove ChromeClient::scrollbarsModeDidChange
3586         https://bugs.webkit.org/show_bug.cgi?id=175805
3587
3588         Reviewed by Daniel Bates.
3589
3590         * WebCoreSupport/WebChromeClient.h:
3591
3592 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3593
3594         Remove ChromeClient::hasOpenedPopup
3595         https://bugs.webkit.org/show_bug.cgi?id=175804
3596
3597         Reviewed by Sam Weinig.
3598
3599         * WebCoreSupport/WebChromeClient.cpp:
3600         (WebChromeClient::hasOpenedPopup const): Deleted.
3601         * WebCoreSupport/WebChromeClient.h:
3602
3603 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
3604
3605         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
3606         https://bugs.webkit.org/show_bug.cgi?id=173536
3607
3608         Reviewed by Brent Fulgham.
3609
3610         If the tree state is dirty, accessible objects are deleted while iterating over children
3611         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
3612         style is updated before this method is called.
3613
3614         * AccessibleBase.cpp:
3615         (AccessibleBase::getAccessibilityObjectForChild):
3616
3617 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3618
3619         [PAL] Move SessionID into PAL
3620         https://bugs.webkit.org/show_bug.cgi?id=174192
3621
3622         Reviewed by Antti Koivisto.
3623
3624         * WebCoreSupport/WebFrameLoaderClient.cpp:
3625         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3626         * WebCoreSupport/WebFrameLoaderClient.h:
3627         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3628         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
3629         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3630         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3631         (WebFrameNetworkingContext::storageSession const):
3632         * WebCoreSupport/WebPlatformStrategies.cpp:
3633         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3634         * WebCoreSupport/WebPlatformStrategies.h:
3635
3636 2017-08-15  Youenn Fablet  <youenn@apple.com>
3637
3638         [Cache API] Adding generic support for CacheStorage and Cache methods
3639         https://bugs.webkit.org/show_bug.cgi?id=175455
3640
3641         Reviewed by Chris Dumez.
3642
3643         * WebView.cpp:
3644         (WebView::initWithFrame):
3645
3646 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3647
3648         Composition underline color is always black
3649         https://bugs.webkit.org/show_bug.cgi?id=174675
3650
3651         Reviewed by Ryosuke Niwa.
3652
3653         * WebView.cpp:
3654         (WebView::setCompositionForTesting): Use text color for
3655         composition underline.
3656
3657 2017-08-09  Daniel Bates  <dabates@apple.com>
3658
3659         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3660         https://bugs.webkit.org/show_bug.cgi?id=175247
3661         <rdar://problem/33679804>
3662
3663         Reviewed by Brady Eidson.
3664
3665         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3666         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3667         clients that need to make use of this information at this time. If such a needs comes up
3668         then we can expose API/SPI similar to what we do for WebKit.
3669
3670         * WebCoreSupport/WebFrameLoaderClient.cpp:
3671         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3672         * WebCoreSupport/WebFrameLoaderClient.h:
3673
3674 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3675
3676         Async image decoding for large images should be disabled after the first time a tile is painted
3677         https://bugs.webkit.org/show_bug.cgi?id=174451
3678         <rdar://problem/31246421>
3679
3680         Reviewed by Simon Fraser.
3681
3682         * FullscreenVideoController.cpp:
3683         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3684         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3685         (AcceleratedCompositingContext::paintContents):
3686         * WebCoreSupport/AcceleratedCompositingContext.h:
3687
3688 2017-07-23  Darin Adler  <darin@apple.com>
3689
3690         More NeverDestroyed and related cleanup
3691         https://bugs.webkit.org/show_bug.cgi?id=174745
3692
3693         Reviewed by Alex Christensen.
3694
3695         * Plugins/PluginDatabase.cpp:
3696         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
3697         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
3698         * Plugins/PluginMainThreadScheduler.cpp:
3699         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
3700         * Plugins/PluginMainThreadScheduler.h: Ditto.
3701         * WebCoreSupport/WebPlatformStrategies.cpp:
3702         (WebPlatformStrategies::initialize): Ditto.
3703         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
3704         * WebHistory.cpp:
3705         (sharedHistoryStorage): Ditto.
3706         * WebLocalizableStrings.cpp:
3707         (mainBundleLocStrings): Ditto.
3708         (frameworkLocStringsMutex): Ditto.
3709         (frameworkLocStrings): Ditto.
3710         * WebView.cpp:
3711         (WebView::standardUserAgentWithApplicationName): Ditto.
3712         Also changed to keep one global string with the prefix of the user agent string
3713         instead of keeping two globals with pieces of that prefix.
3714
3715 2017-07-24  Chris Dumez  <cdumez@apple.com>
3716
3717         Make ExceptionCode a proper enumeration
3718         https://bugs.webkit.org/show_bug.cgi?id=174771
3719
3720         Reviewed by Sam Weinig.
3721
3722         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
3723
3724         * DOMCoreClasses.cpp:
3725         (DOMDocument::createEvent):
3726         * WebView.cpp:
3727         (WebView::prepareCandidateWindow):
3728
3729 2017-07-21  Andreas Kling  <akling@apple.com>
3730
3731         Use more references in event dispatch code
3732         https://bugs.webkit.org/show_bug.cgi?id=174681
3733
3734         Reviewed by Geoffrey Garen.
3735
3736         * DOMEventsClasses.cpp:
3737         (WebEventListener::handleEvent):
3738         * DOMEventsClasses.h:
3739         * Plugins/PluginView.cpp:
3740         (WebCore::PluginView::handleEvent):
3741         * Plugins/PluginView.h:
3742
3743 2017-07-20  Brady Eidson  <beidson@apple.com>
3744
3745         Remove WebIconDatabase from WebKitLegacy/win.
3746         https://bugs.webkit.org/show_bug.cgi?id=174608
3747
3748         Reviewed by Alex Christensen.
3749
3750         It is unused.
3751         
3752         * ForEachCoClass.h:
3753
3754         * Interfaces/IWebIconDatabase.idl: Removed.
3755
3756         * Interfaces/WebKit.idl:
3757
3758         * WebCoreStatistics.cpp:
3759         (WebCoreStatistics::iconPageURLMappingCount):
3760         (WebCoreStatistics::iconRetainedPageURLCount):
3761         (WebCoreStatistics::iconRecordCount):
3762         (WebCoreStatistics::iconsWithDataCount):
3763
3764         * WebIconDatabase.cpp: Removed.
3765         * WebIconDatabase.h: Removed.
3766         * WebKitClassFactory.cpp:
3767
3768         * WebKitDLL.cpp:
3769         (shutDownWebKit):
3770
3771         * WebKitLogging.h:
3772
3773         * WebView.cpp:
3774         (WebView::close):
3775         (WebView::notifyDidAddIcon):
3776         (WebView::registerForIconNotification):
3777         (WebView::dispatchDidReceiveIconFromWebFrame):
3778         (WebView::onNotify):
3779
3780 2017-07-18  Matt Lewis  <jlewis3@apple.com>
3781
3782         Unreviewed, rolling out r219610.
3783
3784         This caused an api failure on all platforms for the test
3785         SnapshotImageLargeAsyncDecoding
3786
3787         Reverted changeset:
3788
3789         "Async image decoding for large images should be disabled
3790         after the first time a tile is painted"
3791         https://bugs.webkit.org/show_bug.cgi?id=174451
3792         http://trac.webkit.org/changeset/219610
3793
3794 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
3795
3796         Async image decoding for large images should be disabled after the first time a tile is painted
3797         https://bugs.webkit.org/show_bug.cgi?id=174451
3798
3799         Reviewed by Simon Fraser.
3800
3801         * FullscreenVideoController.cpp:
3802         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3803         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3804         (AcceleratedCompositingContext::paintContents):
3805         * WebCoreSupport/AcceleratedCompositingContext.h:
3806
3807 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3808
3809         [Curl] Don't start downloading more than once for same request
3810         https://bugs.webkit.org/show_bug.cgi?id=174172
3811
3812         Reviewed by Alex Christensen.
3813
3814         * WebDownloadCurl.cpp:
3815         (WebDownload::init):
3816
3817 2017-07-12  Daniel Bates  <dabates@apple.com>
3818
3819         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3820         https://bugs.webkit.org/show_bug.cgi?id=174427
3821
3822         Rubber-stamped by Brady Eidson.
3823
3824         * Plugins/PluginView.cpp:
3825         (WebCore::PluginView::start):
3826         (WebCore::PluginView::getURLNotify):
3827         (WebCore::PluginView::getURL):
3828         (WebCore::PluginView::handlePost):
3829
3830 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3831
3832         [WTF] Move SoftLinking.h into WTF
3833         https://bugs.webkit.org/show_bug.cgi?id=174000
3834
3835         Reviewed by Alex Christensen.
3836
3837         * WebKitClassFactory.cpp:
3838         * WebView.cpp:
3839
3840 2017-07-05  Brady Eidson  <beidson@apple.com>
3841
3842         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3843         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3844
3845         Reviewed by Alex Christensen.
3846
3847         Adopt to the new constructor for FrameLoadRequest.
3848
3849         * Plugins/PluginView.cpp:
3850         (WebCore::PluginView::start):
3851         (WebCore::PluginView::getURLNotify):
3852         (WebCore::PluginView::getURL):
3853         (WebCore::PluginView::handlePost):
3854
3855 2017-07-03  Brady Eidson  <beidson@apple.com>
3856
3857         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3858         https://bugs.webkit.org/show_bug.cgi?id=174073
3859
3860         Reviewed by Andy Estes.
3861
3862         * WebCoreSupport/WebFrameLoaderClient.cpp:
3863         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3864         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3865         * WebCoreSupport/WebFrameLoaderClient.h:
3866
3867 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3868
3869         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3870         https://bugs.webkit.org/show_bug.cgi?id=174004
3871
3872         Reviewed by Simon Fraser.
3873
3874         * WebCoreSupport/WebFrameLoaderClient.cpp:
3875         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3876
3877 2017-06-30  Daniel Bates  <dabates@apple.com>
3878
3879         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3880         https://bugs.webkit.org/show_bug.cgi?id=165160
3881         <rdar://problem/29451999>
3882
3883         Reviewed by Brady Eidson.
3884
3885         Pass the document that is requesting the load to the loader.
3886
3887         * Plugins/PluginView.cpp:
3888         (WebCore::PluginView::start):
3889         (WebCore::PluginView::getURLNotify):
3890         (WebCore::PluginView::getURL):
3891         (WebCore::PluginView::handlePost):
3892
3893 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3894
3895         Refactor drag start codepaths to plumb a DragItem to client layers
3896         https://bugs.webkit.org/show_bug.cgi?id=173832
3897         Work towards <rdar://problem/32236827>
3898
3899         Reviewed by Ryosuke Niwa and Tim Horton.
3900
3901         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
3902
3903         * WebCoreSupport/WebDragClient.cpp:
3904         (WebDragClient::startDrag):
3905         * WebCoreSupport/WebDragClient.h:
3906
3907 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3908
3909         Remove excessive headers from JavaScriptCore
3910         https://bugs.webkit.org/show_bug.cgi?id=173812
3911
3912         Reviewed by Darin Adler.
3913
3914         * Plugins/PluginPackage.cpp:
3915
3916 2017-06-22  Daniel Bates  <dabates@apple.com>
3917
3918         Make FrameLoadRequest a move-only type
3919         https://bugs.webkit.org/show_bug.cgi?id=173682
3920
3921         Reviewed by Alex Christensen and Darin Adler.
3922
3923         A FrameLoadRequest groups together the information to perform a load into a single object
3924         that is more manageable to pass around than its constituent parts. Code that receives a
3925         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3926         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3927         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3928
3929         * Plugins/PluginView.cpp:
3930         (WebCore::PluginView::start):
3931         (WebCore::PluginView::performRequest):
3932         (WebCore::PluginView::load):
3933         (WebCore::PluginView::getURLNotify):
3934         (WebCore::PluginView::getURL):
3935         (WebCore::PluginView::handlePost):
3936         * Plugins/PluginView.h:
3937         (WebCore::PluginRequest::PluginRequest):
3938
3939 2017-06-22  Daniel Bates  <dabates@apple.com>
3940
3941         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
3942         https://bugs.webkit.org/show_bug.cgi?id=173683
3943
3944         Reviewed by Alex Christensen.
3945
3946         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
3947         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
3948         by including PluginView.h. The latter does not make use of the functionality
3949         provided by FrameLoadRequest.h.
3950
3951         * Plugins/PluginViewWin.cpp:
3952         * WebCoreSupport/WebContextMenuClient.cpp:
3953
3954 2017-06-21  Daniel Bates  <dabates@apple.com>
3955
3956         Cleanup FrameLoadRequest
3957         https://bugs.webkit.org/show_bug.cgi?id=173564
3958         <rdar://problem/32903570>
3959
3960         Reviewed by Brent Fulgham.
3961
3962         * Plugins/PluginView.cpp:
3963         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
3964         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
3965         we do not have one. Use C++11 brace initialization syntax.
3966         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
3967         name as we do not have one. Use C++11 brace initialization syntax.
3968         (WebCore::PluginView::getURL): Ditto.
3969         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
3970         function to closer to where it is actually used. Explicitly pass the null-string for the target
3971         frame name as we do not have one. Use C++11 brace initialization syntax.
3972
3973 2017-06-20  Daniel Bates  <dabates@apple.com>
3974
3975         Have FrameLoadRequest takes a Frame& instead of a Frame*
3976         https://bugs.webkit.org/show_bug.cgi?id=173614
3977         <rdar://problem/32884890>
3978
3979         Reviewed by Brent Fulgham.
3980
3981         * Plugins/PluginView.cpp:
3982         (WebCore::PluginView::performRequest):
3983         * WebFrame.cpp:
3984         (WebFrame::loadRequest):
3985
3986 2017-06-19  Chris Dumez  <cdumez@apple.com>
3987
3988         Use WTF::Function instead of std::function in more places in WebCore/
3989         https://bugs.webkit.org/show_bug.cgi?id=173535
3990
3991         Reviewed by Antti Koivisto.
3992
3993         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3994
3995         * WebCoreSupport/WebFrameLoaderClient.cpp:
3996         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3997         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3998         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3999         (WebFrameLoaderClient::dispatchWillSubmitForm):
4000         (WebFrameLoaderClient::setUpPolicyListener):
4001         (WebFrameLoaderClient::receivedPolicyDecision):
4002         * WebCoreSupport/WebFrameLoaderClient.h:
4003
4004 2017-05-14 Frederic Wang  <fwang@igalia.com>
4005
4006         Add heuristic to avoid flattening "fullscreen" iframes
4007         https://bugs.webkit.org/show_bug.cgi?id=171914
4008
4009         Reviewed by Simon Fraser.
4010
4011         This commit ajusts the window port to internally use the new preference type for frame flattening.
4012         However, the "partial frame flattening" value is not exposed yet.
4013
4014         * WebView.cpp:
4015         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
4016
4017 2017-06-17  Chris Dumez  <cdumez@apple.com>
4018
4019         Use WTF::Function instead of std::function in WebKit2/
4020         https://bugs.webkit.org/show_bug.cgi?id=173504
4021
4022         Reviewed by Darin Adler.
4023
4024         Use WTF::Function instead of std::function in WebKit2/ to avoid
4025         unnecessary copying.
4026
4027         * Plugins/PluginStream.cpp:
4028         (WebCore::PluginStream::willSendRequest):
4029         * Plugins/PluginStream.h:
4030
4031 2017-06-16  Sam Weinig  <sam@webkit.org>
4032
4033         [WebIDL] Remove custom bindings for HTMLDocument
4034         https://bugs.webkit.org/show_bug.cgi?id=173444
4035
4036         Reviewed by Darin Adler.
4037
4038         * DOMHTMLClasses.cpp:
4039         (DOMHTMLDocument::write):
4040         (DOMHTMLDocument::writeln):
4041         Update for new signature of write/writeln.
4042
4043 2017-06-16  Daniel Bates  <dabates@apple.com>
4044
4045         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
4046         instead of URL { ParsedURLString, ... }
4047         https://bugs.webkit.org/show_bug.cgi?id=173495
4048         <rdar://problem/32827445>
4049
4050         Reviewed by Alex Christensen.
4051
4052         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
4053         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
4054         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
4055         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
4056         parse an arbitrary string that looks like a URL.
4057
4058         Also modernize the code using C++14 idioms.
4059
4060         * WebCoreSupport/WebContextMenuClient.cpp:
4061         (WebContextMenuClient::searchWithGoogle):
4062
4063 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
4064
4065         [Win] WebKit shouldn't include the forwarding header of WebKit itself
4066         https://bugs.webkit.org/show_bug.cgi?id=173352
4067
4068         Reviewed by Alex Christensen.
4069
4070         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
4071
4072 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
4073
4074         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
4075         https://bugs.webkit.org/show_bug.cgi?id=173318
4076
4077         Reviewed by Darin Adler.
4078
4079         The logical frame size is currently calculated by scaling the frame size in pixels,
4080         and rounding the coordinates to the nearest integers. The computed logical frame
4081         size will in some cases be smaller than the scaled frame size in pixels, since it is
4082         represented as an IntSize. In these cases, the bottom line will not be painted.
4083         Instead of calculating the logical frame size by rounding the scaled frame in
4084         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
4085
4086         * WebCoreSupport/WebFrameLoaderClient.cpp:
4087         (WebFrameLoaderClient::transitionToCommittedForNewPage):
4088
4089 2017-06-13  Daniel Bates  <dabates@apple.com>
4090
4091         Implement W3C Secure Contexts Draft Specification
4092         https://bugs.webkit.org/show_bug.cgi?id=158121
4093         <rdar://problem/26012994>
4094
4095         Reviewed by Brent Fulgham.
4096
4097         Part 4
4098
4099         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
4100
4101         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
4102         * WebPreferenceKeysPrivate.h:
4103         * WebPreferences.cpp:
4104         (WebPreferences::initializeDefaultSettings):
4105         (WebPreferences::QueryInterface):
4106         (WebPreferences::setIsSecureContextAttributeEnabled):
4107         (WebPreferences::isSecureContextAttributeEnabled):
4108         * WebPreferences.h:
4109         * WebView.cpp:
4110         (WebView::notifyPreferencesChanged):
4111
4112 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
4113
4114         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
4115         https://bugs.webkit.org/show_bug.cgi?id=173318
4116
4117         Reviewed by Alex Christensen.
4118
4119         The logical frame size is currently calculated by scaling the frame size in pixels,
4120         and rounding the coordinates to the nearest integers. The computed logical frame
4121         size will in some cases be smaller than the scaled frame size in pixels, since it is
4122         represented as an IntSize. In these cases, the bottom line will not be painted.
4123         Instead of calculating the logical frame size by rounding the scaled frame in
4124         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
4125  
4126         * WebView.cpp:
4127         (WebView::sizeChanged):
4128
4129 2017-06-13  Sam Weinig  <sam@webkit.org>
4130
4131         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
4132         https://bugs.webkit.org/show_bug.cgi?id=80733
4133
4134         Reviewed by Chris Dumez.
4135
4136         * WebFrame.cpp:
4137         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
4138
4139 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
4140
4141         Remove WebCore::unloadModule and related data types
4142         https://bugs.webkit.org/show_bug.cgi?id=173231
4143
4144         Reviewed by Darin Adler.
4145
4146         * Plugins/PlatformModule.h: Added.
4147         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
4148         * Plugins/PluginPackage.cpp:
4149         (WebCore::PluginPackage::freeLibr